labofsahil/github-event-dataset-2012 huggingface dataset:
using a range here instead of the low-level while loop would be more readable
from http://docs.oracle.com/javase/tutorial/collections/interfaces/collection.html
"Note that Iterator.remove is the only safe way to modify a collection during iteration; the behavior is unspecified if the underlying collection is modified in any other way while the iteration is in progress."
So i guess I should have used an iterator here.
This should be localizable, so it's better to move it elsewhere (like maybe putting it in the partial and moving it via JavaScript, for example)
The wording of this message could be improved – *duplicate parameter names 'foo' are not allowed* doesn't read well. Perhaps something as simple as the following would be suitable?

    throw SyntaxError "multiple parameters named '#{pname}'"
original.txt
This call should be where the setTotalMemoryLimit call lives.
No, I just haven't tested it at all yet. 

I created the new defconfig based on doing a diff of the host mode kernel from that site vs a stock ideos kernel. Most are built as options, but not all, and I would be concerned that something could cause problems or battery drains.
What if he isn't? Have you thought of that test case?
Looks to be fixed in 2.6, 2.7 and 3.x, can you verify this?
I started with Diablo but I now have updates to all of this for Essex, I'll push them up later today,
This commit is no longer necessary, as we aren't using the NilModel anymore.
No problem, I'm really getting into Chocolatey, but it's not the right fit for every project. I'm sure maartenba is cool maintaining it for a while.
MPL 2.0, please.
Nog eentje in backend/profiles/engine/model.php, lijn 256: datatype van $status staat nog niet in phpdoc
On 3/7/2012 11:28 AM, jacob-carlborg wrote:
> I see. I've taken interest in this because I wanted to do this myself, but every time I was about to do this I tried to fix dynamic libraries at the same time. I can't see any reason why this wouldn't work.
>
>

I'm not attempting to fix dynamic library support with this (as you can see with 
the BUG comments), but it is a necessary step in that direction.
I just popped it into the folder on my desktop version of GitHub and then synced it.


On Mar 7, 2012, at 3:30 PM, ellemenno wrote:

> i can download and see it, but as to why there is no preview on github, i
> don't know... other images seem to preview fine:
> https://github.com/earthworksbuilder/earthworksbuilder.github.com/blob/master/images/earthworksLogo.png
> 
> 
> maybe you can show me how you committed it next time we meet..
> -p
> 
> 
> On Wed, Mar 7, 2012 at 12:19 AM, michelle-aubrecht <
> reply@reply.github.com
>> wrote:
> 
>> I can't view this photo. I guess there is another way
>> 
>> ---
>> Reply to this email directly or view it on GitHub:
>> 
>> https://github.com/earthworksbuilder/neh.prototype/commit/5b8a6f832fdf00cd3c93a83c23630c4e483f9682#commitcomment-1051796
>> 
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/earthworksbuilder/neh.prototype/commit/5b8a6f832fdf00cd3c93a83c23630c4e483f9682#commitcomment-1055444
Hi, bit new to github so not sure if this is the right place to post?

I just downloaded 2.3.4 and saw the thumbnail support added. I had already added this in my local repo using the existing 'featured image' functionality.
Just wondering what the advantages/disadvantages with the different approaches are?

I attempted to make a diff of the changes.
http://dl.dropbox.com/u/3209649/thumbnail-support.diff

A better version of the get_the_thumbnail function than I have there:

	public function get_the_thumbnail() {
		$before = '<div class="publication_thumbnail">';
		$after = '</div>';
		
		$thumb = $this->thumbnail;
		
		if($thumb){
			$image 	= wp_get_attachment_image_src($thumb, 'full'	, true);

			if($thumb) $image 	= @vt_resize( $thumb, '', 125, 125, 'false' );
		
			return $before . '<img src="'.$image['url'].'" alt="'.get_the_title($thumb).'" width="'.$image['width'].'" height="'.$image['height'].'" />' . $after;
		}
		else return '';
	}
This apparently fixes #5.
If we remove packet filter, will the droid wall work? can we still block apps to get to internet?
This is important to users.
Thanks.
no, use gingerbread tree, i have update to 1.1.6 not 1.1.4 again, and will try to write file manager 2.0.0 for ics
Эту функцию лучше положить глобально в модуль, чтобы её экземпляр не создавался каждый раз при вызове функции
this check should not be removed! Expected behaviour:  If no value or factor is given, then warning message shown. if this condition removed that doesn't happen.
The fact that you have to do it by hand in every command. I think I'll keep `self.cmd_opts`, but change `self.cmd_opts.title` in every command. Or initialize the optgroup as  `OptionGroup(parser, '%s Options' % name.capitalize())`. I don't feel like importing optparse in every command module.
be sure to spell correct "accross"
As far as the options object, I still think this can be simplified.  How about an optional arg for the type hint and wrapper, with helper methods for toArray/String?
```
Y.Color.toRGB('#f00', 'hex');
Y.Color.toRGBArray('#f00', 'hex');
```

versus:

```
Y.Color.toRGB({
    value:'#f00',
    type: 'hex',
    css: true
});

Y.Color.toRGB({
    value:'#f00',
    type: 'hex'
});

```
This change is completely unrelated to the rest of this pull request.  Please only include changes/commits in pull requests that are related to each other.

There's not a problem with this change, as it's left over from a previous way were were doing things.  It just needs to be in it's own pull request.
not necessarily when using fine grained events, the clusterView will be updated by published fine grained events

some of these conditions could probably be written as you suggests, but I think it's more robust to assert all in the same way and don't make to much assumptions about the how the clusterView gets updated
Should this really have a random name?
should we clear AND rethrow?
When should the non-recursive be used and when not?
Yes, I'm optimizing for the common case (which is probably still quite uncommon in reality). In rare cases it might indeed happen that two threads want to get a previously uninitialized path of a Ref that has already been stopped at the same time. One is going to make it, the other one will have wasted a temp path. Actually there is no tempPath creation in a real spinning scenario here. In order to waste 10 temp path creations 10 threads need to get to this branch at the same time.
Due to the rather limited "wasting" in quite rare scenarios I took the shortcut route.

Fully protecting this branch would require another state token or renaming of the "Registering" state, which I wanted to avoid for code readability reasons as well.
Well, I did do that before and everything worked, for it to not work with a real component (jetty), and fixing it based on the problems found.
I can look into that a bit more. The ticket was specific to camel jetty though: https://www.assembla.com/spaces/akka/tickets/1214
I'll investigate if I can test it without jetty and the http deps.
I think these would benefit from something like

    def ape[T](msg: String)(thunk: => T): T

which is used like

    ape("Error while decoding incoming Akka PDU") (codec.decodePdu(pdu, provider))
This will be terrible, both for performance and memory usage.
okay, I'll make it `private[akka]` then
hmmm, nevermind
this change will break the sandboxing
Made some groups non-captured so we get a simpler parameters array.
Sorry, I didn't see that tmp was defined right above...
Ahh, I see. Makes sense.
moving from helpers would help here too
This only changed when I thought that api wouldn't be available, but now it would work in both forms.  I guess we can have both cases then
Planboxed
This file is the one that's gonna have the doxy, right?  :)
Yeah, I don't know what I was thinking there.
As we talked about, lets do some tighter coupling between the JobFIlter and the parser/getter for jobflows from boto or a file. There should be no reason non-pre-processed jobflows get into the system if someone forgot to use the filter.

JobFlowPreprocessor?
Fixed. Thanks ;)
I don't want to force the usage of Eclipse but rather any IDE with Maven support, so I'm ditching this as well.
I have also changed this line, that's why you need to update your code before creating pull request
Please wrie `if (!mMapImage)` instead.
where does NUM_DIRS get a value from?
Can you remove the merge artefacts?
Parameter names should never include `and` in Cocoa.
I don't think making a mutable array public is a good idea. Since you're only accepting `CAAnimations`, why not just add a method that adds a single `CAAnimation` object onto the private array of animations?
This integer is not printed as an unsigned value. It should be cast to `long` instead.
Its name is incredibly long, and it's reused in many places.
Yes - the default is a bit redundant (and annoying!)
Let's prepend `Abstract` to the class name like `AbstractServerUnsafe`.
This looks right. Could also do

    itemsize /= sizeof(npy_ucs4)

which some compilers will optimize to >>2. It has the advantage of not using a hardwired value.
жесть :)
этот код я когда-то писал. поставьте там // FIXME, чтоли, например
и страничку в вики
Indeed - make it a one-liner:

    charset ActiveRecord::Base.configurations[environment]
:+1: I guess the vars are pretty cryptic haha, I think we should rename h2, to something more obvious.
You could go even further and use Rails.root:

```ruby
Rails.root.join("log", "#{Rails.env}.log")
```
Tbh, I'd rather the thing that calls initialize do the freezing. Freezing strings does mutate them. People may not expect that we froze their strings.

--
Aaron Patterson
http://tenderlovemaking.com/
I'm on an iPhone so I apologize for top posting.

On Sep 14, 2012, at 8:14 PM, thedarkone <notifications@github.com> wrote:

> In activerecord/lib/active_record/result.rb:
> 
> > @@ -11,7 +11,7 @@ class Result
> >      attr_reader :columns, :rows, :column_types
> >  
> >      def initialize(columns, rows, column_types = {})
> > -      @columns      = columns
> > +      @columns      = columns.map{|c| c.freeze}
> We can do @columns = columns.each(&:freeze) or @columns = columns.each {|c| c.freeze} to avoid allocating that extra array.
> 
> \
> Reply to this email directly or view it on GitHub.
>
@rafaelfranca right, thanks. Updated.
misunderestimated level of truthiness
Done. I updated the immediate neighbors as well, so the new syntax wouldn't look too out-of-place.
Some identity beyond "List[Any]" for the macro args is an excellent idea.
You are correct.  I have now removed it.
I've only used javadoc to send to our external partners.
It looks like you anticipate that step can be negative. Should you then just check that the Range is not null?
Yes, it makes sense.
PR #1638 introduces kbins which uses a 2-digit integer to indicate whether the order of the bins or order of items in the bins matters. From the docstring:

```

    The ``ordered`` flag is a 2 digit integer indicating whether the order of
    the bins and the order of the items in the bins matters. Given::

        A = [[0], [1, 2]]
        B = [[1, 2], [0]]
        C = [[2, 1], [0]]
        D = [[0], [2, 1]]

    the following values for ``ordered`` have the shown meanings::

        00 means A == B == C == D
        01 means A == B
        10 means A == D
        11 means A == A
    
    When the order of something matters, it is returned as a tuple, otherwise a
    list. A tuple is used in case the items of ``l`` are not hashable.
```

@mrocklin , #1638 is ready for final review and I included the kbins (not kbin) there. I don't want to make a separate PR since I've already edited iterables in that PR and kbins is going into iterables.
Oh I guess this definition is also standard. So this can stay if you like.
I suggested a similar change, but @asmeurer suggested using a helper function to factor out _pprint_Pow by separating the base and exponent parts and then implementing the refactored code through _pprint_Pow. 
Please see [1] and [2].

[1] https://groups.google.com/forum/?hl=en&fromgroups#!searchin/sympy/Fixing$20pprint$20for$20Pow/sympy/eID1Tisciq8/YXyS5iRmedsJ
[2] https://github.com/ashfall/sympy/compare/Fix_pprint_for_Pow
Yeah... The way to get a pure node in the AST with no logic performed is `Basic.__new__(Add, 1, 2, 0)`. `evaluate=False` doesn't quite give you this.

The equivalent in MatExprs is `simplify=False`. We could change the exampe to MatAdd and MatMul, yes. I hesitate to do this because setting up a MatAdd requires much more code which I assume general users of rules won't know (rules examples should not depend on knowledge of `MatrixExprs`). 

The example as it is is incomplete but, I think, comprehensible. A complete matrix solution would be, I think, less clear. 

The third alternative is to use Basic. Good ol' clean, Basic.

    >>> rm_zeros = rm_id(lambda x: x==0)
    >>> rm_zeros(Basic(1, 0, 2, 3, 0, 4))
    Basic(1, 2, 3, 4)
This is already tested on L28. You could define a dummy class in this test with an _eval_trace method to test the doit call.
Do you still need this line?
This may not be necessary, I think Kiro handled this error in Abstract's event storage.
I think this syntax should be deprecated and then removed.
Basically, I grok neither that nor the corresponding tests. I'm also not sure what the equivalent N-Triples output should be.
Shouldn't this move to the function prolog?
OK, good to know :-) Maybe there is an 10K enterprise add-on to enable longer FK names.........
First of, the default link should be one string or you should use append_sid(). Either way, you'll need to run reapply_sid() on the $redirect link afterwards.
Should be $username instead of 'user'.
Im not sure about this one aswell? a simple login removed the "soft deleted" status? Does this also happen, if the admin soft-deletes them?
How about just:
"Some requirements must be met before phpBB 3.0.x can be installed."
Much more concise and to the point.
Maybe I'm missing something here, but why are you using label elements here? There are no inputs.
Line break for readability.
You answered the first question, kind of (I have no idea what fatal error you are referring to), but what about the other ones pertaining to semantics of this?
Instead of injecting the container, all of these parameters (including `$user`) should be injected directly.
Perhaps we should have a master "tunables" file for all of these delays and jitters?
why set this here if it is changed on line 112?
Poți reordona importurile te rog, ca să fie în ordinea python standard lib; django.*; wouso.*; local stuff (gen from forms..) ? Mulțumesc!
Are we already using them? Also please consult http://gcc.gnu.org/gcc-4.3/cxx0x_status.html
gcc 4.3 doesn't support lambdas.
I still recommend to wait with c++11 migration.
It is not empty anymore since I have a default value in `config.json`. but I do agree that `prefix` in its current form is not semantically correct. In my mind, `prefix` means a prefix path, not a prefix word. We can attempt to change that as well but it will have BC implications.
Old habits are hard to change, let's use mojito namespace instead of YUI namespace if that's more convenient.

The main purpose of the cache is to share compiled views across multiple Y instances (mojit instances). I wasn't sure if Y.mojito.* was shared across all Y instances, I'm still not sure!

What the best way to share data across Y instances under mojito namespace then? something equivalent to Y.Env === YUI.Env
Minor style point -- if you leave off the "else:" after an 'if' block ends with a return (as above) or exit (as below), it reduces the indent level and (in my opinion) makes the "code main line" easier to follow -- the END of a needlessly indented 'else' block can come anywhere without changing the behavior -- it makes me needlessly think "are there 'if' cases above that might have fallen through to here?" and spin my wheels answering "no, that's not possible".
fix indentation....
why a new function ?
Should input validation not happen further up in the code (in line two of this function)?
It could be more descriptive, (maybe " A string representing the snippet to be validated, in xml syntax") but it's better brief than absent.
I think SSL is not related to campfire notifications. Also it should be somehow configurable with default not ssl.
What is all this new code for?
Every line from 407 to here needs a space between the last closing double quote and the it's right side, closing paren - thanks :)
This would be more readable if you manipulated the properties of a single element before each assertion rather than creating multiple elements against which to test. Also, you are lacking coverage in the case where elements other than the direct parent are `display: none`.
Why this changed behaviour?
I don't see any generated document for functions in dt.sql, dt_preproc.sql, and dt_utility.sql.  Is it intentional?
Look for src/ports/postgres/modules/stats/hypothesis_tests.sql_in for the GPDB keyword issue.

```
m4_ifdef(<!__HAS_ORDERED_AGGREGATES__!>,<!
CREATE
m4_ifdef(<!__GREENPLUM__!>,<!ORDERED!>)
AGGREGATE MADLIB_SCHEMA.ks_test(
```

Make sure install-check doesn't run it if ORDERED aggregate is not supported.
I tested with mingw gcc 4.6.2 and 4.7.1 which gave the warnings.  I'd originally tried to disable the warnings for only mingw lower in configure.py (e.g. next hunk) via cflags but by that time cflags has already been written to build.ninja.

It's easy to add a mingw-specific `cflags += ['-Wno-missing-field-initializers']` earlier in configure.py if that's best. I'll update patch if Evan thinks it's needed
I love it, but I still think you could do it in a follow-up and let this land.
happy is a boolean field, so you probably want to filter on it rather than query on it.
We don't want this either.
One nit, use a list here instead, i.e.:

```rb
system "make", "install", "PREFIX=#{prefix}", ...
```

Singular command lines are subject to shell expansion and can thus break if any of the interpolated values contain spaces; using the form `system cmd, *args` ensures that `cmd` is exec'd directly.
Thoughts on making this a non-hidden file? I don't feel strongly about it, but somewhat prefer keeping it visible to help folks obtain and keep their bearings.
awesomely done :)
Er, that technically was supposed to be before the pulp-manage-db step, but won't hurt to tell them to stop the server before even installing the plugin.
i will change it in a new commit, thx
By running ant.
Yeah, I'm loath to change that logic right now. I think we should have a separate bug/story about making the color picker more "roundtrip", so it does a better job of preserving the user's format (whitespace, percentage vs. non-percentage, etc.). I don't think we can easily absorb that in this story, since it essentially involves parsing the user's format and figuring out how to minimally modify it to match the new color values.
Can we actually dispatch rollout and rollover for a native menu? It doesn't seem like we should expose those in the API. I can't think of a common use case for clients needing to know when a menu item is rolled over.
Already done last night. So you can merge now. Thanks.
Whoops. This was me. The comment should read extensions before project.
I think ultimately we want two separate performance suites that can each be run separately from the debug menu. Since the performance open tests
right now are tied to brackets-scenario I thought I keep this code turned off for now. I can add a todo here about our thoughts for the future on this
And we should probably do an unquoted version of that test also.
These numberless ids seem fragile now that tests are mixed into the same window.  Maybe we should use something like "menu-unittest3-after" just to be safe?
Hmmm...

```
def before_pause
  @before_pause = block if block_given?
  @before_pause
end
```

Whatcha think?
dimagi.utils.modules.to_function will do this for you
The problem is that our `RegistrationForm` extends `auth_forms.UserCreationForm`. And that the later is using relation database internally.
I'm on both sides regarding exiting - on one hand, it seems like if I run the server, it should run the server, even if it can't update all the files.  But also, I don't tend to watch the window that's running `jekyll`, and I'd like to know about errors as soon as they happen.  But that also presupposes `--server` as well.
Can we make a ticket to do keyframes mixins in LESS
double spaces before `  rga(`
Just a suggestion: my preference for style in blocks like these is to either separate commented variables entirely with whitespace between them and others, or to place comments a few tabs over to the right on the same line as the code they describe.
`defined?(controller)` will (or at least should if it conforms to Ruby conventions) return a boolean, so I'm not sure why we're checking for `.nil?` here.  Generally methods ending in '?' will return `!!value` instead of `value` to ensure that only TrueClass or FalseClass are returned, neither of which are ever nil.  If you want to check whether `defined(controller)` is false, then you should use the boolean not operator `!` instead of `.nil?`.  If there's some other reason to use it I'd be very interested.
We should really be more precise here - we should test that the redirect is to the iMedidata login URL.  ie. something like:

````ruby
it 'redirects to iMedidata for login' do
  login_url = 'fake_cas_login_url' #maybe this needs to be in genuine URL format
  CASClient::Frameworks::Rails::Filter.configure(cas_base_url: login_url)
  get :index
  response.should redirect_to(login_url)
end
```
Note the use of the Ruby 1.9 hash format, as per the style guide, since the keys in this hash are symbols.  We ought to conform to that when it's easy to do so.
Change this copy right.
[Douwe's eerste note, als test]. 
De regels rondom absolute/relatieve imports zijn veranderd tussen Py3k en Py2 -- vandaar deze veranderingen.
clientgit?
Yes, I agree. I would have used Django's [pluralize](https://docs.djangoproject.com/en/1.4/ref/templates/builtins/#pluralize), which is similar to what I'm doing here, but jinja does not seem to have that, and I did not want to start with gettext now. But it's better to do it sooner than later.
How about [ allow-rfc2136={yes|no} ] 

If yes, then log failed updates anyway. If no, disable rfc2136 completely.

BTW and IMO: dynamic-update functionality should *not* be named dyndns because people will easily confuse that with DynDNS.org-kind of updating, which it isn't ;)
I assume this fixed the weird background on the icon?
Updated in 3114d81
guess there was a Composer update within the past 5 days that changed this behavior. fixed.
Here it would ideal to use something like: http://forums.bukkit.org/threads/playercommandpreprocess-event-getting-the-plugin.113247/
In the future, when background services will be available we need to use that, otherwise the onclick callback will never be called if the dialer application is closed / or if it works that's because we're keeping a reference to it somewhere in the platform and this seems memory leak prone to me.
change to 'Other parts of Astropy that need to assume some cosmology will use ...'
@iguananaut - I commented on the ``string`` -> ``format`` here: https://github.com/astropy/astropy/pull/471#discussion_r2336050 - the code has been changed, just not the docs.
就算是boot，这个方法我也倾向于直接放在index里面，还是那个理由，好读，毕竟这种boot方法很难有地方重用的。
filename:join might be appropriate here
this method is defined off of the class BigML,  so I think it is not accessible
- Before the bitcoin GUI is initialized, in GUI code: yes, from the main thread you can use the QMessageBox::critical static function
- Before Qt and translation services are initialized: no

In this place here you can't.
@stof i don't really agree, i would rather add a null and keep the tag in there.
why changing the visibility ? You have getter for them, and child classes are not meant to replace them either
i think you could modify emesene.py directly e.g. if os == darwin then append that stuff to the path

also: can it be written as a relative path? i don't know if we get some real benefit since i don't know if you can rename the .app, but if that's the case that could actually be better
I don't think these file names should have dashes in them. It should probably be _loomio_process_flow instead.
Theres some slight issues w/ this. Some old search indexes may still be using the other casing. So they'll basically going to go missing until they are reindexed again. Maybe nobody cares.
Doesn't "x is dependent" mean that x depends on something else, as in "John is dependent on nicotine".

"x is a dependency of y" means that y depends on x. It's slightly awkward, but you could say, "nicotine is a dependency of John's".
OK. In time i'll redo all postgres methods to use only psql command.
No, because modules is now a list (as returned by the aptly named `module_list`) so 2-argument form `pop` is not supported.  Perhaps it actually should but well...
As a matter of style, I think a switch statement would be better here.
I will document this further but the idea is something like this:

var calendar; // Top level VCALENDAR from caldav in gaia this is streamed and handled one at a time.
var recurExpand = ICAL.RecurExpansion.fromComponent(calendar)l

if (recurExpand) {
  // three month in the future or 90 for daily cases
  result = recurExpand.next(new Date(2012, 1, 30), 90);
  // push each recurrence over
} else {
  //push single over
}
You're right. I'll narrow this test to only allow `HEAD` to be unfound.
Because this patterns seems to come up in a bunch of places, what do you think about adding (maybe even in the public API):

```c
GIT_INLINE(void) git__init_structure(void *structure, size_t len, int version)
{
    memset(structure, 0, len);
    *((int *)structure) = version;
}
#define GIT_INIT_STRUCTURE(S,V) git__init_structure(S, sizeof(*S), V)
```

to be used as:

```c
git_diff_options opts = GIT_DIFF_OPTIONS_INIT;

/* some code */
/* whoops, I need to reinitialize */

GIT_INIT_STRUCTURE(&opts, GIT_DIFF_OPTIONS_VERSION);

/* now I'm cleared */
```

It just seems like this pattern of reinitialization occurs across all of the versioned structures and writing the same little function many times might be avoidable.
IE can get finicky w/ this stuff. Just want to verify tests still pass (in IE) with this change?
I have no idea. I'll change it.
ordering dependency again
нужно?
the wrapping should probably be shorter
Sf standard would be to use null !== when testing $authorizationHeader
the NullSeedProvider is about the dependency of the Prng class, not about replacing the prng itself in the dpes injected in your unit test.
Please use the official gradient syntax too (and the prefixed versions for other browsers too)
smae for the resources here as there is a loop
In regard to my previous comment - this line is never reached. I suppose the if on line 179 has to be placed before the return on line 178
what do you mean? how else should it work?
You should use a strict comparison
you should use ``defined('PHP_WINDOWS_VERSION_BUILD')`` like in other places. ``stripos(PHP_OS, 'win')`` causes some issues a while ago for a weird OS as it was matched too IIRC
Ok, I think I also got a bit confused with the reserved sub-delimiting chars ",;=". IMO it doesn't matter if these chars get encoded or not in terms of URI equivalence. See http://tools.ietf.org/html/rfc3986#section-6.2.2
Using them for delimiting path parameters is only a suggestion in the URI specification for URI producing applications. So they have no real predefined meaning and are therefore treated the same as other sub-delimiters, like "+".

So your example represents the same resource: "/path;k=v" ==  "/path%3Bk%3Dv". For example you can access such a file "path;k=v" in Apache with both URI requests.

All in all, we could encode all chars (except "/") and will still produce the same uri. That means we could also encode "A-Z" etc because after normalization it's still the same. But it's not recommended that

> URI producers percent-encode octets that do not require percent-encoding

I would consider these sub-delimiters as such chars that don't need encoding because it will enhance readability. But after all it's our choice.
sorry, this is the aftermath of merging and pulling. I removed it
You could change the "order by" SQL line to ascending order by removing "desc."
Then you wouldn't need this backwards loop.
编译后“参考文献”这一章没有了？
set copy constructor as private ?
The name "isMatch" is a bit misleading here, since it has nothing to do with the other overload.
Ha yeah. To force cdb to not georef the coordinates. We only want local
table to have geom.
On Dec 10, 2012 6:14 AM, "Robin Kraft" <notifications@github.com> wrote:

> In src/clj/gulo/cdb.clj:
>
> > @@ -146,7 +145,8 @@
> >          occ-source "/mnt/hgfs/Data/vertnet/gulo/hfs/occ/"
> >          tax-source "/mnt/hgfs/Data/vertnet/gulo/hfs/tax/"
> >          loc-source "/mnt/hgfs/Data/vertnet/gulo/hfs/loc/"
> > -        tax-loc-source "/mnt/hgfs/Data/vertnet/gulo/hfs/taxloc/"]
> > +        tax-loc-source "/mnt/hgfs/Data/vertnet/gulo/hfs/taxloc/"
> > +        occ-columns ["tax-loc-id" "scientificname" "occurrenceid" "laty" "lony" "prec" "year" "month" "season"]]
>
> What are laty and lony?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/MapofLife/gbifer/pull/5/files#r2365431>.
>
>
zaehlt die user, die INSGESAMT einer liga zugewiesen sind
This should be in supacharge.core not testing.
I think we would like this variable declaration to be first in the function
Maybe I missed something here /admin/structure/types/manage/ding-page/comment/display
although the view modes isn't the same ones as the view modes for /admin/structure/types/manage/ding-event/display/
I don't know much about it, so I don't know if we could get the comment view modes that we would want.
see how many times you're doing the same exact thing here?
Use `window.location.hash` to get the hash ;)
Copyright header is missing.
I also question the change, the first call to await would have already timed out to reach the while loop - if there is no positive value from getCallFinished then the CBH was not called so we shouldn't need another time check as the purpose of this loop is only to increase the time out to compensate for time interacting with the end user.
Perhaps create a map here instead of four variables to track the values?
Don't assign inside an assignment like this. Don't build HTML strings from HTML.
I think it is save to just add originalBlob: originalBlob to the object literal above. If its undefined, you'll just get a property with the value undefined and your logic will be the same below since you don't use hasOwnProperty() or in or anything.
Thank you for finding the typo
You don't want to do a an array. That's slow. build a string directly instead.
quotechew +1
I asked to the homescreen guys, as UX said we should use the same style, and they told me that I needed to use those request.js and request.css files. The main concerns about using confirm were that it doesn't have a title and body params and it is not easy to implement the visuals on them (some icons inside). I would suggest use whatever can be reused in all the apps. @vingtetun what do you think?
I just added the test in that way because of #4529 issue appeared :S I don't think is a templating issue but the code for adding the Import button adding the HTML each time instead hiding/showing it. It was done in that way to be reused in FTE, for the record.

I'll try to find a more elegant way to check it :)
Add a name to your anonymous function. This is helpful when debugging/profiling/.....
Here's what I don't understand.  By limiting the index to 3 words like this, it looks to me as if you could be discarding suffixes with higher frequencies.  

Shouldn't you collect all the suffixes, then sort by frequency and then prune to just 3 of them?
Funny, we were discussing this same thing this morning. It's great to know about window.confirm

I just implemented that crappy version of the confirm message to test the new 'Delete all' feature, but I'll be happy to get rid of it when 1758 lands.
Uppercase S for String.Format.
Maybe error should suggest using a .deployment file?
during long running operations (#95)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

How would that class work?

Sent from my Windows Phone
From: David Ebbo
Sent: 4/29/2012 5:03 AM
To: David Fowler
Subject: Re: [kudu] Write progress when there's 5 seconds of inactivity
during long running operations (#95)
>
>  namespace Kudu.Core.Infrastructure
>  {
> -    public class ProgressWriter : IDisposable
> +    internal class ProgressWriter : IDisposable

My initial feeling is that this seems unnecessarily over abstracted
with ProgressWriter/ConsoleWriter/IWriter. Do we really gain much over
it just being a ConsoleWriterWithProgress class?

---
Reply to this email directly or view it on GitHub:
https://github.com/projectkudu/kudu/pull/95/files#r748893
I always forget that `around` exists. This is a good use case.
This doesn't really tell you at all why the JSON is invalid. I realized the sample JSONMakefile I gave you had a typo, and it would have been a lot easier to track down if you had included the error message from the actual exception. I'd print this little message, than also the message from the exception
Is this supposed to be referring to the grid instance variable? In which case it needs to be @get('grid') - Ember semantics!
This class only really needs:
```java
boolean add(ChatChannel);
boolean remove(ChatChannel);
List<ChatChannel> getChannels();
```
Is it too much of an issue? Can it stay like this?
This block of code in a nutshell:

- Open the jar file that this bootjob is running from.
- For each file in the jar, match the name against the regex pattern to find `equipment.item` files.
- Read each `equipment.item` file directly from the jar file, and store it in the `GsonEquipmentDatabase`
It's been many many many years since I touched this stuff, but isn't raising to the 1/2 the same as multiplying by 2?  Also, this line is a little dense, and could maybe use a short comment since it may not be clear from the docstring what your returning.
This is addressed in d1e03cce52897bd283dd946c93aec3aef7ba1650.
CS issue: public properties should be defined before protected ones
Same as before, why make these builders public?
less parentheses here
Yupp it's the main article headline in article/app/views/article.scala.html
Which is why I didn't want to mess around changing that
doesn't selenium wait for the page to load before continuing?
With my patches attached you still see a crash?  And any chances of you running out of system memory? (or maybe even ulimit set for memory)
shouldn't `browserWindow2` be used here?
> I don't like the lazed and promised naming here, are there examples in other places where this naming is used?

`promised` is inspired by bunch on node's promise based libraries like `promised-fs` etc..  I personally like naming, but open to alternatives.

```js
promised(Array)
promised(sum)
```

Kind of reads naturally to me.
Can you just remove those two modifications (base64encore/base64decode)? it goes beyond the scope of this pull request.
I don't see value in ensuring that our patches are going to collide.
I do understand reason why do this now, but after a month from know reading this file will confuse me. Could you please add a comment explaining why and were it's used. Mentioning that it's used by private-browsing now and in a future we plan to transition entirely to namespaces instead ? Maybe also mention Bug 704357
I see it, its escaped in `dialog.get()` at the beginning of the request.
If I understand this correctly, this happens on an email by email basis?

If a user has two emails from the same domain that just got upgraded from secondary->primary, only the email that a user selected will have its cert updated?

Does this happen for silent assertions as well?
och. seriously?  I glanced at that function last night thinking the enumeration was going to bum IE out, but the MS docs said it was ok.  Didn't even think indexOf would be a problem.  Thanks for finding that!
Not sure this file is really necessary.  It looks like the methods are for the most part pass throughs to associated PerformanceTestStatsModel methods and are called by corresponding methods in `datazilla/webapp/apps/datazilla/stats/objectstore_view.py`.  Django views.py methods are controller methods and should be able to call model methods directly and implement controller logic.  

If there are cases where the controller logic needs to be used outside of the web service by a manage command that could be a justification for creating libraries of controllers but this doesn't seem to be the case for some of these methods. 

I think  `datazilla/webapp/apps/datazilla/stats/objectstore_view.py` can implement these methods directly.
I think it would be clearer to move this into an "else" clause on the first try/except block, rather than the conditional here.
Everything can use this._buffer.length with clear requiring a temporary variable to store the old length.
demo for ha (please discard)

```python code```
@hhamon can you check the file encoding or something? You should not rewrite the whole file :p
I create a new hash to filter out unsupported parameters.
I understand, and this is the line I wanted to ask you about. The event never gets fire, even after setting the ring meta. I wanted to ask you if there was another step I'm missing here
Yep, that makes much more sense. 9b6a640 makes this change.
We'll need access to `reset` inside of `Affix.pin` and `Affix.unpin` but it's not unique to each instance, so a var up here is fine.
Maybe extend th PhpRendererStrategy, then?
Forgive me my ignorance, but why not simply use Zend\Db's insert() method to perform this query?
We need to keep the object key functionality as well; removing it is a BC break.
use instead `$name !== 0`
Got it.  sounds like we could skip the xdebug calls just by checking for the property then?

However, I'm not a big fan of the approach, sneaking around the inheritance model of php - it simplifies the end-class but at the expense of giving the end-class no ability to control the final situation, and the end-developer the ability to trace using regular knowledge of php. vs using a method rather than a property:

public function requiredConfig() {
  return array_merge(parent::requiredConfig(), array("someValue", "anotherValue");
  // but have the option of doing more.
}

(that said, it would be nice if PHP offered the dynamic property / metaclass support of our preferred languages, to avoid having to make this choice. :) )
Configurator ? wha is this class ?
What you don't think I should talk about "throw up"? ;)
Change order of operations depending on whether add/remove.
I think "estimatedSize" is better indeed...

"estimatedGainForLeftSafeLiteral"  is good too.
Why is this needed? Just curious.
Ok, jQuery was a bad example, but let say any other JS lib.

I just find it weird that the best practice is having to modify vendor libs.

But keep it as is, and I'll investigate this myself :)
Ah ok, I must be confused about the behavior of ConfigurationService -- could you clarify how it behaves? I was thinking that it:

* Provides a constrained view of the properties to a plugin and omits the prefix

Is it rather the case that it:

* Provides a complete view of all properties with prefixes already resolved and present

If it's the second option, I'll definitely put the prefix back in here. Great catch--
@vesak "Insert into tapahtuma" uupuu
@anti t-funkkari?
Make 2011-2012
Good catch. I don't think we caught this one up during the initial review.
Let's discuss this, we need to get terminology right so we don't confuse others.
Empty line between python API imports and local package imports?
See nit above about how this looks weird without the newline on two-line first lines of docstrings.
https://github.com/retornam/mcom-tests/blob/71b427f5bb89dd82a6344737e777564071c2c8c2/tests/test_redirect.py shows a newline at line 116. Please I run this through a PEP8 checker
Should be at same level as `dict` and `reverse`
What are the reasons you need a flash callback, and a HTML5 callback?

Can we fix this in popcorn/players to not have this flaw?

This one doesn't have to be fixed to get an R+, though, I just want to know if we can make it easier down the road for others.
should this really be appended to the body?
Must use the proper way to use inheritable template files. Here this searches for the 'feed-atom.php' file in the current theme directory, so 1) it will break once you change themes… 2) it doesn't have anything to do with themes anyway unless one wants to customize the feed's markup.
Could very well be. The contents of the rails script in that directory
looked identical to the old 0.4 file so I just changed the reference so the
service starts. no idea yet if it's starting CORRECTLY.

On Thu, Mar 15, 2012 at 10:53 AM, Ohad Levy <
reply@reply.github.com
> wrote:

> > @@ -23,7 +23,7 @@ FOREMAN_USE_PASSENGER=${FOREMAN_USE_PASSENGER:-0}
> >
> >  start() {
> >      echo -n $"Starting $prog: "
> > -    daemon --user ${FOREMAN_USER} /usr/bin/ruby
> ${FOREMAN_HOME}/script/server -p ${FOREMAN_PORT} -e ${FOREMAN_ENV} -d >
> /dev/null
> > +    daemon --user ${FOREMAN_USER} /usr/bin/ruby
> ${FOREMAN_HOME}/script/rails -p ${FOREMAN_PORT} -e ${FOREMAN_ENV} -d >
> /dev/null
>
> isnt it
> rails server ? (or rails s?)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/theforeman/foreman/pull/31/files#r563595
>



-- 
During times of universal deceit, telling the truth becomes a revolutionary
act.
George Orwell
You're swallowing the exception
"e" is an exception. Per definition. :)
I guess I use `rand(2) == 0` here but either is fine.
What if somebody supplies a value for both `upload` and `reset`?

You should do some validation here to ensure the options don't include both of these and alert the user that only one is allowed at a time.
各 describe の before で save するなら、ここを new でなく create にしてしまえばいいんじゃないかな。
あと、save! か create! にしないと保存に失敗したとき気付かなくてハマりそう。
ここだけ FactoryGirl を使ってないのはなぜ?
roughly equivalent to `$(window).load( function() { ... });`
These values (`index` and `element`) are not used, so this line could read `$('tr.cardItem').each ->`.
In other words, can I drop it without losing coverage on anything important?
How is this schema change related to the rest of this pull request?
Please wait for the logo. We can't assume the login button will be present in other scenarios where this page is loaded.
This is missing a bit about `/:name`.
Changed the message to: `The specified comment id is not associated to the specified content id`
We do need the callback if we want to do some stuff after the tenant has been created. I did remove the `else` out of here though. Also documented the callback.
I moved this. The change probably seems more complex than intended, as the method relies on scoped variables. So I refactored the logging a bit.
I think you want 'Git' (the generic name of the tool) rather than '<code>git</code>' (the name of the executable) here?
Should probably use a more meaningful string e.g. Read about 'Big Ben' on Wikipedia
I'm not sure what you mean here, but unit tests should override the core code, not the other way around. What's the purpose of `CodeIgniter::instance()` if we're going to use `get_instance()` here?
Locally I want to see every single possible error, warning, notice, etc.
This one seems not necessary. Remove it and it's all good to go.
Требуется заменить n случайных ячеек на случайные отличные от начальных значения.
Давайте вместе подумаем что можно сделать для улучшения ситуации...

Я вижу 2 возможных улучшения:
1) 
    do {	
         replaceSymbol = [self randomSymbol];
     } while ([self.dna[randNumber] isEqualTo:replaceSymbol]);

можно привести к конечному числу итерций если создать массив с допустимыми значениями, изъять из него текущее и только затем взять случайное число.
Но в данном контексте где в массиве 4 элемента, создание копии массива, потом поиск по нему и удаление этого элемента, а потом всё тот же random ... на первый взгляд не кажеться более оптимальным учитывая число циклов при текущей реализации.

кстати элемент с индексом (index + 1 + arc4random()%(kMaxDNAItems - 1))%kMaxDNAItems может хранить тот же символ и в итоге мы заменим "А" на "А" ;)


2) А вот перебор случайных позиций для изменения действительно при высоких значения процента мутации может обернуться в очень долгий, если не бесконечный цикл. Сдесь дейсвительно есть над чем подумать.
а сколько циклов будет занимать эта проверка на уникальность, если LENGTH_OF_DNA будет 10000? (вместо линейных 10000)
Да, эту ошибку заметил уже после дедлайна. Так получилось из-за того, что сначала реализовывал замену символа, а потом замену по индексу, необходимо было делать наоборот. Ошибка налицо.
Yes, please add appropriate comments in config/environments/*.rb Default PDF_SUPPORT value should stay set to "false".
type: Installation
I'm also pretty wary about this change in subscription behavior. I think I would much rather resolve #94 (which is what I assume this is addressing) with some changes to how subscriptions return their disposables.
Yeah, I think there are a few that listen for particular things. In this case an image. I wonder if cases here it's more of a listener than a command that we can list that, perhaps in notes? This one is probably explanatory enough within the description.
@payten Updated and ferris.xml imports again.
OK, replaced rm with os.remove. But still cannot think of a way to get rid of mkfifo :(
Have look at the :counter_cache option here: http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html
Actually I'm thinking this is fine for now. The only use case would be saving and reading events with mappings but without epochs.
use method = 'dSPM'
this is not a temp variable this is the final result. Please name it accordingly.
Didn't realize that was there.  I'll take a look  at that.
language: "IP addresses are often used to determine" should be "often use IP addresses to determine..."
It's your decision. I just have mentioned this because deprecated needed the second argument.
BTW we will need it as soon as possible in the master version of play, for making the public release of play plugin for eclipse.
moved these into `lib/git_reflow/commands` as referenced in the gli docs here:  https://github.com/davetron5000/gli/blob/gli-2/test/apps/todo/bin/todo#L31

looked like an elegant solution
Remove one colon and put this after this line (including the empty line):

    
    .. code-block:: bash
Add a semicolon (`;`) at the end of these lines (110 and 107)
嘿嘿，行不更名~
thanks.  i've removed the extra require statement.
This causes a few module variables to be promoted to globals in the browser version. We need to make sure that we maintain this module scope.
Ah, okay.... I don't know why an unless is clearer than an if?

`if accessible_attributes.any?`

vs

`unless accessible_attributes.empty?`

Isn't the first way the more truthy way and therefore easier to read?

"If I have any accessible attributes"

vs

"Unless I do not have accessible attributes"

First makes way more sense to me.. and more sense than "If I do not have no accessible attributes"
forgot enqueue() in MongoDB mailbox
Пробелы внутри вокруг `{}`: `({ tr ("Name") })`.
И потом не передавать аргумент в конструктор, если нужно.
Ya que estás, faltó cambiar "Salary por "Salario" o "Sueldo"
I think there is something wrong. The session key is based on the name of the form, which is not known here since this is not form-dependant, so it will default to "captcha", but if your form is named another way it won't work. Am I wrong ?
this can be simplified:  `(some #{category} [:repos :packages])`
Gotcha, +1 for mention it
I'm not sure about using CamelCase for these. When reading this test case there usage looks much like regular functions so I'm tending to the usual lower-case function names.
I like the idea of having users provide their own formatter. I was also thinking about the locator and formatter, and agree that we would need a more tightly coupled kind of object.