labofsahil/github-event-dataset-2012 huggingface dataset:
The reason for this was, to align it with google maps, so that if you switch the map, the zoom visually stays the same. Does this work like that on your phone (at that time it seemed to be perhaps resolution dependend).
BTW, if you change it here, you should change it in the version 0.2.4 class as well.
Ready for integration. Have another look now @mmarkus
secureReadln() returns a byte[]


On Mon, Dec 10, 2012 at 10:48 AM, Galder Zamarreño <notifications@github.com
> wrote:

> In
> cli/cli-client/src/main/java/org/infinispan/cli/commands/client/Connect.java:
>
> > @@ -45,7 +45,11 @@ public void execute(Context context, ProcessedCommand commandLine) {
> >        try {
> >           String connectionString = commandLine.getArguments().get(0).getValue();
> >           Connection connection = ConnectionFactory.getConnection(connectionString);
> > -         connection.connect(context);
> > +         String password = null;
> > +         if (connection.needsCredentials()) {
> > +            password = new String(context.getOutputAdapter().secureReadln("Password: "));
>
> Is an explicit copy of the String required here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/infinispan/infinispan/pull/1515/files#r2361870>.
>
>
use Log.specificLogMessageMethod for looking everything beyond INFO
There's no github project for that file.
That file was recovered by mclay (dunno where) and placed in his project "minify"
Weird indentation throughout this method.
*(This was done)*
Probably the closest thing would be the docstring for plot.
For me, this is not the preferred way of running the tests (in the same way the Makefile is not the preferred way of building the source).
I don't have a problem with adding the "test" makefile target, but I think I would prefer this line to be ```python tests.py```.
Should <code>current_versions</code> be cast as a string in the page object?
Why are two switch_to_frames necessary here out of curiosity?
I'll use "façon d'indenter" instead of the first "espacement".
This is not really clear in french.
Coding style convention.
I'm sometimes curious about your writing (big letter start, small letter start, ...)
You know, I finally figure out how something works and then you go and change it ...
@bp323: Do we have to do an additional POST? Can't the back-end just update the last modified date if anything changes in the entire pooled content structure?
maybe move this inside a `group :development`
Ok here's my stab https://github.com/silverstripe/sapphire/pull/510 and https://github.com/silverstripe/silverstripe-cms/pull/144
Is there a reason why this is not written in the short form?

`this.tabs({collapsible: true, active: false});`
зачем этот файл нужен?
Can this contain a link to `officials.models.Committee` as well?
> Sorry, how do you mean? GitHub also uses VERIFY_NONE?

For web hooks, they have a setting if it should verify SSL. It's false by default and can only be changed over the API.
Are you sure ``$ret`` has the correct type as ``array|object<Symfony\Com...outing\RouteCollection>`` is not a sub-type of ``object<Symfony\Component\Routing\RouteCollection>``?
Are you sure the method ``setMethod`` can be called on ``$client`` (of type "object<Zend\Http\Client>|null")?
...was man ev. ändern sollte, nicht?
недопутимый урл. Нельзя показывать где находится файл, к нему вообще может и должен быть запрещен доступ для веб-сервера. У вас есть только 1 входной параметр, index.php

Во-вторых, параметры логин, пароль, емейл передавать в POST запросе.
I don't think this are particularly necessary, but not a big deal.
maybe we can add a warning that the warning has already been added to the list of annotations?
```
uniq = []
warnings.each do |warning|
  if uniq.include? warning
    # WARN!!!! log? comment in annotation file? something!
  else 
   uniq << warning
end
```

There's gotta be moar rubier way to do this, but I am out of brainpower
Probably better would be to define choices map between ints and some useful strings.
But my question is still: is it necessary?
Combine those into [one](http://api.jquery.com/multiple-selector/).
Have you tried to use `dehydrate_<filedname>` approach? Could be cleaner than this.
Put this on the line before. Please keep the same JavaScript code style as we are using elsewhere.
I think we could simplify here by using the error method, removing the ! part (because error will add it) and removing exit, since error should also handle that.
Can we get this as a patch instead of an inreplace?

If the code here changes in a later release it'll break the patch - which is good, because it prods whoever's updating the formula that it may no longer be necessary.

(I see that the libpng fix is in the upstream source, but didn't make it into this release. I guess the comment can be updated to reflect that it will not be necessary in a future version.)
I think you can get this with

```
git diff-tree -r --no-commit-id --name-only $commit
```

without the cost of invoking the git porcelain.
Better to do it, or else it would be not safe ;)
Was machen wir mit Exceptions im Android kontext? Loggen?
prefix with `\` as you're in namespace `DoctrineModule\Authentication\Adapter`
Alignment
{%- macro select(mk, field) %}
  {% set value_labels = field.properties.value_labels or
                        field.value_labels or None%}
  {% set value_label = (value_labels[field.value]
     if value_labels else field.value) %}
  {{ value_label }}
{% endmacro -%}
I believe that this change will work for JoinWalkers that extend AbstractEntityJoinWalker (e.g., CriteriaJoinWalker).

Switching the order also affects the CollectionJoinWalker implementations (used by BasicCollectionPersister and OneToManyPersister) and  I'm guessing this switch won't be correct in this context.  I would need to see some tests to be convinced otherwise. 

Please take a look at how JoinWalker.orderBy() is used by BasicCollectionJoinWalker and OneToManyJoinWalker and see if you can come up with some tests.

Thanks,
Gail
According to the PSR-2 coding standards, I would keep the "public" visibility : https://github.com/pmjones/fig-standards/blob/psr-1-style-guide/proposed/PSR-2-advanced.md
I'm not sure this sentence is necessary, unless we actually plan to explain the subtle differences that exist at some point in the article.
Wow, sorry I lost track of this.

This is new docs specifically for non-django (i.e., non-playdoh) localization. I'll update some of the surrounding copy with clear links to playdoh docs for `extract` and `merge` commands
In that case proxy should be char*, not const char*.
Oh duh - and you can overload based on return type. Ok, I get it now. Never mind :)
For consistency, we should have types NamedLikeThis not like_this_t
I don't see a advantage of this compared to the simpler 
if not h.shape == x.shape: raise ValueError
2 spaces after def (1 too many)
bah, ty sonny
Import only modules, not directly their content.
Ok.  I'll see what I need to do to consolidate all of it to CoreLib.
@ErshKUS  тебе знакомо слово рефакторинг? :)
You're right, I'll fix that.
This FIXME is related to my confusion about beta.  Once we resolve that (probably you are correct and I'm mistaken), we can remove this FIXME line.
Looks like a tab here...
I think your forgot to remove this opam.ml
Gave same error (on line 17) with sodoer permissions.
Typographically, you might consider an em-dash, "—". That’s `&mdash;` or the equivalent in Unicode. On a Mac, it pops out with option+shift+hyphen. Some Markdown plugins convert `--` to an em-dash, though I do not know whether this system supports it.
Je mettrais un titre plus engageant en complement qui évoque le résumé
@mikepb no, the point here is to add the Git commit hash _if_ it's available. If there's a problem reading it, then we should just not add it, and carry on. If we passed the error to the callback, we'd cause the entire read of package.json to fail, which isn't what we want here.
You are using very complex tenses here. How about "Before we make the application hybrid".
`"false"` as a string again
self.choices is a list (https://github.com/xni/vaurien/blob/ed681988643dc797df252281638c4c3da85b41ac/vaurien/proxy.py#L99), and ```DefaultProxy``` returns (handler, name) tuple.
you could just carry on with 

```
} else if (assertion) {
...
```
and thus not needing the `return`
for consistency it will be better to move this code to webinos/test
Yes: this function can be called on UI snippets that have no identity or password fields.
removed on my last commit
Hello in footer?! It should be in header I think.
I feel it is a little weird to call this function 'ensure' without that.
wait a tick - why do we need genson helpers when using pyll?
Instead of `Dir.chdir` and ch-ing back, a block would look nicer:

```ruby
  cd "src" do
    <things in between>
  end
```
В общем, лучше использовать BufferedReader и метод readLine()
Предыдущее значение можно кешировать.
Дефис - тоже часть слова.
Надо тестировать только proxy. Т.е. чтобы время на создание не учитывалось.
Why this doesn't follow same pattern in storage APIs and have class called `MediaService` which will have a `create` method? IOW, I don't think that in Java customers are supposed to deal with `OAuthRestProxy` directly.
That seems fishy. A little *too* fast? :)
I think there is no way to do this.
indeed this variable has been replaced by separate n_se_n, n_se_s, n_se_e, n_se_w (length of different borders)
could you add a verbatim description of what the example is doing and what to look at in the plot?

btw I find the plot figure really hard to read :-/ Yellow lines are barely visible and dots are too tiny.
shouldn't something like this go via "set_params"?
`DTYPE(_t) -> np.float64(_t)`
Anonymous function is superfluous. 

```js
that.uploader.bind('UploadProgress', onUploadProgress);
```

should be enough
Include the program name in the usage string before build and run.  Should be sys.argv[0] (may need to pass it through basename())

Also add square brackets around the optional args, specifically NDK_PATH and IP_ADDRESS
This is not intended for production.  All the methods in Global will be implemented.  Otherwise i agree that if it's not supported on the platform it should crash
all the pointers should be initialized to NULL here
I almost feel like there should be a macro or function for this or something - you'd use it a lot in the runtime functions.
Jake, that got lost in my GitHub disaster yesterday morning. Just added it back in  (so much easier the second time around)
I'm still not convinced - I can't think of any uses.  The code looked clearer before saying if (stable)
Possibly - although it already uses this mechanism for deleting files.  They typically complete very quickly, so I can't imagine any problems in normal usage.
should be just if (bAdd) really.
This method should go entirely, but only once ```doRemoveEntry``` is able to receive a file, and use that file to check permissions.
queryKeySize() has always been called... (?)
It's part of old interfaces by the looks of it...
if selectInterfaces fails, it checks to see if km != NULL ...
Any issues with the superfile being an entry in the transaction at this point and after ?
I guess that's legacy. Anyway, I will be happy to use a more standard format, but is that not out of scope? We want to have the new UI work as the old one for the moment.
use `chartContainer.text("some string")` unless you can convince me otherwise.
By keeping the `var my_variable` near where it's only needed you make the code more readable. Contrast:

```javascript
var x  = 1;
...100 lines of code later...
function doSomething(y) {
    x *= y;
    return x;
}
```
with

```javascript
...100 lines of code later...
function doSomething(y) {
    var x *= y;
    return x;
}
```

Then you don't have to jump around whilst editing code. For example, if you (using the first example) decide to delete the function `doSomething`, will you remember to delete the initializiation of the variable `x` when it's far away.
@garbas 
Think this has been auto merged from
https://github.com/plone/Products.CMFEditions/commit/1bb1733182b8d67ff224163f4df5625bf6f19ddc
The resource is not required to be mounted at `/trace`, perhaps we could join with the `request.uri` instead?
The "limit" and "barrier" values define the limits enforced by the host environment. So these are the values you should or can't excess. So we need those (at least some of them) to find out if the resource usage is about to hit a limit.

In my example graph the orange and red lines are based on limit/barrier: http://download.moeding.net/diagrams/beancounter/bc-vir.png

You are right, that the "maxheld" value is probably not so interesting, so we can certainly drop this one.
Shouldn't it (and all other calls to json_encode()) be Zend\Json\Json::encode()?
Why wouldn't this just be ZombieToolbox.System?
L40 もそうですが、 message を呼ぶよりは `(incf counter)` などとしてあとで `(should (= counter 1))` でチェックするほうが良いと思います。

また、 batch モードで起動したときに、 ERT の output に message が混ざって結果が見辛くなります。
Change this to "the name of the template to render"
Someone on IRC solved this with Lua scripting, but that would require Redis 2.4+.

http://pastie.org/4566109

The relevant code is:

```
// Returns 1 if acquired lock.
var lockScript = redis.NewScript(
`if redis.call('SETNX', KEYS[1], ARGV[1]) == 1
then
	redis.call('EXPIRE', KEYS[1], 60)
	return 1
else
	return 0
end`)
```

And checking for holding the lock:

```
//Return 1 if lock held.
var holdScript = redis.NewScript(
`res = redis.call('GET', KEYS[1])
if res != ARGV[1]
then
	return 0
end
redis.call('EXPIRE', KEYS[1], 60)
return 1`)
```
SI standard is not Java coding standard. I checked online, another way to spell out millisecond in Java is Millis, one example is the getTimeInMillis of Calender ( http://docs.oracle.com/javase/1.4.2/docs/api/java/util/Calendar.html#getTimeInMillis() )
Actually it's worth discussion - at no point should end users ever see dummy data. We may need more robust fallbacks for missing data than what's in this commit already, but in retrospect, I probably should strip out the dummy option entirely (I was initially inspired by the presence of this option in the Courses widget, but am now re-thinking it).
This should probably handle a wider range of containers/iterables to be more generic.
braces aren't necessary for single line conditionals (if I haven't mentioned in the past, I tend to follow quite closely to Qt's code styling guidelines) - but again, more nitpickery that isn't necessary to fix
I mentioned it in the form comment; if there's existing CSS, it should be maintained even if the custom CSS is not longer allowed by the tier.
Not needed anymore, right?
s/genrated/generated/
Yes, indeed better.
I'm inclined to remove it since all values should be equally affected by round-off errors.
This should have been fixed by this commit: https://github.com/mozilla/mozillians/commit/e7b742d6f847b3f3d0d90933f96ac344d0a5cdbc
Is it too late to mention that *doppel* is German for double?
Can these XHRs be changed to instead be text: requires?
// sets when the clear button shows up. default is Titanium.UI.INPUT_BUTTONMODE_NEVER
What visual style does iOS use? Does this refer to adding a nav bar? Dimming the background? 

Something like this might be clearer: 

On Mobile Web, windows are always modal, blocking input to underlying windows. If the window does not occupy the full
screen, setting `modal` to `true` provides a visual cue by dimming any background windows. If the window occupies the full
screen, `modal` has no effect.

On Mobile Web and iOS, the `modal` property has no effect on whether the window is translucent or opaque.
Should be marked as MW only since MW is DOM3
No need for the width and height variables since they can be passed directly into the returned object.
Yep, good catch! Thanks!


On Tue, Nov 6, 2012 at 5:01 PM, adam <notifications@github.com> wrote:

> In web/file/filesystem/filesystem.dart:
>
> >          _requestFileSystemCallback, _handleError);
> >    }
> >
> > -  bool _requestFileSystemCallback(DOMFileSystem filesystem) {
> > +  void _requestFileSystemCallback(DOMFileSystem filesystem) {
> >      _filesystem = filesystem;
> >      query('#add-button').on.click.add((e) => _addFiles(), false);
>
> Does false need to be added, I think its default.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dart-lang/dart-html5-samples/pull/51/files#r2050895>.
>
>
Is best practice to use the Timer in Isolate? I think we want to use Dart native classes whenever possible.
Probably not in this case. I often put the double check in to differentiate between nil and false. In this case I am only interested in true so taking that out won't be a problem.
entity, newlines :)
PEMDAS.  Your sample answer is equivalent to (10/3 x^3)/2 + 4x +C.  Is this really what you mean?
enclose comparitions in () when connected by logical operators for the sake of readability?
Эта строчка генерит 23 запроса в бд, такого рода:

(0.3ms)  SELECT COUNT(*) FROM `access_rules` WHERE (permission = 'discount_card_ranges#index' and user_id = 6065)

Можно это как-то оптимизировать, чтобы за один запрос выбиралось?
`retro` is a function, not a property, so I'd argue that the parens should be there. But even if you don't agree with that, I'm not sure that it will even compile without them right now, because Phobos is compiled with `-property`. Certainly, if `-property` were fully implemented as originally intended it wouldn't, but I can't remember what `-property` does and doesn't manage to check right now.
wonder if we should just delete these trailing parens
It would be better to move that function definition outside the ``checkScroll`` function.
_ArgumentListMetaData_ is not too bad imo, or do stay with the scheme _ParameterListMetadata_.
This is a bad way to check for home dir
use 
```python
from os.path import expanduser
home = expanduser("~")
```
http://docs.python.org/2/library/os.path.html?highlight=os.path#os.path.expanduser
inject directly
Yeah, I didn't change namespacing on any objects outside of `PSU\AR`
So, you're performing actions at JSM load-time here. You're definitely relying on the fact that JSMs are singleton objects (per window), that is, they're only evaluated once, and are shared afterwards. (Have you tried opening up two Thunderbird main windows?).

Also, you're relying on the fact that in a restartless setting, we're loading this very JSM *after* we've loaded the prefs in `bootstrap.js`.

I think you could definitely create a separate function called `initializeKeyBindings`, that would be called by `bootstrap.js` at the right point in the sequence. That would probably eliminate a few bad surprises later on.
Hmm, Felipe (our master of SS3 design)  won't like the nested context menus, but I guess its a power user feature...
Can we move the HTML out of the _t() call? I know we tend to do that in core, but its not a great habit as it leaves too much room for error for translators.
This is working in MVC2, it is outputting this as HTML.
+1 for: Next, take a look at - and examine - the 'firewalls'
Right. Let me reformulate this then
Is this indententation normal ?
I disagree. There will be partials in partials instead.
should change this to 'mco filemgr' i guess
Ich habe die Konstanten nun eingefügt. Nur leider konnte ich nicht eruieren (auch nach langem Überlegen resp. Vergleichen mit Ecamp/google) wie ich das jetzt in der Funktion resp. Datenfelddefinition einbinde -> hast du mir da einen Hinweis? Meine Überlegung war, die setRole Methode so zu ändern, dass nur die beiden Konstanten ausgewählt werden können, oder ist das im Datenmodell verkehrt am Platz?
Этот метод точно нужен в публичном интерфейсе?
Полагаю, это необязательно, т.к. у тебя в move_to уже есть reload_node, к тому же, есть пожелания убрать reload_node из публичного интерфейса
ДА ТЫ ЖЕ ПОЕХАВШИЙ
Attention, réutilisation de constante. A minima, utiliser une constante spécifique, comme conseillé plus haut.

Tant qu'à faire, peut-être serait-il intéressant d'encapsuler toute cette logique d'initialisation dans une méthode, non ?
Couldn't Apt::Update declare a dependency on this Exec["apt update"] so that this line (and all other similar ones) read `notify => Class["Apt::Update"]` instead?
Yes, only webkit was exhibiting a weird selection issue when doubleclicking.
Missing space before `(`
inject via **the**
Now I think about it; I was more confused than I originally thought.

I thought we decided the default behavior was to work the old way (temp queue per request). That way, it will be slow, but will work the same (unlike me having to add the correlation-key to Mark's test to make it work at all (although I do realize it would be slow without a correlation key).
Sorry I am going up and down as I am noticing things. Should the PseudoTransactionalMessageSource be defined as such:
```
public interface PseudoTransactionalMessageSource<T, V> extends MessageSource<T> {

	V getResource();

	void afterCommit(V resource);

	void afterRollback(V resource);
}
```
then here you would have 'implements PseudoTransactionalMessageSource<File, FileSource> and that would eliminate all those assertions you are  having in line 349
Hi, Gunnar!
`element.getAttribute("input-channel")` is redundant here. Please, take a look into `AbstractConsumerEndpointParser#parseInternal()` on lines around `String inputChannelAttributeName = this.getInputChannelAttributeName();` and into `AbstractOutboundChannelAdapterParser#doParse()`
Or vise-versa: that code should be moved into `ChainParser`...

For 'order' we have constant `IntegrationNamespaceUtils.ORDER`
And also, I think, lines:
````
IntegrationNamespaceUtils.setReferenceIfAttributeDefined(handlerBuilder, element, "output-channel");
IntegrationNamespaceUtils.setValueIfAttributeDefined(handlerBuilder, element, "order");
```
in the `AbstractConsumerEndpointParser#parseInternal()` should be moved after if ... else

The more I see we should introduce `AbstractConsumerEndpointParser#getOutputChannelAttributeName()`: in gateways it is a 'reply-channel' and these attributes should be prohibited for nested elemets too.
WDYT?
Question shall I keep the onInit() check for LiteralExpressions in order to give users feedback as early as possible?
Just wondering, whether for clarification we should state internally a custom **DefaultMessageListenerContainer** is used (**GatewayReplyListenerContainer**)
An __if__ with no __else__ always rings an alarm for me.

BTW, I just ran that test against master and it runs fine, so this would be  a regression.
There's open issues for this at doctrine/DoctrineORMModule#106 and doctrine/DoctrineORMModule#112. Are you able to take care of those? (shouldn't use config here, as of 106).
Compute the value at the crosshair (red vertical line) and print it in the legend next to the metric name. The crosshair, like all other options (zoom, pan), can be disabled through options.
I'd store it in String format, but it's up to you to decide how you want to store it.

On the plus side, Strings are easier to perform comparisons on than byte arrays and much easier to (de)serialize.
changed name to `isResponseDataValid`
`function(options){` -> `function (options) {`
It looks like 1.8 has the encode64 method (as does 1.9), and just the b64encode method has been removed in 1.9. I'm thinking if you use encode64 it will work in both, no?
extract url to WebConstants
writing the same code in the comment as in the method is not very common...please remove that. 
*Toggles between open and close* is clear enough
See previous comment (setting tmpdir doesn't make iny effect)
i htink the idea was that the first thing the user sees is the dialog presentation, but this makes sense if they have already done part of the lesson before, why make them go through the dialog presentaiton. although they have a buton on the dialog presentation that takes them ot the exercises, and seeing the dialog helps reinforce the context for the lesson... @Kedersha what do you think? this is your call...
This method might just as well return a plain old list -- it's building one anyway.
Instead of changing the theme name, let's get rid of it so that the video player will have default styling without a fluid theme on the page.
`--without-apache` is implied with CGI or FPM, and the formula enforces it. See lines 56-58 of the current PHP formula.
I think this file should be called default.html just to make it clear that it corresponds to the default prompt style. Perhaps we can have a index.html that acts as an index to the different kinds of prompts.
@ryan-endacott in your version you're looking up the checkbox's state 2 times. It's redundant.
We are going to use this.$menu very often, so I believe using a variable gives shorter file, specially after "minification"
reset should be removed
There is something funny about the spacing here. Python is sensitive to these issues. The line here should line up with the one above and be PEP8 compliant.
есть просто ASSERT или ASSERT_TRUE
This fix is to mainly address the issue when user types an int in JS, like "2", for fileType, we recognize that as a Double, while he/she thinks that this will be an integer.
String support removed.
This file was automatically generated and conveniently placed into a subdirectory, where it missed my attention. Fixed.
Is this changing line endings or something, it would seem like a line by line change would be easier to read here if possible?
Not sure about this. This logic is specific to the view.
That is a trick done to make the extensions running in the embedded containers like for example glassfish. As I understood the embedded containers does not load the RemoteLoadableExtensions. Similar nas been done here https://github.com/arquillian/arquillian-extension-transaction/blob/master/impl-base/src/main/java/org/jboss/arquillian/transaction/impl/client/TransactionExtension.java. I think that @aslakknutsen can provide more details on the issue.
Make sure user (even owner) can not change createdBy
Yes, dynamically, I plan to do it in the near future.

On Tue, Dec 4, 2012 at 12:51 PM, John Hill <notifications@github.com> wrote:

> In
> lib/lib-dynamo/src/main/java/org/sagebionetworks/dynamo/config/DynamoConfig.java:
>
> > @@ -26,6 +27,9 @@
> >  		DynamoKey rangeKey = new DynamoKey(DboNodeLineage.RANGE_KEY_NAME, ScalarAttributeType.S);
> >  		DynamoKeySchema keySchema = new DynamoKeySchema(hashKey, rangeKey);
> >  		DynamoThroughput throughput = new DynamoThroughput(18L, 10L);
> > +		if (this.isProdStack()) {
> > +			throughput = new DynamoThroughput(75L, 50L);
>
> Are we still planning to do this dynamically?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Sage-Bionetworks/Synapse-Repository-Services/pull/232/files#r2312347>.
>
>
What does you mean saying "always"? Is there any special condition? For me it's creating labels (I can attach code for you).
No new line for bracket