labofsahil/github-event-dataset-2012 huggingface dataset:
I see where this is going and it's a smart move. I agree that the mediator helps greatly to expose things that the application might need pretty much everywhere: other controllers, views, etc. However, I still believe that the mediator should exclusively mediate between different parties, instead of holding instances like User.

I was thinking it might be a good idea to have the next model (I will come up with a solution this weekend if you agree):

ApplicationController < (has composite) Session < User model

Then when ApplicationController calls startup() in a new controller, we pass the user from this.session.getUser() to that new controller instance.
Could this method use a JavaDoc? Would it help out the user to explain what we're doing and why?
0.4.5. Are you at 0.3?
No, actually we could do that without the depth buffer (sounds like a great contribution if you are interested).  Since it will be slower, it should be a separate function like `drillPick`.  Simply call `pick`, set the picked primitive's `show` to `false`, then call pick again recursively (and eventually reset the `show` property for each picked primitive).

While you're at it, might as well add rubber-band picking, which is a minor tweak to `pick` so we return all primitives in a picked x-by-y region, not just one.  Perhaps call it `pickRectangle`.  Rubber-band picking is a bad name at this level in the engine.
Yeah, that's true.  I'll switch it to a dirty list of some kind instead.
You should just be happy that it's not creating two `Cartesian4` instances, too, anymore. :) This class is totally going away when we merge the camera branch so I'm not going to worry about it.
Move this doc to `Context.prototype.createTextureAtlas`
Better yet.  Why not do these checks in `update`?  Same comment for `renderForPick`.
As we discussed, we may want to expose this or base it on number of tiles.  10 ms is a really long time given that we only get 16 ms for 60 fps.
Actually that shader probably needs several changes to make it work in the different modes - not necessarily in the scope of this pull request.
sorry about this one :s
We don't show a log statement in the case of the if check failing like we do below at ln 265.  Really, the if statement at line 258 could be combined with the if statement at ln 257
no npm packages needed by design currently.
Can you guys make this public, then also make public getter for the current state?  I'm working on a Services ticket, the fix for which is going to want to know the state of the runtime.  Would be awesome to have that.
Minor hint: a == NO is equivalent to !a
Hah!  I was looking all over for textContent.  It was hiding as text.  Thanks.
Travis will automatically call the test task. I think the separate task is a good idea as Travis will bring hooks in the future to push changes back to the repo, so the task can be added to for Travis specific tasks.
Nevermind, didn't realize that was a hash, testing something else....
@walterheck  You can create a ticket in the Puppet Modules Project

http://projects.puppetlabs.com/projects/modules/issues/new
* who closes the wrapped System.out?
* yes, as it is meant to print to console
это же будет в будущем отрефакторено? я думаю что конструктор таба надо вызывать когда окошко открывается, а не очень рано
This is intentional for use with jython. __run__.py is a special file that the jython interpreter executes as module when running sosreport as a jarfile. Please revert this bit.
Related question: Is this really `ElementType` and not `ElementEncodingType`. Does this even work with string to dstring or vice versa?

It seems like your implementation is based on "appender.put", and I'm not 100% sure there is support for `dstring` to `appender!(char[])`. I haven't checked, so please ignore me if I'm wrong.
Ah. So that will work. I thought that `isNarrowString` checked that the type was a string rather than that it implicitly converts to one, but now that I look at it, it does do what I'm doing here (though it probably didn't before Kenji fixed bug# 8508). And now that Kenji has fixed bug# 8508, I can probably use `isSomeString` in a few places as well.
This is the sort of comment I was talking about
well the extension is app scoped anyway.
`final`.
Space after `(Cast)`.
what about other exceptions?
only Chef::Provider::Service::Debian supports priority at this time.
change to end class
inkar address dehi ha ro too css sakht mikone
va baraye cms hayi melse wordpress ham injad khata mikone
`&& false` code usually should be removed or fixed ;)
PIC code makes for better security afaik, but there's the performance hit of the extra indirection. Should we care about that?
Für die Leserlichkeit bitte folgendes verwenden:

if($order->getState() != Order::STATE_DELIVERED){
  ...
}

Gefahr des Verlesens bei == ist (zu) gross...
`s/improvemenets/improvements/`
`s/worksers/workers/`
Since sparse doesn't support byte[] as a field type, I don't see how compression can be used here. I retract my request and will merge. We can revisit this later.
it's hard to see what the html part will include for the notes, so it would be great to have a spec for that, too.

from what i get from the code it also contains the asterisk and break tags here? at some point we should use a UL tag for that
why do we set one phase commit to true here?
On Sep 13, 2012, at 12:35 PM, Iain Buclaw <notifications@github.com> wrote:
> 
> @complexmath - the way I have the library build process set-up in gdc, all core.sys modules are processed regardless of platform for generating all .di headers.... Posix is defined on Cygwin last time I checked, which means porters to Cygwin will require to add a version (Cygwin) to add what is supported. But safe guarding the core.sys modules will mean that MinGW/Windows users aren't punished.

I forgot about .di file generation.  I guess doc generation is in the same boat, too.  It's annoying to add the version filter just for those two issues, but there's no easy alternative.
defining 2 new blocks: limit results and sort block
I agree - really this is the discussion we had before where, in batch, the paging item reader has a pluggable strategy to construct the query based on the DMBS. I think forcing a subclass for this is a bit much, given that it's a simple query string and, especially, because there are other requirements (such as calling updateMessageGroup).

I am fine with it being another JIRA, however.

I still need to review much of the code before merging.
messageConsumer parameter is not used (always null passed in).
I am not an English scholar but I am not a fan of in regards to, and all its ilk. Just seems like noise to me.

why not "... is also very flexible and provides ..."
should *afterReceiveNoTX* be *afterReceiveNoT***x**. Throughout Spring we always use the **Tx** moniker.
This wrapper doesn't address anything about @Order annotation,..
Should it be or just will it be enough to polish JavaDoc?
Needs update header comments, too.
Fixing references to r/w owner repo and changing them to the read-only https repo address.
Otherwise LGTM, +1
remember, the length of the line must match with the header length
nepise se zde cely nazev vcetne Exception?
@christianv As this rule is only active for admin pages, I think it's easiest to just leave it in for now.
<pre><code>>:C</code></pre>
I'm sure this is old code.. but this should be something in the quotas, more max size. We don't have to do it here, just pointing out what we might want in the future
from what I can tell, this really does produce exactly the same PDF as your little build script. The makefile isn't even really necessary anymore, but I've kept it as it is easier to type "make" than "latexmk -pdf dissertation.pdf" every time. Likewise for the chapter specific builds.
Can these two lines raise a `ValueError`? If not, i'd prefer to have them outside of the `try`-`except` block.
probably... :P
"that method" -> "that method's"
And add a test with `assert_raises` for the invalid data checks too.
-deleted thisgroupquestions-
How is any of that relevant?
wow, it's a comment.  Don't see those everyday ;)
I would prefer constants here and below.  Somewhere up above (in another file) you define constants for these I believe.
Shouldn't it be phpunit.xml.dist instead of phpunit.functional.xml.dist ?
Having a raw int.Parse inside here could lead to issues. Would be best to use TryParse or some other flow.
What does it do?
`var status = $('#sn-us-status' + status_id).html();` give me same result?
sure..sounds good :)
I looked at the header file:

302 /**
303  * @brief Get the proxy details
304  *
305  * The @c netstatus_get_proxy_details() function gets the proxy details of the
306  * network connection.
307  *
308  * @param details This will be populated with the proxy details.  The
309  * caller must call @c netstatus_free_proxy_details() when done with this
310  * structure.
311  *
312  * @return @c BPS_SUCCESS upon success, @c BPS_FAILURE with @c errno set
313  * otherwise.
please also put a blank line between conditional statements
You have 2 rotation helpers defined here. I would remove one, since it might be ambiguous at a later date which one is defined/found by javascript scoping.
I am confused, are you saying that how he voted is in the key. This should rather be the value.
Lauseke (== (mod n divisor) 0) palauttaa jo sellaisenaan booleanin.