labofsahil/github-event-dataset-2012 huggingface dataset:
Hmm. I see your concern, but I feel like my gut says something different. I feel like if the user returns a non-zero value from the callback, that it feels more natural to propagate it back to them instead of converting it to -1 which can't be distinguished from an internal error.

I feel like requiring the user to return a negative value to abort the loop (as the code is now) is a problem, because it makes it harder to distinguish an error from a natural termination (without requiring the calling code to examine both the return value and the payload). I like the idea that the user can return a value >0 to terminate the loop and then in the calling code it is really obvious and easy to see that the return is intentionally (since we would never return a value >0 from the code).

All that being said, I don't feel so strongly about it. Would you rather that I revert this part of the patch?
Slightly easier to parse is "Password must be 8 or more characters."
I'm not changing history - I don't know how it came to be this way, but this is not the time to change it.
Is it really necessary to create a function for such a trivial check?
top: { type: Boolean, default: false },
Add a method to get the total number of users in `mongo`.
Why was this documentation removed?
sizeof! hipster function.
I think "L'upload" maybe shold be escaped
Are you talking about "backgroundInvoke()"? I think a callbackInvoke will be better. 
I didn't quite understand what did you mean by "push the threading into the method", which threading are you referring to?
It made the test go green. I suppose I should actually figure out why object comparison was being used and correct that.
You could even check if ``$v === 'UTF-8'`` and change the last part of the message accordingly.
you should also mark the test as skipped if there is no mongo server running with the default settings
Whichever is currently preferred should go in the docs I think. Do we currently use scrooge?
Agree, fixed 1b196e0
I'm not sure this page is actually adding anything above the example. I'm more inclined now to move this into the examples folder... what do you think?
Is Path actually ```hashable```? Can we not still get collisions based on object id?
It doesn't return the time.
A lot of work has already been done (https://github.com/alphagov/puppet/pull/187) to get redis integrated into the stack. I'll try to piggyback on those efforts.
niice, although this should be pluggable somehow, dunno if we wanna put connect somewhere around here
Why do we use our own Lazy object instead of ``django.utils.functional.SimpleLazyObject``. Also why the heck do we set it on ``request.__class__`` instead of ``request``?
you're not tearing down this global
stale comment referring to wx
The above change would remove the need for this line.
This should use a SecurityAction
Pull requests for features should never change a version stamp, leave that to the maintainer to decide.
nit: two-space indentation please
nit: add a space between // and the comment
nit: Remov -> Remove
Yeah that make sense.
Good to know this! so I changed to this way when the player need to  release the sources.
let `_debug` default off
I guess it's a typo.
You probably want to do something like:

```js

if ('code' in err)
  errorObject.code = err.code;
```

code is not required but is used (legacy wise, name is used these days for most errors) in some cases.
Do not inline rules. Expand them.
```javascript
/**
 * Real men use block comments.
 *
 * Not only it looks nicer, but it also allows to fold the whole comment block
 * with modern text editors.
 */
```

(just bikeshedding)
Good to know. I guess I developed that habit because similar selectors when used in JS (like jQuery) it is faster to be as explicit as possible. Context switching FTL.
Presumably this should be
fieldValueString = fieldValueString.trim() ?
Can you add comments that explain the logic behind those delay sets, as they seem a bit puzzling without context. e.g. why do we need more than one sequence, and what's the science behind the delays? I suspect it's some well known thing, but I haven't seen it before, so a quick link might do!
Remember the issue here...I'm trying to avoid calls to the underlying 
logging methods...

If I do as you suggest and invoke this through the persist layer, I have 
to go in and find a way to toggle off all of the logging methods in the 
chain of calls that will result.  I'm avoiding this by copying and 
pasting code.  Ideally, we'd use a global redirect of the logging (so 
that all logging would go to STDERR until we toggled it back), but I 
haven't found a way to make that work.

Do you want to discuss this further?  If so, give me a call

On 07/02/2012 02:39 PM, Nan Liu wrote:
>> +    # if the configuration was loaded successfully and it's an instance of the
>> +    # ProjectRazor::Config::Server class, return it, else return a new instance
>> +    # of this class
>> +    return loaded_config if loaded_config && loaded_config.is_a?(ProjectRazor::Config::Server)
>> +    ProjectRazor::Config::Server.new
>> +  end
>> +
>> +  # used to ensure the database is accessible before starting up the daemon
>> +  # process (note; tried to use the get_config method followed by a call to
>> +  # get_data.setup_persist in the past, but this resulted in errors being
>> +  # thrown that showed up in the razor_daemon.log file)
>> +  def database_is_accessible?(conf_path)
>> +    config = get_config(conf_path)
>> +    # init correct database object
>> +    is_accessible = false
>> +    if (config.persist_mode == :mongo)
> This couples the persist layer, and I think what was meant here is closer to this
>
>      persist_mode = config.persist_mode
>      db = ProjectRazor::Persist.new(persist_mode)
>      db.connect(config.persist_host, config.persist_port, config.persist_timeout)
>
> Looking at the original code in persist/controller.rb it appears to have the same issue as well.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/puppetlabs/Razor/pull/112/files#r1088203
We actually don't want to say that it is alphabetical ordering.  The aspect we care about is that the ordering is consistent, not that it is alphabetical.
Exactly this is what should happen if you finish a race!
Can you get these values out of the yaml file? I'm going to start using that more. express has an object called settings (`app.settings`) that is to be used for application wide variables, like env settings.
oh crap - globals? nice catch
Nice. I may move this under ``pretenders.compat``. I've seen that convention used in other projects including version-compatibility adapters.
If `mutateRows` throws an exception, wouldn't that cause us not to close the connection and thus leak it?
Why nest these functions? It harms the overall readability, like before, and there's no clearly compelling reason to do so.
This belongs in the ExitController (and doesn't need the Rails.root)
Sweet, I was not looking forward to setting that on the riak_test side.
I meant for the appropriate leaf classes.
Is there a reason this is called `itemsResetted`? Better English would just be `itemsReset`
There is no output here
Wouldn't this problem be fixed by using `Serenade.useJQuery`? If our proposed solution uses jQuery anyway, then that seems a bit overcomplicated, no?
@gklopper I think you had something to say about this horribly long line of Scala. 
Whatever you do don't let @daithiocrualaoich see it!
But surely setting the "inital" button state and then finally firing off the first loading events is initialising the module??
force using preceding content in the multi pattern matcher
Better style to move `field="settings"` into the `f:entry` and avoid explicit `help` attribute (just name as `help-settings.html` in the same dir).
fixed up here
should mention `readURISync` here
Please use relative require form in both require calls.
this test will save our butts someday!  ty!
Thanks for showing me how wsapi calls can have optional arguments. I'll remove `default` as a value and make this optional throughout the code.
You're right. This used to be nested but not anymore.
`CB` is for CallBack.
Should I rename to `fillContributorsCallback`?
We don't need to import DocsPage because it's imported in the HeaderRegion.
FWIW, I think we (MDN, or just me) would be fine if `s=` didn't auto-create sprints, and was just ignored until/unless a corresponding sprint was created by an admin. Then, once the corresponding sprint (eg. [`s=2012-10-30`](https://bugzilla.mozilla.org/buglist.cgi?list_id=4572316;resolution=---;resolution=DUPLICATE;status_whiteboard_type=allwordssubstr;query_format=advanced;status_whiteboard=s%3D2012-10-30;product=Mozilla%20Developer%20Network)), start paying attention to them.

One of the things I sorted out in my thinking yesterday is that we've often used tagging bugs for the next sprint as a way to collaboratively pre-load the next planning meeting (or even the one after next, like a GTD "tickler" file). We have a lot of inputs - from writers (ie. sheppy), readers, translators, devs, PM, etc. Helps to capture all those "oh yeah, next sprint we should..." moments with a quick whiteboard tweak.

I had also insisted that collaboratively adding bugs to a sprint after it started was important. I still think that, since MDN devs tend to do a few things every sprint that weren't originally planned, and we'd like the end-state of the sprint to reflect what we really did. But, it's less important than the pre-loading notion.

But, if you're doing it for MDN, I don't think either of those two things (pre-loading, post-loading) from whiteboard data really demands sprint auto-creation.
indeed, if thats merged we can simplify this code
this is inconsistent about whether you put the `@api` at the top or bottom of the yard doc. I'm not sure what is better, or what we use elsewhere, but it'd be good to follow a consistent style
Looks good to me (Added to todos).
We should probably add a spec for whether this returns the same class if Time is subclasses or that a new Time instance is returned then.
Does MRI do this or is there actually a more complex coercion mechanism going on here? I suspect this is probably correct, since we do StringValue() coercion as the next step, but just want to confirm it was checked.
optional: can do this in parallel.
s/may (will)/likely to, as explained in the paper./
good call. done.
Nope that's wrong.

It's the config for
```
 grunt.task.registerMultiTask('css', 'Concats, replaces @imports and minifies the CSS files', function() {
```

, should stay outside the the compile section. I thing the empty compile config is compulsory, maybe something to look at for the next version.
Remove this function if is not used
SoapClient is not imported by a use statement, If you do this please do the same in the argument typehint
Name suggests this array represents some kind of threshold. Suggested name: $entriesPerPriorityCounter
Yes, it should have already been here, I'm always using that class
Mea culpa, man. That's fully my fault. Fixed it.
Might be nice if we can get @davidfowl  to have a look at this.
More complicated than that. Thread safety is sort of irrelevant with a distributed cache. The Azure cache has either optimistic concurrency or pessimistic concurrency. We're sticking with optimistic for now, knowing that it's okay if it throws, as it will just get set later. We aren't doing any operations that require consistency. When we do, we'll ass CAS-flavored methods that allow for that.
just a minor cosmetic request. please put the { on the next line
No actually not, haha. Will change this.
if we are going to or from an array or an object we need to reset the object to get rid of _val or extra keys
Can't have `USECLANG=1` here. It hard-wires the compiler selection which causes the build to fail on Snow Leopard.
Yes -- my mistake, obviously. I've updated the formula to install the header file.

Apologies, again, for the repeated mistakes. This is the first time I've actually committed back to a project, and I'm sort of fumbling my way through it. Cheers!
`<% completed ? 'checked' : '' %>`
-> `Meteor  • TodoMVC`
This is probably better written against the slug of the missing category, rather than a magic ID.
Hmm, strange - I'll look into this.
This is a SVN thingy. Please remove it.
there was a longer variable name here before, i probably forgot to realign after deleting.
yeah .. i should just check if its !== null
yes, you can't do it. Unless your me (the admin)
Nitpick
I'd prefer

```php
foreach ( array_keys( $config['system'][$group][$id] ) as $key )
{
    // ...
}
```

As it avoids using a temp variable.
I do not go on the IRC channels that much these days. I couldn't find a log for #github or #gitorious, so I'm not sure how active they are in general or what content is there (I've been idling on them for a few minutes and there are people, but not discussions right now).

I think this is mainly about making the distinction beteween GitHub and Git clear (this was noted to me by Bradley, so my patch is really just relaying his issue).
Don't really want to cut that in two ...
State the return of None explicitely.
above lines outside try?
Maple has the exact same pattern (set finalpath in unpack_src, and copy binary installer to the build dir). Why isn't this implemented in Binary?

In Maple, all the source files are copied to the biuld dir, which seems better.
Indeed, fixed both of your comments.
Where did all the extra indentation come from?
My only comment here is that you could actually specify these as command line properties so that people can do `mvn test -DxmlUrl=... -DjsonUrl=..." - might be easier?

You would need to use a property replacement symbol in the pom.xml ${jsonUrl}, and set default values in the properties block.
It seems odd to me that none of the actual logic for Converting a bag is in BagConverter
Same note about `assertEqual` vs `eq_`
What's with the lack of indentation here?
Is there a reason why we reformatted the standard google code?
AUTO_INCREMENT should start at 0... All table createtions.
AFAIK you always power on an instance because when you create it, it powers on itself automatically after build. I don't think this is feasible not even from OpenStack nova (just because it's never needed)
Downgrade to Jenkins version 1.455
No, Cesy and I decided just to point it at the same database for now.  This
seems to be a pretty common configuration, and it's what's suggested in the
docs we were working from -- when we actually have a real "production"
server, we'll want people to be able to test the almost-ready-to-deploy
code against real up to date data.

A.

On Sat, Oct 6, 2012 at 10:52 PM, pozorvlak <notifications@github.com> wrote:

> In config/database.yml:
>
> > @@ -20,4 +20,10 @@ production:
> >    password: thisisnottherealpassword
> >
> >  staging:
> > -  production
> > +  adapter: postgresql
> > +  database: growstuff_prod
>
> Shouldn't this be "growstuff_staging" or something?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Growstuff/growstuff/pull/37/files#r1779971>.
>
>



-- 
Alex "Skud" Bayley
skud@infotrope.net
http://infotrope.net/
Typo there? islanodra_namespace_accessible($object->id)?
I think we should have at least one TODO here, so that we remember to re-validate this change when we'll be using 5.2
Same as the above type comment.
parse_n3() is taking the output from the curl custom metadata call and converting it into XML to stay consistent with get_artifact_info().

The default curl output looks like the following:

<urn:maven/artifact#mariotest:mariotest:mariotest::zip> a <urn:maven#artifact> ;
        <urn:maven#repositoryId> "mariokart" ;
        <urn:maven#groupId> "mariotest" ;
        <urn:maven#artifactId> "mariotest" ;
        <urn:maven#version> "mariotest" ;
        <urn:maven#baseVersion> "mariotest" ;
        <urn:maven#extension> "zip" ;
        <urn:maven#path> "/mariotest/mariotest/mariotest/mariotest-mariotest.zip" ;
Defects don't show up and there doesn't seem to be an easy way to get both at the same time. Rally is the suck. :thumbsdown:
Done - see https://github.com/aptivate/econsensus/pull/61.
Are these tabs? If not, they should be.
Could we drop this method?
I agree.  I'm already working on a topic branch that includes the addition of a fixtures file to make a line like that possible.  This is just a straight 'port' of the cakefile.
Can you update this to just use [Hash#fetch](http://www.ruby-doc.org/core-1.9.3/Hash.html#method-i-fetch)?

```ruby
options.fetch(:pretty, false)
```
Why do you use blacklist?

We already agreed that in real application you will have more private than public paths!
now I've seen it all... the factory pattern in Python!

Looks good.
Path и CalkPath нужно переименовать
Can we batch these 2 requests?
Sorry, I was thinking that it would just be a testing utility.
The intention was to create an external, unchanging interface if the underlying mechanism of registration changes (e.g, it Checks becomes an instance that stores the checks).
lets use displayError instead here
0.05 instead
This looks weird compared to the one above it.
It's about an extra 25 characters to make it work in an API doc system. To me that is a fair trade-off, and PHP rips that right out so it's not going to slow anything down. You get the vote dude!
Это дублирование ваших данных.
В задании (пункт 5) сказано: ...и возвращать количество позиций где символы НЕ совпадают. Кажется Вы считаете совпадающие символы.
Also, you should update the #clearfooter to be a height of 100px with this change.
shouldn't this be "graft docs"?
Good to go!  Thanks for catching that.
I confirm this works for me, although switching the ID scheme from OID to string causes a lot of errors when trying to access the old OID objects.

>Warning: Illegal offset type in isset or empty in mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php on line 1655

>Warning: Illegal offset type in isset or empty in mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php on line 1525

>Warning: Illegal offset type in mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php on line 1528
Can you please add a space after `<RACStream>` and [spaces around the return type](https://github.com/github/objective-c-conventions#blocks) here?
I didn't do that because there is more uses of $row->extension_id in this function. So, I decided to keep the code following the original guidelines.
Is it not possible to check a status code?
same typos here
Can you create a html+php syntax too?
@drak I think there are arguments for using the longer syntax - the shorter syntax can just look like a typo and lead to people wanting to remove the second colon and it makes it explicit that is to e rendered as a code block. When I started contributing to the docs t was definitely suggested to me to use the longer syntax and that this was the preference of either @weaverryan or @fabpot although I do not remember which. 

I am less stuck on using one or the other, more that I think we should be consistent about it as a the moment both are in use often in the same document.
To start it is not true that it is just a PHP template engine. There are interfaces there, this is just an implementation. The idea is
the infrastructure and then the concrete implementation but it does not limit itself to the concrete implementation.

```sh
Templating provides all the tools needed to build any kind of template system.

It provides an infrastructure to load template files and optionally monitor them for changes. It also provides a concrete template engine implementation using PHP with additional tools for escaping and separating templates into blocks and layouts.
```

I think the use cases are interesting as they could be very specialized, very minimalist or something...
YIKES!

I, for one, use `rake paperclip:refresh` fairly extensively/frequently during development.  Clients are *always* changing the desired dimensions of images and adding new sizes.  In a recent Rails 3 project, I must have run this rake task 10-15 times during the development of [the site](www.stephendaydesign.com).

Was using paperclip 2.7.0 in that project.

This seems like a fairly important feature, as dimensions & how to handle processing of images is something that will evolve as your project & design evolves.
fixed in commit 2f73bd2
You right, today I'm not able to count :(
Missing space after the type casts.
=== plutôt
Or `/-closed$/.test(x)`?
Я бы затайпдефил после объявления LJFriendEntry — `typedef std::shared_ptr<LJFriendEntry> LJFriendEntry_ptr;`, а то стремно выглядит.
Hmm that's weird. I'll look into that and figure out what exactly happened.
on my windows it doesn't :P on my win it just opens system menu on each right-click and doesn't count it as double-click. Seems that the behavior is different to each win installation then? awkward
@lstrojny your massactions have to be declared in order of the wanted display ? Can you use a temp variable to build that without having actions declared in order?
Add index_dev.php to use dev environment
Same comment from last pull request: We might want to restart the nova-api after installation and uninstallation to ensure that the endpoints are available / unavailable.
Hmm, rather than mode, you could have subelement in jmxStatistics, i.e:

    <objectSize/>
    <objectCount/>

If none is present, then none. XSD could help you make sure it's only one of the other two. It also allows you to pass further info to each mode if needed.
Let's sort out this crazy formatting please.

Plus, it looks to be code duplication.
This documentation should just talk about "the default" instead of saying anything about "the user's location".
Yes, I'm agreeing! I'm asking you to update the pull to also change the comment to the correct mimetype :)
Style: `void (^)`
@WeatherGod: Just cleared that up. Sorry for the slow response. All tests just passed.
@dmcdougall I think putting the acceptable methods into the message is fine in this case. They will be quite stable and if another method is added it is only a small change.
This file needs to be added to ```matplotlib/__init__.py``` for automatic test pickup (see http://matplotlib.sourceforge.net/devel/coding_guide.html#creating-a-new-module-in-matplotlib-tests)
style nit -- use <code>index</code> instead of <code>idx</code> for the variable name.
I think the implicit wait might take care of it.
This precondition doesn't make sense. See if you can tell me why :)
Actualy, Gonzalo had changed it to work this way, as it would avoid screenreaders to go into English mode. As far as I remember, they don't react to dynamically changing the existing value.
Do we need the height attribute here?
Should these both be h1 tags?
We don't typically line up the values on the same tab line. They should be 

```css
color: #66666;
position: relative;
```
The way in which the search paging is setup in combination with our infinite scroll plugin will probably not require the data-id.
There should be tests added for these new methods in Map. Many things depend on them
there is more unused comments here
you could also use SG_ADD here right?
I will only use start, since in practice a Form can itself be Action handler and terminate any further request chaining.
I've changed the case on the aggregate methods here on a commit I just merged in, hence why the pull request won't automatically merge. Sorry about that, stepping on your toes a bit there.

This change in case was mostly because I was confused why they were being called lowercase by `DataList`, but existed as upper camel case, so I renamed them to the intended lowercase.

PHP and it's case insensitivity. ;-)
Can you add some docs here on how this code relates to the original plugin? Its it using a clean extension API, or monkeypatched?
Making it part of the jLayout namespace implies its a built-in feature to the casual observer - might be better placed under the "ss" namespace, with "layout" in the name?
Is it necessary to keep this debugging in? In <IE8 this will cause an exception.
I'm setting page->modify->first_id, but I'm not sure that's correct, can you please confirm that?

The same code as in read, mark the page dirty if the tree is dirty.

I'm also always creating the page's modify structure: I thought about not doing that (we don't really need it, at least not yet), but it seemed simpler that way, and presumably the page will be reconciled which does require it.
nice catch. probably not.
hah, me as well, naming things sucks sometimes
Can you remove the comment as it does not add useful information?
Comment should be removed
same here (Why did you replace the old test case instead of just adding another one?)
Are you sure you want to override the parameter ``$value``? This often makes code less readable.
Is it possible to define a more specific type for parameter ``$value``; maybe using a union like ``null|Object``, or ``string|array``?
Letting each plugin have it's own instance and private variable scope would be a good idea and would simplify things for plugin makers.
Fine. Go for it then.
You may want to move the OpenGraph thing in create_message but that's another PR
左端のmarginが切り詰められないようにする(#19)には1（一文字分あける）であるべきかもしれません。
Something like `var name = code in code_name_map ? code_name_map[code] : code;`
IIRC for running tests on 1.9.3, I will re-check
I did verify that I was able to import a csv file from the wicket ui with no geometries without this check. I had to manually apply a projection before the final ingest took, but it did work. From the rest path, I had to set the projection on the importitem object, and a separate change was needed to force the context state to be recalculated for that to go through. That was a separate pull request that got merged in recently (https://github.com/opengeo/geoserver-exts/pull/6).

You have better insight into where this might cause issues, so where do you think unit tests would help improve confidence that this won't cause any unwanted side effects? I just want to make sure that I would add tests to the right places.
English: reponsible for
согласен,убрал.
Pull from main repository and use updated library.
You are right. OK.
What is this? This is not right. Is should be in RFC2822 format. Please set [Tastypie](http://django-tastypie.readthedocs.org/en/latest/settings.html#tastypie-datetime-formatting) to use it. And then see how it formats dates, and use the same.

But anyway, this post->json serialization should be changed. As I described. But I agree, let us do for now like this. We can improve later. So use signal here. And serialize like this.
You have to limit how many times it splits.
You should always escape values. Django template variables are escaped automatically only for HTML. Not for JavaScript. There is a template filter for this.
No. I will fix that immediately.
Order by alphabet. Split into lines.
jQuery, not `getElementById`.
i think i found better library under MIT license 
http://code.google.com/p/jsuri/ 
it looks more capable and stable
Ok logging all 3 values.
This will still leak in the case of nonzero `wrapMap` depth (L691).

It's also right in the middle of https://github.com/jquery/jquery/pull/680. Would it be better to apply a fix on top of (or even *in*) that?
How do you pull down an unmerged change?


On Sat, Nov 17, 2012 at 1:35 PM, Nathaniel Mote <notifications@github.com>wrote:

> In fullhouse/templates/dashboard.html:
>
> > +					</p>
> > +					<p>
> > +						<label form="time"/>
> > +						Time: <input type="time" name="timedue" class="time-due"/>
> > +					<p>
> > +						<label form="assigned"/>
> > +						<p>Members: </p>
> > +						<select multiple="multiple" name="members" class="member-list">
> > +							<option value="1">Janette</option>
> > +							<option value="2">Conor</option>
> > +							<option value="3">Brandon</option>
> > +							<option value="4">Jeff</option>
> > +							<option value="5">Cornel</option>
> > +							<option value="6">Shahaf</option>
> > +							<option value="7">Nat</option>
> > +							<!-- TODO: Implement members, above are just placeholders
>
> you can pull down his changes and try it out yourself.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Full-House-UW/fullhouse/pull/121/files#r2160292>.
>
>
What is this check meant to be? An identifier could also be a related entity or an UUID (string, usually).
The check is probably useless since, as an example, EntityManager can handle `find` using an entity itself as a primary key (when the PK is a relation).
Ok, this actually makes me think that the test should consider only the case where `null === $value`. Can you fix that? 

`""` may actually be a valid identifier value, while `NULL` not :)
yeah, yeah stubbin...
Use code.
No, it is not. It's the data model, but then the namespace where it lives, `cls.NetworkLoggerService` is wrong too. I guess it could just be NetworkLogger? I think we mostly have a name containing "view" for the views.
Batching is implemented in another branch (have a look at https://github.com/gpanterov/statsmodels/blob/nonparametric-all/statsmodels/nonparametric/nonparametric2.py for an overview of all the work).
It's actually rack rather than rails - the rails session class inherits from Rack::Session::Memcache which does this in the initialise method:

        unless @pool.active? and @pool.servers.any?{|c| c.alive? }
          raise 'No memcache servers'
        end

So strictly speaking I think only the active? method is used. Most of the others I added so that I could implement set_servers.
Logic reverse. Can you name this self.libvirt_connected = True?
Good call.  I'll fix it.
I think you want:
```java
bho.writeTo(outputStream)
```
On this line and avoid the ```toByteArray``` which makes an extra allocation. We're pretty nervous about OOM errors which we've seen a lot of in the past. For low-level code like this, I like to try to avoid allocations.
+1 on retiring SBParse.  It's annoying on #134 and does anybody use it?

On Jun 13, 2012, at 5:24 PM, Barnaby Rowe wrote:

>> @@ -364,7 +367,7 @@
>>             double flux=1.;
>>             double re = (nargs>0) ? dargs[0] : 1.;
>>             dbg << "**Returning exp with flux, re " << flux << " " << re << std::endl;
>> -            return SBExponential(flux, re/1.67839);
>> +            return SBExponential(re/1.67839, flux);
> 
> This is Gary's code, so I guess it's just an old typo, I'll update it.
> 
> On a related point, maybe it might be worth a discussion to retire SBParse?  It does require a bit of maintenance to keep track with other changes, and I think that the Python front end supersedes it.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/189/files#r980266


-------------------------------

Rachel Mandelbaum
http://www.astro.princeton.edu/~rmandelb
rmandelb@astro.princeton.edu
I think this is a class variable, right?  Shouldn't it be an object variable?
Thanks for pushing the change!  That's neat, I hadn't thought of that :)

However, I think the missing data in the relevant spots in the `xTable` can still cause artifacts when interpolating.  This isn't visible at native resolution and without zooming out a little bit, but with the current commit I've done the x8 scaling test I did above and you can still see the artifacts in the transition at the x=-y line.

Here's a test cf at native resolution:
![original_cf_271212_v2](https://f.cloud.github.com/assets/1454961/33218/ff0bec62-5071-11e2-9625-78e5d32efbdd.png)

And here's the 8x scaled up version:
![original_cf_x8_271212_v2](https://f.cloud.github.com/assets/1454961/33219/0d8beabc-5072-11e2-8571-7e89cacd772b.png)

There are still discontinuities, and these are because the environment in the xTable around (x, y) on one side of the line (x + y ) = 0 is different from that on the other side, due to missing data.
I'd recommend double-checking with the team whether 1.6 is an acceptable minimum.
*~ should cover all of the .rb~

Please delete the redundant .gitignore entries
setBrokerUrl: looks like a strange public method to have, but I see it follows the same pattern as for Qpid and ActiveMQ. Perhaps protected would better indicate its purpose?
With single quotes, `$local` will not be expanded. However, you could use `$local` directly, without quotes.
Is there a particular reason to use a string instead of a real Ruby boolean? Usually nice to use native types when possible.
In general the leading 0 is better, although I don't mind much either way.

I do, however, like `* 0.1` more than `/ 10`. It's way easier to see that this is scaling the random number to be in the range (.5, -.5) with the multiply, and if I wanted to make the range (1, -1) then changing to `* 0.1` is far more intuitive than `/ 5`

There was a great deal of constant hacking to make this feel good. Making those change intuitive was hugely important. (Side effect: This code is full of magic numbers. It shouldn't be, there should be a few tuning parameters used to compute the rest, but there wasn't time for that).
Then this change should not be in this PR at all then...
What is the reason for making this unclonable?
ah good .. this way we can get rid of all the ``|striptags``
Well, the benefit of the original version is that the stuff that nobody cares about is all one one line, and the stuff that people might care about (the list of allowed IP addresses) is neatly listed each on its own line and easy to edit (e.g. If you run your PHP stack in a development VM). This, to me, trumps both coding guidelines compliance and performance, given that it's not in production code.

Moreover, since it's a security safeguard that might be edited, it's important that it's easy to read and check, not that it's fast and compliant. If this file (or `app_dev.php`, which has the same statement) is accidentally deployed to production, you want to be able to see at a glance whom you gave debug access to.
I recommend limiting lines to 80 chars -- this one is long enough that it isn't readable in Github.
Actually just checked [the docs](http://code.google.com/p/jsdoc-toolkit/wiki/TagParam). It should be `@param {String[]}`
Facebook API calls it that:
interested_in     :  The genders the user is interested in  :     array containing strings

Should I still rename it?
Why remove the clumsy check? Removing this, the staff will just inherit clumsy_check = 1, which means that a clumsy player will have a chance for the staff to explode in their face. Is this the intention?
Не понял, зачем прописывать 'calendar.setFirstDayOfWeek(Calendar.MONDAY)'.
Метод 'getLastWeekOfYear' находит номер последней недели года. Для случая. если 31 декабря приходится либо на пн, либо на вт, либо на ср, то номер недели становится равным 1.
done, and used homebrew standard way of doing writes
maybe you should use `$view->set()`
Or, add the readme to these docs?
I dunno. I'll fix it up. This was just me beating the existing code into a runnable state in Grunt 0.4
On Wed, Oct 24, 2012 at 09:53:22AM -0700, Andreas Mueller wrote:
> > +    seed: int, optional

> shouldn't this be random_state?

Should be. Also the description is off (it should be an int, None, or a
RandomState object).
I'd rather do it now so as to not forget.
Why did you remove the test as well?
> unusual indent - vertical align doesn't quite justify it

Will fix.

> should also add auto r_gs2 = S7019(1); if not present elsewhere

Auto declaration, which doesn't have an explicit type, is irrelevant with the bug 7019.
I believe we should perform an integer type check vs. just a number type check.  Otherwise we add no value by specifying it's an integer vs. just a number.
You should add the name of the file that can't be found to the exception.
This function doesn't seem to be used anymore and I don't like what it's doing anyways. Please remove it.
In general, what are you trying to do here? [&\?] doesn't match the authorizationCode results...
Array instead of nil
As of 8097b80, server.pp now takes in a $yjp_snapshots_dir as a parameter . I *think* it would be expected behaviour for oae::app::server to now manage that directory, since it has oae::app::server-specific requirements (e.g., the sakaioae user needs to be able to read/write to it).
Since these removes are async and in a work queue..

Could a restoreWorkUnit or other action to bring back a dll, interfere with this async delete mechanism ?
yes, my next commit (daregress in cppunit) should take care of it
No, that was not it. I'm just confused %-)


On 25 Dec, 2012, at 20:18 , magnum <john.magnum@hushmail.com> wrote:

> On second thought, you are only printing that when given GWS=0 explicitly, so it can stay. Some of my formats always do a find_best_gws() so I removed the message from them.
> 
> On 25 Dec, 2012, at 17:40 , claudioandre <notifications@github.com> wrote:
>> In src/opencl_cryptmd5_fmt.c:
>> 
>> > @@ -353,6 +353,10 @@ static void find_best_gws(int do_benchmark, struct fmt_main *self)
>> >  		}
>> >  	}
>> >  	global_work_size = optimal_gws;
>> > +	fprintf(stderr, "Optimal global work size %d\n", optimal_gws);
>> > +	fprintf(stderr, "(to avoid this test on next run, put \""
>> > +		GWS_CONFIG " = %d\" in john.conf, section [" SECTION_OPTIONS
>> > +		SUBSECTION_OPENCL "])\n", optimal_gws);
>> >  }
>> Ok. Please, think about it and let me (us) know. So, i will change 'my' formats.
>> 
>> I will be travelling (i suppose internet is really bad). You are the master if you need or want to!
>> 
>> —
>> Reply to this email directly or view it on GitHub.
>> 
>> 
>
Hi Rafael

Commited by mistake then, the next commit do the right thing

Thank you for your review.

On Wed, Aug 8, 2012 at 2:12 PM, Rafael Oliveira <notifications@github.com>wrote:

> In Products/CMFEditions/skins/CMFEditions/versions_history_form.pt:
>
> >          <div class="documentDescription" tal:content="vdata/object/Description"></div>
> > +        -->
>
> @tdesvenain <https://github.com/tdesvenain> I didn't understand this. It
> seems you just commented out the code which shows the title and
> description. Could you explain why you did that ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/plone/Products.CMFEditions/pull/6/files#r1331367>.
>
>



-- 
Thomas Desvenain

Téléphone : 09 51 37 35 18
oups, I removing them
I think that everyone associate the term toolbar with yahoo, ask, google, bing, whatever toolbars, that is 100% width widget in the chrome UI 100% dedicated to your addon. Current "mini-toolbars" created using Widget looks like a little toy compared to these "real toolbars" :p I get your point and I really don't know how to call it otherwise, but it looks like developers may just be disappointed by what we propose regarding what they were expecting.
wonder if you can use a use statement instead of this
Also I have not ported the code that automatically deletes duplicate verts as I want to push an option to the UI to enable this, along with the deletion threshold value see - https://github.com/neomonkeus/blender_nif_plugin/issues/31
Good catch. Idk how i missed this (or how this worked :-S). Will fix.
Shouldn't this use `MISSING_VALUE` instead of magic strings?
@lsmith77 could you update this point before this PR is merged ?
Well, the installation ate up more than 5GB of memory, ran out, and then caused the installer to fail. Probably not a good idea to have Oracle database and BeeHive in the same box, although that seems to speed up installation.  Annoying.
Failed in my test (see coments) ... worked when adding a last line with a "return statement" to the method:

<pre>
	def base
		base = target_uri.path
		base << '/' if base[-1, 1] != '/'
		base
	end
</pre>
Maybe these could be simplified?

```javascript
Cartesian2.fromCartesian3 = Cartesian2.clone;
Cartesian2.fromCartesian4 = Cartesian2.clone;
```
No need for an extra function delegation layer.
Actually this code might also need to execute if the model-view matrix changes.  Do you see why?  Perhaps just make the model-view private.
You mean `ShadyCartesian` was 6 to 10% faster, right?  It was the one without the error checking.

Yes, this is OK with me.
Oops. Fixed this in the latest commit.
Why divide by `500` per fragment here?  Is this tied to your machine?  Perhaps the user should define the actual animation speed direction, e.g., `1 / 500.0`.

In fairness, given that `animationSpeed` is a uniform, there's a good chance that the divide will be optimized out, but it still looks like a magic number.
i dont think u are using the word ``deviation'' right here. Either you use dragStartX/Y or name them like draggingOnX/Y.
At least the following tools build with 2.060: catdoc, detab, dget (if you have cURL installed), tolf

The following don't: dman, findtags (I'll look at making these build, but please add them to the makefile regardless)
I've refactored the web.cloud.config as its big relative to other parts.
This shouldn't be hard coded to the resource - what about the hosted Azure offerings coming in the future?
Do we need to do anything here other than set isPersistent?  I think the flag can just be set here and used (register with activity) when show() is called.
We should be **_very_** careful about storing LocationManager and the list of location providers as statics here.

Keep in mind that Android will keep the process around in most cases even after the last activity has been destroyed. Anything that lives in static memory will also stick around with the process, and keeping a system service in static memory of a process is probably not a good idea (I wonder if this will actually keep around location update events etc)

I would prefer if `locationManager` and `knownProviders` could be tied to an instance of something -- possibly the Geolocation module? just thinking out loud
The code written to the output wastes bytes. You should create a helper function. Also, since you aren't minifying, leave out all whitespace to save bytes.
These methods are essentially there for us to bypass titanium specific code for the onPause(), onRestart() etc methods.  When we are trying to handle the workaround for the android bug, we don't want to execute any titanium-specific code.
Fix needs to be applied on master as well
Fixed in [04c1275](https://github.com/seiffert/ECVagrantBundle/commit/04c1275ca80ccf6678594526d4db71db4af603cb)
Yes, it should show once you've setup the Travis hook. I did fix the link to use the markdown format in the subsequent commits. http://about.travis-ci.org/docs/user/status-images/
D'oh,  can't believe i missed that! Hmm, I suppose we could check whether it's valid to replace the message before the error class is added. e.g.

```javascript
var okToReplace = label.attr("generated") || label.hasClass(this.settings.errorClass);

label.removeClass( this.settings.validClass ).addClass( this.settings.errorClass );

if(okToReplace) {
    // do replacement
}
```
Does that seem fair to you?
I double checked this and that is actually how it works now. Simple comparison chart:

const(int)[3]
typeid:                                 const(int[3])
fullyQualifiedTypeName: const(int[3])

const(int[3])
typeid:                                 const(int[3])
fullyQualifiedTypeName: const(int[3])

const(int[])
typeid:                                 const(const(int)[])
fullyQualifiedTypeName: const(int[])

So actually difference is for dynamic slices and as far as I understand const it is typeid output here which is redundant.
Well, we can get rid of `newLen` (although I tend to think there is a certain clearness to the verbosity).

That said, the line `n = min(n, r.length);` is mandatory, because `popBackN` returns the amount of pop'ed element, which is "the new n".
Rebased with "For example, `ElementType!(T[])` is `T` if `T[]` isn't a narrow string and `dchar` otherwise".
Stack is always only word aligned and a function can't use larger alignment for stack variables without some hacks.
`Scoped_payload` uses `aligned` to align pointer properly.
meh, but it's adjusted now :) translations of entire file on it's way, tags in the files are finished, only the actual translations left :)
fwiw, I think it would be fine to merge in webcomponents.dart here.
it would actually help with merging mdv-poly branch back into master.
not necessary for v11, only for v8
What's wrong with `"DELETE FROM " + TBL_CLIENTS`?
One to configure the top menu item, the other one to populate the children of a given menu item when requested
For now this is OK until we get StyleCop working together. I believe in general we avoid spacing statements this way, but it doe slook clean for constant strings. No need to change in my mind for now.
Oh wait, you mean to define a respond_to? method? Makes sense, I guess.
Doesn't look like this is used anywhere... is there a purpose to this constant?
You sure?  =)
@nicolaasmatthijs Understood. If `!key` is false, it won't continue. The tricky part with `||` is that if you do something like 

```javascript
if (key || key.something) 
```

and `key` is undefined, that line will throw an error.
`click` -> `on`
Ah, you are right. I was going to add a bit of HTML5 Boilerplate inspired IE logic, now I realize SproutCore already does this with JavaScript. Will remove.

Will leave in the no-js class (allows developers to create no javascript css rules for users) and the lang attribute (improves browser support for speech synthesizers, glyph selection, hyphenation rules, and spell checking: http://www.w3.org/TR/html4/struct/dirlang.html )
With #132 we decided not to pimpl the Thread and Fiber classes.
As deriving is part of the API we need to maintain `classInstanceSize` manually.
I still think we should pimpl them because every size change breaks the ABI.
It would also allow to not use self-owned GC memory for Thread/Fiber objects.
The `c_long` and `c_ulong` types are already size dependent.
The reason I have this in there, are issues around cascaded deletes. Apparently, if you do batch/bulk deletes, the JPA spec does not support cascading deletes:

From the spec *JSR 317: Java Persistence API, Version 2.0* - Chapter 4.10 *Bulk Update and Delete Operations*, pp 168:

"A delete operation only applies to entities of the specified class and its subclasses. It does not cascade to
related entities."

Related discussion on StackOverflow:

http://stackoverflow.com/questions/3903202/how-to-do-bulk-delete-in-jpa-when-using-element-collections

In order to ensure *expected behavior* from an end-user's perspective one might even consider NOT to make batch deletes the default.

I hope this explains the reasoning for having this attribute.
Shouldn't we test messageOrPayload here instead of payloadExpression? What if the payload expression evaluates to null? Maybe we should check for that at line 133?
masking __the__ object's hashCode

(i.e., instead of (e.g.,

...and the {@link Lock} for that index is returned.
Wrong :)
'Here' is totally relative. OPEN YOUR MIND AND FREE YOURSELF.
Syntax error? Where is the end of this method?
Nuestro
OK, what I removed was the JError side, which is okay.

What remains still has a RuntimeException:

if (!is_object($this->connection))
{
	JLog::add(JText::sprintf('JLIB_DATABASE_QUERY_FAILED', $this->errorNum, $this->errorMsg), JLog::ERROR, 'database');
	throw new RuntimeException($this->errorMsg, $this->errorNum);
}

@robschley are you saying that log entry should be removed?