labofsahil/github-event-dataset-2012 huggingface dataset:
This doesn't actually test thread safety because of the following reasons:

* `Thread#join` blocks execution of the curent thread until the target thread is finished executing; therefore you never end up having the two threads running at the same time because you're waiting for each thread to finish before continuing.  Instead of calling `#join`, you need to check the status of each running thread until they all indicate they have finished running on their own.
* It's very hard to catch thread-safety issues using a test with only 2 threads.
* I'm not sure RSpec itself is thread safe so calling `should` from inside other threads may result in unexpected behavior.  You need to instead store the result that you want to check in thread-local storage and have the main thread check this result.

I would do the following:

```ruby
context 'thread safety' do
  let(:thread_count) { 100 }
  let(:controllers) { thread_count.times.map { MockController.new } }
  let(:threads) do
    controllers.map do |controller|
      Thread.new do
        GoogleAuthenticatorRails::Session::Base.controller = controller
        Thread.current[:controller] = GoogleAuthenticatorRails::Session::Base.controller
      end
    end
  end
  before do
    GoogleAuthenticatorRails::Session::Base.controller = nil
    sleep(1) while threads.any?(&:status)
  end

  specify { GoogleAuthenticatorRails::Session::Base.controller.should be_nil }
  specify { threads.map { |thread| thread[:controller].object_id }.should eq controllers.map(&:object_id) }
end
```
Is this image (``gettingStartedStacks.png``) intended to be used twice?
supporting 2.0 for PATCH requests ? this would indeed require doing it by hand (but 2.0 would require using the old-school ``bindRequest`` otherwise anyway)
Using a case statement might make this a bit nicer:

```ruby
case payment_source
when ActiveMerchant::Billing::CreditCard
  :credit_card
when ActiveMerchant::Billing::Check
  :check
end
```
Because related fields are special and need some extra attributes.


On 9. apr. 2012, at 13:24, Mitar wrote:

>> +================
>> +
>> +When you are using ``EmbeddedDocument`` in your mongoengine documents, you must define ``object_class``
>> +in Meta class of your resource declaration instead of queryset::
>> +
>> +    class EmbeddedPersonResource(resources.MongoEngineResource):
>> +        class Meta:
>> +            object_class = documents.EmbeddedPerson
>> +            ...
>> +    
>> +If you are using normal mongoengine ``Document`` you can use queryset or object_class.
>> +
>> +Related and Embedded Fields
>> +===========================
>> +
>> +You must define **all** related fields (that you use in documents) in your resource file.
> 
> Why is this required?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/mitar/django-tastypie-mongoengine/pull/1/files#r659694
Don't include a logout view.  We're not logging in or logging out, we're simply returning an auth token when the correct credentials are provided, nothing more.
Je finirais bien sur une autre petite phrase, genre Enjoy! ou Simplifiez-vous les tests!
Ca -> Cela ?
**the** `InjectionTarget` API
good one, will fix.
what about non-translated routes ? I think you would break them.
Did you look at `base.html`? This is called improvising. The user has to work with an HTML5 shell, and is given the opportunity to add scripts, css, and modify the body, all through inheritance and block overriding. This closely mirrors, on a small scale, what we all go through in Medley on a daily basis (not to suggest that we CANNOT modify base templates, but Medley is set up in such a way that we work primarily through `{% block ...` overriding).
When we update Medley to something "better", we can update the dev test to reflect that. What do you recommend, btw?
Java not JAva
This should take sender and message text
과제를 이런 식으로 하시면 안되죠.
Maybe better to take ConceptSource as a param.
This may introduce some regressions with iPad rotation of modals over splitviews; see the testing notes on regression checks.
Good idea! Fixed. Please review.
move to a method getAlarmNames() and replaces all places where this is used
wouldn't this be a bit of a lie in case of a change-merge event? 
It is not actually the uploader but the submitter that the account is referring to.

I think we need to add some kind of event specific parameters. So after the common parameters the event specific ones are added. In this case uploade for patchset created and submitter for change merged. If I remember correctly some events that could be interesting to trigger on in the future has other values as well.

Also beware of backwards compatibility when old builds are deserialized, changing the name could give problems.
I suppose RECAPTCHA does not affect ONLY askbot?
fair enough, its easy to do no benefit in avoiding it.

also means I should add some for the file picker as well since it has so many modes.
I feel we should still check that fopen succeeded and fp is not null.
kannst die actions noch in konstanten packen
Remove it, please
It's supposed to be always defined, even for MIPS64. This is similar to `__mips__` in C and GNU handling them both under the same architecture.
Having separate Identifiers for 32/64 is extremely unhandy and forced me to add boilerplate `version = AnyMIPS` everywhere.
Yeah, for sure--Denis will make some changes in response to this feedback and it'll be in the next go around.