Update stall URL in TODO file

Change-Id: I435836d45a6b8686c85d54986a4693be50fb3238
Signed-off-by: Robert Middleswarth <robert@middleswarth.net>
Specify the iso image for mounting ovirt-node-image

There will two iso images at least. One is the actual ovirt node
image file, the other is the soft link to it. So mounting *.iso will
fail.

Change-Id: Id6b644bd1b71788d9b665cdcf720b86cf575285a
Signed-off-by: Wenyi Gao <wenyi@linux.vnet.ibm.com>
install: fix KeyError on no-efi machine

When installing node, KeyError raises because there is no
key efi_hd in grub_dict on no-efi machine.

Change-Id: Iecd523776f6eb5fa534ca3234363210e7b09bdc9
Signed-off-by: jarod.w <work.iec23801@gmail.com>
network: Don't modify tagged interfaces nic names

A dict is used internally to map interface names to the corresponding
interface informations.
Previously the VLAN ID of "VLAN interfaces" was removed from a interface
name (e.g. eth0.42 became eth0) which lead to wrong
NIC-informations-mappings, because the informations corresponding to a
VLAN interface (eth0.42) overwrote the informations of the original
interface (eth0). This lead to obvious problems because informations like
e.g. vendor were missing from the vlan interfaces informations.
This patch prevents the name mangling of tagged interfaces, this way the
interface is later ignored when summarizing the informations.

rhbz#837745

Change-Id: If0afd40a7f9c0b541f06722cee50568e746c0336
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
o-c-setup: Display and write valid network config

Previosuly, in the case of invalid static network configuration settings
(e.g. invalid IP, GW, ...), the type was set to "static" for the runtime
of the TUI and never changed during the runtime of the TUI.
Now the configuration type is updated correct.

This patch additionally addresse the problem that not all invalid fields
were given in the error message.

rhbz#837614

Change-Id: Ia54d2c5842661c9eac28b7436a1e4159a950e80f
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
o-c-setup: Disable VLAN field on disabled network

Previosuly it was always possible to enter a VLAN ID on the NIC details
page. Now the field is only enabled if the network is or gets enabled.

rhbz#826863

Change-Id: I095f1ea266e7861c364aef96ce76f9cda2662b5b
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
ovirtfunctions: Make sure we don't kill ourselves.

    While unmounting log partation, if there is a python process using log, "killall svc" will kill all python processes incl
    Give a fix to make sure we don't kill ourselves when install node.

Change-Id: Ib057e0576661137928d0d717dbc302314f4bea32
Signed-off-by: Eli Qiao <taget@linux.vnet.ibm.com>
docs: Add documentation on how to setup igor test env

This documentation describes step by step how to prepare the env to run
igor tests.

Change-Id: If418c2b5fd6c924faa3d3037e8637f6fe248db31
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Move python modules into subdir

Previosuly all python modules lay in the scripts directory. But because
this name differs from the installtime ovirtnode package it is not
possible to do build-time checks on the sources.
This patch is a first in a series to allow build-time checks on the
python sources.

rhbz#843753

Change-Id: I09b33ff7741a4c53c2352251806f78072489c871
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
Makefile: Add check-local/-fast target

The check-local target is used to run doctests, pep8, pyflakes, and
pylint python tests on the sources of teh ovirtnode package.

The additional check-local-fast runs a subset of these tests and is
intended to be used with the pre-commit git hook.

Change-Id: I528d3dc5cdf8ebcdc8809f338433df4ae4231891
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
kdump.py: Remove wildcard imports

rhbz#843776

Change-Id: I1ae4bc2eba0819fdeb996abe74e401664e06bd49
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
kdump.py: Remove unused code

Change-Id: Iea22848cb4eb3e318e10ac78f6c148da7643b0f2
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
password.py: Remove wildcard import and add augeas

Removes the ovirtfunctions wildcard import and adds a missing import on
augeas.

rhbz#843776

Change-Id: If9ab63be69e08dcc73aa1871e14c234afd8d3750
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
password.py: Remove unused variable

Change-Id: I183bf17a7dd2055678dbb879ae43d1c9081e44be
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
password.py: Fix E302 (missing blank lines)

Change-Id: I4fa619d1c1e489cb028ba6c826625e4ea685d091
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
log.py: Remove wildcard imports

rhbz#843776

Change-Id: If73c243ca345f79e789528a4d3d78822c6ddd179
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
log.py: Fix E501 (line too long) and module logger

Change-Id: I59325fe8e463efdf4edeb2df5dd7d0f688c0c7a5
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
snmp.py: Remove wildcard imports

rhbz#843776

Change-Id: I53612b96bd9d546fc0e6e65c0d3731bed9d2f314
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
snmp.py: Fix E501 (line too long)

Change-Id: I5cd9d34eeda8da454f4a30c5da0bec5837add2f7
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>
install.py: Remove wildcard imports

rhbz#843776

Change-Id: I5b3447a2360fbdce04dc8a4b919b7eb4ebb3cf3c
Signed-off-by: Fabian Deutsch <fabiand@fedoraproject.org>