labofsahil/github-event-dataset-2012 huggingface dataset:
Hi Ajay, This diff does not seem right. It thinks every line has changed.
Have you got your line-ending conversion configured correctly in git?
http://help.github.com/line-endings/
classes are nice, but OK!
This is awesome. I had no idea of the existence of this code. Thanks for sharing!
FYI - I have enabled CloudFront so all media is available at http://data.cooperhewitt.org/media/350/filename.jpg -- If you want me to pull in your changes, send me a pull request when you are ready... thanks so much!
Or you can use {% with %} here: {% with create_folder_form as form %}{% include .... %}{% endwith %}
@batasrki - Check out my batasrki-tconsole branch on the main project. I had to do some work to get things working with this, and there are still a couple of things I'd like to tighten up before we merge this. Awesome feature!
Endpoint instances are going to be put into collections. Therefore, they need a decent equals() and hashCode() implementation (in compliance with the guidance given in the Effective Java book).
gitolite require unique key. Unique to the gitolite instance.
r+ - it makes sense to me to have all user clicks routed through a single function and I understand the motivation.  A skim of the code looks right.
My assumption was, that at the end of the script the curl connection is trashed anyway. But this doesn't seem to be the case -> memory leak issue. So close option seems the right (but dirty) solution. So a user that doesn't want a memory leak, has to close it himself ...

As you probably understand, I'm somehow not happy with both solutions. Isn't there a better one? :-)

But just to make it clear, the whole problem comes from not using curl_close and has nothing to do with the changes on line 124, right? You had to change this, because the connection is not stored anymore?
where did this file come from?
Which one? Corrected specs or the latter idea?
make ===
setPlayerListName is just used to control the name displayed in the player/tab list.

setDisplayName is the craftbukkit display nickname.

This was correct as it was, at least for vanilla 1.1 clients.
That's a lot of imports ;)
s/reconize/recognize/
Here are the includes needed at the begining
http://pastebin.com/XAUQ7R2A
:)

I like the idea, not too sold on the syntax at the moment. 

What about something like:

     builder.build(objs).into(window);

     builder.build(objs).clobbering().into(window);

Thoughts?
Isn't this a deprecated API?  fluent() should be.
it sure should 59a72fdfc0d401a11f30f5345e9f66178fef2907
This is my goodbye to scripting instances ;D
Kologarn still not playable
While this is okay, I'd instead do a method_exists() check on $screen for add_help_tab(). (The Twenty Eleven theme does exactly this.) It's a more explicit check of the functionality. Plus, if we add some other method to WP_Screen in the future, a class_exists() check won't be enough to verify. It's forward compatible in terms of technical debt.
I have POSIX without Content-Type declaration in s-w-l.conf.


This is how it works correctly. Added the new file 'common.conf', and these lines into s-w-l.conf without comments:
[INCLUDES]
before = common.conf

[Definition]
ContentType = Content-Type: text/plain; charset=`locale | awk -F= '/LC_CTYPE/{ print $2; }'`

actionban = printf %%b "Subject: [Fail2Ban] <name>: banned <ip>
+            %(_ContentTypeMailHeader)s
...

I have no idea why Content-Type does make a difference.
Go for multiple -e.

I don't think an admin would inject any shit in there, just he should know what he is doing. At least it is tested if it is a directory..
This part took me a while to get perfect.
/** noted.
here it's "dump_requests", below it's "objecter_requests".  the latter is probably better? '

other than that, looks good to me!
Блин. Почему именно 10? Почему не по порядку? =(
Hey Lea

I try it again. As you can see I've added the option the same was as you did with the prefix-free library.

Maybe you'd like to move the toggleClass function to a better place and make it reusable.

Cheers
Benny
.. Maybe I could code that up when I can get postgres/postgis working on this laptop :)
It wasn't suggestion for right now, just a comment while I was thinking about it
I don't think you should `child` with a component here. "Component" is the domain of the application, not the restify library. It is more about seeing "oh, these logs are from the 'persistence' part of my app" rather than some library having hijacked and added "HttpClient" (the default name here).
Looks good. I'm not sure how we ended up with that bug, but it's an easy fix.
а че этот файл здесь делает? его наверное удалить надо отсюда
I guess this is just because the java sample applications define test classes in the `test` package but they should be defined in the default package. Nothing related to the eclipse sbt plugin.
isn't if ((strncmp(ptr, "<?xml-stylesheet", 16)==0) good enough?
хотя да, ты прав. тут же tmp.splice(i, 1);
Utiliser négation des caractères de sortie.
put the entire tag is a little messy,  to improve a little bit the original code you could do:   .attr({'href': url, 'id': style})
or worse yet, I might even remember what I did :P
This functionality is pretty useful, so I would rather have the classes be merged and given their public class so that they don't get duplicated yet another time.  I think the name CandidateCluster makes reasonable sense as a name when reading both clustering algorithms even if it diverges from the pseudocode a little bit.  From the streaming paper, Facility still sounds out as being a weird archaic name that only Shindler and Meyerson use.
Can't you do ++ to doubles?  Why not just make it a double and avoid the casting?
I'll do it. 
Sorry for the mess, I'm quite new with git stuff.
I learned about `git rebase` yesterday, that would have made your life easier.

My bad.
This should be merged with Config.java.
I have read the PLIP several times and the take away I have is that the [generators are unnecessary] (http://dev.plone.org/ticket/10959#comment:34).  If you'd like to help me understand, you could cite the specific bits of that very long conversation that are relevant here.
Oh, definitely. But I didn't want to add that functionality in this branch, so I opened a ticket on it. http://bugzilla.pculture.org/show_bug.cgi?id=18772
The class isn't private, in fact it was constructed by Query as well.
Not a problem since I've changed it there too, but others might be using it. Modeshape?
You meant to put /usr/bin at the end right?
Master branch yep, throws errors regarding api.
Heya
strange i wanna import this sql 2012_02_20_02_world_conditons.sql

mysql error table not exit on npc_spellclick_spells 
UPDATE `npc_spellclick_spells` SET `quest_end`=11999 WHERE `npc_entry`=26477 AND `spell_id`=61832 AND `quest_start`=11999;
i hope u can help me, the sql file is wrong or missing infos ( new tables on npc_spellclick_spells, quest_end and quest_start not exit ) dunno why
640k should be enough for anyone....
use GetHitPlayer()
One error fixed.

```SQL
-- Insert npc_text from sniff
DELETE FROM `npc_text` WHERE `ID` IN (9195);
INSERT INTO `npc_text` (`ID`,`prob0`,`text0_0`,`text0_1`,`lang0`,`em0_0`,`em0_1`,`em0_2`,`em0_3`,`em0_4`,`em0_5`,`prob1`,`text1_0`,`text1_1`,`lang1`,`em1_0`,`em1_1`,`em1_2`,`em1_3`,`em1_4`,`em1_5`,`prob2`,`text2_0`,`text2_1`,`lang2`,`em2_0`,`em2_1`,`em2_2`,`em2_3`,`em2_4`,`em2_5`,`prob3`,`text3_0`,`text3_1`,`lang3`,`em3_0`,`em3_1`,`em3_2`,`em3_3`,`em3_4`,`em3_5`,`prob4`,`text4_0`,`text4_1`,`lang4`,`em4_0`,`em4_1`,`em4_2`,`em4_3`,`em4_4`,`em4_5`,`prob5`,`text5_0`,`text5_1`,`lang5`,`em5_0`,`em5_1`,`em5_2`,`em5_3`,`em5_4`,`em5_5`,`prob6`,`text6_0`,`text6_1`,`lang6`,`em6_0`,`em6_1`,`em6_2`,`em6_3`,`em6_4`,`em6_5`,`prob7`,`text7_0`,`text7_1`,`lang7`,`em7_0`,`em7_1`,`em7_2`,`em7_3`,`em7_4`,`em7_5`,`WDBVerified`) VALUES
(9195,1,'Greetings, my $g brother : sister;. How can I guide you today?','Greetings, my $g brother : sister;. How can I guide you today?',7,0,0,0,0,0,0,0,'','',0,0,0,0,0,0,0,0,'','',0,0,0,0,0,0,0,0,'','',0,0,0,0,0,0,0,0,'','',0,0,0,0,0,0,0,0,'','',0,0,0,0,0,0,0,0,'','',0,0,0,0,0,0,0,0,'','',0,0,0,0,0,0,0,1);
```
is it worth having a container.getHintInt() function to common up the code?
Looks good, thanks for doing this.

One minor nit: can you please leave a space after the // in comments? It makes comments look similar across the codebase.
shit....good point
Why do we use `#quit` here?
Was `'a'` a typo?
this line is correct?
...and then if we tell the widget how much space it actually has available, it can adjust how much of each notification it shows, like it was doing before.

Hmm. I don't know if we actually want to replicate the entire Android layout flow (measure pass, layout pass) for watch widgets, but... :-)
How  to isolate every string in spanish.
Try it and see (with softlockup detection enabled) - or, assuming that ramconsole (/proc/last_kmsg) is working (if it isn't, getting it working should be your top priority), plug in the phone and let the LPM crash occur, then pull /proc/last_kmsg to look at what caused the crash.

In my case, it was kinteractived hanging, which is part of the interactive governor.
Correction this commit updates **FYI-BOOKMARKLETS** to the 1.9 release
I thought this was appropriate, no?
I love the layout of github
We should be able to wrap this catch higher up, however this is passing internal server information to a client that does not need to know any more than the call has failed so if we should catch and log but only send back a generic error.
I tried separating out the nav items in two ways: one where the entire background of each block was a semi-transparent background, and another where only the titles 'my info' and 'team info' have a semi-transparent background. the styles for the background on titles only is commented out.
six of the first 30 This item doesn't exist or is not yet in the database. sry no go...
this will get done when the time comes for it.... not to mention we run differ GUID sets then ArkDB...
lets not cause more work then needed.
url should be generated on the fly with PHP and echoed in the head
@inverse yo check this out. It'll install a working, up to date perl now. Just need to have it install one more thing then were good to hack on the music app!
I actually thought I'd removed it in a follow up commit, but it's too early for me to make bold claims like that  :)
I didn't tried. But some stock key layout don't have a key for auto focus
on camera key. Well, by copying I know that i will had fully working keys.
I see. Thanks a lot!
Keygen and fingerprint code should go in the ssh_helper.rb
I'm on board with this approach.

-Jeff
- What do you mean "shell-objects"? I haven't heard this term. 
- Is it enough to initialize all array pointers with nullptr and set nonzero = 0?
`\file` is used by Doxygen
Don't you need UA checking?
Yes, this is a problem. We can convert `entity` to `guid` and then reconvert it in the case of ElggEntities.

The access to this kind of views is by url, using `cache/js/' + elgg.config.lastcache + '/<view>.<type>`, so it isn't possible to use objects. Maybe I need a previous verification to delete objects and leave only strings, numbers and booleans?
In fact, we can consider these constants at the application level and move them to OAuthConstants. But these constants are for the profile so I staid close to what I did in ScribeUP and attached them to the profile : it's very subtle... It could be changed but I prefer to keep things that way.
Yes, now it's a copy of the CAS server default theme, but I imagine that deployers might want to customize the look & feel of the services management UI.
And using theme is a proper way to do that, isn't it ?
It was - pycparser can't handle comments. Perhaps we should run all kernels through the function that strips comments before compiling them, rather than only the FFC-generated ones? That way, we could keep comments in user-written kernels, and FFC kernels wouldn't be special-cased.
we should pipe it to unhandled?
import static java.util.Arrays.asList;
    asList(Foo.class, Bar.class);
Why a lazy val?
Should this really be enabled by default?
Shouldn't this be under the description like with `====Note====` above it or something.
every time it raises an error, it exposes a real data problem.  do not swallow!
doc blocks would be nice to have for this whole file.
not here(!), but these should be fixed to use codenames, no?
You're making a lot of ppl very happy lol. Will re-work and update. I know another kitten dies with each as.xml setting added but this one seems valid enough. Default behaviour will be Eden behaviour - tbh I never fully understood the rationale behind making the constant stream of silence the default rather than the option.
this can be const. and let's keep the hungarians happy and change it to iGroupID
it is just a bunch of text, not sure what file format would be best. It is all readable.
what about calling isGeneratable() before this method and let this one throw exception.
Here users will have to check after anyway
class="report chunky"
Notice that when multiple lines are broken you leave the first line blank and align one clause on each line, and put the closing parenthesis after the last clause aligned with the if.
all the rest of the diff is only dedent, and remove of the final end.
This can be removed once we have a way to get an `CGAffineTransform` from an `NSAffineTransform`.
New code should not be using explicit `@synthesize` directives.
@bnoordhuis , Interestingly after adding abort,  wrap is NULL HandleWrap::Close due to double close. We need to guard against it, UNWRAP was replaced with manual GetPointerFromInternalField in that particular case
Style: method names start with a capital (see the Google C++ guide).
Why do the "unimportant" files not go into `<(SHARED_INTERMEDIATE_DIR)` ?
dead test?
Ah, I see you've done the type coercion here, but you'll want it in d3.geo.path so that calling path.pointRadius() returns a number.
Probably need type coercion here for number (+_), when not a function, and above, when a function.
Actually, would this be better if it were `KeyError`?
on fait pas de recherche dessus encore
```
traits.Either(traits.Int(5), traits.List(traits.Int), usedefault=True, ...)
```
Oh, that's cool... :+1:
I think the or'ed argument would look better on a single line.
Empty case raises the error, you're right. Needs an explicit test (though honestly, why are you indexing to get an empty array in the first place ಠ_ಠ yes yes, I know there are some legitimate uses).

Figured out a few more places where the scalar case should have a warning added.
Should be `gxp_youtubesource`
это же не Id, это сам элемент. я бы заменил на previouslyConnectedTo
else на одной строке с {
Can you fix the changelog here, and move it to the top? Thanks.
Another discussion related to this thing is if you would return 400 to clients when something goes wrong or if you would just ignore "broken" cookies. This may happen if you change the secret for instance.
IMO, it's not as dangerous as it might look. What it does is scan through the file looking for any strings that match `/-([0-9a-f]{32})\./`, for example: application**-15e3a26e343f4cee7500049e0de72b0a.**css

It then does a second check to make sure that digest is contained in the manifest, so if you want, you can safely add references to a compiled file from another application, and it won't touch that reference.
The scaladoc at least states it in the postitive sense: 

> (8) When in both EXPRmode and FUNmode, add apply method calls to values of object type.

Perhaps `isValueType(tree.tpe)` is suitable? 

Incidentally, that has a [different logic](https://github.com/scala/scala/blob/master/src/reflect/scala/reflect/internal/Types.scala#L5809) for excluding `PolyType`s.
I see. Within a half an hour I'll submit further refactoring of the code. Could you please then take a look at the latest version of `typedMacroBody` and suggest a rewriting for it that wouldn't use exceptions and didn't degrade the same clarity? So far I couldn't come up with such an improvement.
Yes, because it's a singleton dummy like `emptyValDef`.
Can't believe this marvel is about to be deleted.
https://github.com/scala/scala/commit/91f82d58219#L3L168
```
-    <!--
-        NOTE: Command line length hell on windows. The maximal command line length on
-        Windows XP or later is 8191 characters (http://support.microsoft.com/kb/830473).
-
-        BUT: this only applies for processes executed directly in the shell, which is NOT
-        the case by default when using ant's "exec" command; this one uses the Java VM's
-        execution facilities which allow larger command lines. Testing gives:
-          - Windows XP: 32768 characters
-
-        When the parameter (vmlauncher="false") is specified, the <exec/> command uses
-        the udnerlying shell, and the smaller limit applies.
-
-        The call to ilasm produces lots of output, which could be avoided using
-        (spawn="true"). This seems to work wrt to the character limit (32768), but is
-        probably not the best solution since it's incompatible with (failonerror),
-        and does not produce any output at all.
-    -->
```
Since A is a matrix this is the operator norm induced by the L1-norm and not the L1-norm. In this case this is the maximum of the sums over columns. 

I would replace `L1-norm --> max column sum` in the comment
what's the case that this covers?
what are the values of logpdf so this is nan?

I don't see when this case might ever occur.
I wrote it from scratch with happened to be similiar since both are based on the init.d.ex template.  
But i will add as you say.
I don't call Basic.new, I call FiniteSet.new

Does FiniteSet respect the ordering of the elements that go into it? I don't think it does.
It was missing though.  I guess the doctester's whitespace normalization makes this work.
Also, `_mat` for sparse matrices was renamed `_smat` since it is a dictionary, not a list.
I can't check right now, what does this actually do? In any case, it probably shouldn't be pointing to your fork of SymPy, but to the main repo. 

I believe there is a separate procedure for organizations that someone will have to go through (I have push access but I'm not sure I have enough rights to do it either).
Ah, sorry, I mistakenly thought that this was part of the `ask_generated.py` file.
Answer is `c**10 * s**10` .  I can get `s**10*(-s**2 + 1)**5` or `c**10*(-c**2 + 1)**5` depending on whether `c**2` or `s**2` is solved for. Would be nice to be able to give simplify an assumption that `c**2 + s**2 == 1` so that we don't explicitly solve for either `c**2` or `s**2`.
will fix and add another test
You need to pass the kwargs here.
why is this in the repo
По-моему, после «писать» запятая не нужна.

«Осуществляете соединение, имея секретный ключ» я бы заменил на «подключаетесь с использованием секретного ключа». Иметь не значит использовать. В данном случае, на мой взгляд, более близкий к оригиналу вариант даже лучше («connect with the SSH private key»).

«SSH-ключа, загруженного вашим пользователем»: невольно хочется переспросить, кем? У меня есть пользователь? Да я сам пользователь! :)
Тут скорее должно быть «загруженного вами SSH-ключа» или «SSH-ключа, загруженного в вашу учётную запись».
SGTM. Thanks.
If get_violator fails (OSError reading from pipe?) this should still write an error message.
I think we should strip this outline. FF seems to calculate the height strangely and the outline shows up below by some bit.
Do you intend to let the user change the default log_debug_level by overriding it in init?
Why you commented those 3 lines?
It's possible, but I don't see any differences between localhost and quadbase, even after saving to disk (admittedly, my browser might unescape stuff without me knowing, so I'm not entirely sure)
File "/vagrant/apps/wiki/management/commands/populate_file_m2m.py", line 8, in <module>
    class Command(NoArgsComment):
NameError: name 'NoArgsComment' is not defined
indentation looks like it's off here? mix of tabs/spaces possibly?
Yeah I remember you mentioning this on 0.1. I discussed that with @ppapadeas -who's actually doing the css/html work- and we agreed that it's nicer to have them grouped per functionality and not alphabetically, therefore we didn't proceed on fixing https://bugzilla.mozilla.org/show_bug.cgi?id=732965 . Do you mind if we leave that this way?
Should be one space instead of two. Same below.
This was actually copied from the remote avatar file. It seems like Cullen might have mixed this up while initially importing that from the old avatar system. The label in this line and the next one shouldn't exist to begin with.
If this does get merged, you should post a link in the migrations RFC to this commit.
Right, that sounds correct.
Such comments should be made in commit messages and/or code.
Don't use global. The only acceptable exception here is main() cause there is no alternative. You should either be passing objects as parameters, or assign them to members variables in main() and use e.g. $this->template.
$phpbb_style
I hope this text is ok. If not, please, provide correct text. Thanks.
Needs phpbb_ prefix and I would suggest something like phpbb_style_verify_active.
Should we add a WARN once on this?
removed the comment... it was weird.
(basically, avoid passing a non-sprintf formated string to a sprintf style function)
Check and see if there is a less ugly way of doing this.
Ack, will fix
no. I have vim only in append mode. giving the whole ramcloud thing a try
@drewfish No, because Y.config.logLevelOrder comes from getAppConfig() from store in the first place, it is set as part of the Y.config early on, and it lands in the _configureLogger through Y.config.logLevelOrder. So, developers my want to redefine that list, in which case the lower priority element does not need to be 'debug' necessarily.
согласен, бред)
Это должно быть в конфиге
Ещё огромгый один плюс такого подхода - можно показывать сттистику за любой день/месяц/год
If we don't need these lines, let's remove them. Otherwise maybe add a comment for why we're commenting it out here.
Ooops, this file lived in a scalar/ folder for a couple of revision, forgot to change the name back.
all browsers will send `on`. But there is no harm on making it case-insensitive.
Single-line if-blocks should be wrapped in curly-braces
camelCase: stockLocationName
No, we may want Sencha registration in the future, keep it there for now thanks
Any reason not to hash ``tag`` as well?
I've tried to implement this without success. I've pushed the unsuccessful attempt in a commit so that it can be viewed. I'll rebase it out later. I'm using Constant (this is what I used in the similar LoadFromDisk op) but that understandably still excites the constant-folding optimizer. Suggestions?
Yes, I believe we should fail.
Can you use the scheduled thread pool executor in RealVoltDB? You don't have to worry about forgetting to shutdown the executor service.
If new value == old value, I don't see the difference. It still might be an accident that there's partitioning specified both in project.xml and ddl.sql. I'm not convinced that the value being the same changes the usefulness of letting the user know there's redundancy in how the partitioning is specified. I'm sure I can be convinced otherwise...
I am uncomfortable with maintaining two independent lists of market instances in the simulation.  The market class currently has a static list of all "live" markets.  Facilities also use `Market::marketForCommod(string)` to get pointers to markets for offers/requests.  Now we also have a static list in the Model class.  I think the two need to be consolidated - otherwise I can foresee tricky trouble emerging in the future.
Indeed, it's a typo.

It isn't a syntax error — or the tests would have failed loudly :)
Indent 2 spaces for all lines here and below, same fix for `$(...)`
`|obj|` ? That's the first time I've seen pipes used as notation to refer to an identifier. Backticks, quotes or no wrapping is more common and obvious I think. Where does this come from?
Minified/gzipped is the main target when size is concerned. Was just shooting in the dark here.

+5 is perfectly acceptable in my book but we need a unit test.
Hi, Florian, I may need more your help about the comments on all the distribution functions. I need much more study to express as clearly as you do. How about you edit these comments directly after the source code is ok?
quote removed. done
What is not static?
Docs for the error codes perhaps, I know nothing about json rpc so I need some hints in her :-)
Also encapsulating the pykka stuff in ``is_future`` doesn't really make sense when you repeat the ``get()`` outside of the wrapping.
Seems like these two lines really need to check for the correct batch, too.

We need to think more about the `[:1]`, that's a little bit odd/scary. Under what circumstances could there be multiple matching sitescans or urlscans? What should we actually do in that circumstance? Randomly picking one of them is almost certainly the wrong answer.
This module name does not match the class it defines.  Must be context_helpers.rb
Here we re-render the list element whenever 'status.contact.updated' is triggered which is done every time a multi element is changed. But we only need to update it if FN, EMAIL, TEL, ADR or CATEGORIES has changed.
If we add the property name to the event as in 
```
$(document).trigger('status.contact.updated', {
    property: element,
    contact: self
});
```

we only have to trigger it once in end of saveProperty() and we could also cut out updating the groups td in addToGroup().

So the event handler would be something like:

```
$(document).bind('status.contact.updated', function(e, data) {
    if(['FN', 'EMAIL', 'TEL', 'ADR', 'CATEGORIES'].indexOf(data.property) !== -1) {
        data.contact.getListItemElement().remove();
        self.insertContact(self.contacts[parseInt(data.contact.id)].renderListItem());
    }
});
```
We should avoid non-english comments. Even in this case the text should be in English.
Yes, i will.
I missed that, sorry.
I'm confused, I thought the point of temp dats was that they didn't have to exist on the host at all (until the user does op_fetch_data).  So why are we allocating host data and then copying it to the device?  I was just expecting a call to cudaMalloc here.

In the MPI case, I guess the temp dat needs space for halo data on the host.

Two more things:

The loop to transpose AoS into SoA appears in multiple places, again, can we refactor it into a function so that people don't have to reimplement it everywhere?

Transposing a flat array of zeros into a flat array of zeros is pointless, so I think the transpose is unnecessary here.

If you want the data for the temp dat to exist on the host as well, I think this function should do something like:

char * data = malloc(set->size * dim*size);
op_dat dat = op_decl_dat_temp_core(set, dim, type, size, data, name);
cudaMalloc((void**)(dat->data_d), dat->size * set->size);  // or whatevery the calling convention is.
@z-index-brackets-bottm-panel-resizer would be more accurate.
I did think about that, but I looked it up. Turns out the original definition
per also defines the code as VK_EQUALS
    http://www.javascripter.net/faq/keyeventconstantsfirefox.htm

Note -  I redefined the code as the brackets uses 187.
    KeyEvent.DOM_VK_EQUALS = 61

    I assume you are OK with the code changes I applied vs the FF reference
quoted above?

    J.





Raymond Lim <notifications@github.com> hat am 7. September 2012 um 20:47
geschrieben:

> > +    DOM_VK_F13: 124,
> > +    DOM_VK_F14: 125,
> > +    DOM_VK_F15: 126,
> > +    DOM_VK_F16: 127,
> > +    DOM_VK_F17: 128,
> > +    DOM_VK_F18: 129,
> > +    DOM_VK_F19: 130,
> > +    DOM_VK_F20: 131,
> > +    DOM_VK_F21: 132,
> > +    DOM_VK_F22: 133,
> > +    DOM_VK_F23: 134,
> > +    DOM_VK_F24: 135,
> > +    DOM_VK_NUM_LOCK: 144,
> > +    DOM_VK_SCROLL_LOCK: 145,
> > +    DOM_VK_SEMICOLON: 186,
> > +        DOM_VK_EQUALS: 187,
>
> Also, why plural here? should be VK_EQUAL.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/adobe/brackets/pull/1583/files#r1557620
Need to record app startup time and return the delta.
The standard on Windows seems to be Ctrl+_Shift_+up/down (see Sublime, Notepad++, and IntelliJ/WebStorm).  The only odd one out I could find is Eclipse, which uses Alt+up/down.  On _all_ of those editors, Ctrl+up/down instead scrolls the view by one line (without making any edits).

On Mac, most editors seem to lack this feature.  Eclipse uses Alt+up/down and IntelliJ/WebStorm uses Cmd+Shift+up/down.  I'd be inclined to go with the latter since it's more consistent with the Windows one (in fact Brackets will automatically convert Ctrl<->Cmd, so you wouldn't even have to declare two shortcuts in that case).
Code style nit: why start a new var? Seems more consistent to add to the list of vars above.
You are right. I copied this from the old watcher
Shortened to two lines to be short and readable ;-)
Can you push a commit to get rid of this debugging code?
Haven't really changed anything here but I think my editor swapped tabs to spaces, or vice versa.
This can be more than just input type=text (e.g., url).  Maybe wrapTextInputElement?
Should I have?
retTmp is not very descriptive, is it? :)
Isn't `null` missing here?
prefix -> path
Why not just add a CSS class to the container on the aggregates page?
jejej, you answer yourself :) the problem was the postMessage so if we send the url via parameter it could run as remote web content. I try to implement it .
This should be configurable as an attribute on the trifle instance - I might want two GeoIP databases loaded in the same redis db, but without using `Redis::Namespace`.
Ok, since the route is added in a array i wasn't shure and wanted to implement it consistent.
Can you remove this file from the PR.
What's with the extra space?
Likewise, here you can use:

```python
@property 
def scale(self):
    ....

@scale.setter
def scale(self, val):
    ....
```
I thought of `SpaceTimeCoordinate` just now - and now again - because I'm a rebel ;-) I just put it in there as an example. In no way do I think this should be done next week. 

By spherical coordinates I mean coordinates on a sphere (like a globe) without a distance. I remember that converting from Equatorial pm to Galactic pm was a simple matrix multiplication.
I don't think ``FK5Coordinates`` has been imported yet
`SOME_OPTION() if val is None else val`.  What's here will always return `SOME_OPTION()`
This is calculating the timestamp after it has been delivered to the cache. If the cache has been backlogged by lots of requests, this means the staleness calculation will be later than if the timestamp had been calculated as soon as folsom returned in `do_get_stats/2`. Maybe that's okay, but it seemed worth mentioning.
Maybe. I think we decided against that last time, and let command-line options temporarily override GUI options. Anyway, this is not the place for that discussion.
This and the previous change do not compile.
Also, note that USE_* flags currently represent optional dependencies. I'm not sure IPv6 is a dependency, just a feature?
Right, I forgot to call this out but I noticed it during the refactor. If we had an update since the last check and its subsequently been > Timeout seconds, then we are still updated, hence ignoring the Timeout.
"fires event" instead of "adds activity"
This event should be fired automatically in the model if `motion.set_close_date` is successful.
BTW: looking at these two lines, I'm not entirely sure 'types' is the best name to choose here. I mean, by itself it makes sense, but right above it, you have another key called "type" that is called almost the same, but does something completely different. Maybe the "type" key could be renamed to "widget" or something like that?
Yup, fixed already in 681e926.
removed from all tests
>Yeah, ok, let's not go this far. You can have more than one argument per line. :p 

Ok. I was just trying to make sure you could review this from your shiny phone ;)
Also add tests for null values in the data
+1

/me should pay more attention
Or here is what it looks like. Right now only activated on hover: http://cl.ly/image/2W3V3C1m3z1t
Indentation is off here. The dot should be located under 'C'.
Your point is sound but the complexity, just to be able to not ask for permission, is high. 

Either way, I think a code comment is in order to explain why savepoints are used.
Is this supposed to be L10n'd?
That's very ool of you. OOL. LOO. Loo. Looc. cooL. COOL.
could do, but the test case hinges on commitRecovered()... but it should be possible to refactor...
This will result in multiple element definitions with the same `id` attribute, which is not valid html.
All prior interfaces have been "Name*Interface*".  I think we should keep this standard convention.
Not having the URI scheme breaks the redirect for some clients (namely my own [s3itch_client](https://github.com/k33l0r/s3itch_client)).
It seems to have been like this in the original WME Lite-code, comment and all.
I suppose the implication here is that RequestMatcherInterface effectively becomes a flag with no additional methods, no?  Is that OK in Symfony-land?
Sending a PR to master will not make it in 2.1. You need to send it to the 2.1 branch
This is wrong. You can have the same DQL with different parameters and different query hints
Yes, but the test is wrong and and even if it breaks bc, it was not really useful before because it generated a URL that doesnt get matched by the route.
And thats not what should happen.
for `$var === CONST` you should write `CONST === $var`
indentation for above function is off
I see where you're coming from. Makes sense.
I see an optional parameter right there `options=""` which is what I was alluding to.  Our other calls use `optional={}` for the optional parameters, and wanted to check if these calls used a different set of optional parameters or none at all.
That should be a logger.error.
Since OIIO is the preferred alias, maybe this "using" is now unnecessary ?
Don't need the extra spaces here.
Il y a une nouvelle URL pour l'install de RVM:
```
curl -L https://get.rvm.io | bash -s stable --ruby
```
what returned error value?
oh, I missed the comment bits, my bad.
对. 不写也可以展示.
We *don't* want spacing around `this.options.autoExpand`, contra https://github.com/jquery/jquery-ui/pull/829/files#r2337662?  

As such:

`function( event )` but `if(thisIsTheCase)` ?  c/d
`document.body` may not exist at this point.
I think you want to rename this `test_`, otherwise it won't get auto-run. I usually use `check_` as an inner function name when I'm doing a generator test.
这个地方你还不得还原。
change
      "import sys, subprocess"
to
      "import sys"
      "import subprocess"
emacs header I mean (ouch)
You should put this into `Lockscreen`
don't we just need
`assert.notEqual(aContacts[1].innerHTML.indexOf('AD'), -1)`

?
We will see tonight :)
Fixed. This is what will happen if there are to many levels of `if`, lesson learned.
Dominic's steps to reproduce are here http://people.mozilla.com/~dkuo/B2G/Gaia/TestMedia/12120005.mp4

I'm guessing that bug only happens near the first and last image.
Looks like I need to clear the frame.filename when n is out of range.
We need to import utils.js for the method of getLocalTime().
File a Github issue for this plz
var len = loadedResponse.shortcuts.length;
for (var i=0; i<len; i++) {
Move up to align with `}`.
nit: remove a line break
I do not see any better place. It's possible to put them in the module parameter, but it's just overkill.
Pas de short_tags please
Why? You don't need this information in `BasicMatcher`. If you do - you need to implement raw interface, not `BasicMatcher`.
Not sure we need a DSL for this, how does devise get their devise_for routes into the proper object?
This seems to me like a quick fix. Setting the start time is not what in the finish method should do.
Rename and have preset and history inherit
Add in an e-mail tag as well here.
Put the raise on its own line.
have you looked at the included memmem?
Make variable more descriptive. 

$m_unit -> $material_unit
...
and what would be the name? the chatchannel name can be "" or {{Red}}<whatever>{{Reset}}
The more I think about this, the more it seems to make sense to include. The cost of including it is basically zero, anyway.
This declaration needs to go at the beginning of the block. (Line 53)
Maybe that trailing colon should be removed? I'd say add a pipe instead but I think that looks funny.
Could `db.completeBuildset` not return whether it updated the db (or if somebody else got there first), and the message only be sent if it did. It seems like this would only cause issues in a distributed setup where the db itself is replicated, but I think we probably have assumption elsewhere that it isn't.
Is this change necessary? The `branch` argument defaults to `self.branch`, which might be `None`. (This is handled in `base.Source`.)
I think page view showed itself as a failed concept. It doesn’t play nice with automatic memory freeing (you need to explicitly delete stuff from view) etc.

I removed it in brunch with chaplin and will remove in ostio as soon as gh-233 will be merged, because regions manage stuff much better.
That's pretty standard for must of PHP's buitin functions returning strings or failure though.
Ohh, right, I missed that completely. Is there no way we can get around the user agent sniffing?
This can probably be simplified to just be: `datum = d[split] || d[split.to_sym] || ''`
i think i'd honestly just prefer whitelistedcidrs.clear();
Instead of using an instance variable here, maybe do something like this:

```
container = event[@container]

```

Then make 'parse() take another argument, this hash, and have parse() modify the container. And if you have '@container' get a default value of "@fields" all things by default will store in the right place.
Is this a `PageSelector`?
Include roslisp:ros-info
we need default sorting
add column position
after_create set it max position + 1 if not set

use default_scope for sorting

This should be applied to all admin tables
the motivation was to be able to keep track of a user's response to "is this your computer".  If a user logs into different sites using different emails, they should only have to answer the question once per device, not once per email address.

challenging myself a bit, we *could* instead keep a collection of emails and update that based on the server's response to `list_emails`.  I'd have to think through this a bit to see how reliable it would be.

How strongly opposed are you to exposing a user's own id to him?
Looking at the overall directory layout and how requires are typically included, I feel like it would be preferable to put all of the create_templates code into a file in the /lib directory that can be included from both scripts/create_templates and here.
I have no idea how much memory that would take up, but would that mean that less used languages would be taking up a meaningful amount of memory that could be used to cache other data?
Seems like this should be Puppet.log_exception
$annotations
I'm a little worried about this part, $rstFile is an arbitrary filename without the arbitrary extension. But xmlFileNameToRst has hardcoded the xml extension

For example: $docbook = 'foo.bar'

```php
$rstFile = RstConvert::xmlFileNameToRst('foo'); // Only filename
// Result foo.rst
```

But the xi:include
```xml
<xi:include href="foo.bar" />
```
```txt
.. include:: foo.bar.rst
```
using `assertSame` here should confirm https://github.com/zendframework/zf2/pull/3050/files#r2209983
We could use `master` instead of `release-2.0.0rc1`

@armetiz The Markdown syntax is invalid. This should be:

```
[INSTALL.md](https://github.com/zendframework/zf2/blob/master/INSTALL.md)
```
This could be simpler: `assertTrue($sampleInput->getAttribute('allow_empty'))`
I've updated the docs for every element.
Perhaps I'm missing something, but using __dict__ doesn't seem to make a lot of sense here...  Is there any reason you're not assigning directly (e.g., self.flags = flags instead of self.__dict__["flags"] = flags)?
){ (no space)
`>=0.8`
`@$el.toggle(if @collection.length is not 0)` or something
Wrong indentation. They should be all in a single line.

## Rule 4: Use only one dot per line

> (Obviously, we have to replace the dot with an arrow in PHP)

When dots are connected, your object is digging deeply into another object (or even a series of objects). These multiple dots indicate that you’re conceptually violating encapsulation. Try asking that object to do something for you, rather than poking around its insides. A major part of encapsulation is not reaching across class boundaries into types that you shouldn’t necessarily know about.

Also, multiple dots in a single line of cod might result in several issues when it comes to debugging, logging and exception handling, since you won’t be able to isolate the bug, or the atomic action, properly.

The Law of Demeter ("Only talk to your friends") is a good place to start, but think about it this way: You can play with your toys, toys that you make and toys that someone gives you. You don’t ever, ever play with your toy’s toys.

> NOTE: This rule will be a guideline as well, and thus has been adapted as follows:
> 
>     Chaining different objects is object, as long as this execution flow involves only getters or setters.
>     Chaining the same object via Fluent Interfaces is fine. Apply this technique carefully, as described here [ http://devzone.zend.com/777/fluent-interfaces-in-php/ ].
This does not make sense IMO. Your view entities are still entities.
why calling ``getCollection`` here ?
can't we use the class loader of composer here?
This should be taken care of by making store_location a before filter.
you mean in my overlay root? No such file - also, what do I need it for,, and why is it not already there?
That would be useful to also specify some metadata in the tests and check that things are like expected.
This is incorrect, should be 
MODULEPATH=($HOME/.local/easybuild|$EASYBUILDPREFIX)/install/modules/all
setMethod() and also rename String operation to String method
Ok. Well it should be:
```python
with open(os.path.join(os.path.dirname(__file__),
          'profile-photo.jpg')) as f:
    profile.photo = File(f)
    profile.save() # Must save inside with block
Yes, I'll throw that it in now.
got it ..my bad
an extra newline, compared to the style of the other declarations (dont mind me if this is too annoying haha)
Surprisingly  this is faster. Benchmarked with:


     test "should detect when a sequenced slug has changed" do
       with_instance_of model_class do |record|
         record2 = model_class.create! :name => "original name"
         assert_performance_linear 0.9999 do |n|
           print ("\n" + n.to_s + "\t=>")
           n.times do
             record2.name = "original name"
             assert !record2.should_generate_new_friendly_id?
             record2.name = "changed name"
             assert record2.should_generate_new_friendly_id?
           end
         end
       end
     end

Results:
```
ORIGINAL
1       =>	 0.000460
10      =>	 0.001874
100  	=>	 0.020734
1000	=>	 0.221181
10000	=>	 2.253847

PATCH
1       =>	 0.000445
10     	=>	 0.003682
100  	=>	 0.019071
1000	=>	 0.213103
10000	=>	 2.068461
```

I think it is faster because most of the time it's not necessary to run the second comparision with the regex, as the first will fail right away with a changed name. The same code is called twice only when there is a sequence number.

Anyway would this look any better? 

```
compare = (current_friendly_id || slug_value)
slug_base != compare && slug_base != compare.try(:sub, /#{separator}[\d]*\z/, '')
```

Benchmark is almost the same:

```
Variation
1    	=>	 0.000579
10   	=>	 0.003117
100  	=>	 0.021918
1000	=>	 0.216265
10000	=>	 2.081233
```
My bad should have read the desc.
Any reason to let `PolicyList` commented ?
We don't.  Please remove them.
But having 2 buttons, "Upgrade ThinkUp" and "Update ThinkUp", both in the status bar, is too confusing. Remember the mailing list thread about this?
get не нужен.
Simon and I started a discussion on this yesterday. It might make more sense to pass in a User object rather than a user id. The user object will be on the request and can be passed in, or when calling it from a different API it forces us to call the getUser function, allowing us to put all user validation code in 1 place.
AFAICT there is no REST endpoint for getting single config values.
The addition to this function doesn't really make sense. You are using `i` on `tenantIds`, but never loop over `tenantIds`, implying that order corresponds with the order in config. I think we should try to remove tenantIds from this function or make it more clear as to why it's there and what it's role is.
Same comment, maybe it should be ``ajdt-indigo``
The name should be `breakpoints`. Using `debug` creates conflict when trying to load both project in a workspace (one of them gets deleted from disk :unamused: ).
think it was from a merge conflict
... Maybe `HttpException` makes more sense... @Baachi ?
Пустой массив mustDeps не сообщает для сборки никакой нформации, его надо удалить.
Basically copied the behaviour that's been used throughout the application with :alert, :warning and :error messages being flashed through to the view. I could move this behaviour to a Helper but it'll be different from how the errors are displayed in the rest of the app.
Applications -> application
Could move the second `preg_match()` on the next line for better readability. I know I suggested the opposite for another similar line, but we had grouping there and it made more sense.
I'd avoid this, just write the same line twice. Tests should remain as autonomous as possible.
Неприятная конструкция. Можно обойтись без подобного цикла.
Да, этот косяк я уже сам увидел.
...когда count, который каждый цикл уменьшается на единицу, станет нулем.
таким образом цикл повторится LENGTH_ARRAY раз.
@slebedev т.е., следуя вашей логике, заменяя "А" на "А" я не заменяю?
Так как этот метод никак не затрагивает состояние класса, его имеет смысл сделать методом класса, а не объекта.
Should we not also have an entry for actions? (webworks.bb10/1.0.0/actions.js)
@jspahrsummers Is that actually possible? I'm all for it if it is. I gave it a try but couldn't get it working.
done - a49dcab216c567d3b3180f4ae6ee8c52b4283655
I'm reading pg_num_rows doc, it accepts only resources so casting null to integer doesn't seem to be a resource.
I think it's better something like <code>( !isnull($cur) ? $cur : $this->cursor)</code> , don't you?
I'd want to avoid using the `arguments` object, it might even go away in future versions of JS. You could just pass an array into the function.
建议将loader也做成一个option吧，这样就一个方法就够了， 不需要重载。当没有loader的时候生成的cache，是只能使用(get key loader)方法的，而不能使用(get k)函数，前者是cache的接口，后者只是LoadingCache的方法。
The problem with using `HNil` directly is that, since `Prepend` is not covariant, you get this error here when compiling the tests:

```
[error] .../core/src/test/scala/shapeless/hlist.scala:240: could not find implicit value for parameter prepend: shapeless.Prepend[shapeless.HNil.type,L]
[error]     def prependWithHNil[L <: HList](list: L) = HNil ::: list
[error]                                                     ^
```