labofsahil/github-event-dataset-2012 huggingface dataset:
As a (probably much higher rated than e000) pillar humping paladin on retail in WotLK, I can say without a doubt that this commit is wrong. The cast should fail at the end. If someone is casting a spell on you and you run out of LoS and then back into LoS before the cast ends, it will finish and hit you. You have to be out of LoS at the time the cast ends for it to fail.
```DIFF
+                DoScriptText(RAND(YELL_RANDOM1, YELL_RANDOM2, YELL_RANDOM3, YELL_RANDOM4, YELL_RANDOM5, YELL_RANDOM6, YELL_RANDOM7), me);
-                Talk(YELL_RANDOM);
```
Should these questions be resolved before merging perhaps (FWIW I think we probably should make lockfree especially as there may be a delay in the OS call (but that os call is presumably threadsafe)
why not ```const atomic_t * curCount = (const atomic_t *) ptr - 1;```

or indeed ```ChunkHeader * header = (ChunkHeader *)ptr - 1;``` then use header->count?
All of this manual escaping worries me, since it leaves room for easy errors and security holes. Any reason not to use parameterized statements?
Like you said, most of my changes are also "logically equivalent" because I'm missing the intended design.
So unless you know what you're doing (i.e. have more information on the design) - I'm pointing out that this change is not logically equivalent:
as you can see above, the original code is both 1) checking and 2) waiting on the condition, both while the lock is owned.

Just making sure you've noticed the difference ;)
addedThrowablesCaughtShouldBeValuesOfErrorListBox
Wouldn't work though because at the time the Gemfile is parsed Refinery is not loaded?
Hmm, yeah, I think you might be right. I had doubts myself when I wrote that comment. I will correct it in the message boards.

Back to my original comment. How do think it is best to fix it?
Build changes only - Reviewed
USB `modeswitch` is running before the `conn-health` script @reboot (expected behavior)
-------------------------------------------------------------------------------------------------------------------------

Of course date isn't synchronized to ntp at that time (expected behavior)

`Jan 23 23:39:08 beaglexm2 usb_modeswitch: switched to 12d1:14ac (HUAWEI Technology: HUAWEI Mobile)
Jan 23 23:39:08 beaglexm2 kernel: [   25.915161] init: ssh main process (416) terminated with status 255
Jan 23 23:39:08 beaglexm2 kernel: [   26.203216] scsi 2:0:0:0: CD-ROM            HUAWEI   Mass Storage     2.31 PQ: 0 ANSI: 2
Jan 23 23:39:08 beaglexm2 kernel: [   26.204284] scsi 3:0:0:0: Direct-Access     HUAWEI   MMC Storage      2.31 PQ: 0 ANSI: 2
Jan 23 23:39:08 beaglexm2 kernel: [   26.254272] sr0: scsi-1 drive
Jan 23 23:39:08 beaglexm2 kernel: [   26.255218] sr 2:0:0:0: Attached scsi CD-ROM sr0
Jan 23 23:39:08 beaglexm2 kernel: [   26.256042] sr 2:0:0:0: Attached scsi generic sg0 type 5
Jan 23 23:39:08 beaglexm2 kernel: [   26.265930] sd 3:0:0:0: Attached scsi generic sg1 type 0
Jan 23 23:39:08 beaglexm2 kernel: [   26.276275] sd 3:0:0:0: [sda] Attached SCSI removable disk
Jan 23 23:39:09 beaglexm2 kernel: [   26.393798] smsc95xx 1-2.1:1.0: eth0: link up, 100Mbps, full-duplex, lpa 0x45E1
Jan 23 23:39:09 beaglexm2 ntpdate[543]: no servers can be used, exiting
Jan 23 23:39:09 beaglexm2 usb_modeswitch[402]: usb_modeswitch: adding device ID 12d1:14ac to driver option
Jan 23 23:39:09 beaglexm2 usb_modeswitch[304]: usb_modeswitch: adding device ID 12d1:14ac to driver option
Jan 23 23:39:10 beaglexm2 kernel: [   28.185485] init: failsafe main process (486) killed by TERM signal
Jan 23 23:39:12 beaglexm2 [conn-health]: Connection health conn-health.lock is created`
I think it would be optimalist to combine both and minify them server-side (and of course an appropriate Expires header, e.g. 1 year). 

A good rule of thumb is combine/minify while the combined asset size less than 25k (pre-gzip); once you reach that threshold, *then* split assets and try to use centralized stores. (the rationale for this is that iPhone cache is 25k [src](http://developer.yahoo.com/performance/rules.html))
Next : your pull request :)
In the middle of updating to 0.2, will try and make the expiry map to the mapping infrastructure. Hopefully that'll make things a bit easier.
Warum das?
Is this a typo? Shouldn't it be "Backlogs"?
is the bundle incompatible with Symfony 2.1 ?
I don’t remember when bundle checkouts were added **by default**? There is a bunch of functions in autoload/vcs_checkouts.vim that are able to do so, but you said I must not make them default.
Should the linux code use the TMPDIR environment variable in the same way as the windows code.
I tried to use that url but I'd got this "Refused to display document because display forbidden by X-Frame-Options." error and iframe did not load the page at all. Unfortunately I could not resolve the issue so decided to use techcrunch.com.
baz!
damn i forgot to revert these lines, idk if theyre correct ot not
Hmm, this also seems to break BC with 2.0.x. 

I got: 
Fatal error: Call to undefined method Symfony\Bundle\DoctrineBundle\Registry::getManager() in vendor/bundles/Liip/FunctionalTestBundle/Test/WebTestCase.php on line 154


T
How do you update your repo?
LGTM!!
functions?

wpa ()
{
	wpa_config="${wpa_config}\n\t${1#wpa-.*=}"
}

for i in proc/cmdline; do
	case $i in
		wpa-*)
			wpa $i
			;;
		*)
			echo "not handled"
			;;
	esac
done


On 2012-02-27 20:49, Kai Hendry wrote:
> agreed, though I had line width issues already editing the file and didn't want to make it even longer. :}
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Webconverger/Debian-Live-config/commit/d7867dcfa25c0be7dd7406502848a4bbe2905da4#commitcomment-1018252
>
o oo.   I built it !!! .  o  ooo

many thanks , Quarx2k
https://github.com/adrianlee/webplatform-framework/commit/5dbd073d040d929b2760a5053ad10fe0b01bdc05#commitcomment-932210
En vez de los if/else, se podría usar el template tag que hice hace rato.
Asi queda mas modular (la imagen por defecto queda en un lugar), y los templates quedan mas limpios y simples.
Now I see. I'm just visually separated the logical tokens, thus they can be parametrized in one of the next steps.

As for the Coding Standard:

    "The Symfony2 coding standards forces you to not add extra spaces before and after the concat operator."

This statement is false.

The written document (http://symfony.com/doc/2.0/contributing/code/standards.html) has the authority here, and it states clearly:

    "Add a single space around operators (==, &&, ...);"

No exception is mentioned for the concatenation operator, thus the rule is valid for it, too. And this is of course good so.

Zend, Doctrine, Drupal (excerpts and links above) use spaced-dot.

So, if you ask me to change this, you ask me to violate the Symfony2 coding standards (and the general php  coding standards).
Custom jQuery event
Like :D
Yes indeed I did. It should still be calling $this->_initialize(); Thank you for pointing that out.
It's best to place them back for the sake of open-sourcability
A little Markdown protip: if the linked text is the same as the reference text, you can just say `[contribute][]`.
This image should use the canonical URL: https://github.com/sferik/t/raw/master/cli-bird.png
Right, but the task of Y.Color.toRGB('#f00')  requires a hop through isString(), wrapping as an object, a hop through _convertTo(), isArray(), _fromHexToRGB(), and wrapping up as an Array(), then join() ing.

That's alot of overhead for a low-level utility method.  Ideally the call stack would something like toRGB(str) -> isHex(str) -> hexToRGB(str).

The isType() tests will probably just wrap up the regexes, so it seems fine to include them in 'color'.
Maybe we should call error handler and return here?
Please remove this header from the files. You can add Quanbit to the top-level contributors file instead.
yes, it is, :-) will change
this diff looks weird, the only change is this if statement
I don't know the background for naming the routees with real names instead of using anon name. Do you know @rkuhn?
Yes it does, "forward" takes an implicit ActorContext.
Evernote was unable to submit your note for the following reason:
The storage limit for this account has been reached.

Original message information:
From: Ryan LeCompte <notifications@github.com>
Delivered to: thanhbv.fa84f@m.evernote.com
All recipients: akka/akka <akka@noreply.github.com>; giabao <giabao@sandinh.net>; 
Subject: Re: [akka] Moderate restructuring of NettyTransport (#982)
Sent: Fri Dec 21 11:52:29 PST 2012

To prevent excessive emails, you may not receive another error reply
for the next 360 minutes.
so far ClusterActorRefProvider extends RemoteActorRefProvider
I would rename it:
hazard_curves_poissonian

in this way it's more explicit that assumes poissonian tom. In the future we will have other hazard curves calculator that do not assume poissonian tom.
https://raw.github.com/okfn/recline/v0.5/dist/recline.js ;-)
The problem is that `check_access()` either returns `True` or raises `NotAuthorized`, whereas a logic function has to return a dict `{'success': True}` or `{'success': False, msg: msg}`. I guess I could wrap check_access and catch the NotAuthorized
I know so very little about extensions, but I thought I'd ask if this initialize() is supposed to return anything, or does it just use an API to do what it needs to do?
I advocated for that solution at one point, but you talked me out of it. I'll take a look at it when I get there
also, this change seems to be irrelevant to the branch, no?
This changes behaviour unfortunately.  I think you can just drop the outer if() and put it on the last else() block instead?
GL_NV_vdpau_interop does not expose a progressive frame, only fields.
I don't think we are still using this
i'm a little unsure of this change, perhaps this should be the "winner" in the race to set the value
The authentication code is shared by many commands, you should turn it into a function
I thinks so, too. Three braces (opening and closing) are better.
You are rigth, my mistake. Don't know why/how but in my previous tests it returned unmodified Image. I was only able to trigger exception by calling self.raise_exception() unconditionally (probably fault of mess in my testing env). Now it works as expected :)
?????? 设置为True的话跟原来的没去别吧...?
@CodaFi  what do you propose completion-block-wise? One for every push/pop method?
"… and where selected triggers …" needs a bit of rephrasing to make sense. Maybe something like:

> … selected upon mouse up. Setting selected triggers a …
This object is never removed as an observer.
Shouldn't you stop the check handle in that case?
This is of course very platform independent.
Tu peux faire le set dans le new.
ко всем новым методам с нетривиальными названиями хочется doxygen-комментарии
написал
объявить в месте использования
I think that without permit it will raise an exception

Rafael Mendonça França
On Aug 4, 2012 7:53 AM, "José Valim" <
reply@reply.github.com>
wrote:

> > @@ -85,5 +85,14 @@ def destroy
> >        format.json { head :no_content }
> >      end
> >    end
> > +
> > +  private
> > +
> > +    # Use this method to whitelist the permissible parameters. Example:
> > +    # params.require(:person).permit(:name, :age)
> > +    # Also, you can specialize this method with per-user checking of
> permissible attributes.
> > +    def <%= "#{singular_table_name}_params" %>
> > +      params.require(<%= ":#{singular_table_name}" %>).permit(<%=
> attributes.map {|a| ":#{a.name}" }.sort.join(', ') %>)
>
> I would leave it as `params.require(:user).permit()`, otherwise the
> default will be to allow everything from then on.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rails/rails/pull/7251/files#r1307224
>
What do you think about `id = :none`? Maybe it would be more logical?

And, maybe parameter name `id` is not very intuitive at all? Considering that it could be different type of conditions, not only primary id.
Btw, you probably don't need to set the variable, you can delegate to `#{key}_iteration.index`, right?
shallow indent
Ok, I will try to use alias_method_chain, but I don't see any disadvantages in my code vs alias_method_chain
Possibly - can you think of a use case?
```ruby
wrapper_tag = options.delete(:wrapper_tag) { :p }
```
What's the git history on it? Just a forgotten method?
There is never any deps in rebar.....
`debugString` is a nice name, but inside the compiler it's used for something else: https://github.com/scalamacros/kepler/blob/fccee33223468f2887951e8c27606106d37363a6/src/reflect/scala/reflect/internal/TypeDebugging.scala#L70
I certainly think so, that's why I removed them. I am against defaults without strong cause. A private method with a default which is used one time is pointless; just give the argument. A private method with a default which is used ZERO times exceeds even that. All the default tells you is that the author imagined in some alternate universe he would give that argument a lot. He was wrong about this universe.
I mean, use the logic in NonFatal to avoid catching the exceptions you should never be catching.
This can be removed.  Perhaps it should be removed in the `numpy.histogramdd` code as well.
apply expand_func to get rid of the gammas
An explanatory docstring or inline comments can be arbitrarily formatted (for the most part) but when reading code, I prefer a standard. And even though it may seem more readable to you it may not be to others. Beyond that, however, the code coverage issue (that Aaron mentioned) is more important.

We don't always follow PEP8: there should be a blank line before the last triple quote of a docstring and there shouldn't be space added inside brackets, like [ this, you, see ]. The binary operator suggestion is a little ambiguous so we often write `x*y + 3*y` instead of `x * y + 3 * y` (which is the sort of suggestion given in the PEP8 examples); in this case, however, PEP8 does say "use your own judgement" and it only said to add space around the 'lower priority operators" which the example I gave first does.
I mean function.py.
works only with tuple/list
wheather->whether
deside->decide
needed->is needed.
Do you think changing this to `return fuzzy_and(a.is_commutative for a in self.args if isinstance(a, Expr))` is the right way to go?
没看懂，是把if和else放在一行？
"If there is no return value, the application will exit......"

Could be missinterpreted, if someone is using `return;`
Also not particularly useful.
Let's add a function in the abstract generator and rename the one that is already existing:
findMandatoryConfigurationProperty and findOptionnalConfigurationProperty.

I try to avoid as much as possible try catch and to have them in only one place for a better readability
It may be better to pass in a pointer to the linked solver rather than the solve type?
Am a better fan of git:// or ssh:// protocol, given the performance, and you don't have to deal with cert matters. Can I have some links (tried) to the actual reason why Git now recommends HTTPs by default?
I do this too sometimes without realizing it, but there's no reason not to use consistent quotes `"` here.
"pushArg" method allow users to add graphicsMagick arguments that are not currently supported by node-gm. So users don't have to wait the node-gm support for an argument added by a new graphicsMagick release. They can use "pushArg" method and wait for an official support.
`Server` is not a term used anywhere in Ember Data. This should be `AdapterValidationError` or something.
I don't know why people keep doing this. It will break the layout of the page. Please add the line back in.
Why is it volatile?
one_mb_string is same as one_kb string.
Make one method which gets a parameter.
Then probably best to refactor it into a separate method that is named as such.
is a wrapper around the :dbcommand:`replSetGetStatus`
No, I tried that. We already have a .template class somewhere that hides things, I think for markup templates cloned by JS.
could it be : write_geometry(filepath, coords, faces, create_stamp=None):
to avoid the burden of manual stamp setting? it would default to "created by %s on %s" % (os.getlogin(), time.ctime()) as in the test
We need to wrap the file delete stuff here in  `converge_by` blocks. Probably one `converge_by` block for each delete would be best since it's the most informative.
As per nickv, leaving as is.
Needs a `.` at the end of the sentence.
@EXreaction 
Shouldn't we change `href="#"` to `href="{U_VIEW_ALL_NOTIFICATIONS}"` ? That way, it will act as a fallback for users with javascript disabled to be able to use it as the link to see all notifications. (This change would also need to be done in subsilver2.)
What about 3.0.x? You should probably change this to 3.x.
I believe you already have the data in php, and in such case you should process it as much as possible in php before asking the database to do more work.
The link no longer points to the "official download page", so you need to change this text.
这个还真得一样。
There is at least one #endif left.
This is private or smth?
Never mind, I get it. The code was originally designed to allow overriding of the ".json" files which is why it uses the indexed array.
Ok, thanks for the clarification. I just pushed a commit that moves it to the known bugs section.
再帰的に削除は階層の深いものから消さないと消えないような気がします。

PHP5.2以上なら `RecursiveIteratorIterator` を使う方法→ [ディレクトリを再帰的に削除する方法のメモ](http://qiita.com/items/b5445ff6fbc21e8d883a) が10行くらいでかけますよ。
missing is - the answer is to add
Agreed. This sentence makes no sense.
Do we need `oa-core`? I guess this dependency could be omitted too.
I don't like any of the names there to be honest. When I read "fragments" I'd expect a list of things, which it isn't. I don't disagree with it being a kind of state, but that state is only used when there are fragments, otherwise there is no state. And "initializing", "receiving" and "finishing" sounds clumsy. Sounds more like you mean "first" fragment, "last" fragment and whatever for the middle state.
The added `\n` is unnecessary, as this already puts in a newline.
It may be better to store these as a list in a message property in the  mule message rather than using the `RestfulHttpRequest`, as it's not really design to transport this sort of data.
`( {` => `({`
One day I'll learn.....
Some mobile browsers that still have usage don't have getBoundingClientRect(). We need to feature test that. I know it's not part of jQuery's official browser compat statement, but it needs to happen.
`function(){};` => `function() {};`
The parameter is passed by reference and hold the value how lany args have been replaced. Since it is not read after the call it is not necessary..
Ok, problem here. Seeding should be allowed to be contextual. This has recently become very necessary in event.js.
No, this should be size_t.
Should Expectation subclass Label or Filter?
I suspect this method and the slugify one really belong somewhere in mopidy.utils with their own tests etc.
"string" is a Python module, so you should pick a different argument name here. I tend to use "s" or "text".
I folded the advanced_installation stuff into the hacking howto because it was just pointing to other things anyhow.
where is `self.supported_properties` set?
This test is doing too much stuff, it makes it really unclear what the `get_properties` method actually returns and what this is actually testing.
The current getACL is here: https://github.com/owncloud/apps/blob/master/contacts/lib/sabre/card.php#L62
What would need to change?
Maybe store reply at the top and log it too, just for completeness?
I was expecting this to publish to `outbound`, not sure if that's correct. It doesn't make a difference for the tests but it might throw off people trying to understand the Middleware stuff by reading the source & testcases.
Já si to od začátku představoval tak, že objekt uživatele bude obsahovat všechno až na velké řetězce (submity), které budou uloženy jako zvláštní dokumenty a bude se na ně jen odkazovat. Tak by to IMHO bylo právě dost rychlé (přehazovat si megabajtové objekty jen pro přihlášení nezní moc prakticky) a právě dost pohodlné (však zvaž, při jakých příležitostech saháš na submity – na dva zvláštní HTTP požadavky „dej mi submit“ a „ulož mi submit“).
Actually, I'm confused as to how this pairs with the above statement.
it stripes html tags
Why do we need `--post_id`? There's already `$args[0]` and WP_Query already has a `'p'` parameter.
This use of the framework is "cute" but I think unsupporting since with the two assignment statements in lines 266/267, we guarantee that the version making use of the framework definitely requires more complexity. Since we must incur the cost of 2 assignment statements in any case, we may as well just use those.
create a property name validation method which ensures the input is in the proper slug format. this can be done in lue of URL encoding.
Please add an empty line above the class definition.
I think, only simply overriding the method is not enough. I tried to put some example of use since i think the people mostly want to log the time.

The reason why i started this pull was that i needed some benchmark testing for ParallelComputer into our wiki. I am missing such feature in the JUnit.
So i do not want to use try-finally in our tests for such benchmark tests.
This Stopwatch would help others as well.
Where is this ClassCastException coming from?
We should add a comment here calling out what this means, since it's easy to miss that this has effects outside of the color editor code.  In particular, this means Editor will close the inline automatically anytime startBookmark would get destroyed (since CodeMirror's internal bookmark that tracks the inline widget will be located at the same pos in the text).
I think this should be moved up in scope to the initSidebarListeners closure. This sidebar_resizer div is created for every mousemove.
Can you add a TODO with a link to the bug # to track when this can be re-enabled?
Since checked is falsy by default, maybe this should be set to true.
Are these error messages localized in Chrome and/or opera? If so, we can't rely on matching the text like this.
Indent of assignment
Sure,  no problem, will fix that. 

I actually copy/pasted from one of the tests above and all the existing ones have the quotes inverted. Do you want me to change those as a bonus, or should we let them be for now?
If an existing filename or folder name has these characters, then we won't be encoding them after url insertion.
Unused ``COLOR_EDITOR_COLOR_INPUT_TIP``
With who can I confirm this further? It works on EC2/cloud9infra so I'm not sure what else to check.
they are for test env in gemfile, so run `rake`, if it checks out you don't need them
See those examples:

http://mongoengine.org/docs/v0.4/guide/defining-documents.html#field-arguments
AFAIK, this is very slow in comparison to adding items to an array and tight-looping through it. No need to run the `hasOwnProperty` in that case.
See https://github.com/mozilla/butter/pull/1147/files#L2R93
chera be tag image background dadi !!!
ya hatta arzo ertefa !!!!!
nemikhad dige
faghat ye display block kafiye
darzemn tagi ke displayesh inline nabayad kollan hertefa dashte bashe
remove the debug test log
就目前来讲，这样类似的框架还是不少的，这里只列出了用得多的一部分。
Same here. No use of Config in whole file. I can see it in another files too. Can you consider again all instances?
You are right, this directory is already in katello-common, which is required by katello-headpin. This would result in conflict. I will remove it from katello-headpin.
Yeah, that's surely not the most common scenario :wink:
Here's an important gotcha that's easy to miss (I also noticed the same thing is present in @astrofrog's ``convolve.py`` - I'll go ahead and fix that in master)... there has to be a space both before and after the ``:``.  That is, this should be ``array : `numpy.ndarray` ``, instead of ``array: `numpy.ndarray` ``.

The same holds for all the rest of the parameters and other parameters, both here and in ``make_kernel.py``
This section is partially redundant with the previous one since units are always specified as a tuple now. The last example might be useful to keep and copy up though.
This file doesn't seem to be included in the docs right now - perhaps add it to ``index.rst`` underneath ``configs``?
This is minor, but perhaps the name should be changed to something like `find_equivalent_units`? "get" to me means something in the getter/setter pattern, and this is more about finding other units rather than getting an attribute of this particular object (if I understand correctly).
I don't see the need for this function.  `x = Unit(unit)` should be sufficient.  Or am I missing something?
@mdboom @astrofrog - should we put this in the coding standards? (Use of ``@property.setter`` instead of the way this was originally done)?
Needed, no. I have a habit of commenting out lines or chunks of code when I make changes rather than deleting them until I know for sure I don't want them. It's a code evolution thing. If things work, they can be removed.
This is the only occurrence of camel case outside of class names in Haraka. Any valid reason it shouldn't be message_stream?
"const CBlockIndex *pindex" means "declare *pindex as a const CBlockIndex", or more commonly "declare pindex as a pointer to a const CBlockIndex". This means that the pointer can change, but it can only point to constant objects. Line 1426 makes it point to a constant object.
Why not always trigger an error?
a protected method _setupFilesystem() etc?
Sure, I'll do that shortly.
This doesn't work. You can also write:

```php
<?php

namespace Doctrine\Common\Annotations;

use Doctrine\Common as CommonNS;

class Parser extends CommonNS\ParentClass {}

```

To resolve class names you need all use statements first and then you must resolve the FQN with the help of PHPs name resolution rules.
http://de.php.net/manual/en/language.namespaces.rules.php
Why not simplify this IF?

```php
return ! ($lifetime !== 0 && $lifetime < time());
```
good idea, thanks. :) I'll try it out when I finish work. maybe what we need is some kind of define to put the tests in to aggressive mode time help find the weird edge cases and limits without causing massive headaches on the day to day testing side of things. well, at least when we have more tests passing.
Should we also add `"http-server": "*"`?
Hmm, I'm not sure what's going on, but it looks like a bug elsewhere in IPython's handling of docstrings.  I suggest you ignore the issue for now and just make sure they're clean reST and read OK in your editor.  I'll look into what we may be doing wrong with formatting.
Should there be a `py32` here?
i'll do it next week.
Indeed. Changed.
very nice abstraction / generalization. I am happy with this modification.
I thought this page was recently added to bedrock. Why the removal in an unrelated PR?
EXCESSIVE SPACE ZOMG
maybe we should have the progress bar show the percent of the goal completed rather than the number of tweets that have replies, now that we've made that change. (currently the same because the goal is 100, but would have a % sign after it)
`assertNull()`
You're right, I should remove this.
Ah, how annoying can PHPStorm's auto-completion be...
you can remove the description for the param as it does not add any value here
if you want to pass a configuration as argument to ``processConfiguration`` ? yes. But it has nothing to do in the upgrade file as it was already true in 2.0

And the mention about dumpable config has nothing to do there either. Dumping the config is a new feature. So it is not a BC breaking change.
I would use directly ``foreach(twig_ensure_traversable($formVar) as $nestedVar)``
Added a line then deleted so no change
self.settings
Check the job for proper URLs to use.
The only [guideline we've agreed to as a team](https://github.com/thoughtbot/guides/tree/master/best-practices) regarding this is:

> Prefer small methods. One line is best.

There's some room for interpretation there.

Messing around with another version of this action in order to try to see in the `create` method what is really going on, and hide the implementation details in private methods:

```ruby
class YammerUserInvitationsController < ApplicationController
  def create
    Invitation.create(event: event, invitee: invitee, sender: current_user)
    redirect_to event, flash: flash_value
  end

  private

  def event
    @event ||= Event.find(event_id)
  end

  def event_id
    params[:invitation][:event_id]
  end

  def invitee
    YammerUser.new(auth).find_or_create
  end

  def auth
    {
      access_token: event.owner.access_token,
      yammer_staging: event.owner.yammer_staging?,
      yammer_user_id: invitee_id
    }
  end

  def invitee_id
    params[:invitation][:invitee_attributes][:yammer_user_id]
  end

  def flash_value
    if invitation.valid?
      {}
    else
      { error: invitation.errors.full_messages.last }
    end
  end
end
```
Dit bestand graag verplaatsen naar SuperPC/Models/Repositories
https://github.com/ckolivas/cgminer/pull/176/files#L1L333
I do it all the time with `let`, but I do stick in some spaces, as in `let(:options) { {} }`.  At least they're not fingernail clippings!  :-)
"an" apartment is pretty generic, and implicitly assumes that there's only 1 apartment. I'd do something like "I visit the first apartment on the page" or something.
yeah, I think so. I'm considering cast 64bit long to ACE_INT32 as you mentioned in the email as we only support longs with 2^31 -1. then we don't need these htonll and ntohll functions. but it looks hard to do the same thing in the java codes ?
Yes. It no longer wraps for me.
Let's just delete this.
Well, the div is being used for controlling the automatic vertical-alignment of the content inside the dialog.
Is the best way to do this kind of, "I don't know how much content, but i want them vertical aligned", without using table, and table-cell stuff.
nit: add a line break (that's free i promise!)
Right now pageHideBySwipe is a boolean and there are only 2 choices
But in the future there might be other ways of moving to landing page - and Evme should not be aware of how to differentiate.
That's why I think the logic should be in the bridge - before it gets to Evme itself.
I don't like origins hardcoded could be 

document.location.protocol + '//homescreen.' +
        document.location.host.replace(/(^[\w\d]+\.)?([\w\d]+\.[a-z]+)/, '$2');
are you meaning that we should return directly to the Contact list screen one all the FB Info has been removed?
If you are returning in this block, the next block doesn't have to be `else if`
This worry me a bit but it also seems a good idea. so r+.
I'm making myself the same exact question :) Thanks!
changed to 'left' in latest visuals ;)
you don't use "now" in this block, did you intend to replace the use of new Date() below?  (It seems like using new Date() every time is more correct, so this could be removed.)
It looks we also need the pending status and icon for pending message. I might add the status later, could UX provide the pending icon at first? Or you prefer to add and pending layout by yourself :)
This should be `keyboard`.
Can we add something like

```
    document.addEventListener('mozvisibilitychange', function visibility(e) {
      if (document.mozHidden) {
        activityRequest.postError('canceled');
      }
    });
```

for the sake of completeness?
I think we'll need to bump the revision here, to `simContacts-imported3` (all seven strings).
I don't like relying on exception handling to validate the click.  How about e.target.classList.contains('wallpaper') as a way to test that the click was valid.  If you do that at the top of this function, I'd be happier with it.
OK, the idea here is when an user is on the borders of the screen or transitioning between pages the drag&drop should be disabled. The problem here is what when pages are transitioning the mousemove event is fired so the checkLimits function is executed and sets the isDisabledDrop variable to false because while the transition the mousemove provides coordinates of the middle of the screen. So I added that if the component is transitioning the function checkLimits sets isDisabledDrop to false too. OK if transitioning is true always isDisabledDrop is true too
I'm not sure you can rely on this regex because there is no defined order if the server returns multiple elements inside the brackets here.

You might look at using a slightly modified version of the regex [here](https://github.com/Contatta/node-imap/blob/f68bf7e22349ebd3ececefce15508fd8046f8326/lib/imap.js#L560) and use it to replace the one on [line 532](https://github.com/Contatta/node-imap/blob/f68bf7e22349ebd3ececefce15508fd8046f8326/lib/imap.js#L532) to combine the regexes and still have everything work right.
no need to call is.close() and br.close(), it is in finally block
I see now. I have a change which corrects `#archive_link`s behavior on my branch but it needs pengwynn/faraday_middleware#51. (If that is a problem there are other ways to implement it...)
I hear what you are saying but it doesn't quite make sense to me. Redirection is as fundamental a part of HTTP as the methods or the other status codes. We don't spend time hiding the HTTP methods from clients any more, and i think we should treat redirects the same. I think the best thing to do is to accept that redirects happen. Remember that there is no guarantee that the nodeload URIs won't start redirecting at some point.

I do see the benefits of adding a new method that returns the actually archive as an `IO`. That actually saves the client work.
how about RbConfig instead of Config
这里改成 http://rs.qbox.me ，80端口现在已经支持了的，10100 端口有些网络防火墙设置会有问题
But it's not a method. It's a property :)! Something like Thread.daemon.

For example you don't have `get_uptime` but just `uptime`.
we should match the text here with the original checkout naming of the branch, so the connection is more obvious (otherwise this looks like they're supposed to be different, which they aren't)
-e はバッククォート無し
Ah!  So I guess boxing of bytes is "free", as for booleans.  I actually didn't know this, but in retrospect it makes perfect sense.

Perhaps I should then rescind this change entirely from the pull request?  I definitely think Max and Min should be specialized on primitives (which are a salient use case) but if Byte is not involved, then it's no longer relevant to the other changes in this request.  Depends how important it is to keep pull requests "on topic".
not used so deleted
That's a lot of ternary.
The citizen class is deprecated and should no longer be used anywhere.  Everything that was using it should now be targeting the mainstream class.
`installs them`
I was talking of the var_dump only
shouldn't you put the reason in the rule ?
you could simplify the variable name by calling it ``$channel``. We know it is a pear one as this class is about pear.
This could use a little formatting love :love_hotel:
detect-pkt-data.c: In function ‘DetectPktDataRegister’:
detect-pkt-data.c:59:51: error: assignment from incompatible pointer type [-Werror]

type is void.
should server_msg be freed here?
aren't you missing an `import markdown` somewhere?  Even better would be `from markdown import markdown` if that's the only function we'll need.
This sounds convoluted to a newcomer. I vote for leaving this how it was before, and separately explaining required keys in the following paragraph (line 83 ish)
Converting them to functions just sounds like a workaround ES.next limitation :(
I have in mind to convert l10n files access to asynchronous access,
We will have to delay addon main module evaluation before l10n files are loaded.
(We have to do that, as require("l10n").get is synchronous.)
Something like this in addon/runner.js:

    require("api-utils/l10n/core").load().then(function () {
      // load main
      ...
      let program = load(loader, loader.main).exports;
      ...
    });

But then, the unecessary `init` method in l10n will become this `load` method and be asynchronous.
So that we won't be able to set exports.locale during module loading
Do you have any idea how to define an attribute in ES.next that can't be defined during module load?
Is this a usecase where we have to end up with functions?
actually I reread that test I linked to and it looks fine.
@seanmonstar - Once the error screen is displayed, it is similar to the "blue screen of death" and doesn't go away until the user reloads the page.  So we don't really need this part here.
Our spec suggests complete_transition will return with `{ success: boolean }`. Perhaps that should be checked in `network.js`, and trigger the error callback if success is false?
This module has no tests.
Ah ok. So one other idea: could we use that target to enable the SDK if not done yet? That would be nice so we could make it a single command and wouldn't have to go into the addons sdk folder first to run source. I would even be happy if the SDK would only be enabled in the Ant sub shell.
@ttaubert - would you mind checking the code if it's getting the group title the correct way?
Pure laziness. It was here before I created the bugzilla app, and I had designs on turning the bugzilla app into a reusable django-bugzilla kinda thing. But I may move it anyway. Might be able to be useful to others...
Wouldn't recur be more robust here?
foreach ($this->getValidationFailures() as $failure)

becomes 

    foreach ($failures as $failure)

and fixed CS, too.
wich/which
I don't blame you, this is within the Puppet module where we explicitly do want to halt execution because we have a hard dependency on Facter 2.0 which has not been met.
Based on the stubbed time and these ranges I don't see how this test is actually a different condition from the one before it.
`YAML` will be defined if Psych is also used. Why are you conditionally checking that here and not inside the method?
This is all I do:  

```viml
let g:vroom_spec_command = 'zeus rspec '

```

If you want to get clever you can do:

```viml
let g:vroom_spec_command = '`[ -e .zeus.sock ] && echo zeus` rspec '

```

That'll only run zeus if .zeus.sock is found.


On Thursday, December 20, 2012 at 2:59 PM, Carl Woodward wrote:

> In autoload/vroom.vim:
> > @@ -233,6 +241,12 @@ function s:IsUsingBinstubs() > endif > endfunction > > +function s:IsUsingZeus() > + if g:vroom_use_zeus  
> I needed to change the way the bundler interaction works because I would want it to fail silently on zeus. So I started doing that but I had issues with it changing the overall flow of vroom. I'm happy to do that but I think that would become a much bigger request. I might be getting it totally wrong though, would you be able to put together a version that works the way you are thinking?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/skalnik/vim-vroom/pull/28/files#r2483737).  
>  
>  
>
Do I understand correctly that you mean that `xdescribe` should be something like:

```javascript
context.xdescribe = function(title, fn){
  var suite = Suite.create(suites[0], title)

  suite.on('test', function(test) { test.pending = true });

  suites.unshift(suite);
  fn();
  suites.shift();
};
```

That would definitely be better than the current.

Perhaps even something like:

```javascript
context.xdescribe = function(title, fn){
  context.on('test', setTestPending);

  context.describe(title, fn);

  context.off('test', setTestPending);

  function setTestPending(test) { test.pending = true }
};
```

Now __THAT__ would be nice :).

Should I try to go for one of those solutions?
I think, we will change `clone` arguments someday, but now I will split `url` in `_download_tarball`.
Again, shouldn't this be typehinted?
I don't now why, but there is a conflict here. 

`Cannot use DateTime as DateTime because the name is already in use in Zend/Form/Element/DateTimeSelect.php on line 13`

This `use DateTime as DateTimePhp;` worked for me.
Actually, I can answer my own question here: ignore. It's clear there's some hierarchy, due to the ability to add localized translations for the various booleans.
Remove first \
function takes no param
Ok, but I think we should be consistent so let move it to api/developerList.feature. What do you think?
Do you have a reference which explains this suggested approach?
Was there a reason to go with this approach of returning early when History isn't supported, as opposed to only making the ajax request if History is supported?
@seandowney @svizion thanks guys. I'll try that later and see if that fixes the issue.
Hm... I forgot about PSR-2.
You're right... this change request is invalid then. It's still one missing... =)
I run the command:

    doctrine:generate:entities

and generated code is correct:


        /**
         * Constructor
         */
        public function __construct()
        {
            $this->groups = new \Doctrine\Common\Collections\ArrayCollection();
        }

I can not find any problem with indentation. Can you explain it?
Your right. The problem here is that "$documentAnnot->nodeType = 'nt:unstructured'", so it seems impossible to tell if the value has been explicitly set in the Annotation.
Since `"" != nil` I think that `String.first("")` should return `""` and `String.last` as well.
Yeah, I had a feeling something like this might be happening. By reverting to the previous format, do you mean just following the natural order of those files as per exception.ex?
2 spaces, one hash
logging_format :-p
Sorry, I was aiming for EAP6, I'll fix those.
Ah! I need to re-merge master in this. I fixed it when you commented on this the first time.
we should  make this locator a variable
Perhaps add some markup for the title if there is one?
Oh! I see. Yes, I could probably fix that in a bit.
I get that you dont have to pass in the kwarg name, especially if you have 1 kwarg, but i just dont like the look of this. Lets poll the guys to see what they like best and ill go w/ majority rules. not to be confused with o'doyle rules.
@jcredding No good reason.  It should be on the data class since that is where the data lives.  I'll move it back.  Good catch.
I tend to keep my test .liq files in src/ so it's giving me quite a lot of garbage in git status. But if you think that this is risky I can remove this line...
I'm still uncomfortable with that function, I don't see why you're clearing and setting breaks like this on tmp. Could you comment in the source to indicate what's the intended mode of operation?
well we should re-label them to reflect those issue. This one below should be the "when scheme is not Basic" test, and the other one should be re-labeled to reflect the multple-part issue
Vim's ftplugin system doesn't load filetype plugin named "foo.bar"(ftplugin/foo.bar.vim).
Why this includes "foo.bar"?
Can we make it `', '.join(...` instead?
This can just be `randFromArray(PROBLEMS)` then replace `PROBLEMS[PROBLEM]` with just `PROBLEM`.
Agreed. That's a better name, done.
SP Call interval should be logged right after the SP is executed. Now it's logged after the result set transformation, which can add significant time.
The main issue at this stage is that a user can change the code while the block is not updated. 

Exposing the code as a delegate to the block codestring sounds like the more elegant solution. Allowing the user to change the code does not really make sense in this class.
чё это? у абстрактного класса странно делать поле, тем более публичное... его нельзя переопределить. смотрится очень странно.
Yeah, it did. Fixed now, though. ;-)
and this would change to details_page.view_source_code.click()
If we're switching to crypto hashes, why not sha512?
Fixed them up all across the code base.
Actually, this is not true. When the browser passes in overwrite=false, this will come in as a string "false". "false" || true will be evaluated to "false" and once casted will be false.
After removing code that unnecessarily creates tenants, I'm not sure there is a good way to consolidate enough of this into a method anymore. I could toggle the setup different based on parameters (e.g., specify which user should be public, if there should be a private tenant, etc...), but IMO that might just end up making the tests harder to follow if one fails.
I wasn't aware of this constructor, looks better now :)
Yahiii! :)
Awesome! I'll remove it right away.
如果是用作分组，我也考虑过用 `data-group`，只是 `3-1` 这样区分每一个元素可能没什么必要，因为需要额外处理。
Probably why the command isnt working? when you /help it
weg gehaald. weet ook niet waarom ik // had staan
Yep. It's quite annoying to have tens of these when trying to read this lengthy diff anyway. :)
That's why there are almost no static calls in the CodeIgniter code - we need to be able to extend classes for similar purposes. Either way - I don't find comments in the code saying that something must be done in a particular way just so that Unit tests don't break. It might not be an actual functional dependance, but it does create a feeling that the code in question depends on the tests.

People are way too familiar with the `get_instance()` function, so we don't need to worry about somebody replacing it.
хм, ячейка может замениться на саму себя, в этом случае считается, что замены не было вовсе.
Выводим днк и тот же элемент в копии
https://www.dropbox.com/s/ydrizf4aozd209l/%D0%92%D1%8B%D0%B4%D0%B5%D0%BB%D0%B5%D0%BD%D0%B8%D0%B5_006.png
это условие должно срабатывать когда элементы не равны (значит была замена) но и условие срабатывает и замены никакой не произошло :(
Программист может быть далёк от генетики, но программистом от этого быть не перестаёт.
@Lert NSNumber вы хотели сказать.
Спасибо, буду знать. Пофиксил https://github.com/volt0/osx-project-1/commit/c2a940c6c5f69bf36fd46f2881cda8c3a9436a89
Лучше проверять на передаваемое значение, а то получается, что методу можно "скормить" как отрицательное значение (пускай ничего и не будет), так и свыше 100 (вот тут уже будет работать некорректно)
This should call stop_error(), because "stop 1" is compiler dependent. If some compilers don't support returning non zero error codes,
the user can always call some C routine in stop_error() to get the desired behavior.
Then Em-synchrony must be putting each event on a separate fiber. Pretty sure it's easy to limit it to one fiber question will be what the performance impact is but I can't see a way around it otherwise we're still racy.
Please add a simple docstring to this function.
Unfortunately interfaces don't allow operator overloads as extension methods. I could just delete this line or change it to:

    Assert.True(branch2.Equals(branch));

Which would you prefer?
Nice style,  I was also trying to mimc the wording of the API docs (did you help write those?)
Gotta be careful with this. [Reachability isReachableViaWiFi] calls SCNetworkReachabilityGetFlags, which can block while it checks network status and possibly even initiates network traffic.
keep verbose=True by default to avoid changing the current behavior of the code
Please add "try catch" whenever possible to handle unexpected errors resulting from parsing errors. Also, make sure that whatever happens within request handling doesn't cause the server to crash.
Hi Eshan,

We don't allow wildcard imports, per OpenMRS standards.

Explicitly listing them lets IDEs do better refactoring, code analysis, etc.

-Darius (by phone)
On Oct 3, 2012 2:49 AM, "Eshan Sudharaka" <notifications@github.com> wrote:

> In api/src/main/java/org/openmrs/api/impl/UserServiceImpl.java:
>
> > @@ -13,13 +13,7 @@
> >   */
> >  package org.openmrs.api.impl;
> >
> > -import java.util.ArrayList;
> > -import java.util.Collection;
> > -import java.util.Date;
> > -import java.util.HashSet;
> > -import java.util.List;
> > -import java.util.Set;
> > -import java.util.Vector;
> > +import java.util.*;
>
> This is done intentionally. It looks nice when we have one import. (I am
> not sure this with openmrs coding standards)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openmrs/openmrs-core/pull/41/files#r1746860>.
>
>
Looks like the blocked bug ID is hard coded.
There should be a blank line between the previous line and a function definition.
made comment in another place I think, but I think it's worth keeping 0.3 and pushing that to hackage first.
This felt a little odd to me but maybe there is a better way? Maybe it can be cleaned up later if/when a Vector type is implemented.
This whole block might do better within a haml `:markdown` block, or even just as a markdown file. Just my 2¢
Multiverse should definitely not be added, we use ScalaSTM.