labofsahil/github-event-dataset-2012 huggingface dataset:
this ensures that even in branches from master it will consider the installed version as "dev-master", which is necessary f.e. for cyclic dependencies
Seeing that `$htmlPattern` is public, I don’t really see why `getNonDelimitedPattern` wouldn’t be.
It's kind of unique to see two "lines" of code on the same line like this. Not necessarily bad, but somewhat unique.
yes, it will be removed.
Sure, but it looks nicer! ;) I'll remove it now..
The documentation you cited above suggests that "The `Library` directory should be completely ignored when using external version control". Why are these files in `Library` being included?
Simple, I double space after `:`
That should be divided by `anims`, not `times`.
Don't you think it deserves a `this.updateStatusBar()` to avoid duplication? :)
This function could be a `innerHTML` with escaped user input text... You do not need to do use DOM API like this :(
If this is just for debugging, please remove it (and delete the entire onerror handler).

If you intend to keep it, convert from console.log to console.warn()
Do you still need `mozApp`?
(non-blocking comment)

It would be better if the font size is dealt entirely in CSS with media query rules. Specify inline style is acceptable on root element though (but only on root element!)
This is resolved, thanks.
I would be API to rename it in a different pull request. One that removes all the GestureDetector duplications.
Yeah was going to do a copywriting/l10n pass later on.
`OnCallHandler.end()` should be enough no?
kill empty teardown
yep excellent point, this code is from another project of mine. I should have really used Object.create(null) in the first place :0
What's the purpose of this function

1. reset the data in `AlarmEditView`
2. return a default alarm data object

pick one. Don't do both. If you do 2 think about where is the right place to put it.
Hmm. I'm torn on using list as a variable name here, I usually try to avoid Python reserved words -- though list might not technically be one and I know Python knows what to do here, so we can probably leave it as is.
It's because @sergiofontes wants this in the link :anguished: look [here](https://www.dropbox.com/s/derro396k30nxu9/AI%20-%20Central%20de%20Ajuda.txt?m)
You just need do ``` @categories.flatten! ```
`True` is python. You want `true`.
直した :exclamation:
c&p alert :wink: .. please change 'touchMouseDown' to 'touchMouseUp'
This should return Pipe.

Also, can you take a type [N: Numeric] instead of Double, so you can do Int, Long, Double?
Elaborate here and elsewhere where `parameters` is an arg.
https://github.com/AppScale/appscale/issues/109
Yes it should be merged since query support is more important that transactions. The old implementation breaks AppScale over time as more data is stored.
This import xml.etree.ElementTree as ET

does it add a dependency to Freeseer or is import xml part of python?
See my comments in #1096.
i see, will fix in a couple of minutes!
The latest commits have moved all the merge logic back to the step. Now the step will only pass a set of sourcestamps to the scheduler. The scheduler creates a new sourcestampset and buildset. Unfortunately this changed a lot of tests too as the interfaces between the step and scheduler changed completely.
not a reference *implementation*
@alindeman Perhaps it's time we read @jstorimer's Ruby sockets book?
On Tue, Nov 27, 2012 at 1:51 PM, Victor Julien <notifications@github.com>wrote:

> In src/detect-engine.c:
>
> >          while (SC_ATOMIC_GET(new_det_ctx[i]->so_far_used_by_detect) != 1) {
> >              if (suricata_ctl_flags != 0) {
> >                  break_out = 1;
> >                  break;
> >              }
> >
> > +            if (pseudo_pkt_inserted == 0) {
> > +                pseudo_pkt_inserted = 1;
> > +                if (detect_tvs[i]->inq != NULL) {
> > +                    Packet *p = PacketGetFromAlloc();
> > +                    if (p != NULL) {
> > +                        PacketQueue *q = &trans_q[detect_tvs[i]->inq->id];
>
> so by adding it's to the detect tv's in queue we know we add it for each
> stream/detect thread in autofp, right?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/inliniac/suricata/pull/228/files#r2232094>.
>
>

yes.

-- 
Anoop Saldanha
Good practice to add `@CheckForNull` (from e.g. `javax.annotation`) to the return value in this case.
Alternately, make `build_event(row)` return a LogStash::Event you can just push onto the queue.
Ok it looks like the owner element will be localized replacing all the content, but I think it's still better to rephrase this. Maybe @wbamberg can help.
This documentation is globally out of date.
global!
@ozten - Great question - all addition/subtraction/mutations are expected to have happened before they are saved to the KPI data store.  Instead of doing any addition or subtraction here, we are setting explicit values.  

sites_signed_in is set once on window_unload (https://github.com/mozilla/browserid/pull/1807/files#L3R77).  This ensures all sites for the currently signed in user are counted, including if the user has just signed in to a site for the first time.

This does leave a hole in coverage for sites_signed_in if a user opens a dialog, sees that somebody else was logged in, and clicks "this is not me".  The original signed in user will not have the number of sites signed in saved.
Is there a reason for this ? The new VM is slower to start ?
Nah. We make it a configuration option. After we merge this.
no need here. readability over all :)
I think the "\\" is not needed because $queryClass is already a FQCN
Here's the new commit message:

```
    (#17917) Allow case equality confinement matching
    
    Without this patch applied the confine functionality is limited to
    testing equality.  This is a problem because some facts have different,
    but similar, values over time.  For example, the use case motivating
    this feature is:
    
        I have some facts I want to run on all generations of dell machines,
        but the manufacturer fact has changed between them so I want to be
        able to use something like /.*Dell.*/
    
    This patch implements case equality which provides a superset of the
    regular expression matching that addresses the problem.
    
    This patch also cleans up the spec tests around confines a bit.
```
'more than'
@jeffweiss unfortunately, the `rename_files_with_uppercase` complicates things. As it is now, if the request is for `foo`, but the file is `FOO.pem` and is not readable, then we'll have the same problem (no warning). Seems like we should either figure out what file we're actually going to use, and then do the `readable?` check. Alternatively, we could just try to read the file and rescue `Errno::EACCES` or `Errno::ENOENT` appropriately.
Thanks for noticing, I just pushed a fix.
you've added an unnecessary multiply to the inner loop -- combine vca and pan_l instead
spazio.
Penso che queste due frasi si possano saltare, poiche' questa frase viene da un concetto riguardante il DIC e precedente la beta4.
`setPort()` here some other setters allow removing URI part by setting it to `null`
`isValid*`  methods on the other hand should not treat `null` as a valid parameter
As of https://github.com/travis-ci/travis-ci-php-example/blob/f1dd180e8d3ed0331f575b6cba3ab6ce60385d17/.travis.yml#L16 it is not possible to test against 5.3.3 right now.
`if ($match[0] === '') {`
I guess we'll need to find appropriate cursors for this tool and a few others?
Hardcoding the compiler is very bad style---for example anyone using XCode 4.3 or newer won't be able to install this formula because they don't have GCC 4.2. What exactly is the problem with `-march=native`?
Add your name, like Adopted to use XMPP ...
Just wondering about the `_`. When will this be dropped?
`comment.comments.blank?` should work here.
AFAIK, we don't do GZip content negotiation for "normal" pages nor in index_cluster.php when serving plain text files so there's nothing new here. Again this can be added later. For expiry, as said just above, it's only able to server YUI files, so the name change if there's a source code change. That's why it's useless for now to change this.
could you please add an empty IUSE="" back?
okay, good. I'll let you finish your work on this then
No problem, I should probably take a nice little walk through the diff and fix all these little style thingies.
Let's not complicate things too much, and just append your name to the list
Upon test looks like these arent's necessary. Please remove unless you can reproduce.
This change makes this a lot less readable. It doesn't look like you changed any of the actual attribute values, right?
This is an invalid assignment, as is the one below it (line 94)
Ah, I remember seeing this in some plugins. Good point, thanks :)
Don't shoot me, but would we want to shove the change to "Show Works You Saved for Later" in this, too? >.> (As part of the big "it's not just fic" push to remove references too specific to reading.)
Hi N! :)

Would you like to replace the hard-coded numbers with the constants (User::LOGIN_LENGTH_MIN and User::LOGIN_LENGTH_MAX, as they are above).

Bonus (not mandatory): ts()-ing the failure message and interpolating the min / max variables in the string :D (examples elsewhere in the code, or poke us in Coders / by email if you get stuck).
drop this: http://arduino.cc/en/Tutorial/ShiftOut in here somewhere :)
What about `'The %s requires the predis library or phpredis extension.'`? :-)
.all.paginate is usually wrong (as it would convert it to an array first)
There are three symbols which are defined in both halves of the try block - `c_websafe`, `c_websafe_json`, and `spaceCompress`. `uspace_compress`, which is defined only in the top half, isn't referenced anywhere else in the file. The handful of `c_*` functions are assigned to `python_*` equivalents, so in the end all the same names have a valid definition.

Would you rather I keep the C implementations of everything but `spaceCompress`? I thought it would make more sense to deprecate `filters.c` all-at-once instead of function-by-function. I could also replace the 'try...else...' with 'if 0...else...' while keeping the note about the C code being outdated, so the code keeps the same structure and can be easily reverted if the C is updated.

(By the way, I'm operating under the assumption that you're not desperately hurting for CPU time, as I imagine Reddit was when they wrote this in C, and it's okay to move this code back up to Python - let me know if that's off-base)
Wow, that's very interesting, I didn't know that! I Thanks @kmtracey, I changed it back. I will have to be much more careful where I use `is` in the future.
Considering this and your next commit it is perhaps best to just delete it after all. Doing that ...
- hiding the metadata - yes. This is imo a larger topic because the existing places where the "metadata" is passed from, the value is always "null", meaning it's not used atm anywhere in the code which calls put/putIfAbsent. Is this likely to change in the future ?
- the reason why I used BasicDocument is that I needed a simple MutableDocument implementation. My thinking was that BasicDocument is simple enough for the connector SPI to use directly. Using only the interface and basically allowing each connector to use a different implementation, would potentially allow imo a complications of things. We could create an implementation of "MutableDocument" for the connectors, but it would look similar to BasicDocument.
@cdeil - could you clarify what you see as the difference between ``sky`` and ``world`` coordinates? In WCS-speak, sky coordinates are just a subset of world coordinates (i.e. world coordinates that are positions on the sky), but maybe you are thinking of something else?
I'm definitely up for switching that around. Any pros/cons? I know about `content_tag`, but I rarely use it unless I'm in a helper.
I renamed the method's name  since it collided with the one above it.
If you store frontmatter by `path` instead of `relative_path`, we won't need `relative_path` at all.
Should probably document the function to show that it will parse string data and could throw an exception.
I thought we were going with .getFirstError() ?
Correct. The additional production optimisation also makes sense, but as you say is probably unneeded for now.
In hindsight I think valid downloads are being tested by virtue of thumbnail URLs? If so, I think that will suffice given you don't necessarily have uploaded content to test w/ here, at least until previews are in.
A lot of these tests do a lot of similar things. ie:
 * create user in tenant A
 * create tenant B
 * make tenant public/private
 * create user in tenant B
 * create content in tenant B

Can we abstract this in a method so that the LOC in the test cases get a bit smaller?
We changed things for 6.1. Did this come from a wiki article? If so, it's out of date.
Yep, fixed there and here.
@tsetimmy 
I think that solve the problem.
Ah, good old semicolons. So it should be `[^,]`.
Second letter needs to be in lower case (for other entries as wll).
Не самое оптимальное решение, но сойдет :)
Вот так уже круче.)
правильнее было бы использовать возвращаемое этим методом значение для вывода информации в консоль тут, в методе `main`, а не внутри `hammingDistance`
With probability of .25 you are replacing object with itself, thus doing identity transform. What you need to do is to replace an object with random object from nucleotide array excluding initial object.

Calling mutate with percent = 100, one would expect to have completely different DNA, but, on the average, will get DNA where 25 position are the same.
Under what conditions would we got tot his part of the code (generating a hash for a node that hasn't been compiled)?
We are going to use the sprint number for builds, so this should be "Brackets Sprint 13"
Naming nit: this function would be better named `MoveFileOrDirectoryToTrash()`.
Can i update this pull request? Or new request needed?
@agramfort you mean so you could do arbitrary layouts, e.g. non-circular or with variable-angle gaps (but still circular)? If so, @mluessi what do you think about making a `node_layout = mne.viz.circular_layout()` function that would use node_order and start_pos to return a `node_layout` layout that could be used? The `node_layout` could then basically just be a set of positions. 

I suppose this might complicate how the titles are drawn. A known-circular layout you probably want radial titles as you have currently, but for something less circular you might want 'top', 'bottom', 'left', or 'right'. This is increasing complexity perhaps with minor gains, but you could also add a `label_direction` argument that would allow you to specify 'radial' or 'top', etc.
Since the real API takes an object as a parameter, we should test with an object here as well (instead of using 100) to make sure that the object is serialized and passed between the content and background windows properly.
and a dot after this item
This is still true (see `vendor/symfony/symfony/autoload.php.dist`, which includes the Composer autoloader)
当前通过一个连接接收的的请求数量
这个应该是意译了。
why not use `system` for these?
Yes I have tested this multiple times. Actually this is already the improved version from sinon-chai, the original version is
```coffee
# Only sinon spy
expect(spy.called).to.equal true
# sinon-chai
expect(spy).to.have.been.called
```
Ok. Fixing.
Splitting it might get more readable:

<code>
name = obj['samples'].get(scilifelab_name,{})
lib_prep = name.get('library_prep').get(prep,{})

if(lib_prep != None):
  ...
</code>
From PEP8: 

Imports should be grouped in the following order:

standard library imports
related third party imports
local application/library specific imports
I would expect this case to return the whole unique objects from the array not just the matching key and value.

```
expect(uniqueFilter(arrayToFilter, 'key')).toEqual([{key: 'value', other: 'other1'}, {key: 'value2', other: 'other2'}]);
```
Here you change the behaviour IMHO. Shouldn't it be ```mapMode == MapMode.LIVE_ONLINE || mapMode == MapMode.LIVE_OFFLINE``` to resemble what was there before?
oh, I think it's because I'm using Eclipse and you the IDEA. For sure both IDEs use very different rules to order imports.
I mean this line; it's probably not the way to go...
Should we restart the nova-api so that it loses the gridcentric extension endpoints?
I'm sorry I tweaked these. I thought :class might be a bit cleaner.
The old line was actually correct :)
I abstracted the LessFilter to include the same method for the LessphpFilter and LessFilter.
it should be ``} else {``

And the if above should also use spaces: ``if (preg_match(/* ... */)) {``
This should probably be a "proper" docstring, with ``"""`` instead of `'''`
Considering that the change that broke everything came about when we did the PEP8 changes, the docstrings wouldn't have been visible in the github diffs and so we didn't notice it then.  Better safe than sorry.

Of course, I would have to wonder about the logic of depending on the return value of an arbitrary callback function to determine if it is to be removed or not...
Could this fit on the previous line?

Also, no need for the trailing comma.
yeah, older logic, thanks
Actually, at the beginning of the function, you could just do a:
if  isinstance(new_content, unicode):
    new_content = new_content.encode('utf-8')
James, can you move this function to the top of the JS so it doesn't execute before it's declared?
Also, there should be some documentation that describes that the function does.
err the SG_FREE below should probably be free_vector.

set subkernel weights implementation depends on kernel. some kernels have subweights even, like CCombinedKernel, CWeightedDegreeStringKernel etc

so these use a full vector, one CKernel has this weird set just 1 element function
It's the config file for a vim plugin clang_complete. I added it to .gitignore to ignore it from git status. If you don't like it, I can remove this.
I've documented correct_state. The -1 is jstree lingo for "root node". I guess my expectation when documenting this stuff is a base knowledge of the jstree API, otherwise it gets too verbose :)
без ```to_s``` не работает?
typo s/serives/services/
Why do the call to wt_txn_update_check after the call to wt_txn_modify?   I think that leads to a bug: if txn_modify succeeds, we increment txn->mod_count, then wt_txn_update_check fails, we return a NULL upd reference, which means our caller __wt_row_modify jumps to err:, but since upd is NULL, it doesn't decrement txn->mod_count by calling wt_txn_unmodify.   (Ditto wt_col_modify.)

I think we could do the __wt_txn_update_check call before we allocate the WT_UPDATE structure, too.
I think this should be MTEXT_UNI.
Sounds good, want to make a PR?
``$_SERVER`` does not seem to conform to the naming convention (``^[a-z][a-zA-Z0-9]*$``). I also found this on lines 35, 37, and 34.
Wäre `switch-case` nicht eleganter?
The actual homepage is "http://softwaremaniacs.org/soft/highlight/en/"
JDataDumpable shouldn't have the slash here.
Why the indenting here?
the param tag is incomplete. The type is missing
public Pessoa
This is an obfuscated version of <a href="mailto:office@eccdsm.org">office@eccdsm.org</a>
This doesn't need to be a value class, does it? Maybe that's a bit confusing
Do it without using `NUMBER_OF_STATIONS`.
It is probably not necessary no. But it looks good :D
Didn't we say that we will use `node_location`?
Since when current unit tests gives the 99% certainty of bug-free code? ;)
Personally I don't mind unless/else when it makes sense, but I think a lot of the rest of this code could be refactored for clarity.
Please use the TrinityStrings, there should be one for this already, if not, add it.
not needed else, just return NULL;
Imagine there is already some creature addon data for them. With my solution I dont have to dump the existing data to my sql file. If there is no entry for the guid, this will create one dummy, which is updated in the next step. 

Insert + delete would be prettier, but not as generic as this.
@Subv You sure you read the code above?
no Subv, list.merge moves elements from one list to another (effectively clearing the second list)
Do you know if the Windows hosts file can handle ipv6 entries?
I can't claim any credit for this, it's just copy-pasta from the core shell provisioner with some minor modifications to make it compatible with windows. Very much an "it needs to work now" hack. I imagine someone could obtain the functionality by extending the built-in shell provisioner...
How to edit an already done pull request or should I make a new one? What is the right strategy?
so, this is commited (db write) and then saved over later?
you have this patching in several spots now => put it in a function in util.
Since you use DSL to describe some of my functions, I feel compelled to remark that `attempt` does not look any better.
This doesn't really belong in `init`, it's more extending the prototype.
I did this to be consistent with other tokenizers.
We've used constants for this in other places.
Okay, you're right about it being ugly. :-) Still, it makes it very clear what we're doing here.
Yeah, ignore this file. Should be git-ignored anyway.
Yes. )-:
What is this check for?
We should ignore more suffixes and not only '.py'.   We should ignore .py  .pyc  .pyo  .dll .pyd  .so  and .dylib  files. Maybe .dll files could be handled as data files since some modules on windows distribute dlls with binary installers.   Could you please add note to docstring that this function will not work for zipped python eggs?
Ok, someone inform me why it insists on deleting and adding a blank line...
Should be "Params" (it's a standard DDOC field name that is handled differently)
Or he could just have appended it with ``loc=self.loc``.
[`package-query`](http://git.archlinux.fr/package-query.git/) is a frontend for `libalpm` (the underlying pacman library) and the AUR rpc interface. It's apparently the actual workhorse, yaourt is merely a set of shell scripts that wrap everything up in a nice interface.  `yaourt` doesn't have much configuration, but package-query has at least an option to [`configure`](http://git.archlinux.fr/package-query.git/tree/configure.ac) that allows to set the base url of the AUR.

Concerning pacman, I know that you can setup your own repos, I didn't say any different. But pacman doesn't track packages across repositories. To `pacman`, `testing/foo` and `stable/foo` are *different* packages, and `pacman -S foo` will not install the highest version of `foo` package, but – unlike basically any package manager I'm aware of – simply the `foo` package from the first repository as specified in the pacman configuration (meaning that just switching the order of repository configuration in `pacman.conf` can have some entertaining effects ;) )

This makes it really hard to overwrite upstream packages locally (i.e. provide a newer version of `foo` in your own repo, but use the upstream version again as it gets updated), or to mix testing and stable packages in a predictable way (i.e. employing a "don't use `testing` for anything else than the latest Gnome packages, and especially never for Kernel and glibc" policy). 

Combined with the complete lack of downgrading possibilities (pacman repositories can only provide one version of a package at a time) this makes a real adventure to use unstable repositories, yields by far less safe and predictable behavior compared to the fine grained control provided by APT (with APT pinning) or by paludis (with package masks and repository priorities).
http://www.stata.com/statalist/archive/2007-09/msg00852.html
I never use code folding.
What I mean is that "comment" and "uncomment" a selected range of lines adds or removes the ``#`` at the first position in all 3 editors that I use.
Nice for quickly removing code, or trying out what a commented out code does.
You could combine this.
We should probably strip out the debug log calls here before merging?
OK, that's functioning quite differently to the way things worked with my own forays into Python multiprocessing earlier this year, which was via the use of the `Pool()` and its `.map()` method (there could be an implementation via that route too).  This also answers my slight eyebrow raise at the lack of a `.join()` for the processes, which would not be possible anyway as they are initialized without handles currently.

What I didn't realise was that this was the way Queues and their `.get` methods worked with `iter`.  It boils down, in my mind, to the default setting of the `Queue.get()` block argument, `block=True`... I imagined that Queues would give some kind of exception by default if you were trying to get stuff that wasn't there, but this was wrong!
That's fine.  It would be worth updating the dox and the quick reference guide so that the examples have galsim.PowerSpectrum instead of galsim.lensing.PowerSpectrum, etc.
Wouldn't it be better to do ```find('div').eq(0)```? Otherwise you may modify multiple divs' css of more than one is found. Also, I think searching based on a class selector would make it more robust.
Should be able to do self.campaign_friend.include(:donation).each do |friend|

I think
great addition
you're right, fixing
I will rewrite that return code to void.
Usa ```double``` mesmo
You don't need to use the wait_for_page_to_load method any more, so this line can be deleted together with the method itself.
WebDriver unlike, Selenium RC uses implicit_wait.
But if the pages still take some time to load, you can always use WebDriverWait().
You don't need the final `function()`, right?
while (ul.hasChildNodes)
          ul.removeChild(ul.lastChild);
is there a way to coerce this to an enum?
We're trying to move to explicit error labels, instead of passing an error value.

~~~~c
    giterr_set(GITERR_NET, "Failed to parse other-ref OID");
    goto on_error;
~~~~~

~~~~~~
        ...
    }

    return 0;

on_error:
    git__free(pkt);
    return -1;
}
Just remove whitespace on newlines - no need for spacing.
@arturo-c FYI - these CSS vendor files get added by [this makefile](https://github.com/AllPlayers/USARugby-Stats/blob/master/Makefile#L3) in order to attempt to pin the external dependency.
included so the code isn't lost.
forgotten debugger
Good idea.  I'll push that later today.
All 3 are reasonable, imo.  I generally don't like full path references in code, but if it is just one of several possible locations to check, then I am not opposed.
Можно сделать метод parseOrExit, например.

CalendarExample -- уж совсем неудачное название. Можно, например, сделать пакет calendar, а главный класс -- CalendarMain.
И тут надо экранировать
we should not use webelement methods in tests
This note appears multiple times. Still relevant?
The problem that I envision is that a `FeatureHasher` constructed in a later version cannot be loaded in an older version of scikit-learn. If that's not a problem, we can skip it. (It's also a bit of a leftover from when I tried to support Python's built-in `hash`, which was a bad idea.)
Perhaps we want something like this (incomplete snippet), where we check 
that the observed training counts are within +-1 of their desired 
values.  The +-1 results because desired_train_counts might be a float, 
so we can only assume equality to within rounding.

observed_counts = np.bincount(y,minlength=y.max()+1)

observed_probs = 1.*observed_counts / observed_counts.sum()


desired_train_counts = test_size*observed_probs

desired_test_counts = test_size*observed_probs


cv = sklearn.cross_validation.StratifiedShuffleSplit(y,indices=True)

for train_ind, test_ind in cv:

y_train, y_test = y[train_ind],y[test_ind]

training_counts = np.array([sum(y_train==i) for i in range(y.max()+1)])

test_counts = np.array([sum(y_test==i) for i in range(y.max()+1)])
np.testing.assert_true(np.abs(train_counts - desired_train_counts).max() 
<= 1.)

np.testing.assert_true(np.abs(test_counts - desired_test_counts).max() 
<= 1.)


On 08/25/2012 03:38 AM, Mathieu Blondel wrote:
>
> In sklearn/tests/test_cross_validation.py:
>
> > @@ -133,6 +133,17 @@ def test_stratified_shuffle_split():
> >          assert_true(train_std[i] <= np.std(np.bincount(y[train])))
> >          assert_true(test_std[i] <= np.std(np.bincount(y[test])))
>
> Also, I would argue that we don't care if it does a better job than 
> |ShuffleSplit|. We just care that it does the job as expected. So, I 
> would just remove the above inequality assertions (comparison with 
> |ShuffleSplit|).
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/scikit-learn/scikit-learn/pull/1060/files#r1459507>.
>
I do have a request object within the DataTableComponent - unless this is to say its unnecessary?
Given that we now import `core.stdc.time` do we even need these declarations?
Again, since these blocks are not being used for their return values, they should use the `do...end` syntax.
You should not have to install redcarpet manually if you have bundler installed properly.
why mention the same twice?
You would need to keep track of the number of rows returned before any spill occurred (to avoid returning them twice), but that should be the only complication.
Shouldn't this say (unsigned) (cycle_to_nanosec(elapsedCycles())/1000000);

Best keep unrelated changes in separate commits/pull requests....
I'm not convinced this logic is in the correct place.
I would expect more:
if (id == 0)
{
....
}
string.append(...) at the end
usually, this is what you use dicts for. E.g. 

```python
return {
    'exact': 'is_exactly',
    'startswith': 'starts_with'
}.get(query_type, query_type)
```
Do we need tests here for `"without table_name_(pre/suf)fix"`?
А чем хуже
```ruby
def signed_in?
  current_user
end
```
В большинстве случаев будет работать похоже, если только у тебя в ```current_user``` булевые значения когда-нибудь не хранятся, в чём я лично сомневаюсь)
The empty name.. I thought that wasn't possible.
As the code declaring queue. Shouldn't the if from publish method really be moved into the exchangeDeclare method?
I would just say stable.
I would in fact don't publicize window-utils and tab-browser even further specially the later one. There lot's of staff we wanted to deprecate for ages and `tab-browser` was left over for test, so I would not like to increase audience for these modules.

Also I think future we want to be at may be relevant here: https://github.com/mozilla/addon-sdk/pull/353#issuecomment-4382945
it should be ``false === $data`` according to the Sf2 CS
is this method in the commons ?
@christianv Interesting - the file can still be found without resolving the asset_path?
The behavior of integer and symbol literals here doesn't seem to match Clojure:

    user=> (type (quote "foo"))
    java.lang.String

    user=> (type (quote 5))
    java.lang.Long

    user=> (type (quote foo))
    clojure.lang.Symbol

    user=> (type (quote (1 2 3)))
    clojure.lang.PersistentList

The symbol case is a bit of an odd one – we'll probably need a new runtime class for that, so I wouldn't worry about it just yet (but we should add a TODO).
no, the logic says:
if len(cfres) == 0:
  #if there is no result returned from the query, then create the record and rerun the query
if len(cfres) == 1:
    # assign the single result to be returned 

comments added to state this
Likewise for ICU and QtDeclarative
WDYT?

```ruby
github_url = Github::Hooker::Config.config.fetch("api_url", "https://api.github.com")

url = github_url + path
```
if res and res.code = 200
I'd kind of like to see a report_note in here somewhere, for both this and the expect check. It'd be cool to be able to report that your target had python or expect, and what version, and what the path was... stuff like that.

Just an idea. Something like

````ruby
report_note(:host => session.session_host, :type => "host.enum.interpreter", found_interpreter, :update => :unique_data)
````

would be nice to point at as a finding.
RGB images are MxNx3, but I've updated the docstring to make it clearer.
@stigi oh - ok let me take another look on this and offer you a :candy: solution ;)
my bad.. fixed
I was imitating `Occluder`, and I think the design is fairly reasonable.  You're right about it working the way it does as a performance optimization, but forcing the user to manage the state externally would be a step backwards.  The current design leads the user toward the pit of (performance) success.
At least reading the whole method description, not just the first line, of `bindAll` before commenting:)
comment is misleading, since when you get into this block, you don't have a default subscription. Shouldn't this be "set the current subscription as the default"?
KROLL GET PROPERTY OR KROLL SMASH!!!!
Cap. Although it's a method name, so maybe leave it. Or go with View.animate.
Same as comment above - Modify KS-Nook if applicable
Sets fullName to "No Name" if no full name provided to match parity with iOS
Both text and textcontent are marked as mobile web only. I thought text was the non-standard Android/iOS mechanism?
Your arguments about wrench possibly being dead (or even needing re-evaluation) are not convincing, but the argument that non-OS X (Linux really) support being outside the scope of this PR is convincing (if disappointing).
From Emacs inline doc (`C-h f` `paredit-mode`): 

> With a prefix argument, enable Paredit Mode even if there are imbalanced parentheses in the buffer.

So the `+1` mode allow paredit-activation even if there's unbalanced parens.

It it really what we want?
use `service.getAuthorizationUrl` instead.
Should add loose (minor) version numbers to these.
you can assign multiple variables per `var`
All other examples use double quotes
В этом файле еще похоже mess с отступами, хотя в диффе не видно.
I'd say same as the `save` condition:

```D
static if (isForwardRange!RoR && isForwardRange!(ElementType!RoR))
```

No point in saving if joiner isn't going to propose forward range iteration anyways.
_newTodo.on.change.remove(_listener1)
Time to separate out some of this stuff into a non-Sync specific `org/mozilla/gecko/Constants.java.in` or similar?  I really think we should take this time to start re-organizing some of the Sync code for generalization to new services.
Maybe we should split the negation into separatenamespaces  for media-type, language, encoding etc.
http://stackoverflow.com/a/5629129/310275

The default character set and collation are latin1 and latin1_swedish_ci, so nonbinary string comparisons are case insensitive by default.

I think we should code against default here.
This class looks a bit like duplicate of `UserResponseEvent` (or inverse), but if I'm wrong some at least phpdocs describing differences would be great, because code looks very similar for both...
If not then there's a failure in ContractByInterfaceTests.Should_be_able_to_deserialise_based_on_an_interface_with_no_concrete (presumably because  the interface is trying to be instantiated). If you think it makes more sense to fix the test in another way, I'm all for it.
How about 
DateTimeOffset originalDatetime = DateTimeOffset.Now;
Need to close the anchor tag.
I'm also not happy with this special if-condition. I also agree with @mmoss. If someone use this combination the opacity fix must be done manually. Maybe with a advice on an new wiki page?
Can you chain the `off` and `on`?
And so on... probably more of these throughout the pull request.
Macht es wirklich Sinn, das ganze ueber die Console zu machen? Eigentlich sollte doch bei der Login-Maske noch eine Registrieren-Funktion sein, die minimalistisch einen Nutzernamen und ein Passwort abfragt - sonst nichts....
Zum Testen kann man das erstmal drin lassen, aber ich wuerde dann ziemlich bald die Login/Signup-Maske noch hinzuegen.
please ensure there are unit tests
I actually think it would be more appropriate to change the signature of the method to take BeanResolver instead. I know we currently only have one implementation but the fact that it is a strategy opens possibility to have more and this utility class which creates and initializes instance of StandardEvaluationContext will not be able to accept any other.
Sure, looks good
Is it a draft? Or what does this commet mean?

And it may be worth to remove *{@inheritDoc}*?
This won't work - $ip isn't defined in params, it's defined in config as you've got it there. I can fix that for you though. Gimme 10min :)
`users click on todo element` -> `users click on a todo element`
`listener to todo element` -> `listener to the todo element`
This is good news and as result (while waiting for new jackson) I think it
is best to move them to the utils-groovy package (you can create a java
folder and keep them as java file like it is done in the
orchestration-engine module in glu (
https://github.com/linkedin/glu/tree/master/orchestration/org.linkedin.glu.orchestration-engine/src/main
)

Yan

On Fri, Mar 9, 2012 at 9:15 AM, Zoran Simic <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,74 @@
> > +package org.linkedin.util.io;
>
> Noted. The 2 classes SortingMapSerializer and SortingSerializerFactory
> won't be needed anymore as soon as soon as Jackson 2.0 is released.
> I wrote to the Jackson mailing list and showed this implementation, Tatu
> Saloranta (one of the authors) is going to add support for sorting keys
> when serializing maps (same as the implementation here). Most of this code
> is to simply make it work with Jackson as available now in 1.9.5. I'll
> remove these 2 classes when Jackson 2.0 is released. At that point, we
> won't need any Java class added to linkedin-utils, we can use Jackson
> directly from groovy as-is. I don't know when Jackson 2.0 will be released
> though.
>
> Here's what Tata said in hist last email on this:
>
> Thank you for sharing this!
>
> For what it's worth, I implemented the new feature
> (SerializationFeature.ORDER_MAP_ENTRIES_BY_KEYS) for 2.0.0, will be
> included in 2.0.0-RC2 when it gets out.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/linkedin/linkedin-utils/pull/6/files#r538061
>
You should be using DisplayUtils.getSynapseHistoryTokenNoHash (...) or one of its variants to create link urls to Synapse entities
redesign layout so long entity/file name, synapse id and file size/md5 info display inline
you should keep the space IMO
*o* comes before *s*.
Но тогда код будет неопрятным. Так как в начале файла, модуля, класса должно быть самое важное. Ну это на мой взгляд.
I removed the r for revision and will do so for others as well.. seems to be what Xavier wants..
consider naming the exception variable `xmlTransformationException`
Fixed in later branch.
This should probably be 2012.
formatting issues in here
Please release p2-bridge before merging this and depend on that
I guess that's marginally nicer.
This method is identical to buildConnectedCallbackArgs and should be removed
we should use islandora_audio_sp as the prefix for this, as per the drupal coding standards. 
http://drupal.org/coding-standards#naming

So it would be something like variable_get('islandora_audio_sp_lame_path', 'lame')
Should these be constants or resources?  If they're resources, folks can change the service URI without recompiling the app.  If the other libraries all have them as constants then I'm fine with that too as Azure won't likely be ever changing that URI.
do you need it in both settings.py AND the wsgi? If so, why?
The formatting that was deleted was perfect. In PMS and UMS all if statements must have { }, and the spacing should be consistent, meaning it should be:
if (usable...
Not:
if(usable...
And:
SIZE = (int)
Not:
SIZE= (int)
its no longer necessary its an archive, it could be a folder as well
remove me plz
I like the collect function.

If I am going to change it I will change it everywhere, because used in stats.js, lint.js and I prefer if I don't rely on a module if I don't have to since fs comes with node and wrench doesn't.

From: James Keshavarzi <notifications@github.com<mailto:notifications@github.com>>
Reply-To: blackberry-webworks/BB10-WebWorks-Framework <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Thu, 11 Oct 2012 11:17:19 -0700
To: blackberry-webworks/BB10-WebWorks-Framework <BB10-WebWorks-Framework@noreply.github.com<mailto:BB10-WebWorks-Framework@noreply.github.com>>
Cc: Nukul Bhasin <nbhasin@rim.com<mailto:nbhasin@rim.com>>
Subject: Re: [BB10-WebWorks-Framework] Preprocessing (#199)


In build/build/preprocess.js:

> +* limitations under the License.> +*/
> +var wrench = require("wrench"),
> +    fs = require("fs"),
> +    path = require("path"),
> +    _c = require("./conf"),
> +    pp = require("./preprocessor");
> +
> +module.exports = function (preprocessDefs, paths) {
> +    return  function (prev, baton) {
> +        var files = [];
> +
> +        baton.take();
> +        //get list of files that need to be precompiled
> +        function collect(dir, files) {
> +            var fs = require('fs');


Instead of this "collect" function, what do you think about calling wrench.readdirSyncRecursive(dir); and then maybe applying a filter to filter .js files. Should make things cleaner.

—
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/199/files#r1821794>.



---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
CS `if ( $this->getRequest()->getMethod() == "POST"){`
==> `if ($this->getRequest()->getMethod() == "POST") {`