Document account lockout configuration

ticket: 7477 (new)
target_version: 1.11
tags: pullup
Cross-reference account lockout documentation

Link to the database.rst description of policy objects when talking
about them.  Briefly mention the "default" policy.  Link to the
kadmin_local.rst description of policy fields when referencing them.
Describe policy fields more briefly, and expand the kadmin_local.rst
descriptions where appropriate.

ticket: 7480 (new)
target_version: 1.11
tags: pullup
Build fixes for windows

Add entries to OBJS and SRCS as well as STLIBOBJS.

Use KRB5_CALLCONV at function definition as well as declaration.

Declare missing variable in _WIN32-conditional code.

ticket: 7479 (new)
tags: pullup
target_version: 1.11
Leave 'OK' button visible in Leash AboutBox

The AboutBox dialog as specified in the resource file is larger than
the one we display; the dialog init routine marks several things as
non-visible, moves the 'OK' button up to where the now-invisible items
were, and shrinks the dialog's bounding rectangle.

However, the edit boxes containing copyright and version information
seem to always present as being on top of the 'OK' button, and their
background causes the button to appear almost invisible with the current
repositioning.

To keep the 'OK' button visible, reduce the amount that it is moved
(and the amount the dialog is shrunk) so that the button does not overlap
with the edit box.

ticket: 7443
tags: pullup
target_version: 1.10.4
Rewrap the Leash ribbon conf file

A big pile of XML on one line is not very readable.
Use 'xmllint --format' to make things more sane.

ticket: 7478 (new)
queue: kfw
tags: pullup
target_version: 1.10.4
Access keys for the KfW ribbon interface

Improve accessibility by actually enabling access keys for ribbon
elements (tap alt and follow the onscreen hints for keys to press),
instead of just underlining a letter in the name of each element.

Supply an underlined letter in the text of each element, corresponding
to this access key, even if there is not a shortcut key bound to that
element.  While here, fix conflicting assignment to 'R' on the 'options'
tab (between "Renewable Until" and "Automatic Ticket Renewal") by
making "Automatic Ticket Renewal" use 'T'.  Microsoft's UI recommendations
seem to say that access keys should be easy to locate when searching
through the menu, and thus using the first letter of the first or
second word is advisable.

The Ribbon XML Reference seems to indicate that these elements should
be "keytip" elements, but MSVS creates "keys" elements, which seem
to work, whereas "keytip" does not.  Apparently 'F' is standard for
the application button menu (which contains exit).  Access keys work
somewhat poorly for us in this menu, as they appear on top of the text
of the menu items, since we have no icons here.

ticket: 7441
tags: pullup
target_version: 1.10.4
Fix typo for windows versions

We omit the patchlevel if it is zero, but the check whether
the patchlevel was zero was checking the wrong variable, and thus
always succeeding.

ticket: 7481 (new)
queue: kfw
tags: pullup
target_version: 1.10.4
Don't return a host referral to the service realm

A host referral to the same realm we just looked up the principal in
is useless at best and confusing to the client at worst.  Don't
respond with one in the KDC.

ticket: 7483
target_version: 1.11
tags: pullup
Make resources.rst more useful to non-devs

Reorder the IRC channel listing so #kerberos is first.  (Developers
form a smaller part of our audience for this documentation set.)
Remove some details that are available on the wiki and not of interest
to non-developers.

Add a pointer to the wiki.

Fix minor grammar errors in Archives.

ticket: 7482 (new)
target_version: 1.11
tags: pullup
Reformat RST to avoid sphinx warnings

Old versions of docutils will see inline markup (e.g., :ref:`foo`)
at the beginning of a line in the content of a directive block
and attempt to interpret that markup as options or arguments
to the directive.  RST intended as inline markup (as opposed to
modifying the behavior of the directive) will not be interpretable
in this context, and causes Sphinx to emit a warning.

Work around this behavior by always leaving a blank line before
the content of a directive block, forcing it to be interpreted
as content and not options or arguments.

The buggy behavior was only encountered in note environments, but
for consistency of style, also reformat warning and error blocks.

Note the new style constraint in doc/README.

ticket: 7469 (new)
title: doc buildslave generates sphinx warnings
tags: pullup
target_version: 1.11
Do not generate unused parts of toctree

Our css only displays up to depth 3 of the toctree, partially
because the API reference content explodes at depth 4 and that would
not be pretty to see in the sidebar.  However, we would previously
always generate HTML for the full toctree and hide parts with CSS.
For the apiref, this proved to be about 65k per html file, and we
have one html file per function/type/macro.

Limit the depth of the toctree that gets generated to save on space
in the release tarball.

Unfortunately, there seems to be a Sphinx bug wherein the toctree
will only be generated to depth 1 for a document at a depth greater
than the maxdepth of the toctree, so the sidebar table of contents
on individual apiref pages will just be the toplevel toctree.
This issue is being tracked at
https://bitbucket.org/birkenfeld/sphinx/issue/1046/

ticket: 7466 (new)
tags: pullup
target_version: 1.11
Do not include hidden files in the sidebar

We play games with hidden toctrees in the RST source to avoid
Sphinx warnings; make sure that they do not affect the rendered
output.

ticket: 7467 (new)
tags: pullup
target_version: 1.11
Note notice.txt's dependency on version.py

This dependency has been in effect since the notice build was changed
to use the main conf.py, due to its unconditional execfile('version.py').
Adding another conditional in conf.py seems to add needless complication,
it is easier to just note the dependency in the Makefile and carry on.

ticket: 7470 (new)
title: NOTICE build has unnoted dependency on version.py
tags: pullup
target_version: 1.11
Fix typo

We do not have any files with extension "rxt".

ticket: 7471 (new)
title: typo in exclude_patterns for notice build
tags: pullup
target_version: 1.11
Fix various integer issues

In kdc_util.c and spnego_mech.c, error returns from ASN.1 length
functions could be ignored because they were assigned to unsigned
values.  In spnego_mech.c, two buffer size checks could be rewritten
to reduce the likelihood of pointer overflow.  In dump.c and
kdc_preauth.c, calloc() could be used to simplify the code and avoid
multiplication overflow.  In pkinit_clnt.c, the wrong value was
checked for a null result from malloc(), and the code could be
simplified.

Reported by Nickolai Zeldovich <nickolai@csail.mit.edu>.

ticket: 7488
add quick docs for KRB5_RESPONDER_QUESTION_PKINIT
add an undocumented -x option for responder values

Add an undocumented -x option in the vein of the -X option, which
accepts question/answer pairs to be supplied by a responder callback.
Expected to only ever be useful for testing.