labofsahil/github-event-dataset-2012 huggingface dataset:
Misschien iets stoms hoor, maar als je  op lijn 24 nu eens 
if(!BackendModel::getModuleSetting('faq', 'allow_multiple_categories', true)) $this->redirect(BackendModel::createURLForAction('categories') . '&error=only-one-category-allowed'); set dan is dat jets properder en doe je de validatie eerier
I think this should be `if callable(func):`
This is not in the "production"-code but in the  `if __name__ == '__main__':` part. I thought that adding the logging.DEBUG is actually better. Or is there a different use for running a single standalone `HeartMonitor`?
Am I right in thinking that a drop will only be accepted if its after the current input prompt? I'd expect to be able to drag anywhere into the console widget and have the text appear at the prompt.
The class name should be the specific algorithm name (HopcroftKarpBipartiteMatching) since other algorithms for the same problem may eventually be contributed.
Does this really need a check? You should just always attempt to pause it, if it's already paused it'll do nothing.
Last parameter should be `force_direct=True` for better readability.
Doesn't LESS have ways of avoiding this kind've repetition?
spacing, etc.
I actually wanted to add a test but, in my testing I did not trigger an error so it seemed ok. Did not test switching tabs though.
Oh didn't notice that comment before merging....
I'll do some refactoring and push again
This fails the snowman test:

``` js
> /(^[^\-]?$|(^[^\-][\w|\_|\-]*[^\-]$)+)/.test('☃')
true
```

``` js
> /^\w{0,2}$|^\w[\w|\-|\_]*\w$/.test('☃')
false
```
Is the original if / else code needed? If yes, please add a FIXME here, explaining why this is s
@stof I renamed `FauxFile` => `MockSplFileInfo`.
Not only that. I see that `Form` accesses `getValidators` although the method is deprecated. I don't think core classes should use deprecated methods. Is it possible to rewrite it without this method? Otherwise it should probably not be deprecated.
why passing a reflection class if the only class for which you can dump tags is the class itself ?
What if json is null or json.payload is null. Please switch sides of ```null``` and ```json.payload.rows```
Possibly unrelated, but on rake, we get this Modernizr error:
`undefined|0|ReferenceError: Can't find variable: Modernizr`

right at the end.
Thanks for the reminder to go back and read "Clean Code", btw. I've read a few chapters but never finished it.
Same comment as above. Checks shouldn't know or care whether they are run in parallel.
When no cast, I get message that no function can be called with arguments supplied (**Pattern.quote()** returns **java.lang.String**), particularly, **jet.String.split(jet.String)**.
So there are two ways: either to declare **this _as java.lang.String_** or to declare **java.util.regex.Pattern.quote(ch.toString()) _as String_** (jet.String here). Why I decided to use the first statement is because it's widely used in Strings.kt.
Please correct me if I'm wrong.
Lets break these TestCases into a finer granularity where each test case is test one thing.  For example., the last test case would be:

```csharp
public void TestGetWithDefaultValueReturnsDefaultIfKeyNotFoundString

public void TestGetWithDefaultValueReturnsDefaultIfKeyNotFoundSInt

public void TestGetWithDefaultValueReturnsValueIfKeyFound

```

You can see how to break up the others from here.
It's going to misreport slightly either way. Better to err on the other side.
This will probably fail in IE, you should use `Ember. ArrayPolyfills.forEach`
Maybe mention that although the router is the default target but it can be changed with the target property.

Uses of the `{{action}}` helper will automatically target the application's router by default.
declare ``changelog`` as service with Pimple
Then it needs to be @Ignore("JBPAPP-8517"). The annotation needs to document the reasoning so it's easy at any time to check if the reason is still valid.
Here you probably mean AbstractRemoveStepHandler?
The  indentation of the file is correct. We think this is related to github indentation algorithm error.
ухты оказывается там можно request в параметры передавать, чудно
yep, I prefer to keep the 0 for clarity
Nope, it will search matches and stop when it has found 20 (or end of table), which is what I intended
umm good idea!!!
list instanceof Array may be cleaner?
I heard that we won't have a USB notification overlay, maybe from @jcarpenter ?
OK, I will mark all the hacks using <code>/* XXX hack */</code> .
Add names to those anomymous functions 

      uninstall: uninstall() {
        ...
      }
the semi-colon is a bug, I think, but the rest looks good.
Having used jQuery.ajax for so many years I've forgotten this, but isn't that supposed to be `var r = new XMLHttpRequest();`?
Was this intended to be a long term debugging log or just a work-in-progress message for yourself?
Also, is this deleting 1000 at a time?
Meant to say 'Ignore the line...'?
Like I said in the email thread, I'd have rathered we didn't start importing pulp.server code into the plugins until we had a chance to make sure it's the right approach, that way we didn't have plugins doing things different ways, but I guess this is the approach we're taking.
No worries.  You haven't caused any trouble.  Just mulling over. :-)
sorry for being fussy: lenth -> length :)
sets are also iterable, no need to return a list
I'd rather use ``while True``
this is where you were mentioning you could not longer just do stuff like `input(checked)` right?
Don't pollute the global namespace with a bunch of global methods. Just make a class and put those methods and the constants they need in it.
Should this be retry = 1 + self.mirror_sync_retry? Looks like you've implemented a "total try" rather than "total retry".
Oh, so it does! *chuckle* I should've looked. :-)
In normal composer operation this wouldn't happen. If someone does crazy
things with the code they can also take the time to fix this I guess.
I use solarized nowadays - these are the options you can uncomment if you want it
see mono/metadata/nacl-stub.c and consider adding glibc-compat stuff there behind defines.
I think you mixed up true and false. Allow rules should return true and vice versa for deny rules
Apparently this is plain text rather than HTML; should document that.
the syntax in logstash for hashes is [ "key", "value" ], unfortunately, can you fix the docs here?

(I'll fix proper hash syntax support later)
make_new_video_url helper method
Tabs class should inherit from list so that tabs[n] will return tab `n`-th tab.
use `expectedText[0]` here
I'd say that pseudo modules shouldn't be normalized in first place.
Yeah, that latter thing can be handled along with validation etc.
Ohh, sorry! I meant leaving a comment on GitHub is fine, but You meant creating a jsdoc comment would be fine.
Updated in latest commits.
Indent and drop 'Detail: '; either use the original message verbatim, or wrap it in additional context ("`The error we caught said 'There was a problem'`").
i think by moving away from the block you are leaving out some cleanup
The "if" is moved to embrace the password checking.
use hasclass, it's faster
I guess what I'm getting to wonder now is: should we have separate hints for Request and Response at all? Even in the HTTP spec, they have basically the same format -- the main variation is that a Request has a "request line", and a Response has a "response line"; otherwise, they both simply compose headers and a body.

Thoughts?
If you're going to implement these, you should likely also implement the EventManagerAwareInterface, which would make it possible to get this auto-injected via the service manager.
Field with initial underscore _paginator
Really is necessary all this arguments for this test? I think than with all this arguments exists more possibilities to fail the test.
Based on usage, it looks like $match is an array -- typehint it as such.
plupart
Good catch. Fix
Fix in my new PR
Could you just clarify whether this is "origin/master" or "origin/develop", please? In fact, it would be ace if throughout this document we used a convention that tells the reader which branch in which repo and whether it's theirs or GiveCRM's. e.g. (username|givecrm)/reponame/branchname?
If there is a published recommendation to use 64k I am fine with that.
On May 10, 2012 6:31 PM, "Matt" <
reply@reply.github.com>
wrote:

> >
> > -#define CAS_MAX_RESPONSE_SIZE 16384
> > +#define CAS_MAX_RESPONSE_SIZE 65536
>
> I cannot find an authoritative source, but it appears other vendors start
> with a default of 64k.  Note your comment in MAS-66 suggesting 16k.
>
> I'm expecting an increase use of SAML to deliver other security tokens --
> e.g., interop with ADFSv2.  So, I don't think 64k is unreasonable ... but I
> do think it could turn out wasteful for the more common cases.
>
> On Thu, May 10, 2012 at 6:24 PM, pames <
> reply@reply.github.com
> > wrote:
>
> > >
> > > -#define CAS_MAX_RESPONSE_SIZE 16384
> > > +#define CAS_MAX_RESPONSE_SIZE 65536
> >
> > Nice thing about keeping it in the stack frame is that it just gets
> > allocated inherently.  Simpler code overall, and we don't introduce any
> > overhead to reallocate, etc. Plus if someone is shipping you more than,
> > e.g. 16k of data then there's probably something very wrong (or you have
> a
> > ridiculous amount of attributes).
> >
> > I don't think the overhead would be much but I don't think the extra
> > complexity really warrants it when we're talking about a fairly well
> > defined response with a size limit we can pretty reasonably cap.
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/Jasig/mod_auth_cas/pull/33/files#r805390
> >
>
>
>
> --
> matt@forsetti.com
> Key ID:7208B5B4
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Jasig/mod_auth_cas/pull/33/files#r805444
>
I don't see this filter being applied elsewhere. Presumably this does not affect any of the callers?
die email / der user existiert bereits, also kein fehler. deshalb ein response 200 - da aber ein redirekt benötigt wird mit der angegebenen message 304
Instead of has...

Human human = entity.get(Human.class);
if (human != null)
Use function statement since this is used on all other functions.
not really know
Because there's a validator which asserts that the `name` of the package is unique. When we're updating a package, the package is already in the database, so this constraint fails.

I've circumvented this by validating only the property which we're updating and simply found no better way yet.
fixed in push
@vesak Mun mielestä tätä käyttöliittymää ei sais näyttää jos tällä kentällä ei ole mitään virkaa. Eli näytetään VAIN jos if ($yhtiorow["tee_osto_myyntitilaukselta"] == 'V' or $yhtiorow["tee_osto_myyntitilaukselta"] == 'W') {

muissa tapauksissa $tyyppi = 0;
wat? ``self.all_languages = map(str, self.all_languages)``.
I would update this comment to match the module.
Does `fieldSettings` always set (i.e. not `null`) ?
This is the default function, just drop it.
spaces around % operator
Please add a space after `r,`
remove blank line from the end of the file.
Mozilla.org is a static site and we dont' write anything to it so no need to mark it
where oh where has my manifest gone, where oh where could it be?
dunno if this would make it appreciably faster, but you might declare `i` and `ntype` a few lines up near reply. I'm pretty sure you've put these variable declarations inside of the if statement because they aren't needed every time you need to parse a result.
Missing an entry further down. I'll add that one.
Could this be added as `s.add_development_dependency 'globalize3'` in the `friendly_id.gemspec` file instead?
Please get rid of these and use `time_series_domain`.  Example:
```python
from ion.services.dm.utility.granule_utils import time_series_domain
tdom, sdom = time_series_domain()
```
Why 5.times?
Ah, then it should be fine. Thanks for the clarification!
Just wanted to mention that this is shiny.
http://rails-bestpractices.com/posts/61-simplify-render-in-views

```rails
=render :form, munoh: @munoh
```

こんな感じで、シンプルに書くといいんじゃないでしょうか。
seems good like that, actually.  I'll change this in my commit.
this condition is wrong, as it take into account only compute resource based vms, not bare metal.

I guess we can extend the can be built method?
Yes, like using a conditional variable. But this is not that `busy`, CPU load never over 1%, so I just take the simple way.
Lines like the above look to be hand-formatted. So I would feel bad the next time I work in this file and hit Control-Shift-F (to auto format) before committing.

Usually for formatting:
tabs -> fail 
hand formatting -> warning (that is a warning that you are working too hard - and that I may wreck the hand formatting next time I use the file)
Idk, As far as functionality is concerned I don't think it makes a difference, but it does keep the debug log free of irrelevant errors. I'm not sure if detectWeb exceptions are reported to zotero.org. I don't think they are.
This seems possibly application specific? Perhaps a yield if a project wants to specify this value?  Though, I am slightly confused why you would want text and the logo here definitively.
Does this weight the problem types, so ones with more data-weight are chosen more? (never seen this before)
Ok, I'm puzzled. Why is ```has_job``` a list instead of just a boolean ?
And why not just check ```self.has_job_lock``` ?
blah blah blah7
I agree with the use of empty, but the conditional needs to be `!Ember.empty(id)`. I'll be glad to merge your PR if you make this change and squash your commits. Thanks!
Unnecesary foreach
@josegonzalez  Sorry, not sure what you mean?
I'd prefer being consistent and *just* using the source path, which is how the user lays out files (and edits them, etc) and let the details of how Middleman transforms them into different paths be completely separate.
Think this locator will pick up the categories too. Should be `#side-explore`
imo this wait is implied so you can move it inside `click_x_page` so it's called every time. It can probably be private too, if that doesn't affect any other tests.
A comment here might be helpful about why we're gsub'ing.
`@deepEqual` would be better here.
See ShadowTypedValue.java for code to do the conversions.
On Mon, Jul 30, 2012 at 03:14:09PM -0700, Chris Price <reply@reply.github.com> wrote:
> > @@ -657,6 +668,24 @@ What username to use when connecting.
> >  
> >  A password to use when connecting.
> >  
> > +`log-statements`
> > +
> > +This should be set to either `true` or `false`.  If `true` (which is the default),
> 
> I haven't benchmarked it.  I can include that in the other benchmark card if you like.  My one concern was that I've seen some amazing performance hits in Java apps that are doing a lot of debug logging--even when the log level is set to something less fine than DEBUG--because it still constructs all of the strings for the log messages.  However, I checked the source code for our connection pool library ("Bone"), and they are doing "if LOGGER.isDebugEnabled()" before all of their calls to the logger, so that should alleviate that concern.
> 
> I'm happy to pull this out of the config if you prefer.

That would be my preference, yeah...less options for the user to deal
with, and our code becomes simpler because we can just assume that
feature is always on. Feel free to say "told you so" if users want a
way to turn that off. :)
why do you have a double "0"?
Hmm, out of curiosity, when an `error` occurs, does the stream get closed / destroyed on its own? If so, does the `close` event get fired?

I'm wondering if the callback could end up getting called multiple times, and/or if there is a resource leak here by not destroying the stream.
This can just use the dropColumnFamily function.
Also, is start / limit implemented here? If not, please document that it's not supported yet.
We discussed this in IRC while discussing the schema.js file. Looking forward to it, because I think error-message-sniffing it's in 2 or 3 different spots right now, and I'd rather consolidate all our hacks into one easy-to-hate location.
rename this to ``initialBehavior``
Oh, I see. Thanks for the clarification.
Yeap, touché!
It's not supported by this provider.
Blech. I know rules exist that support the double-space, but I have always hated that. Nonetheless, the byte-for-byte license has been restored in all 10 of the files where my whitespace cleanup had changed it.
Ваша правда. Но в данном конкретном случае я долго думал :) и надумал раз уж я задаю сам эти массивы и точно знаю их длину и что она не изменится, то почему бы и нет.
Цикл for допускает объявление переменной внутри себя, можно поступить следующим образом:

for (int i=0; i<DNALength; i++)

Переменная i типа int будет доступна только внутри цикла, и уничтожится после выхода из него. Так как далее вы с i ничего не делаете, то это будет идеальный вариант.

Заметьте, что я использовал некую переменную/константу DNALength - это довольно удобно, я могу использовать её везде, где мне нужно использовать количество элементов, но поменять потом нужно будет только значение этой константы/переменной, в остальном коде не нужно будет ничего менять!
Не совсем уверен, что такой подход не приведет к выходу за пределы массива!  Что будет при 100% мутации?

Всегда ли будет генерироваться случайно 0? Вот тут: i+=arc4random()%j; ?

Потому как после обязательно будет i++! 

Тесты делали - сколько именно элементов заменяется? Например, при 99% мутации?
В С/С++ есть оператор ++, который делает то же самое, только писать меньше. =)

`count = count + 1;`
и 
`count++` 

идентичны
Спасибо, здесь понятно, просто я думал, что возвращаемое значение переменной должно быть точно таким же, как и тип переменной.
Спасибо. Поменял сравнение на isEqual
опять таки, массив инициализирован с единицы. Может все таки лучше инициализировать с нуля и избежать путаницы?
We use 2 space indents
done ! :)
Is there really a dependency on angular?
I would change it to:

``` javascript
this.$('.selected').removeClass('selected');
```
I'm wondering whether it'd be possible to namespace this into the captionator object somehow.
Should the ____i18n____ markers be put into constants?
Testing comments in line
No, it's leave the be, not add it. Just demoed locally.
The examples here are still showing `nil` termination. It might also be worth documenting that it's not necessary (since it usually is for variable argument lists).
Isn't this exactly what autoreleasing is for? We should build on top of that mechanism instead of trying to implement it ourselves, since it's mostly guaranteed that background queues will have autorelease pools.
they will now read: (AbsListView view, int firstVisibleItem, int visibleItemCount, int totalItemCount)
这不错， 原来还可以这样些。
@jsteffen Just a clarification question before I merge: you changed the order here in which the storage object and the resource data are saved. Does this new order still work correctly with the indexing (which is fired right after the storage object has been saved)? I could imagine that the index would not contain changes that have just happened in the `resourceInfoType_model` instance, but maybe I’m mistaken?
use your constructor properly now :)
What do you mean?
This has a different meaning. It returns None, of no data is fit which is
used by some catchers. Note that self is our ICA instance, this is not
about sklearn. Makes sense?


On Fri, Dec 14, 2012 at 6:29 PM, Eric89GXL <notifications@github.com> wrote:

> In mne/preprocessing/ica.py:
>
> > @@ -769,6 +770,24 @@ def pick_sources_epochs(self, epochs, include=None, exclude=None,
> >
> >          return epochs
> >
> > +    @property
> > +    def mixing_matrix(self):
> > +        """The ICA mixing matrix"""
> > +        if hasattr(self, '_unmixing'):
> > +            out = linalg.pinv(self._unmixing).T
> > +        else:
> > +            out = None
> > +        return out
> > +
> > +    @property
> > +    def unmixing_matrix(self):
> > +        """The ICA mixing matrix"""
> > +        if hasattr(self, '_unmixing'):
>
> Same idea here.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/264/files#r2422875>.
>
>
method name do not match
can you make sure the ylim for both plot_evoked are the same? it makes the comparison easier.
I re-read what you wrote and decided it sounded compelling. So I ditched the exception.
`#where` won't work with rails 2.x
this seems like more of a css-related concern than a JS-related concern
as above, I believe it should be just `to.equal 20`, please change this everywhere as well...
Yes I agree that there is an issue here. The previous scope are additive (although it's a bit weird as there is an odering issue).
At the same time if you use a query, then the scope does not mean much anymore. This would generate more parameters which don't make sense in many cases.

A better solution might be to write a different API -> searchByQuery
The current search could still be enhanced to allow text search using lucene with a "type" query but the same rules concerning the scope.
This discussion will be added to my mail to the dev list.
All of these needs docs
Shouldn't merge be a method on Gossip?
Порядок инклюдов, ну.
I don't get why you put "ebx" here as a clobbered register, when this (I think, at least) violates -fPIC.
Yes, thanks for pointing that out.  I will change my test to something like: subject.should_receive(:fetch).at_least(1)
I would not have thought to do it this way.  Cool!
I think the AIT interrupt should be the last resort, and it should warn if it sees any live threads - just like TestCacheManagerFactory.
This method is not really a test, so we should avoid naming it as `test...`
I copied the code from a Java class in hotrod-client and I just thought translating it to Scala would take too long...
not always: it is possible for the prepare to only execute after the breakdown service finishes. (My patch added a test which proves just that.) In this situation your fix would indeed release locks but would not remove the transaction from the tx table.
I've added https://github.com/infinispan/infinispan/pull/1396, as this check was already in place in our code as you'll see. Just that it wasn't present in the right place.
Style: add a space before the asterisk, and [remove the space after the cast](https://github.com/github/objective-c-conventions#expressions)
I mean it seems like the property should be exposed as `const git_diff_delta *` or something like that.
Objects returned from `+alloc` should never be used directly. This needs a call to an `-init` method – probably a new one added for just this purpose.
Make a new commit, push to origin. (The power is in your hands!... scary, huh?) :)
`console.log` does not work on Internet Explorer
Может быть заодно тогда привести к одному виду аргументы методов класса? $primitiveName или $name ?
Oh -- another issue -- if the startup tags never get populated at all (which they were not, previously), then they are not startup_tags, they're useless_tags. ;-) It's a good thing they're not used anywhere!
Why do you replace 
if cond
...
 else 
...
with cpmd ? ...  : ...

After that change line is to long and goes out of screen. This is equivalent expresion, so why it can't stay as author it wrote?
Proč tohle?
`@experiments.insert` only works if there isn't already an entry for the given experiment; `set_experiment_enabled` might be called first and create the experiment.
There's a new serial function call, WT_SYNC_DIRTY_DISABLE, that's called when checkpoint needs to turn off writes -- the reason is we have to wait for the LRU eviction queue to drain, otherwise I believe there's a race between a sleeping thread about to evict a leaf page and a checkpoint thread writing an internal page.
I'm not sure if my change here to `warn` was correct, I thought that since it's inside a `catch` it should at least be a warning, it's not a simple log msg...
- Are you sure ``new \Symfony\Component\C...rayInput(array('list'))`` has the correct type as "object<Symfony\Component\Console\Input\ArrayInput>" is not a sub-type of "object<Symfony\Component\Console\Input\InputInterface>"? Please also check line 39.
- Are you sure ``new \Symfony\Component\Console\Output\NullOutput()`` has the correct type as "object<Symfony\Component\Console\Output\NullOutput>" is not a sub-type of "object<Symfony\Component\Console\Output\OutputInterface>"? Please also check line 39.
Are you sure you want to override the parameter ``$predicate``? This often makes code less readable. I also found this on lines 144, 146, and 149.
"alook" => "a look", maybe "take a look"? My english is a bit rusty :P
Jumping in here: why pass all arguments?
The current synonym seems to have "syn-optional-parameters" showing that Dart doesn't make arguments optional unless you explicitly request this. C# does this too (but with a compile error instead of a runtime error). It looks like "syn-default-parameters" and "syn-named-paramters" are to show how the named/optional args are used.
I was in two minds about whether to put it in Text, and from looking at it that was more aimed at larger bodies of text.
But i'm happy to move it to the Text extension for the sake of brevity.
Yes. When implemented, this method could throw SQLExceptions if needed. Caller would need to either catch, or declare that it throws as well.
I think you could make these two lines and make Jenkins happy.
I think we are moving to using PHP_EOL. 

What woudl happen if you had 
$q->select($db->qn('id)');
$q->from($db->qn('a');

rather than writing out the whole thing inside the select?
ah doh .. misread the diff
Good point. Whatever you decide is fine (random, or a specific port)
Linkify?
Definitely agree, we really should be hiding XSL files by default. Quite often you do encode business logic into templates such as `if` statements deciding what certain user levels can see in templates, or quick and dirty password authentication. The system should only ever expose the processed output, not any of the raw inputs.
hmm.. whats the meaning of this one? it would convert it to an array (which was not there before)
Чувак, что за названия. Как буд-то опечатки.
(Ehm, probably at the bottom of the file, after you define them.)
Does it look understandable now? For me not. :-) I have been updating that my commit comment a bit. Maybe you have missed the last version?
Prefix!
I set our application to have 2nd level access. We always go to authenticate our user, and Twitter does the rest So if Twitter sees that user didn't authorize our application yet, it redirects her to authorization link, and says that application will have permissions I mentioned above (so posting Tweets also). Next time user wants to login, it will redirect her to our home page and she'll be logged in.
*verification* != *potrditev*

I would use *vnesi* (we use *ponovi* above). We want to be more personal.

*V izogib napakam ponovno vnesi isto geslo kot zgoraj.*
Above works.
This is not the best way. Better would be to define a simple base class with few methods. And each of them have methods to retrieve data, and also to tell which language is for. Then you just have a list of those classes. And then a function which returns list of supported languages based on those registered classes.

In this way, new language can be made only be creating a new subclass of the base class and adding to the list. It is not necessary to go all around the code and search where it should also be changed.
Is it ok syntax-wise and style-wise?
Why do you pass tempDamage as a reference, if you are not going to use it afterwards?
me beeing checkstyle-> this.readBarcode();
Yep, entities depending on the module isn't helpful. I'll leave it how it is.
Ok, I agree with you. I have just pushed the changed as you have suggested.
TRUE.
thanks Bill. +1 for the patch.
Legacy reasons. Removing.
So... should I change anything here ? The more I look around `client.js` the more confused I am about the syntax :\
Only realized that now, but i think it would actually make more sense to do that branch check only once instead of in each scroll event, e.g. implement `_get_lines_from_delta` platform dependent. But only a detail.
`} else if {` - saves a level of indentation.
Type mismatch, check for NULL.
Fits on one line.  Probably true elsewhere.
I usually compare `object_id`s for cases like this where you want to make sure you don't get duplicate objects.
Regarding your old an messy code, I think you target old and messy browser, so please use a web safe color.
Oh, darn, well in that case ignore me.  I would therefore need the objects to carry around the names of their parameters at the python level.  Cound this be done by making them some kind of readonly attribute?  Perhaps a _param_dict?

On 9 May 2012, at 10:33, Rachel Mandelbaum wrote:

>> @@ -11,6 +11,14 @@
>> 
>> typedef bp::return_value_policy<bp::manage_new_object> ManageNew;
>> 
>> +// Used by multiple profile classes to ensure at most one radius is given.
>> +void checkRadii(const bp::object & r1, const bp::object & r2, const bp::object & r3) {
>> +    if (!r1.is_none() + !r2.is_none() + !r3.is_none() > 1) {
>> +        PyErr_SetString(PyExc_TypeError, "Multiple radius parameters given");
>> +        bp::throw_error_already_set();
>> +    }
> 
> Barney: I'm not sure we're talking about the same things.  You said you never wrapped those methods, btu I'm saying they don't exist at all in the C++ (except for the ones for Moffat that I mentioned -- no other SBProfile has code that lets you reset the size parameters, unless I'm completely missing something).
> 
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/140/files#r796448

--
Barnaby Rowe

Jet Propulsion Laboratory
California Institute of Technology
MS 169-237
4800 Oak Grove Drive
Pasadena CA 91109
United States of America

Department of Physics & Astronomy
University College London
Gower Street
London WC1E 6BT
United Kingdom
LARTing myself for squashing my commits, making this harder to find.

This change came in via ec2d937, which looks like it came into my branch from master.
There is a lot of sophisticated code in the BrooklynMachinePool and MachinePool.
We really need non-live tests for the many different scenarios.
With that in mind, it will be possible to modify in small ways (if required) the MachinePool - perhaps we just need to pass in a mock for the computeService, or perhaps override a doCreate(), doDestory() and doListNodes().

That would allow us to test all the different scenarios, including blacklist, etc.
Is this because exec is more efficient than shell?
Feels a bit dangerous having both, but also useful...
If the user passes in an IP address that is malformed (e.g. "1.1.1.257") then I think this code will log.debug and then return null.
It would be nicer to propagate such programming/configuration errors as exceptions. This code risks hiding them by trying to work around them.
Whether it's a gstring just depends on how it was instantiated. Once it's instantiated, you can treat it just like a string I think. Do we deserialize gstring into a nice format?

But I'm not certain about that and don't feel strongly.
Yep, further down when it is used to parse the date, the PHP DateTime createFromFormat will let us know if the format is valid or not. I'm currently throwing an Exception if the format is invalid but will change that to InvalidArgumentException  which will also help with the unit test
Done. (at the time, I didn't need it, but did for test cases)
Use [validates_length_of](http://api.rubyonrails.org/classes/ActiveModel/Validations/HelperMethods.html#method-i-validates_length_of)
Another duplicated file. There is a `spec/spec/support/factories.rb` and this one.
murdered.
Indenting is slightly off here
think that space is a bit off :P
Not sure about this part. Need to think about this code some more.
This seems to have merge conflict syntax in here, will need to be removed
I know this is picky, but comments should end with a full stop and there should be a space between // and first comment letter
Icon states and colors need reversed here.  That or the actual sprites need reversed, in regards to names.
In my nav branches, I moved this logic to the pathfollower (which also is wrong according to the FSM/pathplanner/pathfollower model) because it really doesn't belong in manual control at all.

What would be better is a callback in the navigation routines that is triggered when the flight mode is changed. Then it can reside in the appropriate point. ManualControl module shouldn't be required to have any knowledge of the current vehicle dynamic state.
I don't see anything anything here which could prevent that no. The 'openpilot' plugin will just be replaced by a common 'fetcher'.
Ok, on reading your reasoning and rethinking a bit, I am convinced your approach here makes sense.  It is perfectly reasonable to expect a rest client to to have assembled information like this, as it is pulled from the api elsewhere anyway, and just represents the client's cache in this instance.  I still think validation of the provider type will happen when this post is made (say, in the case where the cached type has been removed from conductor), but this point is irrelevant other than for the todo comment
oops, I should've used RbTask.rb_safe_attributes
Ik weet niet zeker of dit helemaal klopt..
definitely. i did know that.
В этот объект, others, можно будет извне добавлять Extension'ы.
Don't forget to change this one to match #L5 above.
typo: s/visibile/visible
We should rename this to something more suggestive, like was_refound_successfull.
{note}Grails2.2.0ではdependencies.txtが無くなっています。{note}

という形で修正したいと思います。
- should be an emdash
variableq are renamed
> Is this a convention that absolute imports are acceptable in tests but not in
> other places?

Yes, because some people like to run tests as scripts.
Yes I think it is a numpy / scipy convention. 
Also it is sometimes necessary to parse the parameters correctly. It is not everywhere in the code but I try to correct it whenever I find it.
I wonder if the sub model instantiation should not be deferred to the `fit` call and the sub-estimator storing attribute be renamed to `self.model_`. That will require to store the model init `kwargs` as an attribute though.
=> Pass an arbitrary environment variable to pow, eg, ENV["BACON"] = "chunky"
No blank line as first line in a ìt`block
It does and I didn't quite think about that. I guess its better to say that GenericWeapon simply provides a forced reminder that this item will do damage and as such make sure you provide a way to get its' damage (and set other attributes potentially in the future).
Did we decide to move this under listener so that we could also support a similar option for providers/populating later?
Should we create a `bin` and allow it to be installed globally? Seems potentially useful.
Je trouvais que ça relevait plus du trésorier que du model DocEtude,  mais effectivement c'est peut-être plus légitime de mettre ça dans le model.
Done
Instead of your change below, this line should probably get changed to: 

if((len(parsed_request) == 1) and (type(parsed_request.values()[0]) == dict)):

The reason this is here is that I'm allowing for clients like AcitveResource that want to send something like {"target_image":{"foo":"bar"}} when all we care about is {"foo":"bar"}.
Do you mean something like:

```ruby
class ActiveModelTest < CassandraObject::TestCase
  include ActiveModel::Lint::Tests

  module ::ActiveModel::Lint::Tests
    def test_to_param
    end
  end
end
```
don't use assert - use assertex.
Also don't check row is non-null
Let me try a few things. CMake doesn't allow for optional args by default. I am going to try with a check for the second arg being set if it is not set, I will try to force to build in the macro.
What are the benefits of having IHpccPackageMap defined as a member rather inheriting from it.  Should it be an isA relationship?

Same for IRoxiePackage below.
There is no guarantee that the installGitFileHook() is only going to be called from startup code.
I know this was the original code and not your fault :) having these two almost-identical for-blocks seems ugly. It's not trivial to replace this with a list comprehension or filter/lambda etc. since we want early termination (the product and version names will be repeated several times in the rather ugly JSON format we are dealing with).

I think http://tomayko.com/writings/cleanest-python-find-in-list-function would work though.
I fear this needs to stay here, because only after it is rendered, jQuery can determine if somethin is :visible ...
Then I propose to move this class in the bundle. Now it is unnecessary and its use can cause problems
I don't know I usually treat text in parens as optional so I could read this either as:
"return value or throw ..." or in more details as "return fulfillment value or throw ...".
Reading it as "return value fulfillment  or throw ..." does not makes sense to me, but
I guess you could read it other way as well. So I prefer this form but also fine changing.
Isn't there a missing `return` ?
Similarly, should this throw an exception here rather than failing silently and returning an empty string?
There is an edge case we need to consider, when the specified propertyName does not exist, we will return 0. How can the consumer of this function distinguish between a configured 0 and a missing property scenario? I would recommend to throw an exception when the property is null, return 0 only when the configured value is 0.
Sorry, in the event of null, don't think I was totally clear
The code all works well. 
My suggestion is to add this._super() in line 30 of tests-main.js file.
Extremely minor, but probably just needs a space after the "+"
It seems weird to statically initialize parameters of a class, and then create an instance of it. Why not instantiate and then initialize?
wow... how did this even work
I don't like this construct; what if `@base64` is `false` as documented on line 84?

The logic to base64 decode based on the value in `@base64` should be pulled out into a separate method, since it's also used on line 140.
You have two options here.

Since success is boolean, it has only two values, and a simple else should suffice instead of re-evaluating success (which is also a typo).

However, since this is assumes success is boolean, being explicit could be appropriate with and elsif !success
Yes, the squaring. Will do.
Nevermind, I didn't notice the call to `save` above.
hmm not sure what i could sensibly explain here .. obviously we need to add something to the actual docs. but imho its quite clear when to use this .. whenever you want to use MultilangRouteRepository.
Hey dude, I go back and forth on this one.  To me, the quickstarts are about 'the simplest thing that works'.  To me, adding an extra class kind of detracts from that. Are you ok with not adding this?  Your call boss
In general, I'm not sure that I buy this computation at all.  How is better than the previous computation?  Why can't we treat this exactly like capacity in an `std::vector` and have a sensible default initial size and the ability to override that at construction?
Okay, but should we have a separate constant for whatever this usage is though?  Seems bad to have the same numberic value in multiple places.
Use `defaultValue`.
A separate bug has been filed [TIMOB-8490](https://jira.appcelerator.org/browse/TIMOB-8490)
It would be simpler to put the ui and backend code in one directory. I'm not sure there is a lot of value in separating it. Maybe just put everything in the "src" directory.
@AndrejMitrovic uhm I didn't know that ever worked. But byte[0] is not a zero-dimensional array, it's a 1-dimensional array with length 0.
I'll remove the entire statement then. Thanks.
I think it's a bug in terms of version statemens and forward reference interaction.
 In other words, if there was only one plain version of struct DirHandle being forward referenced  then it would work, right?
I thought because we don't have the information before run-time but just now I realised that we don't need that. Will change that.
load from a config file? blueprint? somewhere else instead of hardcoded
Addressed in Rev 86d14f2. However I would like to say  a) isMencoderDisableSubtitles implies mencoder only and b) even though the checkbox is in the Transcoding tab, the event handler is defined in the Mencoder class. This means that when the mencoder engine isn't loaded (had some issues with the executable at first), the configuration option is broken.
do these tests need to be removed?  they passed on Travis-Ci.
I can't come with a better solution by now
More like: `>=2.1.x,<2.3-dev`
please remove this line, see comment above.
to do?
You may want to test for mime types here as well
I see this is a actually a python extension, it has a setup.py.

You should use this class, so it will use the setup.py and PYTHONPATH will be set correctly.
Also add python as a dependency, you can still use the dummy toolkit if you add the toolchain as a verion suffix to your python dependency.
Someone please confirm that onsite experiences no changes as a result of this pull request, and that all of the changes apply only to studentreg.

I only hide the Javascript, which contains all the logic of the confirmation boxes. Since the divs with the confirmation box content have a style of ```display:none```, they shouldn't appear in onsite, even though the HTML code will still be included.
So Prototype (I think) does this weird thing where it adds the function "indexOf" as the last element of the array. I think it also overrides the 'in' keyword, or something similar, such that iterating over the array works normally, but for some reason this breaks in IE. I remember having this issue before and fixing it this way in a few other places. I'm not sure if there's a better general fix.
In my case I still use 2.0, so the code is still valid but it can be updated for 2.1.
That was copied from Version, maybe it should be changed there too
changed on my side now
`->` на предыдущую строку.
It seems as though the passing of parameters to setTimeout doesn't work in IE

https://developer.mozilla.org/en/DOM/window.setTimeout
indentation looks broken
Good point; I'll revert this line and create another JIRA
there's an open single-quote but no close
snapshot?
Hello, Gary.
Thank you very much.
It was just simple copy-paste ;-)
I think we should say a note about evaluation context limitation here.
So, I'll push it soon, if other guys don't mind of this changes.
Now I’ve exposed my two points fo view, I’ll let you guys choose what best serves the purposes of your tool.

If I ever can contribute on IONauth, I will, thank you for doing this.
I think these need to be valid class names as well.
Please add:

    labelLayer.shouldRasterize = YES;
the php type will be int, there is no double in php
Similar thing here:

```ruby
context 'ApplicationController already defined' do
  before { class ApplicationController < MockController; end }
  after { Object.send(:remove_const, :ApplicationController) }
  subject { lambda { MockController.send(:include, GoogleAuthenticatorRails::ActionController::Integration) } }
  it { should raise_error GoogleAuthenticatorRails::ActionController::RailsAdapter::LoadedTooLateError }
end
```
This might be used (otherwise it will be removed).  See my comment above.
> This is something else then. A list of references probably.

Then it seems that using the index will always be the right thing.


>Hm, but index within the list is changed when you have sorted list, no?

Only when dehydrating, not when hydrating. So using the index of the last item is correct.
this one..
This method is really hard to digest, can you break it up into methods?
namak roo zakhmam napash dige !
you are using the same name as the url defined starting line 16. Using the same view is valid, but the name should be different, consider renaming the url at 16 to get_next_questiongroup_with_order and this one to  get_next_questiongroup_without_order, otherwise it will cause confusion when you later try to do url reverse against this name, and get the wrong url returned to you.
Need to add the following method for eclagent / roxie spilling sort support

    inline const void * * getArray() { return rows.getArray(); }
I think that was before the throw, when the call might have failed and there should be a guarantee that the string would still be null terminated at a decent place. I think it's redundant now for the Linux case, probably also so for the Windows case, too, now.
whitespace >>
Also code is deployed onto utility instances
+1

The only problem is that it creates a circular dependency.  I wish it was easier to yank a part of an existing Django app out into its own app, but migrations would be a pain.
тут нужно слово persistent либо еще один namespace либо внутренний
The GNU suggests `locale` Gettext follows:
http://de.php.net/manual/en/function.gettext.php#59589
But we don't need `LC_MESSAGES` if we don't use Gettext natively
I think this should be `else if(showDialog)`
contentTypeSelect is only changed if the not-equal-to-one conditional is achieved.
Just so I can have some context, can you explain what 0x610BA11D is used for?
Sent on the TELUS Mobility network with BlackBerry
Thats what I meant, for all the UI resources. This way you won't need to have it for all of the assets that get compiled into one thing
Docs ?
ich dachte, assert kann auch mit exceptions umgehen?