flag selenium gradebook2 comment spec as pending

the test frequently fails when executed on aws

Change-Id: I70b1ea54b085754591e5ce1233ede3ce3c1c4dad
Reviewed-on: https://gerrit.instructure.com/8153
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jake Sorce <jake@instructure.com>
modified selenium specs for IE

Change-Id: I61645b4d6fd54e96b0af186e532ef09e3f43e190
Reviewed-on: https://gerrit.instructure.com/8090
Reviewed-by: Bryan Madsen <bryan@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
process page views from redis in transactional batches

This should make the database much happier

test plan: turn on queue mode for page views, generate a few page views,
and verify that they're still stored to the db after the job runs.

Change-Id: If90b543b805c7f599ce1865b669d4943cafb220d
Reviewed-on: https://gerrit.instructure.com/8161
Reviewed-by: Zach Wily <zach@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
process page views from redis in transactional batches

This should make the database much happier

test plan: turn on queue mode for page views, generate a few page views,
and verify that they're still stored to the db after the job runs.

Change-Id: If90b543b805c7f599ce1865b669d4943cafb220d
Reviewed-on: https://gerrit.instructure.com/8161
Reviewed-by: Zach Wily <zach@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
fix sizing on external tool buttons

tinymce buttons are by default 20x20, but the external tool
icons are expected to be standard 16x16 icons, so they were
getting stretched. This fixes that using css to add some
padding for external tool buttons in tinymce.

fixes #6937

test plan:
- configure an external tool with an editor button on a course
  (like http://lti-examples.heroku.com/config/editor_button.xml)
- go to the rich editor in that course
- make sure the icon isn't stretched and ugly
- make sure the rest of the styling for the rich editor still
  looks the same

Change-Id: Ic46e37a812c20f70c00771cebe4e5cb9ccadc5f3
Reviewed-on: https://gerrit.instructure.com/8138
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
support https for retrieving lti xml configs

net http needs some additional config in order
to support https requests.

fixes #6938

test plan:
- try adding an external tool with an http url config
  (like http://lti-examples.heroku.com/config/course_navigation.xml)
- make sure it adds correctly

- try adding an external tool with an https url config
  (like https://lti-examples.heroku.com/config/course_navigation.xml)
- make sure it adds correctly

Change-Id: Ia26c7d383069bccf761f18a2993f352002cc868a
Reviewed-on: https://gerrit.instructure.com/8139
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bracken Mosbacker <bracken@instructure.com>
breaking up selenium wiki_spec

Change-Id: Ib229227d7755c25a4c95eab8cd18efd62d45e680
Reviewed-on: https://gerrit.instructure.com/8110
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
conversations, fixes #6594

Test plan:
- send a message to multiple people you have not previously had a
  conversation with
- observe that the message was successfully sent (but nothing is added
  to the conversation list)

Change-Id: I3b3b57a58faa10bfeb3067112810226434ffd532
Reviewed-on: https://gerrit.instructure.com/8001
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
fix conversation loading errors, closes #6812

Change-Id: Idaafd241be4dfa62197245e792342d11a1cc046e
Reviewed-on: https://gerrit.instructure.com/8109
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cameron Matheson <cameron@instructure.com>
updated selenium specs to use assert_flash_error and assert_flash_notice

Change-Id: I622214e35944a62acdb0324181a83926769f60d1
Reviewed-on: https://gerrit.instructure.com/8164
Reviewed-by: Bryan Madsen <bryan@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
show muted assignment indicator in gradebook2

there was already a tooltip as you hover over
each submission and the header menu let you mute/
unmute but I guess people wanted to see the little
'muted' icon in the header as well

in the process I broke it out into its own
handlebars template

fixes: #6804

test plan:
 * mute an assignment
 * go to gradebook2
 * look for a little mute icon in the header of
   that  column like on gradebook1

Change-Id: If728a4f11241440d377264123c0824edf05f12b3
Reviewed-on: https://gerrit.instructure.com/8114
Tested-by: Hudson <hudson@instructure.com>
Tested-by: Jake Sorce <jake@instructure.com>
Reviewed-by: Jake Sorce <jake@instructure.com>
show outcomes from all associated accounts; fixes #6800

we were showing outcomes for associated accounts for course contexts but not
sub-account contexts. now we are.

test plan:
- create an account level outcome
- create a sub-account level rubric
- click find outcome criteria
- ensure that the account level outcome is available

Change-Id: I64a8feacadecd3bbc12eedc3c1c5ccea9b16360c
Reviewed-on: https://gerrit.instructure.com/8125
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
added js_env view/controller helper

this helper is the mechanism to send data from
rails to the JavaScript w/o requiring an xhr
or dumping data into the DOM and pulling it back
out /barf

you can call it from a view or a controller

test case:
1. call `js_env :FOO => 'bar'` in a view or
   in a controller
2. load the page
3. open the web console and inspect the ENV
   global JavaScript variable
4. ENV.FOO should be 'bar', wassupnow?

Change-Id: Ie079ba0ee610fc6a9e837cd1301ee29b08201e65
Reviewed-on: https://gerrit.instructure.com/8170
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Shaw <ryan@instructure.com>
clean up wait_for_dom_ready in selenium files

Change-Id: I3265319a5b31ea778aa881ee7582eab66c517dbd
Reviewed-on: https://gerrit.instructure.com/8176
Reviewed-by: Bryan Madsen <bryan@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
selenium file cleanup

Change-Id: I34431e9fcdd05626e0f7d2b9ecfe8d760a8145ee
Reviewed-on: https://gerrit.instructure.com/8174
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
fix invitees visiting unpublished courses

don't try and accept! (or reject!) when they're not actually invited.
only show "invitation accepted/rejected" flashes when it actually
happened. don't allow previewing invitees to see unpublished courses.
don't show invitation related flashes when displaying a "you can't look
at this" page. fixes #6708.

test-plan:
  - create unpublished courses in the default account and in a
    non-default account
  - create a user for each course and invite them as students to the courses
  - try and visit the courses as the respective students
  - both should see the "this course hasn't been published yet" page
  - both should see no flash-notice on that page
  - neither should be accepted to their course
  - create a user and invite them to one of the courses as a teacher
  - try and visit the course as the teacher
  - should not see the "this course hasn't been published yet" page

Change-Id: I5e6ce4541621bdc3d6dac0efe62a2741f7addabf
Reviewed-on: https://gerrit.instructure.com/8079
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
unpublished quiz preview fixes #6528

previewing the quiz is posted, and then redirected
with a get request but the preview parameter was
not passed through to the redirect, now it is.

test plan:
1. start a new quiz
2. add and save a question
3. click 'preview quiz'

you ought to be able to preview the quiz

also fixed the spec to check for the presence of
the questions container, rather than the title
since the title is present whether you're able to
preview the quiz or not.

Change-Id: I87a3a179ed79f464b7c765c9f23ba48226bb86ca
Reviewed-on: https://gerrit.instructure.com/8099
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
added resize_screen_to_default to wiki_and_tiny selenium spec

Change-Id: I4876093013b180832dd5ff54647c036615f19a78
Reviewed-on: https://gerrit.instructure.com/8171
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
improve error reports categories query on postgres

postgres can't/won't use the index for a DISTINCT query, so be a
bit more explicit with it to get it to use the index

test plan:
 * go to /error_reports
 * it should load fast, there should be a categories dropdown,
   and it should have a few things in it besides all categories
   (assuming you have some error reports)

Change-Id: If7c71cd669e7eadc1792eefe1fb6e85a08c054ed
Reviewed-on: https://gerrit.instructure.com/8190
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
cleaning up sleeps in manage_groups selenium  spec

Change-Id: I30560891cdbc8732bfc354468e8489d589ec788d
Reviewed-on: https://gerrit.instructure.com/8175
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>