labofsahil/github-event-dataset-2012 huggingface dataset:
I'm not sure about most of the expr->isDictionary() calls in this file.  I don't think any will cause any harm, but they may make the code more confusing since they will never be hit.
`testChangeSet` at least seems to pass even _without_ your changes in `src/main` so I am dubious about the need for this pull request. By the way is there an associated JIRA ticket?
I would much prefer to see all of these settings in base.py instead. 
Most people won't need to override them and if we decide to change them, everyone will have to be notified to copy from the latest local.py-dist.
The commit I'm pushing in a moment is exactly doing that ;)
I wonder if it would be better to strip the leading P from Postbank account number. Is there any overlap between Postbank account numbers and the account numbers of other banks?
Should we be careful here and read from our copy of the URL?  In the past, we've experienced segfaults reading from the request itself.  Of course, since this is a synchronous call, perhaps it doesn't matter.
I push a little bit too early, all should be fixed now !
We have similar functions, but not exactly the same. For instance: https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/utils/data.js#L48
except that the code there does something with it to set it in some cases
I put this here despite the fact that it turns off all popover titles everywhere... That's not ideal but I can't work out where the popover is inserted into the DOM by bootstrap so I can't seem to target just these popovers. Any ideas?
starting_date doesn't mean what you think it does... it's used as the basis of deciding what is tomorrow (so that tests work even when the dates aren't current). It doesn't mean "show me tasks from this date". Once we need that feature, we'll rethink this code.
no general references pls
if res and res.body ....
Homology is a technical phrase, so if you want to use it here, define it as well.
These lines are all identical. This method might help:

    def add_role_to_failure_message(message, adverb)
      if role_used?
        message << " #{adverb} #{@options[:role].inspect}"
      end
    end

(Or some other abstraction.)
That's not good. That means our JSHint checks aren't looking for it. We need to address that. We'll have to pre-announce that change in the ZAM forums.
Maybe this will be 2.3...
You should remvoe this file as it seems unrelated to the logging quickstart.
Consider making use of package visibility here rather than public; as long as your test case is in the same package it should work out fine and be more safe.


LegendViewFiltersHandler getFiltersHandler() {
DeveloperError no longer takes a second parameter.
Ha, that's true.  It will be become public in the terrain branch.
I believe the most precise name is "Plate Carrée" but "Geographic" is pretty good, too.  "EquidistantCylindrical" is long and uncommon.
Given that most functions require `isReady` to be `true`, should we:

* Throw an exception in those functions if `isReady` is `false` like we do with `isDestroyed` on objects holding WebGL resources?
* Have a factory that asynchronously returns the provider given the arguments of this class's constructor function?  If I really knew what promises where, I might suggest them here.

I haven't looked at the other providers yet, but I assume these comments will apply to them as well.
Why uses a separate name?  GLSL has function overloading.
Please check your indentation in al files
Should this `instance` also live on the GeolocationModule as an object instance? Again, trying to avoid keeping system resources in memory after all activities have been destroyed.
Don't need to add source and type for any events--these are inherited from Ti.Event.
There isn't a single code base now, and there probably never will be due to differences in base languages (Most platforms have a C-base, but MW is javascript and can't use anything else, obviously). Unfortunately we can't do anything about Window in MW because there is no such thing as a "top level control" in HTML...we just have divs and spans to play with.
again, this seems like extra complexity to me.
Yes.  The redis docs recommend everysec over always so I changed it.  Sorry I left it out of the description.
This should probably be a part of the arch independent spi.h interface...?
So we can implement the same for the lpc, see issue #147

@dewagter @gautierhattenberger did you have chance to look at this?
I imagine it's so it can be tested without quotes mattering.
And we expect the existence of the current_user helper
наверное лучше не использовать местоимения
This is my very last gripe: if sep is already an array of the right type, then `array(sep);` will definitly allocate for nothing. to!string will also call dup for nothing. how about something like this?

```D
static if (isArray!R)
    static if (Unqual!(ElementEncodingType!RetType) != Unqual!(ElementEncodingType!R)))
        auto sepArr = to!RetType(sep);
    else
        alias sepArr = sep;
else
    static if (isSomeString!RetType)
        auto sepArr = array(sep);
    else
        auto sepArr = to!RetType(sep);
```
woops, nice catch
mmm - seeting your use of cascades below, this might read better by doing 2 ..adds:
sb = new StringBuffer()
  ..add('#import("...")')
  ..add("#import("...")');
Because we don't have the information if a class is a model before run-time
If there are errors, we need to fix them, not hide them.
especially as you never use this
Should have a matching respond_to? here
You don't need parenthesis here.
it's not about see the structure. The db model is new in this release, and modified frequently. As it is there are 64 migrations in crowbar across the different barclamps. Since there's no expectation of a clean upgrade during the development cycle in any environment, the overhead of individual migrations is not really merited.
Wouldn't it mean you can leave the `llvm::` alone? You would only have to change `namespace llvm {` to `namespace llvm = llvm_30; namespace llvm_30 {`.
hm, this is the only thing that really changed, right? would have helped if you had committed the whitespace fix separatly ;-)

we should look at the network traffic when we try to create something that exists. the information must be somewhere, probably in the response content. maybe its all handled already by the request class evaluating the xml contained in an error reply from the backend - otherwise we would get failing tests. or did we disable some test for the jsop change?
extra indentation :)
Но сразу. Так как сразу — просто tabInserted. Если бы ты, например,
через сутки обнаружил, что таб ВНЕЗАПНО был добавлен хуй знает когда,
тогда и нужно было бы писать Was.
All these comments can probably be removed.
I'd double-check that #warning is a valid synonym for #warn which is the "canonical" way to do it.
The specs are green because we are mocking the call to #warning... so they tell us nothing about it being right.
That's done. I also update the rm/del commands as well.
In any case, the stripping should be done in the Abstract class (given that the prefixes are __added__ there, he should be responsible for removing them when necessary). If we leave it here, and we ever add another subclass, we'd have to replicate this code.
True, will fix that as well
Right, I understand that, but we usually use xxxSet for situations like this, but that would mean we'd need to reverse all the Asserts 

To me, Assert.state( ! this.redisTemplateSet...) reads better than Assert.state(this.redisTemplateNotSet...), but Assert.state(this.usingDefaultTemplate...) is even better.
This import was automatically added by Eclipse whenever {@link QueueContract} was pasted into the class comments. When the import was present, then Eclipse would provide autocompletion for {@link QueueContract#...} tags elsewhere in the file. This didn't seem to be required for the Javadocs build to succeed, but I left it in because it didn't seem to harm anything and it helped for documentation comments. It's clearly a non-comment and can be removed if it's an issue.
Actually that offset is not actually used by this, it is on the haproxy/db/block_device stuff.
Why bother changing the defaults? This might break things for people using other OSes....
My plan is to add the time span feature (from, to) to generate the demo data in a certain time span. This will be called in --demo also. I will rename dummydatastream command to dummystream and add  a clearstream command which will remove all data from the database.

On 29. 09. 12, at 12:19, Mitar <notifications@github.com> wrote:

> In docs/usage.rst:
> 
> > +    e - end time (in a number of seconds from UNIX epoch)
> > +    d - downsamplers, you can specify them to limit returned downsampled values to only
> > +    those, can be a comma-separated list or specified multiple times in the query; possible
> > +    values are same as downsamplers' keys
> > +
> > +For example, query to return minutes granularity with only average, min, and max values, could be::
> > +
> > +    /api/v1/metric/caa88489-fa0f-4458-bc0b-0d52c7a31715/?g=m&d=m,l&d=u
> > +
> > +
> > +Demo web page
> > +=============
> > +
> > +For a demo web page, start mongo database, go to the tests folder and run::
> > +
> > +    python manage.py dummydatastream -t "int(0,100),float(0,3),float(-2,2),enum(1,2,3)" -v 2
> You should faster fill the demo page. So every second or so. So that people can see changes fast. I left it running for some time and plots are still empty for me. :-(
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Darn, I just removed unused arguments in all datastream.js functions. PyCharm colored them gray, it was ugly. :)

On 29. 09. 12, at 12:21, Mitar <notifications@github.com> wrote:

> In tests/test_project/test_app/templates/demo.html:
> 
> > +                <tr>
> > +                    <td>Metric</td>
> > +                    <td>Granularity</td>
> > +                    <td>From</td>
> > +                    <td>To</td>
> > +                    <td>Elements</td>
> > +                </tr>
> > +            </table>
> > +        </div>
> > +        {% endif %}
> > +    </div>
> > +    <script type="text/javascript">
> > +        $(document).ready(function () {
> > +
> > +            var to = new Date(2012,8,19,12,0,0,0),
> > +                from = new Date(2012,8,13,12,0,0,0);
> Hmm. This is hard-coded? Is this why it does not display anything to me when I start with fresh database one?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
I did this 'trick' to be able to see the msg field as text and at the same time be able to download and save it's content.
@bp323 Added that in
I don't see it as polluting - these are features specific to Fody (I assume) and using the product name as a prefix helps for grouping these features together.
would it be better fileName rather?
Sure. See additional commit.
la fel și aici
change this to something meaningful (like in pull #27 for MohGenderRuleTest)
Good point. They should be.
Coding style is very important. Having things line up is very important

```javascript
                if (!value) {
                    value = editor.record.get(field.getName());
                }
```
Note that `contains?` probably doesn't do what you expect it to! The name is a bit misleading as it doesn't check for membership like `member` in most Lisps does but  actually whether a key or index is present in a sequence, e.g:

    user=> (contains? ["foo"] "foo")
    false
    user=> (contains? ["foo"] 0)
    true

You could use `some` instead.
will change here and on the backend.  (this is the new)
This allows httpd to read any directory on the system: not a good idea. It's the whole reason of using selinux...
If this isn't the recommended way, you could just put this in a 

    .. note:: 

block
Great. It sounded weird to me, but I left it so as to keep it similar to the other artifacts.
We should really trim all the console.log calls.  Or even use the logError utility function so we can disable for release.
noted tnx
please do the full initialization here for shape purposes. 

Also, since we are already including 'mimelib/content-types' (exposed on mimelib.cintentTypes too), please just throw that in, with defaulting to application/octet-stream.  MailComposer has a brief 3 liner for this if you want.
Technically we only need one of these, the 2nd definition with the "optional" argument is sufficient (you will need to check if the dictionary is null though)
Comment here such as `// resb.toString now "U go now.***********"`?
Next step here would be to setup a connector (mock) and actually invoke the openXLink-method there.
Should be fixable by concatenating the result of the i18n call in the array keys.  It won't be the prettiest code, but it will work.  I'll fix.
This if statement does nothing and should be removed.
This tag is designed to prevent an scm build from trying to initialize the git submodules. If this tag is not specified then the scm build will fail
make sure revision is not null
It should not be a class variable.  I originally had 3 methods one for clicking "Enrollment Home" button, one for search and one for view, then I put everything into the acal_view method.
with strings as keys and strings as values