labofsahil/github-event-dataset-2012 huggingface dataset:
Short answer is that `unify` shouldn't make this decision. Upstream tools should. 

It would be fairly trivial to create an evaluation rule with rules and have it go through and apply this transformation to clean up a tree.

In MatrixExprs I call a `.canonicalize()` method.
partition_from_rgs is no longer a function so it can be removed from the import
If, in B, you put the f_1 first I would have caught on to the correlation of the expression to the tuple faster.
If no ordering is guaranteed for the infinite lists either, then what is their use?
Быть может, вместо «аккаунт» говорить «учётная запись»?

И ещё какие-то странные формулировки «взимает плату за аккаунты» и «получить бесплатную учётную запись». Можно подумать, что это разные учётные записи — платные и бесплатные, хотя отличие, если я правильно понимаю, только в тарифном плане, который можно менять в рамках одной и той же учётной записи.
Вариант: «GitHub — это коммерческая компания, которая взимает плату за хостинг приватных репозиториев, но любой может быстро получить учётную запись для бесплатного хостинга любого количества открытых проектов.»
There is no need to return anything as it will always be true you can leave it out.
Why not always return an array?
needs to be moved to 1.1.13 now.
checkstyle demands this. I suppose at some point, I can turn that off, but I was aiming to finish the samples. :)
best to check all of these and make sure region is interface
What is the purpose of this change? Will this negatively affect the IO RC read-in?
I was confused by a test that was not really related to that. Moved back to its original place now.
Indeed, but this says if its the fact composer.phar isn't there or whether there was a problem with the composer files (composer.json and .lock)
c/to ``shared view/to this ``shared view``
lead burred. this is probably the only thing that users actually care about.
J'ai reussi de contourner le probleme. C'est quand meme une restriction un peu sale.
My point was you invoked this function but not each search backend defined it.
It's okay with me.
We would want to store full post subject to use it as a URL title later.
You are specifying 1) #darkenwrapper and 2) 3000.
Count the number of whitespace characters.
In order to have the `=>` aligned, all of them require a new tab.
What benefit would that give? The get_user() function also has a fall-back to anonymous in case the user does not exist.
I would suggest: `create_extension_metadata_manager`.
stopped should be declared in init like timeout.
sugestii?
why make a dict, when there is only one target?
Why only 20 here? I know it was 20 before but why isn't it 25 like everything else? I guess this is a question more for @dlecocq
ах. колко просто можело да бъде !
Подкрепям.
Do you want more explanation here in the test, as to what the test is testing?  Or what the workaround is doing in the workaround code?
Yes, null will work too.  I'll change.
jslint is fine with it (there's no dot or [^... )
AssemblyInfo.cs is blocked in the `.gitignore` file. You should _link_ in the `src/SharedAssemblyInfo.cs` file and put it in the properties folder
file.seek(32, os.SEEK_CUR) perhaps.
On Thu, Aug 2, 2012 at 5:52 PM, Łukasz Langa
<reply@reply.github.com>
wrote:
>> @@ -61,7 +61,6 @@ def _get_show_tabs(request, venture, device):
>>          tabs.extend(['history'])
>>      if has_perm(Perm.run_discovery, venture):
>>          tabs.extend(['discover'])
>> -    #if has_perm(Perm.read_configuration_item_info_generic):
>
> Why was this check removed by the way? Seems like it should be there.

I have no idea why it was removed, I'm just pruning trash code that is
commented out.

-- 
Radomir Dopieralski, http://sheep.art.pl
These are the active gets, not the currently active read repairs. Is there a chance, with enough gets starting at once, that no actual read repairs occur?

Say hard limit is 100, and 1000 gets start at the same time, by the time the first get decides to read repair, the `Actual` maybe way above the hard limit. Should we be using a measure of the active read repairs here? Is it OK since we have AAE now, as well?

Sorry if this has already been discussed somewhere, I don't know where to look for further context.
Where are you using this class?
Fixed in f8c94e4.
Could probably be a tuple now.
Yes - it was a note as to the GEO matrix options I wanted to cover, copied and pasted from a postgis or similar docs page - will strike
Óóóó, ebben már van Trait is.
just noticed this typo - s/Johns/Jones
Instead of aliasing strings, these could be symbols. `define BIN;`
Here I am checking for `np.memmap` and not `np.ndarray`.
Will this be exposed publicly?
Would you need to add a "LIMIT ALL" on Greenplum in order to have a deterministic order?
state.numGroups is of type uint32_t, so casting to int32_t is not a great idea.
comment seems wrong, it's the reverse of what is being tested
Good reason, but :(
the ``wrench`` module isn't used in this module
Du kannst per default enabled=$user->isAdmin() machen und setEnabled() ueberschreiben, sodass sie nur funktioniert wenn der user admin ist
wg Sinnhaftigkeit war ich selbst auch noch nicht überzeugt, daher hab ichs hier in den Raum gestellt.
Is this still used? Can it be removed?
I preferred the old variable name, `link`.  `l` is one of those ambiguous letters in monospace fonts, it very much looks like `1` and is [recommended against in PEP-8](http://www.python.org/dev/peps/pep-0008/#names-to-avoid) for this reason.
You need to add behavior to the code generator to detect these and blow up. Later you can support @ Element on generated code.
no, up above is a ifndef OMP where the gauge field pointers are set for the first time. this is because each thread starts at a different point in the loop and therefore needs to have these pointers separately.
k, hmm can't remember. It was @rwldrn that added it.
Although 3.8.2 was the last release of the project without org.junit packages, I'd have thought that we're still providing a 4.9, 4.10, etc, version of the junit.framework packages.  They're just not changing very fast.
Please fix the style of the assignments in the test too. Thanks
'blessed' isn't descriptive enough.
LOL, I didn't see this before my last comment. I do think this should have a deferred.

-----Original Message-----
From: Jason San Jose [mailto:reply@reply.github.com] 
Sent: Wednesday, May 23, 2012 1:33 PM
To: Ty Voliter
Subject: Re: [brackets] Menu, MenuItem, key bindings, and Command API (review only) (#927)

> +        return this._id;
> +    };
> +
> +    /**
> +     * Executes the command. Additional arguments are passed to the executing function
> +     *
> +     * @return {$.Promise} a jQuery promise that will be resolved when the command completes.
> +     */
> +    Command.prototype.execute = function () {
> +        if (this._commandFn) {
> +            if (this._isEnabledFn && !this._isEnabledFn()) {
> +                return (new $.Deferred()).reject().promise();
> +            }
> +
> +            var result = this._commandFn.apply(this, arguments);
> +            if (!result) {

Will we enforce commandFn to return $.Deferred? For synchronous commands with no return value, it's a minor annoyance to add "return new $.Deferred().resolve().promise()".

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/927/files#r870932
According to the docs, spies are removed at tear down.
Makes sense to me -- I'll remove it.  We should probably do a little extra testing around arrow keys in the opacity slider then, since this does change that codepath's behavior.

I'll defer to you on the unit tests :-)
Shouldn't that be something like `dbg.state === "running"`? Or is this a check for definedness? (See my other comment about the `state` property :))
Does it make sense to have toInetSocketAddress in HostAndPort ?
I can make edits to your code since this is not a problem for me.
EditMarkup inserted the form which is shown right after a user clicks 'edit' - bad luck, this form will be replaced by the return from the server...
Should this be a query arg?
If this property only had to return the text of one common element regardless of where in the UX it is it would be useful.
Since these are static values, there is no reason to set them here. You should put them in the stylesheet.
these should probably be re-prefixed with butter eventually
Allow an ID or Elem to be passed:

_container = typeof container === "string" ? document.querySelector( container ) : container,
I think I prefer vim for editing commit messages
Agreed, but this is the same test that exists in master (also, see [Simple fix](https://github.com/sonatype/nexus/pull/362) with same change). I just left the test in place -- just like the method call but made it deprecated.
Whoops, I'm mixing tabs and spaces right now, that's why it's looking fine for me. Last time I wrote JS I was using tabs (and followed jQuery's style). I'll fix that.

At some point we need to decide on a style for JS code, but I hope that can wait until we have more or someone else comes in and says how it should be done. As I told pmclanahan, I've seen way too many styles and did not nearly write enough code to have a strict opinion on that myself.
I agree with arvin that we should use there standard method for replacing ( replace_all )
Move repeated code into method
This method could be private...
here is one more (%) problem, I know it was there before this commit, but when touching we might it fix right away
huge try blocks frighten me, is it worth tightening it more or maybe wrapping the try block in another method? dunno just typing out loud
The comprehensive list here shouldn't be needed; `filter()` returns a list.
you seem to really want sending the original record instead of the normalized one...
I am not sure, but it seems like if `v` and `V` unpack formats are out then there's no special purpose to these functions. I don't mind to keep them, though.
// to produce a "." followed by a space.
But since the entry already has a dataset called number you can probably use an event handler only for the main container. And use evt.target.dataset.number from the children to make your call.
Perhaps a short paragraph should be added here that states that the main point of these `add` and `subtract` methods is to let have subclasses use them to simplify error propagation and such?
I'm pretty sure this message isn't ever sent anymore after some refactoring you've done prior to submitting this pull-request. If this is dead code, let's remove it.
Yes, this interferes with the status bar warnings. But those do only work if the client was connected to the network at one point or another.
It fix the "All KML" button alignment with other buttons
goog.array.filter kullanalim.
Can squash 118~121
Bummer, but definitely understand.  I think there were really too many features in this branch.  I took one large story and grouped it all into one feature branch.  Lesson learned.  Let me know when things are merged, or when we want to get back to this.

The site is looking great!  I am trying to get more folks in Houston working with it.
Small change but I think this would be less confusing as: "Users must be able to add other users to groups"
Hmm, personally I'm keen to keep controller actions doing one specific thing.

For instance, we used to have Membership#create do different things based on the params it was passed. In some cases it would create a membership request, in other cases it would add a member directly to a group. But I felt that splitting it up into separate actions makes things a lot easier (i.e. Group#add_member, Group#remove_member, Membership#ignore_request, etc.). It just makes it a lot easier to be explicit with the permissions settings. And it's more clear what's going on (without having to read all the arguments in the params hash).

So yeah, personally I'd like to make parent.id NOT accessible from the outside, and then just keep the specific Group#add_subgroup action. 

And I'd actually like to do the same for discussion. At the moment, in ability.rb for Discussion#create I have to parse params in to see what the group_id is that we're trying to create the discussion for. I'd rather axe the Discussion#create action and instead have a Group#create_discussion action. It's more explicit and we won't have to parse params anymore in the ability.rb.
I think this is already defined in the WXSlider
Just sayin don't worry about it :wink:
I think that makes sense - let's bring that commit into this PR.
Actually this should fail horribly when not available. IMO we should focus on ES5 targets.
That just doesn't seem right...
same comments,

letc clean this test up :) ..we really dont need linkedin examples here:)
IIRC Bedrock doesn't have a database. Are we going to add one for this patch (and has IT been informed of this?)
Out of curiosity, why didn't you name the view aaq_step1 to match the pattern name?
This method is used not only for movie download. Loading of the other file don't `params`. Please use other way to transmit params than "loadFile".
There's also PATCH and OPTION and HEAD. We don't use any of them. I feel more comfortable dealing with those once they're needed.
Same as the earlier comment. Why copy these?
If you're just concatenating two strings, just use `+`. I realize you didn't write this, but the whole `%s%s` nonsense looks like crap.
One class per file, also, it looks like the file for this is missing?
This comment can be updated too.
why ``RawMetadata`` here whereas ``Metadata`` is used for the getter ?
You should revert permission change.
FYI - since PHP 5.2 there is no need to use `DIRECTORY_SEPARATOR` at all, since PHP automatically normalises the slashes in file paths internally, therefor mixed `/` and `\` are not a problem.
wrong phpdoc. This param does not exist
the array should be typehinted
but it must be useful if the default is not used (it's my case).
> It's something that was already in sympy-bot, so I didn't modify the logic with this pull request.

Sure, of course; I just asked the question when it struck me :-)

> I think it's better rather than to try each second, because it would overwhelm the server. But maybe we can add some max time. But the way I think about it is that in 10 tries (that's a lot!), the time gets from 1 s to 17 minutes.

Yes, that's a lot of time; and that's why I asked the question.  It _may_ be better that SymPy-bot tried to get through to the server ten times, with a 60-sec timeout, and then reported failure.  In that case, it won't hang there for hours.

However, feel free to disregard my comment, I'm mainly speculating.
If that was true it wouldn't be available to the private method.
cleanup too ?
Gotcha. Better now?
This should not be necessary.  See test_helper lines 77-79, and the use_template method....
I don't see what you gain by abstracting out the render function out into another function. Just use render when you need it. You've got 3 lines of code here to replace 1 line of code.
why comment stuff out instead of deleting it?
Minor issue, but you're missing an "s".
This line is VERY dangerous, don't you think?

I think I'd rather have something like:

cd *stable*
# DO STUFF
rm -rf *stable*

What do you think?
no need for Title1, right can use Title now?
Tu es sûr? Pour moi ce n'est pas une valeur possible de word-break : 
http://www.w3schools.com/cssref/css3_pr_word-break.asp
http://stackoverflow.com/questions/4282757/how-to-make-word-break-on-firefox-using-css

(note que là je ne peux pas tester)
+1
I think I added this a few months ago (apologies if it was someone else) but I totally agree
Yeah, document.activeElement does work if no element is focussed, ie if I just click the trigger. But seeing as though this is for a11y, in most cases we'd assume they were tabbing and focussing anyway. Happy to do it another way if there's a better approach.
oh, sorry I missed that.
this section is not something you should have had to deal with, it was broken by a commit from @dwf where he changed the names to have underscores but didn't run grep to check where those fields were used. the correct call now is self.monitor.report_batch(batch_size).
@dwf , have you fixed this section yet in the trunk? if so @yaoli should pull those changes and merge them so his commit doesn't undo your fix.
我增加哦一个code，这个是上个星期不得讨论到的。因为后来我想，只有description可能不够，我们还要多种语言的name和description。
增加code以后，在view里面就以code来显示对应的i18n name和description。
数据库里面存的name和description作为一个默认值。
What about:

      composer.to = to;
      composer.subject = subject;
      composer.body = body || '';
      composer.cc = cc || '';
      composer.bcc = bcc || '';
Can you reverse the rule order? 2 > 1
I'm confused that this else clause separates the code in the if() clause from the call to this.audio.play(). Could you move the this.audio.play() into the if clause above? Or move this else clause into an if clause of its own at the top of this function?
and if we are trying to make the code easier to read, maybe a comment in here (or better above domSelectors) explaining that to every dom-element there's a domElement camel case function??
`icon.hidden = (this.systemDownloadsCount === 0);`
Sorry again (I'm really bad with this) but we should concatenate any string, concatenating strings is adding format and any format should be localised.
Thanks @gtorodelvalle
nit: mix of ' and "
This bug has been fixed, but we can un-blacklist this separately.  There was another report of alarms not working so maybe not yet.
The variable represent the current editing alarm belongs to the edit view module. Move it our of global.
I don't know if I've ever seen a negative lookahead assertion in the wild before!  How about a comment for this pretty obscure regexp.

Actually, looks like it is unused, so you can delete it.
Which is the scenario here? If you have checked before if `this.input.disabled`, when is this scenario going to happen?
Chrome JS listens for this event, and activated or deactivates the screen reader.
http://mxr.mozilla.org/mozilla-central/source/accessible/src/jsat/AccessFu.jsm#223
Does Error('fo') call its own constructor or is this a typo?

`throw Error('nosdcard') === throw new Error('nosdcard')` ?
Oh I am mistaken
Does the new design will have a gap ?
Isn't this an external link? Why not just link it to `http://persona.org` or whatever it is in the template?
You should type parameterize this as <State, Iterator<List<Object>>>
Ideally this error should be presented to the user, not a full traceback.
I don't know how to do it properly.
What's this TODO referring to? It looks like the remove code is there.
fixed in bd20a36
Since you dont need any instance methods here it would be simpler to just stub the createRecord method of `Shared.Track` like this: `sinon.stub Shared.Track, "createRecord"` and restore it in afterEach with `Shared.Track.createRecord.restore()`
you are right -> lets add a static property to the class that represents that error message
Good point - I wrote this when I thought I was going to have FOREVER defined as -1, but then changed my mind - will go back through it with that in mind.
Expand on these cases - raise the `TypeError` and tell the user you were expecting a string, not a (whatever type they gave you).
Aquí hay lío...
I originally thought heroku needed them to do the database migrations with south, but I just forgot to remove them after I figured out that it didn't need them.
I wanted to avoid any possible side-effect of importing stuff. (Although `buildbot/__init__.py` already has side effects). This might be a needless consideration.
You have added setAccelerometerInterval support, but why did you comment this line?
I think you're right _if_ git is using SSL, but there's no such check for the git protocol as far as I understand.
Can you make it translatable please?
why not use `diff_new_line` you added to Note?
Delete will not trigger update repository callback. And user still have access to repo via ssh
Now this is included post bootstrap it can be refactored into the fonts module, (which does the same thing in a slightly different way). But it might be worth waiting until @commuterjoy gets his AMD loader done, and we can merge that into here and fix this up for master.
Test or do not test. There is no maybe. 

![TEST OR TEST NOT. THERE IS NO MAYBE.](http://cdn.memegenerator.net/instances/400x/31324747.jpg)
because is in the specs? ;)
@lloyd - all those state.js changes should have never been part of the PR.  I reverted state to be the same as is found in dev with one additional line to allow the unit tests to complete.  A separate state.js refactor PR (#1975) has been issued.
Addressed in 56d79a3, moved to using tmpfile and stubbing the search method to return the location of the tmpfile.
It seems like you've written 'fails_on_ruby_1.9.2' here a slightly different way. If we can't really test the psych stuff yet should we just be setting our yaml engine to syck for now?
Could you not use a class variable here?
spelling: fields
Indeed...must be getting to late here (and I was too focused on making this fail under 2.0 that I missed it was also failing under 1.9). I've pushed a better, albeit confusing, spec for this...
Hmmm... maybe we should rename this to bundler, any ideas @javierg ?
Single `%` comments are for EOL.  These should be `%%`.
{@code IntShardsWriter}
Identifier is used to store Github User ID. Is it ok to use it as primary key ?
I guess we should set up this translator for view plugin also.
`urldecode` is part of the task needed for decode the raw input into PHP values. So the correct place for call this function may be `fromString()` or `setValue()`

I suggest do this in line 112 `$header->setValue($headerValue);` as if someone decided to decode the string outside of the method should be responsible too for undo the url encoding.
This should be enchants, not enchants1.
I checked and it's the ssh version... I usually edit files in `khan-exercise.js` by editing the subrepo, doing a substate commit in the mercurial repo, and then pushing in mercurial (which also pushes the git subrepo to GitHub (but prompts for username and password)). That is, if I want the change to go live.
We should be able to get rid of some packages that are deprecated names of packages. AspNetWebPages.Core, AspNetMvc, AspNetRazor.Core.
Can you amend this change into the previous one when you're merging into master?

Sent from my Windows Phone
________________________________
From: Luan Nguyen
Sent: 9/10/2012 5:24 PM
To: NuGet/NuGetGallery
Subject: Re: [NuGetGallery] Upgrade NuGet.Core to 2.1 (#590)

> @@ -30,7 +30,7 @@
>      <add key="Gallery:SiteRoot" value="http://nuget.org/" />
>    </appSettings>
>    <connectionStrings>
> -    <add name="NuGetGallery" connectionString="Data Source=.\SQLEXPRESS;Initial Catalog=NuGetGallery;Integrated Security=SSPI" providerName="System.Data.SqlClient" />
> +    <add name="NuGetGallery" connectionString="Data Source=kinhln2\SQLEXPRESS;Initial Catalog=NuGetGallery;Integrated Security=SSPI" providerName="System.Data.SqlClient" />

Oops, ignore forgot to undo this :)

---
Reply to this email directly or view it on GitHub:
https://github.com/NuGet/NuGetGallery/pull/590/files#r1572178
Yeah, for then I figured I would just add the code for a cursor and then make it an easy switch of a string and the location of the tip of the cursor... unless you want an X cursor! :)
@Ninir actually I started to use `responsive less files` because I needed to change the `margin-top` just for screen above `980px`. It works but please give a look to the following commit to confirm me this is the right way. Thank you.
Ah, all of these destructive functions in the API (see cluster join, leave, node down, stop) put the node name in the URI.  I can work on changing that; what are your thoughts on addressing that in a different pull request?
To make future expansion easier (and improve readability a bit), could we change the usage from:

```ruby
sync('~/foo', '~/bar', true)
```

To this instead?

```ruby
sync('~/foo', '~/bar', delete: true) # or :delete => true in 1.8
```
the braces are not needed here
I would put that in capitals, if it's a constant.
So you prefer a hard crash rather than starting out with a fresh empty shelf?
import X before from X import Y lines.
You probably want to add an assertion that the response is, in fact, a `Twitter:: SearchResults` object.
Should be:
```python
subject = _('Become a Mozillian')
```
"this is sparta" );

Wondering if we should have something better text wise, but I guess that doesn't matter.
or maybe i mixing up the commits :) sorry, to many pull requests for the same code :)
I didnt try, but using @trend.values wont work?
path already a String
sequencer name - no, sequenced path - yes, 
the output path not sure - should it be the configured output path ?
pretty sure we dont need the 2.
cc @ryanseddon 

otherwise this looks good. thanks!
lol, my bad... :)
change "adjustgridswit" by "adjustgridswidth" ("d" character is missing)
CS: space inside parenthesis needed
This should be MemChaser as we are no longer using Adblock Plus in the tests.
Do you want this here?
On this (and the rest of the options) it seems wordy to say `# e.g. foo =  bar`, followed by a line that says `foo = bar`. I think we should remove the 'e.g.' lines
I don't think you have to require 'csv' here. As long as it is in the gemfile, it should be there. Just confirm that before changing it though.
I think this can just be `that.replyTo = replyTo`. When replyTo has not been supplied, it won't have a value.
Searches are now registered through the `SearchAPI`. library search lives in content, members and memberships searches live in oae-principals.

The central oae-search module now registers a rest end-point that can automatically use new search types, rather than other modules having to register their own. So once you use `SearchAPI.registerSearch(...)`, your search is immediately accessible through `/api/search/<myCustomType>/my/custom/params?my=&custom=&opts=` .
The reasons for creating a third tenant are:

1) I think there are (were?) cases where I need 2 public tenants and a private tenant for a test setup. An alternative would be to update one of the tenant configurations during the test, but I think it makes the test harder to follow, also:

2) Not a fan of changing the state of the global tenants. If I change the GT tenant to private, then the "global state" is forever altered. I could set the GT tenant back to public, but technically is not the same as having "override from global" like it was before. It's a bit of a nitpick, but for example if we changed a default config value, now you could end up with spontaneously failing tests, depending on test ordering. Combined with #1 is why I just made new tenants to be altered.
There is no idea of snapshots in the p2 repositories. Every build has a full version. It is why we put the git hash and timestamp as version qualifier
What you mean is that the implementation should be ``new Region(selection.getOffset, selection.getLength)``, am I getting this right? Or the Eclipse API already provides a ``ITextSelection => IRegion`` somewhere?
This probably all fits on one line?
You're using the wrong constructor here, this is an uncatchable exception, which is reserved for system level code. You need to specify the exception type with ExceptionType.LengthException (or whatever type it should be.)
It's just a way to get UNIX timestamps; I don't think it needs an explorative constant.

I probably will comment all of this soon though.

On 2012-11-02, at 4:26 PM, Jen Fong-Adwent <notifications@github.com> wrote:

> In public/js/app.js:
> 
> >      }
> >  
> > -    function updateCurrencies() {
> > -        ls.currentCurrencies = JSON.stringify(getCurrencies())
> > +    return Math.round(date.getTime() / 1000)
> constant for 1000?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
I'm not strictly opposed to exposing the Registry to the users, but my plan was to avoid it, so the only real interfaces are:
* OKComputer.register
  * Choosing one of the existing checks
  * Or creating their own by subclassing (or, I guess, creating an identical interface)
Is there an i18n string for this?
Ah ok. Is de size van de map ook veranderd? Zag er anders uit op mijn scherm, denk ik.
No spaces around the concatenation dots please. :)
I'm not sure if the styleguide says anything about it, but it's done without spaces everywhere in CI - let's be consistent. :)
``require_once()``
Да создается. А есть ли в objective c переменные класса? Как правильно стояло сделать это?
похоже, что я таки понял эту магию остатков
очень интересный подход и красивый
убедили:) Туплю. сории
а как же проверить hammingDistance без копии Cell то?
это же сколько итераций Оо
EDIT: oh I see, ignore my last comment. CouchPotatoServer must be added to SABnzbd-Suite PKG_BUILD_DEPENDS
Not sure if we want to force all instances of BadgeUI to share the same defaults that way - that said, I added this var to a collection that was already there, so I'm tempted to leave them where they are simply because that's what the code looked like, before.
Similarly to below, this might be subject to a race condition if these arrays are non-empty here, but then empty in `dequeueAndSubscribeIfAllowed`. Returning a `BOOL` from `dequeueAndSubscribeIfAllowed` and removing this check (as mentioned above) should fix the problem.
Because `RAC(testObject, keyPath) = subject;` will try to use the keypath `keyPath` instead of expanding it.
We should test `sendNext:nil` too.
please adjust your IDE (Eclipse I guess) tab to be 4 and let's keep the alignment please.
Det stemmer - det er for å få full bredde, da må den ligge utenfor containeren. 
Det der med instansvariabelen var en quickfix. Det bør skrives om slik du antyder... :-)
Something like $.mobile.path.isHashValid( location.hash )?
Extra TODO?
Check bf91e21
it seems indeed that we would need methods: one for scoring and one
for plotting eventually informed by the order derived from the scores

wdyt?
Oh thanks, indeed :)
Why not do the baselining in the outer (user) function scope and remove it from _prepare_tfr_plot  - so we could get vmax / vmin as before.
I figured this was about as tight as we could get while still removing the components. Don't know of a more principled way of doing it. I like using a constant-Q filter (bandwidth increasing with increasing freq), at least, because if there's any FM on the fundamental (e.g., 60 Hz), it scales proportional to the harmonic (e.g., 180 Hz has 3 times as much). I'm open to other ideas -- but this seemed to work well when eyeballing plot_raw_data_spectrum.
Gah. Ruby slays me.

In 1.9.3, this will generate the X.509 Subject Public Key Info style key (what I think we want). In earlier versions of Ruby, the PCS#1.
it is ``--ansi``
to create or for creating? i lean towards the former
I see what your saying. I think I could swing that. Give me a bit and I'll
submit a PR on it.
Erik

On Thu, Aug 23, 2012 at 5:59 PM, Mark Triggs <notifications@github.com>wrote:

> In
> contrib/media/common/src/main/java/org/sakaiproject/nakamura/media/MediaCoordinator.java:
>
> > @@ -276,7 +272,7 @@ private void disconnectFromJMS() {
> >
> >
> >    private boolean isMedia(String mimeType) {
> > -    return mimeType.equals(mediaService.getMimeType());
> > +    return mediaService.acceptsFileType(mimeType, null);
>
> Just adding my two cents, the original model was:
>
>    -
>
>    User uploads a video. The MediaListenerImpl's handleFile gets called
>    with the poolId, which calls MediaCoordinator.maybeMarkAsMedia
>    -
>
>    maybeMarkAsMedia looks up the mime type of the content object and asks
>    the MediaService if it accepts that mime type. If it does, it sets the mime
>    type of the content object to the mime type used by the media service (e.g.
>    application/x-media-brightcove)
>    -
>
>    After that, all checks to see if I given content object/version is
>    supported by the MediaService are performed by isMedia, which just does a
>    dumb string comparison to see if the object has been tagged with the mime
>    type of the media service.
>
> My thinking here was that calling mediaService.acceptsFileType(mimeType,
> extension) could be potentially expensive--it might actually need to
> interrogate the remote media server to answer that question. Since we call
> isMedia a lot (at least once for every updated content object, and once for
> each version if that object turns out to be a video) it needs to be very
> cheap. So the model was "do the expensive query at upload time and tag the
> object with a known mime type, and then just check for that mimetype from
> thereafter"
>
> Would another option be to modify the MediaService signatures to support
> multiple mime types? I'm thinking maybeMarkAsMedia could look like:
>
>   if (isAcceptedMediaType(mimeType)) {
>     String extension = MediaUtils.mimeTypeToExtension(mimeType);
>
>     obj = cm.get(poolId);
>     // Modified getMimeType here to include parameters, giving the MediaService the option of assigning different
>     // mime types to different file types.
>     obj.setProperty(FilesConstants.POOLED_CONTENT_MIMETYPE, mediaService.getMimeType(mimeType, extension));
>     obj.setProperty("media:extension", extension);
>
>     cm.update(obj);
>   }
>
> and then isMedia could just be:
>
>  private boolean isMedia(String mimeType) {
>      // Push the string comparison into the MediaService.  For a MediaService with multiple mime types this could look up the mime type in a set?
>      return mediaService.isMedia(mimeType);
>  }
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/thecarlhall/nakamura/pull/2/files#r1449607>.
>
>
Only start/stop isnt TS, so that's ok. 

-
Piotr Gabryanczyk

On 25 Feb 2012, at 13:35, viktorklang<reply@reply.github.com> wrote:

>> +import org.apache.camel.CamelContext
>> +import org.apache.camel.impl.DefaultCamelContext
>> +import akka.util.Duration
>> +import scala.Predef._
>> +import akka.event.Logging
>> +import akka.camel.Camel
>> +
>> +/**
>> + * Creates an instance of the Camel subsystem.
>> + *
>> + * @param system is used to create internal actors needed by camel instance.
>> + * Camel doesn't maintain the lifecycle of this actor system. The actor system has to be shut down by the user.
>> + * In the typical scenario, when camel is used with akka extension, it is natural that camel reuses the actor system it extends.
>> + * Also by not creating extra internal actor system we are conserving resources.
>> + */
>> +private[camel] class DefaultCamel(val system: ActorSystem) extends Camel {
> 
> What? No. IF DefaultCamel isn't TS, and is called by multiple Actors at the same time, then it's not TS. At all.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jboner/akka/pull/344/files#r488621
It's ugly and breaks the flow. It has its place, say in documenting the variables in a big struct, but even there the comments tend to get ragged. The new line isn't gratuitous, it make the code pretty.
That kind of static type-checking is more likely to be a PITA in the future than a help. I think it's best not to bother.
`struct` необязательно писать, кстати. Плюсы же.
Есть же QCalendarWidget, им можно заменить Year/Month/Day.
One way to fix this is to change the package layout so that algorithms and tests are both sub packages under another package:
> sort/
>     __init__.py
>     sort.py
>     algorithms/
>         __init__.py
>         # sortfn files go here
>     tests/
>          __init__.py
>         test_algorithms.py

Can also just put the text of test_algorithms.py into tests/__init__.py.
I am happy to do this, but I'd like to understand the useage scenario you have in mind.

If ad-hoc editing, then surely all is possible anyway and the user may as well just edit the allowSave function in place.

If template expansion in a web server (maybe the NodeJS 'pseudo-server' in AppJS), then there'd need to be a suitable replacement token in the file (or we may as well just edit the body of the allowSave source directly).

AFAIK we cannot insert anything into the DOM from AppJS, because the Window object is not available until the browser is 'ready' - i.e. after the HTML file is fully loaded and main() has already been run.

I determined it is possible to put an immediate 'script' block in a tiddler between the 'div' and 'pre' tags, but that is not supported by the tiddler handling within TW (it might be a useful enhancement to support this, but without it we're back to ad-hoc editing).
We should test here that the complete event is not set prior to the AsyncAGI event coming in.
Reword this sentence
It didn't.  It's part of $versions if local switch is not specified line 65
Has there been a decision here?
I don't think they're doing it correctly:
http://en.wikipedia.org/wiki/KL-divergence#Definition .  If you want to do
the KL on those kinds of vectors, you should use the Jensen-Shannon
Divergence instead, which is defined even if the values are incorrect.

On Wed, Sep 19, 2012 at 11:18 PM, Keith Stevens <notifications@github.com>wrote:

> In src/main/java/edu/ucla/sspace/common/Similarity.java:
>
> > @@ -1749,12 +1756,8 @@ public static double klDivergence(DoubleVector a, DoubleVector b) {
> >
> >              for (int index : aNonZeros) {
> >                  double aValue = a.get(index);
> > -                double bValue = b.get(index);
> > -
> > -                // Ignore values from b that are zero, since they would cause a
> > -                // divide by zero error.
> > -                if (bValue != 0d)
> > -                    divergence += aValue * Math.log(aValue / bValue);
>
> That's what I was originally doing, But with that restriction, but then
> we'd *never* be able to compute the kl divergence of any sparse vectors,
> which kinda seems like a deal breaker. I looked at some other KL divergence
> and this is the trick they did to make things work.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/fozziethebeat/S-Space/pull/19/files#r1647761>.
>
>
typo: missing word "the compute _service_"
The clean target removes all the test files (below).
It is updated from an inner class.  A primitive won't work here.  I'm using the atomic variable more as a container than for thread safety.
This should set defaults for a **single** find. It can do so by:

- storing $this->modelDefaults[$Model->alias] in a temporary variable somewhere
- modifying $this->modelDefaults[$Model->alias] to be the results of this array merge
- restoring the old defaults if a `persist` key is not specified or the `persist` key is set to false.
:+1: Much nicer, cheers for the clarification @arrbee!
Could you put spaces around `!=`?
I like blank lines, but this is a little over-done with blank lines
What is we use here <code>div.pagination a:last-child</code> instead of xpath?
Can assert against the current FM frequency https://github.com/mozilla/gaia-ui-tests/blob/master/gaiatest/gaia_test.py#L195
Nice, didn't know checking for the event is that easy. Might change this myself in the audio test too.
Ok, my bad -- `Format::file_size` already exists and does this
can you refactor this to expect the 3 events but in any order? i would implement a helper method that gets a list of the expected events and unsets each it sees, then fails if something unexpected comes before the list is empty.
Good point, that would be easier.  I'm just about at the end of my day (it's after midnight here).. but I'll go ahead and make that change really quick and get the tests passing again. :grin:
I think it's actually a *set* of strings, and '|’ is the union operator on sets.
http://docs.python.org/library/stdtypes.html#set
It's saying, "add to the set of possible tags any that are in m[3]"
Q
not sure if this needs to be formatted by hand, maybe there is a `to_s(:xml)` or simply passing a date already renders it correctly
Better yet, the line could be this to avoid binding multiple times:
``s23SiteMenuContainer.off('click', '.icon-sakai-help').on('click', '.icon-sakai-help', function(ev) {``
We probably don't need the double `!!` here.
this comment can be removed...
Number needs explanation.
What described right here and here https://wiki.sourcefabric.org/display/CS/Gimme+API+-+Slideshow+-+items seems a bit confusing to me. The actual response is not about the items of the slideshow, but the slideshow as a whole. In my opinion this should be renamed into simply:

/slideshows/{id}
(to correspond to other resources like /articles/{id}

as we are sending not only the items but also id, title and summary of the slideshow. The items are only part of the response. So in general, to define it as "get" method instead of "items".
If not in use then let's remove it
Ještě drobnost. Koukám, že taky zatím synchronizuješ přes vypnutí interruptů. Já si nejsem jist (a nezjišťoval jsem), zda je to rekurzivní. Tj. pokud se třeba v timeru taky vypínají a zapínají, tak zda se ti třeba po zavolání nějaké funkce z timeru najednou zase nepovolí. Že by to bylo side effect. Jestli to taky nemůže dělat někde potíže... (Znovu říkám, to je jenom nápad.)
Here JsSource should be a property: $this->JsSource instead of $this->JsSource()
doing a `return dao.findDepartmentByCode(code) == null` might be more concise and easier to read.
No reason really; this should be renamed to ClockworkRaven to be more clear. But it's probably a good idea to wait until this CL goes through to rename so it gets working ASAP.
Use `prop`, not `attr`. [Read here](http://api.jquery.com/prop/).
Which command do you use to start celery?
`idle`? Is not there a callback setting to `google.maps.Map` which is run at the end?
*OpenHours*
String? No, why not a reference field to Comment document?

But you probably get an circular import error. :-)
I am glad that you learn new things. :-)
"(&pos)->" its recerencing with "&" and then dereferencing witch "->", so use pos.IsPositionValid() instead
150 here, isn't it?
No, this is merely the ID that is sent to OpenSearch on request. It does not affect the returned data.
this service cannot be private if you want the listener to be lazy
each year...
Before talking about event delegation, introduce event bubbling - it's the "given" that makes event delegation a useful - and understandable - technique, instead of just magically being "EVENT DELEGATION"
Ik zou een `if` statement in de loop doen die optioneel de huidige locale skipt (doen wij namelijk ook wel eens):

```php
if ($options['skip_current'] && $supported === Locale::getDefault()) {
    continue;
}
```

Wellicht boven de foreach dus een `$default = Locale::getDefault` plaatsen, want je gebruikt heb anders erg veel.
Using `helpers.eq` would get you caching.
Doesn't L455 already setup the service init scripts when using --install-layout=deb? If not, that's fine.
This class-level comment should be on e.g. `RootRoute` so that automatic documentation generators know which class it applies to. Right now it looks like documentation on the `HighVoltage` module.

This applies to the other class-level comments too.
This is wrong. It will not count the number of elements matching the criteria. So it works only when using an empty criteria
I agree, it doesn't hurt.  But I'll remove the mention about the the RNG stuff which we now bundle.
I don't quite follow your comment. Is javadoc like this what you mean?

  Currently supported for entity and location fields: if not explicitly configured, then the field will be set to
  the default value. It is then up to the user of the item to consume that field's value.
kill this log line
Debug statement left here.
Why not implement this as a decorator?
Django's CSRF system will block POST requests from other sites.  There's probably still a small window where malicious JS could manipulate the redirect inputs.  I think the right handling is just to check that the 'next' parameter is a URL path (ie without a host and protocol)
ahh sorry.  this is a Multimap, not a map, so there are multiple values allowed for a key.

I think syntax will look like this:
  returnMapBuilder.putAll(Address.Type.PUBLIC, Iterables.filter(addresses, Predicates.not(IsPrivateIPAddress.INSTANCE)));
  returnMapBuilder.putAll(Address.Type.PRIVATE, Iterables.filter(addresses, IsPrivateIPAddress.INSTANCE));

this should eliminate the for loops
Just a question out of curiosity: why are we using ``$my_array->{'my_attr'}`` instead of ``$my_array->my_attr`` in cases where the later is possible? I read that the former is for accessing attributes at runtime, so it would useful when you want to access an attribute which name is in a variable. But when the attribute name is known, why don't we stay consistent and use the classic way of accessing attributes?
Nice test :-)
¡Este archivo hay que borrarlo!

Simplifiquemos este punto, para no tropezar y cometer fails con las claves. xD
Ar fi mai bine sa definesti dictionarul in readConfigFile sau sa il faci private.
Should this be:

```ruby
include_recipe "apache2::mod_auth_cas"
```

? Note the use of ::, not :.
Лишняя `(` скобка.
Все прекрасно работает.
   Ноябрь 2012
Вс Пн Вт Ср Чт Пт Сб
    1  2  3  4  5  6
 7  8  9 10 11 12 13
14 15 16 17 18 19 20
21 22 23 24 25 26 27
28 29 30
Инкремент в цикл. Видимо, надо будет делать:
```
do {
  i++;
} while (condition);
```
Поля начинаются со строчных.
Надо проверять, что i не вышел за границу массива. Иначе пользователю exception вывалится.
Ой. А нельзя метод public сделать?
Having a `collapsed` attribute really simplifies all this methods and events. `show` and `hide` are now just changing the `collapsed` state which removes a lot of helper methods
spelling error: `canHighlightNode`
Why didn't we put this into go_to_developers_homepage() method instead of login?
perhaps rename into `generate_random_slug()`. This code made me wonder whether there was an infinite loop in here..
I prefer single quotes when the string doesn't contain them.
This method is too confusing. What is the intent?
:facepunch: me
Strange I haven't seen this yet, why is this being removed?
fixed by following ppca implementation.
for the public function yes, for the private one, I think this is ok.
Please also add a test that checks that identical or very similar histograms get higher chi2 similarity values than very dissimilar histograms.
I think that I would prefer "comment=None" in the signature of the function.
> Also: how are we going to test this beast?

Check that the energy decreases during the training?
This code will fail if last / first are not random access iterator
You can use len(seq) that will distinguishes between the two
Хей-хей! Вот вам ещё врезка, посаны:

Непрозрачные обёртки не позволяют, в первую очередь, использовать примитивы, предоставляемые API так, как хочет консюмер. В том числе — реальная ситуация — использовать их так, как дизайнеру вообще не приходило в голову, что их можно использовать. Это правило действует для любых примитив (конструкций в ЯП, кубиков лего), не только рестовых точек.

Решение дизайнера можно считать достаточным, если предоставляемые примитивы взаимодействуют друг с другом в каких-то обычных воркфлоу и, желательно, не дублируют функциональность друг друга. В остальном можно позволить консюмерам быть креативными.

Если делать над примитивами уровень абстракции, то лучше, чтобы это был известный, часто используемый сценарий. Например, абстракция «цикл» над примитивой «goto» — классно. Короче, лоу левел можно и нужно прятать, но тогда, когда с хай левел тоже можно реализовать творческий потенциал погромиста.
Also here, a f.q.c.n of the exception is required.
These lines here could be condensed a bit further:

    AWS_SECRET_ACCESS_KEY = getattr(settings, "AWS_SES_SECRET_ACCESS_KEY",
        getattr(settings, "AWS_SECRET_ACCESS_KEY", None))

As a side note, shouldn't there be tests around this behavior to make sure that the correct keys are picked up and in the correct order?
The reason was to format the usage saying that could be provided ndk_location with -t option. Don't know do we need that really.
NativeDateTimePickerObject.h should be first, then an empty line, then our stuff (eg TiConstants.h), then 3rd party (eg bb, Qt).
xUnit supports unit testing when returning async
I would drop the CLOUDSTACK prefix and OPTION suffix.   ProviderOptions.ZONE_ID  looks clear enough to me.