labofsahil/github-event-dataset-2012 huggingface dataset:
Creo que una app de consola sería mejor y más fácil de manejar y hacer. Ya
que hay que hacerlo, ¿no preferís mover la lógica a esa app en lugar de
dejarla en la web?

Alpha.-


On Mon, Nov 26, 2012 at 5:35 AM, andresmoschini <notifications@github.com>wrote:

> In source/CommonJobs/CommonJobs.Mvc.UI/Global.asax.cs:
>
> > @@ -70,6 +74,41 @@ protected void Application_Start()
> >  #else
> >              CommonJobsAuthorizeAttribute.AuthorizationBehavior = new PrefixFromSettingsAuthorizationBehavior("CommonJobs/ADGroupsPrefix");
> >  #endif
> > +
> > +            StartTimer();
> > +        }
> > +
> > +        private System.Threading.Timer timer;
> > +        private void StartTimer()
>
> Buh, es cierto, voy a tener que iniciar un servicio de windows (o
> aplicación de consola), aunque por ahora yo programaría un request diario.
> Que opinás?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/225/files#r2220688>.
>
>
probably camelCase ?
$current_user
multiline is good
Yes we'll get a NPE but that shows the developer he is doing something wrong.
ok, I get it now
hmm, it would not make it fail though
Lol I had them doing that for the longest time. All the duplication is uuuuugly though.
Good point. Fixed in latest commit.
can you not just do ```import matplotlib.collections```?
this import is not used
Also, capitalization and punctuation.
To answer Zac's question, yes. This is the equivalent to implicit waits, however I understand this only waits for the element to exist, not to be visible.
Same comment as above - I'd move this into a separate python class
It's nice to see all of these <code>self.lockscreen.unlock()</code> calls removed. Nicely done
I know this is from a previous PR, but:

"...happen because the namespace name __*is*__ already used or __*due*__ to __*an*__ incorrect..."
Agreed. I've changed the URL accordingly. If that's your only remark, then please merge!
Considering the plethora of distros using yum these days (I personally manage centos, rhel, amazon linux and fedora) trying to establish "one config for all" of them may not be the best approach.

I would definitely fix the permissions in the previous template file - removal of a recipe would actually constitue a breaking change.

I also think that adding copyright details for each file may not be accepted into the Opscode repo, since this is an "opscode maintained" cookbook. You also have to sign the contributor CLA for them to consider accepting your patches, as well as have a corresponding Jira ticket. Ref: http://wiki.opscode.com/display/chef/How+to+Contribute
fixed in f8407b563ad6b17030292446f0a78a7b83205af5
Yeah, that makes sense. Keep it as is.
Gotcha, that makes sense. Thanks for the explanation.

On May 22, 2012, at 11:42 AM, Sam Ritchie wrote:

>>       (chunk-src _ ?ts-chunk)
>>       (vcf-src _ ?vcf-chunk)
>>       (get-loc ?ts-chunk :> ?s-res ?mod-h ?mod-v ?sample ?line ?series)
>> -      (:distinct false)
>> -      (map ?series [:start-idx :series] :> ?start ?ts)
>> +      (schema/unpack-timeseries ?series :> ?start _ ?ts)
>> +      (schema/get-vals ?ts :> ?vals)
> 
> Yeah, say you're trying to make a `DataValue` out of the array trapped in a timeseries. You don't want to break the values out then wrap them up again.
> 
> I think functions shouldn't try to do too much. if you want to compose these two functions, you can break them out into a predicate macro that does both things. `get-vals` already pulls out values. IMO it'd be a mistake to for `unpack-timeseries` to do this too when you might as well just compose them together.
> 
> ```clojure
> (def unpack-timeseries-vals
>  (<- [?series :> ?start ?end ?ts]
>        (schema/unpack-timeseries ?series :> ?start ?end ?wrapper)
>        (schema/get-vals ?wrapper :> ?ts)))
> ```
> ```
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/reddmetrics/forma-clj/pull/26/files#r862587
https://github.com/reddmetrics/forma-clj/pull/163
Replace `[ betas]` with `[betas]`.
@bp323 Can we prefix the id with `newaddcontent_`?
Can we do this before merging this pull request? Sounds like people might run into issues on shared hosting if AcceptPathInfo doesn't work.
I think 

container = this.closest('cms-tree-view-sidebar'); 

then check if container is defined, rather than hasClass? It's used to check if we are in the sidebar sitetree or not.
OK, you're talking about files. Uhm, I think that logic was more or less copypasted from the SiteTree.URLSegment since the dawn of time. File URLs should be pretty as well, but its a lesser concern to file name consistency, so I think we can relax the rules there. Problem is that it'll cause duplicate files if you re-upload stuff on existing installations. Worth it?
I've added another onremove condition which removes all events namespaced to "click.ss-ui-action-tabset"), that should do the trick.
I would think that they are escaped when the report was being added. Seeing as we're pulling directly from the DB, stripslashes() would be more appropriate
This is the code that creates the fake deleted page when we have deleted the node and suddenly we're forced to instantiate it, where we build an in-memory version of the page and create a set of deletes for every entry in the page.

Note at line 34: I'm setting page->modify->first_id, but I'm not sure that's correct, can you please confirm that?
I've taken out that comment.  I'd like to get to the point where we can add new data types in an extension, via the `WT_DATA_SOURCE` interface, but we aren't there yet.
Don't tell me you're a double space  between sentences kinda guy?

I guess that's ok, just making sure it was intentional.
Should probably specify which directory to run this command from.
The assignment to ``$_GET`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
Are you sure that you can access the property "where" as it is declared protected in class "Zend\Db\Sql\Select"?
remove spaces inside parentheses
This directly uses HTMLAudioElement and therefore needs to be it's own crew.

src/crews/audio/**
The hashmap class is not thread safe and might behave strangely if modified by one thread and read by another.
You already synchronize access to the node list. One thing that you can do is to make sure you always are synchronize on "this" each time to access  one of the member collections. That way you don't have to worry.

As long as you avoid any blocking file or network I/O within the synchronized blocks the performance implications are minimal.
"sure check" -> "sure to check"
__halt_compiler действительно должен до конца файла всё комментировать? Или я неверно читаю?
Of course, thank you for seeing this. My apologies.
Without it, I get permission denied errors when chef tries to cache the cookbooks...
I'll ping him on Monday to look through all mentions of him on github so you should get response eventually :)
aah now I noticed the `phpunit.xml` in build folder . I haven't checked what the build was .
Yes that does seem to be precedent in this SDK (via 2 examples).
no .. this is a different issue.
knp menu assumes that children are only of type NodeInterface, but if you have a node in PHPCR it might have instances that are not implementing that interface .. like you could have a mixed tree of menu items and routes

f.e. see https://github.com/symfony-cmf/SimpleCmsBundle/pull/22
I tried to use mongoengine signals and Post_save method in api.models.py, but there is a problem because i can't import NotificationResources in models.py because of circular imports. Because of that i cannot use serialize from NotificationResources and have to manually create json object using python json package.

This new code is working but is not so clean as current one.
Do i really have to change it?
What is different in this file in comparison to `form.html`?
Then there would be third choice for "empty" gender in registration. Unless I change how the gender field is render :)
This is not correct?
<code>Subject: [PiplMesh] Confirm your e-mail address</code>
Space before `/`.
I think that if you use as alias url, you need more replacing, otherwise you create quite hard to use alias.
Ah, it's just a copy and we never see it?
:flushed:

Yeah so I meant to say in the case you don't _want_ to change the order of the conditionals, which is for me always, because I order conditionals by probability/importance -> exceptional.

Now back off my unless :gun:
That's the whole point of this fix: It has been tried to implement it directly in the `FakeItEasyType` class but that is not working. It throws an exception.
I tried to explain it in the commit comment, but what is basically happening is the following:
In the case of one or more parameters on the constructor the `StaticMethod` instance is created for the method `BuildWithArgumentsForConstructor` which has one parameter. But to the constructor of `StaticMethod` an array of `ParameterInfo` objects is passed leading to the following:
When the `StaticMethod` is invoked it gets passed in an `IEnumerable<object>` with a value for each specified parameter. This is than transformed to an array and passed as the parameters array to `MethodInfo.Invoke` in `StaticMethod.Invoke`.
The result is an exception about a mismatch in parameter count, because `MethodInfo.Invoke` expects one parameter per item in the array, but `BuildWithArgumentsForConstructor` only has one parameter. Changing that one parameter to an object array doesn't help.
>This looks really similar to
>CString CGit::GetShortName(CString ref, REF_TYPE *out_type)
>in CGit.cpp.
>Do we need C&P the code?

I just follow the code in DrawTagBranch()
why is this hardcoded to vehicle seat 0?
This should be a relative import:

```
from .dendrogram import Dendrogram
```
Can we refer to this as model_error instead of module_error?  Not a big problem, just a bit more accurate.
Please use an option type that resembles the method name.
Use `window.event_handlers` here.
Should the 1 and 2 be constants?
Newline before I guess.
Also note that I'm using `jasmine-node` as a dependency instead of requiring the global install.
same thing with this.
Yeah. Print statements are not the way to go I don't think. Once we're done with some cleanup and I have my bearings a bit more I'll see if we can't figure out what's going on.
this sucks (test)
That's too extreme :) Sometimes it's nice to have human readable font name for sanity check when looking at the font dumps. Could you change bad chars not in range 33 through 126 or one of the [, ], (, ), {, }, <, >, /, % to the '-' or '_' ?
You could specify some padding-top on this paragraph, rather than using extra markup.
Let me make sure I understand: this will not undo any commits that happened after the one I'm worried about? I'm concerned about weirdness associated with the fact that I later deleted the entire docs/ directory.  So it doesn't seem clear to me how that earlier commit that changed something in docs/ actually can go to the top?  I read some documentation to try to answer this question, and have successfully confused myself further.  ;)
Suggest changing this to:
```
@brief Draw an image of the object by shooting individual photons drawn from the surface brightness profile of the object.
```
i.e. About what it does, rather than what it returns.  The `@returns` bit below already describes the returned tuple.
I'm going to vote for "I don't care", but you're more than welcome to do that if you have a strong preference.
Yes, but it's not "deprecated" unless the server being connected to does not support it. :tongue:
just greclipse weirdness
Do you also need/want a flush after System.err.print?
agree.  ideal probably debug on first, and every 10s thereafter, otherwise trace?
Et arrete tes _vs_ cest pas de langlais ecrit ca
c'est a dire ?
This code should be:

    data.paintRectStruct = cellRect;
    data.paintRect = &data.paintRectStruct;

As mentioned previously.
Actually, this specific case of overriding the existing options isn't hard to test, as we can just set a cursor option, run a query, and then get the cursor option back out again.
Need to take into account that the remote branch may have been updated, so this should be reset to/rebased on the remote branch
Oh! I just wanted to double check that you didn't mean "rescue Exception" here

A "rescue" with no class, actually does not rescue any exception -- it rescues only RuntimeError. Often that is desirable (e.g. because you meant only to capture a specific kind of error.

If we are trying to capture YAML errors, then it seems this might be very difficult!

  YAML.load('sdfsd') => "sdfsd"
  YAML.load("{this is really: malformed json}") => {"this is really"=>"malformed json"}
  YAML.load("one fish -- two fish\n\truby fish\n\tblue fish\nfoo: bar") => "one fish -- two fish 	ruby fish 	blue fish foobar"

It seems YAML is a very lenient parser ... with 5 min of playing around, the only way I could get it to raise ANY exception, was:

  YAML.load("almost valid: second key: crazy") => ArgumentError: syntax error

So, perhaps what we mean to do here is:
 * rescue ArgumentError and return false
 * if YAML load succeeds, test that resulting object is_a Hash (or perform duck type test for :[] if we want to be true Rubyists)
mind you, we use single quotes.
OK :) 

Merge on the way
We don't need this :p
The Eclipse projects here are an out come of the instructions for Ubuntu only, so might not work outside Ubuntu without making changes - do you want them to be OS independent?
I just checked and there's actually a newer version:
Не переносится
НУЖНО КОНЕЧНО ЭТО ЖЕ JAVA: ФАБРИКИ, ШАБЛОНЫ ПРОЕКТИРОВАНИЯ, ПРОТОТИПЫ ХАРДКОР
Можно сразу указать в конструкторе размер ArrayList'а
If the category is present then it's true, if it's missing then it's false...
I have renamed the software-scifio file as just 'scifio.txt' and put it in my new users folder. Don't think that will affect this being merged first but wanted to add a note just incase.
We really need this expand_path?
I'm sure that tree.py could benefit from this as well...
On this plot, I'd also set a title to the color bar
а тут реально крім категорій не потрібно інші фікстури підвантажувати
ps: Maybe it´s better to actually have a playlist class (that takes songs from song class) which will be passed into the Jukebox class?
What exit code does stop return? If it's a 0 exit code, supervisor won't restart it. We should also explicitly set the autorestart and exitcodes supervisor params (http://supervisord.org/configuration.html#program-x-section-settings) so we know on exactly what conditions supervisor will restart things.
Does this still work if the foreach body itself has a foreach in it?
I wonder if that should be a while(func->fes) rather than if(func->fes), but I don't know such a situation can actually happen.
For now, just leave this out since it's not used by anvil and update the apidoc
I preferred to have two different functions one for callbacks and one for timeout events. rather than to have default argument and make addition checking in the function. We can discuss it online
This is an issue with the framework.  Dave is working on this timob-9398.  

I'm a bit surprised that it needs to name to be defined, but then the resulting object is the actual built in Date object.

In all events this shouldn't be needed in the future, so i suggest waiting for 9398 to complete this patch.
Why is this necessary? It's assumed to be a string as per the comment.
Can you add this to a new file, belongs_to/reflection_test.rb?
you cannot know if remote object exist without requesting it
I was calling fn->method 
then realized It isn't needed
Added overloaded "addRow" which allocates roxiemem index array in chunks
double 'accept' typo
If your files are locked because a roxie talking to the same dali has loaded queries that read those files, then you will not be able to update them. Doesn't matter if it's the same roxie or not, and doesn't matter if the process trying to update the files is a roxie or not... We are not trying to fix that case, because that behaviour is by design...
Again, can just use getLogs in legacy / non-legacy.
Shouldn't this be private, then?
Actually it is showing a bug - it should be tested in the if()
looking back, possibly no. Create Super File will, though.

Ok, I'll move it to a higher place, possibly transaction.
attributes have been moved to the front in the record def by this point. You are probably right that PACKED also needs skipping here, in theory (I suspect there's other code that will fail too - both new and existing)
why changing the formatting between the part done in the ``if`` and the part done after it ?

Thus, I prefer the previous way to write it: an early return when we don't do anything, and then the actual logic in the case we do something
En fait je suis pas sur qu'on ait besoin d'une collection ici, on peut juste se contenter de content_editable.
once things are more settled, we can probably make a better attempt at harmonizing the response_uris.
should we do this with a rel or a class?
please remove the 2 empty lines
Just copy and paste from enum_domain.rb - I guess that could use updated its all in the API! 

What registry key/local configuration file is your domain controller stored in?
Worthy comments. Corrected.
> It raises an I18n::MissingInterpolationArgument exception

That makes sense, thanks for the comment. In that case, can you check for that exception specifically? Like this:


```ruby
expect { @model.should ensure_length_of(:attr).is_at_least(4) }.to_not raise_exception(I18n::MissingInterpolationArgument) }
```

That way, it's clearer what you're expecting, and if another random error gets raised, it's not swallowed.
flavorRef  is a required element for the create instance call.
Since this doesn't take into account the curvature of the ellipsoid, we should document it just like the comment in `Polygon`.
Are these OK given that `pixelSize` could be zero, etc.?
didn't throw the exception. Users can still create polylines with no positions and remove them later. The exception is only thrown in the setPositions method where it's excpected that you'll need at least two positions to make a polyline.
Should assign the internal value
In general, I prefer comparing with TiC.PROPERTY_PHONE.equals(field) instead, since it prevents NPEs
should backfillStart and backfillEnd be marked as android/ios only since we ignore those values?
This should not be removed.  Instead, you should add 'android' to platforms, since you exposed it as a method.
I tried changing it from Object to Krolldict, v8 gives me a signature error so...
Agreed.  This is a hold over when logging was more robust in terms of reporting transmission states.
At least add a non-null check.
What is a line note?
I just copied the one mozilla template for this section... its not really my code.
I think that testing for r1.empty would be faster... if and when r1 is empty.
However, since the "usual" case is to call equal on non-empty ranges, I think it is overall better to avoid the test.
`$(RED Warning: The pointer returned by this function will not be considered a live reference to the array by the garbage collector.)` should be fine.
Done: TY.
It's Erik, not Eric :P
Please fix this
For simplicity (of the stack traces) I'd probably only wrap in ``new Exception`` if it's actually a ``Throwable`` **or** we teach ``FILE_EXCEPTION`` and the rest of the events to handle ``Throwable`` rather than ``Exception``.
I'd prefer a defmulti
I think if this would be included, then I'd like to see it not change anything by default.

IMO, I feel like this is encroaching too much into Apache's realm of responsibility and would begin coupling Horizon to the Apache service too much again.  Given the example where I have port 443 listed in ports.conf, as it is, this code will only change port 80. So now the code needs expanded to account for 443. I feel this is a slippery slope.

I do understand that in 9 out of 10 cases, a simple Horizon and Apache config work just fine, so it's manageable to include apache-centric configuration in the horizon module. But what about SSL support and what if someone decides to use nginx with Horizon?

Using a past commit (7a56c8aa40a4) as another example, I felt this was acceptable because the file Puppet is modifying is part of the Horizon package. ports.conf is part of the Apache package.
Why doesn't `for x in page` work here?
Maybe GraphiteNotifier for a class name?
this will default to nil by default, !!nil == false
Shouldn't this change be ' instead of ’ ?
This line is terrible.
Since it is a test, I'd guess that someone calls the method with these values, but anyway I'd suggest to disable doc comment fixes on tests anyway. They are usually not necessary.

http://jmsyst.com/automated-code-reviews/docs/guides/using_different_configuration_for_tests
I refactored the base class to have an addViewColumn method, and I call that from here too, to avoid duplicating the code.
I think it will be removed. I'll replace it with a plain comment.
Creates a CustomPropertiesDictionary with specified HttpResponseMessage.
do the version thingie
Почему бы не сделать что-то типа такого?0

    auto& pair = SpyWho_ [msg.toLower ()];
    pair.first = true;
    ++pair.second;

Обрати внимание на амперсанд и неконстантность.
there is an encounter.getObsAtTopLevel that you probably want to use here. 

How does hl7 handle multiple levels of hierarchy?  We support it, but does hl7?
Correct - but I don't know another way of warning them the method will not be overridable in 3.0.
More magic constants.
What happens here? Init local vars with null, set local vars from jndi if jndi config does exist, then set local vars to field values if they're set (use overridden value?), and then set props on _msm?
It should be possible to understand what's happening/intended.
Why not use the ConfigurationObject to encapsulate fields (copy from jndi obj)?
Still, all the config props handling should reside in MemcachedSessionService
What's the deal with the `?` ?
Ok, it's done. It will just need some polishing from you.

I think it's a very nice thing. One of the things I don't like about the default GoToFile search is the way it will only search unopened filenames if you have opened a project. Our one fixes that **and** we will be able to open all the matches in one go. Brilliant!

Thanks for the help and encouragement.

Fb

On 22/03/2012, at 11:42, tito wrote:

>> +	##       ##     ##    ##          ##     ##   ##  ##     ##    ##    
>> +	######   ########      ######     ##    ##     ## ########     ##    
>> +	##       ##     ##          ##    ##    ######### ##   ##      ##    
>> +	##       ##     ##    ##    ##    ##    ##     ## ##    ##     ##    
>> +	##       ########      ######     ##    ##     ## ##     ##    ##    
>> +	
>> +	# Hi Tito!  
>> +	
>> +	# So, I've had a go with it. I had a couple of problems:
>> +	
>> +	# - The big one: I don't understand how to turn on and off the event listener,
>> +	#		so it is currently on all the time.
>> +	
>> +	# - I couldn't set a sidebar_results variable that I could then access
>> +	#		from the FindResultsListener, so I went off the name of the view.
>> +	
> 
> That object seems to be non-writeable. That's way view.settings() is there.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/titoBouzout/SideBarEnhancements/pull/11/files#r590303

--
Stephen Horne
:party: awesome job extracting this out. Love it.
I got the impression from the existing docs (https://github.com/doctrine/phpcr-odm-documentation/blob/master/en/reference/basic-mapping.rst#identifier-generation-strategies) that the default was ASSIGNED - but its actually parent isn't it?
In this case is easy, `$this->_region` will be always null at constructor time
This should probably be `ZF2_PATH`
rename to createTitleBar
spaces unnecessary for padding when passing a parameter
还是有缩进的问题。一定要用空格填充缩进空间
Make the max_length 255
I think the username have to be "postgres" instead of "root" here.
this is wrong. It does not reflect the real container passed to the DI extension
Could you rename this to ``isDevDependency``? Basically removing the ``get`` and there is also an ``n`` missing at the end.
I've added `--sqlLocation` option to `azure mobile create`. It allows you to specify the location of the SQL server to create. it defaults to mobile service location.
tool is duplicate int he `build tool`
Now this line should be:
      if (!file_exists($this->config)) {
We cannot afford using `@import` rules.
Yeah, I know how those methods work, so I knew this would still be OK on 10.8. If we rename them, I'd go with `isAtLeastLion`. :-) We'd have to check plug-ins for those. I know Networking uses it to decide between "AirPort" and "Wi-Fi" in names.
May want a comma in here; `dragging it, versus the`
Internal use only, should not be exposed.
please pay attention to the checkstyle guidelines (util-classes should be final)
Я бы не рекомендовал изменять этот код, там улучшить нечего. И задержка необходима - на некоторых бордах родная карта строится не сразу.
На ычане и некоторых других бордах меню возникает на пиксель ниже кнопки и если относительно медленно перемещать мышь вниз, меню успевает исчезнуть.
Why PPS?
yeah. also looks like a simular XSS attack will work on PlayBook as well:

https://github.com/blackberry/WebWorks-TabletOS/blob/master/framework/src/webworks/webkit/WebkitControl.as#L169
A bunch of the copyright messages seem different than our usual. Is there a valid reason for this inconsistency or is it just a mistake. Please confirm
Нет кейса для service, чтобы руками сконфигуренный сервис, можно былю заюзать как дефолтный сторадж
as g is the same for all objects of this class, we should make it a class variable (same as static in Java), denoted by @@
(<= 13 age 19) palauttaa jo sellaisenaan booleanin