labofsahil/github-event-dataset-2012 huggingface dataset:
I used :update originally because I got an error running "rails g spree:install", I confirmed with master and :install still causes the issue


       run  bundle install
/Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/bundler-1.0.18/lib/bundler/definition.rb:82:in `resolve_remotely!': Specs already loaded (RuntimeError)
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/bundler-1.0.18/lib/bundler/installer.rb:43:in `run'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/bundler-1.0.18/lib/bundler/installer.rb:8:in `install'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/bundler-1.0.18/lib/bundler/cli.rb:220:in `install'
	from /Users/cmar/Projects/Work/spree/core/lib/generators/spree/install/install_generator.rb:196:in `bundle_command'
	from /Users/cmar/Projects/Work/spree/core/lib/generators/spree/install/install_generator.rb:120:in `install_gems'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/thor-0.14.6/lib/thor/task.rb:22:in `run'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/thor-0.14.6/lib/thor/invocation.rb:118:in `invoke_task'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/thor-0.14.6/lib/thor/invocation.rb:124:in `block in invoke_all'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/thor-0.14.6/lib/thor/invocation.rb:124:in `each'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/thor-0.14.6/lib/thor/invocation.rb:124:in `map'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/thor-0.14.6/lib/thor/invocation.rb:124:in `invoke_all'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/thor-0.14.6/lib/thor/group.rb:226:in `dispatch'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/thor-0.14.6/lib/thor/base.rb:389:in `start'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/railties-3.1.3/lib/rails/generators.rb:168:in `invoke'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/railties-3.1.3/lib/rails/commands/generate.rb:12:in `<top (required)>'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:240:in `require'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:240:in `block in require'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:223:in `block in load_dependency'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:640:in `new_constants_in'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:223:in `load_dependency'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/activesupport-3.1.3/lib/active_support/dependencies.rb:240:in `require'
	from /Users/cmar/.rvm/gems/ruby-1.9.2-p290/gems/railties-3.1.3/lib/rails/commands.rb:28:in `<top (required)>'
	from script/rails:6:in `require'
	from script/rails:6:in `<main>'
@BDQ: the `auth` alone passing when it was still in `three-dot-two` branch, the brokage could be due to another commits introduced after
I think it would be cleaner for the `_getLabel()` method to search for the any `"yui3-button-label"` node when trying to find the label of a button. Also seems like it could _always_ use `text` or `value`. I'm not sure I see why `innerHTML` has to be used.

```javascript
_getLabel: function () {
    var node    = this.getNode(),
        tagName = node.get('tagName').toLowerCase();

    if (tagName === 'input') {
        return node.get('value');
    }

    return (node.one('.' + Button.CLASS_NAMES.LABEL) || node).get('text');
},
```

I also do not see the need for a seperate `_uiGetLabel()` method, that seem redundant, and this version of `_getLabel()` should probably be the `label` attributes `getter` function.
Any solution for build problems on windows?

    Error	38	error C2664: 'DllLibNfs::nfs_lseek' : cannot convert parameter 5 from 'off64_t *' to 'off_t *'	d:\xbmc_git\xbmc-main\xbmc\xbmc\filesystem\filenfs.cpp	346
    Error	39	error C2664: 'DllLibNfs::nfs_lseek' : cannot convert parameter 5 from 'off64_t *' to 'off_t *'	d:\xbmc_git\xbmc-main\xbmc\xbmc\filesystem\filenfs.cpp	348
    Error	40	error C2664: 'DllLibNfs::nfs_lseek' : cannot convert parameter 5 from 'off64_t *' to 'off_t *'	d:\xbmc_git\xbmc-main\xbmc\xbmc\filesystem\filenfs.cpp	433
    Error	42	error C2664: 'DllLibNfs::nfs_lseek' : cannot convert parameter 5 from 'off64_t *' to 'off_t *'	d:\xbmc_git\xbmc-main\xbmc\xbmc\filesystem\filenfs.cpp	578
        110	IntelliSense: argument of type "off64_t *" is incompatible with parameter of type "off_t *"	d:\xbmc_git\xbmc-main\xbmc\xbmc\filesystem\filenfs.cpp	346
        111	IntelliSense: argument of type "off64_t *" is incompatible with parameter of type "off_t *"	d:\xbmc_git\xbmc-main\xbmc\xbmc\filesystem\filenfs.cpp	348
We're getting closer. :) I'm OK with 1 and 3 (discretionary ligatures are next on my list and this was the way I hoped we could do it).
I'm not sure how to do 2, however. Your points are valid, but I don't see good solution:

* we could make BaseEngine (and put common stuff in and extend from that) but I don't see anything else common to both engines.
* we could make api.registerEngine inject util functions but that would be overkill as well.
* we could make transformer function an option but there is already `modifyText`, which, unfortunately is not appropriate for the use here.
* or we could just leave as is for now: `Cufon.CSS.textTransform(font.applyLigatures ? font.applyLigatures(text) : text, style).split('');`.

Is there other way? What do you suggest?

By the way I tried accessing chars with indexer (string[]) as well. This is way faster in IE but I wouldn't change to that though.

You didn't give me any comments on how to submit new patch?
I did not test that.
вообщем у меня рука тянется залезть в компилятор и посмотреть в чем там дело
A general comment on this patch: I think it's a great idea, but would prefer to *not* insert the "@" in the type and call the parameter "--raw" instead of --special. Thus we can support the extensions and other stuff as well, still not sticking / depending on a specific version.

__cron foo --raw "!foo" would work, as __cron bar --raw "32times a day, if moon is half filled and birds are making a romantic evening" with this mode :-)
можно писать
if product = Product.find_by_id(params[:product_id])
...

так на одну строчку меньше :)
It errors-out at the beginning of this method if markdown content doesn't exist.
Электорнная?

Сокращенная форма используется вынуждено из-за нехватки места в некоторых формах.
Is this commit still valid? Any chance you can get Openlayers working?
I'll take a look at your patch later. Here is the list you requested: http://paste2.org/p/1863981
> Unfortunately, I don't think it's possible to totally remove the axis labels and ticks from inside the geom code -- the user has to do that manually. 

@wch - I'm not sure we need to remove them, but maybe I'm just misunderstanding what a histodot dotplot is supposed to do. Consider this code:

```r
ggplot(mtcars, aes(x = mpg)) +
    geom_dotplot(method="histodot", binwidth = 5.5)
```

which produces this graphic: 

![Dotplot where multiple bins exceed a count of 1.0][1]

My expectation for a dotplot with "count" on the y-axis was that "count" would basically indicate (bin count) / (total count). That is, the numerical value for the height of a dot stack was precisely (or, at least rounded) the fraction of total dots that were binned in that stack.

The above graphic proves that my interpretation can't possibly be the case, since two stacks clearly exceed 1. Also, a look back at Wilkinson (1999) confirmed that the original graphics don't even really have a quantitative y-axis. 

Is that why you're suggesting that we "blank" the axis text? Because it's not actually a count anyway?

[1]: http://briandk.com/screenshots/DotplotWithCountsExceedingUnity-20120226-215430.png
This needs rolled back, this is a feature not a bug.
Who ever requested this to be fixed had the "essentials.eco.loan" permission which is designed to allow the player to go into negative balance.
Shouldn't be `developer.unsupress()` ?
Hey Aaron, It looks like you're using some C++ generator code that did not include support for optional fields.  Since you're using the weekly code with the os.Error -> error change, if you grab the C++ Go Generator from the weekly branch, you'll see we now have support for optional fields :-)  I've had someone else confirm that it works with Cassandra.  

You'll also want to get the one-line patch for tlist.go if it's returning twice the number of elements that it should.  See https://github.com/pomack/thrift4go/commit/5c81c2d767b642950f80417d5848fa33045d5460#lib/go/thrift/tlist.go

Let me know whether the updated C++ Go Generator works for you.
meh, you're correct. I'll fix it.
Well, not exactly…
I just remember from my recent codeschool course that "live" is far less performant than "delegate" used on a specific section of the markup.  So, if '.tandem_content' only is going to appear under select places, that might be useful.  Regardless, can't we add "click" as another element in the above hash being used for mouse events rather than re-selecting ".tandem_content"?
Hope this fix works ok for the Ark users :)
the wheel bounding box might be to big, see: http://www.youtube.com/watch?v=dg8pic7mloE
this was supposed to be
this.authPath(this.authPath() + '?display=popup');

updated in next commit
damn, that's a lot of files
This is the latest one*
Host url is harcoded, should be picked from scrumr.properties
#前加个空格就行了~ #27
Ah, sorrt. I just see now that it is a new branch.
ah but thats what related_name does, it says "this field does not exist, but i want it created. It should be a foreign key (or m2m) pointing back to me"

Which means Skill.subtypes will look like this: models.ForeignKey(SkillSubType, related_nameskill", ...) but is created _implicitly_
LogLevel = 2
LogFileLevel = 2
VMSS.Statistic.Enable = 1
VMSS.Statistic.Threads = 1
VMSS.Statistic.Interval = 300000
Not necessary, defaults to "NONE".
How about the following?

```C#
if ((blob = repo.Lookup<Blob>(sha)) != null)
```
Why did you comment out the condition which decides what qnas should be marked as new ?
This way all the question will be marked as new.

+ please commit such things separately. this condition has absolutely nothing to do with the logout stuff
I suppose this should be ```mkdir build```  ?

make build actually call make all ; which fails on my host
fahmy pake yii bootstrap, aku  udah coba di local belum aku push, ngantuk n lwapeeer
this commit is taken from jim's pr: https://github.com/xbmc/xbmc/pull/382
In the meantime it has had quite a few testers since it is included in openelec developer builds.
thx for this, will add it to the master branch now.
I left a bit commented out, here was where 192 bytes of zeros where pushed out, and I replaced that with the server and file name.
you should try to not reverse urls twice, if you can help it. but this reads just fine.
Is it really necessary to change term -> expression?
Ticket http://open.silverstripe.org/ticket/6842

Other part in cms: https://github.com/phalkunz/silverstripe-cms/commit/915202f980ec3c9be8968e5f34fa67d0ff6dbbbe
indendentation
merci Régis d'avoir intégré ma pull-request dans ton commit (et merci pour le client).
deux petites questions (gentilles) :
- si je n'avais pas fouillé dans les scripts ce matin, comment aurais-je pu savoir que ma contrib était intégrée ? (pas de notification de github, ni de mail à priori)
- je n'ai pas pensé à mettre mon nom dans les commentaires d'entête des scripts; aurais-je dû le faire ? quelle est la politique à ce sujet ?
yes, I have renamed the repository to dozer as it is github best practice.

Dmitry

On Tue, Jan 24, 2012 at 11:39 AM, Alan Stewart
<reply@reply.github.com>
wrote:
> Actually push just worked after I changed the DozerMapper/Dozer.git to
> DozerMapper/dozer.git. Did you change this?
>
>
> On 24 January 2012 20:36, Alan Stewart <alankstewart@gmail.com> wrote:
>
>> Hi,
>>
>> I added a new new unit test to ReflectionUtilsTest and also cleaned up all
>> the calls in GranularDozerBeanMapperTest to getMapper so that just a string
>> is passed as suggested.
>>
>> Having trouble pushing at the moment. Getting
>> ERROR: DozerMapper/Dozer.git doesn't exist. Did you enter it correctly?
>> fatal: The remote end hung up unexpectedly
>>
>> Another advantage of commons-lang is that the Validate class can be used
>> to enforce the contract of the public api by calls from users.
>> Anyway, I have time tonight and tomorrow morning to do the commons-lang
>> 3.1 upgrade, but since this will affect a lot of classes, do you want me to
>> wait until the morning for you to apply any other patches?  I don't need to
>> do any more tonight.
>>
>> Let me know
>> Alan
>>
>>
>> On 24 January 2012 19:48, Alan Stewart <alankstewart@gmail.com> wrote:
>>
>>> Will have at look at it again soon - just out at the moment. Will also
>>> add a unit test for the the new ReflectionUtils method.
>>>
>>>
>>> On 24 January 2012 19:20, Dmitry Buzdin <
>>> reply@reply.github.com
>>> > wrote:
>>>
>>>> I would add a separate unit test on this one in ReflectionUtilsTest
>>>>
>>>> ---
>>>> Reply to this email directly or view it on GitHub:
>>>>
>>>> https://github.com/DozerMapper/Dozer/commit/59513a3e91791671b2475a46655ee81fcc038c5b#commitcomment-895341
>>>>
>>>
>>>
>>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/DozerMapper/dozer/commit/59513a3e91791671b2475a46655ee81fcc038c5b#commitcomment-895503
Ionar should split only once, at 50% HP, since some patch.
Fixed in fd3461a5c06b9178f6da20f5274f014b36782772.
We have to avoid to check in the auto-generated .orig file.
あーごめんなさい。^ つけます。
We must enable warnings; otherwise the `configure` script will wrongly guess that the style of `gethostbyname_r` is glibc and the build will fail. This should be fixed in Traffic Server 3.1.2 -- see https://issues.apache.org/jira/browse/TS-1091
> My solution has the cost of a synchronized in the construction of the partial function, but the apply is optimal in the sense that it there is no overhead if the original partial function is invoked (as opposed to the orElse argument).
Plus synchronized at every access to APF.fallBack.
So if you have `f = f1 orElse f2 ... orElse fn` then `f1.apply` will be called without overheads whereas for any other `i` `fi.apply` will be preceded by synchronized block.

> Your solution makes the apply go through one forwarder per orElse.
Of course. Note that all orElse chain is flattened during construction so in `f = f1 orElse f2 ... orElse fn` call to `f1.apply` will go through only one forwarder.

As regards to performance, what bothers me more is that both solutions (yours and mine) kills the possibilities of PF specialization (at least return type specialization). I wonder if this can be a problem in future.
yep that works for me. both can be `loc()` for now if you'd like
nice one ! :)
Looks fine. The thing i pointed out could be done in a seperate "Random small fixes linked to lua c++ scripting functions." commit
looks fine (for me) and works fine
Who is tommy and who missed what? Talking about mangos version? There are several commits for this system not only this one on mangos anyone has the same crash and can fix it?
Oh right, just thought you'd forgotten, I didn't check :-P
With this 4 tests are still failing, but you can use social_stream flawlessly. Kudos to @atd for the rails magic.
What kind of application do you see for async functions in a config file.
Este cambio, por cierto, permite demostrar la generacion de un conflicto entre este lado (web) y el otro (traduccion), ya que por un cambio posterior de estos ultimos, le pegan justo a la misma linea de este archivo....
プラグインも変更して全体を統一しましょう。
i don't spot anything except for that if, if someone wants to cherry-pick this commit... @sbte ?
@cyanogen We should not init using git@ though, since everything goes through gerrit.

In any case, here's a hack/script I use to set up the push URLs on git:// repositories:


https://gist.github.com/1954630
Huge indeed...

Sorry, but the original etherpad does all the things you don´t do in the frontend:
- use DIVs for layout only
- attach an ID to every single element on the page
- attach events with onclick handlers
- use absolute positioning on all elements
- use separate images instead of sprites
- use image formats without alpha transparency
- ... the list goes on endlessly

As you can see, I did like 5,000 changes, but the amount of code was reduced by around 50% in some places and it is so much more efficient and easier to understand now.
It still takes a huge amount of work to arrive at a cleanly coded interface, but I hope that this provides a good foundation for future work.
Good idea - looks great! Thanks
Ah, yes, I got that.  I guess in this particular case, throwing a string is good enough to let the dev know that they screwed up.  :)
these are going bye bye, I want to replace them with a simpler less opinionated api
**Top_Cat** *pounces*
Could the default be None instead?
The interpolation function coded is actually not the 2-tap interpolation functions people usually use. It's actually a variable tap function that can take any number of data points and resample them properly, so large pre and post resampling sample rate differences don't cause issues.
This service looks quite artificial. The only reason it exists is for backwards compatibility. Since I can't think of a different solution, I'm ok with that. In the future we might want to extend it to allow registration of controllers via myModule.controller which would delegate to $controllerProvider.controller or something like that.
Hey Flo cool, das du das gemacht hast, aber ich glaube da gibts/gabs nen gem für müsst ich aber erst noch nachgucken.
Hey hello my name is Sherlock.
Never trust input from outside
Some enchantments are too long to write on the enchant signs.
awwwww yeaaaaaa
Hm... Don't kill mez. Okay, it's done. But it needs also be done for the registry? I mean, when we update max players or something send the command and the data to the Registry. (If the command was supposed for that lol)
Use DoCastSpellIfCan instead of m_creature->CastSpell below - also maybe research if there is a related ScriptEffect spell for this (would fit the diff-mode dependend multi-casts)
This breaks the installer.  You are importing tempodb on line 13 now, before it exists on the system.  When you try to import tempodb, dateutil is not yet installed and the installer breaks.
- 로컬: 개발자 PC
- 개발: 개발서버(dev.springsprout.org)
- 운영: 운영서버(springsprout.org)

정우가 메이븐 프로파일쪽 설정보고 적절하게 서버 설정해줘.. 으히히..
yes, this was only called by `build-stage`
I find that the real hovercard doesnt happen after this change, The hovercard doesnt stay visible when mouse is moved over the hovercard.
What about using the plusignment operator to add default directories to the path?
this modification makes the tag @references do not be displayed
You need to use Player.setAimByMouse(x,y) for the player to update it's aiming Vector and graphics, or take a look at it and find a better solution.
This is a comment....
Why Retriman?, If only knows copy without giving thanks?   
thanks Left4Info for your work! and Machiavelli for the implementation :)
what? :s 
https://github.com/Retriman/TrinityCore/commit/8b06d6d388e80fc1dc3a4ae932671ff0d16edeac

paecman = Left4Info  <paecman@googlemail.com>

i have credit in my repo :s
You can still grow/shrink/grow and write the same value at a different time. I'd assume you need the tag at every element, every time. And I'd increase it, rather than try to keep the same. It's simpler, the effect is the same and the number of counters is far bigger than it'll ever be used.

And 64KB is more than enough RAM for everyone.
Did you have problems with the current policies, or is this just a "honk also works"
tag.php :)
Wouldn't you want this to point to the github version?
Will work on mtp and update this section.
Cool! wasn't for me :)

Any way driver not working for now. i see arrows, but no traffic. i am trying to rebuild some code. and test for some more.
But driver compiled as Module and as internal with no warnings or errors, so i hope that problem is with my NET drivers or config.

the old one worked ok.
I wanted to move these rules into their own classes, because they're actually dependencies. I wanted to inject this logic into an engine that isn't aware of the logic associated with the rules themselves. This will become more clear as you move through the commits.
Nice work @mdesrosiers!
``v2.1.0`` does not exist yet
right, missed it
Замени l = left и так далее
From what I understand, it is cascading on a user to items. I mean if a user is deleted, items adding by the user will be deleted as well.
This doesn't seem get used anywhere.
This is really awesome, @wilhelmbot! I've wanted light markup support for a while!

One thought I had about the architecture. Consider:

### TTTAttributedLabel.h
``` objective-c
@interface TTTAttributedLabel (Markdown)
- (void)setTextWithMarkdownString:(NSString *)markdownString;
@end

@interface TTTAttributedLabel (Textile)
- (void)setTextWithTextileString:(NSString *)textileString;
@end
```

I think this is a clean, decoupled way to add markup support that scales well. It may also make sense to add an extended version of that method that passes a block of the resulting attributed string.

Thoughts?
Replace with write to debug log
@treyhunner 
 I implemented the `indent_size = tab` support for geany now. For convenience, I use "indent_size = -1000" in the source code when indent_size is set to "tab". This way, we may have problems if we want negative value of indent_size in the future, but it's more elegant. So if we want indent_size to have any negative values, we could use something else more meaningful instead, such as `indent_size = feat_name12` (feature name + number).
What's the ratiuonal behind this? I thoug
`which's` ? Is that a typo?
dont work for windows
Apparently this function was returning the value as a string when it should've been an array which was giving a warning later on.
Looks great jbird next onto the lockscreen text color
Was that my typo?
awesome, I'm waiting the release
Посмотрел, он зовёт `_link()` и `injectSubArch()`. А проверка у тебя только в `link()`.
Представь ситуацию, когда у тебя добавляется кусок дерева, только часть из которого уже выполнялась.
Sorry to be nit picky, but please align the # above.
I don't think it makes sense to add a general options attributes to the method. It would be better to add an actual disk config attribute or pass a parameter to the create method. Here's my general rule of rhumb: use attributes for data that is returned by a list and/or details call, and use method parameters for things that are only specified during an action. I believe this is returned by the list and details API call, so this should be something like:

```
attribute :disk_config, :aliases => 'OS-DCF:diskConfig'
```
…Unless they are `free()`ed though, right?
"jqm_list_split_button" should be "jqm_split_list_button"
Utils is not imported?
Hm, if you ment `case Event(SetTarget(t : Some), d) ⇒` then this does not work...
Could we switch to Scala Lib's MurmurHash or Phil's new hash?
ok, pushed change to this branch
ok, and then also in the migration guide
So what you are saying is that I should remove DevRandomSeedGenerator
because according to Paul Dyers SecureRandomSeedGenerator code:

 * <p>This is the only seeding strategy that is guaranteed to work on all
 * platforms and therefore is provided as a fall-back option should
 * none of the other provided {@link SeedGenerator} implementations be
 * useable.</p>

On 2012/07/03 08:04 AM, Björn Antonsson wrote:
>> +    new RandomDotOrgSeedGenerator :: // first try the Internet seed generator
>> +      new DevRandomSeedGenerator :: // try the local /dev/random
>> +      new SecureRandomSeedGenerator :: // this is last because it always works
>> +      Nil
> I think that the order should be `RandomDotOrgSeedGenerator`, `SecureRandomSeedGenerator` and then `DevRandomSeedGenerator`. The `SecureRandomSeedGenerator` is configurable from the outside, but the `DevRandomSeedGenerator` is hardcoded to `/dev/random`. This leaves more possibilities to configure your way around bad `/dev/random` implementations.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/akka/akka/pull/571/files#r1090104
yes, that would feel better, they are triggered by these watches, right?

    systemGuardian.sendSystemMessage(Watch(guardian, systemGuardian))
    rootGuardian.sendSystemMessage(Watch(systemGuardian, rootGuardian))

there is some initialization order to think about here

this termination hook business is only needed for systemGuardian, perhaps I should make two different Guardian classes, so that userGuardian can be kept simple
use must matchers instead of asserts, for fun and profit!
needs to be private[camel] - we talked about it
ok, so be it :)
Already pushed :-)
The xref element is not closed.
I had a discussion with @kindy about exactly this. I prefer from ... import in cases where I want the import to fail as soon as possible. I'll change it in this particular case, though.
I think it would be great for this method to have a couple of its own tests.
I think the diff output is misleading here.  Please check the file.
See comment above. What you do now is make a vector into a string and then back into a vector.
Do you mean constructing the packet here and setting stop_parse to 1? Will try this.
wrong indentation for the array of the value map (using tabs instead of spaces maybe ?
What sort of layout do you have in mind? We can only centralize so much, because we need the actual configuration object of a given piece of code. Or do you mean to centralize the actual logic applied to configuration objects?
Perhaps using xs:float or xs:double instead of xs:string?
oops, this line should not have changed. I'll update the pull request when I get home
wwRows is not very descriptive.
There is not need to pass "asset" to getParsedObject()
Please don't forget to add copyright/license headers to new files.
The language "it's not recommend" is not strong enough.  It's a requirement, not a recommendation.  It should say "You MUST NOT use the same mapper for ...".
--> } else {
Unfortunately, the way that delete is called here, it only deletes sdmanager_. 

Here's a stackoverflow discussion on the topic : http://stackoverflow.com/questions/3037655/c-delete-syntax . 

This will, unfortunately, have to be changed to :

```
delete sdmanager_;
delete commod_;
delete manager_;
delete p1_;
delete p2_;
```
Did something get truncated here?
This property does not appear to be used.
One Buffer declaration per line, no unnecessary newlines.
NodeCounterProvider is the name of a code-genned extern (by the perfctr tools)--so I'll leave it, but the others are fixed.
Typo and doesn't follow the convention of starting your comment with a capital letter
This should be subsumed by `xhr.header("Content-Type", …)`.
Make sure to add other dependencies as well (especially OpenLayers components).
dfhgjdhgjkdhgjk f gd
было бы удобнее сделать все виджеты реально ui-виджетами
хм, и правда не выйдет
@jonleighton @rafaelfranca hey guys, could you please work on shrinking this list down? If you have questions, please ask me. But basically, everything that will be loaded at boot time if used (for example, Base and the modules it includes), needs to go. Feel free to do the change on master, I can rebase later.
Right -- I was supposed to discard those, and forgot.  Fixing that now.
Sorry, we are using. I think is better to define only the `attr_writer` and rename the `set_current_config` to `def current_config(env = Rails.env)`
this r dumb
That said, I do know quite a few people that love client_side_validations ;)
I think this doesn't work, since calls to `len` were throwing errors.
Previously, `HashTable.serializeTo` would by default serialize the key, and map the entry to some value that needs to be serialized. Now, it requires calling the `out.writeObject` explicitly within the closure.

Normally, the correctness of such a change should be validated by the `test/files/jvm/serialization.scala` test, but I do not see `LinkedHashSet`s included there. Linked hash set serialization check should be added there.
There's a very good example of integrating a "normal" macro into fast track:
1) macro (this step is already done): https://github.com/scala/scala/blob/2.10.x/src/reflect/scala/reflect/runtime/package.scala
2) registration in definitions: https://github.com/scala/scala/blob/2.10.x/src/reflect/scala/reflect/internal/Definitions.scala#L489
3) bridge in fast track: https://github.com/scala/scala/blob/2.10.x/src/compiler/scala/tools/reflect/FastTrack.scala#L37

Nothing scary. Just two extra lines and a redeployment of starr.
Doesn't this fail if the function returns a list? It's probably not an uncommon case for the user function to do this, so it'd be better here to do things in two stages: (i) unpack the tuple with PyArg_ParseTuple, (ii) convert the array using PyArray_ContiguousFromAny.
Ah, yes, right!  Sorry, `len(S)` and 3 got mixed up in my head :-(
It's bad because it hides the definition of x from the user. When I read this, I don't know what the assumptions on x are. Also, it reinforces the confusion between Python variables and sympy Symbols, which is a major problem for new users.
MatMuls are strange in that they can also contain Exprs. The is_Matrix is there to protect against the AttributeError on Expr.is_MatMul
Should this be a @property?
@cebe OK. I'll send a PR.
Please check if it's not overriden in any child classes. If it is, there will be PHP error.
This line needs a doxygen comment.
There's no reason to touch this file for this change, and we've moved on from 80-character-wide editors.
I don't think there is a ja PDF yet, as I wasn't able to get the PDF to generate correctly.  However, I'm not very experience with Latex and know even less Japanese.
3.0 is still a very long way away from release to be worrying about right now and it will probably have a separate book due to all the change just as 1.x and 2.x are separate.
I prefer `== -1`, that's what we use almost everywhere else in libuv.
Remove this file from repository.
is there a chance that exports will exist but process.env wont?
Sure I can do that. I checked and all use cases for main_project have a check for !is_published? somewhere.
Is the comment about the *.hbm.xml still relevant?
I was thinking of this API call: http://joda-time.sourceforge.net/apidocs/org/joda/time/format/DateTimeFormatterBuilder.html#toParser()
This duplicates the content in http://docs.mongodb.org/manual/applications/replication/#write-concern

I think we can kill it here.
Good suggestion. We shouldn't eschew passive all together.
sorry, I didn't catch this earlier, but I think we can just say "It applies entries from an oplog," I'm not sure "a command object entry," makes sense. 

If we want to be really extravagant, we could also say, "It applies oplog entries passed to the command in the ``<operations>`` array,  to a database, or collection if you specify the ``ns`` option." 

Correspondingly, we should probably change the "array of operations to perform," to "array of operations to apply."
"ascending order" is not necessarily good advice, and sometimes it's very bad advice.
May want to change the URL for this, too: At some point, we'll want a page that lists all templates for viewing and editing, just like the needs-review URL. That will probably want to live at docs/templates.

In fact, I still think this all best lives under the admin pages, because we can search for `is_template` like this:

http://developer-dev.mozilla.org/admin/wiki/document/?is_template__exact=1

The sidebar in the admin tool has filters, and `is_template` is one of them. From there, we can use the checkboxes to select what to export with Smuggler.
Consider "notification type" instead of "item type".
v2 here and elsewhere.
The original intent was simplify the cache drivers by removing redundant code.
I think talking about relative vs absolute would just confuse users. Absolute should always be used.
So this should probably be changed to sth like that:
`<input type="submit" id="preview_btn" accesskey="f" tabindex="6" name="preview" value="{L_FULL_EDITOR}" class="button2" onclick="document.getElementById('postform').action += '#preview';" />&nbsp;`
and include some .js file with this content:
```$('#preview_btn').click(function(){
   $('#postform').attr('action', , function(i, val) {
      return val + '#preview';
   });
});
```

... I think...
s/Root/root ?
Should've a space between the closing bracket and the dot and between the dot and the apostrophe.
response was advertised to be a string, how does it have a chunk property?
These should be set as class properties instead of being globalized.
That: OPTION_FLAG_BBCODE + OPTION_FLAG_SMILIES
Is only equivalent to:
OPTION_FLAG_BBCODE | OPTION_FLAG_SMILIES
because there don't have not shared bits.
I.e.
OPTION_FLAG_BBCODE = 001
OPTION_FLAG_SMILIES = 010
OPTION_FLAG_LINKS = 100

The bitwise OR is the standard(?) (at least the most logical to me and what's teached). I don't know about the specifics and which one is faster but the bitwise OR is what makes more sense to me. If there's something in the coding guidelines that I missed, I'll fix it.
Hrm, good call. I just pulled this out without looking.
is 'i' the index?
Fixed in b450dc0
No curly braces for single expression bodies.
1.) You’re right :) The commit is already there
2.) Hm, fps logging is kind of baked in atm, so it might be difficult to move it out
Nice. But a comment about intent here would be nice to clarify the goal of the loop.
YUI does always return the Y instance, even if the callback is passed for chaining purposes!

About the number of lines, not a big deal since this is server side only.
I think that's fine actually
Is there a performance issue related to running that loop on rows twice? Or no?
what this does is that if there is no plus(a, b), the expression that will be built will be map(plus_., a, b). We probably only want this to happen during evaluation, not construction
This will most likely be a store that searches on concepts with "route administration" (can be oral, injection, skin, inhaled, etc, but we will need the uuid's eventually too. I am working on this currently in pharmacy.
Please remove other, we only want Male/Female.
We should log the ParseException rather than a silent one
How about a code tidy while you're there?
This was to see easily the numpy interface to this function. As it is also in the cuda_ndarray.c file, I'll remove it here.
you TODO to ease grepping.
This, I must admit to cargo-culting (i.e. I'm not sure what else it does). @slfritchie has warned me off when I've snuck in calls to unload before.
Хм, очень странно
This probably resulted from a search/replace operation.  But if it's not, I prefer to use space for alignment, TABs for indent. Even more so in comments.
Use uppercased keywords.
select => SELECT
bra!
Why is the default `output_type="hazard_curve"`? For a generic `create_output` method, this seems strange.
s/eecords/records/
hoge って何？っていうテスト
Oh, meant to delete the timing stuff. Is it worth leaving in?
then `testEl` would be absolutely positioned, so `getOffset( testEl, ... )` would not recurse.
Not only is louisremi right about the non-critical aspect of this code path, but perf results seem more mitigated once you store the regexp: http://jsperf.com/indexof-vs-regex2/2
I should probably add another note saying that running `npm install && grunt` (or checking out the git submodules manually) is required before creating a custom build.
What happened to the modularity check for jQuery.ajax?
returns empty string in Chrome 23 and IE9.
What about quantile functions?  Is there general rule for invalid inputs for them?
I'd rather express it as a function of the machine epsilon and give an explanation for this expression.
> This code doesn't work in case the facebook package was added before accounts-ui.

Ah, indeed. Dependencies... 

> I'm redo'ing the login service listing to iterate over the Meteor.loginWith{ServiceName} methods instead

Do you have a branch where you're doing that work? I'd love to take a look and/or contribute.

> I think the next step (outside this PR) would be to eliminate all of the boilerplate code in files like facebook_client.js. It could be pretty easy to create a function in accounts-base/accounts_client.js named, say, Accounts.registerLoginService that does this...

Was definitely my plan - I think `Accounts.registerLoginService` would be the correct sort of abstraction that I had in mind as well for later :) Wanted to get something out there first, and then iterate.
Why not just use the camleCase names in futures and then do:

```
for future in futures.values():
    future.get()
if futures['currentTrack']:
    futures['currentTrack'] = futures['currentTrack'].serialize()
return {'properties': fututures}
```
Doesn't the `'0'` at the end here and the `'1'` at the end of the previous list cover the case that the `return bool(int(s))` covers? Do you need both?
Could just make this an ivar:

```rb
@locate_cache ||= {}
return locate_cache[tool] if locate_cache.has_key? tool
```
I thought it might, but I just checked to make sure and it does not. I've removed it along with the few bits of template that were left.
Global?  Needs to be passed via the thing that initializes rest client.
A comment would have saved me some time. flair_csv_and_list sometimes throw an error, as do either subscribe_and_veriify or unsubscribe_and_verify. Are these upstream bugs as well?
this whole block could and should be rewritten like:

```javascript
var filepath = getFilePath(templatesFolder, basename, language)
                        || getFilePath(templatesFolder, basename, 'en_US')
                        || filePath = getFilePath(templatesFolder, basename, 'en_US');

if (!filepath) {
    delete componentConfig.views[viewId];
    return;
}

// the rest of the logic goes here
```

this way you reduce the indentation level, and also simplify the logic
..."to translate it": Who's it ?
I think it's a you-ain't-gonna-need-it situation. Logging when codegen isn't working is good information; it tells you that you aren't as fast as you should be. But this should also be FINE, 'cause it's doesn't harm behavior. If we ever want to rip out the reflection path altogether, we might have a different story. For now we need the reflection path for superclasses that get compiled independently from dagger.

When we fail, one exception should be enough!
However, bestEval is has automatic storage and, consequently, is released at the function's end; plus, the variable is not used anywhere in the function after this point, no?
Can you inline `doAddJsonSchema` and do

`schemata = Array.isArray(schemata) ? schemata : [schemata]`
Not your place to decide the Spout standards though.
Maybe it's obvious from context, but it wouldn't hurt to say what the string key means here.
No reason. Added Module to all these declarations.
jquery ``$`` is unused
Done. Agreed. This would be nice centralize with FileIndexManager or FileSyncManager.
I've addressed this by checking if the plugin is available first. I realize it isn't the most convenient approach right now but it works and will work with FTP, so I suggest in the interest of time that we implement a better architecture after our current push.
* sigh * I picked sqlalchemy to avoid SQL. (The code looks fine though, and I vaguely remember running into the same issue, hence why I opened the issue in the first place. Keep up the good work!
same comma comment as above
Already did. :-P
El ago 23, 2012 6:55 p.m., "Fernando Lores" <notifications@github.com>
escribió:

> In scripts/welcome.js:
>
> > + *   None
> > + *
> > + * Configuration:
> > + *   None
> > + *
> > + * Commands:
> > + *   None
> > + *
> > + * API used:
> > + *   http://iheartquotes.com/api/
> > + * Author:
> > + *   martinpaoloni
> > + */
> > +module.exports = function (robot) {
> > +  robot.enter(function(msg) {
> > +  //robot.hear(/quote/i, function(msg) {
>
> yes, please remove it
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ferlores/Boric/pull/25/files#r1449594>.
>
>
This has global scope, maybe not such a great idea.
I'll add a test for that and some other things we're missing tonight.
Is this really needed to be repeated? Can we use just mark (void*) pr mark (YWidget*)  and share code?
Are you sure we can just simply assign this value? It is compatible?
You should check validity of the arguments in `__init__` so that they are checked only once and not for every `validate` run. Also exceptions will be thrown correctly at field initialization and not field validation.

Arguments can of course be `None`.
What shall be done with java scripts and stylesheets? I changed stylesheet path to load from static. I left google jsapi to load from default URL. Line 13 and 20 are inconsistent. Should I wrap lines 13-17 in a single line or unwrap line 20? If later what indent to use?
Don't use inline CSS.

Translatable string is here.
Make sure you TomDoc that :)
i think PageProvider is overkill for this project. there are exactly two pages one would go to directly, the home page and this one. Aside from conformance to 'the standard', i don't see why doing it like this is better for the user:

    complete_registration = CompleteRegistration(selenium, timeout, expect)
    complete_registration.load_page(url)
I think this wait should be after setting the password rather than before clicking the button.
Yeah, I'll use 412 instead since it's a client-originated error
It's just non-obvious for people who don't know there's a shim hiding in there.
If you look right below, we already have a check to see if the retrieval worked correctly :)
Similar to your check for empty values in a string, make an `isDataUrl( url )` function that does this check, and reuse it here and below.
space by left opening bracket
We have a resize in image.js too. Do we want to try and share code between the two?
https://github.com/mozilla/pdf.js/blob/master/src/image.js#L131
It mentions this in the pull request, but I did this for best practices. ActiveRecord defines this method to check if the in-memory record has been destroyed, similar to ```new_record```? It checks the ```@destroyed``` ivar, which we can set to ```true``` and avoid having to rewrite the method. 

For instance, if I have an arbitrary ivar named ```@some_record```, and I want to know if it's been destroyed in this request, I call ```@some_record.destroyed?```. But if that class happens to have ```acts_as_paranoid```, it might not have been destroyed in this request but would previously return ```true```. Probably not a huge bug, but I felt it was important not to change the meaning of the method.
Woops, Util in same namespace.  My bad, disregard
external module which will be compiled
Ooo that's way nicer.  I was planning on looking to see if I could use symbol keys, but hadn't gotten to that.  I like methods much better tho.
There should probably be a license header here
Oh very nice. I wasn't aware of that functionality.
Maybe specifically mention what this means, like the nurses for this unit and shift have been sent account creation emails and the ordering is set or something?
Arrghh, you're right. I will remove it :)
Ah, forgot about that overload. Yeah that could be problematic if eg. Select ran in parallel...
sqarely -> squarely
You might consider adding a docstring here so that the longer forms of the test-runner provide a description of the test.  

But it looks like you haven't done that in other places here, and it might end up a lot of work, so it's fine either way.
Use `ma.is_masked()`.  It will return `False` if there is a mask but none of its entries are masked.
It is not clear to me why we also restrict eligibility in the reverse direction when we have less than `NVal` remaining.
In my opinion, this mess should go in bignum_tests.cpp, since that's the only place it is used and I can't imagine we'll use it anyplace else.
I had a bad feeling about leaving another global in the bunch of globals that are used in the code. Should I come over this feeling?
I will update and use "Signatures" :).
Hmm, yes I think this change makes things a bit cleaner, thanks.
Same as above, all of these expressions can be reduced to a single `<<` expression binding.
The reason here is that we want to re-use the same functions from the client_validators module.  Proxying allows caching the validation function with a given set of arguments rather than re-creating on the fly.  The whole point here is to minimize the copying of code.

I was in two minds about whether the ClientValidator class should implement a non-trivial validate() method at all - presumably any text that the validate method sees has already been given the OK by the client.  The only reason for doing this is to allow fall-back to server-side validation for really dumb clients, but there is a potential problem here if validation is expensive.
Because of cropping?
Why the `@skip_doctest`?  There's no doctest in there, so it's not needed.
I see, I did not understand the S3 client also retried.
Line indentation seems broken here
Are there tests for the template file `add_lang_files` stuff?
Ditto remark 1.
Ah yes, good choice!
If there's a max_length answer to my above question, then it'd apply here, too.
This 19 is probably a setting or "constant" somewhere (or some setting/constant - 1). I think I'd use that here.
`self.logger.error('storage trouble for %s' % crash_id, exc_info=True)`
@peterbe er uh yeah :) ok then! thanks :)
We will soon start removing those, so better starting now! :) (See https://bugzilla.mozilla.org/show_bug.cgi?id=744446 )
You can use `:first-of-type` and `:last-of-type`
ah, good to know. I'll do that right now.
No - we can leave it there as is. Not a big deal. Does seem strange to me to return both err and return value, but that may just be me being used to what I'm used to.
Should be `REQUIRED_PROPERTIES`?

It looks like these are all necessary, so that would make the spec a little clearer
it does not make a difference.
If someone provides a request, it doesnt throw an exception...
This bugfix should be sent in a separate PR to be merged sooner IMO so that it does not need to wait for an agreement on the digest stuff
maybe var_export inside exception instead if you really need it
OK so basically all fields can/should be `xsd:string` and it's sorted out in the configuration class?
I would rename the property for consistency
Drop the ticket back into working.. add the copyright and set it back to review when you are done. 

Xcode should generate the copyright for you on new files if config'ed correctly. 

Andrew

On Sep 28, 2012, at 12:39 PM, kutecht <notifications@github.com> wrote:

> In candpiosapp/Utils/NSDictionary+JsonParserWorkaround.m:
> 
> > +//
> > +
> > +#import "NSDictionary+JsonParserWorkaround.h"
> > +
> > +@implementation NSDictionary (JsonParserWorkaround)
> > +
> > +- (id)objectForKeyOrNil:(id)key {
> > +    id object = [self objectForKey:key];
> > +    if (object == [NSNull null]) {
> > +        return nil;
> > +    }
> > +    
> > +    return object;
> > +}
> > +
> > +@end
> I forgot to add copyright. Is it too late?
> 
> // Copyright (c) 2012 Coffee and Power Inc. All rights reserved.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Maybe these should go in a pvt namespace? They are static, but I wasn't sure what was the best organization.
Dependencies should be locked, as per our Ruby styleguide. This is important for maintainability.
https://github.com/alphagov/styleguides/blob/master/ruby.md
good call. and can always make it more complex later
Modifier en `VARCHAR` si Sponsor.level est annoté `@Enumerated(STRING)`
caniuse.com shows quite nice info about browser prefix usage for this feature:
http://caniuse.com/css3-boxsizing
i htink you have two User_Profile no?
I think I wasn't clear when I said EJB client API changes. What I really meant was it requires a change in the EJB client project code to add the private attachments to that "jboss.invocation.context"key. Nothing more than that.
need localization :)