labofsahil/github-event-dataset-2012 huggingface dataset:
What do you think needs to be done about them?

The above code adds the OSGi packages to the FRAMEWORK_SYSTEMPACKAGES_EXTRA. As described in the comment above it, it is a temporary measure until we fully implement the R5 spec.
No expressions.
This is something we discussed in the past, and it didn't get approved to go in -- before EAP.
Afaik, @ctomc is working on this, to get proper / better support for this.
Just use .css("width") here.
This should be copying `testswarm-sample.json` not `testswarm-defaults.json`.

TestSwarm initiates the configuration object with `testswarm-defaults.json`, and then any settings you need to set, can be overwritten from `testswarm.json`.
I made the corrections and made sure they worked when I ran one of my models. I also changed the call to add_channel in sgd.py to explicitly specify the dataset, since there might be other datasets in the monitor at this moment.
Can you throw this stuff inside unit tests? If you shove the test files inside a `StringIO.StringIO` object, you can simulate a file pointer with it. See http://docs.python.org/library/stringio.html
lint error. It seems like botio lint tool is not working :)
You can also help the previous author by also rerouting `mozbrowseropenwindow` and `mozbrowserclose` events to this function, instead of using `.bind(this)`
better here to use if(fb.isEnabled)
It won't change anything, but I'd rather use `200`.
Sorry, should be `attachListeners`
This is really sad .....
nit: single quote
it is unneeded
EXCLUEDED -> EXCLUDED

What about splitting Gaia in two parts, one that is called apps/ and the other one that is called tests_apps/. Then GAIA_APP_SRCDIRS can default to 'apps tests_apps' and I believe that should be good for your demo?
Some descriptive text, like the old "To send and receive mail, you need to set up an account" string would be useful here, at least for the first time you set up an account.

Also, the bold-face on the form labels seems a little bit off...
rewrite this.
Well, you *could* use CSS to all-caps it rather than have the actual content read so yell-y. I guess that's semantics, but it just looks really odd...
nit: is this really a useful tool to expose?  or is this something that was interesting for debugging a specific issue and now just clutters things up?
Sure, could do that. I didn't for expedience today– the existing fixtures use this feature, I'll need to make some new fixtures that don't if I throw here.
最初のサービスだけ前後にスペースはいってるけど、残りもそうする？
We don´t need to require it here as it is already required in `slotcars.js.coffee`.
Extention should be extent
Done, for this and all other case classes.
By 'This probably isn't needed', I meant that I don't think we should include either of these methods:

```julia
function hcat(dfs::Array{DataFrame,1})
function hcat(df::DataFrame, dfs::Array{DataFrame,1})
```
what's all this? lots of stuff for one function
What's the point of this? It saves the pure json from server to the variable. I would suggest not to do this
Most of the following code hasn't changed that much--just minor whitespace changes.
(if we do use the self.codebase, then 'codebase' needs to be added here; however, see my next comment on whether we should do that)
no need to alias it as it does not conflict with anything
It is InstallerInterface descendants knows 'correct' disposition of package files. Downloaders just bring files here from somewhere... and their result can be altered by installers.
Yes, it will, kind of the point. It appears that looping with the while consumes the thread, which appears to be the same one that is the UI thread for the page itself (at least that's what it appeared to do to me).

Please give the test a try with and without this change.
use equal better than include `res.body.toString().should.equal('Some Error');`
If you're not modifying the parameter, no need to pass by value.
Okay got it. Done.
no longer true :)
AHUHUEAHUEAHUAEE
mto boa essa troca de "pouco" pra bocado
I think this changes are no longer required then are they ?

P.S.: It has a merge conflict now.
`mod` is a bit misleading, it seems referred to a `PageMod` instance when actually is a `Worker` instance. Could you rename it in `worker`?
this approach makes sense and is good enough for our unit tests. thanks for the comment!  Do we ever use <%- on templates that are evaluated on the frontend?  where we're outputting html?
@seanmonstar - What is the difference here? I tried to find some info online but am coming up short.
This change is so we can set the XHR result of the changePassword request without affecting the requests that occur during createController.
this should be `class_list_str.splitlines()` not `class_list_str.split('\n')`
typo: s/ar/are
`!important`, eh? Was that my fault?
Please revert these to their proper constant names (`serial.EIGHTBITS`, `serial.PARITY_EVEN`, `serial.STOPBITS_TWO`).
This wrapper looks redundant, we should merge it with `dprime_from_samp`.
agree, I thought I saw similar treatment elsewhere and kept it for consistency but cant find that now.
Remove that newline here.
Heh I just curl'ed this down from the original source dude (and changed the asset path of course).
just set the e here
Sure, but I'd say it's more unreadable.
no reason for the closure here.
awesome thanks again guys. This one I would be careful with .forEach since it'll need to work on the client-side as well, and I would make this private API (at least for now). Not a huge deal but I would maybe renamed it to `.eachTest(`
Why this large intendation?
Need update namespace
CS: Move the "else" statement up to the preceding line, with a space before and after the word.
I'd argue that the FirePhp log writer shouldn't support a formatter at all, as it simply intends to pass the message verbatim and disregards all other event data fields except priority, which is handled separately in the writer.

Much like the DB or Mongo writer, it seems there's nothing to format.
Zend\Cache should pass since a merge today ;)
Without this, the only way to set the priority of an element is when calling `$form->add($element, array('priority' => 99));`. In modules like ZfcUser, the forms have an init event which is mean to listeners to attach to and manipulate the form as-needed (thus they don't have to extend or override the form, creating a last-module-wins situation). The idea is that, without this, users listening to forms' init event would not be able to easily change the priority of an element.
`Quindi dobbiamo notificare l'applicazione dell'esistenza del nostro modulo.`
This is not very usual.
Ah, right.   MWWorld::Class::get(*iter).getName(*iter) it is, then. (iter is an iterator that points to an MWWorld::Ptr)
Why still have this if the route is in the $route array now?
Can you add a little bit of description (comments are fine) as to why the outcome of each test is as you expect?  i.e. "should fail" because authoritative and attribute not reachable, should decline because not authoritative and not reachable, etc. so there's a bit more human-readable understanding of why these cases were selected?

also, minor nit, this currently doesn't test that an authoritative, present, attribute would result in authentication success but I agree it's unlikely that it would fail where as the non-authoritative would succeed.
There is a reason: initially I wanted to remove `self.segments` as it did not make sense in `powerline/renderer.py` (it is always regenerated before using).

`self.segments=segments` was added after I saw it is used in vim renderer and realized that I don’t know a clean way to pass it to .render method in vim renderer. Changes made were kept because this way it should be slightly faster (*very* slightly) and `segments` no longer seem like something persistent (`self.segments` looks very much like something cached or even generated only once, like a *state*, but it is really not as it is generated on each `.render()` run).
This line is hacked...  notice that when name is false (as in empty string), it will do \"\":[, which originally was just [
Seems like it would be easier to just do getCurrentMice().size() or something, wouldn't it?
It would be better to just delete this code instead of commenting it out.
@matuszemi http://blog.evan.pro/a-simple-explanation-of-git-rebase
isn't it harder to do a code review with github, which doesn't seem to wrap?
`{{#if completed}}checked="checked"{{/if}}` -> `{{#if completed}}checked{{/if}}`
Consider changing the name ZipCodeField to PostalCodeField in order to be country-agnostic
Line break between assignment and function call
Instead of using the word `or` can you use a `|` character instead. I just want to keep things consistant across our docs and that's been the convention we've been using so far. See http://popcornjs.org/popcorn-docs/utility-methods/#Popcorn.forEach for an example.
To have a generic implementation, I would rather directly inject the siteaccess list in constructor/setter
@fsouza is right, this settings has no use to the end user, thus makes no difference to have `django_nose` always in `INSTALLED_APPS`
Fixed, added a decent sanity check for libxml2, and also got rid of tabs *spit*.
Note that I have no clue :-D
better to use `closest` here instead of `parents` if what you really mean is the first parent element to match this selector.
Can't you just

```python
patch_cache_control(response, **self.Meta.cache_control)
```
Yep, manually verified that this works, despite the docs asking for absolute URLs. I tried it because the example showed relative urls. Actually, specifying an absolute url to localhost caused a login error, whereas leaving these as relative urls worked fine even on localhost.
@isratrade donno, maybe git is updating this in the background...
nevermind, see #235 for a suggested cleanup
thats actually not required if you are using a subnet with dhcp proxy
When would `testMode` be false and `Exercises.completeStack.getCustomStackID` be undefined? Can you just do `!testMode && Exercises.completeStack.getCustomStackID()`?
Again, like above, you can use \<code\> tags to make this look better.
Any chance you can configure your IDE to put the "java" packages first in the imports? The preferred order would be "java", "javax", "org", and "com".
Unfortunately, [this line](https://github.com/component/component/blob/master/bin/component-build#L61) always creates the file (even if empty). We probably want to put a guard around that.
Do we need the cID parameter for the ccm_saveArrangement function? Why? Isn't it enough to use the CCM_CID global constant?
If that cID parameter is unuseful then the global variable ccm_arrangeModeMulti_cID becomes unuseful and can be removed...
Can you also add a note about the `self-update` command to easily update the fixer to the latest version?
Please validated your HTML prior to pull request
Why not putting all these tests in the old `test_certificates` module (which should be renamed to `test_wellknown`)?
Using singletons is one way to avoid re-parsing any one configuration file more than once.  It certainly would be possible to hand-code explicitly the idempotency in a module.
Fixed with 587b474.
Oh, n/m...just saw that it's not encoding data.
Can we support both? Test for presence of main app and if not present
use relative to extension. I would very much prefer that
This is incorporated in my PR.
I think I may have fixed a bug in this method (or a similar method) at some point. If the method is intended to tell you whether or not a user has access to manage something, I don't think an error should be returned if it successfully managed to determine that you do not have access to manage it. Rather, an error would determine that there was an error checking (cassandra went down, maybe some validation error), while the boolean would be the actual successful result of the test.
Probably not, but I wanted to ensure that whatever the backend returns is a filebody (ie: string) and not some Buffer/error object/ ..
If adding / removing single memberships would be a common use case, then these would be good to have as it is clearer when using the API externally. Do you think single group membership changes will be common?
I think this can be done now.
Why is this condition unnecessary now?
The base objects from httplib and urllib2 libraries are old styles and are not inherited from object. So super won't work.

I could make my own class inherit from object as well. In this specific case, by using:

class InvalidCertificateException(httplib.HTTPException, urllib2.URLError, object):

and

class CertValidatingHTTPSConnection(httplib.HTTPConnection, object):

things get more complicated, specifically in the first case, super just assumes to call the first inheritance's init, which works correctly, but makes the code harder to read. in the second case, we convert a single inheritance to multi-inheritence ... would it worth it?

Not sure if it worth the complication ... what do you think?
i don't know if this is still the case with PSR-2 .. i guess we should eventually run the CS-Fixer over our code: https://github.com/fabpot/PHP-CS-Fixer
Assuming this was supposed to be **DEFAULT 'river'** ?
Push the card dictionary to another place to make the code more readable?
Van de ImpactJS docs:

`The return value is the newly created entity.`
I see, well if it needs to support direct access to those arrays that is also 1-based then I guess there's no other simple choice. I guess one could ask whether that direct access is necessary though?
This needs to be wrapped around in braces, see some examples in here: http://codeigniter.com/user_guide/general/styleguide.html#code_indenting
ни разу в икскоде этого не делал, надо будет поразбираться
... потому что когда count станет нулем. выражение в скобках (count--) станет нулем. для while это будет ложь и цикл прервется.
Повторюсь. Если элементов в массиве 100 (как в условии), то выражение "заменить строго х процентов" эквивалентно "заменить строго х элементов". 

 mutatedIndexesCount= (dna_length / 100) * mutationPercent;
эквивалентно
mutatedIndexesCount=  mutationPercent;

Ошибка - не ошибка ваше дело :)
Это внутренний метод и в интерфейсе ему не место.
Just try it. 
In your main.m:
```
Cell * cellA=[[Cell alloc] init];
Cell * cellB=[[Cell alloc] init];
[cellB setDNA:[[NSMutableArray alloc] init]];
 ```
and try calling
 ```
[cellA hammingDistance:cellB];
 ```
In this case it will crash trying to call objectAtIndex on empty array. The same reason for any array which capacity is less than lenthOfDNA.
Исправлено в 2fe0846 коммите.
метод должен называться hammingDistance, через 'a'
it appears that a typo is added here
If the method should be used instead, should we even expose this property?
LOL - wow, this just sounds like a terrible idea - what the heck are the standards for allowing a script in? Whoa.
This was very moving.
sort_method is not used after setting it
I'm not sure if it is a good idea to have a default value for subject. Users will likely run label.smooth() without any arguments and end up with screwed up labels if the label wasn't created from fsaverage.
Well, either way its not a big deal. If its only me then i can live with it :)

Im happy if your happy.
It makes sense for small entities though. We also can return a ScrollableResults instead of a List (kind of a ResultSet).
You probably want to use the '<ext:modifyColumn>' tag
I'm suggesting not casting the byte sequence to a string.  JSON has encoding rules for strings that string casting does not handle like Unicode codepoints like \u0032.  UnmashalJSON will likely be given untrusted data, so it needs to be robust.  I'm thinking along these lines:

http://play.golang.org/p/Sp9B5zOYMz
Don't use the `::` shorthand if you don't want to put a `:` after the sentence, use the `.. code-block:: php` instead. The `::` will be replaced with `:` and the indented text after it will be seen as code.
Why should it be? It's the only element in the array.
what about `current_user_fulfills_additional_requirements?`? It sounds weird because you're specifying implementation in the method name where you really want to describe behavior. So, something along the lines of requirements or prerequisites or something would probably be good
you are starting at 3, stepping by 2, so this is an unecessary test.
`QString ` можно не писать.
Creo que tu problema de usos horarios tiene que ver con esto, estás seguro que es necesario crear un objeto Date? me parece que datepicker también funciona con strings ISO.
I see where you're coming from on the resource part, but as for knowing that it's missing, you'll know that just as well as it is now, since the file won't show up at all. I'd much prefer that to a request that returns a 404, in that case. How resource heavy is the file check anyway? That's not my strong side at all, I just code, I have no idea of what's fast and not. :P
This is a good catch, but the fix doesn't belong in this series of commits. Please split the issues of old messenger fields, respectively fixes for drafts support in postgresql, in two different PRs.
no need to change the Pods; they are 'source' dependencies .
please remove parenthesis
Another debugger statement.
You should look at Nova's flavors

but okay
Is there any reason not to use an `NSURL` here?
These bifurcations are a little concerning to me. Is it impossible that this behaviour could live in the renderer rather than having a path_effects ```_Base``` class?
Presumably so we can wipe the rest of `$(TARGET_OUT)/b2g` without losing the webapps dir. @fabricedesre any other thoughts?
Not needed to merge
With more examples of what we are trying to move towards, and what we are trying to avoid, it will be easier to put the right wording together to describe it. The description of the rules or conventions should be simple and clear enough to understand, but not to leave it open to ambiguous interpretations. So try starting from the sample code and working back.
The function is pretty straightforward.  I just added a bunch of extra explanation to the test facts, so that _everyone_ could get it.  I can document less, if that's better in the test namespaces.
Missing space after if `if(`
Please move constructors to the top
@sminnee Changing them to `getFrom()` etc would be consistent with `getDelete()`, `getLimit()` etc which I've already changed to. :-) `getFromAsString()` etc compiles the internal predicates from an array into a string, imploding it with a connective, so that should fit the bill, right?
This message is wrong. What must be set is either the hostname or the id
Changed because the user model is currently using the alpha_dash rule. I think the password rule discussion has been a long time coming, we should get the rest of the team's opinion :smile:
Just to make it easier to get everything in one swoop since order is submitted with the fields now, I added it to the update routine.
I'd have gone with something other than "NONE", maybe "IGNORE", "ROLLBACK"?
What? I don't see any reason this needs to be double quotes. The only reason I am aware of for using double quotes is to parse the string with variables or to parse a character like \n. Obviously in these cases it isn't a major issue since the strings aren't huge, but repeated use causes slight speed decreases.
That sounds a good replacement. I never thought about "corpses" in the game :)
Are you sure ``$adminGroup`` has the correct type as ``object`` is not a sub-type of ``string``?
a missing , :)
Just `(contains? a-set x)` would have sufficed.
I like the way importing a different file here changes the notify animation. Maybe add a comment above this line documenting what you mentioned in the pull request?
Hmm...I'm not sure what the user's intention would be in having an empty string directive, or in what situations that would come up, but I see what you mean, and will keep it in mind.
Isn't there a constant for that?
If you are checking a page parameter for a certain value to restrict access (e. g. `<xsl:if test="$token = 'aqwerl78afsdhhl'"></xsl:test>`), allowing people to see to those files would not be a good idea. So I'd they that they might indeed be a security risk.
Ok, my leases file was the cause, not the code. new patch incoming.
Please control it. Check diff before doing commits!
See. This is the main problem of your approach. View functions are wrapped in middleware. You don't run them here. So there is some pre and post processing possible. What if author of the view function counts on that?
Why define global variables? Will they be accessed from some other JavaScript file? If not, it is probably no need for them.
I didn't translate it, I just (don't know why) added it as a translatable.
Not valid XHTML. Please test. Use [HTML validator](http://users.skynet.be/mgueury/mozilla/).
There is probably no need to split this into multiple lines.
was there any reason openlibs was not used the the contractor?
Can this be a normal keyword argument with a default value, instead of dictionary fishing?
it seems all changes to this file could be removed from the patch
Drop the parenthesis.
for discrete models it is set in DiscreteModel initialize (which is called by __init__)

df_model is the number of parameters minus 1 (or minus number of endog levels J in MNLogit)
It assumes a constant and subtracts one for it. 
(I don't like the -1 anymore but that needs a systematic refactoring)

here you can just reset df_model in fit(), 
the inherited df_model is corrently incorrect if there are zeros.
add comment before: ``#Aggregate states into regions`` or something like this
There's not much reason to use File.join unless you're joining more than one sub-path.  Try this instead:

`data_path = File.join(File.dirname(__FILE__), "data")`
(that's sed syntax: substitute Map for HashMap)

Nima

On Fri, Feb 24, 2012 at 12:49 PM, Zhai Ke <
reply@reply.github.com
> wrote:

> > +        * (-1.0 / 12.0 + f
> > +            * (1.0 / 120.0 + f
> > +                * (-1.0 / 252.0 + f
> > +                    * (1.0 / 240.0 + f
> > +                        * (-1.0 / 132.0 + f
> > +                            * (691.0 / 32760.0 + f * (-1.0 / 12.0 + f * 3617.0
> / 8160.0)))))));
> > +    return r + Math.log(x) - 0.5 / x + t;
> > +  }
> > +
> > +  /**
> > +   * Approximate the trigamma of x.
> > +   *
> > +   * @param x
> > +   * @return
> > +   */
> > +  public static double trigamma(double x) {
>
> Hi, Jimmy,
> what do you mean by "s/HashMap/Map"? static HahsMap<Map>?
>
> Ke
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/lintool/Mr.LDA/pull/1/files#r486043
>
we should do a lot more of this :)
thanks for notice.
Yeah , it was just LD23 and MiniLD34 ( which caused I could not add it yesterday ) where I was learning using break . Thanks . Changing .
okay good to know, but let's find a better way to solve that problem, when we face that actual problem
Oops, I commented out the lines below this two months ago in https://github.com/brooklyncentral/brooklyn/commit/9a4b86a912c96d6d716064a41f4e1de4398e07b5#diff-6

That means we haven't been properly testing jboss6 and jboss7 in our integration tests.

We should re-enable those (i.e. uncomment lines 126 and 128).

Given your change is just about tomcat then it's unrelated to this particular problem. I'll uncomment those, run the integration tests, and submit another pull request.

It's messy to be modifying this code in these commits as well (makes for a strange git history), but I won't block the merge because of it...

---
That's a nice reminder of how strict we should be about commented out code in pull requests!
And that we need to look to delete unused (including commented out) code, but checking that it really isn't useful first!
In slf4j, can use: `log.debug("Running the user povided script: {}", script)`
This prevents string concatenation when logging is not set to debug.

It's not important here as it's only being called once, but again a good habbit to get into.
javadoc says "returns null if not found; throws if wrong type", so this should throw ClassCastException or something rather than doing if check and returning null.
`as they've been successfully conquering mobile users:`  plutot que `as they achieved...`
Ok. As I the problem was not introduced in that code that I did not change, but when doing the constructor refactoring. this.template used to be initialized at "" in the ctor it is not anymore. And that explains the pb. That said I find strange to do that. I would prefer to let it null and check for this value later to avoid doing unnecessary operation. I will augment this pull request with a fix in that spirit.
I haven't seen that so far for this case. I do recall the duplicate indexes errorcode seem to have letters in them..
I don't think we have a defined list of errorcodes to check for..
це теж в категорії. проект може бути прив’язаний до кількох категорій. відповідно сортування різне може бути в різних категоріях. в тебе це враховано?
These links are missing the domain and protocol - they are just paths at the moment.
Please please get the latest update from main repo. This is already there.
Add these back :)
А где название пакета?
Зачем нужен DataInputStream?
А значение может быть null.
И тут с пробелами и отступами проблема.
RaJ Branch
We should have suffix "_locator" at the end of the name. This applies to all the names below.
This is the actual binding to the select so the filteredRegions variable would contain something like:

```JavaScript
[ { id: '029', name: 'Caribbean'}, { id: '013', name: 'Central America'} ... ]
```

The filter option is stored in the selected variables below (e.g. `selectedRegion`) which support multi-selection.

The `queryFilter` variable holds all of the query filters.
Yeah. Was waiting for other possible remarks.
L

2012/11/12 benkonrath <notifications@github.com>

> In static/global/js/app/blogs.js:
>
> > @@ -8,6 +8,9 @@ App.Blog = DS.Model.extend({
> >
> >
> >  App.blogListController = App.ListController.create({
> > +    init: function(){
> > +        this._super();
> > +    },
>
> Are you going to remove this so I can merge this in?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/onepercentclub/bluebottle/pull/139/files#r2097062>.
>
>



-- 
Loek van Gent
1%WEBMASTER

*1PROCENTCLUB.NL* <http://1procentclub.nl>

*1%Facebook <http://www.facebook.com/onepercentclub> +
1%Twitter<http://twitter.com/1procentclub>
 + 1%LinkedIn<http://www.linkedin.com/groups?home=&gid=1071287&trk=anet_ug_hm>
+ 1%Hyves <http://eenprocentclub.hyves.nl/>*

* *

's Gravenhekje 1a

1011 TG Amsterdam****
T -  (+31)20-7158980
E - loek@1procentclub.nl
args[0] == 'help'

Don't use instance variables when there is an accessor
With a mock parser we could force the `hashChild()` method to return true etc etc
At the moment the parser just throws an error or returns undefined
To create this file I first had to do:

```
python profile create default
```
Really? I've never noticed that, and I'm almost sure I have seen some old generated C that was doing indexing properly on such local variables.

It's definitely the case if you do "cdef np.ndarray foo" that you get Python overhead, but I think if a C type and ndim are there you're alright.
I would use `for t in xrange(self.max_iter)`.
Is `pyamg` automatically used or is there a constructor argument to switch explicitly to that implementation? I would prefer the latter.
Sync shouldn't be loaded here. It already a part of the modelbase.
Needs a default to make it clear what happens if this param is omitted
I didn't change this...
Instead of poking loc, try:

    e->error("Cannot modify '%s'", toChars());
keep ordered
Don't we need usage string here to provide more descriptive message rather than "devicemanagement.py [options]"
We tested it and indeed the activity indicator needs to be added to a window on BB before it can be shown.
I see now you thought of this already....
Is this a Python 2.6 compatibility change?
This is not as good as it was before, but unlikely to be a problem (since it was just for reporting the error).

I'll add this later...
There should be no ${DIR_NAME}:
```cmake
install ( FILES ${CMAKE_CURRENT_SOURCE_DIR}/lib_saltlib.eclmod DESTINATION plugins COMPONENT Runtime)
```
Note: "COMPONENT Runtime" is not used currently and would need to be fully revisited for all install items if we ever did want to do component installs (so you can leave it in or out, no difference).
@rhelmer might need to change the test I had not as Not 'Page not Found' vs. 'Page Not Found'
There are some code in HqlFunctions.cs in the test suite regarding dialects that don't support certain standard functions that should be tweaked for this.
Per the Author class, import these if used, and refer to them based on the import (classname or alias).
now that the HTTP request is done using Buzz, you should improve the testing by using the real class tested here instead of testing a mock. The mock should be used only for the Buzz dependency injected in it
出色的编译器可以将一个尾调用编译成一个 *goto* ，因此可以将一个尾递归函数编译成一个 *loop* 。

1. 把“可以” 翻译成“能够” 是否更贴切？
2. 仔细思考了下，觉得这里的 loop 其实应该是个概念，而不是CL中的 loop 宏。 所以把它 *loop* 可能会引起误解。
Something wrong here????
I don't think this works - have you tested locally?  We'd have to populate the position field for every Resource Guide and then make sure that the position is lowest for the guides we want to show.  Then we'd have to change the way the controller selects the guides.

What we do now is grab a randomized slice of 4 employer guides.  I think the easiest solution is to create a yml file of employer and student guides we want to always show, and the fill out the rest with randomly selected guides.  I'll take this on since I've worked with the code a bunch.
Not used.
Can be deleted ?
I'm glad I brought this up because these are really excellent points. I think my initial reaction to passing the params into `Discussion.search` was that I had no idea what `Discussion.search` used in the params hash by looking at it in the controller. It looks like a big black box that eats the `params` hash and spits out discussions, but it isn't easy to see which keys it consumes.

I do agree with you now that a hash is the signature for this method. But I would feel better, if that is a valid argument, if we did:

```ruby
Discussion.search(params.slice(:category, :state))
```

This way it's very clear which values we are sending to that method. What do you think? I don't want to go too crazy with this because it's not something I feel strongly about, but that small change would ease my initial concerns.
This line, and most of the imports above can be replaced with

```python
from skimage import data
lena = data.lena()
```
This pattern is used a few times(line #112), we could probably pull it out into a method to make it easier to understand.
We try to avoid using return-guards like this. Could you change this to something like:

```ruby
if @instance_type
  if model_class. ...etc...
    # etc
  end
else
  true
end
```
Why is this a separate function?  Why not do everything in `update`?
Should this take `left`, `right`, etc. as arguments or perhaps an object literal so the caller has a clue what the values mean.
Are you sure you want this?

[EXT_texture_filter_anisotropic](http://www.opengl.org/registry/specs/EXT/texture_filter_anisotropic.txt)
Be careful about spaces/tabs in makefiles. Some versions of make differentiate between spaces and tabs, so I wouldn't blindly apply D coding conventions to makefiles. (I ran into this issue by accident once, nearly pulled all my hair out until I examined a working makefile and found that it had tabs where I had spaces. Not Fun(tm).)
should u use a as instead of hard cast ?
Why the empty line ?
s/RepsonseHeader/ResponseHeader
s/properites/properties
Hi Bill--actually, no... I meant 

if deprecated.has_key("removed"):

"Removed in <release>."

else:

"Deprecated since <release>."

I just didn't like "Removed since <release>". Sounds funny to my ear.
I think this reads better as:

_If the Sleep/Wake button is pressed when  the app is in the foreground,_ the following events _take_ place:
Why the check for window here?  If the event is being fired on the stack entry then is this still needed?
Isn't this comment block describing the whole file, which is already described in the main block?
This is what I said from the beginning :-)
Yeah, this sounds like the classical problem of cpu vs memory.  Since the 5MB constraint is so drastic (compared to our very fast cpu's) I think we should stick with this try catch.
This type of filtering could be avoided with having each spec create its own data.
Good eye.  I'll have to be more careful with my comments going forward :)
I'd say make this extend LinkedHashMap, to preserve the order of elements. (The whole messaging framework is expensive enough that this should be trivial to add.)
you're wrong, but as long as its normalized some way I don't really care.
This is the only method you added with parens around the arguments. This should be normalized... preferably with parens everywhere IMO
ups! ya lo acomodo
We need to maintain backwards compatability with 1_5, thus 1.7 can't be the default
Add more info on the usage. For example how to render a form with all permissions? How to check permissions in controllers?
no need for `UL`
I think the copy should use `auto ref` for target.
Are `isinf` and `isnan` slow enough (and is the compiler untrusty enough) to deserve explicit folding?
> I agree we need to worry about breaking existing code that uses `move`.

No, I'm not telling about it. I'm telling that there is a function in *phobos* that doing useful job *X* and you can't just get and remove the function from the library telling: I don't like *X*.
Change the position of equal sign
more nits: prefer ' over " and use them consistently in this file.

Above, I'd suggest using ''' instead of """ (since there are nested " inside) or switch the inner " for '.
I didn't do this because there is a bug that doesn't let you do instance of checks with typedef in dart2js.
This should also be noted in the README for now.
I'm struggling to parse this sentence. Do you mean

"if the client connects to a cluster of servers, then a cluster element must be defined"?
pls remove unneeded empty lines in this class
Right now we are working towards the simplest case.  @seth and I discussed the approach you mention and decided it is still easy to add their fork as an additional remote.
Why `setString` and not `setChar`? Are you expecting non-ascii characters?
Intended. There should be even more warnings. I once fixed all non-Wall warnings. The -Wall warnings are on my TODO in Trello.
Should that value be in resources or defined and const?
me neither. let's pull whoever did it to ask
This method could be:
```
def assessment_form data, options = { submitted?: false }
  form_presenter = options[:submitted?] ? SubmittedAssessmentFormPresenter : AssessmentFormPresenter
  render partial: 'woople-theme/assessment_form', object: ThemePresentation.wrap(data, form_presenter)
end
```

It will consequently DRY up a lot of implementations downstream, and keep the interface backwards compatible (which means you won't have to update the unsubmitted form implementation in Woople) while progressively enhanced.
Gotcha :thumbsup:
Unfortunately, our website doesn't have a consistent notion of resource types. Every program has different resources. If you look at Splash 2012 vs. Splash 2011 vs. HSSP vs. Stanford Splash vs. Chicago Splash etc., you'll see that they all use different resources. So this hard-coded list will only function properly for a very specific set of programs, that set up their resources exactly the way that you have assumed that they will.

I don't think we should merge this code unless errors are handled gracefully (i.e., if your resources don't match this list, the scheduler won't look messed up, and will have the same display and functionality as it normally does). And we should eventually look for a better solution to this problem (which I plan to do within the next few months anyway).
Mailman is optimized for bulk-insert/update; it would be much faster to add students that way as well.

I propose that we implement a new function ClassSection.preregiser_students() (intentionally plural) that takes a list/iterable of the set of registrations that you want to make be entered.  It can wrap all the relevant iteration/Mailman/etc logic; and do so in a way that minimizes the number of DB hits.  Then ClassSection.preregister_student() becomes a trivial wrapper around .preregister_students().
Members sind nun eingefügt, inkl. der zugehörigen getMembers Funktion
Это дублирование надо бы как-то устранить. Почему бы часть этих проверок не перенести в метод move_possible?
Чтобы не создавались. Скотт Майерс открой, пес.
not sure why the prepare needs to be send in total order?
Wy do we need to change this? Shouldn't be body still be the one with the `i18nable` class?
Parts of this are duplicate code from newaddcontent -- can we centralize that code to increase maintainability?
These lines are extra long -- can we adhere to our 80-char limit here?
Why not put in `using (WebResponse response = request.GetResponse())` inside GetResponseMessage?
When the...
s/$1/$i
these options need to be documented
@GregSutcliffe and I just spoke about this on IRC and I think we would both prefer to leave the defaults the way they are because it's unclear what the side effects of this change are. @ekohl, I'm not sure I understand the reasoning for the change. Can you explain it further?
BadRequestException にはメッセージを持たせて、ログを出力するようにしてもらえますでしょうか。
BadQueryParameterException のところが参考になるかと思います。
allow_linker
as i said before this is not guaranteed to work
This is meant to test a module on its own, not in the context of a ZF2 application.
From kml reference

Color and opacity (alpha) values are expressed in hexadecimal notation. The range of values for any one color is 0 to 255 (00 to ff). For alpha, 00 is fully transparent and ff is fully opaque. The order of expression is aabbggrr, where aa=alpha (00 to ff); bb=blue (00 to ff); gg=green (00 to ff); rr=red (00 to ff). For example, if you want to apply a blue color with 50 percent opacity to an overlay, you would specify the following: <color>7fff0000</color>, where alpha=0x7f, blue=0xff, green=0x00, and red=0x00
This conditional branch looks identical to me?
do we need to hard code the version here?
remove unused properties and methods
Huh? If you have to special case this, something else is wrong with how you've threaded the callbacks.
> Let me summarize to see if I understand:
> 
> The interceptor can on each call use the metadata api to determine whether interception is needed
> The interceptor is free if not even encouraged to cache this information
> If interception is necessary the according validation methods are called
> If an error occurs a ConstraintViolationException is thrown
> The alternative is:
> 
> Interceptor calls the validate method for each method (obviously worse performance)
> So really it is up to the interceptor to make this efficient by caching the information on whether validation is needed!?

Yes the spec never mandate optimizations. It has been designed so that optimizations can be done though.
I expect interception to not even happen if the method is not constrained or if the method validation has been disabled.
I was wondering about 'level'. I know we have called it method-level constraints for some time, but is it really necessary? Wouldn't method constraint be enough. In fact you are using the term _method constraint_ as well.
Yes, "when a new module is compiled".

And I went with:

> Therefore, the code could be modified to store a mapping from each child process to the module it is waiting for so that when a new module is compiled, only the children that depend on it are notified.

The only change is that a child process can only depend on a single module per time, so there is no need to map each child process to a list of modules.
Should these be defined in an enum in android_modem.h? (I guess we don't expect to emulate any of the other fail causes in the future?)
avoidMouseEnter is set to true by prev() and next(). It can be reset to false also by moving the mouse after prev() or next()
I've settled on the following language to explain requests, feedback appreciated:

**Ensure the current thread or greenlet always uses the same socket until it calls end_request(). This ensures consistent reads, even if you read after an unsafe write.**
I is correct judgement? I.e that if it contains a DatasetDefinition with this key  or i should also check its type
In Jolla coding conventions braces are expected for one line blocks as well, which I personally find better as well for various reasons.
`teh` -> `the`
Could you make this argument optional ?
Oh yes, sorry, this should default to true, as that's the previous behavior.
I think we can drop sortIndex and collection from this logging.
What happens if the param value is false.
We use it for testing.
Maybe the comment can be improved a bit as well.
Can probably mock the function calls that actually do the copy, so we dont actually have to make new files
CS require a blank line before return http://cs.sensiolabs.org
determine platform and form factor, and render appropriate components

or

render appropriate components based on the platform and form factor