labofsahil/github-event-dataset-2012 huggingface dataset:
The synchronization should concern the hashset and the queue at same time, so a syncronized block ?

I writed that :
private void addToRenderQueue(SpoutChunkSnapshotModel model){
		synchronized (renderChunkQueue) {
			SpoutChunkSnapshotModel previous = renderChunkQueued.get(model.getX(), model.getY(), model.getZ());

			if(previous != null){
				if(previous.getTime() < model.getTime()){
					renderChunkQueued.put(model.getX(), model.getY(), model.getZ(), model);
					renderChunkQueue.remove(previous);
					renderChunkQueue.add(model);
				}
			}else{
				renderChunkQueued.put(model.getX(), model.getY(), model.getZ(), model);
				renderChunkQueue.add(model);
			}
		}
	}
	
	private SpoutChunkSnapshotModel removeFromRenderQueue(){
		synchronized (renderChunkQueue) {
			SpoutChunkSnapshotModel model = renderChunkQueue.pollFirst();
			if(model == null) return null;
			renderChunkQueued.remove(model.getX(), model.getY(), model.getZ());
			return model;
		}
	}
I don't _keyMap can be null anymore.  Other code below assumes it's non-null also.
Might be nice to have a setMinSize API so panels can have something different from the default.
Should probably make testcase name slightly different from the one above it.
We should add a comment here that every suite in this list must have ```this.performance = true;``` in order to get filtered correctly.
Sounds good. I'll go ahead and merge.
Pull request to remove the windows help menu adobe/brackets-shell/90
The existing code already kind of had this problem, but I think it's a little worse now: there are a few different functions with very similar names that are a little hard to tell apart from each other: `_readFileAndGetFunctionList()`, `_getOrReadFunctionList()`, and `_getFunctionListForFile()`. I don't have a great suggestion for renaming them, though.

Maybe another way to factor it would be to change `_getOrReadFunctionList()` to something like `_shouldGetFromCache()`, and change `_getAllFunctions()` accordingly:

```javascript
function _getAllFunctions( ... ) {
    ...
    return Async.doInParallel(fileInfos, function (fileInfo) {
        var result = new $.Deferred();
        _shouldGetFromCache(fileInfo)
            .done(function (useCache) {
                var docInfo;
                if (useCache) {
                    docInfo = {doc: undefined, fileInfo: fileInfo, functions: fileInfo.JSUtils.functions};
                } else {
                    _readFileAndGetFunctionList(fileInfo) ...
                }
...
```

(You'd have to rejigger `_readFileAndGetFunctionList()` to just return a new Deferred instead of taking one as an argument.) I think this would be a little clearer and eliminate the need for the extra function.
I'll add a link to EditorUtils.getModeFromFileExtension(), which is essentially how we currently document the Editor constructor's ```mode`` argument too.
This method was never intended to be public. Why do you want it to be?
A lot of how you handle responses from the API seems to be very similar between types of calls. I'd recommend finding a way to refactor this.
Please no println :-)
this might be cleaner

```javascript
/translate|rotate|scale/.test(TString)
  ? return toRTransformString(TString)
  : return rParseTransformString(TString);       
```
Comment here is still missing?
This is really old, please go back to what we do on master for dealing with existing query string params in the embedSrc
I think you eviscerated the change detection mechanism here such that `changed` is pointless.
Needs other prefixes for -ms and -o
Passing client here is not so nice. Such circular dependencies should be avoided.
No need to use a global variable here. The mustache class has direct access to the ruhoh database, so we can do something like:

```ruby
def posts_count
  self.context['db']['posts']['dictionary'].length
end
```
uuuuuh... a) should use {}, b) you don't need to toString() when string concatenating... its redundant.
This function is not declared and used.
Tämä taitaa olla turha.
Have you tried pulling in the same version of finagle that we use for the rest of the project? Too different?
I was looking more from the search engine's point of view, the problem of duplicated content. But it looks like Google is prefering the long URL for videos.
This bracing is inconsistent with the rest of the file.
Is this TODO still outstanding?  Any issues with tackling it now?
Enquoted
Add unit tests for this type.
Ah, I wasn't aware of PEP 257. I've changed the docstring quotes back to triple double quotes :-)
The included controller file isn't necessary at all. Nor is the additional model class.  You should add a unit test case to the existing model validation test suite.  [Here example of a method similar to what you would want](https://github.com/cakephp/cakephp/blob/master/lib/Cake/Test/Case/Model/ModelValidationTest.php#L174-190).
Indentation is off here, Cake uses hard tabs.
Sure. Will do so when I get back.

Do you have suggestion about windows issue or portability?
Private functions should have leading `_`
this check should actually be under bin/genejs.

it should also be in geneJS.cli.process, too, since we're not obliged to execute cli from bin/genejs (but this is not necessary for now).
Fair enough, but we still need handle the possibility of `None`.
Eh. I think it's fine. It encompasses what's different about the two fairly obviously.
sure, logging would be good to have, but in a case like this, we will have to inform the end-user anyways, since they need to know that their input could not be saved. So we need a way to let the error bubble back to the user. If the store method is triggered programmatically, I think an exception would be the way to go, since then the calling code can decide what to do. If store is triggered via the REST handler, it could also catch the exception and send its message to the browser. This of course needs support from Create.js. I talked about this issue with @bergie at some point, but I'm not sure if there is a way to pass error messages back to Create.js yet.

But like i said, IMO this should ideally already be caught by validation (i.e. a unique constraint on the relevant field), and the exception should just be the fallback.
Ah, I see. I was misreading the args to `partition-all`.
Yeah I tend to agree.
Don't forget to forward this change to upstream: https://github.com/dottedmag/path.py
*Symfony :)
Why is this so separated from the rest of the SSL config? Also: why os GnuTLS the first option? AFAIK OpenSSL should be more widely available.
looks like raising `Exception` is consistent with the rest of the file, so no need to change I guess.
Moved the "roll over the markers below for feature info" box into the figure, to make sure that wrapping of text "Tour the User Interface" (in case of a locale different than english) does not affect the positioning of the box in an adverse manner.

Also, changed the <p> to <span> in order to place it in-line  (without adding a new line) inside the figure.
Does the channel view need to handle the newsletter submission?
L10n: `{{ _(product.title, 'DB: products.Product.title') }}`
I kind of like yours better.
You missed this one :-)
actually there are a few of these here :-)
If this works equally well, you could cache the db results, too. The db will always have more recent data than ES does.

In fact, if this works fine, then maybe we should always use the db for this call and not use ES. The ES faceting is good for when you've got a query and you want to see facet_counts for the result set from that query. We're not using it that way here, so we're not doing anything we can't do in the db just as easily.
Thank You for the answer!
But it's still not clear for me: 
so 
> `testScreenshotSaveCorruption()` should check that `check_screenshot()` correctly handles an exception, which could be thrown by `NetUtil.asyncFetch()`

?

I propose to rollback [fa4456bef6][1] and improve it: it would be more readable.
Catching malformed uri before asyncFetch would be nice.
Even it more be more nicer, if `utils.js:saveScreenshot()` would error out with `NS_ERROR_ILLEGAL_VALUE` or `NS_ERROR_INVALID_ARG` (or something) if `aDataURL` isn't a `data:` URI.
With other words:
when `dataURI.schemeIs("data")` is false - where `dataURI = NetUtil.newURI(aDataURL, "UTF8", null)`.


[1]: https://github.com/mozilla/mozmill/commit/fa4456bef6 "use "aDataURL" directly in NetUtil.asyncFetch()"
I thought we had consensus to stick to lower-cased with underscore names. E.g. "database_name" and "load_db.py"

Or is that just what lars, adrian and I just happen to have in common. If so, sorry for bringing it up.
Is it even possible that ``$product`` is undefined here, as it is a parameter of the function?
This should line up with `'ecosystem...`. Otherwise, it looks like `page` is an HTML attribute on your `<a>` and not a keyword argument.
Ahh you are absolutely right! I will make that correction now :D
Ahh its below, ok.
should be "geüpload", same on line 191
It's fixed, i'm sorry
This still depend on TwigBundle for the template
Disposition is one thing but the important point for me is the filename. Why wouldn't you want the header in your application?
Well the ColumMap class from Propel except a TableMap object, and looking at the code in Bridge/Propel1/Tests/Fixtures/ItemQuery.php, I saw that this object was implementing some function from TableMap (getPrimaryKeys) instead of using Problem TableMap class. I taught I would need to create the ColumnMap instead of using the Propel one. Trying to use the Propel class return an error saying that a TableMap was expected, but ItemQuery was given.

I simply saw that it seem that no Propel classes were used in these files, so there must have been a good reason. I continued this trend.
Overall, I don't understand why you're operating these style changes.
kill this, superclass can handle it.
Probably can drop "Notice" from the name. `Email` covers it.
Rename to `pending_reminders`? Definitely pluralize in any case, since it's a collection.
Might be nice to leave this assigned to null, even though it gets done in clearAll its more explicit.
Why have the `expected_path` and `result_path` methods return the paths without the extension, only to add them on straight after?
cimgtransform perhaps? cimgt is a little cryptic.
Ah I see whats going on now...carry on :).
This channel should be buffered, so the instance monitor doesn't have to wait for the listener to read from the channel before continuing.

Actually, this opens up a vulnerability (not a security vulnerability, but a deadlock vulnerability). If the person listening to instance notifications stops listening without informing the monitor, a deadlock will occur once the buffer on that channel is filled.

My recommendation would be to have a channel with a decent-sized buffer (perhaps 10), and a select{} with a default case to send on that channel. The default case will be empty, and the normal case will be the send you're already doing. That way if the buffer gets full and the listener is behaving poorly, future notifications will just be dropped.

The down side is that if the listener is just blocked on something that takes a few seconds, and during those few seconds a large number of instances are discovered, then the listener will not be notified about all of them.

Idea: in the default case, spawn a new goroutine whose job it is to send to the channel. When this happens, the number of goroutines goes up, and notification order gets lost, but notification order isn't important in the first place, and the #goroutines only goes up in pathalogical situations.
Heu... Ca serait bien de décommenter...
The software overhead is a constant - not related to the number of hashes AT ALL
I used a line of best fit using least squares to estimate it (very simple but clearly worked)
Feel free to do something more complex, but a simple a = b * c isn't gonna get you the right answer
please make this "boolean".
It's probably not necessary to save these as ivars since we're just using them to format the message.
well, t has no reason to contain ``/js/libs``
There might be external subsystems which might be doing things like:

         serviceBuilder.addDependency(SecurityRealmService.BASE_SERVICE_NAME.append("foo-security-realm", "ssl"), SSLIdentityService.class, new InjectedValue<SSLIdentityService>());
 
Basically, the "type" of the Service has now changes to SSLIdentity instead of SSLIdentityService
Thanks, Darran. I knew we were using ~ 5 secs elsewhere; this question was somewhat a proxy for asking about that. I hadn't heard complaints, but I don't hear as much input like that as I should these days. :-(

Anyway, as you pointed out, this is actually about opening the channel, and yeah, > 5 secs for that is definitely a sign of bigger issues.
usernames *can* now be numeric so we might need to re-revisit this
Sorry, I misunderstood. 

Seems a nice idea. I will wait for @scottgonzalez response.
This looks like it should get addressed in menu itself. What issue is this working around, is there a ticket? Ping @kborchers, too.
Remove this `try ... catch`. What you are trying to catch?
please add `others` to l10n properties file.
nit: extra line break
As this file is a port from Java, try using <tt>===</tt> instead of just <tt>==</tt> to avoid type coercion and non-welcome side effects. ;)
Ok, yeah. I wasn't sure about that. The less, the better.
Doesn’t hurt, but note that durations are not locale-dependent anyway.
Hi Evelyn,

This part has been refined in #6905.
So you could remove this and reply on #6905 to do the "disabled" style

Thanks.
totally agree. again, c&p without thinking :(
If you set `#modal-dialog-prompt-message { display: block }` then you don't need the `<br />` below.
the comment has not been addressed
I removed all the "background" permissions in the manifests since only "backgroundservice" was defined in PermissionsInstaller.jsm
So this is unlikely to work.
I would like to keep app storage part separated since it is kind-of independent module.
I will try to merge media_storage part into storage.js. 

Thanks.
ditto, does this belong in `bin/` ?
Thought elasticutils had something like this already. Or you're using raw pyes? E.g. I thought it had a `.result_dict` or something.
This won't handle the case where only \r is used, but that might be ok as it's rare today (old MacOS used to do that).
I get that, I was referring to the msbuild property "KuduReferenceAssemblyDirectory"
BC guardian
Any reason you're not calling `attr_array_to_hash` in the top map?
Actually, I missed the require above, never mind.
Cool. Sounds good.
Bon après ça se fait pas de deep-linker une image comme ça, faudra choisir un background qui te plaît (et légal) et le copier en local dans ton app…
I was just following suit on the var dec here: https://github.com/bengourley/jade/blob/52d93e69edc639024d208ceef026672db21cec84/lib/compiler.js#L528

Won't nested eaches be in a new scope (caused by https://github.com/bengourley/jade/blob/52d93e69edc639024d208ceef026672db21cec84/lib/compiler.js#L520)?

Might be wrong. You've obviously spent more time in there than me :)
Great. Update the comment.
I'm curious, why is this checkbox being tested differently than the checkbox in the general settings tab (i.e. the autohide checkbox)?

It seems like here you're testing the variable associated with the checkbox (and the `audiomixer` variable), whereas for the autohide checkbox you're also testing the GUI.
This should be just removed =)
It looks like the corresponding statement for y is missing
buildbot also has this as `buildbot.util.naturalSort` that could be used if buildbot is installed (but we probably don't want to depend on it here.
I didn't know that. Will think of something. Probably we'll switch to expect.js.
What situation will this method return false?
Oh, okay. I get it - thanks!
That's useful indeed, but then print also the path to the executable. For instance one can have more than one `java` command.
These don't go here. They should be in a `before` block, or better yet make them `let`s.

This is why the spec/requests/api/users spec is failing.
there is `for_diff_line?` for that
note.noteable_type.blank?
Ok Thanks for the clarification.
这里可以省去一次对 datetime.datetime.utcnow() 的调用。
Please mention what the default is. And maybe also mention that weak reference may be garbage collected by the time event will be fired if no other references are kept.
> You should rename this to requirerPath (for ex.) as it collide with module path defined on line 67.

`let` is block scoped line 67 is in `if` block. But sure I can rename.
extraHarnessOptions is given by the user while harnessOptions is fully computed by python code.
I'd prefer keeping it as-is in order to avoid combining them in python side.
It is something we will easily cleanup when we will build a cleaner manifest from js side.
These no longer need to be reset since they are now instance variables.
yeah man.  goofy.  every time you add a resource to static resources, you gotta increment this number...  these tests could be made more awesome.  meh.
Other than PSON being more liberal about UTF-8 data (eg: it allows things that are not), there is no difference.
This feels like a step in the right direction.
`rgba(0,0,0,.1)`—no extra spaces, no extra 0 before decimals.
Seemed like the most fool proof way was to just add another "function" for first-childs that gives them the proper margin-left.
ok, since we're suddenly seeing action on Bug 720738, I'll concede this point for now.
Merge conflict blocks
An exception could be thrown, yes. And no, a constructor does not return something.
return 'string'; does not return the string, instead the object defined by classname will be returned.
@Maks3w I agree. [I did well](https://github.com/zendframework/zf2/blob/master/library/Zend/Log/Logger.php#L277).
Remove space before is_string and after dbconnection.
Should be <proposal href="proposals/EXT_color_buffer_half_float">
some of the code is copy&paste from older version, and a lot of them I haven't had time to clean up yet
Spacing.

See the App Spec.
I agree with Brad; either the *complete* experience, or an unadorned page-refreshing experience. I think a partially-working automatic filter would be confusing.

On 9 Aug 2012, at 17:02, Bradley Wright <notifications@github.com> wrote:

> In app/assets/javascripts/application/document_filter.js:
> 
> > @@ -108,6 +108,9 @@
> >      }
> >  
> >      var _enableDocumentFilter = function() {
> > +      if (!History.enabled) {
> > +        return false;
> > +      }
> I think auto-submitting to cause a full page refresh would be a pretty bad experience, so I'd probably prefer they had to trigger the submit manually.
> —
> Reply to this email directly or view it on GitHub.
> 
>
The reason this stores a number instead of a Boolean is that it is later used to null out the old duplicate value. Setting it to true, it wouldn't know the offset of the old value to null out.
This would be a BC break for people extending the persisters as they are protected properties
Since we can control the order, `[:line, :file, :description]` seems to be the best.
I wonder if such information is really necessary, since it can be obtained by loading the content for the location in the slot. I'd rather not go the way and let more and more information sneak into the slots.
Are we not using the @ in front of TODO comments, to follow phpdoc conventions?
There should be spaces around = afaik
Nit: check out our ordering rules for `import` statements: http://mozweb.readthedocs.org/en/latest/coding.html#import-statements
To be consistent with other jobs, this should be `Execute add-ons tests for ESR10 candidate builds.` This applies to all jobs.
Like I said in the ticket, you can do this with ok( false, "we failed" );
this method should be a property
Should this be "First 50 iterations..." to match the number of days?
I believe they were initializing the connection twice because first time was using the account supplied in LDAP settings and second time was with the results of the ldap search. I'll give yours a try on Tuesday and let you know if I see anything. Thanks!
why false instead of nil?
This shows the problem even without localrc:

    :edit `="$HOME/.vimrc"`
    " (opens .vimrc)
    :set wildignore=*.vimrc
    :edit `="$HOME/.vimrc"`
    " E480: No match: `=/home/user/.vimrc`
This needs to change to the new Portable git ZIP, but let me take care of it after I merge.
Don't belong in common.simba.  common.simba is for functions common to the random solvers, and neither of these are used in the solvers.  Is SRL_GetBlackBackground an old function?  If not, it needs to be renamed to something that tells what it is (in this case, the black of the minimap).  Don't really know what file they should be in, color.simba, maybe?
What are the `@`s for? And also, why do you use braces in the `if`-clause, but not in `else`?
I would agree - why not just check for :interstitial ?
При turns[x][y].empty? тесты не прошли.
POD is out of date: rename function to parseSBML, returns a list of objects, etc.
Also include expected usage for factory constructor (new).
Is the intention here to remove the last semicolon? Pretty sure there is a better way to achieve this without reversing it twice.
I couldn't get it working either. However, since I could use curl I didn't spend too much time on it. I can revisit it again to see if I can get it to work.
Removes of queued actions of the queue or Removes all queued actions of the queue..
oh and to be clear, I was not trying to change gem name (this was badly reflected by erroneous change to README). I juste wanted to change the default require.

`gem 'ember-rails'`

`require 'ember_rails'`
This is not correct. PSR-0 does not support HTMLPurifier as a loadable class. You'd need HtmlPurifier_Core or something like that with some BC for (empty class) HTMLPurifier extends HtmlPurifier_Core. I would then add a single file classmap to handle the legacy condition.
"classmap": ["library/HTMLPurifier.php"]
@clemherreman The issue is I create a class mock named `foo` in a `PlatformTest`. The method pointed by @gnugat registers an invalid class name which is called `foo` too Theoretically, the class `foo` shound not exist but due to the previous mocking, the class foo exists & is autoloadable...

The worst is the test passes. The PHPUnit mock builder throws an exception & the test case should throw an exception too...

Conclusion, if you use a mock with a specific class name, you can not reuse the same name elsewhere in your tests.
Yes we probably do, what else do we need? Django includes the hashers below this line: https://github.com/django/django/blob/master/django/contrib/auth/hashers.py#L187
Why send strings? A single byte would be far simpler.
<code>wait_for_results_refresh</code> is in search.py  and is search specific and <code>click_x_page</code> is in the paginator region which is used by other pages too.
In other words, to make it possible to check that the correct X things are done without actually doing them for real, since that requires opening windows and whatnot which in turn may depend on the current execution environment, which is not feasible when running unit tests.
i'd like to figure out what is wrong here, because using PKGCONFIG like this isn't the most ideal of situations if (like me) you don't do system installations of Qt, you'll need to remember to set PKG_CONFIG_PATH.

this will also be a problem for user applications, so it's not really nice to keep working around it, as then we expect application developers to do the same - and that's another piece of pain for them..

can you pastebin build output using QT += sql and the pkgconfig approach seperately? my guess would be a possible bug in Mer's qt packaging
Several conversations with @grimradical .  We decided to play it safe and not get too fancy for this release.
I like this better when it was just readme
imho this file should be in `core/vendor/assets/javascripts/nestedsortables.js`

Is that possible? (It's not really your problem)
I think the error check should go one higher?
It sure was
Even though it'll give exactly the same result, this is probably better as an INSERT. It's more explicitly saying that we expect something to be inserted here.
This test I will move to the principals module as part of authz. It can probably be a group membership benchmark. The Authz performance tests will be different, in that it will not create user and group profiles as part of its benchmark, because it will no longer need to.
Docs on here are not right
I don't understand the comment. How the 1s timeout helps? If the ``eventSet`` is ``null`` it will just keep looping until ``running := false``, which only happens if ``dispose()`` gets called. Basically, I don't see how ``eventQueue.remove(1000)`` is any better than ``eventQueue.remove()``.

One more thing, I believe you should catch ``InterruptedException`` and call ``dispose()`` (just like you do for ``VMDisconnectedException``)
It is unlikely to ever be a problem, but it would make more sense to me to finish processing the event (`eventSet.resume()`) before releasing the actor (`! FutureComputed`)
Curly brace needs to be on next line.
А он ничем особенным не будет отличаться от обычного init. Я приведу пример того, как это можно сделать, имея только одну переменную (NSMutableArray *DNA), ибо не знаю, зачем в нашем классе ещё нужны переменные.

```
-(id)initWithCell:(Cell *)cell {
    self = [super init];
    if (self) {
        DNA = [[cell getDna] copy]; //настоятельно рекомендую вам пересмотреть геттер, я уже комментировал, почему
    }
    return self;
}
```

Не вижу ничего архисложного.
Нечитабельно, но оригинально! Тут как бы и минус за нечитабельность, но зато как всё просто и элегантно, без дополнительных циклов и проверок.
Тогда задайте константу, например, с помощью #define, и используйте её.
Использование своей переменной такого плана допустимо, если вы создадите свой конструктор, что-то вроде `initCellWithCapacity:(int)capacity;` Раз такого конструктора нет, то и переменная не нужна.
Каким образом это надо учесть? Ввести проверку на диапазон вводимых чисел (0<=x<=100)?
Никаких проблем с категорией не будет. @property создаст геттер и сеттер, что никак не повлияет на обращение к переменным в определении класса.
<% if tag_form.object.try(:persisted?) %>
куку ) что за отступ
опять закомментил :)
To match the mac side, change this to ``BRACKETS_SRC`` and point to the root of the brackets repo.
We will revert this file
space after `$currFieldName`
I made [this](https://github.com/Thynix/fred-staging/commit/a76e79fa060a9e69a7fd6623d2391d489eed375a) but I'm not so sure it's worthwhile. Do you think it's worth the extra method calls for better readability?
Can you please use dot syntax for `RACTupleNil.tupleNil`?
Why does this need to be writable outside of `RACCommand`?
The point here is to return a __new__ Money object, not change the object in place. There's a very good reason to make the Money objects immutable and always return new ones. See http://money.readthedocs.org/en/latest/Immutability.html and http://martinfowler.com/bliki/ValueObject.html.

Closing.
@cspurk Sorry for that, it will be corrected in the next version.
Isn't it better to reference the instance variable directly and call release? this way you avoid the risk of that getter being a lazy loader and loading it for nothing. Also, since it's the dealloc method you don't really need the variable to be set to nil after releasing it...
It could only crash is if someone would pass a non-callable non-string.
The idea is that the get returns the string label instead of a callable if
the string label doesn't exist (which I tested before).
Or what do you see I don't see?

2012/10/29 Alexandre Gramfort <notifications@github.com>

> In mne/artifacts/ica.py:
>
> > +def find_ecg_events_ica(raw, ecg_source, start=None, stop=None,
> > +                        sort_func=stats.skew, event_id=999, tstart=0.0,
> > +                        l_freq=5, h_freq=35, qrs_threshold=0.6):
> > +    """Find ECG peaks from one selected ICA source
> > +
> > +    Parameters
> > +    ----------
> > +    event_id : int
> > +        The index to assign to found events
> > +    raw : instance of Raw
> > +        Raw object to draw sources from.
> > +    start : int
> > +        First sample to include (first is 0). If omitted, defaults to the
> > +        first sample in data.
> > +    stop : int
> > +        First sample to not include.
>
> untested and buggy :)
>
> ValueError('%s is not a valid score_func.' % score_func)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/165/files#r1965928>.
>
>
On 12.12.2012, at 04:08, Eric89GXL <notifications@github.com> wrote:

> In mne/epochs.py:
> 
> > +    def equalize_event_counts(self, *args, **kwargs):
> > +        """Equalize the number of trials in each condition
> > +
> > +        It tries to make the remaining epochs occuring as close as possible in
> > +        time. This method works based on the idea that if there happened to be some
> > +        time-varying (like on the scale of minutes) noise characteristics during
> > +        a recording, they could be compensated for (to some extent) in the
> > +        equalization process. This method thus seeks to reduce any of those effects
> > +        by minimizing the differences in the times of the events in the two sets of
> > +        epochs. For example, if one had event times [1, 2, 3, 4, 120, 121] and the
> > +        other one had [3.5, 4.5, 120.5, 121.5], it would remove events at times
> > +        [1, 2] in the first epochs and not [20, 21].
> > +
> > +        Note that this operates in-place, and will call drop_bad_epochs() if bad
> > +        epochs have not yet been dropped.
> > +
> You mean non-in-place (on copies)? I figured folks could do epochs.copy() to experiment.
> 
true,
> I think it's cleaner than having every function give the option to return a copy or not (and only have that where it usually makes sense to return a copy).
> 
but also numy-like to have inplace=False as default (although arrays have copy methods).
just a gut feeling.

> —
> Reply to this email directly or view it on GitHub.
>
``which``, not ``who``
You need to put every namespace on his own line with his own `use` statement.
That's a pretty funny design decision, but if that's true, then you're fine.
GlooxCLEntry *clEntry = id2account [id]->CreateFromODS
(ods);

                    const QString& path = Util::CreateIfNotExists
("azoth/xoox/avatars")
                            .absoluteFilePath (entryID.toBase64 ());
                    clEntry->SetAvatar (QImage (path, "PNG"));
if you want the conversion, you should inject the converter as a dependency instead of retrieving it from the container at runtime
I think this line should be removed.  What if we want to test that katello gives a proper error message when the description is left out?  We should be able to use this task for such a test.
Please remove it if it's not used anymore
This is good idea, I will definitely do It when I will implement pause/resume.
While we're on this patch, I'd like to note that `asdf` was a typo, the name of the gem that does the viewing with nanoc is `adsf`.
Saw someone got spec with Appraisals
https://github.com/ZenCocoon/rspec-subject-extensions

Will try to bring it back -3-
I'll change it to follow that rule
You can make this optional by checking `RUBY_VERSION =~ /1\.8/` you only ever need `OrderedHash` if in ruby 1.8.
As an identifier with a `_` prefix is supposed to be private, by Python convention, we probably shouldn't recommend using it in the docs.  I think we should add a public alias for this and then recommend using the that in the docs.
is updated
Stop invokes that the connector gets deleted and actviemq will be closed. Unregister connector just unregisters the connector. The connector is still oben. for example

registerConnector
unregisterConnector
registerConnector
unregisterConnector

is possible but

registerConnector
unregisterConnector
stop();
registerConntror => exception
Hm, thought I caught that in the bullets; I will amend to just "encouraged" (the identical wording in the narrative portion).  The narrative portion specifies 120 as a "warning, *not* error".
The `";` is tabbed in 1 too far.  Ditto for all future multi-line strings.
How about a method like this:

```php
public static function fromValue($value, $noneValue = null)
{
    if ($value === $noneValue) {
        return None::create();
    }

    return new Some($value);
}
```

I also think that we should prefix these factory methods somehow so that it is clear that they are factory methods, personally I'd use ``from???`` as it's pretty short and should still convey its usage.
Hi, I'm sorry for the typo. This is fixed now.
I don't see much value in WT_IS_ERROR, I'll pull it out -- I'd also suggest adding comments to make it clear why these errors can happen.

I don't see any path where we could end up with ret == WT_DUPLICATE_KEY, am I missing something?

Also, it looks like this can fail silently, should we have a call to __wt_err() here so we know what happened?
See if we broke a single rule, using the `(some ..)` call from the current refactor in master
Are you sure you want to override the parameter ``$mimeType``? This often makes code less readable.
javascript нерабочий, вы неверно разрешили конфликт в git.
Please don't use net/http.  Use Faraday instead, so we can make adapter changes if necessary (such as EventMachine for non-blocking HTTP requests).
There are a few trailing spaces in this file.
This exception is still printed on `System.err` of being logged
nit: double space after "parameters"
I think it's clearer if you just do `sum(payments).to_f / sum(times)`.
i'm dying from suspense.
*comment* -> *comments*?
`future` is not needed because we are not using `url` tag anywhere.
I don't understand this TODO? I think this does not have a place here now?
Move date parsing to a method.
Oh, I didn't know about this one. Can you port also other periodic tasks to use this function? And remove timedelta.
Aaa, you are using this as a set. Why then don't use set? That is, object?

```
panels_forcedby[dependency][panel] = checked
```

?
Also add the address to which token is send.
No :), because _other_ channel subscriptions are kept somewhere else.
true/false.  It's a boolean field
Please make sure indentions are correct,
Got it fixed, just have to manually check for immunities as much as possible (especially disarm)
Yeah I'm just thinking the check should be removed all-together then and made an assertion (implied or otherwise).
Why not expose it right away?
I think handling an NSUndefinedKeyException (http://developer.apple.com/library/ios/#documentation/cocoa/Reference/Foundation/Protocols/NSKeyValueCoding_Protocol/Reference/Reference.html#//apple_ref/doc/c_ref/NSUndefinedKeyException) is going to be cleaner here.
A pattern seems to emerge in the code below. Ripe for refactoring.
use ``self::``
Потоки из конструктора лучше не создавать. Жизнь показала, что удобней для этого заводить отдельные спецметоды.
Looks like a whitespace issue here. Would be good if it was consistent, but a minor nit.
this method is actually not createList, it creates a list of instance of specified class.
This was just for consistency with other values.
Hi, Chris, I have couple questions about the comment you make.
I am not sure where to look at when you mentioned, "
We should also probably make sure the port QLineEdit is disabled when this checkbox is set. This would be less confusing to the user. "
Also, when you mentioned why I change this line code "libtorrent::error_code ec;". In my file, the line looks like "
error_code ec;", I don't have the "libtorrent::" in front of it.
Thank you very much Chris.

-tony 
Date: Sat, 1 Sep 2012 23:44:24 -0700
From: notifications@github.com
To: qBittorrent@noreply.github.com
CC: ireallylikeher@hotmail.com
Subject: Re: [qBittorrent] clean up code for the feature that selects a random port everytime the system restarts (#67)

In src/preferences/options.ui:
> @@ -263,6 +263,16 @@
>                  </widget>
>                 </item>
>                 <item>
> +                <widget class="QCheckBox" name="checkRandomPort">

I cannot really tell from the diff, but did you add this checkbox over the "Use UPnP / NAT-PMP port forwarding from my router" one in the "Connection" tab? I think this would be its right place.

            
              ¡X

              Reply to this email directly or view it on GitHub.
make `rights=None` just in case we find a repo that doesn't contain copyright info.
Yeah totally screwed that up. I'll have a patch for you in a couple minutes.
There are a couple of non-Mac package managers that work on Mac. NetBSD's [pkgsrc](http://www.netbsd.org/docs/software/packages.html) has [quality](http://www.wezm.net/technical/2011/01/mac-os-x-package-management-with-pkgsrc/) packages and is not hard coded to NetBSD. Gentoo's Portage is also [available](http://www.gentoo.org/proj/en/gentoo-alt/prefix/). Recently, another package manager, which is very interesting, called [Nix](http://nixos.org/nix/) has had its [1.0 release](http://news.ycombinator.com/item?id=3967550).

Pacman for Mac OS X is [available](http://www.archmac.org/). It just lacks packages right now. There are only a [few](https://github.com/archmac/repositories) written by the author for himself. Perhaps an Arch to Mac PKGBUILD porting script could be written.

The Most Macish package manager is [Rudix](http://rudix.org/), which uses native, self-contained packages, but making packages for it is still complicated since it's not yet automated and requires the atrocious Apple PackageMaker.

As for Conary, it's written in Python with a small portion written in C, which is the part that gave me troubles when I last tried to compile it on OS X. It should be easy to port though.
No, toctree should be fine with :maxdepth: 1
X_j is all observations with j != i ? to see if I understand correctly
I'm finding lots of references to implementations of the Fast Gauss Transform, but nothing that's directly reusable. That would be the way to go.
No comma, just removing the second ``:``. Addressed in https://github.com/rgommers/statsmodels/tree/pr-408-comments for all code.
Are you referring to the `nfd_quick_check ` technique?
Organize imports in alphabetical order. Also, those two could be combined into one:

```
from django.contrib.auth import backends, models as auth_models
```
There might be value in naming the things already on trapper with a well-defined convention to avoid name collisions. For example, double underscores as in __initialize(). Another option is to explicitly check for a name conflict and throw an exception. Another option is ending up with a difficult-to-debug codebomb.
I was only referring very specifically to minor typos, for which comment locations shouldn't get changed since only a few letters on a single line would be changed.  For anything more significant, I would raise it as an issue on GitHub.

So based on this answer, I will edit directly for minor typos, except not right now since you just said you're editing for the psf/PSF, hdu/HDU etc. consistency.  I'll start the direct editing for my next round of comments, later today.
Aha, good idea, thanks! Pushed.
I don't like to use 1.0 for tests, since it's sometimes possible for math to errors to be missed.  I don't see any particular reason it would be a problem here, but 1.8 is a bit harder to imagine accidentally passing.
should be `lightSaberColor` to honor camelCase word
Why Hashtable instead of Dictionary<string, string>?
Note: This is an addition in projects and is not necessarily used in frontpage -- I believe frontpage depends on projects
keep this constructor with a warning for backwards compatibility
It seems like you have scriptName defined in three places. Why don't you just define it in one place and not let it be configurable. We'll make it configurable later if we need to.
This is essentially `_.result`.  You could probably use that here.
It's to ensure the name ends up correctly, otherwise it won't be found in s3
^ you don't need this if you just call a method on SERVICES. global is only if you want to change the variable value itself
Nevermind. The hidden state matches this case and will trigger transition.
I left the `CGPDFDocumentRelease(pdf);` within the caller (e.g. Line 969 and 992) mostly because I try to keep memory management as local as possible (no hidden release calls without explicitly mentioning them in docs).
Whole test suite is extremely brittle due to stuff like this. The only difference is I'm calling sleep explicitly instead of having it buried in a testlib function like it was. I have no way of getting my hooks into the various phases of job creation in order to test these things. This is a design failure of splunkd, and the test suite will always be brittle until someone dreams up a way around it. My test suite doesn't pass deterministically. If I run the files separately, they pass, but they sometimes fail together. Or they fail if I don't leave long enough between runs because I have no way to clean things up.
Hm. OK, I mixed that with keys for functions.
On 29/02/2012 16:30, Matteo Spinelli wrote:
>> @@ -177,7 +181,7 @@ DefaultPhysics.prototype = {
>>       var small = Math.abs(diffX)<  20;
>>
>>       var flick = quick&&  !small;
>> -    var tap = small;
>> +    var tap = !this.movedThreshold;
> 20px seems a long run, maybe 10? On iPhone seems somewhere between 5 and 10.

This value really depends on the dpi of the device (centimeters = pixels 
* 2.54 / dpi)

So on desktop this is:

20px == 0.52


While on the Galaxy S2 and with 218 dpi:

- 20px == 0.23

This is already a small moves ;)
sweet. Thanks!
I'm pretty sure that the chan would already be the nick anyway, I need to check into this.
Only someone who knows about genetics would see this.
My oh my, that is sure more readable!
These comments were picked up from HiTL. They either should be removed in both, or uncommented in both.
Redundant it can be replaced by int len;
It does not. It would not be a problem anyway, as the e-mails are validated later by ```isValidEmailAddress()``` method.
I *believe* the above section can be removed from the cinder.conf entirely... it is only read AFAIK, from the api-paste.ini file.
I prefer `#valid?` over `#save` in those cases.
просто секцию <script> с кодом внутри?
My opinion was that the purpose of this test was the see how long to took to transition a deferred from pending to resolved. In its old state it introduced propagation and chaining. These two things are the focus of the two tests suites I have added
Пробел - не единственный разделитель между словами.
Эту магию с param надо переписать. Благо в java есть достаточно выразительных средств для этого.
Вообще в ruby не принято использовать всякие unless, for  и тем более делать break
oh :(
in that case, can we change the name? `enableLogging()` (i don't think you'll ever need to disable logging)
i don't have a better solution, i'd just like to see a good explanation of the problem in the comments in the code =)
"""This is a Mock, rather than a pure object, because the code calls some methods on this object. We don't really care though.""
This is fairly repetitive (the stub request), can you refactor that out into a couple of things?  might suggest you try

let(:link_type){ 'LIST_CARTRIDGES' }

and create a helper that creates
stub_request(:any, mock_href(app_links[link_type]['relative'], true))

also, you probably want blank helpers for the to_return so you can do:

.to_return(empty_response('cartridges'))
Назнач встречу, почитаем код — подумаем ;)
Чем этот метод отличается от `open()` из `bl-combobox__list`?
> you should probably remove the commented out lines below...?
Done :)
Do we need to make measurements before going ahead with that? After all, keeping the previous implementation as a special case only adds 5 lines of code and *will* be more efficient (perhaps only slightly).
I meant ``import numpy as np``. But if that incurs some overhead, never mind.
could be a defensive copy (e.g. we want to modify ``sample_weight`` inplace later) - will check
why are we using the person directly rather than it's id?
було компактніше і читабільніше імхо
If len == 0, then len1 and len2 are both 0 also, right?  So, just return 0?
Ok, I guess `driverSocket.write` will have access to the real stuff in C++
please address the same comment,  for other hard coded values as well (e.g. fontFamily, normal, intalic, fontWeithg, etc.)
Wait... `$entityManager`?
Extracting the key (and calling this getFlags() function is only ok if selectInterface(TAIhashdedupargs_2) returns non null.
Otherwise you may have backward compatibility problems with old workunits.
Right, yes.. harmless as not used.
Otherwise, i guess it would have meant that it _could_ have succeeded after failure to start session and you'd expect errors on subsequent use.
A future optimization - this looks like it is always working with a serialized stream.  You could just read from the file directly into a buffer.
Should this question be resolved before I pull?
Getting a path that is relative to OS wouldn't be ideal in this case, since you don't know if you have permissions to write in that path.

For instance, user ```hpcc``` won't have write permissions on ```/thordata/regress``` which is also hard to test in ```daregress```, since you would have to create that dir as root and chown to hpcc beforehand.

A relative path in this case makes much more sense and it permission-safe on any platform.
Looks like your whitespace setting is off. What OS's have you tested this on?
Ooops, big mistake :) fixing it.
You don't use an apostrophe to pluralize. It should be "PSRs".
this will need to use `join()` for windows
The two previous examples don't match their previous sentence. Or I don't get the point of these examples?
hasOwnProperties?
@shacker It doesn't have to be a part of this commit but if we use YQL for the next widget as well, it's probably best to create an API function for this.

e.g.

```javascript
sakai.Api.Util.getRSSFeed({
'url': '...',
'fields': ['pubDate', ...],
'limit': 4
});
```
@yuhunglin Can you also add some JSDocs to this method and maybe to other lines you've changed? (e.g. the maps)
why the order change?
`study_plan` is a `:has_one` on `CourseMembership`. I looked through the API docs, and I couldn't find any way to `find_or_create` on a `:has_one`
I always lock to the patch version (n.n.x).  If a minor or major change comes, I generally want to know about it, before allowing the change in.
Obviously that assumes people actually semantically version their gems, just been bit too many times before on this subject.
Do you mean result.nil or result.empty?  Because as far as I can tell result will never be nil because you already set it as "" at line 191
I dont like furnitures around comments but.... doesn't break nothing.
@jlee-r7 While I agree that backticks may be more portable, I'd like to point out that `$()` is specified in [IEEE 1003.1](http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_06_03) a.k.a. POSIX. This has been the case since XDG4, when the switch from System V shell to POSIX shell was made in the Single UNIX Specification (see [the differences here](http://www.unix.org/whitepapers/shdiffs.html))
Adding 3 widgets then runs the filter 3 times?
The user might want to provide an array for the data argument. Why not add a `color=` keyword argument, that would be `gray` by default, but could also be `multichannel`? This would be more robust (and easier to use).
Maybe we shouldn't leave the `*`?

    mu_ji = sum{ array(x, y) * (x - x_c)^j * (y - y_c)^i }
Yep, confused this with the focus method.
simple enough to make this a base class. Unless you meant to move this to a common location? Its just the top of the instance_actions.py because its only used inside that file at the moment.
simplify this by using the method of the EntityRepository doing the work for you:

```php
<?php
$qb = $this->createQueryBuilder('u')
    ->where(/* ... */)
```