[Form] removed getPositions from PropertyPathInterface

this method was just an implementation detail (that is not even needed) and should not be part of the public API as it serves no purpose
Fixed a typo
[Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again
merged branch Tobion/proppath (PR #5313)

Commits
-------

79a1257 [Form] removed getPositions from PropertyPathInterface

Discussion
----------

[Form] removed getPositions from PropertyPathInterface

This method was just an implementation detail (that is not even needed as my implementation shows) and should not be part of the public API as it serves no purpose.

---------------------------------------------------------------------------

by fabpot at 2012-08-22T06:19:35Z

ping @bschussek

---------------------------------------------------------------------------

by stof at 2012-08-22T09:11:51Z

what is the performance impact of your implementation compared to the previous one ? the form binding is executing this code thousands times for big forms.

---------------------------------------------------------------------------

by Tobion at 2012-08-22T14:08:39Z

There is none of course.

---------------------------------------------------------------------------

by bschussek at 2012-08-22T15:23:57Z

Looks good to me.
merged branch goohib/fix-form-component-typo (PR #5323)

Commits
-------

bca68ca Fixed a typo

Discussion
----------

Fixed a typo

The CSRF error message won't be translated due to this typo even if the translator is enabled.
merged branch bschussek/issue5221 (PR #5319)

Commits
-------

a38232a [Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again

Discussion
----------

[Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5221
Todo: -

---------------------------------------------------------------------------

by stof at 2012-08-22T14:14:55Z

the return value of the getParent method should be updated in the phpdoc of the FormTypeInterface to mention the FormTypeInterface .And the description of the method should be updated to explain than returning an instance is discouraged as it implies a performance penalty and does not support using type extensions (if the comment in the factory also applies to the unregistered parent)

---------------------------------------------------------------------------

by henrikbjorn at 2012-08-22T14:22:00Z

Wasn't TypeExtensions supported before? This means that Csrf will not be applied?

---------------------------------------------------------------------------

by stof at 2012-08-22T14:23:50Z

@henrikbjorn the csrf extension is targeting the FormType, which is registered in the form registry. What is not supported is having a type extension targeting an unregistered type

---------------------------------------------------------------------------

by bschussek at 2012-08-22T14:39:53Z

@stof Exactly. I find it a bit unlogical to register an extension for something that is not registered.

---------------------------------------------------------------------------

by henrikbjorn at 2012-08-22T14:39:57Z

Okay. That wasn't what i got from reading the comment :)

---------------------------------------------------------------------------

by bschussek at 2012-08-22T14:44:27Z

@stof Updated.