labofsahil/github-event-dataset-2012 huggingface dataset:
nit: remove this dead code.
`system_banner` implements only the bottom banner (ie for app crash and now update error)
I think this should be another building block. I don’t think it can be factorized between the Contacts and Settings app, for instance.
`ts_` was a prefix created for indentifying 'messages' which where stored in IndexedDB. Currently we should remove it.
What if you passed the multipliers in instead of the flag?  Could you save a step on computing the ranking?
buttons has landed in shared :)
This function is poorly named. Judging by the length of the code, move this back to `handleEvent` can work (for now).
CalendarColors and TimeHeader are currently both being loaded after the db connection, and potentially after first render. You can spot it, but I think it looks ok. Take a look and let me know if you think it's not acceptable.
There also has the same style of "no message" block in SMS and they set the magic number for the font size... I think it's fine to remove the calculation.
Sure! To be uploaded soon... ;-)
Why not just

    adb shell "cd /sbin && for x in `./busybox --list`; do ..."

?
It looks like you're missing the call to `http_interaction_list.assert_finished!`--this should be called from `eject`, I think.
Consider if this is critical to have this functionality in app. If, for any reason the special sphrases are not loaded, app will be probably not usable. However, I'm fine with this if the assumption is that it is a must.
@bpot Is there a better way to go about this? I'm thinking of doing `pr = pr[(pr.index(':')+1)..-1]` to extract the branch name from that, but it looks messy.
OK, sweet.
http://www.kernel.org/pub/software/scm/git/docs/git-archive.html
--format=<fmt>

    Format of the resulting archive: tar or zip. If this option is not given, and the output file is specified, the format is inferred from the filename if possible (e.g. writing to "foo.zip" makes the output to be in the zip format). Otherwise the output format is tar.
The contract is kill process will gaurantee either process terminated or throw (an issue that our team needs to investigate).  There is a race where the process may terminate naturally and we call kill on it.  In that case, we handle with HasExited.
leave this \n
why capture res2, why not just return the result of the foldLeft?
You're right. The user should ensure that the arguments are valid. If I remember correctly it was the `-scala-extra` argument that caused the problem. I'll take a look tomorrow and provide the necessary patches for both zinc and the maven plugin.
You're saying the filtering is complicated. Is it because it shouldn't be handled there or is my code bad? If it's the latter how could it be improved?
Use `Djinn.log_run`.
Didn't know this syntax for `str.join`. Aren't brackets required?
And this is exactly what? :D
s/gonne/going to/
Don't version your database. If you need a sample one, create it with another name.
Upped these to 1024 for conformity, and a little extra compile speed.
The first association I have with `checkout` is with vcses
Rather than forcing it to be a <pre>, it would be better to make it a <div> with an appropriate class such that it can be styled via CSS.
It is exactly the same. I prefer @ to be consistent with coffeescript.
I wrote about it at above. let me know what you think.
I'll probably try other way that keeps z as int.
Aw crap...Ruby indentation. I'll fix it. Thanks.
Ups :-)
Yes, this was a mistake on my part. ncaps should be initialized to 0 and increase as capabilities are added to the namespace. Currently using the destination == NULL concept, though the idea of not reusing capability numbers is also intriguing.
Just call render. ;) Do we need to expose this publicly (for tests)? Otherwise we're just queueing up loads of overhead with all these events being fired all over the place.
Fixed it. This is already in the Platform but not the CMS.
@warner - For a long time, I was under the impression that scripts are not be run unless they are attached to the DOM using appendChild or insertChild - this is *almost* correct.  IE9 does not behave this way if the script that is to be filtered out has the "defer=true" attribute set.

example:

```
stripHTML("<script defer="true" type="text/javascript">alert('XSS')</script>")
```
will print XSS in an alert box in IE9 (only)

whereas
```
stripHTML("<script type="text/javascript">alert('XSS')</script>")
```
will not.


Because of this, I am instead replacing the list of sensitive chars found in https://www.owasp.org/index.php/XSS_Prevention_Cheat_Sheet#RULE_.231_-_HTML_Escape_Before_Inserting_Untrusted_Data_into_HTML_Element_Content to their HTML encoded equivalents.
Also add "interaction_data" which defaults to {}
context managers rock!
As long as everything is a manage.py command, this line should not be necessary.
please add a blank line to separate the groups.
Well isn't that interesting- in Chrome it does NOT, and in Firefox & Safari it DOES. Now I'm not sure what is the best verification.
your new commits in your branch "relativistic&boris" are automatically added to this pull request. You can see them on this page "okapetan added some commits".

If you press the green button "Merge pull requests", all your commits will automatically be merged into the master, so this should only be pressed by someone else ;-)
Ah!  So, turns out my code was correct - the `windows-api` gem has a bunch of features to automatically generate methods that wrap invocation, but since I don't use them I don't get the automatic boolean coercian when I invoke `call` on the object.  I am going to push this with this part reverted.
Why not use the existing `.active` utility class here? That would be consistent with the rest of BS.
Ha, I was testing whether `any()` still complained if an expectation was never invoked. It only happened in conjunction with `with()`, but recent version of PHPUnit must have resolved the bug.
Why `$url` here when you renamed to `$uri` in `prepareRequest()` ?
`$flags['name'] !== ''` ?
тут фикс последствий, причина - метод resource, фиксить надо его
+1. Avoid instance variable if we can.
This will never be null `getPlayer()` will throw a CommandException if the player is not found.
ok - all fixed (I think!)

Glad to be part of such a great project.

I've been trying to get some more support for o_O --- any ideas ?

On Sun, Apr 29, 2012 at 2:59 AM, Sindre Sorhus
<reply@reply.github.com>
wrote:
>> +  $el.keyup(function(e) {
>> +    if( e.keyCode === ENTER_KEY )
>> +      func.call(context);
>> +  })
>> +}
>> +o_O.bindingTypes.enterKey = 'outbound'
>> +
>> +
>> +// adds an `s` where necessary
>> +window.pluralize = function( word, count ) {
>> +  return word + (count === 1 ? "" : "s");
>> +}
>> +
>> +// represents a single todo item
>> +var Todo = o_O.model.extend({
>> +    type: 'Todo',
>
> There's only one type, so it's moot specifying it. Can you remove it?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/addyosmani/todomvc/pull/150/files#r748690
I don't think this is the same as defining a getter for the body since the body only gets updated when the addToContainer method is called
is it really a class name if it contains the metadata ?
Can't you just make the normal flow the non-branched step?
This means you'd have to negate the condition and `continue`. It would remove a level of indentation easily.
Change to:

return (parent ? parent.view : null);
@ametaireau -

Without this patch, it crashes if the directory does not exist.

With this patch, if the directory does not exist, it tries to create the directory. If there's a failure creating the directory, it logs an error. If the directory-creation succeeds, there's no extra logging output.
For reference, This was added in #488.
The problem is that, with the `RELATIVE_URLS` option, the `ASSET_URL` in the html files in subdirectories (`categories/`, ` pages/`, ...) will be wrong. Using `SITEURL` is a way to fix the issue, and after some reflexion I did not have a better solution to propose.
the curly brace should be on the same line than the ``if``, and you need to add a space right after the ``if``
Sorry Pete, can you please clarify?
This command currently renders at the end of the previous line so it's hard to see. I believe you need a blank line before this so that it appears indented on a new line. 
Check out how it's done in the other quickstart README.md files.
Please include the config files in the project or provide sample config files
If you make copyIndexedColorData a function on $SDL, there will be no need for the deps stuff.
It's relatively wrong but absolutely right; the two lines above it should really be indented.
Thunderbird misspelling
Weird indent?
IMO - you only want to do this if the user sets there username on registration, right?
I think you should use async API for reading the file.
Change this to 'service.transform_management.restart'
It was complaining that the objects needed marshal_dump defined last time I was testing it, even after I made sure the collection was an array and not a relation object. Trying it again, it worked fine without it - and it should, since marshaling is part of active record. So I chalk that up to caching weirdness and being in a hurry to get it working.
This should work fine, but you can just do user.works
I was thinking about our use of em tags here, since it's not quite right. I think what we want is the kbd tag on what the user would be inputting (book*, Harry Potter, Harry | Potter, "Harry Lockhart", Harry -Lockhard) and the samp tag around the results that would be returned.
I could be Rails-y and call it `deliver` to avoid a conflict.
whats fhs?
bad merge for the puppte_server value
I put the "no datastream found" error in get_datastream_dissemination and then realized its probably useful here, since this function performs almost the exact same soap call
fixed (but we lost easing)
Should the last parameter be "ipv6=None" ?
Adding a comment only because it may trigger the github merge dialogue which has been flaky recently.
; - ?
Can you somehow check that the alias is registered and if yes then do remove?
This dangerous printing could be solved in another PR.
Doing that now
I'd rename the argument to `search_term`
Should the references to "rhc" in this file be "ss" instead?
Have an empty line at the file.
@pyr : why is this LOAD_PATH manipulation necessary?  Forgive me if I'm missing something; I don't have a tremendous amount of experience with gemspecs.
Yea, that method doesn't really cast the value to a boolean though, which I need in this case.
Since the ``index`` is computed lazily, I assume this can possibly be triggered outside of the ``PresentationCompilerThread``, is that right? If yes, can we have an assertion to ensure that the ``index`` always gets computed within the ``PresentationCompilerThread``. What I'm suggesting is to check that the thread-confinement is at least checked at runtime, WDYT?
Done in pull request 73.

I thing this one can be closed :)
`isset()` is not needed - `! empty($config['log_path'])` will do that as well.
плохая идея называть файлы так, вот смотрю я на твой проект и ожидаю в что в файле cell+mutator.h будет объявление интерфейса класса Cell и класса Mutator, а там импорт =(
лучше конечно Cell.h и Mutator.h
Исправил:)
double `\n`
This line seems to repeat many times. I'm not  super fond of this code duplication. Could we add this somewhere more prominently? Perhaps in a layout definition?
It is available in 1.8.7p358, not sure about older versions.
err. Comment?
Filed adobe/brackets#1759
(I think it's a good thing.)
Could you remove this line @erikw ! Left it by mistake, oops ! Breaks the behaviour.
Does this need to be a loop? Could we get into a situation where each subscribable has two values waiting to be zipped and sent?
I would not expose here _do_stderr unless you want to return both the evoked mean and the standard error.

I would refactor with `_reduction(self, keep_only_data_channels=True, mode='mean' | 'std'):`
Darius, this.cache = newMap is a good solution, but you MUST remember to make the cache field volatile :)
I would leave this for another chapter just because I'm not sure this is relevant to newcomers.
I never ended up using fallback_to_404 here.. Should probably be removed.
确保应答是JPEG
Personal pref: I like to add the curly braces even if there is only one following statement.  Just leads to bugs later, especially when mixing in working with other languages like Python.
Yep, that's obviously a typo. :-$
Falta un * acá.
add spaces / CS
moar spaaaaaace
BitSets can actually be kind of slow for this if the vectors are long.  Perhaps use TDoubleSet from GNU Trove?
Why not call FileLookup.lookupFileStrict() ? That will through the right exception, wouldn't it?
Why do you need a taskId?
The key is already a part of the entry.
Actually, it's not without value. It just checks whether the header exists no matter if it has some value or not.
This will conflict with my transform limit PR. Need to watch out for that.
Just to clarify: no support for opening video yet?
Lose the `@froms`, I know R# puts them in there but they are unnecessary
This is predicated on an assumption that ruby is on the PATH, which is problematic and something we want to avoid. May need to rethink how we find ruby in this scenario.
pulled this method out of SolrSearchBatchResultProcessor so that logic about rendering results is divorced from the actual search process.
Hi, the problem is that I will have to create Kernels in the run-time. Since I do not know what the type of the kernel the user supplied, I have to use the kernelfactory. Or I do not know what to new. If you know any better solution here, please tell me.
That's true! I had a fresh look at it now, and it appears there is no need to have this `else` at all: there is only one root layout element - '.cms-container', and it already lays itself out through `this.redraw()` call! No need to do it explicitly.

Thus the only situation that we need to cater for here is if a child of level 3+ gets replaced:
https://gist.github.com/52a6853a0a648575c85a

How does this look to you?
We should look into bootstrapping data as has been done with the alerts and custom field tests. It's a much cleaner way of creating fake datasets.
huh?
but you're already repeating all the escaping code twice in this function anyway.. 

and as per other comments - DB escaping shouldn't happen here anyway.
I updated the comments as suggested.
$ext should be sanitized to something like ^\w+ here.
Are you sure ``true`` has the correct type as "Boolean" is not a sub-type of "string|null"?
Are you sure that the method "getEvent()" exists?
@schmittjoh this comment seems wrong. It is not a ReflectionClass here
Are you sure ``array($this, 'stripSlashes')`` has the correct type as "array" is not a sub-type of "object<callback>"?
This is the only line that changed when I ran `android project update --target android-15`, so I don't think it needs to be ignored. Certainly picking an SDK level and sticking to it (and documenting ti somewhere) would be good, though.

If an SDK level is picked it's probably safer to go with 14 rather than 15, so it works on non-HTC ICS devices - I just did the minimum to make it work for me.
Yes... will fix. Fucking JS.
What if "level" is not set to a recognized value?
Think about *OS process scheduler*: when one *real thread* unlocks *real mutex*, then OS process scheduler *will resume execution* of another *thread waiting for a lock* **sometimes in a future**, and *thread* that *just have released lock* continues execution **without any interruption**!!!

So, if we wish to imitate thread real threads and real mutexes, we ought to continue execution of current Fiber, and we must be sure that other Fiber will be resumed sometimes in a future (that what `EM.next_tick` does)
I did have to change the visibility of `#read_key` to achieve that, but the performance gain is worth a wee bit of code smell, IMO. :)
What is the utilisty of this line?
why are you base64 encoding the data instead of storing the binary?
CS : Braces on a new line
I set to empty string to match your original style, but left it in so it is easier to adapt for other people.
The original style only showed a `*` when branch is dirty. 

The new code checks for much more, if you want to assign a symbol, just pick one.

Compare with @necolas version: https://github.com/necolas/dotfiles/blob/master/bash/bash_prompt#L79-L96
Pois, podes sempre passar como argumento no 'respond_with', no controlador.
I'm not sure embedding dependencies in components or having the component load it is a sane way of managing dependencies. This has potential for conflicts, useless bandwidth usage and also doesn't let developers load dependencies the way they want (maybe they prefer concatenating all their scripts or use a specific script loader). A lot of work has gone in dependency management in NPM, maybe some inspiration could be taken here.

If ultimately you decide to keep it that way in xtag (self-contained components) then I will comply.
curly braces are a style thing. I can change it rather quickly... I just want to engage @paulirish about it first.
instance_heap_t
Some comment would be really good here, why and what exactly we are doing here. So why exactly here, what is this.
I just thougt that when we will have Google maps and other stuff on page they will have same 'box' design (that will have the same toggle effect and header)
Yes, you get mismatch error (because something is not equal to nothing). Why is that a problem ?
Surely there's a library for this.
this should be thrown, as it generates an exception
Now I see why you asked me about `hibernate.dialect`. Currently Hibernate OGM detects the dialect from the datastore name on `hibernate.properties` so it's not a required property. I should have reflected the fact on `RequiredProp` enum.
add "Aubourg"
What kind of extra options?
Ditto, would love to see some docstring here :)
is it really useful to have a "get_socket" method that is brainless like this one?
do we want the number of processes here?
Browser won't show any fallback if you don't specify one. But regardless, You must not embed plugins inside Dragonfly - this opens up for security issues.
The up direction is dotted with the vertex position of the star in camera space.
Have you tested this locally for a timezone other than PST?  Use System Preferences to change it around and see what happens when you run the tests again.
Why are these initialized to empty objects?
I don't like this because TNArchipelEntity is a generic class that doesn't have necessary libvirt connection.

What I suggest it to create a method

```python
def custom_xmpp_connection(self):
    pass
```

Then in the loop, call this function. Then you can override it in subclass.

Anyway, this is an awesome patch!
I think there's an extra '.' here too.
Has been worrying me *hard* for the last four days, and I've reached some partial conclusions and successes.  See the post below...
in the GSObjects we also now check that, if not `None`, the `interpolantxy` is an `InterpolantXY` instance for safety.  I'll push an edit that does this.
That's it exactly.  It didn't seem like NFWHalo and PowerSpectrum were things that we wanted relegated to a sub-namespace.
I think we could use more error checking on filetype -- e.g., if someone isn't sure about the caps convention and puts "ascii" or "fits", or has a typo and ends up with anything but precisely "ASCII" or "FITS", then it will get to the return statement and try to return an undefined input_cat.
Might these be clearer as `PoissonDeviate` and `GaussianDeviate` for this example of noise models?
or possibly note behavior in the docstring, at least?
I would rename the file to be consistent with the other class names ... Could you change that and I'll merge the PR. Thanks.
I think why dont we restrict minimum unit is $1 dollar, screw cents :D

On Sun, Nov 18, 2012 at 1:29 PM, ducky64 <notifications@github.com> wrote:

> In app/controllers/projects_controller.rb:
>
> > +
> > +    if (params[:amount] == "other")
> > +      amount = params[:donation][:amount]
> > +    else
> > +      amount = params[:amount]
> > +    end
> > +
> > +    if (current_user)
> > +      @donation = Donation.new({:readable_amount=>amount, :email=>current_user.email})
> > +    else
> > +      @donation = Donation.new({:readable_amount=>amount})
> > +    end
> > +
> > +    if (@donation.amount == 0)
> > +      flash[:error] = "Invalid donation amount"
> > +      redirect_to project_path(@project)
>
> Fixed and fixed.
> Minimum donations may have a problem, where for a $500 project, someone
> donates $499.99, making it impossible to finish the project. Need a way
> around that, but since Stripe imposes minimums, might as well add a $1
> minimum.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/baugarten/CS169-Group-11/pull/25/files#r2162057>.
>
>
have marked "entries" private and added a getter with synchronization 
and COW


On 26/11/2012 12:16, Aled Sage wrote:
>
> In core/src/main/java/brooklyn/catalog/internal/CatalogClasspathDto.java:
>
> > @@ -0,0 +1,21 @@
> > +package brooklyn.catalog.internal;
> > +
> > +import java.util.ArrayList;
> > +import java.util.List;
> > +
> > +import brooklyn.catalog.internal.CatalogClasspathDo.CatalogScanningModes;
> > +
> > +public class CatalogClasspathDto {
> > +
> > +    /** whether/what to scan; defaults to 'none' */
> > +    CatalogScanningModes scan;
> > +    List<String> entries;
> > +
> > +    public synchronized void addEntry(String url) {
>
> Why is this synchronized? The field is package-private rather than 
> private, so I'm not convinced by this synchronization model: it's 
> unsafe, even if not in the way current calls do stuff but in the way 
> it's likely to be added to if we leave it as folk accessing the field 
> directly.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/brooklyncentral/brooklyn/pull/396/files#r2221012>.
>
All the code from line 11 to here (line 53) should be moved out of the view. I think the best approach would be to make a "View model" sometimes called a presenter. The view model would just be a simple class that defines methods like: btn_text, material_id, material_type, and activities
The class is instantiated with the material and the current_user and it computes the values of btn_text and activities. To start it could be instantiated at the top of this view partial, but you might find it makes more sense to instantiate it somewhere else.

So far we've put these view models in the models folder. Examples are models/portal/school_selector.rb and models/report/offering_status.rb
You can just use TMPPATH here.  It's based on VARPATH which is defined with realpath().

eg:
$this->gm_ini = TMPPATH . "/gm.ini";
Which Railscasts
Why did you change the inner quotes? With single quotes everything would be a little bit simpler to read .. IMHO
Use `add_development_dependency`, or only include this in the Gemfile.
The correct fix here is to make server_split_hash check for NULLs, which I've just merged. You also forgot to free username and password here.
```diff
- Sifeo
+ Sifteo
```
If we add this, we need to start depending on python.
This one is irritating, but I had a situation with diff where I had a `const git_vector *` instead of a `git_vector *` and so I could not use `git_vector_get()`. I added this alternative accessor, but I'm not very happy about it.
Must extend OBController.
Hice 2 funciones que son cuasi-identicas, llamadas "sql()" y "r()". Muy eficientes, minimizan un poco el codigo y permiten abstracción básica como bien dices. Están definidas en "source/inc-functions.php". 

Quiza podrias utilizarlas y así ahorrarte este trozo de codigo. Pero si te supone mucho problema da igual. Es que me ha parecido curioso.
Use sig_catch
В этой строчке не будет компилироваться.
По умолчанию используется UTF-8. Специфицировать свою не стоит.
unless решил написать, чтобы было короче и понятней
break добавляет оптимизации, т.к. бессмысленно вызывать find_email_in_user и идти дальше по циклу если юзер уже найден
I think we should say "the first few eigenvectors", as not all eigenvectors will only cover the connected components, right?
The original code looked like:
```
    /**
     * Get header value
     *
     * @return  string value
     */
    public function getValue() {
      return $this->value;
    }
    
    /**
     * Get header value representation
     *
     * @return  string value
     */
    public function getValueRepresentation() {
      return $this->value;
    }
```
getValue() is used in ```equals()```
getValueRepresentation() is used in ```toString()```

```toString()```is used to return the full qualified header string.

So basically it's possible that ```equals()``` would check for other things that ```toString()``` returns.
I changed ```getValueRepresentation()``` to return ```$this->getValue()``` instead.
Yeah I agree it started looking unnatural to me too.
We use it just ones. Nothing we achieve from that rather, than have extra unusable variable.
Looks like you are using TAB for indenting. The rest of the code uses 4 spaces.
Bonne idée merci :)
Because this is a general purpose module. This logic should be configurable and you don't know if the end user extended `DateTime` with his own logic. You should rely on the metadata the user has told you to use (which is his responsibility).
should heapFlags be a RoxieHeapFlags? 
although that will make it slightly more hassle to pass in combo. of enumurated types.
This needs to return more information about the types.  E.g., size/endian/unsigned for integers.
It can't be added, once spilling has started
True, the obvious way, prob. was tracing diff or something before
why is that defined here?
You later do `runGraph(buildAjaxURL())` or something like that. 
If you're going to define all these variables "globally" within the `$(function() {` then I'd expect the code to look like this:
```javascript
buildAjaxURL();  // sets variable ajaxURL
runGraph(ajaxURL);
```
Not needed. The `http` import is on line 6 so you can do `http.HttpResponse`
確かに！nameもgetNameで使っているし、directoryもgetとaddメソッドで使うだけなのでprivateにできそうです。
Особенно круто, когда код можно совершенно без ущерба для понимания, логики и красотливости ужать из трёх строчек до одной. Догадываешься, да? :smile:
This does not hurt if you use the usual `brew install gfortran`. I prefer the `brew install gcc --enable-fortran` in order to get the 4.7 version (which I need for numpy/scipy). That version rocks. But I need to set `FC`, since hombrew-dupes appends the "-4.7" and most software doesn't find gfortran then.
Homebrew recently got the ability to build on systems with xcode only (so no command line tools installed). In order to make this possible, we had to [add some things into the CFLAGS, CPPFLAGS and LDFLAGS](https://github.com/mxcl/homebrew/blob/master/Library/Homebrew/extend/ENV.rb#L280). There are some formulae in homebrew that only pass LDFLAGS to a combined compile/link step. Therefore, we decided that it should not harm if we add the include path there, too.

I think the `ENV.remove` method is robust enough to "do nothing" if that include path is _not_ in the `LDFLAGS`.
This line kind of is the problem; it will enable that button right after any pages load, and i already default the button to disabled.
`chrome` attribute seems useless for top level windows. I'm not able to force having system principal for a document served from http://.
It seems to be only using protocol flags instead?
env isn't used, is it?
It looks like we are leaking `onChange` as we never release this observer on addon unload.
Either fix it or feel free to open a followup bug, as we were already leaking it in previous code.
After a precise investigation, it seems that sles 10 uses syslog-ng with src and Debian s_src. Should I keep the current behavior and amend the change as requested or discriminate between the two OSes ?

Risk is that one Debian syslog-ng user tries to use Rudder, will have his reports broken...
As discussed, requests will follow any redirect and the status code will still be 200 if the request was successful. The history attribute of the response will contain a list request objects that were needed to complete the request. See http://docs.python-requests.org/en/v1.0.0/user/quickstart/#redirection-and-history.
@shacker Indeed, that was in the spec (Jira)
I agree that there is a lot of code to get 1 useful line. Again, I did not want to rock the boat, so I followed the pattern from the ApkBuilder class.
I will look into trimming it down.
No, though it seemed to work anyway? Fixed now.
I know the pull has been merged in but, I'm wondering why not use the View.createCheckoutManager() instead of the deprecated CheckoutManager(View).
This looks like registry_getvaldata().... or specifically meterpreter_registry_getvaldata().  I think your code will look simpler if you can use registry_getvaldata().
I don't think you're actually using Msf::Auxiliary::Report in this exploit...
This method looks identical to ```postgres_upload_binary_file_linux```
Is this a derived or empirical value? Maybe a reference would be helpful.
What about:

```ruby
found_outside_item = @array.detect do |item|
  next_item = item.next
  if @array.include?(next_item)
    next_item
  end
end

found_outside_item || raise WhateverError
```

I'm not sure it's better, I just really dislike surprise `return`s. Thoughts?
yes, pickup_email, delivery_email
`context` should be `[context]` to indicate that it is optional.  Then you can get rid of the second sentence.  Maybe change the entire description to `The context used to create textures if the material uses them.`
Fine with me.  @pjcozzi, if you left this in intentionally (future-proofing?) let me know.
It'd be useful to add a method that converts an axis-angle directly to a matrix.
@mramato want to take a look at this file?
是不是light 的插件漏了，Ogitor拖出来没有
These lines should probably be lined up with those above them. Whitespace :cop: strikes.
Hi Daniel,

I was wondering about constructor overloading instead of pass null as argument, is less error prone. Wdyt?
yea, it's in finishModification(), which is called after we modify the database.
See below about the map currently requiring its view to be attached in order to create, remember, or forget annotations. Fixing this issue requires a structural rewrite of the map proxy and view.
Should we be explicitly `require()`ing node.js components which may be loaded by other directives?
{ should be on the same line as catch
it does, forgot to change that from the older code
Interesting, I've never been a big fan of checking for null, checking the object type seems easier to read. If the command entered is not a function or null both cases would be handled to be an error.
Replace with getBounds()
Vou comentar nessa linha, mas esse comentário se aplica aos trechos parecidos abaixo :D

A solução de vcs atende perfeitamente a questão de encapsulamento em relação à área das figuras. Existe aqui, no entanto, uma questão mais profunda que é em relação às responsabilidades. Quando vc chama circ.setRaio(...), vc indica que a classe chamadora (FigurasGeométricas) passa a ter conhecimento sobre algum atributo da classe. 

Esse tipo de conhecimento deve ser avaliado para saber se é realmente necessário ou não. Por exemplo, esses setters criam uma dependência que diz o seguinte: "Ao criar um círculo, não podemos ter sua área logo de cara. Temos que setar o raio de forma externa".

Isso normalmente não é legal, pois a gente sempre pressupõe que os objetos saibam cuidar de si próprios.

Só um toque para o futuro, blz?

Abs!
It  probably would be better to encapsulate this widgets into their own class, so that you simply pass the package to the widget, and this then does all the rest.
Yep, adding 'continuation=enable' in the general preferences is not enough. I've tried to find a clean way to do so, but I failed. 

Adding the default pluginsDir location to `ScalaCompilerPreferenceInitializer#initializeDefaultPreferences()` should work. I am not excited of defaulting -XpluginsDir in two places (here and CompilerSettings), but you have a point. Furthermore, now that I think about it, we might actually have problems with 2.10 (which does no longer require to pass -P:continuations:enable). Ok, let me check what I can do. Thanks for pointing this out!
here you
<alloc memory>
<work on something that is not related to the allocated memory>
<use the allocated memory>

the preferred way to do it would be:


<work on something that is not related to the allocated memory>
<alloc memory>
<use the allocated memory>

The first approach can lead to memory leak, if something happens in the "work on something" that breaks the flows and the third step is never reached.

It's also good practice to check that data is not NULL after allocation, handling the out of memory error when needed.
nit: capitalize O
And the net effect is about -10% performance on your tests using DMD.  
Haven't had time to analyze the generated asm code.
I think it's enough of experiments already  I'm doing another pass on style.
I think we can merge this to a part of `std.conv.to` feature.
```d
ref toImpl(S)(ref S source) if (isStaticArray!S) {
  alias Elem = getStaticArrayTerminalElemType!S;
  enum dim = getStaticArrayFlattenDIm!S;
  return *cast(Elem[dim]*)&source;
}
unittest {
  int[1][2][3] mdimSArr;
  mdimSArr.to!(int[6]) = [1,2,3,4,5,6];
  assert(mdimSArr == [[[1], [2]], [[3], [4]], [[5], [6]]]);
}
This was intentional. Why remove it?
Please use `popFrontN`, since it's shorter - either that or remove the popFront lines altogether and change the assert to

    assert(equal(odds[3 .. 7], take(drop(odds2, 3), 4)));

And then please rebase everything into one commit. After that, I think that it'll be good to go.
This is a direct copy from TimSort for Android. You can check the original code for detailed documentation:
http://cr.openjdk.java.net/~martin/webrevs/openjdk7/timsort/raw_files/new/src/share/classes/java/util/TimSort.java
Better use the UFC syntax and the short lambda notation, i.e. 

```d
assert(variant.visit!((int i) => i, strfunc) == 6);
```
Required for `Hash#symbolize_keys`
here it would make special sense giving this as argument; it don't think this should chance once created
right... spot the guy who doesn't work with video much (me) :-)
`_protect_identifiers()` was just renamed today: https://github.com/EllisLab/CodeIgniter/commit/032e7ea646b953a8f4d28327d7f487de2ffa7288
Right. Will wrap it with a check to see if the current annotationClass in the configuration object is "XWiki.XWikiComments". Thanks.
Should we stick a `max-width` here instead? If people have smaller screens it would be nice for the table to automatically resize itself. Perhaps add a `min-width` of ~ 200px?
the best thing would be to configure Propel to do that itself, Phing should not force this configuration, even if it was the best practice for years....
This method is to first try and compare the core types such as int and decimal. By default, IComparable.Compare(int, decimal) will fail. However if we cast it to the correct types, it works.
Non comprende
the master branch of the bundle is not compatible with Symfony 2.0.x so the doc in the master branch should not talk about Symfony 2.0.x
этот метод по идее не нужен, т.к. он должен быть вычисляем с помощью методов вида `person_identity_card_path(person_id, id_id)`
are you sure this is the correct default? what are the implications of client code thinking that something happened today when in fact no date was specified?
another tab here
Please break this out as a separate method inside the ctd_stream_publisher. I do not want the same code copied twice to do the same thing.
date filter form
Hi, Gary!

Need to update **Copyright**
All 5 comments are addressed and pushed
If this is the only thing, can you fix it during merge?
Actually I'm not sure that is true. It depends on the component I think.
Why can't you pass the DataList (unlimited) straight into the Paginated list (which handles the pagination). This seems to do work which doesn't need to happen.
Put each element into a new line.
(For students: unnecessary empty line.)
Can you involve this in a note?

```rst
.. note::

   <indented text>
```
trait にはメソッドコメントを書きましょう。
Could we update these to comply with the new styleguide?
Indeed you are right, I did not even realized that it would do a step for each servos,
I will correct it.
Oops, yes self._headers. Obviously having a bit of a fail on this today.



On 13 Nov 2012, at 18:09, ludwigkraatz <notifications@github.com> wrote:

> In rest_framework/response.py:
> 
> > @@ -20,9 +20,12 @@ def __init__(self, data=None, status=200,
> >          """
> >          super(Response, self).__init__(None, status=status)
> >          self.data = data
> > -        self.headers = headers and headers[:] or []
> ok - just double checking:
> 
> https://github.com/django/django/blob/master/django/http/response.py#L40
> the attribut used there is _header
> 
> I assume this header shall be _header as well? If not, I really dont get the purpose of this "self.header" attribute, because it does not do anything.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Ya but seems that on backend it doesn't make any effect
>  "return value" would be better than "return type". It's the value that is validated, not the type.

But then we need to talk about parameter value and property value and that's not what we want as we don't annotate values.
because i was using it wrongly and setTimeout fixed it. 
fixed my repo. thanx for the tip.
Please, check if System properties in text fields are resolved by Jenkins.
Correct me if I am wrong, but I think that:
<pre>
diag = (v_prime * Q**2).sum(axis=-1)
</pre>
should do the trick.
Don't you think it is sufficiently clear here? In the narrative it says that LinearSVC does "one-vs-rest" but can also do crammer_singer if you set the multi_class parameter accordingly. In the docstring it says that 'ovr' trains one-vs-rest and 'crammer-singer' trains something fancy that no-one uses ;)
Should we really be removing this comment? I recall you asking me to add it in.
This should be: execute "brew *upgrade* #{package} #{opts[:brew_args]}"
default value?
typo _pariticpant_
This line uses an array to pass the attribute that needs to be searched (not used for AD group membership checks). The reason for an array is because that is what in_required_groups? passes from the required groups configuration. I am not sure whether the values should be passed as an array or if there is a better way for the values to be sent.
How can we assume that image/png is the right mimeType? There are several different image types, PNG is only one
The event name to check
changed locally to use isEqualToString
no overwrites
I think there has to be something missing here.  When I run the tool, I get the links taken out, but none of the additions.  I.e. the hybrid/SmartStorePluginTest/res/drawable-hdpi/sf__edit_icon.png symbolic link does not exist in the repo.
add information here (or in `RegistrationCoreService#registerPatient()`) to describe the requirement of exactly one null person (A or B) in each relationship.
why did you remove language file?
Oh wait, this is a unit test. Nevermind.
Actually false, these are encoded to strings, so they come in as "undefined"...
ah thats a good catch, I didn't see that, I will integrate them all into the same test
@joncotton the rest of Armstrong uses the `tests._utils` approach.  We should stick with that since it's the established convention for the rest of the project.
Will base the debug mode on SCCC markup and css
The surrounding `if` is unnecessary. The comparison `(= (mod n divisor) 0)` already evaluates to the correct boolean value.