labofsahil/github-event-dataset-2012 huggingface dataset:
@wkerzendorf Huh, I didn't even know this `numpy.iterable` existed.  But after having a look at it, I can think of a few reasons not to use it:

It doesn't check for `collections.Iterable`.  Ideally, `isinstance(obj, collections.Iterable)` should be *all* that's necessary to check if an object is iterable.  But I've found some cases where falling back on `iter(obj)` has been necessary.  Regardless, `collections.Iterable` should be supported.

I think that `isiterable()` more clearly describes what it's checking for than does just `iterable()`.

I think it really should return True/False instead of 1/0, but that's a nitpick that shouldn't really matter.
You are correct, $argv always contains strings.
Why not just use isset() or empty()  Its unlikely that charset will be null.
testC (capital C?)
I correct this and rename all $number into $value
I personally have a preference for `event.azimuth !== undefined`. We don't need a `typeof` in this case.
Oh, I see.  So if we pass to JSONEncoder.default some object that it can't deal with, we can trust it to throw an exception that we know how to handle farther up the stack. Cool.
The reason why I moved this line into it's own development group (but not test), is that if we want to use travis-ci.org, they have specifically asked people not to include the ruby-debug gem, because it's dependencies take too long to compile and it isn't needed for CI. This isn't critical for now, but basically the idea is that we want the debugger on our machines, but not on Travis. Should be easy to achieve, but I tend not to use the debugger either way, so I don't tend to notice if it's working or not.
api.parse_ts
Did you check to see if this was possible via LibGit2Sharp, instead of using a shell command?
Will this work on all OSs? You open the file here, write to it in another process, and then read it here. I assume that works on Linux, since the tests pass, but I've no idea about Windows in particular. @jstenar : Do you have time to test?
Is it deliberate to allow both `ipython profile locate foo` and `ipython locate profile foo`? It seems kind of unpythonic to offer two similar commands for the same thing.
best not to catch Exception, rather some subtype you expect.  if you are unsure of which exception you will get you can catch RuntimeException.  best to do "throw Throwables.propagate(ex);" vs swallowing.
Bracket on it's own line and should be able to use `protected` here.
To be honest, I'm not sure whether the `strval()` is explicitly necessary here. For one, values that would cause errors shouldn't be passed to the `default()` function in the first place, and I'm not even sure whether any of them (objects, arrays) would cause errors when implicitly typecasting to strings (by concatenating them).
Since all of the cases where `format_object_header()` could have returned an error code are now handling by asserts, it should never fail (except by asserting), so I don't both to check the return value for < 0 anymore. Does that seem okay?
Oh, don't worry about it then--just leave it as is. I was just thinking it's a nice feature if it saves us effort. Stupid unittest.
置顶操作是在哪里做的呢？
Yeah you are right. Yesterday night my brain nearly fried trying to get this done ;-)

I'm glad you accepted the pull request even if it wasn't perfect. Thanks
We didn't cover this yesterday, but put `users` and `myAuthDB` in the same var statement.

The "one var per function, at the top of the function" thing is a javascript convention apparently designed to clarify some weird javascript behavior: http://stackoverflow.com/a/1236270

I've never gotten a clear answer on why it is beneficial to have only one "var", but it makes life in the javascript ecosystem easier so I just do it.
Probably should change the file name, too
Added comments to the `try`s to clarify this behavior.
Done, thanks for the feedback :)
It's kind of terrible because it seems PHP's configuration ini takes strings and casts them as required which is kind of nasty.  If you set something boolean when you retrieve the values you get back string integers on ini_get().  So the question is how much validation do we want, since these would have to be "integer strings" if you catch my drift. 

I think if Symfony2 doesnt allow `%string%` replacements for integer fields, then that's something that should be looked at quite honestly.
you are displaying too much things in the toolbar IMO. This is likely to make it too big
Yeah, thanks for the link. The parameters `absolute` and `relative` of ``generate` are confusing somehow. It might be better to combine them in one variable. But can we do it? It's taggedd with `@api`. But the current naming of the generate parameters are also quite confusing with regards to the RFC:
`absolute = true` means absolute URI
`absolute = false` means path-absolute

Maybe we should add two more allowed values to `absolute` = `relative-path` and `network-path`
Perhaps instead of DefaultRenderingStrategy this should be called SubrequestRenderingStrategy?  Since on many sites the "default" may actually be ESI/hInclude/nginx/whatever.
I think you have to set `self::$mongo` to `null` and skip in `setUp`.

Please:

* Once you are done squash your commits and follow the guidelines in the contributor guide for the naming of the commit,
* No need to comment "Done"... We receive an email each time ! thanks.
this is wrong. we don't want to display a list of constraint classes to the visitor seing a form error.
@hason Please read the full deprecation message: this feature is not reliable (and cannot be made reliable without rewriting the full Form building as children can be build before adding them in their parent)
I don't see the necessity to enforce this choice just to make testing easier. Simply extend a test interface if you mock it.
```
interface MockablePropertyPathInterface extends \Iterator, PropertyPathInterface
```
I think that this should be loaded by in the configuration file parser. Is the configuration file still usable?
The thing is the inflections have very similar pattern which is easily recognizable having all the words at one place... Though now that I'm thinking about it, a matrix would be even better :)
line 27
agreed, nice catch
I think the code of properNeighborhood should be inserted somehow here. 
Otherwise, you must create a small object, and then copy it in the output iterator.
typo: `MIPmip` -> `mip map` ?
Subtle difference from original: before we only called make_texturemap for valid formats, but now we fall out of this switch block and call it with the default conversion mode of MIPMAP. Should we exit with EXIT_FAILURE in the non-implemented branches instead?
Got it. Yes, implementing this for the PUT call makes sense. Will do.
Nitpick: Perhaps checking the cause for a BindException first?
Should probably have a serialVersionUID
We need to have a top-level `package.json` file that references Mongoose as a dependency if we are requiring it here.  Please add that to this Pull Request.  You can fill in minimal metadata for `package.json`, just the bare minimum for this dependency is fine.
Anything we can do about that? Will this get fixed in browscap at some point?
хрен его знает. У нас как-то выходит что GroupPermissionService управляет правами топика, а TopicPermissionService - правами комментариев :-)

Можно переименовать, но давай потом отдельным патчем
если будут вопросы, я подмогну.  02.10.2012, 16:32, "Maxim Valyanskiy" <notifications@github.com>:In src/main/java/ru/org/linux/site/Template.java:> @@ -245,6 +245,20 @@ public String getNick() {
>        return currentUser.getNick();
>      }
>    }
> +  
> +  public String getRemark(String otherUser) {
> +    if (!isSessionAuthorized()) {
Не знаю, можно засунуть куда-нибудь вроде PreparedTopic/PreparedComment. Тут @hizel уже подготовил патч который Template совсем удаляет как класс, так что в него не надо ничего добавлять…On Sat, Sep 29, 2012 at 11:26 PM, Yury <notifications@github.com> wrote: In src/main/java/ru/org/linux/site/Template.java: > @@ -245,6 +245,20 @@ public String getNick() { > return currentUser.getNick(); > } > } > + > + public String getRemark(String otherUser) { > + if (!isSessionAuthorized()) { хм. тут подумать надо, куда сохранять. — Reply to this email directly or view it on GitHub<https://github.com/maxcom/lorsource/pull/336/files#r1723788>. — Reply to this email directly or view it on GitHub.-- тех. конс.
на тестовой базе проблему можно тут увидеть: http://127.0.0.1:8080/news/hardware/1948091
Let's remove this method. It seems a bit overkill.
Remove L12 to L14. File an Github issue and Bugzilla issue for the fact that we cannot turn off/on Geolocation in Gaia (coordinate with @fabi1cazenave)
didn't want to break the tab separation for screens by moving the code to another section
nit: give a name (no more excuse now that there is built-in profiler that show Anonymous!)
I think this line would be clearer if written like this:

  self._favList = value || {};
ok. :-)
doesn't an empty "it" automatically become pending? or is the preferred style to actually say "pending" instead of "it" at that level now?
Hey, it's alright! This will make the code look much cleaner for sure.
FYI, Oscar had suggested this be called groupByFn. I can do this if we still want to and think this a more appropriate name.
Uppercase...
well, as you are mocking functions, couldn't you mock extension_loaded too and be done with it ?
Ooooh, that makes sense - these are all things that @iguananaut added, I think as a part of astropy.io.fits, so that's why I didn't recognize them.  So ignore this - sorry for the noise!
In fact, one can fix this to not polute the global environment by doing
```python
self.patch(os, 'environ', {'TEST_THAT_ENVIRONMENT_GETS_PASSED_TO_SUBPROCESSES': 'TRUE'})
```
(see https://github.com/buildbot/buildbot/pull/454/files#L0L131)
Already updated here, @lorenzo.
Done. I amended my commit.
Yes, I abort if ``signing`` is on and no ``VERSION_TAG`` is provided. Otherwise, the ``VERSION_TAG`` is set to  ``local``. This is to prevent forgetting to pass ``VERSION_TAG`` when building a release.
The two variables should allow authentication for Delta, Cypress, etc.
3 posts looks better
I ran gitlabhq in development mode with a gitolite install to test this behavior by hand and it appeared to work. I prefer to have automated tests. I mentioned in the request that I was having trouble writing tests for this and requested help.
Why is this needed?  Also, for S3 object, you should use `inherits`, not `is`
maybe this can be wrapped in "unlikely" macro
```#include <assert.h>```
I believe it would be best not to include it, since it is the GELF spec version.  That version number would be determined by the sender of the GELF message, in this case it is the GELF output module sending GELF version 1.0 data.

-Jeremy


From: Jordan Sissel [mailto:notifications@github.com]
Sent: Tuesday, September 04, 2012 9:53 AM
To: logstash/logstash
Cc: Jeremy Einfeld
Subject: Re: [logstash] Correction to GELF forwarding (#194)


In lib/logstash/outputs/gelf.rb:

> @@ -39,6 +39,16 @@ class LogStash::Outputs::Gelf < LogStash::Outputs::Base

>    # is useful if you need to use a value from the event as the facility name.

>    config :facility, :validate => :string, :default => "logstash-gelf"

>

> +  # The GELF version designator. Dynamic values like %{foo} are permitted here.

> +  config :version, :validate => :string, :default => "%{version}"

> +

> +  # The GELF line number. Dynamic values like %{foo} are permitted here, but the

> +  # value should be a number.

> +  config :line, :validate => :string, :default => "%{line}"

Maybe make this have no default, and only use it if specified?

—
Reply to this email directly or view it on GitHub<https://github.com/logstash/logstash/pull/194/files#r1524807>.
**Side comment** This is not quite I meant in collections proposal what I meant to preserve semantics of the original collection.
So it would me something like this:


```js
function reducible(reduce) {
  return Object.create(reducible.prototype, {
    reduce: { value: reduce }
  })
}
reducible.prototype = {
  map: function(f) {
    var source = this
    return reducible(function(next, start) {
      return source.reduce(function(result, item) {
        return next(result, f(item));
      }, start);
    });
  },
  filter: function(predicate) {
    var source = this;
    return reducible(function(next, start) {
       return source.reduce(function(result, item) {
         return predicate(item) ? next(result, item) : result;
       }, start);
    });
  },
  // Rest of the array methods ....
}

function enumerable(enumerator) {
  return reducible(function(next, start) {
    let state = start
    let elements = enumerator()
    while (elements.hasMoreElements())
      state = next(state, elements.getNext())
    return state
  })
}

function domWindow(window) { return window.QueryInterface(Ci.nsIDOMWindow) }

var windows = enumerator(windowWatcher.getWindowEnumerator)
   .map(domWindow);

```
Also please make sure to Proxy handler code to use `method(branchName + pref)` instead of `Branch.method(branchName + pref)` or `exports.method(...`
I moved this code to tabs/utils and merged with the similar method in tabs/tab.
likewise, I thought this parameter was going to be called siteName
``{{ _('<a href="{0}">Ugrade today</a> foobar')|f('http://...') }} should work, if I make a format helper "f" for you. Key is to not rip sentences apart because that won't work for localization.
Not just `browser.js` but other functions in
@dbussink I took a look at this, but I don't think it's possible to check the encoding only once. If in the comparison are only ASCII chars, it will take the encoding of the first string. Basically it works there. But if it tries to figure out which encoding should be used on two non ASCII compatible strings, it will throw an error.

Here the results of my performance tests:
```
without fix
$ ./bin/benchmark -t ./bin/rbx benchmark/core/string/bench_gsub.rb 
=== ./bin/rbx ===
                lots    14663.3 (±2.4%) i/s -      74100 in   5.056604s (cycle=1235)
           lots - ()    17249.8 (±0.9%) i/s -      86240 in   4.999904s (cycle=1568)
                 one   788884.9 (±0.5%) i/s -    3967584 in   5.029506s (cycle=35744)
        one + newstr   698025.1 (±0.4%) i/s -    3498294 in   5.011787s (cycle=34297)
          match_from  1737102.3 (±1.0%) i/s -    8656632 in   4.983893s (cycle=47304)

$ ./bin/benchmark -t ./bin/rbx benchmark/core/string/bench_gsub.rb 
=== ./bin/rbx ===
                lots    14878.2 (±2.6%) i/s -      74700 in   5.024285s (cycle=1245)
           lots - ()    17379.7 (±1.0%) i/s -      86912 in   5.001324s (cycle=1552)
                 one   871270.9 (±0.8%) i/s -    4348296 in   4.991105s (cycle=35352)
        one + newstr   763845.9 (±0.6%) i/s -    3813040 in   4.992095s (cycle=34664)
          match_from  1777566.0 (±1.2%) i/s -    8860775 in   4.985477s (cycle=50633)

with fix
$ ./bin/benchmark -t ./bin/rbx benchmark/core/string/bench_gsub.rb 
=== ./bin/rbx ===
                lots    14502.7 (±4.9%) i/s -      72660 in   5.023241s (cycle=1211)
           lots - ()    16859.0 (±0.9%) i/s -      85030 in   5.044060s (cycle=1546)
                 one   849812.5 (±0.4%) i/s -    4270734 in   5.025567s (cycle=36502)
        one + newstr   765136.4 (±0.7%) i/s -    3828944 in   5.004492s (cycle=34187)
          match_from  1780676.3 (±1.1%) i/s -    8895600 in   4.996242s (cycle=49420)

$ ./bin/benchmark -t ./bin/rbx benchmark/core/string/bench_gsub.rb 
=== ./bin/rbx ===
                lots    14167.7 (±5.0%) i/s -      71309 in   5.048772s (cycle=1169)
           lots - ()    16596.5 (±1.1%) i/s -      84336 in   5.082183s (cycle=1506)
                 one   830846.5 (±0.8%) i/s -    4179120 in   5.030255s (cycle=34826)
        one + newstr   740366.5 (±1.1%) i/s -    3718680 in   5.023382s (cycle=32620)
          match_from  1699596.6 (±3.3%) i/s -    8503018 in   5.008466s (cycle=46978)
```
If you're going to spec there then use the `:: type()` convention.  E.g. https://github.com/rzezeski/yokozuna/blob/master/include/yokozuna.hrl#L25
This is only used in Line 200 of the TMKM, so it can probably just be changed there and removed here. Or, even better, there could be a "debug" flag in the config file that takes care of setting a bunch of different debugging / logging options. But that probably should be a separate PR.
can this be `_.size(foo) > 0` ? would be more obvious for me
this all seems too large we should be able to make this a pretty small solution
Leaving it as-is, I'm still curious how DateTime instances should be converted for the DB and ZendMonitor writers.

What is the typical timestamp column type for DB writers?
Right, I discussed with @EvanDotPro - I see whats going on.  Basically, we shouldn't be iterating $this, if we want raw values.  We should be iterating the datasource.  When iterating $this, current() is called, thus the hydrator is used.  I don't think this is the desired behavior, or, if it is, it needs to have a special flag.

We need to update this PR such that it will actually return unadulterated raw values from the datasource instead of passing through the hydrator.
This class should be imported
Can I just write 5.3.3 along with 5.3 (add a version to be able to also always test latest stable 5.3)?
Why limiting the check for two words here?
Combine getValue and setValue into single 'value' method which switches on whether there is an argument provided.  If argument provided, set and return 'this'
Your ``dry-run`` option is missleading as it will give you the command to create Solr even when it is already running. (the next check should be moved first IMO)

Thus, the ``dry-run`` option generally means that you display what the steps of the command without acutally doing them. Here, it is different as you are dumping the command needed to do the job by hand. So the option should probably be renamed
and you should switch to the composer repo maintianed by ZF: http://packages.zendframework.com/
would like a combined if better than a if without brackets leading to a long if
This method is mis-named. It should be called `fetchBy()` or something similar. I don't mind the idea, but its function signature should be:
`protected function fetchBy($select)` in my opinion.
Ah, yes. I didn't look far enough for an osx method. I'll switch it out.
You have extra spaces between the end of variable name and the `=` sign.
you should do the ``key()`` call only once IMO; and I would use ``isset``
LdapFilter instance (definitely through derived class)
use CAPS for constant dict
s/Bedrock/the Bedrock
This should be in the `vouch()` method I think. Makes sense to keep it with the model. Possibly in a signal.
Are you asserting that the length of the set of fields is less than or equal to? I'm not 100% sure what `<=` does on two sets. Does `==` compare sets memberwise?

And you don't need the `()` around the message (only need those if it's going to wrap to a new line) but a `.` would be good.
You're duplicating a lot of tastypie code here, which might break if tastypie changes their implementation.

You should've used `super` instead:

```python
def get_offset(self):
    """Limit offset to the total number of objects in the database to avoid ES crashes."""
    offset = super(self, Paginator).get_offset()
    return min(self.get_count(), offset)
```
You should add the expected number of passes here
I know this makes it a tiny bit awkward but perhaps it'd be best to pass the `WriteError` instead of the raw `err`?
This is confusing having both an `additionalAttributes` and `addAttributes`. In addition,  `addAtrributes` sounds like a verb, not a noun. Beyond just renaming the var, this probably should be rafactored to have the injection of both kinds of additional attributes be cleaner. I know the original code was a bit messy though :(
I guess I really don't understand your question.  Can you provide the code lines you are questioning, and what the effective difference of the method you are suggesting is?

To repeat what I said above, changing the power state of an instance is the same as editing any other attribute of an instance.  And when the power state changes, the foreman database needs to be updated, as same facts about the instance will change.
Seems like every time you do something in this method you return without calling this, but every time you do nothing this is called. What is the reason behind this? Seems like you can get multiple watchers, unless the exists-method of ZooKeeper handles that allready.

Anyway, it would be good to leave a small comment here inform of why you have to "reregister" a watcher.
Perhaps it'd be better if I made the ``Trade.MaximumTradeTime`` el. al. ``internal`` so they cannot be set outside of the ``SteamTrade`` library. This would force users to use this function or accept the defaults by not using it. and it would simply the Trade interface.

This is in effort to make the ``Bot`` class simpler like [so](https://gist.github.com/4170662).
Breakage of component inclusion paradigm.
Yes, you are right, I added primary color there.

I am still concerned about overwriting variables. Our goal is to unify all elements not just shapes but colors as well. For example primary color shouldn't be overwritten, because it's given and changing it would lead to the same. And this applies also for button colors, form colors, etc.
nit picky but we indent one further if under a private or protected block
gonna highlight this one in the patch notes
Use GUIDs instead.
I think a "the" is missing.
where would something like "rich" be defined?
Are you expecting `metadata_for_file` to be a public API? Maybe for extensions?
details_page.license_faq_click() can change to details_page.license_faq.click()
We should replace the print with something else. Maybe a try catch.
Awesome thank you :-)
Should we validate that it is an integer?
This should probably be a util function inside of user.ap.js.
This can use cassandra.createColumnFamilyIfNotExists
Can reduce to `cacheFile(path, callback)`
Actually, this is not needed.

The reason is that when creating a p2 repository the version suffixed to the JAR's name is the one declared in the MANIFEST, under ``<Bundle-Version>``. The above declared ``version`` is never used. I've removed it from the POM in a follow-up commit eb37bb587578af866f12d28d78c6ed410687b50f (just pushed).
If I remember well, the prefix is only `foo`, even if the user types `this.foo`.
Yup, I'll do that during the next few days.
No hurry :)
We should migrate it slowly to sf2 coding standard.
:+1:  `http://www.geoplugin.com/`
A static method is one which is declared static by using the word static `public static function foo()` and usually should be called using `::`. It might not matter in this case. Can you email me please drak at zikula dor org?
As per Dave's comment, this should probably be:

```python
try:
    import bz2
except ImportError:
    bz2 = None
```
This item is the last in the list, so no comma goes after.
slowdown als hij hem niet spot. als hij hem wel spot is maxVel namelijk 200
Also add space after foreach
`false` -> `FALSE`
Нет проверки, действительно ли мы изменили значение ячейки, и не оптимальный алгоритм мутирования. Проверку добавить стоит, алгоритмы всякие разные изучить - тоже стоит.
Точнее, 33 клетки.
Более того, ваш алгоритм изменяет клетки, стоящие на строго определенных шагом позициях. 
А нужно, чтобы позиции мутирующих генов были случайными.
1) count перемення для всего класа.. Что бы каждый раз не обявлять новую..
2) Исправлю
3) Забыл удалить
4) Исправлю
В любом случае спасибо, что многое разьяснил. 
Вот смотри, использовал я @throw и в итоге получил такую картину: http://d.pr/i/AzSt - а хотелось бы, чтобы пользователь просто увидел сообщение об ошибке без всяких отчетов с адресами памяти.
А в идеале, чтобы программа ему предложила ввести другое корректное значение.
Неправда, Objective-C только выделяет память под массив, но не инициализирует его
Вообще, как делать, ваше право, но мой совет: старайтесь писать наиболее адаптивный код. Программирование для того и было придумано. Сегодня у вас можно выбирать из 4 символов, а завтра из 20 - что ж теперь, весь код "лопатить"?

Особенно это будет проблемно в больших проектах, где классы гораздо больше, и самих различных классов гораздо больше. Если сразу не привыкать писать адаптивный код, то вносить изменения в проект будет очень и очень трудоёмко.
Нарушаем инкапсуляцию, нехитрые манипуляции позволят изменить значение DNA, и объект не будет об этом знать.
у вас может получиться так, что новое значение элемента ДНК будет совпадать со старым, т.е фактически мутации никакой не будет. 
Если следовать вашей идее, то я бы добавил вверху переменную NSString перед серией проверок, в которую бы записывал значение A, T, G или C, а тут перед реплейс сделал проверку и если новый элемент == старому, то тоже делать i--;
Sure. I'll get right on that.
Oh. I do see cef_data, but only on the mac side: ``/Users/jasonsj/Library/Application Support/cef_data``. Let's change this back to cef_data but add the "Brackets" folder. I'll fix the windows code and the readme file and update this pull request.
In HTML, this is migrating to the top of the `<t>`.
`unlikely`
I think we can do without the collection names. ODM will use Offer by default, and `BaseTest::tearDown()` drops collections between test cases.
Actually I was not sure if it was okay for the keys generated by computeJFKsharedKey to be used to generate SecretKeySpec. I think there was a discussion on whether some of the keys were weak. 
So I left the keygenerator code commented. They can be removed.
Right right, good call :+1:
`util` comes with node so isn't required here.
Is this a general purpose method to check for duplicate names, if yes, then it should only check for duplicates in the passed in locale and not the broader one
You are right that using b will not handle MBCS, but for validating minimum length of a password field I think that is ok.

The spec would be:

    valid_password(X) when is_binary(X) andalso byte_size(X) > 6 ->
        ok;
    valid_password(_) ->
        error.
            
    {fun_match,
     {fun valid_password/1,
      string, <<"password must be at least six characters">>}}
In order to do something after the enumerator is finished, you need to do something with the `Future[Iteratee]` that `|>>` returns.  The `ChunkedResult` case class however accepts a function of `Iteratee => Unit`, so it ignores the return value of applying the enumerator to the iteratee, therefore by design, it can't do anything after the enumerator has finished.  The only way to communicate that the enumerator is finished is to send an EOF.

But this is exactly what the iteratee is expecting, if you look at the code in PlayDefaultUpstreamHandler, you'll see that as long as the client stays connected, the iteratee will only enter a Done state when it receives EOF:

https://github.com/playframework/Play20/blob/master/framework/src/play/src/main/scala/play/core/server/netty/PlayDefaultUpstreamHandler.scala#L236

And the last chunk is only sent when the iteratee is done:

https://github.com/playframework/Play20/blob/master/framework/src/play/src/main/scala/play/core/server/netty/PlayDefaultUpstreamHandler.scala#L249

So I think it's perfectly fine to send EOF, isn't that what EOF is designed for, to let the iteratee know that there's no more input and so it should finish up?
Changed to action.
What does this do? It's not used anywhere.
``Translating``
@weaverryan I see your point, but the `...` 'symbol' means some sort of fold. I think 9 of the 10 examples with folds in it in the documentation do not work.

I have done this change because you don't fold a line, but a part of an array. If this array was less extensive we use the `...` without a comment:

    array('foo', 'bar', ...);

I think we should be as consistent as we can in code, when we don't use a comment in one-line-arrays we shouldn't use it in multi-line-arrays.
Can this just be `t(".introduction_paragraph")`? Do we frown on that? Same for the other `t()` in this file.
In the actor-editor `this.country` is used in order to create new actors in the correct country since it was just the abbreviation String before. Now it's a model and so you also have to change the actor-creation part: https://github.com/transparencyint/CGIP/blob/4ae09f2efc118b1dee2895dbd52686f9783f626d/app/views/actor_editor.js#L202
I was thinking some people might point at different proxies depending on where their server is started, but removed
A bit too magic for me, what's it used for, why isn't it pulled from the config?
I am sorry, I must have missed that from @tfotis's commit, I will ask him to also add docblocks.  They are required and as I said, someone will  have to do them.  If you use beans just adding /**(return) will start the entire docblok - it doesnt take a couple of minutes to do.
`std::swap` для девочек, понимаю.
Пробел лишний перед `&`.
Imaginate que en lugar de:

   @Html.HasActionPermission("GenerateOrder", templateGigante)

pudieras hacer:

    @using (Html.BeginPermissionTrimming("GenerateOrder")) {
        // template normal
    }
I wanted to give you chance to get credit for your work...

I left a comment in the pull request thread asking to split up your pull request so I 
can bring in some of your changes
would change this
Instead of defensively checking for nils, you could:

```
  @color = attribute_hash.fetch(:color, "").downcase
```
What do you think to replace 
,,js
if( this._isTouchEnabled ) {
    this.setTouchEnabled( false );
     this.setTouchEnabled( true );
 }
,,

to
,,js
if( this._isTouchEnabled ) {
   cc.Director.getInstance().getTouchDispatcher().setPriority(priority,this);
}
,,
?
The output of `#inpect`used to be gigantic
should we default the url to this? i guess for dev environment it would be ok. But if others were running this and expect that the service catalog will have the endpoints.
Why Serializable? It should marshalled via an externalizer...
the one in eclipse
Not used, remove
self.report_disconnect() gets called in run_tests() as I have mentioned before. Please check:
https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/__init__.py#L374

run_tests() handles each JSBridgeDisconnectError around the self.run_test_file() call. It doesn't re-raise this exception. In run() we have another `except JSBridgeDisconnectError, e:` statement and try to handle it again. Exactly that makes no sense because we would never reach the code in except. If it would handle another exception it would be fine but not that way.
cool, then document this :-)

On Tue, Aug 7, 2012 at 11:15 AM, François Thillen
<notifications@github.com>wrote:

> In testproject/ETMTCP/ETMList.cs:
>
> > @@ -0,0 +1,235 @@
> > +﻿using System;
> > +using System.Collections.Generic;
> > +using System.Collections.Concurrent;
> > +using Protocols;
> > +using System.Collections;
> > +using Protocols.ActiveMQ;
> > +using Apache.NMS.ActiveMQ.Commands;
> > +
> > +namespace TCPHandling
> > +{
> > +    /// <summary>
> > +    /// New List, which overs the possibility to pars the elements
> > +    /// </summary>
> > +    class ETMList : IList
>
> Well I need a special list, this list takes into account, how often a
> elements has been chosen and always returns that one with the lowest
> numbers. This could be done without an own list but it makes it readable
> and I have less code.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/23/files#r1319268>.
>
>
1.7RC2+
"espace**s**"
This adds scrollbars to the main page actions, as well as the page filter actions. Can't use this alongside overflow: auto, please revert and find a different solution (not sure what you're trying to do heh)
I would write this as `$dropdownField->setDisabledItems(array('US', 'GEM'));` so it's tidier, and the syntax aligns with the rest of the codebase. The same applies to other changes made in this commit, where whitespace is included around the brackets.
Nit: `0` with units
Better to use a higher specificity than to use `!important`.
Nit: you don't need to specify units when value is `0`.
I've pushed the change I meant.
One of two callers of the new functionality in __rec_page_modified/__rec_page_deleted, using the WT_REF.addr field to decide if the page is really gone and no cell needs to be written.
actually, this should be broken up to not be one long line. if you need to, you could do something like:
\<textarea class="flat big" placeholder="Enter featured text using markup"
                 name="text"\>{{ form.text.value }}\</textarea\>
Are you sure ``$exception`` has the correct type as "object<Exception>" is not a sub-type of "string"?
Are you sure the method ``validate`` can be called on ``$this->validator`` (of type "object<Symfony\Component\Validator\Constraints\CardSchemeValidator>|null")? Please also check line 48.
Will this work across browsers? In other words, how with this code can I get the text of the selection? Above I see a feature check, but are the objects totally different in IE compared to Chrome and Firefox? If so you might want to put those examples in the getSelection docs.
Ok, maybe add a todo to move it later?
Can you change the method name to `leader_at_in`? This is consistent with the behavior of the method where you'd only ever return a single member from the leaderboard.
`delegate` is not synthesized so that when a delegate is added, all existing serial ports are checked by the delegate to ensure that they match the delegate's rules for managing the ports.
Библиотеки должны лежать в корне или в отдельной директории — уровне, чтобы они попадали в инстроспекцию всего проекта (которую мы сейчас пишем)
Das muss unbedingt wieder entfernt werden, wenn das Ding deployed wird... So wird bei jedem Start die DB neu erstellt.
Hol dir den Typ nur einmal raus und prüfe ihn dann auf null.
Sorry, I am interested as to the reasons not to accept raw/json as options, and cant seem to find the issue you are refering to - except for a comment by you that it could be somewhat annoying to have to change the config before each call to `$.cookie` if you are using both methods or mixing code with other people and so cannot be sure of the global options.
Personally I would tend to avoid a global option as it makes code less reusable.
just fixed that on https://github.com/jnunemaker/mongomapper/pull/482
Could this be replaced with a foreach ?
Ditto on other methods.
These fields should also be `final` to prevent reassignment.
Quand j'ai fait l'extraction git, le répertoire admin/cache étant vide, il ne me l'a pas créé, j'ai donc eu des erreurs à la récupération des flux puisque le dossier n'existait pas. Une technique quand on veut garder un dossier vide est de mettre un fichier vide dedans, c'est ce que j'ai fait en ajoutant le fichier admin/cache/.keep. Ensuite, il faut bien sûr l'exclure du gitignore.

Si la méthode ne te plaît pas, je peux supprimer ce commit, qui n'a pas grand chose à voir avec PGSql...
No need to prefix with `horoscope_`. It is quite obvious.
I can still see in the pull request!
WHAT IS THIS?
No need for this in final code.
You still have unnecessary new space at the end of this line.
Generate DOM fragment using jQuery and build it together, don't blindly concatenate things together. Who will escape things in such case?
Hm, but markup plugins can also have child plugins (embedded) which can be image and so on. But OK. They will just not be rendered properly, but with an warning. OK.
standard is to lower case this.
Does `APPLE_GCC` force it to use gcc? What happens if the user requests clang (or if clang is the default)?
Ok. got that. Fine.
But it's generally it's better to have the folder structure seperately in an array or something, leaving 'afilename' for just the filename, since if by chance a '/' creeps into the filename, there'll be an IOError as that folder was not created.
sorry,but i don't follow.
what exactly should i do?
i mean i don't know yet how and where to make a generic spellscript.
`waitHandles`
Not going to merge in a single white space change.
This is so that CMStore can see the internal properties of CMObject, so that it can modify them. The only other solution to this that I can see would be to have a separate, private CMObject header.
I tried but it is not going unnoticed ... ;-)
Rather than doing all this data processing here in the initializer, I would prefer to make `Request` and `Response` real classes and just define methods on them. So `Request` and `Response` would each have a `@data` ivar and methods that read from it. E.g.

``` ruby
class Response
  def initialize(data)
    @data = data
  end

  def status_text
    @data['statusText']
  end

  def time
    Time.parse @data['time']
  end

  ...
end
```

I find this to be much simpler than the current approach, even though it's a little more verbose. (simplicity > brevity in my opinion)
это не конструктор, а инициализатор. Конструктор - это __new__. Кого-то в prom.ua плохо собеседовали ^_^
Can you also add a docstring here? What's the difference between this and ClusterController for instance?
I'd recommend using ssh_server for clarity. Also I am not sure but the indentation looks wrong. Make sure your editor replaces <tab> by 4 spaces
I think this is already renamed in other places?
One takes a request and the other takes configuration info.
Alas, yet another trailing newline.
You're probably right. I didn't think about it too much.
Server can handle it. When node reads the headers, everything is lowercased.
You can combine imports.
Why is this present?  It seems like a leaky abstraction.
Accurate for you, not for me, as the pig's ear / dog's breakfast of style in OpticalPSF attested! :)
The code that follows gets repeated as a block many times.  Would maybe be neater to define a function for this calculation, that takes a GSObject and a radius to which to integrate, and returns the flux within that radius?
What's wrong with '==' method?
I think going forward we should provide our own submit button instead of having that come out of the database HTML.
We should add another tag for the confirm link or we should add this automatically,

I think <link> is for the video link
Or even a new  EntitiesSafe.invokeXxxx which swallows the exceptions ?
Typo / process noise in file.
This should be `cocoa.id` or `id`, not `objc.id`. And it should send `value.id` to the `objc_msgSend_bool` function.
A bigger flexibility would be let the column to be nil. If you add a
constraint at the database level, it should have the default value there.
Nit: Unindent close brace.
Isn't reportCreated() already called by ListeningRoom::create()? (see my comment above)
No need for this, I believe. We store each granularity in its own collection, so you can just specify start and it will automatically only those entries you want.
Thanks for it and shame on me.
For /strangerock/New()

Because acid melts strange rocks, made it so the method var is always 0, meaning fire can harvest bones and such from them. method needs to be renamed to something more clear.
this is only known if player has PM with us.
I'd go for just removing these deprecated methods. Would you move `setStepDataKey` and `getStepDataKey` up to where `setSessionDataKey` and `getSessionDataKey` were placed originally?
Нет. Только сейчас заметил ошибку. Там кидается null interface и до вызова throwException дело не доходит
Это совершенно нечитаемый код. Надо использовать Enum/EnumSet или класс с boolean-полями.
Пробелов не хватает.
На просмотр каждого предка ты делаешь лишний substring
Аааа, ну так вот где баг. List может быть немодифицируемым. Т.ч. неправильно получать из первого targets экземпляр - и добавлять всё в него.
Ah, I see. It is destroyed by the inspector.
Sufix with `_locator`
Again, remove debugging.
start the arguments in the next line and a tab
Is there a way to exit out of a generator somewhat gracefully? If so all the if options[:template_*] can be removed if we exit on def error
Done cbed471d8c3c962fbf5c2111abab1b906602a248
Maybe reformulate to "If labels are not binary, pos_label.."
It might be better to change the default value but that is a tricky API change. A comment is enough for this PR.
I feel this method is the predict and the decision function should be just `np.dot(X, self.coef_)`
This should be an `n_samples` array in the binary case. Same goes for `predict_log_proba`.
To be consistent it should be called SGDRanking

I like the idea to have a separate estimator as the default score can now be kendall tau. Otherwise the score func depends on the loss. Just thinking out loud...
"i.e." => "e.g."  or "for instance".
these are not used any more, right?
cool idea! maybe you should specify how and when the character would check if he can perform an action? where would that check be used?
L. 110 is a duplicate of 104 which is still in, so removing 110 should be ok, no?

I'll get some more padding/margin onto that. I thought it looked a bit tight but I didn't want to mess with it at first.

Thanks for the feedback.
@netaustin did you test this thoroughly? seems like the sky might fall on our head.
The function still has to be pure, no?  Was this check moved somewhere else?
Should be `PROP_GETTING_FUNCTION(getRuntime);`
update the apidoc to say this isn't supported
This description should be more along the lines of what is done for the other platform.  Specifically for the switch, the main difference among platforms seems to be the support for associated text with the switch.

So the description needs to cover that, does the BB toggle button support associated text like android and mobileweb or does it not, like iOS?
Interesting. May be we should add support for defining haml/erb templates in the assets folder
I understand what these two gsubs are doing (here and line 61), but I'm left with no clue as to why. No tests failed when I removed them. Can I suggest either wrapping the gsub in a method that describes why/what it is and/or a test that shows what problems they solve?
Comments work too!
Crazy monkey patching.  Turns out, making changes to `UserChangeForm.base_fields['email']` get ignored.  They need to happen after `forms.ModelForm.__init__`.  So there it is!

Hacky, but actually very straightforward.  Thank you Python object model!
Actually these don't have much in common - only the main report_index page needs all this stuff, the others I will strip everything out of.
Shouldn't that be `{% if os_name is None %}` or better `{% if not os_name %}`
I like it! Much better than that silly hidden variable.
Why did you change this line?
That would be great.  I wasn't sure how to inherit configs.
i have to admit i didn't think about that
Note that I just implement API that node provides today and they export all these names, event though only document one. I though it was good idea to do the same so users can reuse libraries written with node in mind. But I can be convinced to export only documented names.
Changed this to NON_WORD_DIGIT and removed my comment.  I think this is a little better.
Hamcrest always comes in handy
Wow, is there really a field in LDAP called "l"? Satan himself must have designed that schema...
`.forEach(function( chapter ) {`
this is not what I meant when I said do it in a helper. this just moved code.

Pseudo code for what I have in mind:

  view: <ul> + @issues.each { |issue|  <%= issue_link(issue) %>}  </ul>
  helper:
  issue_link(issue)
   if issue[0] == CVE
    content_tag(:li, link_to...
  else
   ..
  end
Could you name It: propel/sf-propel-orm-plugin
I'm tempted to suggest there should be another shell_command_token() to check if the file actually exists or not. But we almost never do that in modules, either.  So I don't know, up to you.
This is a classic error introduced by copy-paste.

# The following returns :foo
def foo
  return :bar
end

Take a run at these comments and make sure they all make sense, because when generated docs roll around for all these handlers, it's going to be super confusing when all the comments are lies. :)
This looks like a typo.  "rapid7/rapid7metasploit-framework" should be "rapid7/metasploit-framework"
What happens if you call `_central_moments` with a (0, 0) center? Is there a significant difference in timing?
'text' is the default and should be omitted.
I chose `BoundingRectangle` because you can create one that contains a list of points or an extent. You could ask the same thing about `Sphere` versus `BoundingSphere`. I do like just `Rectangle` better (and its less to type), but that isn't consistent with `BoundingSphere` and `AxisAlignedBoundingBox`.
Beyond optional parameters and performance aside, object literals create self-documenting code.  I would even make @shunter's rule of thumb more aggressive - if it is not obvious what the function arguments are when looking at a function call, they should be an object literal.  Readability like this lowers the barrier to entry and helps adoption.
Are you talking about when we runs Auths in Payflow and the data is captured by Litle to tokenize the card?

In that case I think we need to pass the ```user_id``` in the order field as defined by Payflow.

is there something else I'm missing when we use Litle?
Due to what appears to be a Android bug with filters, my previous suggestion will not work overall.  Disregard previous comment.
They're actually generated during the *module* build+packaging process.  An external "native" module that has any JS files in its assets/ folders ends up with one of these.
You should be able to use "var img" here, or "var img = query('img.orig');" if you need to be more explicit.
Ok, I'm done reviewing.
0.7 is out, I think.
Ok, I'll fix my mistakes, thank you
I think that there's certain methods — especially in older classes which which existed pre Objective-C 2.0 — that while not declared using `@property` can fairly be thought of as properties. The technical syntax of `@property` (which are just representing accessors after all), and the intention of dot syntax are totally separate in my mind. Of course there's room for interpretation.
Instead of getting a random key, why don't you test that all of them work? Plus, vary the values of the object's attributes so that you can test more than just numbers.
Даже не знаю как сделать. Если отдавать строки "image loading error" и "no area selected". И программист захочет выводить свои ошибки (или как-то еще менять поведение при разных ошибках), то ему придется сравнивать со строкой, что выглядит как-то опасно.

Сейчас есть две ошибки:
 - картинка не загрузилась
 - вызвали `forceDone()` до того как картинка загрузилась

В `$.ajax` хоть и строка, но там 1 слово — типа тоже id. Не могу придумать в одно слово для наших случаев.
Technically, you also need to check that `hasLength!Range2`, in the odd case of `isInfinite!Range2`. Infinite ranges *can* be random access, and slicing and infinite range (while a strange notion) is legal.

FYI, I am writing a `isDroppable` interface which would allow a less restrictive "slicing to end" functionality, but it is not ready yet.
Related, this kind of opDollar verification feels like it should also be added to isRandomAccessRange, no?

```D
static if (is(typeof(r[$])))
{
    static assert(is(typeof(r.front) == typeof(r[$])));
    static assert(is(typeof(r.front) == typeof(r[$ - 1])));
}
```
Thoughts?

It's related, but it's a stand alone change, so I can do it if you don't feel like weighing down this already long an important pull.
Explain why you are doing this, because it looks crazy! Maybe even make a utility class that can convert an iterator to a list.
Note: I'm still following plymouth-webapp on Github, so I saw this conversation come through my email :)
oh right, thanks for noticing that
`isset($name)` will always return TRUE, unless you pass NULL as it's value and `! empty($name)` basically evaluates as `isset($name) && $name != ''` anyway ... you don't need `isset()` here.

Also you should have a space on each side of the exclamation mark and one after `if` as well.
Might be a good idea to move the comment on the previous line too, I doubt that anybody in our days would be reading that with a 480x320 resolution, but it still causes a need to use the scrollbar in e.g. this view we're currently looking at. :)
What if `ibase_fetch_assoc()` returns FALSE? We'll have a row count of 1, but no actual results ...