labofsahil/github-event-dataset-2012 huggingface dataset:
here it’s a little difficult to keep track of the scope of the futures and flatMaps. it might help to separate out concerns a little, and flatten things out eg.:

```scala
def acceptGreeting(res: Result) = sg match {
  case sg: ServersGreeting if sg.serverCap.has(Capability.protocol41) =>
    Future.value(())
  case sg: ServersGreeting =>
    Future.exception(Incomatib..)
  case v =>
    Future.exception(new Exception("invalid reply type %s".format(v.getClass.getName))
}

def acceptLogin(res: Result) = res match {
 ...
}

// Then the login sequence is very explicit, and flattened by using a
// for comprehension.
def apply(conn: ClientConnection) = for {
  service <- self(conn)
  sg <- service(greet)
  _ <- acceptGreeting(sg)
  res <- service(makeLoginReq(sg))
  _ <- acceptLogin(res)
} yield service
```
No need to change this file.
I think the routes are more constant that the method names.
-Geoffrey Parker


On Fri, Apr 27, 2012 at 7:08 PM, Joe Tessler <
reply@reply.github.com
> wrote:

> > @@ -32,7 +32,7 @@
> >
> >    <h4>Going(${event.getMemberCount()}):</h4>
> >    #{list items:event.members, as:'member'}
> > -    <a href="@{Application.about(member.id)}">${member.name}</a>
> > +    <a href="/users/${member.id}">${member.name}</a>
>
> I'd use `@{Users.about(member.id)}` to generate the URL. If we want to
> update `conf/routes`, we shouldn't have to change any templates. This
> arises a few times in this pull request.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/w7cook/OpenBook/pull/241/files#r747598
>
Here I'd rather move the JS event handlers to webyast-users.js file to keep the HTML output clean, examples.:

```javascript
$("#user_uid").keyup(function(){return user_exists_validation(this);});
$("#user_uid").change(propose_home);
```

See http://api.jquery.com/category/events/
yes, changed
Why duplicate the constant?
Keep the exception object in the Failure (something like Failure(msg, Full(e), Empty) ).
Um... let me get the next thing or two off my plate and then I'll take a closer look.  I may have botched this.
Perhaps a proper *unit* test (`mock` anyone?) would help, instead of an integration test which relys on a live WMS server.
The reindenting achieves nothing useful as far as I can see. It's not even a long line so there is really no gain whatsoever it just makes the diff huge.
ok, i do not have a computer to test on, but what happens if you try to place a dead bush while looking at a sand block, from north? It checks the sand block itself, but doesn't check what will be under the bush once it is placed! I will do a proper test tomorrow, since i will be finally home :P
Не сразу понятно, к чему именно относится этот `.then()`
or i guess this works too:

```js
var foo = require('foo')
var bar = require('bar')
var Foo = foo.Foo
var Bar = bar.Bar

function blah() {
}
```
typo: must have at least one connection allowed to an instance
I would keep the structure of this statement the same, but just change the way the settings are retrieved.  Something like:

```ruby
@xcodebuild_settings = app_settings(flags)
```

Then the `app_settings` method would then just return the value, or `nil`.
`KitchenDot` is inheriting from `pydot.Dot`. For being as compatible as possible (sorry for fixing pydot's PEP8 errors xD), I left the `p` variable as it was (and it is usually used for creating a `Popen` instance).
I'll fix one of these now and go through the others later.
This should be something like:
SERVER_AUTH.resolveModelAttribute(context,sasl).asBoolean()
Nah, its not. Removed.
не понимаю почему конфигурацию нельзя гонять по jsp. в SS я ее вообще глобально подвесил https://github.com/maxcom/lorsource/pull/341/files#L7R48 для удобства :}
The indent seems odd. break needs to be at the same level than open().
` = !!e.target.result.length;`
furthermore why do we expose origin and not a private variable before new Message(Message.Type.ADD_BOOKMARK, this.data), this._origin);
here (fileType != '') will always be  false. isn't it?
Hmmm It's a good idea, but there is an issue with this solution. Once we have all our messages from DB we have to add 'pendingMessages' from our cool 'Pending DB' for creating Threads properly, so I have to wait until have 'Messages DB' + 'Pending DB' for creating Thread list. But also there will be a huge increase in performance because we are going to render it only in these 3 cases:
- Open app
- Receive a message
- Send a message
With this change we will reduce rendering an 70% in ThreadList (now we repaint every time is showed...)
Please address the parseInt issue for the mnc code otherwise It couldn't work even having the data we're fetching in the apn object.
I *could* use an ID on button and attach the same code in an `onload` callback but that would make it much less readable.
Seems like what you want to do is to tag list. So What about .tagList/untagList and pass an argument with the name of the tag. (here 'disabled')
Same as above. Save dataset in a variable and use that.
`<i>`
Could we use `rem` units instead of `6%` ?
Only the first one?  What do you do if there is more than one blob? Will the user see that only one file is being transfered, or could they be confused by this?  (None of this should block landing this fix.)
no pun, bad spelling =)
There is a comment here states that the constructor is for internal use only, but, there is a `return BlobView;` down there, other script will be able to use `new BlobView()` to construct a BlobView w/o having the `get()` function to read the given blob. Is that intentional?
Add some indentation otherwise it is hard to see the bounceEnd is a parameter.
Great tip! Probably after launching `homescreen` and `ftu` as apps we could remove this code. But if we will need it, I will update following your suggestion. Thanks!
Remove the comment, this is obvious when reading the code ;)
The way these objects are declared inside the browser object feels a bit messy, is there a way we can split these out to keep the browser object a little cleaner do you think? Maybe just

Browser.screenSwipeManager = {

};

outside of the main browser object would make the code a bit more readable? I'm not sure to be honest, but this just feels a bit messy.
Isn't this similar to what Q_DECLARE_PRIVATE below does?
Please stay consistent with the shell variable deferencing: ``$REPO`` to ``${REPO}``.
TBH I didn't give much thought to it since I took it directly from #330 ... you may be right about this
Что "это" ? Пишите развернутые ответы.
why not just mtime checks?
but saveprofile() function just fill variables so this function can only return true...
@DziNeIT did that, this should be fine.
That should probably be "clamps" rather than wraps.
Shouldn't you use `composer/installers` instead, and set the type to `cakephp-plugin`. Doing this would remove the need for extra lines in the host app's composer.json file.  The [readme for composer/installers](https://github.com/composer/installers) has some more information.
In the best case (no nested models), toJSON creates a new object and copies all attributes to this object. Primitives are copied directl, objects are referenced.

The delegate solution creates an object which has the model attributes as prototype. But only on the first level and on deeper levels which need to overwrite properties. This is a memory-saving copy-on-write technique. Properties are only created when they differ, which applies to serialized models.

To understand the generated structure it’s helpful to inspect the output of this console.debug using the Web Inspector:
https://github.com/chaplinjs/chaplin/pull/77/files#L16R307

![attributes](http://s3.amazonaws.com/imgly_production/4453533/original.png)
Needs to be updated, as vendor dir is now defined via $config, and dump's arguments changed.
No; this is part of some scaffold stuff I need to remove.
NULL check?
Okay, right.
Add level on next line:
$level = 'item';
string appending is quite slow in ruby, this may be better written:

```
message = <<MESSAGE
Date: #{event.timestamp}
Tags: ...
...
MESSAGE
```
this if statement isn't ever true right now, about after fixing the test below to be unaffected by other tests, I decided to the do the same to my test.  Since the tests are async I figure they could be run in parallel at some point.
Will do -- thanks for the awesome pull request!
I'm wondering if PushLogStatsModel is really a derived class of DatazillaModelBase instead of PushLogModel.  There doesn't seem to be any inherited functionality from PushLogModel that is used in the derived class or through a caller of the derived class instance (I could be missing something here).  The class attributes PushLogModel.CONTENT_TYPES and PushLogModel.DEFAULT_PROJECT are the only things in common.  The only shared methods that are used are coming from DatazillaModelBase in the call to the constructor.
I will make sure that the folder exists/is created when the prefs change.
It seems like this should just be in the actual spec tests as opposed to it's own separate file, since it's so small. This would also make it easier to understand what's going on in the tests.
The names of those methods are super-confusing.  I would assume that "build_tree" returned a data structure, and "format_tree" rendered that as text.  I guess they are the reverse of that.
Using a [Struct](http://ruby-doc.org/core-1.9.3/Struct.html) rather than a class is good here, if all you are doing is treating it as a checked bag of attributes.  It makes it more clear the intention, and reduces the overhead from your side.
There's a separate, pre-existing test for that. The array is flattened and resources are created for each element. This is for the resource title array syntax:

    file { ["/tmp/a", "/tmp/b", "/tmp/c"]: }
Still, please remove the semicolon. Also, it would be preferrable to use QMessageBox's static functions here: http://qt-project.org/doc/qt-4.8/QMessageBox.html#the-static-functions-api.
Good call with removing activesupport. I think in the beginning I was using several activesupport functionalities. Over the time those were removed (except for the spec below you changed), but the gem stayed.
This should return a string according with the name of the method
@taisph It's in an elseif, not the else.
No because $plugin can be mixed type.
s/expect/expected
It's a little weird to have this commented out.  Let's either use it and set a default, or remove it ;)
https://github.com/KnpLabs/KnpBundles/blob/master/bin/behat-ci.sh
and btw, the installation of MinkBundle will probably fail as Mink dependencies are missing
Oh, also, to be consistent with coding standards, `'key_only'` should be `'keyOnly'`. Thanks!
require throws an error on failure, it doesn't return a falsy response.
I think your if-statement is not required, instead you can write: var EventEmitter = require ? require('events').EventEmitter : EventEmitter;
Why are you using a prefix increment? `++i`
again, this isn't ISO2, it's RFC5646 if anything.
lets just delete this. we should make sure to search the entire project for any potential breaking strings:

import couchapps*
from couchapps*
import apps*

.etc. (apps, couchapps, util, elastic, middleware, and pillows should be checked)
I agree with you guys.

For sure this is not the best approach.
But the current events system can't handle this without create a event manager per class.
And we don't have a DI to store shared instances.

If you have a better solution are welcome :)
You can inline this semantical error.
nope .. we don't
No, the browser shows that weird because that Hebrew text is read from right to left. If you open in vim it show ok... well ok for us that read from left to right :P
OK, for these cases I'm fiine with the additional info.
I wanted the second line to indent, but even hard spaces weren't working here...
add docstring for module
Can you keep all the keys at the same indentation level?
BTW this applies to each item in the list.
Should be 8 spaces.
Correct. 

You can use this Servlet locally too, but the readme only tells the user how to run the Arq test.
I would switch this from a notice to a flash but that's personal pref.
Does the link below appear on a newline still? I think that was the point of this.
I swear I thought I commented on this. Please change the name of this function to something the more specifically describes the functionality. Perhaps `mergeTrackEvent`?
your indentation is all wonky here though, 2 spaces
@ohadlevy, the documention is generated by what is configured in the initializer file apipie.rb.  Now ,it refers to v1

  config.api_controllers_matcher = "#{Rails.root}/app/controllers/api/v1/*.rb"
I see, GitHub is not showing enough context...
_getData will add "yield"
I see :) Sorry, mised that the commits were matching...
Marco Pivetta

http://twitter.com/Ocramius

http://marco-pivetta.com



On 17 October 2012 21:05, Eric Boh <notifications@github.com> wrote:

> In src/ZeffMu/App.php:
>
> >
> > -        return parent::init($configuration);
> > +        $app    = new self($serviceManager->get('Config'), $serviceManager);
> > +        $router = TreeRouteStack::factory(array());
> > +        $serviceManager->setService('Application', $app);
>
> @Ocramius <https://github.com/Ocramius> This PR ist just one commit ahead
> and simply removes the ['view_manager'] config key "hack".
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/BinaryKitten/ZeffMu/pull/5/files#r1870816>.
>
>
This `<` needs to be replaced with `&lt;` to work in IE
Why isn't this in a function yet?
@igorw This is a feature, not a bug. If developers want to test out changing styles, it's much easier to pass it in the URL until it's finalised.
Just to clarify, these produces a new `Quantity`, not a scalar or something, right?
How come it ends up as /Ftp? I guess it's a specific thing of the cakephp installer? Other than that all the variables names with capital letters are a bit strange.
It's generally better to not have large blocks of commented-out code.
сам почиститься
`Refinery::Plugins.active` returns empty array so we should probably start to dig from here.
Will this allow using /api/auth/login as an Ajax call without following the redirects?
I think this needs to check `files.length` rather than the array object.
What's the difference between the errors that get passed in here or the ones that get passed to done but with a data.error?
Cool, thanks. A similar implementation could be done for getDoc as well to make it synchronous, too.
The storage backend mechanisme's require it.
Missing comment, should be fixed.
If a test class is private, the JUnit runtime will throw an exception during initialization, which I feel is helpful for the user to understand that he did something wrong (this matches the behavior in the Eclipse Java support). On the other hand, it is true that I'm filtering on trait, module and abstract classes. I should check what happens in Java for abstract classes. And the reason I don't look into module is ticket [#1000856](https://scala-ide-portfolio.assembla.com/spaces/scala-ide/tickets/1000856#/activity/ticket:).
But it's a private class.
This isn't a plugin for Mingle.

How similar are the Mingle / Rally api clients? You might want to make a second base class, like AlmAPIBase, for doing common tasks. It looks like the __init__ methods are almost identical for example.
Ok, that's more or less my coding standard anyway.
Во всяком случае, вывод на экран - это по сути и есть логирование, в каком-то смысле. А метод этот был подсмотрен в книге Аарона Хиллегаса, и рекомендовался он именно для того, чтобы объект класса можно было выводить на экран. 

Я согласен, что этот материал был в лекции, но так же и сказал, почему в данном случае не захотел использовать их - лучше уж без свойства. А вообще, если даже это влияет на оценку, хотелось бы услышать комментарий @freetonik по этому поводу. 

--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev

-----Original Message-----
From: ASPCartman <notifications@github.com>
Date: Wed, 31 Oct 2012 09:20:08 
To: Hexlet/osx-project-1<osx-project-1@noreply.github.com>
Reply-To: Hexlet/osx-project-1 <reply@reply.github.com>
Cc: S. Lebedev<sergey.al.lebedev@gmail.com>
Subject: Re: [osx-project-1] Решение задания "Проект 1 - ДНК" (#17)

> +    NSString *descr = [[NSString alloc] init]; // хочу, чтобы всё выводилось в одну строку!
> +    for (id elem in DNA) {
> +        descr = [descr stringByAppendingString:elem];
> +    }
> +    return descr;
> +}
> +
> +-(int)hammingDistance:(Cell *)someCell {
> +    int ham = 0;
> +    /* долго думал, и пришёл к выводу, что так сравнивать лучше всего, так как 
> +     у нас нет прямого доступа к массиву DNA объекта someCell */
> +    NSString *sourceString = [[NSString alloc] initWithString:[self description]];
> +    NSString *compareString = [[NSString alloc] initWithString:[someCell description]];
> +    for (int i=0; i<capacityOfDNA; i++) {
> +        if ([sourceString characterAtIndex:i]!=[compareString characterAtIndex:i]) ham++;
> +    }

Поле Description используется исключительно для логирования. Нельзя (ну как, никто не запретит, но это моветон) его использовать для других целей
https://developer.apple.com/library/mac/documentation/Cocoa/Reference/Foundation/Classes/NSObject_Class/Reference/Reference.html#//apple_ref/occ/clm/NSObject/description

Проперти создать нужно, почти что по заданию - такова была тема лекций. А делать ли его readonly или нет - исключительно ваш выбор :)

---
Reply to this email directly or view it on GitHub:
https://github.com/Hexlet/osx-project-1/pull/17/files#r1994385
I just did that because it was like that in rubrics/index.html.erb.
redundant with initialization.
Should we drop appURL param that is no longer needed?
I thought windows was implemented. Why is this ``#if`` here?
But this function is called in line #169, it's a boolean validation.
It would be nice to do the arity check as well so `callback` isn't necessary for sync stuff
Will this include the payload?
How? I don't see it in the gemspec or in sniper.
onCreate is called every time you create a new x-dropdown element.  So this would be adding multiple listeners for the same thing.
Fixed in 880947d8e0ec92163dbefa71f5c4ba482f0aeed3
why is this section removed and not the parts above, and if it should be removed, then shouldn't it be placed somewhere else or at least a link to confluence page that gives you overview of features eZ Publish 5 extends Symfony with?
There are plenty of other edge cases, I don't think Raven should be changing another library's config, that is something for the user to decide.
Well. It is better than the recalculation hack. And I will implement it in this way.
You should use ``escapeshellarg`` instead of manually escaping arguments of process.
Is the exception indicative of a programming error, or an exceptional condition that might affect users using various clients at runtime.

From what @dahlbyk says, it sounds like this would be a programming error and you should check `IsBare` first. In that case, I'd lean towards `InvalidOperationException`. Probably no need to have a specific exception type.

If it's the latter, I'd recommend the specific exception so we don't have to parse the exception message to know what to show users.

Though keep in mind, is there the possibility of race conditions where I check `IsBare` and then it changes when I actually try the checkout? I'm guessing that's not something that would really happen.
When interpolating one thing into a string, the parentheses aren't necessary, so I omit them. I would write that `('/api/%s' % api_endpoint)`.

You might be interested to know you have to include a comma to make a single-entry tuple, so it evaluates as `'/api/%s' % api_endpoint` already anyway. If it were required to be a tuple, you'd need to write `'/api/%s' % (api_endpoint,)` with a trailing comma.
Sure!

As to the plot. So what you have in mind is to iterate over channels and
plot e.g. two conditions inside a channel window rendered in MNE analyze
colors?


On Thu, Dec 6, 2012 at 7:28 PM, Alexandre Gramfort <notifications@github.com
> wrote:

> In examples/plot_topo_compare_conditions.py:
>
> > +
> > +print epochs_au, epochs_au
> > +
> > +layout = read_layout('Vectorview-all')
> > +
> > +evoked_au, evoked_vi = epochs_au.average(), epochs_vi.average()
> > +
> > +
> > +###############################################################################
> > +# Show topography for two different conditions
> > +
> > +pl.close('all')
> > +for evoked in [evoked_au, evoked_vi]:
> > +    pl.figure()
> > +    title = 'MNE sample data (condition : %s)' % evoked.comment
> > +    plot_topo(evoked, layout, title=title)
>
> I know that's why asked :)
>
> I'll do it tomorrow if nobody does it before.
>
> thanks heaps for this new cool feature !
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/229/files#r2338907>.
>
>
sortBy allows only one column ? If multiple columns are passed it sorts by conceptId.
remove dbms="mysql"
We could, it's sort of all or nothing (you generate the pair).  This also matches what we have in `opscode-omnibus`.
Same as bash, I think the Pygments name for an ini code block is "ini"
Nitpick - Capitalization? OpsSchool?
Also, there's a config for that:

```scala
def CREATE_IF_NOT_FOUND: Boolean = c.getBoolean("csrf.cookie.createIfNotFound").getOrElse(true)
```
Why do we need a whole new class beyond what the SDK provides?
Not for a good reason, I have readded it :)
woops... you're right
This is wrong for the standalone part
Yeah, I was thinking that could be handled in that commit.
@bnoordhuis  We already are doing `-fPIC` in the cflags, is it also necessary for the ldflags (if yes, what about for the other platforms where we are already using -fPIC?) ?

I also realized that gyp automatically adds `-shared` to the ldflags on Solaris, so this change is redundant. I'm reverting.
after checking in source file identation is wrong in github interface only
unused namespace declaration
Let's remove this file.
ya the method itself is using context, client, and uuid.
You can also take one element out of a set with `disj`.
@idan Sorry, it's my fault, because sometimes the header does not exist, so i just simply set the header again. I will add another commit soon.
Style: `delta.binary`
The spacing here is inconsistent with how methods are declared all over the framework. Also, Objective-C methods should typically read like sentences or short phrases.

With that in mind, can you please change this declaration to something like:

```objc
- (void)expectSHA:(NSString *)SHA forRefspec:(NSString *)refspec;
```
Good lord yes… the irony of me finding this after just schooling @ben on how these should be done is pretty strong here. I would imagine these slipped through due to the removal of `inRepository`.
In general the [KISS principle](http://en.wikipedia.org/wiki/KISS_principle) suggests keeping it simple rather than pre-empting future (undecided) changes. The future rc default mechanism may be completely different, for instance a syntax similar to
```def pie( ..., startangle=rcDefault('piechart.startangle', 1), ):```, avoiding the ```None``` requirement, is completely conceivable, but that is for another discussion.

Sorry for labouring this for such a tiny action @WeatherGod, but it seems like it is something worth agreeing on.
Same thing with this imports as above.
hmm...I'm not sure this belongs in this class. Can you find somewhere else to put it?

It's important to keep things out of the main "TestCase" class, as other python classes/files may want to reuse this code outside of a test case context at some point.
J'ai déplacé le check de la permission après le check de la première ligne pour ne pas empecher les joueurs qui n'ont pas la permission de placer des panneaux normaux.
This should reflect the actual version of the ConnectorManager-dll
Not sure how I missed the one - I'll fix the upgrader issue too - it should be a hard fail.
Wrong tab there
And there is problem with `TEMP_FOLDER` which [I described](https://github.com/michalochman/sapphire/commit/03b253c136b59c4ca8b0bfd6b07e8255aa1424b2#commitcomment-1546112). It is using PHP's [sys_get_temp_dir](http://au2.php.net/manual/en/function.sys-get-temp-dir.php) returns completely different paths for apache and cli:

CLI:
`/var/folders/kb/ghk0_dgn2dz20h8q9n5kr4xm0000gn/T/silverstripe-cache-Users-michal-Projects-SilverStripe-htdocs`
Apache:
`/var/tmp//silverstripe-cache-Users-michal-Projects-SilverStripe-htdocs` (it even has double slashes here)
What *would* be a sane timeout for this? I'll add it in if you want it.
IMHO, the route middleware should better be triggered before the global app ```before```. 
Most of the time, routes middlewares are used to detect abnormal use of specific routes (a "edit profile" route for a non-logged in user, for instance). They are simple functions, and they often redirect the user if such a case is detected.
If you have heavy specific process in the global app ```before``` hook, it's not necessary to run them if a route middleware detects a forbidden route usage.
Of course, it depends on your usage of the routes middlewares and the  ```before``` hook, but from my point of you routes middlewares are simple operations that should be run before the global hook.
There can be much more than 100 products so searchItems() must be called in a loop until all products are processed
Are you sure ``'array'`` has the correct type as "string" is not a sub-type of "string"?
Where is it called from? I couldn't find it anywhere.
Für was ist diese Funktion genau? Bitte dokumentieren.
I think it is a good idea.
Okay sounds good (re: Adler32).

Yeah for two strings it's a wash, but it's three strings here. + is not usually used in Python for concatenating 3 or more strings because every time + is used, the interpreter makes a new string and copies both sides into it. If you do this 1000 times, you'll create 999 throw-away strings. As you say, with very few strings it's not a big deal, but it's "good Python style" to use string interpolation or join() on three or more strings.
Instead of hardcoding an index value have you considered something like 

integer index = 0
infoArray[index] = blahBlah;'
infoArray[++index] = blahBlah;
Cheers for the feedback, will sort it. I hadn't realised when I was writing
this that it worked up the inheritance tree.

On 4 Sep 2012, at 15:18, Daniel Grunwald <notifications@github.com> wrote:

In
ICSharpCode.NRefactory.CSharp/Refactoring/CodeIssues/NoDefaultConstructorIssue.cs:

> +
> +		private class GatherVisitor : GatherVisitorBase
> +		{
> +			private bool initializerInvoked;
> +			private IType baseType;
> +			private ConstructorInitializer initializer;
> +
> +			public GatherVisitor(BaseRefactoringContext context)
> +				: base(context)
> +			{
> +			}
> +
> +			public override void VisitTypeDeclaration(TypeDeclaration declaration)
> +			{
> +				var result = ctx.Resolve(declaration) as TypeResolveResult;
> +				var baseType = result.Type.GetNonInterfaceBaseTypes().FirstOrDefault(t => !t.IsKnownType(KnownTypeCode.Object) && !object.Equals(t, result.Type));

This is incorrect.
For the inheritance hierarchy "class Form : Control : Component : object",
your code would return Component, but correct is Control.
You only need the direct base type, not the whole hierarchy, so use
result.DirectBaseTypes.FirstOrDefault(t
=> t.Kind != TypeKind.Interface) instead.

—
Reply to this email directly or view it on
GitHub<https://github.com/icsharpcode/NRefactory/pull/106/files#r1523139>.
Maybe just change it to `python` -- do any distros use Python 3 by default yet?
`if (this._redirectAuth && ~url.indexOf(host)) {`
Not necessary anymore here.
Constant string should be in `'`. Use string interpolation instead of concatenation.
We don't :)
Well I havent seen "Povezani" on any slovenian site so far only "Prijavljeni", but I can change it. It just sounds so weird for some reason.
One more thing. This should not be only in `home.js`, but on all pages where logout is displayed.
This is not exactly as I imagined but is a nice idea. It probably seems to work, but there are some slight issues with such approach:
 * you are in fact accessing internal attributes of field objects, you are not sure if you are not breaking something with this, it might be that there is some other things which are configured in field based on initial value before you change it
 * you are changing the readonly flag only for objects, not for class, so instances of the class will have their fields readonly, but if I try to passively check fields without creating a class instance, I will get another picture

So yes, your approach seems to work but it is error-prone. And this is one thing I would like to teach you. To think about such things. Not all solutions are always the best. For code which should run for long time, you should use only documented APIs (even those change). And use undefined ways only if there is no other way.

Here, there is official way. It is ugly and tedious, but it is: define all resource fields manually. Currently, most of them are inferred automatically (see `get_fields` method in `MongoEngineResource`) from the fields defined the document, only fields relating to some other resource has to be defined manually. But in this case you have to define it manually.

The second approach is to override `get_fields` to post-process fields automatically. This would solve the second issue above, fields would have flag also for classes, but would not solve the first one.

The third approach is to change `get_fields` implementation in `MongoEngineResource` to allow hooking in and alter field creation parameters dynamically. I will prepare this now.
Slightly faster. http://jsperf.com/binary-regex-vs-string-equality
Instead of predicating the variadic forms on `Numeric?` or `Integer?`, I think the predicate here should merely be `countValues(..AA) != 1`. I think you should also use `foldlValues` instead of `foldValues`, since you want the operators to be left-associative by default.  Those changes should make the variadic operators drop-in compatible and let you back out your other changes.
What is happening here? every time we render the object so "begin" the animation and "end" it right after the rendering?
i can, but the query will still be needed because of getting at_login flags. Or should i add it to CharacterNameData too ?
Hmm, have you tested this?  Looks like a stack overflow.
if you go for the scalar prototype as suggested, it would look like ``<resolve-target-entity interface="foo">Bar</resolve-target-entity>``
I think the check on the PROVIDER is redundant? (But I might be wrong..)

Also, consider that someone might want to extend your _DataStoreProvider_ to change a single method.. it would then fail for who is trying that.
If you think extension should NOT be supported, make the class final and mention the reasons in some javadoc comment.
Because I'm accessing it from same class. For now it's `HostedServiceProperties` I'll chat with folks about using `HostedService` for everything later.
This is a copy from the nginx source, which does it like this for each of the things it can clear: http://lxr.evanmiller.org/http/source/http/ngx_http_core_module.h#L508

In general I agree `do { ... } while (0)` is better, but I think it's actually more dangerous to make our version of `ngx_http_clear_etag` safer than the upstream one.
We're not using `CartoDBClient` so let us not import it.
why is this line commented out?
I will add a few lines view, but I don't know what the variables mean since there were no details in the original script
If you retype this to List<Matcher<?>>, can you drop the @SuppressWarnings?
Please be more verbose.
I don't think you need the period between @ and $ do you?
I don't actually use it anymore, but for a while (until I made other improvements to the getXRange and getYRange functions -- especially the ones in SBDistort), the two profiles being convolved could be partially disjoint.  Think of a square pixel just barely crossing into an ellipse.  

Then the inner integral for the convolution would get exactly zero for a while, where the two profiles were not overlapping, then ramp up to some finite value at the other end.  This is hard for GKP, since it is inherently doing a polynomial approximation of the function, so it doesn't really like sudden changes in the slope like that.

So what this function did was look for that string of zeros and try to split the integral at the point where it started to be non-zero.  Then the two halves are both smooth (one of them is trivially zero), so the next pass through intGKPNA succeeds for both regions, and the two sums are added together.  I called the function findZeroCrossings, since I think it will be more often used to find where a function crosses 0 as a good place to split.  The string of zeros was an additional feature.

This helped a lot for a while.  However, I eventually did a more sophisticated calculation in the SBDistort getXRange and getYRange functions.  And then I wrote the OverlapFinder stuff (cf. line 95 in RealSpaceConvolution.cpp).  After those two improvements, I didn't need to use findZeroCrossings anymore.
This is a bit cryptic when seen out of context.  Perhaps a comment each time (or once in each file) you use this saying that the code between @cond and @endcond are excluded from the doxygen output.
I'm so glad this feature was useful!  (I never use it, but it was a feature request by someone else, and I don't really have a good idea how often people use it.)
I made duplicates of nextState to check if joypad handling / simulated keypresses should override the mouse keypresses . When nextstate2 is true ( which is ONLY refreshed by real mouse / key presses ) , nextstate won't get touched from joystick handlings . Otherwise , if it's false , it gets replaced .
`preinstalled: false` should not be displayed here
Doesn't work. Causes errors.
Aloha: Error message: Uncaught TypeError: Cannot call method 'smartContentChange' of null
As discussed over skype, although it might "work", I don't think it's what a user would expect. The user didn't configure to use this file, and nowhere is it documented that this is the default file to be picked up. 

Much better to fail-fast about an invalid configuration than to behave as though the user had set this value in ssl.destinationCertificate.
Add a test that loads an application from an external Groovy script in `src/main/resources` via both _classpath://_ and _file://_
Why not cast this earlier to Application? It gets cast two lines lower down anyway...
Hollywood et les grands labels traditionnels (Sony, Universal par exemple).

Qui produira le contenu si elles meurent ? Des labels independants (moins vrai dans le cas d'Hollywood que pour la musique mais j'ai pas envie de rentrer trop dans les details). En fait, comme je l'ecris plus bas, elles vendent des bouts de plastique, et on n'a pas besoin de plastique a l'ere des objets connectes (un film bientot ca se telechargera, le DVD va mourir).
_A position' score_, pas this
Looks like I still need to get the path for both Python scripts, so they will get unpacked from the jar file. BundleUtils still makes it way easier, though.
Put the QObject back
Why the __version__ here? Isn't this just adding lines of code for no reason?
Answered this already but for others to see:
Click on View file and it's on line 771
` var type = options['httpVerb'] || StackMob.METHOD_MAP[method] || 'GET';`
просто не треба про це писати. в коді я позабирав цей параметр
oh, ok got your point now. need's only be set in the networkinterafacecard received as argument.
+1
They should all be relative since it is setting dependant (MEDIA_URL/STATIC_URL). I'll fix the absolute ones.
That happens when you switch back/front camera while having a filter applied.
Why remove the O2 kit?
I know this is outside the scope of what you changed but do you think this could have a race condition?  Specifically it a timeout and a transaction completed happened at the same time?  We could double delete the same object then...
I think both phrasing are misleading.  This block sends EITHER and ack or obj_req packet is that's appropriate (not always sending an object) and below it sends the object otherwise.  The current phrasing makes it sound like you may or may not send the object.
It is the data in the response not the body of the request.  IE this is the data that the server sent back for people to look at when debugging their error.
remove the author tag,
You won't have guaranteed access to the node['nova'] attributes. You need to put a default['cinder']['rabbit_server_chef_role'] = 'rabbitmq-server' in the attributes/default.rb file. Eventually all of these will move into the openstack-common attributes, but they are not there yet...
This example fine; however, it could stand to be less academic and focus more on how one might solve a real-world problem with an anonymous function. Further, it would be good to separate the examples so there is one for a plain anonymous function and one that depicts a use-case where a closure would be in order.
anonymous functions !== Closures (however, closures are anonymous functions)
Неправильная проверка. Класс может реализовывать интерфейс, который, в свою очередь, реализует нужный интерфейс.
Надо минимально проверять на корректность паттерна.
Лишний container.get
IOHandler всегда падает и все за собой валит, если что-то не так, так, разве нет? 
так зачем тогда?
Ошибки в System.err писать надо
Проверять на корректность надо с помощью TimeZone.getAvailableIds()
We do.
The doc comment says:

    /**
     * Open the toolbox for a specific target (not tab).
     * FIXME: We should probably merge this function and openToolbox

The problem is that openToolbox and openToolboxForTab do slightly different things, and both of them not quite right. I think they should return the promise of a Toolbox, so that all toolboxes are valid and useful, and don't exist in a weird 'coming into existance' state.

I think we should probably fix both problems at the same time.
Separation of concerns. The `run_install_script` is not technically an essential part of the install process, and could do more in the future, so I separated it out.
We should move this import and the beginning of the file as per http://www.python.org/dev/peps/pep-0008/#imports
'Imports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants.'
nope 
removing it from both tests
We already removed this method in another pull since it's not preset anymore.
no because that's in the bidpom code and that's used in all the projects... 

this is specific to marketplace mobile
There seems to be no filtering on object so I added this. Can you tell me if I'm missing something and if this is the best place/way to implement it?
Maybe split all the tests in this file to separate test functions for RGB and grayscale?
Ok, I got it (finally). Pretty awesome example, but also a bit advanced. Maybe add the output of some given input ?
This fix should be cherry-picked and pushed to master directly.
> Indeed, can you rerun the benchmarks to check if this is not just the natural variance of executing stuff on your hardware + OS?

I only posted one set of outputs but ran the script several times; some cases where the unrolled version was faster the first time are slower some other times, so this is just variance IMO.

Unilke the speedup of the current version vs. the previous one, which is consistent.
To me, this section looks written as if post-pruning was the only way to prune a tree. I would rather introduce both pre-pruning (using `min_samples_split` or `min_samples_leaf`) and post-pruning and compare them both. What do you think?
It looks like this could be wrapped better.
Subsampling implemented this way amounts to have an _average_ fraction of samples equals to `self.subsample`. From one estimator to another, the actual fraction of samples might indeed be different. Is it intended? Instead I would maybe do something like that:

```
n = max(1, int(self.subsample * n_samples))
sample_mask = self.random_state.permutation(n_samples)[:n]
```
верни отступ
why not just name the var "return_value"?
Please group together from ... imports after import statements.
No problem; I can fix it when I merge.
You are right. I've completely forgotten the return type covariance. I'll fix this.
The formatter is inconsistent. When angle brackets are in a declaration, it removes spaces but when it is within a method, spaces are added.
This function should take 2 params http://docs.appcelerator.com/titanium/2.0/#!/api/Titanium.UI.Picker-method-setValue
OK, that does make sense when doing more complex assignments with conditionals. I'll keep that in mind!
If the user has overridden the default runtime directories this will throw away their changes.

If they haven't then I don't see why we generate the setting at all rather than leaving it blank and calculating it on the fly when needed.

i.e. the code here should really be cone where a component needs to know its runtime directory, using a value based on the component name if no overriding directory name has been specified.
It seems a shame to add this extra include, just to defined hash64_t. 

@richardkchapman any other ideas?  (I would say include it in platform.h, but eclrl.hpp doesn't include that.)
Typo - should be hasLineTerminator
Comment now slightly dishonest
You shouldn't be parsing the path, to workout the component name, to lookup the group...

The clusterName is in the workunit, all Thor's are required to be the same size.. so you can get at the thor target processes and group via the clusterName of the workunit.
Should have a comment

    //Ensure selections from dictionaries do not have a separate activity for the row lookup.
Sure, I'll add it as ${it.rev}:${it.id} which mimics the default changeset format of hg log.
Good for security.
I had actually just realized this, and in my version this conditional has been removed.
Зачем указвается версия?
@yuhunglin Are you sure that you're using tabs instead of spaces?
```mapping_p_o[label] = []```will suffice.
2f is ```/```, not ```"```
I think doc or a link about how to do a pull request would be useful:

https://github.com/rapid7/metasploit-framework/wiki/Metasploit-Development-Environment#wiki-pull

For me important points to remark here if only the link is provided are:

* 1 module => 1 pull request, changes to core => another request, (you speak about that below)
* Don't use "master" ! Create a new branch in the forked repo.
let's either do this todo, or remove it
Additionnally -> Additionally
I agree it is easy to accidentally pass in a float image that is not normalized. On the other hand 1) it is an error in the client code, 2) it takes two passes through the image to detect, 3) integer images that are not properly normalized are accepted without check, and 4) there are valid cases where the float range of a normalized image can exceed [-1..1]. 
If the check is put back, at least there should be a simple way to disable it. Maybe a warning is enough?
The `def/rescue` syntax is at odds with our internal style - how about this?

```ruby
def delegate_method(delegating_method)
  begin
    require 'bourne'
  rescue LoadError
    raise "....."
  end

  DelegateMatcher.new(.....)
end
```
仅仅是用\func{fgets) 就可以做到这一点
Why not replace all this:
```javascript
this._commandLists.removeAll();
if (frameState.passes.overlay) {
    this._commandLists.overlayList.push(this._overlayCommand);
}

if (!this._commandLists.empty()) {
    commandList.push(this._commandLists);
}
```
with something like:

```javascript
if (frameState.passes.overlay) {
    this._commandLists.overlayList[0] = this._overlayCommand;
    commandList.push(this._commandLists);
}
```
Or even assign to `this._commandLists.overlayList[0]` elsewhere.  `update` should always do the least amount possible.
`result` parameter.
I know exactly what this spec name means, but is it descriptive in our open source world?
I know u like this c# style of declaration, which is inconsistent to the coding style we are using by the way. Unless I'm missing something, I dont see any benefit with embracing this style form. Also, I'm not trying to nitpick, but is this something we both have to agree first?
for sake of consistency, since we dont use _varname, you might consider using the name twin, selfThis, etc.
Ah... yes. I just looked at `ifeq` and thought that it's for `MODEL_FLAG`.
Ok everything is in updated commit
This does seen like a cleaner way to go. It ensures that in the event that there are no tags, an empty array is created, removing the need for the `unless`.
If onTabChanged is called when the first tab is added and when the tab is changed then do we actually need this?  Seems like the background will be set no matter what.
How so? In Ti terms, a module is a singleton object bound to an identifier in the global namespace. I don't know about MW, but in iOS and Android, that's exactly what Ti.UI is--an object that provides a bunch of factory methods and constants. We use modules by accessing their global identifiers:

var win = Ti.UI.createWindow();

Within a single app instance, Ti.UI always refers to the same object. 

A regular ol' Ti object (say, Ti.UI.Window) isn't guaranteed to be accessible using a global identifier. On some platforms Ti.UI.Window may be an object; on some platforms, it may be undefined. We don't specify. But in general these are objects that we can create instances of, and we access the instances, like `win` here.
unecessary parenthesis
Can you change all instances of "=>" so that they have a space around them?
It's been set here, for just this block.

It's just use the same messages that was already defined in code, and use that in both `log_message()` and `show_error()``
`$this->markTestIncomplete(...)`
Ok, will change that. (although, I think it's more rigid/complex that way) :P 
Like we taked, `stable` will be required and `legacy` optional.
I would put this logic into the mainwindow. The screen could just emit a signal "installClicked()" or something like that, and then the mainwindow can receive it and switch the pages.
The term 'dude' comes across misogynist lately.. I wonder about using it. ;-)
тут лучше использовать std::auto_ptr, а по современным стандартам std::unique_ptr
This is very much a stylistic/opinion thing. Personally I hate using /usr/bin/env in #! lines :)
Please rename element to button_element.  Also, the property could be renamed to button_names
Actual text taken from:
http://www.cplusplus.com/reference/clibrary/cstdio/scanf/
Are there any problems by ```T result;``` ?
I updated my Timsort module with a much better unit test.

https://github.com/Xinok/XSort/blob/master/timsort.d#L564
Le 15/09/12 14:26, PeterSommerlad a écrit :
>
> In boost/suffixes/select_int_type.hpp:
>
> > @@ -22,10 +36,10 @@ struct select_int_type<val,INTTYPE,INTS...>:std::conditional<
> >  template <unsigned long long val>
> >  struct select_int_type<val>{
> >      typedef unsigned long long type;
> > -    static type const value{  val };
> > +    static type const value =  val ;
>
> UDL suffixes will work for C++11 only, why did you change the c++11 
> style back to "classic" assignment style?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/PeterSommerlad/UDLSuffixBoost/pull/2/files#r1613555>.
>
No this change is not needed at all. Sorry for that.

Vicente
> Hmmm, I think that's enabled by default.

Correct. I added this when I started looking into the issue. Just adding it did indeed not help. The problem was w/ these explicitly configured executions of the source and javadoc plugin. Removing them and just relying on the super pom _release-profile_ did fix the problem.
I did not remove it so far, because it gives a hint on what we rely on. If you really want to go all DRY we could remove it.

> So I was wondering whether the JavaDocs aren't already published to the repository.
> And indeed that seems to be the case for the snapshot repo, but there are no JavaDocs in the release repo.

Before this change neither the SNAPSHOT nor the release repo had the jaadocs jar deployed. The latest SNAPSHOTS have the javadocs deployed, because that's how I tested the changes.
BLASPHEMY! YOU MISSED SOMETHING! PLZ CHANGE!
Align with below.
Sounds good, I'll go with `createBlobService` like what node has.