labofsahil/github-event-dataset-2012 huggingface dataset:
Changed logging code

Defined a function called log() which would take care of adding proper category and message prefix if required instead of appending same data over and over.
maybe this should be removed

this line does not exist in the original arrays.xml

https://github.com/IceColdSandwich/packages_apps_ROMControl/blob/master/res/values/arrays.xml
line 299~303
Adding myself as a student/mentor
re-introduce httpserver port 0 for automatic port selection
Update arch/arm/mach-tegra/board-smba1002-gpu.c

New higher pclk, better performace with compatibility (tested with latest TeamDRH's RC Jelly Bean build). Removed customs porch sync as not needed.
add opticharger and squisher
Issue 4809: Help the stack walker to find the location of a throw statement

This patch creates a standard stack frame for the _d_thowc function under Windowsn, even if druntime is built in release mode. This allows the stack dump and a debugger to display a correct call stack when an exception is thrown.

In addition, a workaround is added to allow the stack walker to synchronize without symbols for kernel32/kernelbase being available.

http://d.puremagic.com/issues/show_bug.cgi?id=4809
Some refactoring. 

- String is null as default;
- The method ```condition()``` is implemented not overrided;
- As Clean Code says, is good put the ```SuppressWarnings``` locally;
- We don't need the specific ```List```, the generic ```Collection``` feets;
- Removed blank javadoc;
- The element ```<br />``` as valid xml, even HTML5 does not need it.
Test Fixes - 02/16/2012
INT-2445

fixed WebServiceInboundGatewayParser to not fall back on super.doParse() which was iterating through all attributes in the element attempting to set a corresponding property on the BeanDefinition.
Added tests for both Inbound and Outbound gateways
Add a log message for when resource mapper is done

There's already an info level log message for when resource mapping starts (whenever a file changes).  This pull request adds a one line log.info message for when resource mapping is finished.

This would be a big help for knowing when I can reload my browser.  I always end up hitting refresh a couple of times never sure if my latest changes are out there or not. 

Now I can just watch for this log message and then refresh after it's done, confident that the new code should be in my browser after I load.
DEMO - 6.1 - LP - Announcements

http://issues.liferay.com/browse/LPS-25180
Fixed DB Console not opening in Rails 3.0.x and other bugs

Hello,

I was trying to use the RLA to dump into the DB which was fine, but opening it up in the provided console failed. There was issues in the command line arguments, a missing bracket in a library setting, and also files were not loading once they were in the IRB commandline. Moved around and fixed the issues and no longer get warnings.

Once in the console, all calls to an association to Source or Request would fail. This was because it was trying to find the class. XXX::Source or XXX::Request. Fixed this by adding in explicit class names to the associations. This required specs to be altered as well.

All specs passing.

- Cameron
remove AFN dependency version limit in podspec.

This limit stopped me to install AFHTTPRequestOperationLogger from CocoaPods if I use AFN 1.0RC in my project.
Feature/askbot integration

First part forum integration
- better organisation, better comments new way easier to read
- adition a "css reset" should be elsewhere later.
It is supposed to prevent other stylsheet to influence this one.
- styles for question_card.html
- styles for contributors.html
- styles for edit_post.html
- styles for question_edit_tips.html
- styles for question.html
- styles for tag_selector.html
- styles for question_card.html
- styles for ask_form.html
Fix two crashes

Fixes the crashes discussed in https://github.com/doubleencore/DETweetComposeViewController/issues/41
Bootstrap 2.2.2

Hi

Updated to 2.2.2
Added test for zooming the profiler.
Alinhamento 25/02 - Caio

Alinhamento 25/02

Seja o que Deus quiser!!!
New web_server.coffee screenshot using util instead of sys.

sys appears deprecated (see below), so I created a new screenshot requiring util
instead.

$ node
> require('sys');
The "sys" module is now called "util". It should have a similar
interface.
2
Update solaris packaging script

The build script to build the solaris package was outdated:
- mco was not installed
- building from tar didn't work because the Rakefile was not included

https://projects.puppetlabs.com/issues/8601
update to Bootstrap 2.0 stable
Упрощение кода скрытия
Pull Request: Updates packager with new versoin support card as application type.

Also it has Framework submodule with corresponding changes.

[CI Build](http://ci0000003863287:8080/hudson/job/BB10-Webworks-Packager-next-adds-card-invocation-support/3/)
V1.8 fixing broken repo
Merge some commits from my old repository
Fixed checking for 0 on datalabel

if you define plotOptions: { line:{ dataLabels: {x:0} } } it would inter.pret x as -999, fixed by checking for 0.
Updated to v.0.2
Document unreliable screenshot

Reasons for documenting this, rather then silencing the error:

(1) Errors should never pass silently.
(2) Unless explicitly silenced.
(3) I want the user to make a choice about whether he wants to retry making
the screenshot or whether he doesn't care for it.
(4) I don't want to re-invent Robot Framework's machinisms for retrying and
silencing errors

This gives a specific error message for the backend's explicit
"Screenshot not available" status, so one can handle it in the test script.
add leading slash to /obj/lib/libcamera.so

it was complainng there was no rule to build /obj/lib/libcamera.so

this fixed it for me. :| 

p.s. I am a total n00b.
Typo Correction

aren't use -> aren't used
Typo in French translation

Hi, just a typo 
Anyway the addon 3.0.0 works perfectly now, great job.
I still believe that "Choose default download path" should be in the Settings dialog and "Album download path" should be when you press the context button (or c) not the other way around.
Activity Logging feature

Feature for generating logs of synapse user activity for data mining.
Refactored Java client, added Provenance methods
Android: Titanium.Network.HTTPClient.send - V8/Rhino - Android 2.x - send() loads text instead of image

https://jira.appcelerator.org/browse/TIMOB-6446
Updating to match latest Notifier API

Latest api docs can be found here: http://help.airbrake.io/kb/api-2/notifier-api-version-22

Tested and seems to work. I didn't minify it, since I'm not sure what engine you used. If you have a script to do it, please add it to the repo or note it in the readme.
Small typo and sentence construction fixes

Are we going to persist with the "Customer" and "Customer's" not being preceded by "The" or "the" all over but especially heavy in the Support section?

I held off on those given that it is sort of a legal doc. We should minimize that usage n order to be a good manual, where we can, I think.
SOCIALFB-8: First cut at FQL support in Facebook API binding.
Looping and stop() bug, Quiet Mode

Up to date with quietmode branch, that also fixes looping bug, stop() bug, and implements quietmode..
Woops, wrong branch...
Bii

Unser letzter Stand
Replaced 'childrenAttributes' with 'attributes' in MenuBuilder

Id- and class-attribute are not added properly when using 'childrenAttributes' so main-navigation remains not formatted.
Parameter-Reihenfolge von createPagination() passt nicht zu Pagination::create(). Getauscht.
Depends on 684104a (patch-3)

As I understand it, this makes the bottom and top of the clock-face line up better with the rest of the status-icons. Again, could just be me.

All the best,

-HG
try to fix compatibility with django 1.4
Fixed bad links in the view (May have already been fixed but not committed)

Bad reference to .name instead of .person in model.
Bad reference to field list instead of location in view.
add pyramid_workflow
Added validation before changing config
Update to work for future as well as past dates

Hey, James.  Simple fix to account for future too.
Added limit_type="chars" parameter

Limit_type parameter added, defaults to words for backward compatibility.
Make sure cms uses reverse from localeurl

Not very elegant, but it fixes the problem on my dev machine. Would you like to give it a try on the live server?
Fix username rewriting with social auth
Updated AccessGrant so timeout now matches AuthController's access_tokens

Based on the conversation in issue #7, I have set the AccessGrant to last for Devise.timeout_in (30 minutes by default).
Translated はい いいえ to Yes No

Translated はい いいえ to Yes No
guzzoni.apple.com crash fix.

When guzzoni.apple.com cant connec, it will just dropp the connection to the iPhone. Should make a much more stable option for using Tor.
Ch08 french review

Finished the review of chapter 8.
Two commits : 
- the first one to format the code
- the second one for the modifications
I think preg_quote is the appropriate escape to use here, not quotemeta.
OK, go for it.
The problem you're describing has nothing to do with this commit, most likely nvidia-settings is not behaving correctly, to work around it you need to disable dynamic twinview in xorg.conf.
Sorry, I was little confused about what I had to test on layout part. Tomorrow, the first thing I'm gonna do is this.
Does this not cause many (thousands, in my case) warnings matching the following:

`/Users/leehambley/.rbenv/versions/1.9.3-p0/lib/ruby/gems/1.9.1/gems/activesupport-3.1.4/lib/active_support/core_ext/string/output_safety.rb:24: warning: regexp match /.../n against to UTF-8 string`

It is important to be able to escape I18n localized strings in European languages too. What's the suggested fix/workaround?
Ah, good. I was worried that the subtlety might get lost.
use https://github.com/presidentbeef/brakeman, it finds mass assignment vulnerabilities pretty darn well
python 2.5 will work for the foreseeable future but I'm anticipating the day when a gyp update breaks 2.5 compatibility.
http://blog.stevenlevithan.com/archives/cross-browser-split
Well, basically I have changed this because there were too many spam on my debug builds.
Also the warning was inside the for loop, which will check it for different locations. It should be outside.
Also there were no message, when trying to load the "_d" postfixed filename.

```[18:41:36] INFO Trying to load the plugin ./RenderSystem_GL.dll.
[18:41:36] INFO (Ogre) Loading library ./RenderSystem_GL.dll
[18:41:36] FAILURE (Ogre) OGRE EXCEPTION(7:InternalErrorException): Could not load dynamic library ./RenderSystem_GL.dll.  System Error: A megadott modul nem található. in DynLib::load at ..\..\..\..\OgreMain\src\OgreDynLib.cpp (line 91)
[18:41:36] INFO Trying to load the plugin ./RenderSystem_GL_d.dll. <== This was missing in old version
[18:41:36] INFO (Ogre) Loading library ./RenderSystem_GL_d.dll
[18:41:36] INFO (Ogre) Installing plugin: GL RenderSystem
[18:41:36] INFO (Ogre) OpenGL Rendering Subsystem created.
[18:41:38] INFO (Ogre) Plugin successfully installed
[18:41:38] INFO Successfully loaded the plugin 'RenderSystem_GL' from './RenderSystem_GL_d.dll'```
This is not needed, since it's an error if anything tries to use the object after it's been deleted.
As such it's actually better to leave the pointers in their place, since it's then easier to detect these cases.

So, in this case the error seems to be that something is holding on to a reference to the entity even after it's been deleted. From the stack trace it seems to be an issue where the terrain is shut down while there's still an ongoing terrain updating task occurring in a separate thread. I can take a closer look.
I had too many of those mistakes in this pull request :) i'll fix it immediately!
Calling your method "get" and the type of the object it returns is maybe not specific is enough. Very soon, your class has a "get_list", "get_string" and a "get_tuple" and it's impossible to tell what does what.
Hahahahahahahahahahhahahaa lolerskates. This is wayyyyyy less dumb.
I don't think the use of align_to() here makes sense.  The alignment affects on what boundary ptr will be aligned, not the size.  If `align` represented the alignment of the next field in the structure, then this would have the effect of zeroing out the padding as well as the structure in `ptr`, but that doesn't seem necessary to do.
Кодировку поменял, новые файлы отправил.
Про Doxygen почитаю чуть позже, спасибо за совет
Bah, Why is eclipse so cleaver at adding these imports, yet not removing then?
why not simply rely on the parent method here ?
When committing someone else's patch, use

    git commit --author="John Smith <john@website.com>"
Yes. Batshit crazy, in fact.
don't need this line, as it will produce duplicates in unmatched tokens.
GUI**D**... oh well, it's in master now...
Did you do something special within MacVim to disable Cmd-N? For me it opens a new window.
Will think about it. In the meantime, you can check a similar wiki project - [commonplace](https://github.com/fredoliveira/commonplace) for some inspiration.
This is no need to define offset for it is not used twice
Actually, it's unrelated to the prefix.

`DESTDIR` only indicates where the files should be copied to, which is highly desirable when building a package. You could for instance set `DESTDIR` to `/tmp/pkg/jbofihe`, which would install files to `/tmp/pkg/jbofihe/usr/{bin,lib}/…` (assuming `--prefix=/usr`).

Without that, you can't use `make install` to build a package because everything would be copied to `/usr/{bin,lib,…}` directly. If you look at the Debian package, it's not using `make install` (for that very reason).

Note that if `DESTDIR` is not set, the behavior is the same as before the patch.
Simon: What git incantation do you use to pull in single commits from another repo? I have tried various things with cherry-pick and format-patch, and everything but "git show XXX" on the object (to dump a patch that I can apply outside of git) seems to go nuts, pulling in everything up to the head of 3.0, which I have set up as a tracking branch.

Ordinarily that would be fine, but the locales in MLZ are sorted differently, so anything that touches locales produces a huge number of conflicts in each of the locale files; for those commits, it is more efficient to apply the en-US patch, and then update using a local tool. But I can't get git to act selectively, so at the moment I'm basically only using it as an online storage container.

I can cope with my current method, but it's possible to work more efficiently, I'd like to do so.
Hmm, it's no longer needed. :-)
That's broken. That path is not guaranteed.
Highlevel documentation missing! Documentation of implementing class isn't that important.
However interface documentation is.
The fact that this code is just copy-pasted from the ProtoBackend is concerning, and seems very error-prone if we change one and forget to change the other.  Is there some reason that this code can't be shared?
I like Handbrake, but isn't building an .app against the homebrew rules?
Sorry for taking so long to answer. I didn't notice you had written that.
This string is what should appear instead of the number of topics and the number of posts. Leaking that information is really bad idea. It should be a small string so showing "Private forum" seem to be too many characters
fyi, James has been thinking about how to eliminate these silly, empty views. Hang tight :)
Should be: `"#{bin}/ct-ng version"`
Doesn't work for me. I did a make clean. What am I doing wrong?

julia> printf("| %-8s | %3d |\n", "foo", 3)
printf not defined
in run_repl, /Users/viral/julia/j/client.j:22
in _start, /Users/viral/julia/j/client.j:134
If you think it's ready and structured date tests are still pass, feel free to issue a pull request
Using a hash here is too much indirection. Each expected value is used exactly once. If they were used more than once then collecting them like you have done would be appropriate.
w/o is not really a good option. Older people might not know it.
Binary. But they still show up in the Language stats. See for example https://github.com/emesene/emesene/graphs/languages
cant you just put the source of the library?
vagrind with 5 players (bots) not give any leak detect...
ahhh you are right^^
No, It isn't. A quote from [here](http://www.wowwiki.com/Damage_over_Time#Discussion):

>In PvP, DoTs are vulnerable to being dispelled, but have the advantage of continuing to cause damage if the caster is silenced, out of range or even dead.
Ok releved one possible cause, player pointer can be null while teleportation.
If someone have time please try this patch (of this commit)
http://paste2.org/p/1891496
This `require` should be moved up to the main req list, no reason to have it here.
нормальный тест на логику
плохо что он падает, тесты стоит прогонять перед коммитом
How does this code handle being compiled against the 10.6 or earlier SDK? I think you need to declare the protocol yourself when targeting those older OSs.
As far as I can see, the double is not even used ever. Might just replace the double stuff with float completely.
Curious to know why this was removed...
Good job, man!
\ is redundant for ) into [ ]
@malleor done , please test 9d08a4db8520dbb634f8bd9e8f73c2a4fb4d10ed
Once cleanup occures the engine is destroyed. That is when a user goes to us it its going to give back an invalid response. I suspect strongly that that response is going to be very confusing. Could you run a quick test to see what the error given when using a cleaned up engine is?
do_disable? This is to disable mailing authors?
you guys need to jammit.  the point of this commit was to make all templates served from static files (of which, are managed by the jammit gem).

run `bundle exec jammit` and tell me if your issue still persists (it shouldn't).
Did I spam you with multiple responses? If so I'm sorry, don't really know
how that happened, but my mail history in Gmail have multiple mails in this
thread with somewhat the same content.

-- 
Lasse Vågsæther Karlsen


2012/1/27 Lasse Vågsæther Karlsen <lassevk@gmail.com>

> Ah, hm, you should be able to do a manual clone from Github though...
>
> You can either:
>
> 1. clone from github: git clone git@github.com:lassevk/DropChest.git
> 2. download the ready-built binary, built from the next-to-last changeset,
> and the last changeset is not interesting for anyone else either, it's just
> some debug messages
>
> Make sure you remove any old versions of the DropChest.jar file from your
> plugins folder, and then drop in my replacement and you should be good to
> go.
>
> Vennlig hilsen
>
> *Lasse Vågsæther Karlsen*
> lasse@vkarlsen.no
>
> On 27. jan. 2012, at 16:11, sorklin wrote:
>
> Unfortunately, i'm not narrowtux. So I can't do anything about the main
> code base.  I've been following your fork because I'm trying to get it
> working on our servers.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/lassevk/DropChest/commit/200bbe49ae3ac4476ffd12d4108791e8d382ed08#commitcomment-908398
>
>
>
Vincent,

I was not able to trigger errors with 'all projects' in any of the pages from which the print_version_option_list() function is called. Would you mind providing steps to reproduce the behavior you experienced ?

Thanks
this probably isn't the right place for it. the sidebar would work better.
Ok, fixed :-)
that helps for what ?
No, just showing it can do false assertion as well and is using the previous assertion mechanism.
What does this do? Are you demonstrating that it doesn't raise an assertion if the block just returns false?
p cool codez

neat
Try: 

for x in range(1,5):
The `retryWithTimeout()` function is redundant, the `retry()` function already supports specifying the timeout and iteration parameters. However instead of being retrieved from specifically named arguments, they are pulled from the `arguments` variable that all JavaScript functions use. The intent was to allow the caller to specify none, some or all of these parameters as needed while keeping the code readable.
Consider making these protected, they're implementation details. Once you do that, the __ prefix isn't needed anymore.
Why is it sorwimael.rtk? Shouldn't the file extension be .rkt?
Ah ok, didn't notice that. Carry on then
Shouldn't it be 4.2.2 instead 4.22?
Map<String,String> ...
и хватит уже делать мапы стрнгов. вэлью долджен быть объектом в твоем случае
I start to believe that Twilight Halion is spawned in the meantime as Halion, cux this could cause some bugs.
This commit seems to break the screen rotation consistency with the collection view.

For example, when I start the program with the screen vertically: http://i.imgur.com/3jSff.png

now when I turn the device horizontally: http://i.imgur.com/1E5rZ.png

The reverse happens when I start the application already in the horizontal view. It'll show the items, but when I change it to the vertical view, the items don't show.
Обрати внимание, он их реально использует в своих небольших примерах: `AddPoint( CPoint const & iPoint )`
The loadend event is always triggered synchronously now.
这样也可以
Can you change its name to BaseModel? It will be less confusing.
Thanks Mario. We should wait for Memphiz OK on the git rev and enabled it then.
I'm wondering if you are aware of the `cache` option in knitr; saving and loading objects can be done automatically with `cache=TRUE`; it is kind of cumbersome to use `save()` and `load()` explicitly in R code -- I wish authors can focus on writing and forget about these tedious jobs
I did some changes in active_record.rb. To spare you any useless hassle, I merged master into your branch on sferik/mongoid.

Thanks for your hard work.
Yeah, BugTracker also use the old stuff, so I'm reverting this commit while we fix the other issues.
it does test, whether browser.defer.flush() throws an exception and yep, it does, we test that in the previous test as well (angular-mocksSpec.js)...
anyway, not big deal...
@ruoxuwu 必须的
Will -DMPI_CXX_COMPILER override  -DCMAKE_CXX_COMPILER ??
Which one takes precedence?
*overridden :wink:
you should also mention that by default, the algorithm is applied several times and the result is converted to base64.
according to its javadoc getProperty is not supposed to return null so that's not the proper fix...
I don't understand this new section of code from lines 439-514. It really REALLY needs useful comments. Adequate commenting is needed to respect the time of other developers who will otherwise have to invest a great deal of analysis into understanding what's going on.
insert:
```
//SANITIZE ALL ESCAPES
$sanitize_all_escapes=true; 
//

//STOP FAKE REGISTER GLOBALS
$fake_register_globals=false;	
//
```
hahaha :) pewnie jest na to patent ^^
Нямам си и на идея :) Може да е сложено по-късно
Yes, i would have noticed ;) and there are so many deprecation warnings that I overlooked these.
I checked that it does raise a warning, though.
There is already one: #1059
Ah I see. It comes from passing the options to script local vars. I'm aware of the side effect and provide a command in ctrlp to reload the options, but didn't think it'd be much of a hassle. Perhaps it's time for some changes.

Anyway, I saw your tweet earlier and just thought I should ask. Sorry if it's inappropriate!
Preconditions.checkState(port >= -1, "port is negative")
This commit seems to have broken the admin meta box for product data. It's displayed as if JavaScript isn't enabled. Reverting this commit brought the tabs back. Could you check it out? Thanks.
Det är väldigt sant.
Checkbox needs label tag, see my other comment.
Aren't you just introducing a spelling error?
Thank you very much for your sugestion, I will try it and test it.
I didn't delete them, Xilinx ISE did when it regenerated the Coregen blocks.
Bonjour,

J'aurais aimé savoir quel intérêt a cet boucle?
Est-ce qu'il s'agit d'un test navigateur?

Pour moi, enumerables passe toujours à null ici...
<code>.hprof</code>에 대한 링크가  있으면 좋을듯?(http://java.sun.com/developer/technicalArticles/Programming/HPROF.html)
CalledFromWrongThreadException 対策

etResponse.setText(nico.login(email.getText().toString(),password.getText().toString()));
HttpClientの処理結果を表示させるのを、NetworkOnMainThreadException対策のため単純に Thread に入れても CalledFromWrongThreadException が起きるためHandlerクラスに表示処理をさせます。
Where does this link go and why?
You probably want to mention what the correct length is here (40).
the typehint should be ContainerInterface instead
use @Mock (& MockitoAnnotiations.initMocks(this) in setup) instead
Sweet!! Nice find madhacker3kxl! That works perfectly!
Tabbing is bad.
Um... seriously? 
"DELETE FROM `conditions` WHERE `SourceTypeOrReferenceId`=18;" Wut? 

So you remove this: CONDITION_SOURCE_TYPE_ITEM_REQUIRED_TARGET and replace with SPELL_CLICK_EVENT.. This I understand. By why exactly do I want to remove my 200+ item required targets from the table to input a bunch of quest requirements... which by the way do NOT all align with any supported skyfire database. Furthermore, where are the rest of the sqls? "Update a typo in original data entry".. What typo in what data entry? It seems like we are missing some seriously important shit here. I for one will NOT run this sql on my database.... Truthfully it should be removed from master, as it WILL cause a LOT of broken shit.

Raydeon
Be my guest! :)
This may be my groovy ignorance here:  but does `bloodPressure` get assigned only in line 155 below?  Will it only be `null` once?  How do you avoid just overwriting the same element multiple times?
ten wiersz można usunąć...
**notes**:

  * tutorial.rst is not a new file - just accidentally didn't move it with git mv... so it thought I deleted and added a new one..

  * savefigs have been removed from plot files in the example folder.

  * plot_digits_first_image is to generate the first digit for the scikit-tutorial first page.
I'd add an extra test `if [ -f /usr/local/bin/virtualenvwrapper.sh ]; then ... fi`. If you ever use them on a PC/mac where you don't have virtualenv installed (yet?) it won't throw errors :)
create load controller instance
sip, pero cuando las tocas, te dan un toquecito, y pum desaparecen jajaja
Now just one bug to fix : phone shuts down & restarts when locked.

Might be cpufreq instability... Or cpuidle, see picture below for reference.

 https://lh3.googleusercontent.com/-qhS5JVC5Z_w/Ty73GTgjOcI/AAAAAAAAADs/Jws_m374BGc/s400/screenshot_2012-02-05_2239.png
only THE FIRST copyClick callback gets executed fix!
Fixed in my recent commit. Thanks once again.
cool, seems like an interesting idea :)
Capitalize AND, use two lines:

```
  public static final String TBL_KEY = COL_ACCOUNT_GUID + " = ? AND " +
                                       COL_PROFILE + " = ?";
```
Do you mean:

```
Editor edit = getEditor();
edit.putLong("serverClientRecordTimestamp", timestamp);
edit.commit();
```

?
Is `db.store` synchronous? (Very likely, just wanted to check.)
Part | Points
------------- | -------------
base | 1
*Total* | 1

Passes tests. :sparkles: 

```python

    if w < 1 or h < 1 or type(w) != int or type(h) != int:
        print "Error: Invalid Dimensions"
        return
```

What you're doing is similar to the concept of [Exceptions.](http://docs.python.org/tutorial/errors.html)  (other info: https://en.wikibooks.org/wiki/Python_Programming/Exceptions http://www.diveintopython.net/file_handling/index.html)
If the github commit viewer is showing "that.png" instead of "this and that.png" above, something is wrong.
@croby shouldn't this have a `var` in front of it?
Interesting how now, after we've had some time doing ruby, I can see the one-line version of this whole setup.
This is my habit to avoid "recursive require" error.
Add platform support tags for this method.
no it doesnt yet... use a win machine to patch ;)
 then port over. that used to work.

...and mac ACK!!! lol
Arent you missing that somewhere else?
Perhaps you could create a new/separate storage connection with imaginary keys (something like 'XXXXXXXXXXXX' or whatever) and generate the keys from that.  Since it does it locally it shouldn't care that these are invalid but should return something more consistent.  That would be my first inclination anyway.
General remark about the constness: Using as strict as possible interface reduces the number of mistakes a programmer can make and allows a compiler to perform more aggresive optimizations.
Missing "}" of if block
Is that caching done for performance or for correctness reasons?
At the time I was trying to be sure that my change wasn't propagating outside that class, I wasn't entirely sure another class wasn't accessing it through the val. So I wanted to see if any errors would show up. I decided to leaver it since this value isn't always going to match the local ip address used in the rest of remoting, it should only really be used to initialize the Netty server so I felt using it externally should be discouraged.
afaik this are non local returns, return is required. The whole ReflectionUtil is quick and dirty copy paste from Java. I was tired. Just wanted to have something that is working. Will clean it up.
This isn't sent to the sender, just FYI
yes thats better.
if you remove this, then isBoundTo is not called anywhere else, are you sure you didn't break anything when removing this?
I can easilly implement this without ScatterGatherFirstCompletedRouter. I tried to dogfood. Why is it bad? This is not performance critical in any way. If ScatterGatherFirstCompletedRouter can't be used for this I think we should remove or rewrite it.

/Patrik

14 aug 2012 kl. 18:27 skrev Viktor Klang (√) <notifications@github.com>:

> ScatterGatherFirstCompletedRouter
if it's atp, do you want to tag? or better yet, do warden in a new branch?
dim doesnt seem to be a parameter in the __init__
may be call it c_dim ?
Agreed.  I'll add the docstring.
FYI, you can tack these onto the leading sentence:

The new repository can be seen with its unique ID and display name.::

Not saying there's any benefit to it, just a heads up if you didn't realize.
Can't do this with gettext.
`$` isn't `require`'ed
Use `+=` or `%` but not both!

```python
e.msg = '%s (%s)' % (e.msg, msg)
```
Done. Now I just need to fit all this info in the Analytics API. Thanks !
I don't disagree - this has been the subject of some discussion between Daniel and I. But I don't think it's sensible to have the 2 copies of the code differ, and I don't think it's likely to be an issue in practice. It may be more of an issue in pip, where we don't rank the wheels (so a 3.1 wheel could be picked over a 3.3 wheel). But I'd rather wait for a concrete problem to deal with it.
check_catalog_presence / $repo_name
return $?
Just to make sure, System.nanoTime can be negative and wrap around, is this parried for in this class?
erk wtf?
Looks like there are some mixed tabs and spaces here. Can you convert these comment lines to using tabs, and make sure they line up with the indentation level of the `for` line?
Not really, previous check return just a string. Though I may improve this code tomorrow.
I couldn't get it working with a null check or a default value for length, but I only gave it about 10 minutes before I gave up. Any specific ideas?
Done, see https://github.com/idralyuk/ql.io/commit/22b4accb27c5195313c87bfe30dc916270c0651f
нет такого файла вроде
It's an extra space. This blank line should not be there.
Agreed. Also updated.
`merge!` here
>Maybe I would place an implicit default in the parallel package object, so that people who import collection.parallel._ get it, and people who just call par don't get a default. That way both schools of thought can be satisfied. :)

An implicit in the package object is actually part of the implicit scope of all types defined in the package.
Agreed. I would vote for NonInternal, or smth similar.
hasRepeatedParam?
I left these literals out as SIP-11 defines the simple escape form as `$` followed by an identifier, and `null`, `true` and `false` are no identifiers. If we support this, people might expect that it works with other literals as well, e.g. `f"$4%10.3f"`.

Moreover, I think `$this` could be useful, but I do not see why to write `$null`  and not directly `null` in the interpolated string (same for `true`  and `false`).
Deleting lines 933 and 934, could the rest of match function be written as--

matchdict = {}
for k in f1.keys():
       if k not in f2:
            return False
       if len(f1[k]) != len(f2[k]):
            return False
       for i,x in enumerate(f1[k]):
           matchdict[x] = f2[k][i]
return matchdict

This is because, after simplification, if functions are equivalent, then the keys must exist in both 'fingers' and the no of variables with those keys must also be same.
It was for a comment so that a type error wouldn't be triggered. I don't get an error if the lines are commented out. I do get an error if they are left uncommented. So at least on my machine this seems to work. 

What is the standard practice in this situation?
-> Create a nice table representation of data.
Thanks for both!
The first line `assert G.coset_unrank(48) is None` is still there;
the other two depend on the implementation of `schreier_sims` and on the ranking algorithms,
which were both changed; what matters is that `G.coset_unrank(G.coset_rank(gens[0])) =- gens[0]`, which was tested 
already above.
Try use the double colon:

```
rules::
    Imaginary**integer -> Imaginary
                                                 if integer % 2 == 1
```
They are, though only when they are needed.
```{``` is not needed. Ruby automatic detect hash and pass it
there is a button *loop*, so I think this line can be deleted.
oh, by check for options you mean on the if empty()?

That to does not make it for the changelog

The changelog file is for users to browse what issues has been fixed or new functionality added to the new version. So it makes no sense to write there something like styled code in the class XY or added a check for empty in class XY if that is not fixing any known issue.
Since this helper has been removed this line should also be removed.
We should remove the mendatory comments in checkstyle... doesn't make any sense on interfaces like binders and we don't need @author with a modern vcs... since it keeps the history of all contributors.
right, then :host and :port options are also needed
Looks like this particular NetworkRelativeEffect is only used for displaying the confidence interval, and is now based directly on the Quantiles (overwritten the getConfidenceInterval() ) so it should be okay ... also see the commit 66be106
It looks like you've doubled-up on the JANKY_CHAT_CAMPFIRE_TOKEN line.
Use `uv_sleep(msec)` here.
Expected space between `)` and `{`.
Blah, of course.  Maybe change the comment to "it's technically impossible to have more than one cycle with 3 registers. THIS SHOULD NOT HAPPEN." or something? I read that as "it's not allowed to have more than one cycle with 3 registers".
Ok. good approach. will use it
:child_question => true
make this imperative: Do not use the positional operator with...
c/it will not start/it will delay
It's probably worthwhile to mention (at the end of this document) that the same information can be seen in MMS.
Sam, What warning is needed here?
Sure we can. I just the "_" at start to make it look "private" since are only using this variable to feed "mentor" and it's not a form field. Do you think I should remove the starting _ ?
Remove if no tests.
It seems to me that message should become required and the first parameter.
I have no idea what error it throws, can someone with IE installed
test this for me?


On 4 May 2012, at 07:13, Senky
<reply@reply.github.com>
wrote:

>> @@ -502,7 +532,7 @@
>>    <p>In SQL statements mixing single and double quotes is partly allowed (following the guidelines listed here about SQL formatting), else one should try to only use one method - mostly single quotes.</p>
>>
>>    <h4>Commas after every array element:</h4>
>> -    <p>If an array is defined with each element on its own line, you still have to modify the previous line to add a comma when appending a new element. PHP allows for trailing (useless) commas in array definitions. These should always be used so each element including the comma can be appended with a single line</p>
>> +    <p>If an array is defined with each element on its own line, you still have to modify the previous line to add a comma when appending a new element. PHP allows for trailing (useless) commas in array definitions. These should always be used so each element including the comma can be appended with a single line. In JavaScript, you should not use the trailing comma, as IE doesn't like it.</p>
>
> This probably should be rewritten - you can keep the last sentence, but, please, state after it what is a real problem (IE throws error); "not liking" is not serious problem...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/phpbb/phpbb3/pull/779/files#r772556
You need to make two branches, one for 3.0 using e-mail and one for 3.1 using email :/
should be prefixed with phpbb_
We might have global checks for this already, please research whether we do and if so all related code can be removed from postgres search backend.
Most of the rest of phpBB seems to use <br />

Makes more sense to be consistent?
Yes, the last one please, if the logic is still the same.
parenthesis in the if statements... not too keen on
Probably you should not call these functions get${direction}Vector() but just get${direction} (e.g. getUp).

BTW getTargetVector name sucks twice.
Shoes::Logger will wrap basic logger commands and instantiation.
we'd setup a global #logger that points to a Shoes::Logger instance.

def Shoes::Logger#initialize
  @logger = if Shoes.backend.defined?(Logger)
    Shoes.backend::Logger.new
  else
    ::Logger.new
  end
end

Thoughts?
Peter Fitzgibbons
(847) 859-9550
Email: peter.fitzgibbons@gmail.com
IM GTalk: peter.fitzgibbons
IM AOL: peter.fitzgibbons@gmail.com


On Tue, May 29, 2012 at 7:10 AM, Andy Lindeman <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,17 @@
> > +require 'delegate'
> > +
> > +module Shoes
> > +  module Logger
> > +    class Log4j < SimpleDelegator
>
> I'm not sure what you mean exactly; can you gist some code samples of how
> it would look?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/shoes/shoes4/pull/26/files#r891736
>
Pretty much the same behaviour, it can* be done at any time. I just fancy this method :)
Sure.  This file was semi-experimental to start with. Still should be well doc'd though.  (It really is a shining candidate for the mythical "mojito_dev" package.)
Won't pass jslint with multiple var statements. I think we want our test files to be lint-free.
code style - { should be on a new line
Remove these lines or fire event?
Actually, the OpenMRS code didn't allow the doctor to void Obs, so I thought the same.
Watch out for the change in class hierarchy of `GeogCS` and `RotatedGeogCS` - we still want to be able to save rotated pole data.
Why was the filter able to be removed?
逻辑判断。如果类型是boolean类型的话。 if (b) 或者 if (!b)就可以了。
backRect.mouseover(mouseOverBar).mouseout(mouseOutBar);
again "incorrect" rather than "wrong"

"for instance" -> "for instance, by"
Not related to the changes in this PR, but could this be a source of non-determinism in tests? (since we break on the first item, and the order is not fixed). Would there be a way to make it deterministic?
It would be nice to put this comment on the line above the statement, rather than make the line so long.
I was totally confused by this funcion's name and initial javadoc comment.
I thought it was some kind of metadata functon that "set...Types".
Maybe rename it to convertExtractedParametersToMatchTypes or the like.
Also the wording "the types of the params are not always accurate" makes it sound like we made an earlier attempt at typing. A better explanation would be "the extracted params are all represented as Java strings exactly as formatted by voltGetXML".

Instead of "fix those types", how about "create [or serialize? see below] Java objects that are more appropriate to each parameter's type".

Since they are all strings, maybe m_extractedParams should be a String[].
Yes, then it could not be reused as both this function's input data and output data, but that's OK? -- there's more below on an alternative output option.
What problem is being solved here? Maybe I'm being lazy and it's in the commit message.
nitpick: The hash could be of anything, doesn't have to be an `ObjHash`.  Naming is hard.
Leading whitespace here. (Wish GH's diffs showed that like Git's did.)
I'm down for that. I'll add the comment.
Should be split_criterion_name according to the code.
I believe this is a left over todo based on when this code was using a hash table instead of a sorted string.  On the surface this is a good thing, but the problem was that it was a global hash table and the assumptions about the hash table's current state were invalid, which is why keesiong rewrote it to the current form.
I think we can wrap these lines at 80 columns, to make it nicer for people viewing this in GitHub's web UI.
Just `depends_on :xcode`, no `=> :xcodebuild`.
Finding the SDK is now handled by `MacOS.sdk_path`. It's smart enough to deal with different installation schemes. 
I recommend to use `MacOS.sdk_path.to_s` because in cases where no Xcode is present but the "Command Line Tools for Xcode" are, this returns `nil` and the `.to_s` an empty string in turn. And that's alright, since the sdk is basically located in `/usr` in that case.
Ok, debate time...

I will happily do this, but I want your arguments as to why, and how this will improve the quality of the code/application.

Here's my reasons for doing it as I have:

* It's code that is only ever going to be used on this page - why hide it away in another file?
* It's not that much code so it's not going to affect performance.
* It uses variables only available in the mustache templates - to extract out this code we'd need to create a global config object or something in order to house these variables, (which are only going to be used here), and then have the extracted code read them from there.  To me this smells of making the code far less straight-forward to read and a bit of over-engineering for what is a simple bit of functionality...

As for the wrapping it in an anonymous function, we can do that but again, it smells of over-engineering for the sake of it - we're not building a library here, just adding some functionality to a page, adding two functions to the global namespace will not hurt.
This breaks and L367 breaks some apps which do things like:
`<input type="hidden" name="requesttoken" value="<?php echo $_['requesttoken'] ?>">`
As far as I could test if the file is open unlink will simply fail and the file will not be deleted (until the file has been served and cron is not called again)
Just a heads up that going forward Redis might not be running locally.
This is what `cfg.emit` is for.
The intention isn't to run this against production redis. Probably needs some help text in the description.
Okay. It's definitely better than before :)
No big deal Abe.  DOS people would appreciate it :-)
Where exactly does this ValueError occur? This try clause is extremely general. Can you please change it so that the contents of the try block are as specific as possible?
I think I like the previous version better: it had a colon at the end and was thus related to the example which follows.  Am I missing a subtle language issue?
nit: nuke this
Will fix where I can see it.
I was just thinking something like "Let the process complete even if this thread is not finished."
I think extracting these static members into an own class, say `Recording`, would make the whole test easier to read. That way, you could simply assign a new instance to a single static field in the `@Before` method. What do you think?
Probably more correct to exit with $GLOBAL_EXIT_CODE, though I figured the two scenarios were mutually exclusive--there's no one there to Ctrl-C on Travis and if you're running it locally you don't necessarily care about the exit code.
Dan the original reason why I was doing it in base was just an attempt to get it in at the end of the app lifecycle, but you are right the code would probably make more sense in UI, but would also require a bit of a refactor in there. I will test and see if it will work.
I don't think this function does enough to be exported by this module. I think it should be removed from the exports to simplify the API.

Actually, I am not sure it's even worth having a function at all.
Why is this in a self-running function? Can't you just move this code to the module definition?
nice tip! thanks.
Since addBinding() can take an array directly, is there any need for the forEach() here?
You can also pass command object (returned from CommandManager.register()) to addMenuItem() instead of a command id, so at least 1 test should do that.
I think you want `{APP_NAME}` in this one. For Brackets `APP_NAME` and `APP_TITLE` are both "Brackets", but for Edge Code `APP_TITLE` is "Adobe Edge Code" and `APP_NAME` is just "Edge Code", and I think we want to use the shorter form everywhere except the "About" link (so we have "How to Use Edge Code", for example).
In brackets.js ``require.config()`` we should update to:

```
require.config({
  paths: {
    "text" : "thirdparty/text",
    "i18n" : "thirdparty/i18n"
  }
});
```

...so that this require call can be ``require("i18n!nls/strings")``
Already both CSS and HTML apparently can use that feature, and any languages introduced by third parties can't do that if we don't expose it in the `base_handler` interface. However, to expedite things you can make an issue for this so we can address it later.
If CloudCare deleted the alert-success node instead of hid it after displaying it, it would make this a little cleaner.
All accesses to this map should always be through code running on that netty channel's single I/O worker thread
This error is raised if there is something else than layer or style in the toc, this is an error for software developer. The user can't do anything to solve this issue.
please never use ```new Integer(1)```. If you have to, do:
```java
Integer.valueOf(1)
```
But in this case, replace all your ```Integer``` by ```int``` (autoboxing in java 6), including 'frequency' below.
Sure, let's just store in git config then. That makes sense.
I'd really like to not have a limit on queued items.
It might make more sense to just include https://github.com/douglascrockford/JSON-js  in the build.   Usually I do this by adding a submodule.  If you'd like you can leave this in, and I"ll probably just do a different pull request to swap it out for Crockfords version bundled in.
What about this? Escape it too. Check the list of all builtin tags and filter to see how. :-)
There was also a bug that it tried requiring a migrator before it even checked if it was an available one, which I've fixed alongside displaying the list of available adapters/
.
could you rename `:tag_name` to `:title` - it would reflect actual attribute name in Picasa API
Again, what if link is undefined? I think we need safer checks here.
Same here. Looks like you actually implemented something similar here: https://github.com/mozilla/butter/pull/821/files#L2R31
Make this 4, it computes to between 12-13, which is closer to the original default.
I think it's unclear.  You can't really set top and bottom at the same time.  Why not break this up into some selects?
Lint sez: `src/util/dragndrop.js: line 424, col 6, Missing semicolon.`
Also, why is there a bunch of inline style here? Can you put it in your <style> declaration?
this declaration is invalid, !important needs to go before the semi-colon. However, the fact that this works with the invalid css says to me that you don't need the !important syntax here.
`-items[j] / font.spaceWidth` is equal to `fakeSpaces` is this point, no need to repeat calculation
@nvcVincent Do you see this? Change and send me a pull request. I'll push it to my master.
haven't fully reviewed this code yet, but is this perhaps called from another thread?
`typeset -f` fails pretty spectacularly on OS X.

    bash: typeset: cannot use `-f' to make functions

Any ideas?
Don't you have to free bsFileName?