labofsahil/github-event-dataset-2012 huggingface dataset:
Sounds good. Once I started considering how subversion and other VCS would be taken into account I realized a Twig helper would probably be better but wanted validation on the idea first. :)

I'll do it as a Twig helper.

Thanks for the feedback.
@samiluukkonen Pitäiskö tossa varsinaisessa selectissäki (rivillä: 145) olla tilkpl > 0 niin ei turhaan loopata ja tsekata hyvityskeiseissä?
The different dict implementations exist because they have different storage and performance requirements. In my opinion, if we can allow the user to choose his favorite implementation without imposing one, I would prefer if we did so.

If the user wants to pass a non-empty dict, that's also up to him (i.e. i see no reason to limit it) :)
It's funny — I was just about to request that!  :^)
use multi-line string and shorter lines for description
Add dot at end of sentence.
Agree with Jens.
Yes, that would be fine as well (I prefer `wicketear`). I really should have said we don't want the nested package.
hashCode is provided by Type. The goal is to force sub overrides
Though, oddly enough, the behavior here ends up being correct: Since cache_key is null at the time revalidate() gets called, the response from unsupported request methods doesn't get cached.

But, that's just an accident, and this needs to be coded better. I'll probably commit some tweaks to fix
I probably don't need to comment each line, but just sms -> SMS where you see it, please
I think this should be in performance.py with its locator.

Iit's not global, as far as I can tell from a quick poke around the site.
The display name is only populated in the else part of the statement. I tested it by removing the dn population from the else statement and it fails to create the display name under any circumstance which made me feel as though it was just being a piece of "show" code :L

I'll just add it back in.
Should I change this now, or do I need to wait for consensus or what?
Since there are someother tags affected too, you could put a loop around the test definition to apply the same test to other tags too (there are examples in this file for that)

Otherwise looks fine to me! :)
I tried doing that at first using `db.close` and `db.open` to reopen the database but failed, since `db.open` didn't behave as I expected it. I've figured it out now and have fixed this in a future commit
Can you not set a class attribute called something like `exclude_fields` instead of the `.pop()`?
Just curious as to how you created these files. Did you use rails generate controller? How often do you used the generate scaffolding/controller/etc. command as opposed to manually creating these files
I think report would also be better here.
The bit above though, how do we currently check if a data stream is accessible in tuque?
Ok, I understand. The "getChildrenMap" method is in the DocumentReader as a convenient way to get all of the children (rather than getting all the child reference nested documents) in the same form as the added/inserted children. Makes sense.
This produces things like `20120712` for today's date, add better formatting.
Yes.

I think the simplest thing to do is keep this predictable behaviour of "always send the message, even if we're not in the process of state change"; therefore rescuing a 404 would be the right thing.
This probably should not be passed into rules. Will comment below on where it's used.
I must just be confused, but don't you want to output at the destination path?
Why did we remove this part?
please add a doxygen file header
@mattvarghese approves
@parndt sorry, didn't get around to it during the week. Here it is!
Does this actually need to be a route? Doesn't the `index.html` from `public/` get served by default?
We should really call this groupId. A UUID is something of the form 550e8400-e29b-41d4-a716-446655440000
This method is a duplication of `Form#submit` I would instantiate an instance of form and delegate this behavior.
At this point, I didn't care if there was a player match, as all I cared about was it being a player. Player name logic I was leaving up to the scripter for now. Suggestions?
@dwbuiten You did not review it carefully. This too belongs to a cosmetics patch, hence OK.
I really don't like single character variables...
on this specific line
короче проверил, метод возвращает  указатели на одни и те же константные объекты, поэтому это эквивалентно тому что предложено в первом комментарии. и из того следует что будет работать сравнение указателей. В целом по проекту - всё ок.
Можно использовать isNotEqualTo.
Перейди в свою ветку и выполни git rm filename - потом тебе наверное нужно будет коммит сделать и запушить код.
этот метод присваивает по умолчанию роль user. Предлагаю назвать его set_default_role например
не знаю, я в гитигнор всю папку nbprojects кинул
А если статус, например, created, на что там в show смотреть?
Быть может, лучше:
```ruby
unless @game.status == :started
```
$options are type hinted to array, this check is not necessary
does contextMenu not have a feature id?
> When the route changes the todo list should be filtered on a model level
With synchronization, the copying here should be unnecessary.
Based on how I've seen this class used so far, it seems like it'd be convenient to have an initializer which just accepts the `execute` block (like passing `NULL` as the first argument).
I'm still not really sure what you're getting at here :\ It's in the Project group, which is correct. That means it's not public. It's part of both ReactiveCocoa the framework and ReactiveCocoa-iOS, which is correct.
Oh yeah... I think this code must go to platform's driver. The current code did not work to me (postgresql 9.1)
You're mixing Test::Unit-style ```assert_*``` and RSpec expectations here. This should probably be:

```ruby
assigns(:topics).should_not be_nil
```
Why VFAT? This code is executed only in the emulator mode, not on Kindle. Also, not relying on the success of rm would cause mkfifo to fail if the file already exists (e.g. if we run in a directory to which we have no write permission and so can't delete anything).
Could go either way, just curious if there was a reason.  Mergin
see last comment, testing-stuff. for the actual example this doesn't belong there (the data_cov)
take this check outside the function. Don't call the function if no 'filter' was provided by the user. Also use if (query.filter) instead
You are not using docRouter module, so remove it please.
Can I ask for an advanced feature?

Wrap OSI like so:

    :term:`OSI`

and add an associated term in `glossary.rst`

You can then wrap any occurrence of OSI such, and they will link back to the Glossary term.
Run rake assets:precompile ;-)
I would really like to combine the `duration` and `dot` argument somehow, since it feels a bit verbose to have a special parameter for dots. Maybe we should make it possible to make `duration` an object:

    teoria.note('c', {duration: 4, dots: 2})

Or maybe you have a better idea?
you could even take care of the optimized instantiation code dumped even for the first request (thus, it would make it behave more closely to others):

```php
<?php
if (!$cache->isFresh()) {
    $containerBuilder = new ContainerBuilder()
    // dump the container here
}

require_once $file;
$container = new MyCachedContainer();
```

This is what is done in the Kernel for instance
Please place an empty line between 285 and 286
Those commas are  part of the Symfony Coding Standard and should be kept in all the examples.
to use who? the factories?
The 2 examples are now different, it should be better if those are equal but in another syntax.
there is also ``finishView`` (named ``buildViewBottomUp`` in 2.0)
语序
I think we want parens here based on current style guide?
The issue is that we need to specify which, a file or a folder, we create.
I thought we agreed on forcing file deletions, even if people have it open on a tab, because that's important. Not forcing it makes rm useless, there will always be someone who forgot to close his tab on the file, and you'll never be able to delete the file. Editing has to be interruptible anyway (think server restart or you want control back on a file you accidentally left public for editing). Why did you change your mind?
По типу видно. Тут тебе не полотно кода на 100500 строк
Да нихрена не читабельно.
Idem acá, habría que quitar los estilos inline.
wrong charcater
Please move this to where we do the other config validation, near line 170 or so.
I'll go ahead and change this to nullable and we can solve this mystery out later.
instead of returning _null_ and having to document the meaning of the exceptional return case, it would be semantically equivalent to return cacheWrapper.getCache; it also avoid a second lookup.
Cassandra ?
why iterating by reference ? You don't need it
Oh, my bad. It was just moved up. Ignore my previous comment.
No you don't have to clear the lock. It closes automatically once the event loop spins.
Actually, this exists generally so don't worry about doing this for this patch
Oh. How is this coming in? I will remove it :-)
Not necessary to put the index of an object in quotes, and in fact, preferable not to.
I vote for both `%{title}` and `%{note}` replacements, and just change the `%note` currently in the database to `%{title}\n\n%{note}`.
Well, if it was at a central location that would be good, but barring that it makes more sense to me to have it in the same directory rather than somewhere that only exists on one machine. The normal practice would be to host the sap-ui-core.js file in the same Git repository as the application, but given SAP's licensing restrictions that is not possible. Just one more way that SAP is shooting itself in the foot with developer licensing.
Version hell indeed! lein was working just fine, then having this in the project file started causing problems. I'm using v 1.7.0. I'll upgrade to the latest pre-2.0 and try again. I'm wary of moving to lein2 just because stuff seems to break randomly with minor upgrades. I can't being a bit gunshy, but if you think it's worth it I'll give it a shot.
if you also put it into the header the browser can show it in the url-bar rss dropdown
This will be loaded from the /, /register, /content, etc. for which a redirect to /noscript.html will fail. We should be redirecting to /noscript, and map this in nginx.
Agree, I think documenting mixins is a good idea (especially for more obscure ones - clearfix et al are standard enough to explain themselves). I'm a bit surprised we have so few mixins, given how powerful they can be, but I guess the compass mixins are filling the gap.

I'll fix up the name thing.
what about returning this array? e.g. return array(...);
I don't think we want to exercise the build_stubbed factories, just test that each factory is valid.

On Oct 19, 2012, at 1:56 AM, Adarsh Pandit <notifications@github.com> wrote:

> In templates/factories_spec.rb:
> 
> > @@ -0,0 +1,9 @@
> > +require 'spec_helper'
> > +
> > +FactoryGirl.factories.map(&:name).each do |factory_name|
> > +  describe "the #{factory_name} factory" do
> > +    it 'is valid' do
> > +      build(factory_name).should be_valid
> > +    end
> > +  end
> Is a separate block is required to exercise the build_stubbed factories?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Not sure about >= here.
Hmm okay after a search in files for that, I guess it's not. I'll work on this later.
Are you sure ``$attribute`` has the correct type as "integer|string" is not a sub-type of "string"?
Remove the PITA message and props in this comment.
Similar to above, in the name of pep8 compatibilty, could you remove the extra blank lines here and a couple ofther places?
Something bothers me about the way you name things but I can't quite put my finger on it. They feel... excessive. Like you're trying to make things important by giving them big scary names? I know it's high fantasy and everything but they just feel kind of forced.
Shouldn't that be: "https://github.com/carhartl/jquery-cookie"?
Maybe 'Custom' instead of 'Customized' ... can't decide.
GitHub replaces tabs with four spaces. It'll look better in an editor.
This magic number is a string of the form of a license key.
Shouldn't it be ... downloadable _formats_ ... ?
But, then i can't used locale.setlocale() for parsing slovenian date: datetime.date.strptime(slo, "%d. %B" )...
Why remove `unique_with`? You should extend it to include date, too.

I see that you don't understand how above query works. Please take some time to learn about that and to understand it.
See this [template](https://github.com/wlanslovenija/nodewatcher/blob/master/nodewatcher/frontend/templates/registration/activation_email.txt).
Can you move it up, after other authentication backends data?
Yes, and you could deduce wrong if you remove too much from the list of opened connections. You remove from the list something for other channel, while user is still connected there. You think she is offline, while the other channel is still open.
No need for this, this should already be done by global callback.
Group imports, order alphabetically.
Yes, your original code style is OK here. :-)

(Is it really necessary to specify second empty argument? Sometimes jQuery is smart and knows how to detect which parameter is which.

"slow" is a string constant.
`ARGV.build_universal?`
This phrase should be checked carefully and edited appropriately for the correct singular/plural noun forms! Read the comment in the code before the phrase.
Probably shouldn't have a default, right? I think we'll only end up querying by capacity for claimed venues.
void UpdateAI(const uint32 diff) -> void UpdateAI(uint32 const diff)
Same here. We should check that we are only showing deployables that are associated with the selected pool. Add a deployable not associated with the pool in the test.
again, not threadsafe.
By inherit I mean `B extends A` because of the return type and the fact that one need to know if you want to call a property, entity or global level property, you cannot really reuse the same method name to refine a given setting unfortunately.

We could work around it by requiring some kind of .end() method to tell that you are done with a specific level but I am not fan of that. It makes simple config weird to read.
> Infinispan is an open source in-memory data grid focusing on high performance. As a data grid, you can deploy it on multiple servers - referred to as nodes - and connect to it as if it were a single storage engine:

good point, fixing.
This now no longer does the test at all in strict mode. That's not desirable.
However, you have two `deferred` (hence two `deferred.promise`) in the scope (one masking the other), which makes it ambiguous. You may want to rename the inner `deferred`. Right now, I have no clear-cut idea regarding how you could call it, perhaps `deferChain` or `nextDefer` or something such.
Nop, te azure proyects are not included in this solution, so yes, I think
we still need it.

/kzu from mobile
On Jun 12, 2012 12:16 PM, "fsimonazzi" <
reply@reply.github.com>
wrote:

> > @@ -0,0 +1,263 @@
>
> Do we actually need the new solution? The only parts that rely on the
> tools being installed would also be part of this no azure solution.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mspnp/cqrs-journey-code/pull/521/files#r967672
>
Check my original response for that
The CheckStyle is good with the whole change. I tend to run the task `phpcs-ci` each time with my PRs
Some others distribution could have network manager and not have systemd ( for example, Debian do not plan to use systemd due to lack of freebsd support, and yet may use networkmanager ).  I am not sure that's a safe assumption to make, as this may act weird in corner case.
Don't forget to call srand(time(0)) beforehand.

Please use:
const unsigned short randomPort = rand() % USHRT_MAX + 1025;

This will generate a random number from 1025 to USHRT_MAX(65535).
A tougher case is described here, statsmodels with numpy.linalg.pinv fails 

http://jpktd.blogspot.ca/2012/03/numerical-accuracy-in-linear-least.html

I started a linalg branch, to switch to scipy.linalg.pinv2, but it looks much slower. So, I postpone any linalg improvements.
When you use symbols like ``*`` or ``|`` in a docstring, you should surround them by double backticks so they're rendered by Sphinx as is. Now it will consider those symbols like special characters (``**`` is bold I think) and therefore you'll get rendering errors.
Still think we can get rid of this copy. It's taking time.
I merged this into one section Results Classes
Again, I'm just sharing my opinion, but in this case you're not chaining actions, but check that value is here and then process it. For such cases I usually use `&&`. Honestly, my attitude changed a bit later and looks like I use `&&` form almost in all cases now. So it's up to you.

What really surprised me, now, when I looked at it closer, is that you're checking existence of a value in a hash at some key and then pass both hash and the key further. That feels strange. Basically, you check some value and then do nothing specifically about this value. Wouldn't it be better to move that check into the `get_range_start` method? I didn't read this method yet, so it's just an idea for now.
`all` should be removed because you deleted the `all` target
Again, see above. Please form comments in a consistent way (space after #, upper case begining).
also, if there's no format, the default for type-less input is `text`, so that's a sort of win? but i agree this is gross.
Same comment. Abstract is not needed. Redundant. Codestyle will see this as a violation.
Standard practice so far is to use all-lowercase for kwargs; recommend changing to `bp::arg("image")`.
I think it would be clearer to write out the 4 cases in xValue and kValue.  We can worry about optimizing later if it turns out that the if jumps are a slow point in the code.  But it's probably easier to explain the code there in comments than the code you would need for option 2, and I do think there is value in that.

For example, my guess it that you would still be able to reduce them to 2 cases (i.e. a single if statement) with the use of abs values, so I don't think you'll end up losing much, if any, efficiency from doing it that way.
I hate adding specific entity exclusions to things like this, it should be an interface but for a very minor visial affect i dont know if its worth it.
if i had to id say !( carriedby instanceof Player) .

what you thing?
I think there's one _more_ place where live_datetime can change.  This is in the list view, when you can select a lot of videos and change their live_datetimes.  The view which does this is in `courses.actions.change_live_datetime`.  I think we need to write this code there too.
also, it looks like you are relying on the default "print" formatting for turning the dd object into a string.  what if you wanted to tweak the formatting?
fixed, will be in a later revision
actually we can move almost all, only thing which is different is line 58 and 61.
this line, and the ALL_HOSTS_VALID constant below, allow it to connect to https endpoints with any cert (it's still encrypted, just not authenticated)
Why commented out? Delete or uncomment? Or explain?
and you didn't change app name. XD
This error message is not showing up in the test case - they need to be propagated too. Also, "This" isn't very descriptive - it should include the name and port of the server too.
type alert 'strong'
was this delete intentional?
Mixed return types (in the lambda) are confusing.

Recommend rewriting as:
```
self.assertEventuallyTrue(lambda: stanza.refresh() and len(stanza) == 1, pause_time=0.2)
```

Recommend the same rewrite for most subsequent occurrences of:
```
self.assertEventuallyEqual(<non-boolean value>, lambda: <boolean-expression> and <non-boolean expression>, ...)
```
Careful - that's a security hole as a user can force any notification ID.  You need to also filter by user.  I've fixed this already.
Missing ``{% blocktrans %}``
so action==Info means Create? Maybe calling it "Create" would be better?
This LOOKS like it was a typo. Fixing it in the move. Any comments, anyone?
I do not see `erb` and `open-uri` in gemspec. Is that a concern?
A space is needed here after "if" :)
will fix ...
There is a chance - slight but still - that we receive a NACK for an object we actually don't know about either, due to transmission errors. CRC takes care of this to an extent, but this is another safeguard. Too much, you think?
It wasn't something I really thought we had a policy against.  In this case the benefits of making it an API that works on the UAVO directly seems very worth it.
bitte wo?
On my machine 925 causes stackoverflow for the deffered library. None of them can make it to 10000 though. When makes it to 3000 laissez to 7. I guess jquery might of if it was the old version since it would be recuring.
Вообще все эти Reader/InputStream придуманы для того, чтобы можно было вне зависимости отреального источника писать один код.
Переиспользование переменных в разных местах - моветон.
Мой мир рухнул, Вы правы
Думаю как исправлять
unsafeInstance можно сделать статическим.
Огромный copy-paste.
It'd be good if you can make the catch clause common for these two exceptions, check [this thread](http://stackoverflow.com/questions/3495926/can-i-catch-multiple-java-exceptions-in-the-same-catch-clause) it describes how to do this but FYI this is supported in a specific Java version.
This name should be specific to media services - what if the client is also talking to a different service that also uses a different oauth service uri?
Maybe use os.path.exists instead of a try/except ?
どこからの相対パスなのかがわかる名前であった方が親切かも
Hey Sacha can you explain the bump in min sdk version, is this necessary?
This bit is not necessary, you can pass duration straight into the `find_element`
It's cool. It just a problem with the pycharm debugging interface.
Personally, I typically want to set the relative threshold. Actually, when I wrote `peak_local_max`, the only threshold was a relative threshold. You're right though, it's only one extra line. Meh, I could go either way, I guess.
I think as_float_array does not always copy so you changed the behavior.
I am just wondering how to do similar things to issue a depracated warning when imported from `cluster.spectral.` Thanks for that.
minor thing: I'd use ``n_outputs`` instead of ``n``
Would an explicit `del clf` help garbage-collect the classifier faster?
The concrete notion of budget is not explained. (``n_iter``?)
stopped early
I just added a test for that in ndawe#12.

Note however that not all base estimators can be used. Support for sample weighting and proprer `classes_` and `n_classes_` attributes (in case of classification) are required.
hm forgot about the ``loss_function`` case. should fix that.
euh...
![](http://www.dragonsworn.net/wordpress/wp-content/uploads/2012/04/wat.jpg)
the phpdoc needs one more space (to be align with the first ``*`` of the opening part
nit-pick: I think it's more elegant to handle the error case as an escape, e.g. if (!arg->IsNumber()) { ThrowException .... return QString(); }
@jpl-mac: ip address validated.
@dlifshitz-maca: I don't think we need such checks. We'll simply ignore it when it provided with build
This is implemented in blackberryndk.py:

```
$ python blackberry/blackberryndk.py
BLACKBERRY_NDK=/Developer/SDKs/bbndk-10.0.03
BLACKBERRY_NDK_VERSION=10.0.03
```
The following don't have the platforms list but are not yet implemented afaik.
click
show
startlayout
GradientColorRef
Dimension

The following items likely need a description update:

anchorPoint description needs to be updated as our use is not as documented for iOS, will need to be run by appcel, i get the feeling they will like bb to act like iOS
height, width: description needs to be updated, UI.SIZE and UI.FILL are not currently supported are they?
top, left: are both % and px currently supported?
at least not downstream in my repo... also the build looks fine here

On 24.12.2012, at 17:50, Alexandre Gramfort <notifications@github.com> wrote:

> In source/index.rst:
> 
> > @@ -267,9 +281,12 @@ What else can you do?
> >  What comes next?
> >  ================
> >  
> > -    - sparse solvers
> > -    - beamformers (e.g. LCMV)
> > -    - coherence measures
> > +    - frequency domain beamformers (e.g. DICS)
> > +	- improved M/EEG data simulation utilities
> > +	- band-stop and notch-filters for removal of power line artifacts 
> there seem to be indent pb here
> 
> —
> Reply to this email directly or view it on GitHub.
>
It's possible to right the puppet scripts in a OS agnostic fashion but I want to delay the decision until we have a customer usecase.
thanks for contributing
contains a typo:
    
    bewteen
ok.. var name not v. significant either way
checkLogicalName will throw much better descriptions
DRY: what about to use action.getUrlName() as a parameter and getDynamic()?
when adding an inline docComment for a variable, please do it with the one-line formatting: ``/** @var $data \SimpleXmlElement */``
Use `.removeAttr('disabled')`
" if you don't need the original list, it's slightly more efficient. "

I could be wrong. It's an interesting topic. 

With an in-memory sort, you're just moving pointers, with `sorted()` it'd need to have a copy of each element in the list. 

I think the CPU difference is about 0.000000001% :)
``signature`` is not part of the query string above because the signature changes for each row. This is in a loop, not the query string generation. And you are right, the ``|string`` part should not be set here, if think I had a failure with the case when a signature is ``None`` but that's not suppose to happen anymore as all null signature are given a default value in the DB.
Please don't delete this IF, it's necessary for Production.
in the line above auth_token can anything, including the hash.
Why the change from "src" to "s_src" here?
No offence taken :smile: Now that you mention it, 3 checks might be better as you can give better errors.  Nice you don't need the pattern matching features of preg_match, you could just do strpos() which in theory should be faster.
@yuhunglin indeed, there should be a way but I didn't want to fiddle with it right now ;)
We should try to make imports relatively alphabetical.
if it isn't used here, include it in the .cpp instead - forward declaration is preferable as it leads to slightly improved compilation time
watch out for nil as the return value.   So you should do:

if res and res.code == 200
I would like to see this as either a fail_with or print_warning. I expect you want to continue down to the return Unknown checkcode, so I would use print_warning.
This run_cmd() function looks pretty much the same as the built-in cmd_exec() function in Msf::Post::Common.  Please just use cmd_exec() instead.
Hmm, I think my previous question was poorly worded.

Put another way: Is `b` guaranteed to be grayscale? if so, would the following do the same as the calls to `transpose` and `swapaxes`:

```python
a[:] = b[:, :, np.newaxis]
```
If `b` is not greyscale, then the assignment won't work... I think.
The upgrade and the UpgradeCommands class can be removed
This should cause an error as there isn't a CMISSRegion_TypeInitialise routine, only a CMISSRegion_Initialise routine?
Hack removed.
That's a good question.  I'm not sure what the answer is so let's just leave it as it for now.  None of our other get functions clone, so at least we are consistent.
Does the central body cause problems, e.g., it always picks the central body until the center pixel is over a polyline?  I didn't notice any problems in the Sandbox.
Soon we'll have a separate constructor function for this, but not with this pull request.
We should not block the native click event.  I believe that iOS still calls through to the native click but this should be verified in the sake of parity.  Ideally, we will call the native click AND fire the titanium click event.
Well spotted! Thanks for this, Bryan!
Fixed in next update.
`TiC.PROPERTY_REVERSE` should be used here
I don't think this tells the whole story:

Prior to iOS 6, it was possible to explicitly specify a color value of <Titanium.UI.iOS.COLOR_GROUP_TABLEVIEW_BACKGROUND> or 'stripped' (sic) to select the iOS group tableview background texture. On iPhone and iPod Touch, this produces a pinstriped texture; on iPad, it is transparent.

In iOS 6, there is no way to explicitly specify the group tableview background texture. The color values <Titanium.UI.iOS.COLOR_GROUP_TABLEVIEW_BACKGROUND> or 'stripped' are interpreted as black.
What does "note the callback" mean? Store it? Add it to a proxy?
I'm confused as to the purpose of this. I can't find any usage in 1.8 for this macro that would warrant the change.
`assert` has a `.throws` that takes a function that should throw an error. http://nodejs.org/api/assert.html#assert_assert_throws_block_error_message
Correct. Since we forcefully override the .dir flag, users are forbidden from using the .url flag.  However they can still customize the command, at which point we do not update anything and give them full control over the remote command
Esto estaba bien.
@boegel to be added before i merge it
.toggleClass же
нет, ты получишь все клики, просто у твоих каллбеков будет метка `.myTag`, и ты сможешь их все разом отключить
std::vector<std::unique_ptr<>>
old comments?
Good catch while refactoring I forgot to update this. Thanks!
I tested 'haystack.dropOne().save' using benchmark.
It doesn't effect the performance.
I agree with Andrei. Same approach is more clear.
I haven't seen this code for a while, but think *InPlace should at least try to reuse the same array if it's extandable (has capacity)?
Or it looks like crapy advertisment.
sure, but: 1) sometimes code fits on one line, so `'<div class="foo" />'` works well, and 2) you can use triple single quotes if it overflows to multiple lines:
    html = '''
    <div class="foo">
      <span class="bar"> ....  </span>
    </div>''';
and 3) most of our code already prefers single quote so there's a consistency argument.

anyway, I don't think it's a big deal either way. I violated this guideline recently in the html5lib port, because the Python code was using double quotes in most places.
Nevermind -- I answered myself in #144 :)
As we are demonstrating this facility, we should say "DeltaSpike allows..."
s/Inteact/Interact
Ok, I'm not quite sure if the removals really need to be enhanced. Need to think and discuss about that I suppose. So I suggest to put that also to a separate issue. WDYT?
@aeoth the event was being raised like a generic "settings updated" event (see ```Accept``` inside ```SettingsViewModel```) rather than anything specific to spelling. I think the name was inaccurate, but I'd be more explicit and use ```SettingsChangedEvent``` to indicate the intent.
DRY all of this out -- lots of duplicate between individual and non-individual
this is not equivalent either
Shouldn't you just do e.getForm().equals(tbScreeningForm) ?
Should i rather move it to internal utilities or name it _getGuid? It would have to be public static on the utilities class.

I will sure add the comment.
ram_covered here is a little confusing, it looks like we're tracking it as if it's an incremental total across all entitlement quantities. It can't possibly be used that way if I follow the requirements, it's only used if quantity is never more than 1 and we only find one entitlement. Code is technically correct, but it does throw the reader for a little loop when you see it tallying up RAM like that. 

Comment at the start could use a touchup as this is an important block. It reads as if there's such a thing as unlimited RAM being specified on the field of an entitlement. I'm not sure what the part about largest RAM In the stack means. Could just use a little clarification, two or more entitlements ram limited entitlements means unlimited RAM, otherwise the limit is the RAM on your 1 entitlement.
Please put a space after =.
Both `if` structures have to be executed to determine empty files and give an error, but also upload any valid files.
This catch..if is only triggered when a) there is a bad locale (MissingResourceException) and b) that locale is es_419. Otherwise, the else block below will throw the MRE exception.
I think it is. I was passing a symbol before (the model name) but realized it could be made consistent across all three controllers by using controller_name in the method to do the deed.
two spaces between widgetid and id
On 20 June 2012 22:10, Alex Rønne Petersen
<reply@reply.github.com>
wrote:
>> -    bool isX86_64()         {return (amdfeatures&AMD64_BIT)!=0;}
>> +    bool ahf()          {return (amdmiscfeatures&LAHFSAHF_BIT)!=0;}
>> +    /// $(RED Scheduled for deprecation. Please use $(D ahf) instead.)
>> +    alias ahf hasLahfSahf;
>> +    /// Is popcnt supported?
>> +    bool popcnt()        {return (miscfeatures&POPCNT_BIT)!=0;}
>> +    /// $(RED Scheduled for deprecation. Please use $(D popcnt) instead.)
>> +    alias popcnt hasPopcnt;
>> +    /// Is lzcnt supported?
>> +    bool lzcnt()         {return (amdmiscfeatures&LZCNT_BIT)!=0;}
>> +    /// $(RED Scheduled for deprecation. Please use $(D lzcnt) instead.)
>> +    alias lzcnt hasLzcnt;
>> +    /// Is this an Intel 64 or AMD 64 CPU?
>> +    bool is64()         {return (amdfeatures&AMD64_BIT)!=0;}
>> +    /// $(RED Scheduled for deprecation. Please use $(D is64) instead.)
>> +    alias is64 isX86_64;
>
> But that's ambiguous because that's compile time, while this is runtime (and independent of the bitness of the process), no?

It's info about the CPU, like everything else. Just as lzcnt() will be
true in 32bit mode, even though you can't actually run it in 32bit
mode.
It means, the X86_64 instruction set is supported on this CPU.
(Note that it might be a 128 bit chip, it would still be true if it
can execute those instructions).
So it's more in the sense "hasX86_64" than "isX86_64".
Sneaky bugger. Got him this time.
mavenLocal() is still here - your comment said you'd remove it. Also, see Chris' comment about tailoring locally.
Please no. I want my .rspec file to be used, not the repo's.
Is preferible use `debug()` method declared by the interface. That makes the code reusable
official => officially
You'd be undoing a recent fix with this, please use def().
Andrew - 

This makes me wonder. Really, this type of fix probably should have gone with the "throw error" work. As I search the core code fro $db->getErrorNum, some are associated with JError Exception/Warning and other times, not.

As an example, JFactory has the $db->getErrorNum IF statement in the createDbo method, but there is no JError::Warning statement at that location. If $db->getErrorNum() has no bearing due to the throw error inside the database class, what should be happening at that location instead? Is it possible that since there is no catch processing, this might explain why Joomla gets that looping when the database connection doesn't succeed? It is also appears in ModelList, Database, etc., without the JError.

I can certainly remove it but -- stepping back, I wonder if there is a bigger issue here? How and where should catch processing take place? It might make sense to some recommendations/standards in place and then to walk through the code and make certain error handling consistently treated. Right now, I suspect you would really like catch processing where these JError statements were. If we remove them, then we also lose that marker.

Should we get this PR in, and then follow with a catch processing PR?
not implemented yet - I just wanted some of these out in case I'm doing something horribly wrong
Should be `environ['CONSUMER_KEY']` not `os.environ['CUNSOMER_KEY']`.
Nitpcking. Since all clients have been moved to a single page, maybe we could add a label at the top of the web section and refer to this label here using :ref:.
@apex13 Changed both
Please don't change this; instead just run tests with ```-Itest``` if necessary.
This thead is in the wrong place.
why `_1`? Surely we can be a little more descriptive?
Could be then this field *EmbeddedListField*?
this should simply be ``if``
should we have a function similar to what we have for name in other places that prompts if not given.
do you really need so many nested runs?
what are you trying to do?
should be `false` (if you copied this from swig, there's a very good reason for allowing it there)
докблок
Now that you can specify by room_name or room_id, should make this `elsif room_id`, with an else clause that raises an error.
"monthly on a day of the week" is ok, but the second one is not "day in a month", it's "a day of the week" of a certain week of a certain month every year :|
"add register"?
The parameter name is "code" in Android.
OK scrap that last comment.  There is a way to globally set it.  I've 
made the change and updated the pull req.

Thanks.

On 10/04/2012 11:39 AM, Martyn Taylor wrote:
> There is no way that I found to set the custom responder globally.  
> The only way is to get Rails to use the custom responder is to point 
> to it in every single respond_with.  i.e.
>
> respond_with @template, :responder => ImageManagement::Responder
>
> I wanted to make the fix in one place rather than have this in every 
> single controller action.  But now I'm thinking about it, we do not 
> want to override Rails classes at all, because with any Rails override 
> it affects Rails behaviour for the host as well as the engine.
>
> I will update the patch to include the technique above with a custom 
> responder.
>
> Thanks for catching this.
>
> Martyn
>
> On 10/03/2012 10:18 PM, jguiditta wrote:
>>
>> In app/responders/image_management/responder.rb:
>>
>> > @@ -0,0 +1,24 @@
>>
>> I have to say that I don't love overriding the rails class for this. 
>> Is there a reason we couldn't just subclass it and point respond_with 
>> to our custom responder? If you convince me, I can merge this in 
>> tomorrow, it is otherwise a nice improvement
>>
>> —
>> Reply to this email directly or view it on GitHub 
>> <https://github.com/aeolus-incubator/image-management-engine/pull/29/files#r1755585>. 
>>
>>
>
>
This file should be named WebView.js or web_view.js (to correspond to what it exports).
UploadReadCallback gets the value of max_chunk_size. If we kept the callback static, we would have to make max_chunk_size static which we would not want in the case of multiple file uploads.
Update comment to reflect time change.