labofsahil/github-event-dataset-2012 huggingface dataset:
I'd be interesting in having this commit (and your others) in Forem. If you'd like to submit a pull request with them, I'd be happy to review it.
This is referenced in at least two other places too:

    app/models/spree/order.rb
    59:    # For compatiblity with Calculator::PriceBucket

and

    spec/models/calculator/price_bucket_spec.rb
    3:describe Spree::Calculator::PriceBucket do
    4:  let(:calculator) { Spree::Calculator::PriceBucket.new }

Please update these accordingly.

Thank you!
add reply to field
I suggest you to take the scripts from roar-ng. The reason I haven't licensed these versions was my intention to rewrite them, in the form of those in roar-ng - they had more thorough testing.
pourquoi ce commit?
au moins un tag est toujours indispensable pour une proposition.
need to delete elem; this variable isn't used
The development version fix all warnings! thanks

Can I publish app with developer of three20 version?

Thanks a lot!
what, no test?!?!??!
This comment is useless -- deleting it in a fixup commit.
**#25048925: La experiencia de ejemplo debería tener contenido real**

En los mensajes de commit, aparte del ID de la historia de Pivotal, es importante que pongas también el título... que si no en el log del repo no nos enteramos de qué va la cosa.
Hi Thomas,
Sorry about that - I think in this case it was kind of inevitable though,
because the things I was changing in the nodesoftware were things I needed
to change in order to make the CrossSection thing work.
It might happen more, when I commit a couple more changes now, but I'm not
sure. Don't worry if you need to revert the nodesoftware: I can pick up the
pieces at my end.
By the way, has MoleculeInchIKey been abandoned as a keyword? It seems that
we have only InChIKey now.
Best wishes,
Christian


On Tue, Feb 7, 2012 at 2:04 PM, Thomas Marquart <
reply@reply.github.com
> wrote:

> You committed hitran-things together with nodesoftware-things. I'll pull
> it, but please use separate commits in the future :-)
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/xnx/VAMDC-VALD/commit/102d51bbaaf466c5754d8f657f5cb3b4e83e0d53#commitcomment-941004
>
We can deal with that using the debug code block at the top of sysimg.j. We can put in a definition that does a ccall to print an integer. Then when our bootstrapping process improves we can just delete that whole block, and its functionality will be provided by a prior version of the julia library.
@eteq `io.open()` here returns an `io.BufferedWriter` object, while just `open()` returns a normal `file` object.

I haven't looked at the surrounding code here, but it probably assumes that a `file` object is returned somewhere.  I have some utility functions in PyFITS for dealing with file-opening in 2.x/3.x that might prove helpful here at some point.
Looking through the original code, I noticed that namespaces where anonymous modules which behave like both a Driver and a Handler. So my idea was to change so that it behaves just like a Driver, and, as a driver does, it delegates to the proper Handler implementation later.
Yeah, the indentation got fixed when I finished making changes and I ran autofix to correct any of my poor indentation. If you think it'd be better, I have no problem reverting to the original version and then recommitting the actual changes.
/Agree with reamer
What does this affect?
Just revert mangos [11898]
ooh yeah
Hehe. Got it fixed for Travis and exchanged a few emails with their PHP guy. Pyrus is basically borked for a lot of PEAR channels (even the latest phar download) since it can't parse some of the XML properly. Workaround was to install a specific TGZ file after having it discover the channel. Not very intuitive. Hopefully, they'll accept my suggestion and just install PEAR itself too - it can't be done on their VMs since it only provokes an error from their Ruby environment when you try the pear command.
Sounds great to me! As soon as I get off work I'll update and test everything and anything I can think of.
ah. wow, now I see now that I've looked at the other specs in the file. this syntax is weird. thanks.
Ah, you're right. I missed that - I'll take a look and fix it tomorrow.
This change looks unrelated/irrelevant to me.
Ah, I missed that this was in a `if "".respond_to?(:encoding)...else...end` block.  That makes sense.
I think `print(exists x else "no X")` makes no sense because the lhs of `else` must be an optional type but `exists x` is a `Boolean`. You can write `print(exists x then "X" else "no X")` but in in any case the `exists` in this statement is an exists expression (type `Exists`), not an `ExistsCondition`. Actually, the `print(exists...)` example should already work since you already implemented `visit(Exists)` :-)

I guess an `ExistsCondition` also occurs in `while (exists...)`. Maybe we can reuse some code there. I'll probably do that next.
So this covers both cases:

`obj?.member` becomes `function($){$===null?null:$.member}(obj)` -- if `obj` is null, function returns null, otherwise returns obj.member

`obj?.f()` becomes `function($){$===null?nullsafe:$.f}(obj)()` if `obj` is null, returns the `nullsafe` function, otherwise returns obj.f, and then the returned function (either obj.f or nullsafe) is invoked.
I agree about portability (even if C code carries its own set of traps to
avoid about portability).
But there's many things bash is better than native for. This is true for
file manipulation or other commands call (git commands especially).

I think that at a mature state, core functionality (mainly those making
call to the server by ssh) would be migrated and utilities scripts or
higher level scripts could stay in bash.
I must confess this is how git client is implemented :P : core runtimes are
natives (C), some higher runtimes are scripts because it's not so useful to
rewrite them in C.

2012/2/6 daniperez <
reply@reply.github.com
>

> Me personally, I would gradually migrate to C++. The dependency on Bash is
> not a show-stopper in terms of portability but a native client would be a
> better user experience imho.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/daniperez/magrit/commit/b824e15f4424cb8a5b1ef896cdf6237367ad9730#commitcomment-935960
>



-- 
Frdric Menou
Regarding the first point, are you suggesting a function rename?

Regarding the second, can you demonstrate a bug stemming from that unusual behavior?
Does this result in a 500? Would the admin user see this or know what happened?
Yes, a full uri like that is definitivly beter and more flexible :)

Jean

Le 20 janv. 2012 17:14, "Gerhard Lausser" <
reply@reply.github.com>
a crit :
>
> I propose you use my init-code from logstore_mongodb
>        BaseModule.__init__(self, modconf)
>        self.plugins = []
>        # mongodb://host1,host2:0815,host3/?safe=true;w=2;wtimeoutMS=2000
>        self.mongodb_uri = getattr(modconf, 'mongodb_uri', None)
>        self.database = getattr(modconf, 'database', 'logs')
>
> with "server" everyone thinks of a hostname. I prefer "mongodb_uri"
because this better makes clear that you can write much more than just a
hostname here. you can express multiple hosts and several flags, too.
>
> ---
> Reply to this email directly or view it on GitHub:
>
https://github.com/naparuba/shinken/commit/ab4e79781e9785679dc1545197433403e00a6f14#commitcomment-886448
#function table developer
No one really want's to run Guvnor tests locally since they take.. take.. take... long..long.. time.
I wonder if anyone actually found the calculator easter egg..
Since I already have the episodes, I don't need to make a call, back to the server. SeriesId will now be stored in the SeasonModel, since it is needed in the Season partial view.
Thinking about stripping it down even more but we will see with future revisions
what exactly is the divine meaning of this line ... and is it missing the semicolon on purpose?
This isn't really consistent with how the rest of WTF works - clicking on the title of a list item takes you to the edit view (no separate edit link), there is a separate "View" link which opens in a new window/tab, and the destroy button is titled "Destroy," not "Delete."
Good point. I used new ArrayList(0) so it would still be editable, but that
doesn't happen anywhere.

I guess the same can be done when the field is initialized.

On Fri, Feb 3, 2012 at 9:21 PM, Christoph Kutzinski <
reply@reply.github.com
> wrote:

> If you're so concerned about the bytes ;) wouldn't Collections.emptyList()
> not be even more reduce the footprint?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/huybrechts/hudson/commit/88360dbbbe033b84010b8a92966739cd694d6833#commitcomment-931690
>
i'm so confused
Holy shit, I hope thats not a live certificate?!? If it is, I would strongly recommend getting a new one, as this one is by all means compromised.
Consider squashing this commit with the previous one.
Definitely, there is no need for #'buffer-stream-close and #'buffer-cue-close to be two distinct fn's. If the assert statement in either was changed to `(assert buffer? buf)` then it would work for both types. 

Renaming ::buffer-cue and ::buffer-stream to ::buffer-instream and ::buffer-outstream would make their similarity more obvious. Perhaps they should both be derived from ::file-buffer as well? and ::sample too?
what's wrong with `cat.name = {local_code: ''); cat.save()`?
另外在設計Logo時提一個小建議，最好強調開發而不是強調娛樂，我弟弟一看到XP和VX ACE的圖標就以為那本身是個遊戲，好囧～～這也是敗筆啊
In actuality, this can be moved to the first commit. Please take a look at my attempted implementation of boot_once (which I currently lack the means of testing it) there, and let's work to get rid of changes to boottool.py on this second commit.
Please note that this code is not yet working, i had to push it to show it to @Edoxile
Oh I just eralized this comment was actually removed in a later commit.. ;)
Hard to find, openstack wiki is completely unorganized and not up to date.
typo, relies
@beberlei please merge to 2.1 and 2.2.
Adding ticket #38 for this.
LOL. Alright :) its 7 now. I'll be online at 9. 

-- 
Andrew Cates (iPhone)


On Jan 6, 2012, at 6:01 AM, Joe Hudson<reply@reply.github.com> wrote:

> Some documentation here would be meaningful
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/walmartlabs/lumbar/commit/aea776e30c91a3cc58228f18ca0684b3817eb697#commitcomment-843717
no ono mi to takhle nefunguje ... tim zanorenim routovani komentaru pod clanky jsem zde neziskal dostupny `@article` ... pouze `params[:article_id]` ... takze max muzu udelat find ... a pripadne otestovat aby to nepadalo na nil ... 
udelam to tudiz obracene ... current_user.comments.new atd
Yeah - exactly. i added it here because git is strange or i can't use it properly... I can't add empty folder to repo :D
Should this be:
var emailregex = "/^[a-zA-Z0-9._-]+@[a-zA-Z0-9.-]+\.[a-zA-Z0-9]$/"
?
Need to be escaped via php htmlspecialchars function. We have shortcut functions for this (that combine the xl function and the htmlspecialchars function at library/htmlspecialchars.inc.php). The two function are xlt(translate and escape normal text) and xla(translate and escape text within html attributes). For example:
```return ($pdHTML == '' ? '<p class="alert"><br />'.xlt('No Messages').'</p>' : $pdHTML); ```

For better explanation of the security model and using these functions see here:
http://www.open-emr.org/wiki/index.php/Codebase_Security#Plan
He he. We seem to be taking turns at shooting same fish :-)
In the client case, connect() is called by end user code and the expectation is that a new connection will be created or it will fail. Failing here is an error condition that the client application needs to be able to deal with (and should probably not arise unless the client does incorrect things like stop the endpoint and then try and make a connection).

In the server case start_accept() is called in response to a remote client connection and the expectation is that the connection will be serviced or refused. Failing here is an expected condition that that is not the result of the server application doing something wrong. Dropping connections in low resource conditions or while stopping is normal server behavior.

What is missing is a log line on the server that notes when it refuses a connection for this reason so that the dropped connections can be debugged later. I will add that.
Thank you. Everything is clear.
Thanks to vially this issue is now properly fixed.
Someone told me that he was on vacations, i really dont know
don't know about you.. but I found how to implement volume wake and some other stuff and will try to play with those tomorrow...
I've made a huge mistake... 

http://www.collegehumor.com/video/3786003/ive-made-a-huge-mistake
As you already pointed out: It is very very cheap - imho too cheap to worry about that, so rather leave it as it is.
Проверил diff-ом разницу, переводы одинаковы. Кстати, а они были изначально проверены на корректность хотя бы гугль-транслейтом?
в noads-translation.js нужно добавить
Maybe failed too?
How did you decide which fields to include for each object type?
Also: Look, ma, unit tests!
Why? When it never did anything, why should someone use it?

And are there events fired by inventory actions?
No that's not correct. A user can ask for a factory but it is passed via the `Environment.MODEL_MAPPING` property, not the `SearchConfiguration.getProgrammaticMapping()`.
My favorite is "gambling lemurs get all the babes".
Ah, but I never said anything about cascading DCM ... just that instanciating them didn't have to be at the top level.
?? I don't know what you mean. It's part of the test suite.
I haven't checked since my last message on the issue.  I was waiting for word on the plugin system, to refactor and build it again on that.  Has it been implemented?
There are sometimes even 3 sayings and this solution handles them as well ;)
I like this one because like that there is a little less code ;P
i think this might let `commit_on_success` be true, and commit the broken transaction.

Probably we should just let it raise an exception, and instead bother to make FlightDeck's 500 page.
I'm sorry, but I can't get it to work by just implementing load_archive like you do in the Wii port - it will crash hard at system_reset() then. What I need to be able to do is to look at the file extension, determine the system_hw based on the file extension, and THEN load the first file in the ZIP file into the buffer - anything else seems to end in vain.

Perhaps you can suggest to me which parts of the code need changing for it to work. But until then, this is a real stumbling block right now. In the end,
Each time when I try to use this UI strings externalization I get this error:

(NoMethodError) undefined method `t' for main:Object

What can be done ?
Did you ever pursue this further?
If the types are identifiable, we should keep using a StringMap (since its faster). Otherwise, make sure hashCode() and equals are implemented (it might be better to map from a concrete implementation to something for that reason).
First float is sin angle and the last float is the velocity
@A-Metaphysical-Drama : Revert all since this commit ?

I've reverted 65d269f , not working for me :s
the mistakes with parens and use of concatenation in the string are remnants of java i'm afraid. will do my best to operate the python way in the future. thanks!
文字化けしてるように見えるが、文字コードをSJISからUTF8に変更したため。
No problem, I was just copying the formatting from DefaultLoadEventListener when working on the stats and logging bits. Would you like me to revert the logging style?
I had this same concern about biasing `Region` toward `(||)`, when the bias comes from a particular *use* of `Region` (and similarly for `Bool`).

I wonder: do we want to impose the constraint that all types capable of conversion to `Color` (via `HasColor`) must have `clear` in their image/codomain?

I'm trying to remember my motivation for having that `HasColor` class at all. It might have been just a convenience for displaying/testing Boolean and real-valued images.
True. But modern text editors (vim, even) should make it pretty easy to deal with, and since this stuff is all programatic anyhow it shouldn't be too annoying. Besides, there's a good strong structure and solves a lot of really hard problems.
yep, at least for classes which are not annotated as "OpenEngSBModel"
You have 4 spaces for indentation here but 2 spaces on line 69.
I started a textual description of the desired QC steps at https://github.com/citation-style-language/utilities/wiki/Style-QC. Feel free to help flesh it out. I haven't added all the checks I make with https://github.com/citation-style-language/utilities/blob/master/csl-qc.py yet.
Hmm... i will revert it!
Does this line have any effect?
Oh well, I edited it already anyway......and why are there 2 READMEs?
Awesomeeeee!
@ohadlevy I checked that  when poweredOff, VM's ipaddress is empty.  I agree we should check whether VMware Tools is installed, and also define what ready means. I suggest ready means IP address is ready and this VM is ready for connectting to via SSH.  Fog EC2's ready behavour like this. What's your opinion ?
I am not sure we can give such arrays external solver libraries.
@brianreavis Fixed!
I assume this may be to avoid modifying the non-impacted code path, given the timeframe, but is it worth adding it, just to remove it 2 lines later?
I just a think a problem after update the code.

For example - there's only a widget have 1 event handler, now, remove the event handler.

Then use saveEventHanders() to generate the file, but because all of event properties have no contents, so it won't generate it, it's meaning old cached file is not update, the latest event handler still exist.

How do you think ?
Since property and @property are functionally equivalent, and the additions in this pull request follow the pattern used in the rest of the file: I think that changing every property to an @property is something that's orthogonal to this pull request. If we want to change it, we should do it in another branch/pull request.
That is already possible with trait Act (the DSL).
That is exactly what Roland proposed, too, and I agree with both of you on  
this.
import math.{ sqrt => √ }

val newDeviation = √(newVariance)
As in documentation I mean
Evernote was unable to submit your note for the following reason:
The storage limit for this account has been reached.

Original message information:
From: Roland Kuhn <notifications@github.com>
Delivered to: thanhbv.fa84f@m.evernote.com
All recipients: akka/akka <akka@noreply.github.com>; 
Subject: Re: [akka] Fixed handling of unbound transport errors (#970)
Sent: Fri Dec 21 10:54:32 PST 2012

To prevent excessive emails, you may not receive another error reply
for the next 360 minutes.
I think this is suboptimal since this is in the documentation. Add a defaultAddress(): Address to RemoteTransport that by default returns addresses.head
OTOH we have a ticket for making sure that code samples fit into the printed docs, which made me press cmd-shift-f on a few files in order to do some boy-scouting; maybe I was a bit too trigger-happy with that one, since this file is not in the docs.

But let me ask: do we really care either way for medium-long lines? wrapping around 80 has the advantage of keeping the github displays more readable at times, so I guess I’m only saying that requiring long lines might be over the top (in Java sources, where there are no one-liners by definition).
Isn't this method wrong? Don't you need to check getByRef every tailcall?
What do you think about the log info - keep it as is?
Shouldn't this also be private[akka] and documented to be internal api?
It is my intention to add some nagios integration with cloudwatch using boto... but if that's out of scope of the project, please feel free to reject it.
This part really didn't change.  Just moved down and put in a subclass.
The check is not needed, just always do "ConvertType (value.ToString (), targetType);"
au temps pour moi : non pas un `<div>` mais deux `<div>` imbriqués… :-(
Yeah, but we say often that matrix has shape (X, Y, Z) or (I, J, K). So, I think it makes sense to say (X, X, X). How would you say it?
I don't think you should be doing this here - better for the template to know the user id than pass it all over the shop - this just creates spagettiness
Maybe remove "the" from "the HTTP"?
I'm adding some stats to prove it, but I think most of the id fetches will hit locally when a Wagn is humming along.  There is some evidence already, and we'll be able to find out more.
Can I suggest ; "%s.%s" format (name.getGroup, name.getType) maybe
Is it normal that we only alter the local node status here?
We have to distinguish between adding a stream and dropping a steam. Right after a pmt change we can check if a stream needs to be dropped. But a new added stream (while already playing) is not ready right after the pmt signal. demuxer would add it to the streams with first packet belonging to the stream coming out of ffmpeg. This is the time to signal a stream change to player. Unfortunately we have a packet at this time.
по форуму и доке делал
Could you give the comments a line above to breathe?
"If there is a `binding.gyp` file..."
albo na <strong>...</strong>
On Fri, Jul 20, 2012 at 12:38 PM, Denis Arnaud <
reply@reply.github.com
> wrote:

> > @@ -51,6 +51,10 @@ if (NOT BOOST_TOOLSET)
> >      set(BOOST_TOOLSET "vc90")
> >      set(BOOST_COMPILER "msvc")
> >      set(BOOST_COMPILER_VERSION "9.0")
> > +  elseif(MSVC10)
>
> Are you sure it's MSVC10 (rather than MSVC100)?
>
> Sorry, I have no MS VC install to test that variable myself.
>
>
Yes it's MSVC10, see http://www.cmake.org/Wiki/CMake_Useful_Variables .
I find the name "suite" kind of strange, since what this really means is that if you say suite="foo", then eunit will run any tests available both in foo.erl itself as well as in foo_tests.erl if that exists. But if the module name already ends with _tests, Eunit doesn't try to find ..._tests_tests, so you can say suite="foo_tests" if you want to avoid any tests in foo itself. So "suite" is really "module", but I guess it's no big deal.
Does this actually work? I thought the thing with gcc on sunos is that you need to specify -pthreads instead of -pthread?
This could be rewritten as `var hits = completions.filter(function(c) { return c.indexOf(line) == 0 })` right? Shorter is better in examples.
Let us return CompositeByteBuf here so we can support method chaining
Please use `public_send` instead, we shouldn't bypass private methods here.
Can we use `||`? It is in Rails Code Guidelines to not use `and` and `or`. Thanks!
Perfect. Thank you kindly.
Wrong result here.
I don't see what q.v. stands for here.
If it's noncommutative I want it in numer_others so that it doesn't get reordered. That's the simplest solution to the wrong result without touching the whole simplification logic that's in the loop.
>
> I don't see much of a difference between the two approaches.
>
>
the approach you use creates a 2nd list and always goes through the
machinery of adding the element;
the approach I recommend doesn't create a new list and only makes a change
if warranted.

other factors are more significant when it comes to time, I suspect, but as
a general rule -- you and others can comment if I'm off base -- I don't
like to create new lists if I don't have to, especially when I don't know
how big they will be.
I'm afraid I'm getting a bit sleepy and so I didn't manage to get my message over to you, sorry :-)

https://github.com/scolobb/sympy/commit/76f63a14bc9e945943958cac0890f29dad9fcf31 -- this is what I was actually suggesting.   With this commit on your branch, the command `bin/doctest doc` works fine.  Feel free to cherry-pick that commit if you feel you like that style better.
this doesn't fail for me

```

>>> p1 = 64*x**34 - 21*x**47 - 126*x**8 - 46*x**5 - 16*x**60 - 81
>>> p2 = 72*x**60 - 25*x**25 - 19*x**23 - 22*x**39 - 83*x**52 + 54*x**10 + 81
>>> q = 34*x**19 - 25*x**16 + 70*x**7 + 20*x**3 - 91*x - 86
>>> gcd(expand(p1 * q), expand(p2 * q), x)
34*x**19 - 25*x**16 + 70*x**7 + 20*x**3 - 91*x - 86
>>> _==q
True
```
Done with 79fdf1d
has → have
I suggest remove this private method too.
Please do not assume '/' is the path character. Use File.pathSeparator or File.pathSeparatorChar
You deployed the crawler to a new address?
Why are we only doing this if the number of versions is greater than one?
Please revert/remove this change.
Ah that's a bit of legacy I forgot to remove.
Capitalization is wonky on this method.
1. s/MongoDB/mongoDB/

2. that link for locking isn't right.
I think that there should be a heading here that includes all of the following sections called "procedures" or "operations"
the "location index" is not a term we've used or defined anywhere.
for queries *that* include both of these fields, MongoDB
Good suggestion. Will use that instead.
Needs a full docblock (parameters, return value).
Better solve this somehow. How about making a div that has that written appear under the textarea?
But they are the result of a class performing certain actions. So I think they could be placed in the `phpbb_revisions_post` class.
Not sure I understand what the reason for this is? why limit it to 50?
`php` -> `PHP`
so this query can be changed to limit 1. variable name can also be changed to USER_HAS_POSTS looks good?
This should be attached to the `phpbb` object instead of being a function
I used concat here because it is the version of mysql and Oracle, while || is for postgres, sqlite and firebird which are less spread...
Please make a ticket to improve the randomness here and in avatar salt, the code here is fine with me if it is identical to what we do for avatar salt.
Can we skip logging when someone doesn't pass in a flag?
This most certainly needs a comment explaining the reasoning.
cache this.dimensions and this._dimensionPaths outside the loop.
Why does this require node?
too much indentation here. and btw, this could probably be kept on one line.
NT2_HAS_OPENMP_SUPPORT is not defined at that point.

I believe this change is a bad idea.
Believe so. Worked for my environment.
This test should be updated (or another one created) to use Theory/InData and pass in "on" with different casing (on, ON, oN for example) to ensure there is test for the case-insensitivity
typo, shouldnt change this line ("funtion" should be "function", as it was before)
No such link...
Should we print host_structure in that case?
No. Basically that function ``typeConstructor`` works only for float32. The assumption is that float32 variables can turn into CudaNdarray and therefore only for that dtype I need a function to construct the type. I've added new comments to explain better what is going on. This ``typeConstructor`` function is the result of an old refractoring that tried to merge the class for scan on cpu and scan on gpu into a single one.
Don't need these assignments (unless setParams/fromJSONArray gets called more than once on an instance, in which case assigning to null would be simpler) as these are redundant with those at the top of calculateSerializedSize. Is there any good reason for the assignments at the top of calculateSerializedSize to be conditional?

Alternative: move the similar assignments in calculateSerializedSize out to its only other caller, fromJSONArray.
Yes, it should go to the unionnode.h
"Assign all devices and copy all variables and values from the specified `source` group."
This line fits in 80 characters, no need to break it.
Unnecessary whitespace above.
Is this needed anymore?  Our typical development process passes the dev's ssh keys using ssh-agent.  I don't think the deploy account needs it's own public key anymore.
Same as above see: https://github.com/devco/knockup/pull/37/files#r2404016
Misses a "versionadded 1.5" directive.
Is it necessary to have the PEP8 fixes in this pull request? I'm not sure what the recommendation is, but normally I'd ask for either a PEP8 fix before the code changes, or one just after (to separate out changes which should have no functional impact).
This line spacing is really awkward, please don't make unrelated changes like this, especially when they make stuff uglier.
Can you reformat this as:
```rest
.. note::
    <content>
```

Also, "a model named ``Author``"
It's actually not quite that simple. See https://bugs.launchpad.net/openquake/+bug/979876/comments/1.

Basically, if we want safe and predictable results (regardless of architecture), we need to limit seed values to 32-bit signed ints (-2147483648 to 2147483647, inclusive). In combination with that, we need to fix this: https://bugs.launchpad.net/openquake/+bug/979722

We should put in place the same limitations on all other random seeding (logic trees, for example). I'll file this as a separate bug. Good enough?
Need a space here between inner braces and argument.
Did a small test:

http://www.howtocreate.co.uk/tutorials/javascript/browserwindow

The innerHeight only chnages as long as the browsertoolbar is visible.
When the document is scrolled down and no browser chrome is left, the height will stay the same.

1. Scroll down 50px
2. Store the height
3. Scroll down for another 150px
4. Compare stored height with current height
You're clever :heart:
is that really smaller? just curious.
As RF and C4.5 share the same tree growing engine, this file provides all the APIs of RF, and validates the input parameters' value.
I wonder why your quote doesn't show explicit cast, although compute_mlogregr says

```
        updateExpr = """
            {schema_madlib}.mlogregr_{optimizer}_step(
                ({depvar})::INTEGER,
                ({numcategories})::INTEGER,
                ({indepvar})::FLOAT8[],
                {{state}}
            )
```
Should ``foo.bar`` be sorted before or after ``foo.foobar``, i.e. should the nesting level count when sorting? Not a 100% what the sort order affects, maybe you could add a comment about why we sort.
How will this mix with really only having 40 volume levels? Will you get the value you set back out again? Should be add a test to the fake mixer / gstreamer tests with max_volume = 40 to test a case where max < 100?
this line is empty.
ok so as the coffescript converter natural behaviour... I'll try to do it
nicer than the replacement of ind1 elsewhere
I'm slowly beginning to grasp it, maybe. But you're right in that I should read the RFC.

> This is only true because of the default 'simplification' of getACL. (...) Delete is represented as {DAV:}unbind

So I can define {DAV:}unbind in my getACL method?

>  If you override 'getSupportedPrivileges' you can create custom structures.

Which is not needed because the default already has representations for finer permissions than just read-only and read-write?

> Not saying my code is awesome, that statement referred to the RFC ;)

You know it is :-D

@LukeOwncloud We use the CRUDS permission constants as defined in https://github.com/owncloud/core/blob/master/lib/public/constants.php 
I don't know what the sharing does with expire date, but I guess it's transparent so results don't show in queries if they're expired.
Useful change
Hmm. This docstring is out of date. Probably the original is too?
`c.response.content = request.environ.get('usable_error_content', "{\"error\": %s}" % code)`
should this throw?
no? i think they rock. people will have to adjust. java introduce(d/s?) null-check without == null as far as i know. so above would result in:

          return testclass? null : Description.createSuiteDescription(testClass);

this will cause even more people to adopt it.
I'm not sure if the inline comments here help, and they obscure the formatting.  Remove?
For compatibility, we need to leave the old constructor there to delegate to the new constructor.
Might need a better message. for exception.
@dizzyd this one is on result (and only when from s3, not the cached ones), isn't the intention to generate the event on request and for all of them? (all the other events are on-request at least?)
You mean between the li { and the a { ?
Use `var` instead of `const`.
Also, how will this work wrt fixing #964?  Can you set a shortcut display override _only_ when the shortcut is created simultaneous with the menu item?  Or will KeyBindingManager accept & store the ```displayKey``` property too?  (Seems like the latter is more flexible for extensions, and a more consistent API... but naturally, more work too).
Seems like we should make this an anchored regexp (assuming `/test` should be at the end of the path). Otherwise if you were a user whose username started with "tester", for example, this might not work.
W.R.T. to the 2nd comment. I fixed the issue where dirty documents without new timestamps would hit the cache instead of being re-read.
It's hardcoded in jquery.jstree.js, line 275 (in the big string literal full of CSS code... bleh).  Ideally it would be in some external file that we could translate to LESS and tweak to share this variable, but c'est la vie...
This looks good. Please add a comment to the code to explain what this does. When I saw a param called "nocache", I was expecting you could just use "nocache=true", so please explain why a unique value is required.
Fixed (also fixed in nls/strings.js, where I copied the initial code from).
Would be cleaner to take out the whitespace diffs in this file
search.js is not needed. All the functionality from this file has been superseded by FindReplace.js

(pull request #2314 removes search.js from `index.html`)
left in this debug print
You need three versions of the email. Two for proposers, one for the comment being responded to:

1. [User's name] left a comment on your proposal (for top-level comments).
2. [User's name] replied to a comment on your proposal.
3. [User's name] replied to you on [Proposer]'s proposal.

You should go through them in this sequence and ensure that if someone has already been emailed under a preceding condition, they don't get mailed a second or third time.
I'm not sure if this error is persistent across all browsers. However, `e.name` should be `INDEX_SIZE_ERR`, `e.code` should be `11`, and `e instanceof DOMException` should be `true`.
I'm trying to hit invalid things like undefined, false, null.

Going to update this to return 0 as requested below, though.
I've attempted to use the checked attribute, but having difficulty toggling the 'One page..' and 'Two page..' options. I have looked at https://developer.mozilla.org/en-US/docs/XUL/PopupGuide/MenuItems and https://developer.mozilla.org/en-US/docs/XUL/menuitem#a-checked but oncommand and/or autocheck="false" doesn't seem allow me to grammatically check or uncheck the states
W0000000t!!!!1
Ooooh....neat.
System properties that affect behaviour should be documented.
`visionmedia-jscoverage` лишний уже
ok, I'm convinced :-)
I see.. nice!  I'm new to this so my head isn't quite "in it" yet.  I'll get on that...
Should this actually go here, or should we just hook up another signal method here? Seems like its unrelated to geoserver.
perhaps say ZTYPE here
@ehelms, @knowncitizen ACK?
By the way we have this wonderful DSL for this:

User.as 'admin' do
...
end

But it only works with textual search, yeah.
Would moving that initialization to after the call to InitializeConnection suffice?
Ditto here with fully underlinng the ``-``
我非常希望这段东西直接放在index.php里面，因为这是所有代码执行的入口，如果routing规则也放在index的话，它同时也就是查代码的入口了，以前每次要去一个配置文件里面翻，其实是影响开发效率的。
I really want to see this `repair` function changed so that it determines the `Owner` using `riak_core_ring:index_owner` and then immediately does a `gen_server:call` to the `Owner` which handles all the repair logic. In other words, move all this logic into the `handle_call` on the `Owner`. Currently, this logic is performed wherever, and then the `repair` call is made to the `Owner` which does the rest. Why not combine the two? It would also guarantee that things are calculated using the owner's ring rather than the ring on the node the user ran repair from.
This looks like it *always* starts a new process for getting the stat value. Am I missing another check somewhere?
Sorry, I made the comments more clear.

Basically, I check if we have any image stored and return that before going
to Gravatar. This stored image can either come from OmniAuth or if the user
changes it.

No need to check for *nil* email, Gravatar will return the default url in
that case (*gravatar_id* = *nil*)

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>



On Fri, Nov 30, 2012 at 5:49 PM, Luke Steensen <notifications@github.com>wrote:

> In app/helpers/application_helper.rb:
>
> > @@ -1,2 +1,9 @@
> >  module ApplicationHelper
> > +  def avatar_url(user)
> > +    #first tries image from OmniAuth, then Gravatar using email, then uses default URL
> > +    default_url = "http://i.imgur.com/NgOB1.png"
> > +    gravatar_id = Digest::MD5::hexdigest(user.email).downcase
> > +    user.avatar_url if user.avatar_url
>
> What is this? Also, make sure you test this for cases where user.email ==
> nil.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/bitcast/pull/23/files#r2284205>.
>
>
As the MessagePage has set the flag focusPolicy = NoFocus (which is the default), I'm rather sure the setFocus() had no function before!
See http://qt-project.org/doc/qt-4.8/qt.html#FocusPolicy-enum
What is this one doing?
The new `themes` option should be documented.
why calling the file ``ApiClass.php`` ?
missing linebreak between the params and return
This should be done the new way as well...
Hey Paul, any reason why you've marked this test as pending?
Using regular expressions to do this seems really inelegant, but I don't know a better way
I just worry about infinite loops with an `is` check, in case there is some
casting operator involved in the trait.
I would agree with @bfroehle  on this one.
add .rawStatus(vmState.toString())
Yeah, I missed that
This belongs on the `posix.h` header.
I was alphabetizing them, but forgot about that rule. doh!
Ahh, excellent.  Yeah, I did it that way for both suties and runs.  Very clean.  thanks!
actually, on re-examining this, no it cannot be made simpler or safer.  The flaw is in the ambiguity of the spec here.  The string can have two forms: a literal that just needs to be used for equality tests, or a fragment of python code that needs to be executed in lieu of an equality test.  There's no easy way to tell the difference.  So this code tries eval to see if it is a code fragment.  If eval fails, then the code assumes that we've got a literal.  

So, I've redone this section of code so that it logs what it does.
Same thing here, shouldn't this be 'Setting'?
Thanks for the clarification guys - merged!
I think that this string should be `"a\n  margin auto\n"`, with the proper linebreak after the selector, just like a similar test in [scss_test.rb](https://github.com/sinatra/sinatra/blob/master/test/scss_test.rb#L18)
But they can be both be used to achieve the same. So from an API point of view, I don't see what is supposed to do what.
addAllRoutes($collection) does not add more than addRoute($collection). So the name is very misleading. And addAllRoutes can also add sub-collections, not just Routes.
It's not visible here, but it's fixed
Fixed and squashed again. Note that this should be corrected in Doctrine too then :)
Would CacheObject be better? I'm not very good at naming stuff.
well, either you are using tabs or you are using 2 spaces per level. In both cases, it does not respect the coding standards
php.net: InvalidArgumentException => "Exception thrown if an argument does not match with the expected value" is more accurate.

> if a callback refers to an undefined function 

not the case here

> if some arguments are missing.

not the case here
I'm aware of the stupidity of the two functions above, given that we have very similar functions for the container background for venue feed previews.
I will bust the two of them out into a category on PostBaseCell but to get this in for a TF + app store build this should be an okay solution for now.
double check this still works - it never does whenever I make a change here :)
Added benefit: you can use the same interface for other uses of the method, like line 22
These two lines is ended with windows line break '\r\n' instead of unix style '\n' only.
You may need to change it in notepad++ or something like that.
@JosephPeng 其实那样写也挺好的，记得最后致谢里面说明一下就行了
Opps, it seems the github is under the GFW now, I can't sync the file changes to the master branch...
A very minor detail, you can finish the line with a comma to avoid having to change it again once you add more checks.

    Memcache(self.checksLogger),
Let me see if I can get it to do something on my end.
Sorry, miss-understood your statement. Yes, you can get the figure that this axes belongs on with ```self.figure```.
Yes. Thank you. I meant to point that out - this is definitely a bugfix.
Согласно твоему другому замечанию createCommonNodes возращает непромис - а значит это q.when(). createBlockLibrariesNodes в данный момент тоже непромис. На then можно поменять только у createBundlesLevelsNodes.
......去掉了
Why hash? There no value in this change.
I've tried that but I ran into problems. I fixed it by creating an `isApplication` on `Ember.Application`.
I don't like doing things this way either, but I couldn't come up with a better way to append to the editor's context menu without messing up with the editor code. I planned to use filters for this earlier but seems like they are limited to checking the attributes of the event object only and not arbitrary conditions.

Please suggest if you have a better way in mind to append actions to editor context menu.
I find this easier to read as:

```
$attrs = array(
  "style" => "...",
  ".." => ".."
);
```
This was necessary because I needed to override it in a subclass
Here was my rationale:

The stepCompleted() variant is basically a shorthand that deemphasizes the rollback handler implementation. So I pick one or the other based on whether there is value in *emphasizing* the rollback handler impl. If I think the person reading the code might get some benefit from seeing that the rollback handling will be a no-op, then I spell it out.

A couple cases in this patch where I did this, there really is no way to "roll back" the change. So I use the long version to help emphasize that to the reader.
Yep. I won't block merging this for this, but we need to solve it. At minimum context.revertReloadRequired() has to be called if  context.reloadRequired() was called.

This handler doesn't need to subclass AbstractRemoveStepHandler if doing that makes it painful to make the necessary state available for restoring the profile.
Since the purgeBeanClasses() method is private, don't you need to call purge.setAccessible(true) at some stage?
Preferably both. Not sure how much styling we should do if the button widget isn't loaded.
@wycats Can you point @sgharms at a vim plugin that will find and use the correct .jshintrc based on the current file?
above you join with the empty string.  Here, and below you use a space.  Is that intentional?
Per my comment to @mozsquib in https://github.com/mozilla-b2g/gaia/pull/3443#issuecomment-7742489 we do not want to use -moz-box because it's not actually a standard.  squib ended up using the table 'display' values, but I think you could also just use calc on the children rather than flex.  (Using the position: absolute trick with margins on the non-absolute thing could also work, etc.)
I am afraid that if there were some careless person trying to implement `unobserve` someday :P

(and that person could be me in the future)
Yes, that's another bug @ChiajungHung found.
Because of entry points, you should get name from `runningApps` object.
Fixed. textContent will not be escaped for search. Highlight string will be escaped partially for preserving span highlight tag.
typo-> "openTrustedUI"
Nop, I'm ussing that.
That can be done in a followup.
Deprecated as of OS X 10.6. Rewritten to use currently supported methods. Minor error-checking added. Logic unchanged.
16f3a65
As `limit` is always 4 we could use a instance variable here!?
=== is almost always preferred over ==
\00a0 for CSS nbsp.
Hard-coded URL
Why the ruby 1.8 style hash syntax here? The previous line uses 1.9 syntax for options.
Ok after the chat we had: makes sense to keep RowVector, ColumnVector, since colt supports 1DMatrix
It occurred to me wonder why this is a class, but create-master isn't implemented that way. But I guess there is enough state here to warrant it.
Single quotes, otherwise LGTM.
this code cause compiling error on win32.
you should remove the extra line
As mentioned in other comments, name your interface ExpressionRewriter or something like that to avoid direct references to MVEL.
I would like to start recommending to not override maxretry (which defaults to 3 btw anyways) unless there is a good reason to be that strict and not allow even a single human error ;-)
this one should still be a double backslash, I think. It's saying "Lines ending with backslash" where as your change makes this "lines containing a dollar sign"

Otherwise this change is good, thanks for fixing the typo!
Perhaps @logger.warn here instead of 'puts'
can it be just `template`  ? or `template-path` / `templatePath`
> Does that mean that the workaround implemented in loader.js:freeze() doesn't work and throw?

Yes it will throw if you'd load `loader.js` here.

> If you add a pseudo module @loader which return loader loaded by cuddlefish.js, would it work?

I'm not sure to be honest. But, I don't think `@loader` module is a good idea as one will be be able to modify behavior of parent loader at runtime. I'd rather see a good use case, before allowing that.

>  It is weird. Here we load a new module require('api-utils/loader') instead of using the existing one.

As a matter of fact we use same loader and even with the mentioned bug fixed, we would reuse loader and just use `load` function from `require('api-utils/loader')`. Although it's not really a big issues since platform caches that anyway so there is no IO involved. Finally all this is just form `program.main` which are in process of deprecation anyway and hopefully in a future will not be a problem.
Before passing this to the dialog, should we do some sanitation/verification to make sure the specified email address is really an email address?
remove these 4 lines.
Why is this assert here, because the url of the current page after the search does not end with /?s= , it ends with /?s=<search term>
Not easy to see.

Is it worth considering to reference lxc-ubuntu-template and not copy paste it ?
I don't see this file anywhere in the commit.  Are we assuming that knife-windows is installed as well here?
config here is not just the leiningen config, but only the migratus fragment of that config. The config that gets passed in could also me some arbitrary map that someone sends to migratus.core/migrate, migratus.core/up or migratus.core/down. This would require changing the expectation of what is in that map to include a :root key, which is certainly within the realm of possibility if this is a useful feature.
typo? numIntersetions
I added some tests that exercise this idea in 0858993.  What do you think?
@zaphod42 are you suggesting using `C:\\test1#{File::PATH_SEPARATOR}C:\\test2` here? coz that will break in all sorts of fun ways...
It gives zero-cost class methods for a module. I think I wanted to use this instead of including the module, but I didn't, so it can be removed.
@Maks3w Why do you think the package is not official? That might be a problem because I used that package to build the log writer...
You need to escape this attribute. I'd actually argue that you add 'class' to the $attribs array, as htmlAttribs() already does attribute escaping via the Escaper component.
Another strange line break
I hadn't studied the latest base.css closely enough.  I was able to use the standard "visible" binding now without using an override css file, since a few `display: none` styles were removed.
.toggeClass( FILTER_COMPLETED );