labofsahil/github-event-dataset-2012 huggingface dataset:
Just add a login function to the base authentication service class. 

Envoyé de mon iPhone

Le 2 oct. 2012 à 12:52, Tim Roediger <notifications@github.com> a écrit :

> In src/DoctrineModule/Authentication/AuthenticationService.php:
> 
> > + * <http://www.doctrine-project.org>.
> > + */
> > +
> > +namespace DoctrineModule\Authentication;
> > +
> > +use Zend\Authentication\AuthenticationService as ZendAuthenticationService;
> > +
> > +/**
> > + * Authentication service that adds login and logout methods.
> > + *
> > + * @license MIT
> > + * @link    http://www.doctrine-project.org/
> > + * @since   0.5.0
> > + * @author  Tim Roediger <superdweebie@gmail.com>
> > + */
> > +class AuthenticationService extends ZendAuthenticationService
> I'm happy if you say that this is outside the scope of DoctrineModule. However, I think the code has it's place, even if not in DoctrineModule. Why should every dev write the same lines of code when most of them just want to create a function login($username, $password)?
> 
> —
> Reply to this email directly or view it on GitHub.
>
If you take out the storage, and use the factory, then creating the AuthenticationService can be a one liner:

`return new AuthenticationService(null, $serviceManager->get('doctrine.authenticationadapter.odm_default'))`
Why `Protobufs` when we have `ThriftUtils`?
What version of java / eclipse are you using? I'm running:

Eclipse Java EE IDE for Web Developers
Version: Indigo Service Release 2
Build id: 20120216-1857

java.runtime.name=Java(TM) SE Runtime Environment
java.runtime.version=1.6.0_31-b04-415-11M3635
java.specification.name=Java Platform API Specification
java.specification.vendor=Sun Microsystems Inc.
java.specification.version=1.6
java.vendor=Apple Inc.
java.vendor.url=http://www.apple.com/
java.vendor.url.bug=http://bugreport.apple.com/
java.version=1.6.0_31
java.vm.info=mixed mode
java.vm.name=Java HotSpot(TM) 64-Bit Server VM
java.vm.specification.name=Java Virtual Machine Specification
java.vm.specification.vendor=Sun Microsystems Inc.
java.vm.specification.version=1.0
java.vm.vendor=Apple Inc.
java.vm.version=20.6-b01-415
probably being a bit overzealous with raise.  Returning nil for "that data isn't available" is usually easier to deal with than a lot of raising
Uber-nit: space after #
This is when it will show up in the network logger ui, right?
good, I like that version better (than the initial valueerror IIRC)
Je propose de modifier le pom.xml  du coup histoire que le env par défaut soit également esup : 
<env>local</env>
deviendrait 
<env>esup</env>
[c'est ce que j'ai fini par faire ici pour notre Esup4 avec l'environnement "runn" ]
Good idea.  That's a good reminder.
如果是类的话，就大写首字母丫。
Is it necessary to check for .fragment, since getFragment will cater for both pushState and hashchange modes?
No idea, aren't these just intermediate build files?
Is there a problem displaying our usernames?
If so I would image we could remove all ```.txt``` files from this project.
Not off by one -- mysterious how python lists are open on the right
Is this really a generic SoftwareProcessEntity method with correct default behaviour?
It at least needs some javadoc to say what it means.
For example, I might think I can edit an entity's configuration prior to starting it but once it's running then the set of possible modifications is greatly reduced.
Boom!  Bishoped, much better.  Updated
I would prefer `request.application_url` instead of http://service-url
あれ。ほんとですね。
Deixei com o choices para fechar este ticket, entretanto, acho que podemos abrir um ticket sem prioridade para remover o choices e deixar a configuração de areas mais flexível pelo admin do django.
This will test whether ASCII strings formatted as Unicode will work, but what about Unicode-only strings?

I'm not sure whether you're actually trying to test Unicode hostname handling or not, so this comment may not apply.
This code relies on Jefferai's patch in remote branch specfilescanning.
MozSmsFilter exists in desktop Firefox, so I think we don't need the check. Unless Gaia is also supposed to work on other browsers? (Which I don't think is the case...)
+1 for easier to read.
I like Joe's idea. Please do this.
In case it's ever important (and I doubt it would be) we should put 2012 (2013?) whenever we add to the existing header.

The PhoenixPilot Team, http://github.com/PhoenixPilot, Copyright (C) 2012.
Would be great to break these out into single lines -- right now, spiceweasel and other tools have a rough time understanding the dep loop like above...
На самом деле не очень правильно ограничивать документ только ожидаемыми типами узлов. В документе вполне может быть что-то лишнее, просто надо вычленять оттуда нужное.
I tried that once & remember there being an issue, so I reverted to copy-and-paste from a role model. I have no time to try at the moment, but maybe you could & amend the eggshell?
If I am not mistaken, this function should not be needed. If the user click on the main toolbox button, then we don't need a `tool` parameter, if the user use one of the tool menu, we should use `openToolboxForTab(tab, tool)` (not toggle).
Can you explain what you mean by "global leak"? It is intended to parse all GET arguments that are present in the url.query string and push them on the back of the existing arguments.
`{"tilemill":"0.10.0"}` ?
Let's just add the id to the mock app object, and then we can retrieve it from there in other methods.
You must have put a lot of work into this Adi! Unfortunately we normally avoid putting loops into the tests even though on the outside it seems like a good way to get a lot of coverage for a little code. The reasons I will explain: 
If the test fails at some point then the test will stop and all of the remaining items in the loop will not get tested.
We can't Xfail just one part of it - we can only XFail the whole thing and that compromises our test coverage.
If it fails it's hard to debug and tell which step of the loop failed. this is important because you need to know on what page the bug was.

In this circumstance it's perfectly OK to make some code duplication and have several tests for each type of sorting criteria. You might even be able to make use of `parametrize`.
So, somehow this `my_input` class is being applied to the wrapper? =(
unless the test is really robust to the seed I would use a local seed
@larsmans does the same argument hold here, too?
I totally agree - I removed it from the code base - I will set up an issue so that we can work on a common monitor API.
слушай, а может нам вообще сделать `$file->getImgTag();` ? я не уверен но раз уж у нас есть getInputTag
That's an issue, the case where length > 2 should be handle explicitly.  Otherwise we get into situations where 

`String.formatDate(date, format, extra);` will give the same result as
`String.formatDate(date);`

when it should be yielding the same as
`String.formatDate(date, format);`

I checked on the iphone and extra params are silently ignored so the condition should be changed to `length > 1`
Builder._type2variantCpu  is meant to be private to Builder.  The fact that you would need to access it without using the Builder class shows that there should be more thought put into the logical separation of classes and how they should be kept decoupled.

This would be adding some odd coupling
might need to add to dependencies though?
(or terminate if i == maxRows)
Trying again... ;)

Why not use the variable "user", instead of re-evaluating "queryUser"?
implement - it should be trivial - see ccdserver.cpp
Would need to do a lot more testing...

We should consider doing so, but as a separate commit / issue
Is this missing a STRINGLIB_API?
Otherwise it might not be exported (if we ever use those flags to control gcc visibility as well)
thanks for that link. I had read the same doc, but had somehow missed that all of those options were required on the compute node.

Thanks so much for that link to the code. You are clearly right!
Yes.  I'm sorry, It is typo.
"cppcm-hash" is correct.
We should only try this if the manifest_path exists, otherwise all add-ons that don't have restart tests will raise an exception.
Hmmm... $LOADED_FEATURES might be the alias for this?
We use "root" here, but it was "baseTemplate" when setting up?
lessc did that :(
`STATUS_CODES` is already defined in the base models.py.
Actually, it’s correct here.

It’s a different method implementation.

I should really factor these two into a single method, probably on site since deployment already depends on site.

Thanks,
Andre

From: Chris Tavares [mailto:notifications@github.com]
Sent: 23 de outubro de 2012 00:08
To: andrerod/azure-sdk-for-node
Cc: André Rodrigues
Subject: Re: [azure-sdk-for-node] Github (#13)


In lib/cli/commands/site_.js:

> +            } else if (options.git) {

> +              context.lvcClient = LinkedRevisionControl.createClient(cli, 'git');

> +            }

> +

> +            context.lvcClient.init(context, _);

> +

> +            // Scaffold

> +            copyIisNodeWhenServerJsPresent(_);

> +            updateLocalConfigWithSiteName(_);

> +

> +            initializeRemoteRepo(_);

> +

> +            if (options.git) {

> +              addRemoteToLocalGitRepo(_);

> +            } else if (options.github) {

> +              ensureRepositoryUri(_);

improper parameters

—
Reply to this email directly or view it on GitHub<https://github.com/andrerod/azure-sdk-for-node/pull/13/files#r1910625>.
The default endpoint has to be verified it's `https` or `http` only. From .NET SDK

    private static readonly AccountSetting DefaultEndpointsProtocolSetting = Setting(DefaultEndpointsProtocolName, "http", "https");
"====" over and under the header is a level higher in the header hierarchy than just below, so you can use "====" below the next headers, and not need to use "^^^^" on the lowest levels. This works nicely as is, just thought to let you know how it works.
@christianv Given the time delay, I'd like to address the open question with a follow-up commit as needed.
http://stackoverflow.com/questions/5091296/how-to-enable-colors-with-rspec-when-using-jruby-or-bundle-exec
aha, so __enter__ must return self
route_data << route_item
Won't this end up with ```--config-dir=--config-dir=foo``` ?
if res and res.code != 500 and res.code != 200
Since op5 its an applicance I wouldn't add compatibility with python payload without ensure which the python binary is available by default in the applicance.
You should just be able to do ``np.load("hand.npy")``.
Never happened to me to be honest. We can keep it that way, but I don't think this extra test is necessary. @stefanv how do you think about this?
Add `envVars` property in category `Tests` (or something like that)?
lets do this right off the bat. If we don't have the right url lets redirect without doing any processing.
if we wait for the ajax in click_all_time to take effect the locator will change in  css=#most-visited-table>tr:nth-child(2)>td:nth-child(1)>a or something similar
> Was this bug fixed in Chrome?

What was the bug?  I haven't seen any problems.
I see, carry on then :)
We know that anything that begins with `_` is private - no need to comment it.  In general, avoid comments like:

`i++  // add one to i`
Perhaps "camera position."  If we say viewer, people might not know how that relates to a camera, which is the most likely input.

As far as design, I think this "pass some arguments as properties and some as arguments" is hard to understand.  I thought the design was awkward when I first saw the C++ version years ago.  Perhaps the only benefit this design has is the user will hopefully not think to allocate a new `EllipsoidalOccluder` on every call, but that is probably equally true in my suggestion.  I don't know - I'd see if it feels better, and then make the call.
This check is not exactly ideal.  It's as if we want the projection to be able to return its GLSL, but given that the projection is in Core that seems too high level for it.  Ideas?
On mobile web, if the blob doesn't represent a file, then nativePath is an empty string. We can easily make it null if that's really what iOS and Android do.
Can we use a local variable, eg. boolean visibility=TiConvert.toBoolean(newValue) ? View.VISIBLE : View.INVISIBLE, instead of calling nativeView.getVisibility()?
this was left in accidentally, will remove it
эта реализация похожа на издевательство :)
Thats the second link provided below.
there's a primitive `overlap` or so
Yes, but we need to figure out how. I guess until that's fixed, we should either add the author as a copyright line, or figure out how to acknowledge authors (and maintainers) and then also implement it.
Excess parens.
So if the send fails, do we retry? And if we do, and it fails again, do we keep showing toasts?
can we keep the braces sticky at the type? :-) String[] parts...
I think for our use-case, a relative path would be better. I'll look into updating this.
You can actually pass a defautl as a second variable to `fetch_param()`. So you could replace everything that sets the delimiter with:

    $delimiter = $this->EE->TMPL->fetch_param('delimiter', '|');

Also, please use a more descriptive name than `$d`.
So i close this and try to resend in 2.0.
well you can actually just do ``if (!empty($config['request_content_param_converter']['enabled'])) {`` alone
well, I was just finding it weird to have an english word in the middle of bulgarian strings and so was wondering if it was a mistake or no
As a general comment, this should have been capitalized like "DeclineCd4Calculation". Standard practice is to treat acronyms like a single word, and only uppercase the first letter. (We haven't always done this right in OpenMRS.)
Since dsttype is already known to be INT, why recurse?
for me ::osfamily just says "Linux" which is not very useful at all.
я думаю це в suggest
ok. but you do modify it above, when you eat away the format. maybe we should say
     
        ....
        $part = $matches[1];
    } else {
        $part = $url;
    }

but its really a detail of code readability.
Когда будет — тогда и добавишь скобки.
no, you're right.  that was just a bug.
Correct. Using tabs allows the reader to adjust the indentation as he or she likes. Plus, they use less bytes (the lamest argument ever, I know ;)). I think the main argument against tabs comes from people using tabs for alignment, which of course screws up your code when someone has a different tab width. Alignment (if any) should be done with spaces, indentation should be done with tabs.

```
// ~ = tab
// ° = space

if (foo)
{
~if (bar)
~{
~~// the simple case: two tabs to indent and some spaces to align the definitions
~~$x°°°= 1;
~~$foo°= 2;
~~// above works perfectly with *ALL* tab widths

~~// again: tabs to indent. Since the position of '3' and '5' depend on
~~// how long the variable is, spaces must be used to *align* the
~~// literals.
~~$longLiteral = 1 + 2 +
~~°°°°°°°°°°°°°°°3 + 4 +
~~°°°°°°°°°°°°°°°5;

~~// alternatively, you can of course just go with the 'when breaking
~~// up a line into multiple lines, just indent them' rule, which would
~~// look like this:
~~$longLiteral = 1 + 2 +
~~~3 + 4 +
~~~5;
~}
}
```

So when used correctly, I don't see any reasons against using tabs.
Fixed, will run through jslint as well.
indented 3 lines, not 2
You don't just statically assert in the middle of a template like that. This will give the user no information whatsoever on what went wrong. In fact all of these static asserts should become template predicates. If an error message is really required, then you could provide separate overloads which error upon instantiation, e.g. in pseudocode:

```d
void destroy(T)(ref T obj) if (!is(T == const)) ......)
void destroy(T)(ref T obj) if (is(T == const)) ......) { static assert(0, "`destroy` doesn't work for `const` types"); }
void destroy(T)(ref T obj) if (is(T == shared)) ......) { static assert(0, "`destroy` doesn't work for `shared` types"); }
```
@andralex: The proposal already includes `InvalidMemoryError`, but _in addition_ a `NullPointerError` subclass which is thrown if the faulty address was particularly low.
I simply used automatic indentation. It's not a problem to change the alignment. (However, sometimes, especially after cut-pasting code, I sometimes apply automatic reformatting to entire files, which obviously destroys manual alignment.)
should probably have a more specific name; like GerritReviewersNotifier or similar.
Perhaps add some text before the link, e.g.,

Ensure that your code conforms to our [Style Guide].
Fixed in follow up commit
you are close on this (and the other methods) ... the word "should" needs to go between @verifies and get, here and in the other methods.
Would it be worth it to pull localhost:8779 into an ALLCAPS_VARIABLE?
i think `$configurations` would be a better name.
Figured out and clarified.
Should this also be 'technical_debt' to ensure we're using the same user details?
or only ``jinja`` as we don't have HTML code
Umm, you should have a gander at some of the roots of the modern, "responsive" movement - http://www.alistapart.com/articles/responsive-web-design/

A template need not use JavaScript or template logic whatsoever, in order to be responsive.
yep, do we have the case were the inner div should not have the `.inner` class?
groupId follows similar naming conventions to java packages
We note that we use the iOS constants but don't really explain how they are used
To make a file path you do `os.path.join(ctx.abs_target, BUILT_INDEX)` with `BUIT_INDEX` being `index.html`. `abs_target` is already absolute. `path.join` takes care that the result is a syntactically correct file path on the according platform.
Pretože ak súbor obsahuje IBA php, a nie je mixovaný s html a pod., tak by sa uzatvárať nemal. Tu sú nejaké dôvody:
http://blog.rogeriopvl.com/archives/php-files-closing-the-php-tag-or-not/
taktiež to začali praktizovať vývojári phpBB - pozri sa na EN language súbory.
I think we can use simple `str_replace()` here.
well, assuming you set it to ``date``
I think we should include a section on actually packaging an app with this setup, otherwise how is building the framework useful.
WTH???? Geen pragma once of ifndef header?
Comme pour "après que", on doit utiliser l'indicatif après "une fois que".