labofsahil/github-event-dataset-2012 huggingface dataset:
please elaborate?


On Thu, Nov 8, 2012 at 3:14 AM, José Valim <notifications@github.com> wrote:

> In lib/mix/test/mix/cli_test.exs:
>
> >        assert output =~ %r(\* creating lib/new_with_tests.ex)
> >
> > -      output = mix "test"
> > +      output = mix "test", [{"EXUNIT_CONFIG","none"}]
>
> We should probably clean up this environment variable on
> test/test_helper.exs than changing every test in it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/elixir-lang/elixir/pull/636/files#r2067906>.
>
>
1.5 passes :-D
can you put this in on the wiki so it's documented that these value's can be used? Or you can get rid of them since in the .eb file they are also defined...
Is that good practice? do one thing and do it right?
This bit seems to conflict with changes that @dgouldin made—not sure what should take precedence.
https://issues.jboss.org/browse/LOGMGR-44
Why not use `ok_(not ...)` when testing for False? This way is perfectly readable and good, I'm just curious.
Wrap this line. You might just want to make the literal a code block like the previous two.
I was using pending because isNew didn't seem to do the same thing. I can revisit that, though. Mostly the logic is in there as "full descriptor", since I needed to console.log-track all the possible cases, but we can take those out now I guess =)
This then becomes

```ruby
def parse_samlresponse(response)
  return response if response =~ /^</
  return decoded  if (decoded = decode(response)) =~ /^</
  return inflated    if (inflate = inflate(decoded)) =~ /^</

  raise "Couldn't decode SAMLResponse"
end
```
Looks like you missed the `+`, and the message doesn't seem to match the code. :P

Also, you should probably use `==` instead of `eql?`. In Ruby, `==` is used for basic value equality while `.eql?` is used in Hash when there are hash collisions... and then `.equal?` is used for object identity equality... Ruby equality is pretty messy.
それ， validator でやるもの?
Can we move these to constants so they can be reused in the other `getXxx` methods and we ensure they're always in sync?
re.escape on this an all password formats.
Can you move this step into a tearDown so that it runs and uninstalls the app even if one of the UI steps or assertions fails?

This will mean next time the test runs or a different test won't try and install the same app twice.

Sometimes we may run this test on a device twice without flashing/resetting it.
Two things:
1) I can't find any code in `cloudhead/vows` that utilizes the `--cover` flag. Are you sure this is needed?
2) As my comment above details: Check the coverage format agains a list of valid formats, this will remove the need for a default option.
I would like to see this generalized like in `getReporters()`, i.e. create an array with all valid coverage formats and only return a flag if the config option matches one of them.
Removing the acl is only useful for testing purposes.
For production environments it is better to leave this setting to match the local network only.
Having a test* prefix was just an accident. Something short and slightly descriptive will work. One consideration is that if you want to run a single test, it should be long enough to understand what it does, but short enough that you manage to type it on the command line.
Yeah, you probably want to make a factory that gives you the right instance of Remote subclass rather than giving this burden of knowledge to Tasks. Tasks shouldn't care which it gets back.

Remote::create
  pro? ? OSSRemote.new : ProRemote.new
Added "canSelectRows" property to determine whether or not selection is even available in the grid. If this value is "false", "isMultiSelect" will have no effect. Default value is "true" (assigned in the grid initialization)
I like the idea of having more of our extensions expose just an object to `Middleman::Base` rather than a bunch of objects, it's way cleaner. But in some cases there is only one method to expose, so I'd just expose that method. I don't think consistency is necessary in this particular case.
was there some kind of preferred style i 'broke' when i put line wraps the statement?
Perhaps we need another task to clean them all up then?
Would you mind to put it as the first element so we keep the alphabetical order?
Rather return `None` here. `False` is equal to `0`, which is a legal value.
No docstring or pre/post-conditions. Is it okay if this returns nil?
this is wrong, please disregard.
`path` is probably more fitting and in line with what we have in other places.
The rationale was that negative numbers could be reserved for "system-level" things, such as boot-strap, while people who plug functionality in can rely on just using positive numbers within their own set of custom functionality to determine what relies on what. We may even want to consider moving all "core" functionality into the negatives in the future, while all "contrib" functionality would be in the positives (since contrib functionality could depend on core functionality in their init's).

I personally don't mind if we have to say "All prioritized contrib functionality should have a priority higher than 10", v.s. "Higher than 0". If my rationale swayed you, let me know, else I'll make them all between 0-10 in a follow-up.
I'm fine with either, I just don't want to pass an array or an object. It should be the same everytime.
There are some places (~15 according to git grep) where we rely on it to be an object so it wouldn't be a major change I guess
Change this to [namespace, ...,] key
now looks corect, right?
The docblock needs to be *immediately before* the function definition and preferrably - indented in the same way.
Использование свойств, в данном случае, не оправданно.
Зачем `+1` то? Почему не +72? =)
ААА, понял, он будет путаться запросы же делать. Тогда да, тут всё правильно
Ifdef should be avoided here. Can it be placed somewhere else?
Stray NSLog?
$this->url() ?????
@jmikola Yes, this is the fix for the bug. If `recomputeSingleDocumentChangeSet()` doesn't have the extra loop, then changes to associations aren't processed properly.
I think this is the same as the current implementation: https://github.com/github/ReactiveCocoa/blob/master/ReactiveCocoaFramework/ReactiveCocoa/RACSignalProtocol.m#L207

It's obfuscated a bit more, but if a signal immediately completed repeatedly, that completion block would recurse infinitely.
Okay. Can you add some documentation to this method that gives an example of that?
Kan hier een base file van in de repo gestoken worden? Nu is het nogal vaag wat er allemaal in moet.
Please rename to `CommonAncestorOf`
缩进呢……
Why -1? That is 0xFFFFFFFF in 2-complement, right? Also, should we print the capability in hex or binary? It's meaning is not clear in base 10.
Sorry, testing / uncommenting/  WIP  stuff, for the actual it belongs there.
untested and buggy :)

ValueError('%s is not a valid score_func.' % score_func)
maybe ArgumentError here? Would it be better to use `is_a?` instead of direct equality of class?
Something to consider here, what if the session is empty?  The premise of CSRF is that an attacker hijacks an existing session.  If there is no session, there is nothing to protect against, so there's no need to add a CSRF token unless we already have a session.  I think this check should also check if the session is empty, and not add a token if it is, this will avoid creating needless session cookies for clients that have no need for it.
Might be worth mentioning to translators that this is the name of the site. Also, is capitalization correct?
why  not use `enumFile'`?
dad always said after a colon always upper case

the same as mama always said flush after creating an object
终于有个人写中文了，哈哈
如果请求头中未提供<header>User-Agent</header>域，浏览器以没有列出对待。
which one? I could generically link to akka.io/docs.
This reads as "All orders, ordered by ID in descending order, for this order's user, but only the completed ones, and the first of those."

Wouldn't be be better to read as "The first of this user's completed orders, ordered by ID descending"? i.e.:

```ruby
@order.user.orders.complete.order("id desc").first
```
same strip() comment as above.
`return result.value (0, -1);`
`:` с новой строчки
This is not the right package names
I'm not sure how I feel about multiline statements here either.
multiline alignment is good for you
This object would deserve a test
~~This is commonly referred to as the routing number in the USA~~
This is work in progress and will be used e.g. for GPX import.
Well, actually it could be a good idea, because is you like to add PostgreSql and more tunning, this part can grow to much.
What about moving the db-setup into a separate recipe `db.rb`?
Good points.  Done.
Would it really be that much clearer? I had to read your example twice to figure out just how it differed from what I've got there.
I tried calling visitExpireCommand from there, but there appears to be an interceptor somewhere trying to change the ImmutableContext that's being passed. I'll investigate further into what's happening, exactly. I would agree that mixing listeners and interceptors isn't ideal and, if implemented, would be a temporary solution. Has there been any discussion in the past about moving the expiration functionality out of the eviction manager that I can refer to?
can we extrapolate the version to a property ?
Please use SysPropertyActions.getProperty().
What about `ResponseMode.ASYNCHRONOUS_WITH_SYNC_MARSHALLING` ?
Why did you start the loop from the last element?
I didn't check the regex, this is from the previous @phiamo's PR. I'll check if I can improve it a bit.
This doesn't really need to be `malloc`'d. You can just return the struct directly.
Note: This means we can see if any of the tests are producing standard out (if your prepared to look at the travis log), and to determine easily *which* test is producing it.
And that function could be used to set an rcparam for default colormap...
There's a ``#`` sign, which, I think, is not supposed to me there here.
Is there a risk that Fields might not contain a "name" key? If it doesn't, Fields["name"] will be nil and the type assertion will probably result in a panic.
Just a nit, I'm not sure if we care but thought it would be worth noting; do we want to document what we expect this function to return? Looking at the other files in the <code>/atoms/</code> directory this is something that we've been doing.
why both a not_if and a checksum?
Is there a reason this got moved to before the cache lookup? It's unnecessary if there's a cache hit.
Not sure what rounding is going on here? Can you put some comments above the function outside the docstring to explain what this is doing? Stuff like "remove the seasonal component" is sort of meaningless w/o reference.
Please make this dependent of EMI too, as it is an EMI-specific adjustment
There might be some scenarios where it's still being laid down in cloud_state_dir, e.g. instance import. I will check it out.
Done.

- Rajesh Segu

On Friday, June 29, 2012, Public Keating <
reply@reply.github.com>
wrote:
>> +
>> +    request.notify("progress", this, function(response, evt) {
>> +        ok(true, "Received progress event");
>> +    });
>> +
>> +    request.notify("abort", this, function(response, evt) {
>> +        ok(true, "Received abort event");
>> +    });
>> +
>> +    request.notify("error", this, function(response, evt) {
>> +        ok(true, "Received error event");
>> +    });
>> +
>> +    response = request.send();
>> +    ok(SC.ok(response), 'response should not be error');
>> +    same(response.get('body'), {"message": "Yay!"}, 'repsonse.body');
>
> Tiny typo here:  repsonse
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sproutcore/sproutcore/pull/773/files#r1076546
>

-- 
regards,
Rajesh Segu,
www.rajeshsegu.com
I would recommend that `EditorWithToolbar` becomes `Editor`, and `EditorToolbar` becomes `Toolbar`, I think.
"possible configure" -> "possible to configure"
You use the backticks in the exceptions as well (such as `filename`) is that how it should be? (similar `~np.ndarray`). I thought they were only for the documentation, but I don't know.
You really need to memcpy here? What about casting pData to int64_t*?
Before this gets merged, it needs to require PHP 5.3.2.
Are you sure ``array($this, 'filterByLevel')`` has the correct type as "array" is not a sub-type of "object<callback>|null"?
This does not need to be checked here. The only way you could use this to become cloaked as non-spy is if you are the server, and then you can do whatever you want anyway.
Please remove this file, we won't want a stray knife.rb hiding.
I'd rather have a method that looks at a Map and returns whether to make methods accessible. Something like

boolean areMethodsAccessible(Map map);

This would allow someone to make the choice on a per map basis and not have it changed globally.
`lambda: timezone.now()` -> `timezone.now`?
```
panels_forcedby[dependency] ||= [];
```
What is used elsewhere?
As I said, I would like that you create a different view for password change, yes.
Spaces around `()`.
:D it is
Constant string. You should use `'`.
This is also done automatically. Check [the code](https://github.com/jschrewe/django-mongogeneric/blob/master/mongogeneric/detail.py#L19).
O no no. No no. No no no.

If you want something so repetitive, this should go to the panel's base class. And then this can be populated automatically.
Would you prefer the file name to be `r.timeago.js` or just `timeago.js`? 
The code for timeago is in lib/jquery.timeago.js - should I move that into the same file as the init function or leave it as it is?
Fine with whatever needs done, but not fully up on puppet'isms.  Also couldn't find anyone actually notifing two services, so just  changed the reload-samba that I found.
Not really. But the project uses NSubstitute NuGet package, so I decided to include it, to simplify getting this dependence.
BTW, how I should resolve your remarks? Should I fix issues and make new pull request? Or do something else? I'm new with GitHub code reviews and PullRequest modifications.
Production/Staging on EY are 1.9.3-p194

However, Woopy runs within apps that are on Heroku, and using 1.9.2-p290
Why used a static attribute for just one option ?
Exploring the collections API is definitely not cheating.
You must have to compil the kernel module by module-assistant auto-install xtables-addons.
So when you install packetfence with apt-get you can´t build the module in the init script (it use dpkg that is already locked).
So i prefer to document that and install by hand.
Please leave one space between function definitions.
在web中请用logging而不是print，防止输出至页面
This would be nicer as either:

    CHECK(false) << ("This should only happen when ctx->is_resource_fetch is true"
                                     ", in which case we can not get here");

Or just:

    // This should only happen when ctx->is_resource_fetch is true,
    // in which case we can not get here.
    CHECK(false);
Actually... technically I don't think you're meant to rely on std::string having a null terminator, or if it does have one I don't think you're supposed to rely on being able to access it safely through operator[]... so yeah, this loop should be changed.
do we really need to recompute/solve,  ``res`` still has the latest results ?
What about NegativeBinomial ?
we cannot use `?:` here as Swiftmailer must be compatible with PHP 5.2.
in this case we are providing a queue name as well
You seem to have changed the encoding of this file since all of it shows up as changed. Is this on purpose? It also makes it hard for me to review your code changes.
I presume this is really the name of the app (as used for the key in Andrei's code). You're using the fully qualified classname as that default name. At some point, we may add support for supplying a name as well.

I'd change the app description for undeploy to:
`where APP is the name of the application to undeploy; the default app naming scheme is to use the fully qualified class-name of the application`
Looks good! Mind cleaning up the formatting so it matches the rest of the file? Spaces between operators, arguments, etc? Thanks!
I don't understand. How do you mean?
The command is 'ismaster' though.. So how about "last_ismaster" ? That should making it more obvious how we actually got the data.
Is this line necessary?  I'm surprised that our resolving is still working even though we have absolute paths in this file.
Haben die einen Facebook oder Twitter-Account? Hier wär der richtige Ort dafür.
I think these class names would be more readable if you used `Test` as a suffix rather than a prefix.

That is:
* TestApp -> AppTest
* TestAppIntegrity -> AppIntegrityTest
* TestDisableEnable -> EnableDisableTest

Currently the classes feel named like methods.
Ah, yeah compare can't be used here. So this is meant to support just empty arrays and scalars? (i.e it will skip arrays with values and objects)
їх можна в шаблоні тягнути з category
This is where context manager initializes and hooks into webinos in order to capture data. I guess i put that here by rush, when i found the export. 
I could move that on top but i would prefer that it would load after your initialisations. That means i would put it just before the Pzp declaration. ( https://github.com/webinos/Webinos-Platform/blob/master/webinos/pzp/lib/pzp_sessionHandling.js#L50 )
Fixed in df3e8b7
Yes! I was thinking of having `settings.WEBTRENDS_METRICS_REPORT_ID` since there is an extra ID in that URL that is probably worth keeping secret and configurable.
Can you keep the keys in alphabetical order?
user() is in OBController, it doesn't have to be in Application. Look at the latest repo.
I think that both versions are OK, but mine is simpler.

PHP_VERSION_ID is available since PHP 5.2.7, but you need at least PHP 5.3 to use Symfony2 anyway.
This disables DMA. As this can at best be a temporary fix, i left the original line in there.
Ne pas utiliser Bootstrap.css directement mais plutôt la gem et overide les default. Je t'explique ça tantôt.
s/supportted/supported
It would be good to write `${name}` instead.
Since that form is getting a little complicated for a JS string, I think I will put it in calendar.php and set up the l10n that way.
Very interesting :+1:
Я всё жду, когда все догадаются сделать какой-нибудь IoUtils, в котором будет метод close, который делает это всё.
Надо кешировать в локальной переменной значение toString...
Этот файл удали из коммита.
I was really happy to get this logic out of the UI code, although `World#regional_depth` is an incredibly vague method name.
I'd call for asserting that:
- The blob content type is binary
- The blob content stream equals to variable `content`
I don't think this is actually going to be passed a third `node` argument, looking at the rest of the code.
no indeed
I wonder if it would not be more relevant to raise a LinAlgError here?
This behavior does not appear in the docstring.
As Mathieu said, `verbose` should be a constructor parameter.
Would be nice to put this in a green block
```
.. topic:: **Exercise**
   :class: green

   Fit a model....
```
nice catch - I included a new tree utility function that generates random sample masks (``random_sample_mask``) maybe we can use it in RandomForest too
should be 

```
"""Compute the cosinus kernel between X and Y
```

see pep257
Why are we copying this into a new variable?
Ок, провел небольшой рефакторинг.
Текущий метод request был переименован в __preparedRequest и создан новый метод request, который теперь вызывается как:

    $api->request($type, $path, $data = array(), $headers = array());

Обновил примеры, документацию и тесты, убрал из ридми упоминание про константы, они теперь останутся только для внутренних целей библиотеки.
Is there a good reason for making this optional?
You really don't need this cast to SRCTYPE.  float or double divided by int is hunky dory.
remove comment - the method is readable enough to grasp the purpose
true, time_t might switch to 64-bit for 64-bit code, but long isn't the same bit length across platforms and compilers aswell. int32_t sounds ok, but then we'll have to do something about     "time(&header.f_timdat);". "header.f_timdat = time(NULL);" should work for the next 26 years. I'll update the pull request.
Can you give this a default value so it doesn't mess up existing deployments?
Format this with literal: getGridCellsIds(Point lowerLeft, Point upperRight, int gridLevel)
Yes I agree, just haven't gone over all code to change.
I will change this one and repush
These definitions should really be somewhere more public
Not from EclWatch, but, I do not know from other sources.
Shouldn't there be a check/assert here?
e.g.  assertex(_size == (memsize_t)size32);
With this new awesome test I think you might not need your test_models.py changes since that stuff gets covered by these tests.
It would be nice to have a setter for cacheTime.
I'm not sure it's useful to mention window.alert as most browsers today have console.log anyway, maybe it's even better to mention that it's just like browsers console.log but logs into different location.
I see no need to change delimiters and boundaries, as they are defined as is in the URI standard (plus: docblock is wrong).
I'd say `_perm_cache` here since we don't want anyone relying on this externally.
Using the ``setUpClass`` and ``tearDownClass`` may make this test case faster to run.
This now sets up git-flow in any repo that has a `develop` branch.
DFReporter.log
there isn't really a need for those else statements since you are returning. (same below)
That's what I get for copy/pasting code...
SecureRandom needs to be a soft dependency. Actually, this doesn't need to be secure or random anyways, just use Rex::Text.rand_text(16).
This string is localized.  Check will fail if we're running on a non-English system
Update since `compose_implicit` was removed. (Same for line 60.)
Fixed. Didn't find any text that needed wrapping elsewhere, did you have another place in mind?
TODO: shorthand this if
Running against the gem in your dropbox works perfectly.

Weird, huh?
s/builder.exposeheaders/builder.exposeHeaders
tab.getBackground() actually returns a StateListDrawable. From what I see from the docs, there's no easy way of getting a color from a StateListDrawable.
There are actually a lot of sections of code where we threw in some conditional debug switches like this as part of resolving some bug, and didn't take them out for some reason. In general these are only switched on if you really care about them, so a unique prefix for filtering is a good idea.
"Node that was removed." suggests that it's the same as the parameter 'oldChild'.  Should we say something like "Node after child has been removed" instead?
Platform tag
This isn't checking for whether or not the subview is a `TiUIView` though - this checks whether the `TiViewProxy.view`is a `TiUIView`, which is always the case, even for those views.
Just remove this description. Our developers don't care about the Android API reference.
The summary I mentioned above should be enough.
= {};
I left it in there, to show how you can easily switch between testing develop/master.
@chrisroberts No worries. Also, that the non-"bulleted" list gets concatenated on one line is annoying to me :).
why allowing only the 2.1.6 tag of the ORM ? I don't see why the bundle need to be so restrictive about it. It works with other 2.1.x releases and I don't see any reason why it would be broken with 2.2.x so it should be ``>2.1,<2.3``
it should be ``Delete`` for the value
We had this problem with another module recently, and someone just submitted a patch to librarian that should fix it...

https://github.com/rodjek/librarian-puppet/issues/60

Would that solve things for you?
говно я имею в виду что я из функции которая занимаетс UI шлю эвенты к функциям про действия
I don't like having the version here
What about "Refinery now comes as"
ah, right. I keep forgetting that they don't support that :\
That's an interesting test. I can't see it in the generated reports, though. Is it to be executed manually?
> I don't think that we should change the old name and if a new license header uses LLC or Inc I don't care.

Ok, but I mean if "Inc." is the current name I think that's the one we should use for new files. IMO it just doesn't make so much sense to have a copyright note in favor of an entity which doesn't exist under that name any more.
Tu vas me trouver pointilleux et chiant (et c'est pas faux) mais pourrais-tu renommer "fichier PHAR" en "archive PHAR", c'est le terme qu'on a employé jusqu'à présent dans le reste de la doc :)

Merciiiiiiiiiiii :)
OK, then feel free to merge :-)


On Tue, Nov 6, 2012 at 10:00 AM, Lukas Stampf <notifications@github.com>wrote:

> In pom.xml:
>
> > @@ -1607,5 +1612,16 @@
> >          <enabled>true</enabled>
> >        </snapshots>
> >      </repository>
> > +    <repository>
>
> it is, i added this for the one day it took it to get to central and
> forgot to remove it.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/openengsb-framework/pull/777/files#r2040058>.
>
>
can you remove this else?
please inject your real dependencies instead of depending on the full container
There is an issue here. It will not refresh the cache automatically in debug mode when you do a change.
I think it's not, will fix that.
I approve of this removal of trailing newlines.
This should be removed once the migration is complete.
no need to import math, numpy also has pi.
Read the rule again: only classes, methods and functions should have braces on a new line. The rule below discredits your comment: Conditional statements should have braces on the same line, with a single space before the brace.
sometimes the output from `sh "curl..."` just returns the output instead of an object for that command
Added the regex from jquery.validate and credit to Scott Gonzalez in a comment above it.
popfd/popfq
I see your point. Yeah, after all the thing that really matters to avoid unnecessary IF statements so if both attributes at the end will be Expression than its fine. So yes I agree.
The CSS classes are copied over from DoctrineORMModule
wouldn't this cause a HTTP 500 if the project is badly configured?

I guess you also need an empty constructor for serialization to/from disk.
This was exactly what I was looking for (alternations), but my web searching had failed me. Thanks!
@christianv Separate these into 2 sentences: "... log in with user1:test. During development, ..."
OPEN_ID_URI should come from presenter
Hi PP Web Dev!!
Yes, that is better.


On 9. apr. 2012, at 13:20, Mitar wrote:

>> +    pip install django-pushserver
>> +    
>> +or by installing from source with::
>> +    
>> +    python setup.py install
>> +
>> +.. _pip: http://pypi.python.org/pypi/pip
>> +
>> +In your settings.py add ``tastypie`` and ``tastypie_mongoengine`` to ``INSTALLED_APPS``::
>> +
>> +    INSTALLED_APPS += (
>> +        'tastypie',
>> +        'tastypie_mongoengine',
>> +    )
>> +
>> +You must also establish a connection with mongoengine::
> 
> I would put *connection with mongoengine* into a link to [here](http://readthedocs.org/docs/mongoengine-odm/en/latest/django.html).
> 
> Probably better would be: *You must also connect mongoengine to the database.* No?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/mitar/django-tastypie-mongoengine/pull/1/files#r659677
I see that we are using both `.id`, `._id` and `.pk`. Probably we should stick to one? Probably `.id` is better as `.pk` is one function call more. And `.id` could be non-`_id` field if user wants so.
yep. So, basically it need to pass Object (can't be string). I already started making some changes as I looked in the event.js and figured that it will need to be JSON object.
Unseeded random generation scares me because it makes non reproducible doctests. I usual add seeding just before.
The .NET Framework behaviour, in 4.0 at least, is for this to be false. We need to be consistent.
Will this classes be installed in the db for users who have netfields in INSTALLED_APPS?
The same applies to this, it should be `1rem` imho
Why replacing underscores in tag with spaces? That won't be a proper tag/branch anymore.
If that's really wanted though, you could move this one line up and use for log_title also.
Plugin repositories are usually towards the top of the POM.
Is it convention to split attr_(accessor|reader) into multiple lines? Just asking for future reference.
nitpick - spacing
No symbols were references from this header
Got a cut and paste error here.
X (I'll stop commenting, just review below in case there are more.)
One suggestion which was initially proposed during the spec was (if I remember correctly) the removal of `anchorPoint` on iOS as a non-animation property.

Note that this doesn't make solving this problem any easier, just postpones it until we revise the animation subsystem.
Shouldn't we just change it to the cordova plugin format?
"Duly"?
Add missing test for non-numeric id values
why does this change appear in the pull request ? Seems like you messed your repo as this is already part of the WhiteOctober repo
Instead of undefined vs defined, how about unprepared vs ready?
copy paste error.
+ using task queue API