labofsahil/github-event-dataset-2012 huggingface dataset:
Just wondering about your reasoning for not obsoleting the attribute and convention?  Now there are two ways of doing the same thing...
I can add messages to your line if I don't like them.
why is the shipit icon a rodent in a fedora? is this some definition of shipit I am not familiar with?
Shouldn't the <link /> tag be properly closed here?
I'm going to have to make some changes in order to expose and make clear that there is a distinction between validating a signed_request and also checking that its age is not to old (would you trust a signed_request from last year?), and actually using the access_token (directly or via code) to verify its validity.

For most use cases a fresh signed_request will be enough and simply having a argument '$validate' which runs a /me will probably be enough.
Nice to see you over here :)
To your first question - I'd do that processing on the query side. That is, save the right kind of document in CouchDB and use the map/reduce functions in views  to decide how and what data to return to the user.

Collections: Absolutely. You can get anything from a list of ids to a list of full documents - you define what the views send back to you, and you can even use javascript in the map/reduce functions to return computed values, etc. Short answer - it's easy to define a view that only returns the fields you need from a collection. On the other hand, if the CouchDB is on the client anyway, you're not making an expensive HTTP call to get the data, so you may be able to merge your old lightweight list collections with collections that contain full models without paying a penalty for it.

I'm just getting into the replications part, but you can set up continuous replications. You can even set up your backbone app to listen to the local CouchDB's changes feed and update your collections and models in near realtime based on changes replicated to the local couchDB. It's not necessary to wait for fresh data, but you can. Update conflicts are marked in CouchDB as part of replication. I believe the replication is pretty solid, since it's one of CouchDB's main selling points.
This isn't a pull request, it's just a commit.  These are the exact same changes that were under discussion before--they were the reason we had the meeting.  All I was trying to accomplish here was to capture them so that the work isn't lost if we ever decide we do want to resuscitate them; this was the outcome of the conversation that Justin and I had about the earlier pull request.

To the point about "test -f"--the current framework doesn't allow you to capture exit codes from processes, only output from stdout.  test -f uses exit codes.  In any case the goal was simply to encapsulate the functionality in a method so that tests wouldn't need to duplicate the logic; then we could improve the efficiency of the operation by changing the code in one place rather than in each individual test.

As to duplicating the logic for creating a remote file: yes, it does that--I noted that in the comments.  However, it moves the logic to being a method on a Host object rather than a general method on TestCase.  This would allow different host platforms (e.g., one that didn't support scp) to provide their own implementations of this method--and again, we'd avoid the need to refactor the tests when that happened.

At any rate, just to re-iterate: my goal here was just to capture this work rather than throw it away.  I completely understand that this is the same set of functionality that did not achieve consensus in our meeting, which is why I did not issue a pull request.
Does this work with an "AND" too? I don't see code around this...
* tento riadok je moc dlhy, bolo by dobre ho rozdelit na dva (staci dat do zatvoriek a niekde v strede ho rozdelit, python si s tym poradi)
* `instr in block.instructions` netreba, ak sa process_instruction nebude volat pre ten if
* treba pridat komentare preco je ta podmienka prave takato
Thanks @siddMahen for the initiative.

I hate to be *that* guy, but I'm not really digging the native v8 bindings. In my experience node-waf has caused problems and I don't think the use case is strong enough to justify adding it.
OK. 2.6 adds code in order to be compatible with 3.*, so we should be ok with only one of the branches in the if-else's
no need this, if video laggy, just copy from GB latest, i recommend using 2.3.5 codec
Need to have a checkForLoaded method, similar to audiohttpserver one.
You're right. Good catch. Public shaming is in order.
Okay, so we add patch for framework for manual network searching (not
working with standard RIL)
Should we be embedding HTML in this return or should that be handled by the template or renderer?
Maybe using the qcom opensource omx vendor files will help with HW accel.
Kali has also got a qcom display tree for CAF's ics chocolate branch
https://github.com/Kali-
You've created wrapper for you code. It's good. But in your wrapper all code looks messy. You are operating with variables like a global variables style. Please, read once again chapter 9 of Flaningans JavaScript book.

Ideally each class/object has one responsibility. How many responsibilities it has right now? It should be re factored in mode classes have one responsibility.
nope 8)
@TomFischer  BTW I noticed one of CRSMatrix constructors stores pointers to these CRS data crated by outside and delete the memory by calling delete[]. This can cause mismatching of new/delete or malloc/free because you don't know how they are allocated. I suggest to let CRSMatrix copy the given CRS data instead of storing pointers to them.
yeah, I see your pt of view.  maybe a 3rd person can help decide what is more intuitive in this case.
I can see needing that info at some pt,  but my opinion is to leave it out til it's needed.
I'm a little wary of a property like that, because it can be mistaken to literally mean "dependency", and as we know,  in the context of a install set,  it's not a true/false distinction whether something is a dependency.   it can be "top-level" and a dependency of another top-level requirement.
Remove "HACK" comment block.
We'd better check $.isEmptyObject(matchedProps) before saving.
Gotcha. Thanks for the note. Guess I totally skipped over the `isMemcachedListening();` line.
OK, I'll switch to that to avoid any potential issues.
I think we can expect UFL to bring all the terms on the same domain under a single integral - so I think we should raise an exception if this is not the case, rather than it just being a FIXME.
4e08f6f
This is quite a long function. I think it can be split up into a few operations

* loading, validating, merging, saving could all be extracted
* dealing with old versions of the config can be split out into a 'normalize' function (a TODO to remove in a future version is also nice, so that we don't have to maintain backwards compatibility code forever)
* a try/except over 40+ lines is usually a bad sign, ideally this block is only a couple lines
Nice! This reads so much better than `lock.lock try { ...`
Even after the multi-line case statement?
because before we’re even started we know for a fact that we can’t have failed
here it would be easier to understand if define was Metric.apply, i.e. 

    def systemLoadAverage: Metric = Metric("system-load-average"
I don't understand what the scatter-gather thing has to do with using receiveTimeout instead of: environment.scheduler.scheduleOnce(environment.settings.SeedNodeTimeout, self, InternalClusterAction.JoinSeedNode)
It is very weird to argue for switching to Unsafe here. I'm with Patrik. 
1. It is not needed in this place
2. If you still think it is - prove it with a real-world benchmark - D. Knuth applies 
3. It adds complexity to the code, e.g. unnecessary baggage, cognitive overhead in understanding the code etc. 
We can't go around and optimize every singel AR to the verbosity of Unsafe.
On Sat, Dec 8, 2012 at 12:19 AM, Viktor Klang (√)
<notifications@github.com>wrote:

> In akka-camel/src/test/scala/akka/camel/ProducerFeatureTest.scala:
>
> > +    override def oneway = true
> > +
> > +    var lastSender: Option[ActorRef] = None
> > +    var lastMessage: Option[String] = None
> > +    def endpointUri = uri
> > +
> > +    override def transformOutgoingMessage(msg: Any) = msg match {
> > +      case msg: CamelMessage ⇒ if (upper) msg.mapBody {
> > +        body: String ⇒
> > +          if (body == "err") throw new Exception("Crash!")
> > +          val upperMsg = body.toUpperCase
> > +          lastSender = Some(sender)
> > +          lastMessage = Some(upperMsg)
> > +      }
> > +      else msg
> > +    }
>
> Also, assigning vars inside a transformation?
>
Yep. just to see if the sender ref is ok during transformOutgoingMessage.

>  —
> Reply to this email directly or view it on GitHub<https://github.com/akka/akka/pull/933/files#r2355028>.
>
>



-- 
Raymond Roestenburg

code: http://github.com/RayRoestenburg
blog: http://roestenburg.agilesquad.com
twtr: @RayRoestenburg
book: http://manning.com/roestenburg
They cannot both be true, but both can be false (during a restart).
I think Patrik fixed this differently in another PR
wouldn't it be better to store the listeners as `Runnable` instead of `() ⇒ _` and then it wouldn't be needed to create `new Runnable`
I'm thinking that the order of these is important in thinking about which parts to add first, next ...
@davidread 

Can you provide some feedback? This change only affects create_users() which is not used anywhere in core from what i can grep.  We shouldn't really be accessing this from outside of core so why do we need this.  Personally I'd like to remove create_users() as it is unused code.

Can you help here?

Thanks
But also more text to read ;-) I tried to use the first in cases where we have a very long string or many arguments. For simple cases like this, I prefer the shorter version.
Just for interest's sake, I'll point out that you could also do:

    user.pop('password', None)

and skip the try/except lines.
Markup the script name with double `
Co oznacza ta jedynka? Nie lepiej by było nazwać tą stałą?
I didn't find in the CURL API any return code or whatever to indicate that a transfer is paused...
ie: any field that belongs to this table in the AQL will NOT be saved
Thanks, dan!!
I was mildly surprised that you did it this way. I think 'expected <foo> got <bar>' is still useful even if you have a message passed in.

E.g.,

'Problem with tablename: expected string, got function' or whatever.
As I was factoring out the animation to become more iOS/OS X-like, I realized that it was already an array, so why not make this array public?
Yes, it might be valueable, but currently it doesn't check to see if the parent Container is in a selected state as well. I can add the code that checks that.
This exception can also be moved up to eliminate the nesting.
omg, good catch.
ton schema est pas a jour je crois, invitation n'existe plus ( devise_invitation)
sorry, nevšiml jsem si ukazatele. a i tak díky za vysvětlení :)
Indeed. I can fix that and backport this myself; Ondrej is busy IIRC.
Or better: " where unit is the unit of the sample spacing. For instance, if the sample spacing is in seconds then the frequency unit is cycles/sec."
по константной ссылке надо
Also, wouldn't the message be `to the 'has_many :through' definition`, with `the`? (just wondering...)
It works fine without it, but it just makes the `manifest.yml` file look really ugly, and bug reports become harder to debug.
break the line here:

```ruby
when /^enum\((.+)\)/i
  $1.split(',').map{|enum| enum.strip.length - 2}.max
```
Done https://github.com/rails/rails/commit/44f12bbba08071178ec256c03eecadacdf35dccf
Can leave these out, they're better demonstrated below
OMG! These conditional are too complex. Could you try to simplify they. The first idea that I have is:

```ruby
if column.number? && (changes_from_nil_to_empty_string?(column, old, value) || changes_from_zero_to_string?(column, old, value))
```
Yes, also there are classes using dash too. We need to reach a standard. I think the underscore version is preferred.
IMHO this would be cleaner as two distinct cases with two while loops rather than one while loop with a complex condition. For instance the variables count and terminal are specific to each case.
Noted. Since I apparently don't know what I'm doing regarding the how objects (as in object O vs. class O) are represented, I ask: if I have two ClassSymbols (since, as you say, objects get ClassSymbols), how do I find out if one of them  denotes an object?
I think it would be worth investigating using an extractor:

```
object SomeRef {
  def unapply[T](optRef: Option[WeakReference[T]]): Option[T] = 
    if (optRef.nonEmpty) { 
      val result = optRef.get
      if (result != null) Some(result) else None
   } else None
}
```

this way you don't need to call the `fallback` method twice:

```
toScalaMap get key match {
  case SomeRef(v) => v
  case _ => <inline fallback>
}
```

The downside of course is the Option-boxing happening in the extractor.
I just meant `this` is available as normal syntax. I don't think this is specific to scaladoc. Anyway, it's not that important.
please remove ``NumPy``, a 1-D array is clear.
``astype('d')`` --> ``astype(np.float64)`` would be more readable.
why javadoc style? should we follow Google style and use C style?
Would it be better to test something that is actually simplified. That is, something like:

    assert S('[[2/6,2], (2/4,)]') == [[Rational(1, 3), 2], (Rational(1, 2),)]
or `a *= sqrt(g)`
you could delete the above and write the below as `return result is result is None else indep*result`
Why is the change in `__mul__` necessary here?
This is wrong. You can't compare floating point numbers like that. You need to do it the following way:

abs(x-y) < 1e-3

Unless there is something that I am missing.
```
# insert terms in place
seq[current_pos: current_pos + 1] = o.args
```
There does seem to be some error in certain cases. I will try to refine the algo. Lets see.
Will do in all symmetry forms for [1,2,3,4,5,6,10], as that seems the natural set.
just to reiterate, though, sympy isn't able to tell if its odd or even using the current assumptions
I think there should be `default` validator for `connectionId` with `value="db"`.
could we make this a plString please?
is it better how?

-------- Original Message --------
Subject: Re: [karaf] 1) demos poms 2) karaf plugin "install" 3) karaf
features xmlns version (#6)
From: Andreas Pieber <notifications@github.com>
To: apache/karaf <karaf@noreply.github.com>
Cc: Andrei Pozolotin <Andrei.Pozolotin@gmail.com>
Date: Fri 17 Aug 2012 11:57:10 PM CDT
>
> In demos/command/pom.xml:
>
> > @@ -35,9 +35,15 @@
> >      <name>Apache Karaf :: Demos :: Command :: Extend Console</name>
> >  
> >      <dependencies>
> > +		<dependency>
> > +		    <groupId>org.osgi</groupId>
> > +		    <artifactId>org.osgi.core</artifactId>
> > +		    <scope>provided</scope>
> > +		</dependency>
>
> the formatting is still messed up in this file
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/karaf/pull/6/files#r1408433>.
>
Any reason why you changed this from `get` to `Ember.get`?
Picky : please use standard for `if...else...` control stucture to comply with the rest of codebase :

```
if (condition) {
     //...
} else {
    //...
}
```
No need for the quotes. 

Should we expose these errors on the L20n object?  I feel like it might be useful for developers, as they will have access to the Exception objects (via event listeners).

Also, I'd prefer something more DOM-like in terms of style, i.e. `L20n.INTEGRITY_ERROR` instead of `errorCodes.integrity`.
Hey you definitely don't need both this and the change I suggested together. Remove the loop.
"range" here refers to what you called "boundaries" above. Consistency with terms like these is important.

I think 

    Given 26 bits of precision and the default :ref:`bounds <geospatial-bounds>`, the precision of the index is approximately 1 foot or 30 centimeters.
What do you mean by the latter comment?
sure np!
This works but I believe we can avoid introducing a new function and just do:

```
{{ url('profiles_view_profile', pageuser.display_name }}
```

Thoughts?
> In terms of a test of three items, why not assert the entire order?

No reason, will push a fix.

> Can a node instance have a nil name?

Yes, but I couldn't think of other fields to sort on that would be persistent.  The node objects that we will typically be ordering will have non-nil names as they can't be persisted to the server without a name.
Could you push stuff as you fix it? I can't make sure that you've fixed everything correctly (there are multiple instances of SUCESS) if I can't see what you've changed.
Error checking missing.
Please cut all comment lines to 79 chars or fewer.
Delete ?>, make sure there is a newline at the end. Same for other files.
I think you misunderstood why I meant. Shouldn't the _js_include() function simply add $this->phpbb_root_path in front? But I guess it's cleaner if that function can take any path and won't always prepend the root path.

But I would definitely prefer that you pass $phpbb_root_path into the renderer over the current public solution.
If this is only needed for the tests, then this file should be included in the test itself.
Yeah, at least call disable after `$symfony_request``assignment.
this leaks the virgo_error_t, maybe we want to make a virgo__luaL_error() method that takes `L` and `err` and properly cleans up the error object / GCs it?
Based on two optional pop() calls below, a quick check here for > 3 would let us exit early if the basename isn't valid (has too many '.' s).
Not sure, it was copy/pasted from @mojit0's examples.  I don't think it does anything to be honest.
would do the same.
I think I need d as for creating list in search query i have to add start time and end time.
Let's remove this entirely out of fillPrescription. Instead, just make a call to printPrescribedDrugs().
See PR #124
I don't have the image results to hand, but it may be that this is exactly equivalent to the former. i.e. the ```map_setup(projection='moll', lon_0=120)``` call makes a global map...
I thougth we were going to do `\Sky\Memcache::config(array());`
we're not using `$sites`
Should the ``Sparse`` title above be removed?
This is related to schedule. cmodule_key used to be a static method that ordered nodes by calling fgraph.toposort. It now calls self.schedule. 

If different Linkers have different schedulers then cmodule_key must be a method and not a static class function.
I understand that it is a good and necessary thing to have a normalizer that can give SOME limited assurances even when limits may effect results.
I understand that we want to minimize the cases in which we fall back to this compromise level of validation.

I question how automatic and query-driven (vs. manual and configuration/file-driven) the criteria should be (or even CAN be) for when to apply the weaker validation.  That is, we have the option of ONLY running with fuzzylevel=1 with particular templates and statements that we know or strongly suspect are non-deterministic, and running all deterministic cases only ever in separate configurations with fuzzylevel = 0.

If the automation could be easily perfected, then we could make fuzzylevel 1 the only option, relying on it to do the optimal amount of validation tuned to each statement. But if it can't (as hinted below), maybe the better alternative is to keep it stupid simple, always validate just the counts no matter the query, and judiciously CONFIGURE the minimal number of cases where it gets applied.

Here's an example query that demonstrates that the above pattern matching is too much by virtue of being not enough:
"select ID, DUPLICATE from T order by DUPLICATE limit 1" meets the criteria for a full match even under fuzzylevel=1 but may produce a false negative after "insert into T (ID, DUPLICATE) values (1, 2); insert into T (ID, DUPLICATE) values (2, 2);"
Queries are always lists already, this is not needed anymore.
Once again, the state/macro thing.  Since you changed it in other places probably want to change it here too.
I'm not sure if that's technically correct as it will raise a 500. Is there any previous mentioning of what should happen if AJAX access isn't supported?
please don't add trailing whitespaces in empty lines (they should be really empty)
List test outcome (pass/fail)
I agree with @rwldrn , no reason to expose this on the object. Let's make sure once Rick removes the IIFE's that we make this private. I can't imagine anyone droppping in a defaultDisplay replacement.
Done! compute_log_Mi is changed to compute_exp_Mi. Thanks.

On 2012-08-16 17:59, Feng, Xixuan (Aaron) wrote:
> In src/modules/crf/linear_crf.cpp:
>
>> + iflag = 0;
>> + return;
>> + }
>> + execute_entire_while_loop = true;
>> + }
>> +}
>> +
>> +void compute_log_Mi(int num_labels, Eigen::MatrixXd &Mi,
> Eigen::VectorXd &Vi) {
>> + // take exponential operator
>> + for (int m = 0; m < num_labels; m++) {
>> + Vi(m) = std::exp(Vi(m));
>> + for (int n = 0; n < num_labels; n++) {
>> + Mi(m, n) = std::exp(Mi(m, n));
>> + }
>> + }
>> +}
>
> This function seems to compute exp_Mi instead of log_Mi which is the
> name of this function. A name that describes what this function is
> actually doing would be helpful.
>
>  --
>  Reply to this email directly or view it on GitHub [1].
>
> Links:
> ------
> [1] https://github.com/madlib/madlib/pull/199/files#r1398193
Can we clean that up, maybe after KeeSiong first?
Moved this up to win some time for the Windows operations.
Why not have the default be ``::``? I would prefer to be IPv6 enabled by default if we can, though we might need to import the has ipv6 test result into the settings. Other option would be to have a blank string as the default and pick ``127.0.0.1`` or ``::`` automatically.
@serman What do you think of making the HTTP API purely WebSocket based, like @woutervanwijk suggests? E.g. send JSON over WebSocket instead of doing AJAX against a REST API. Would this be an OK approach for your use case?
Pointless test
The only reason I can think is if you didn't own /usr/local/var, which is sort of bad anyway. sudo means it'll all be owned as root, which is way worse, I think.
no, because autogen.sh first does make -f Makefile.am log which generates ChangeLog from git log's output. You're no more within a git repository once in staged root.
`bin.mkpath`
Better to set the leave date and create/save a new participation instance so the historical data of when someone was organizer of a course is not lost.
I think there might be slight differences across platforms, but mostly I just didn't take the time figure out how to put the code in portable.
yeah it's to see what's is unpacked ... 
this has worked with POINT ZM (.. but fail with other. the size or the order is not good)
Possibly. I only refactored the existing test classes, I didn't implement new functionality.
I'm wondering whether maybe the error paths should send an ack too (ack everything)? I'm not quite sure a delivery report is the right thing to send on errors -- maybe a failure would be better? I wonder if we don't need a failure event to send back to applications (not for this PR)?
There are a couple of scenarios here. If they are using the auto_set_breadcrumb method - then I believe it should be opinionated - both for Home and and Index values. Home is always 1, and Index requests are always 2 and anything after that is 3, or above. However the i18n point is valid and I mentioned that somewhere (I forget where).

If they are not using auto_set_breadcrumb - then the user has full control over the breadcrumb stack and it can be set for each controller, in a before_filter with a helper method defined on a per controller basis.
Fixed on master.
Hi Yura, this file seem to be identical with testData/ontologies/ISO24751-2/flat.json, except for being wrapped in an object and keyed with "ISO24751-2/flat" .. Does this have a purpose, or could it be avoided somehow?
You're right, it doesn't throw an exception. I think the `.git` directory name is actually case sensitive.
Gonna be THAT guy again... `this` instead of `@`
Is that correct formatting?
Should this be `@media (orientation: portrait)`?
3770 looks like a magic number. Replace with constant?
In JS if you pass a bad array index it helpfully returns `undefined` silently instead of throwing an exception... not my favorite feature of the language :-/
Yikes. Makes me wish we had resize events from the DOM. In my past pull requests, reviewers have been cautious to use a solution like http://benalman.com/projects/jquery-resize-plugin/ that relies on polling.

There's a lot of width adjustments here that shouldn't be necessary. Are we doing something wrong with the .sidebar overall? I know we had to play some tricks to get the selection marker to span the width of the jstree. I'd like to address that problem first or at least file an associated bug noting the difficulties.

There are events that the scrollerShadow and selection triangle listen to for resizing/repositioning. This should work:

```
$("#project-files-container").trigger("scroll");
$("#open-files-container").trigger("scroll");
```
This is a little confusing -- it's documented as being a QuickOpenPlugin, but it's actually a plain object that gets converted to QuickOpenPlugin internally.  It might be better to document all the properties of the bag here, moving all the info from above down into this comment since this is the public-facing API.

Also, nit: change "plug-in" to "plugin" to match arg name.
Would be idiomatic to just chain `.appendTo($parent)` onto the previous call, but that's up to your stylistic preference.
please do page.$model.data.getAttribute(...

getXml gives you a copy. That's very expensive.
did you add the check that makes sure the user can access that domain? i don't see it
I'd recommend using `navigationService.NavigateToViewModel<HubViewModel>();`. It's a much prettier approach.
`language` is missing (or you have not yet pulled this in)?
Thanks, running without relational database.
can this not be included in the .html file as well so we can work with it like we do all of the other elements?
Move "util/lang" to new line so it's more obvious it's there
Will fix -- I didn't read the "Contributing" file before contributing. :)
Are we using send so we can call private methods here?  If so, why is that necessary?
这里在shm结构体里面加个slab的成员变量吧，看起来清楚一点。
That's one thing that puzzled me when I looked at the code the first time. Pages that are accessible under different URLs. With/without trailing slash, with slug or without. I was under the assumption that it was good practice to have a single canonical URL for a page. Did that change?
I've noticed this while coding as well, the code can be more efficient. For me, this code was more readable and i believe (because of if statements) the query is not performed 3 times.

I'll try to rewrite it...
Guess I am just slightly confused.  Is history a list of jobs? And history_tasks a list of tasks for specific job?  The names of those actions just don;t seem to make it click for me.  But may be helpful to get others to weigh in the event its just me.
Ok, could you add this kind of information as a comment to the code for it to be more clear when to use it?
Yeah let's empty string it.


On Wed, Nov 7, 2012 at 8:56 PM, Robin Kraft <notifications@github.com>wrote:

> In test/fossa/core_test.clj:
>
> >    "Test read-occurrences using sample dataset"
> >    (read-occurrences)
> > -  => (produces-some ["Acidobacteria" "242135095" "9.93166666667" "0.896666666667"]
> > -                    ["Acidobacteria" "244666043" "47.166668" "19.583334"]
> > -                    ["Acidobacteria" "244664083" "-40.8747" "170.851"]
> > -                    ["Acidobacteria" "244662123" "15.509722" "73.88306"]))
> > -
> > -(fact
> > -  "Test latlons->wkt-multi-point"
> > -  (latlons->wkt-multi-point [1 2 3] [4 5 6]) => "MULTIPOINT ((1 4), (2 5), (3 6))")
> > +  => (produces-some ["Acidobacteria" "242135095" "9.93166666667" "0.896666666667" "\\N" "2005" "3"]
>
> I think the \N are for the precision field. Is there ever actually data
> for that? Can totally replace with empty string though.
> … <#13ade605a80aee1f_>
> On Nov 7, 2012, at 9:53 PM, Aaron Steele <notifications@github.com>
> wrote: In test/fossa/core_test.clj: > "Test read-occurrences using sample
> dataset" > (read-occurrences) > - => (produces-some ["Acidobacteria"
> "242135095" "9.93166666667" "0.896666666667"] > - ["Acidobacteria"
> "244666043" "47.166668" "19.583334"] > - ["Acidobacteria" "244664083"
> "-40.8747" "170.851"] > - ["Acidobacteria" "244662123" "15.509722"
> "73.88306"])) > - > -(fact > - "Test latlons->wkt-multi-point" > -
> (latlons->wkt-multi-point [1 2 3] [4 5 6]) => "MULTIPOINT ((1 4), (2 5), (3
> 6))") > + => (produces-some ["Acidobacteria" "242135095" "9.93166666667"
> "0.896666666667" "\\N" "2005" "3"] I wonder if we can drop these "\\N"
> values and replace them with empty strings? It'll be another big character
> saver. Maybe? — Reply to this email directly or view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/MapofLife/fossa/pull/7/files#r2065325>.
>
>
Don't we want to keep precision field?  Right?



On Wed, Nov 7, 2012 at 10:20 PM, Aaron Steele <notifications@github.com>wrote:

> In test/fossa/core_test.clj:
>
> >    "Test read-occurrences using sample dataset"
> >    (read-occurrences)
> > -  => (produces-some ["Acidobacteria" "242135095" "9.93166666667" "0.896666666667"]
> > -                    ["Acidobacteria" "244666043" "47.166668" "19.583334"]
> > -                    ["Acidobacteria" "244664083" "-40.8747" "170.851"]
> > -                    ["Acidobacteria" "244662123" "15.509722" "73.88306"]))
> > -
> > -(fact
> > -  "Test latlons->wkt-multi-point"
> > -  (latlons->wkt-multi-point [1 2 3] [4 5 6]) => "MULTIPOINT ((1 4), (2 5), (3 6))")
> > +  => (produces-some ["Acidobacteria" "242135095" "9.93166666667" "0.896666666667" "\\N" "2005" "3"]
>
> Yeah let's empty string it.
> … <#13ade762a012cb1d_>
> On Wed, Nov 7, 2012 at 8:56 PM, Robin Kraft <notifications@github.com>wrote:
> In test/fossa/core_test.clj: > "Test read-occurrences using sample dataset"
> > (read-occurrences) > - => (produces-some ["Acidobacteria" "242135095"
> "9.93166666667" "0.896666666667"] > - ["Acidobacteria" "244666043"
> "47.166668" "19.583334"] > - ["Acidobacteria" "244664083" "-40.8747"
> "170.851"] > - ["Acidobacteria" "244662123" "15.509722" "73.88306"])) > - >
> -(fact > - "Test latlons->wkt-multi-point" > - (latlons->wkt-multi-point [1
> 2 3] [4 5 6]) => "MULTIPOINT ((1 4), (2 5), (3 6))") > + => (produces-some
> ["Acidobacteria" "242135095" "9.93166666667" "0.896666666667" "\\N" "2005"
> "3"] I think the \N are for the precision field. Is there ever actually
> data for that? Can totally replace with empty string though. …
> <#13ade605a80aee1f_> On Nov 7, 2012, at 9:53 PM, Aaron Steele <
> notifications@github.com> wrote: In test/fossa/core_test.clj: > "Test
> read-occurrences using sample dataset" > (read-occurrences) > - =>
> (produces-some ["Acidobacteria" "242135095" "9.93166666667"
> "0.896666666667"] > - ["Acidobacteria" "244666043" "47.166668" "19.583334"]
> > - ["Acidobacteria" "244664083" "-40.8747" "170.851"] > - ["Acidobacteria"
> "244662123" "15.509722" "73.88306"])) > - > -(fact > - "Test
> latlons->wkt-multi-point" > - (latlons->wkt-multi-point [1 2 3] [4 5 6]) =>
> "MULTIPOINT ((1 4), (2 5), (3 6))") > + => (produces-some ["Acidobacteria"
> "242135095" "9.93166666667" "0.896666666667" "\\N" "2005" "3"] I wonder if
> we can drop these "\\N" values and replace them with empty strings? It'll
> be another big character saver. Maybe? — Reply to this email directly or
> view it on GitHub. — Reply to this email directly or view it on GitHub<
> https://github.com/MapofLife/fossa/pull/7/files#r2065325>.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/MapofLife/fossa/pull/7/files#r2065437>.
>
>
The exception here means that you cannot use this handler in a codebase written without knowing this handler as it would not have the ``event`` key. For instance, enabling this in a Symfony project will break things on the first log message
Hi Paul,

Just committed changes to disallow "T UNION T" and union with more than 1
partitioned table.
https://github.com/alexeevm/voltdb/commit/7f7c062f7c187575ee62900f5d38b2b2c1d00884

The unit test still uses old technique to make table partitioned
(explicitly in the code) - haven't pulled the latest changes in yet.

Thanks,
Mike

On Fri, Sep 28, 2012 at 8:46 AM, Paul A Martel <notifications@github.com>wrote:

> In tests/frontend/org/voltdb/planner/TestUnion.java:
>
> > +            aide.compile("select A from T1 EXCEPT ALL select B from T2", 0, false, null);
> > +            fail();
> > +        }
> > +        catch (Exception ex) {}
> > +    }
> > +
> > +    @Override
> > +    protected void setUp() throws Exception {
> > +        aide = new PlannerTestAideDeCamp(TestUnion.class.getResource("testjoinorder-ddl.sql"),
> > +                                         "testjoinorder");
> > +
> > +        // Set all tables to non-replicated.
> > +        Cluster cluster = aide.getCatalog().getClusters().get("cluster");
> > +        CatalogMap<Table> tmap = cluster.getDatabases().get("database").getTables();
> > +        for (Table t : tmap) {
> > +            t.setIsreplicated(true);
>
> The issue with T UNION T stems from the same sort of limitations that
> prevent T JOIN T from working correctly -- at this point, I would suggest
> giving an error if any table mentioned in a UNION's (UNION TREE's) children
> occurs twice.
>
> For now, I would also suggest just living with the current restriction
> that the final plan can only have 1 or 2 fragments, meaning that only one
> of the selects can be multi-partition.
>
> To me, a higher priority is either error handling or disabling "inferred
> SP" support. Or BOTH error handling AND disabling -- try planning with
> inferredSP and on failure retry without inferred SP -- I THINK we do
> something similar with multi-statement batches. What we need to avoid is
> cases like "SELECT ID, DATA FROM T1 WHERE ID=1 UNION SELECT ID, DATA FROM
> T2 WHERE ID=2" where each SELECT would normally run as a single-partition
> plan and contain a single fragment, but the PartitioningForStatement state
> would indicate that the single-fragment plans are only valid when run each
> on their own partition.
>
> In theory, in some cases where there are exactly 2 such single-partition
> SELECT plans -- or where there are only 2 different inferred partition keys
> shared by the two or more SELECTs, the SP plans can be stitched together
> into an MP plan by adding a Receive/Send pair to the top (and possibly a
> Distinct Node) but this would be very ambitious and could only be a
> specialized feature for specific SetOperations.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1716910>.
>
>
Because it's Optimize, not OptimizeSpeed.

BTW, I think -O3 is rather harmful for embedded
I'm not going to add support for scalars right now, until we are happy with the rest. But I'll keep that on my list.
Sometimes I should think a bit longer and pull a bit slower ^^.
Don't know why it wouldn't...
I saw this in other places in the code and just wanted to do the same ... thought it would be considered standard in the code base for large strings. I'll revert this one.
I'll add a comment. But the reason is not that it allows attackers anything. The corrections were already very conservative and limited to what base58 considers equivalent, so there was already no risk of look-alike addresses.

More like:

  // Corrections made are very conservative on purpose, to avoid
  // users unexpectedly getting away with typos and sending to the wrong address.
I think exactly the same :P

I invite you to read 28bd6880df2f4a6bd182bcb0f3a04dd5a1b64fad which got itself to master, and later b75a6b440abfbaf7af3ef82dd19eb4aff4be5847 which fully explains the rationale.
Typo; should be `environment`. Although I agree with @rchavik about excluding this message all together. :)
@markstory Commited the test case using the E_* constants now.
@nschonni pretty sure you're right on that one. lgtm.
I'd recommend to inline @var documentation.

```php
/**
 * @var string Cache directory
 */
```
you should remove the extra braces around the instanceof check
Just to note, $filter might not have been initialized at this point. (I didn't check 'delall' and 'delete', but tbh I wouldn't count on it either way)
item_type_id
For a modicum of portability, I've been using len(j.VISIT_LIST). Relatedly, the number of realtime visits is at self.json['study_info']['rtVisits'].
While we're on the topic, the visit_info dict of each visit has the key 'type', which is either "prepost" or "realtime". (Grep around for "j.VTYPE" to see how I've been using that.)
Check out json_template.py for more handy accessors. And if there are some things we should be computing only once and then saving as object variables (self.rtRuns, self.rtVisits, self.totalVisits, etc), then awesome, let's do it that way!
The notebook is currently broken in this branch.  Due to typo here: should be `add_button_group`.
Well, in the other builds that were accepted I followed this approach since we validate at build time.  I guess we could just throw an NPE.
I'll do both.
tu peux voir ici que ConfigParser vient avec un shortcut pour faire un get de integer a ta place. getboolean, qui converti les 1, true, 0, false etc en bool(True) et bool(False)
varTestFloat
I love stuff like this. ;)
No, not really, it was more complex initially and I eventually simplified it this way, I should remove it.
this code is going away and this technique will  go away with it.  though, I must admit that I have some affection for it as manual dependency injection can be very useful.
You don't need to create a temporary variable. Just stick it in! :point_right:
Condition to be refactored (too large)
I think we still need it if you use `jump_to` when resource is not passed.
btw, you are not even sure that ``log.context`` will be defined according to the DebugLoggerInterface
it doesnt seem to be used. and it doesnt handle invalid indices which result in a php notice
no need for a var here
Well, you should use the form type hierarchy to apply the logic of the collection type, not PHP inheritance.

and your own listener should not extend ResizeFormListener but apply only the logic needed here (the one you placed in a closure) and then let the collection type add a ResizeFormListener when applying its own building logic.
Andrew, my implementation is simplest possible and rock solid. Only way to break it is to change layout of view. And this case does not happen that often.

On the other hand approach you suggest can break in two ways:
* you call [self setQuietTime:YES] two times - this can happen and it will make view to travel a lot in one direction
* you call [self setQuietTime:YES] and [self setQuietTime:NO] quickly one after another - this will interrupt [YES] animation and "frame.origin.y" will have undefined value before calling [NO]

So in order to make you suggestion work I'll have to track state of view, original "frame.origin.y" and add code complexity.

This is first time in ~6 months this view has broken, so there is no need for such a prevention.

I'd apply golden refactoring rule:
* if it breaks 1st time, quick fix it
* 2nd time, quick fix it
* 3rd time, refactor!
yes I know, but you are fixing .gitignore, please fix this line too
Controllers are funny - there is no global "state". The ivars used are local to the actions/methods.

So effectively, using the ivar would be local to each action.
Strange indentation here?
`self.projection.domain` is what you need
I'm not keen on this, but it can wait until the tests are fully migrated to unittest.
BFGMiner has generic stats functions in the device API, but kanoi threw a fit and stopped Con from putting it in CGMiner... maybe it should be reconsidered.
isn't this a Django bug then? Is this tracked somewhere?

Also since this test only does assertNumQueries (according to the name), why not use a conditional unittest.skip decorator?
This would deserve to have a shebang and be executable...
maybe add a note that Nodes do NOT have a connection (or are not required to have a connection) to Page and that developers should NOT try to access Page objects via NavigationNodes
Why is this diff showing up here??
Instead of doing a `get(this, 'orderBy')`, why not just call `this.orderBy` here? You'll have to make sure `this` is passed as the second argument to `forEach`.
@trisapeace @mecathcart there was the mysterious disapering book, sorry it was me!
What about moving this method to an EjbSecurityManager interface in the ejb3 module, that extends ServerSecurityManager ?
Perhaps this should be handled when working on Hans mail.
On SGS2, these changes looks fine, but seems not correct on otoro.
nit: Dodgy indentation.

Can we call this something like "results" instead of "visited"? top sites, history and (usually) bookmarks have been visited too!
You are referring to 

https://bugzilla.mozilla.org/show_bug.cgi?id=810431
It's not working for me... I cant see the photo of a contact in 'contact-live-search'
It's numeric (see http://mxr.mozilla.org/mozilla-central/source/dom/network/interfaces/nsIDOMMobileConnection.idl#434).
This will completely break the initlogo. I believe this is a typo or not something you want to do?
nit: remote it too
nit: indentation (not blocking on this)
Okay, I got it. I didn't think of it will be changed individually by user in flight mode on, so `this.reservedSettings.*` may not sync with current state. 
Thanks for review. :)
`/sdcard/temp-music`

Just in case if someone had already left a `temp` dir there.
if (navigator.mozSms) {

}

I know :), is just one line and it's moved, but it improves readability.

Thanks!
This pattern has always seems awful to me, why do not declare this method next to the const that turn it on or off.
Same, we should listen just for the text inputs
please currentPage !== current-page, or I'm wrong?
Do we need to prefetch te images?
Yeah sure, i'm agree 100%, i let that work to you guys!
l10n. Also, why all the yelling?
I think we should change this interface actually. Rather than handle one data point at a time, it should handle all data points emitted in the same time interval from a task. So the interface would be like:

handleDataPoint(TaskInfo info, Collection<DataPoint> dataPoints);

TaskInfo would contain the generic information like hostname, task id, port, timestamp, and updateIntervalSecs. Each data point would just contain the name and the value.

This also requires the metrics tuple to pack together all the data points for the same sized interval into one tuple.
I'll re-iterate on the naming
Is there a reason why QColorDialog::DontUseNativeDialog is removed when there is a note to saying it should be used?
Shouldn't this be set_breakpoint? If you maintain a state on both sides and use non-idempotent calls, it can become very confusing if you mess it up somewhere and the states become inconsistent.
The Args class does not expose its internal hash. So I can either subclass Args and have a CascadeJobArgs, or I can modify the Args class to expose it internal map. Or, I could add an argsFor(prefix : String) method to Args that uses the above logic, basically returning the subset of the Args map that is either not prefixed at all or is prefixed with the provided prefix. What is your preference?
Actually, matching on \w+ won't work either as that will yield only the punctuation in the returned array.
I would definitely leave the `abort` in here. Before this commit, the idea is that copying over the file is absolutely required, which is broken by this diff. Why would you want to continue on if copying the file failed? I saw from a different issue that there is a desire to keep the AppController running, but I would argue that there must be a better way to do it then to allow it to exist in this broken state. Furthermore, since we would log it as a "CRITICAL ERROR", that implies that this is exceptional and some kind of drastic action needs to be taken, and certainly not just `break`.
Nevermind will change over since it exposes more info on failure.
Why cannot you just get all the settings and output those like we do with component configuration?
Translations needed in translation_support.coffee
Not in the second if, then the first action would only be executed in 
the next gameturn. The first if is a shortcut for silent actions which 
are excecuted only once and have no followUp.
Rather than use this separately in multiple methods it might be better to have a private method:

````def ticket_client
    @ticket_client ||= TicketClientConnection.get_client
end````
As I said, I don't like all the condensing without benefit. Makes maintenance harder.

I'd be fine with the above example and a do-while instead.
This could probably be:

``` python
def getSourceStamps(self):
    return list(self.sources)
```
The link is timing out for me, but it seems that `<pre>` isn't a reasonable default style. I'd think that a description is typically going to be some prose, so a regular font would be best.
Should be `} elseif (...) {`
actually, we could do


```

while (current.is_a?(Reshare))

```
ntohs returns uint16_t, so the format for printf should also be unsigned with modifier for 'short', i.e. %hu.
How is #exists? working with other locators than :index?
This should probably wrap the `if ($code === 301) {` from line 26 as well if it's conditionally redirecting, shouldn't it?
But... it's private. Doesn't make sense to me.
This seems broken.  This field is being reset each time this method is called.  This variable (and the following two) should just be local to this method.
P.S.: Also your example there returns `true`.
Lots's of sync IO here, if that's just for test that's fine, but than it should live in test folder.
@6a68 - i am the one who put that line in, and this diff pulls out the reason i put it there.
They are sibling keys in the same dictionary.  That is a rather misleading comment but an easy fix!  It looks like I repeated it everywhere so I will clean them all up.
`my` feels like an odd choice of word here, given it is always followed by a block.  It might be good to pick a more descriptive term, and either retain `my` for compatibility, or ditch it since it never shipped to anyone.

My main concern is that this reads oddly in the manifest:

    my {
      # random Ruby code
    }

    my do
      # ditto
    end

Perhaps something like "ruby do" or "globally do" is better?
I'm a bit concerned about pulling these provider-specific options into the type.

I know there are some other issues that are causing the platform team to consider allowing providers to define properties themselves, it's probably worth chasing this up with Andy and Eric.
Probably the current time + the maximum wall time. That should give the kernel ``max_wall_time`` seconds to get an execute reply back to the server, regardless of whether it receives an execute request or not, which not only stops long-running computations but also solves for the case where an execute request is never actually sent.
https://github.com/domenic/mocha/blob/693fc6bcd7354e9d05d4134e8166245eaaca4499/bin/_mocha#L363
Rephrase to read, "There are fewer elements than specified in the collection (%s). Either set the allow_remove option "
Thats only a helper method and should not part of an interface
This line is indented differently from the original one. It means that "department_fields" will be outside of container they were in previously. Is it OK?
Fuuuuuuuuuuuuuuuuuuuuuuuuuu----

Anything else before I rage quit? (or have a bath of coffee)
Per your comments on the other PR, why not != APR_SUCCESS ?
Gehört das hier hin?
yeah, we need to plug this into django signals instead, so the document is updated as it comes in. this management command should not be run on a regular basis
then, why allowing a criteria in loadAll if it does not apply the proper logic ?