[Filesystem] missing realpath breaking FilesystemTest class on Windows (one line of code change)
[EventDispatcher] Adding IteratorAggregate to GenericEvent
added a missing phpdoc param
[FrameworkBundle] Allow to set null for the handler in NativeSessionStorage
fixes pre for var_dump with xdebug
merged branch bamarni/patch-5 (PR #5285)

Commits
-------

bd9319b added a missing phpdoc param

Discussion
----------

added a missing phpdoc param
merged branch drak/nullhandler (PR #5290)

Commits
-------

8e11aaa [FrameworkBundle] Allow to set null for the handler in NativeSessionStorage

Discussion
----------

[FrameworkBundle] Allow to set null for the handler in NativeSessionStorage

Bug fix: no
Feature addition: yes (ok for RC)
Backwards compatibility break: yes
Symfony2 tests pass: yes
Fixes the following tickets: 5267
Todo: ~
License of the code: MIT
Documentation PR: ~

Refs #5267

Adds the following configuration

```
session:
        handler_id: ~
```

Which allows the configuration of the session not to use any save handler and therefor just use whatever save_handler is set in `php.ini`

---------------------------------------------------------------------------

by dlsniper at 2012-08-17T17:24:37Z

:+1:
merged branch Marmelatze/var_dump (PR #5291)

Commits
-------

9c20634 fixes pre for var_dump with xdebug

Discussion
----------

Displaying var_dump with xdebug in exceptions

When debugging code I often use `var_dump` to quickly look into variables. Since 2.1 alle output generated by `var_dump` is displayed in one line. http://screencast.com/t/11LuIlIdHsvP
It seems to be no problem for small objects, but it becomes a real pain when displaying huge arrays or objects.

This is caused by the changed word-wrapping for the pre tag introduced in #3827

With fix: http://screencast.com/t/GdA3dkpWxU

---------------------------------------------------------------------------

by dlsniper at 2012-08-17T17:22:38Z

:+1:
merged branch mtdowling/event_dispatcher_add_iterator (PR #5268)

Commits
-------

0ad00f8 [EventDispatcher] Adding IteratorAggregate to GenericEvent

Discussion
----------

[EventDispatcher] Adding IteratorAggregate to GenericEvent

---------------------------------------------------------------------------

by drak at 2012-08-16T07:43:29Z

What is the use case for this that it should be part of the Generic event?

---------------------------------------------------------------------------

by mtdowling at 2012-08-16T17:12:28Z

This allows for the GenericEvent to be even more generic. Now listeners don't need to know an exact key from the arguments, but rather can iterate over the arguments to find what they are looking for. This makes the GenericEvent more like an array.

---------------------------------------------------------------------------

by mtdowling at 2012-08-17T19:31:04Z

How would this be a nasty break? It's just giving the GenericEvent more capabilities with IteratorAggregate.

This is a completely separate PR from the one that flipped the constructor args.

---------------------------------------------------------------------------

by schmittjoh at 2012-08-17T19:34:47Z

Why are you not just doing ``foreach ($event->getArguments() as $arg) { /** ... */ }``?

If you just have ``foreach ($event)``, to me at least it would not be so clear what we are actually iterating over.

---------------------------------------------------------------------------

by mtdowling at 2012-08-17T19:39:23Z

This class already has ArrayAccess. If you're already using this class like an array, then I think you should expect to be able to iterate it like an array. I'm just finishing that concept off by implementing IteratorAggregate.

---------------------------------------------------------------------------

by schmittjoh at 2012-08-17T19:47:43Z

Indeed, if we already have ArrayAccess which we probably don't want to remove again, then that seems reasonable.
small optimization
merged branch Partugal/patch-guesser-perfomance (PR #5298)

Commits
-------

630d16b small optimization

Discussion
----------

[Form] Guesser perfomance

speedup depends on count of guesses
on my tests is 2,4 and 6 x faster for 5, 10 and 20 guesses
merged branch bdmu/ticket_5233 (PR #5234)

Commits
-------

47b8538 [Filesystem] missing realpath breaking FilesystemTest class on Windows (one line of code change)

Discussion
----------

[Filesystem] missing readlink breaking FilesystemTest class on Windows

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5233
Todo:
License of the code: MIT
Documentation PR:

fix for windows plateform

$file == 'C:\Users\USERNA~1\...' before touch
$file == 'C:\Users\Username\... after the touch and readlink so it can pass following assertEquals

---------------------------------------------------------------------------

by bdmu at 2012-08-13T05:35:07Z

Hello,

Another solution may be (need to test it) to add
    $this->workspace = realpath($this->workspace);
line 36, after the
    mkdir($this->workspace, 0777, true);
in the setup method

Regards,
Christophe
Update src/Symfony/Bundle/FrameworkBundle/composer.json
merged branch guilhermeblanco/patch-11 (PR #5310)

Commits
-------

595a974 Update src/Symfony/Bundle/FrameworkBundle/composer.json

Discussion
----------

Update src/Symfony/Bundle/FrameworkBundle/composer.json

Supersedes #5308

---------------------------------------------------------------------------

by guilhermeblanco at 2012-08-21T16:50:10Z

ping @fabpot
[Form] removed getPositions from PropertyPathInterface

this method was just an implementation detail (that is not even needed) and should not be part of the public API as it serves no purpose
Fixed a typo
[Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again
merged branch Tobion/proppath (PR #5313)

Commits
-------

79a1257 [Form] removed getPositions from PropertyPathInterface

Discussion
----------

[Form] removed getPositions from PropertyPathInterface

This method was just an implementation detail (that is not even needed as my implementation shows) and should not be part of the public API as it serves no purpose.

---------------------------------------------------------------------------

by fabpot at 2012-08-22T06:19:35Z

ping @bschussek

---------------------------------------------------------------------------

by stof at 2012-08-22T09:11:51Z

what is the performance impact of your implementation compared to the previous one ? the form binding is executing this code thousands times for big forms.

---------------------------------------------------------------------------

by Tobion at 2012-08-22T14:08:39Z

There is none of course.

---------------------------------------------------------------------------

by bschussek at 2012-08-22T15:23:57Z

Looks good to me.
merged branch goohib/fix-form-component-typo (PR #5323)

Commits
-------

bca68ca Fixed a typo

Discussion
----------

Fixed a typo

The CSRF error message won't be translated due to this typo even if the translator is enabled.
merged branch bschussek/issue5221 (PR #5319)

Commits
-------

a38232a [Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again

Discussion
----------

[Form] Fixed: FormTypeInterface::getParent() supports returning FormTypeInterface instances again

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #5221
Todo: -

---------------------------------------------------------------------------

by stof at 2012-08-22T14:14:55Z

the return value of the getParent method should be updated in the phpdoc of the FormTypeInterface to mention the FormTypeInterface .And the description of the method should be updated to explain than returning an instance is discouraged as it implies a performance penalty and does not support using type extensions (if the comment in the factory also applies to the unregistered parent)

---------------------------------------------------------------------------

by henrikbjorn at 2012-08-22T14:22:00Z

Wasn't TypeExtensions supported before? This means that Csrf will not be applied?

---------------------------------------------------------------------------

by stof at 2012-08-22T14:23:50Z

@henrikbjorn the csrf extension is targeting the FormType, which is registered in the form registry. What is not supported is having a type extension targeting an unregistered type

---------------------------------------------------------------------------

by bschussek at 2012-08-22T14:39:53Z

@stof Exactly. I find it a bit unlogical to register an extension for something that is not registered.

---------------------------------------------------------------------------

by henrikbjorn at 2012-08-22T14:39:57Z

Okay. That wasn't what i got from reading the comment :)

---------------------------------------------------------------------------

by bschussek at 2012-08-22T14:44:27Z

@stof Updated.