labofsahil/github-event-dataset-2012 huggingface dataset:
Something about this block of code doesn't quite look right to me.

Is the call to inode_dio_done() supposed to be commented out?  and is it the only thing that's done if the flag is set?

It looks like, from the indenting, that all the "wake anyone waiting on unwritten extent conversion" stuff was intended to also be in the if (io->flag & EXT4_IO_END_DIRECT )  block, but is not actually due to no curly-braces.

I won't pretend to know what this code is doing, but since we're having issues in recovery with backing up an ext4 partition (/data), it might be worth making sure this code is actually doing what it is supposed to.  I did find out that the TAR command used for backing up data is going into an un-interruptable sleep while waiting for IO to complete, and it seems like it is never woken up.  Since that looks like something this code here could be doing wrong, maybe it's worth a look....

Sorry to be a PITA :)
> Yup. outside = regular text highlighting, inside = highlighted.

I'm not sure that that is a good idea. Sometimes .cfm files will have hash tags inside of them without surrounding them with cfoutput tags when the file is included for instance in some frameworks. Don't you agree?

> I did get a bit confused from your pre-edit response as from what I could tell scope in or out of cfoutput was always text.html.cfm :)

Actually if you include text.html.cfm inside cfoutput the scope will be `text.hfml.cfm text.html.cfm` so you'll get a superfluous scope in there.
created #90
Adapters: `li3_queue\extensions\adapter\storage\queue`, base: `li3_queue\extensions\adapter\storage\queue\Base`.
Yikes! Thanks for the heads-up. Fixed - although the lack of the :aot tag
is giving the annoying "No namespaces to :aot compile listed in
project.clj" error - have tried a clean leiningen install and it just keeps
on happening....

On Sun, Feb 26, 2012 at 10:10 PM, Phil Hagelberg <
reply@reply.github.com
> wrote:

> Just a heads up; the debug task looks like a duplicate of lein-pprint:
> https://github.com/technomancy/leiningen/blob/master/lein-pprint/src/leiningen/pprint.clj
>
> Also you should remove the :aot from project.clj.
>
> Looks handy apart from that.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/snewman/lein-gentags/commit/a1d8794c589f24a8f66fc79fe2d22ac2e9f63053#commitcomment-1013080
>



-- 
sam
http://www.magpiebrain.com/
why not remove the component altogether if it's not used ?

Is there a jira issue about this so that we don't forget to fix it?
Sorry, a bit new to git/github. Not sure of the protocol for pushing changes back to a project I fork. 

PS - nodemon works well for me, thanks!
enviando Readme
There's nothing in it--but it should get filled in. How do you run tests for mirocommunity?
Ha, well, there you go.

But the question remains: would that help solve this issue?
You can mark something in the profile to replace the original project.clj work.
There are three problems:

- His commit edd09ef06a (which you merged, doh!) broke CPButton and CPPopUpButton mouse tracking and also broke updating of titles in CPPopUpButton.

- I don't like this test for `_highlightsBy == undefined` either, it should *always* be set to something. That tells me that stuff is not getting initialized correctly. Both _showsStateBy and _highlightsBy should always be initialized, currently they are not.

Personally I think edd09ef06a should be reverted until all of these can be addressed properly. Not having proper mouse tracking and title updates is a much bigger problem than not having the extra button types.
ok. no prob.
(pedantic comment, just to show that I read it)

You interchange 'code' as the numerical ID and 'code' as the java program here, making the extremely useful comments (yay) slightly harder to follow.  Might want to consider using 'java' or 'implementation' in place of 'code' for clarity.
Can we just make currentTime do this instead of making exactCurrentTime?
you could even do:

q.exec("delete from trainers where laston < '" + string date + "');

One line solve all!
I was getting the following error and failing in the nightly build Installer:

./postinstall: diff: extra operand /Library/Mail/Bundles//GPGMail.mailbundle'

I can only guess that the paths should be quoted as they are elsewhere in the script.
got it, that looks good
The CCRepeat bug is probably this issue.. http://code.google.com/p/cocos2d-iphone/issues/detail?id=1288.
Sorry.. I checked in some garbage..  That empty method can be safely
deleted.

Ian

>This method name is missing a character. Is this method deliberately empty? I always prefer to check in comments explicitly marking where there is known missing functionality.
>
>--- 
>Reply to this email directly or view it on GitHub:
>https://github.com/ianupright/org.intrace/commit/120d9bbfc2f2d046130b4f1824b2bca365dc75f8#commitcomment-1047355
`getDefaultLanguageCountry()` is only called by `loadLanguage()` and `getDefaultResourceName`, and `getDefaultResourceName` is only called by `loadLanguage()`, so you can pass the locale around by parameter which is better than keep the locale in a mutable field here.  After all the current locale is determined by the `Options` object.  This makes more sense because the current locale is an option setting.

My point is, by removing the `locale` field we would have one less mutable state to care about in this class.  Just my 2 cents.
I'd rather see this along the lines of:

  when "foo"
    log_action
  when "bar"
    log_action
  end
  @ taxon_concept.reindex_in_solr

...Meaning, it always gets reindexed, regardless of the visibility...  less code.
TODO: Add the site offset
<img src="http://picquick.ru/uploads/11022012/c03782a183177a1ce8fd16036bccae0f.png" />
wala lang, try try lang
Hi

Yes I will prefer to trigger a new events like Tapestry.AJAXFORMLOOP_ROW_ADDED and Tapestry.AJAXFORMLOOP_ROW_REMOVED. 

What do you think ?

Manu
This isn't code that we really care about, but I think should null-terminate s even if fgets fails
LNK2019: unresolved external symbol "protected: virtual void __thiscall ByteBufferException::PrintError(void)const " (?PrintError@ByteBufferException@@MBEXXZ) referenced in function "public: __thiscall ByteBufferException::ByteBufferException(unsigned int,unsigned int,unsigned int)" (??0ByteBufferException@@QAE@III@Z)	AuthSocket.obj	authserver
@zbohm Sorry I haven't gotten back to you about this. I haven't had much time to try to re-create the initial problem that I was trying to resolve here. I can tell you that I ran into this issue when using ReportLab with xhtml2pdf to render tables using html tables. I will get back to you with more information once I can reliably recreate the failure.
it is the automatically created files from netbeans project
all i edited myself was the part at the bottom of build.xml
verdammt :-)
lol I just realized the problem *facepalms* I am using the BML version.
Didn't notice the filename on my phone...

On Mon, Jan 9, 2012 at 9:26 PM, Daniel Yehya <dyehya@gmail.com> wrote:

> Soooo just tried to flash the kernel by downloading from link and using
> download manager to install, rebooted into recovery flashed and rebooted
> and now just getting a Samsung boot loop. Power on Samsung for a few
> seconds reboot same thing...same thing going into 3-finger recovery.
> Throwing it in download mode to reflash recovery....Even if the download
> was corrupt it shouldn't mess with BML8 (recovery partition) and then will
> download again and try and reflash manually.
>
>
> On Mon, Jan 9, 2012 at 8:35 PM, Paul Blair <
> reply@reply.github.com
> > wrote:
>
>> The kernel is on my site. I've been running 100-1316, set with setcpu for
>> the entire day with no issues...yet. I've been running benchmarks here are
>> there and have played a game for about ten minutes. I thought about posting
>> the kernel on the forums for people to test, but feedback from the general
>> public is rarely very helpful.
>>
>> http://xda.toadlife.net/packages/CleanGB-MTD-Kernel-1510b5ac03.zip
>> --
>> Sent from my Android phone with K-9 Mail. Please excuse my brevity.
>>
>> dyehya <reply@reply.github.com> wrote:
>>
>> We can email through GitHub... That is awesome... If you can email me the
>> compiled kernel, I can help test for stability especially under high load.
>> Unfortunately with just 1.2Ghz enabled (1.1 disabled and not using 1.3+),
>> I
>> still have soft reboots randomly. Don't know if it is kernel or ROM issue.
>> On Jan 9, 2012 4:00 PM, "Paul Blair" <
>> reply@reply.github.com>
>> wrote:
>>
>> > I might just remove the 1.4 step too. As I said 1.4 has never worked for
>> > me either and since the whole point of my ROM is stability, removing 1.4
>> > completely might be the prudent course of action. As for the voltages, I
>> > don't have a lot of experience with voltages which is why I didn't touch
>> > them.
>> >
>> > ---
>> > Reply to this email directly or view it on GitHub:
>> >
>> >
>> https://github.com/toadlife/CleanGB-Kernel/commit/1510b5ac031c0d1ceb2787db5470f67e41e2ce25#commitcomment-851173
>> >
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/toadlife/CleanGB-Kernel/commit/1510b5ac031c0d1ceb2787db5470f67e41e2ce25#commitcomment-851817
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/toadlife/CleanGB-Kernel/commit/1510b5ac031c0d1ceb2787db5470f67e41e2ce25#commitcomment-851843
>>
>
>
Oops, my bad. Thanks
I want to add a plugin that supports to import Twitter Bootstrap from github. so I executed the commands like below: 

    git clone https://github.com/brunch/brunch-extensions.git
    cd brunch-extensions
    npm link
    [Code Modification]
    npm install

Before this modification, `npm install` command compiles the sources, so I don't need to compile. But now, I have to.
What do you execute when you want to compile? `coffee -o lib/ src/`?
Haven't changed the variable name from flap.
meant to be 2 separate commits :(
toemilk: It's not adjustment for the menu, but for the order in which it is randomly picked.
Might we get more than one of these attached if the user ends the encrypting of the session and then encrypts again?
Do not always blame others, the first clear understanding of your own.

I release the above questions, not behind the repair.

 You know what?
I don´t see how that matters, because we override the render-method anyway (using the one from clearablefileinput). so yes, we could extend fileinput and actually use the clearable render-method. no point in changing that IMHO.
why you no `Object.keys(this.gameObjects).forEach`
Nice, so that when starting bumblebee daemon, we should modprobe it like this "modprobe bbswitch load_state=0 unload_state=1". And stopping bumblebee daemon should unload bbswitch.
Thanks. Yes, very useful. I'm using it in my rewrite of Tar Heel Reader,
our literacy site for kids with disabilities.
gb

On Mon, Feb 27, 2012 at 7:42 PM, Arwid Bancewicz <
reply@reply.github.com
> wrote:

> True, could be useful to find out which element was animated and for
> consistency with animate. That or opts.complete.call(el) will do. Committed
> 253e53cb8d92668d12965052a29bfbcdf4beb0e9
>
> Really appreciate you uncovering these issues! Hope you find it useful.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Arwid/jQuery.scrollIntoView/commit/c86f597a5b2195fe2b2a820b7e5227c35cd3605d#commitcomment-1017793
>
> And it is debuggable if it ever happens. A simple grep for the key is enough.

You don’t understand such kind of bugs. Pretend there is a code that checks dictionary for being empty and behaves differently depending on this. What should you grep?

> sort, filter, .. they all change in place. So tell me why I should do it
differently.

The fact that vim is doing wrong things does not says you should do the same. `grep` and `map` in perl, `filter` and `map` in python all return a new object. In-place map and filter can be used for performance reasons, but it is not an issue here.

I don’t think it is likely to happen in this case too, but when there is a choice “to copy or not to copy” dictionary I will always do the first. There is not a single reason why we do want to add a new key to existing dictionary.
esto pa que es?
now in this case am I pulling the status from a thread (Where finished is 4) or should i consider the exit() function where in that case status may be 0
"@content" => 'Brian'
How do you mean? I think the method name and the code are quite clear, with no pitfalls.

That is, how do you think a comment could add net value here, given the implicit cost of comment maintenance and rotting?
Thanks, this helped a lot.  I was making (at least) the following error.  I was thinking of Record's from the perspective of Fennec, as something with state that changes over time, and therefore I was thinking of deletion as a state of a Record instead of as a state of the Envelope transferring back and forth between the server.
Hooray for backwards compatability! :)
I think it uses nowhere. I will remove it.
Of course, the sha reference in the commit is a complete lie and should actually be twitter/bootstrap/33a969dd0c.
hehe yea i saw. only one tweet tho :)
Why is everything static! WHY!
Great! Thank you so much. Even it worked very well for me. 

Once again soo much for you instance response and honest solution.
man... are you feeling alright?
That's your personal style. Please change it after the pull request was submitted and add your own pull request.
does fog support any kind of logging?
OK, can you remember/do you have more notes from Benilton's class? I just can't remember if this is right, and I get confused by talk of "comparing expression against the average for _all_ samples" -- this isn't what I'm saying in this comment. But is that actually what the contrastsMatrix does?
That's not really necessary here
change "SimpleLIstItem" to node.getType() + "Item" so that this function can be inherited by other lists.
I think it's due to necessity for permissions check to set private setting on user being the owner. It's not checked later, maybe should?
What about make this part a hook? I guess some extra microformats could be added in the future.
but the logger is private, so only available in the current class...
why semicolons?
This seems weird, what's the difference between success(Fail(e)) and failure(e)?
uuh, inlining that would be pretty ugly
"abandon" could technically be mutable, and in this case you're exposing it to other threads.
this won’t fly: breaks horribly in all kinds of cases, not even thinking about remoting. ActorRefs MUST be properly registered with the provider, because they must “just work”, we cannot add crippled ActorRefs.
That was used for the "rest_controller" which is now history, I think.  This routing would be handled in the new rack based stuff when it arrives.  I will delete it.
Okay will fix it.  I had the impression that you added it in at some point.
fanstatic resources do not need to be included in the script block could have been in the page block and then no need to have scripts block at all
Ah, I didn't notice that subtle difference and the tests were passing. Am I right that TCPServer instances are only used in cli for restarts ? Why not just close and open new socket ? To prevent closing opened connections ?
you can lump these `.removeClass()` calls into one (saves DOM API calls!):

    $sortedColHeader.removeClass('sort-asc sort-desc').addClass('sort-null');
Is this the one where an account is added it an existing card?  That form was going nowhere, it would just sit there after sending the mail and saving. I don't think I broke it, but this seemed better.
oooooo :)
yes, I thing we should (and this code does?). The stream and extradata are disposed if codec, width, or height have changed. Then the parser is initialized again. Should we add more criteria to check whether the old stream should be released?
Then how can this work? GetAbsoluteTimes will still only use the difference between start and stop time for duration and add that to pPacket pts. Wasn't the whole point that that didn't work anymore?

Err.. i may see what is going on. You have also kept your old change in GetAbsoluteTimes (+= instead of =). So the comment about it only using duration is not valid anymore and it's name isn't really either. I would prefer that that function was in it's original state. Then always trust the timestamps that have been passed through ffmpeg.

Also you seem to have lost the whole: overlay->replace = true; logic.
No need to transform to a List here
This line (and some others) look mis-indented.
This isn't thread-safe.  You can use an AtomicReference to the map.
I agree. I am installing a column limit now.
This default needs to take its units from the settings, or we'll get an error when someone builds a non-em-based grid.
You're right. By default i always add Twig Extensions to my projects and I didn't realize that truncate was one of these. Should I move it to the twig-extension documentation?

BTW, shouldn't this function be moved to the Twig core? I mean, it's really common when you're working on frontend to truncate string to make them fit (i.e. long product names on listings)
This can use the new object literal syntax: `@[ _textRenderer ]`
This should be a property, and the ivar should only be prefixed with a single underscore.
Please fix the header attributes:

 * Public for OS X
 * Project for iOS
I'M SO SORRY D;


On Wed, Nov 21, 2012 at 7:52 PM, CodaFi <notifications@github.com> wrote:

> In lib/UIKit/TUIPopover.m:
>
> >
> >  - (void)removeEventMonitor {
> >  	[NSEvent removeMonitor:self.transientEventMonitor];
> >  	self.transientEventMonitor = nil;
> >  }
> >
> > -@end
> > -
> > -//***************************************************************************
> > -
> > -CGFloat const TUIPopoverBackgroundViewBorderRadius = 5.0;
> > -CGFloat const TUIPopoverBackgroundViewArrowHeight = 17.0;
> > -CGFloat const TUIPopoverBackgroundViewArrowWidth = 35.0;
> > +- (void)setBehavior:(TUIPopoverBehavior)behavior {
>
> This entire method is in SPACES
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/github/twui/pull/143/files#r2202100>.
>
>



-- 
Aditya.
why you delete the dni?
Please don't use defines where at all possible. Use something like
const int record_header=8;
你确定你在字符串中嵌入变量的语法正确？
make sure that all paths set in outputs are absolute.
Travis failure is legitimate: https://travis-ci.org/numpy/numpy/jobs/3172720

The ternary operator here isn't supported in Python 2.4.
This seemed nonsense to me, you cannot delete something along an axis which is not there in the first place... why silently return the array in this case? But maybe I should document it, or someone knows that this makes sense for anyone... Similar goes for np.insert, though there the special case makes maybe a little more sense.
Good point again!
qstring const &repoInfo, mb
You can remove this too ;).
Ops, I just notice `result-file` does do that, so nevermind :)
Has this changed recently?
Yes and no, I just noticed that you don't know to which class you're delegating until runtime, in that case DelegateClass won't do, since you need to know the delegated class when you define the object.

That said, even if also uses `method_missing`, I would still use Delegator because it handles things like #respond_to_missing?, #public_methods, etc.

Something like

    class QueuedMessage < Delegator
      def __getobj__
        @actual_message ||= @mailer_class.send(:new, @method_name, *@args).message
      end

      def run
        __getobj__.deliver
      end
    end

Then you don't need #method_missing, #actual_message, or #to_sin that implementation :)
Why not use a Map instead of a Set for def all to make this behavior more obvious?
I hate to make this more complicated, but can we avoid generating extraneous builders?

```scala
override def to[Col[_]](implicit cbf: CanBuildFrom[Nothing, T, Col[T @uncheckedVariance]]): Col[T @uncheckedVariance] = {
  val b = cbf()
  if(b.isCombiner) toParCollection[T,Col[T]](() => b.asCombiner)
  else seq to cbf
}
```

Note: I'm using the "new" to method, see my latest pull request.
I was also thinking along the same lines. The only disadvantage is that things won't be centralized anymore (you won't be able to just do sources.* to refer to all the map subclasses), but that is not that big of a deal.

Did we ever agree on inst as the location for mission-specific code?
I tried that but its showing failures such as ''Pi' has no is_nonegative
@smichr I have modified the test cases and squashed them, but i have a doubt  if <code>arg.is_nonnegative </code>is placed instead of <code> arg.is_positive</code> and <code> arg.is_zero</code> then its showing errors such as http://paste2.org/p/1979595 if <code>arg.is_zero</code> is true the <code>arg.is_nonnegative</code> also should be true
We don't need pretty, do we?
I've changed this so that Trace(non-matrix) raises a TypeError
Some terminals let you explicitly let you set the font as ASCII only.  Maybe you could try that.  Also, sometimes it is like that when you ssh into a machine.
Don't create a global symbol for this. Use the `Dummy` class instead, and create the symbol locally in the `_eval_expand_func` method.
I added spaces around the operator `x>1`.
i don't think we should silently ignore such a programming error. i think it is a security problem if a programmer sets a value and CPasswordManager does not accept it and the programmer is unaware of her or his mistake.
Also for the love of the spaghetti monster let's make it dynamic.
Well they should be removed...
Такое впечатление, что всю эту проверку можно записать проще. И как минимум ````!@highest_point.nil?```` в более читаемой форме ````@highest_point.present?````
Instead of all this, you can use a Turtle (which I prefer over mock for Testify code since it ships with Testify):

check_my_args = turtle.Turtle()
assert_raises_particular_exception(..., check_my_args, arg1, arg2, kwarg=kwarg)
assert_equal(check_my_args.calls, [(arg1, arg2), {'kwarg': kwarg})

I think this is a little more standard than your approach. I guess I don't swear that it's a lot more readable.
A shorthand for "left-hand side". I' going to change occurences.
Das Problem ist folgendes:
Im RegisterController muss ich für die Registrierung zwei Services Aufrufen (CreateUser und CreateLogin).
Nun ist es so, dass diese jeweils eine eigene Transaction haben. Es kann also folgendes geschehen:
- Ich fülle das Formular aus
- CreateUser ist erfolgreich
- CreateLogin failed
- Ich gebe das Formular zurück und Angaben werden korrigiert 
- CreateUser wird jetzt Failen, da ein User mit diesem Username bereits existiert..... :/


Daher glaube ich, dass wir bereits im Kontroller Transaktionen definieren können müssen.
Wenn dieses auch noch nicht umgesetzt ist.... habe ich mir das folgender massen vorgestellt.

Wenn wir innerhalb einer Transaktion flushen zulassen, kann jeder Service seine Änderungen flushen.
(FlushAndCommit flushed also immer, commitet aber nur, wenn es eine BaseTransaction ist)

So müssen wir nur die Transaction auf den Kontroller anheben; Nicht aber Flush oder gar den ganzen EM.



Darf ich fragen, wer denn die Verbindung schlisst, wenn eine PDOException geworfen wird?
Ich hatte die Hoffnung, dass diese lokal abgefangen; gespeichert und am Schluss (nach dem rollback) erneut geworfen werden kann.
In what scenario could this fail? Surely if the font descriptor fails to create then an exception will be thrown trying to add it to the array.
Maybe you also wanna check that Project.default_for_user!(@user).project_questions.last.question is a derivation of @published_question.
This is a different test - it's overlaps instead of overlap.  The naming is borrowed from the joda Interval interface.  overlaps: Boolean; overlap: Interval.
I would give this a better var name .. 'r' is not clear as to what it does or means :)
I am not sure I am getting your point correctly, but what I did is to support these characters and any other that could come up depending on the user. That can be "*" or "|", what I mean is that you never know what people really come up with.

I can easily support only these three separators, what I did I just go beyond them and give the user the chance to be creative.:)
Does this one test case cover all the uses where we would want deep_merge to throw an error?
Tests should be deterministic. Use a set of usernames with the required chars. If a certain combination is required, there is no guarantee that it will be tested on any particular run.
Erik already wrote the code for translations and the language entry, this is why I kept it.
`.value` again as above
I think "tsearch2" is no longer used in postgresql documentation, I think I haven't come across it yet. We should use whatever wording postgres uses - please check current postgres documentation. My guess is it would be something generic like "full-text search".
Why private, this should be protected so tests can use it too if they need to?
Would be better as `$join_topic = $type !== 'posts';`
Add an abstract base class containing all the tests that all implementation are supposed to pass.
Event still should be cleared, who clears it?
I don't understand why there is a separate `all` export?
typo. and let's use fmt()
No need to check for `Infinity` explicitely. `Infinity - 1` remains infinite.
Please list the properties as supported, with a hard-coded value.

```ruby
# The server is contacted only in case of a registered domain.
property_supported :available? do
  false
end

property_supported :registered? do
  !available?
end
```
Done dominictarr/monotonic-timestamp#1
Good point. Fixed and new pull request sent. ;)
the should be a var TIMEOUTLIMIT at the top so we can easily change it
Thanks for the article Nathan!
Make a note here of why this is not working.
"disabled", "as the bug was not"
Az admin oldalra nem kell feltétlenül a statisztika, de ha már itt van, akkor a sorok közé is be kellene tenni.
I find this method weird. I don't think the connection should be responsible to create the ShardManager (especially as the connection is inside the shard manager). Btw, for the SQLAzure implementation, you create the shard manager directly by passing it a connection instead of using a getter on the connection (which does not exist)
the use statement is missing
The field "task_ordinal" in the table ses_rupture is not used in the code.
Could you document what do this field represent and how will it be used?

Also, see the comment below regarding the choice of a better name (instead of "task_ordinal") for this field.
Yeah, this must be surely refactored, lol.
Same as `forcetrigger`
the stdint.h check is a special case, because we don't really have to die if it's not found (logic for this is in webvtt/util.h) -- But, changing the other stuff
I'll call it personal preference since I lack external justification, but I feel like this should just be a couple lines of comments prepended with # instead of using the multiline syntax
I suspect it would. @dmethvin and @jaubourg - I'm not particularly a fan of a four condition OR, but dropping it in ajaxSetup doesn't exactly let us escape from something like that... how do you guys feel about @curiousdannii's solution?
So, just to clarify, we really don't want to do this. We really just want to add a flag to TestCase that nixes index/unindex live indexing.
I think this is actually wrong. There's a bug for this, but all static assets should come from STATIC_URL--not MEDIA_URL.
I would like to see parentheses, so that I can tell whether you mean
    if (not tld.tld) or tld.subdomain
or
    if not (tld.tld or tld.subdomain)

(You're getting the first one, as the code currently stands.)
Maybe put `minitest/autorun` above all the other requires in that paragraph?
Need to at least pass `--prefix=#{prefix}` (or equivalent) to configure, or we won't have any control over where it is installed.
Use full paths in tests: `system "#{bin}/pngquant", "--help"`
I'm not familiar with this build macro. What build does it refer to? The collectd build or the clang build?
rest_client should be on commands/base.rb, not in helpers.  Moved to command_spec.rb
Don't rescue generic exceptions here - that's the responsibility of run! (after all other exception types are handled).  Same for rescuing argumenterror. Basically, all exception handlers that commands can share should be handled in one place (run!).
It can't, because it needs access to `self`.
No need for a comment as it'll be fixed independent of a PRAW source code update. Hopefully before I merge in these changed.
That's more than 50 chars too long to fit on a summary line. You have 76 total. I quite like the original line. Because it states the point of the function. Get our requests within guidelines. It doesn't explain the how, that is the job of the description a bit further down. Thinking of refactoring to

    Ensure frequency of API calls doesn't exceed guidelines.

    We are allowed to make a API request every api_request_delay seconds as specified in praw.ini, this value may differ from reddit to reddit. For reddit.com it is 2. Any function decorated with this will be forced to delay api_request_delay seconds from the calling of the last function decorated with this before executing.
Can't do i18n this way, you need to call _ on the string itself, not the variable. I see that it's that way in the code before you added this, but might as well fix it while you're in here.
That was the original functionality, this method doesn't rely on it, so it could be changed. This started as the method moved out of `verify_required_parts!`. Method still works if you change it to Array#each or really any iterator method that goes through all the values.
$path darf keine newlines enthalten -> spam gefahr durch eingeschmuggelte http header
My thoughts are that if the user knows that uglify is used under the hood, it would be frustrating not to be able to have full control over its options (given any control). Perhaps a better solution would be to give the option to provide a custom compress function, and by default offer just uglify with the standard options, rather like the stylus middleware does.
It's a bit weird to keep two different sets around that both do the same thing: `injectedClasses` and `delayedInjectedClasses`. Could you change this so that you only use `delayedInjectedClasses`? You'd be able to remove this loop....
The method is easier to read if you extract two methods: createTestUsingConstructorInjection and createTestUsingFieldInjection.
maybe put the duping in RenderCache if that's why it's necessary
I x'd this out because I couldn't figure out why the error callback never fires when the request fails. I suppose you didn't have any luck either? Not sure whether we should be concerned about this or not.
typo - missing a 't'
In general, there do not seem to any parameter or return descriptions.

In this case, there was one but it was removed. I'm curious as to why the parameter description was removed?
Done. I added 10px between label and input, and I figured out how to center a box with dynamic width! (The width is "dynamic" because it's based on the content which is language-dependent text)
It seemed odd to me to space items out using padding instead of margin. In the case of the spinner, it would actually mess up the rotation (since the padding is part of the box, so the spinner would rotate around the center of the box instead of its own center).
Archivo?
I think that would read a little funny / ambiguously combined with the assignment at the beginning, so I'd rather leave it as-is in this case if you're ok with that.
this will only work for version 2 cases and higher, and also makes an assumption about the structure of the form and where the case blocks are. does it really belong here?
The relative path should not be needed if the includes are defined properly. This should be removed!
On it - good ideaz.
I think the way to fix this test is to create a `self.tearDown` method that removes the objects, since `self.seed_reads` is creating them at the beginning of most tests. We could call `self.tearDown` at the end of each testcase.
As above, I'd consider changing this to “Adds the given cmd to the JavaScript that will be executed when the document is ready”
OK I will put it back, I am sory.
`XHR` isn't needed here anymore.
We should get something else in here, this won't be topical in 6 months.
Can you explode this line? It should probably be a few lines instead.
I just noticed this: shouldn't it be `test-css.css`?
Too much space between these.
These if blocks can be replaced by something like:

`newStart = Math.min( Math.max( 0, newStart ), duration );`

the same goes for `newEnd`
The OCD in me wonders why there's a random blank line. But it's by no means a blocker to this getting pushed through!
There is a site, not sure who started it but, it seems not to be kept up to date as it marks some valid properties as invalid such as appcache_path :: http://appmanifest.org/. Will make the other changes as suggested.
REQUEST_URI gibts nicht zwingend.. nein.
Ah, using opendns.com explains things - adding a note is probably easiest, will also see if there's a way round this
the character 'c' of 'cf->cycle->conf_ctx' and character 'n' of ngx_dso_module should be aligned.
Deze mogen er nog uit lijkt me?
tässä voisi olla user.isCreatorOf(event) tjsp
Right.  Say you schedule an errata install on a group of 5 systems.   A job is created with 5 tasks (one for each system).  So the history command will list the jobs, and then the history_tasks commands lists each task and the status of them. 

I guess I could have named the commands 'jobs' and 'job_tasks'   but that seems a tad more confusing to me.
Should I show non-readable keys without link or hide them totally?
made a small change that hopefully makes the code more understandable.
s/special/Special
Triple check :wink:
So do we reserve "const" for things that we don't want to change in code (same as readonly static) or things that truly can never change, ever, like pi, or Newton's gravitational constant? Earlier reviews have gone with the latter, which is why I ask.
Reformat the line so it's not so long.

For the  Dispose() execute it synchronously
nit: add a space between : and "
Even more nitpicky (so feel free to ignore it)... but doesn't this sound more like it should be a `TypeError`?
Also - no "-" and a blank line between each entry.  This isn't to be overly pedantic, but numpydoc chokes on this.
@iguananaut - do you have a preference?
Is this comment associated with the next function: `construct`. If so, there is nothing named `Required` anywhere.
Should be `lists.where(name: "Bookmarks")`. Otherwise you will get all lists, not just the ones for this video.
Does the name of the file matter here? It'll just be overwritten with a correct link right now. I don't think there a pressing need to add rename+delete logic.
You're right. That does look better. I didn't know tr() accepts multiple arguments like that.
As far as I can see `CFilter.name` is currently unused.
It should be enough to have the name as index of `CBloomers.map` for now.
I don't want to use 0 at all, the argument adds unneeded complexity. IMO I think it's best to remove the argument nUnit completely, and always use the unit from the optionsmodel (as it was before).
... but we don't want Runek to end up reinventing gitian-downloader, and I hate making 'perfect the enemy of the good'.

So I vote this gets pulled as-is, because it is much better than the nothing we have now.
Why do we need to define this flag ourselves?
Why not always return the value for inputDefaults instead? that way we would have a single return value type for this method
no inline docs - use the funcion doc block
the style guide stuff (http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Conditionals#Conditionals) is also true for if/else statements. Were all these curly brace changes intentional or did your text editor do it?
This one is right - means they're closely connected (http://en.wiktionary.org/wiki/conjunction)
For this function and the next, let's add at least proper docstrings (i.e. with full Parameters and Returns descriptions), as they are likely to be useful for others in general.
This was unceremoniously added in 745e9cb8 without much explanation.

I don't think that we need this to be a no-op, as the completer framework should be in place regardless of whether or not it gets used.
since name is image_from_server, the args should be imagename, followed by serverid.  you mind switching these?

( i understand that we haven't combed through all methods to make this consistent, yet, but definitely need to before going beta )
I see; this method is ugly.  I opened a pull request for changing the entire method as you suggest:

https://github.com/jclouds/jclouds/pull/630

Don't be shy about submitting cleanup patches before the patch with your desired functionality!
removed jsv for now
I thought that the VALUE= must be specified rather then just using whatever type you felt like in RDATE but google does not agree in all cases.
This would be a prime candidate for inlining. Can you do that? It's a simple bitwise operation on a field that is already public.
No, 在这里处理不是很好, 因为会平白的浪费一个循环的时间, 而且我
下面在赋值的时候已经把旧的值 free了, 
        if (b) {
            s_free(b->status);
            b->status = s_strdup(status);
            if (client_type) {
                s_free(b->client_type);
                b->client_type = s_strdup(client_type);
            }
        }

而且, 这个函数一般只是开始的时候调用一下, 之后 buddy 上线/掉线的时候, 
server 会发消息过来的, 这时候会自动保存online status
@jordanbyron: It's not quite so easy to merge these two `get`'s as one might suspect. The problem is the eager matching of the underlying regex. I've come up with three solutions.

1. Leave it as two methods.
2. Use a custom regex. This is what I've come up with to match the basic transactions rendering in one method ` %r|/(.*)/([0-9+\-:T]*)\.\.([0-9+\-:T]*)(\..*){0,1}|`, something more perverse will have to be used to match descriptions.
3. Continue to use `"/:channel/:from..:to"` and use some special logic to rip the extension out of `:to` if it's present.

I'm not really sure which I like better. Option 1 is the clearest to read, but breaks DRY. Option 2 gets us to one method, but introduces a nasty regex. Option 3 looks nice, but has to have some nasty custom logic due to eager matching. Thoughts; is there an option 4 I've missed?
you can replace these three lines with `helpful_ids = [row[0] for row in cursor.fetchall()]`
Docstring wrong?
The `%s` does the same thing as `str()` except it's better at handling potential Unicode.
corrected mainly by quoting you
On Fri, Dec 21, 2012 at 04:30:31PM -0800, Rob Hudson wrote:
>`l` and `1` so near each other might be unfortunate for those with a bad font. :)

Heh. True.

-- 
Kris Maglione

[T]he people can always be brought to the bidding of the leaders.
That is easy.  All you have to do is tell them they are being attacked
and denounce the pacifists for lack of patriotism and exposing the
country to danger.  It works the same way in any country.
	--Herman Göring
LinkedHashSet
Do you think it's good to call it every time you need something to store/remove ? i.e.:

```php
$session->set('foo', 'bar');
$session->set('bar', 'foo');
$session->remove('bar');
$session->remove('foo');
```

It would be 4 calls to db, or I'm missing something ? =)
@stof also said something regarding this that was wasted thanks to Github removing old comments

community is speaking through comments remember :)
it's in case of `null` or `empty string`, `false` value
Maybe use `-name`/`-regex`/`-path` (or the i-prefixed variants)
You must still iterate, you would not be able to reset the hostname pattern for children with this method. Also `$this->hostnamePattern != $route->hostnamePattern`. And you should also cast to string above now that you made `''` the default: $this->hostnamePattern = (string) $pattern;
I think you should still keep it in dev, even if they should be catched now. It does not hurt and will avoid hiding the errors if the error handler has a bug
This doesn't look like it is tail recursive and it seems like it might be a problem if for some reason it recurses too deep.
NOOOO? What does it mean?
Lots of changes that I don't get.
Ah, it checks for persisted votes. Never mind.
Is the leading `*` intentional?
I'd like to see this if block extracted to a method named something like `garbage_collect_once_per_second_for_faster_tests`, then delete this and all the comments in this file.
This comment is obsolete now, since we changed the spec so that R will be black & white.  You should also state what happens when R has a different width than the histogram - I prefer to just resize R to the right width if possible (use ImageBuf::reres() - keep in mind that this can fail, so you'd better check that; see the docs for reres().)
Also, it looks like you didn't modify the case where there is momentum.
I think this can be reworked not to use the try/except fomat. Just have an if statement that checks if it's a SparseVariable at the start.
"Защита от робатов". Учи албанский!
sorry but changes on locales after string freeze need a late-l10n tag on bugzilla, and the approval of a l10n driver (@stasms maybe?)
`getDefaultAlarm`
Thank *you* for your work. I’m a bit stressed by the l10n string freeze these days (due on Friday!), but that should get better in the next few days. ;-)
camelCase please. Also, please add this comment

   // Set to the initializing state to block user interaction until the operation completes.
   // (unless we are being called for the first time, where Bluetooth is already initialized)
No :) It's a JWT parameter.
I mean the line break! :)
I don't want to remove the whole animations because there is a JS that listen for it, and i don't want to make that deep changes in JS, i will feel safer if @albertopq  make that fixes once this is being merged
If you put it here in `init` it would only run once ... I don't think you want that.
you miss .properties files
lol I really should have caught those ifs :)
Is it not better to use the exactly same Python interpreter again than to rely on the system to perform the direct launch?
Note that on Windows, System.IO supports both slashes. But my concern is more where do the paths come from. Does one of them come from the .deployment file? If so, someone might trying using forward /.
Minnor identation error.
Yeah, I also think that % full is a silly metric. Spots filled / total spots is much more informative.
This translation is in English. Why?
Should a date format include the time as well?
Ummm. You're not as cool as Disco Stu. Fix please.
Would this loom right?

```scala
def isEqualIffZero[T : Metric : Arbitrary] = forAll { (a: T, b: T) =>
  beCloseTo(Metric(a, b), 0.0) || a != b
}
```
You are absolutely right, but we have unit tests and they will fail if that happens.

There is really now way around this. If you call .getClass on (1,1) you will find that it is Tuple2$mcII$sp.  It's just some internal name mangling that the scala compiler does.

I learned this from the repl and random underdocumented sources. I don't know a good reference for it.
Please add our standard code header.

Example: https://github.com/Freeseer/freeseer/blob/experimental/src/freeseer-config
The issue is that the functions are called from two separate places, one is static call and another by using object. We could call it statically from both places?
Only one of the following three settings can be active at any time. If $user is KunenaUser object, we could use $user->getName() instead of having 3 it's in here.

But even if it isn't, should we use elseif?
Ah yes, I see now. You are correct.

if @Olloth, @Afforess, @Raphfrk agree with my liking of this PR (good code), it will be pulled.
I guess one could make the argument that this is the name that the cli uses. But that doesn't mesh with having `-` in the names in some cases.
I'm not sure the rationale here?   We don't want to serve the UI at a path of '/', but at '/ui/' instead.

I bet the reason behind this change is that the redirects won't work if you don't have the base URL set up correctly, so likely the redirect from / to /ui was broken for you?  At any rate, I think this part should be reverted, too.
well i was thinking more like that :  
```
$lowercasedPackages = array_map('strtolower', $packages);
```
then 
```
foreach ($lowercasedPackages as $key => $package) {
    if (!in_array($package, $knownPackages)) {
        throw new UnknownPackageException('Package ' . $packages[$key] . ' not known');
    }	
}
```
it might look like a micro-optimization but i always see in callgraph that strtolower is often too much called
you can remove the extra braces around the instanceof check
I suggest you name it MVELConstraintBuilder... using "DefaultXXX" named classes makes things inconsistent in the future when a new  "default" implementation is created. See what happened with serialization and protobuf stuff.
Especially on multicore, I doubt we ever want this.
Why isn't this being compressed?
I will remove it also; we can add it later if we need it
I added ruby_timestamp function to events class to address comment from Jordan.  I believe your change above is a clean way to incorporate Date Obj support.  I will change the pull request if all are on board.
It might be usefull to add some links about this.
Like platform code that highlight these interfaces:
http://mxr.mozilla.org/mozilla-central/source/content/base/src/nsCopySupport.cpp?rev=7857c5bff017#530
Please add "use strict"
I'd rather prefer module.module = { uri: uri, exports: {} }
"In servers where authentication is required, this commonly means that the provided credentials were successfully authenticated but that the credentials still do not grant the client permission to access the resource (e.g. a recognized user attempting to access restricted content)."
no, this block will execute when the caller of the API has provided a password AND when in the database the user has no password set (which is the norm for accounts with only primary addresses).
It seems like odd UI to me to have a `run_metrics` command that takes a `--run-metrics` option, without which it does nothing. (In general it seems a little odd to have a command that does nothing by default unless given additional options). Why not simply remove the `--run-metrics` option and make that the default behavior of the management command? It's not people are going to run the `run_metrics` command by accident, so you need to make them type an additional option just to make sure they really meant it ;-)
Change to single quotes:
<code>self.selenium.get(self.testsetup.base_url + '/media')</code>
Wouldn't this fail if `thing` is the last thing in `things`?

Either `<= 1` or `< 0` would fix it.
How do we know the current working directory is inside of a Git clone of the puppet sourcecode when this code is evaluated?  This code will be evaluated when doing a simple `require 'puppet/version'`.

This file was originally intended to provide a very simply way for anyone to get the actual Puppet version with:

```
require 'puppet/version'
version = Puppet.version
```

As far as I can tell, this intended behavior will no longer work if this patch is applied.  Has this intent been taken into account?
No, "greater than 10.7" was an attempt to prevent death-by-lawyer before the NDA on 10.8 was lifted.  It should now be "greater than or equal to 10.8"
I'm planning to release 2.11 this weekend, but I don't want to include this as/is. @danrasband - will you have time to look at this before then?
Comparisons with True should always use `is` rather than `==`
The same command as above :)?
Use "static", not "self".
I see what you mean now, this is very strange. Let me try to fix that
I don't see any reason for fix the return value to -1, 0, 1 when the description of the method talk about 0, positive and negative
remove the spaces on the brackets
I need to map ids to actual labels before instance initialization with params.
I also have to remove them from params. This is what the local variable is for.
Generally I'd rather wait to create an abstraction and base until it's needed for multiple implementations, but maybe we have more coming down soon. Either way, I don't feel strongly about it.
undefineds are kind of a special case. I want to be sure it's really undefined.
You should be able to use `if (!$this->zfcUserAuthentication()->hasIdentity()) {`
I will send a new pull request