labofsahil/github-event-dataset-2012 huggingface dataset:
What is `Action` here? Should be just an empty list, right? Seems unnecessary to pass it along in the resource state.
@samiluukkonen Mihin tätä keissiä tarvitaaan? Eiks defaulttihaara oo ok?
because it cannot convert criteria into sql yet.
Yes.  View entities are still entities because that is the only way Doctrine is trained to interface with any table.  Otherwise, you'd be forced to use raw SQL for everything, ignoring any additional functionality Doctrine has to offer.

A view is a table in all cases except one: it cannot be written to.  Therefore, it should be treated as an entity.
Inline the type conversion (do not use 2 lines)
i think this needs an `|| self::HYDRATE_PHPCR_NODE` if you want both options (is this the same in the ORM? otherwise lets just have one of the 2 constants)
I did not test it, but the first attack that comes to my mind would be on windows servers, by using '\..\' in the path.

Will do more research on the security of using pure str_replace to avoid directory traversal attacks.

Last nitpick: A directory called "hello.." is unexpected, but it would be filtered out by your code, while it is in theory acceptable.
I think you could also say that it requires ``htmlmin``.
Move 1 line up
Why is there no space at the beginning of the string? You're doing a +=, so it may happen that the string did not end in a space.
I'm not sure if it's a good idea to inherit from GraphiteWriter as semantically you're not doing a specialization of Graphite. I'd prefer pulling out a common base class or using delegation.
Yeap its using lat and lng, not location
s/contributor/contributors
Should we be using a locator variable in the script, rather than hardcoding ```window.highlighting.editor```?
Description needs to be clearer
This line is called by `on_quit` already, so calling `stop` again is likely going to error out.  Also, this class doesn't call `on_start`'s base method.  Luke was saying that some of these are intentionally not calling their baseclass, this might be one of them.
I believe we have this one coded somewhere already, I use it in Lang.
looks good, for better readability, I would consider moving the setting names into a constant or class method?
Err...I wouldn't agree with that.  I think the right intention is being followed here mainly because the mozapps API does give clarity of what's actually in the app registry, which is a reliable source across multiple platforms that the homescreen relies on and is part of the validation of this smoke test. I believe this check is doing that right now, as it validates that the value in the app registry matches the expectation. 

A lot of validation actually can really reuse the app object to the majority of the validation. I do think we should still check the homescreen UI directly though, as you've stated.
copy and paste :P
These two are needed for the .fma and .fm commands. Without them, they won't work.
Delete commented html
There is an element called `<passForm>`?
IMO, this is wrong. The value should be passed to the platform without any updates.
typeof is larger here, because typeof isn't used anywhere else.
Added a validator
The keys need single quotes around them
module.exports.addRole = function(principal, subjectPrincipal, roleId, callback) ?
if (parameters.length)
We might just want to trigger the re-index in _setGroupMembers ?
At some point I needed this, not anymore though. I've removed it.
``assert(Thread.currentThread.isInstanceOf[PresentationCompilerThread])``
Any particular reason you removed the $_GET here?

To be honest, I do not remember why I had put it in there in the first place, but I think it had to do with being able to tell if you were coming from a page where a vote was previously placed.
I think "Finished GET" should be "Finished PUT" in the logger.debug. 

Also, variable 'versioned' is being printed out for 'value: '. Is this correct? I think at other layers either the value or the size of the value was printed out. For other tracing at this level, at least the size of the value put would be valuable.
Yes, good catch. Thanks.
одна и та же строка пересоздаётся в цикле. она в принципе должна быть глобальной как минимум на уровне класса Cell
init исправил
```-setNeedsLayout``` makes ```-layoutSubviews``` be called, and in there I call ```-setNeedsDisplay```, so could you remove the ```-setNeedsDisplay``` from here to keep this cleaner? :)
It just seems like a really easy attack surface for things like DoS attacks. It's probably just paranoia on my part, given that you have to be authed into a locker before you can hit the endpoint, but it would be really easy to flood Airbrake with notifications if you were so inclined.
This will always evaluate to true.
"best" is a reserved meta quality, please don't overwrite it. Call it "live" instead.
Okay I will do the tests tomorrow for all the callbacks in another PR because it's quite large. I won't bump the version until we have the tests in place.
This will always open a link in a new tab, right?  I think I preferred
the original behaviour where it would open in the same tab you
already have open.  Also, if we decide that this new behaviour is
right, it'd be better to put `target="_blank"` in the content we
render on the server side so that it works in Chrome too.
The type of the `key` argument could just be changed to `RACSubscriptingAssignmentTrampoline` here, which would remove the need for the two casts below.
It's JavaScript.
This is one of the most awesome lines EVAR.
yes please if you can. Don't forget to deprecate the previous
time_to_index and remove its usage everywhere.
If I'm thinking correctly, with the above maximum() call, we should be able to remove the one below, which should eliminate any performance degradation.
I don't get this message:

what's "n"? 

... "when" a complex value is passed ....?
same here console.error(error)
Hmm, i think if you already have a unit test for the code, most likely the assertion in it will act as as your 'debugging break point' in that case
@josevalim Do you think it deserves an update note ?
You're right, I'll fix this as soon as possibile.
this will help you to do $app->add ... :-1:  . Just noticed , whether this will fail.
Furthermore, your current code is fragile because you don't use Scala keyword parameters. It's now possible to change the order of the fields in the case class definition without noticing that we put wrong data in the wrong fields if the types happen to match. Once you fix that, you end up with:

```scala
  private def stockDirectory(buf: ByteBuffer) = {
    StockDirectory(
      nanoSeconds              = nanoSeconds(buf),
      stock                    = stock(buf),
      marketCategory           = marketCategory(buf),
      financialStatusIndicator = financialStatusIndicator(buf),
      roundLotSize             = roundLotSize(buf),
      roundLotsOnly            = roundLotsOnly(buf)
    )
  }
 ```

which is just pointless and ugly obfuscation.
outline: none doesn't provide a clear focus indication for the navigation controls.
Famous last words. :-)
Drop this and use Akka Serialization
This is pretty standard, linux for instance, it makes the comment stand out, makes its extent clear, and can be useful when running scripts on the source. Your editor should take care of it so it isn't any extra work. I'd much rather keep it.
I think this section should be demoted to a subsection of the Calculus section, because I can see that the subsection about series expansion is already there.  Perhaps, this bit of documention should go right after the description of series expansion (which starts at line 382).

The developers have the ultimate word, of course.
Right. Fixing it.
Пробелы перед открывающими скобками же (везде).
Пробел после `<<`
Ок, исправлю
Simple delegation to the `VimInstance`.
Look into using [OCLC's OpenURL libraries](http://www.oclc.org/research/activities/openurl.html)
Any reason this test is commented out?
For id's you don't even need to specify the tagname.  ID's are supposed to be unique, so anything with that id is going to be the right element.

```
   :system-add-content	         	     "add_content"
   :system-remove-content                  "remove_content" 
   :system-package-name                    "content_input"
   :select-package-group                   "perform_action_package_groups"
   :select-system-package                  "perform_action_packages"
```
this token should be then validated when the form is submitted
Is the newline also not present in other translations?
I'm a little bit worried about this change -- if I'm reading this correctly, this means that no `mongod` will have journaling enabled on any node that also happens to have an arbiter. That could prove catastrophic if that node were also a large replica set member.

@lackac can you comment if that was your intention, or if I've missed something about this?
Fixed Version Issue for tapestry5-jquery plugin.
this change comes from a old edit by me and a little "unclean" revert
should we onlly load traceback if we are in fakemode?
We should probably just keep that as BadRequest
Is the `(Object[])` cast really needed here?

These two for loops are pretty much identical in all methods except for the annotation checked, can we remove code duplication? :)
so the following example is not going to be acceptable?

    { name : "Sanne", surname : "Grinovero" } 

As with this kind of recursion you are requiring `{` again.
I guess since 5.2?
We can't depend on this being UTF-8, but I'm also not sure what other options we have here. :\
Can you please style this as `err.code` instead?
This should use `YES` and `NO`, and the blocks should be split over lines for readability:

```objc
repo = [GTRepository cloneFromURL:originURL toWorkdingDirectory:workdirURL barely:NO withCheckout:YES transferProgressBlock:^(const git_transfer_progress *prog) {
        transferProgressCalled = YES;
    } checkoutProgressBlock:^(NSString *path, int curObj, int totalObjs) {
        checkoutProgressCalled = YES;
    } error:&err];
```

This also highlights the issue with `error` that I noted on the interface.
All right, `B` should be removed for now.
This is a little too far to the left in my opinion.
OK, will do.  Just a nitpick though...this is not a "pass it along" situation, it's a "merge with existing results" situation...which could open the door to different, and harder to find, problems down the road.
can you check if these imports are used?
This isn't after swipe, but after swipe and clicking unlock. After swiping the lockscreen is still visible.
I think the JSON parsing should be performed on the application level, so I'd just store the string in `obj.appinfo`.
I would suggest

```php
'Any' => 'Any'
```

To me, `All` implies more than one item, where `Any` is a wildcard
hmm, since we have the fti already it'd be nice if we could just pass it to the schema cache rather than making it look up the IDexterityFTI too.
Apagar comentário.
@bp323 The root of the issue is that when we get the world/course template [1], the rows is an array of strings:

```javascript
"rows":["{\"id\":\"${refid}4\",\"columns\":[{\"width\":1,\"elements\":[{\"id\":\"${refid}1\",\"type\":\"mylibrary\"}]}]}"]
```

We can probably fix this after [KERN-2728](https://jira.sakaiproject.org/browse/KERN-2728) - ability to have an array of objects - has been fixed.

[1] http://localhost:8080/var/templates/worlds/course.7.json
@bp323 Just like with `getTemplate`, can we make sure the fist argument of a callback is a `boolean` whether is was successful or not?
Now it will just silently fail.

Maybe it would be good to have a `debug.error(` statement in both functions when it fails?
(just like `getGroupData`)
Thanks! 

Slight error though, it now says "Cancel" instead of "Uploaded".
this  function body have still wrong indentation
This flush could be outside the loop for better performance. Probably doesn't matter much though.
The comment seems fine.  I *think* we only need to force the last checkpoint -- if compact dirties and pages, the tree will be dirty for checkpoint 2.

My real question here is if we should check whether the compact will be skipped up at this level before taking the checkpoints.  Do you expect applications to rely on the compact call to be cheap if no work can be done?
reuse copyEntries()
Note that this line is not removed. It is present on line 759 post-revision.
This one seems to be still incorrect
With the addition of devise, this gem will be irrelevant.
The exact same as the non-streaming scenario. The error should only ever take up the first argument, in this case the only error info provided to us is status code indicating an error (the only likely case this would happen is if you're running a different server at the place you said neo4j was running)
Hmm... The type of problems that trouble me the most.
"The value of a ListProperty cannot be None. It can, however, be an empty list. When None is specified for the default argument (or when the default argument is not specified), the default value of the property is the empty list."

Nevertheless, I can drop 'required'
The name is weird for a method cloning the environment
Either way, we should make it clear what browsers are supported, for people downloading it.
Nitpick: Useless new line. Can you remove it? Thanks.
the param too btw
good ;) but also missing the `@return` phpdoc ;)
Why not use a normal `Runnable` and pass everything else (tries, pauseTime, etc) as arguments?
timeline_class must be defined for the ORM provider. This validation should exist somewhere in Configuration or in HighcoTimelineExtension
No need for `DEFAULT_FROM_EMAIL` part there, this argument is not needed when using `mail_managers`.
models: i have same as you provided me + i tried with abstract=True and  'allow_inheritance': True

save: models.State.objects.create(temperature=17)

query:
weather_data = models.State.objects
for u in weather_data:
    print u.temperature
    
i get : < class 'mongoengine.fields.DecimalField' >

with MongoExplorer looks like nothing is really saved but only object instance  http://shrani.si/f/1F/Zp/1f53xSoX/capture.png
And this should be "if (list == null) {".
sympy related come first, and then other libraries
I'm not sure what you mean. When you call `join('return', '!0')`, it will produce `return !0` (notice the space) instead of the more space-optimal `return!0`.
That is PayGateXML's global sandbox account credentials.  It's given in their API doc.
They are also in the PayGateXmlGateway class file around lines 81-83.
I don't think this method should raise. All other integration Notifications just return 'Error' for something unexpected.
unneeded check, instancescript cannot exist without instancemap
lkb
Avoid qualifying `HttpStatusCode`.
Remove qualifying namespace for all of these guys
Den brauchts echt nicht....
Die verfügbaren Resourcen sollten wir wohl an einem zentralen Ort pflegen.
It might be nice to add something like, If you have any questions, feel free to reach out to us on GitHub or IRC.
This is a class not an hidden method (think about strategy dp).
going with this:

```ruby
  unless custom_data.values.all? { |value| value.kind_of?(Proc) || value.kind_of?(Symbol) }
    raise ArgumentError, "all custom_data attributes should be either a Proc or a symbol"
  end
```
Maybe could you refactor that to something simpler to read?
Space around "-".
Did you mean to have transform without -o- here?

BTW. I don't recall us dropping prefixes for transitions/transforms. If we want to prepared for the future, we probably should add all possible combinations because we don't know what will loose prefix first.
Ditto.

Unless you think it's worth creating `ngx_http_pagespeed_conf_get_srv_config(cf, ngx_pagespeed)`?
Let's make `oauth-get` private as well.
Label is translatable string.
Add space after `,` in function arguments.
that's supposed to be Butter with 6 ='s under it
Again, merge this sentence with one above?
There are currently a lot of doxy comments for private and protected functions/members.  This question probably deserves a separate issue so people can comment on whether we want them or not.  (I usually only write doxygen stuff for the public interface, but I see some text in doxygen_readme.txt recommending doxygen stuff for private functions too.)  So for now I just left this in as a doxygen comment.  (Although I did humor you and make it a single line.)
Again, this looks like a class variable.
Sure.  I'll add that.
Now I had wondered about that... But thanks for flagging this as some investigation just now showed me that some of the assumptions I'd made were false.

I had reasoned to myself (based on a misunderstanding of the workings of `allclose` and indeed the integrator thresholds as they were used that point) that it was still interesting that the relative error had been reached even though the absolute threshold was almost immediately met.  But this was wrong: it hadn't been.  In fact, it wrongly seemed to me that this was more of a stress test than most of the others.  Thanks for flagging!

I'll move to -15,-14 as you suggest, 7.8e-9 is a good number.
Feels like this should go in OfferExtensions in SWF/Eastwood.  Anyone have a strong opinion either way?
It absolutely can, I just figured it might be useful to others so I put it in here.

It is currently passed to the Distinct (LISQ) method in order to get the set of available variant values.
oops.  nevermind the comment right before this.
This has been changed to Function in master already. Which makes me slightly concerned about the merge, given I haven't rebased this branch against the very latest master.
Note to Scott: This should be added to all groups.
We need to settle on the right SHA toString algorithm. I'm happy to take whatever the test uses if there is proof that the test is correct and the algorithm in the impl is wrong. Currently this could be vice versa (i.e. getSHA256(contentBytes)) could be wrong, no?
@psawaya says, "in general, i try to wrap everything in an outside object when passed so that added metadata later is not a pain."
indent is weird :)
Out of curiosity, you set the model as read-only, but implement dropMimeData---is that so only allow in-view reorders?
This was dead code that wasn't used anymore.
Um... whaaat?
"in holster" should be "in the holster" or better yet "in the [src]"
Well, whatever, i'll pull your code, make some adjustmentes here and push it giving the credits to you, peraphs i'll be able to finish it today or tomorrow.
Can you make `mocha` and `should` dev- or test-only dependencies? We don't want them to bloat the Heroku slug. You can do that with something like:
``` javascript
{
  "dependencies": {
    "connect" : "2.x",
    "express": ">= 0.0.1",
    "canvas": "git://github.com/bensheldon/node-canvas-heroku.git"
  },
  "devDependencies": {
    "canvas": "git://github.com/LearnBoost/node-canvas.git"
  }
}
```
В этом случае надо закрывать сокет.
плохо, когда метод скрывает установку instance var, а дургой метод эту переменную использует.
`find_person` видимо должен что то возвращать
i'd suggest this isn't realy useful, and will be a bit spammy in "real world" use.. maybe remove it
thank. タイポ修正します。後者は/にして見なおしてみます。
@eshamow  This approach seems problematic for the general case b/c classes usually inherit from the params namespace so that class param defaults can use the variables from the params namespace. How will this pattern work for that case?
change to
if (bottom_ != NULL)
Only the Cache Schema has a reference to the Download Location.  This sounded like a better option if you wanted to have multiple locations to store files, you could just use different cache schemas rather then switching back and forth the attributes of the FileManager.
Mettre en Warning : 

```
.. warning::
  Attention, cette méthode ne doit être utilisée que lorsqu'il y a un degré élevé de confiance
entre le propriétaire de la ressource et le client.

.. seealso:: Voir aussi `http://tools.ietf.org/html/draft-ietf-oauth-v2-10#section-4.1.2 <http://tools.ietf.org/html/draft-ietf-oauth-v2-10#section-4.1.2/>`_.
```
> do we really need this init() method

I am also a little towards it. I am wondering whether this was a specific fix for something.
The difference is that the original code walked the transform, this code walks the record resolving things in the transform.

The process things in the same order for TABLE() (since one is derived from the other), but not necessarily for AGGRETATE().
rogue size32_t cast
You may as well mangle both regardless, even if only TDXjobtemp's are published.
You'll be able to make the code simpler that way.
i.e. just always strip off ~ upfront if present and then append rest..
Hmm... Why isn't the middleware already returning them in order if the order matters???

Also, you have excess whitespace around the `key = lambda`

By the way, if you are going to re-use the same variable, it's much more memory efficient to do an in-memory sort. Like this:

```python
middleware_results = api.get(product)
middleware_results.sort(key=lambda i: (i['date'], i['version']))
```
Do whatever html5boilerplate does. Thats my ultimate yardstick.
I don't think this is right, it should also make sure that the directory is cleared before running the first test in case some old files remain from a previous failed run or something.
它不是在递归回溯的时候构建返回值，而是在递归调用的过程中积累返回值。

加个逗号中断一下，更好读一些。
wait it's not going to work. sorry I screwed the order in config...router in connect middleware/express always belongs at the end of that config block, or as close to the end as possible because router has to come after we execute the reference to static assets we want to serve from public.
Format is not consistent
I still think this one should be a for.. if not we have to look carefully to make sure you actually got all numbers.
Also copying the logic from run.sh, might be handy to make sure there's no server running first: 
echo "`date`: Stopping CalCentral..." | $LOGIT
mvn -B -e jetty:stop | $LOGIT
@christianv Ah, forgot to add the image in the commit. Updated now.
Maybe initialize the variable with default build notes first, like this:

    String notes = vars.expand(buildNotes);

Then the logic below can be simplified a bit.
good point - fixing that
Maybe there were a little of confusion and I'm the reason, quoting myself:

<pre>
Would be nice to keep a max line length "constant" int he description. No more than 100 columns please.
</pre>

"in the description" was just in the description field awright :S. Sorry because it was misunderstood I think
```when``` should be indented at the same level as ```case```
From what I understand, going back through Grady's paper and some earlier work on anisotropic diffusion which uses a very similar framework, we may need to retain some form of standard deviation.  This form of the weights is a Gaussian form, and it may behave differently without having the equivalent of sigma in the exponential's denominator.  Just because the range is [0, 1] doesn't mean differences in the distribution are accounted for that show up in the moments about the mean like variance or `std()`.

At least, I think that's the case...
This has been implemented long ago. You comment on one of the old commits here.
Same here, the final | 0 on the end should be unnecessary.
Yeah, this was an attempt to deal with the fact that drawing circles on canvas are automatically anti-aliased, which causes rendering artfacts due to the partially-transparent billboards being rendered in random z-order, not back-to-front.  Maybe this should be removed for now until we have a better solution?
I just realized something: if you select every Term, you will also display those who have no definition but a link instead.  So you either need to apply a `.exclude(description='')` to this QuerySet or handle this (not so) special case in the template.
s/exposeheaders/exposeHeaders
Mobile Web doesn't have proxies, and we don't have the notion of a "Titanium" object. Objects are just objects in MW.
OK I'm embarrassed now :). yes you are correct.
We are waiting for apidoc inheritance to be implemented (should be this sprint) before events are added to all views, for mobile web.

https://jira.appcelerator.org/browse/TIDOC-639
IMO, 'enableModelListener' sounds better. 

it almost seems like we have a method named setModelListener
probably simplier to pipe `curl` into `tar` here and remove the `rm` and `${jdkTarball}` stuff
`typeof` check seems unnecessary.
Just to set something bogus so it's not blank

On Fri, Jul 27, 2012 at 1:57 PM, Tommy Bishop <
reply@reply.github.com
> wrote:

> > @@ -112,7 +118,11 @@ def set_ssh_user
> >        end
> >
> >        def primary_instance
> > -        @instances.first
> > +        if @stack.instances.any?
> > +
>  @stack.instances.first['instancesSet'].first['privateIpAddress']
> > +        else
> > +          "169.254.169.254"
>
> What's the use case for this?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/live-community/simple_deploy/pull/47/files#r1256560
>
lets refactor all pagination actions in one action and use meta_search gem
if you're gonna do the freaking parens stripping, be consistent please
Actually, I think this will work just fine. It's using the vhost resource name, not the server name. If you have two resources that share the same docroot, whether http/https or ipv4/ipv6, the vhost name will have to differ.

If this is incorrect, can you give a more concrete use case?

However, this is still not doing what I originally set out to do. I wanted `${logroot}/${servername}` so logs for each domain are kept in a single directory. I will modify this.
That's a good point. I'll merge them in at the same time.  I left them out of my initial sync for some unknown reason, and then got hammered with audits for projects more urgent than "simplify day to day workstation administration"

Sent from my HTC Inspire™ 4G on AT&T

----- Reply message -----
From: "Krzysztof Wilczynski" <reply@reply.github.com>
To: "David Trzcinski" <david.trzcinski@reddog.com.au>
Subject: [puppetlabs-stdlib] Addition of lib/puppet/parser/functions/str2saltedsha1.rb (#67)
Date: Thu, May 3, 2012 12:56 am




> +    require 'digest/sha1'
> +    require 'base64'
> +    raise(Puppet::ParseError, "str2saltedsha1(): Wrong number of arguments " +
> +      "passed (#{arguments.size} but we require 1)") if arguments.size != 1
> +
> +    password = arguments[0]
> +
> +    unless password.is_a?(String)
> +      raise(Puppet::ParseError, 'str2saltedsha1(): Requires a ' +
> +        "String argument, you passed: #{password.class}")
> +    end
> +
> +   srand;
> +    seedint    = rand(2**31 - 1)
> +    salt_hex = seedint.to_s(16)
> +   "000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000" + salt_hex + Digest::SHA1.hexdigest([salt_hex].pack("H*") + password) + "00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
 00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"

No worries!

Also, if you want to get your function added, you have to add tests. I guarantee that Puppet Labs will ask about them.

--- 
Reply to this email directly or view it on GitHub:
https://github.com/puppetlabs/puppetlabs-stdlib/pull/67/files#r762200
Хотя, в данном случае и так, и так нечитабельно, имхо. :frowning:
Мы для логических эл-тов пользуемся ролями (`@uploadcare-foo`), а классами — для визуальных.
не очень понял зачем нужен этот класс.
For any user-defined lifetime implementation. E.g. in collections.
Once you removed `moveFront` change `ElementType front` to `ref front` to force `front` to return by `ref` if possible for module level implementation.
static assert(isBidirectionalRange!(typeof(app[]))); compiles with -property.
This doesn't have a target product...
We need to suggest the use of "true or false" to DS doc also: https://cwiki.apache.org/confluence/display/DeltaSpike/Temporary+Documentation#TemporaryDocumentation-Deactivatable

:smile:
good catch.  This was lost in the conversion to a function.  Fixed now.
Updated the code, please let me know!
Rather than inserting your URL at the end of the list, please follow the convention of inserting it in alphabetical order. Doing so makes this (frequently edited) file easier to maintain.
Agreed, but that needs a vote on the community and is outside the scope of this pull request.
Ah you're right, maybe tell them to `php composer.phar update` instead but include a warning that it will also update other dependencies that are not fixed to specific versions? Or is that too much detail? Link to the [composer docs](http://getcomposer.org/doc/01-basic-usage.md#installing-dependencies) instead?
Not sure I really follow what is going on here, and the bug description doesn't really help. Maybe more comments explaining why this is needed?
Me and my lack of xml experience, I thought namespace would be used as metalink:m4 but anyways your regex is a lot better and strict so will use it,
Nitpicking: space after `,`.
I'm not a cmake expert - but does it matter that DEBUGMODE is set after it is queried?
Align the rockets
There seems to be a lot of code duplication going on to create these objects.
Would it be possible to create these objects with a function and some parameter (e.g. in this function only the `_ref` param changes.

e.g.

```javascript
createPageObject(_ref);
```
if `key` is undefined here, wouldn't it continue through to the next `||` and the throw an error?
It seems that the check above should be more precise than ''contains". You know that it will match as a pattern ([gateway_id]$[message_correlation_id]). A Regex might be better.
~~N~~null
Make messageStoreRegion final and remove the setter. That would eliminate mutual exclusivity
storedProc

I am assuming these naming issues are copy/paste - are these parsers are similar to the JPA parsers?

Is there a case for refactoring - have the core parsers in jdbc and have jpa depend on jdbc ??
I know its an existing code, but should it be asserted as hasString() especially now where you are creating LiteralExpression where the assertion is not made. Probably a bug lurking in Spring, but we can make it safe here.
I did this, because it is much easier with low impact of other parts, working recusivly, with arrays, sets and hstore out of the box.
If I add another parsing path for enums (which will be more or less a copy of the existing one), we need to handle the part in multiple areas of the code. So I decided to extend the exsisting code to allow passing of enum values.
This is a bad practice afaik.
Could I kindly ask you to edit the document as you see fit. Unfortunately,
I do not understand your suggestions for improvement. I think you only have
to edit a couple lines. Thank you very for much for your assistance. ;-)
Jonathan
On Aug 9, 2012 7:34 PM, "Maks" <notifications@github.com> wrote:

> In docs/languages/en/index.rst:
>
> > @@ -471,6 +472,13 @@ Zend\\XmlRpc
> >          * :doc:`modules/zend.xmlrpc.client`
> >          * :doc:`modules/zend.xmlrpc.server`
> >
> > +.. _zendservice:
> > +
> > +ZendService
>
> Probably ZendService should have his own index or something
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zendframework/zf2-documentation/pull/139/files#r1344656>.
>
>
Mudei a versão do android para a 2.1 pois o AlarmClock não estava presenta na versão 2.3
I had originally thought this (showing XX) should be lower level, like a method on the dealer .... but this works just as well. Sort of like you are "presenting" the cards through the status method.
in JS, functions are just variables, so the convention same as any other variable (camel case). I'd drop the f.
rename to getValueToCache
The polyline implemented in base was specific (as far as I know) for google map provider, this specific implementation was moved to google map provider.
I understand what you were asking about the other day here.   

Should we cross join the publisher lists and this class becomes a 

string ListKey
bool OptIn

And we can reuse the class in the update list.

Even if we don't cross join, maybe our model should be a ListKey and OptIn.
So would I, actually :)
What about `root_val = Keyword.get(opts, :root, ".")` instead of the `case`?
As I said below, I would rather do this in another PR. This logic is in SGD and also in SVM and has to be adjusted to fit all cases.
translation.need_update?
Do we keep NSLog in this code or do we use a logging framework for that?
Probably better to use the `unredacted` scope here, and for the other similar ones in this file.
thnaks for all this feedback sean


On 9 November 2012 23:25, Sean T Allen <notifications@github.com> wrote:

> In src/main/java/st/redline/core/reflector/NoOpInspector.java:
>
> > @@ -3,27 +3,27 @@
>
> extra spaces in method sigs from String suffix removal
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/redline-smalltalk/redline-smalltalk/pull/150/files#r2082421>.
>
>
We need an active transaction so all recursive deletes (remcontents) happen at the same time, and are cached within the transaction, so there are no locks when deleting.
change the TODO text to ``change it when bumping the requirement to Symfony 2.1``
This isn't implemented on Android.
IOS has another property `duration` which provides info on how long the animation to transition in/out of fullscreen. (Seconds)
Like the `greeting pad2 20` style that this makes possible, but any reason for having the function body in one line?
You can "return" right here.
It didn't really *cause* the problem; rather, you need to override the isEligibleAttributes so that the mapped-*-headers values are not taken literally.
Missed that one ;)
Anyway, i scrapped that PR and here s the new one https://github.com/SpringSource/spring-integration/pull/372
Ok sorry, github displays it in strange way...
Either uncomment or delete
I am not sure I follow here, this is passed into thread_info, and it's deleted after NotifyEvent is called in FindThread/SaveThread/RemoveThread
You do. But "Radio" class extends "Element" class which add's label decorator. 
You only need to change class on labels of options.