labofsahil/github-event-dataset-2012 huggingface dataset:
Just because it's not the source, doesn't mean it shouldn't follow the style guide LN16-25
You have a few style issues, and we expect to use strict equals when we can, it should be changed to:

`selMatch[ sel ] = jQuery( sel, this ).index( jqcur[ 0 ] ) !== -1;`
The ```array_to_string(attr_col_names, ''',''')``` probably doesn't work correctly with column names that require quote_ident(), however I strongly suspect that this is just one of many for the DT code, so I doubt that breaks anything new.
Tested now. The mount point wins.
Added :-)
this should be `prop.startswith('-moz-')` not `'-moz-' in prop` I think.
Full path to executable in tests: `#{bin}/treecc`
AFAICT HOMEBREW_MAKE_JOBS is a no-op under superenv.
just asking: Do we need to explicitly add the std_cmake_parameters?
Some upstream patches went into the cmake formula recently, do they help with the issues here?
I'd rather prefer we use `forEach` and avoid switch statements for now:

```javascript
var validReasons = ['navigationRequested', 'loadInProgress', 'pendingWait']
reasons.forEach(function(reason) {
    if (validReasons.indexOf(reason) === -1) {
        throw new CasperError(f("Casper steps do not wait on `%s`", blockParam));
    }
    this[reason] = true;
}.bind(this)); // note the `this` context binding
```
Didn't you forget to interpolate 'diffyears' into the translation?
You should change the file name to: "Features-proposal-text-transport.rst" to match the other proposal file names.
Yep; pushed
We could throw an exception, and likewise if the buffer is overridden, instead of asserts. What do you think?
Fixed in ad02521
If this is getting pulled into hapipy, it is probably stable for production, no?
I had inititally added that in there because of the code that is removing the previous connect for ios. But at this point we don't need a reference.  In fact, I wonder if I should just wrap the whole thing in logic.
We should just delete this line now that multiple protocols are supported.
no, forum it's fine ;)
Could we still include this bit: "If no editor visible, does nothing."
These two entries--`html_file_exts` and `server_file_exts` aren't used anywhere in this pull request. Did these accidentally slip in?
Now that this is reusable, I think we should document the expected format of the ```ranges``` arg here.
Hmm, actually on reflection maybe I misread how this works.  If the user edits a file without saving it, the timestamp won't have changed and thus we'll still use cached data there too -- so I think this will only ever pick up changes i they're saved to disk (except on first invocation, where we'll pick up whatever's in memory?).

Is that true, or did I misread it again :-)  If it _is_ true, then perhaps DirtyDocumentTracker shouldn't bother listening to the dirty flag at all -- it could use the save event instead.
Move this to coaster if it's not already there.
Is this required or can it be reverted?
I am not sure what this is pointed at. I've updated this pull and lines got crossed?
Why don't simply use the one from `django.contrib.auth`?
Yeah, if all the test steps have gone correctly then you can expect (n) email at that point.
Open sans is already included in our tree
Hm, actually the may I have it set up, bubble will always be defined, and it will always be an element. I can just remove elem alltogether
This will provide visual feedback when users drag something over a droppable area
I'm not much the wiser on that this selector does and what a, i and m are - could you use slightly more easy to understand var names? (they can be compressed down by jingo for production)
In the case the File.symlink fails, we are aware of it and can ensure `rm_r` is doing anything.
The "Simple..." muck is removed.
Why do we need a function for this? Are you duck-typing something like asset.created ?
This duplicates the one in util
While we do not document CSS style currently, you'll see that all CSS rules are separated with an empty line right now, yours is not.
Haha oops. I'll fix it.
It is used in user.rb .. Look in line 507.. I thought we'd be better off putting the call to get a UUID in one place.
I would suggest avoiding sharp dependencies
Yeah, you're right, I even had it in my local branch, but forgot to push it.
David,

I can, and it’s a few clicks with ReSharper but it will take me far longer to submit because I don't have Git set up and this isn’t an edit I can do through GitHub.

I don't see resources used anywhere else in Signalr, what motivates the request? Do you just want to move the long string out of the method body? Would refactoring into a separate method suffice?

Thanks!!
-Michael

-----Original Message-----
From: David Fowler [mailto:reply@reply.github.com] 
Sent: Wednesday, July 18, 2012 2:25 PM
To: Michael Teper
Subject: Re: [SignalR] Silverlight cross-domain fix (#540)

> @@ -184,6 +184,23 @@ private Task ProcessRequestAsync(HttpListenerContext context)
>                      return connection.ProcessRequestAsync(hostContext);
>                  }
>  
> +                if (path.Equals("/clientaccesspolicy.xml", StringComparison.InvariantCultureIgnoreCase))
> +                {
> +                    return context.Response.WriteAsync(@"<?xml version=""1.0"" encoding=""utf-8""?>

Can you put this is resource string or something.

---
Reply to this email directly or view it on GitHub:
https://github.com/SignalR/SignalR/pull/540/files#r1192125
Dispose *always* needs to be in a finally block.
And ideally a trailing /
简体拼音输入 -> 拼音

Since this keyboard comes with two scripts, let's only use character that looks the same in traditional characters & simplified characters.

Otherwise you would need to introduce both `zh-Hans-Pinyin-tr` and `zh-Hans-Pinyin` layouts into the settings and the global key loop ...
Style bike shed: use single quotes
I'm a bit confused, can you please clarify what's conflicting?

Can't you just use an alias when importing it?
@iguananaut - I looked at the code for the PyFITS header that you linked and this looks like a very nice pattern that we could use.  +1!
Typo: `infintiy => infinity`
WROANG
Would prefer to have this in the CSS.  Since we already store the height there, we could have a rule like this:

   
    .sp-allow-empty .sp-hue {
      top: 28px;
    }

And add the container class with the others like this:

    container.toggleClass("sp-allow-empty", ! allowEmpty);

Then we could remove this entire block.  Make sense?
I think "Verify Signed Message" is a good title, which simply states the action. "Dialog" is not a sensible word to end users unless they're UI designers.
Apologies, I misread the diff. Ignore my comment.
If you add `TODO:` in the comment, many code editors will show it in an overview. Might be useful, and more clear to readers that it isn't just commented out code (otherwise, someone that doesn't know might remove it).
So when I change the final Shutdown-call for no GUI to create a thread this function can be removed then, right?
Regarding C++11 - good idea, but it's rather important that I keep this C++98 compatible for now.

Regarding unsigned vs signed int - unfortunately it's implementation defined whether the underlying enum type is signed or unsigned, so changing to int isn't really the final answer.  I suppose we could cast the (manifestly positive) enum value to unsigned in the offending line 557 ... ugh :-/

Regarding std::bit_set - I tried this out and you're right it leads to nicer code.  Surprisingly it also seems to give a minor but measurable performance hit of a few percent, so I haven't decided whether to commit it yet.
This makes a really long line, why not break it up?
> No. Before and After don't establish requirement relationships

Then add `Wants=network.target`.

> We want cjdns to be started when network.target is set as reached though,

Why is this necessary?

> so we have to implement a relationship using `WantedBy`

WantedBy doesn't establish *ordering*, so cjdns will be started as soon as possible if you only use that.
Nit: this indentation style makes me a bit sad. Can you do:

fc.Find(bson.M{
    "source": source,
    "tag": tag,
    "dest": dest,
}).One()
This is an API method (public), so could you provide a docstring here? (And in the other API methods that don't have it?). This is important because it helps our users to know how to use them.
This example should have a reasonable module-level docstring that explains what it does.  Examples are meant to be used as starting points by others for their own projects, so they should be overly verbose in comments and useful information.  The rest of the code is well commented, but a top-level docstring is necessary.
Oh yeah, duh, never mind.
Oops that's a bug. Good catch. Looks like there is no test for this. I'll add the test and fix the bug
You're missing a break statement here.
Yes you are correct. Sorry, but I actually did not look at how you were using it in your code, I needed something like this in OONI and though of implementing it as a patch for txtorcon.

Disregard this patch.
Oh, nvm this one, in the parser it's obviously different.
Not sure if the js is run through jslint at some point. I have to run on each save. This line prevents jslint from complaining about the $ and the function call.
You change spacing here from 4 to 2 spaces. Use 4 throughout.
Are you suggesting something like?

```Ruby
stats.processed.size
```

instead/in addition to:

```Ruby
stats.processed
```
so the arguments that were added and broke compatibility were not necessary to begin with? I guess my question is why did we break it in the first place? Maybe Mattias should answer this.
To be removed or implemented
Upon running `composer install`
> Your lock file is out of sync with your composer.json, run "composer.phar update" to update dependencies
你妹啊。这也写出来。群里吼一嗓子就行了。
shouldn't be possible != impossible XD

I had thought the same, but the parameters comes to the function, so... I only put an exception to let know to the user that the problem is that value. I know what  must come, but not what will come :-)
anyway, yes, I know that this has no much sense
I wonder how tests passed with that btw
Copied from original implementation, removing
Perhaps the signature should be changed to `setPosition:ofDividerAtIndex:animated:`, for better API parity.
What are `laty` and `lony`?
This is not correct. The transform is the transform of the data, not the transform that you want the data to be on.
TODO(david): wire up exception handler
``for site in getattr(settings, 'CMS_SITE_LANGUAGES', []):``
Oh wait, I didn't realize equalizer was a dependency on devtools.  Do you think it should be here, or a dep in the devtools gemspec?
These methods with the _akanda_ prefix don't seem to use self, so it's not clear why they are part of this class (instead of say, an AkandaNetController class or just module-level functions used by this plugin class).
We should really be using something like this for pushing text into html attributes (maybe add it to utils.js).

```js
function htmlEntities(str) {
    return String(str).replace(/&/g, '&amp;').replace(/</g, '&lt;').replace(/>/g, '&gt;').replace(/"/g, '&quot;');
}
```
and we got it :)
together with transformer
I notice you have deprecated the sharedTransactionLog variable, you also would need to deprecate the getters and setters if they are not used too if you don't mind
Better to do 

    $error = $msg = $file = "";
`cellbroadcastLabel`
If you’re looking for a generic name, I can suggest “boolean inputs”.
I would verify the contents of the newly created contact to make sure everything entered was saved.
Nit: too many spaces. Please either vertical-align the `=` signs or use the same number of spaces on all lines.
Remove the additional // at the end of the line
On 08/06/2012 13:49, Timothy Guan-tin Chien wrote:
>> @@ -32,6 +40,12 @@ REPORTER=Spec
>>   
>>   GAIA_APP_SRCDIRS?=apps
>>   
>> +ifdef DEMO
>> +GAIA_DOMAIN=thisdomaindoesnotexist.org
>> +EXCLUDED=uitest template test-agent
>> +PREDEMO=install-media-samples
> So that means we need `DEBUG=0` on `ifdef DEMO` ?

I'm trying to say that I'm not sure DEMO/PREDEMO make sense.

It seems to me that a cleaner solution could be:
  - If DEBUG=0 then call the target install-media

I would like to replace them by a a real fix that would involve calling 
install-media-samples always if DEBUG is not set and splitting apps to 
separate things that are real apps and apps that are just for testing 
purposes.

To make it works it means we need to make sure DEBUG=1 works on the 
device too.
@evelynhung is it OK to remove the size & maxlength attributes on these four `<input type="number">` fields?
Makes sense, on it!
@crdlc you are totally right, so we don't have to look for the page with the specific icon :)
nit: remove the extra line break above }, and add one after
not a good idea to add it in the html, as strings are planned to disappear from there eventually, and that will make all the translations to be modified (and be aware in the future)

will change for margin instead, thx
nit:
`var openscreen` -> `var openWindow`
You are declaring this twice. Also theEvent is a really bad name, why not |var event = {}| ?
I still think this is wrong. And flex-box is not deprecated, AFAIK.
I need to talk to you about this as this code will be coming from BBs
Is TAG_OPTIONS empty here? I mean declared but not initialised?
nit: preValue -> previousValue
`getAttentionScreenOrigins`
What about `bool TryGetLock(out HttpResponseMessage errorMessage)`?
I don't believe that `|&` is actually POSIX compliant, so this will fail on anything where `/bin/sh` isn't bash.  (Included at least some releases of Debian out of the box).  You should probably either put the complex redirection inside the direct execution, or use only POSIX compliant redirection.

It also seems that you should probably capture all the output to me, but I have not checked what other broker plugins do...
why not do 

valid_verbs = [.....]
return verb.trim().lower() in valid_verbs

?
It doesn't sound good to me... but I don't really know how to check if that's correct or not.
`Uncomment this and change MYOBJECT to your own tag if you want this action to call a trigger`
ugh,
Just use Redirect.archiveLink(...) which calls Redirect.thread(...) when we want the post link. You shouldn't have to edit Redirect.thread that way.
This function really shouldn't be written twice. I suggest promoting it to Sburb.parseXMLError and only defining it in serialization.js. Actually, these two files are duplicating behaviour a lot. Perhaps it would be better to create some function like Sburb.parseXML instead that takes in a string and returns the documentElement? I could see having more areas in the future where I would want to parse an XML snippet. If there's a parse error it could just throw an exception and the caller can choose to catch it or not and do any of the extra logging it might want. I imagine in the case of this file, we might not really be interested in catching it and doing anything more (debatable). In the case of the the serialization file it might want to catch it first and log the extra "what file" data before propagating it. 

Maybe have it throw something like:
{name: "XML Parsing Exception", message:<whatever parseXMLError is getting us>, input:<String we tried to parse>}
This used to be mixed into the scrollbar code that was for IE <= 8, but that code is now for IE7 only. Is this still necessary? Should we submit it back?
Neglected to move it when moving fetch_artefact after merging in the ExitController changes. Will move.
Remove all hard-coding of regions
changed the way it works now
This looks like the only deferred in this function, so it would probably make sense to just return it, rather than decorating the function with `inlineCallbacks`.
I bet this might contribute to our persistent issues referring to self.master in the web status.
Should the 'codebase' parameter be in the renderables list too?
I don't mind using an exception, but you raise ValueError rather than something that would result in -32602.
This looks unused?
This is the only TODO that is not in the web status ... I guess it's pretty safe to put a list over there ...
you could use the freshly-documented `buildbot.util.flatten` here :)
That one I made up.  I could replace these with constants.
I want it now.
js最好能写到一个单独的文件中
`lists:keytake(NewSubscriber, 2, Subscribers)` ?
no sometimes there is a user=name at the end..

On 12/11/2012 9:46 AM, Yaroslav Halchenko wrote:
>
> In config/filter.d/dovecot.conf:
>
> > @@ -15,6 +15,7 @@
> >  # Values:  TEXT
> >  #
> >  failregex = .*(?:pop3-login|imap-login):.*(?:Authentication failure|Aborted login \(auth failed|Aborted login \(tried to use disabled|Disconnected \(auth failed).*rip=(?P<host>\S*),.*
> > +            pam.*dovecot.*(?:authentication failure).*rhost=<HOST>
>
> I believe this one could be anchored at the end with \s$, right?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/fail2ban/fail2ban/pull/94/files#r2378678>.
>
We probably don't want to leave a todo here?
it could be changed with mock object and standard `expects`, `with` `will`
Review comment created for PyGithub
It's up to you right now since I don't have a 'plugin protocol' written to enforce behavior here ;)

You can leave it as is, but it looks like
* if @region is nil, you drop messages
* upon any failure, the plugin will enter a bad state and never recover (@region.put fails, then what?)

If you are OK with this behavior, at least for the initial version of this plugin, I will accept :)
In this case this felt simpler since you just need a mapping between wrapper and an element.
If we care only about `path`, we should just expect the path instead of the module.
I'm wondering if this works on Fennec
I just piggybacked on the `resetPasswordEmail` for un-authed no_password. We should probably do the same in both cases tho.
We have one test that fails when run under MYSQL, unless travis is still loco.
https://travis-ci.org/mozilla/browserid/jobs/3650831
@ozten - there is an error in BigTent's routes.js.

On line 15,   
```
app.get('/proxy/:email', function(req, res, next){
```

Then you get the email on line 21 using: 
```
     var service = proxy.service(req.params.email);
```

emails are appended on to the URL as the email GET parameter, we do NOT search for :email and replace as this route is looking for.  The second gotcha is to avoid XSS, we encodeURIComponent each item, so ```@``` is converted to ```%40```

```
/proxy/:email?email=set117%40gmail.com&return_to=http%3A%2F%2F192.168.1.88%3A10002%2Fsign_in%23ADD_EMAIL%3Dset117%40gmail.com
```
(I updated the `l18n-abide` repo and linked to the explanation in a comment!)
Mind naming it 'openPushlogSinceCurrentBuild'?
Should I include it in .gitignore?
@joshcooper Sorry, that wording is a little confusing. What I was trying to get at was something that Luke brought up yesterday, which is that it would be really helpful to know that everything is on Redmine. That way we don't have to wonder if it's just a PR, or an email patch, etc etc. 

I mostly put this in because the document suggests other ways to submit code other than GitHub, so the idea is that no matter where the actual code is, we can always find the ticket on Redmine.

I'll try to word this a little better.
Ah, I see the script itself uses `exit $RETVAL`, but I think it's still important the start function return an exit code indicating if the service started properly or not.
I think it would be fine to allow writes for the owner only and then set the mode back
Would it make sense to add some information within the resource that lets us know if it can have a scope? That way if/when we have something other than `Class` that has a scope, this code will work properly?
Ok, this looks reasonable – removing the filter.
This is an excellent question, they should both be .read.  I'm unsure what on earth was going on there!
There are some whitespaces left at the end of line.
It's not the same slot
We should probably shortcut here. If times for example come from a database, they hardly ever have sub second precision. We probably want to do something like return dup if nsec == 0. This also prevents all kinds of additional logic and object allocation to be executed.
Rubygems must not depend on the system having tar, so this code must go.
Not thirlled by any of these `@extend` calls we're not really adding anything else to these new styles but our compiled `coffeescript` will repeat the styles multiple times in the `css`, I see not reason not to use them separately as we were unless there is something I'm no seeing in here.
Not to be too much of a stickler about it, but isn't this function GPL-licensed code if it's modified straight from the Sage library? If so, that's problematic.
well, in fact waht you need is maplist to get list of rules. So how it can look like ( with below changes):
```

list<string> rules = maplist( map rule, settings["net-udev"]:[],
{
  string attrib = rule[ "rule"]:"";
  // comment describing need to translate it
  if ( attrib == "ID" )
    attrib = "KERNELS";

  return sformat("SUBSYSTEM==\"net\", ACTION==\"add\", DRIVERS==\"?*\", %1==\"%2\", NAME=\"%3\"",attrib, rule["value"]:"", rule["name"]:"");
}
```

I hope you found it more readable then current version.
Is this form "magic"?
> I would honestly expect that if you're using a DB log writer, you'd want to specify your own formatter, and likely format individual fields of the log event.

This is exactly what I said before: every writer must have its formatter in order to define your own needs. We should normalize format with Formatter before to send event to the writer (who handle for the backend).
Twitter query parameter is "q". So to change and get query, there are getQ() and setQ() method.
HttpUri no longer used
Yeah, the if statement was kinda redundant, so I removed it.
This not cover all schema grammar restrictions. You should obtain the schema using at least a static method from `Uri` with the help of this regex `([^:/?#]+):)`
In the datastore admin on appengine, we can only edit entity that already have entities saved. If no entity is saved, we didn't see the entity in the drop-down list.
So I've been playing around with this for a little while now and I'm kind of mixed on its usability. I've found that since the editor is generally positioned close to the top-left portion of the screen that it's hard to generate numbers that are smaller or much higher. I'm wondering if dropping the multiple might make sense. e.g. maybe 10.0 -> 2.0 and 100.0 to 20.0, that way you don't have to jump all over the screen in order get the number you'd like.
the old data does not contain enough information to build the new format as it contains only the constraint for the master branch. The way to build the data for the new version is to trigger an update for all bundles to read the needed information.
Could you send this as a separate PR? Seems unrelated.
again transactionCompleted bool unnecessary
Should check if its a player first. I don't want to do an un-necessary ping.
Make sure you read the exception or if it's faulted it'll take the process down.
this should probably be changed as the console component is not in the Doctrine folder (it was the case for the first Doctrine pear package when symfony2 was not available through pear yet and so doctrine maintained their own one)
This should be a `before_filter` that is skipped when it needs to be skipped.
I never saw before this construction with 'utf'. I tried to google. In my opinion it looks senselessly. 'utf-8' is encoding name, and what is 'utf' in this case is not clear to me.
``\`` is not necessary at the end of lines here
attropl is the name used in the python API. 

I'll rename it to pbs_attributes?
the other checks are using warning() as well
This looks weird. Should you not make sure that files are ordered in increasing time? i.e. YYYYMMDDHHMMSS-like format?
GPL header? (you get the point)
You should add link to `scopes`: http://vk.com/developers.php?oid=-17680044&p=Application_Access_Rights
That's where I saw it too. I can strip out support for it if you prefer. It uses kind of a gnarly regex anyway....
Can you explain the purpose of this class and why you need to use Threads?
Why? The view itself doesn't trigger any error reporting, and it allows localizers to see what their 404 translations look like without causing errors.
Fix the indentation in all the lines of the file.
Even parametrized if the test fails, it fails where the problem is.
`border-radius: 3px;`
NIT: should use spaces around operators:

```js
for (var i = 0; i < assertionUrls.length; i++) {
```
I don't have a real issue with it, I was just curious about the specific version pin - normally we'd use '~' or '>='
Video fps is not good. The whole purpose of the patch is to set the delay based on display refresh rate (the intent is to correct video gear delay which depends on display refresh rate; this is not necessarily the same as the video fps).

You should be able to use GetResolution() (inherited from CBaseRenderer) to get the current RESOLUTION. However I think setting in Configure() is not enough. It is OK for initializing the delay value, but the refresh rate is changed _after_ Configure() in CXBMCRenderManager::UpdateResolution(). Therefore I think m_GlobalAudioDelay should also be set there after the call to g_graphicsContext.SetVideoResolution().
I'd really like this form to be prettified a bit.  I'd like it to be in the "horizontal" layout we're using for eg. plantings (that is, the label beside the field, not above it), and for the button to have :class => 'btn' so it has the bootstrap look and feel, like our other forms do.  I also think that some explanatory text might be in order, eg. "Create a new garden.  Garden name: [  ]"  As the form currently stands, it's a bit sparse and unfriendly.
It would probably be clearer to not use the vertical bar notation, or alternatively to say something like "We need to evaluate this function at the limits of the integral, limit_1 and limit_2, then calculate F(limit_2) - F(limit_1). Another way of writing this is <show vertical bar notation>."
When the pink `x` came up I got confused because it wasn't clear what the pink was supposed to refer to -- maybe get rid of it here but keep it in the next hint?
Thanks for your comment) I have implement it in other way)
https://github.com/Monstra/monstra-cms/commit/70bfa3e976c60fa1f8f09c64a65b6caf7aac0f5e
https://github.com/Monstra/monstra-cms/commit/97c72c002a7f6d731022a04a8f633839bfeac70b
I do believe we already have an `AdminUser` that is given to us by ActiveAdmin?
hah. very hacky indeed...
probably yes... i decided to follow the way already done in
https://github.com/ezsystems/ezpublish/blob/master/kernel/setup/steps/ezstep_site_details.php#L80
but maybe we can change both...
let me know your preferences
на с++ принято все таки на 2 строки то разделять.
Yep, instantly fires the database update: http://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#method-i-has_many
Haven't thought of adding that. It's an option. Logstash agent doesn't fail when it can't connect, so I just coded the same behavior.
`None` is generally a better "no value" default than `''`.
i'll change it to use doto, thanks
This is not really a comment about this pull req in particular, but I'm curious about how the thread pools work for Clojure futures.  Do we have control over max number of threads?  I'll google on this too :)
do we have to log to console?
I would make the opts object optional, so null can be passed in as well.
I think this entire function needs some TLC. Reading it, I have no idea what it's doing. It needs at least some documentation that specifies the expected behavior and expected values, but probably needs some simplification as well.
Yes that should be `indexResource`, good catch.

I thought this needed more abstraction as well, but I cut myself off time-wise on making tweaks in the framework, and thought I'd see if you guys come to the same thought independently :)

I like your suggestion, I'll see what others think as well before I abstract it, and if others agree it's worth doing it before we accept the PR.
Can you precede this with `_` so it's more clear that it is a private method?
It is not needed anymore
How's that? Should I leave it like this for now, or do something similar for all mobs?
can you use the double backquote thing to identify the keys? => ``
I suppose that depends on your naming convention.  I went with matchRequest-plus-suffix, but if Symfony convention is otherwise I'm fine with renaming it.  Note that we likely will want to rename it in light of https://github.com/symfony/symfony/pull/5895 if that goes in, which I hope it does.
Don't like this, prefer that you set the values on the epggrab_channel and let that deal with passing them on. Goes for number, name, icon etc...
this.dirty = -> dirty =
Please change author and copy right info.
Фишка в том, что прямой доступ, опять же, будет работать только в пределах файла с имплементацией класса (в моём случае). Смотрите какая штука: у меня категория объявлена в файле main.m (как в примере). Если делать @property (nonatomic, readonly) NSMutableArray *DNA, то в этой категории я не смогу изменить значение самого массива _DNA, так как категория не видит такой переменной, а свойство объявлено как readonly. Тем не менее, если посылать сообщение объекту self, то всё пройдёт замечательно!

[self->_DNA replaceObjectAtIndex:generated withObject:modifiedGene]; // Error: 'Cell' does not have a member named '_DNA'

[[self valueForKey:@"_DNA"] replaceObjectAtIndex:generated withObject:modifiedGene]; // ok!
@Buxxter, извините, не доглядел. А по поводу дополнительной проверки - она необходима, если нет инкапсуляции. IMHO.
При изменении данной константы, код перестает работать корректно, выводится только - hamming distance before mutation = 7.
Как раз наоборот. То, что вы написали - за вас сделал сам Xcode в момент, когда вы написали `@synthesize`, он сгенерировал геттер `-(NSMutableArray *) DNA` и сеттер `-(void)setDNA`. Я же советую переопределить геттер таким образом, чтобы он не возвращал ссылку на вашу ДНК, иначе её можно будет изменить "снаружи" объекта, а он об этом не заметит. Например, в текущей реализации можно получить ссылку, и изменить массив за ней, например, удалить элемент. И когда дойдёт дело, например, до метода hammingDistance, может быть ошибка, так как по алгоритму может быть обращение по несуществующему индексу в массиве. 
Переопределите геттер, чтобы он возвращал не ссылку на ваш массив, а ссылку на копию вашего массива. По той же причине, кстати, можно сделать свойство readonly
You mean always emit an empty `drain` event on polling transports? (Please clarify all transports or just polling)
Me neither, because we do emit emit heart beats and people might expect that the event is called like every 20/25 seconds or so and if you have a lot of message traffic, you would not receive any of those events. cc/ @guille
Combine steps 2 & 3.   I know it seems odd but the user doesn't think "Oh I visit the login page to login" and in the future, your login may actually be on every page so just combine those two steps.
I think that what @abmargb means is that you once you are returning the same value of index when it is equals to -1 you can replace the if/else statement with something like:

return index === -1 ? index : html.lastIndexOf('<', index);

And please, always use '===' instead of '=='. The rest looks good to me.
How about having _DART_TEMPORARY_ATTACHED be a numeric value - the number of elements temporarily attached at this point?  Decrement below and disconnect at 0.  That should be a little more efficient that the string operations.
This doesn't match up with the opening brace of the block.
Should CODE be a keyword argument instead?
This assertion should be extracted into its own test method as it is not about verifying “that an editor group is removed from all relevant resources”. The same should probably happen with the second assertion below: in its current form it actually just verifies that the editor group is not visible. The test should be to verify the removal using a database query; only then we can be sure that the group has really been removed.

These issues should also be checked in the other tests below.
ecg -> ECG
I don't like the take_abs. I think score_func should have this logic
note that this is not working fully but it's a draft. I have to run home...
Names of conditions corresponding to event_ids.

Labels as a particular meaning.
why dtype int as you divide by a float after?
use elif else to catch illegal value
Please fix the name, this is a timer for news not horoscope
example should be for the whole feed. something similar to /jobs?filter=engineer
You mean isDuplicateConceptName is better English? :)
Wrap this around ``_()``
I don't think this needs to be a spy either. It should just be:

chrome.extension.sendRequest = function(request, callback) {
...
};
I've added an [explanation](https://github.com/kostiklv/symfony-docs/commit/2088fa4a36e6c684d93e641daf1840020e58fa5b) on why we are re-implementing parent.
请求处理会被延迟
=>
过速请求处理会被延迟
* Should this method ends with `?`, as it return true/false?
* Can you cut this line to be <= 100 characters long?
This will fail for `node -e 'require("assert")(0)'`
Tradition?  :-)
The test is doing nested selection along with a few other where conditions. Please name appropriately.
WDYM? Where should I create the 'clusterSettings' in a companion object?
Indeed shorter. Taken. Nice.
error — константа же из енама ProcessError. Лучше дергать
Process_->errorString () или как его там.


2012/12/16 Dmitry Sgibnev <notifications@github.com>

> In src/plugins/shaitan/terminalwidget.cpp:
>
> > @@ -61,5 +68,12 @@
> >  		emit removeTab (this);
> >  		deleteLater ();
> >  	}
> > +	void TerminalWidget::gotError(QProcess::ProcessError error)
> > +	{
> > +		QMessageBox::critical (this,
> > +		      "LeechCraft",
> > +		      tr ("XTerm has not started: %1.").arg (error));
>
> Эмм, разве номер выдается? Вполне себе текст. Или ты о чем?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/0xd34df00d/leechcraft/pull/156/files#r2429095>.
>
>



-- 
  Georg Rudoy
  LeechCraft — http://leechcraft.org
把 L20 ~ L22 都 `<!-- -->` 吧，因為照片 imageTile 還沒更新
I fixed the odd changed?":changed":"" logic
¿Estos saltos de línea no rompen el markup?
...NetworkName
Return `this` to save an object creation.
nice! (although remember: artists are inspired. great artists steal).
We're not going to add type lengths to \@param or \@return types.
please move the comment to the previous line
`POST /v1/credits` should not result in the bank account being stored
Never have single character identifiers, except for the _index_ variable in a for-loop. Never have variables or fields starting with an uppercase character (except for constant values).
The chocolateyInstall.ps1 should have knowledge of the package it came with.

Everything passed is through environment variables.  Long term this provides the most maintainable contract.
This shouldn't have been copied from reddwarf.extensions.mysql.models. Some common method should be created both bits of code can use.

What's more is this code, which takes a chunk of JSON and changes it to a MySQLUser type, should be in the controller, not the model. The model should just get its types and not have to worry about junk the user might send in.

So I think reddwarf.extensions.mysql.service and reddwarf.instance.service could team up somehow (maybe with a common method) to take a chunk of JSON and turn it into a list of MySQLUser objects, validating it along the way.
It seem to me this loop could be replaced with ```allRecipients.retainAll(members)```
(I mean to remove the suffix from the TIMESUFFIX enumeration)
If one of the guessers is omitted, then this guesser should not be called at all.
but why not move this entire if/else block to ``getPrimaryLanguage($locale)``?
Agreed.  Should be `BytesIO`, though.
Get rid of the spaces before `:`.
As you are using check in every routes, I suggest to use something like: `/api/check/disks`
I don't know if you have any of these objects pickled or mocked anywhere, so I don't want to break any existing tests or functionality in that way. If you think it shouldn't be a problem, it's ok to remove, but it's also not hurting anything where it is.
I see this same code repeated about four times in this file - can you pull this logic out into a separate function?
Do we really need to setup touch on every single test case?
Sometimes you have `selector{` and other times it's `selector {`. It should be consistent.
Not a bad idea. These are really all just accessor methods though, so I don't feel bad about adding in a lot of the "same code." We could've just made it all public, but sandboxing is important.
This code has many indention levels. Try to extract some methods.
That is not true - scp/ajax.php is protected.  It doesn' t hurt to have double checks - but had to remove it to allow client interface to utilize AjaxController.
Random sanity check: Does this work when input ts has 0 or 1 elements?
Done in 300635c
I say this one.
Adding a class to the image shouldn't be necessary. Could you verify that the image renders fine when just applying 100% max-width in all instances?
@bp323 shouldn't we replace `jQuery` with `$` ?
This class was copied from Sling to handle sparse related stuff. The [upstream class](http://svn.apache.org/viewvc/sling/trunk/bundles/servlets/post/src/main/java/org/apache/sling/servlets/post/impl/SlingPostServlet.java?view=markup) only clears delayed references during service activation. I've not seen services clear references on deactivation. Since we use event-driven reference collection, I'm not sure that these cleared references will be replaced on service activation. Unless it is found to fix a problem, please remove the `clear()` calls in deactivation.
As I mention below, this feels like a bit of a hybrid. So far my refactoring has left just a single #{_q} in the vestigial query-template strings. My goal was to centralize all query logic in one place in Java code rather than having it spread between JSON templates, client-side JavaScript, and multiple server-side components.
please use SGVector here then you dont need the extra length field and you also can use SG_ADD to register parameters
Looks good to me (tm)
It looks like we're also using `array`, with Zend being inconsistent and using both. I've updated this to be consistent.
You're deleting the documentation about enabling the extension, and running dev/build etc but not providing a replacement. Could you amend that?
Also, I'm just ignoring files that are a MB or smaller.
I'm not 100% sure this is safe... I think that split pages should never appear on disk, and so we should ignore them for the purposes of compaction, but  I'd appreciate any comments you have on this.
Are you sure ``new \Zend\Validator\NotEmpty()`` has the correct type as "object<Zend\Validator\NotEmpty>" is not a sub-type of "object<Zend\Validator\ValidatorInterface>"?
Are you sure ``$validator->isValid('a')`` has the correct type as "Boolean" is not a sub-type of "Boolean"?
Should the type for parameter ``$container`` not be "null|Navigation\AbstractContainer" instead of "Navigation\AbstractContainer"?
Are you sure the class "Symfony\Component\Form\Extension\Core\ChoiceList\ChoiceListInterface" actually exists, or did you maybe forget to add a USE statement?
Are you sure ``$validator->isValid('0')`` has the correct type as "Boolean" is not a sub-type of "Boolean"?
Is it possible to add a ``@param`` annotation for parameter ``$nodePath`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``? I also found this on lines 41, and 46.
If this is expected: use less verbose logging.
No need for DBUnit you are right, it is in there since I initially assumed that we are dealing with databases and it got me thinking that there might be a use for it while testing. Alas Phpmig is actually using adapters that should be tested on their own.
Originally I allowed this to be configurable, but I opted against it in favor of reducing configuration complexity (the driver currently has ~20 connection configuration options).
Can you wrap this call so that the browser does not attempt to perform this in IE? It is only available in IE9 when the developer tools are open.
I guess we are blowing a simple function to a full blown jQuery plugin. ;) I took the code from http://www.tinymce.com/tryit/jquery_plugin_compressor.php and IMO we should stay as close to the documentation as possible as long we don't have a good reason.
Very cool. That's a whole lot easier than it is in bash. Thanks.
can "output_required" be stored directly in self? LBConfig is meant for configuration parameters that specify how the simulation is run.
Of course type should be something else, also names. Also `message` should not be payload.
We are doing space just after the `#`. See how other comments are done.
Hm, do we really need this line?
We do not need this here.
Or one can be /confirmation/ the other /confirmation/token/{{token}}
So do i store key and secret in session seperately?
Breaks build on ES platforms
and shouldn't it be setting 'group' on the reply ?
Try:

{% for member in user.profile.house.members %}
  <option value="{{ member.id }}"> {{ member.user.username }} </option>
{% endfor % }

Also, have you developed a Task model yet?
Yea, I already saw this in code like that, but as I said, its easy to overlook and hard to read.

Name me one advantage of this coding style. In my opinion this isn't a good coding style at all.

Maybe @Cervator @immortius could contribute with a little comment on this issue.
The more I think about this, the less I think pagination per se makes sense. The list of venues is going to be long -- we need a way to present the most likely candidates first. Maybe we prompt the user for an address, and show only venues within some small distance of that address? Or search by name and order by distance from the user.

We need to think about how to present venues in the "need" workflow, too.
am i missing some comments? o.o
muffin?
Not sure we should provide defaults for this and for `$credentialProperty`. The benefit in removing these is reminding the user that he has to provide them (thus avoiding stupid exceptions when he forgets about defaults) and we also don't need to document the default behavior.
Can we use localizable strings here? I'm pretty sure if you put the language key instead of the text it will get run through lang() automatically. Then just add the translation to merchant_lang.php.
That may make the history a bit dirty since once merged there will be two commits removing the same file -- Could you add me as a collaborator (hit the admin button and at the collaborators page add me with my github ID) and give me push access to your github? I can try to fix it up and push it.
This should include the disabled option (via xi:include).
Ah, ya.. Auto is already off. I did that one on purpose. I'll revert that bit and update pull req.

Btw, would you prefer I just cast input enum values to string in both places, instead of value.toString()?

I like the idea of fail fast on no matching enum value for input value, but perhaps we should also just make hard assumption that input values are always Strings, too?
I'd also catch a second import error here on paramiko if it's not installed , and raise something like 

```python
raise ImportError("pexpect was not found, and failed to use Paramiko. You need to install Paramiko")
```
Well, you claim that you intend to write client code that strongly depends on the order of evaluation of asynchronous code.

This has the following drawbacks:

 - most contributors or users will not be aware of this guarantee, so they will not be able to understand what makes your code tick;
 - in many cases, most contributors or users will have no clue of the order in which handlers have been registered, so this will again get in their path if they try and understand what makes your code tick;
 - as a former concurrency guy myself, I tell you that this hypothesis is very shaky once you introduce actual concurrency, which I understand is one of the objectives of Jetpack.

> Now even if you disagree with above statement I think it's important to be complaint with behavior of Q which happens to be FIFO.

I have not been able to find this in the specifications of Q. Could you point me to it? If this is just an implementation detail and not a specification, I really suggest we avoid these semantics.
About the point, I understood that I had misconception about scalaVersion in plugins.sbt by some experimentations.  You are right and that "if statement" is not necessary here.  After a while, the extra
"if statement" will be removed.

BTW. publishing for Scala 2.10.0, I was hasty.
I thought about that before and I think that this class is really for getting a deployment as it has just the required two members for that which are slot or deployment name.
Write `window.tag_manager` instead.
We have the option to run a test case without .spec file. You could just:
- add test name to NO_SPEC list in ./buildtests/runtests.py
- if the testcase is supposed to be --onefile mode then the test file should be named

./libraries/test_onefile_wx_pubsub_kwargs.py
invcov is the inverse of covariance matrix of the linear transformation
inv of dot_fun(r_matrix, dot_fun(cov_p, np.transpose(other)))

we don't need/use the inv of the cov of the params.
Typo: invovling
you are right, but you deleted my todo: ``#TODO: avoid cholesky pinv for diag sigma`` 
I didn't see before that we are always building (nobs, nobs) sigma

I'm subclassing GLS in GLSHet, not WLS

difference between GLS diag and WLS is that weights = 1/variance
I don't use the node itself as a root of a new trie, but instead create a new node with nil value and same hash of children, because by design root node of a trie should have `nil` as its value. Otherwise `find_prefix` works incorrectly in cases when a key is not present in the trie. The problem is that it ends its search in the root node, that means that nothing was found, but returns a non-nil value stored in the root (you can see it [here](https://github.com/KL-7/twitter-cldr-rb/blob/aaee8bfb53dfaaa98769be5ef62eee21f834f971/lib/twitter_cldr/collation/trie.rb#L89)). Maybe there's a better (more explicit) solution for preventing trie's root from having a non-nil value (e.g., with some additional logic in `Trie#intialize`), but that's the best what I could think of. 

Regarding locking the trie, the idea is that this method is only used in `Trie#find_prefix` that returns a subtrie, that is supposed to be used only for further search and not for modification, so we better protect our subtrie by locking it.
Please use [class-base generic veiws](https://docs.djangoproject.com/en/dev/ref/class-based-views/).
The change is in the `loadHandler`, so I hope the field is not rendered before ;)
FWIW, I did not notice a flicker.
You can force push to this pull request's branch.
I didn't change xMin, etc. to camel case.  I changed the documentation of it to camel case to match the actual variables.  This line is just a bug that never got discovered because we don't have any scripts that try to draw objects off the edge of the image.  

However, I'd be equally happy to make all of these lowercase instead to make this statement correct if people prefer lowercase.  I think lowercase actually matches our more typical style, so maybe that would be better.
I just pushed a version with a little more detail on running these examples; can you check it out, please?
Is Spring AMQP actually constrained to 1.5?
testing 288
have a campaign index page and then be able to go to the dashboard of any campaign?
this relative require is not allowed in 1.9, I just hardcoded the version number for now.