labofsahil/github-event-dataset-2012 huggingface dataset:
Well, if the listener itself it not needed, then it can go away altogether.

For the runnable part, I understand now, it is to have some computation executed on the AWT even thread. Then I think you should rather use an anonymous inner class rather than extending Runnable.
Don't rename module so much (just add a prefix to avoid conflicts, but leave it as it is). So `from foo.bar import xxx` is OK if `xxx` is unique, otherwise you prefix it with `bar`: `from foo.bar import xxx as bar_xxx`.
Probably "(i.e., some long string)", no?
Is this actually necessary? Why not just have selectable and cursor stuff in the general `.butter-disabled` class?
Are you sure this is going to work? Don't you have to  call `update` on the trackEvent object for this to be stored correctly?
I'm going to disagree with this... it makes it look ugly. And they're for separate purposes too! Plus, it's not like we're minifying the JS files, right?
500 might not be the best error to report. Maybe we can report something more meaningful.
Should the section added like this?
I have a lot of doubts where to put that verification, but if a "when" step is strictly an operation i'm going to move it to the "then" step.
Thought so, however for ordering sake, a name starting with LdapUserManager* would be preferred.
Master fails.

Then I tried your branch. It fails as well.

Running org.sonatype.nexus.rest.RemoteIPFinderTest
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.085 sec <<< FAILURE!
testResolveIP(org.sonatype.nexus.rest.RemoteIPFinderTest)  Time elapsed: 0.085 sec  <<< FAILURE!
junit.framework.ComparisonFailure: expected:<[127.0.0.2]> but was:<[missing]>
	at junit.framework.Assert.assertEquals(Assert.java:85)
	at junit.framework.Assert.assertEquals(Assert.java:91)
	at org.sonatype.nexus.rest.RemoteIPFinderTest.testResolveIP(RemoteIPFinderTest.java:62)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
	at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:252)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:141)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:112)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189)
	at org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165)
	at org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:115)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:75)
I would call rec records here
I think the idea is that every model that uses attributes ("custom infoz") will include this controller module. this way they each don't have to implement them in their own controller; the routing is supposed to handle establishing the association correctly by setting the :type. If he went with a helper, every model you wanted to add the custom info too would have to implement the controller methods

i would suggest a name like CustomInfoable or something
actually, quite a few places here w/ case sensitive headers, might want to just settle on a case and convert all new headers being sent in for auditing
I don't understand why terminated and stopped states are rejected to dump to the file?
建议把config的结构变一下，用顺序代替key。
比如
```
["addDingAds", "after", 'ListingConnection->find()'],
["modifySomthing", "before", "somClass->action()"],
```
这样语义上也更通畅一点。
You can make it automatically delete on close with `dialog->setAttribute(Qt::WA_DeleteOnClose, true);`
Thanks, didn't know that ... I'm rewriting the code to remove the need for directly calling functions from ::detail / ::ipcdetail!
you could say `!== true` => continue to reduce the depth here by 1
This assignment creates a local variable. It does not assign to `self.validator`.
Would prefer to avoid long chains like this; intermediate variables aren't evil.
please add "string" type qualifier in the doc
Keep me updated should you encounter any issue, please.
Let's just pass `UserMagics` to the call to register in L2012 below.
This turns the selected cell an odd color.  I don't recall discussing this.  Shouldn't this be removed from the PR?
Seems nicer to use map+join, rather than appending this to the message like this. What do you think?
Using HTML comments here will result in several copies of the license being outputted in the source of some pages (as some templates inherit others). If this is necessary in every file (is it?) can we use jinja2 comments rather than HTML comments:

 {#  example comment... #}
These are now updated.
I don't think it's going to be a big deal unless you have a large queue configuration, but this line is O(N^2) compared to using a group_by style solution. See below:

```ruby
require 'benchmark'

queues = Array.new(100) { |i| Array.new(rand(1000), i) }.flatten

Benchmark.bmbm do |x| 
  x.report('sort') { queues.uniq.sort {|a, b| queues.count(b) <=> queues.count(a)} } 
  x.report('group_by') { queues.group_by { |q| q }.sort_by { |k, v| -v.size }.map(&:first) } 
end
```

Rehearsal --------------------------------------------
sort       2.110000   0.000000   2.110000 (  2.114599)
group_by   0.010000   0.000000   0.010000 (  0.006662)
----------------------------------- total: 2.120000sec

               user     system      total        real
sort       2.230000   0.010000   2.240000 (  2.227665)
group_by   0.010000   0.000000   0.010000 (  0.006582)
mmmmm I love mexican food-themed test cases
I think you can get rid of the ``onSuccess`` and ``onFailure`` methods here and inline them into the ``handle`` method.
well, if the folder matches other filters of course
why would it forbid it ? You can register the same prefix several times in the autoloader.
http://doriantaylor.com/policy/http-url-path-parameter-syntax already links to it: http://tools.ietf.org/html/rfc3986#section-3.3
But the mentioned link explains it much better.
no, it is the success handler which should now be mandatory as it is now mandatory in the parent class.
@lanthaler @schmittjoh you're absolutely right. I'll propose a PR soon with this only feature (the accept-* headers parsing) and I'll use `preg_split` which is awesome.
I'll just remove the workflowId param from these urls.
Good point. Unfortunately, how RoutingState and reloadUpdatedForwardings work are significantly different: RoutingState builds a tree from already fetched Shard/Link/Forwardings data while reloadUpdatedForwardings access nameserver db for shard/link data as needed. I don't think those two would fit into a single class very well.

I considered making another class for tree construction, but I think its logic is quite simple enough. I'll keep it as it is.
Yeah, right.  But how do we get the customized content? I think in news we just get the content field and write it there. I don't want to add a function specific to checkin to the Post class. 
I think we should have a function getContent in Post and override it in Checkin. Though that requires changing the news.html and any other Post related views. Am I right?
add space after 'if'
This fixes the nicknameLabel.. have we considered adding generic html decoding in CPapi.m ? ie. within  
          + (void)makeHTTPRequest:(NSURLRequest *)request 
                  queue:(NSOperationQueue *)operationQueue
             completion:(void (^)(NSDictionary *, NSError *))completion
Are these three pieces of information (recipient, sender, and event) used as arguments in multiple spots? I can see that they're used in `Guest#invite`, `Guest#remind`, passed to the constructor for `GroupPrivateMessenger`, `UserPrivateMessenger`; this feels like a smell. An object that wraps this information up that all of these areas of the code can program against more explicitly would be ideal. I urge avoiding hashes; instead, interact with objects - the interface is clearly defined, if you mistype a key in a hash you're less likely to know it, it's often easier to test... the list goes on.
```projectManager.getCurrentProject().getName()``` can result in a *NullPointerException*.
hier wird der key dann benutzt
+1, looks much more natural.
I'd suggest indenting all of these.
This is now
[[Installing and Upgrading]]
@erikstmartin That's what it does in the latest version, which was also part of the Pull Request
I'll have to dig a little deeper here, but isn't ``plugin_list`` ordered at this point? If so, the parent-searching method further down could trivially be optimized by keeping a cache.

Something like:

```python
cache = {}
for plugin in plugin_list:
    plugin.child_plugins = []
    cache[plugin.pk] = plugin
    if not plugin.parent_id:
        root.append(plugin)
    else:
        parent = cache[plugin.parent_id]
        parent.child_plugins.append(plugin)
        parent.child_plugins.sort(key=lambda x: x.position)
    last = plugin
```

The whole ``child_plugins`` handling could probably also be optimized by using a datastructure that will insert sorted. In some cases we might call ``parent.chlid_plugins.sort()`` quite a lot.
I'm not sure if there is a compelling use case for concatenating strings, specifically. I included a test with it because it's the only primitive other than Array with #concat
Why? The updates should be applied synchronously.
I should say a bit more: the moveToTop idea is only present because of the need when working with zIndexes to push items to the top of a given heap (stacking index).

Scott's idea (as I understand it) is to deal with this purely by appending the dialog to the right place in the dom to make sure it's at the top of the heap.
This function is being called in `onMouseUp` function only. Let's give it a better name like `doKeypress` or `sendKey`.

(It's my bad, I should have fix the function name in the original code)
Nit:

Let's just use text, a blob is a blob.
-> 
Let's just use *content-type text*, a blob is a blob.
is there any reason you prefer `document.location` over `window.location`?
These fields need documentation: what do they mean and what units are they in?

English nit: s/_stoping/_stopping/

Can be addressed in a followup.
nit, need to take out the 'var'
This needs a comment explaining why you are appending ?time like the other place.  Are you defeating some type of caching in development?  Is this just a debugging thing?
It seems ugly to have one module poke something into an other module like this.  Without a comment here or on the target that says it's a public API that needs to be coordinated by everything in the same JS global.  I'm over the fact that there's no enforced dependency ordering in your module system though :)
hi @borjasalguero, good point, I'm used to create the singletons like that, but you are right :)
nit: I think it's better to move this line to the end, so the banner shows when content strings are ready.
oh, sorry, missed that text input. And yes, a `type="reset"` would make sense here. ;-)
Nice one! Although kind of "semantically" confusing regarding the spec of the disabled attribute (https://developer.mozilla.org/en-US/docs/HTML/Element/button). In my opinion Javascript went too far on that one and may change its behavior without us noticing to strictly follow the spec... :-D But OK, I've included your suggestion ;-)
I think you want "name = aval.name" and "address = aval.address" to be in an else block, since the code outside the block will clobber the results of the if conditional.

Also, the code inside the if block really wants to parse the e-mail address.  I was lazy and did not do this previously.  I'll do this in a follow-up, but if you could add "// TODO: parse mail address" in that block, it would be great.
`sendNormalKey`?

anyhow, the relationship of this function with `onMouseUp` need to be clarified.
Maybe it is unneccesary. I'v been testing that /sbin is the first place where looking for the utility so if you remove the utility from /sbin, the original (in /system/bin) remains. I'm going to delete the back up.
I think this widget is not localized yet.
Can be a followup, but please help check if this could fit in string freeze schedule.
Any reason why we are not checking the length here the same that in other cases?

var notesLength = getLength(contact.note)

?
https://github.com/nemomobile/commhistory-daemon/blob/master/src/notificationmanager.cpp#L775 is the one I know of offhand.
I concur. My only potential issue is with the HTML generation in RAD and handling that, but it's a separate issue for RAD.
Remove the newline.
I don't understand this. Why create a testing column family in the production DB?
Extract this string constant.
Yeah. All property access need to happen through get(...)
changed the way its work now
Fix this brace too
This can just be `self.db.pool.do(thd, tags)`. `do` pass any additional args to the function passed to it.
why not `resetItems`, `removeItem`, `addItem`?
Good note. I think it should be some "guesser" for archiver type (need to implement all archivers), and fallback to no-cache or some plain format (just a directory?). I think Factory integration is the most unclear thing in this PR :(
This doesn't look right or upstreamable.. did you mean !native_client or is this not needed?
Global variables are initialized to zero by the compiler, so if this is called only once after start-up you safely can remove these lines. state should also be initialized by the compiler to TANKLEVEL_STATE_IDLE. Saves flash.
The idea was to decouple auto-completion from notes. There should be auto-completion anywhere you can write GFM. This means it could be also used in issues, wiki, etc. This lead me to put it in an extra controller to make it independent/reusable.
can we simplify and just supply w?
Why not use the same logic as the other "Auto" modes? Adding another place for determining the number of detect threads is confusing.
Please add the hit counter changes to your description. Thanx.
Since you're using the catstreamer Heroku app, you don't need the reddit URL anymore.

You should also remove the commented out line. And, your two `msg` lines don't do anything.
It's definitely fine as is, but maybe it could be good have an example about what we meant with "absolutely necessary" (e.g. Security issues, Platform changes – like the private browing stuff, etc).
It would be straightforward to understand if you use this instead:
```
main: (function() {
  let main = null;
  return {
    enumerable: false,
    get: function() { return main; },
    // Only set main if it has not being set yet!
    set: function(module) { main = main || module; }
  }
})()
```
No worries I'll just use option version in your snippet.
Not sure what you mean. It's like write a comment why the parameters in the querystring needs to start with "?"…
Has not @ZER0 landed a `readURI` util function yet ?
I would just say that one can inherit from `Unknown` to create new implementations of XPCOM interfaces, and mention aside that idiomatic way of doing it in SDK is using heritage module. 

It's just lots of people feel very strongly about how to subclass in JS and in that regard we are compatible with [standard js inheritance](https://developer.mozilla.org/en-US/docs/JavaScript/Guide/Inheritance_Revisited) and heritage module just provides sugar to reduce boilerplate.
@lloyd - Looking over the client-sessions README.md file, I see the following comment about maxAge:

```
 60           // cookie expiration parameters
 61           // this gets updated on every cookie call,
 62           // so it's not appropriate for saying that the session
 63           // expires after 2 weeks, for example, since the cookie
 64           // may get updated regularly and push the time back.
 65           maxAge: 14 * 24 * 60 * 60 * 1000 // in ms
``` 

I know right now a session and a cookie have the same length, but since the cookie is valid for two weeks from its last write, the cookie is going to expire after the session.  Does this have any negative repercussions?
Interesting, yep.
extract a method `remove_manual`
The normal idiom for an optional argument with no default is `outfilespec=None`.  But this works (though technically `' '` is a legal filename).
I'm not too keen on passing the error up the stack. Is it not possible to handle the error here? Does the caller hold some vital piece of info which makes handling this error there better?
actually now that I think about it, this does cause an issue with the current implementation, since we have to augment argv before parsing
Can "kind" be renamed to "level"?
Missing type Traversable
ViewHelperBroker was removed.
Well, then if you do setQ > setQuery also do getQ > getQuery for consistency
will be removed as the function is the same as 'rosmake FroboMind --robust'
That's not true. What if we need to test out how exercises look on the real site? Or with the scratchpad or something?
Why only `css` ? `js` should be minified too, and it's below page...
This query should be IMO reverted, as we same `nbRecommenders` in database.
I agree, but I like this implementation.  Nice separation in this case, making the code more maintainable.  Often early abstraction can lead to harder-to-maintain code, but this seems good to me.
What happens when we want to update the version?
Store this in the datatable

Add a DefaultedKey in VanillaData.
`continue`s are bad bad bad IMO. An `else` would be fine here.
@sindresorhus you're right, dumb idea.
Whats bellow should be better:

```diff
diff --git a/architecture-examples/emberjs/css/app.css b/architecture-examples/emberjs/css/app.css
index 74b02a2..e1babc8 100644
--- a/architecture-examples/emberjs/css/app.css
+++ b/architecture-examples/emberjs/css/app.css
@@ -3,9 +3,3 @@
 .hidden {
   display: none
 }
-
-.all-selected #filters li.all-filter a,
-.active-selected #filters li.active-filter a,
-.completed-selected #filters li.completed-filter a {
-  font-weight: bold;
-}
\ No newline at end of file
diff --git a/architecture-examples/emberjs/index.html b/architecture-examples/emberjs/index.html
index 1af33a2..c73fd69 100755
--- a/architecture-examples/emberjs/index.html
+++ b/architecture-examples/emberjs/index.html
@@ -33,14 +33,14 @@
 	</script>
 	<script id="filtersTemplate" type="text/x-handlebars">
 		<ul id="filters">
-			<li class="all-filter">
-				<a {{action showAll href=true}}>All </a>
+			<li>
+				<a {{action showAll href=true}} {{bindAttr class="view.isAll:selected"}}>All</a>
 			</li>
-			<li class="active-filter">
-				<a {{action showActive href=true}}>Active</a>
+			<li>
+				<a {{action showActive href=true}} {{bindAttr class="view.isActive:selected"}}>Active</a>
 			</li>
-			<li class="completed-filter">
-				<a {{action showCompleted href=true}}>Completed</a>
+			<li>
+				<a {{action showCompleted href=true}} {{bindAttr class="view.isCompleted:selected"}}>Completed</a>
 			</li>
 		</ul>
 	</script>
diff --git a/architecture-examples/emberjs/js/views/application.js b/architecture-examples/emberjs/js/views/application.js
index 6e8db4a..4a5c96a 100644
--- a/architecture-examples/emberjs/js/views/application.js
+++ b/architecture-examples/emberjs/js/views/application.js
@@ -58,12 +58,16 @@
 			}),
 			filtersView: Ember.View.create({
 				templateName: 'filtersTemplate',
-				classNameBindings: 'routerClassName'.w(),
-				currentFilterBinding: 'Todos.entriesController.filterBy',
-				routerClassName: function() {
-					var currentFilter = this.get('currentFilter');
-					return (currentFilter.length ? currentFilter : 'all') + '-selected';
-				}.property( 'currentFilter' )
+				filterBinding: 'controller.namespace.entriesController.filterBy',
+				isAll: function( event ) {
+					return Ember.empty( this.get( 'filter' ) ) ? true : false;
+				}.property( 'filter' ),
+				isActive: function( event ) {
+					return this.get( 'filter' ) === 'active' ? true : false;
+				}.property( 'filter' ),
+				isCompleted: function( event ) {
+					return this.get( 'filter' ) === 'completed' ? true : false;
+				}.property( 'filter' )
 			}),
 			clearBtnView: Ember.View.create({
 				entriesBinding: 'controller.namespace.entriesController',
```
I'm sorry, but this sounds implicit, and again, this value (None, or 
'') could be used with a different meaning.

(I don't get why you don't want to use False to disable the file writes)
yeah that was super fast! now I get to see if my type annotations work :-)
this looks like the right place indeed. xml and yml do this:

    $class->setNodeType(isset($element['nodeType']) ? $element['nodeType'] : 'nt:unstructured');
It looks like there's an existing test named `try-tests`. You might just include these assertions in that test, or you could rename this test.
old version of the LIBBLAS setting, I removed the comment line
better to just remove these 2 lines completely.
Yes, the constructor should go first.

If the super function is supported in Python 2.4, use that everywhere where we extend \_\_init\_\_ .
You're definitely right about not needing the apostrophe, but I'd still get rid of the comma.
You should probably be updating this with extra_context afterwards:

```python
my_context.update(extra_context)
```
should this be KumaEJSTemplate?
Get @jsocol or @tofumatt to weigh in on this.
Don't leave this commented-out line.
Fixed with the follow-up commit.
Those two urls above, just drop them in the browser.
I don't think these relative imports  work for Python2.x versions. You might want to take a look at how 2to3 works in numpy in order to support the full range of versions.
This file appeared to be redundant, so I removed it
Why are we changing the pairtrade spreads here?
this sort of use-case will work better with https://github.com/senchalabs/connect/issues/522

I need to think on that some more though, both have pros/cons, deferred errors like this one might invoke app.error several times which is good for reporting but bad for responding. we could tell people to check `if (res.headerSent)` but that's kinda lame, almost need one callback for reporting errors and one for responding :s but that's sorta lame too
Due to the fact Snaplet.Test exports some fancy HUnit assertions.
This is not needed, build_ossec() removes all packages...
Shouldn't you use `bot.BotControlClass` instead?
What is this change? I don't see anything changed...
I thought all of the responsive elements were wrapped in media queries such that it wouldn't matter where they were imported in the hierarchy of CSS?
you might want to rescue this within the CLI or Lib app and reraise a NexusCLI error
estabilish? xD
oops, nice catch :)
Added new "canSelectRows" config property, defaults to true to support backwards compatibility. To turn off selection, users must explicitly set this to "false".
capital for RETURN (and all keywords)
Session instances are immutable, so this method will not work as intended
If you just do a bare `raise` doesn't it not push this frame onto the stack trace and act as if it's just the original exception not being handled?
I miss being able to expand context, Github.
Actually, it has never been needed, except if you send Content-type: application/xhtml+xml.
To make unit testing possible.
Could we maybe also have the server return a URL to visit for upgrade info, and then include that in our log message?
Wx 2.9 includes three different implementations of the pubsub API. This takes the version 1, (which is the default implementation in wx 2.8) into use
An explicit check for `=== 0` is going to be more readable.
Can we make this ID more descriptive? 'will verify that users can log into the system using a local authorization strategy' ?
Yes, that will no longer be possible.
The bodyParser is essentially a wrapper for the JSON-, urlencded- and multipart- middleware parsers.
AFAIK, the UI isn't using JSON POSTs anywhere so I removed it as it runs a check against each request which isn't really needed.
Not sure if file is a descriptive name.
I think you can save the listener for later and still use an implicit if you use an explicit type:

```
val eventListener: IDebugEventSetListener = { e: DebugEvent => ... }
```
Put it on a separate line so it separates the config option from the documentation for it.
Aha. Ik zou dit andersom doen. je bewaart in de `Enemy` een reference naar de `HealthBar`, en in de `handleHealthStatus` functie zeg je dan zoiets als:

```js
healthBar.updateHealthTo(health);
```

En de `HealthBar` heb je dan een functie `updateHealthTo` die de bar aanpast. De `HealthBar` luistert dus niet naar de `update` functie.
Does this bring any advantage at all?
Not everywhere second letter in lowercase. Russian is corrected.
Все загрузилось. 
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
выше мой комментарий не актуален, были правки уже.
@dmitrykh посмотрите-ка внимательнее, метод **numberWithInt:(int)** - это class method, и пример корректен.
хм, вы массив инициализируете с единицы, а проверку начинаете с нуля.
According to the brackets-shell readme page (https://github.com/adobe/brackets-shell), the cache location on Windows is "{USER}\AppData\Local\cef_data", so there's no "Brackets" folder. I'm not sure if that's a typo, or the code should change, but these should be consistent.
can retrieve the server's
This `@synchronized` is unnecessary now.
hmm.. if (noise_cov != None) is False, you know that noise_cov is None, so there cannot be any silly values, no? (I might be wrong, it's early in the morning and I haven't had any coffee)
So my one big concern about this is that while the user's submitted content will never change, the sanitization parameters will. For instance, as we run into issues like #130 and #54, we'll have to change how we use bleach, which means that the return value of the GET request will need to change.

I guess this is okay if we have a way of invalidating the cache on the server-side whenever those sanitization parameters change, but we should document it well and make sure it's easy to do. If we can't easily invalidate the cache on the server side, we might want to wait a while until our sanitization parameters stabilize, because at the moment I personally don't trust them at all. :)
Can you put a reason in the annotation for why you are ignoring.
that's a good idea, making that update right now
Use `-pthreads` (note the extra `s`). It's a bug (sort of) with gcc 3.x on SunOS systems, gcc 4.x recognizes the singular form.
can you explain why you think it is a prefix?
done now. thanks for the suggestion
Читабельнее, чем твой!
No me gustan mucho esta forma de inyectar referencias, pero en este caso me parece aceptable.
I don't like that you write the real url in anser_url. You should use reverse('application_support'). But reverse will probably not work in the url-statement. For this reason you should write a get_answer_url() method for your class-based-view which returns the support-url, if self.unsupport == False, and the unsupport-url, if self.unsupport is True.
please be consistent, all results must have a result key
spelling: _It's_ possible
If someone has sent us a username that is blank, thats a bug.
cache(i) looks a bit nicer...
@mmarkus, couldn't you modify StateTransferInterceptor to forward TxCompletionNotificationCommands as well?
At first glance I'd add setThreadContextClassLoader to SysPropertyActions. 

Not sure I understand/buy the package security enforcement. Why not use SysPropertyActions?
Ah yes. Sorry! This is debris from the object oriented interface. I'm a heavy OO user, so when I write I examples I use the OO and then convert them to pyplot when I'm done. I'll fix this.
we need some of this logic here in the case of multiple calls to hist() or mixed plotting.  If there are existing bounds, they should be used (at least, that is what this logic attempts to do.  It might need some serious updating, though).
@WeatherGod Good spot, I didn't notice those.

@jgehrcke As Ben points out, it looks like it passes because they're already `ravel`d, so you can disregard my previous concern.
Nit: This is using double quotes, but two lines you're using single quotes. In webdev we use single quotes for everything. I'm ont sure what the convention is here, but should probably pick one and use that across the board.
"et espace**s**"

"fichier**s**"
Very good point ... from the docs:

> convert periods (string) to an integer value that is relative to the start period.

It's not strictly wrong, it's just not doing what we need. It returns the correct period indices relative to the start period, but the problem happens when you use those periods as vector element indices with `subvec`.

Do you have an intuition about where the fix should happen? I'd like it to be dead obvious what's happening - this period vs. vector indexing business is confusing!
There's a double space here
2 lines here as well.
Hah! Well it compiles better than putting display none on each of them. But so does putting all the rules together to begin with. ;)
oh well I guess I did point that out in an edited chunk so can't blame you lol -> https://github.com/verticalbrands/vanity/pull/12/files#r1279160

Also can't find anything weird w/ the testapp (since all I do is click button to track!) [in regard to edited comment here -> https://github.com/verticalbrands/vanity/pull/12/files#r1284959 just in case you did not see that bit (and I really need to stop abusing the edit feature) (and parenthesis)], so yeah I'm going to leave it out for now and bring it up w/ the vanity people.
should this call something like:
```fail "Experiment #{name} cannot have more than one default alternative" unless *args < 2```
we should check this error, nooping it wont be good
connections -> connection's
I set the WT_BTREE_DISCARD flag in the session code and passed it down, it wasn't clear to me if that was correct, or the flag should be set here, since we have to detect that we're opening the "last" checkpoint here in any case.
Why is "." added. It worked just fine before and that's the way Composer's docs suggests that it be done?
This line is the Line where all my edits begin
Are you sure ``$nodeName`` has the correct type as "integer|string" is not a sub-type of "string"?
Are you sure you want to override the parameter ``$originalName``? This often makes code less readable.
Should the type for parameter ``$userAgent`` not be "string|null" instead of "string"?
Probably a tab?
Seems like we could just use `/^Rails 3\.\d\.\d has a .../` but clearly this is non-blocking.  The regexes in general could use some love but, again, this is super unimportant
From what I understand, the response from MTurk is only the MCQuestionOption ID, from which I can get the MCQuestionOption and MCQuestion. If the MCQuestionOption ID is nil, then I can't access the MCQuestion's label/question to produce a (label, "No response given") entry.
isoformat is probably not the best, but probably good enough for tests.
Indent all this part from here to before "var form" once to the left.
It's not because of `<input>` inside of `<form>` as `browserid_form` puts it, and `<input>` cannot be a child of `<form>`, because you need a block-level element. However, `browserid.js` runs:

    var $e = $('#id_assertion');
    $e.parent().submit();

so it expects the `<form>` to be the direct parent of `<input>`. I've worked around it by wrapping it in `<div>` and attaching a submit listener to it, so when `browserid.js` submits it, it automatically submits the form. Is there a better way, without modifying `browserid.js`?
I think there are errors somewhere else in your code. Please do it in the way it should be, commit and push and I will check. OK?
JavaScript indentation is not good in the file.
Bug :) I removed ListField.
There is space before `...` in Slovenian language.
Why is `gettext` so stupid :)

> Now, this is a general approach. In your case, because you are translating week days names, those translations are probably already existing. It might be interesting to research if Django supports such translations in JavaScript by itself, or how to leverage existing translations for days or localized date time formatting.

Is this a hint, because your suggestion with associative array looks very promising.
Exception Type:	DuplicateKeyError
Exception Value:	
E11000 duplicate key error index: PiplMesh.weather.$at_1_created_1_latitude_1_longitude_1  dup key: { : null, : new Date(1348481093000), : 46.5507723961, : 15.6441316009 }
Is this included in the commit?
Shouldn't the else case be target, not '_parent'?
The type of the args shouldn't matter, since the variadic overload just forwards to the binary overload.
En este guión el único detalle que tuve fue que en mi OS mi `rrdtool`, lo que hacia para probarlo es pasarle como argumento la ruta del binario rrdtool pero mejor lo exporte con el `which rrdtool` creo que queda mas portable el código.
how about instead of passing in all these values you construct an options hash that you populate along the way then just pass it in?

```ruby
options = {:xml => response}

options[:identification_number] = root_node.get_text('ShipmentIdentificationNumber').to_s

# ... etc ...
```

Also, there's a lot of really long lines here, could that code get separated out on to different lines? I almost didn't even notice the code because of how narrow the GH code view is.
You are right... Math fail... Damage should be 100-500, with lowest
damage on 25y. I'll think of better formula later today.

On 12/28/12, joschiwald <notifications@github.com> wrote:
>> +        class spell_egg_explosion_SpellScript : public SpellScript
>> +        {
>> +            PrepareSpellScript(spell_egg_explosion_SpellScript);
>> +
>> +            void HandleAfterCast()
>> +            {
>> +                if (Creature* buru =
>> GetCaster()->FindNearestCreature(NPC_BURU, 5.f))
>> +                    buru->AI()->DoAction(ACTION_EXPLODE);
>> +            }
>> +
>> +            void HandleDummyHitTarget(SpellEffIndex /*effIndex*/)
>> +            {
>> +                if (Unit* target = GetHitUnit())
>> +                    GetCaster()->DealDamage(target,
>> GetCaster()->GetDistance(target) == 0 ?
>> +                                            500 :
>> +                                            500 /
>> (GetCaster()->GetDistance(target) / 5));
>
> checking float == 0 is not so good
>
> i think the formula is also bad:
> dist = 0: 500 dmg
> dist = 0.1: 25000 dmg
> dist = 0.5: 5000 dmg
> dist = 1: 2500 dmg
> dist = 2: 1250 dmg
> dist = 5: 500 dmg
> dist = 10: 250 dmg
> dist = 25: 100 dmg
>
> or i'm wrong?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/TrinityCore/TrinityCore/pull/8755/files#r2513192
>
i mean you need to execute this query only once and not for each quest in map
Looks like this diff is only spacing changes?  I think we should be living in a 2-space indent world, wherever possible.
@bakura10 nope, that won't be accepted in ZF2 imo. The `credential` concept is something specific to the auth adapter, not the service itself.
> `, '_this', '_this', '_super'`

You added `_this` twice?
In this context, you're only concerned with the data coming back. You really don't care what it's called with or how many times it's called.

Mock are for when you really care about the arguments and/or how many times something is called (for example a really expensive operation or when calling it multiple times actually changes some state somewhere).

Make sense?
Long line. Skip the parens around `header.name`.
Why does basestring cause an issue for py3k? I'm pretty sure this is the standard way to check if a variable is a string, and 2to3 should handle it fine.
This should be converted into a CLDR locale by calling TwitterCldr::convert_locale, otherwise stuff like: `TwitterCldr::Shared::Calendar.new(:'zh-tw').months` won't work.
If you have to introduce !important, I believe you're doing it wrong (unless this is a workaround for browser limitations or to override another developer's use of !important).

![Not a blocker, though.](https://www.a.pdrake.allplayers.com/anim_thumbsup.gif)
This can be the interface EventRecorder.
Hi @TallJimbo , I'd like to be able to wrap the `get1d` member function to get Python access, but wasn't successful.  Is this possible?  (I want to use it to instantiate a new `InterpolantXY` object in the `CorrFunc` `.copy()` method.)  Any comments / help / commits would be welcomed!!
Yep.  Thanks.  I just removed all the other unnecessary static_casts that I hadn't done yet.  (I hadn't grepped for it before -- just changed the ones I noticed at various points along the way.)
Since we aren't really polyfilling here is it better to just turn this into an object with properties for names and truthy values and check for existence of the property rather than looping an array using a non-native method?
I think theres a method in the Video model for this
ok, this was copied from Richard before
I don't get this: what adds e to entitiesToStopOnShutdown (both in the path of previously null, and when !=null ?
seeing how easy it becomes to add a javaSysProp in the example i like it a lot.  i think best way to clear it up is to make it standalone and well-documented, a micro-project in a sense.  (and same for Tasks methinks.)
Perhaps say what the type was? The toString on the instance might not make clear why it is unsupported...
O URL Path está cravado (/accounts/password/reset). O ideal seria utilizar o mecanismo dinânico de montagem de URLs ``{% url url_name %}``
> My test suite doesn't pass deterministically.

That's a shame. :-(

For this specific case, would it work to wait until the job is ready instead of sleeping? (I'm not sure if you're waiting for the ready state or something else.)
we could extend the File class from the odm here. then this would be a file usable over webdav...
Any reason not to put a <video> element with these attributes in video-container?
Whats up with these guys?
In this method are multiple undeclared vars used which will clearly end up in a runtime error
Forgot the if(!poisoned) here ...
Backspace function 1 column
Why not just have an example file in src control in a specs/examples directory (or similar)?  I am not keen on writing temporary files for these kinds of tests
Yes. get/set are mandatory on RecordID field like [PropertyDescriptor](http://docs.oracle.com/javase/1.5.0/docs/api/java/beans/PropertyDescriptor.html) if is not provide [throw FieldNotFoundException](https://github.com/danielpassos/aerogear-android/blob/configurable-id/src/org/aerogear/android/impl/reflection/Property.java#L53) see tests [testSaveWithNoPropertyToSetId](https://github.com/danielpassos/aerogear-android/blob/configurable-id/test/org/aerogear/android/impl/datamanager/MemoryStorageTest.java#L95)
Change to "Instance to set new value"
If an unique position is available for every row in issues, why should the update fail?
Clearing these styles:

for fl-videoPlayer-volumeControl: background: none repeat scroll 0 0 #F2F2F2;
for ui-slider-range-min: background: url("images/ui-bg_gloss-wave_35_f6a828_500x100.png") repeat-x scroll 50% 50% #F6A828;
for ui-slider-handle: background: url("images/ui-bg_glass_100_f6f6f6_1x400.png") repeat-x scroll 50% 50% #F6F6F6;
I still think we need to say something like

    The CarMart quickstart can work in two modes: "library" and "client-server", however only "library" mode is supported in JBoss Enterprise Web Server or Tomcat.
The values for side and h seem to be calculated incorrectly. This caused distortions in the texture when I tested it.  I resolved this by setting side and h to 0.5f and 0.25f respectively(I used square images).
Why is `App.IndexOfObjPropMixin =` here? I'm not sure this makes sense.
"make use of"?
I *think* that would work, could you test?

```ruby
assert_no_select "label[class]"
```
Is this step necessary? See line #102.
ok. will try to make all names more explicit.
It's probably better in general to use `.toarray()` instead of `.todense()` as the latter returns a matrix object that has a confusing API. Even though this is not a problem for this test, better be consistent across the project as user might copy and paste snippet without being aware of this kind of gotchas.
yeah sure. Wasn't really convinced mine is nicer. could even be longer ;)
`b` and `c` are not meaningful variable names. Maybe `bias_hidden` and `bias_visible` would be better names? (This is a suggestion)
Is a reference *really* required? Since XP 5.0.0 I almost never saw the reference sign used again:) Content could be copied and re-set later on, right?
So, I would consider make this repo PSR-2, but if not a couple things:

 - `use stdClass;` would suffice.
 - I'm used to lowercase `namespace`.
 - Document the class, if you must document the file, just say `Contains classname.`.
`Expression* e = (Expression*) o;`
->
`Expression *e = (Expression *)o;`
Put this line after the TODO, or better yet move the TODO onto or above the line it's talking about
weight if we decide to add that.  could help depict 'most popular repos' or something. it's just there.
Why in a separate loop?
Not needed ... Just a copy-paste.
Does hthor not need eof handling like roxie?
if disk is full, could release() throw an exception, leaving a non-null writer?  Avoided if use Owned.
It is a shame that this code needs to be dependent on the activity kinds.  I can't think of a simple alternative though.
I've moved the `isLocalProxyPortAvailable` to the new base class, and cleaned up some of the config parts to make them more composable when in separate filters.
But if it doesn't get translated and the exception occurs when rendering something with `I18n.locale` set to language different than `:en` then instead of exception message there will be `"translation missing"` (or maybe even different exception saying that there is no translation of your exception message).

To make it work properly one would have to keep webmachine exceptions translated to english in every used locale. That way the error in logs or tools like airbrake.io will always be meaningful and coherent. I think that you would be misusing `I18n` library for what you are trying to accomplish. You don't want that message to be translated. You just don't like random string in code. So maybe something like:

```
#somewhere
Exceptions = {
  unroutable_resource: "Routing for the resource could not be found",
  annonying_paneq_github_user: "Stop telling me how to write my own framework :)"
}

# raising an Exception
raise ArgumentError, Exceptions[:unroutable_resource]
```

However it gets tricky if you want to have dynamic exception messages with for example name of resource with missing route. You would have to store Proc generating such messages in the hash keeping exceptions.

I personally would just keep it the way it is now. That was my 2 cents. I hope you appreciate my feedback even you make a different decision.
deze wijziging ken ik niet ?
Uh, no! This was only meant for this single line (so a block of assignments is always aligned to the minium number required.
This spacing could be better:
```
THUBNAIL_ALIASES =  {
    'small': {
'size': (100, 100)
+                        'all_settings_sample': {
 	 28	
+                           'size': (0, 720), 
 	 29	
+                           'quality': 100, 
 	 30	
+                           'autocrop': True, 
 	 31	
+                           'bw': True,
 	 32	
+                           'crop' True, 
 	 33	
+                           detail=True, replace_alpha='#fff', sharpen=True, upscale=True),          }, 
 	 34	
+                        'large': {'size': (400, 400)}}
```
Donc cette CSS est appelée par Wufoo c'est ça? ce serait bien de le préciser dans les commentaires.
Instead of using UserService to get a user, you should just create your own:

```
User user = new User().setUid("323487"); 
```

And remove the UserService member from this class. Ideally a unit test should only include the component it's testing, and any collaborators should be mocks or fakes.
s/ativity/activity
if user.length == 0 and pass.length == 0
Modules should not run getsystem.  Check for necessary privileges and tell the user if they need to run it.
I know you didn't change this part but wtf
OK, it's also best for backwards compatibility.  Let me know when ready, then I'll merge.
In the future, when moving functionality, do:

```
git mv _greycomatrix.pyx _texture.pyx
```

and then edit ``texture.pyx``.  That ensures that ``git blame`` still finds the right culprits!
Maybe replace with

```python
def estimate_transformation(ttype, src, dst, order=None):
```

This will make the docstring cleaner and clearer. It'll add a little work b/c you'll have to special case the arguments to the polynomial transform, but I think it'll be worth it.
I'd go with `pyramid_gaussian` and `pyramid_laplacian`.
Hey Pete - are we no longer doing the HTML versions?  I looked at a few others and that appears to be the case, just wanted to make sure.
i updated it further to avoid having to follow the redirect.
Like I said, just devil's advocate.  I'll change it.  It won't make the result passed in case any slower. (assuming creating temporary vars has no affect?)
We probably want to avoid the object literal allocation here but accessing a strach value via a closure.  If only we could put these on the stack.  Ugh.
Less is more - and if we can avoid adding a new class and still keep this class cohesive, we should do it.  @IanLilleyT see what you think works best.
I don't think `Matrix4.inverseTransformation` would work if the model matrix has a scale. The reason the inverse of a rotation matrix is equal to the transpose is because it is also orthonormal. If a scale is added, it is no longer orthonormal.
Why have these empty `beforeAll`, `afterAll`, etc. calls throughout.
Yeap.  Good catch.
ok，后面的空格我也会加上的
This is pretty hard to read. I'd like to see the boolean tests split out into separate helper methods, so that this could be written as:

return (WebRoleExists(roleName) || WorkerRoleExists(roleName)) && 
    CloudConfigExists(roleName) && LocalConfigExists(roleName);

I think that's a LOT more readable and maintainable.

But let's not do it now, this is more a note to self for later.
I would prefer keeping these parentheses as I find them appropriate for `typeof`'s unusual syntax.
We should be using constants from the TiC class for strings like this
There should be no new line between @param v and its description
Well, this particular function is actually an example of how to remove all extra items. I can put another for adding additional items.
Check out ````@apiNotice````, there's an example in blackberry.app.events
Это не читается. Много лишних скобочек и длинная строка.

```javascript
if (typeof start === "number" &&
    start / 20000000 > 0) {
    // your stuff
}
```
are you missing a `:` here after the `1`?
no space between parens and braces.
I'm also unsure where this is being used outside of the loop in the template.
why enforcing a collection here ? All you really need is ``array|\Traversable`` as you only iterate over it.