labofsahil/github-event-dataset-2012 huggingface dataset:
Ok, I've pulled it out into a CSS class. Do you think it needs to be in LESS as well?

Thanks,
Chris

From: Ben Combee <notifications@github.com<mailto:notifications@github.com>>
Reply-To: enyojs/layout <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Tue, 30 Oct 2012 13:58:06 -0700
To: enyojs/layout <layout@noreply.github.com<mailto:layout@noreply.github.com>>
Cc: Chris Patalano <chris.patalano@palm.com<mailto:chris.patalano@palm.com>>
Subject: Re: [layout] Image view pins (#97)


In imageview/source/ImageViewPin.js:

> +             for(var i=0;i<controls.length;i++) {
> +                     controls[i].applyStyle("position","absolute");
> +             }
> +     },
> +     // Apply specified positioning to client controls
> +     positionClientControls: function() {
> +             var controls = this.getClientControls();
> +             for(var i=0;i<controls.length;i++) {
> +                     for(p in this.position) {
> +                             controls[i].applyStyle(p, this.position[p]+"px");
> +                     }
> +             }
> +     },
> +     // Update styling on anchor point
> +     highlightAnchorPointChanged: function() {
> +             var bkgnd = (this.highlightAnchorPoint) ? "yellow" : "transparent";

Is there a non-debug use case? If so, should use styles defined in a LESS file for the pins instead of hardcoding "yellow". Same for border.

—
Reply to this email directly or view it on GitHub<https://github.com/enyojs/layout/pull/97/files#r1984762>.
Maybe not related to the feature, but `pry-rails` is pretty cool anyway :) We already had `pry` in there too. Can always merge and remove later
I really don't see the point of this shortcut
I'd rather leave this as Scale.default since that's not actually contrary to the recommendations. Does jslint actually complain?
I like this, but I'm thinking version should be omitted from the method signature. It seems unrelated and more low level than most curl abstractions. I'm starting to think this should be renamed to something like sslVerification(), setSslVerification(), configureSslVerification(). What do you think?
Should be camelCase. We could also expand this into an array manually and set it as a static property on the class rather than force this to be computed each time for every cookie validation.
We use the join to add the missing <class, value> pairs. 

If one <class, value> pair does not exist in the original data, the grouping set operation will not generate it.
You know all these files aren't in your git repo? VS.net gives me a bunch of file missing errors when I try to build your branch.
s/have/has/g for the paragraph
Yes, this fits the MPD commands, but it's also the API of pyspotify/libspotify: a playlist is created by name, and then you fill it with content. For the local backend, it is useful to get the name of playlist first, so you can construct an URI based on the name.

On the other hand, I guess it would be possible to give `save()` even more responsiblity, and have it create a new playlist if the URI of the playlist object it is passed isn't set.

What do you think?
So in the light of `git` being in there, too and overwrites homebrew's git, I guess we leave it as is?
join("\n") is not what we're using in other places - we're just doing "Sentence.\nSentence."
Can one get both short_message and message_payload?
Good question. I found the command to do it, but didn't see a way to specify the ISO size. Perhaps this is a question for Pradeep, and the actual guide for doing the export will come under the admin client section of this guide.
This isn't actually what I meant in #1345, only to test that the Timestamp or datetime.datetime values in the resulting object arrays have the right `tzinfo` set
Oh, just I mean have `self.agent.request` just wrap that function, I mean, so you don't have to do the work of checking the args and obtaining the the body producer, and calling that function every time.
added data-target="#"
This functionality would be really useful in select_ensemble_bagged too. Let's add it as a parameter to that method, then it can get passed down to select_ensemble and we'll get it for free.
```
for _, target in ipairs(targets) do
  target:setVisible(isVisible)
end
```
のほうが上記のtarget:setVisibleとalpha値の設定が重複しなくてすっきりするような気がします
Couldn't `edge` be null in this case? For example, we should have tests for:

    Edge edge = null;
    Edge other = new Edge(...);
    Assert.False(edge == other);
    Assert.False(other == other);
Let's shorten this: "Invalid @parameter value: 5.  @Parameter fields counted: 3.  Please use an index between 0 and 2."
You could extract getTestClass().getAnnotatedFields(Parameter.class) to a seperate method getAnnotatedFields().
Decided for `andAlso`, renamed the methods in 872faeab15115635b3260001979ae036e64e29bf.
I'm not sure there's much interesting to test. The contents of the files will likely change. Since it's just concatenating two files, there's not much to go wrong unless it completely fails because one of the files is missing or something. In that case, we should get an exception anyway.
Same question about $()
Is this block supposed to be commented out? I see where it was removed in ``loadProject``.
I think this text would be more readable if the string were delimited with single-quotes, then you wouldn't have to escape the double-quotes. Same comment in next test.
Use 4 spaces instead of tabs.
For completeness we should probably put a script tag in every place that's UI-visible: versionString, dateString, name, description.
The Esc key closes all other dropdowns in Brackets, so it would be nice to also do that for this dropdown.
Matt makes a good point. Can this state not be deduced from server messages?
instead of this and the forEach do
    var page = tabEditors.getPage(message.path);
i'm not sure what you mean?
This file should not be in the source code. Please remove it.
and this one :-)
Nitpick, the description could help by saying 'should return the latest version set' or something like that.
Neat! Didn't know Travis could do that.
`;` at the end.
The google map plugin doesn't honour defaults. I have to do them manually.
Move this to an external .js file so we can lint it.
If we're not checking for errors on file deletion, lets make these all parallel one-shots.

```
fileStore.remove( embedShell, function( e ) {
fileStore.remove( embedDoc, function( e ) {
res.json( { error: 'okay' }, 200 );
```
spacing before =
This div will need `data-butter-exclude` too. You can probably just set it on the div and not the img.
Doesn't look like `popcorn` is used at all in this file. Do you need it?
Why the extra variable `trackevent`?
I'm not really convinced that we need to mention anything mortar-specific. This is just a template that people will change to their own app, so we just need generic descriptions about stuff.
My intention was to have it reworded, to make it less prominent.
I couldn't get PATCH to work. I kept getting "More than one resource found at this URI." If you can get PATCH to work, I'd be game for fixing the docs here.
Also, shall we assert consumePaths.size() = resultSet.size() + 1
Appears we may have some inconsistency around the usage of escape_javascript and our i18n strings in this file both from the ones that appear to be added with this commit and lines 29-31 below.
What is the purpose of this `isForConnection` flag?
What is up with these target name changes?
These null returns are redundant. This one is unreachable as it stands.
Extended help to be more specific on bitcoind's implementation.
The magical numbers are arbitrary, but 75% network support before enforcing a "If you produce a v=2 block, then it must have heigh in the coinbase" and 95% support before enforcing "no more v1 blocks" feel reasonable.

You can get a sequence of version 1 block following version 2 blocks, there is no way to avoid that unless we think we can tell everybody to upgrade and start producing version=2 blocks at exactly the same time.
copying an existing const char* isnt more robust than copying its contents to a std::string.
I think no, and why?
it builds with an unbracketed if? anyway that is not something I want to pull.
Could you explain this change? I can't get to this on dev.123done.org so not sure how to verify it? It's using nth-of-type and so I'm wondering if there's a better locator to use here.
this was a mistake, will remove it
Deze variable is unused ;)
Niet beter om getMaximumFeaturedSequence() te gebruiken? Stel dat er morgen nog iets komt dat sequensen nodig heeft?
Could you please make the titles a little more consistent ? e.g. start with a capital letter, end with a period, and put a blank comment line afterwards.
good catch, removing
Yes, please do.  I started writing this stuff before I understood the casting behavior of traitlets.
On second reading, I am concerned with the code before and after my changes.  It converts an InterruptedException to a TimeoutException (previously, wrapping this in a RuntimeException).  Should we raise InterruptedException instead?
If we use CanCan then probably this part may not be required.
can we add a few more tests for completeness

to make sure both ? and  # behave the same way 

- 0
- "0"
- true
- false
- []
- {}
Slipping this into the Pull request.
I get that this is to have the "chosen" styles but you shouldn't be adding an overload of js functionality just to get some CSS classes...
oh littering the global namespace :)
Changing the text here has the implication that you plan on maintaining the instructions and making sure they work for Ubuntu going forward. If that's the case, that's fine. Just wanted to make sure you know what you're becoming responsible for.
This chunk of code is copied directly from Bug 809433, where Kadir posted the generated code from Survey Gizmo, which is why it is a mess. In particular, the div gets appended to the body as the last step on the next line, which is bad.

Do we want to try and prettify these ugly blobs?
no, they were the beginning of a different approach to write the assertions, but I went with specific gets instead of trying to do looping, etc.  removed.
Since every test needs a mocked logger, put here:  ``self.logger = SilentFakeLogger()`` maybe.
The only thing that makes me uncomfortable about this is if you have an accidental typo in the python expression. Then it might swallow the error. 
I'm sure you've thought about this a lot more than I have.
Hum finally it is not ready yet, it makes another test case (Session) failing because of a conflict, I'm going to try to find another way for having different names for request test case containers.
Please fix CS to match [Symfony2 CS](http://symfony.com/doc/current/contributing/code/standards.html).
If you want ``path`` to be the equivalent of the Twig function, the third argument does not make sense. And the name would be wrong. If you set ``$absolute`` to ``true``, you are not generating a path anymore.
ok thanks for the info
Actually, this does not change anything (I removed my initial comment because it was the wrong way to do it, and `true` is the default value).
You must do:

```php
<?php
if (!$this->headers->has('Content-Type')) {
    $this->headers->set('Content-Type', $this->file->getMimeType() ?: 'application/octet-stream');
}
```
BC break #3492
> owner?が目的語を取るのは違和感あり
なるほどー

owned_by がよさそうですね
I think it's fine it just does this User.find_by_email(blah) || Guest.find_by_email(blah) so both run.
насколько я помню задача была вобще не использовать эти кешированные каунтыри и показывать всегда реальное количество комментов.
Șterge-le, n-avem nevoie
Niiiice. Now I need to use RVM to test on all of these locally. Makes me glad I paired with Wayne on that back in the day (not that he needed the help!).
Vacuum also in a seperate commit for #2974
(non-essential)
Do we really want this on a separate line, and with the trailing comma on the previous line?
Should this only yield ```.py```/```.so``` files?
See test_linear_ring.py:31 for my preference.
nit: technically we should align this with the prev line. We could use a multiline string to make it look like you want:
```dart
var doc = parse('''
    <body>
      <script>...</script>
    </body>
''');
```

(same thing below on all the other tests)
Fixed up this if.
what does the sv class do?
If the connection is in use (caller did not close), but validate is true, this will leak
Needs removal.
Can't you use `item` here?
если я правильно понимаю, то колонки user_id, ref_user_id и remark_text не могут содержать NULL-значения. Надо их тогда и объявить как nullable="false"
хм. тут подумать надо, куда сохранять.
You don't need this scope
oh yeah, last minute syntax error. that's a heads-up I should go on vacation right now! ;)
What will it do at other resolutions?
+1. Make sense. I've modify the CSS from display 'none' to 'block'. Thanks!
Delete selected will 'erase' the messages from the view, but not from the model (that's what the 'Done' button will do. It's a kind of undo functionality. In case that we press the 'X' instead of 'Done', no messages will be deleted from DB and will be shown in the view next time you enter the thread.

Instead, the Delete All will fire a confirm window. If the user chooses indeed to delete the messages, they will be erased from view and model, and the app will move back to thread-list window
You are matching the same element with two selectors, why?
Also it seems like editContactButton.removeAttribute('disabled') is duplicated?
`sb-i` are for applying CSS sprite rules. I need them on a class instead of id to test the icons on `icons.html`
So you want to add https://bugzilla.mozilla.org/show_bug.cgi?id=714357 next to this comment.
FFOS -> Browser OS
You likely want to not create variables for those and use them directly.
same.. no l10n?
break up line
Why `AUTO_INCREMENT=1003`?
Can you make a note of that on my repo? I'll make the change there.
I usually like to group the import vs. from and then list by alphabetical order, but grouping by system vs. custom imports is fine too.
I still don't understand what it gains from cycling through 8 similar yet different sequences instead of just using one. But maybe you can explain that to me in person later!
What's the replace here for?
s/見てみてください/参照して下さい/
a line break after the = would probably be fine.
this probably belongs in the ``spawn``/``launch`` module
Yes. Your code try to remove/rename install folder every time someone request some page in the site because of preload.
Even after the install folders have been removed/renamed, your code works again and again.

    if (LEGACY_INSTALLERCHECKER_ACTIVE == true && is_dir(XOOPS_ROOT_PATH . "/install")) {
        $this->remove_install_folder(XOOPS_ROOT_PATH . "/install");
        $this->rename_install_folder(XOOPS_ROOT_PATH . "/install");
    ...
Erase this line.
Was not suppose to be a comment but rather a section. Made it look like such.
This looks like you're appending to a global. Should you consider using a lock to prevent race conditions?
In ArchiveLink, wouldn't it be better to collect all values and send it to Redirect afterwards?
```
Redirect.to 'search'
  board:    board
  name:     threadID
  email:    threadID
  subject:  threadID
  filename: threadID
  md5:      threadID
```
...sounds a bit silly.
As far as I can tell, the message isn't visible anywhere. The console and debugger both seem to just get the string "Uncaught #<Object>".
Ok, fair enough, just moved it.
Doesn't `wantData` imply `wantMq`?
My bad, I didn't know about that.
please use lowercase for booleans
why commenting the old code ? The versionning is done by git, not by comments
Should be `if (...) {`
Don't use `is_null()`, use `empty()` or `isset()`
I don't know. Is there? Those issues are very specific to IE7, so I don't know how to handle this in other ways...
>Default value for issues_enabled (and some other) is TRUE, but if I pass the nil - it will be FALSE.

Like I already said, you don't need to pass a parameter, unless want to set attribute value.

>I think this is wrong behavior.

No, because any value (except `false`, `0`) will set these attributes to true.
https://github.com/gitlabhq/gitlabhq/blob/master/db/schema.rb#L107
dont' understand this change.  Where is the code being replaced?

If we're just commenting it out, lets get rid of it.  No reason to keep commented code around.  Just creates confusion as the code-base changes.
We should validate the algorithm is available here and that the validator works.
are these changes congruent to the sdh hardware driver? do we need to change the cob_default_robot_config files for the sdh for all robots?
El 05/12/12 21:46, Brian E. Granger escribió:
>
> In converters/reveal.py:
>
> > +        return u'\n'.join(lines)
> > +
> > +    def save(self, outfile=None, encoding=None):
> > +        "read and parse notebook into self.nb"
> > +        if outfile is None:
> > +            outfile = self.outbase + '_slides.' + 'html'
> > +        if encoding is None:
> > +            encoding = self.default_encoding
> > +        with io.open(outfile, 'w', encoding=encoding) as f:
> > +            f.write(self.output)
> > +        return os.path.abspath(outfile)
> > +
> > +    def optional_header(self):
> > +        optional_header_body = [\
> > +'''
> > +<!DOCTYPE html>
>
> Let's put the HTML code in a separate file and read it in. That would 
> allow us to use jinja2 to template over variables if we need to.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/ipython/nbconvert/pull/63/files#r2329548>.
>

I agree with you, I will separate them.
@webcoyote 

Would the following perhaps be safer?:

   Config::CONFIG['host_os'].include? 'mswin'

It may prove to be safer to go with a system flag such as this over a mutable environment variable.
`"use strict";`!!!!!!!!!!!!! :)
I can't see this really called out in the spec either, but I can see a lot of use for it. Perhaps a slightly contrived example that I'm thinking of might help. There is a webservice that I was to expose as an API. I want to return a promise that fetches the JSON from a particular query, but I must also do a request to find out what version of the webservice is currently in use. I can do that simply as:

```javascript
function getJSON() {
  return request("api/version").then(function(text) {
    if (text == "1")
      return request("api/1/lookup");
    else
      return request("api/2/lookup");
  });
}
```

There are certainly other ways to do this, but I can't immediately see any that end up as elegant.
Please do not overload arguments variable with something else!
my mistake - i see that this is redefined in static/shared/javascript-extensions.js
I imagine it can. I can add a try/catch in the routes, with a log. I think the exception is worth showing in full when running `scripts/compress`, though.
I think this line should perhaps be moved into an "else" clause on this try/except block, though it doesn't matter much. In general better to limit the "try" clause to only statements that you expect might raise an error, and put additional "if no exception was raised" statements in the else clause.
I initially attempted to use PyPI by adding `oauth2==1.5` and it failed to recognize the version number.  I used the version number found in vendor/oauth2/_version.py maybe that's the wrong one to use? I'm not familiar enough with PyPI to effectively troubleshoot and the github version worked for me.  If you know of a better way to do this please let me know.
Rather than this method, why not just have `ProjectCommandBase` also use a `handle_project` method that receives the project as an arg? Seems to make just as much sense here as it does for `ProjectBatchCommandBase`, makes it a bit simpler to use.
Does this need to be thread-safe? Because as it's implemented here, it isn't particularly
I'd say "When you add a backlog URL no bugs will appear immediately, but you should see something within 10 minutes or so."

Something like that. You don't have to do the manual refresh when you first add it. The new URLs get picked up by the cron on the first run after addition.
Hey Pavol, is that necessary to build whole Sandbox?

Isn't it possible to select just bootstrap?
not crazy about having the label value being maintained in the plugin. You should keep an object for lookups outside of this plugin which you then translate to. So for example, you would provide an array to the typeahead, if it matched "@fat" - you would use that value to lookup `{ "@fat": "jacob thornton" }` when processing your form.

You don't want to do all this extra work inside the plugin itself - unnecessarily complicates things.
I thought the point of this PR is to return the object after hydration?
Apart from animation, there's nothing a GIF can do that a PNG can't do more efficiently. :)
Fix indentaion, probably a tab instead of spaces
``markTestIncomplete`` would be more suited for this case
IMO you can easily use here ``$bundle->getPackagistUrl()``
reverted however in real deployment it was the problem
Yeah, we talked about this and I said same. Which not change anything and this migration is useless =)
Yes. That is a bit specific to data tables. I could not think of an elegant
way of creating a hook for that.

On Thu, Jul 5, 2012 at 4:30 PM, Egil Möller <
reply@reply.github.com
> wrote:

> > @@ -153,14 +153,20 @@ linestylefilter.getLineStyleFilter =
> function(lineLength, aline, textAndClassFun
>
> Hm, wouldn't this have been possible to hookify? "data-tables" sounds
> very... table-support-plugin-specific?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Pita/etherpad-lite/pull/843/files#r1108951
>
Two for the price of one :P
Sure, I just find it disgusting to have to wrap lib code that is only meant to be used on the client.

What if I want to use jQuery, do I need to wrap that too with `Meteor.is_client` ?

There has to be a better way. If not, I will bring it up on their support.
->

```js
$('#main, #footer').toggle( !!this.get('total') );
```
Hmm, I guess you can't fold it in since it's overwriting the base assertion. But place it next to the implementations for those other properties, since it's so closely related.
No, you should just have:

```ruby
before_filter :store_location
```

and then have:

```ruby
skip_before_filter :store_location
```

in places you don't actually want to set that value.
CS issue: the curly brace should be on its own line
Yes, much better.

On 28 Mar 2012, at 18:41, sgilda wrote:

>> 
>>             mvn clean package -s PATH_TO_QUICKSTARTS/example-settings.xml
>> -
>> -          For JBoss AS 7 or JBoss Enterprise Application Platform 6, Maven user settings configured: 
>> +    * For JBoss AS 7 or JBoss Enterprise Application Platform 6, Maven user settings configured: 
> 
> Is this OK:  For JBoss AS 7 or JBoss Enterprise Application Platform 6 (Maven user settings configured)
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/167/files#r616476
I added more tests in a separate branch
Better set validity even if minCount/maxCount is not defined...

ctrl.$setValidity('min', angular.isNumber(minCount) ? values.length >= minCount : true);
ctrl.$setValidity('max', angular.isNumber(maxCount) ? values.length <= maxCount : true);
Yeah, this is one of those weird cases of porting a preexisting bug. But, I may as well go ahead and fix it now, so that commit will be forthcoming.
Great, that works!
do we still want to be using the R-word?
I think all you're missing is setting the rs pin to HIGH prior to sending each of these commands. See https://github.com/arduino/Arduino/blob/master/libraries/LiquidCrystal/LiquidCrystal.cpp#L251, it is using the `write` method which calls the `send` method with a mode of HIGH. 

I'm not in a good place to try this out, but I will be in a few hours.
Why aren't the ruby racer traces good enough?
One more second here leaves time for 100 ticks on the kinetic scroller timer, so a displacement of 100*101/2 = 5050 pixels.

That increase could be made dependant on whether kinetic scrolling is enabled or not, and adjusted on the current displacement speed. But that would be better done after the event handling is moved here rather than in the surface.
While several older translators contain this code, it's not necessary. Just pass ```null``` to ``doc.evaluate()`` in place of ```nsResolver```. You may also find it easier to use the [XPath helper functions](http://www.zotero.org/support/dev/translators/coding#utility_functions) instead of ```doc.evaluate()```.
thank you very much ! Have four search engines is very strange.
ACK, fixed
... As for processing, it still needs some work to do, so for now its status is "until nothing better is done"
The first two sentences don't really mean anything
lol, yes it must have required some fiddling. No it's not very readable as a one-liner imho.
Missing phpdoc file header (see ezcache.php for instance)
You meant parenthesis.
Also I'd say use an early return here

```php
<?php
public function convertToPHPValue($value, PlatformInterface $platform)
{
    if (!is_resource($value) && ($value !== null)) {
        throw TypeException::conversionToPHPFailed($value, Type::BLOB); 
    }   

    if (is_string($value)) {
        $filePointerResource = tmpfile();
        fwrite($filePointerResource, $value);
        fseek($filePointerResource, 0);
        $value = $filePointerResource;
    }
    
    return $value;
}
```
I sure wish we could have Lady MacBeth freaking out here or something.
info-\>statusVertices[v]  в переменную
Just a minor style point again - generally, ERB templates look nicer without using parentheses to denote arguments, but if you **do** use them, them there should not be a space between the method name and the parentheses.
Well, I used to set it when I was a starry-eyed kid who dreamed of the days of XHTML 2.0.
We probably only want to do this if extra exists.
I think most calls would be something like `Config.getConfigValue`, so perhaps the original `getValue` is slightly cleaner?
Please add the appropriate spaces. Is there a way in which we can move the time measurement to the Telemetry module? I suspect not, but I wanted to check.
Would be good to explicitly set the default for limit here.
@stuartf : I'm tempted to say that the sorting should happen inside of the getAvailableOAEModules function. In there, we walk through all of the folder and might as well retrieve all of the package.json files and return the modules in priority order. This would also allow us to move the readFileSync out of the sort function.
I can definitely turn the trait into an abstract class (and I'm doing it because it has advantages on its own, i.e., less classfiles). Though, I don't see how I can lift ``global`` into a contructor argument. The issue is, how do I correctly tell the compiler that the ``global`` type in method ``findTestClasses`` and inside ``JUnit4TestClassesCollector`` is the same? 

Basically, how do you express the following

```scala
object JUnit4TestClasses extends JUnit4TestClassesCollector {
  val global: comp.type = comp
}
```

if ``global`` is passed as a constructor argument to ``JUnit4TestClassesCollector``?
The repositories must be available. The zend packages use her own packagist.
If you removed it, composer will search on http://packagist.org, and found the wrong package :)

BTW: Have you tried to install only `zendframework/zend-http` package? 
Composer should automaticly install all other packages.
Will do. I wanted to make a debug flag to stop execution just before sending the job to EMR. However, that will be part of a different pull request. The comments need to go!

On Feb 23, 2012, at 6:02 PM, Steve Johnson wrote:

>> @@ -1560,6 +1662,9 @@ def _launch_emr_job(self):
>>         # define out steps
>>         steps = self._build_steps()
>> 
>> +        ## SHIV DEBUG
>> +        #exit(1)
>> +
> 
> Remove please :-)
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Yelp/mrjob/pull/378/files#r483551
Согласен, невнимательно писал.
очень понравилось как Вы реализовали элементы ДНК.
в задании говорилось, что precentage должен задавать кол-во в процентах от длины. Конечно в данном случае при длине = 100, всё будет норм. Но вообще... понятно что я пытаюсь тут понаписать.
Ну разве что с эстетической точки зрения =)
@iamqq вопрос интерпретации обсуждался, и интерпретировали уже предельно ясно - менять строго х %, каждую ячейку можно менять только один раз, то есть ТУ ячейку, что уже участвовала в замене, использовать нельзя, так же нужно менять **случайные** элементы. Тот вариант, что вы привели, даст только первую случайную ячейку, остальные будут за ней. 

Я не проверяющий эту работу, однако критерии выложены предельно ясно, и обсуждались на проекте.
CS: Newline at end of file
`getTimGroupNames()` or `getGroupNamesForTim()`?
If would make this more readable if this was

    if (chunk && '' !== partial) {

But even so it doesn't make sense. `chunk` will always evaluate to true, because it'll be a buffer, even one of length 0 will evaluate to true.

And please use type strict comparisons `===` and `!==` unless for the unique case where you're checking for `null` or `undefined`.
tip: if you don't access these classes outside of the package it's better to not have them public.
直接打到命令行不好吧? 感觉日志应该是标配？
This change is way too big
"tvrip" is commonly used on BTN for user-capped content, so non-scene stuff. Since the scene should not use this, I don't think adding this would be a problem?
@N3MIS15 not sure what u mean man. I have been trying to reproduce the problem but it seems to work as expected. Maybe I just dont understand the problem?
You should be able to use plain Mockito here: Mockito.when(Context.getMessageSourceService()).thenReturn(as);
Why is this visible?  See the original commit, where it is not visible: https://github.com/openmrs/openmrs-core/commit/6d482f2613b8e969fbd600ca541e40055cd25d8f
It's basically:

 If we are not in a SSH (remote) session or if starting the multiplexer in a SSH (remote) session is enabled
 and, if the multiplexer isn't started and if auto-start is enabled.
yeah, all doc links
Capitalize "Extension" and "Class"
It's an attempt to cover all bases. If your console commands running other php scripts that use emit colours and Windows is not setup for ANSI, you will get  ugly ANSI escape characters displayed with 100% certainty. I use Windows as my development environment so I'm very familiar with this phenomenon:. There is no might, it's 100% sure you will get ugly characters displayed. The point of this note is make it clear that while the Console command has control over what it emits and can detect whether colours are available, it has no control over vendor PHP scripts you might run in the console and makes it crystal clear that Windows must be configured to use ANSI.

Without ANSICON, if you force --ansi for the Console, it will also display garbage ANSI escape sequences. It's up to you - this is about clearly documenting a phenomenon so you can refer to it when you inevitably get github issues being opened by those who do not know about the problem.
"通过"没有必要翻出来。
Of course. Just a stupid C&P error while merging two configs.
The inner copywriter attacks!

```java
/**
 * InMemorySessionStore is not meant to be used in production systems.
 *
 * It is a persistent in-memory session store for testing and performs badly in
 * long sessions with lots of messages.
 *
 * It stores each message going through it for duplicate message identification
 * purposes. Because of this, it will eventually run out of memory and, while doing
 * so, get slower as it compares each message going through it against all stored
 * messages.
 */
Sorry @qiangxue , that's a really serious error :( .

I thinked the method in the way that when you use default value as null, the default value is disabled, so the resulting string is that user puts... an empty string.

Another way to doing this is using as `$default` default value an empty string and strip the `&& $default!==null` condition.
Since errors were swallowed. Now they are reported as failure.
Alright, thanks for reviewing.

-- 
At.
Carlos Antonio


On Saturday, March 3, 2012 at 3:17 PM, Piotr Sarnacki wrote:

> > end
> > 
> > def self.references(attributes)
> > - references = attributes.map do |key, value|
> > + attributes.map do |key, value|
> > 
> 
> 
> I don't think that's something that should block that PR, just saying that it feels less readable, minor thing anyway.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/rails/rails/pull/5255/files#r514884
> 
>
$sender and $params should be null per default to be compatible to CEvent constructor.
lo arreglo tb. De tanto probar  me equivoque  seguramente
Al parecer no, porque anda bien
It's the same, the only thing changed here is name, so that it appears that it's for both promotion and deletion.
Ok, I have little understanding about locks and concurrency, but the intention here is to have only 1 PROMOTION or 1DELETION at  one point of time.
Good point re. being DB-agnostic, didn't even think about that, d'oh! ;] ILIKE is still Postgres-specific though, isn't it? http://www.postgresql.org/docs/7.3/static/functions-matching.html 

However I see your point about ILIKE being better because it'll use the indexes. Not much of a Postgres expert, myself. ;]
Even if you could get that to work, say with a `@page` ... I think it'd be hard to follow where exactly `@page` came from, so I wouldn't
You have to use the dialog like this : 

```
                {% set alert_message %}
                    {% trans 'prod::thesaurusTab:dlg:Acceptation en cours.' %}
                {% endset %}

                var alert = p4.Dialog.Create({
                    size : 'Alert',
                    closeOnEscape : true,
                    closeButton:true,
                });

                alert.setContent("{{ alert_message | e }}");
```
That's where I changed the code.
> As a result OGM is no longer supported or developed and is formally discouraged by Xiph.org.[18] Today, video in Ogg is found with the .ogv file extension, which is formally specified and officially supported.

I think that OGM isn't necessary. Do you need it?

Wiki says 

> Filename extension	.ogg, .ogv, .oga, .ogx, .spx, .opus
:+1: i'm a fan of a mocking/stubbing library, mocha is a good one. I'm actually :-1: on shoulda, not a big fan, though it's been awhile since i've used it.
The page_start method returning the filename for background image is just an ugly hack and shortcut, there should definitely be a better separation of concerns
This explicit destructor instantiation is required to obey our layering; PrerenderHandle::m_prerender is an OwnPtr<Prerender>, and PrerenderHandle is an instance of RefCounted.  Without this empty destructor here, no caller could drop a reference to a PrerenderHandle, since they can't use the Prerender.h header (as it includes from platform).  I only write this here because it was an interesting learning experience about our layering to realise it.
`fields_for_params` is only called by `hidden_field_tags_for`. We don't expect end-users to call `fields_for_params` (unless they are doing some significant monkey-patching!). Anyway, other parts of the code use the idiom of transforming the argument into an array, like in https://github.com/gregbell/active_admin/blob/master/lib/active_admin/helpers/optional_display.rb#L35. I'd prefer that approach to two independent conditions for `except`.
@sachin87 Up! :)
And this one :) and the one below :)
The whole point of the models' data() method was to change objects to a dict for use in mulitple ways. Can we revert this back and call the data() method plz? I guess i dont feel incredibly strongly either way honestly as long as we are consistant. I think that if we are using database backed models they will come thru as maps, or maybe im wrong :D
i think this should be `self.device` instead.
I'm a bit weary of having another map of key to size, instead of having specialised cache entries that take size, which are stored in the given data container. The latter option would be more memory efficient.

Besides, I'm a bit concerned about the concurrent update safety of this collection.
Ugh, my bad here.
Yeah, it'd be great to remove this guy too. :star:
I did not see a section  for changes to v1.2.x. Should I create one and migrate that snippet to the new section?
The only problem with this (and the fix that I implemented), is that the result of transform *could* be ```NaN```/```Inf```. It could be fixed in this PR, or we could do it for 1.3 - I will leave that call to whomsoever merges this PR.
Point taken. I'm not really sure what to do in that case.
Oh I was thinking of refactoring the datad assignments into a single dictionary too.  These sorts of OCD formatting are welcome? :)
Thanks! Last minute change I forgot about!
I suggest adding in the docstring some example code or a embedded plot directive link to an example that shows how to use this with fill_between
Fine to leave it as is.
Looks like it’s 5.
I agree, we need some coding standards documentation ...
Not relevant for me personally but true enough. The example given I think would be trivial to resolve by copying and extending the regex to include comments but then there's more to consider if the comments are arranged as so:

```
// for io stuff
import java.io.*;
// for net stuff
import java.net.*;
```

The above couldn't even be remotely accounted for in how it's currently done.

Eclipse doesn't handle this very well either when organizing imports as I just tested.  Whether the comment is at end of line or on it's own line, it ends up at the bottom of all import statements after organization, which is only slightly better than the comment disappearing completely.
Superfluous but it's fine :-D
Sounds better yes. I'll take care of that.
@gsilver missing space before `{` + we should use `on` instead of `live`
@jsloane Can we use 2 separate lines for this?
Just in case we get more pulldowns in the future, it's probably a good idea to add the menu's id here
Are you sure you want to override the parameter ``$lifetimeField``? This often makes code less readable.
Ok, so the actual cleanup occurs if using the memory backend & the test property is true.

Does the test server need to do anything to the vnodes to make them aware of the backend clear?  See the reference to this more invasive reset method that recently had to be updated for riak 1.1 ... https://github.com/randysecrist/ripple-contrib/blob/master/test/support/ripple_test_server.rb#L119
When using multiple dot's it is probably easier to just leave out the subview and don't remove it when there are 0 dot's to display..

    if([[marks objectAtIndex: row * 7 + column ] boolValue]){
        self.dot.text = [self stringWithMarks:[[marks objectAtIndex:(row*7+column)] integerValue]];
        if ([self.dot.text isEqualToString:@"*"]) {
        	CGRect r = self.selectedImageView.bounds;
        	r.origin.y += 17;
        	self.dot.frame = r;
    	} else {
    		CGRect r = self.selectedImageView.bounds;
			r.origin.y += 13;
			self.dot.frame = r;
		}

	    [self.selectedImageView addSubview:self.dot];
     }else{
		[self.dot removeFromSuperview];
	}

then becomes:

        self.dot.text = [self stringWithMarks:[[marks objectAtIndex:(row*7+column)] integerValue]];


which is quite nice, isn't it ?

This can be done in 2 pieces of code (old line numbers 414 & 518)
Qual é o problema com ele? 

getattr(dict, attr) não functiona na verdade, tem que usar dict.get(attr, default) para fazer o que você queria mas aí não pode validar argumentos extras, que estou fazendo nas linhas 166-167 aqui.
Bad formatting (need to insert spaces)
it just checks if there is a `#` right.. so that would be for the color.. does it always return a hex code, even if it's set with rgb?
Is this a default /etc/tmux.conf from an OS package? Generally we prefer to drop off the default from a package since it will be least surprising to users.
I don't think so, as I haven't received any feedback from it. But they are not ran as well as these above :)
yup that too
и здесь аналогично =)
Sorry, my mistake. :)
Why you name result of `objectify` once `tree` and other time `data`? It should be the same.
No, use `EmbeddedListField`. Comments are embedded in list!
The thing is I dont really know which exception I am suppose to catch. Well I know that it is username already exist, but I dont know how to define it.
right, we need it before not now.
I don't understand your last sentence. Where and what should I check?
Made the change. I am running this in set up though. I can move them into the individual methods if thats what we want.
Screwed up newlines?
on retail a DND player should always receive whispers no matter if its a GM or not. And this is what the patch does. It removes the strange restriction to block whispers while being DND. The check you are talking about previously excluded GMs from those blocked whispers but that is obsolete now.
First I called the loader from the custom section, but I was told to move the call to another section. So I created a new commit and forgot to restore the original content. I'll fix it.
No, AfterHit is called once for every target, you are mixing it with AfterCast (and GetHitUnit will not return null here)
not?: if (!isWorldBoss())
I am not sure if I get you point here. We passed to this feature extractor
two arguments, jcas and word token. I tried to find for this word token if
it is a predicate or an argument. I cannot see how you link your way to the
target token. Please give me more hints. Thank you!

Best,
Chen

On Thu, Aug 30, 2012 at 8:40 AM, bethard <notifications@github.com> wrote:

> In src/main/java/org/apache/ctakes/feature/extractor/SRLExtractor.java:
>
> > +import org.cleartk.classifier.feature.extractor.CleartkExtractorException;
> > +import org.cleartk.classifier.feature.extractor.simple.SimpleFeatureExtractor;
> > +
> > +import org.uimafit.util.JCasUtil;
> > +
> > +
> > +import edu.mayo.bmi.uima.core.type.syntax.BaseToken;
> > +import edu.mayo.bmi.uima.core.type.textsem.Predicate;
> > +import edu.mayo.bmi.uima.core.type.textsem.SemanticArgument;
> > +import edu.mayo.bmi.uima.core.type.textsem.SemanticRoleRelation;
> > +
> > +
> > +public class SRLExtractor implements SimpleFeatureExtractor {
> > +
> > +	@Override
> > +	public List<Feature> extract(JCas jCas, Annotation focusAnnotation)
>
> Iterating over the entire CAS for each focus annotation is probably a bad
> idea. Is there any reason why this couldn't have been written something
> like:
>
> for (Predicate predicate : JCasUtil.selectCovered(jCas, Predicate.class, focusAnnotation) {
>   return Collections.singletonList(new Feature("Predicate"));}for (SemanticArgument argument: JCasUtil.selectCovered(jCas, SemanticArgument.class, focusAnnotation) {
>   return Collections.singletonList(new Feature(argument.getLabel()));}
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/bethard/ctakes-temporal/pull/1/files#r1496084>.
>
>
in strings.xml verschieben.
Ja, warum nicht...
Seems like this script is basically just a wrapper around `rails new` with the convenience of rvm and gemset management. I think I'd prefer to manually create my gemset and use the template with `rails new` directly. I suppose I could still do that, but I suppose I'm just not seeing the benefit of this wrapper script.
> Often The best option is to store the index in wathever NoSQL database you are using
It would be nice if you could move all versions to the <dependencyManagement> section in the parent pom: so we have a guarantee of consistent versions across all modules and a single point to define them, but more importantly it's the only place in which you get a good guarantee from Maven about which version it will actually use.
ipset module is not load by iptables
Great; will do
The `onResourceRequested` callback has an `id` property. I reckon this would be a more resilient way of tracking that correct request. Also, I don't think this code will work properly for subsequent page loads. E.g. if you do:

``` ruby
visit '/'
click_link 'foo' # the status may not be correct now, because `open` was not called
```

I wrote this phantomjs script to play around with the callbacks:

``` js
page = new WebPage()

page.onInitialized = function() { console.log("initialized") }
page.onLoadStarted = function() { console.log("load started") }
page.onResourceRequested = function(r) { console.log("resource requested: " + r.id) }
page.onResourceReceived = function(r) { console.log("resource received: " + r.id) }

page.open('http://phantomjs.org', function() {
  console.log("finished")
})
```

Here's the output:

```
resource requested: 1
load started
resource received: 1
resource requested: 2
resource requested: 3
resource received: 1
resource received: 2
resource received: 2
resource received: 3
resource received: 3
initialized
resource requested: 4
resource requested: 5
resource requested: 6
resource requested: 7
resource requested: 8
resource requested: 9
resource received: 4
resource received: 4
resource requested: 10
resource received: 5
resource received: 5
resource received: 10
resource received: 10
resource received: 7
resource received: 7
resource received: 6
resource received: 8
resource received: 8
resource received: 6
resource received: 9
resource received: 9
finished
```

I think what you can do is this:

* Always store the last `id` from `onResourceRequested`
* When `onLoadStarted` is called, store the last id from `onResourceRequested` in the separate variable
* Then, match the id and update the status in `onResourceReceived` (or deal with redirect, as you are doing)
`console.log( x );`
There's nothing specific to reducers in this class. s/ReducerHeartbeatThread/TaskHeartbeatThread/g
You can read the code below to see what happend in __new__.
It is to provide commands and autocompletion method for the Cmd module.
My spacing in the IDE is wrong, I will fix it.

About Zoom limitations: I think that some times it is usefull to zoom out little bit to see more on the screen, but more than 0.5 would be too small. Also double tap on the screen zooms first in and then out to 0.5. Do you think it shouldn't be still 1? 

In some other browsers, there is pinch zooming out, but after releasing pinch it will zoom back to screen width. That would be quite easy to do. 

And what about maximum zoom, I set it 10, should there be limitation?
Better have a single t() -- it's easier for translation.
I'd insert this in name order.
Does our own `addClass` not work there?
calling this variable 'scheme_offset' might be clearer
And now I become doubtful ;-). It's only use is in a commented section in QSObjectCell. I think it might have been an attempt to modernize display of object by creating a real formatter. What do you think ?
This is going to be a problem. If you run init with completion available then turn off completion, `fasd` should fail. You should check the availability of completion in the fasd code using `if (( $+functions[compadd] ));`, alternatively, you can create a _fasd completion file and the init code can add the fasd completion directory to `$fpath`.
this looks funny...
Should these maybe just refer back to the description of the constructor's parameters to avoid redundancy?  

Also, it looks like the two descriptions have already gotten out of sync with each other.  e.g. here they point out the None option and mention that the returned grid should have the same shape as the input grid.  So better to make the text what we want in one place and have this function just refer to that.
https://github.com/GalSim-developers/GalSim/issues/190
Yes.  But again, no need to mention that in the QuickReference I think.
Fine, I just couldn't remember what we decided.
I was referring the email.

I think that both profile should be exported, but as far as I can remember, you can't setup two material in max, so what would you export?

I haven't wrote that code. I'll ask the guy that worked on tomorrow.
mkdtemp creates the whole dir path, not just the name like clib functions do (I think)
and set this only if [ -z "$BROOKLYN_HOME" ] ?
That should be 127.0.0.1
This syntax is for variable assignment. You should change `=` for `:`

```
checked: false, options: {}
```
Any reason for not supporting specifying safe and fsync? (the fsync check is done 2lines below but is skipped when safe_pp is string)