labofsahil/github-event-dataset-2012 huggingface dataset:
What's the reason for switching those back? I thought this bug was about throwing too many non-GridFS exceptions?
Besides the tag_count, we should also add the tags themselves - makes it really useful to debug this.
Why is the ordering here significant?
ups, that was plain wrong before, thanks for fixing!
If the user puts a bad value in the `timezone` cookie, doesn't this throw an error?

And while I appreciate not looking up the profile for every view, maybe we could stick the timezone from the profile into the session when the user logs in, instead of relying on a cookie.
Have you fixed this yet?
How can _filter not be 'none' here?
I think these 2 constants are not defined in anything before ZMQ 3.0. I guess that's why they were put in numerically. An #ifdef may make sense here. I did the same thing in https://github.com/JustinTulloss/zeromq.node/pull/162/files for the ZMQ_LAST_ENDPOINT option.
get rid of the author tag;
add some JavaDoc on this emun and it's values
what about unicode?
А потом оно в catch перезавернётся в FormatterException?
Если в конструкторе DataInputStream произойдёт исключение, файл останется открыт.
Приватные поля суперклассов тоже хочется получать?
this is just to be consistent with the rest of the unit tests.
we try to use symbols in all configs, let's just stick to that here, no need for both.
I saw this "uber-jar" expression on Weld documentation http://docs.jboss.org/weld/reference/1.1.0.Final/en-US/html/environments.html#d0e5259.
why are we passing in the template size for the map size?
If the selection is supposed to always be the same as the inspector's, it would be more explicit to make `selection` a getter that fetches the selection from the inspector, I think.
Without the .initialize method .getDataFolder() will be null.  Therefore it would throw a NPE immediately upon the SpellLoader starting.
Why did we change this to contains?
@joshmoore Probably that fits in here: http://trac.openmicroscopy.org.uk/ome/ticket/7782
Should the following section be formatted as a table?
I recall `apt-key` requiring python-software-properties be installed, no issues when testing? Possible you install it prior to running this?
expectation-maximization (EM).
> Yes, because some people like to run tests as scripts.

and also it allows you to test your install
In a recent patch, if `n_ouputs==1`, then `classes_` is enforced to be flat.
moche
je verais plutot pythran_long(v) tout le temps
закоммітив випадково
If you could rewrite this, would you have consolidated the before/after observer logic into a setter? I feel like this might be a little too verbose plus it feels awkward to use `ember_assert` after it's already set even though it still works as intended.
I don't agree with this. Why do you want to open this port up on the appclient? This port is used for remote naming and remote EJB's, neither of which is applicable for the appclient.

Also it is not secured, which goes against our secure by default policy.
Please, some comments for what these variables represent.
Is there a Jira for this? I only see TIMOB-9307, but that can't be it.
Same comments as for the _decodeURIComponent function
"require: false" is a good idea for webmock whatever group you're requiring it in. In my experience it's the sort of library you always want to require explicitly.

But why is this group development and test? It looks like a set of gems we only want when testing?
If you say so... :P
As mentioned iteration on these elements is extremely critical for performance; HotSpot will be able to inline and optimize to a certain degree of complexity, but not more.

Looking at this and how often the conversion is needed, I'm wondering why don't we store it all in radians?
It seems to me it would simplify a good bunch of formulas as well.
you seem to be assuming this xpath will always be valid and lead to something, what if queryPropTree returns NULL?
I know, I'm talking to Gavin about this...
Oh, no. It's shadowing another... I wouldn't do that... I know it's ok from a language point of view, and saves a few lines of code, but it confuses a lot.
@richardkchapman please can you give a second opinion on this function.  I don't think either Jake or myself are very confident about what it should do.
Benefit of clearing this last unneeded msg buffer?
yes not a lot of benefit, wanted to make clear it wasn't used more than anything.
I just committed a patch that renames all formats' release_all() to done()
It saddens me that we call the variable with a singular name. I know the damage is done already in the view function. However, you could make it less worse by calling it `product_versions` at least here as it gets used in the template.
I don't know why you have upgraded us. Is there a particular reason?

If not, change this back to a57795255065fd1a6cdd6e5f25fb93cf4a1bd9f9. I think you can use:

```
$ cd vendor
$ git checkout a57795255065fd1a6cdd6e5f25fb93cf4a1bd9f9
$ cd ..
$ git submodule update --init --recursive
```
I'm not sure, should we use `that` instead of `this`?
Yes, I will do.
yeah, but why keeping ``$fs`` ?
Shouldn't the first check be if this airspace is by NOTAM or by AUP?  So move these checks to the beginning of this function?
Remove this whole directory from the repo.
Not yet supported on this PR.
Just as with `EmailLinkColumn`, value needs to be HTML escaped.
Because ... I'm an idiot and didn't think of that? The timeout will always be wrapped in the CHE, so I fixated on detecting the wrapped one. You're right, we don't need to care about what it's wrapped in. I'll take out the FSM, things just got a ton simpler, thanks!
I haven't really grasped that code, but comparing the diff where that code
was introduced, maybe should it use lookup_value?
https://github.com/django-nonrel/djangotoolbox/commit/70407c6032c540a5ace097d72e8c8d9baee542e8#djangotoolbox/db/basecompiler.py


On Tue, May 1, 2012 at 11:14 AM, Jacob Gur <jacobsgur@gmail.com> wrote:

> You're right. I glanced at it very superficially, and assumed that was the
> problem. Here is the error I get when doing a query count of the following
> filter:
>
> models = MyModel.objects.filter(id__in=modelIds).filter(outDt__isnull=
> False).filter(outDt__gt=inDt)
>
> models.count()
>
> ---
>
>   File "/Users//Documents/workspace//src/django/db/models/query.py", line
> 336, in count
>
>     return self.query.get_count(using=self.db)
>
>   File "/Users//Documents/workspace//src/django/db/models/sql/query.py",
> line 401, in get_count
>
>     number = obj.get_aggregation(using=using)[None]
>
>   File "/Users//Documents/workspace//src/django/db/models/sql/query.py",
> line 367, in get_aggregation
>
>     result = query.get_compiler(using).execute_sql(SINGLE)
>
>   File
> "/Users//Documents/workspace//src/djangotoolbox/db/basecompiler.py", line
> 360, in execute_sql
>
>     count = self.get_count()
>
>   File
> "/Users//Documents/workspace//src/djangotoolbox/db/basecompiler.py", line
> 421, in get_count
>
>     return self.build_query().count(high_mark)
>
>   File "/Users//Documents/workspace//src/djangoappengine/db/compiler.py",
> line 68, in _func
>
>     return func(*args, **kwargs)
>
>   File "/Users//Documents/workspace//src/djangoappengine/db/compiler.py",
> line 140, in count
>
>     return len(self.get_matching_pk(0, limit))
>
>   File "/Users//Documents/workspace//src/djangoappengine/db/compiler.py",
> line 323, in get_matching_pk
>
>     self.matches_filters(result)]
>
>   File "/Users//Documents/workspace//src/djangoappengine/db/compiler.py",
> line 346, in matches_filters
>
>     return self._matches_filters(item, self.query.where)
>
>   File
> "/Users//Documents/workspace//src/djangotoolbox/db/basecompiler.py", line
> 266, in _matches_filters
>
>     submatch = self._matches_filters(entity, child)
>
>   File
> "/Users//Documents/workspace//src/djangotoolbox/db/basecompiler.py", line
> 276, in _matches_filters
>
>     if isinstance(value, (datetime.datetime, datetime.date,
>
> NameError: global name 'value' is not defined
>
> On Tue, May 1, 2012 at 10:10 AM, Simon Charette <
> reply@reply.github.com
> > wrote:
>
>> > @@ -271,7 +271,7 @@ def _matches_filters(self, entity, filters):
>> >                  entity_value = entity[field.column]
>> >
>> >                  if entity_value is None:
>> > -                    if isinstance(value, (datetime.datetime,
>> datetime.date,
>> > +                    if isinstance(entity_value, (datetime.datetime,
>> datetime.date,
>>
>> That doesn't look like a typo to me -- how can `entity_value` be and
>> instance of `datetime.datetime`, `datetime.date` or`datetime.time` if it's
>> `None`?
>>
>> Is it triggering any issue?
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/django-nonrel/djangotoolbox/pull/27/files#r755916
>>
>
>
@shacker even though this will probably be replaced, can you you run it through jsbeautifier and use 2 spaces for indentation?
This machine is not on the list? But link is working...
PEP8 (long line, space after commas)
res can be nil if it times out. So normally you do:

if res and res.code == 200
Module name fields should be In Title Case to match the rest of the tree
Sorry, I forgot about two things. First is this newly introduced empty line. Please just remove the line with the Note and do not add another blank one.
Can't we get the field names through `Meta` or something so we don't have to manually update tests and a separate method every time we add a field? That seems to remove the whole point of having a framework manage our fields.
Same comment as `CompositePrimitive`.
Yes, ```return rgbaf;``` can either be a size 4 array of color components or an array (multiple of size 5) of time/r/g/b.  (As I said in another comment, we could have better error checking here but that's going to be done in another branch).
Instead of doing an addImages after your new TextureAtlas, it would be better to add a 5th (optional) parameter that takes an array of images.  The result is cleaner code.
isNaN covers the case where the user accidentally passes in a defined object instead of a number, so just checking for undefined isn't a good enough check in my opinion.  The code base is wildly different in how we check for valid parameters, it's something that really needs to be cleaned up.  In fact I think I'll just write up a separate issue for discussion that way when someone feels like playing janitor, they can just go clean everything up.
I am not sure I understand: do you agree we should always create the section anew, potentially removing the previous instance if it existed? I don't see that in the code above.
just a reminder to configify all this.
Group vars
should probably read "...to use _**to**_ bootstrap _**commands**_..."
Maybe:

ScrollableView supports an on-screen paging control to indicate whether a previous or next child view exists. On iOS, the paging control appears as small dots on the bottom of the screen. Android displays arrows on the left and right sides of the screen when the paging control is enabled.
Missing 'if', should read "Returns `true` if this node..."
`t`?
And thus begins the embarrassing part of this code review, haha

Fixed.
resolved the issue using mktemp
i think its now optional. it wasnt back then.
I got same error message as here: http://d.puremagic.com/issues/show_bug.cgi?id=7354
Are they still there? Maybe mark it as @@BUG@@ but  code might look better this way regardless.
I think the comparison function should take two `dchar`s
It's been established that `Range` is a tuple, so you could just use the `length` property here.

I see now that `std.typecons.Tuple.length` doesn't show up in the documentation (it's a manifest constant - do they not work with DDoc?), but it is documented with a DDoc comment, so that would just be due to a bug.
You don't have to, but personally, I think that it's better to put the break inside the braces.
Ah, so it is. Clearly, I missed that.
Yes. Today template instantiation error trace is enough useful, and shows the real problem why you fail to compile less predicate.
It's idiomatic in C++ I guess, but foreach is more D-Like, so you are right, I'll change it.
code in comments why?
Are there any tests for this method?
I understand the need for this, but that may get out of hand, no?
Similary.
I don't think we need to replicate all the gems here? As long as we require goliath gem itself, we should inherit all the right deps.. no? 

Otherwise we'll just fall out of sync.
Apaga esse teste.
Maybe it's an idea to declare a HTTPS var somewhere, with true or false? Maybe in the Config.php __construct()?
Yeah. I'm assuming you're going to check for the width of a span on the page. Are you checking that it's exactly 66%? I think that because of the way I do it, it ends up being ```width: 66.66666666667%``` or something like that.
+1 that fields have child fields and the previous formatting was better
should the "/sync" be a variable in an initializer or something?
Debug code shouldn't be in product code.
replace "updatePlaceholders" by "createPlaceholders", as the original "updatePlaceholders" method's function has been replaced by createPlaceholders.
* `append($list, $value, comma)`
* `append($list, $value, space)`
* `append($list, $value, auto)`
Missing `of` before `an`
Wasn't aware of this.
In this particular case it would still be good to change the name though.
Does anyone actually use GDC under Cygwin? It seems kind of like a dead end/pointless effort, considering it's very trivial to write Windows-native code in D.

Regarding DI generation: See #218 for how we do it today. I think GDC should do the same.
When reading the documentation, I shouldn't have to look at the source code to figure out what it's 1) returning 2) what type the data is that it returns.
@alexrp : Read the description of the pull request!
"Pirate" if/else statements stomping on one wooden foot (one braced branch, the other unbraced) are a bit meh. Care to fully brace?
well, check the performance in isolation - contains is not usually very good since it's "looser" - a regex match can pinpoint the match
Right; definitely not allowed in the 2.1.x backport; but I thought we also agreed to leave off interface @ Overrides, even in 2.2
Hello, Gunnar!
Let me a bit comment your code ;-)

How about to squash into single line:
`final boolean ignore = FileExistsMode.IGNORE.equals(this.fileExistsMode) && resultFile.exists();`
agains(t)
I'll leave it up to you but wanted to say that I am not a big fan of 'continue'. Makes it hard to follow. May be something like this:
````
if (executor != this.shutdownExecutor) {
				if (logger.isInfoEnabled()) {
					logger.info("Stopping executor " + executor.getThreadNamePrefix());
				}
				ExecutorService executorService = executor.getThreadPoolExecutor();
				executorServices.add(executorService);
				if (this.shutdownForced) {
					executorService.shutdownNow();
				}
				else {
					executorService.shutdown();
				}
			}
			else {
				logger.debug("Skipping shutdown of shutdown executor");
			}
````
please remove '==' from comment
A string works fine for a single executable. https://npmjs.org/doc/json.html
self.failUnless(node_1 not in nodes_found)
Hmm, I think I surrounded the clipboard string by double-quotes so that the start and end of the string would be clear (in case of newline/tab characters in the clipboard string).  It's no big deal, I'll remove them.

On Nov 28, 2012, at 12:41 PM, Ally <notifications@github.com> wrote:

> In example/www/index.html:
> 
> > +    }
> > +        
> > +    function getTextForSetFailure(result)
> > +    {
> > +        var text = prompt("Please enter some text to store in the copy and paste buffer:","");
> > +        window.wizUtils.setText(text, setClipboardTextSuccess, setClipboardTextFailure);
> > +    }
> > +
> > +    function setText()
> > +    {
> > +        window.wizUtils.getText(getTextForSetSuccess, getTextForSetFailure);
> > +    }
> > +        
> > +    function getClipboardTextSuccess(result)
> > +    {
> > +        alert("Current device clipboard text is:\n\"" + result + "\"");
> Not sure why you want to include extra double quotes here?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
please use PEP 008 styling on code
PLease remove commented out code
Yea, using `to_f * 1000` was because of the same reason. `to_i` makes sense. Changed it.
Need to use the Equals method. It's overwritten and knows how to compare it correctly.
http://stackoverflow.com/questions/1397512/find-image-format-using-bitmap-object-in-c-sharp
http://social.msdn.microsoft.com/forums/en-US/winforms/thread/56c3e411-0b05-435e-918a-c653c89b6350
This is getting complex enough you might want to consider using an actual recursive-descent parser and a formal grammar.
Вот что бы я сделал по максимуму:

  * Сделал бы из файла модуль ([LMD](https://github.com/azproduction/lmd) или AMD)
  * JSDoc для всех публичных функций (те, что на экспорт из модуля) с `@example`
  * Сделал бы из модуля npm-пакет - `package.json` (прописал бы все зависимости)
  * Добавил бы юнит-тестов на основе QUnit или [Mocha](http://dailyjs.com/2011/12/08/mocha/) `test/*`
  * Сделал бы автоматизированный и безбраузерный запускатель тестов на node.js и PhantomJS
  * Сделал бы автоматизированную проверку кода JSHint (не JSLint)
  * Предыдущие 2 должны запускаться по `make test` и `npm test`
  * Сделал бы git-hook на основе JSHint, который не давал бы мне коммитить говнокод (желательно это сделать сразу иначе потом забиваешь).
  * Сделал бы автоматизированную сборку документации `make docs`
  * Прописал бы проект в TravisCI для автоматизированного тестирования каждого моего коммита в git origin
    *  TravisCI при каждом коммите скачивает к себе мой репозиторий выполняет `npm install && npm test` (вобщем автоматом ставит и запускает базбраузерные тесты)

Почти все это я сделал тут https://github.com/azproduction/lmd
Should use `ms` for consistency, otherwise LGTM, +1
You'll want to specify the pubid in _config.yml most likely?
html koochike
harchand case-sensitive nist
no need for the self.
should raise an error if no locale found.
i.e. ActiveRecord::RecordNotFound

Use Locale.find_by_id(params[:locale_id]) instead

@locale = Locale.find_by_id(params[:locale_id])
if @locale 
  @translations = @locale.translations (no need for the .all)
else
  @translations = Translation.all
end
algo más cortito, por ejemplo: "#numero". No es necesario que diga solicitud de reserva, ni nada.
I'm not familiar with the git.io domain - is this an official Github short URL?
std::move(min_value)
Same comment as for #48.
Да, пожалуй я тоже с этим согласен. Верну.
add an image with the id reinforcement_image in the tcpp, tdfm, tdfm pages (we dont have their reinforcement images right now, but i will make them quickly and put them into the dropbox)
as @stof said in the comments. This can be done as 
``` php
<?php
array_merge($request->query->all(), $request->attributes->get('_route_params', array()));
```
This is getting removed. @dylin is just finishing up the share image.
`(== 0 (mod n divisor))` is sufficient
No, `std.c.*` is supposed to be deprecated in favor of `core.stdc.*`, so I'd rather keep them where they are. That said, moving them to `std.uni` or something would make more sense, I think...
True. Errors should be 'help-inline'. But in example markup the description is shown as 'help-block'.
The is a unseless blank line here