labofsahil/github-event-dataset-2012 huggingface dataset:
Suggestion: let's write a class-level javadoc that summarizes, from a caller's perspective, what the various options are, without reference to the field names.

Then, let's deprecate the old constructor, and replace the new constructors with named factory methods that make it easier to map the user-meaningful options to the factories.
Dangling comma :)
delete this if it's empty
It is weird, but after talking to Ashley yesterday I think we should just actually list desktop OS.  We can more accurately control the not supported message better that way anyway.
I found these names very confusing.  Could we rename to normalizedColor and _normalizeColorString()?
Yes. This was redeclaring a variable that is supposed to be the result of a `RegExp`.

If you see on the previous version of this file, on this line:

- https://github.com/ajaxorg/cloud9/blob/4cbe5d5039bed075f81d8b926ef59ffeb973528e/plugins-client/ext.filesystem/filesystem.js#L285

assigns `name[0]` to the `name` property. If we keep the (re-declared) `name` inside the `if` block, this property will contain the first character of that string, which is not what the author wanted to do, I presume.

This could have been the source of many subtle bugs in the file system until now.
I like to always wrap blocks `{ }` even if they're one line. Apart from giving it a uniform look, it could also conceivably prevent an "Oh I'll just add another line below this one" error.
I would keep this description & title in.

See <foo> for setup information
Another option would be to replace mu with mu4e.  The mu4e recipe would assume that mu has been built and is available.  Thoughts?
You could write this as `def self.no_freeze(*mods)`, then you wouldn't have to use `Array(mods)` below.
Here's another commit message related to changing the "el" param: 
https://bitbucket.org/rg3/youtube-dl/changeset/d3199645a82a3101de3a7ff88318f96b4e939e56

Seems like it's required for certain videos only.
> Why do you need the aaply? Passing in a character matrix should be fine.
I don't think so, but the codes are improved.

>  And I don't think you need the ifelse either?
For the case alpha is `NA`, and by default alpha is NA.
It doesn't really matter because there are unused "using"s all over the place, but it seems silly to have committed an addition that wasn't needed. #gettingRealPicky
*This class defines document type for posts on a wall.*
Hm, this URL probably should not be hardcoded, but reversed from `urls.py` (so you can set it in the same manner as other configuration variables).
Yeah - I think as we've only got a 1 to 1 relationship between users and entries that would be overkill.

If things get more complex that's a winning idea though
keep this one here: error  function can be intercepted by malicious code to not throw. or change error to throw here
Do you mean null here? Or not defined it?
Oh, yeah, Twisted is aware of the currently active exception and records that by default, right?
I'm new to redis, so my apologies if I'm getting this all wrong.  The documentation you referenced seems to indicate a nil reply means an empty list for a "bulk" section, not a "multi-bulk" section.  In a "multi-bulk" section the nil reply means a timeout (for a blocking list action) or an aborted "multi...exec" block (my use case).

In either case, it does not invalidate the results of the other actions in the same queued sequence of instructions.  Perhaps this error should be stored for the individual command ("exec" in my case) rather than returning an error for the entire sequence?  I'm not sure I like that idea either, but I think the current API is lacking something.

What I need is some way to detect when a "multi...exec" block was aborted due to a "watch" condition being violated.  I couldn't see any good way to detect that with the existing code.  I could extract the text of the error, but that seems like a bad idea.

Any other suggestions?
Bah. a mistake, fixing it.
Tähän vielä primary key määre
`PATH.sep` — только node.js 0.8, а мы ещё 0.6 поддерживаем, лучше использовать `PATH.join(path, '.borschik')`
in user github hastesh
plz hichvaght readme ro taghir nade too hich projeyi !
noyi tohine :D
You should ask autor to add semantic version tags. Use [this](https://github.com/CocoaPods/Specs/wiki/%22Please-add-semantic-version-tags%22-issue-template) template.
That's a good question.  I didn't think it would, but it couldn't hurt.

On Fri, Jul 27, 2012 at 3:14 PM, Eric D Helms
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,43 @@
>> +.details_container
>> +  .item-container
>> +    %label.fl.ra
>> +      ID
>
> Does this need i18n wrapping?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Katello/katello/pull/380/files#r1255704
Just a commet to test how it works.
Does this change affects only the verbose mode?
systems_controller.rb doesn't raise HttpErrors::NotFound any more, should it be or was that not used previously?
Maybe test `round-to` on negative numbers. Actually, do we want to round or just clamp? I think maybe clamp since rounding changes the position of the coordinate. So 3.10000009 should just be "3.1000000". Yeah?
Ok then - will change that
What levels do you figure is appropriate?
I have plans to do some work on MonoDevelop next and improve it's project config options, at which point these will be updated.
Taken care of all your comments. Thanks for the detailed review.

Implemented the following extensions

```
ex_iterate_multipart_uploads()
ex_cleanup_all_multipart_uploads()
```
I just noticed these examples - as mentioned previously, flam and fnu are not units. An example of a spectral density unit is ``Jy``. So a valid example is:

    In [3]: u.Jy.to(u.erg / u.cm**2 / u.s / u.Hz, 1., u.sd(u.AA, 3500))
    Out[3]: 1.0000000000000001e-23

which is an F_nu to F_nu conversion, or

    In [5]: u.Jy.to(u.erg / u.cm**2 / u.s / u.micron, 1., u.sd(u.AA, 3500))
    Out[5]: 2.4472853714285712e-08

which is an F_nu to F_lambda conversion.
Actually, scrub that, I now pass only the data array, so this is indeed now ``result_data``
这都能挖到，偶像！
去提pull request把
Is caller ever not `self()`?
Learned something new - thx for the tip :-)
Are you sure the input string is well-formed?  What if it is the empty string, or ":" ?  Either assertions or sanity checks would be a good idea to avoid indexing out-of-bounds.  And maybe unit tests for this routine...
Yes that's weird. It'd make sense to move the printf to ThreadIRCSeed, the same function that prints "XXX exited". 

And replace the message at this line with something else "ThreadIRCSeed connecting" instead of removing it.
That's an option as well.
`. '' .` shouldn't be there
LookingUp_state_NON
isnt it better to check for -1 ? and using lastIndexOf because of filenames like foo.jpg.bar.test
It's not so much disliking `else` as it is liking Object Calisthenics :)
It's our awesome CS... not PSR-0. =)
@guilhermeblanco I'd push this to `3.0` (to be discussed, obviously)
I see why you dont like this..
Can't you just do
user.group_ids.include? discussion.group_id
My opinion on these is that I'm okay with them being added as part of another change, but I'm not going to go out of my way to add them to everything.
`kills`
Thanks for the reminder.  I have certainly read about wrapping values in Option, but sometimes I forget some of the facilities scala provides or I'm not entirely sure about the performance implications of something.  I'm sure I will use more Option(somethingPotentiallyNull) in the future as  really like Option's get/getOrElse/map syntax.
probably a typo here in "remote".
This line must be conditional by platform, and should only be run on OS X.  The equivalent would be pyreadline on Windows, and nothing on Linux.
I think this should expose *at least* the silent arg, and probably also the user_expressions/variables keys.

In my [example](https://gist.github.com/2605662), I have sliders that trigger execute, so my prompt count quickly rises into the hundreds while I am fiddling around.  And I really don't care about keeping track of any of those near-identical calls in my history.

Also, the default value for silent should be True, just like the default value for store_history in InteractiveShell.run_cell is False.
This is fine, or `line.replace(',', ' ').split()`, which is equally hard to read.  The comment is quite helpful.
redo this class like Tag https://github.com/jclouds/jclouds/blob/824ea1fd0a25fdd825abd89927d875f358d4a69f/apis/ec2/src/main/java/org/jclouds/ec2/domain/Tag.java
this was required b4 so it should still be for some os version. Does it really need to be commented out?
Looks good, as long as it passes all is well :)
Should add a note it's MySQL only.
An enum? Or maybe you could infer it from the filename somehow... you could at least infer gzip from the extension.
It's only accepted with Option Strict Off - it's a conversion from Boolean to Integer (which is implicit with Option Strict Off).
Woot, that's cool
that said, if it's required, at least empty the file.
Fun fact: the font I'm looking at this in shows f and t such that they look like upside-down versions of one another.
I didn't like the way the blacklist is dependent on a hard coded route, plus the tutorials page probably isn't going to live at /ecosystem/ forever.
Uhm? What? We are showing how to use get_tool?
Thanks buddy  

--  
Phil Sturgeon


On Friday, 14 December 2012 at 12:44, chad d wrote:

> In system/cms/modules/pages/plugin.php:
> > { > - if ( ! is_numeric($child_id)) > + if ( !is_numeric($child_id) )  
> There was one file where the whole thing got accidentally reformatted, this was it. I will fix these along with the other changes you noted.
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/pyrocms/pyrocms/pull/2125/files#r2423054).  
>  
>  
>
Removed testing content

This was not testing content!
I'm stucked in here... all those providers are correct but tests passes only if I keep one of them each time, I don't exactly know why it fails but it looks like a caching issue, even though a few lines below the cache dir is deleted, apparently they use the same kernel class, and as it's within the same process only the first one is used by PHP, is there a solution for this? thx
shouldn't this one be initialized to ``false`` ?
This can be removed as it is already done after the condition.
you should keep it on the same line
Make the class final, for restricting it to be inherited.

    class MyHttpUtils extends HttpUtils
    {
         public function __construct() {}
    }
    // In Java you cant inherit from class with private default constructor, 
    // but in PHP you can
    $utils = new MyHttpUtils();
`getDefaultValue()`
please replace `and` by `&&`
Symfony never uses the base Exception class direclty. You should use the SPL exceptions
This is true, but it's not unnecessary on HTML4 and XHTML1.0 and XHTML1.1, and last time I checked, HTML5 isn't done yet. The spec isn't complete. But many people use it anyways.

But it's good practice to have it there for people not using HTML5.
jQuery dblclick event fires click twice. Checking if click was fired.
Diffs are not idempotent given the current implementation. If two diffs race with each other and if the one that started later (which should have newer data) finishes updating certain branches earlier, the one that started earlier (with relatively stale data) would overwrite the data.

Maybe this could be made idempotent and/or thread-safe, but I don't think concurrency would be a big gain for the reload operations. I simply put synchronized blocks around the reload/reloadUpdatedForwardings methods to update them atomically.
If ```contact-cell-bg-selected.png``` and ```contact-cell-bg-selected@2x.png``` are no longer needed, you should delete them.
whitespace is messed up in this file, tho you did not introduce it.
Extract this hash with the access token into a private method like `access_token_for_query`.

For that matter, pull the `to_query` out as well.
Should we have a test for this?
I'm fine with that, but I don't want to limit something just because we don't know it. Maybe people who use IIS use these types of requests? Do we have someone who uses IIS that could shed some more light on this?
Also, unrelated, there's a typo in this name. It should be `not_found` not `net_found`
We should keep the inlined variables here. It's a really tight loop, so they give a little performance boost.
spatie na !=
url => URL
Localize these links... no more wiki.basho.com ;)
again as above, I'd rather have consistent messaging (either everything through ``self....`` or ``messages....``
@twinturbo discussed w/ @wycats @tomdale this AM.  You're observing items in the array and needlessly recaulcuating while constructing the arrangableContent.  It eventually finishes, but is highly inefficient. 

We monkeypatched my running instance by copying off content to origContent and then moved this forEach below L#156
or just `(typeof exports === "object" && exports)`?
Why export="true" ?
I think I'm fine with making button a required dependency.
`this.document.find( options.appendTo )` for cross-window support.
please avoid anonymous functions for debugging
same comment as above

I think the handlers should be declared as separate functions
Given the fact that `self._reconfigScreenTimeout();` respects `_screenWakeLocked` now, doing this `if (...) {} else if {}` make no sense anymore I think.
Actually I will add pending deletion ability in the MesageManager.delete so there is no need to separate your logic in view page. You just need to call delete api and it should works no mater the message is in which DBs.
BTW, do you execute the delete here? It seems that you have to put every number in the delete list and execute deletion.
give a name to your function
Let's change this variable to `isSlientModeEnabled` all right?
@timdream I did this by copying/pasting from the system locale, please confirm/infirm.
ok for me although I used to write (typeof onDone === 'function'). Be careful, don't change anything ;) It is just a comment, I didn't know instanceof :)
I'll change this for the next PR if you don't mind. Or do you think this should be solved just right now?
The current notification API doesn't allow me to remove the notification when the voicemail status changes.. is there a bug for this already?
could be legacy code :)
I decided to give up this pattern since I even didn't know why I kept this! I believed I was trying to keep the consistency with some other apps, and I didn't realize why the getter delete itself and then replace itself with another one.
So let's get rid of this from this PR~~~
D'oh!  I think it was originally setActive.

I much prefer setVisible (short of explicitly setting the state).
I also changed this line to reset this.delimiter to undefined so that it won't fail on condition at line 358.
I don't understand, we should talk about it  :confused:
An alternative to this would be to define a RichFields class (extending
Fields) and an implicit Fields -> RichFields conversion, so that in place
of the apply method we could have the (somewhat more natural?)

fields.getFieldList

to return a List[Field].

RichFields could even be manifest-annotated so that the getFieldList
conversion would be fully faithful in the case where the Fields object was
originally constructed by scalding.

On Sat, Sep 8, 2012 at 12:06 PM, P. Oscar Boykin
<notifications@github.com>wrote:

> In src/main/scala/com/twitter/scalding/FieldConversions.scala:
>
> > +  def ord : Ordering[T]
> > +}
> > +
> > +case class IntField[T](index: Int)(implicit ordval : Ordering[T]) extends Field[T] {
> > +  def id  = index
> > +  def ord = ordval
> > +}
> > +case class StringField[T](name: String)(implicit ordval : Ordering[T]) extends Field[T] {
> > +  def id  = name
> > +  def ord = ordval
> > +}
> > +
> > +object Field {
> > +  def apply[T](index: Int)(implicit ord : Ordering[T]) = IntField[T](index)(ord)
> > +  def apply[T](name: String)(implicit ord : Ordering[T]) = StringField[T](name)(ord)
> > +  def apply[T](symbol: Symbol)(implicit ord : Ordering[T]) = StringField[T](symbol.name)(ord)
>
> How about a method here like:
>
> def apply(fs : cascading.tuple.Fields) : List[Field] = {
> // Go through and get out the comparator, use
> Ordering.comparatorToOrdering to convert.
> // I've been trying to talk chris Wensel into adding the java Class object
> into Fields, if he does this, we can almost round-trip.
> // until then, make a Field with the Option[Manifest[T]] set to None.
> }
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/twitter/scalding/pull/175/files#r1560962>.
>
>
Can you comment why you used crossWithSmaller rather than crossWithTiny?
Should this not be abstract?
Extract this magic number out to a class constant.
Remove space between "=" and "-1" here and below.
If we remove the doc method using pretty_inspect, we can remove this requirement probably as well.
Can we not do braceless blocks? I know they're more spacially efficient but they're fragile and easy to miss. Also uniformity.
as above... please remove
We recently changed this to "Postcode, town or place"
OK. Let's make this function one line.
Ok, but you'll have to manually check out the related branch.
Say what azimuth is here too maybe
Is this going to be idiomatic? If so, should it be documented?
Cool, let me know.  If it doesn't work it's fine.  I can merge it as is and we can see if there is a better way later on.
This is corrected by making initial window size 480x320.
The convention in this file seems to be to use single quotes instead of double quotes.
Ok, I've overseen the WritableRepositoryInterface, there already exists the method removePackage. I'm just not that happy with Composer\Factory::purgePackages iterating over the repositories and calling removePackage without making sure that all repositories implement this method. Maybe we could integrate a `if ($repo instanceof WritableRepositoryInterface)`?
For now, I am removing the method from RepositoryInterface.
Is this indention intentionally?
we need this one? I think we should change the `output_dir` function to use `"test/output"`
posts joins taggings  where taggings.tag_id in (...) is much better than 2 joins.
A little bit naughty, but while I was in here I put in the refreshStatus field so we can disable refreshing under load.
Sure, it could help people :)
I agree 'match' is not clearly the best name.  I just followed the closest examples i could find: grep & grok.
As explained here: http://en.wikipedia.org/wiki/Radian
Is it possible to specify the dependency for this without requiring it for library installation?
Argument that we ignore. In AMD and commonjs API is:

`define(function(require, exports, module) { ... }) `

As we ignore first arg I called it `_`.
In this case a class var would be simpler and work just as well - there are never multiple instances of the same management command class that should have different lock file values. So rather than `DEFAULT_LOCK_FILE` on the class and telling subclasses to set `self.lock_file`, just have `LOCK_FILE` on the class and have subclasses directly override that as a class var.
Doh! Thanks, have updated the request
The "now" time is 22:30, not 1:30, but your conclusion is still right - I have moved the start of the range from 23:00 to 22:00.
It is only used when importing types from Ruby DSL and Scope object is unavailable (and not needed there). I only use some API from the scope object, because I want to reuse the same code when evaluating ruby files and importing types from ruby manifests. It accepts any methods with any parameters and nullifies the chain of execution by only returning self.
You can do:

    gzip -cd filename.tar.gz | tar xf -

But my concern is more around controlling absolute paths. Solaris tar doesn't have a simplistic way of controlling extract location - gnu tar has the -C switch at least but Solaris tar doesn't seem to have an equivalent.
Where's the pre-1.9-specific spec for the behavior in this 1.9-specific spec?
if we use a more generic `.actions` class we can re-apply it on other places
I thought the point behind the Config object is that we wouldn't have to do this.
I doubt it makes that much difference in performance (see [here](http://www.erichynds.com/javascript/javascript-loop-performance-caching-the-length-property-of-an-array/)), especially since we have a relatively small object (we don’t expect to be dealing with a page with hundreds of Sage cells) and the length caching requires the extra step of creating another variable.
`themodal-overlay`?
This can't be done this way.  3306 is only the default port for MySQL; other drivers have other defaults.  Suggest this change:

7: protected $port;

23: "{$this->driver}:host={$this->host};".(!empty($this->port) ? "port={$this->port};" : '')."dbname={$this->database}"
simply nodes.get(id) will work
He is using a particular naming style with the same names in the Twitter Search API doc. Also he is using underscores for var names.
CS: ALL blocks need braces!!!!!
I am taking arrival time in israel timezone to compare it against israel lesson timeframe
remove all underscores
Suggestion to turn this into classOf()
The init() function would benefit from it, if you decide to move init to the class-level, instead of the prototype.
yup at ginawa kong mas concise. paulit ulit lang eh hehe. yun yung brittle kasi pag me nagpalit sa registration natin sira lahat tas papalitan mo isa isa. mas ok yung isa lang papalitan mo hehe
no, contains the ApiReqquest, not the HttpRequest!
This should be a private method.
This action doesn't seem to exist.
A explicit compile group option seems great. If we are doing so, I don't think there is a need for `captures:` as I said above then.
`<\!-- ([^\:]*):(.*)-->` should capture the key in the first group and the value as the second one. I've used the incredible "kodos" tool to help me with regexp in the past, maybe you should give it a go, it helps to let you have direct feedback on the regexp you're creating.
When in doubt, copy! :) Added a new commit that copies what RSpec's BaseTextFormatter does.
Please see my comment on the first pull request:

> And I'd rather not use the Objective-C literal syntax for NSDictionary so that the library can be compatible with older projects.
I'm happy to change this. I was following precedent in other files in this project as I wasn't sure what standards were followed here. I guess I should have just assumed. :)
move this method up
Emphatic search!
How about

```python
username = forms.CharField(
        label=_lazy(u'Username'), max_length=30, required=False,
        widget=forms.TextInput(attrs={'placeholder': 'Example: IRC Nickname'}))
```
FIXME: or TODO:
Also isn't being used for anything, nuke it
Work in progress. The idea is to match whether the output of runSnaplet matches an expected one
це я взяв з останньої версії composer symfony у них в репозиторії, я думав, що це спеціально додали у версії 2.1
It also Reports a failure. Don't we have the Start+Report part encapsulated elsewhere already?
nit: quotes around attributes.
add one of these before this:

```js
var prefix = Modernizr._domPrefixes[i].toLowerCase();
```

it'll look a lot better
This one is unfortunate because it can mean you did several things "wrong."
This function exists in glassfish, java, utils and python... all with probably slightly different behaviour.  Not sure how to approach this.
You don't need this either.
You don't need this - the proper parent pom already contains this.
Is this changing the "default" port to zero? What's the reason for that? Obviously not relevant if the server is started from the "IDE server", but if it's just going to error out if the port isn't specified, why not just print an error message and exit?
This comment and the one on line 253 do not add much explanation and I would prefer if they were not included.
that's fine.  I just tossed it in the first place I thought of.
That is how you do block comments in coffeescript
This doesn't work on OSX. The usage statement says nothing about `-S`.
We have to set the min-height to 100% here to ensure that the mover is always at least as tall as the scroller client area, so that if a theme sets a background color it covers the whole area.
I was going to suggest taht you just change the check for the icon to use is_element_present rather than _visible.
"don't use the button".

Simpler; easier to understand what this is for.
Please use 'from timezone import PacificTimezone'
Testing inline comments
Some testing objects, for example objects of type TestEquivalenceTester.notReflexive, are not .equals() to themselves. So it is necessary in this test to compare the pointer before calling .equals()
Please put all these on different lines:

```javascript
if (!basic_user) {
  return done(null, false);
}
```
This should be part of the validator.
I wanted to keep it private, but I had to open up the visibility, since I used it from the semantic highlighting/hyperlinking packages (both the factory, and the call to `Hyperlink.withText`.
It's very hard to come up with a test like that, so I preferred to do it this way. Here's when it matters: if the Scala library is *not* on the boot classpath, the scala compiler uses the library found in the running JVM, regardless of any libraries you may add using `-cp`. It simply ignores it. If you can write a test that makes sure it's the scala-library on the classpath, and not the one that's used to run Eclipse, I'm happy with that.
So, making a MetadataFactory "advanced" won't force advanced drivers for the sake of BC.
Добавил обработчик, спасибо!
да, bug по невнимательности
Да, на выходных подправлю.
Тут можно было обойтись без этого цикла. Есть метод, который из элементов массива склеивает строку. К сожалению, забыл как назвается.
I'll leave this as a comment, maybe we can make an issue to clean this up next sprint (I made about the same comment on another recent 'blocker' patch, and let it go there too).  It seems very redundant to me to have 3 blocks now, each for just adding a directory to the load path.  This can easily be accomplished in a single block, making it more DRY.
`ns-resize` is only vertical, but it implies you can move it up or down, not just down
I'd consider removing this IDE dependent comment and aligning the `=` signs
I would prefer if
 (1) this would be in a separate sub-interface, since not every IterativeComputation would support the reset() operation
 (2) this would not be a reset of the iteration counter, but an increment of the TotalIterations
We should support pointer `^…` arguments if possible. It'd just be unwrapping a pointer from `NSValue`.
I think the problem here is that blocks queued that execute after the scheduler has dealloc'd won't be able to call `currentScheduler` even though they were originally queued on a scheduler.
Another solution is to wrap the scheduled block in another block, have the wrapper block retain the scheduler, and dispatch that one instead. Very ugly trick.
You can actually do:

```ruby
p.governing_periods.make!(...)
p.should be_in_government
```
Raghu and I discussed this. We thought that if the decompressor was not created explicitly by us, then we don't reuse it. No other particular reason.
> Or, should I just put everything in a separate file and only import sample_path()? This would be nicer.

1 file is fine with the added comment
On 09.12.2012, at 10:53, Alexandre Gramfort <notifications@github.com> wrote:

> In examples/inverse/plot_label_activation_from_stc.py:
> 
> > +
> > +data_path = sample.data_path('..')
> > +os.environ['SUBJECTS_DIR'] = data_path + '/subjects'
> > +meg_path = data_path + '/MEG/sample'
> > +
> > +# load the stc
> > +stc = mne.read_source_estimate(meg_path + '/sample_audvis-meg')
> > +
> > +# load the labels
> > +aud_lh = mne.read_label(meg_path + '/labels/Aud-lh.label')
> > +aud_rh = mne.read_label(meg_path + '/labels/Aud-rh.label')
> > +
> > +# extract the time course for different labels from the stc
> > +stc_lh = stc.label_stc(aud_lh)
> > +stc_rh = stc.label_stc(aud_rh)
> > +stc_bh = stc.label_stc(aud_lh + aud_rh)
> the more i see the stc.label_stc I am wondering if the naming "stc.in_label(label)" would not be more natural?
> 

yes, it would be from my point of view. +1

> any opinion?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Whoa, nice. I will do that next time, thanks!
It should return boolean and not Boolean. If deathdateEsitmate == null return false.
Consider adding some paragraph breaks to make this more readable.
`:current_password`
This is not going to work. The module is included before the configuration options are applied.
Bad i18n. Incomplete sentences.
While I think of it, you might want to start looking at escaping this stuff. The app is small enough still that you could turn on haml auto-escaping and probably just fix things.
Why are you embedding NVM in Prezto?
can you please just add a little code comment explaining what this code is doing for future maintainers? :-)
@WouterJ  @stof I just used modified a view created by the ``generate:doctrine:crud``` command. I have made the change to use an input element rather than a button because I'm not concerned enough about it to argue either way. 

Looks like the output from that command doesn't meet the current Twig coding standards with regards to the spaces after the parenthesis for the hash.
missing either ``::`` at the end of the previous paragraph or ``.. code-block:: php`` to make it a code block
This should be:

    /**
     * @var string Uniquely identifies the secured area
     */
请添加官方copyrights，以示尊重。他们也是最近加的。
+Copyright (C) Igor Sysoev
+Copyright (C) Nginx, Inc.
It appears to me that you are never passing the headers into the method

So if I call 

    connection.delete("/foo",{"Accept" => "application/json"})

Doesn't the params parameter get populated with my hash and not the headers parameter?

Is the expected behavior of this method 
    
    delete(url, headers) { /* block */ }

maybe line 87 should actually be 
    
    def #{method}(url = nil, headers = nil)

or perhap you should check to see if all three parameters are passed in like

    connection.delete("/email",["roo@bar.com"], { /* empty headers */ })

And if only two params are passing in you shift the params over to the headers

    connection.delete("/foo",{"Accept" => "application/json"})
is there a test that transform_params won't alter the appearance of MessageDate<=2012-04-02?
You are right.. Maybe we should just let the method in there and use the drain listener inside here ? I think it makes things a bit "easier". WDYT ?
also, always have return types on your methods. Trust me, will save everyone involved a lot of headache and will add documentation.
Why not message instanceof Disconnected?
which means that it would need to be a nested class; is that worth it?
Очень хорошая функция.
Could you explain this bit. Are you simply trying to get the name of the class? Using ```inspect``` is generally pretty expensive.
At one point I thought that was failing, but maybe I was confused. I'll see what I can manage.
Do we need this here?
any ruby method can take a block, not just iterator methods. To call a block a method uses the yield keyword.
You can not use the exit keyword
just because its more of an internal function and not really meant to be called outside the library. That's usually how I label those type of functions.
Vektoriliteraaliin voi toki laittaa useita alkioita:
~~~clojure
[(my-take elems a-seq) (my-drop elems a-seq)]
~~~
The ResponseGenerator is responsible for wrapping the outcome of commands into a Response object. Your question made me think why I wrap the caught exception in an ExceptionResponse a few lines below ... That is not necessary and will be removed.
yes we only have a snapshot of Search at this point compatible with Lucene 3.6.
Unfortunately we already moved the Lucene Directory to Lucene 3.6, I didn't expect it to not work but had to make changes in Query because of an issue in Core.

So we either roll-back a bunch of commits in Infinispan Core +  Query + Lucene Directory or we have two reasonable options:
- use 4.2.0-SNAPSHOT
- move the dependencyManagement definition out of the way to use a different Lucene version across the two modules. Not sure I like that..

I'm sorry for the mess, it's mostly my previous mistake that I'm attempting to fix, it would have been far easier with a working CI job to warn me eagerly.
why don't you implement cancel with interrupt? :-)
When we have a ``set*`` method, it generally resets the array instead of just adding new elements while keeping existing ones.
I think we should keep the bracket syntax here, because `is` getters are unconventional with dot syntax.
ここで返している値は何ですか？
メソッド名から推測しにくいです。
Docstrings should be encased by triple double-quotes, as you have done in `autoscale`. Could you either use encasing `"""`, or perhaps use `#` and make it a comment?
@NelleV I agree with @dmcdougall that this is a bad break; with parentheses you could follow his suggestion.
Indentation looks a bit weird here ;)
It's private it's not going to clash with anything.

When we settle on the app object model is the right time to move it.
I agree, there must be something wrong with it...

Though, using QGLWidget *does* fix the slowdown
Agreed, I think the message should be the same in both cases, something like:

"Thanks!  If we find your email address in our system then we'll send you a link for you to use to reset your password."
This needs a title.
For the 3 above lines. please use PropertiesUtil.toStringArray instead of casting to String[].
Changed this. Made it less than 200 for design reasons, but gave a little more space. It's now 150.
I'm not a huge fan of the `database.yml.sample`-style approach and have generally found there's a cleaner way. I don't think I want the `sample.env` hanging around in my git repo.

Knowledge of Foreman is good, but is already covered here:

https://github.com/thoughtbot/guides/tree/master/protocol
Suggestions on a different top level name? What's wrong with <import> ?
The color options were inherited from upstream, but I can't remember whether it was from vagrant-windows or vagrant itself.

Either way, I totally agree with you.  :D
This comment doesn't apply here :)
"period of inactivity" => "periods of inactivity"
`s/[*][*]/*/`
Might as well make this 80 chars
currently, it is still LGPL. but as Doctrine is switching, we need to know if beberlei wants to change before or after merging :)
Whuck? are you missing a closing paren?
No, it wasn't, but I remember writing the code once. I wonder why it didn't make it to the repository.

In any case it is tied to this feature in-as-much as the use case that requires postMessage also requires this addition.
Can you add a @since 12.2
Steps to reproduce:

1. Uninstall tastypie.
2. Replace the current requirement for tastypie with the command: -e git+https://github.com/toastdriven/django-tastypie.git#egg=django-tastypie
3. pip install -r requirements.txt
4. Restart django server.
5. Refresh page. I get the following exception:

`"{"error_message": "'QuerySet' object has no attribute 'query'", "traceback": "Traceback (most recent call last):

  File \"/home/aljana/dev/src/django-tastypie/tastypie/resources.py\", line 196, in wrapper
    response = callback(request, *args, **kwargs)

  File \"/home/aljana/dev/src/django-tastypie/tastypie/resources.py\", line 421, in dispatch_list
    return self.dispatch('list', request, **kwargs)

  File \"/home/aljana/dev/src/django-tastypie-mongoengine/tastypie_mongoengine/resources.py\", line 309, in dispatch
    return super(MongoEngineResource, self).dispatch(request_type, request, **kwargs)

  File \"/home/aljana/dev/src/django-tastypie/tastypie/resources.py\", line 454, in dispatch
    response = method(request, **kwargs)

  File \"/home/aljana/dev/src/django-tastypie/tastypie/resources.py\", line 1107, in get_list
    objects = self.obj_get_list(request=request, **self.remove_api_resource_names(kwargs))

  File \"/home/aljana/dev/src/django-tastypie/tastypie/resources.py\", line 1855, in obj_get_list
    applicable_filters = self.build_filters(filters=filters)

  File \"/home/aljana/dev/src/django-tastypie/tastypie/resources.py\", line 1736, in build_filters
    if hasattr(self._meta.queryset.query.query_terms, 'keys'):

AttributeError: 'QuerySet' object has no attribute 'query'
"}"
`

I'm trying to patch this right now but I have a bad feeling that this could take very long :) So any idea what caused this would be helpful.
Changed file bits back to 644. There is no need for .js file to be executable :)
Yes. I used an existing test case as a starting point and didn't see it.

Given that there are existing test cases already not using it and there's nonzero effort required to switch to it, I'm going to leave this test as-is for now. We should really clean up all the tests, but that's out of scope for this branch.
Just minor fix, no need to add None as 2nd argument to dict.get
if it really does need an order accessor then `Response` should be subclassed. I don't really feel like this is needed though.
Yah, these line notes are kind of deceptive on Github; it's actually the last line of the snippet that I'm referring to, i.e. `successful?(response)`.
Da fehlt noch:

    android:fillViewport="true"
    android:overScrollMode="always"
    android:isScrollContainer="true"
    android:scrollbarAlwaysDrawVerticalTrack="false"
    android:scrollbarStyle="outsideInset"
    android:scrollbars="vertical"
Could we add this owl:Ontology metadata back and add owl:versionIRI to denote the version?
Captialize questions
It should work also with len.
what's the performance of this like? Does it degrade much as the response body grows?
this line isn't necessary - the driver is reset between test runs already.
Done. Fixed for all deprecated classes.
Do you think a second signature that takes a filter would be helpful as well? Also, passing FileSysterm here seems ideal.
Btw. I can't say for certain that changes are defect free. But if ya create
a test that reproduces, I'll gladly fix.

Dan Schlossberg
Chief Software Craftsman
www.softwaresingularity.com
(m) 678.361.6960

Sent from my iPhone.

On Nov 4, 2012, at 3:03 PM, Greg MacLellan <notifications@github.com> wrote:

In Swagger.Net/Factories/SwaggerFactory.cs:

> @@ -0,0 +1,135 @@
> +using System;
> +using System.Collections.Generic;
> +using System.Reflection;
> +using System.Web;
> +using System.Web.Http.Controllers;
> +using System.Web.Http.Description;
> +using Swagger.Net.Models;
> +
> +namespace Swagger.Net.Factories
> +{
> +    public interface ISwaggerFactory

Only one implementation - why is an interface needed?

—
Reply to this email directly or view it on
GitHub<https://github.com/miketrionfo/Swagger.Net/pull/15/files#r2025465>.
**Q** has it, as they always queue all the operations so it's never sync, that is why order there is FIFO.
If this is for testing purposes surround it with comments stating so before pull request. 
/*******. Testing item class *******

Code here;

*************************************/
How about put this as one of the test configuration parameter.
Yes, I think that would help a lot.
split over multiple lines
This could be done in Lua already - there's a low fuel event, and all the relevant methods are exposed to Lua. All we need to decide is whether refuelling non-player ships is something that Lua should do, or the core should do.
I am a fool, and your suggestion works perfectly. I've added a new commit implementing it.
Please use the following string:
_(qBittorrent has been shutdown.)

The _() is needed for translation and I removed -nox because the Web UI is not specific to -nox.
Import only modules, never directly its contents.
One empty line inbetween.
Nope, I filed https://webmademovies.lighthouseapp.com/projects/65733/tickets/436-have-butteriocornfield-write-out-a-script-tag-to-load-browserid-if-its-not-loaded on that
There was discussion on how to lay out the roles page. Either:
- Tables with checkboxes like it is now (doesn't allow ordering people)
- Something else (I've been suggesting something like mail TO/CC/BCC fields maybe using typeahead)

That's all
Never mind.  I found it in the test_nfwhalo function.
That seems quite sensible in fact.
I see what you're saying.  I still have a slight preference for E and B (and what I'm thinking of is, for example, the CCDNoise class which isn't CcdNoise - but I realize that's not quite the same since we were respecting the acronym in that case).  But it's not a very strong preference and nobody else seems to care, so let's leave it as is.
Do you need the code placed inside this comment? If not, please remove :)
Comments like "display error" don't anything here. If the syserr doesn't make it obvious that you're displaying an error then improve the code rather than adding a comment. In general, I like to have a comment about a block of rather than lots of small comments about individual lines. And I like those comments to be on their own line so they stand out more to make the code easier to understand at a glance...
Thanks. I'll fix this and pickup mozilla/source-map#20.
fufill -> fulfill?
Please revert all modifications to this file.
Now that I think about this more, I'm tempted to make this public, as it is a useful utility function in case anyone needs to clear throttling on a particular job type.
nit: `should not`?
Мы не можем быть уверены, что модель не будет  содержать числа. В случае модели "123" объект не пройдет валидацию и не сохранится, поэтому необходимо форсировать преобразование в строковую переменную.
It does work! However, it only works when running make as root (see my other comment).
You are completely right, as usual.
Remove these line breaks
Typo (lol - finally!) :smile:
Whoops... probably should have gotten rid of that.
Actually, revert this whole file.
Don't do it by hand. There is some shortcut methods:

```php
$config = $processor->processConfiguration($configuration, $configs);
```

or even shorter (and hiding the processor):

```php
$config = $this->processConfiguration($configuration, $configs);
```
@mythz , how do you think is it good way to store instances per thread context? The same approach used to store EndpointHostInstance
The same here s/enpoint/endpoint
Not a bad idea...

I was a little nervous of doing this, but as you mention, problems can be sorted while upgrading...  I'll get rid of it.
As said below, it would be better to avoid dash in class names.
I haven't changed anything in here but it may of broken slightly with the changes I made to the runner
yeah makes sense, let me test that
Yeah, very similar. Keith said we had to do that. Is there a better way to expose that to class and instance methods?
It may be clearer to drop the ":auth => true" business & just call "login_with_cas(whoever)" in the body of the test, but given the task's goal, that shouldn't block a merge.
Yes you need to run the code from the web server to make tests pass.
Captionator's XMLHttpRequest() refuses to read the file from the file system because of this code
ajaxObject.open('GET', source, true);
    							ajaxObject.onreadystatechange = function (eventData) {
    								if (ajaxObject.readyState === 4) {
    									if(ajaxObject.status === 200) {
    										....
    									} else {
    										....
    									}
    								}
    							};

According to https://developer.mozilla.org/es/docs/XMLHttpRequest/Usar_XMLHttpRequest (look for Example: Non-HTTP synchronous request) status should be compared to 0 instead of 200. Which you can also reverify by putting a break point in the captionator code and running few tests.
Thanks for adding statsd to your new route. Looks good.
２つのぶんにするには文がそれぞれみじかような。

    起動します。

ではなく

    起動し、

とか一文でいいような。
Since we don't plan to change it during runtime, a tuple is better as it takes less memory.
@rafaelfranca @carlosantoniodasilva right, I've just pushed these tests. Please take a look.
On 10/03/2012 10:47 PM, Yann N. Dauphin wrote:
>
> In sklearn/rbm.py:
>
> > +        v_pos: array-like, shape (n_samples, n_visibles)
> > +
> > +        Returns
> > +        -------
> > +        pseudo_likelihood: array-like, shape (n_samples,), optional
> > +            Pseudo Likelihood estimate for this batch.
> > +
> > +        References
> > +        ----------
> > +        [1] Tieleman, T. Training Restricted Boltzmann Machines using
> > +            Approximations to the Likelihood Gradient. International Conference
> > +            on Machine Learning (ICML) 2008
> > +        """
> > +        h_pos = self.mean_h(v_pos)
> > +        v_neg = self.sample_v(self.h_samples)
> > +        h_neg = self.mean_h(v_neg)
>
> h is sampled for the persistent gibbs chain. For computing the 
> learning statistics, by deriving the log probability w.r.t. the 
> parameters you get a difference between free energy derivatives. Which 
> results in using the mean field of the h's (see 
> http://www.iro.umontreal.ca/~bengioy/papers/ftml_book.pdf 
> <http://www.iro.umontreal.ca/%7Ebengioy/papers/ftml_book.pdf> page 
> 64). When computing the learning statistics, it's mathematically valid 
> and better to use the mean-field because it adds less noise to learning.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/scikit-learn/scikit-learn/pull/1200/files#r1755979>.
>

Thanks for the explanation. Makes sense as long as it is sampled again 
for the MCMC chain as you do below.
@GaelVaroquaux What's your opinion about this renaming, from `mode` to `eigen_solver` and `eig_tol` to `eigen_tol` :)
Hum, you're right. I didn't pay attention because the name of this metric is `Brier score`.
Can you use == ?
"is" can be dangerous for strings and as a special meaning
galazies :point_right: galaxies
I am pretty sure It won't work for all cases, but this is the only generic way I can see for the update combiner.
Do not worry, we can handle the remaining cases at c++ time
It would be better to start from 1.
Qt::UniqueConnection only prevents duplicate connections if both objects are the same, but since you're creating new handlers every time this will never be the case. Please see my comment about refactoring.
yes but I will do it later because I also need to add timeout to prevent the process from blocking on error
Mostly out of curiosity, but why change from get('clientId') to get()'ing the whole object and then index it?
great

you read my mind
FYI you can add an actual link.
yes last row should have said last bucket.

>>but kept it allocated
>Keep the (empty) HT allocated?
Yes.

>>so subsequent rows were still deduped
>Do you mean add to HT after spilling for dedupping purposes, i.e. none will be output (addHash will always return false).
>And, it may get cleared (but not spilt) repeatedly

Yes.  Once it has spilt the hash table would only be used for deduping - as you do at the moment - but none would be output.

Partly because I was wondering if you should be doing this for all buckets.
Ideally, yes, but they get very hard to call cleanly.
Yes that was what I meant.
Should be a size_t (or strictly speaking ptrdiff_t)
you should use ``{@inheritDoc}`` instead of duplicating the phpdoc of the interface
Moving the connection store here prevents reuse of the open HTTP connection across requests. The connection should live across requests.
Add namespace statement?
you could write:

```
expected = list(Session.objects.filter(pk__in=[1, 2])
```

but this works just fine :)
please check this was intentionally committed.
Paul? Why you no like 4.8.2? Angry at Beck?
I would get rid of this paragraph. It sounds slightly awkward.
global variables suck. better solution?
Consider defining
```python
min_in, max_in = np.iinfo(dtype_in).min, np.iinfo(dtype_in).max
min_out, max_out = np.iinfo(dtype).min, np.iinfo(dtype).max
```
since it's used so often.
Don't use `matcher =`.
This won't work, as CDI won't reinject on reserialization. Need to find a better way to do this (e.g. inject Instance)
Handled in the terrain branch?
I'm fine with leaving it for now.  Maybe in the future we can have a "Defaults" object that can be required in that has all kind of default values that end users/developers can tweak at startup.
Deleted ;)
`nil` check is unnecessary; `[view isMemberOfClass:[TiUIView class]]` will return `nil` for the value. Does the compiler complain about the type coercion?