labofsahil/github-event-dataset-2012 huggingface dataset:
Maybe it's a translation difference, but I call it a "user account". Every member of a forum has a user account. \*shrug\* But I suppose for consistency, I change it.
I will handle this in an extra PR. It does not block this PR.
Please don't use prompt!
1. I will do… when I have finished writing it >_<

2. And then what should I do if I find an invalid xml tag name? Either: output invalid XML or: kill the script, outputting nothing but an error. I know which I would prefer.


It's also fairly simple to check whether there are database credentials in there, but I would argue against that, too.
please use the $db->sql_in_set method here.
The problem is not with config names but with CSS classes and IDs. They can't contain dots.
This also needs to be addressed ;)
nevermind, just needs to be used here at all :-)
Use double quotes instead of simple, for multi-line strings.
hahaha this is probably my favourite line ever
Document constructor
please avoid putting commented code in a pull request. if not needed, just remove
Use Ext.Msg.Alert(''...") here
to minimize typos like this, we should retrieve it from the Utils.
```
utils.uuids['prescriptionfillEncounter']
```
that way if we ever change the string we can just update it in one place
Toggling this on/off changes the theme
Don't need the ```~```.
zeros should always be returned if output is an int, even if the dtypes do match.
Can you change that to 5.2 please? Then I'll get it merged in.
please provide better name than Trolling
yes it has tests and what way of fixing this you suggest
nope, not intentional... I'll clean it up

Matthew Gidden
Nuclear Energy University Programs Fellow
The University of Wisconsin -- Madison
Ph. 225.892.3192
Fax 608.263.7451



On Mon, Nov 26, 2012 at 1:20 PM, Katy Huff <notifications@github.com> wrote:

> In auto_cleanup/checkDoxyLineLength.py:
>
> > @@ -62,7 +62,7 @@ def rasterBodyLines(body_lines,nspaces, offset, hard_limit):
> >              if (ext == 'h'):
> >                  files_to_change.append(path+'/'+file)
> >
> > -for file_name in files_to_change:
> > +for file_name in files_to_change
>
> is this intentional, don't you need the colon?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cyclus/cyclus/pull/423/files#r2226179>.
>
>
Is this method necessary if it's always returning `True`?
@dmethvin, for the record, prepend and append work on nodeType 11 (documentFragment)...
It's less obvious to someone unfamiliar with bitwise operators.
I'm suggesting adding the boundary check later than here.
We should include the other browser versions of this and the standard name, if it exists. Unless less expands this for us.
If we're using an up-to-date jQuery, you can do `$el.data('value')` to get the data attribute at `data-value`. It does some type coercion, too, which can get screwy with integers `> 2 ** 32 -1`, but I think it'll just give you a base-10 integer.
We require a stable URL in order to be considered for inclusion; also checksums don't apply to head (or any VCS checkouts).
There's no point for local variable. it can be as simple as `helper.func.apply(...)`
See above. Also, is there a way to avoid duplicating this check?
see comment above about the parent key
Here's an example of the opposite problem.  The code that you have in this step definition is much more appropriately moved down into either the data object or the page object.

I'm not sure what the issues are with the way the info is displayed on the page in Kuali, but I am fairly certain that you don't actually need to use an each_with_index method, here--and definitely not at the level of the cucumber step definitions.

If you want ideas on how to make this better, then we should chat and take a look at the page and the use case together.
Does this URL include the revision of the wiki page?
Um... why?  Clearer?  It seems exactly the same only longer.
Should raise an exception if both flush types are set
Here you should probably explicitly load the modules that you need (e.g. if you need testFramework you would probably be better off loading it as a separate module).
Nope, using that instead
Yeah, next up is /friends/facebook etc, but more importantly, this doesn't return entries nor can it be used for push or support all the same query args.

It's generated solely in response to the request and not the underlying data, a different kind of beast entirely (and pretty v0 experimental yet).

On Oct 11, 2012, at 1:20 AM, Simon Murtha-Smith <notifications@github.com> wrote:

> In lib/webservice.js:
> 
> > @@ -678,6 +640,56 @@ hallway.get('/types', function(req, res) {
> >    });
> >  });
> >  
> > +// friends are special, aren't they tho?
> > +hallway.get('/friends/all', function(req, res) {
> Seems like this should be /types/friends/all - any reason for it to live in the root namespace?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Ick. I know this wasn't introduced in this pull request, but I gotta say this feels dirty to me.
Also there shouldn't be a space between the function keyword and paren in this comment.
Similar deal with missing multi-line matches.  It's not that uncommon to have the arg list split across multiple lines, so I think this is worth adding a TODO or a bug.
Same comment as above regarding "also".
Raymond, I was curious why the attr.name is a space for issue 1312?
Typo - 'onces'
Any reason to use a span vs. a?
I would have expected this setter to actually change the appearance.
It is not handled, but it shouldn't break the client more than a normal UI error, or a network error, which is what happens. I could just `console.error` it for now, but it is an error that should not happen...that's why is treated like that. Do you suggest that I write it up in the console instead of throwing?
is this just to copy the array? I think 
    var emit_key = prefix.slice(0);
would be cleaner (took a while to figure out what was going on here).
The parenthesis position looks weird.  I prefer

```
std::fabs(tStats(i))
```
This line is a syntax error. You can't declare a function inside another function.
All these copy-pasted if that are preceeded by tabs...
Moreover, are you sure returning null is safe ? Won't it cause a NullPointerException ?
There are few lines you did not change, so maxence is still an author of this class. I think you have to put its name back.
@tnm, the problem is that when removing a note a commit obj is created and it needs an author and a committer. A hash seems like a reasonable way to pass them. 

I don't see how the note removal can work only with note's ``oid`` .  Maybe I didn't understand what you meant?
It would be better to do this on the `dispatch` method. Because this view also does GET and POST it is a bit strange to do it in `get` only.
Changed to MongoEngineBackend(mongo_auth.MongoEngineBackend):.
What have you been changing here, excepting breaking the indent?
Yes probably it would be the best if we would go over pull requests, or at lest we should check mistakes like that and maybe some good solutions which were found during some feature implementations. And then probably less mistakes would be made.
Why hotLoad when they're *not* logged in as opposed to when they are logged in?
This isn't an expectation based on computed value or state. If it were to fail, there is nothing this code could do about it. It's superfluous.
Should guard this, there is enough object creation and method calls here to warrant isDebugEnabled()
Why? strange to deprecate a private member so you probably have a good reason ;)
The ```scope = I18n.normalize_keys(nil, key, scope, separator)``` is not the problem, since scope immediately gets re-assigned after its value was passed and commited to the hash. On the other hand:
I propose you call the argument just "graphs" :-)
so its using the fixtures, which eliminates a lot.  What seems odd?
Well, the master branch of the library is the dev branch for 2.0. I want to think a bit more about this renaming, and about the issues related to the breadcrumb (see other comments) but such renaming would be done not long after the merge. But I will open a separate issue to discuss it
Worth it to either log or propagate the error? Looks like you'd get a throw in any case a couple lines down, so to my thinking might as well keep the extra context.
Why `AsEnumerable()`
Wasn't familiar with this, agreed.
Well sometimes that makes sense. But in this case it really doesn't.  Even if a module is already imported there's a not completely insignificant cost associated every time an import statement is called.  In this case, requires_optional_dependencies is being called at import time for each function it wraps, so you're just repeating that import statement potentially dozens of times.

In this case it doesn't really contribute anything to the startup time. But the more of these kinds of things you have it does start to stack up.  I had an in-line import in pyfits once that I didn't think was a big deal until somebody mentioned that it was run for every single HDU in the file.  And when it came to files with 1000+ HDUs it added over a second to the run time.
I suppose we could define "equality" here such that a Unit object could be equal to a Quantity, but they remain different object types. I think that's the right thing to do since someone who saw that line of code would say that they are equal, and I'd hate to say "well, they're not, because one is a `Quantity` and the other is a `Unit`." That's a detail of implementation and shouldn't interfere with the fact that what they represent are in fact equivalent.
this indentation looks weird (i would have put everything in a single line) but if that's the way it's done elsewhere i'm fine
At least n = -1 is undefined, as n is defined as unsigned.
ACK @gavinandresen
You should trigger_error here if validation handler is not found?
Should be `assertEquals()`, `assertEqual()` is deprecated.
Doesn't mess up other browsers right?
Ok, will have to use Kernel here as well. Let's see if I don't get into an issue of what Pre/Post runs first (Bootstrapper or this)
i created https://github.com/flack/createphp/issues/41
the sad thing is that fig did not want a general logger interface, so if we do something we tie to some implementation like Monolog (or at least the symfony logger interfaces)
gxmessage not available on Mac OS X, using Growl instead
Fixed, looks ok for the other elements
That said, libraries usually shouldn't print. Are you sure you don't just want to return strings, and leave it to the caller to do the printing?
That would be my getting used to vim and ^N. Fixed!
We should fix the problem more upstream where dust seems to be treating numbers as string literals...i.e. 0 doesn't evaluate to false, which leads me to believe its treating it as "0". {} should evaluate to true in keeping with standard javascript.
Works for me, I live in Greenwich!

...but, yeah, you're right. My changes just make it not return nil. It looks like it's using the current timezone. I'll keep digging and see if I can figure it out.
It's visually confusing for the keys and values to start at the same column like this. Maybe indent the values and wrap if needed?
I don't know - I blindly copied this from apps/mozorg/views.py   Jlongster?
What do you think of adding some kind of separator between each page? /nit
A comment explaining why you are doing this would be helpful.
these two lines can be collapsed into one: `res = self.get(status=200)` - you'd also need to make your `get` utility method accept the `status` arg (or arbitrary `**kwargs`) and pass it (them) on to `self.app.get`. The `status` arg to `self.app.get` asserts a given result status so you don't have to assert it separately.
It's not obvious what the point of this is. Is it for making writing unit tests easier? A comment would be nice.
Unfortunately, not every test requires this, thus the reason i have to add it manually. Only 13 out of 37 functions for this class use the "switch_is_active" nonsense. Will try to figure out what switches are actually being tested here.
Yes, it is. But because it is like this at several other places in zypper we have to find a solution for all those usages. WIP
An additional check (\0x99) is required to detect the trademark glyph for Loom under Windows encoding too.

The code looks fine, other than that small required change for Windows.
Can you use `DictType` rather than `dict` here? Means people can subclass dict (if they must).
the second part of the sentence is wrong. The Processor accept a config tree, not only a ConfigurationInterface
Can you remove the try/catch block here?
this is wrong. After binding an element, ``$child->getData()`` returns the appData, not the clientData.
should read `{{ choice.value }}` and `selectedchoice(value)`
Is it normal to have different values for the ``-moz`` and the W3C syntax here whereas they have the same value for the minitoolbar ?
this way to call it only works for closures in PHP 5.3, not for callables looking like ``array($object, $method)``. You need to change it to use ``call_user_func`` as we cannot require PHP 5.4 for Symfony
`setMessage` is deprecated, should be chnaged to `$this->context->addViolation()`
oops, sorry about that, that's already what you've done.
It may make things a little easier to read if you use `unless`:

```ruby
unless action['repository']
  action['repository'] = {'name'=>'unknown repository'}
end
They're replaced with the Ajax ones
Where does `guest@example.com` come from?
Test phases separated with newlines for this whole block
re: methods, yeah I agree somewhat, although I'm trying to cut down on callbacks in general, but not eliminate them. I find their "implicitness" leads me to forget about them and make mistakes.

re: Observers, not sure of the official opinion. I would generally check https://github.com/thoughtbot/guides or the code room.

My personal opinion is they feel like callbacks and I feel less control over their behavior. This seems like a good use-case for a callback (send a conf email or PM) but I'd like to give all of them a hard look.
Style: `}` on newline.
已做详细行注
Here using   Z3i::Point  for TV can induce all points with same coordinate 0 and provokes this warning:
[ERR]Warning quad not added due to identical vertex...
I verified the correction to the stipple pattern scribing some test white lines to the video fields by writing directly to the texture. With the original pattern the lines were not aligned correctly to the display pixels (zoom was set to original). With the corrected stipple the lines clear and pixel perfect.
I wanted to test how accurately texture lines were aligned to display lines and I discovered the inverted stipple pattern.
I guess you was trying to weave progressive video encoded as interlaced field pairs? Worth trying again then.
Right, fixed a078289
zaehlt die user, die einer division zugewiesen sind
can do this as a next step no problem
Why not make all the variable names less readable?
All of the _akanda_* methods make calls against the instance.  I'll refactor these out into a mixin for this and OVS.
Minor: the usual terminology for this is "sibling". We want to be a happy, gender-neutral family :)
Actually that (binding from an extension point) was one of `the` reasons we decided to separate private default drop handlers, so that users can simply "bind" drop_handlers to an existing extension point without harming the default handlers.

Since default handlers are executed at the end, they would not interfere with any custom handling. The file drop handler doesn't actually do anything unless you configure it with extensions, it is a kind of backward compatibility hook and also provides a very simple way of configurting file drop handling.

And, though we can probably remove file handler from default private handler, we would still need the tab drop handling. An alternate way would be hardcode the tab drop handling, but as it is now, the private trait indicates that this is not something you would normally want to modify.
I checked it, it is correct. we are getting only unique header items... I wonder if it hs handling the strange heaers like 1sgImper{+) with parentehsies and plus...
I am not sure whether you need this part when you remove the checkbox but I am not sure right now...
`.simulate()` is a higher-level concept, which is meant to come closer to real user interaction.
Because that was something I didn't change previously :-/
Same as above for the spacing issue.
It's possible that music is more than 1 hour...
I think we need this block, and change it into,

```js
#screen.locked > [data-z-index-level="keyboard-frame"] {
  z-index: 2045;
}
```
You would need to deal with settings app version of https://bugzilla.mozilla.org/show_bug.cgi?id=815595 here later (not this patch)
If the `unread-highlight` is an empty element that always go before `unread-tag`, use `unread::before` element instead.
Is cropping the right choice for the music app?  Or would UX and visual design prefer you to letterbox it?

If they want letterbox, you could fix that in a followup bug, I think.
jejeje I lose the head
update `GAIA_DOMAIN` dynamically in Javascript
This is such a simple function that I'd just nest it in the method above. It doesn't use this, and doesn't need to be a method.
we still need to store the ID ;)

this is the first time that we get the message ID here !
Recently at Happy Hollow, we visited the "birding research station", where we had a chance to see a ring-necked teal and ask, "Is that really teal?"

My daughter's favorite part was the old typewriter on which the field researcher would type out her field notes.  I explained what a typewriter is.  She also knows what a wired phone is, and may even have seen one once.
I've updated the README for future reference.
I'm not sure we should drop the tables if exist. I guess it is OK for dev purposes?
Fixed. The commit containing the change can be verified here https://github.com/felipevieira/freeseer/commit/0eca5403a0ccc1b8b8628234b121194037cec8b7
Funny =P Because you removed such `use` from rackspace one =D
to return asap
Not if you also pull https://github.com/SpoutDev/Spout/pull/1740.
Then SpoutChunk.get<X|Y|Z>() still works the same, and sinceneither SpoutRegion nor Region multiplies the base with the size this will fix those.

And welcome back!
why not change to 
```if not isinstance(qtree, dict):```
Starting from Windows Vista it is not possible to write C:\Program Files without admin privileges.

So if the game is installed in C:\Program Files (which is usually the case), it will try to do that and end up in wrong folder (Virtual Store).

App Data is proper way to do such things. 

Good explanation what happens is in chapter 6. Virtual Store:
http://blogs.msdn.com/b/chinmay_palei/archive/2011/01/16/windows-7-application-compatibility-issues-fix-centre.aspx

This way app can be installed properly in C:\Program Files and writing will work as Microsoft designed (to C:\Documents and Settings\username\Local Settings\Application Data).
why no $(this.embedHTML()) ?
wouldn't be 'BUTTON_RELEASE' be a better choice instead of 'BUTTON_NOPRESS'?
@randx Ok, do you want me to replace it with the following?

`````
custom_port = if web_custom_port?
  web_port
else
  nil
end
Can you please use `options` rather than `opts` for consistency. Thanks!
The host header of the request needs to be set to guardiannews.blahblah. This needs to match exactly with correct host in properties file by stage. But, er... webdriver deliberately won't let you set a request header. So you're caught.

http://willmer.org/kb/2011/07/selenium-webdriver-wont-let-you-addchange-request-headers/
load() in general, creates some callback functions for the AS scripts to call.  The logSocialNetwork is an unwanted hangover from R2 - I've removed it in a forthcoming commit. Thanks for spotting.
Random note: $! is actually set on a per-thread basis, despite looking like a global. Ruby has a few of these "thread-global" variables. IIRC the regex variables work the same way.

However, using `e` still makes more sense.
think MAXSIZE and MAXLOCATIONS are in the wrong order
Maybe something like HTP_REQUIRE_REQUEST_BODY?
> If we use a template, let's maybe use a templating engine,
> We now require Jinja2 for notebook why not for nbconvert.
>
Up to know the template is only for the header and footer... Using a 
templating engine just to add this pieces, I think it is a waste of 
resources.

> Especially, me might be able to use jinja2 for loop to do things more 
> cleany and just pass it an array of cells.
>
I thought this class in another way... I have chosen to build the array 
of slides inside the reveal class through the build_slides method to get 
the properly structure for reveal.js framework. Then, I just add the 
header and footer.
Why I did that? Sometimes, for example to build nested vertical slides, 
you have to add new <sections> encapsulating all of them. And for me (I 
have not used jinja before), using a *real* templating engine **when the 
template have to change because of the user choices** was difficult to 
foresight and implement.
Using `Integer.MAX_VALUE` (or anything close to it) makes it awkward to put future links to be determined on the other side of this one, though you could use `long`/`double` values. Better IMHO to choose largish but readable numbers like 1000, and leave some space (> 1) between defined links.
Should probably be `final`.
This is not necessarily the same - if `Capybara.server_port` has been modified between calling `#new` and `#boot`, this modification will not be picked up.

Probably a safer implementation would be to default the port parameter to `nil` in the constructor, and in this line do:

```ruby
@port = @init_port || Capybara.server_port || find_available_port
```
dá uma quebradinha nesses comentários maiores, fica mais fácil de ler =)
This would be better as an exception, with a message that clearly identifies the problem and the directory having the issue.  A java.security.AccessControlException would be good for this.

throw new AccessControlException("No write permission on directory "+logDir.getCanonicalPath());
doesn't this execute info.complete immediately, instead of passing the complete function?
Is raising `oauth.Error` generally the way that `verify_request` signals failed verification? If so I think 500 is the wrong error code here, wouldn't a 403 be more appropriate?
@nvcHilary ,deb rejected that one, he ask to change to include "/Login_Form/check_login.php";
Please check this, https://github.com/nvcDeb/CoinCod/pull/45..Is it what he means this??
When can this fail, and legitimately return `nil`?  I have a gut feeling that this is probably an error situation, but I can't pin down evidence either way.  Can you explain why this should return nil rather than raise an exception here?
Hrm.  This preserves the previous behaviour, which was to split just this same way, and retain only the first two components.  Well, except that it now doesn't mess up and drop part of the string.  Right now it should work, but not fully qualify the path on Windows.  Do you think that is reasonable, or should I try harder to handle things there?
I think we could use

```ruby
::Object.instance_method(:method).bind(@object).call(@method_name)
```

here too. Though I think your code here should be functionality equivalent?
Is there a reason we don't want a version number here? Or does openbsd report a name here with a version number?
I can remove it with ruby 2.0.0dev (2012-07-05 trunk 36314) [x86_64-freebsd9.0]
default `false`
i'm getting a failure when i use the mock cassandra, which i believe i
being caused by the following:

in get(), extract_and_validate_params_for_real() gets called, which maps
the column name being looked up to the correct type as defined in the
schema, so to_s() is invoked on the right class when doing the hash lookup
by column name.

in insert(), extract_and_validate_params_for_real() does not get called, so
to_s() is invoked on whatever the type is of the column name that the
caller passes in.  if it's a (ruby) Integer, say, when the column type in
the schema is LongType, it should be converted to the LongType.to_s
representation before being inserted.  instead, it's currently inserted
into the hash as a plain Integer.to_s(), causing get() to break (since it
does attempt to convert the column name to LongType, and a value like
"123456" isn't a valid string representation of a Cassandra::Long)

so this mismatch between get() and insert() (and delete() behaves like
insert() as well i think) is causing errors.  i don't know how cassandra
treats types in production, so perhaps my patch resolves things in the
wrong way and i should make insert() and delete() behave like get() in
looking up the type.  now that i think about it, that sounds like the right
thing to do.

does my explanation above make sense?

On Wed, Jul 11, 2012 at 11:26 AM, Ryan King <
reply@reply.github.com
> wrote:

> > @@ -449,7 +449,7 @@ def merge_and_sort(old_stuff, new_stuff)
> >          new_stuff = new_stuff.inject({}){|h,k| h[k] = nil; h }
> >        end
> >
> > -      new_stuff = new_stuff.to_a.inject({}){|h,k| h[k[0].to_s] = k[1];
> h }
> > +      new_stuff = new_stuff.to_a.inject({}){|h,k| h[k[0]] = k[1]; h }
>
> The prior behavior should match how this library works with a real
> cassandra cluster. Does it not?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/twitter/cassandra/pull/150/files#r1143019
>



-- 
-ilya
because it simply doesn't work, take a look at [`Math::rand()`](https://github.com/zendframework/zf2/blob/master/library/Zend/Math/Math.php#L68)
Also, this implementation is naive, as it does not check `headers_sent()`. While I advocate moving that check back to the response object, nevertheless, we need to check it _somewhere_, and this class does not check it all.
returns AnnotationManager
lol /facepalm 
Thank you! :)
I would call this 'else' :)
.... *sigh*, as I said:

                 V Space needed.
               // CraftBukkit start - Check for item loss (breaking)	
               if (this.count == 0 && entityliving instanceof EntityHuman) {	
                 ^ spaces needed -----------------------------------------^
It's interesting that you put this information here-- I listed the configuration options at the bottom. I'm impartial to where the information lies, though I think this location may make more sense in retrospect-- in any case, all of the options ought to be grouped together.
Why use `sudo tee` instead of just `sudo echo "..." > /usr/local/etc/nginx/nginx.conf`?
上述のように、この文字列にリンクが張られるといいほげ
I thought about that and wondered the same. My concern is that with the Install section first, folks won't realize that there's a "quickstart" option further down the page. Perhaps I can add some language to the Install section that clarifies that it's to explain the other, different install methods.
@guilhermeblanco will ask you to align the ``=`` :)
Wait, I think `Code.load_file` doesn't return the result of the file. Maybe we could change that?
Tu asi chcelo byt "#"?
Kazdopadne oba komenty by som kludne vyhodil...
Should I use extraParameters to override that configuration?
What about using http://necolas.github.com/normalize.css/ instead of reset?
? we need to remove this line
Doesn't the admin panel come with jQuery? /me seems to remember
Again, doesn't visible tell us they're present?  Why the separate checks?
Nit, but this newline isn't needed.
Nit: but is this a helpful comment?
Yeah, this is probably good advice. Of course there's not much guarantee that `navigator.id.get()` is totally stable, but given that it can take the same options as `request()` (which I only found out after changing to the Observer API) trying the smaller change first is probably best.

I will go ahead and close this request and issue a new one with the smaller change.
We actually don't even need this line as a seek gets triggered right after. Inside the seek listener for vimeo we do the currentTime check like you mentioned, so we should only set seeking = true then anyways. Gonna remove this.
Need one more } to close the opening {
remove the space after "text"
Does this need to be updated?
Psst, it's 2012. ;)
this declares the total days i think
Does exists a way to deal with Text -> String and String -> Text more elegantly?
Like I said in the desc, the ShadowFragmentActivity calls onCreate during transaction add/commit.
Fully agreed. I that also the Github stuff needs to be refactored in a dedicated class. After the merge I will look for this.
Will there be an exercise template 2?
Won't this produce `'td##ctl00...'`? Is the "td" even necessary?
Hello, I suggest this sentence

Vous utilisez %edition, cette version n&apos;est peut être pas à jour avec les dernières corrections et service packs. Contactez &lt;a href=&quot;%ez_link&quot;&gt;eZ Systems&lt;/a&gt; pour plus d&apos;informations.
And the sentence is...  removal :)
файлы стараются маленькими буквами называть.
I thought you said you had removed all the `clear` attributes..?
He doesn't mean the login page has loaded, he means the page we're currently on is loaded (eg the homepage).
Since that method would also need to iterate through the suites, it doesn't seem like there would be a clear benefit to that.
Hmmm, yeah, agree... I guess my editor must have done that during copy-and-paste.  I'll double check the rest of the code in these new files.
Merged the ones below into the appropriate tests.
Couldn't this just be contentId?
I think this is inconsistent with how content determines isMember / isManager -- just want to make sure it's intentional. Content will determine isAllowed, which traverses group hierarchy to determine if the user is a manager or a member. /cc @nicolaasmatthijs .
IO.getFileListForFolder already takes care of this.
I think options would work for radio as well.
I think it's cleaner to have one endpoint for adding a comment. Whether or not it's a reply feels like an artificial distinction.
Some of these methods seem very useful for things outside of the authz module.
Could these be moved to oae-util/lib/validator?
Interesting. I'm thinking that my ``fullName(IJavaElement)`` method in [FindReferencesTests](https://github.com/scala-ide/scala-ide/blob/master/org.scala-ide.sdt.core.tests/src/scala/tools/eclipse/findreferences/FindReferencesTests.scala#L139) could be useful here. If you think it would, what do you say if we put a FIXME note so that we won't forget to extract the needed functionality?
True, but that branch will only be reached if the final matcher is a UrlMatcherInterface, which does have setContext().
Should be `integer`
Yes, currently is not used in the codebase. 
If you want to introduce this feature, ask @willdurand please.
Кстати, тут еще хорошо бы проверить что x ∈ [0..100]
did you use gpg tool ?
"for authorization and to specify the objects to search."
Express 2.0 used both the res.local and res.locals alias in some capacity.  So this was intended.
Yah.... okay
Dette tregner ikke være en instansvariabel. Fjern `@government_slug` og bruk heller "government" direkte i viewet, som er det eneste stedet den brukes.
Why removing this? What should the following statements be expected to return?

 - `repo.Commits.QueryBy(new Filter { Since = null })`
 - `repo.Commits.QueryBy(new Filter { Since = string.Empty })`
you could do it in one line with list comprehension:

```
isthere = [ci in names for ci in bad_names]
```
make info default to None and then test if info is not None. Empty dictionaries in fonction signatures can be a dangerous practice.
zero mean is above
In MNE, the colormap is alpha'ed from fmin -> fmid. Since this (presumably) does not work that way, we should explain that this is different to users.
Wait, will these features be removed in v0.6, or only deprecated?
I stole this docstring (and code) right out of scipy, but I can certainly reformat it here to fit our conventions better if you prefer.
I really don't like these PowerMockito methods and you should be using Mockito whenever possible.
i think is easier if we define our dependencies by id (or folder name) instead of name. I am looking at possibility to use our own repository listing similar to bundles.laravel.com for extensions and themes
iterator to a "for" loop is "unsigned int" (OK, I am a bit too paranoid with object's types  ;-)  ).
Why was this file edited?
scratch that.  activesupport is not included by default.  it's a minor thing.
Thanks, I have added a note about this
Many bundles and packages suggest modification of `composer.json` and:

    composer update

My intention was to give a hint, that one should avoid updating everything.

The method:

    php composer.phar require doctrine/doctrine-fixtures-bundle:@dev

is simpler.
If the method returns itself each time and you have method chaining I won't indent the second line, but if the method returns a new instance it is nice to indent the next line. We have done that in the `component/config` article.
This is a `bash` block
...and a dot after this item
How about renaming this to `coverageReporter` ? Similar to `junitReporter`
your “fix” is a nice one ;-) ah, if only we could compile with `-optimize` …
Не, зачем переводчику <em>-то лишний раз видеть. Пожалей его тоже :)
baseUrl is now a constant.  Usually, Java calls constants by all upper case letters
Given that 1.2 is not released yet (although expected soon), I am inclined to support 1.1 at least.
I left it to lookup the host ip each time as in the setups i have done (and in graylog 0.9.7) i used WRR DNS to distribute load between graylog servers
Reviewing this. first observation: it's not having copyright headers.
Might be a good idea to have it generate copyright also on the generated parser.
for the route generation case it expects the route to have a _locale placeholder i guess.
The more and more I look at this PR, the more I can't bring myself to accept it.  I would rather fix the underlying problem.
Oops. Yes, of course.
hatch_style[2] should always be a string (and thus hashable)
Yum config documentation states that baseurl and mirrorlist can be used.

```
This can be used instead of or with the baseurl option.
```
"sous-espace**s**"
Terrible idea. It's only a cheap way of protecting class files on poorly configured. shared hosting servers. 

It goes against the principles of php-fig.
Does `deleted = false` work?  Should it be `deleted = 'false'`?
Windows equivalent is written in C#, not bash. See remark on agent_config.rb
I just read up on it a bit further and according to http://mudge.github.com/2011/01/26/passing-blocks-in-ruby-without-block.html, it looks like it's the declaration of the `&block` that causes the performance hit (since it has to instantiate a `Proc` object for it), so I would make sure to remove it from the method declaration as well.
you should use ``defaultFalse()`` here
I'm still concerned that we can see `s->hazard == NULL` here if we race with a close.  That is, we see the active flag set, then get descheduled and the session is closed, then wake up and read `s->hazard` and it is either `NULL` or pointing to memory that is freed while we look at it.

The simplest way I can see to make this safe is to not free session->hazard until closing the connection.
An instance of Slugifier.
Are you sure that ``$options`` (of type ``*``) is traversable?
Are you sure the variable ``$this`` exists, or did you maybe forget to declare it?
Download the file and include it instead of using link
Why the delete here instead of just `@attributes['uri']`?
Why adler32?

Also, you should not use ``+`` for string concatenation. Use string interpolation or ``''.join(...)``.
Shouldn't we just require a folder to be specified?
@bryanwb why did you use Chef::Resource::Execute instead of shellout?
nit: double space after "for"
Используй xml-documentation для всех публичных контроллеров и методов.
Fixed and made protected.
I would prefer this a dict:

config_values = {
    "msg:ignore": "",
    "irc:server": "irc.synirc.org",
   ...
}

Then, when you use this variable below, you can write the loop like this:

for conf_name, conf_value in config_values.items():
    currentConf = getConfig(conf_name, conf_value)
two spaces in this file as well
This is to show which venue was clicked?
No empty line here? Or more empty lines around the method. Just not like this.
Use `django.crypto.get_random_string`.
You mean a missing attribute number or a missing value for attribute number? If I iterate over number values stored in a list, and converted to int, conversion could fail in a case when value is missing, because it would try to convert empty string.
Ok, i moved this line in else.
You think that on every page rendering we will be doing a HTTP request to Google to get its image? This is a bit too much, no?
Spaces around `*`.
Read here:

https://docs.djangoproject.com/en/dev/topics/i18n/formatting/#locale-aware-input-in-forms
https://code.djangoproject.com/ticket/13339#comment:11

So yes, it seems this will not work. You will have to parse it manually. Yes, you can internally use dict for mappings.
Hmm, I read somewhere that get() is more reliable than [].
Дебаг режим в "production"? :)
Should correct these notes - 0xFEFF0901 indicates a directx 9 (minor version 1) effect object, and it probably should be made clear that GLSL is our own custom format.
Hi David, Just saw this a few minutes back. I had left it out. Now I have got it patched and will push it in in a minute.
better to indicate in comment line :)
Good point.  I'll fix this.
I just ran it, and it does what conor thought it would.

please, please, please at least run things before you check stuff in. you can run our project on attu if your vm isn't working.

don't leave it to someone else to catch trivial problems like this. this could easily have been overlooked and merged.
This line will look recursively through the templates directory (and any subdirectories) and return only files (no need to deal with . and ..). It then maps the basename of the files with the erb extension removed.
yeah, oops
sorry


On 16 March 2012 12:00, Chris Boulton <
reply@reply.github.com
> wrote:

> >        */
> >       public function perform(Resque_Job $job)
> >       {
> >               try {
> > +                     $this->log("afterFork being triggered",
> self::LOG_VERBOSE);
>
> Debug code? :)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/chrisboulton/php-resque/pull/49/files#r566325
>
This is the first problem I am having with the DIC. If this name param is injected, then the it is also injected on each of the Symfony\Component\Console\Command instance, overwriting the name defined in the class file, and breaking the CLI.
Yeah I like `resolvedFakePromise`, makes it nice and clear what it is.
Should use double quotes throughout the file. We only have single quotes in legacy code (or right next to it).
Actually, I don't think I need any CHECK here.  When I was less sure I understood nginx's configuration sequence I wasn't confident that handler would be initialized yet here. 

Check removed: ce5a23c
I agree -- I'll add this in. Plus, I want to do at least a few unit tests for this routine as well.
This seems wrong. You're not supposed to delete the item here I believe.
全体的に無駄なスペースがあります。全て削除するようにしてください。
```vim
set listchars=tab:>-,trail:_
```
This one fails on my local machine saying that the returned value was `"Vor 322020420 Sekunden"`.
@camertron Should a change like this be in a separate pull request?
The name of this class seems odd.
Why not `title` block?
Can you check to see if error is !NULL before calling g_error_free.  Otherwise, I think we will get a warning in the logs.
The error codes actually become statuses in this spec.  So they will be capture in the event description.
no, i didn't, thanks for catching.  i will revert.
s/assocaited/associated
Sorry - will do in future. 
What's best Gitiquette here? Should I tidy up the braces on my fork and submit another pull request?
If we don't mind adding the dependency, then great. Or if it is already there even better.
avoid star imports
not necessary, we've just registered it above
Strange to use $RUN_DIR in most places, but then %s with getRunDir() on the next line.
But too minor to worry about...
again, no need i think ?
Refatorando:
 
       data_queryset = super(AppCustomManager, self).get_query_set()
        if availability is not None:
            if not isinstance(availability, bool):
                data_queryset = data_queryset.filter(is_available=availability)
                
        return data_queryset
thanks, that should be fixed now
These are for reading logs. Generally the log format on disk is fixed once (or seldom) and read over and over. It's nice to be able to say:

class LogDataSource(implicit dr: DateRange) extends DailySuffixLzoThrift[LogObject]("/path/to/log", dr)

but you're right, you could just pass that in (unfortunately, that would be a big internal change, so I'd punt on that now).
i agree. i think i first added the event code into application.java then factored it into its own class. this change just must have got left behind
I didn't have OBController but I'm all up to date with the original repo now. Thanks.
去掉debugger吧
I wanted to leave links out like this so we don't run up bandwidth charges for people like Chmouel. Is there somewhere else we can host this box?
`daate`
Формат JSDoc не корректный - http://code.google.com/p/jsdoc-toolkit/wiki/TagReference

```
description
%new_line%
@param {Type} name description
@param {Type} name description
%new_line%
@return {Type} description
```

```javascript
/**
 * Создает новый экземпляр Circle по диаметру.
 *
 * @param {number} d Диаметр окружности.
 *
 * @return {Circle} Новый объект Circle.
 */
Circle.fromDiameter = function (d) {
    return new Circle(d / 2);
};
```
А если меньше нуля?
@shacker I was thinking about the fact that other apps on your machine might also use the `postgres` user after the `initdb`. If we set a password here, the likelihood of a conflict will increase.
based on my research, numerical character reference does not come free in Jersey library.
This is probably better expressed as `uri.query.nil?` and letting the empty-string fall through to the else: 284f8080b30309ee81fd861d5b94c03b4fda1fae
nvm, ignore.
Can you tighten this locator with something like `div.preview-successful` ? When you open the media tab the locator points at something completely different whereas if it's targeted a bit more then when the media tab is open the locator fails.
It will protect a little against bad workflow in the test.
Sounds reasonable what you say, so then throw an exception. The only place where I can think of this failing is in the Syntax Coloring preference page, that has a dumbed down read-only editor.
I understand just saying to avoid recommending access via LDA.label_encoder_.classes_
> Isn't y optionally [n_samples, n_targets] now?

fixed
It does, using either micro or macro or "weighted" averaging:

```
>>> from sklearn.metrics import f1_score
>>> f1_score([1, 2, 3], [1, 1, 2], average='micro')
0.33333333333333331
>>> f1_score([1, 2, 3], [1, 1, 2], average='macro')
0.22222222222222221
>>> f1_score([1, 2, 3], [1, 1, 2], average='weighted')
0.22222222222222221
```

And `zero_one_score` does as well:

```
>>> from sklearn.metrics import zero_one_score
>>> zero_one_score([1, 2, 3], [1, 2, 2])
0.66666666666666663
```
On Sun, Sep 30, 2012 at 06:30:37AM -0700, Satrajit Ghosh wrote:
> whether it would be more useful to add options to spectral embedding
> (like kernelPCA has options for various kernels) or to write a separate
> estimator

If you want to write a finite time diffusion, I would suggest to
implement a separate estimator, as the spectral methods really rely on
the eigenvalue problem.
See [2] Ji Zhu, Hui Zou, Saharon Rosset, Trevor Hastie,  "Multi-class AdaBoost", 2009.
Param**e**ters
Remove the comment and use correct indentation please
only tiny change is that I renamed this to `connect` in Connect to match node's names for these events
OnPrint doesn't seem to be invoked from anywhere, unless i'm missing something
Just as above here there is an assumed configuration of the delegate ViewResolver. I'm guessing with prefix but without suffix? Same suggestion as above.
unfortuntately both the PDF and the HTML renderer don't allow a large page width. On the HTML preview this example is rendered with an horizontal scrollbar, making it pretty hard to read. On PDF you can't read it, as what doesn't fit is removed.
Could you please review the example code to format properly?
Agreed.  See  HPCC-7821 as noted above.
can do, wouldn't normally with these operator precedence cases, i.e. equal
avoiding a warning re. precedence
This is an intereesting usage, but it would mor normally be used to provide an intelligent error message from a query that failed (e.g. 'Too many associates found' in places of 'Limit exceeded in thor_data::rels::20120606' )
please insert a copy of the MIT license here
This could be turned into a method and thus be a lot smaller and easier on the eyes.
missing space after the ``if``
Please use the bracketed notation:

```python
VCS_MAPPINGS = {
    'cvs': {
        'cvs.mozilla.org': ('http://bonsai.mozilla.org/cvsblame.cgi?' 
                           'file=%(file)s&rev=%(revision)s&mark=%(line)s#%(line)s')
    },
    'hg': {
        ('hg.mozilla.org': 'http://hg.mozilla.org/%(repo)s' 
                          '/annotate/%(revision)s/%(file)s#l%(line)s')
    }
}
```

The `+` is an operation on two strings. 

</extremenitpicking>
Let's not put this in the public sample config.
Ok i move values and values_list in the new contrib/collections.py. But i want to keep both, they, as in django, do not respond to the same needs
Not sure my remark was clear: my question was about the "dict or tuples" possibility.
Can't we just chose one of these?

About the moving thing to contrib: I think `instances` is a core feature ; about `values` and `values_list`, I'm more on moving to contrib, as you suggest, but I'm not opposed in keeping them in core.
Please use the Composer\Util\Filesystem::removeDirectory method instead of relying blindly on unix utils.
Ifyou type hint the StorageAdapter you no longer need to check if $storageAdapter is of type StorageAdapter ;)
It's because vars are computed before classes, and at the first iteration, the vars @(apache_modules) isn't defined yet
With new update, I incorporated $apply along with your suggestions
this class doesn't seem to have Javadoc though...
Like above, this is the same as `(map second collection)`
All looks good:

https://gist.github.com/4113707

I created install with test-keys signature then android:deploy failed with inconsistent certificates. After removing the test-keys signed version was able to deploy using android:deploy.

Thanks,
Nic


On Tuesday, 20 November 2012 at 7:40 AM, Nic Strong wrote:

> Yes I will be at work in 1 hour I will do extensive testing then.  
> On 20/11/2012 7:39 AM, "Manfred Moser" <notifications@github.com (mailto:notifications@github.com)> wrote:
> > In src/main/java/com/jayway/maven/plugins/android/AbstractAndroidMojo.java:  
> > > @@ -605,7 +605,12 @@ public void doWithDevice( final IDevice device ) throws MojoExecutionException > { > try > { > - device.installPackage( apkFile.getAbsolutePath(), true ); > + String result = device.installPackage( apkFile.getAbsolutePath(), true ); > + if ( device != null )  
> > I updated this in master. Can you test it for me?  
> >  
> > —
> > Reply to this email directly or view it on GitHub (https://github.com/jayway/maven-android-plugin/pull/148/files#r2170756).  
> >  
> >  
>  
>  
>  
>  
>
I have add a option for mkfs.xfs cmd, and the force option  is off in default.
totally not cool eating exceptions
Default should still setup the "default" LWRP.  the action can be nothing, but the convention is to set up the resource in the default recipe.  Then this recipe would only call action :install
What's the reason for testing this?
Yes, of course, you are right.
Print some more informative text.  Simply running the example prints "brick, brick, glass" on my machine, which doesn't tell me much.
Please use 1.8.7-style hashes - we want the tests to run on 1.8.7 (for now, at least).
Can the guest api not have specific references to mysql. Not an issue but would be nice to not deviate, even though we are specifically doing this only for mysql. The same for stop_mysql