labofsahil/github-event-dataset-2012 huggingface dataset:
I didn't expect straight iteration to be so slow but on average, pop(0) is better than your shifting approach:

```

shifting vs popping

>>> tot = []
>>> for i in range(5,50):
...   a =  timeit('while x: y,x =    x[0],x[1:]','x=range(%i)'%i)
...   b = timeit('while x: y=x.pop()','x=range(%i)'%i)
...   tot.append(a/b)
... 
>>> print sum(tot)/len(tot)
1.01592722568



shifting vs shifting in place

>>> tot = []
>>> for i in range(5,50):
...   a =  timeit('while x: y,x =    x[0],x[1:]','x=range(%i)'%i)
...   b = timeit('while x: y,x[:] = x[0],x[1:]','x=range(%i)'%i)
...   tot.append(a/b)
... 

>>> print sum(tot)/len(tot)
1.00732532433


shifting vs iterating

>>> tot = []
>>> for i in range(5,50):
...   a =  timeit('while x: y,x =    x[0],x[1:]','x=range(%i)'%i)
...   b = timeit('for y in x: pass','x=range(%i)'%i)
...   tot.append(a/b)
... 
>>> print sum(tot)/len(tot)
0.0997246226469
>>> 
```
Could you check that these exact errors are still relevant (the stuff in the XXX examples)? More generally, could you check that each if branch is used only when necessary?
Is there any advantage to keeping track of what's been seen and using the skip option to not scan that branch of the tree again?
I am not expert on this theme at all!

Well, lets leave as is now. I ran the tests now.
I suspect this can be integrated by forcing deep=True when mul=True
There are non-Basic instances in args.
Oh crap! I've mixed up course and course_membership again. Sorry about that.

I'm thinking we don't need `CourseMembership#instructor?` at all. Since we want to know if a given person is an instructor of a course, what do you think about having `Course#instructors` to return all instructors and `Course#instructor?(person)` check if `instructors.include?(person)`
Yes, I don't think it's reasonable to store these paths. Instead, I introduced TLS Config which is actually used.
Again, you should determine these indices somewhere, not assume a fixed set of indices. They *will* change once we start constructing the density plots from the quantiles.
I suggest renaming `uv_run_flags flags` to `uv_run_mode mode`. 'flags' suggests it's possible to OR them together.
Declarations go at the top.
This one is used in test\test-spawn.c:745
Using strndup() here is superfluous if you're calling strlen() anyway.
あ、なんでもないです、nullでも`NumberFormatException`でるのか
Also, if you're satisfied with the new tags field, this can just be deleted
You may want to use variables so you don't have to repeat it (expectedFirstName, expectedLastName). The first name was set with the code points before.
Actually… I'm not!
Coding style needs fixing here.
Is that supposed to be a dash?
In that case having a base class makes no sense. Each controller should assign its own dependencies.
This should probably be `$this`; it's more readable, and it's what the rest of phpBB uses.
You should probably revert this change.
Even though, because this is a static class, it cannot use the dependency injection container (unless I am mistaken), it should at least contain an initialize() (or similar) method that is called at the top of any files in which it is used. Something like:
```php
static function initialize(phpbb_auth $auth, phpbb_user $user) // Add any others of course
{
    self::$auth = $auth;
    self::$user = $user;
}```

Then in, for instance, viewtopic.php:
`phpbb_content_visibility::initialize($auth, $user);`
tab this in pls
In C++11 it could be just:
```cpp
for (auto renderable = this->renderables.begin(); /* */) {
```
> WIDTH / 1.0f / HEIGHT

Oh my god.
Cool. Just a tiny heads up. If we for some reason were to reject this pull request, then we'd not get the NCrunch stuff. So it would be better to send a separate pull request for each "feature" change. Most likely not going to be an issue this time though :)
I think it is 119, not 120.
take -> takes
Yes. Thanks. Your way is much cleaner.
get_data_type()
first i got the faction id with players team then i edited somthing and again forgot to delete Team sry
"will not be built"
What else should we do? Raise an error? Not use a table-wide default for that column (and thus potentially not be able to add it)? This has caused issues in the past, certainly, when the function behind there is random.something.
Here we only parse complete teletext lines.
(into {} (for [[k v] m
                 :when (seq v)]
                [k v]))

Just as clear, saves iterating over the map twice.
Just because it's not the source, doesn't mean it shouldn't follow the style guide LN19-28
path, prev_top1_array, curr_top1_array, prev_norm_array and curr_norm_array, they don't need to be ArrayType.  You can use ordinal int*, as they are used only inside this C function.
This file is a Wix template for the installer.
Don't we need to ensure uniqueness for the combo of `page_url` and `site_scan` here, since we use `get_or_create` in the pipeline? Which probably also means we need `page_url_hash` here as well?
Hmmm... does this actually install Metis? If so, this creates a nasty clash with the `metis` formula that we should take care of.
`"#{sbin}/darkstat -i en0"` ought to work.
Defining "CMAKE_BUILD_TYPE=None" breaks at least the eigen formula (see https://gist.github.com/2793020).
Would make sense putting the CGI escape directly in the page? (Demeter)
This class is not usable?
Cool! Thanks @schneems.
Typo: javas should be javascript.
Try to keep lines under 120 characters wide since this is the width that Github begins to cause scrolling in the code review.  In this case, I would wrap each parameter on a separate line like so:
```
self._training_params = {
    'errtol':errtol,
    'maxiterations':maxiterations,
    'learning_rate':learning_rate,
    'lam':lam
}
```
Can you recommend, in the comments, a good tutorial for people (let's face it, like myself) who might want to edit this code in the future, but aren't fully versed in the idioms being used?  Thanks.
The reason is that runs is usually translated into "ausgeführt" whereas "läuft" is slang adopted from English.
That comes from styles/bootstrap/patterns.less ``.modal`` class. I'm essentially pushing this value down to ``.modal-header`` and ``.modal-body``.
Ah, thanks. I didn't follow that right.
Indentation on these 2 lines
these vars are no longer used
Typo? Should be найден
Yeah, having all that in one variable is much better. And adding a comment like that is probably good enough.
hah, that's much better.
Is this line really needed to fix the problem? I'm not sure what is does and if it's a potential regression source.
$1: here is the rename of run.sh
Write together.
Yes. Tests are to use test.conf to disable the UI.
I need CSS for the crash reporter dialog to work, having Dialog ready isn't enough.  This is the soonest that our CSS is loaded, and since the crash reporter is UI (i.e., we don't want it if UI is not enabled), it seemed a logical place.
Why does this happen in the UI code? Might a better place for it be in `main.js`? It relies on `dialog`, but they should be loaded in `main.js` anyway: https://github.com/mozilla/butter/blob/master/src/main.js#L25
multi-line object literal please
I agree it makes sense for a PoolManager to have something similar to _new_conn. Naming-wise though, I'd prefer to also call something connection-related, perhaps `_new_conn``as well. Specifically, if you look at the surrounding methods (connection_from_host, connection_from_url), they refer to the pool they return as a connection, because both pools and pool managers are `ConnectionPool`-like objects. Does that make sense?
ngx_pcalloc -> ngx_palloc?
I think it's not necessary to memset the content if it's going to be set by 'memcpy'.
This should probably not be here?
Do you want to put `_` on these exceptions?
That's a very good suggestion.  I had actually forgotten about the 'navigation_element'.  (I actually added that long long ago so that we could support the 3rd level nav in the pane).  I'll look at using that element and possibly rename it throughout.
i assume we need to check for both promoting and deleting in the 'if'
This seems incorrect, why was the length restriction removed?
There are cases when due to floating point errors, the imaginary values are not zero. I cannot come up with an example right now, but I have encountered it with numpy while taking fourier transforms using fft. So added the tolerance.
plot(cos(x) + I*sin(x)). This is converted into real values when you cast it to a list further in plot. Hence an exception in numeric.py
I changed it after re-looking over it =)
不写log么？
You should return the name ;)
Revert this change per previous comment.
nit: remove the log to the console
Suppose we also modified the `ConstantDefinition` class so that the `.em` attribute is `None` or a string representing the EM system.  Then we wouldn't have to rely on this hackery like parsing the variable name to get the system.  The variables should probably still use the name they have anyways, but this would still be a little more explicit.
Ooh, I also like @wkerzendorf's suggestion from the thread on E&D's API of allowing something like `format='hms dms'` where the format of each component can be specified as a single space-separated string.  Again, a tuple could also be used here, like `format=('hms', 'dms')`.  Or just `format='hms'` if they're both meant to be displayed in the same format.
All public methods should now have docstrings!
This is a nice general function to have.  I wonder if, instead, we should just allow any array -- something along the lines of `np.isarray(obj)`.  Object arrays would have to be dealt with specially, but I think everything else should work.  Do complex numbers work in JSON?  Maybe not.

I also wonder -- and we don't have to do this in this PR, if this would eventually belong in a separate module for JSON handling (as we already have a package here for XML).  I can imagine that we'll have more JSONy things down the road.
我觉得起名叫g()的方法是个好主意，既然这样，那域名也叫g.baixing.com吧，一致~
That would certainly make it closer to the previous behavior Happy to change this unless anyone objects.
If this process takes a few seconds (or more), it's IMO worth adding a ``uiInterface.InitMessage(_("Verifying database integrity..."));`` message here.
Shouldn't this probably be Bitcoin-Qt.lnk anyway?
I'm fine with the ternary as well.
the
if (isset($_GET['value'], $_GET['filter']) && isset($filters[$_GET['filter']])) 

will fail for an invalid filter even if $_GET['filter'] is set, we could perhaps catch that with an 
	elseif (isset($_GET['filter']))
	{
		$filter = array();
		unset($_GET['filter']);
	}

to clear out anything bogus as a catchall
A little cleaner to use Callable\<NodeMetadata.  Then allAsListcan have correct type.
It's ok, it gets output as a string later anyway (with no calculations or anything)
We probably don't want to ship with this
I guess you figured it out?  You're not seeing something weird that I am missing, right? (besides the weird nesting of #ifdefs)
You should be able to use `$.data` instead:

```javascript
var $origin = $(this);
var video = $origin.data('videoSource')
```
Which function is this decorating?
I see below that the aaq view is covering all the steps. Sorry about that.
Probably you wanna add an empty line here.
yeah, I guess it was an attempt to make it obvious what those things were.  But since I only used each one in one place, it's true, they provide little to no value.
What if line 42 fails then line 51 will fail too. 
Don't you have another pattern where you first create `connection=None`?
@Vader19695: Standard libraries shouldn't be required in the controller (or any framework-level file). A better place for this is in `config/application.rb`, where I've moved it.
Why do you need to add classes here?
The question is: does it work? :-)
Historically, `Date.parse` has been quite slow.  I think it's a lot better in 1.9.3 than prior versions of ruby (I think I heard it's in C now), but this should still be faster, I think.  `Date.parse` handles many different date formats, and it has to be tolerant of you using any of them.  Here we know that we have 3 integers, which is exactly what the normal constructor needs, so we can bypass the complicated parsing logic entirely.
@RayFromSquare had an idea once to allow for arbitrary REST mappings via annotations. We could support our ridiculous use case with the 5 callbacks but by default we'd provide a simple implementation that would look something like this:

```java
public interface Callback<T> {
  @RestResponse(from = 200, to = 299)
  void success(T response);

  @RestResponse(default = true)
  void failure(RetrofitError error);
}
```

Then the consumer could extend this (or provide your own) to customize functionality.

```java
public interface AuthedCallback<T> extends Callback<T> {
  @RestResponse(401)
  void unauthorized(RetrofitError error);
}
```

Too complex still?

Another option would be to only provide something like `Callback` above and then have us wrap it in an abstract class like so:

```java
public abstract class SquareCallback<T> implements SimpleCallback<T> {
  public final void failure(RetrofitError error) {
    int status = error.getStatus();
    try {
      if (status == 401) {
        sessionExpired(error.getBodyAs(ServerError.class)); // getBodyAs uses supplied Converter
      } else if (status > 500) {
        serverError(error.getBodyAs(ServerError.class), status);
      } else if (status > 400) {
        clientError(error.getBody(), status); // getBody would use the generic type here
      }
    } catch (Throwable t) {
      unexpectedError(t);
    }
  }

  public abstract void networkError();
  public abstract void sessionExpired(ServerError error);
  public abstract void clientError(T response, int statusCode);
  public abstract void serverError(ServerError error, int statusCode);
  public abstract void unexpectedError(Throwable t);

  public static class ServerError {
    public String title;
    public String message;
  }
}
```

This would also allow for extreme customization to suit the endpoints need while providing strong typing.

Thoughts?
you missed another "client browser" in src/Symfony/Component/HttpFoundation/Request.php (there were two of them)
There is no reason to have a setter for them. Commands are not meant to change the Output object they receive
Hm, I don't believe the mocked method is even necessary... I'll remove it
Hum not sure but I guess it should not be hardcoded in the property.
this should not use concatenation but query parameters (you can have SQL injection through the username currently). Btw, doctrine DBAL supports binding an array as parameter (which is not the case of PDO itself) so it is easy: ``WHERE s.identifier IN(:ids)`` and then binding the parameter as ``Connection::PARAM_STR_ARRAY``
It accesses the method for BC. Once we remove the method, all accesses can be removed.
I don't think we need to mention the phpdoc tag here. Mentioning the introduction of the interface is enough IMO
you should remove this extra empty line
Rather than wrap these two method calls into one I might register both methods as after_creates. The argument could be made that as is it violates the single responsibility principle. More just an observation. I think it's fine as is.

Another question on this topic, what does thoughtbot think of Rails Observers?
that is reason for ```|| output``` according to documentation if nothing match regex, it returns nil so original output is used.
`if (BooleanFunction() == false)` does make sense in some cases, because YCP boolean can be `nil`. But this case is not one of them.

What is probably poorly documented: the default value in map lookups also applies a cast to the result. So if you don't mind getting `""` insead of `nil`, like here, you can write:
```cxx
map<string, any> result = ...;
string err = (string) result["stderr"]:nil;
string err2 = result["stderr"]:"";  // shorter!
integer exit = result["exit"]:-1;   // a common idiom for bash_output
```
So
`if( ret["exit"]:1 != 0 || !IsEmptyString(result["stderr"]:"") )`
na estefade nakardam va yadam shod pakesh konam :D
Nitpicks:  else should be on the same line as the closing brace in PS's coding style, and "unsaved" is the correct spelling of the 4th word ;)
This `return` needs to be outside the `finally` block otherwise it will silently dispose of any exceptions.
Lets change the name space to SupaCharge.Core.Config

Note you'll have to do this for the test cases as well
soynode will compile an entire subtree, is dirs.map needed?
why is this error not in ``cms.exceptions``?
嗯，对，我改下
Why have the add/remove handlers as params, and not the "describe" stuff? I was thinking more the other way around, to expose the whole notion of "describe" as a formal part of the API.

Then an overloaded createSubsytemRoot(PathElement pathElement, StandardResourceDescriptionResolver resolver) could pass in the GenericSubsystemDescribeHandler stuff, serving as the convenience API for the common case.
Just as a reference for future - after looking at the remoting code, I can confirm that the close() on MessageOutputStream does actually decrement the outbound message count (synchronously). So it really isn't a issue.
How about giving 13300-13399 to Security instead and moving JDR to 13100-13199?

That effects fewer messages, and these SecurityMessages are the highest importance of all of them, so the ones we least want to change ids on.
This again is not bad, but saw in a couple of places for putting messages like '(3)', we will need to take into account this messages for l10n, so far is not bad at all :P
This file is only about busybox, but its name suggests it's about the whole |build| directory.  Can you please change the name?
If this is a bug, then when the bug gets fixed your code will break.  Maybe you could just use a heuristic that if you ever see a time value > 1000000 you assume it is microseconds and convert. Otherwise you assume it is seconds?  Would that work?
the string patterns used to build the REgExp are constants and should be defined appropriately. In addition the RegExp object probably can be reused
add below

    if (!app)
      return false;
And I think we can avoid the duplication.
The callback handleInitLogo, has the same name of the private function for the WindowManager object, is perfectly functional but prefer to have different names for different things.

Gracias loco!
you guys are cray cray
If you change this to `self.per_page = 100 ...` the tests pass again. Still a little confused why :/
ReadLine returns null at End Of Stream, so technically you don't need explicit EndOfStream call.
@brunomachado, I see two elements with same id in the same page. This one and the `p#title` on line 12 of this file. 

`id` attributes are supposed to be unique throught the page. `class` should be used when you need to target more than one element.
This probably shouldn't be hard coded.
Again using it right below, but will move it if everyone thinks it's weird.
I don't like setting filters by default for common elements because IE is known to get slower because of this.
Please don't beat me.
Then why store that "/token" in the database? Seems like it would be more clear to just add that to all of the requests. Otherwise you'll have to deal with adding/removing that when you edit users as well.
We need to make this much more generic... with this code, we can't rename clusters or deploy cassandra with other cassandra rings.
This verify operates on a separate stream context it seems. Verifying a connection unrelated to the actual transfer? This will probably lead to a client-profiling attack. (Eg let the cert check hit the real server, intercept the 2nd request)... this might need more review.
Perhaps this `"t('.make_something')"`
`https://developer.mozilla.org/en-US/docs/JSON#toJSON()_method`の記述がmarkdownのリンクの記法と衝突してしまってますね、、、。
どうしたらうまく書けるのかな。
To CSS
You should remove that "Closes ..." part as long as you don't have an actual ITP open.
why is this freed here and not in FileFree?
I think there is a leftover ```/button>```
Nit: Elsewhere we use different style:

```js
const { activateTab, getTabTitle, setTabTitle, closeTab,
            getTabURL, setTabURL } = require('./utils');
```

I'd prefer to be consistent in that.
In other words 'CustomEvent's maybe created and dispatched without any DOM nodes or attributes for setting data on them. Also I think custom message approach has advantage over postMessage as such messages are only received by a listener registered to that event type. In contrast postMessage dispatches message events and there maybe listeners registered for it already.
thanks for the pre-emptive explanation
I don't like actually including raw JSON files in the tests like this; I'd prefer to handle it the way I did for the perftest data structure sample, where the data is built up in Python functions with every element overrideable. The reason is that the latter is flexible for reuse later on when specific bugs with specific data edge cases are found and need to be tested. With raw JSON files you either modify the existing one and risk breaking existing tests, or you start to accumulate more and more raw JSON data, which is difficult to maintain.

I see now that the pushlog tests were done the same way; somehow I missed that or I'd have commented on it there as well.
What about if you put the `os.environ` line that sets `DJANGO_SETTINGS_MODULE` at the very top of the file? I wonder if some of the `google.appengine.ext` imports indirectly import something from Django that import settings?

Not that it really matters, if this works - I just hate having to add in strange boilerplate without understanding why it's necessary :-)
I've just implemented this, did you want me to revert it?
Good catch. This will be fixed in the next commit.
Cool. I like this line of reasoning. If we wanted to get fancy, maybe we make something that would recommend you add one. Or something. That's a 3.0 feature. :wink:
You're right, that's ugly.  Removed.
don't know if it matters, but mysql also supports `_` in `LIKE` for matching exactly one character:
http://dev.mysql.com/doc/refman/5.1/en/string-comparison-functions.html

dont know if this is SQL standard or MySQL specific
Or, alternatively, we can put them into a subnamespace. But let's wait to see how the development goes to make that decision.
Not really relevant to this particular pull request, but the use of the variable name "group" here seems unnecessarily confusing given the context of what we're trying to accomplish.
This does not do what you expect. QThread.isRunning() returns whether a QThread (in this case, the GdbReader thread) is running.
Now rubinius behaves exactly like MRI. In $LOADED_FEATURES we have full path to file.
If these methods are meant to be private, let's actually make them private rather than prefixing with an underscore. You can do that by putting them in a `class << self` block and using private inside it before the methods.
Use `yz_misc:get_ring(transformed)`
Or alternatively, change that method in the trusted kernel manager.
Sure. The code was written before the famous semi-colon discussion, and I was just following JS linting.
`indexOf` on arrays is not supported in IE7 (and maybe IE8?). Plus, if you switch to #RRGGBB for colors, I'm not sure what `.css('color')` will come back with, if they'll be the same format. I'd recommend associating the colors with classes, and assigning/removing those instead. Then we can easily target and change.
Oh, ok, any reason you can't just use Lodash templating directly?
private file for dist. i should remove it.
`=` here is base 64 padding, so it not always present, depending on byte length
As you can't inherit an already declared function you should delete this (signature, comment and docblock)

Also you should describe the purpose of this interface in the class docblock.
Can you add the missing pipelines (`|`) between params?
All of these methods should have a second, optional argument, $default, and it should be passed to whatever container the parameter is being pulled from. This allows things like:

```
$page = $this->params()->fromQuery('page', 1);
```
No param name given
Why are you coding the dumping by hand ? Symfony 2.1 already provides a tool for this.
typo ---> show_s_
Sorry about this, but I feel little annoyed every time I build the package. Maybe it's just me.
-> `if (todosStatus.length) {`
this is useless. The user is an object, so it is modified by reference. No need to set it again
We do not allow this. Please remove IDE dependant code.
Why supporting Criteria if no method implementation is changed? How can you do that?
Missing doc block comment
I would refactor this to use an instance variable for articles and a number of methods.
vendredi 2012-11-16 à 09:38:24 (CET), Alexis Metaireau a écrit:
> > @@ -22,6 +22,10 @@
> >  __version__ = "{0}.{1}".format(__major__, __minor__)
> >
> >
> > +documentation_url = "http://docs.getpelican.com/en/{version}".format(
>
> I would put that in capitals, if it's a constant.

This is sensible indeed :-)


--
Feth
used to be in docstring format or whatever """xxx""" is called.
same here, the [0] should be there imho
done i have change the meaning
Can you send pulls for this stuff to the archetypes as well, so we keep them in sync?
Right. I need to go back and fix a bunch. Copy/paste propagated the issue.

On 04/05/2012 11:09 AM, Pete Muir wrote:
>>
>> -This quickstart provides Arquillian tests. See [Run the Arquillian Tests](../README.html/#arquilliantests) for information on how to set up and run the tests. When asked to start the JBoss Server, this quickstart requires that you start it with the _web_ profile.
>> +                  mvn clean test -Parq-jbossas-remote
> OTT indent!!!!
>
> 8 spaces only!
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/193/files#r650527
Superfluous new line
The only problem is, Errai is now on 2.0.Beta3. The version in the BOM is 2.0.Beta2, and there's a critical bug fix in Beta3. We will send another BOM pull request.
Not sure I completely understand. Does the Jackson give me that?
Got it, and FYI it's `urlparams("/a/path", hash='services')` not `fragment`.
double quotes here, and whitespace
remove the semicolon from the end of the line.
You can account for this by checking to see if the test is within 6 seconds of the boundary. If it is, just set a timeout to fire after 5 seconds...many of the tests in this suite are like that due to the time sensitive nature of the tests. :)
It might be better to use straight python rather than ipython. If you have doctests later on, you will have to.
In general, I feel like we should avoid adding ids and classes until there's a real need for them, since they add complexity to the code without adding value. I've been in the situation where you're trying to update page structure or simplify css and it gets confusing if you can't figure out why an id is in there, where it came from, what it's being used for, etc. But Enigel's right, and if that's the only issue, then I can merge this in.
This line throws a `Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException` with the message `You have requested a non-existent parameter "kernel.bundles".`. I think you have to create a compiler pass if you want to check if the `LiipMonitorBundle` is used?!
Well if it's an organization then it should show location here and vice versa so that logic needs to exist somewhere. A helper might be in order here, but since the logic is display-only (and pretty simple) it seems like the view is the right place.
i think this is best to handle at the lib/model/foreman/ec2 class rathen then here, after all, it gets passed as part of the hash
This is hard problem...
I use `fnameescape()` for now.
If any problem is reported with this way, I'll switch to @mattn's way.
`'wildignore'` is a global option, so I think it has no major problem for this plugin.
Yes, we tried and it works (even on different locatoins), we can make a
warning if there's location mismatch

On Wed, Jun 27, 2012 at 6:00 PM, Tomasz Janczuk <
reply@reply.github.com
> wrote:

> > @@ -857,13 +866,20 @@ exports.action = function (cmd) {
> >  <CreateStorageServiceInput xmlns="
> http://schemas.microsoft.com/windowsazure">\
>
> During ```git azure init```, if a storage account with the specified (or
> implied) name already exists, I skip the storage account creation step
> (even if there is a service location mismatch between the existing storage
> account and the service location specified through parameters). I am not
> sure if the same logic makes the cut for you for affinity groups, or
> whether you want to enforce the equality of the affinity group of a
> pre-existing storage account with what you attempt to set up with ```git
> azure init```
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/tjanczuk/git-azure/pull/54/files#r1063672
>
On 21/12/12 9:12 PM, pozorvlak wrote:
>
> In app/controllers/members_controller.rb:
>
> > @@ -1,6 +1,6 @@
> >  class MembersController < ApplicationController
> >    def index
> > -    @members = User.all
> > +    @members = User.where('confirmed_at IS NOT NULL')
>
> This could just be my unfamiliarity with MVC, but wouldn't this code 
> be better-placed as a method on User? Similarly for the SQL in the 
> call to |find| below.
>
>

I suppose the same would be true of the recent updates stuff, too.

A.

-- 
Alex "Skud" Bayley
skud@infotrope.net
http://infotrope.net/
The reason for the copies is that there is an extra processing step: properties which existed previously but were changed appear both in the removed & and changed list from the session node changes. This is because the SessionNode does not use an "added" properties field.

Exposing this "as is" in the document changes, isn't as natural imo as having 3 clear sets: added/removed/changed. 

The same extra processing happens for the removed children & children inserted before: the session node will have in the list of removed children the children which have been inserted before another child. This also isn't "natural" imo for a connector to process.
I was debugging an issue where a query worked in librets but not ruby-rets so I changed the string to be encoded the same as librets to more easily compare the two. I used each_char as I did a direct translation between the librets java function and when i quickly thought about it at the time if the urlencoding the % which would now have extra matches after the previous replacements had been swapped out, so i figured it was safer to go each_char
I'm not sure, but I think there's also "sky coordinates" which would be different from "pixel coordinates" and "world coordinates".  E.g. imagine you have a survey map like [this one from Fermi](http://www.nasa-usa.de/images/content/317870main_Fermi_3_month_labeled_new.jpg) and you want to do aperture photometry with circles of 1 or 10 deg radius on the sky or PSF photometry with Gaussians of width 1 or 10 deg on the sky.

So the main use case I have in mind with "sky coordinates" is that you have an aperture or PSF which only depends on the spherical distance on the sky.

I think computationally photometry with "sky coordinates" would be similar to photometry with "world coordinates", because for each given position you first have to compute the binary aperture mask or weights image, whereas for "pixel coordinates" you just shift one given aperture mask or PSF weights image around the image.

Am I making any sense?

I'm not saying `astropy.photometry` should support "sky coordinates" necessarily, I just wanted to mention it as one possible use case and that the API should be clear here what exactly it can an cannot do.
Yeah... While I am typically moving toward $option arrays vs a potential bunch of arguments, setJpegCompression is basically a setter (as much as PHP has those). A setter shouldn't have multiple arguments, or $option array arguments. You wouldn't do setJpegCompression(array('pngTransparency' => .5)).... you'd do setPngTransparency().

and imageJPEG is a PHP function, and doesn't have any more possible arguments.

* Which implies there should be a getJpegCompression(), though I don't know how useful that would be.
Да я тоже не особо с github-ом работал. Вроде можно сделать еще один commit, а потом его добавить в текущий pull request.
i don't undestain your question... only said that use substr is faster than regular expresions
Here, you should use `definition` instead of `constraint` according to your Check implementation.
please update the doc comment for $node and say in $name that this is used in cases where $node->getName would not return the correct name (during move operation)
this should be ">=" condition (to support any version)
Strange, i did remember that this was failing a test. :|
Nevertheless the part when sometimes it clicked "See All x reviews" i could reproduce it several times.
I'll test it again, and if it happens i'll make a screencast of the issue, until then i will change it back the way it was.
perhaps I am dense but I don't know what that means
Members and Memberships lists are now "child" documents, which allow us to index them separate from eachother, and the resource metadata. members and memberships are now filtered using a `has_child` elasticsearch query. It is not inefficient as we have seen w/ Solr joins, as a strict parent-child relationship allows ES to route the child documents on the same shard as the parent, thus `has_child` doesn't have to consult other shards for additional documents.
Please specify that this is optional and what happens when it's not specified.
I think just having `/api/content/:contentId/comment` as the URL is enough. It can then take an optional `replyTo` parameter from the body.
Typo here, `a` with a hat creeped in.
The sys module has been renamed to util in version 0.7.8 that I am running. Perhaps we have to add a test to figure out which one to pick.
The alignement should depend on the user formatting preferences. You don't have to fix it now, maybe open a ticket if you agree ;)
And I didn't know that. Thanks for the clarification! :-)
Yes, I have though about this will lead to memory leaking if parsing fails. But if parsing fails here, will it necessary to parse the rest of the code, or just exit the compiler?
If that were the case we would need to add a guard around the attempt to
auto login in case there wasn't a username and pwd.

On Thursday, December 20, 2012, Jason Smale wrote:

> In app.js:
>
> > @@ -59,6 +65,9 @@
> >        var firstLoad = data && data.firstLoad;
> >        if ( !firstLoad ) { return; }
> >
> > +      this.store('email', this.settings.username);
> > +      this.store('password', this.settings.password);
>
> Ah ok. But we should make those settings not required in the manifest?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zendesk/harvest_app/pull/3/files#r2474448>.
>
>
Расстояние Хэмминга высчитывается только для массивов одинаковой длины, так что нужно или оставить как есть, или выдавать сообщение с ошибкой
у вас генерится случайное значение из 4 возможных, затем сравнивается с текущим, если они одинаковые, генерится опять и так до того, пока не получится другое. можно же сразу выбирать из 3 значений, исключив текущее
Again, gfx/fonts/fonts.c
@jason-sanjose The readme says `{USER}\AppData\Local\Brackets\cef_data` but the cache is being written to `{USER}\AppData\Roaming\Brackets\cef_data`.

Note that the brackets-app cache is also written to the Roaming folder.
Netbeans... :D
Total number of objects that could not be fetched.
Do you really need this check?
Not really.

CommonPHPDriver is alias for Doctrine\Common\Persistence\Mapping\Driver\PHPDriver which uses DefaultFileLocator for loadMetadataForClass.
@jspahrsummers I feel like we're talking past each other here. Did my comment on #94 clarify its role here?
I was actually going to put this into `<RACStream>`, perhaps with a rename to `+concat:`, since it seems generally useful.
BTW, I'm not sure the name of this test fully reflects its content ;) ^^
Shouldn't this be ZincJSONWritingOptions?
I think the ideal situation is:

      starts with /
          - resolved as an absolute path from the any of the roots (bases)

      doesn't start with /
          - resolved relative to the current file's directory.

Not sure if that really jives with this yet.

Maybe we can instead change the bases to start at src/ and then api/1.x/ ?
start test functions with 'test'. This should be testDefaultWeather
And I mean the list size cannot be guaranteed ;)  Run the test and check the size - it isn't the number of rows in standardTestDataset - that's because other tests add to the list.

Tests shouldn't depend on setup from earlier tests.
Not coherent with the previous change. Shouldn't be replaced by _new_?
should only check for comments by someone other than the pull requestor (?)
I used npy_intp instead of ssize_t because npy_intp was already used in mtrand for sizes and indices. 
https://github.com/numpy/numpy/commit/9bda193417b278dce14c22b1ac5c8bc1a6717365#diff-5
please see if the strip() comment above applies to all cases where strip() is used...
Ладно. Тут исправлять не буду, а на будущее буду писать просто
¿Para qué vas a usar el RelatedEntityType?
yes, the key being passed into is the pre-hashed URL, which hasnt at this point had the query string attached.
Wrong. It works for 2.0 as well
So correct me if I'm wrong, but the intention of creating a "singleton" module would be to only create one instance of VehicleCollector which would be globally available? That way you know you're referencing the one and only VehicleCollector? How would create a "singleton" module? Would it be on the module itself or on the Vehicle class? 

I tried implementing the code you provided above but I also couldn't get it to work. Specifically, I'm not sure what self is referencing in this context? 

What do you mean I'm reaching out to the main VehicleCollector module? 

Sorry, quite a few questions as I'm not sure what's going on!
Can you remove this change, I'll bump it when I release.
I see it (now)!
Ya thats how the openstack common helper class works. In the guest code im writing (which i will one day check in), ive created a _exec() so u dont ahve to pass those, but u can optionally pass root=True|False to it
What Info?
omg this is a mistake, forgot to remove this line :/
please don't add trailing whitespaces
Unnecessary empty line here.
@pelson That's a nice extension of @efiring's suggestion. I'm happy with that method, too. I'll leave this for a while and let others weigh in with thoughts and opinions.
You could probably just use two `yield`s here.
Why?

2012/8/23 Phedrik Benjabria <notifications@github.com>

> In bootstrap-tour.js:
>
> > @@ -41,17 +41,17 @@
> >          }, options);
> >          this._steps = [];
> >          this.setCurrentStep();
> > -        $(document).on("click", ".popover .next", function(e) {
> > -          e.preventDefault();
> > -          return _this.next();
> > +        $(document).off("click", ".popover .next").on("click", ".popover .next", function(e) {
>
> try use .delegate() instead off().on()
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pushly/bootstrap-tour/pull/17/files#r1446377>.
>
>
This should work:

`![Server Metrics](/images/servermetrics.png)`
I give this full :sparkles:
Dec isn't actually what we want - we need something like `(- 1 n)` here. But thanks for pointing it out - I had to think for a sec about whether we'd done it right.
Can we get rid of the if and make version.size return "NA" if there is no size? It would follow tell don't ask, and make the view more consistant on how it looks?
```if (xxx)```
whats this il here?
This was a related issue – destroyed bindings were sending their nulled-out property paths through this function one last time, and it was throwing an error because it wasn't properly gated. I suspect that there is a solution that involves preventing destroyed bindings from doing anything, but I couldn't track down whatever queue they were still part of, and nulling out their property paths and fixing this method to not throw up on nulls worked.
Use

```ruby
browser.alert.should_not exist
```
Why take this assertion out?  This was a real bug in the code previously: by taking this out are you saying that it is okay if syncop == 0 here?
I've fixed s_style, it was doing something non-portable to search for "return 0";

I'll add the check for snapshot_count == 0, I don't think it will make a measurable difference in common cases.  Single threaded code won't get this far because there will never be an update with an ID > snap_min.
Are you sure ``$this->events`` has the correct type as ``object<Zend\EventManager\EventManagerInterface>`` is not a sub-type of ``object<Zend\EventManager\EventManager>``?
- Are you sure the variable ``$feedRenderer`` exists, or did you maybe mean ``$feednRenderer``?
- The assignment to ``$feednStrategy`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
用于保存当前歌词
If @keep_count > 1, you'll get an array of arrays:
`{0=>['null']}.to_a.sort.map {|(num, results)| results} #= [["null"]]`
else only an array:
`{0=>['null']}[0] #= ["null"]`
Is that expected? or should it be `[@hash[@hash.keys.first]]`?
Maybe we can go for something like `l10n_date`?
Why are you removing this? This increases the chance of breaking things when something is added to the JHttp constructor that is required.
Fair point, I'll leave it out for now.
You're missing the throws tag on this method.
Usually this called 'epoch'.

For private members we use a convention of using the name without the _

Also I think this should be somewhere out of the DirectionsRequest class.
There is: putAll. Just changed to use it.
Made them protected. private in a test suite really does scare me.
`#drop_down_login_container #drop_down_login_options` is redundant. Matching by ID is exact. There is no reason why you would match by ID like that. Matching by ID exactly matches that one element. So it cannot happen that there are two elements with same ID, where one would be in a child relation and the other not.

Of course the question is why are you using IDs in the first place. You could use CSS classes.
Ehm, what if you would add only if it does not yet exist? Not that you remove and add if it exists?
In general, positive conditions is easier to think for humans. So:

```
if request.user and request.user.is_authenticated() and request.use.is_staff):
   return super..
raise PermissionDenied
```
OK. This is not good. We cannot remove and add like this, on every event. We should just add if message info text is not yet there.
This can be simplified! ;-)
`('get')` -> `('get',)`

This is one-element tuple, no?
Why do you serialize yourself? You could leave to `send_update` to serialize for you. In this case you should also not really use `sender.serialize` as it is from wrong class.
Those files is something local to you. They are not in the repository. Please have a clean repository when collecting strings for translation. Check `git status` for that.
Don't hard-code paths to images!!!
i looked at other formulas but didn't see consistency regarding etc/:

#1

##1
`git grep -e "etc[ '\"]*+"`

##2
`git grep -e "prefix.*etc/"`

##3
`make` installing to etc/ without links. (see nginx for example)


#2
didn't see recommendations in the wiki..?


#3
`brew uninstall` doesn't remove created directories in etc/

#4
didn't see recommendations / standard way to prevent clobbering such as .dpkg-old / .dpkg-new / .dpkg-dist or .pacnew style.
here and elsewhere, use "if (" with a space, and remove the blank line at the beginning of the function.
>What is happening here? every time we render the object we "begin" the animation and "end" it right after the rendering?

Please, look at the AnimateRotateOn class and you will understand =)
What type of taxa data are you thinking of specifically? The format currently doesn't specify what those should look like, although the vector of taxonomic ranks is convenient for use with QIIME. It might be worth having a page on the website with recommended conventions that we could consider for integration into the standard.
Change "sample" to "observation" in the last sentence.
the filename should be `imperio.rb`, and not `imperio .rb` (notice the whitespace)
`0 5px`
I already have syntax enable in the config :-) I will remove the other occurrence. Thanks.
`if book.title != '':  readme_meta += ":Title: %s\n" % book.title` would be a lot more compact and uses string operations instead of concatenation.
the only one that doesn't have retgrad
Is this part necessary? Or just the property change below?
Should be `TwitterCldr::Formatters::TimespanFormatter`.
`Array.new(size=15, obj="")` creates an array of 15 empty strings. I chose to create the entire array just so the next statement would work whether `TwitterCldr::Shared::UnicodeData` returned `nil` or not:

```ruby
decomposition_mapping = unicode_data[5].split
```

I think it'd require more code to perform the nil check and then return an empty string if it *is* nil:

```ruby
unicode_data = TwitterCldr::Shared::UnicodeData.for_code_point(code_point)
if unicode_data
  decomposition_mapping = unicode_data[5].split
else
  decomposition_mapping = "".split
end
```

What do you think?
This is kinda weird.  I know the the currency symbol for the Nuevo Sol is "S/." - is that not in the CLDR repo?
You don't have to specify the encoding, as utf8 is the default.
example.com?
Please align.
I think undeployArtifact also needs fixing in the same way
yeah i didn't know either, kinda picked it up going along, it used to be just `lein clean, jar` but it changed (in latest lein 2 anyway)
That was my reasoning: if it was likely to be used as a PSF, I added FWHM, but I didn't otherwise.
How about this to fit within 100 chars:

# At www.wolframalpha.com:
# Type "Solve[BesselJ0(x)^2+BesselJ1(x)^2=1/2]"

This is more readable and avoids the issue that wolfram might change how it does its get method input someday (the "?i=" part of the url).
This would benefit from a variable `fwhm=1.0927...`, so the magic number isn't written out in full twice.
Ooops, I see you did it already.  Thank you!
same comment about error handling on `tag` here
Don't think this has to be synchronized. It does a volatile read under the covers.
Or if it does need to be synchronized, then does that imply all other calls to all() need to be synchronized?!
Refer to comment #1 on this pull request.
Why not just add replicaset and connect to the $rp above? the "+ $rp" is a bit odd.
drop the `File.exists?` check from `load_xml`.  calling `load_xml` with a nonexistent path is a logic error here, and we should not have code to guard against that: where would we stop?
I am not comparing the actual contents of an array, all I am checking is if they both are empty. Em.compare though can be used, seems to be an overkill for that. 

btw just checked if Em.compare looks into actual array contents, unless I am missing something does not look like that as  
Em.compare([{k1:1}], [{k1:111}]) returns 0, the value it returns if both objects being compared are equal.
out of curiosity due to this file, does not it mandate all api to be implement this, cannot registry.js be used for the xmpp too
I'm not familiar with Guava, so forgive my ignorance here.  The addresses object is a Map<Address.Type, Address>.  The Predicate assumes a String, though, so this doesn't work, right?
Same as above. let's use only one declaration on top of the file and remove the rest.
I think that readonly properties even could be without `copy`
As non-admins can see this view too, I'd rather have the status in the global administration.

I get the point about the 404 and I agree that there should be a better error message, Managers shouldn't have to worry about it (i.e. not be presented the "status" by default) and only be presented something like "uh, oh, couldn't find the binary, please tell your admin" or whatever.

(not sure if I'm clear, if not we should jump back to the issue on chiliproject.org to discuss this correctly)
Again this test results in a lot of recursion so we have to keep the cycles count low
А закрывать кто будет?
Если подать на вход пустую строку - будет исключение.
Для if, while и т.п. фигурные скобки обязательны.
And once again:
"But it was curious to know why it is considered to be unreliable :)"