labofsahil/github-event-dataset-2012 huggingface dataset:
True, these are valid concerns I didn't think about. And frankly, I have no idea about answers ;)

So maybe a different approach to do this? How about creating an interface that the repository can implement if it wants to provide a custom query builder. Let's say

```class UserRepository implements ElasticaQueryBuilderProvider```

which forces to implement a method ```getElasticaQueryBuilder($alias)``` (or ```getSearchQueryBuilder($alias)```).

If this is implemented then it's used by the transformer, otherwise the standard ```createQueryBuilder()``` method is used.
`#readpartial` waits for all the output to finish, and I'd like to be able to work in parallel.  `#readpartial` shouldn't truncate content in the middle of a string .
As this is an interface and the functions are public the underscore convention doesn't hold here.

It is a direct request from the client that functions beginning with an underscore must be private always and the reason why i removed the underscore on these.
User will expect the same behaviour on all platforms except for when it's not supported on a platform.  If that means that we have to use a format string to match the behaviour of other platforms then that is what we should be doing.  The only worry that i would have with this approach is if it doesn't work well with the system configured locale, but the format string is supported by the QLocale::toString function so it should be supporting the configured locale.  Validation tests with different locales should still be run.

I see from you results that the output doesn't quite match the Qt documented behaviour for the short date format.  So verifying the plan with Suavek is good.

If the output will not match that of the other platforms, then it will need to be run by Appcel to approve the different formatting.
This still needs the pragma code I mentioned before.
shouldn't the members be copied first?
This function is actually much more generic. I suggest renaming it to setV8ValueProperty and use Handle instead of Persistent.
Yes, I was in two minds about the inheritance structure from the outset, originally I derived from RoxieOutputRowArray privately and masked out the spillable functionality, but didn't look right.

>Possibly there should be a shared base class which spillable and non spillable both derive. That might help.

I think I made same comment above somewhere
Maybe you're saying I should put the building code inside, and just print the name at the else.

Since printing the name is much simpler and quicker, I tend to make them early exits, since that makes the code much clearer.
Typo: recommened :point_right: recommended
I don't think we need to catch LookupError anymore since that's thrown in the old library.
`nest_prefixes` mutates the passed in config dict. Maybe we want `config = nest_prefixes(copy.deepcopy(config))`?
you can make this class abstract
что будет, если юзер сменит пароль в своем профиле стандартными средствами ДЛЕ? он больше не сможет авторизоваться через uLogin
should this be a navigateTo method?
is this the page title or the horizontal menu at the top of the page with the links?
@christianv Please add comment and Jira for future integration of the two URL functions.
@christianv Link target removed intentionally?
>Plus: what is the "highest" type? In the mentionend GetUntrackedFiles() calling .ToList() just before returning seems quite arbitrary. There are other methods like .ToArray() or .ToDictionary() which could also be seen as "higher" type than IEnumerable.

I think the problem is set upside-down. Function doesn't return the type accordingly to variables types they use, but it uses suitable variables accordingly to type it returns. What is the highest type? It depend on what function is supposed to return. GetUntrackedFiles should return a collection of untracked files. There is no good definition of the highest here. You have to choose between possible types accordingly to use cases (curent and future), performance etc. But here you chose IList from: IList (possible return type) and List (other possible type and actual type at once). Do you think why ToList returns List instead of IList?
If OS commands can be executed maybe it can be converted into an exploit
If it can execute os commands it could be converted into an exploit
So I should say "if and only if" or do you have a better formulation in mind?
My mistake, committed an old version of this. Fixed now.
Hmm, I thought we were pretty aggressive with our Cython dependency. Since it's a bit less stable than, say, numpy or matplotlib, I thought it was OK to use the latest stable version, i.e. 0.16. Thoughts? (Note: the website currently states 0.15 as the minimum requirement)
just "if filename" would be almost equivalent
Yes you did - my mistake. Sorry!
of order creation
Yeah, I bet you could pull it off with a single class.
Again, let's replace `_update`.

Also, since we are compiling a shader, checking for the pick pass is critical here; otherwise, we could almost double load times (if we are bound by shader compiling).
After discussion we're going to leave this.  Deleting ids from the object does make it slower, by putting it into dictionary mode, however, dictionary performance is what I'd expect here.  Recycling IDs would be problematic because tasks could complete in an arbitrary order, meaning to recycle an ID, you'd have to scan the array to find a free ID at schedule-time.  In any case, the overhead of posting data back and forth will outweigh any performance impact of scheduling and resolving.
Is this a good idea?  I wouldn't expect a.toEqual(b) to potentially toString them and compare.  Any object without a toString override will compare equal to any other object.
This is a prominent breaking change so we should provide a concise code example here.
Not that it matters, but what is the alpha now?
we need to discuss about this design choice; preferably in a skype meeting.
You are not using it right. I agree that the additional p is unnecessary. I will fix that. have u tried this: self.points.each(function(p, i){...});? U can see how to use this in the InnerRectangle. For sake of convenience, I provide the code that does herein

```Javascript
inner.points.each(function(p, i){
				// subtracts the center from each vertex point
				p.x = p.x - center.x;
				p.y = p.y - center.y;

				// scales each vertex point
				p.x = InnerRectangle.SCALE * p.x;
				p.y = InnerRectangle.SCALE * p.y;

				// shifts back the center
				p.x = p.x + center.x;
				p.y = p.y + center.y;
			});
```
OK cool. Cleaning whitespace is a good idea. I think you should mention it in the commit message.
Yeah, but this for future SDKs as looks like each SDK will have different config.
Yeah you are right, this this should be the other way round, the other constructors should delegate to this one as the primary constructor.
done: https://issues.apache.org/jira/browse/CB-377
Nvm. you're right
I don't see the fix.
Ah okay. It's the upstream name.
sorry, emacs!
… correct, hence the smiley :P
No, the introduced symbol is a template.
In that case, just make the first sentence red - and maybe add one little bit onto it about breakage. e.g.

> $(RED The current implementation of std.string.format and std.string.sformat are scheduled to be replaced in January 2013. In some rare cases this will break code.) They arae going to be given...

Or maybe it would be better to just go with

> $(RED The current implementations of std.string.format and string.sformat are scheduled to be replaced in January 2013 with improved implementations which conform to writef. In some, rare cases, this will break code. Please see the documentation for std.string.format and std.string.sformat for details.)

Yeah... The second is probably better. Too much information in the changelog and it won't be read properly, regardless of its color. The ddoc on format and sformat can take care of properly explaining the details.
I know this is terminology from DMD, but I think `hasInout` is better.
Part of an experiment which I neglected to nuke...
I'm wondering whether we need to release/destroy the created beans for message interpolator, parameter name provider etc. (as we do with created CDI constraint validators). Or is this happening somewhere?
use IPA header from https://github.com/ipa320/setup/tree/master/templates
Local var to avoid nested `new` and linebreaks.
Also, be aware that you'll get an exception if you try to insert a record that's already deleted, which could happen. Either use the update-or-insert pattern here, or just catch any exception on insertion into the deleted table — it's way less important than the non-deleted table.
You're right, unnecessary, removed.
api around choosing devices is unclear. what does it mean for a device to be 'selected'? what is the difference between `setVideoDeviceID` and `setSelectedVideoDevice`? where do the IDs for `setVideoDeviceID` come from? this could do very very much with inline comments in the header.
This is from http://damieng.com/blog/2010/10/17/enums-better-syntax-improved-performance-and-tryparse-in-net-3-5
Does this handle order of blocks?
Why the functional tests are added to ignore list? Also you've updated the `phpunit.functional.xml` with the phpunit "" feature
I would change this to just "Commands to manage ServiceBus" as config is overloaded.
It should actually be `fade-in` (with a dash) - `fade_in` is the function name but a dash is used within the SCSS itself.
lblConfirm is missing from changepassword.aspx.
Extra space after `function`
If your page is id12345, the following will exist during editing:

/p/../id12345
/p/../tmp_id12345

All changes in widget data and text will be saved into tmp_... during editing, keeping the original data available at the core path. The data in tmp_... is used as the autosave data (+ allows us to autosave widget data as well). We only store the changes at the base path when properly saving the page.
You can use the `init` property to abbreviate the alias.
`alias typeof(ucontext_t.init.uc_mcontext.gregs[0]) REG_TYPE;`
Quite likely, but the reason I didn't mark it as such is that I have a rather large pull request with attribute adjustments all over druntime that I'll update after all of these have been merged. So I just marked it `@system` conservatively for now.
/**
	 * Obtains a lock by masking the lockKey's hashCode() with
	 * the mask and using the result as an index to the lock table.
	 * @param lockKey the object used to derive the lock index.
	 */
in embedded mode with the right hardware, i'd think it's possible
Gunnar, I'm lost a bit already ;-)
I don't see any XSD changes here...
The `<poller>` is still there.
I agree.  However, this is a tradeoff in favor of very nice syntax the majority of the time, e.g.

    compile("org.springframework:spring-tx:$springVersion", optional)

in exchange for a slightly more cryptic approach when exclusions are involved, e.g.

    compile("commons-httpclient:commons-httpclient:3.1") { dep ->
            optional dep
            exclude group: 'junit', module: 'junit'
    }

The previous approach was that one must use the following syntax even for the simplest optional / provided scenarios

    compile ("net.java.dev.rome:rome:1.0.0") { optional = true }

I (and afaict, others) prefer the more compact approach that one achieves (most of the time) with this:

        compile ("net.java.dev.rome:rome:1.0.0", optional)

btw, see http://issues.gradle.org/browse/GRADLE-784 for lots of background on these approaches and a request for first-class support from Gradle itself.
Why comment this out? Now, how are you setting the transport factory?
Minor issue: this file is using spaces instead of tabs.
I believe you can also enclose the code in triple backticks (```).
"For now we have" replace with "Supported cookbooks are"
Not here, actually. But it should be "a user's" (note the apostrophe)
i think i was working on this part at 4 in the morning. my bad.
中括弧
`active` &rarr; `activate`
Can you use jQuery keywork ?
don't use import *, import only what you need
I am not 100% sure that the step is necessary here.
But I suspect that without the step the mServos[i]->getPosition(); will return nan.
Ehm, but we are extending tastypie with support for mongoengine. The idea is to support all fields mongoengine support in documents in tastypie resource. No?
I refactored to bypass the duplicate-message-loading problem.
no need to get the AppDelegate reference ..  self can be used
Yeah, that's a much clearer format.  Thanks for the tip!  I'll update.
There is no visual design for it, and i think we must not be wrong with an "informational" calendar (as it could be the Calendar application) and a selectable one....
`transform`
``` /* ативный блог */```

где ты уже такого насмотрелся? это ведь однострочный коммент. пиши просто ```// ативный блог```
an alternative to having pre-staged test data is for the test to create such data on the fly
how about adding:

```
mxDomain = mxDomain.split('.').slice(-2);
```

so at least sub.example.com becomes example.com
Now defaults to false. This won't change any behavior, as the specs say the underlying implementation will also default it to false: http://www.w3.org/TR/XMLHttpRequest/#the-withcredentials-attribute
View.INVISIBLE, View.VISIBLE and View.GONE are constants for native android that we do not necessarily expose to the end user.
If we consider this a fatal error then should we consider adding a ASSERT_OR_DIR call perhaps that would go ahead and die on the spot rather than continuing until a segfault occurs when env is used?  Might make identifying crashes slightly clearer in the log.  Thoughts?
Great work with merging has_evaluation? method! I think this now should be updated :)
Please add something like

    static assert(is(KeyType!Hash == string));

to make this clearer. I was initially very confused by the next line where you declare a variable of `KeyType!Hash` (much as I probably shouldn't have been). The static assertion in the example should make it clearer. And please do the same for the `ValueType`.
No, you are right :-)
Меня от ентих вызовов всегда коробило.
`pF = open(phrasesFile, 'r')`
we seem to be using this function a lot, maybe we can put this in it's own class or header and make it common so all extensions can use it, I have some other functions I would like to put in there as well, good idea?
Should name this test and the one above differently. They have the same name right now. Will be hard to tell which actually failed, if one does.
Maybe something like `can preprocess a simple if else [else condition]`
It's better to move the function outside "trigger" so it can be used in other client libraries
Better to use execSync as it indicates 2 things:
1. we ignore the return value
2. the framework code is executed synchronously and ends when the client method ends
You're right. I shall fix it.

From: Jeffrey Heifetz [mailto:notifications@github.com]
Sent: Tuesday, November 20, 2012 07:07 PM
To: blackberry-webworks/BB10-WebWorks-Framework <BB10-WebWorks-Framework@noreply.github.com>
Cc: James Keshavarzi
Subject: Re: [BB10-WebWorks-Framework] Localized blackberry.app.name and blackberry.app.description (#277)


In ext/app/client.js:

>      value = readOnlyValues ? readOnlyValues[field] : null;
>      Object.defineProperty(_self, field, {"value": value, "writable": false});
>  }
>
> +function getLocalizedText(data) {
> +    var locale = navigator.language.toLowerCase();
> +
> +    if (data[locale]) {
> +        return data[locale];
> +    } else if (data[locale.split("-")[0]]) {
> +        //Region specific locale [i.e. fr-CA]
> +        return data[locale.split("-")[0]];


Isn't this comment misleading, isn't this the "region unspefic" locale?

—
Reply to this email directly or view it on GitHub<https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/277/files#r2188880>.



---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
I was thinking about having it add itself to the device startup script. But if we're going to combine with deploy-tests that might not be necessary.
$file?
Please also add public void checkForUpdates(); and call it from subscribeToDictionary.
Documents in the cloud ftw.