labofsahil/github-event-dataset-2012 huggingface dataset:
Prefix isn't used for all other cache backends. Looks inconsistent.
This piece of code looks weird:
<pre><code>$this->_enabled=false;
$this->setEnabled(true);
</code></pre>
Hi,
I have a zk1.2.7 where Categories is 1.1 and also in zk1.2.9 B23 categories is 1.1

I could find an older install of zk1.1.2 (upgraded to zk13 now) where Categories is 1.04 an looking in the pnint.php of Categories 1.04 I see the old lang defines there (used in zk11x). Those definitely need upgrading with the $this->upgrade_MigrateLanguageCodes();

But from version 1.1 of Categories onwards the language is already correct in display_name and display_desc. 

So did I think wrong in the lines that are being executed for version 1.1 ? I always have to think twice which line is being executed coming from a certain version. Let me know, would be great to solve this bug/blocker
I'm, guessing, to be consistent with the current API, we probably need to return an array rather than the entity class this query will return...?
I had to add it so much at the beginning because they old config.php breaks the connection to the database and causes errors.
That's the idea; ``loaded`` plugins are really supposed to have been loaded programmatically, rather than by configuration, and probably have no intersection with those that can be loaded by configuration.  Really it's an academic point, since the only ``loaded`` plugin in this bot is the ``Bot`` instance itself.
@fabpot I forgot to mention the app injection workaround, adding it.
It's not being removed, but moved to `onEarlyKernelRequest`. Reason for the move would be nice anyways.
any reason to not just stuff this down in the other method?
Sure, take your time. And thanks  :)
passing in this factory is weird and breaks the DI model.  If we are using this to generate a config, then that config should probably be a sub-config on the Master config or part of the master config or something like that.
As an example, yes. But, it can be moved. If/when we want to package the wiki app up as reusable, we'll want to ship this template along with it. Keeping it close to the rest of the app is the easiest way to do that.
ok how about `monthly_reports is not None` ?
nit: `()` suggests unit to me, but this is actually the (inexpressible) empty-tuple.
Spaces around `.`
Was this PR tested on fastcgi?
Make up your mind, are you going to put a space before the brackets or not? :-D
Yes it would need that, shall i still change it?
I think we should only count topics, that also have post count enabled.
Also I'd just add a user_topics column like I did in my MOD and increase that when approving/posting
It's also really important that you test updating with different styles installed and prosilver removed. I think you need to at least overwrite default_style config variable
Use the lang() method rather than the lang array. Applies to any other similar uses of $user->lang[]
this just seems... wrong?  why are we using a regex to figure out the types ever?
line 280 suggests that is not the case or was not at some point.  Although, the call to setTimeout assumes that callback does exist.
Ideally this would use the Rouge pretty-printer.
OK.  Presumably that's their intent, if they're replacing a string with an array then they intend for the array to be used.
true, which is why it was removed :smile:
Good call on using `Task.Factory` here. I'm going to update clrzmq to do the same.

One suggestion would be to pass `TaskCreationOptions.LongRunning` to this call, as devices will generally run for long periods of time (in CPU terms). What do you think?
I have done enum for pages in https://github.com/Raxa/Raxa-JSS/blob/master/src/resources/scripts/page_enum.js
You may consider doing the same for pharmacy
remove file or commented code
Any reason that it's not static anymore?
If a group gets deleted, this pricing variable - and consequently all its pricing values - get deleted as well. Confirm this is conscious.
Identation typo
This rarely survives gzip, but what about something based on the following?

```js
var j, detail,
  val = 0,
  i = name === "width" ? 1 : 0,
  augmentation = [
    { prop: extra, test: "margin", eq: true, add: true },
    { prop: "padding", test: isBorderBox && "content", eq: isBorderBox },
    { prop: "border", test: isBorderBox ? "margin" : "padding", eq: false, suffix: "Width" }
  ];

if ( extra !== (isBorderBox ? "border" : "content") ) {
  for ( ; i < 4; i += 2 ) {
    for ( j = 0; ( detail = augmentation[ j++ ] ) != null; ) {
      if ( ( extra === detail.test ) === detail.eq ) {
        // since `true` is mathematically `1`...
        val += ( detail.add || !isBorderBox || -1 ) *
          parseFloat( jQuery.css( elem, detail.prop + cssExpand[ i ] + ( detail.suffix || "" ) ) ) || 0;
      }
    });
  }
}
```
Looks like an indentation issue here?
Actually, [we can](http://jsperf.com/jquery-pull-743). For the block in question, `.each` takes roughly twice as long as `for...in`. But in terms of absolute speed, even the worst browser in a virtualized environment can run through it in 35 microseconds.

And the operations hit of 4 extra function calls and 12 extra array lookups (minus 6 dictionary lookups that become array lookups) is at most equal in time to the 5 function calls and 1 nine-property `for...in` of the rest of the function, resulting in a total slowdown of something like 30% per `jQuery.Deferred()`.
You want to replace the second SRF_IS_FISTCALL() with is_first_call.  But I'd like to see more elegant way.
I agree it's faster in a small k but not sure about up to how many K we can calculate.  Maybe we need to investigate it during the QA test.
I'd vote for playlists stored in Sqlite or similar instead.
Why tuple instead of list?
`brew audit` this and it will (should) warn that this version was detected from the URL.
grep the formula directory for "Requirement", basically.
creating no sería "crear, o no se ... generar" ?
Could we maybe use something like http://dk1.php.net/manual/en/function.htmlentities.php#106535 to support more than German chars?
Same comment as for line 93
Ist self als fype hier erlaubt?
Is this always going to be size 1? I think you're overgeneralizing here way too early.
Should just keep the original error? since it probably reflect the reason why you can't delete the Attachment in Mongo db.
Ugh.  All of these explicit type parameters still make me think that the typing in hamcrest is more trouble than its worth.  What do you think?
Done. I combined all of the "should add new menu item..." tests.
This was part of the acceptance criteria. If I recall correctly, this just help us simplify the UI part of this story.
I think the lineComment() function should simply be a bunch of if/else conditions that check for certain modes and pass control to methods (e.g. lineCommentJavaScript(editor) ) to do the work. This would make it easier to add other languages.
I think this is reversed -- we want Ctrl+G on Win and Ctrl+L on Mac (on Mac, Cmd+G is already mapped to Find Next)
i don't think there is a timing issue here.
any non noticeable timeout could work
changed both to 100
But do make sure the last line of every vcard ends with \r\n
Can you line up the fields and put the different constraints on separate lines please?
It may be clearer to use EventHandler here. The anonymous class is... huge ;-). As the change is probably easy to do and pretty fast forward, it is not high priority, though.
Will see ... I want that you still extend things! ;-)
also note that while for those two methods, BrowserID *can be* instantiated with None, None, it doesn't have to, it could be instantiated with real values.
This could be problematic if there's no console defined... is there another way of exposing this error?
Probably don't need this here either now. It seems to load fine with persistence enabled, which is specified in the registration of the editor.
It might be enough "self-documentation" to use `isPrimaryInput` instead.
Nope. One does `drop`, one does `stop`. They happen like this to make sure everything is in a sane state before moving to the next step.
数え方が正しいでしょうか。Adobe Readerにはただ「{{page}}」で、言えば「第{{page}}ページ」と使え、「ページ {{page}}」はちょっと変だと思います。
Can we comment it or include as a snippet?
Do defaults? instead of empty strings?
denke ja, und auch bei delete.. zumindest dahingehend, daß man die params in die MP instanz übertrageben bekommt, und diese dort - auch wenn man die subpages/Funktionen wechselt - weiter propagiert werden..
Don't you need to refresh the page here?  It's not clear to me how this works.
There are lots of `should` lines here.  To the extent that it's possible, these should be broken down into separate `it` statements, so that they are independent tests.  Then it will be very clear what we're testing and if one thing breaks it will be very clear what has broken.
统一改成ctx->flag_postion++这种形式的代码吧，上面还有++ctx->flag_postion的代码
oh my lady gaga!
Instead of iterating through the pills and binding a click handler to each you can just bind it via the selector
```javascript
$(".js-zipkin-navbar > li").click(function(elem) {...});
```
yeah it contains more than that

```ruby
[numeric_ip_lower_range_bound, numeric_ip_upper_range_bound, country_code, country_name]
```
ew :) Is this kosher?
Thinking a lttle more, since  exec "generate-passphrase" seems idempotent, it probably wouldn't hurt to leave it in here. Especially if a config doesn't ever need to eval templates for katello/candlepin for some reason
done & done

On Wed, Sep 5, 2012 at 2:13 PM, Justin Sherrill <notifications@github.com>wrote:

> In src/app/views/content_search/_browser_box.html.haml:
>
> > @@ -85,15 +84,6 @@
> >                      = _('Search for all packages with a specific requires:')
> >                      .example
> >                        requires:sendmail
> > -        %div#package_autocomplete_list{'data-url'=>auto_complete_nvrea_library_packages_path}
>
> Removing it from the haml is good, I would also remove its references in
> content_search.js
>
> I believe the only reference is in the KT.widgets variable on line 19.
> Removing the autocomplete key/value should suffice.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Katello/katello/pull/577/files#r1532831>.
>
>
print? probably should remove it.
This logic is simply wrong. Other handlers may need a different way to format the message. If you really want a fallback, it should call ``handle``
走得到，比如/a就能走到这个else分支里
We shouldn't do this.

lib will already be in the load path and files within it should be manually required.
On 12/04/2012 06:51, James Lal wrote:
>> +    launch: function(){
>> +      var event = document.createEvent('CustomEvent');
>> +      event.initCustomEvent('mozChromeEvent', true, true, this.getDetails());
>> +
>> +      window.dispatchEvent(event);
>> +    }
>> +  };
>> +
>> +  function MozAppGetAll(){
>> +    setTimeout(this._loadManifest.bind(this), 0);
>> +  }
>> +
>> +  MozAppGetAll.prototype = {
>> +
>> +    //relative to homescreen
>> +    appManifestFallback: './apps-manifest-fallback.json',
> Sorry for not responding earlier Vivian,
> We could just include the output of the fallback json file in git and remove the makefile target?
> When we make changes to the manifests we could just run the script in tools to regenerate it.

If we can do that but keep it confined to webapi.js that would sounds 
great to me. (sed?)
I believe it's not necessary to register the class if you have already inherited from the ABC (which you have), so these and the other register lines can be removed.
This causes the following error for me:

```
UnitsError: Could not parse the angle value '1' - units could not be determined.
```
Ah, yes, good catch. Not sure why it's commented. On the left is a `Quantity` object, on the right is a `CompositeUnit`, so I think I can just implement fix this in `Quantity.__eq__()`. It should be straightforward, so I'll do that when I get to my office in an hour or so.
Should probably add a bullet in ``docs/units/format.rst`` that lists this format as well.
Also note that many of these stats only update on the leader node, and some, like 'objects_forwarded' only update on non-leader nodes.
No problem here, it is entirely correct: calling itostr casts the unsigned short to a signed integer (which is larger, so there is never undefined behavior), before feeding it into strprintf as a signed integer (%d).
Right— I agreed. I removed it once; but with all the rewrites and rebases I forgot I'd done that.
Nevermind I saw the default implementation below.
I thought so, too; Mark S straightened me out: evidently, it has to be faked, because if we want a DELETE method via a form tag, browser support is not really there.
:b




On Sep 2, 2012, at 21:06, Juan Basso <notifications@github.com> wrote:

> In lib/Cake/View/Helper/FormHelper.php:
> 
> > @@ -1607,7 +1612,7 @@ public function postLink($title, $url = null, $options = array(), $confirmMessag
> >  		$formName = uniqid('post_');
> >  		$formUrl = $this->url($url);
> >  		$out = $this->Html->useTag('form', $formUrl, array('name' => $formName, 'id' => $formName, 'style' => 'display:none;', 'method' => 'post'));
> Shouldn't the method in the form tag be changed?
> 
> —
> Reply to this email directly or view it on GitHub.
>
We should remove `_button` from this locator name
refactored on a5a867c
This doesnt work if the entry exists already, but is expired.
same issue here with the class name
Yep, the new stuff looks fine.
this block should be moved to the `init_layout` method.
>> -          say(room, "flapjack jabber gateway started at #{Time.now}, hello!", :groupchat)
>> +          say(room, "flapja ck jabber gateway started at #{Time.now}, hello!", :groupchat)
>
> o_O
>

I blame... err... the phase of the moon? Not sure how that got in there.
cool, i used jsbeautifier in command line and fixed the rest through sed.
Not a very robust test - all sorts of things can be in /tmp. And it's probably not called /tmp on Windows.

What about something like `nt.assert_in(testenv_dir.name, result)`?
the method name createServerInDC doesn't make sense here.  also it seems you might not be using the datacenter arg.  Want to change this to createVMWithImage(name, image) or something?
Isn't this valid HTML5?
I vote for starting off with 1.8.2 here since it's new. I'll file a bug to upgrade the desktop site but that requires a ton of testing to make sure nothing breaks.
Thanks for cleaning up the CSS! I still see 3 `!important`'s. Can we get rid of those too? :-)

Also for this ^^, you can ust do `margin: -0.5em 0.5em 0.5em 0;`
I'm a little confused here. Looks like it's switching from 7 days to 30 days for the popular_translated. Is that intended?
I skimmed through that file pretty quickly I must confess.
You forgot to use ``out::H(`` here, which displays wrong signatures as ``&gt;`` and ``&lt;`` symbols are not html-encoded.
Indeed, it is the clients fault - he passed in an invalid URI. He can fix that by passing in a correct URI.  
ParseAndVerify is to be used when a valid URI is required by the controller action. If this is not the case, `TryParse` should be used anyway.
Unless your point is that the headers cannot be bigger than 4096 bytes, which is a known limitation. In fact, it exists by design. It is the maximum buffer of the request header parser.
Rather than doing a loop with two splits, you might be better off with a single regex. Perhaps a case-insensitive pattern like `(?i)\Wcharset=([^\s]+)`

(From Guava's tests, content types look like this: `application/atom+xml; a=1; a=2; b=3` or
I'm not talking about the compilation logic. I'm talking about the rendering logic (which is were the loop occurs).

In the unit test, the resource is a static string, so there is no issue (as there is no computation). But you can use any valid Twig expression to get the resources. The following is valid:

```jinja
{% form_theme some.hidden.nested.var with app.user.config.formTheme %}
```

In this case, you would be computing the retrieval of ``some.hidden.nested.var`` twice (once in the if and once in the logic) and ``app.user.config.formTheme`` N times in the case of the loop.
In this case, it means computing several GetAttr nodes twice whereas it is one of the slowest parts of Twig (which is why this function has been implemented as an optional C extension btw). And it could also be a function like ``with get_form_theme_from_db()`` which would then be slow too.
``Collection[]`` ? No. it does not return a array of collections
The typehint should be an interface
should be ``Fatal`` without the typo
I feel pretty strongly that gc should be specified explicitly because it actually affects security.
Can you should me the code please?
Would be better IMO.
Still the issue with "[Максимальный допустимый](https://github.com/symfony/symfony/pull/6106#discussion_r2215232)". And I'd better say "Размер файла слишком велик. Максимально допустимый размер {{ limit }} {{ suffix }}". It's more clear and consistent with other messages.
As in, a rogue library that has a malicious toString method?

We can completely remove it but the problem of sql injection is still there if the a user builds their own sql statement.
Shouldn't it be `return !$this->contains('W...`?
Strange, this seems unchanged but is shown as a diff.
This would benefit from `try...finally` to avoid leaving the monkey patch.
le TODO peut sauter du coup.
This is correct for the installer.  But you also have to handle the upgrade case which means 3 things:

1) modules/gallery/module.info needs a version # bump to 51
2) modules/gallery/helpers/gallery_installer.php's install() function needs a module::set_var call to set this value
3) modules/gallery/helpers/gallery_installer.php's upgrade() function needs a stanza for this new version that checks if we're running version 50 and sets the lock_timeout value and then sets the module version to 51

Once you've done those 3 things, run "php index.php package" and it'll rebuild the install.sql file.  Note that this will nuke your current install (and sometimes you have to run it as sudo if you have permission issues), but it'll make sure that you've done the installer code correctly.
Why are commit() and forget() called twice?
We don't have the bottom and right values, but I've refactored it to reuse targetOffset, by cloning that once at the beginning. Leaves us with no extra DOM access, so performance overhead of this feature is very low.
Considering the size of that ini file, should we be concerned about parsing this more then once per request?
合并嘛，周末再讨论各种log等级。

在 2012年11月22日星期四，judi <notifications@github.com> 写道：
> In grails-app/conf/Config.groovy:
>
>> @@ -71,11 +73,17 @@ environments {
>>
>>  // log4j configuration
>>  log4j = {
>> -    // Example of changing the log pattern for the default console
appender:
>> -    //
>> -    //appenders {
>> -    //    console name:'stdout', layout:pattern(conversionPattern:
'%c{2} %m%n')
>> -    //}
>> +
>> +    appenders {
>
>
这个是log4j需要配置咧appender，就是一个log器，他负责输出你需要咧log，比如有个是sout，就是一个appender，输出到控制台，另外一个是file，就是纪录文件，你还可以自定义其他类型咧appender。
root就是最顶层咧总配置，比如level是info，他咧appender就全部打info咧日志哦。即使顶层配置。
> …
> -- zhoudi 已使用 Sparrow (http://www.sparrowmailapp.com/?sig) 在
2012年11月21日星期三，下午7:58，longhengyu 写道：
> In grails-app/conf/Config.groovy: > @@ -71,11 +73,17 @@ environments { >
> // log4j configuration > log4j = { > - // Example of changing the log
pattern for the default console appender: > - // > - //appenders { > - //
console name:'stdout', layout:pattern(conversionPattern: '%c{2} %m%n') > -
//} > + > + appenders { appenders , root 这个是哪样？ — Reply to this email
directly or view it on GitHub (
https://github.com/longhengyu/dream/pull/4/files#r2192877).
>
> —
> Reply to this email directly or view it on GitHub.
>
> <
https://github.com/notifications/beacon/Jshd8sI44GVrKZBvymxqKI-MqXgV_AllOLjUF7O1J5RflQqGwGD8CRK_sg1Js01o.gif
>
Yep, you perfectly answer it :)
Ya... If the parameter is not string, it will raise error in escapeHTML because replace method. Original escapeHTML function will create a html element -> set textContent -> get innerHTML.
same comment as with other inline objects
Add this directly on the button.
It's work.
I think that I should do window.close at child page.
The error log "window.opener is null" cause by the parent have be closed...
1. I don't think the UX guys will even want to give you the control of color here, so let's scale it back and just denote the highlight part. Is the colors REALLY that important to denote input state in Japanese IME? I don't remember using any Japanese IMEs with four colors.
2. Adding parameters does not cause compatibility problems if we add checks like `if (typeof highlightStart === 'undefined')` and states that THAT means no highlights.
`\ No newline at end of file`
Yes, that's the plan!
meant to remove that, thanks!
thanks.  btw you meant https://github.com/msiebuhr/node-statsd-client/commit/a58331eb8eb76319c8fb4dd770d3ecaf9cfce208
This can be collapsed in one match:

```scala
rawChildren match {
  case MethodDefinition(_, _, _, "this", _) :: rest =>
    rest.toArray
  case _ =>
    rawChildren.toArray
}
```
Lets put back these methods to allow backwards compatibility.
Don't do this in a `chdir` - just do `cd dir && tar ....`.
Two loops for same array ? Why not only something like:

```php
$dirs = array();
foreach ($files as $value)
{
    $file = ltrim($value['path'], '/');
    if ('.' !== dirname($file)) {
        $dirs[] = dirname($file);
    }	
}
Oh god, why were these commented out?
Oh right, we only care about timestamps coming from mysql :P

Thanks for looking into that.
Ideally this would get moved to a testing monkeypatch.
s_pZipFile is not deleted?
IMO you should use same convention for this message like is already used in composer.
making a PR because rename is not reliable on Windows and proposing another unreliable way looks bad to me
maybe we can default to /opt/napatech3/include/ here
You're right, should be Backbone's models. Bootstrap provides styling. Fixed.
Utils `getTabLocation(tab) / setTabLocation(tab, uri)` ??
it's already called by this point, so I'm not sure how to pass the `options` to the `Tab` constructor.  Can I clean this up later? when I do the `favicon` update I may be able to do this at the same time.
I'd like also keep consistency with the code style of the module, so instead of the `for` loop I would suggest to use some array's method (`unique` use `forEach` for example):

```js
function hasAny(array, elements) {
  return array.some(function (element) {
      return has(elements, element);
  }
}
```
Please add comment explaining what this does and more importantly why. Example of `pref => normalizedPref` would also be helpful.
Normally, fixed in the new pull request.
beautiful tests.
You may want to line-break when appropriate :) (I know it came from upstream like this)
支持不了email登陆的
This diff is just a unclosed paran of $(document).ready(
Nobody really "builds" from HEAD, they just run there directly. :)

Having an external file for the version number makes writes simpler, at the cost of complexity on read: you need to handle the file:
 * not existing
 * being something strange (eg: directory, dangling symlink)
 * having odd content (eg: zero bytes, multiple lines)
 * being actively hostile (eg: disconnected named pipe, Unix socket, /dev/zero, /dev/urandom)

Given a desire to have `version.rb` be as light-weight as possible, it seems simpler to keep version number information directly in the code.
There can be several associations with the same class name, e.g.:

```ruby
has_many :created_tasks,  :class_name => 'Task', :foreign_key => :author_id
has_many :assigned_tasks, :class_name => 'Task', :foreign_key => :assignee_id
```

So we might need to use `builder.object_name` to guess association name with the latest rails versions too.
Why is it wrong? It's just a normal task target.

We could nest it in a `files` prop just to be clear, but should work without too.

https://github.com/sebv/generators/blob/86d26396b92302278d9829bc78bee795fc7b603c/lib/generators/yeoman/app/templates/Gruntfile.js#L19-28
Why did you disable 1.8 tests on travis?
Also, usage of more than two dots in relative imports is considered a bad practice. Just use an absolute import in this case. See http://mail.python.org/pipermail/python-dev/2004-March/043773.html and http://www.python.org/dev/peps/pep-0328/ ("Guido's Decision" section).
Not sure why all this commented out code is here.
Let's rename this to "onDispatch()" -- I've been meaning to do that anyways.
Can you split the array values? Will be more readable.

```php
.......array('table '=> 'users',
                 'field'   => 'field1',
...
```
Use Object\ObjectInterface like the docblocks.
Ah, thanks, I was looking for something like that.
"return" is not Ruby Way
This fixture is wrong. You don't handle old data and not convert it to new format, which makes this file useless.
枝を束ねるイメージの方が近いかも？
Use the full name when referencing org.spout.vanilla.controller.block.CraftingTable.
typo: "it's" → "its"
True, thanks. It is empty (without translations) anyway, so I'll remove it (and keep just pot file).
What is `preg_replace()` for here ? Removing *convert* ? If so, it's wrong since it won't work any more with regular `convert` binary. I don't see the point here...
okay thanks :-)
Thanks for adding tests of `empty?`. You might also include some tests of non-empty values to make sure we didn't define `empty?` as `(fn [x] true)`.
I thought this function would do some sort of cleaning on the IRC nick, but if it's just a setter, we should just set the attribute directly.
I don't see where we use this method in the tests. We should remove it if we don't use it.
I really don't like having to number attempts like this, it feels awkward and clunky. Is there a reason you chose to do it this way rather than just iterate through some kind of enumerable?
Changed phrasing/formatting to match the Share box on works.
`t5 - maxIdleTime >= now so buffered traces get sent to the backend`

But t5 - maxIdleTime < now, right?  I assume you gave `_maxIdleTime` in milliseconds, so that's 5 seconds.  At t4, the traces get sent, so `_lastTimeTs` is set to 4 (now at t4).  Then the difference, at t5, between now and `_lastTimeTs` is  1 second, which is less than 5 seconds, so it doesn't get sent.

Am I misunderstanding the math?  The way I understand it, currently, if you do not have `_maxTraces` over and over, you'd be sending between once every `_maxIdleTime` and once every `2 * _maxIdleTime`.   If you reset the time each time you send, you'd never send more frequently than between once every `_maxIdleTime` and once every `_maxIdleTime + some negligible amount`).
AWESOME COMMENT!
So, this is an (ordered) array, and at first glance the order matters (fallback to en last?), and also at first glance the reverse index iteration added above is opposite the default forEach forward index iteration (https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Array/forEach ).  So, does this break fallback, and should it be forward instead?
Remove dependency from 1.7.2... Parse folder... And other 1.7.2 in nagios installation.
This should be a boolean OR (`||`) instead of a bitwise OR.
The thing you are testing here, is the response from your request, using the resource() method to get a jersey client. Thus, you are testing the value of a ClientResponse. Thus, you should compare it to an "expected" ClientResponse.

I also think this method is obfuscating what it is testing, by taking the entire response as a parameter, just to provide a nice error message in case something is wrong. I would actually prefer to write the actual test directly, such as:
```java
assertThat(response.getClientResponseStatus(), is(ClientResponse.Status.OK));
```
It's a bit more verbose, but precise at least :)

I think also trying to extract the entity may introduce some subtle bugs, as it is a one-time operation. So for instance if you call your assertHttpStatus after having already extracted the entity, it with get nothing or may even fail.
This logic is not really valid. If the `name` parameter is not really a Name, then it's treated as a string without a prefix. So a string such as "`jcr:description`" would be treated as a property named "`jcr:description`" in the global namespace, whereas it really should be treated as a property name of "`description`" in the `http://www.jcp.org/jcr/1.0` namespace.

There are a couple of ways of addressing this:

# keep the signature as it is (statically untyped), but handle the cases where it is a `Name` and `String` (which should be converted to a Name); instances of other classes should produce errors. PRO: flexible. CON: It makes it harder to implement a connector, since developers will have to research what type of objects they really should supply when calling this method.
# change the signature to `String`, and internally convert this to a `Name`. PRO: connectors can just use Strings, so its simpler. CON: It's less efficient, since we really need a `Name` and will have to create instances anyway on each method invocation, even though connectors may very well be calling this with constant name parameters.
# change the signature to `Name`. PRO: Simplified logic in this method; if connector implementors frequently pass in the same names, it will be more evident that they can/should create `Name` constants. CON: Connector implementations will be exposed to `Name` (I'm not sure this really is a CON).

Because of the PROs, I prefer the 3rd approach of changing the signature to `Name`. This means that Connectors will need access to our internal value factories (which is okay, IMO). But as mentioned above, making Connector an abstract class (rather than an interface) would allow us to provide helper methods that create the document builder with an ExecutionContext.
why are you passing `&block` into the block?
Blockquote (I'm going to stop pointing these out, now).
I'm not a big fan of protected. Why not private?
You can change this to `$options = compact('path');`.
Ur right @andrerom, appended should be better, if we can confirm that the order is not important (see https://github.com/ezsystems/ezpublish/pull/59/files#r1401329)
Also we might consider rewriting such arrays with multiple lines so that futur diff are more readable (when adding a line, we only have a new one, instead of one removed and one added) :
```php
'keys' => array( 'node_id',
                            'selected_section_id',
                            'object_id',
),
```
Should have a substr on last param, so $class->attribute( 'identifier' ) doesn't return a string longer then 50 until class is re fetched from database.
Isn't this whole think block commented out?
... but it seems to break with an error that you can't mass assign a protected attribute "badges", despite adding to attr_accessible in Player.

I've rolled back to the original one for now.
Probably nothing now, they should both be wrapped with indifferent access by this point.
Couldn't we just wait for `s.find_element(*self._devs_comments_message_locator)`? In the mentioned test this will even occur due to implicit waits (but I have no objection to making this an explicit wait).
Not quite sure why this slice is here. Is it because you need a copy of the array?
Copy paste inaccuracy fixed.
Since we specify `WHERE principal_id = ?`, I think `rows.length` will always be equal to 1. One row to hold the principal_id column. You will likely have to use `rows[0].count <= 1`
It's helpful to have for understanding the API when there are 0 consumers to refer to. I fully expect these will dissolve when we have good examples of using the API from other modules.

Another benefit that I didn't want to address immediately is PrincipalTypes conflict. Should we have string-based name-spacing? Wasn't ready to answer that question yet.
Can you document the arguments that will be passed into the callback in all of your public methods?
This file has a missing license header
왜 CommandTokenizer가 따로 필요하냐?
What is the race condition? Or mean lost updates?
Removed the default.
I would simplify this a bit, I wouldn't worry about the check for .., since you're no longer serving a given path.

I would simply check for remain != NULL and then use sscanf() rather than atoi. I'm abit nervous about using atoi on untrusted arguments, though I know it's used elsewhere (including my own code).
Sorry, but that statement didn't make any sense to me. If you can show me a good reason to change it, I'm happy to change it, but I need something more substantive than "it's obvious."
Aren't ``aid`` and ``@assignment.id`` the same thing ?
Sigh. You're absolutely right.
Change ``LiveBrowserMgrMac::GetInstance()`` to ``liveBrowserMgr``
Usually, this is done for partials.  When are you expecting this to change?
This should not be _event but rather event.  Any place you include our modules you shouldn't use an underscore
Missing command docs.
This could actually use a description, but should probably be a separate issue. i have no idea what the heck this does from reading the header.
Is those really necessary?
If it's commented out like this, it should probably be removed.
`DJANGO_FULL_URL` is not necessary and wrongly defined as `DJANGO_URL` already contains `DJANGO_BASE`. You should use `DJANGO_URL` in all places where you try to use `DJANGO_FULL_URL`.
maybe something like:

http://nipy.sourceforge.net/nitime/examples/multi_taper_coh.html

or

http://nipy.sourceforge.net/nitime/examples/resting_state_fmri.html

between magnetometers?

all examples are at:

http://nipy.sourceforge.net/nitime/examples/index.html
yes a user is not going to load the src with an old mne and save with a new so it should be fine.
but what about second one + use first samp?
would get a negative index, right?

On 15.12.2012, at 19:51, Eric89GXL <notifications@github.com> wrote:

> In mne/fiff/tests/test_raw.py:
> 
> > @@ -597,6 +597,20 @@ def test_raw_index_as_time():
> >      t1 = raw.index_as_time([100], False)[0]
> >      t2 = raw.index_as_time([100], True)[0]
> >      assert_true((t2 - t1) == t0)
> > +    # ensure we can go back and forth
> > +    t3 = raw.index_as_time(raw.time_as_index([0], True), True)
> > +    assert_array_almost_equal(t3, [0.0], 2)
> > +    t3 = raw.index_as_time(raw.time_as_index(raw.info['sfreq'], True), True)
> > +    assert_array_almost_equal(t3, [raw.info['sfreq']], 2)
> > +    t3 = raw.index_as_time(raw.time_as_index(raw.info['sfreq'], False), False)
> > +    assert_array_almost_equal(t3, [raw.info['sfreq']], 2)
> > +    i0 = raw.time_as_index(raw.index_as_time([0], True), True)
> > +    assert_true(i0[0] == 0)
> > +    i1 = raw.time_as_index(raw.index_as_time([100], True), True)
> These are the relevant sorts of tests. They would have failed before...
> 
> —
> Reply to this email directly or view it on GitHub.
>
It works with rpm/deb i.e. fpm translates it for any package type it supports.
"currently run on the current user's system" - not exactly accurate. That will show the jobs for the current user, but not all the system's jobs.
You're correct. Updated! Thanks.  :heart:
I don't think it's worth internationalizing the command-line management commands.
agreed - you're enhancing the docs in a way that goes beyond your new feature. And the changes are good! So yes, first we need a PR with all of this, but without your new change (a PR against 2.0). When we have that, I'll merge it into all branches and you can then rebase and update this PR with only the new 2.2 stuff.

I know that's a pain - but it helps us a lot to continue enhancing all versions of the docs :).

Thanks!
The format looks better if you place the `:doc:`...`` section on the next line.
Typo: `incomming` should be `incoming`
please revert the namespace change (see below for the explanation)
this is asynchronous
J = math.ceil(math.sqrt(n))
Надо просто было сделать его раньше!
Понял твою мысль, но это плохо. Я бы сделал так, что PlayerTab обладает иконкой в трее. Сам подумай — это же логичнее.
blog user 的頭像 class 名稱要繼承之前 titto 的方式
However, either the variable needs a docblock with type and purpose info or the getter setter pair...
can use (if-not (empty? errata) ...)  or better yet, (when-not (empty? errata) ...)
when is better when there's no else clause, because you can have as many expressions as you want in the 'then' clause without having to wrap in (do ...).
I guess the reason I got mixed up is because I thought the 'replay' method had to be defined in match.rb for the test to pass. When I wrote the test and ran it without writing the ```def replay ... end``` it still passed... 

Your example makes a lot of sense, I appreciate the little nuggets of information like - "Generally -- only use should_receive on a different class..". I'll keep that in mind.
I would have thought to use the "for" statement.  Very interesting, and works in this context.
this task does not seem to be unit tested
Add message to response
Czech strings are disordered with respect to original ones. So I want not only to correct and translate the strings, add the missing ones, but I need to reorder Czech strings to ease the work with diff tool. <!-- NEW: is just the place-holder and reminder. Will be removed within next commits. See https://github.com/k9mail/k-9/blob/master/res/values-cs/strings.xml
Do you use another IDE than Eclipse? Normally we have shared preferences in the git repository which should convert this into a block statement on save.
The comment is wrong. Thank you. 
However, the right type should be cc.Node.
What is the difference? Spaces introduced?
Storing the size along with the cache entry would be more efficient. Would it be appropriate to add setSize/getSize to the CacheEntry interface and implement in AbstractInternalCacheEntry?
joined doesn't seem to be used?
Indeed, it's not going to work due to it only considering one character at a time (with too little state info) and therefor not parsing the grammar for comments properly; I'd normally recommend using a more elaborate finite state automaton for the latter, but crowdsourcing is definitely more cloud 3.0. Beware of using jquery files though, the excessive use of dollar signs might influence the tokenizer in thinking you might be part of a billion dollar photo filter company and could drive up pricing per token parsed.
By raising here, this functionality is eliminated, there's no way for the code path to continue. So either keeps this as a warning, or raise with just `"The faceted option is deprecated. Please use edgecolor instead."`
Fuckin perfect. Once this lands, that's another bug closed. God damn that's so god damn fine.
+1 on the excellent <code># comments</code>
This will also replace any 'date' string in any field content
Same deal about the 2-liners. Why not just have timeseries-value handle creating the array object correctly?
Sorry for being such a n00b - will just comment next time :/
Same here, just widgetData.canManage
i think he only fixed indentation, so let's do it in separate PR
I find it a little counter-intuitive that it wouldn't be using the version of Ruby that I'm using. If I install a version of Ruby and switch to it, and then generate a new Rails application, all the gems are installed and set up using that version of Ruby. With this change, the same won't hold true for generating a Suspenders application.
There's a couple potential issues here.  

One is that using the query in the metric name (i.e. `self.sql`) will likely lead to "Metric Explosion".  http://newrelic.com/docs/general/what-is-metric-explosion  It's important to limit the number of unique metric names that can be generated, since this can decrease the usefulness of the data, and (more seriously) overwhelm our systems.  This is the reason we assign metric names like `ActiveRecord/Other/select` in the ARec instrumentation.

Also you'll want to be wary of using unobfuscated queries in the metric names.  Queries sometimes contain sensitive information (e.g. Customer names) and we obfuscate that information out of them before sending them back to NR's servers.  The agent has built in facilities to do this, though in this case, not using the sql would be the better solution.

Thanks again for the contribution.  It would be great if you could update the pull request with those changes.  I can also put you in touch with our "Metric Explosion Expert" if you have questions.

Cheers,
Sam
"@" key attributes take precedence over :attributes! keys.
The default behaviour should be to only index products in categories. Otherwise, rebate products will be found as well
On 28/09/2012 01:44, Sebastian Meßmer wrote:
>
> In src/main/scala/ftanml/types/AllOfType.scala:
>
> The functional implementation is a bit shorter ;)
>
>
I had a feeling it would be. Climbing the learning curve rapidly, though.

Mike
Ok, I got it wrong then because of the mention of checking types later on.
Could you add a ``@return`` annotation?
The assignment to ``$_REQUEST`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere?
This should work in the original form. was there an issue leading to the change?
Let's wait until we see how they define Hashable, once the change to remove interface is all the way through the system.
should be parameterizedCount
I wildly upgraded to 0.11, because I think it can be done quite straightforward (not like from [0.7 to 0.10](https://github.com/harrah/xsbt/wiki/Migrating-from-SBT-0.7.x-to-0.10.x)). No idea if more changes should be applied on the code base...
@mnoble - Agreed... I removed the dependency on pry (that's just something I like, no real dependency there), and moved rspec into the gemspec.
No, attach events with jQuery. Not in template/HTML.
Yes this works. So I only have to define other resource models and do the "in-live change" - I am clueless what and where this should be.
But check if it is still XHTML compliant. :-)
Hm, still no embedded document here? ;-)
Move before `style.css` so that we can override things in `style.css`.
User visible string. As I see that it is quite repeated, maybe move it to a constant?
Empty line in-between.
Do we want to add a note that you'll need to have `Git` installed as well for this to work?
Why not try-catch block?
Do you want to remove `:version` as a required field then? Otherwise on the Shopify we would have to pass that in and maintain I guess.
Remove qualifying namespace
it maybe better to use the `stringtypes` shorcut from https://github.com/mozilla-services/circus/blob/master/circus/py3compat.py#L6 there , so we will e ready for py3 (if we aren't already)
Actually we can leave the `w+` inside the parentheses.

We just need to restrict the begin and end of string and escape the filter

```ruby
/\A#{Regexp.escape(filter)}\(w+\)\z/
```
Do one thing, and do it right.
I just tried to reduce the number of things that we put into the load path manually. I believe we can make it even nicer by adding `js/lib` to `require_path` in [gemspec](https://github.com/twitter/twitter-cldr-rb/blob/master/twitter_cldr.gemspec#L18) and directly requiring `twitter_cldr_js` here, or even remove this `require_js` method at all, because `TwitterCldr.require_js` wouldn't be much shorter than require 'twitter_cldr_js` in that case.
Yes, settings is copied over in the scaffolded app. I'll add an explanatory comment.
How is this copyright to 2 sets of people?  I assume we can't GPL this?  Can we even use it?
How does that comment make it into the build?

Thanks,

Brian Hoffman
Lead Associate
Booz | Allen | Hamilton
Supporting DoD P&R IM / MHS

On Aug 30, 2012, at 10:49 AM, "zmelnick" <notifications@github.com<mailto:notifications@github.com>> wrote:


In Product/Production/Adapters/Framework/AdapterCommonDataLayerEJB/ivy.xml:

> @@ -31,6 +31,10 @@
>    </configurations>
>
>    <dependencies>
> +    <!-- To find dependency params use http://www.mavensearch.net/ to find the XML descriptor.


This comment should be removed. mavensearch.net<http://mavensearch.net>, as far as I can tell, is a spam website that is not related to maven at all. Other organizations have removed links to mavensearch.net<http://mavensearch.net>, citing them as nsfw for their organizations.

—
Reply to this email directly or view it on GitHub<https://github.com/CONNECT-Solution/CONNECT/pull/5/files#r1497431>.
Quotes around "scons install" to make it clear that you mean to run that particular command (which is completely obvious to me, but there will be users who are new to scons and might wonder what particular scons install magic you have in mind).
I don't have a problem with this.  I don't think our requirements on the random number generator are all that stringent.  But we could certainly add code to the BaseDeviate constructor that rand the input seed through a different random number generator for a few iterations before seeding the one we do use.  boost.random does have a few recommended Merseene Twister's included, so we can pick a different one for the setup.
Worth mentioning that this can also be done using multiplication as in line 113?
I\m not sure I understand why the division is only nearly equal here.  The wording seems quite deliberate.  Is this because of the photon flux weighting that can be used as an alternative to rejection sampling?  Or is there a simpler reason?
This will go away if you drop bundlor support.
I forgot I added these comments, probably because I'm changing the need to do this import AND because this was one of the hiccups I hit late last night. I think I like the comment there now, but maybe on  a later revision I'll opt to remove it.
IOException? or something else more meaningful
Totally agree - wouldn't have made it into our real codebase.
I can certainly change this.  But the reason I omit querystrings is because (as far as I know) there is no standard for arrays as querystrings.
You probably don't need `inviting_user` here. :)
I'm confused. Why does the GET version check for `/` at the beginning of `path_segment`, but this doesn't?
I see here that XP-Language was first mentioned in v5.8.0 (http://releases.xp-framework.net/xml/release?5.8.0) which was released on 2011-01-11. Should I change `inceptionYear` to 2011 then?
In pep8, it's considered preferable to use import sys... sys.exit rather than globally import exit.
Instead of using constants, try using class instance variables like I did in #144.
No, I want to be more general, and allow some records to leave the blobprops undefined
OpenSky has a phpcs config, but not sure it catches everything either
`which_python` is not defined in this formula. You need to use the following instead:

    python#{py_version}
This would be a good use of the fmt_* functions -- format all the numbers into one buffer, and do a single write.
что в нем не некорретно?
Надо обходиться без containsKey. Т.е. так:
```
Integer count = map.get(currentWord);
if (count == null) {
  count = 0;
}
map.put(currentWord, count + 1);
```
Здесь может выброситься NumberFormatException. Его надо заворачивать в FormatterException
Ну мы пытаемся вызвать метод интерфейса у объекта...
Кроме Stack -- другие импорты не используются.
I suspect that this is is exploiting an implementation detail in jQuery and will leave us open to breakage in the future. Let's try and find another solution.
you may need to throw exception.
I noted this in the readme.
don't use relative imports for tests. The reason is to be able to spot install problems with the test suite.
The shape should be `[n_samples, n_samples]` if `affinity == "precomputed"` and  `[n_samples, n_features]` otherwise.
What the hell ? Didn't we expect set<T>(begin(), end()); ?
I don't see where ${node1} and ${node2} are set. testsuite/pom.xml sets node0 and node1. Also, the default for "node" in change-ip-multicast addresses is "${node0}" so that's inconsistent.

If there is a lot of infrastructure out there in QE-land that assumes it should set node0 and node1 (which IIRC is what's been used since at least AS 3) this could be asking for trouble.
Don't append to a string, build a list than ''.join(your list).
Don't think you want to use IsAbsoluteLatestVersion because the LocalPackage implementation returns true on get.
Does this really need to be for every expression?
…and this?
Can you please consider moving/copying the documentation from CallExp::semantic here? Being able to easily look up a type is a huge help for people reading the code (such as when working on GDC/LDC).