[V8] use checkInboundData in setWebGLArrayHelper
https://bugs.webkit.org/show_bug.cgi?id=93051

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-17
Reviewed by Kenneth Russell.

Use TypedArray method checkInboundData in setWebGLArrayHelper instead
of performing the computation manually.

No new tests. This patch doesn't change behavior.

* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::setWebGLArrayHelper):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry][EFL] Remove compile warning in WebCore
https://bugs.webkit.org/show_bug.cgi?id=94328

Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-17
Reviewed by Rob Buis.

Fixed compile time warning in WebCore.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::createEdje): unused variable ‘errmsg’ [-Wunused-variable]
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::selectionRect): ‘toX’ may be used uninitialized in this function [-Wuninitialized], ‘fromX’ may be used uniniti

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix XCode project file.

* WebCore.xcodeproj/project.pbxproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fixed incorrect references to JSVoidCallback.{cpp,h} in the project file.

* WebCore.xcodeproj/project.pbxproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Disconnect UndoManager when its undo scope host is destroyed
https://bugs.webkit.org/show_bug.cgi?id=94388

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

Disconnect UndoManager in Element's destructor to prevent
use-after-free vulnerabilities.

Test: editing/undomanager/undoscopehost-use-after-free.html

* dom/Element.cpp:
(WebCore::Element::~Element):

LayoutTests:

* editing/undomanager/undoscopehost-use-after-free-expected.txt: Added.
* editing/undomanager/undoscopehost-use-after-free.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Add a style check for #include "cc/..." in chromium files
https://bugs.webkit.org/show_bug.cgi?id=94382

Patch by James Robinson <jamesr@chromium.org> on 2012-08-17
Reviewed by Adam Barth.

Adds a style check to make sure new chromium code follows the correct convention for including cc files.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_include_line):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_check_cc_includes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r125940.
http://trac.webkit.org/changeset/125940
https://bugs.webkit.org/show_bug.cgi?id=94398

"Causes crashes on the bots
http://build.webkit.org/results/Apple%20Lion%20Debug%20WK2%20(Tests)/r125944%20(2626)/fast/css
/first-letter-removed-added-crash-log.txt" (Requested by
bradee-oh on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-17

* rendering/RenderListItem.cpp:
* rendering/RenderListItem.h:
(RenderListItem):
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
(RenderObject):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
* rendering/RenderObjectChildList.h:
(RenderObjectChildList):
* rendering/RenderQuote.cpp:
* rendering/RenderQuote.h:
* rendering/RenderRegion.cpp:
* rendering/RenderRegion.h:
(RenderRegion):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
nrwt: don't fail tests if ImageDiff fails on the wk2 ports
https://bugs.webkit.org/show_bug.cgi?id=94396

Reviewed by Ryosuke Niwa.

It appears that WTR is generating PNGs that ImageDiff doesn't
like, and so we're getting lots of "can not get ImageDiff"
errors (see bug 81962). The change in r124581 made this a test
failure, and this is causing the WK2 bots to frequently abort
with 500+ failures.

This change makes ImageDiff errors not be test failures just for
WK2 for now until we can better triage what's going on.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Preserve styling elements in DeleteSelectionCommand
<rdar://problem/12040676>
https://bugs.webkit.org/show_bug.cgi?id=93643

Patch by Alice Cheng <alice_cheng@apple.com> on 2012-08-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

Styling elements (<link> and <style>) can appear inside editable content. To
prevent accidental deletion, we move styling elements to rootEditableElement in
DeleteSelectionCommand undoably.

Test: editing/execCommand/delete-selection-has-style.html

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss): Added to preserve styling elements during the command
(WebCore::DeleteSelectionCommand::handleGeneralDelete):  Modified to preserve styling elements during the command
* editing/DeleteSelectionCommand.h:
(DeleteSelectionCommand):

LayoutTests:

Test if delete selection command does move styling elements to
rootEditableElement, when the selection contains some. Also test command's
undoness.

* editing/execCommand/delete-selection-has-style-expected.txt: Added.
* editing/execCommand/delete-selection-has-style.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125955 268f45cc-cd09-0410-ab3c-d52691b4dbfc