labofsahil/github-event-dataset-2012 huggingface dataset:
Promises/A spec doesn't seem to define this feature. Being able to return either a value *or a promise* complexity the documentation and the implementation. Without this feature it looks like we have to be synchronous in success and failure callbacks. So that it sounds like going against asynchronous and promises.
 I have really hard time understanding the API. Abstract examples using foo/bar don't necessary expose the usefullness of such pattern.

If we want to keep this feature, we should improve this paragraph. Microsoft has a dedicated page about this particular feature:
http://msdn.microsoft.com/en-us/library/windows/apps/hh700334.aspx
For example, we should explicity mention that the way to chain promises is to return one from an handler. So that second example is the best way to chain promises. We should mention that `foo` and especially `bar` returns promises. We may tell in which case it is usefull to chain promises: when we can't just return synchronously a value. And/or add some concrete examples, with fs API or something alike.
I meant this link. This link isn't recognized by the doc parser.
I think what I was trying to say is that this complicates things, as you like to say users will have to learn about these error types. If only desire is to handle such errors differently we could just set `isInternal` or alike property and avoid a lot of complexity. If you want to have custom error types it's still ok by me (just make sure to use Object.create(Error.prototype) instead), although I would prefer more simpler approach.
So is the test explicitly closing the popup dialog which will dismiss itself? Why would it do that?
fantastic documentation of the RE.
[Fixed](http://git.io/mV_BiQ)

Also added a check for email.
Not too important, but something like this seems more idiomatic to me.

    (some
      #(and (= (val %) thing)
            (key %))
      things)

(I'm very picky about reinventing the wheel in functional languages.)
ILHO, this default connection stuff is really not that important. Most applications will just use a single connection. See Ruby's AR, they don't even mention that. K.I.S.S. all the way, I can implement my previous suggestion and we'll be fine with that.
@hkenney s/Kerenel/Kernel/
Recently when dealing with another face-related issue (the one about the --name parameter), I sent mail to puppet-dev, talked to several PS folks, and got feedback from James et al.  To a man, they told me that no one outside of our employ and small circle of known contributors has written any faces... so it actually seems to me that this might be the best possible time to do this...
@pcarlisle yeah, in ruby 1.8.7, `close!` can raise `Errno::EACCES` due to calling the finalizer cleanup routine directly. I'll fix that.
Don't define methods in describe/it blocks.
OPTIONELEMENT_GROUPVALUE 不存在
改用了 已经定义的OPTIONTREE_GROUPVALUE
can kill this comment.
Is there a reason the French characters where removed?
I agree, must remove this, sorry.
If there are other reasons than readability than it's no issue explicit upper case. So I'll update.
Check the indentation in this line, you must use 4 spaces.
Plans for logger?
"Loation"
ping ?
Line 438?
Sure.

BTW, `node_modules` needs to be ignored, because it’s what brunch creates for plugins. If any other user will try to build the app, he will see the dir in git repo too.
Use `input.focus()`
right. I was looking at $.trim. I'll update
Probably. It should give the same result but I am not so familiar with PHP to know if there are som hidden gotchas. This is the code used by Shared email module so my vote would be to keep the code as it is.
Why replacing the ternary operator ?

And btw, your code is not equivalent to the previous one as you don't test the same thing (I'm not even sure it is still E_STRICT compliant)
Nope. `.empty?` doesn't work either.
This is not the signature of the interface.. :)

Proposal: Create a protected function that exposes this param and reuse it in both create and copy if you prefer that.
( similar to an earlier pull request that added param to interface signature for copy() use )
Incomplete cleanup, fixed, good catch.
text = "\n".join(["export %s=%s" % (key, env[key]) for key in env if key not in env])
This is a bit clunky. How about "Some of the quickstarts provide Arquillian tests. By default, these tests are configured to be skipped, as Arquillian tests require the use of a container. "
Достаточно делать это в preload.
В each_run можно оставить только reload FactoryGirl.

Ну и spork-rails должен вообще убрать всё про перезагрузку приложения отсюда, хоть он и выглядит не супер.
Ouch. Can we put that in the CSS somewhere. I assume CSP doesn't care about inline _styles_, but this is still bad form.
This is unnec, definition is globally accessible via the plugin registry, https://github.com/mozilla/popcorn-js/blob/master/popcorn.js#L1865-L1877
you could perhaps use self.is_element_visible here which already manages the try/except block. Like the use of `Assert.fail` too :)
Actually, we only need to check if the preference is on, or the current_use is the user, regardless of preference. If the first check returns true, it won't bother evaluating the second part of the OR. And if the user being shown is the current_user, it doesn't matter if the preference is on or not.

Do you think you could, in your copious spare time, update it? :D <3
I'd delete this entire comment, only leaving a note about the types of arguments to enforce condition.

Example formatting:

    :param condition: condition to check
    :ptype condition: function request → bool
    ....
Forgot about that bit. Off the top of my head I don't think that
trying to "pretender" the resources would be easiest path to take.

What about some sort of delimiter? A fake handlebars helper could do the trick.

I.e. input template; spilt on {{yield}} or some other literal; compile
part 1 and part 2 as separate templates.

I def like the single template idea if we can make it work.

Sent from my mobile device

On Jul 13, 2012, at 6:55 PM, Ryan Eastridge
<reply@reply.github.com>
wrote:

>> @@ -162,6 +162,18 @@ The scopes are somewhat akin to CommonJS modules, generating a `module` instance
>> general input from plugins and the `exports` or `module.exports` variable allowing for the module to
>> expose functionality to the outside world.
>>
>> +The output of a module can be customized with two templates each of which will receive `scope` (the current module scope) and `name` (the current application name) as variables.
>
> I guess the thing that is confusing me here is that we're pushing and unshifting callback functions onto the resources array. I'm not sure how / when we would combine the resources into a single compiled string that could then be passed to template. If you can point me at the right technique I'll take a stab at it.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/walmartlabs/lumbar/pull/64/files#r1163228
Can yield be called in here?
you probably meant `cleanAuthor("author", true)` rather than using false as a string, which evaluates to true.
Really please don't remove the initial `{}` here. Like I said above, it causes a bunch of errors if you don't have this.
Cucumber is primarily for features, stories that might be written by a customer. If a customer would really care about a particular failure mode, then it's worth making a Cuke feature for it. Usually, though, they don't care.

Unit tests should test object/class success and failure. While you could absolutely use cuke for unit tests, too, we've found through experience that RSpec is still better suited for them than Cuke is.
Lol I use too many different formatting profiles... VP is spaces, CraftFire is spaces, then I forgot Spout is tabs :/. Will fix tomorrow.
blah blah blah3
this shouldn't be translateable I don't think
I can see it.

So are we sure we want to reset the elapsed time there? What was the issue with leaving it?
а зачем тут дефайны? и почему если не установлена печать, то ты вообще не запускаешь тесты?
to respect some "standard", this lines should be :
```
start on (filesystem and net-device-up)
stop on runlevel [!2345]
```
This not actually help for translation, the value of LEGEND is not being loaded there, if you are not using LEGEND in other places, i would suggest to place the string here.
What if the regex is invalid?
"datasource"?
I think it'll be clear enough — the text formatting will make it apparent, and the way it's used in the other lines should lend it comprehension, too. If we get a complaint, we can change it, but I don't think this will be an issue.
The `headers` parameter, and the way it is used seems very specific to HTTP, but we may not always be communicating with HTTP. Would it be better to have a standardized parameters object that has options such as:

opts.filename
opts.contentLength

And then the back-end can choose to (or not to) use them and serialize them for appropriately for the remote service?
I think `rows.length !== 1` is not needed here. `rows[0].count === 0` is sufficient to check whether a profile was found using this query.
The jEditable plugin uses the returned body to update the value in the UI.
Good way to document callback params. Can you please pass this on to Simon and Bert so we use it / progressively fix up going forward?
This should go into one big 'verify cropping validation' test.
```php
$timezone = $timezone ?: null;
```
Great, thanks. But why the e6 argument with a default value. I find it a bit strange. What other value would make sense to pass in here?
Ik zou al dit voor nu gewoon weglaten. Komen we later op terug.
Сравнивать NSString'и следует так http://stackoverflow.com/questions/3703554/understanding-nsstring-comparison-in-objective-c
Что бы избежать потери точности при делении
Почему вы так решили?
Очень запутанная и неочевидная реализация метода mutate
тут сравнения объектов или указателей на них?
You should bump up the getVersion method if you change the packet ;)
is it wrong to be explicit?
Use formatting instead of concatation:

    self.logger.debug("JSON data url: {0}", url)
IMO its ok. It was used only one time in the core. I don't thinks users used it.
we do contact lookup in the call log too. so we need it.

On this note, the SMS background service does contact lookup too, how are you suggesting we do that? (currently broken in this pull request by the removal of libphonenumber in the sms background service)
As below, I don't know if this test is valid. It doesn't seem like we should depend on `+combineLatest:reduce:` re-subscribing to the same signal multiple times.
same here... still I think if one would decide to run for cfse: it WILL fail.
Would you compromise on ```FindCommonAncestor```?
Please don't use scriptlets i.e. < % rather jstl < c:set var="groupOpen" value="false" />
Maybe mention some of the uses of these technologies? Maybe file servers, database server storage, amongst others?
It's worth mentioning to translators that these choices refer to theme names.

    # Translators: This is a name of a Sphinx theme.
Done - it probably was my mistake just not in this PR :)
Include a filecomment in each code-block:

    .. code-block:: yaml

        # app/config/config.yml
    
    .. code-block:: xml

        <!-- app/config/config.xml -->

    .. code-block:: php
 
        // app/config/config.yml
Hmm, I don't like these changes. Is there a coding standard that we're following to do this? I know you often see things like `if (false === $var)`, but I'm not as convinced with this part - just seems less readable/natural
I think it is better to put this into a note, or something like that, or in a normal PHP comment (`/* comment */`), but not in a PHPdoc comment.
iPhone :smile:. I wouldn't align due to breaking comments in the middle and the precedent set by other parts of Stirling codebase.
нет. Там упоротый bimap же.
¿Por qué `DEV1`?
nada, lo mismo que pasa con el mail de los postulantes

On Thu, Oct 4, 2012 at 9:47 AM, Alpha <notifications@github.com> wrote:

> In source/CommonJobs/CommonJobs.Domain/Employee.cs:
>
> > @@ -18,6 +18,13 @@ public Employee()
> >              AttachmentsBySlot = new List<SlotWithAttachment>();
> >          }
> >
> > +        [Display(Name = "Usuario")]
> > +        public string UserName { get; set; }
> > +
> > +        [Display(Name = "E-mail corporativo")]
> > +        [DataType(DataType.EmailAddress)]
>
> ¿El DataType no nos mete validaciones en JavaScript, verdad? ¿Qué pasa si
> se ingresa algo incorrecto?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/193/files#r1761190>.
>
>
When get-subsin-act-key is updated to return a list, this also needs to be updated to verify the list matches an expected list (probably without respect to order, because there's no telling what order they'll be listed in the UI, it doesn't matter to us).

You can use sets to compare and ignore order:

```lisp
user> (= #{1 2 3} #{3 2 1})
true
user> (= (set [1 2 3]) #{3 2 1})
true
```
"at" the top of the class
The idea was to run the calculations (especially needsRepaintForHeading) only every half second to preserve battery. updateDirection() is called every 60ms. I can rename timeLastRepaintPositionOverlay into timeLastPositionOverlayCalculation.
Our rollback method right now is to basically relaunch the instance on the same host, so this would require that libvirt has already forgotten about the instance. In other words, this needs to happen after bless which is why the method is named post_bless.
It's fake mode... returning data in bytes... translates to roughly 140mb.
Some comments on why this is really needed would be useful.

A safe copy is needed, and we cannot rely on building a colleciton based on the iterator and clear it after `evictionManager.onEntryExpiration` because the notification could be async and so, we could cause malfunctioning of the listener implementations.
Hmmm, I think I can see why you're doing it... but, couldn't you keep the configuration object with the original setting, and make the StateTransferManagerImpl compute whether fetch state transfer is needed or not based on looking at all configuration parameters? This state transfer component could keep around the calculated setting and then reply to other components that might need to know. I think this is a cleaner solution.
I don't think you meant to commit this :P
while you are at it .. the code also does not match the Symfony2 CS .. there should be a space after ``if``
Indeed - I deleted it.
Perhaps it would be better if these two lines lined up with the opening parenthesis of `np.array`?
I asked @malini this too and she said it was something to do with importing the touch script to the client on every test run. They wanted to reduce that overhead on non-ui tests.
Consider switching away from numbers altogether.  Come up with strings for each level.  Perhaps:

* cts-admin    (for cts_admin)
* cts-general    (for cts)
* cts-external   (for calllog)
* standard    (all others)
Thanks guys, now I just need to get lucene-querybuilder working with python 3.3
You're missing one.
We use `data-` in a lot of places to store extra data that might be needed again so I'd say yes. It should be doing a parseInt.
I prefer the first one too.
yeah, that's right
it should be, but the idea is that if one update statement takes longer than the one after it then you might get parts out of order in the db, but the seq number should correct that, right?
I think this is more naturally grouped with the cursor stats.  In fact, to avoid the long description, maybe we should track byte counts for each operation type separately, so we end up with "cursor_insert_bytes", "cursor_update_bytes", "cursor_remove_bytes"?
From my testing today, mongo gives error if only one of min or max is specified. It needs both to be set, or both unset. Cant set only one.
cb.path is the minecraft.jar path, NOT the backup file path
Fixed up issue @fb55 brought up
Is this likely to come back?
würde eager initialization vermeiden.
Protipp: XML comments können mehrere Zeilen umfassen :P
curious why you changed this vs using a method cascade as shown in the api docs?

    Stopwatch watch = new Stopwatch()..start();
The specific proposed change in behavior is to make validation happen only on `save`, not on `set`, unless opted-in.

This (while very different than how it worked previously), is I think might be the only way to keep it both consistent and useful.

If you validate on `set` by default, you have this perennial problem:

    var model = new Model(attrs);

... when validation fails. If the behavior diverges between that and this:

    var model = new Model();
    model.set(attrs);

... I think that should be considered to be a bug.
sorry for commit mess around this one, but i had troubles finding out what you wanted to do with it. Now it's perfectly clear. Sorry for that.
I think we should try to find an alternate way of solving this issue. This feels like we know too much about the implementation details.
It is an error, I'm fixing it.
Oh, yes, I noticed that unnecessary typo too. I thought I'd removed it, but apparently I forgot — sorry about that!
Aren't they in ocaml-xenstore? Dave accepted my suspend/resume pull request a few days back, iirc.

Jon

Sent from my iPad

On 15 Dec 2012, at 16:07, "Anil Madhavapeddy" <notifications@github.com<mailto:notifications@github.com>> wrote:


In xen/lib/xs.ml:

> @@ -88,3 +93,19 @@ let transaction f =
>  let wait f =
>       lwt client = client in
>       wait client f
> +
> +let suspend () =
> +     lwt client = client in
> +     suspend client


I seem to be missing this definition when I try to compile:

File "lib/xs.ml", line 99, characters 1-8:
Error: Unbound value suspend


Where is suspend meant to be defined?

—
Reply to this email directly or view it on GitHub<https://github.com/mirage/mirage-platform/pull/10/files#r2428510>.
Hm.. I don't think the text was supposed to be localized because they are company names (e.g. Adobe does not have some other name other than Adobe as an example) I believe I confirmed this with Chelsea before so I assume all are as is.

As for the image as a link, I guess we could. I'll rebase that tomorrow.
If you're allowing open and close to be independent then if you only have a close date you get "and closes on..." If they have to come together you may as well combine the two tests.
So, change that `3` into this setting.

And think if you want to leave this as a setting or top-level (module) constant.
Thanks.
So I'll limit the query to fetch for last 12 minutes, and then add two flags, one for data older than 2 minutes and one for data older than 10 minutes, ok?
*vnesi*
Add TODO about error message displayed to the user.
I know I am old-fashioned here. I even don't like `>` selector.

But this is from my experience. That once you name the div with `id`, because there was one need. Then designer finds also other good uses of it. And then can create selectors which are possible because there is that `id`. So it is more the idea, that if there was once such a need, it could happen also in the future, and it will open also new ideas how to design things. You must also know that most designers have problems creating complex selectors. So providing them with such tools makes things easier for them.
Panels themselves are such an example. ;-) But there is a bit more complicated, because they allow registering from different apps. You do not need this (you do not need something like `panels_pool` we have). But for structure of base class and subclasses, yes, something like that.
OK. Or:

```
if (checked) {
    panels_forcedby[dependency][panel] = True;
}
elif (!checked && panel in panels_forcedby[dependency]) {
    delete panels_forcedby[dependency][panel];
}
```
That's nice, yes. It could be also like:

```
setTimeout(function () {
    marker.setAnimation(null);
}, 750);
```
I feel like this should error out when instantiating the helper where the credentials are initially passed in, not delayed when receiving the notification.
There probably is, but
 - I don't have test devices for these versions that can receive PSTN calls.
 - Since this diff adds support for many devices without changing behavior
on the rest, I prefer to get this CL committed before we add the other
cases.

On Sun, Oct 14, 2012 at 12:26 PM, Moxie Marlinspike <
notifications@github.com> wrote:

> In src/org/thoughtcrime/redphone/pstn/IncomingPstnCallListener.java:
>
> > +
> > +  public IncomingPstnCallListener(RedPhoneService service) {
> > +    this.service = service;
> > +  }
> > +
> > +  @Override
> > +  public void onReceive(Context context, Intent intent) {
> > +    if(!(intent.getStringExtra(TelephonyManager.EXTRA_INCOMING_NUMBER) != null
> > +        && intent.getStringExtra(TelephonyManager.EXTRA_STATE).equals(TelephonyManager.EXTRA_STATE_RINGING)
> > +        && service.isInCall())) {
> > +      return;
> > +    }
> > +    Log.d(TAG, "Attempting to deny incoming PSTN call.");
> > +    TelephonyManager tm = (TelephonyManager)context.getSystemService(Context.TELEPHONY_SERVICE);
> > +    try {
> > +      Method getTelephony = tm.getClass().getDeclaredMethod("getITelephony");
>
> Is there no way to case this for 2.2 and 4.0 as well?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WhisperSystems/RedPhone/pull/9/files#r1837719>.
>
>
You are iterating through the array twice here: First with map, then with join.

Can you not do the same thing with:

%message= errors.full_messages.join('. ')

This only iterates through the array once.

Also, I would suggest changing the delimiter to something other than ". " It's possible that this could appear one of the messages.  For example at the end of a sentence.  This makes it difficult to parse the individual messages in the client.  How about splitting on newline or semi colon?

Lastly,  I'd suggest using "#{message}."  It's safer than using + (it will not raise exceptions when message is not a string).
Bring this line up to 52 and out 1 tab
Good point, Collections.EMPTY_LIST will do fine here. Changed.
There definitely used in older projects that had this code as part of the incuna app
Now changes were tested and works fine.
Boom!  Fixed.
this is not the right place to validate the parameter, all the validations should happen at the beginning of the method.
This is not the only error that may occur. You should probably catch the specific error that's raised in case of too few params, and otherwise re-raise the original exception.
I understand that.  On the other hand, by strongly encouraging a standard, downstream tools can expect a standard (for example, to find the method name associated with a test run, throw away everything in brackets.)  This has been a (somewhat accidental) win for standard JUnit tests, as well, which are usually parseable into class and method names using simple rules.

Any chance I can win you over?  :-)
I like long lines more than split lines in the middle of work. ;-)
Since we are now using JoinPoint arguments I think it may be good to use @Around notation, and get rid of the before/after.

@Around("@annotation(annotation0")
public void outboundMessageEvent(ProceedingJoinPoint joinPoint, OutboundMessageEvent annotation) {
    delegate.beginOutboundMessageEvent(joinPoint.getArgs(), annotation.serviceType(), annotation.version());
    joinPoint.proceed();
    delegate.endOutboundMessageEvent(joinPoint.getArgs(), annotation.serviceType(), annotation.version());
}

It may reduce some overhead, and will simply reading.
i don't think you want to check this in..
How does this handle sublcassing, particularly where the class defines `@events` in the "usual" way?
Technically `V(0)` invokes the constructor for `V` with 0 as the argument, rather than casting `0` to the type `V`.  But once the compiler gets done with it, both versions do the same thing.  And I'm too lazy to write out `static_cast` all the time for those kinds of things.  But if you are really casting something (typically a non-POD object) to a different type, rather than constructing a new object, the `static_cast` is de rigueur.
I agree.

On May 14, 2012, at 12:34 PM, Mike Jarvis wrote:

>> +
>> +    Does some checking for sensible inputs, unlike the functions it calls (ReadAsciiInputCat()
>> +    and ReadFitsInputCat()).
>> +    """
>> +    # First check for sensible inputs
>> +    if cat_file_name == None:
>> +        raise IOError("No filename given!")
>> +
>> +    # Raise an apologetic exception for FITS input-wanting users
>> +    if filetype == "FITS":
>> +        raise NotImplementedError("FITS catalog inputs not yet implemented, sorry!")
>> +
>> +    # Then read in from the ASCII-type catalogs
>> +    if filetype == "ASCII":
>> +        input_cat = ReadAsciiInputCat(cat_file_name=cat_file_name, comments=comments)
>> +    # Return catalog to the user
> 
> Come to think of it, this might not be bad policy for all of our checks against user-generated strings in the config file.  We don't need to be heavy handed about enforcing CamelCase for everything.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/146/files#r817396


-------------------------------

Rachel Mandelbaum
http://www.astro.princeton.edu/~rmandelb
rmandelb@astro.princeton.edu
pushed a fix
Is this supposed to say exist?
it's better to use
root_path
@igreactive Can I still merge, even with this line? In other words, do you think that this would cause other coders to waste time, or can we just fix it later?
scary to me, because we can't guarantee we'll do it right (i don't think, unless there are routines that do it well ... if we really need smarts we can add them but the rules like single quotes inside double quotes etc would take a while to suss out).  wdyt?
Again can use `MutableMap.of(...)`, but not worth changing. Just for future reference.
this path looks strange, is that what it is supposed to be?
ok dans ce cas la soit plus precis, parce qu'on a l'impression que tu parles en general
Yeah, you're probably right. Got a bit carried away by my random test cases... ;-)
More naming, I think this reflects what is happening better:

```ruby
initialize_delayed_job if Evenitron.delayed_job_present?
```
Can you add logging here? It's not clear what's the problem here. As I undestand, we'll have exception here in cases

- No version record
- Several version records

It would be highly useful to distinguish this cases, and log message is a good starting point
If you put `approved`
Both Runtime and Instances have Position = 1. I don't know commandlet writing enough to know if this is ok or not?
This is a non-backwards-compatible change (`@articles` to `articles`) meaning everyone who started using the 3.0 version will break when they upgrade to the next version. Could the old way be retained?
Again, can we change that to:
Test for PHP-266: segfault when connection string refers to unknown replica set member
maybe should we put that with the implementation of the behaviors, rather than importing them here?
For what it's worth, I'm leaning very heavily toward making these class triggers. That would have the smallest impact on Marketplace code, which looks to be the principle customer for this package.
We actually don't need this anymore.
we only have the issue: https://github.com/jackalope/jackalope/issues/90
Why doesn't this line work on Ubuntu?
Good point. I'll update the documentation within an hour.

The functionality is simular to the registry.js except it being a registry of different kind of objects. The 'features' used here wrap a webinos API implementation into a feature object (aka service) and manages its lifecycle on the overlay network.
Yeah, did I make a bad assumption somewhere?
can we change this to 
```from socorro.lib import transform_rules```
or 
```import socorro.lib.transform_rules as transform_rules```
instead?

Because, as you're reading the code (or debugging) it's easier on the brain to read "tranform_rules" than "tr".
set the buttons as UI buttons with properties and listeners
Ah, I see.  An if statement could have accomplished that, and at anyrate line 17 is well over 80 characters. (I don't personally mind going a little beyond 80.)

Anyways, just some thoughts.
На будущее, по Code Conventions OPN (аббревиатура) должна писаться как Opn.
This makes searching through the `Point` objects that `World` aggregates easier. In retrospect, it would have been better to store these objects in a hash keyed by point label (with a catchall for unlabeled points, possibly)
We need molly/maps/management/commands/markers too it seems: http://buildmaster.mollyproject.org/builders/molly_demo/builds/560/steps/shell_1/logs/stdio
what if several parsers support the class ? Currently, the last one wins and the oder cannot be controlled
Since you are retrieving View and saving in mCacheView which is View, casting to (RelativeLayout) is not need it
Yes!!

And check out how the ofQTKitGrabber handles video saving, with a custom ofEvent. I think we should make an ofVideoEvent videoLoaded;
Optional: I would rather this be an non-active button to remove distraction.
you should use fit_intercept=False otherwise some time will be spent centering the data which is not necessary here
I would prefer a more explicit variable name such as `query_id` (assuming this is a namespace to build pairwise combinations of search results for a learning to rank problem as formulated in an information retrieval context).
In `SGDClassifier`, we decided to not use `sparse_coef_` anymore because a sparse-sparse dot product is slower than a sparse-dense dot product. So, here too, I would just store `self.coef_`, even in the sparse case. For backward compatibility, we can define `sparse_coef_` as a property.
> Also we should stop using auc in our public API but instead used
> roc_auc. "Area Under Curve" is ambiguous as we have roc_auc and
> precision_recall_auc that are both valid yet different scoring metrics
> for classification.

+1
because AFAIK the numpy rng cannot shuffle inplace a python list.
This seems pretty imprecise... any idea why? Bad gamma / bad data scaling?
No need for `list`, I think.
+1 on adding a test
Use `generator` here instead of `np.random`.
how about 

max_iter_strong : int
    Maximum number of smaller problems solved using strong rules.

you'll then have to find a good default. Maybe 100 ? 1000?
It should be faster to test for non-namespaced class first (as most phpcs-standards should be PHP 5.2 compatible).
Is it necessary to move this before setParameter?
Not completely sure about this setting; shouldn't it rather be iso-8859-15?
typo: `calles -> caller`
I don't see this restriction in the docs and it would make sense to be able to set this in other states too. Please remove it, unless I missed something.
changed to get the parent control outside the loop
This is going to throw an error on: [:create, :update]. You have to do it in diferen lines, each one with the on:
Similar to above, I do not like the if/else statements but in this case it is different. How about a method, 'each_table_row(table_name)', that always takes a block. dump_table_rows would use it and always put to IO.
Fix whitespace here (see other headers)
Oh, I'd misread, still odd IMO, using two StringBuffers for no good reason.
Could just use errorMessage(errors) and add "," when not last.
Should use:
> indexCapacity = RoxieRowCapacity(rows) / sizeof(void *)

as the allocated size can be more than requested.
Hmmm, it does compile for vc++ 2008... but if it limits portability I'll change it.  Just like the clean look.
I think you mean body.  I'm not sure it is worth asserting though.  Possibly while developing.
I think its not **softdeleteable**
Apparently, it is required. A normal dictionary doesn't, but a Response object expects 2 arguments to .get()
Собака нужна только если во view будешь эти переменные передавать, насколько мне известно. Особенно странно она смотрится возле ```@user_id```
We should remove this code instead of commenting it
I just push a fix
this needs to be user without the ' otherwise it will ignore the user setting passed in :)
Don't you mean where `MEDIA_ROOT` points to?
green color for the first item
helps resolve issues when switching between the oracle & h2 drivers. All the other h2 -> oracle db mapping fields can be blanked.
why the condition on ``v2.0`` ?
Format is copied from quotes and orders API
I'm on the fence, but leaning towards changing it.

Reason for not changing it:
* Currently, it is short and clean, and as functions do more work, e.g., compare this function to `Cartesian2.normalize` below, the overhead of the constructor function is less relative to the total work.
* (The JIT could figure out the duplication and remove it.  A C++ compiler totally would.  In fact, a big reason to inline functions is to enable global optimizations like this.  I have no faith in JavaScript though).

Reason for changing it:
* These functions are hot-spots since they are called so often and everything is built on them, so every once of speed helps.  Duplication is bad, and I'm DRY just like @shunter, but the duplication is minor and isolated.
What can it throw?  I thought we checked the input here and throw.
I don't have a strong argument for this other than I think it groups properties together and looks nice (however, I think true architecture astronauts have a name for it), I usually only assign to properties once in constructor functions.  I'm not advocating that everyone should do the same, but if you try it, you might like it.
Assuming this TODO doesn't need to be taken care of before we merge this into master, can you add more details to this comment and also submit an issue on it?
where u experiencing the order problem, even with the partAdded event being handled by the Router? I am asking this because you are using a queue here. I am concern that we are fixing a problem (given the assumption that the changes to the Router object solved your problem) that does not exist. Then, we are opening one more door for other types of problem.
Mobile Web's paging control looks like iOS's paging control.
Can you use something just a tad longer than c?
So, do we need to open an issue around the fact that the gem list (and it's dependencies) are not being built dynamically or are we just going back to a static list?
these should be development dependencies only.

You can also change the Gemfile to use the gemspec as well.  See that blog post from Yehuda.
no it's fine for now!
It depends if the double call to `trim` is expensive or not
What do you mean mixing `ElementType` with template programming. `ElementType` is a template which is therefore used in template programming. _All_ range-related traits are used in template programming. They're not good for anything else. And this trait not only has a name similar to `ElementType`, but it's doing something similar. But I'd still think that having this trait work with anything other than a multidimensional static array was fundamentally broken even if `ElementType` didn't exist. The only difference would be that I probably would have suggested that the trait have a template constraint rejecting anything that wasn't a static, multidimensional array rather than suggesting that it result in `void` like `ElementType` does.
Same as @alexrp says. This line changes the function to inout function, and allows declaration of inout variable in the body.
unusual indent
I would have considered this to fall directly into the purview type construction, but I wouldn't have thought of type construction as creating new types in the way that you clearly do. I can certainly move it to std.conv though.
Nitpick parentheses:
```D
auto result = appender!RetType();
```
There is no layout or view, we call this with die(). When you call   new SimpleXMLElement it will create the xml tag for you but only the very basic xml tag `<?xml version="1.0"?>` and AppDirect is asking for more. So when you call new SimpleXMLElement with a xml tag it uses the one you define.
Ça serait cool si tu ajoutais:
* l'exécution des tests en passant par l'archive phar pour sf 2.0.x (php vendor/mageekguy.atoum.phar
* l'exécution des tests en passant par le binaire créé par composer pour sf 2.1.x (./bin/atoum)
* un lien vers le chapitre 3 pour connaitre les différentes manières de lancer atoum (par répertoire, par fichier, avec un fichier de conf, etc...)
Add a comment here that you are deliberately adding a record to the deleted items table on deletion, and why.
I don't know if the manifest can be seen within a weaving hook. I will create an idea issue for that.
mhm ok  then; pls extend it
This is no longer correct.
well of course - I can't know that - but I'd hope so :) With the ~> operator it seems to me no need to lock it down so much since we don't _know_ if 2.1 will break this, so no need to force people in the future to deal with this dependency. Just depends on how conservative you prefer to be I guess, totally up to you.
//willdo
also testing the comments
I see this as a potential security problem.
08ec53e
How about tracking this in the issues intead of code?
You should always put the DLAppHelperThreadLocal.setEnabled(true) in a try-finally block.  This is to ensure that if there are any exceptions thrown, this thread local is still disabled.  This is true throughout your code.
I've actually looked into this further and found that the previous version of the gem incorrectly found the two images to be 0x0px. FastImage correctly identifies the 341x90 size. I've added the fixtures, the FakeWeb hookups and disallowed true web connections in the following commits.
if you use a QByteArray instead of QString*, this all becomes a lot easier

QByteArray busAddress = qgetenv("XDG_RUNTIME_DIR);

if (!busAddress.isEmpty()) {
    busAddress.prepend("unix:path=");
    busAddress.append("/pulse/dbus-socket");
} else {
   busAddress = qgetenv("PULSE_DBUS_SERVER");
   if (busAddress.isEmpty())
       busAddress = DEFAULT_ADDRESS;
}
Theres archserver but it hasn't made it into facter or past beta.

We could pull request facter to fall back to operatingsystem instead of kernel
If I'm reading this correctly, if they pass `port` and not `ssl_port`, they'll get a deprecation warning but it won't actually open the port.  I think you may need a third variable that does something like:

`if ($ssl_port) {
   $final_ssl_port = $ssl_port
} else {
   $final_ssl_port = $port
}`

maybe?
I changed the divs to spans inside the tag, and this works for the button tag.
Should these be volatile?
@andralex: The point is that `*(cast(ubyte*)0x100) = 1` will give you a `NullPointerError`, even if it's not a null pointer. I'm not sure whether there is any benefit to having `NullPointerError` along `InvalidPointerError` at all – it only seems to create confusion.
Because I couldn't immediately understand why it is necessary.
Conversely, is it a language feature which all druntime readers should be known? I couldn't think it is right.
It seems to me that is code smell.
each occurrence of 'CorrelationID' should be 'JMSCorrelationID' here
Right, i was just trying to stay consistent especially in case if the message will expand in the future with concatenation. I guess its ok for now
From grammatical point of view should this be <code>ThrowIfNotSucceed </code>or <code>ThrowIfNotSucceeded</code>. Also <code>ThrowIfFailed</code> would be good name candidate.
They aren't :)

I only committed the .gitignore file because I was unable to rebase otherwise. I'm new to git; I have only used Subversion before.
this period is not gramatically correct
More on __file__,

http://stackoverflow.com/questions/2632199/how-do-i-get-the-path-of-the-current-executed-file-in-python

LP

Miha
Extra space between _ and 'DRY'
Why is necessary this import? It's not used by the example.
Removed completely.
Не думаю, что мой рецепт «основной». Лучше назвать по имени.
Thanks, figured out what you meant. Bit slow this morning.
I assume that allocate() here did not actually allocate anything?
Also look at your indentation @ line 54
remove unnecessary comment ...
Please remove this. See #274 for a proper implementation of extension points
this should be ``html+jinja`` to highlight the Twig syntax
You mean the URL segment is called `apnssettings` not `apns`? I was coding blindly from the spec, since at that time the endpoint was not live yet.
Is there a way to do this without having to explicitly load Set? It seems unnecessary to make it a dependency.
erm I purposely put it twice and same, as it may be possible for the user/another view to pass the url without 'order_info', 

in other word if the pattern include order_info, it'll use the first one, else, use the second one? and as long as a view return both questionnaire_id and order_info as it kwargs, it will use the first one?

was thinking in terms of the patterns difference,  and "if-else" situation
Or is it better to rename it to explicitly define for it's purpose? :D

django will always run/try the first "url name" that matches, but not try all of it? that is why there is a possibility of that confusion you mention?
jQuery is comparable, because this "documented extension point" is [just a shortcut](https://github.com/jquery/jquery/blob/master/src/core.js#L84) to `jQuery.prototype`, extending which adds methods to instances of jQuery class (with an infinite potential for conflicts).

Sure, these things could be rewritten as functions to prevent possible collisions in future, but this also removes some convenience and readability of code, so one should compromise. Given the nature of introduced methods, I doubt they could ever cause any conflicts.

Once again, I can see how rude it might look in a static language environment, but this approach is very common for dynamic languages.
added in bf6a4e25fa7c95fd61b13a2541697eaead9eb225
For clarity's sake change <code>toggle()</code> to <code>show()</code> then.
Please don't include such comments in the source.
what if I want version 0.0.0?
Can you direct me to an existing event so that I can follow that format?
Replaced all double quotes that I could find in my changeset
You're right, this is definitely the case when they aren't doing any back-end work. If they do, they'll probably want to have an updated version (from sakaiproject). What would suggest here? Completely remove this block?
To fix the CI issues, the require.js file is not being linted. This is because I ran into an issue with functions calling each other out of order.
Does connectionchanged need to be in the actionMap as well?
(< 12 age 20) palauttaa jo sellaisenaan booleanin