labofsahil/github-event-dataset-2012 huggingface dataset:
It looks like this commit upgrades us to version 2 of the protocol.
Good to merge!
Code looks fine. And i could not reproduce the bug again. So i guess it is fixed.
Same as in line 856.
Pourquoi ne pas retourner getLB() (de la vue)? Car en générale le getValue renvoie toujours la lower bound.
Ce serait plus cohérent d'appliquer ce principe à toutes les vues non?

si x=[-5,3] getValue va retourner 5 alors que la LB de la vue est 0
Voila alors voila ce projet permettra de jouer à D&D via le réseau !
ok ^^ thank you.
is Serendipity now instant applied?
J'aime :D
??? this broke almost all missile-type spells. also this not may be compiled...
That's good. I'm a fan of shipping with a working cache for development.
Hhhh tienes razon, gracias por avisar
With this patch there are files _logs (actually a directory) and _SUCCESS that would match your pattern and would break from.dfs. Maybe a pattern that excludes anything that starts with '_'? I would love to find what the right thing to do documented somewhere instead of guessing. Multiple Outputs is not available in streaming AFAIK so I didn't thought of it, but it would be nice to have if you know how.
I think we should lower-case "ext" in the last change (in vs2010.py) before comparison, shouldn't we?
Please use dashed_variable_names, not camelCase.
This is the css file
hmm unfortunatly i think this time/date sorter is in a couple of places.  Can we find out where in backbone land we should put this global helper?
Had to add these two missing pages to the manifest. Kind of strange how it does work without them. I guess I don't understand appcache yet.
Right. Both of those invariants are good, imo.

As far as letting IO errors leak through, I think you're right. I'm
not sure what made me want to wrap them in the first place.

--
Michael Jackson
@mjackson



On Wed, Feb 22, 2012 at 10:39 PM, Bernard Lambeau
<reply@reply.github.com>
wrote:
> For `:to_path`, sorry I was a bit confused. We have the two following invariants now, which is good, right?
>
>    # The initial parsed source, being a Pathname/File/IO/String is
>    # always preserved when invoking #parse
>    grammar.parse(anything).source == anything
>
>    # The source is always a Pathname when invoking #parse_file.
>    # +anything+ mut respond to :to_str, the later denoting the path to
>    # an existing file.
>    Pathname === grammar.parse_file(anything).source
>
> You're right about consistency of error management, so I'm fine with that too. However, for the next major version, it would be better IMO to let IO errors unchanged everywhere (including in Citrus.load, that is). There is nothing Citrus can do if a file does not exists. Hiding the real cause (Errno::ENOENT) behind a Citrus::Error actually prevents the caller from doing something smart (friendly user message, catching the cause and finding a countermeasure, etc.).
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mjijackson/citrus/commit/2a79ad93874b687736edf71e4948280dd6d91aee#commitcomment-999437
so this can become an `<h2>`.
It notifies of failures or successes. I admit I mostly did this so the tests were easier to do.
What's the license for this?
This commit is linked to issue #1.
Guys, 

Sorry, hadn't looked in droolsjbpm-integration yet. Javadocs would be nice once in a while (unless you're sure that no one else will ever look at your code or need to understand it.)

Thanks,
Marco
Thanks. I pushed you corrections.
The purpose behind the setup (including "create" and void*) was not to
be flexible, but rather to be able to put the thread dependent code in a
CPP file. If we use the direct type, then all of the code has to be in
the header file, which means any user of this file also has to include
the entire set of boost threading headers (and would have to link
directly to those libraries). That is what I am avoiding by doing this
-- users of QuantLib can be oblivious to the locking used.

So, no, "create" will always use "new". It's just a way to abstract that
type-dependent bit for the CPP file.


On 02/12/2012 03:17 PM, Luigi Ballabio wrote:
> Do you have any use case in mind in which `create()` should not use `new`?
> Also, right now there's no way to pass another function to `SingletonInstanceLoader` (since it can't be passed to the `instance()` method which calls it) and `create()` is not virtual, so it can't be overridden.  So we end up always using `new` anyway.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/mortoray/quantlib/commit/dbf6b23429b21cccb0982d6f3e5c13f5860842e1#commitcomment-957739
> 
> 


-- 
edA-qa mort-ora-y
-- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
Sign: Please digitally sign your emails.
Encrypt: I'm also happy to receive encrypted mail.
While your editing this line could you do me a favour and remove the /phpbb_blog from the url.

Thanks. :)
BTW, I also see these failures here locally
Looks like yes. (
That will result in the following error message: `"Cannot use a custom kernel function.Precompute the kernel matrix instead."` (note the lack of whitespace after the period. Instead you can directly do the following:

```python
                raise ValueError("Cannot use a custom kernel function. "
                                                "Precompute the kernel matrix instead.")
```
Well, the creature ids, timers and spellids I copied from the old script. I just rewrote it because locknes said that the way the old scripts handle the Difficulty (scripting each creature, for each difficulty of the instance) was wrong.
il faudra changer le code pour correspondre aux stratégies définies dans le ia.h
I've not used any of it in anger yet so I don't know sorry. :-)

Will post back here once I get to play with it.
@briank would be happy if you find a couple of minutes to review this.
Give it a shot if you'd like.

On Sat, Mar 3, 2012 at 1:29 PM, Amiel Martin <
reply@reply.github.com
> wrote:

> Would it be helpful to have more tests around this?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/redsquirrel/resque/commit/d23b9e5b4f3df7db15d066c2b86a9dcd06b0c693#commitcomment-1039178
>
i'll try this...THANKS! only a question...this patch can work on a sense kernel? or only cm kernel?
Another style note — I've tried to avoid loading in the “all-encompassing” header files in the libcork source, and instead just load the needed pieces.  For the endianness macros, you can change this to

```c
#include "libcork/core/byte-order.h"
```
Give me a test? I actually intended this issue to be a refactoring of addEventListener to bind, not just an alias - improve the overall state of the code, not just introduce another archaeological difference.
ex7: add mmap system call, but no vma show in /proc/pid/maps
yeah it was basicly only a comment typo fix, but still :P
Thanks! That spelling has been bothering me and will continue to do so until I get around to pulling from your branch.
Dieses
Nowhere.

The lines on the info part are for future enhancements.
https://github.com/Kroc/NoNonsenseForum/commit/9e70bc7fd92e5e0b5dd9ea500b026030558ded45
turns out people rarely delete stuff.
Попробуй отрефакторить этот код. ;)
Projet indice 2
HTML indice 3
Titre/Paragraphe/Image indice 4

le tp merd si on a un autre fichier html et qu'on clique dessus
Merge from NSB master.
Sorry the commit was done by me

-Brandon
add a 'blueprint' class on the script element.
Inline JS can probe for it and know it's a nested_form blueprint.
This looks quite interesting. I understand how unbox allows me to access the inner bean, but when do I use box()?
Hi Max,

I have time (at least) to check your commits. I do have a few questions:
- in cache_inode_get.c : why removing the unlock in the case cache_inode_valid fails ? The entry will remain locked which will lead to later deadlocks. The fact is that this function almost never returns an error (which hides many things) : your code will result in a segfault because you set pentry to NULL then deference pentry->lock
- in cache_inode_getattr.c : you need to keep the V_r. If not, the pentry will remain locked, which will result in deadlocks
- in cache_inode_link.c : same issue
- in cache_inode_rename.c : same issue too. 
The key here, is that cache_inode-* calls makes all of the lock management. If they take lock, when should release it when exiting. The statements that you removed were set for that purpose. 
- in cache_inode_rdwr.c : why removing the test on if(seek_descriptor->whence != FSAL_SEEK_SET) ? Was it causing bugs ?

In the current state, I can't integrate that commit (the change in cache_inode_get seems quite dangerous).

   Regards

        Philippe
That's a kind of named argument: I think one doesn't need to read any documentation to understand the meaning of Sync.TRUE and Sync.FALSE.

Btw, I'm okay with WriteType.SYNC and WriteType.ASYNC too, the problem is I should do the same with ReadType, hence having two different enums for what actually is a simple boolean: in other words, that's the voice in my head making me wonder if after all those years of OO Java programming I'm maybe starting to value complexity over plain simplicity ;)

Btw, I'll think about that and also try to ask feedback from other users.
@mcculls sure, code format fixed on a isolated commit now.
https://github.com/sonatype/sisu-litmus/pull/3 is fine
すみません。なんかへんなことしちゃったみたいです…。
I swear it didn't look like this in my editor
patrocinadores e não palestrantes x)
would you think its useful to have a font loader class in three.js for this?
We currently ignore callstacks that involves two different third parties. We do see records that have this property.
It stores current locale, so I would leave it. getDefaultLanguageCountry() uses it (to be refactored to something like 'getCurrentLanguageCountry()'). It could also be passed via bus message. This is very trivial so I rather focus on other tasks.
I just noticed it, fixing
@richp: I started ripping apart the source to get it organized.
This way it should be possible to get a feel what actually is the discrepancy between the _SCons_ and _Ant_ builders. And the code should be cleaner.
The complete `build.xml` source is in so when a new _Android-SDK_ is released you just have to diff with the new `build.xml` and you'll notice all the changes and can then correct the methods in question.

Could you give this commit a little review and look at the general idea behind it. I'd love to hear e.g. what you think is the best way to handle (semi) global variables.
Nice, i have waited for that. Now i will setup my server :D.
Ah, ok, my bad
looks like there's a typo here : 

```ruby
sidemenu = [{:title => "Google", :url => "http://google.com/search?q=#{escaped}"},
                  {:title => "Images", :url => "http://google.com/search?q=#{escaped}&tbm=isch"} ,
                  {:title => "Videos", :url => "http://google.com/search?q=#{escaped}&tbm=vid"} ]
```
...so pirate speak is the official language? It has been decided!
Just to proof my point from an earlier comment: Such issues would have been compile time errors and easy to catch if you had not used sendMessage for communicating with the action set.
We will need to meet sometime tomorrow afternoon to compile everything
...simply specify the '*' wild-card character for these properties.
Yes I agree with adding this but I also don't agree with all of rails_best_practices.  That is a different arguement.  It would be nice to run this against the code base to see what it suggests.
I forgot, the require-kernel needs to be written to the page for IE7 (since scripts added through `doc.write()` load in undefined order) – that is probably a (minor) show stopper. I’ll devote some time to removing that requirement. `var require = parent.parent.require` should fix this (with caution around x-frame typing (`Array`, `Function`) issues).
Hi Igor, can you please use the following concatenation pattern?

String availableTabs = "email-from,web-content-added-email,web-content-updated-email";

if (WorkflowDefinitionLinkLocalServiceUtil.hasWorkflowDefinitionLink(themeDisplay.getCompanyId(), scopeGroupId, JournalArticle.class.getName())) {
  availableTabs = availableTabs.concat("web-content-approval-denied-email,web-content-approval-granted-email,web-content-approval-requested-email,web-content-review-email");
}

Thanks!
Juan
I would have phrased is `("'connectivity' should be a sparse matrix, got: %r" % type(connectivity))`
Why do we not use the `WorthwhileTypesystem` here? Note: This does not address the containment problem mentioned at line `1152` but who implements the type definitions?
It was supposed to upload overnight but it looks like it didn't happen like it should. A manual build is going now.
ok.
thanks for your reply, and I'm waiting it.
platformIdentity`
Thanks Clement. I just proposed to re-add this feature in #106 with a special switch.
I sent a PR to fix this https://github.com/thoughtbot/shoulda/pull/198
did you send a pull request
It's not a wrong value:

```C
#include <stdio.h>
int main() {
    char buff[16];
    printf("%zi\n", snprintf(buff, sizeof buf, "%s", "hey")); // yields 3
    return 0;
}
```

But according to the manpage, the value can be negative on error (whatever that means).
Эта куча use'ов действительно нужна?
Opera 9.5/9.63
Стабильно получал обшибки при работе с for(var x in y)
Цикл натыкается на ключи с мусорными объектами.
В остальных циклах по скрипту, енто не было критично.
sorry skyfire
Preprocessing will happen in the m-c build process, not on our side.
Salut all
hi there,
where is the updated version (2) that you uploaded? i can't find it here
thanks @grobie! I'll keep the atomic switch in mind when using this.

I just noticed that there's no mysql2 support yet; if I could submit a patch, would that be something you guys would accept?
@devongovett I decided to just wait and see what breaks. Also, I filed [a bug with jQuery](http://bugs.jquery.com/ticket/11316) and it looks like it will be fixed in future versions.
comment should have been removed the @raw_log initialization.
Je te laisse faire la demande de pull request.

Je mergerais ça demain!

Bonne nuit
Also why `ParameterDescriptor`
Sorry i forgot to mention.. build using framework base that i fork on this account.. :)
About managing multiboot. Why don't we just do it like it was done in nandroid restore? Boot from a folder. 2ndsystem script respective to each folder could be placed in the folder itself. That would be easier, no?
Okay thanks.To keep in contact just register at www.dekemaserv.com/forums and you will be admin.
A cleaner way to load default configuration parameters and quietly exit if the plugin shouldn't be loaded.
not sure what's the intended way to log in a middleware. Any idea?
So to understand you properly, you messaged me asking if I still hosted my code so that you could copy the camera changes, make a change, add yourself to the authors, and submit to gerrit for Kali to track your changes? Was Kali unable to contact me? Did he ask you not to tell me this intention when you asked for the location of my projects? What if I had planned to submit this work myself? Please do not insult my intelligence.
@nvie Have you though about making slight API changes to (or introduce a new API) something like this:

```
q.enqueue(
    func=func,
    args=[foo, bar],
    kwargs={'foo': 'bar'}
)
```

This will allow us to do more interesting things like setting ``timeout`` and ``retry`` (maybe?) on a per job basis. I used this syntax in https://github.com/ui/rq-scheduler because I needed to pass in extra parameters.
Is this line still needed/useful? Why was the variable name changed from `url` to `fileurl`?
This slot should probably now be in runtime_base, no? (similarly with any others)
And users generally shouldn't create instances of them :-)
IntelliJ magic! I'll remove that line...
2 to 8 seems quite arbitrary from this point of view
def gossip(): Unit = selectRandomNode((nodes - selfAddress).toIndexedSeq) foreach gossipTo
allChildren foreach { case a: InternalActorRef if a.getParent.path.address == address ⇒ system.stop(a) }
Fixed.  I even did the same to some older migrations

same for create vs. create!, right?
Why not using a `reify` decorator, instead of having one more attribute (`_dpi`). Like Pyramid one. Little example:
http://repl.it/Cbs#
yikes... may be __doc__ could be left alone and then ArgumentParser could be provided 
```
doc=__doc__

```

to internally do something like

```
description = doc.split()[0]
prolog = doc[doc.index('\n'):].lstrip()
```
(with some additional checks etc)

Having regular """ ... """ in front is more pleasing for consumption than the content of variables ;)
These three imports aren't used, is there a reason they are still here?
This is actually where the problem code was.  Needed to be a string and parameter style to use OR
This class is only for testing purpose (or will it be ?) ... if it's going to be used yes I agree with that.
We're getting rid of this one, right?
use cost.keys(), its implicit, but its also a little confusing.
I shouldn't have included this file (I didn't mean to). If you notice, it's all commented out. It doesn't really work, and isn't meaningful. The issues around implementation details of various Tuples makes it tough to make a meaningful, generic test suite.
What if I don't specify a package ? The method signature says it's not required. Add a test to that
For consistency, the naming on this should probably be something along the lines of:
  +stepToClearTextFromViewWithAccessibilityLabel:(NSString *)label traits:(UIAccessibilityTraits)traits expectedResult:(NSString *)expectedResult;
j'étais en manque d'inspiration
here's the real change, the rest is just whitespace changes
I have played with different techniques over the years, and tend to favor the multiple return one usually.  It is just a matter of opinion.  I think the extra nesting can obscure what functions are trying to do - especially in cases where you check several different/diverse conditions before proceeding.  I try to only use the multiple returns when functions are relatively small and the extra returns are easily noticeable.
OK, I'm sold on the current code.
Do the `ancestorScrollView` methods call for window rects?
I don't mind either way, actually, but those were just my two cents on it.
Actually, this could be simplified to a one-liner:

```python
o['variables']['node_use_perfctr'] =
  b(sys.platform.startswith('win32') and not options.without_perfctr or options.with_perfctr)
```
this is a nit, but can we assign value self:pop() and then return the value in the 'return' in the outside block?
Agreed, it's original code, only moved. Will fix.
Same here, just `PDO`.
If -> if
Not sure why we need to mess with these?
Revised, please check again.
Thank you and best regards
Hongcheng Chang





On 5/16/12 10:52 AM, "Subbu Allamaraju"
<reply+p-833391-d3749f2cf8ea7cc954fc3a49ef7f1f123c9046dd-1302440@reply.gith
ub.com> wrote:

>> @@ -0,0 +1,3 @@
>> +-- this route does not have the word 'with optional params', so
>>requires all params to be provided.
>> +return select itemId from finditems where keywords = '{^keyword}'
>
><del>word</del>  clause
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/ql-io/ql.io/pull/459/files#r833391
This means we are modifying the original options, no?
Would it be overkill to create a private method `teen?(number)`? to make it immediately obvious what that first bit is doing?
@rafaelfranca This had the 1.9 syntax, but failed the tests when I ran it locally, I will convert it back
Good catch. fixed. Those long lines were killing the formatting in my editor.
I would place a dot in the beginning of each line but Ruby parser can't handle comments in-between :-( The receiver is the previous line, I've made an indentation to help people see that.

The previous code converted to_sql everything but strings: `s = s.to_sql unless s.is_a?(String)`. I'm doing essentially the same thing, except I ask the object if it can convert itself rather than check type.
We should not always add this middleware, we should add it just if the configuration is set to pending.
extra whitespace before the `&block`
FYI this can be written

    val res = typer.typed(Function(List(), tree))
    res.changeOwner(typer.context.owner -> res.symbol)
How to document guide improvement: https://github.com/numpy/numpy/pull/255
Putting control transfer in a macro is just sinful. I cry every time I see this in Numpy, and I'm sure that somewhere a puppy dies.
Mutable default arguments are dangerous.
This needs a doctest. [I feel pedantic in pointing it out, and it annoys me to no end in writing my own code, but *all* new user-facin methods should come with a doctest.
good catch. It's been added back. I had deleted it when it appeared that powsimping couldn't be done with symbolic exponents.
We should add several more tests for empty matrices (basically, anything that is not already tested).
It is better to use more specific typenames.
@romainneutron no need to comment on this old PR, yours practically replaces it.
What I mean is that if getifaddrs() return zero results (which indeed happens and is not an error), count gets zeroed. In that case it doesn't matter what addresses gets set to (NULL or a unique pointer) because there's nothing to read.
we should have a warning or note that says you don't ever actually want to do this *unless* you **need** to have indexes that are compatible with versions of mongod before 1.8.2?
same, as above.
two line breaks?
Before you can?
FROM should be on the next line
Missing a space before true. And no, letting this default to true is fine.
You need to open the file in your editor and delete the newline at the end.

If you know how, squash that commit into the first commit that added the newline.
use sql_fetchfield('msg_id') and cast to bool
Was underscore handling changed in sqlite3? This should be researched, the code changed as needed and the comment deleted.
What do you mean by independent breakage? And as far as I know, no test covers this code, though I'm not sure what one would look like.
`$this->unlimited_read` vs `$unlimited_read`
Same here, this should simply be a private function on the implementing class.
Poți filtra direct:
`return Activity.get_player_activity(player).filter(action='chall-refused', timestamp__gte=start).filter(user_from__id=player.id).count()`
Rename `easingFn` to `easing` and `lastFrame` to `duration` please.
Instead of `rescue nil` I would suggest to use 

    unless $1 == '-'

In this way we are sure to let the parsing fail in case of an other different response.
вся нагрузка обновления дневной статистики в моем варианте, это 1 insert ... select запрос в конце дня
в твоем варианте тоже 2 крона будет, 1 проверяющий лимит, 2й обновляющий суммарную статистику за прошлые дни
Suggest that we name the methods more clearly to indicate their roles. might prefer to have "logoutUser" and "loginUser" methods, to have a clearer sense of the workflow? ("loginUser" would replace saveBasicAuthHeader).

Other *suggestions* might include:

beginUserSession
getUserSession
endUserSession

or

saveBasicAuthHeader
getBasicAuthHeader
deleteBasicAuthHeader

but if you can come up with something better, please do!
Consider renaming ```drug``` to something clearer. I find ```drug``` a confusing variable name because it's actual plural (zero or more drugs), not singular.

maybe ```drugGrid```?
Okay, never mind. Instead, don't include the navigation view example (we only want the code you have written) -- close this pull request and make another with just the screener module code.
This comment shouldn't be here. It should be the test name (on line 85).

    e.g. it("has the same text on the userName label in the UI and in the i18n properties file")

My main reason for this feedback: when a test fails, the user will see whatever the name of the test is (it("<name>")). So please make the name as descriptive as possible, rather than forcing someone to look up the test code in order to find this comment.
How were the tests working before this?
@bblay - this is just my thinking. Feel free to ignore.
Hmm the test looks like you are checking that a ValueError is raised. What am I missing?
does this close the gossip just sent by GossipHello6() ?
Actually `Ember.isNone(date)` would be better.
Struck.
@aaugustin The pull request has been updated to match your request.
Just because it's not the source, doesn't mean it shouldn't follow the style guide LN14-23
I'd expect this test to run with `checkJqData`. Maybe allow `QUnit.expectJqData()` to set it without adding any specific expectations?
I love hot paths.
I wasn't sure that there are no other number values, that's why I did it this way. Should I simplify it then in my repository?
You could write this as BLOCK_SIZE = 1 << SHIFT_SIZE; to guarantee that it's the correct value
Hmm, this one is actually problematic. If `value` is the result of a subtraction, then we are facing the problem of loss of significance. (We obviously know the difference with much less precision than we knew the original values.) From a numerical perspective, the only clean solution is to change the signature and have three parameters `first`, `second`, and `mu_0`. Alternatively, the user could provide a different argument that tells us the precision with which the differences are known.
maybe disconnect the signals in Monster::forgetTarget?
It should not really matter but i think it would be more clear.
Makes sure all slashes are forward slashes, because back slashes don't work in bash on Windows.
I will take a quick look at this later today. Not quite follow your branching strategy here. Which branch you want me to target the new pull request for?
Having this change return types based on inputs feels fishy.
These should be as a list to protect against spaces in the paths, i.e.

```rb
system "install_name_tool", "-change", ...
```
Just plain `#{var}` is shorthand for `#{HOMEBREW_PREFIX}/var`.
Setting them shouldn't be necessary unless `configure` is ignoring the `MPICC`, `MPICXX` and `MPIFC` environment variables that it should be paying attention to.

I guess the bottom line is: if this doesn't build unless `CC` et. al. are set, then there should be a comment noting the errors that result so we aren't left asking "is setting these necessary?" all over again several months down the road.
We really want to override run! (so that we can insert our own exception processing) rather than catching errors before run! returns.  The goal is to have a single clean method that does all of our exception handling, and since we have a need to do that for InvalidCommandError (because we want to intercept the error), we should extend and replace run! rather than run_active_command.  By doing that we can take authoritative control of the logic, but keep it isolated from start (which is about defining the runner).  Having the local module subclass for Commander::Runner is the right approach though - I like that much better than monkeypatching.
In this example, ``$documentRoot == '/var/www'``
Pourquoi le supprimé? Juste pour tes oreilles?
I don't think we need this executor (see below).
Why ?
And why not  $(grep '^version' setup.py | sed -e "s/'$$//" -e "s/.*'//") ?
The basic semantics (structured menu with option text, etc.) are the same, but the implementation is slightly different. If we should ever need an explicit menu format, I'd like to have a few examples to abstract over. (I have no plans to actually do this, though. Just leaving options open.)
Den Shortcut gibt es ja nur für die ID, nicht für die anderen Felder. Und diese Funktion wird sehr oft verwendet, man braucht meist nur die Id. Deswegen finde ich die schon ganz praktisch..
Ah, I finally see -- you're setting the revision id params and overriding the page name param with the appropriate name. Coulda saved me a lot of time if you'd replied to Logans' and my comments with clarification! :(
```
# * <tt>:domain</tt> - the domain to update for. E.g.: "domain1.com"
# * <tt>:attributes</tt> - a contact attributes hash like:
Ok - I've traced the flow through, I think you're right.  But the way we're doing this with scope(blah)  wigs me out because I NEED to widen it to support multibindings (or clone it).  But the assertion is good.

Though if we're "double scoping" that's not bad, per-se - depending on the meaning of this method.  In practice, it's "if this is a scoped binding, but hasn't been scoped, wrap it in a scoped binding."  In that sense, passing through this method is a non-issue.

having said that... my plan is to eliminate this whole flow and have Binding handle scope properly without creating this extra object. But that's a different CL.  In this case, I'll change this to an assertion.
Or, how about we use a Set for each channel?  http://redis.io/commands#set
Ahh. I forgot to remove it. I'll do it tomorrow

Roar

On Mon, Sep 17, 2012 at 9:32 PM, Olof Nilsson <notifications@github.com>wrote:

> In stages/processing/basic/pom.xml:
>
> > +        <dependency>
> > +            <groupId>commons-codec</groupId>
> > +            <artifactId>commons-codec</artifactId>
> > +            <version>1.6</version>
> > +            <type>jar</type>
> > +            <scope>test</scope>
> > +        </dependency>
> > +        <dependency>
> > +            <groupId>commons-lang</groupId>
> > +            <artifactId>commons-lang</artifactId>
> > +            <version>2.1</version>
> > +            <type>jar</type>
> > +            <scope>test</scope>
> > +        </dependency>
> > +        <dependency>
> > +            <groupId>org.springframework</groupId>
>
> We can't have dependency to Spring here, and it's unused.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Findwise/Hydra/pull/76/files#r1622164>.
>
>
Shouldn't this be modified by reference instead? Why would you ever need to setNotEquals()? getNotEquals should never return null, so it should really just be modified (changed by reference).
I assumed you meant that you want to have it Matcher<PrintableResult> instead of Matcher<Result>. Also I moved the causedBy matcher to JUnitMatchers.
We should document that this is a key**down** event specifically.

I would suggest changing the method name too, to make it even more explicit, but I wonder if at some point down the road we'd want to just make itconfigurable via another argument...
I'll check on windows.
This user story implements extensions other than .htm/.html, so it not experimental anymore.
Good call. Editor didn't pick this up...
What about using "Click to switch indentation to spaces" and "Click to switch indentation to tabs" to give it more context?
i << 1
(i << 1) | 1
On 09/27/2012 03:40 PM, David Pollak wrote:
>
> In web/webkit/src/main/scala/net/liftweb/http/LiftServlet.scala:
>
> > +   * Tracks the two aspects of an AJAX version: the sequence number,
> > +   * whose sole purpose is to identify requests that are retries for the
> > +   * same resource, and pending requests, which indicates how many
> > +   * requests are still queued for this particular page version on the
> > +   * client. The latter is used to expire result data for sequence
> > +   * numbers that are no longer needed.
> > +   */
> > +  private case class AjaxVersionInfo(renderVersion:String, sequenceNumber:Int, pendingRequests:Int)
> > +  private object AjaxVersions {
> > +    def unapply(ajaxPathPart: String) : Option[AjaxVersionInfo] = {
> > +      val dash = ajaxPathPart.indexOf("-")
> > +      if (dash > -1 && ajaxPathPart.length > dash + 2)
> > +        Some(
> > +          AjaxVersionInfo(ajaxPathPart.substring(0, dash),
> > +            ajaxPathPart.charAt(dash + 1),
> > +            Integer.parseInt(ajaxPathPart.substring(dash + 2, dash + 3), 36))
>
> I'd really like to not have a limit on queued items.
>

+1 for no limit

-- 
Andreas Joseph Krogh<andreak@officenet.no>  - mob: +47 909 56 963
Senior Software Developer / CEO - OfficeNet AS - http://www.officenet.no
Public key: http://home.officenet.no/~andreak/public_key.asc
Spacing please!
I'm literally copying what YouTube does, and I'm not sure why they do it this way, but they do.  We can move into the embed.css stylesheet if it won't change anything.  What do you want me to do?
Change this to `cp( BUTTER_CSS_FILE, DIST_DIR);`
Why not just switch this line with `target.build()` below?
Lint sez: `src/util/dragndrop.js: line 67, col 4, Unnecessary semicolon.`
don't think we should rely on www
Cannot revert this.

#000 does not work in chrome, has to be #000000.

It just so happens chrome defaults to black if the colour is invalid, so we never saw it.

Trying changing it to #FFF and see it go to black.
Are you positive this isn't necessary? It's a bit of a relic, but does `addTrackEvent` ensure that the changes are baked in?
Use the "~0.9.1" syntax here. You'll also need to regenerate the shrinkwrap file using `npm shrinkwrap` once you've installed v0.9.1.
don't need variables for oldSrc and updateOptions
Yes, not sure why this is here
You probably don't need this here.
I don't think this change should be made; what's wrong with the vertical list? Aside from it being long
Yeah, turns out there are two zoinks ><

This zoink is actually not in use and Matt has it removed in another ticket.

I'll just remove the changes and not touch the file
Ah yeah.  Mike is right here. element.hpp is  a new file, but we did copy the license text from Willow Garage.  I'll change line 13 to IPI.
I'm wondering if we need to pass group into all of these events... we can just get it from the item that we're passing in.
I've really tried to get away from throwing exceptions in constructors in favor of creating a static method in a companion object that does this kind of checking. I've run into some really strange object initialization errors in certain cases when this happens.
I didn't know that.  Hmm, yeah, I have no idea.  I'm sure I can find it somewhere, and change this accordingly
@omidgharib 
in userete! khob to vaghti useret ba horufe kuchike, taghsire baghie chie!!!? :-)
vaghti to khodet be khodet tohin mikonio ehteram nemizari, che entezari az digaran dari!!!? :trollface: ( :smile: ) :trollface:
Are any additional 'param_rules' needed to support the new actions? (e.g. create_system_custom_infos, update_system_custom_infos,...etc.)
I'd probably make this into a class method/scope since it seems like we'd maybe want to use it again and that way you wouldn't have to call `#send`.
Reshaprper refactoring
I am not sure if I am sold on this change or not… will need to see if Rails parses ISO8601 out of the box
you can remove the ``$content`` variable. It is unused
Look at the docs (http://docs.rackspace.com/files/api/v1/cf-devguide/content/Create_TempURL-d1a444.html), you also need to specify an object prefix when creating a temp URL for a container.
What is this global call for?
Ok, will do.


On Wed, Dec 26, 2012 at 4:00 PM, Luke Steensen <notifications@github.com>wrote:

> In config/environments/development.rb:
>
> > @@ -35,6 +35,8 @@
> >    # Expands the lines which load the assets
> >    config.assets.debug = true
> >
> > +  config.serve_static_assets = true
>
> This could actually *cause* double execution errors. You prevent them by
> setting this to false, telling rails to ignore /public/assets/ and go
> through the asset pipeline every time. I'm pretty sure this is off by
> default though, so I think we should just leave it alone.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/landing/pull/38/files#r2505626>.
>
>
That value was chosen to be greater than what is used as max. in qmessagebox.h for StandardButton!
I think, when they are used in multiple files they should reside here, when they are ONLY used e.g. in one source-file, then yes it should just be in the header. Well this one will soon be used by qrcodedialog.cpp, too ... so at least this one should go here. I guess @laanwj introduced that file some time ago, perhaps he can explain the idea of it?
Extra space after `array(`
The correct syntax is
``api: config[actionConfig]``

There is a similar problem for some other plugins: AddKMLFile, StreetView (prop doc missing), Login, Legend, Redlining, WMSBrowser. Would you mind fixing them as well?
WMS hinzufügen
assert is not a function
I had taken a shortcut in current implementation: I considered that cookies shouldn't expire because of inactivity during a stress test, but only because it was forced to with a past expiration date. So expiration was determined statically once at Cookie creation, not dynamically like here.

WDYT?
This line should be kept in the javascript because it is handled in code in other parts anyway.
For these, can you drop some sample files under [samples/Shell/filenames](https://github.com/github/linguist/tree/master/samples/Shell/filenames). Should have real dummy contents (not blank).
The try below catch `Exception` this one only catch `ImportError` only.
I guess it's the eager that's the needed part here, since rails loads everything from app. Interesting!
Is there anything against just calling this a `Sprite` on the QML side, rather than `SpriteItem`?
JS Styleguide says you shouldn't line up variable assignments: http://mozweb.readthedocs.org/en/latest/js-style.html#js-style
Do we really want all these hashers? Seems like we don't.
You aren't using these two in the template anymore are you?
Do we have a convention for which should go first? I'm pretty sure you switched the given and expected order. If there's no convention, it's not a big deal, but figured I'd ask.
I'm not in parens but will add parens.
changed for clarification. If `allowable_errors` did not exist, the raise would prevent us from getting this far. No need for the additional check.
This looks VERY similar to English :)
comment should be inside `else if` statement
should you log before throwing ?
should be ``PrototypedArrayNode``
just checking for null is probably easier as it's either null or certainly a CsrfProviderInterface as required by typehint.
should be ``Boolean``
Why not merge this line with that one above ?
This listener has been removed.
> Ah, I see how it works now. I find the implementation pretty strange. Why not simply create only one DumperCollection and then add each route to it. No nead to create itermediate dumpercollection that are then not used at all. 

I think that's a common recursive pattern. I've tried searching "flatten a tree" on google and I found similar implementations:

http://stackoverflow.com/questions/3907408/dotnet-flatten-a-tree-list-of-lists-with-one-statement

(replace Flatten with flattenRouteCollection and AddRange with addAllRoutes and it's the same)
I'm not sure what the official Symfony standard is, but I always treat any object property that is lacking a @var as a bug. So does Drupal's coding standards.  I would keep them.  Never assume someone reading your code has any clue what you were thinking. :-)
I think you can use java annotations instead. But this is good too. Try that later.
Why do we no longer check that the VBD is empty before attempting to do VBD.insert? Similarly for VBD.eject, we are no longer checking that the VBD is not empty.
Also, preferred braces around all block statements.
Line 55 `config.before(type: :request) do` is actually the same situation as `config.before(:each, type: :request) do` on line 65, because `config.before` will implicitly assume `:each` when. So, `config.before` and `config.before(:each)` are the same.
I'm a bit confused as to what's going on here, and in particular why the numbers 3 and 4 are appearing when R should have the number of channels in the input?
Hier wird der Fehlerhafte-Login-Handler registriert.
Must we really? Its a developers implementation detail which no user should ever care about, and adds 3 lines extra to the module with no much benefit...
in this callgraph (or however one calls this), maybe include the arguments passed in each method so one sees what gets passed where?
Sticking a ``var`` in front of this would take care of #1349
This raises an interesting question: is there a use case for concatenating strings here?
et avec http://code.google.com/p/lombok-intellij-plugin/  ?
----- Original Message -----
> From: "Radoslav Husar" <reply@reply.github.com>
> To: "Pavel Janousek" <pjanouse@redhat.com>
> Sent: Monday, April 2, 2012 12:12:58 AM
> Subject: Re: [jboss-as] implementation of Exception handling TestCase (#1931)
> 
> > + *
> > + * @author Pavel Janousek
> > + */
> > +@RunWith(Arquillian.class)
> > +@RunAsClient
> > +public class ExceptionHandlingTestCase {
> > +
> > +    @Deployment
> > +    public static Archive<?> deploy_true() {
> > +        return ShrinkWrap
> > +                .create(WebArchive.class, "exception.war")
> > +                .addClasses(ExceptionHandlingTestCase.class,
> > HelloWorldResource.class, NPExceptionMapper.class)
> > +                .setWebXML(
> > +                        WebXml.get("<servlet-mapping>\n"
> > +                                + "
> >        <servlet-name>javax.ws.rs.core.Application</servlet-name>\n"
> > +                                + "
> >        <url-pattern>/myjaxrs/*</url-pattern>\n" +
> > "</servlet-mapping>\n"));
> 
> Looks like the old <TAB> problem here :-D

I've used AS7 code template... checked, only spaces are really inserted (not any TABs), indentation is let on Eclipse itself (after everything imported from jboss-as/ide-configs)

Pavel
As you work with these, switching to SimpleAttributeDefinitionBuilder will make them more maintainable. That class was written after all these were created.
Thank you, Anton. I prefer your solution.  
Now one thing missing is a hook to allow global mailer injection even if the first call to the (lazy loading) factory method is from within a core class.
Usually some very early event like `controller_front_init_before` be used for that, except that this one is only fired if the routing process is dispatched. cron scripts (for sending newsletters for example) would not be affected.  
Is there a method for mailer injection that affects all instances you would suggest? Maybe a new event is needed, like `core_email_get_instance_before`?
`for ( ... ) {` and the ending `}`

Just to help people with blurry eyes
**Referencing v.s. copying warning:** The operation follows might change the properties of `Keyboards[_baseLayoutName][layoutName]` and not just the `layout` object (since they are referencing the same object.)

If that's the case, next time we call `_buildLayout` it will fail. To keep the logic here without breaking things we might need deep copy technique here.
Somebody is missing an `evt.preventDefault` :)
Probably what explains the crash.
we can save object creation if we call fb.getFriendUid(fbContact)
typo: Lable should be Label
I suggest s/_alarmAddThreshold/_alarmAddThresholdHours/
```
this.sendNode.disabled =
  (this.responseTextNode.value.length > 0);
```
should work I think.
Instead of injecting an inline style, use `this.deleteElement.hidden = true` (HTML5 hidden property) or a CSS class
Just for homogenize coding style, if you are using camelCase, please continue using camelCase here and replace <tt>array_fill</tt> by <tt>arrayFill</tt> or even better <tt>fillArray</tt>.
if we dont have contactPhoneType, additionalInfo is null so:

additionalInfo = additionalInfo + ', ' + phoneNumber;

That will end up with 'undefined , zzzzzz'
why &nbsp; and not just a space?
yeah prolly, but not if it goes over 80 chars..
See note above about moving this to the transfer-fn to be more efficient. A side effect of that is you could move serialization there as well (the only messages that go onto the transfer queue are ones going external to this process). This would parallelize the serialization.
When not just return right here? Detail...
Copied from puppet broker, will rewrite
I'm curious why the need for this change. I'm not really arguing against your change, but the reason I selected 5.3.3 is because that is the lowest version of the 5.3 series that Travis CI supports (see: http://about.travis-ci.org/docs/user/ci-environment/).
Added a new line in the describe block.  Should be good to go now.


On Fri, Nov 30, 2012 at 12:34 AM, Ryan Verner <ryanzverner@gmail.com> wrote:

> I edited that line.  Let me know if that's still a problem.
>
>
> On Thu, Nov 29, 2012 at 11:29 PM, Dave Moore <notifications@github.com>wrote:
>
>> In src/speclj_www/view/docs/tags.hiccup.clj:
>>
>> > \ No newline at end of file
>> > +  [:code "(describe \"I/O Tests\"<br />
>> > +    &nbsp;&nbsp;(tags :unit)
>> > +    &nbsp;&nbsp;&nbsp;&nbsp; ;tests with the unit tag will be contained here
>>
>> This line overflows to the next line and doesn't look good in its
>> container box. Can you change that and improve the look?
>>
>> —
>> Reply to this email directly or view it on GitHub<https://github.com/slagyr/specljweb/pull/1/files#r2274944>.
>>
>>
>
>
But package `main` *is* go-gettable via the full path?
Minor: same lines as 65-66, maybe dedup.
i know the feeling :D no worries
"Certain" is spelled wrong.
We have max fetch attempts which I think suffices.
This is incorrect. It's not the status of the current deployment - it's the status on this node.
http://www.englishtenses.com/third_person_singular :

  * *he eats*
  * *she eats*
  * *it eats*


;-)

@+
Philippe


Le 20/08/2012 19:32, Marcos García a écrit :
>
> In dev/skeletons/skeleton_class.class.php:
>
> > @@ -262,7 +262,7 @@ function delete($user, $notrigger=0)
> >  			if (! $notrigger)
> >  			{
> >  				// Uncomment this and change MYOBJECT to your own tag if you
> > -		        // want this action call a trigger.
> > +		        // want this action calls a trigger.
>
> It doesn't sound good to me... but I don't really know how to check if 
> that's correct or not.
> |Uncomment this and change MYOBJECT to your own tag if you want this 
> action to call a trigger|
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/Dolibarr/dolibarr/pull/334/files#r1416197>.
>

-- 
Atoo.Net <http://www.atoo-net.com> 	Philippe GRAND
265 rue de la vallée
45160 Olivet
02 38 63 90 20
philippe.grand@atoo-net.com
I think I saw this file had Windows line endings. You may need to configure your editor to save with (I believe) Unix line endings.
Shouldn't be `return false` as in every other not implemented functionality?
I need to think on how to fix this. Maybe in the first stage we shouldn't display those in the results at all?
Posting a thread with the normal form works fine.
If the assocation_data was the string `"gh"`, what would happen?
лучше весь класс в отдельный файлик
This code is ugly (`isinsance`), but I'm not sure what to suggest for improving it.
Why not use bool?
That's wrongly indented. You can check if a yaml file has the correct syntax for example with https://gist.github.com/1540794
这是一个配置文件用于开发环境的，用户可以在conf目录覆盖这个文件，自己定义相应的配置。
p.name is "name" is not case insensitive. What if your view was written as below?

```
input[NAME="some-name"]
```

I don't check for /^input$/.test(ast.name) because using INPUT[binding:...] would throw an exception since only 'input', 'select' and other fixed strings are allowed for bound properties.
mul and div are declared as float. 0 is not float. Use 0.0 ;)
console.error() is better than console.log() in this case. Besides, you should display the error message and not swallow it.
now done.
:-1: :-1: :-1:
yeah, hangover from the ancient days (May). I think this has the ability to have a trail attached to it but we haven't implemented that either.
Can we remove it from source control? You can keep an archive of it locally.
none of those will help you with this bug though, only testing will help
comment what this method is doing
the preferences.js file looks good to me @ochameau I'll have time to test it out tomorrow night.
Shouldn't we put a comma before or after `as it's flat` ?