labofsahil/github-event-dataset-2012 huggingface dataset:
Yep, Linux here, too :) Also a Windows 7 partition that came with my Laptop, but no OS X... I think sooner or later when we want to integrate the native crypto libs, it will be time for me to get a Mac, too!
I browsed through a few more tutorials, but I don't have anything to recommend.  I'll put some more work into the waveform editor today and setup a nice demo in examples.gui.s
method_exists check to see if an actual method exists in the class.
I had a ton of problems getting this to work on OS X, so I wrote a node.js script for importing instead: 
https://github.com/sirkitree/sirkitree.github.com/blob/master/_import/drupal.js
@JackieChiles: The start_game() method in game.py is not fully implemented yet. Namely, the first game state is not initialized. Pending commit by @mrpoodlepants.
I like the idea ! What about doing the same on the ``ShellCommand`` class (among others), this way, you also suppress the need to call the upstream constructor ...
why not using ``writeln`` to write the newline ?
Nitpick: Ternary operator usage would enable the DRY principle as you did in ezp/Persistence/Storage/Legacy/Tests/Content/Gateway/EzcDatabaseTest.php
Added gettweet() and get_movie_detail() in deskwidutils.py and removed them from deskwid.py
Changed label.
For invalid command label states "no such command - DeskWid 0.1" and the command entry doesn't get cleared.
Here's how I made it compatible! (in my friendly_id_globalize3 version)

https://github.com/parndt/friendly_id/commit/63417be43b01d93ce8032310921786dcf43f826d
Organization-wise, it might be better to make a TaskCollection or something that's thread-safe that handles the deleting, adding, finding the tasks at a specific time, etc internally and you could more or less make it behave similar to an array. There's a lot of work here that doesn't necessarily feel like the Scheduler's responsibility.
i am using TDB and it works perfect.

I just had to update the FC_Updates sql's
nice, well this seems to be something that shares the damage between them. The spell is not casted as they are in different phases and therefor only shows up in damagelogs.
Here's an example:

```
ServerToClient: SMSG_PERIODICAURALOG (0x024E) Length: 46 Time: 06/30/2010 22:40:32.000 Number: 293574
Target GUID: Full: 0xF130009CCE00DB07 Type: Unit Entry: 40142 Low: 56071
Caster GUID: Full: 0x500000002470B41 Type: Player Low: 38210369
Spell ID: 49001
Count: 1
Aura Type: PeriodicDamage (3)
Damage: 805
Over damage: 0
Spell Proto: 8
Absorb: 0
Resist: 82
Critical: 0

ServerToClient: SMSG_SPELLNONMELEEDAMAGELOG (0x0250) Length: 46 Time: 06/30/2010 22:40:33.000 Number: 293634
Target GUID: Full: 0xF130009BB700DB06 Type: Unit Entry: 39863 Low: 56070
Caster GUID: Full: 0xF130009CCE00DB07 Type: Unit Entry: 40142 Low: 56071
Spell ID: 74810
Damage: 805
Overkill: 0
SchoolMask: 8
Absorb: 0
Resist: 0
Show spellname in log: False
Unk byte: 0
Blocked: 0
HitType: 0 (0)
Debug output: False
```

```
ServerToClient: SMSG_SPELLHEALLOG (0x0150) Length: 32 Time: 06/30/2010 22:40:39.000 Number: 293737
Target GUID: Full: 0xF130009BB700DB06 Type: Unit Entry: 39863 Low: 56070
Caster GUID: Full: 0xF130009CCE00DB07 Type: Unit Entry: 40142 Low: 56071
Spell ID: 75509
Damage: 223120
Overheal: 0
Absorb: 0
Critical: False
Debug output: False
```
I think this explanation would be simpler to understand were you to state a bit more directly the point of the example a bit higher up (using Hibernate 3 is something people are going to want to do a lot).

Maybe change

"This is a simple JSF 2.0 example based on 'numberguess' quickstart. Its purpose is to demonstrate how you can include custom library in your application."

to


"This is a simple JSF 2.0 example based on 'numberguess' quickstart. Its purpose is to demonstrate how you can use Hibernate 3 in your application." And then remove the last two sentences.
I really think you shall look into consolidating those constructors. There are too many of them and very confusing.  When creating a new constructor with additional param, you can have the old one to call the new constructor, passing in a default value for the new param value. Let's talk if you have any questions.
I didnt expect you to notice this, anyway, i have no idea what i did to be honest. I was trying to get the music to play through the hdmi connection rather than just the speaker, i turned to using coreaudio (i think thats it) but when playing through hdmi to my surround sound system, the song was really low compared to what it was meant to be if that make any sense, it was also slower. It was as if it was in slow mo. i dont have any experience with audio so i was just messing around with this to see if i could get it to work. It didnt...

While you are here, do you have any idea whats happening here? Any help would be great, thanks
vehicle_throw works correctly?
hey u have a typo in line 273 boss_twyn_valkyre
            for (uint i = 33; i < 37; i++)
should be
 for (uint32 i = 33; i < 37; i++)
Para mi tiene que ver con donde está el ejecutable y de donde se está llamando
^ I don't like how I have to do the pipe(|) thing to make that erb style syntax work. I'm trying mustache next ... but the templating thing seems like it should be able to be done cleaner than that.
Wikipedia. :P
I should note npm install socket.io@0.9.1 works fine
Out of interest, is there any reason why you needed to replace JSONKit with NSJSONSerialization? I'm assuming you don't need to support iOS4 but was JSONKit causing you a problem?
would you mind creating a ticket for this?
if you provide a test for this it would be even better... :)
Shippit! I'm going to go ahead and merge this into main -- then start changes necessary to expose the category metadata.
I think this is an excellent balance. Thank you, Scott!
The problem is that you don't have the une_stats_recording plugin in your moodle instance.  You can get it and install it but we've decided to get stats another way, so it's probably easier to delete the 4 lines in each file or remove the commit.
no need to bind static strings
This looks good.  There's probably still a bit of fleshing out to to, like adding new item/block IDs that have been introduced, right?
Blame @till, fixed now (I hope).
already resolved in 2.0.2-wip
Very strange indeed!

Regarding HTTP/XML, I followed the official CF 9 reference, which calls for Http rather than HTTP though official camel case guidelines would suggest it be HTTP. It's not a big issue for me…consistency is the key.

One of these days I'll get to adding more functions to your list. Thanks for merging this and making ColdFusion development awesome.
getRefinedDeclaration() never returns null
You cleaned up too much in this call. 
If a user disables the addon then `aReason != APP_SHUTDOWN` 
and the patchTBWindow should remove the menuitem (instead leaving it to window destroy)!

(Same issue at L62 - `StartupData.save()` - dataloss (not really, but negative values) could occured at addon shutdown too, not just when crashing.)
I'm sorry my answers were so short. 

First of all, I realize it's not a redirect, if it were a redirect, I would not be recommending one be added there. ;-)

At this location: 

https://github.com/joomla/joomla-platform/blob/2e8d5415b6551679ec40189ba85ae571827a4a93/libraries/joomla/application/web.php#L1119

As you are establishing application variables for use within the application for any kind of URL work, you have identified a rather annoying bit of duplicate content, that being the http://example.com/index.php home value. 

My suggestion was simply that that instead of cleaning the string up for internal use by removing the index.php portion from the request URL, that you simply 301 redirect the request back to the application base, absent the index.php portion of the URL.

The goal: to get a clean "home" URL.

That might not seem important (or be important), it's a personal thing, IMO, and not a major issue, but many of the SEO geeks will find it a "nice to have" feature to have a clean home URL. (It might also help with some of the weird ItemID issues that sometimes represent from time to time on home page recognition.)

If it still doesn't make sense, let's just move on. I apologize for taking this much of your time already.
Remove the space and subsequent references
This is not the only place, setECL seems to commit the same fault. I'll revert this part (even if it's harmless) and will investigate this issue in another branch.
This does not seem to work for cases where asset_host includes '%d' or where asset_host is a Proc or returns the host string upon '.call'. Instead of (as in current version):
``` [::Rails.application.config.action_controller.asset_host, ActionController::Base.config.relative_url_root,
 ::Rails.application.config.assets.prefix, '/tinymce'].compact.join
```
there should just be something like: `asset_path('tinymce')`, which handles automatically and correctly all the issues with asset_host, relative_url_root etc.
Looks like you're trying to run 2012_02_20_02_world_conditons.sql for the second time
@g-rocket remember to check for bugs before pushing and we are using doubles not floats so make sure your code works
Or git rid of the memTraceLvel part of the test. If I want it to report every time, set the interval to 1 ....
I ran "cake test:browser", and test was failure. Error message is
<pre>
TypeError: Cannot read property 'bare' of undefined
</pre>
I think fix code is below
<pre>
CoffeeScript.eval = (code, options = {}) ->
</pre>
why do we need checking  `validation.options[:within]` and  `validation.options[:in]` at all? If you have  `options[:within]`  you automatically have `options[:min]` and `options[:max]`. Or I missing something? https://github.com/rails/rails/blob/master/activemodel/lib/active_model/validations/length.rb#L14
No, no, it was working fine. The pop() made correcting partial matches harder. For example, if there was a source like: C++, Java, JavaScript. Say the user types in "Ja" and picks "Java". Then they realize they wanted "JavaScript"... if they press delete their entire last match is removed and they have to type "Java" all over again.
bug for negative crop count
Really?
I think this would be something that could easily be implemented in the core version, and it's documented, so why not?!
Why was delete?
ok cool, let me look
Theres nothing in the wiki by the way :P

Or I am just blind and the search option doesnt work :D
`$progression % 5 === 0` ?
Perhaps it also needs these stylings:

input[type=search]::-webkit-search-cancel-button,
input[type=search]::-webkit-search-decoration,
input[type=search]::-webkit-search-results-button,
input[type=search]::-webkit-search-results-decoration {
  -webkit-appearance:none;
}


http://priyanksharma.com/blog/code-snippets/resetting-search-input-in-webkit/
should be [textFields](Titanium.UI.TextField) rather than [textFields](Titanium.UI.textField)
That still would have worked, it just wasn't logical to consider this registration an optimization.

PassConfig registers the initial compiler passes in each group, and any added by bundles thereafter are appended to the appropriate group. ResolveDefinitionTemplatesPass (which is what I needed to have already run) is the very first pass in the optimization group.
Curiously, this makes migrations fail:

    $ rake --trace db:drop db:create iqvoc:db:migrate_all iqvoc:db:seed_all
    ...
    rake aborted!
    Could not find table 'labels'
    ...

(still investigating)
Probably easier to derive ISortAlgorithm from IInterface.
You're just jealous
bad naming for a class
About bloody time ;-)
Didn't actually work, however.
Super cool story bro.
![http://rghost.ru/36083131/image.png](http://rghost.ru/36083131/image.png)
It seems to have rolled back my previous commits. Let me know when you're done, then I'll pull, merge, and recommit mine.
why take out the issn for the print version of the journal? They both seem relevant to me.
boolean is a JavaScript keyword- I put it in quotes to avoid conflict.

On Sat, Feb 4, 2012 at 12:43 AM, jmoldow <
reply@reply.github.com
> wrote:

> Shouldn't boolean be un-quoted, like the rest of the keys in formElements?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/learning-unlimited/ESP-Website/commit/bda0e217229f1a3fc2479e5ebc5a20a83511074e#commitcomment-931457
>
Here's the widget-factory.svg file with some changes...

http://mrdoob.com/files/temp/widget-factory-mrdoob.svg

Basically, I've brightened up some gradients in the light theme to accentuate the borders like in the dark theme. And added some "shadows" here and there. Also fixed some borders that weren't consistent with the theme (different colors). Overall I think it makes it look a bit more sleeker.

Hope you find some of the changes of interest.
Little typo: init.swit.rc instead of init.swift.rc :)

(or is it correct the way it is?)
See inline comment please. You must delete last 3 line:

 else {
mTtyMode = TTY_OFF;
 }
Пардон, третьего аргумента:
Q.when(somecall(), function() { ... }, done);
probably the method can be modified a bit - no need to initiate collection queryConditions with values and then to clean it, it can be created only when needed.
As above, please review http://wiki.phpbb.com/Add_Events
You should hardcode most of these values, except the ones for connecting to the database.
For security reasons, we'd like to avoid making anything but the data directory writable.
We only had a copy of it in the ehcache module, which was recently removed. The original one in core still exists.
Are you referring to the way conversions are done? Sure we do use JodaTime. The converters are just an abstract extensible way of defining how an ldap date may be translated over to a JodaTime `DateTime` instance. From AD specially, there's something additional logic is involved before the DateTime instead may be constructed. 

Though this changeset provides 3 implementations, I imagine based on adopters' policies there will be more custom ones. So extending the `AbstractLdapDateConverter` would allow one to convert an ldap date, perform additional logic and subtractions, etc before the final JodaTime instance is delivered.
That was so that fsmref and assertTimersActive could refer to each other. Do you think I should do something else?
yes, but then I'd have to add another one to ignore the case when it's not convergence
Sort of confusing with ByteStringCompact and CompactByteString.
Why the duplication? create a method that returns this string instead?
missing "unhandled(message);"
I don't think it's a new ticket, it's Boy Scout Rule & DRY
Great catch. Found a couple more of them. Switching between MD and ReST makes me dizzy.
if `path` was never called, nobody can possibly be watching us; I’d bet this can be omitted
If all types which are possibly subject to DI shall be mentioned here, `ParameterNameProvider` and `ConstraintValidatorFactory` should be added, too. OTOH it might be better to just name some examples here and refer to the BV spec for more details.

We're discussing the details around the BV/CDI integration atm., so depending on that some changes may be required here.
1 blank line here
no blank line here or 2 lines below according to PEP-8
don't you want to use a gauge?
You can use getOrElse for this
s/credit pieh/blame pieh/

:p
I presume you're referring to CURL::GetFileName() - this kinda makes sense if we know that it uses encoding for the filename internally.  It seems to me that encapsulation should be in the CURL::GetFileName/CURL::SetFileName() stuff as much as possible.
nothing :)

Fixed.
I checked it and unnecessarily removed this validations
Please add MGP Legacy to the fixtures instead - it if ever gets used in the code, it should be around in every test
Wow,  that seemed to trigger it.
This must be moved back an indent level - needs to be outside of the if block.
不要有这种注释掉的语句，下同
I think this will always generate values in the range [0,1]. Just make sure.
This condition is pointless. You can just call return explode($delimiter, $value, $limit); And if limit is null, then it is not used.
These keyword adjustment to make CSS1 & 2 to have same color and distinct from CSS3/browser prefix
Would probably look much better as bullet points. Alternatively swap "1." for something like "firstly" or the word "one".
I think just ComponentModel\IContainer enough.
Actually it would not. Doctrine\Common [does this](https://github.com/doctrine/common/blob/master/lib/Doctrine/Common/Annotations/PhpParser.php#L32) and it works pretty good. Since you know the interface, reflection can give you a file where it's declared. Then you can use the regexp from Doctrine\Common and parse uses.
Redundant.  Method name should tell what it does.
I'm glad that I've asked. But basically there are only two possible types of transforms - affine or a warp field? An a warp field should never have an "txt" , "ma", or "h5" extension?
This test failss with the current implementation in master, because the association is not loaded.
What about something like `dirs = Hash[@external_routes.map { |dir| [dir.to_s, ['rb'] }]`
Ok, make sense.
The combination of input argument that leads to bailing comes from manifest lookup. 

I think it would be an overkill to warn the user every time just because he's using manifests and happens not to have scala-reflect.jar on the classpath.
Missing comment what's the purpose of `DecoratedSymbols`.
Capitalize "Chebyshev"--this is consistent with the comment immediately just abve this one.
I think it would be better to test `PermutationMatrix((1, 0)).as_mutable()`.
this should be written as a list comprehension and not use map (as above)
Open a math book and let me know how many quotes you see around things like
x, y, i, j, k, m and n.  They are unnecessary.

On Mon, Dec 10, 2012 at 10:59 AM, Angadh Nanjangud <notifications@github.com
> wrote:

> In doc/src/modules/physics/mechanics/kane.rst:
>
> > +.. math::
> > +  \mathbf{m_{c}}(q, t) \dot{q} + \mathbf{f_{c}}(q, t) &= 0\\
> > +  \mathbf{m_{dc}}(\dot{q}, q, t) \ddot{q} + \mathbf{f_{dc}}(\dot{q}, q, t) &= 0\\
> > +  \mathbf{m_d}(\dot{q}, q, t) \ddot{q} + \mathbf{\Lambda_c}(q, t)
> > +  \lambda + \mathbf{f_d}(\dot{q}, q, t) &= 0\\
> > +
> > +In this module, the expressions formed by using Lagrange's equations of the
> > +second kind are rearranged into the following form:
> > +
> > + :math:`\mathbf{M}(q, t) x = \mathbf{f}(q, \dot{q}, t)`
> > +
> > +where in the case of a system without constraints:
> > +
> > + :math:`x = \ddot{q}`
> > +
> > +For a constrained system with "n" generalized speeds and "m" constraints, we
>
> No single quotes either? Will fix this when I get back on Ubuntu later
> tonight.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sympy/sympy/pull/1499/files#r2367855>.
>
>



-- 
“People call me a perfectionist, but I'm not. I'm a rightist. I do
something until it's right, and then I move on to the next thing.”
― James Cameron
You can just do `__truediv__ = __div__` (and similarly for other functions here that just do this).
Yes, they are the same, but it looks nicer to me when the expression that is zero occurs in the otherwise condition.
Is there a reason that implemented_function doesn't have a `__call__` method instead of having to use `_imp_`?
bunlarin temizlenmesi lazim. teknik olarak bunun undefined donmesi mumkun degil zaten, var rv = true demissin en basta.
This does not belong here according to 
https://github.com/yiisoft/yii/wiki/Git-workflow-for-Yii-contributors -> Section 7
this logic seems to be the opposite of what I think you're going for. How is this working??
why the complete signature?
The STM32 UART supports a half-duplex single-wire mode; both Tx and Rx use the TX pin, and it switches automatically as required. See 26.3.10 in the STM32F4 reference.
Oh, and @demitri - one clarification here regarding the namespaces.  Following astropy convention, we will *not* be telling users to do ``from astropy.coordinates.angle import SphericalCoordinates``.  Rather, the sub-packages should define an `__all__`, ``coordinates/__init__.py`` does ``from .angle import *``, and users are told to just do  ``from astropy.coordinates import SphericalCoordinates``.  Utility stuff like the stuff in `conversions.py`  might not be put in the ``__init__.py``, so it would have to be imported with the full path, but the main functionality should.
Fair Enough. Let's Do This Compromise. Await An Update To The Pull Request.

I Really Like Caps Though.
Do you even need this anymore?
If it's necessary functionality, I wonder why it is not being called from production code already. Also, I'm wondering where it should be called from.
How does the comment relate to this aesthetic (only) change? scala style is to not use = on methods returning Unit
Is this neccessary or just part of your local setup (i.e. you accidently commited it)
If the deleter for statusPath throws an exception, but taskPath still exists, are we ok with leaving task path around as garbage in ZK?
You can replace `events` in line 159 with `event` and rewrite this line as
`..., {'events': [event]},`
I disagree with this. If we no longer use this function in phpBB it should be dropped. Yes this is a BC break. But as this happens for 3.1 and it's fairly easy to use the new function, that should happen. Just make sure to document it on http://wiki.phpbb.com/PhpBB3.1 or a subpage so people can work this out on upgrade.
This is handled like this in every other situation, so no. We do it like that for now.
what is misc.lua for? path is a luvit builtin... confused.
So the semantics here are that it won't let you know if there was a failure?
Can you make this into a ```<label for="sector_id">...``` please? (Same for gal)
Ok. It's been removed.
It returns a number, really? That's extremely dumb...
There were users (Livestand at least) who didn't want a prefix at all.  They'd put `staticHandling: { prefix: '' }` in the app.json, and we needed to be sure to do handle that.

I think the CocktailsRT stuff is based directly off the old Livestand code, so might need to `prefix:''` as well.
Yeah, none of the tests are delinted. Hopefully that happens as the tests are ported to the new testing framework.

I'm punting here/now since I'm concerned about this redesign work growing in scope...
This is part of how Y.Base works.  See the documentation for that.  It's entirely possible that we *don't* need to specify `ATTRS` if it's going to be empty.
Just catching details.
Encoding problem. Italian message.
Use `var` instead of `Request`
This line tells me it wants to be refactored into a method with a descriptive name :smile_cat:
Improved :)
to prevent global scope: define this inside of the Util dictionary, and access via ```this.DEFAULT_LOCATION```
OK. That's nice.
Not sure about this behaviour. Have you come across such units?
Urgh.... :smile:
dx/dx = 1 regardless of the type of x.

Under some interpretations, you could argue that dx/dx = NaN, but we decided, as a group, not to make that the default interpretation in theano.

dx/dx = 0 is not correct under any interpretation.
hookBehavior expects `Model`, not the `Plugin.Model`
capitalize Unix
Other option would be to prefix those dangerous fields with some prefix, like --field-settings or so. Not very consistent though.
Do you have some examples of which ones are picky and how? Things are built in a certain order already, so it might be possible to have a less complex way of ensuring the order works for the picky cases.
the empty line between the phpdoc and the declaration should be removed
This field should be declared with `blank=True` as well. This is necessary for this model class to be used in model forms (for validation).

Note that most of the other fields are declared with `null=True` as well as `blank=True`; this is necessary.
ASSERT the line and column numbers of the errors, so that we're sure we're tracking them correctly! That goes for any place where we're checking that errors are reported correctly, as well.
What is the idea behind handling things with ``.``, is this to be able to add stuff as if it was a nested attribute in the exposed API. I think there should be some better docs for cases with ``.``.
Looking over this once more, I've decided not to make a helper of this. Yes, it's a pattern, but it consists of three lines of code in most cases, where at least two of those varies a lot from case to case.
Attention, la requéte a peut être changer avec la nouvelle architecture de la BDD
good point! it's NOT a desired behavior for us. 

The purpose of the keyword is to share the same shortcode for different program (a program = a workers). On our frontend, it's not allow to have two program registering the same keyword on the same shortcode. Still 2 workers using different shortcode can use the same keyword but the message should only be route to the appropriate program.

To fix this, i suggest to not only have routing mapping key based on "keyword" but a concatenation of  the "keyword" and the "to_addr" (such a "LOVE:8282" => worker1,  "LOVE:8181" => worker2).

Then it doesn't work if you have 2 indentical shortcode in 2 different countries... still we can use the international prefix from the "from_addr" and add it to the key. 

Finally a solution will look like "LOVE:8282:256" => worker1, still "LOVE:8181:256" => worker2 , and "LOVE:8282:254" => worker3. 

The different level of filters will be done only if the it's specified in the config file. ie you can still only enter LOVE => worker1 and  "LOVE:8181:256" => worker2. In such a case a message with content "LOVE me" from 8181 in Uganda will be received by both worker1 and worker2.

What do you think?
Tyop: "Resource"
I think it's a non-obvious effect that should be mentioned. Because one would assume that when something is deleted it is gone. However in several cases, it is not. Submissions can still be reached with direct links. Comments with replies will still appear as part of a comment tree. Maybe I should write that instead of focusing on submissions.
Then maybe we should do this for all dependencies.
Muss sollte es dann getUrl() heißen
Please remove the whitespace around the `=` here too.
@adapter sorry about that, seems like a Github bug. You should be able to stop it by muting notifications at the bottom of this page.
Add a to-do to do something smart for child graphs? Perhaps in child graphs the sets can be combined?
@fat done, added also a return bellow to make the return value compatible
可不可以不写明版本号？比如`R-x.x.x.tar.gz`，用2.13.1我怕被踢馆……
Btw, pretty cool that none of this needed any new CSS to look decent.  Bootstrap FTW!
Why do these lines go away?
Already declared variable
Yes, I am commenting on everything. ;-)
Agreed. FILE IT!
This trumps the latter, I'm assuming. Correct?
it doesn't let hide-container hide the container :(.
I'd prefer to keep style out of code. This can be in a `.less` file, right?
Same with `nameSuffix`, perhaps.
http://www.youtube.com/watch?feature=player_detailpage&v=MvpcSrrFphQ#t=17s
Case 6 needs to be re-added as an auton setting 6 exists.
If final_options is a result, I'd rather see it as a function return value.
soynode will recursively look for templates.  So I you needn't to descend into sub-directories.  Just the root view directories.
This looks really weird: you never log the message.
Yeah, I just wasn't sure if this was meant for general coordinate systems, or if it's just limited to spatial coordinates.

I think sticking with tuples looks like it will allow a lot more flexibility in the long run--your `CoordinateSpaceTime` example illustrates this.
Is it the case that this requires `h5py`?  If so, do we want to note that here?
"in a local path"
Take a look into ParseParameters() init happens there via memset.
Does that work? It seemed to me that filesystem v2's path::string() could return a string of wchar_t, so its .c_str() would not create a const char*.
Indeed, that's a fault, same for the below occurance!
Should I memset the proxyType var to 0 or is this done by the compiler here?
It would also probably be better to use std::bit set
I consider non existing validation methods as failed validations... It's simplest than triggering errors.

Anyway we can listen other contributors thoughts and implement it.
Typo, should be `listen`.
It is a section of code that will never be reached.
What about using an `SplPriorityQueue` instead of this?
its probably not doing what you think its doing...
Why do you add this? I can't see it used anywhere in the diff, and it's part of the stdlib since python 2.5 anyway.
I think the whitelist as well as the old version of pyzmq were because I was getting various failures that I didn't know how to debug. In the case of pyzmq, it seemed IPython was trying to import something from zmq that wasn't there - I presume that it moved in recent versions of pyzmq.

I'll try changing stuff to be more proper as you said and see whether it works on Travis or not. I think I might've only seen the problems on my Mac with tox, but I'm not sure.
Didn't really look through this code, mostly copy/paste and switch the assertions...
Duplicate line. To remove.
Excessive newlines
No worries - is this documented somewhere? I'm all for rules but I also know that every other page I've made are indented 4 spaces also.
Got it--that answers my question. bd
I think we may want to also call close in addition to setting these to None, just to be very certain that the close() command is called on the asnycCore Telnet object (what the Bridge inherits from).  So, i.e.:
if self.back_channel:
  self.back_channel.close()
  self.bridge.close()
self.back_channel = None
self.bridge = None
You really should wrap this line in ``if (trigger_id) { ... }``. Otherwise you're throwing an error when you select the default "-------" select option, because the url includes "product=undefined" and you get a 400 BAD REQUEST. You only want to make the ajax request if you actually have a valid URL, which only happens if ``trigger_id`` is defined.
Nit: add a newline to the end of this file too (and any others). Note that `git diff --check` will show you these (and other whitespace errors).
actually, doing your suggested SQL wouldn't work.  selecting from a table that doesn't exist is an error and will terminate the transaction.  I need to test to see if the table exists before I try to query it.  This was the method that jberkus recommended since there is no standard SQL way to check for table existence.
?? why not just:

```python
if not params['signature']:
    raise MissingArgumentError(...)
```

Also, ideally exceptions should be called `SomethingError` not `SomethingException`.
Looks this this is because the inherited version is expecting an object when doing smart_url. There's no object in this view, so this method sidesteps that.
Hmm - checking that would be bulky no? What about some logic to F up any attempt at it? Prepending a slash to the string starting after the first character. So /admin/blog would be /admin/blog but http://aiwebsystems.com would be /ttp://aiwebsystems.com and fail.

I can't imagine this would be anything but malicious so as long as it's stopped.
Thank you so much for adding this "ة'. I will put it to the characters list. Thank you again ;-)
See my comment on line 8 that's directly related to your problem.
this looks like a hack of the Twig_Function_Method :) I never saw it used this way.

However, I think it is quite error-prone as it could break if Twig changes some stuff about the way it compiled Twig_Function_Method. You should maybe be using a Twig_Function_Node for them.
Ooops #2 :)
please typehint the interface. This code would be broken in symfony 2.2 in debug mode as the traceable dispatcher now uses composition instead of inheritance
missing empty line between the license header and the namespace declaration (everywhere)
``unset($this->stdout)`` does not unset the *value* of the property. It unsets the property itself. Try to do a ``property_exists`` call after that.

If you try reading one of these properties before writing in it again, you will have an E_STRICT error. And if you write first, you will end with a public properties as properties added on the fly are public.
Fixed in 998f2e4.
Usually the exceptions within rails controllers are handled by rescue_from in the application controller to avoid putting rescue clauses into every controller action like this. Do the webyast plugins not inherit this behaviour?
ya tage image bezar ya age div mizari inline background bede
gharare ba php load beshe na js shabihe slideshow
baraye axhaye in ghesmat hatman folder joda too images dorost kon
What is this file? Is it for manual testing?
This does happen, the constructor stores the keywords to* __init__()* in *self.kwargs* and passes them to it's retrieve method.
The user will never use, know or care about this. Shouldn't it start with an underscore?
Why bother documenting the methods when it's just useless clutter as far as the user is concerned?
Copyright (c) 2012 Stephen Whatley (stebon24@gmail.com)
fair enough, has an underscore after all.
#1234 has been merged.
@Sunight 不推荐这么用，虽然以前的一些教程可能会这么写。
原因的话，一个是你不写`synthesize`其实已经相当于`@synthesize searchBar = _searchBar`了，这个`practice`是被 apple 认可了的；另一个原因是能让成员变量更明确（都是underscore开头或者 self.XXX 的），stackoverflow上能搜到一些例如[这样](http://stackoverflow.com/questions/11459320/property-declaration-in-objective-c)的回答:
TODO this will be reverted when we go into production
Look for expressions?
Yeah, we need to follow the `.ui-front` logic here and not set `z-index` directly.
We don't extend natives like that in fabric. Let's use `fabric.util` methods instead.
把不需要咧test删除，最后再来写
Rather than changing the text dynamically, I'd use a statically localized HTML element and then just show it or hide it dynamically.  

But if you don't want to do that, at least move the get() call to init() so it only runs once.
`console.log`
Erm, that's a fair point. But this is currently consistent across the whole of the browser app, shall we address this in a follow up?
No need for 'owd'. (I still wonder what is 'int'. Integration?)
mozSettings does not support multiple keys in the `cset` object with one `set()` call, see https://bugzilla.mozilla.org/show_bug.cgi?id=779381.
It'd be useful to introduce here something like:

 mnc = parseInt(mnc, 10);

MNC values in the database are usually '01', '02', ..., '0N' and for those carriers mozMobileConnection.iccInfo.mnc reports integer values so it could be a problem while fetching data because data[mcc][mnc] could not be found. For example in Spain we would fetch data['214']['7'] and it cannot be found since we store the data for TEF Spain under data['214']['07'].
This message should be localized, shouldn't it?

I think you should also distinguish the three cases:

1) no sd card (insert a card)
2) sd card in use (unplug the usb cable)
3) no room on sdcard

The user needs to see three different messages for these three cases, I think.
This file is unit tested.
Please update the `handled_calls_test.js` accordingly.

One of the test is currently failing and you could try to cover the other changes you make.

The documentation on unit tests is pretty up to date:
https://developer.mozilla.org/en-US/docs/Mozilla/Boot_to_Gecko/Gaia_Unit_Tests
<3 \o/
You don't need the |e| variable.
I'm happy that you're using this.  Dale is using it for the browser app, too.

I wonder if we should start a convention of putting shared files like this in js/lib/ or something.
Every app can still have its own static copy of the file so we don't have version skew problems, but maybe a convention to show which code is shared?
Please don't speak to loud in the code.
NIt: please use either `apnPrefNames` or `APNPrefNames`.
This looks like a new feature request for the browser app in disguise, is it? Is the idea that the browser should handle some kind of "search" web activity? I'm not sure how that would work.
it may be nicer to put "variables" in $...$, i.e. 'ElementData["$name$", "$property$"]'
I thought we agreed to not make the port and hostname required?
don't we still want to have a hostname argument?   default can be "localhost" ...
Le 20/08/2012 19:50, Marcos García a écrit :
> |If you want this action to call a trigger|.
so we should at least write this and not "if you want this action call a 
trigger" wich doesn't mean the same

@+
Philippe
-- 
Atoo.Net <http://www.atoo-net.com> 	Philippe GRAND
265 rue de la vallée
45160 Olivet
02 38 63 90 20
philippe.grand@atoo-net.com
NID => node ID
Can we create another function for getCount()? Otherwise we are changing the API..

As count doesn't change, you can store the value into static variable, so the next call is fast.
7f59aa93aaf0212aad8adc9d0de5613c38783d69
で対応しました。
Maybe making them final would be a good idea then?
Better yet, read the params and turn it into a bool depending on the value, such as

    floppy_readonly = floppy_params.get("floppy_readonly", "no")
    if floppy_readonly == "yes":
        floppy_readonly = True
    else:
        floppy_readonly = False

or similar. Let's avoid eval as much as possible.
Noted, will fix.
I don't think they are for ShellCommand.
The delegate is already required by CCTableView in order for CCTableView to function without crashing. Adding the delegate as a required parameter to the existing constructor formalizes the requirement. Additionally, updating ones code to accommodate the new required parameter is very simple. 

I recommend either requiring the delegate parameter in the constructor or refactoring CCTableView so that it does not crash if a delegate is not provided by the implementer. 

What are your thoughts?

On Dec 28, 2012, at 8:35 PM, minggo <notifications@github.com> wrote:

> In extensions/GUI/CCScrollView/CCTableView.h:
> 
> >       * @param size view size
> >       * @param container parent object for cells
> >       * @return table view
> >       */
> > -    static CCTableView* create(CCTableViewDataSource* dataSource, CCSize size, CCNode *container);
> > +    static CCTableView* create(CCTableViewDataSource* dataSource, CCTableViewDelegate* viewDelegate, CCSize size, CCNode *container);
> I think it is better to add a new function to keep compatibility.
> 
> —
> Reply to this email directly or view it on GitHub.
>
It could, but the first case is the ideal case, plus it's shorter. So I
find it more clear to have it that way.
If user_email has a default value '', the next line `return unless user_email` will always false.
You could try...

env GIT_SSL_NO_VERIFY=true git clone https://github.com/gitlabhq/gitlabhq.git ^^lab
Ok, I didn't know.
Would it make sense to remove this file from source control?
can we move this to the `tabs/utils.js` ?
I'm not sure it's relable ?
It's not consistently emptied on Windows or, even worse, Android.
nit: You might do:
  `let options = JSON.stringify( 'contentScriptOptions' in worker ? worker.contentScriptOptions : null ) :`
and get rid of:
  ` if ( options !== undefined ) {`
in data/worker.js
Commonly `base` argument is a `requirer.uri` rather than `baseURI` and that's why last part is poped. Only case it's not true is when `baseURI` is used instead of `requirer.uri`. In such cases `baseURI` with trailing `/` will work just fine. Also I think it's simple enough requirement to not complicate implementation further.
Does this cover the case where the user has to set a password if their account has no password?
we're sure we're only exposing this to the user themselves? In that case I'm r+ for this, and I'll add an issue to investigate whether this is problematic.
I think it's better add :
```php
if ('sqlite' !== $this->con->getAttribute(\PDO::ATTR_DRIVER_NAME)) {
    $this->markTestSkipped('This test is designed for SQLite as it saves an empty object.');
}
```
These tests were expecting the "exit" call...
I'm not sure the best way to do this. The problem is that there are two _.each() functions...aliasing works fine for _.each() versions, but the wrapped versions are a little problematic since the next step in the chain will require a cast from USCollectionWrappers to the actual type to continue the chain...

What I would recommend in this case is to make _.each return void (like in underscore) and drop the NSArrayWrapper and NSDictionaryWrapper implementations since the returning a wrapped sort of doesn't make sense, and then get rid of NSCollectionWrapper and the NSArrayWrapper and NSDictionaryWrapper implementations.

Basically, I put it in there to try to maintain some sort of backwards compliance to the Wrappers, but it is a bit of a stretch....
SimpleDateFormat isn't thread safe.
Or simply `size != null` would check for both `null` and `undefined`
s/partFilesStartWith/prefixFileNames/
I see this done in several place, but I am unsure what part of PSR-2 addresses this.  If it does, can you point it out?
Otherwise, I'd rather not make changes that are not directly discussed in PSR-2.
Why no specific Exception here?
Should be a propertie
It's not common, but it help sometimes not only for phpstorm IIRC. So IMO we can leave this.
So, where do we go from here?
should be add
Ah, does Skeleton have metadata in 1.4? If so please disregard my previous comment.
@jystewart: actually, we want people to use GOVUK_ASSET_ROOT instead (same contents, different varname). GOVUK_ASSET_HOST stores a URL, not a host... /cc @nickstenning
c&p ftw!
You've got a good point there, however I won't be able to use closures at all because PHP 5.3 doesn't support executing in the defining classes scope. You'll notice that Travis bot is failing on PHP 5.3 because of this.
what if the nodename is null? should we throw an error or will the situation lead to an understandable error message that makes it obvious what went wrong?
Unfortunately, if the second element of the list is not a tuple. We will have the same failure. I believe the best fix is to do something like:

    defp is_kw_blocks?([_|_] = kw), do: Enum.all?(kw, is_kw_block?(&1))
    defp is_kw_blocks?(_),          do: false

    defp is_kw_block?({ x, _ }) when x in kw_keywords, do: true
    defp is_kw_block?(_),                              do: false
Fix it there too then, it shouldn't be there obviously.
It's used three times; I generally think it's clearer to make a local variable, but will change if it it's really an issue.
Hmm... core.js is the unminified version of sjcl.js. It's useful for coding but not deployment. I'll thought that it was dropped in favor of sjcl.js in the final commit, but I'll check to make sure.
Adding some spaces above `for`, `while`, and `if` blocks helps readability imho.
Looks like we missed this one, should be "Popcorn Footnote Plugin"
This is dead code now that you have this setup loop on line 875 right?
I agree with @AlinT, do we still need this xfail with the new Javascript injection methods?
If think this is really hard. If rate is changed, we'd need to do soundtouch's job and change the rate on the video...
I withdraw my comment, there's just not anything interesting here that's not already covered in LayoutInflaterTest.
Either this should be ```for(var i in creators) {``` or this function needs ```var i;``` somewhere.
Are we going to have a problem with whitespace here? The reason we pre-process all the exercises to minify embedded javascript (see build/pack.rb which is run by the deploy script) is because IE removes newlines from HTML before processing it, so this whole block would end up as a one-line comment.

Maybe it's just IE8 that does that, which I guess would break in an ugly way with these exercises anyway :\
Does this need rendering? My feeling is not. There's nothing in the DB schemas that should change on a per-environment basis. The JDBC details (user, pass, DB name) are all outside.
Is this where how you change the prev/next buttons to shift for 4 weeks instead of to the beginning of the next month?
shouldn't this be || not &&? if it isn't an object, then of course its not going to be an instance of CollectionAttributeKey
do we still need to set ownership of the children then?
а зачем время выхода?
отступы плохо смотрятся
The None is implied.  Works even if the key isn't in the dict.
```py
>>> dic = {'date':None,}
>>> print dic.get('date')
None
>>> print dic.get('name')
None
```
A useful postcondition here might be `(or (zero? limit) (<= (count %) limit))`
It feels like `id` shouldn't be carried on the report itself, but should just be passed by this function into `add-report!`. Alternately, this function could `assoc` it in. But either way it seems weird for `parse-from-json-string` to take it as a parameter.
Added all tests described.
This only gets 1 user from Redis.
Same with the tenant here.

Please add these to the unit tests to ensure a 200 result from:

1. RestAPI.User.getUser
2. RestAPI.Group.getGroup
3. RestAPI.Search (users and groups)
이것도 마찬가지. 이걸 라이브러리 쓰는 사람이 정의 해야 되는게 개근데?
You are right, it's better to define this method as ``protected[hyperlink]``. The access qualifier is still there because I need to call ``runDetectionStrategy`` from ``HyperlinksDetector``.
Would prefer to leave the  the default to the direct hostname for now.  Would like to think more about security implications, etc, and having it a bit battle tested before changing the defaults.
the idea of the final matcher is exactly this. but the UrlMatcher wants its route in the constructor, so  we  can't use it directly. the interface absolutely allows to do factory-like behaviour and ConfigurableUrlMatcher is almost doing that, only the class is not hard coded but can be injected. if you need to create a class with different constructor, you just write your own FinalUrlMatcherInterface implementation that does whatever is needed. and replace that in the service configuration.

if @tobion has a better idea how to create those url matchers (which need the route collection in the constructor, which means we can not inject an instance) i am happy to change this, don't really like it either. but i dont see other solutions.
Well, if all things need to implement RouterInterface, it means that ``only the nested routers implementing MatcherInterface`` is equivalent to ``all nested routers`` (as RouterInterface extends MatcherInterface).

I would call ``match`` here instead of create a fake incomplete request holding only the path info anyway
':new' is needed here, so the actions should be limited to it:

resource :phenotype_attempts, :only => [:new]
Метод init не обязательно описывать в интерфейсе нашего класса, так как он уже описан в интерфейсе "родителя" - NSObject. Мы его должны только переписать.
Этому массиву совсем не обязательно быть свойством. Доступ снаружи к нему не нужен ни разу
Эти вызовы srandom((unsigned)time(NULL)) перед началом заполнения массива дают такой результат, что у нас получаются идентичные массивы. Если закоментить второй вызов, то массивы будут разными. А одинаковыми я их делал для того чтобы проверить что происходит в предельном случае: вначале оба массива одинаковы, а после мутации на 100% подвергается второй массив.
А вообще говорят что лучше было использовать arc4random.
Вы имеете ввиду поиск нуклеотида, отличного от текущего? Каким образом, если не секрет?
с чего вы взяли, что я подумала, что вы "ругаете"? вообще очень странный поворот в разговоре взрослых людей. я всего лишь отвечаю на ваши вопросы. не более того.
Это особая магия остатков.

Случайное число r должно лежать в отрезке [ i .. genomeLength-1] (упс, похоже, верно так: "[ i+1 .. ...]"),
длина которого как раз (self.genomeLength - i ),
а начало - i.
which should be?
this method would be less hack-y if i were to switch from using mtconnect.Connect's do_get() to using requests directly throughout _Fixture
Should the error be propagated directly via Completer.completeException(), instead of calling complete()?  We should decide now for consistency of any error handling APIs.

Does the API provide a stack trace associated with the error?  If so, we should pass that too.
Moved it to a separate file which I indeed forgot to add, should be added in the new commit!
@houqp I would like to see your comment on this. Because this recalculation is a hack for koptreader which cannot determine page size before the page is rendered. Should we have a more elegant way to update the page size?
loader是肯定要有的，要用它来加载数据的。然后后面的options确实是用的map restructure啊
这里怎么不加:added?