[Routing] removed tree structure from RouteCollection
adjusted tests
added upgrade instructions
Fix problem when 1 column identifier in propel is a string.

The ModelChoiceList thinks it can be used as the index of the ChoiceList, when it can only be used if it is an integer.
#2042 initial implementation of fatal error handler
Fix namespace of Validator and BrowserKit Tests
merged branch franmomu/fix_validator_test_namespace (PR #6177)

This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #6177).

Commits
-------

964074a Fix namespace of Validator and BrowserKit Tests

Discussion
----------

Fix namespace of Validator and BrowserKit Tests

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Todo: -
License of the code: MIT
Fixed DefaultValue for session.auto_start in NodeDefinition

This is just for consistency with the node type (Boolean)
merged branch franmomu/auto_start_default_value (PR #6155)

This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #6155).

Commits
-------

88811f4 [FrameworkBundle] Fixed DefaultValue for session.auto_start in NodeDefinition

Discussion
----------

[FrameworkBundle] Fixed DefaultValue for session.auto_start in NodeDefinition

Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets:
Todo: -
License of the code: MIT
Documentation PR: -

This is just for consistency with the node type.

---------------------------------------------------------------------------

by fabpot at 2012-11-30T07:17:33Z

I don't see the need to change the default value as this is deprecated anyway.

---------------------------------------------------------------------------

by franmomu at 2012-11-30T07:35:35Z

I was trying to validate default values in Config Component and if I do this throws an exception
[Security] Move DigestDataTest.php inside the Security component
merged branch franmomu/move_security_digest_data_test (PR #6183)

This PR was merged into the 2.1 branch.

Commits
-------

d03281b [Security] Move DigestDataTest.php inside the Security component

Discussion
----------

[Security] Move DigestDataTest.php inside the Security component

Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Todo: -
License of the code: MIT
[TwigBundle] Fixed tests
merged branch hason/twigbundle_test (PR #6187)

This PR was merged into the 2.0 branch.

Commits
-------

acf1f86 [TwigBundle] Fixed tests

Discussion
----------

[2.0][2.1][TwigBundle] Fixed tests
Merge remote-tracking branch 'upstream/master'
Fix my code and also fix the test suite.
I found the error in my latest commit. This pass the test suite.
removed the TODO mention. Will keep the Propel code here so it can work with older version of Propel
Removed the PropelColumnTypes.php copy

Using the Propel class instead, like in Column class
merged branch Koc/critical-errors-logging (PR #5863)

This PR was merged into the master branch.

Commits
-------

acfc750 #2042 initial implementation of fatal error handler

Discussion
----------

Display traces for fatal errors

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: looks like yes
Fixes the following tickets: #2042 (partly)
License of the code: MIT

Output looks like on screen http://easycaptures.com/fs/uploaded/737/1191436899.png . I've added one line to css to prevent displaying standard xdebug trace http://easycaptures.com/fs/uploaded/737/5939488074.png

---------------------------------------------------------------------------

by Koc at 2012-11-08T21:55:41Z

So, community please advice me, how can I trigger `KernelEvents::EXCEPTION` event in `ErrorHandler` or `ExceptionHandler`? Or should I provide other event for this?

---------------------------------------------------------------------------

by stof at 2012-11-08T22:03:23Z

@Koc Don't. the exception handler is there to be the safe guard when developing, and does not depend on the kernel (which would be required to trigger the event). If you were triggering the listener again, it would mean that any exception thrown in a listener would lead to a loop.
And if it is for the fatal error handling, you simply cannot be sure the kernel is still available (and even less in a wokring state) at this point.

---------------------------------------------------------------------------

by Koc at 2012-11-08T22:06:31Z

But how can I notify logger (which will send me mail or just log this situation)?

---------------------------------------------------------------------------

by fabpot at 2012-11-09T07:33:41Z

The error handler is only registered when in debug mode in the Kernel and can be triggered very early in the handling of a request (even before we have access to the dispatcher or anything else). So, the current PR looks fine to me (apart from the typo and the lack of unit tests).

---------------------------------------------------------------------------

by Koc at 2012-11-09T09:13:03Z

> The error handler is only registered when in debug mode

Ooh! I haven't see that before. But the goal - be notified about errors by email or log-file. Like now exceptions with traces from site emails to me.

---------------------------------------------------------------------------

by fabpot at 2012-11-09T09:20:54Z

I think there are two goals. The first one being to have nice pages in the development environment when a fatal error occurs. And this PR addresses that feature quite nicely. The second can be addressed in another PR.

---------------------------------------------------------------------------

by henrikbjorn at 2012-11-14T11:50:22Z

I have some questions about the ErrorHandler. Is there a reason for it only to be registered in an debug environment (which prod is not). Would assume that if i enable the ErrorHandler in productions aswell Monolog would log thoose instead of them just vanishing?

---------------------------------------------------------------------------

by Koc at 2012-11-14T12:01:50Z

I am thinking about it too. But as Fabien says it will another PR

---------------------------------------------------------------------------

by GromNaN at 2012-11-18T10:38:09Z

You should add a memory reserve to be able to handle "Out of memory" errors.
An example is here :
https://github.com/LExpress/raven-php/blob/513d628966ffc356d827ecc48ec557675bd116b8/lib/Raven/ErrorHandler.php#L91
https://github.com/LExpress/raven-php/blob/513d628966ffc356d827ecc48ec557675bd116b8/lib/Raven/ErrorHandler.php#L62

---------------------------------------------------------------------------

by fabpot at 2012-11-28T11:35:21Z

@Koc can you finish this PR (probably by integrating the memory reserve as explained by @GromNaN)?

---------------------------------------------------------------------------

by Koc at 2012-11-28T11:46:12Z

of course, on this weekend

---------------------------------------------------------------------------

by Koc at 2012-12-02T17:44:44Z

@fabpot done
[Config] Fixed tests on Windows