labofsahil/github-event-dataset-2012 huggingface dataset:
argc >= 3? Why does it need to be greater than 3? We only have 2 parameters?
ОК, спасибо
I was not distracted at all while typing this commit message. Definitely.

In other news, it works! Cubior is now compiling on all OSes! (afaik)
Adding: 

MIDDLEWARE_CLASSES = MIDDLEWARE_CLASSES + (
    'amo.middleware.NoConsumerMiddleware',
)

To settings_local.py will turn all that the consumer stuff off.
What input gives this a syntax error?
I dont think postgres has unsigned data type? Or am I wrong?
This line should also have a "-lm".
you don't need this whitespace!
удали этот файл)
I see.   BTW: I suggest social_stream use bootstrap-rails for UI :)
The screenshot I linked too, shows the client 'crashing', all I did was set my name to a name that was 13 characters long + 3 colour codes.
I'll gladly do some testing.
Validating spell scripts...
2012-01-09 17:08:09 ERROR: TSCR: Spell `48278` Effect `Index: EFFECT_0 Target: 15` of script `spell_paralyze_pinnacle` did not match dbc effect data - handler bound to hook `OnUnitTargetSelect` of SpellScript won't be executed
Does swig let me `set` to another variable? Inside a loop I tried to do `set foo = loopvar.subproperty` and foo became `[Object object]`. I worked around it by using an `include` right away within the loop, then another `include` within that template.
> Clean up the ChargifyExceptions file. If it doesn't work or breaks things even more, blame @warmwaffles not me.

=/ lol
I have been creating the export labels by adding the 'Comp' suffix to the capital letter identifying specific matrix decomposition component, as documented in Wikipedia. For example, VComp, SComp, and UComp for the SVD's U S(igma) V' decomposition , or QComp and RComp for the QR decomposition etc. Let's talk about how we would like to change them tomorrow.

-----Original Message-----
From: David Bayliss [mailto:reply@reply.github.com] 
Sent: Wednesday, February 22, 2012 5:55 PM
To: Muharemagic, Edin (RIS-BCT)
Subject: Re: [ecl-ml] SVD initial version (b101ed0)

I am going to pull this as is so that we can actually start testing the math. I do think we want to sit down and think through some of our export labels though ....

--- 
Reply to this email directly or view it on GitHub:
https://github.com/emuharemagic/ecl-ml/commit/b101ed04c7ed7ce4750d45bf2257097d514be8ea#commitcomment-998449


-----------------------------------------
The information contained in this e-mail message is intended only
for the personal and confidential use of the recipient(s) named
above. This message may be an attorney-client communication and/or
work product and as such is privileged and confidential. If the
reader of this message is not the intended recipient or an agent
responsible for delivering it to the intended recipient, you are
hereby notified that you have received this document in error and
that any review, dissemination, distribution, or copying of this
message is strictly prohibited. If you have received this
communication in error, please notify us immediately by e-mail, and
delete the original message.
I just tested it, it's good, the only thing is that the views don't snap to their max/min positions anymore. That could be another feature: allows to snap or not
This spams the console with Java errors:
10:24:10 [WARNING] Task of 'MinecartManiaCore' generated an exception
java.lang.IllegalArgumentException: No enum constant com.afforess.minecartmaniacore.utils.DirectionUtils.CompassDirection. PLAYER]
        at java.lang.Enum.valueOf(Unknown Source)
        at com.afforess.minecartmaniacore.utils.DirectionUtils$CompassDirection.valueOf(DirectionUtils.java:16)
        at com.afforess.minecartmaniacore.signs.LaunchMinecartAction.calculateLaunchSpeed(LaunchMinecartAction.java:46)
        at com.afforess.minecartmaniacore.signs.LaunchMinecartAction.valid(LaunchMinecartAction.java:64)
        at com.afforess.minecartmaniacore.api.MinecartManiaActionListener.onMinecartManiaSignFoundEvent(MinecartManiaActionListener.java:27)
        at com.afforess.minecartmaniacore.event.MinecartManiaListener.onCustomEvent(MinecartManiaListener.java:257)
        at com.afforess.minecartmaniacore.MinecartManiaCore.callEvent(MinecartManiaCore.java:247)
        at com.afforess.minecartmaniacore.signs.SignManager.getSignAt(SignManager.java:53)
        at com.afforess.minecartmaniacore.signs.SignManager.getSignAt(SignManager.java:18)
        at com.afforess.minecartmaniacore.signs.SignTextUpdater.run(SignTextUpdater.java:18)
        at org.bukkit.craftbukkit.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:137)
        at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:493)
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:425)
        at net.minecraft.server.ThreadServerApplication.run(SourceFile:457)
Hi,
(sorry in advance for posting the same reply as above :) )
I have pondered this also. The nice thing about this function is that it can't be called to much, so safest to get in the habit of included it everywhere (this stops nasty stuff from happening if a user logs in twice on same browser to multitask; if this breaks down, then can get crazy behavior to happen).
-brady
Please do not use magic constant values.

PACE_PIN (if it is the correct name) is preferable to 0x03.
done there (conflicts while merging) https://github.com/gofigure2/GoFigure2/commit/2ef54489d3408081d51d97b9216c20e8e1db73a8
Inconsistent with Player::_LoadSeasonalQuestStatus()?
if you cant write this code your self you have no buisness cherry picking now go get the missinfg sql and test before you blindly cherry pick ... damn im glad i left dont have to clean up all these messes
If they have an eventclients package installed, those will be updated.

I have to double check upgrades from dharma to eden anyway.
> то res, то results... между ними есть разница?
Привёл к одному виду - results
Just FYI you wrote over the fix for mode error with this fix do to white space and explode function.  It throws an error when done the old way.  :( 
Starting at line 564:
		$reqdfields = array("mode");
		if($_POST['mode'] == 'hostap') 
 			array_push($reqdfields, "ssid");
Two things I wonder about off the top of my head are:
1) Does it support renaming of documents
2) If only CouchDB is used, what happens when make patient reports (and ImageMagick is used to convert some of the files)
I really hate using index.php for this kind of stuff. I know you wanted to stray away from not having a tools directory, but it may be something that should be reconsidered.
right.
otherwise ok?
Oh, ok.

I was talking about moving the l32-35 block to l10.

That is, before content is aliased with context. It lowers the chances of side-effects.
not true after the latest fix, was not true before either, event.amount() did return the minecraft-relative amount of healing, so setting this as health would not have worked.

Now the amount is returning the right amount so you can just commit the healing event with argument (max - current) and not set anything else, the player heals to full health :)

doing a pull request (here) right now to fix that!
One still could use eval() for IE7 to ensure compatibility - IE7 could be detected server-side, even.
Yeah. Doing this now
you can use IWuWebView for everything, including xml.

For XML you can call "expandResults" with some flags:

    unsigned xmlflags = WWV_ADD_RESPONSE_TAG | WWV_INCL_NAMESPACES | WWV_INCL_GENERATED_NAMESPACES |     WWV_OMIT_SCHEMAS | WWV_USE_DISPLAY_XSLT;
Cuz the BSD license is better bastiches!
"$users = $users =" seems to be problematic.
Look great +1
No tengo ni idea :S.
Replaced it with 'tableFieldsId'
Sure ,-)

```
-do-debug:
 [zipalign] Running zip align on final apk...
     [echo] Debug Package: D:\Daten\Develop\Eclipse\cgeo\cgeo-calendar\bin\cgeo-
calendar-debug.apk

debug:
[propertyfile] Updating property file: D:\Daten\Develop\Eclipse\cgeo\cgeo-calend
ar\bin\build.prop
[propertyfile] Updating property file: D:\Daten\Develop\Eclipse\cgeo\cgeo-calend
ar\bin\build.prop
[propertyfile] Updating property file: D:\Daten\Develop\Eclipse\cgeo\cgeo-calend
ar\bin\build.prop
[propertyfile] Updating property file: D:\Daten\Develop\Eclipse\cgeo\cgeo-calend
ar\bin\build.prop

BUILD SUCCESSFUL
Total time: 5 seconds
```
Why?????
correct me if I am wrong but I think the "remove unneeded event check in PhaseEquipProcess" was somehow not removed starting at _Unit* pVictim_
This event does nothing.
It has not been tested. As for the character list issue, I probably got confused and thought that the range of char was 0 to 255. Since it's actually 0 to 65535, your suggestion is probably best.
Note that I have added a second commit, to improve the wording of the displayCaps vs DisplayCaps notice.
hm, in ulduar i used
```
    GO_CACHE_OF_STORMS_10       = 194312,
    GO_CACHE_OF_STORMS_25       = 194315,
    GO_CACHE_OF_STORMS_10_H     = 194313,
    GO_CACHE_OF_STORMS_25_H     = 194314,
```
Because I was really really annoyed about the confusion in ulduar. but the instances with 4 modes are indeed clearer in the naming.
So I think
```
CHEST_SAURFANG_CACHE
CHEST_SAURFANG_CACHE_25
CHEST_SAURFANG_CACHE_10_H
CHEST_SAURFANG_CACHE_25_H
```
should be fine - and always using CHEST_SAURFANG_CACHE is a nice and fitting usage
@parndt wow, ur faster than me! thx :)
It throws an invalid syntax using 3.2.2

G:\b3-180b\BF3-b3-1>G:\Python32\python.exe G:\B3-180b\b3_run.py -c G:\b3-180b\BF
3-b3-1\bf3b3-1.xml
Traceback (most recent call last):
  File "G:\B3-180b\b3_run.py", line 33, in <module>
    import b3.run
  File "G:\B3-180b\b3\__init__.py", line 120
    print 'Starting %s\n' % getB3versionString()
                        ^
SyntaxError: invalid syntax

It actually on the closing quote after \n


It also thinks it is running on 3.0 when using 2.7.2 and 2.6.? , unless the version info is retrieved from the registry?
Hilter Kaput -)
you probably should squash this commit with 61660cc0d5dc6620dbe87a316b61d106046bd930
What is this for? Do we need to keep a reference to its container?
!isWidgetInitialized()
Should we consider taking all the constants (such as "NServiceBus.OriginatingAddress") from a single constants file?
I think that one (small benefit) that I can think of, is a common, general place that shows the headers types we have.
Just an idea...
closes #905
Those guids do not have a path_id defined in creature_addon, that means it shouldn't have MovementType 2.
If it has spawndist == 0, set MovType = 0 (nothing)
If it has spawndist != 0, set MovType = 1 (random movement)
fuck ima idiot
txComplete was previously modified in the synch. Was this not needed?
おお、コメントありがとう！取り込みます！
Default prototypes?
```default.prototype - TYPO3.TsTest```
allowing:
```prototype(TypoScriptArrayRenderer) {```
or if it makes the default easier to detect, use a colon:
```prototype(:TypoScriptArrayRenderer) {```
I know this is early development and you probably already thought of this. The new TS looks awesome!
No I don't think this is a problem. The idea is to use the SonataBlockBundle but have our own implementation of BlockInterface and the corresponding BlockServiceInterface, i.e. all the code and the logic is in the SonataBlockBundle, we just provide our blocks, our blockservices and our block loading. Do as little work as possible :-)
@dkowis added a mac slave to jenkins to build mac apps :)
whenever you update, you can see it on jenkins ;)
http://ci.maescool.be/job/Catacomb-Snatch-mac/
Jättebra att du exporterar databasen och lägger här också!
:p it works for waterwalk, even while moving, but ive got wrong spell in there, 
i need to make it so its not locked to one spell,,, xD that was jsut my test spell.
dude this is not done, the final patch will pushed today.
On Thu, Feb 2, 2012 at 9:39 PM, Gael Varoquaux
<reply@reply.github.com>
wrote:

> Should be fixed

Confirmed :)
Why are you cleaning / reusing a single event rather than just creating a new one?  I couldn't quite follow the logic here (see comments below).
Thanks so much for helping me. I've managed to figure out stable frequencies and it makes a real difference especially because of GPU acceleration.
This should call radius_list_name(), and get a pair_list_t back
Okay this is needed with FXP but not with stock ROM. *might* be needed for MIUI.
let's imagine... I'll use it:
<pre>
suggestions.addSuggestion();
</pre>
do you see anything strange here?
Maybe also: -DCUSTOM_SDCC_WIFI_SLOT=1 ?
Looks like this commit causes a lot of trouble on the IRC channel since "bin/vendors update" now fails for 2.0.10 users. As far as I can see this is mainly related to the usage of `Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition:setInfo()` which is not available yet in 2.0.10.
Is it necessary to use a BufferedReader? we are only trying to retrieve count bytes and Openfile.read() should store the additional bytes for you in buff and return the # of bytes read in.
Sorry, it did make perfect sense, I've just been working on something else. I'll crack onto it shortly :)

Sent from my mobile

On 2/02/2012, at 12:28 PM, John Kubiatowicz<reply@reply.github.com> wrote:

> In case I wasn't clear about feature requests, go to my project page:
> 
>    https://github.com/kubitron/redmine_git_hosting/
> 
> Register a new issue, and click on the "Feature Request" label at the right before saving....
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/kubitron/redmine_git_hosting/commit/00aa93d81b0b20d6f7c69d8a509d0df9c9014454#commitcomment-924464
Ok questi commit sono riuscito a metterli :-)
Download button moved to main activity
Anzahl der anzuzeigenden Links
C'est `bookmarlet_add.html.twig` la syntaxe
First off, nice one. I am actually using this in one of my projects and works without a hitch. I just want to make a suggestion for the $template parameter. can it be the path to a partial/view script. This would help make the code neater and comprehensive.
а может и воркает, я его не тестил. но это давольно старая версия, а новую я никак родить не могу, весь запутался
Ahh okay. Well, the ``wl()`` call below will then take care of it.
Warum drei Ausrufungszeichen???
Did this break something?
charging $1.99 for paper bill
ok, I was looking at my commit and wondering how it could have caused your
error.  Some of my other work was related to that function, so I guessed
that I broke something.  No worries on the alarm.

E.

On Fri, Feb 24, 2012 at 12:53 PM, Vincent Hugot <
reply@reply.github.com
> wrote:

> Yep.
>
> Errrr... I can't reproduce the problem from a clean clone, actually.
> 6bdae8e tests OK, as does 76eec30, and the current HEAD (though the
> testsuite has become quite time-consuming) .
>
> There appears to be something wrong with my local clone and not your code
> -- for instance with HEAD, bytecode tests hang up on this, 0% CPU, nothing
> happens -- no idea which of my untracked files could be causing that.
>
>    [509 / 609] >str_decode; str_encode>src/batBase64.ml:126
>
> So.... false alarm, sorry.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ocaml-batteries-team/batteries-included/commit/6bdae8e75896085c12c057c38da14d1fdbe156c3#commitcomment-1008817
>
usigned is mysql-only.
@geemus this helps to test just one provider. is there a way in shindo to scope tests?
The VDC provides the URLs of the vApp or servers that exist and then one has to iterate over these URLs to fetch the actual information
this test probably doesn't makes much sense, since it's always 1>0 :) or it tests that property value hasn't been removed?
'(renamed to geneNames from 'gn') can go
All noted, will fix :)
99 seems like an arbitrary default. [The maximum length of a Twitter screen name is 20 characters](https://groups.google.com/d/topic/twitter-development-talk/3HuhyNoycXc/discussion), which seems like a more sensible default to me.
You can use Handblars partials so you don't have to repeat all this code. `{{>datatable-masterdetail-source}}` inside of triple-backtics it will highlight it for you.
A logger is already exposed in the parent class. Please use that:
https://github.com/Jasig/cas/blob/master/cas-server-core/src/main/java/org/jasig/cas/authentication/principal/AbstractPersonDirectoryCredentialsToPrincipalResolver.java
fixed in d0eefa6
(0.0d /: newIntervalsForConnection) { (mean, interval) => mean + interval.toDouble - newMean }
Might want to comment as to why cleanUp shouldn't be implemented.
Yeah, I agree. Ideally I'd like to remove admonition and just select on ".admonition .warning" and "-admonition .note" but I didn't wnat to risk breaking anything.
How are these accessed from Java?
Do you really think that is needed? The purpose is to kick off other things, like starting some top level actor. Wouldn't default dispatcher be good for that? I can of course add a ec parameter that without problem, but not just because I can.
We don't have that for terminationCallbacks.
please move the example usage into an actual SupervisedAskSpec so that it is executed (also, this does not compile as is)
it's all about the unreachable stuff, so I suggest `diffUnreachable`
I'm working on getting a page of documentation about the plugins.toolkit and all it's functions etc - I'm about half done so hopefully by the end of next week - it'll be a separate page as I'm auto-generating it from doc_strings but I can't use sphinx directly :(
anyhow pop it for now so solr is happy
Good line about where the type has to match up to.
'click' => 'js:function(values) { console.log(values); }',
Не  Yii::t('YCustomGridView', 'выполнить'), а  Yii::t('yupe', 'выполнить'),  =)
This line and the one below needs to be switched (line 32 and 33) for the logout to work properly, since in the current format, $token isn't specified yet on line 32
Nope, that line is commented out (removed in next push.) See discussion in next comment.
I think I already pointed this out (but by mistake on the commit rather than this diff): This typedef was a lot clearer before the indenting was touched - please just put it back the way it was.  There's another occurrence of it further down in the diff as well.
Realy nice, I never mind about this solution :-)
`sizeof(map_[0])`
If I recall correctly, passing the Serializer here was dangerous, because the task might contains some JARs it wants to add to the classpath that are necessary for deserialization, added using SparkContext.addJAR. For example, say that the user adds a JAR that contains class Foo, and then uses a Foo in the task; we need to add the JAR onto the executor's classpath *before* deserializing the task body, because that body will use Foo. I guess this might not be a problem for Counters, since it is part of Spark, but it would be nicer to deserialize them after, as part of the task, instead of here.
Tu l'as oublié ou c'est pour une autre story?
Sun supports quad precision. I think it will show up in the next couple of years.

I'm not sure what tests would be appropriate, maybe a table of known hashes to check against. What about void types and structured types? In some ways this might be like the tests for the random number generators where just the first several values starting with a known seed are tabulated. That serves to make sure that changes don't go unnoticed. If there is a chance that pickles are affected that could be checked also. Can you think of other things that might be useful? I'm no expert here.

How was pycon?
/media/ should not be hard-coded in templates, see https://docs.djangoproject.com/en/dev/howto/static-files/#referring-to-static-files-in-templates
Строчки длинные
закомментированные методы не нужны больше? убрать их тогда
@fxn inputs?
Do you mean this instead ?

```ruby
@connection.execute 'drop table' if exists json_data_type
```
This discussion actually made me realise that the `method_missing` here is already not threadsafe. Fixed in 12d6d3a6f8914d272529d79cba461759e2dedf09.

@nikitug you can reuse the mutex I've added there. you no longer need a mutex in `delegate_to_scoped_klass`, but per the above please put a mutex around the `@@compiled_delegators.include?(method)` call.
Can't we just add railtie to sprockets-rails and create an initializer there?
Already changed: 45427e28a9f26f599f86c6626ed32672511c8dc5
dalli isn't shipped with a railtie to set this config

cc @mperham
Pushed https://github.com/rails/rails/commit/572ecaef17837550996cf86fabad17c2103e5a7e
Thanks for that comment. I just fixed that with pattern matching in 14f7cee.
How does this compare with `isSynthetic`?
Should the first case even be allowed?

```scala
scala> trait Y; trait X extends Y
defined trait Y
defined trait X

scala> class X[+A <: Y]
defined class X

scala> null.isInstanceOf[X[Any]]
<console>:10: error: type arguments [Any] do not conform to class X's type parameter bounds [+A <: Y]
              null.isInstanceOf[X[Any]]
                                ^

scala> null match { case _: X[Any] => }
warning: there were 1 unchecked warnings; re-run with -unchecked for details
scala.MatchError: null
```
plt is pyplot, it is imported at the top of the map module. To display it the user would have to import mpl themselves, not under the plt namespace if they didnt want to.
Why does pep 8 add these extra spaces?
Should these be properties?
Thank you.
Yes, the lower level seems to be a perspective direction (for this recursive method), with some internal structure.

2-d kind Bell polynomials, as yo can see, have property that the "order" of monomials (if we weight-ed the x_1, x_2 variables) are the same `$j_1+2j_2+3j_2+\dotsb=n$`. So the  structure is sparse.

But may be exists another combinatorial methods (even though recursion by one index, that is 1D), But I did'n find.
When I was thinking about this, I came to believe the returning un-evaluated was the best option, because the true meaning of sin(oo) is in the eye of the beholder.    For example...

    limit(sin(1/x)*x,x,0)

evaluates correctly to 0 under the current implementation, but raises an error inside limit() if a Nan is returned.  After all, sin(oo) is not arbitrarily undefined like 0/0 is, since we do know -1 <= sin(oo) <= 1.  A "right" implementation of sin(oo) and other oscillatory functions might be to return the closure of the set of all accumulation points of subsequences, but in standard practice, we fold this complication into limit directly, with things like the sandwich theorem.

However, if there's a simple mechanism that ensures things like limit() will never be confused by the NaN evaluation,  then evaluating to NaN becomes more attractive.
You have lost this case. L247should be modified to include this. The minimum case for this to be specified is ``ask(Q.real(x**(y/z)), Q.negative(x) & Q.odd(z)) == True``. Note this code you deleted has the same problem that you fixed with your code that used modulus, so it should use even and odd handlers instead.
need -> needed
Should these have `+` signs in front of the method calls?
the logic below is insane.
5.0 and above only.
This might not be a get, it should maybe just be `#request(from_params)` or something like that.
Sure it can!

```c
return uv_cond_condvar_destroy(cond), (void) 0;
```

/me ducks
Do you want me to fix these (and the other changes) and send another set of pull requests?

Thanks

On 28 Dec 2012, at 13:28, Ben Noordhuis wrote:

> In src/unix/linux/linux-core.c:
> 
> > +  /* Now we want to make sure that all the models contain *something*:
> > +   * it's not safe to leave them as null.
> > +   */
> > +  if (model_idx == 0) {
> > +    /* no models at all: fake up the first one */
> > +    ci[0].model = strndup(bogus_model, strlen(bogus_model));
> > +    model_idx = 1;
> > +  }
> > +
> > +  if (model_idx < numcpus - 1) {
> > +    /* not enough models, but we do have at least one.  So we'll just
> > +     * copy the rest down: it might be better to indicate somehow that
> > +     * the remaining ones have been guessed.
> > +     */
> > +    char* inferred_model = ci[model_idx -1].model;
> > +    unsigned int i;
> Declarations go at the top.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
This migration makes no sense.
It removes this from the commit so that grit doesn't blow up:

```bash
mergetag object b2b1760347d797f3dc79360d487b9afa7baafd6a
 type commit
 tag v1.1
 tagger Jonathan Hoyt <hoyt@github.com> 1340923695 -0700

 signed tag in foo
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.12 (Darwin)

 iQEcBAABAgAGBQJP7N8vAAoJEM+49UOrepeVvk0IAMg8rB5eM0wFPC2nBy9ji4rp
 mM2xmrmEJmI7IKbY4TxtFTXq8kU9YhETBj5ZDTzUysPNDA5n+ZkZ/8MeXGTp4ml6
 kdDUIGXfAt7UXsEUjVw4C0Ln8TbxZEk2bDGWoEuPuMcwqj0aNihIcxb0lg7iYoq4
 THdKlbaA4qvF2Su42tayLOcT3pmIIZilQjSe6eilYLkqz9VpW0Fi/eMhe1WD2Vc7
 A97pq0garOYg38roQC9JsLyx5gBsaWix30IxtwIQdPZB77rRTZGoCfofOvZvwJtD
 4LQoMEzppxHMIdBbKyOaU5i/RjBxtJIScwlHXd9FSujn9ydAJdj8gvpyRtvCkCE=
 =yhJX
 -----END PGP SIGNATURE-----
```
Do you think it's worth using something like icu4r instead?  Or were you thinking of changing `CharlockHolmes` to use the C API to ICU?
I don't like manually enumerating section titles. 

I think it'd be ok to have something that resembles the following for the document structure: 

- synopsis

- patterns

   - proxy collection/function

   - optimistic loop

Ed doesn't care parent nodes that don't hold anything other than children nodes, but I have no problem with it when it describes the actual logic of the document. As long as we don't have more than 4 levels in a document under the most extreme conditions, then I think it's fine.
Not sure how I missed that;  removed.
Yeah, I should be consistent with the rest of the code in this class.
Alright, thanks :-)
Space migrationsto
Did you look at the language entry? Did you test it?
Not sure, but think skyBox should not belong to camera.
I think blend() and blend3() (and copy() and mergeRecursive()) are intended to work on JSON-like objects/arrays.
This change seems very very strange.  The file has gone from one that registers actions on the controller, to one that creates a mojito app.  Yet, it's still in the `/actions/` subdirectory of a mojit.  I think this is perhaps an error.

(Of course, since it looks like `examples/sandbox/ex1/` is doomed, the issue is probably moot.)
"const int" will not help. using run-time, not a compile-time value to specify the array size is not a standard feature. Use vector<Vec3b> colors(nLabels); instead
I think the comment should be removed.
I'll change. Thanks.
This random data generator loop is pretty onerous. Perhaps the classes themselves could generate random data, like AmazonSite would have a method to generate a random JSON doc for itself. That would allow this to get more complex without making this nested switch stuff explode.
Is this supposed to fail here? Should we call fail()?
yep, just memoize this in `helpers.findTestFiles` itself.
we should probably change it to a proper order too
I see it the opposite way - if qe_child is deleted first, then spawned_children_.begin() would not exist for the erase.
You could use the `django.test.utils.override_settings` decorator to wrap `FileStorageDefaultPermissions` here.
@alex see [this comment](https://github.com/akaariai/django/commit/3c2fce6bdb82d27b153e8061888ec6514795f88c#django-db-models-deletion-py-P50).
If you put `use Adapto\Mvc\Controller;` above this class, you can avoid these long namespaced class names and just write `AbstractActionController`.
Oh, okay
Could you please add a comment somewhere describing why install-dirs is special-cased? Is it simply the only know section or is it special in some other way?
I'm not sure if this is necessary, you can access the functions without this.
No problem. Will do shortly, and report back.
@rwldrn did we decide to remove the style exception for spaces around quotes within parens? TBH they have always confused me too; I know there was some recent discussion.
Thanks; this and `jsonProp` were my favorites.
No, it's not done.  It is desirable to do it correctly in C++, but as far as you don't understand why palloc is dangerous here, you should write the SRF in your traditional way like in C, and do whatever you know including ereport().  Then wrap it in PG_TRY() and throw a C++ exception by MADLIB_PG_TRY() block so the error can correctly be handled.

At least the current code is worse than before, as new'ed pointers are not delet'ed, for example.
This is fine for now, but in general I find this code messy. There are lots of plpy.execute invocations where there only needs to be one. Also it would be preferable to use the Python format function instead of string concatenation.
Eventually, of course, this code should be adapted to the forthcoming Python abstraction layer and all the PG/GP-specific parts should be factored out.
(1) Inlining it won't help performance.
(2) Inlining it will increase the binary size.
(3) Inlining it means that any time it changes, all modules that include tool.h must be recompiled, which slows down incremental compilation.  This is important to developers.

So, it does two bad things and no good things.  Don't inline it.
```
def perform(op, key, *args)
      key = key.to_s
      key = validate_key(key)
      begin
        server = ring.server_for_key(key)
        server.request(op, key, *args)
      rescue NetworkError => e
        Dalli.logger.debug { e.message }
        Dalli.logger.debug { "retrying request with new server" }
        retry
      end
    end

    def validate_key(key) 
      raise ArgumentError, "key cannot be blank" if !key || key.length == 0
      key = key_with_namespace(key)
      raise ArgumentError, "key too long #{key.inspect}" if key.length > 250
      return key
    end
```
would this be ok?
I made it clear earlier that we (meaning "Homebrew" in general) don't want to be in the position of maintaining software or large patches. Making small configuration changes is one thing, but I do not want to maintain growing patchsets that aren't being incorporated in the original project.

Given the direction this is going, it might be more appropriate for pass to be maintained in a tap rather than in Homebrew core.
Is this something which can be automated? I'm sure it can but my UNIX-fu doesn't take me that far ...
superenv makes this sort of thing unnecessary, you see.
ah ja, ja. 
No me había dado cuenta :p 
Claro que es texto y no text
It isn't.  This is a developer assert.  A hold over from my C days where I don't like to leave code continuing to run to a possible uncertain outcome.  It souldn't ever trigger but if it does we have issues bigger than confusing the user.  Usually we would turn these off in a production env once we are satisfied that the result is all but impossible to reach.
Il faudrait un fichier ou se trouve TOUT le texte. Je sais que pour l'instant ce n'est pas grave mais si un jour on a besoin de faire de la traduction, ça sera 1000 fois plus simple
There's also a [DispatcherTestCase](https://github.com/praekelt/vumi/blob/develop/vumi/dispatchers/tests/test_base.py#L13) method that you can subclass to make [testing easier](https://github.com/praekelt/vumi/blob/develop/vumi/dispatchers/tests/test_base.py#L469). Some of the older router test cases don't use it because it was only recently added. It's up to you, use it if you find it helpful.
is there a reason for not just doing:
days_of_month = set([int(day) for day in self.self.schedule_definition['days'].split(',')])
could we get space separated values coming in ?
(I'm not doing a full review, just glancing at things over morning coffee)

The trailing slash isn't needed, since you're inside parens.
The default for subject is `described_class.new` so this probably isn't necessary.
I think we can get headers installed from a linux/kernel/ expression. No need to add anything to kernel-headers. I might be wrong though.
我还是希望多数*nix用户能以标准轻便的方式安装，不要轻易动用make以及改PATH
Should log the flush interval
If you can take it out, and the self-tests still pass, please do it.  I'll take the heat.  I _never_ should have written those lines in the first place.
Sure! I wouldn't call it "global state", though. Rather, this is a mechanism to support certain kinds of JUnit extensions, without requiring users to do anything more than adding a jar file to the runtime classpath. Other special runtime environments, such as OSGi containers, Java EE, etc. already provide similar mechanisms, I believe. TestNG provides this exact same mechanism since version 6.2.

To me, it makes a lot of sense that a fundamental framework such as JUnit would support such a mechanism. The JUnit test runner is the entry point for the execution of a test run (well, apart from the software that calls into "JUnitCore", like Ant, Maven, IDEs, etc.), and there are many other testing tools which need to integrate somehow with the test runner. Today, users have to jump through unnecessary hoops (like adding "@RunWith" or a rule, or extending a base class) in order to make use of these extra tools in their test classes. The idea here is to provide a clean and non-intrusive solution.
More comments to remove.
It lies. (It supports <audio> but no codecs.)

On Friday, July 13, 2012 at 4:44 PM, Dan Imal wrote:

> > @@ -21,6 +21,7 @@ dojo.declare('toura.components._MediaPlayer', mulberry._Component, {
> > 
> > this.media = this.medias[0] || {};
> > this.useHtml5Player = mulberry.app.Has.html5Player();
> > + this.androidAudioFallback = this.playerType === 'audio' && mulberry.Device.os === "android" && mulberry.Device.osVersion < 2.3;
> > 
> 
> 
> Can we use feature detection instead or does android lie and say it supports <audio>?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Toura/mulberry/pull/526/files#r1162136
> 
>
Oy. No. There was another branch in there at one point. Will definitely remove.
This should still be within `.component.video-player` so it's not global.
Should probably test the unquoted variant of this too: `div dir=lt`
I searched around and it looks like we are pretty consistent. Fixing.

-----Original Message-----
From: Narciso Jaramillo [mailto:reply@reply.github.com] 
Sent: Wednesday, May 23, 2012 10:55 AM
To: Ty Voliter
Subject: Re: [brackets] Menu, MenuItem, key bindings, and Command API (review only) (#927)

>      var _commands = {};
>  
>      /**
> +     * @constructor
> +     * @private
> +     *
> +     * @param {string} id - unique identifier for command. Plugins should use the 
> +     *      following format"author-myplugin-mycommandname".
> +     * @param {function} command - the function that is called when the command is executed.
> +     * @param {?function} isEnabled - callback function that returns true when 
> +     *      the command is enabled.
> +     *
> +     * Events:
> +     *      enabledStateChanged
> +     *      checkedStateChanged

I think in general we use the present form of the verb instead of the past for event names--e.g. "change" instead of "changed". Not sure if we're consistent everywhere though.



---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/927/files#r869660
template.render → Tilt#render → evaluate → cache_evaluate → precompile...
This really needs to move to the base_handler interface. Maybe you can add a `getIdentifierRegex()` there?
W -> w
I don't think this `or None` is necessary, but also this is slightly different functionality than what was there before.

For example, before, the node `<value> </value>` would have passed `if text` and then returned `''` (empty string). In the new code, the same thing would raise an XFormError, because you strip first, then filter out empty strings.
Do you maybe just mean == and not <= ?
This is Danger Zone™, we're hacking into implementation details of Win7. However, I don't think there's any proper way to do this - might be best to gate this behind a version check (i.e. only do this on Win7 + Win8)
the traceback? what?
.info 也可以拿掉, 一般像是 .info, .pick 這類的 class, 都是有關樣式定義 (例如顏色大小等), 而會有重複利用時, 才會特別去定義
例如刪除的按鈕, 新增的按鈕, 或照片數的數字等, 不然的話通常在定義位置的 class (.pull-center)就夠了 (代表這個位置的文字就都是這樣的樣式)
The name of the database should probably be a setting?
Very good that you remembered to do also this, but it has been already done. (But I think you can still indent.)
Omitting the `href` atrribute is probably enough actually, as long as that works for all browsers
Add frame in here too, since Brian had it before.
Could we adopt this style for all the methods for all the functions (other than login)? 

Maybe it should be left to another ticket.
这个handler机制为什么不能用switch结构来搞？链式的这种handler处理方式会不会引起冲突？
Same thing with the nulls here. Return type of `Some[List[String]]` would be good
Hrmmm, it's a bit weird, but I don't know.  Is it always true that one can only write a BlockingWriter for something that has MimeTypes?

I feel like this information should be found outside of the writer, not inside.

I'll wait for you comment before saying ok to the pull-request, even if it's probably ok for now.
Yes, in future. But let's not try to solve multiple things in one patch. Do with localhost for now ;-)
`allows you to`
docs pls
I made new test (pivanov) because I have used page with iframe but You are right :) this should be pivanov test :)
Good point.  This actually predated the "1 as default" behavior.  I'll fix that.
All files should include the license line:

    # Licensed under a 3-clause BSD style license - see LICENSE.rst
I find the word "catch" here a little confusing.  What this really does is include warnings in the logger.  When I think of "catch", I think of something that would halt execution (like an exception).  It may in fact be useful to have a setting that would turn warnings into exceptions (I know Python has one as commandline arguments to the interpreter, but we may want to make that more obvious by having our own flag).  For this, how about "LOG_WARNINGS" instead?
No need to discuss in the end, I just removed if for now :).
@TheBlueMatt we could eventually go to representing all URIs as QStrings until the last moment before parsing. QUrls were great until the requirement came along that "bitcoin://" should work too... Qt mangles the address in this case, which kind of breaks the abstraction already...
I think the reason is in bitcoin.cpp ThreadSafeMessageBox(), where we first use the modal flag. I'm sure it could be removed, when I have time I'll take a look. Do you think this should block merging this pull then?
kind of verbose, don't you think? it should be a brief description of what bitcoin is. no need to be all technical and say it's a gui or what the licence is.
If that def isn't valid, bitcoin wont build correctly anyways. It just implies using #include <iostream> vs #include <iostream.h> and similar.
That must be a merge misstake I overlooked ...
Yeah can do that. Was unsure where to place it as I also saw CakeTestSuiteDispatcher::date().
s/psuedo/pseudo
please remove all ``@abstract`` in the interface
again, down here the easy_install readline needs to be OS X only
porque es la prueba 1 y no 2?
deleteContainer
I see. Is this mere convenience though? I'm guessing jclouds will become more generic aware/friendly overtime, so maybe just bite this bullet?
can you put a more meaningful description and/or example?
This is a library, not a script intended for running, so leave out the shebang.
It looks like a text-book example of using a regex. If we pre-compile it just once, the performance hit will be minimal.
Hrm, were these steps necessary in Lion / Snow Leopard as well, or just Mountain Lion?
Is this content intended to be localised? If not, we should remove all the calls to `_()`.
Doesn't this fail in the 1 case (in English) and print "1 questions in the last 3 days"? In Polish, this fails in the 1 and 2 cases (I think that's right).
This change we definitely want to keep, nice catch :-)
back 4 spaces.
This conversion of string to `nsIURI` __is needless__!
From [NetUtil.asyncFetch()][1] at MDN:
> __aSource__
> > The source to open asynchronously. This may be specified as an `nsIURI`, `nsIFile`, `nsIChannel`, `nsIInputStream` or __as a string specifying the URL__ to open.

Therefore `NetUtil.asyncFetch()` could be easily feeded with `aDataURL`.



[1]: https://developer.mozilla.org/en-US/docs/JavaScript_code_modules/NetUtil.jsm#asyncFetch%28%29
done. it felt clunky when i wrote it.
please describe what about this needs to be fixed and/or file a bug for it
Ok reading the bug it seems you were aware of this, sorry I wrote too quickly.
Same as above about including `params.uuid` in the exception.
It's not, but the same whitespace copying issue applies in both places, so I figured it made sense to fix both at once.
This is actually a (translated) comment from the original source. My take on it is that you can't skip starting dialogs, since it calls all the various script and animation handling code, but once a dialog sequence actually begins, you can skip it by clicking the mouse.
By moving it to the end of the condition the expensive property path is not invoked when not needed, e.g. when data is not an object.
you should delete it on tearDown
You should keep it like it was as you need to keep how it was done in Symfony 2.0, not before your patch.
The issue when forcing each implementation to support matching a Request is that the Request is not in the Routing component
Would also work, yes.
This makes the class unusable as methods are not static
i'm ... really not sure. :)

it would be good to have the position information for the actual token causing problems when we throw an exception, but it doesn't seem like that's possible without threading the AST node through the TypeResolver, either explicitly, or by calling withNode in a bunch of places whenever the focused AST node changes.

i'm leaning toward the explicit passing around of node objects, because the withValue() thing is a bit magickal to me -- i had to go look up what that is. but if it can be done with a few well-placed withValue() calls vs changing the argument list to every method in TypeResolver, then that's probably better.
Could you please change this Netdev call to a call to the network daemon?
Something like should work:

let module Net = (val (Network.get_client ()) : Network.CLIENT) in
let dbg = Context.string_of_task __context in
let mtu = Net.Interface.get_mtu dbg ~name:device in
che maskhare :neutral_face:
Seems fine to go in here (assuming the server is reliable enough...)
No line breaks please :)
There needs to be another new line here (imports from separate packages get a blank line between them).
The dependency on _something_ `Event`-like existed previously, this is just bringing it to light.  If `jQuery === Ember.$` can we update this PR to 
`var Event = $ && Ember.$.Event` and pull? Or should do we need to better delineate State#transitionTo and Route#transitionTo?

Followup Q: I've never needed the jQuery event in a transition. Can we just pass context and skip the events entirely?
There is also a `context` property which is the templateContext. This is especially helpful in cases of `#each`
could change this to be - instead of _
@scottgonzalez, should I be using .simulate in tests instead of .click() as a general rule?
yeah, I forgot to delete it when cleaning the code from comments
@jmcanterafonseca is another option :), @aymanmaat you decide.

But still don't see necessary to add the listener.

Thanks!
nit: what is 'int' for ?
nit: Switch to the first page only if the user has not already start to pan while home is loading
I think it is needed here to call to subject.remove to remove the contact from the DOM and then test what happened
/shared/style/ is theoretically reserved for sharing building blocks that will land in $Gaia/shared/style/. Don't want to enter to much into details here to not pollute the review with this subject!
Settings store is expected to be loaded by this point
Ah yes. Please remove. It's bad for CSP. And also just bad.
The space before the colon may be removed.
Do we actually need capturing groups around the entire expressions here, or are they just a nicety?  It might be good to have a comment explaining them either way, since if they confused me they might confuse others. :)
The full line is 

Create the "sticker" application do

which is definitely a syntax error.
I think your logic would have to be the opposite. In the case of an outputdir being present, I'd want the module name to not exist since the outputdir option writes each template into an individual file, negating the need for a module name. Without an outputdir, I think that'd be assuming that they're going to get shoved into the same big file. Meaning the module name would be required. I think I'm ok with that use case if you are.

And regarding the module name, I think this may just need to be an option that can be passed through. Make `hogan.js` the default, but give me the option to change it for my specific application. I feel that everyone is going to have their own alias. It's not set in stone like it is for Node.
I haven't fully thought through this, but I think using inner joins here (and below, line 398) might actually be to our advantage. My reasoning is this: since the full skew join is only allowed to have inner join semantics, any (for example) left key that does not have a corresponding right key will not appear in the final output, and so should be replicated *0* times. This is kinda like doing a bloomfilter join, except that we're using the key counts hashtable to do the filtering instead of compressing it into a bloom filter.
Does doing a multi-line string like this put a lot of space when it actually logs it? It seems like you'd want to do `"Please" + \ "check the datastore type"
Why nest these functions? It seems unnecessary and you could just eliminate the inner function, pasting its contents in the outer function.
Document this class.
>`data` is what jquery calls it:

What if jquery was wrong?

>that's what i thought it was at first

I thought a form was [something you filled with according values](https://www.google.fr/search?q=form&tbm=isch).
So should we `catch` the expression inside the case header?
I wonder if we should perhaps just ignore it, or still assert that
`method=='clobber'`.

There was a question recently about how to handle forcing a full
rebuild. One way to do that would be to make `mode` renderable ... which
I just realized would complicate things further, as the config checks
couldn't be done at config time, so ignore this, probably.
What is this about?  I see it tested but not used..
There's no 'c' in broken :)
# Header that blocks the [ edit | delete ]
If I undersood correctly your idea is to move:

if(!Create((LPCTSTR)m_szViewName, (int)width, (int)height))
{
PostQuitMessage(-1);
return false;
}

from CCEGLView::setFrameSize function to CCEGLView::sharedOpenGLView()?

Then in main.cpp after:

CCEGLView* eglView = CCEGLView::sharedOpenGLView();
we should add something like:
if(eglView == NULL) return -1;
Note that the github protocols stuff is used only for downloading packages from "source" (as opposed to dist), which means typically it is dev versions of packages, and not tags. Now assuming you get MITM'd, I *think* the git process would prompt for user acceptance of the new signature, and it'd block there because that is hidden from the user, and then it'd time out after a while.
hmm, no sorry. But var_dump should be removed :)
why building an interface returning an array or false ? I know some PHP function love this kind of weirdness but it is really weird. I don't see why a boolean would be used here. If nothing can be returned, the proper return value would be ``null``
I think I'd preffer a Rails.logger call instead of puts :)
Is it not simpler just to render all the images on to a single page, in a list? Not sure the advantage of paging through with a querystring for non-javascript users. I would have thought it would be slower experience than skimming a list of images.
My personal preference would be to not show anything at all if there's no choice to be made.
@lloyd - I am confused by the behavior here and am not sure if this is working as expected on FF Nightly.

Once I said who the user was, I expected an attempt at getting an assertion.
Correct. I typo'd it.
Did you try to reason about this method under concurrent scenario's? I wonder what the behavior should be when for example multiple other threads try to kill the same thread, can that for example result in the thread not being killed at all? Should we use a lock here or not?
Why does this exist? Why use the system to figure out what to do?