labofsahil/github-event-dataset-2012 huggingface dataset:
It looks to me like this call to service_registered has the desired effect of removing the service from the riak_api_pb_server's dispatch state; however I don't think it's `states` are being treated as cleanly. I'm not sure if that matters, but I think it's worth a look.
nit: indent +2
I don"t really care. I used the eclipse builtin code generator, otherwise I would use the commons-lang one.
I actually kind of like this way of delimiting parameters (the @ prefix), but it seems like at least all of the new API docs should consistently either use @s, or enclose in quotes, or simply refer to the param the same way. Thoughts?
Would you say that reading the migrators from the directory itself is the best way to keep a list of available adapters to handle this?
Why is that needed?
In which situation previous implementation didn't work?
Spacing (at the end).
This line:

this.orderTracks = function( orderedTracks ){

Has differnet whitespace than this line:

this.setScrollbars = function ( hScrollbar, vScrollbar ) {
I noticed that trying the server without mongo running is still broken (which is in another ticket), but even the error message is lopped out. I don't mind if you just want to deal with this in that other ticket (https://webmademovies.lighthouseapp.com/projects/65733/tickets/2055-cornfield-startup-error-in-absence-of-mongodb).
This is still wrong. Did you rebase?
Yes. You are right. This way it's much cleaner.
Thanks.
这个 API 是正常的 API，所以这个测试没必要去除。
Turns out a potentially non-deterministic parameter ("?service=[data]") gets appended to this URL in CAS -- I used a RegEx to keep the test from being brittle, but the RegEx isn't supported by redirect_to. (Passing a non-String tricks it into expecting an ActiveRecord I think)
kept as-is
missing since tags (in a few places other than this too)
coding style, squeeze the spaces between the type and variable. There should be at most two spaces.
The timezone is actually stored in the off:Float field, as a day fraction. 

The zone field was meant to store the string zone abbreviation, since there could potentially be a one to many relationship between time offsets, and named zones. 

Thinking some more about it, i think this is a mixing of concerns, the date object should not care what the human readable zone it. It should be a concern for the data formatting routines. I am therefore minded  to remove the string zone field altogether from the type.
I can't remember the reason for the params[:offset] but I'm not sure this should be 0 or even a string of "0".
Catching general exception is bad thing. You want to do this:

```
try:
  ....
except OSError, e:
    sys.stderr.write("Error %s while executing command: '%s'\n" % (str(e), " ".join(cmd)))
    ...
```
Is there some reason why you can't clean it up?
I shortened this to be just the composer/packagist name. mlehner/gelf-php
It looks like it should be an option/argument to the call for sure...
It would be really nice to just to be able to say 'initialize once ready' and return. That way the script would not have to deal with a long delay... not sure how to make that happen though.
Is there an alternative?  I don't particularly like adding all that extra spacing here; it implies a separation that I think is inappropriate (purely a REST question, I think)
ah. I see what you mean now. fixed. thanks.
I really don't like CBlocks storing their own reject string, seems like a layer violation. Maybe not directly related to this change, as nDoS does the same.

I'd rather see a CValidationResult which stores such information, which is returned or pass-by-ref inside the block- and transaction validation functions. That's maybe out of scope for this change, though.
Will this work in case the proxy was set through the command line?
@lorenzo I didn't mean 2 functions to get and set each property. What I meant was 1 get/set method each for each of the properties _isRequired, _allowEmpty, _validationDomain so total 3 methods.

In my previous comment I was thinking of using a common function like `option($name, $value = null)`.
I agree with mark, adding more magic like this is not going to be good in
the long term. You can just easily override getColumnType or your schema to
return whatever you want.
Ah, I did not read you are getting the config from ClassRegistry... never mind then
stray whitespace here :)
Fixed with 9b774a69118f816f932ecdfc0ec354b3c55a9baa
I wonder if we should change that to 

    $type->setVocabulary('lucky', 'http://localhost/lucky/');

see also comment on next line
No, I just mean it should not have a whitelist of test groups, it should let the iptest program decide which tests to run.
codecell.js
```javascript
301     CodeCell.prototype.toJSON = function () {$
302         var data = IPython.Cell.prototype.toJSON.apply(this);$
303  >>>>   data.input = this.get_text();$
304         data.cell_type = 'code';$
305         if (this.input_prompt_number) {$
306             data.prompt_number = this.input_prompt_number;$
307         };$
308         var outputs = this.output_area.toJSON();$
309         data.outputs = outputs;$
310         data.language = 'python';$
311         data.collapsed = this.collapsed;$
312         return data;$
313     };$
```
so `toJSON` is an unnecessary extra call as it uses `.get_text()` under the hood, and does not apply any transform to it.
And here. I'll just stop commenting, grab them all.
also invalidate "jclouds#"+groupname
I will remove the client classes then and will make the one line changes in ApiMetadata class
Futures.get will be less code and still propagate exceptions
Typo: should be "that's only"
Yeah, that's probably ok, and more JS-like (document.location.search also starts with question mark).
Maybe put an `{% if settings.GA_ACCOUNT_CODE %}` around this part? The above needs to be there in case we have other client code pushing commands onto the `_gaq` array, but no point loading the rest if a code isn't present.
Kitsune and docs run with pip without problems. What others parts have to be tested?
Some extraneous characters at the end of this line.
what's with the `~`?
is this correct? just curious
ок. а якщо на mailchimpi будуть зайві? наприклад я видалив юзера
докблоки. ти перевіряєш check stylo'м код перед комітом?
I've been thinking a bit about this and I've reached the conclusion that it doesn't really make sense if people are not using a container to implement a registry for them. If by any chance they'll want lazy loading of the driver instances, the ones via CacheDriver.php then they would just need to load the driver into the CacheDriver then. And if they are using a DI other that Symfony2 one then they don't need one.

Also having a CacheFactory doesn't really provide any other improvements as either the DI or the use will handle it.

I'll drop this functionality from the PR and move it to the DI for the CacheBundle.

Thanks for enlightenment @stof :)
This implies it takes an array but this is now shown.
Should be `Boolean` here and below, to match Sf2 CS.
Thanks for having implemented this as an upsert. The comment is misleading, could you remove it ?
This will not work if you define several encoders using bcrypt (for different classes) as you are forcing the id.

You should return the data needed to build the encoder instead, like done for other encoders
Can re-use method on line 29. See if we can make it private, also.
破折号是三个“-”连一起。
This is my main concern in this section. Currently there are several different approaches:

 * An OS map tile nest needs to be told what projection its data is in (the user doesn't need to do this), that crs is then passed on to imshow to transform the image into self's projection
 * A WMS instance can get images from (any?) projection, therefore we don't necessarily need cartopy to do any image transforming
     * As an extension to this, it would be nice to be able to specify the projection that the retrieved wms image is in **on construction on the WMSFactory**, that way if there are projections that cartopy has that the WMS doesn't, the user can still get their WMS images.
type, should be Legacy
Du coup tu pourrais mettre cette nouvelle identité dans la config globale de git, non ?
Would something like http://hackage.haskell.org/package/filepath be nicer than all this munging?
Why do we have both `context` and `contexts`?
dont remove ll and la, I use them all the time
here is an example of why having a prefix or something longer in th elocalization classnames would have helped:

Description = a classname to localize
description =  a classname to format the description text of a user. 

my preference:

locale_description = a classname to be filled with the localized word corresponding to the classname minus locale_
description = a classname that i woudlnt use unless i was sure that i wanted to format the description of corpus, data list and user all the same color/size/font
Agreed, this is a bit excessive and unneeded on an undeploy.
No, you shouldn't set `appendTo` at all. Dialog should automatically be found because of `.ui-front`.
How is that a force flag? When the dialog doesn't end up being moved (`moved.length` is 0), no focus event is triggered, independent of the flag.
может эту логику в конструктор или в геттер перенести?
FTR, `checked` is enough, you don’t need `checked="checked"`
This will fail horribly unless your intent is to create a string here...

What you want is to either push each element or do something like this:

````js
// note your probably wasting an array here pushing them would likely be better...
carrierKeys = carrierKeys.concat(['...']);
````
none blocking: can be group these `SettingsListener.observe()` calls into a loop?
That's the most important modication of this patch, so better be clear.

Here is what happen. You open sms app and open a thread list and start sending receiving messages with someone.
You focus the textarea element, the keyboard is shown and window manager code fires keyboard event and correctly display the keyboard and resize the sms app. For now, everything is fine.
But while your keyboard is shown and you are still focusing the textarea, you receive a message.
When you receive a message an `open-app` event is dispatched in the system app:
  https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/window_manager.js#L1242
That end up calling setAppSize from here:
  https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/window_manager.js#L1290
Without calling setAppHeight as there isn't any loss of focus nor any keyboard event in window manager.
So that you end up with your textarea still focus, the keyboard still shown, but the sms app with a full height.
And part of the sms app ends up being displayed behind the keyboard.
You don't need to save the `target` since it will always be `iconContainer`
'delete' is not a reserved word for naming a method?
They must be indexing starting from 1.  :-/
Thanks for reminding me that this exists! I should probably localize that soonish.
On 19/06/2012 11:41, Fabien Cazenave [:kazé] wrote:
>> +
>> +/* === Localization ===
>> +*  This thing here will push setting change into mozL10n for it to
>> +*  load the new locale.
>> +*  Each time mozL10n loads the new locale (including first load),
>> +*  it will dispatch a 'localized' event.
>> +*
>> +*  XXX: mozL10n should handle setting change by itself if possible.
>> +*
>> +*/
>> +
>> +(function l10n() {
>> +  var called = false;
>> +  SettingsListener.observe('language.current', 'en-US',
>> +    (function localeChanged(lang) {
>> +      // Skip the first callback firing
> sorry for the silly question, but why do we have to skip the first callback?

Likely because the first callback is equal to navigator.language and the 
UI is already initialized. Tim?
You got it! ;) Thanks!
I would indent this lines
originNode and targetNode will be their names :) sorry
Can we remove the console.log if no error here?
searching for coincidences on family name too
Wouldn't this fail if the phone number is saved on contacts with the country code and the search is made with a number without it?
OK, I misunderstood you code, this one have since moved to L1636 right?
All relative paths starts with "/", so, I think that there are no problems with separators between root ant relative path.

All relative paths are generated using:

```clj
(defn nimbus-storage-stormdist-root
  ([]
    "/stormdist")
  ([storm-id]
    (str (nimbus-storage-stormdist-root) "/" storm-id)))
```
Make this a List<string> instead of ```IE<string>```
建议函数名改为 saveAs，并且参数 opts 改名为 opWithParams。其中 opWithPrams 是 imageMogr/xxxx，不含 /save-as/Bucket:Key。为什么不应该是 opts？因为 imageMogr 的参数列表是次序相关的，并且一个参数不一定只出现一次。所以只能是一个字符串。而且这个函数还有另外的好处：如果我们多个 fileop 都支持 save-as 参数，他们可以共用同一个 api。
unused `handler` arg
Thank you for your advice.
Devise use the class Mapper of ActionDispatch::Routing module for create devise_for. 
I will follow this new way.
cf. https://github.com/plataformatec/devise/blob/master/lib/devise/rails/routes.rb
admin が指すところは UI 要素ではないので、「」ではなく "" にしない？
Do you also want distributivity over scalar plus? (i.e., `forAll(v : T, a : Double, b : Double) => (a + b)v = av + bv`)

It's another vector space property. I guess it's unclear to me what this scaling operator is supposed to be.
What does arity of -1 mean? I don't know?
dissect_wipe_session is called conditionally (when we have found CHAP_N and CHAP_R strings). Until then, we keep the session.

Wouldn't  using session_get_and_del destroy the session immediately even after receiving any packet (which might not contain CHAP_N and CHAP_R strings) from the client?
This bit worries me. You removed the inner ConcurrentHashMap, and are using a non-thread safe HashSet. So now modifying the sets inside of the registeredRecipes map is unsafe. 

Instead of 'new Hashset<Recipe>()', I suggest using this:

Collections.newSetFromMap(new ConcurrentHashMap<Recipe, Boolean>());

That will return, in essence, a concurrent hash set, with type <Recipe>

http://stackoverflow.com/questions/6992608/why-there-is-no-concurrenthashset-against-concurrenthashmap
http://docs.oracle.com/javase/6/docs/api/java/util/Collections.html#newSetFromMap%28java.util.Map%29
it would be better coding style if you write

     command = ["%VCENV_BAT%",
                            "&&",
                           "msbuild",
                           etc
Although the installation guide recommends to use git and gitlab users, the gitlab.yml allows settings another git_user than "git" so I would probably suggest that the check should not be hardcoded to "git" but should use the user setting from gitlab.yml. Additionally it might be good to set the gitlab user in the config too imho (instead of also chcking for a hardcoded "gitlab" user)?
Can you sort the imports so that external libs come first?
IIRC, @avdi referred to this as "exception tagging." A fitting name, I think.
There must be an easier way. On all other components we're doing fine with one object. Could you look into that again? Thanks.
Is there any particular reason to not call `preflight.create_jid()` ?
`topic` is already exposed via `type` property, is this really necessary ?
This currently breaks creating any non-objectstore dataset, because `None` translates to `NULL` so it's trying to store `NULL` in a non-nullable field. Either these need to be changed from `None` to `""`, or the fields need to be made nullable (add `null=True` to the field definition in the model). I'd probably lean towards the former, as I find nullable charfields strange unless there's a clear semantic distinction between "null" and "empty" for that field.

Symptom is easy to detect - currently the tests don't even run, cause they can't create a project.
should 'use strict' be at the very top (e.g. outside of define)?
Damn copy&paste !!
Fixed
change this example to 'body'
If you expect `None` of something other, please check for `None` or `not None`.
@prolic Can you undo this?
Isn't catalog being already added on upper levels?
Added support for changed password. System will silently update the database whenever a new password is used by a user logging in. Will investigate not storing the password at all.
It may show "a" bug, but not 'the" bug. Also, fixing this bug may introduce other bugs because the integration test is incomplete. We need to make sure that the proper library is loaded when the key is unset.
Apparently, Opera and IE expose global variables for HTML element IDs, Mocha even filters out it's own IDs when detecting leaks. (https://github.com/visionmedia/mocha/blob/master/mocha.js#L4265)
It isn't an issue, it's just IE being IE.
how do you handle the creation of static documents then? I think this part is missing
Do we really need File.write? Ideally, we would simply use `IO.write()` for that (or `IO.putb`).
Note for later improvement : These instanciation need to be handled via individual services with a specific service tag. This would ensure extensibility
In this file there is only one place where it's called, so this will behave the way you want. But i think you are right and it's will be a better solution.
why the switch from `e.arguments` to `e["arguments"]` ?
I understand you prefer not to hand-edit easyconfigs, but instead of issueing pull requests for easyconfigs without `buildstats`, maybe you should fix issue #233 first, such that the `buildstats` have the desired format.

Are you OK with that, and fixing the pull requests you made that way? I don't expect that too be too hard...
Well, no. because I was using hardcoded '/''s before. :P

Since I'm now using os.path.join, I'm also using os.path.sep.
missing space after args,
shouldn't this just be removed?
Those tests assume that `BANNERS_HASH` is empty. They will fail on Jenkins because `BANNERS_HASH` is set in `bin/jenkins.sh`
Did not know about the fragment argument. Always learning.
I... yeah.
Should this have an ensure block that resets `MiniTest::Unit.runner`?
Maybe call this shiftKeyOffset?
if its attr_accessor, you dont need to @
I would add the if SETTINGS... here too, so this would ensure even the group is enabled, that it wont be required for the application to start.
Construct a Gaia app object with the result and let the constructor do the parsing to breakout the various pieces of the result.
It should not be a problem.
为什么要删除呢？
每次都要$("input.select")效率高？
In PHP < 5.1 instanceof would return a fatal error but after that instanceof should not need to be check with is_object() anyway.
http://php.net/manual/en/language.operators.type.php
see example #5
Does something is missing before `instanceof`?
The code coverage wasn't 100% for the method targeted by this test. It seems that the class `foo` is created when running the tests, so I changed the value for something that would both pass the test and cover the line.
и часто ты такое создаешь? в любом случае лучше сделать отдельную функцию, так как дефолтный конструктор може не существовать
Unused function? I have a better implementation of GetNickname and doesn't look like this is used..
Changed... using the older syntax, although I think they are trying to encourage migration to the new one.

Good to be consistent within an app though...
This needs a wait.  When I run the test, I don't see the page for viewing the source opening.
technically you could just do
```py
if user:
```
but it doesn't matter that much.
Yup, I'll add that stuff as long as you guys are convinced that the main thrust of this is legit.

Also, @nicklewis suggested maybe just having "activate-node" handle the certname add/check.  Which kind of makes sense, and would sidestep the need to come up with a new function name :)  Whatcha think?
I added an example configuration to the error message.
`config` doesn't seem to be needed. Also, the `logger(...)` statement should specify something like 'cluster' so you know where those log statements are coming from.
Fixed, as well as in `createUser`.
This should also check whether or not the comment that is being deleted was created by the current user or whether the current user is a content manager/tenant admin/global admin.
Why `_callback`? `callback` should be fine here.
I think it would be better and more consistent if this function would be _rowToComment and would just take one row and return one comment.
Taking this further, it would be nice if you could register a listener in ScalaPlugin that listen for changes for ``event.getProperty == RedirectStdErrOut`` and restarts the PCs (this way the method ``restartPCs`` could be private to ``ScalaPlugin``).
See comment below re: threads
that's as per RFC. If the agent is giving you */* then it's fine with anything
These should be `AND` instead of `OR`. You can add both as parameters to one `isset()` as the other methods have (keeps it consistent).
Если не секрет - почему 10? Наверное, всё же [[NSMutableArray alloc] initWithCapacity: countMutations] ?
в гитигнор!
Wil automatically close the file when you go out of scope.
Usually, if the thing is invalid we'd return :status => 422 instead of returning an object with a success status. This looks like a pretty good article with example: http://travisjeffery.com/b/2012/04/rendering-errors-in-json-with-rails/
i tried with the Cursor class and used  ```count(true)``` but it was the same result.
Negative/max_array_size sanity checks?  Or are these handled elsewhere?
It certainly should. :trollface:
@carlosmn I've sent a PR (libgit2/libgit2#629) to fix this. Could you please peek at it?
This and the other changes in this file were necessitated by the extra commit I added to `testrepo_wd`.
just a tiny comment on aesthetics, the left bar looks somewhat squeezed. We should add some space via the xticks.
Auto-completion masacre.
@pk11 It seems to be free, right?
So, we should replace this by something like:

```
application.global.getControllerInstance(classOf[..])...
```
exports.dispatch = function(...) {
...
};
why removing it ? It is still necessary when composer picks a dev version of the SE (which is the default with this command when you omit the version)
Capitalize "Extension". Basically we try to capitalize nouns in titles.
当前由一个连接产生的请求数量。
If it was in the code, I'd prefer to use a constant for this

    port_range_from = "1024"
    port_range_to     = "4201"

and then some sformat(...)s in the code

    "PassivePortRange" : sformat("%1:%2", port_range_from, port_range_to)

but as the testcase will probably not change, it's fine
We should rewrite the tests so that they only take as long as they need. use awaitCond instead of arbitrary sleeps
the way to do that would be to make these variables look private by adding `_`
and then writing to properties by these names in the base class.
That sort of explanation would be perfect in the docstring.
Т прнс^WW Failed.
Todavía se sigue leyendo el documento entero :(

Me gustaría que no tengamos que leer el documento entero y trabajemos
todo con stream reader, pero al fin y al cabo tenemos que guardarlo en
los documentos que van a Raven teniendo todo en memoria.

De cualquier manera, al decidir utilizar las categorías de Unicode
tenía que hacerlo carácter por carácter, una expresión regular no me
servía (creo) por eso lo hice así, no tenía ningún costo extra.

On Sat, Jul 14, 2012 at 12:54 PM, Alpha
<reply@reply.github.com>
wrote:
>> +                    stringBuilder.Append(" ");
>> +                }
>> +                forbidden = false;
>> +                space = false;
>> +                line = false;
>> +                stringBuilder.Append(character);
>> +            }
>> +        }
>> +
>> +        public void Add(IEnumerable<char> characters)
>> +        {
>> +            foreach (var character in characters)
>> +                Add(character);
>> +        }
>> +
>> +        public void Add(TextReader reader, int bufferSize = 255)
>
> Me gustó mucho la solución, pero esto me dejó en duda: ¿hay alguna razón por la que quieras mantener un buffer de 255 y no leer todo el contenido en memoria como hacíamos antes?
>
> No creo que los archivos sean TAN grandes como para generar un problema.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CommonJobs/CommonJobs/pull/130/files#r1164125
anónimo
Si, ahora lo hago. Jeje, solo copie y pegué, me podrían haber metido
cualquier cosa.

On Sat, Sep 29, 2012 at 3:01 PM, Alpha <notifications@github.com> wrote:

> In
> source/CommonJobs/CommonJobs.Mvc.UI/Content/DataTablesHelpers/DataTablesHelpers.js:
>
> > @@ -1,4 +1,27 @@
> >  ﻿$(function () {
> > +    $.extend($.fn.DataTable.defaults.oLanguage, {
> > +            "sEmptyTable": "No data available in table",
>
> ¿Le cambiarías por No hay datos disponibles?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/185/files#r1723707>.
>
>
It's not a built-in: https://github.com/al63/SublimeFiles
This is irrelevant. We want to test that the component returns a Ref rather than an error.
It is perceivable that `args` and `kwargs` and even `request` get replaced/changed in the `prepare()` method, so I recommend that this be changed to `return handler(self.request, *self.args, **self.kwargs)`. Also `self.request` should be used in preference to `request` on lines `353` and `354`.
Oops, that wasn't meant to go to pullreq, thanks for spotting it :-)
It was just meant to be a local version so I could test building of a gem
Is it possible for us to check for the active admin constant, and it that doesn't exist just call super instead of re-implementing the method from Formtastic?

This might work in the `#input_class_by_trying` as well.
it looks like this is overriding line 87 above. Is that right?
this looks wrong...
Thanks for all the feedback Dan. Erik's complaint was that we should change constructor (Cache , ExecutorService) not to take ownership of ExecutorService lifecycle and that makes sense. What are your doubts specifically?
Bah, node's path module just does an explicit check for win32: https://github.com/joyent/node/blob/master/lib/path.js#L23
No. Apologies, I meant to get to the ```mpl-data``` directory (the subject of which is in another comment later on).
I think we should probably remove the fonts from this plot. (see other examples in ```test_axes```)
Does this result in the same image in python3?
import matplotlib.collections as mcol
import matplotlib.patches as mpatches
@rintaun - the use of StudyCaps specifically covers how classes are formatted. `SQL` is not StudlyCaps. Yes there are different interpretations of what StudyCaps means but that is why there is an express example to make it clear: `Class names MUST be declared in StudlyCaps.`
I also think context is not within the scope of this interface.
I can do this way. Should we wait another opinion about it?
Thank you very much.
Could also do `(into [1] ....)`
That was my first thought and I have that code. I got an 'as documented' argument from the stakeholders, so I went their way. I don't see the harm in supporting all levels so I will put that back in.
Ahh, this is a merge issue I think. SakaiDocPagePublishOperation did not exist when I created this PR. I'll update that class and add a commit.
My main concern is still this full distance matrix. My suggestion is to add embed_distance(CDistance*) method and handle 'to compute' case with CustomDistance. Something like that: https://github.com/lisitsyn/shogun/blob/libedrt/src/shogun/converter/DiffusionMaps.cpp
Can you please set the message back to `Incorrect number of arguments passed to filter()`? This is something I changed earlier, don't want it to be overridden. ;-)
typo - interacting
Mostly to not convolute the logic (active? also does this).
We decided that as long as collecting is off, alternatives are always shown and no data is recorded.
Michael, the good news is I've pushed the changes to:

Delete conn->sessions (rename conn->session_array to be
conn->sessions), but we now access the array of session handles directly.
 This means we can no longer use the NULL vs. non-NULL test to know if a
session handle is active, add an active field that's non-zero if the
session handle is in use.

Stop shuffling the session array elements to keep them tightly
packed: allocate the lowest available slot we when allocating a new
session, decrement conn->session_cnt to the largest active slot when we
close a session.

The only thing that's a little surprising is the use of
WT_SESSION_IMPL->active to flag a session that's in use -- I futzed with
using WT_SESSION_IMPL->iface.connection, but that got ugly fast, so I just
added the active field.

I think this branch is ready to be merged whenever you're ready to merge
it.  (The changes are  mostly orthogonal to earlier changes in the branch
-- if you want, I could delete the max-sessions branch, and then re-apply
the last set of changes to a develop branch for a fresh diff, but I don't
see any reason to do that work unless you want to for some reason, and we'd
lose the discussion, I suspect.)

The bad news is the performance win I saw is gone.  No clue how or why -- I
stepped through the commits one-by-one, and couldn't find it again.  So, I
guess we have a cleanup that's worth having, but we're back to square one
on speeding up tcbench against the WT 1.0 release.

--keith

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Keith Bostic
keith.bostic@wiredtiger.com
這個好方便XD
done
Why are margin and padding !important? Can you add it into the comments?
`.length` is never negative, so comparison is unnecessary.
Ah, at first it was about better minification #80, but that changed to #81. So basically it's about reducing scope lookups as well as having a robust undefined value.
Yes, you're right, sorry forget the `_configure` overriding. All of that should be handled by `initialize` which would be passed `options`. But what this change would do is not have the leftover `this.options` set on the View that is no longer relevant. `initialize` could set `this.options` if it wanted to, or it could do more complicated things.
Nit: I think this is a bit confusing, and perhaps is not that important right now, but  using req.session.nickname as the property name and then having a channel name property inside make sit seem like the nickname prop should be 'user' or something like that.
this should be internal instead of public
HTML comments are often avoided.

- _Compatibility:_ Some older browsers don't like them.
- _Performance:_ You're including bytes that you're not using.

Prefered: Use your preprocessor to comment. Comments won't be in the source code of what you're doing but they will be in the jekyll source code
```
{% comment %} Now this is a single-line comment {% endcomment %}
```
This could be a bit misleading, the transform published is not the current estimate of the robot pose, but the correction to the odometry estimate.
It is clear to anybody already used to those specificity but it wouldn't arm to make it explicit.
No empty lines around, indent.
I did check and they use male and female.

But when user registers with facebook, gender is already set so all users get the default value of female and they have no way of reverting it.

For connecting exsiting users with facebook acount we shouldn't use registration I think but just get the facebook link and token and things like that, that enable user to login with facebook.
Move this import to the top: we group imports by package and sort them alphabetically.
http://docs.celeryproject.org/en/latest/userguide/canvas.html#groups
No, I mean here. So you register listener for click events, what does the function all get? Only event object? Or something else too?
No, we are not throwing exceptions here, but should use `error` argument. We should probably change that argument so that it takes string as an argument and constructs an error out of it.
It suddenly works now and I have no idea why? But it works. :)
If you have not deleted PiplMesh database, I recommend that you do that. We have in last month migrated to offset-aware datetimes. It might be that you have offset-naive stored in the database.
`$.getJSON`? http://api.jquery.com/jQuery.getJSON/
Do you think we could get rid of these logging calls? Or if we want to keep them add some explanatory text so it can be made sense of in the log file
should I replace '_parent' with just target then?
yep, there is one above for US that tests it includes it
Is not an array, was converted to Position struct
evtl. Zeilen zusammenfassen:

    ClientResourceFactory.getClientResource(Res.getURI(Res.BEER_COLLECTION));
if you can't explain it, don't use it.  This is not required css. Please remove
So, 9 weapon, total? Is there a chance that he _wouldn't_ save this for the end-game?
added in pf::SNMP::constants
I don't think we need this entire paragraph at all.
OK.

Is this a good idea in the first place? I'm doing it because we can catch a class cast exception early on this way, right in the constructor, (so right in the grunt shell before anything happens) instead of during the MR execution.
This should sourceConfInit()?
Been starting at this a bit longer.  I don't understand right now when and how you'd set the useShards and useChunks flag, but it appears that we're assuming useShards is true here regardless of flag value.    Maybe I could use an explanation of what these flags are and how they're set.
Ok let's take the most common use case: I want to run circushttpd with the defaults.

With the config file:

``config
[circus]
...
httpd = 1
```

and in the API 

```python

Arbiter(..., httpd=1)
```
Initiates is probably the correct term here - the call's async, so it doesn't actually update the status, it just kicks off the process.
I'd indent this.
No need for `typeof` here. And if that disappears, maybe we can check against `null` (to catch that too if needed):
```javascript
if (this.map[key] == null)
```
It's obviously missing a `id_or_ur = url;` at the end of the `if (url)`
Don't we need to skip writing manifest if we actually decide to skip uploading the file?
EmptyLinesOverflow!
uniform_deviate is used a few other places, so I changed this to use it too.
You're right.  My mistake!
consider making stdout or stderr explicit rather than just printing
Seems strange to take a Function rather than a Predicate when matching a given criteria.
Agree could do with some refactoring. It's quite confusing with the poll code here. But very happy for that to be deferred to a completely different pull request.
IATFolder already extends the IATUnifiedFolder on Plone 4 (so make it explicit is not useful). The IOrderable interface... seems not used anywhere in Plone also.
These comments obviously don't belong here, and even if they did they should be formatted as `line_of == code # comment` (This is just criticism of myself).
두 개의 테마를 이야기하는 것이기 때문에 알기 쉽게 홀로 라이트와 홀로 다크의 탐색바 정도로 바꾸겠습니다. :)
No doc comment on return value. What does that bool mean?
The `related_name` here looks wrong?
Yeah, I think catching a `NoMethodError` is fine.  That way, if we don't have to maintain a list of methods this depends on.  I think it'd be nice for the failure message to say something like `expected #{object} to be array-like, but it did not respond to #{no_method_error.name}`.
Why are we requiring this here and again in io monkey?
no need to make it virtual, it should be private as well
probably best VAPP and VAPP_TEMPLATE
Will fix.  I just didn't see the reference when I researched originally.
Since you don't treat the different exception types specially when re-throwing, you can probably simplify this and just keep a list of thrown exceptions, then re-throw the exception at the head of the list if present.
It doesn't have to.
80 column rule: Codes must not exceed 80 columns in width.

-- Amin



On Sat, Mar 3, 2012 at 4:55 PM, Geoffrey Parker <
reply@reply.github.com
> wrote:

> >      this.username = username;
> >      Skins.setSkin(this,"DEFAULT");//set skin as default skin
> >      // this.education = new ArrayList<Enrollment>();
> >    }
> >
> > -  public static User connect(String email, String password) {
> > -    return find("byEmailAndPassword", email, password).first();
> > +  public static User connect(String login, String password) {
>
> 80 columns rule?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/w7cook/OpenBook/pull/20/files#r515119
>
include_mini should also prepare a $request variable so you can do $request->get('comp_id'); :)
А затем, что у меня Vim собран с питоном, но без перла. Да и с перлом в Винде тяжко, а работать на ней иногда приходится.
this is not a parser wrapper. It is the actual parser (the wrapper is the service ``markdown.parser.sundown``)
Please wrap the text here.
Just uses a convention for locating the analysis cache. So given `target/classes` the cache file is `target/cache/classes`.
very reasonable concern
Зачем System.exit(0), когда приложение и так завершится?
Не знаю, почему-то когда я писал это, это казалось чертовски логичным
Это лишний if. Правильнее сделать компаратор для compareTo(), и использовать экземпляр компаратора уже в зависимости от флага ignoreCase.
Принято степень двойки использовать.
@yuhunglin and the reason for this is that otherwise calcentral is undefined (namespace issue)? Originally we were loading the controllers and other files first.
That's pretty :)
Can you avoid this loop by targetting the app by the name that is passed in?

Something like `account_history_page.purchased_apps('app_name').click_request_support()`

Look to the other projects where we have done similar.
you can combine these lines into "return self.find_element(*self._menu_items_locator).is_displayed()"
because the common case involves _index, _type, _id. elasticsearch supports more meta fields. but it is cumbersome to type:
```php
<?php
$es->index($doc, array("_index"=>"blah", "_type"=>"bloh", "_id"="bluh"));
```
at least for me... i can change it to just $doc and $meta if you like... (or we could just ignore other metafields)
I'm not suggesting we cover every possibility. Maybe I should have said what I like about this …. we don't have to worry about updating the helper when we change thincloud-test.
Since they're both being directly replaced right now in the populate method (e.g. `controller.set('content', data['objects'])`), they should both be null. I'll update the code. Thanks.
This link doesn't show up correctly.
You could even use this (that's what I meant saying that regex values are already extractors):

````Scala
for (line <- lines) line match {
  case offsetExtractor(offset) =>
  case _ =>
}
````
(just nitpicking) :+1:
Also add to ``bento.info``.
I wonedr if ``tv_denoise`` decreases the range?  We might want to adjust for that.
dgemm is not in the shipped cblas 

we'll need @fabianp one more time for windows :)
The docstring (``out``) is not consistent with the variable name effective ``pred``. If would rename ``pred`` to ``out`` or ``cumulated_pred``.
> Why the change? You don't want to cater to <9 features any more?

I had the same though and decided not to nitpick, but I actually agree
with @amueller
On 10/09/2012 07:19, serge-sans-paille wrote:
>
> In pythran/pythonic++/core/set.h:
>
> > +			return (this->difference(other)).union_(tmp.difference(*this));
> > +		}
> > +
> > +		template<typename U> 
> > +		void symmetric_difference_update(U const& other) {
> > +			*this=symmetric_difference(other);
> > +		}
> > +
> > +		template<class U>
> > +		void print_debug(set<U> const& s)const{
> > +			//Debug fct
> > +			std::cerr<< "Debug : " ;
> > +			for(typename set<U>::iterator it=s.begin(); it!=s.end(); ++it)
> > +				std::cerr << *it << " ";
> > +			std::cerr<<std::endl;
> > +		}
>
> If this is really debug code, I would avoid it in the trunk
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/serge-sans-paille/pythran/pull/12/files#r1563242>.
>
But but, it's a nice piece of debug code :(
Isn't change already supported by BB?
We also need to make sure this gets run in the proper context.
Also need to throw an exception if `offset < 0`
No, for sure not to be handled in this PR, but still to be handled somewhen... Will open an issue.
I ll look after a full migration to radians for internal storage to avoid many call to Math.toRadians which is costly
Hm, I did add a hint for start, I seem to have lost it.

In the absence of a hint, for fixes records with a min and max # of buckets, basing on total num rows, I still think it might be worth estimating.
NB: getLogs fix = gh-2583
Oh, great spot!
комменти до змінних
s/autload/autoload/
"бас нэг хувилбар" эсвэл "өөр нэг хувилбар" гэвэл илүү оновчтой
Hm. So from what @ZER0 said, it sounds like I should definitely scrap this tutorial, actually. Since it doesn't respect that guideline. I'd like to suggest, instead, to raise another bug where I'll think of (or steal :) an example which uses HTML content in the widget, but not in this way. @Gozala, @ochameau, what do you think?
Personal preference really. I prefer the readability of this since its really easy to miss the `||` on the line when skimming over
Same as with the collection,
only that I know that here the 'photos' model does the fetching and assigning and this 'photo' model just represents a single instance
Non parce que le bloc qui contient le texte a une largeur fixe en fonction de la taille de l'écran, ce qui fait qu'il ne passera pas en dessous.
Err yes, I should not have that commented code in there.
Ditto here, due to serialization and deserialization, any manual edits of the token fields will likely result in garbage out during decryption
@shacker We shouldn't initialize arrays like this, can we use the following syntax instead:

```javascript
var weekdays = [];
```

It's probably also good to just add the weekdays in there already:

``` javascript
var weekdays = ['Sun', 'Mon', 'Tue', 'Wed', 'Thu', 'Fri', 'Sat'];
```
Indentation throughout below.
I talk about the `field` method...
Could you please use a longer, more descriptive name than just `m` for this local?
Wrap text at 78, add a one-line short description.
It might be clearer if this was "(row, col) vertices of polygon." or "(row, col) coordinates of polygon vertices."
Should de-proxify these (although I don't know if GMU has access)
这个也是plugin扫语法扫出来的。可能那个是针对浏览器环境的。因为我没在本地大环境跑，所以没注意到node不支持Integer
What ruby version are you using?

On Sat, Mar 3, 2012 at 12:30 PM, Scott Hyndman
<reply@reply.github.com>
wrote:
>> @@ -299,8 +299,7 @@ def call(method,args,requires_auth=false)
>>        if Rdio::log_posts
>>          Rdio::log "Post to url=#{url} method=#{method} args=#{args}"
>>        end
>> -      resp,data = access_token(requires_auth).post url,new_args
>
> Hm...this one was giving me problems. I'll take another look.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/spudtrooper/rdiorb/pull/7/files#r514844



-- 
Jeffrey Palm --> http://jeffpalm.com
Are we sure this should be `@private`?  I thought this type exists just for doc?
Iterating properties of an object in general is relatively slow.  It might be worthwhile to maintain a hash and an array, one for lookups, one for iteration.
Sorry, you're right, just `return`.
Nope, that was all me.  Thanks.
Are `_up` and `_upWC` supposed to be the same instance, or is this a bug waiting to happen?
I assumed that the multitouch gesture `scale`, which corresponds to Titanium's `pinch`, should have highest priority when determining how to process events as it is the only multitouch gesture and is then inherently more complex than all single touch gestures and events.
since 2.1.0
We need to track down why this is returning zero.
Just returning here still causes the issue. The socket/input stream
might be in a bad state.
Для большей читаемости.
```javascript
if (typeof gps !== "undefined"  && 
    typeof gps.x !== "undefined" && 
    typeof gps.y !== "undefined" && 
    typeof name === "string") {

    // your stuff
}
```
imports and blank lines
Lets remove the throws from the sample Trigger
Nice! Did you just read that comment on the post on Planet Drupal too? :)
What are you trying to say? Drop the empty line between the imports and the `from`? Or put the two `build_log` imports on separate lines?
I think this should be assumed as 0 because if a script hasn't made it to its v1 phase this could cause issues
I know basically its the same think but we should use the suggested locator  it's stronger this way
Mistake, I think I pasted it from another part of the file, will fix. :)
here we should use auto ref for inputs and outputs
Hrm, well it is but it's rather odd. How about:

    for (size_t len = src.length; len-- > 0; )
Based on the current compiler's implementation, some hacky code might work for the nested class.
(This is rough code, and does not consider filed alignments).
```d
class C {
    int x;
    class D { int y; }
}
void main() {
    pragma(msg, "end = ", C.tupleof[$-1].offsetof, ", size = ", __traits(classInstanceSize, C));
    pragma(msg, "end = ", C.D.tupleof[$-1].offsetof, ", size = ", __traits(classInstanceSize, C.D));
}
```
This doesn't render properly. It's missing the ending underscore, :-)
_NOTE: To fire the update audit, you must change one of the contact fields_
Error投げるとfluentdとまりますよね? 止まったほうがいいのかなー
`final` and don't assign `null`. You always return in the `catch` block, so the compiler can guarantee assignment.
I don't think we can override if it's static.  Am I right?
you can remove groupId and version if its the same as the parent
this seems redundant, get_version seems to return "" on failure
Is it really needed to update the parent?
You've quoted a string, that is surrounded in a heredoc - so when it fails you get strange errors like:

    err: Failed to apply catalog: Parameter set_mark failed: Munging failed for value "0x1/-1" in class set_mark:               "MARK value and mask must be integer or hex between 0 and 0xffffffff"

There are 2 other cases of this in this file.
само уничтожится как child
Beautiful, I love it.
Or does OSX fall under Posix? I never know if these two can be equal or not. Anyway it's strange since the static assert was not present before.
date filter submit
@surangak said only preferred
Hi, Gunnar
`IntegrationNamespaceUtils.createElementDescription(element)` may be extracted as variable. 
And how about to refactor those all only to one `parserContext.getReaderContext().error` call?
And also: can you, please, explain why didn't you follow with my recommendations on your previous commit?
By the way: 'outbound-channel-adapter' can be used withing the chain too. But these tags may have 'channel' attribute. Right now this issue is covered by `AbstractOutboundChannelAdapterParser#doParse()`. 
IMHO: parsers should also follow with consistency principle.
I don't understand this logic - the root context initializes first, and then child contexts. Shouldn't we be checking for the event's context being the current application context (via ApplicationContext aware). ??
same comment as above: there are more valid chars for JMS property names (refer to the JMS spec)
Move format part inside the createOrUpdate and pass the object.
I'm merging locally then
yup, copy and paste boo boo
Typo - dashboard_config
Maybe add a note in the form or something so people don't forget that this isn't escaped?
Don't you need to capture a weak reference to self to avoid a strong reference cycle? See details at https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html#//apple_ref/doc/uid/TP40011210-CH8-SW16
Ups - i see i missed this point, this is umbraco only :(

Making another pull request, when its have been removed
once you have the patient identifier added to the patient, you will need to save the patient so it can be seen by the rule.
Why is innerRings passed by reference?  The only need to do that if the method assigns a new instance to the innerRings reference, which I don't see it doing.  Also, nested generics like this (List<List<Cartographic>>) are best avoided, if possible.  Is there another way this could be represented?
Is it worth mention the eclipse project or classpath files here? Or should things just work?
Remove that comment too
The `unicode()` should not be necessary, otherwise this is a potential bug.
yeah, seems so.
I don't mind fixing this up but I'm not sure how to get a reference to these "different configs" your speaking of.
este hardcodeo hay que sacarlo.
Who the hell is galactica-mac?
This should be replaced with filter() (rather than where) which does the escaping for you
/me stupid. Note to self: never review code before coffee.