labofsahil/github-event-dataset-2012 huggingface dataset:
Couldn't you chain this? `$('#help-form').unbind('submit').trigger('submit');`

For that matter, couldn't you just not user preventDefault above? If the form submits to the server, you'd have to perform this in the success callback for the post to ensure it hits the reps server before refreshing the page, and if it doesn't, you can just remove preventDefault above and have the form's normal submit event fire after this runs.
So... if we're explicitly creating a forum, it's easier to read this if it explicitly created a forum rather than implicitly create one. e.g.:

    old_forum = forum(save=True)
    t1 = thread(forum=old_forum, save=True)
    ...
+1 spell check :p
Because clearly I was an ass an forgot this myself, can you add `app_version = '1.0'` for me? You know, whilst you're at it.
It would be good to log something here. Not the whole traceback, maybe just the exception message. We will need to put this back soon but it will not be the InappPayment table, it will be something retrieved from webpay.
A previous pull note suggested using numeric constants. 
Since this has indeed gotten nuts, will redo these as simple constant values.
Can we update this documentation comment to make it clear that this feature is experimental, and what the intent of putting this out is?

Something like: "The server supports streaming results, resulting in better performance and lower memory overhead. For you as a user, there should not be a difference in how the API behaves when using streaming, your HTTP client should hide the details from you. This feature is still experimental, but the goal is to make streaming the default mode in subsequent releases."
for consistency's sake, we should use jquery here...or alternatively use function($) {}(jQuery) as a closure around the entire file and switch everything to $
Sigh... Poor alphabet...
Also thinking `utils` might be a bit broad. We should think more about the namespacing.
This was copied from the interface
Should be `null !== $this->getDefaultcommandName()`
```php
if (!empty($servs)) {
    $services = call_user_fun_array('array_merge', $servs);
}
```
I would throw an `InvalidArgumentExcption` in `setCallbacks`
I don't like it either, but the above solution doesn't test the bug that was fixed. If I revert the changes in HttpDechunker, the current test fails. However, your suggested test passes in either case.

The issue isn't that the EOF is sent to `error` before the last message is *sent* to `messages`, it's that it's sent before the last message is *received and synced* from `messages`. Thus, selecting between `messages` and `error` will most often select `messages` first. What we want to ensure is that EOF is not sent to `error` until the last message in `messages` has been synced.

We can verify whether the dechunker has sent the second message to `messages`, but we can't verify whether it's quiescent, or getting ready to immediately send EOF to `error`. The 1-second wait verifies to a high degree of certainty (absent a huge GC pause) that the dechunker is, in fact, waiting to send EOF until after the last message is synced.

If you're opposed to this solution, the only real alternative I can think of is unit-testing `HttpDechunker` without IO or an executor. If we remove threads from the equation, we can be sure that all side-effects from sending a message have occurred when we send the original message. Would you like me to write this test? Or do you have any other suggestions?
Since the initial build of the forwardingTree is implemented inside the RoutingState class, this update logic should probably be in there as well for symmetry.
This is...an odd test, based on the description (though I think I wrote it!).

It looks like you're changing the behavior from testing a suggestion with an in-memory, unpersisted vote (the `.votes.build`) line to basically testing `Suggestion.new.votes.should == 0`. For a faster test, how about:

```ruby
suggestion_with_unpersisted_vote = Suggestion.new
suggestion_with_unpersisted_vote.votes.build
suggestion_with_unpersisted_vote.vote_count.should == 0
```
I used it based on this answer http://stackoverflow.com/a/4686608/656507 but I guess it's not necessary as the `in` operator already returns a boolean.
Indfiferent access call hanging around.
The 1000 is probably ok, but my guess is that the `A>0` is superceeded by safe_sqrt checking for 0.
> Seems strange...

Indeed. It looks a bit like a square peg has been driven into a round hole. Supplying the `proj4_params` argument completely circumvents the definition of the Geodetic class! One could now do: `crs = Geodetic({'proj': 'tmerc', ...})` and end up with a "geodetic" CRS which is actually a transverse Mercator!

The way to avoid this would be to allow only the parameters relevant to the rotated geodetic, e.g.:

    class Geodetic
        def __init__(self, pole_longitude, pole_latitude, ellipse, datum)

But now the Geodetic class looks just like the RotatedGeodetic class! Which highlights the need for either:
 1. Make Geodetic a subclass of RotatedGeodetic.
 2. **Get rid of the inheritance between Geodetic and RotatedGeodetic.**

Out of those two I'd rather have option (2). It gives us what we need with the minimum of complexity.
Maybe add something about this being a sasl or kerberos connection to the log message
Yep my mistake
You gotta remove this line to :)
Would it? The public list can only be changed when a cert is made public/hidden or removed? What situation would it be out of date?
I don't see where could be a problem and people can disable it if they want to keep dev/preprod controllers in prod.
likewise, video/flv is missing from the new list
This isn't actually in the 1.2 schema, correct?
Same as KEYSTORE_PROVIDER
There is no link in your comment. Could you create a ticket and link to whatever is available? http://bugs.jqueryui.com/newticket
Just declare this directly on the prototype instead of creating it in `_create()`.
хм, есть вариант с url http://static.springsource.org/spring-security/site/docs/3.1.x/reference/taglibs.html

`<sec:authorize url="/admin">`

> If the user is allowed to invoke that URL, then the tag body will be evaluated, otherwise it will be skipped.
`fail('blob is too shorter than the given length.');`

I wonder if whether we really need to throw error in this case or not. Will this cause `blob.slice()` to throw? Can we instead safely handle this case and return a shorter array buffer? I suspect this check will be triggered very often at runtime and we will have fun time debugging.
nit: add a space between contacts and the {
Well not so much a description but like an indicator that the bellow content belongs to it.
Thinking out loud maybe:

```html
<dl>
  <dt>My title</dt>
  <dd>
    <ul>
      <li>
        <p>My item content</p>
     </li>
      <li>
        <p>My item content</p>
     </li>
    </ul>
  </dd>
</dl>
```

But this structure will not work with non-title cases
`function timeout() {`
This isnt your bug, but we should probably fix this at the same time, s/tabId/tabname
Those objects are "mocked" I could use public properties on the mocks since they won't be used outside of tests.
Same doubt as in threads... This question should be here as in Wireframes? or when clicking 'Done' button?
ouch! is it possible to calculate this dynamically? I am sure someone will change the css and forget to alter it in the JS.
Need to get rid of code duplication here. This should be a wrapper around result(String, ByteBuffer)
I'd just change the return value and return from the inner loop:

```ruby
    # Get the pull request number that deals with a given branch
    def self.get_pull_request_number(nwo, branch_name)
      response = get_all_pull_requests(nwo)
      response.each do |pull_request|
        if pull_request["label"] == branch_name
          return pull_request["number"]
        end
      end
      nil
    end
```

Then you can just guard against the nil in the caller:

```ruby
      def self.completed(build)
        if (pr_number = ::Janky::GitHub.get_pull_request_number(build.repo_nwo, build.branch_name))
          if build.green?
            ::Janky::GitHub.comment_on_pull_request(build.repo_nwo, pr_number, ":green_heart:")
          else
            ::Janky::GitHub.comment_on_pull_request(build.repo_nwo, pr_number, ":exclamation:")
          end
        end
      end
```
@richardprice did you fix it so that a null setting doesn't blow up?
This should live in its own Turbolinks module and be included in ActionController on its own. Rather than by reopening Redirecting. Use ActiveSupport::Concern with included do/end to set the alias_method_chain.
I think this unnecessary, it could be done by some configuration. Read more in http://guides.rubyonrails.org/i18n.html .
This does not work on my machine ... and please make it a one-liner :wink:
no longer http
I think actually filtering, as you suggested, is better here.
haha sweet. hmm yeah if there's no id let's just do a `debug('no peer "%s"', id)` and emit an event, not sure what to call that, `this.emit('peer missing', id)` or something
There must be a better way to say this.
Is this spacing correct?
Might be worth validating that params[:target] is a valid redirect target? Just a bit of protection against broken markdown or the like.
Wouldn't status be better for a query?
Oh, right - I was thinking it was particular to this class.  So, yes, these should probably be `mock_logfiles` or the like, and merged in `__init__`.
This is not something that will magically start working when the SUT is updated.  If anything, I'd rather skip impossible tests, rather than mark them TODO.
Does delta ever get set to something other than 0.0?
Yes, you're right. So could you have a try for this?
Well then the proper fix is to also clean up the pretty version using your `parseVersion()` method. The lock file should not display normalized versions.
Yeah, can you integrate it into travis or so?
`isset($defaultOptions['http']['header'])` is enough, no need to check for intermediate keys
shame on me.  will fix it in few minutes.
We have sattelite repo. Maybe we use it instead of patching hook
Is te related to that Rinda::RingFinger bug?
renaming to ..._tilt_link? There is no lower and upper neck
org-mode to markdown again. Fixed.
Now the old valiable name stays with its old behaviour. I renamed the new one and edited the comments.
What is an `entry`?
"into an isolated JS sandbox"
Same here Factory.new no longer exists:
https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/tests/test-xpcom.js#L75-79
Yo dawg, I herd u like data...

Sorry I named this data.

Maybe iadata? or blobs? or ???
Well, since this is an async event callback, on *nix, when the signals are triggered, it will no longer be in this try/catch. The only sync thing here to catch is `process.on`.

There also isn't a decent way to see if the process supports signals. The error thrown isn't even useful ("Module not found", since it's trying to load an internal node signals binary). The only way to detect it earlier would be something like this:

```js
var hasSignals = true;
try {
  function noop() {}
  process.on('SIGINT', noop);
  process.removeListener('SIGINT', noop);
} catch(err) {
  hasSignals = false;
}
Used from `bin/browserid`
i like that you're explicit about the parameters.  in this case, the long arglist is good for making things really clear
Since this is removed because there is no verified or type field, line 794 "emails_to_update" should be removed as well.
no, this pubkey is bogus.  let's remove it...
`configobj.ConfigObj(source)`
I wouldn't shift entries here and test for an empty buffer because this test is about resizing.
Interesting. I was checking it with xhtml strict where it passes. So yeah, we should follow the HTML5 spec. Thanks

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
 <head>
   <title>Test</title>
 </head>
 <body>
   <p>
     <span id="logger" class="disabled" />
   </p>
 </body>
 </html>
for consistency w/ the rest of the codebase change "$1" to '$1'
Gosh, you're right.  Thanks for the note!
@aboe76 Hi Niels, did you really mean to include this file? It this looks like an emacs backup.
Can we copy the file to the temp directory? (currentCase.getTempDirectory())
no chance for NPE on getData()?
Already fixed on 2.2.2-wip. 
Here is the update on this file: https://github.com/twitter/bootstrap/blob/2.2.2-wip/less/tables.less
As for naming, since it's around attribute removal, "ElementAttributeRemovalInterface".
Um, the above two are backwards... shouldn't you call setQuery() in the first, and setPost() in the second?
File commenting
I don't understand it :) How do you run behat 2.4 tests not on CI, but in command line ? `php app/console --env=test behat` or `bin/behat` ?
please use a query parameter, not ``sprintf``
You can't see it in the diff but your TestNew tests have duplicate docstrings.
fixed on next push
IMO, you should keep the common MappingException as previous exception instead of stripping it
not sure if there are valid use cases for removing all locales (the document would still be translateable - we would even end up in a messy state where you can not load the document anymore because odm can't find any translation anymore. i think if you really want to remove several, you can loop over getAvailableTranslations or however we called that method.

i think we have to prevent removing the last locale. you should completely remove the document if you want to get rid of all locales.
Then we can rename `File.write_file` to `File.write`. :)
Besides all the other files seem to have "Easybuild" in their header :-p
Yes, of course.  Amended the patch.
Is there a defined convention for this?

I'm never sure whether to add modelines to other people's project, the heuristic I've been running with is if their project deviates from the standard (3 space indents or something) I add them.
"Add  value for `SECRET_KEY`" could also be in the setup instructions. But running lflux with `SECRET_KEY` = None breaks in a very difficult to debug way.
Same question for:

https://github.com/simplee/tivoka/blob/5a88613d52137021ec0ef8e70fdbc9c2d221251c/lib/Tivoka/Client/BatchRequest.php#L126

I didn't want to break with your code style to maximize the chances of being merged. This means trying to reproduce what I'm seeing in the original code ;)
remove extra space after `function`: `var toSeconds = function( t_in, offset ) {`
Pass expect as second param.
selectヘルパーのoptions_from_collection_for_selectの第一引数にオブジェクトの配列が必要だったので、
options_from_collection_for_select(Munoh.all, , ...) と書かずにコントローラで記述していました。
This looks like an accidental inclusion, could you zap this file please?
о нє. ця стрічка похєрить всі коментарі, бо в нас не такий shortname.
можеш глянути в сорсах який в нас шортнейт
I'd recommend to be more descriptive with the variable names here because $wide_width itself doesn't say much about the value it carries. How about ```$responsive_classic_width``` ?
use a div to have the graphie and paragraph hint(s) at the same time.  Not sure how much I'd break this up
True, the output nodes may not be available, but we certainly know the output path(s) we passed to the sequencer. Isn't that useful information?
Fairly certain you need to sort these somehow descendingly. Otherwise you can't be sure it'll auto-upgrade to the *latest* HMAC key.
сюда можно принимать unique_ptr, тогда комметарий не нужен
This is not used any more in the file.
What about this?

formatted=`cat package.json | python -mjson.tool`
start=`echo $formatted | awk -F"[,:]" '{for(i=1;i<=NF;i++){if($i~/start\042/){print $(i+1)} } }'`

That formats the json and then pulls out the value of the start key
Why is it `my_e`? Should be camelCase, but why not just `event`. It's a reserved word, but It still works, as long as your not calling `function (event) ->`.
Not quite. Here's an example:

IIRC, when I create a group in OAE 1.4, I would type in:

**"This is my group"**

The UI would automatically generate the "short name" of the group for me:

**this-is-my-group**

I would have an "AJAX"-y notification to tell me if this already taken (a red X appears, I think).

I would then have an option to change it to something like:

**this-is-my-super-unique-group-short-name**

Then all would be good and I create the group.

In this example, the consumer of the groups API needs to **specify** the group short name / "id". In the API we have, this is not possible, because we always auto-generate the short-name from the title "This is my group".
Yea that guy came a little later. it's added now.
This isn't really in line with the other models in the other modules
First name and last name-related properties can probably be removed as we no longer have those.
Totally private now.
I wonder if "Filter compiler generated getters" would be a better description.
No no; it might make sense to have such an assertion in other places / entry points in the refactoring library as well. So, how do I check if I'm running on the PC thread?
You are right, nice catch!
wouldn't the correct name be `matchRequestPartially`?!
`strings` does not tell me anything about the content other that I guess it is an array of strings. But if the strings mean something like 'active state info' then I would rename the var
Have to move this out of the request then. Painful but definitely simplifies the pull.
On Feb 23, 2012, at 5:59 PM, Steve Johnson wrote:

>> +           # Don't even bother running the job if the output is already there,
>> +           # since it's costly to spin up instances. Similar logic to checking for presence of input dir.
>> +           # In this case, we check for the absence of the output dir.
>> +           if self.path_exists(self._output_dir) and not self._opts[FORCE_CLEAR_OUTPUT_DIR]:
>> +               raise AssertionError(
>> +                   'Output directory %s already exists, this will cause the job to fail midway!'
>> +                   ' Enable the %s option to force delete output-dir.' % (self._output_dir, FORCE_CLEAR_OUTPUT_DIR))
>> +           if self._opts[FORCE_CLEAR_OUTPUT_DIR]:
>> +            if self.path_exists(self._output_dir):
>> +                self.rm(self._output_dir)
>> +                time.sleep(WAIT_FOR_S3_COMMAND)
>> +            if self.path_exists(self._output_dir):
>> +               raise AssertionError(
>> +                   'Output directory %s already exists, and could not be deleted on a force delete!'
>> +                   % self._output_dir)
>> +
> 
> Ah, I wasn't aware of that exchange. I'm still wary of having it as part of the Pig pull request.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Yelp/mrjob/pull/378/files#r483535
Was dit niet waar thomas mee bezig is? Remove.
Why remove this to just write a longer version of it later?
Тестов было очень мало.. Спешыл. Нужно доделать
... и лучше это делать в цикле do while. ведь мутировать-то надо по-любому. а потом уже проверять.
Лучше так не делать. init - это конструктор по умолчанию, его делают без передаваемых параметров. Его можно реализовать в данном случае для инициализации массива строго из 100 символов, и сделать дополнительный конструктор на подобии такого:

-(id) initWithCapacity: (int)capacity;
Насчет методов с одним именем двух разных классов всё, конечно, было понятно.
Замечание было о другом: когда видишь в коде такие вызовы, не сразу ясно, из какого класса метод. Даже несмотря на то, что имена экземпляров намекают.

Насчет повторения результатов - полностью согласен. Погорячился.

Вопрос: а вот где-таки изменяет функция [cell mutate] исходный массив, который хранится в Cell?

Насколько я понял из документации, arrayWithArray копирует массив, и оставляет исходный в стороне.
И [gene mutate] вызывается для элементов именно копии, а не исходного массива.
@idemidovich вот нужно было дочистить зубы да еще и попробовать :smile: 
а вообще, ваше утверждение относительно длительности - риторический вопрос. Я скорее бы сказал, что этот метод не оптимальный нежели "медленный". 

Почему?
1.Во-первых, с чем вы сравниваете эту медленность?
2.Во-вторых, метод создает масив из 100 элементов при верхней границе 100 за ~ 0.0003 сек = 0.3 милисекунды. Ужас как долго :scream: 
3.В-третьих, мы здесь решаем задачу в определенном контексте, по этому на оптимальность и оптимизацию мы вообще не смотрим. "преждевременная оптимизация - корень всех бед" (с) Кнут.

А вот если писать такой метод для какой-нибудь оперсорс библиотеки - тогда добро пожаловать в алгоритмы, но об этом уже не сегодня и не сейчас :smile: 

Спасибо, вам за комментарии.
Понял. Спасибо!
все дальнейшие действия должны происходить в блоке if (self) { ... }
Can you pull out the `queue` ternary expression onto its own line? This line is already pretty long.
You could flip the memory management around.
Have the scheduler create the dispatch queue lazily when a block is scheduled and keep a reference to it without retaining it. The block will retain the dispatch queue while it's queued, and while it executes. As soon as the block is done executing, the dispatch queue is released. Register a cleanup function with `dispatch_set_finalizer_f` to clear the reference to it in the scheduler.
This allows you to have the dispatch queue retain the scheduler and avoid this problem.

A big drop in performance with all the creating new dispatch queues though, might not be worth it.
Not sure if this is meant to be private or not, but its header visibility needs to be fixed either way.
:+1: Good points.
Pronto. Finalizei o código até nesta linha.
All changes above this comment are just trimming whitespace from line endings and can be ignored.
no don't write it.
pep 257 says

Docstring should be a short one line and then a longer description if needed. So

```
"""Write a triangular Freesurfer surface mesh

It is the same data format  as returned by read_surface.

Parameters
----------------

etc.
```
Try to mimic the flow from the `_getAccessToken`method.

Make sure to parse the response and assign the returned access token.

```php
<?php
$options = array(
    CURLOPT_POST => true, 
    CURLOPT_POSTFIELDS => $postData
);
$response = json_decode($this->_request($this->getAccessTokenUrl(), $options), true);

if (array_key_exists('access_token', $response)) {
    $this->_accessToken = $response['access_token'];

    return $response;
} else {
    return false;
}

```
Is this FieldBridge necessary? If you are just calling toString(), i thought this is what lucene does by default
I think this is already executed in the right context, I think this is where the the apply function is eventually invoked:

https://github.com/playframework/Play20/blob/master/framework/src/play/src/main/scala/play/core/server/netty/PlayDefaultUpstreamHandler.scala#L331

But I'll write a test to confirm.
It does work for me.  I haven't had time to look deeper into it yet.  I will let you know.  Thanks.
This should be:

    /* encoders */
    $encoderFactory = new EncoderFactory(...);
Seriously, it overloads the / operator? Did the creators of the module
consider just how silly of an idea that is? That's something that Ruby
would do. Anyway, that wasn't the crux of the problem, I just changed it
because it was throwing errors when I did static analysis of the code.

I'll update the pull request tomorrow.

On Dec 6, 2012, at 6:48 PM, Tyler Butler <notifications@github.com> wrote:

In engineer/engine.py:

> @@ -354,7 +356,7 @@ def serve_static(filepath):
>                  return bottle.HTTPResponse(status=404)
>          response = bottle.static_file(filepath, root=settings.OUTPUT_DIR)
>          if type(response) is bottle.HTTPError:
> -            return bottle.static_file(path(filepath) / 'index.html',
> +            return bottle.static_file(os.path.join(path(filepath),'index.html'),

This shouldn't be necessary. Engineer includes a dependency on the
path.py<http://pypi.python.org/pypi/path.py/2.4.1>module which wraps
the os.path module in some syntactic sugar, including
overloading the / operator. Since most, if not all, path-handling code in
Engineer uses that module, I'd prefer to stay consistent.

—
Reply to this email directly or view it on
GitHub<https://github.com/tylerbutler/engineer/pull/39/files#r2343307>.
What about using keyword arguments?

```scala
StockDirectory(
  ...
  symbol = "QQQ     ",
  ...
),
```

It could make this a bit more readable.
Can you remove this ?

It's a test for overriding config (in the configuration file) by args from cli, so passing an object is not possible, it can be only string.
Anyway, we don't need to be passing proxy configuration from cli.
Intentional -> when you want to execute multiple dangerous statements at all cost.
small change
```
diff --git a/nipype/interfaces/nipy/preprocess.py b/nipype/interfaces/nipy/preprocess.py
index 9f11749..5ee169d 100644
--- a/nipype/interfaces/nipy/preprocess.py
+++ b/nipype/interfaces/nipy/preprocess.py
@@ -147,10 +147,9 @@ class FmriRealign4d(BaseInterface):
             motion = R._transforms[j]
             #output a .par file that looks like fsl.mcflirt's .par file
             for i, mo in enumerate(motion):
-                string = str(mo.rotation[0]) + "  " + str(mo.rotation[1])
-                + "  " + str(mo.rotation[2]) + "  " + str(mo.translation[0])
-                + "  " + str(mo.translation[1]) + "  " + str(mo.translation[2])
-                + "  \n"
+                params = ['%.10f' % item for item in np.hstack((mo.rotation,
+                                                                mo.translation))]
+                string = ' '.join(params) + '\n'
                 mfile.write(string)
             mfile.close()

```
Чтобы избежать копирования.
Лочить, если я правильно понял смысл функции, нужно перед самым первым запросом же.
//TODO quitar los estilos inline.
Finally, I would choose retrieveAssertion as a method name, but I'm not deeply tied to this...
I don't really understand this change.  if changeset-type is "deletion" then nothing gets added?  I would think it should be the same whether it's a promotion or deletion.  In other words, this function shouldn't change at all?
This was in a bin folder... see the entry on .gitignore for why this is being 'deleted'.
我觉得这里的intval 应该换成is_numberic($value) 放在if 条件里。
We could just load the remote module from the config file like we do with the db api. Technically this is almost the same, but I chose to do it this way so the test code being imported looks like a special case, and maintainers see the real code first. It looks like everyone disagrees on that though so I'll change it.

There's some other ways to do this as well which I would ultimately like to discuss, but I didn't want to go overboard with this PR and change too much code. In particular, I think importing stuff dynamically while a module is being parsed for the first time should generally be avoided if possible since we've had import errors in the db api stuff result from not putting imports in the right order. However fixing this requires changing the code a bit more ... it'd probably be easier to talk about in person.
Fair point. You should add a comment line with that information though to avoid people modifying the pattern in place.
@mdboom (or anyone else who has previously worked on this): I have put in a fix to what I think was a problem, but am not confident that it is the right thing to do. Would you mind having a quick look.
In mpl, we use None as synonymous with default (typically from an rcparam).  I would get rid of the use of 'neither' and stick with None.  Also, in documentation, surround None with asterisks.
Actually, I think this was supposed to be "pprinted" as in "import pprint".
I followed the coding standards of "Routes" 
look ==> http://routes.readthedocs.org/en/latest/
You should also add the product 'WebappRuntime' to _expected_products_camino_removed and to _expected_products , because this is a valid product with a valid page.
I think this file doesn't/shouldn't exist anymore
You need to configure your editor to use tabs as 4 spaces so your code will line up with the rest
@christianv I'm not sure, .offset().top returns a different value in IE8 than the other browsers do so I think this is the easiest way to fix the problem. The dashboard widget does something similar.
Missing `@param` here.
What the difference between this file and edit_questionSet.jsp?
o que comentei acima sobre o models esta assim: https://gist.github.com/3897059 já pensando em adicionar um "manager/adapter" para manipular o cache local (estou pensando em Redis, o que me diz?)

mas para gerar o feed corretamente vamos precisar dar uma atenção maior as fixtures e já definir como será gerado as demais tags
could you put all the code into a method. Otherwise, shogun with trace-mallocs will complain about unfreed memory in the matrices
I would rather do this locally
a record's, instead of a records
Lint says cast WT_ATOMIC_CAS to (void).
Both ways seem kludgy to me, but I don't know of anything better in Javascript.  I'll make the change.
I see your point.
I'm not familiar enough with the router to work out how to do this conditionally.
Are you sure ``'getEventManager'`` has the correct type as ``string`` is not a sub-type of ``object<PHPUnit_Framework_Constraint>|string``?
Its not really PD specific, maybe call it addWidgetKV for key value?
Do you mean non-alpha chars?
Tässä `count` välttämiseksi voisit käyttää `my-some` funktiota:
~~~clojure
(not (my-some (complement pred) a-seq))
~~~
Basically if you are truncating to one character when you have a string longer than one character you have some problems no matter what because we requre a ... to indicate the truncation, but in this case we are just saying look you have html here and you only want one character, we're just going to call that truncated totally and be done.   The real problem is if you just truncate to a <.  You could make an argument that if someone starts of with an <img src="myimage.ng"> and they truncate to one character (which becomes ...) that we should include all of the html. We could do it but it seems extremely edge case.
Tens toda a razão, eu não reparei quando escrevi, só depois de voltar a olhar. Sorry.
actually I'm considering moving that logic inside the get and set. Just haven't gotten to it
Any reason you're not just throwing me ?
Clarify that this is pay rate per hour (which you did above).
Rewrite the render method so it can take an array of variables as an argument.
Hmm. This is a bit tricky here. `obj_create` is called somewhere in the middle of the request handling. This can have two problems:
 * if request fails afterwards from any reason, all clients were already notified about new post
 * author of the post will get push before the post request will finish, data will be transmitted twice

The second one is not really so big problem, anyway data is already there, client code should just check everytime that post is known and ignore if yes (because anyway there is a chance of duplicate push requests for the same post, by the nature how our push mechanism works).

But the first is not so simple. One solution would be to hook into `post_list`. This would also have a benefit of having JSON output available directly from the response. So you would in some way simply multicast the same response author is getting to everybody else.
Fix this indentation, if you are already around. ;-)
I had troubles of getting atributes from this class so I just crated new class ErrorMessages (now Mixin) and put all the messages there. I think its better that we have all messages in one class, so if changes are in need, we dont have to jump arround in code.
The thing is, *clean* methods are called only if there was no error until now, so `cleaned_data` always contain data for the given field (but not necessary others, so this is why in `clean_password2` we use `get`). So here you can use:

```
username = self.cleaned_data['username']
```

And be sure everything is OK.
I would just do:

```
if (($('#id_email').val()) {
...
```

No trimming, because we are not do any trimming on Python side.
Yes, but there is one space too much in href. But yes, something like this.
(Again, nodewatcher is not good source here. We are using one library there which does not pass everything necessary to template context, so it is not possible to do it properly. But here we can do it properly.)
... actually reset it rather here because `if (save_sources) Pkg::SourceSaveAll();` is not only once in the file.
Lion and newer have the latest version of cairo, so this dep should probably have an `unless MacOS.lion?`
Please move this line up one (above the @helper.add_field).  Right now, it looks like you're expecting add_field to truncate the original "description" variable, but #truncate is non-modifying.
space after each operand
This is based off the code in PhoneApp, which checks before releasing but
doesn't before making multiple acquires.

The docs on acquire() don't refer to a count, and WiFi locks can be either
reference counted or not.  If you're right that they are ref counted then
this would be broken - I'll double check, but I -think- my test cases would
have exercised that bug.
On Nov 1, 2012 2:21 PM, "Moxie Marlinspike" <notifications@github.com>
wrote:

> In src/org/thoughtcrime/redphone/call/LockManager.java:
>
> > +      case INTERACTIVE:
> > +        setLockState(LockState.FULL);
> > +        disableKeyguard();
> > +        break;
> > +      case IN_CALL:
> > +        //TODO(Stuart Anderson): Use proximity wake mode during calls.
> > +        setLockState(LockState.PARTIAL);
> > +        disableKeyguard();
> > +        break;
> > +    }
> > +  }
> > +
> > +  private void setLockState(LockState newState) {
> > +    Log.d("LockManager", "Entering Lock State: " + newState);
> > +    switch(newState) {
> > +      case FULL:
>
> Wakelocks are reference counted, but the calls to the LockManager appear
> to be framed as idempotent. If so, shouldn't all attempts to acquire a lock
> first check to make sure it isn't already acquired?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WhisperSystems/RedPhone/pull/45/files#r2010440>.
>
>
sorry, forget it as it is the type, not the tag name
What if a user adds this option within key arguments string?

The ctor should accept three strings and parse non key/value related options from the third option.
Add testReadUnsetKeyValue
Also please use a namespaced value ("elephantbird.jsonloader.nestedok" ?)

Also please pull it up into a static final constant rather than using string literals, and document (maybe we should have a separate wiki page on reading json?)
I think it would be great to have them in circus.util yeah
Well then I have to parse the message and then we could also parse the cs and replace there Map type with a Dictionary. Then we can use Maps on java side
We actually probably don't want a default salt.  We should probably raise an error if this hasn't been set by the user.
I don't think so. What kind of filters are you worried about?
Can you use only `"` please? Thanks.
ну если это займет недолго то варум нихьт?
Should be this docstring? Otherwise dot at the end is too much.
Module setup isn't async
Are you sure this namespace is not declared in xmpppy? If yes it would be better to use it, instead of the string. Otherwise everything looks good
What's going on with this new import?
That's a nice simple solution, though I think the Newton-Raphson is faster in this case (it doubles the number of sig figs every iteration for a well-behaved function like exponential).  In my (brief) experimentation I found it gets to 1e-6 accuracy in 3 or 4 iterations.  Still an open question whether doing the iteration with logs 3 times is faster than the pure-numeric OneDimensionalDeviate (which is what SBSersic does with n=1).
This sentence seems a bit confusing.  Rather than say that the two functions won't match, I think we should lead with how to make them match.  So maybe the following:
```
It is important to remember that the image produced by drawShoot() represents the object
as convolved with the square image pixel.  So when using drawShoot() instead of draw(),
you should not convolve with a Pixel.  This will produce the equivalent image (for very large
N) as draw() produces when the same object is convolved with Pixel(xw=dx) when drawing
onto an image with pixel scale dx.
```
That feels a little rambly, so it could probably be tightened up.  But something along those lines.
The use of the namespace to discriminate at the top level was the reason all my functions in optics.py were so generically named... I do think it's nice to have `optical.psf` and `atmospheric.mtf` in general, since otherwise we could dispense with the namespace altogether.  

However, as the Kolmogorov PSF may not be the last word in our models of the atmosphere (fingers crossed!), perhaps we could make these function names be the very explicit `atmospheric.kolomogorov_psf`, `atmospheric.kolomogorov_mtf`, `atmospheric.kolomogorov_psf_image` etc.?
use {  } please :)
there is nothing to replace in this patch, why adding it to `substs` ?
comment about intermediate results applies here, too.  in fact more so here than the other place.
I would replace this class with a Jersey client filter as explained here:
http://jersey.576304.n2.nabble.com/Connection-Retry-on-jersey-1-5-Client-td5994296.html

We should also make use of client.setConnectTimeout(10) & client.setReadTimeout(10);
could we also have this effector on DynamicWebCluster ?
(that could be a separate pull)
+1

I'll change that in a separate pull request. Will need a dedicated function for resizeOperator (it takes two args), but currentSizeOperator can be guava Function<Entity, Integer>.

I'll also double-check the other policies for use of Closure...
Some as above.
global selectors is a kind of bad practice in backbone. is it really needed?
why not use view scoped selector? http://backbonejs.org/#View-dollar
This file will never exist because the original is "2012-06-19-draft-article.html.markdown"  (06 not 16).
Why set algorithm to None when you could just set it to 'RANDOM' if there isn't a one set?

Then you could remove the "if not algorithm" section entirely as it's been done above.
Nice :) Gotta do what you gotta do.
Na verdade não é uma configuração estática. Considerar que a aplicação poderá ser utilizada por outras instituições, neste sentido os parametros do SMTP poderão ser diferentes para cada aplicação.

Essa configuração esta no mesmo contexto da configuração de conexão com banco de dados.
This is in direct conflict with what's in the docs.  *See above*

 > +Both the Web API and SMTP API support BCC.
Mutta tuosta toisesta lauseesta voinee poistaa toiston siitä että valtaosa valitsi Pythonin. Vaikka Python onkin useampien mainintojen arvoinen ;)
No, it's not supposed to restart if it doesn't need to. I've added a comment.

uncheckedRestartSplunk always restarts.
Annotations are (so far) only used for storing spotify track ids in playlists that are synced w/ spotify
I'll try to re-write these bullet points in a way hopefully simpler to read/understand. But if you're not totally against the idea, I agree with David Golden that it would actually be better to have the text here instead of re-directing to /dev.html - don't make a user who wants to contribute go to additional pages to read how to help, at least not the basic info.
This method seems to miss a check whether "addDefaultChildrenIfNotSet()" is called as it makes only sense for arrays which contain a prototype.
In diesen Zeilen finde ich das besonders schlimm, das nimmt mehr Platz in Anspruch als es sollte.
looks like this is still called has_one
also just for the completeness, you need another test to test it returns false if it is not "united-states"
А что по-твоему thread-safety. Что будет не так, если не будет synchronized.
No background noise on Windows.
Is this testutil available in public repo's? It's currently packaged with the source which is kind of ugly.
Old mailing list?
I'd say we want to throw the deprecation warning on chef-10 as well.  Those users should know about the registry_key resource in chef 11 and it should push them towards chef-11 and registry_key.  The LWRP /is/ deprecated, its not just deprecated for chef-11 users.
The wrapper uses Many.wrap instead of html_options_for. The code is,

```ruby
        klass = html_classes(input, options)
        opts  = html_options(options)
        opts[:class] = (klass << opts[:class]).join(' ').strip unless klass.empty?
```

where html_classes returns [nil]. It seems better to fix the problem in html_classes itself (to avoid other potential callers from having a similar issue) as opposed to saying klass.compact in Many.wrap. But I can do it the other way as well if you prefer.
Can we do this as one query, with a JOIN?  My knowledge of SQL is kind of limited.
Sure, but can't we just determine the output type and use its full range?  Or, do you mean, preserve the percentage of the original dtype coverage?  With equalization, I don't think there's any need.
Unfortunately not... I can reproduce the segfault on two different machines, running this example.
I think strong_rule_feature_filter should be a function (not a method) used by different estimators maybe even LassoLars (We'll see this later)

basic usecase would be:

>>> strong_set = elasticnet_strong_rule_active_set(X, y, alpha, beta)

since Lasso and ElasticNet do not compute a path but just a solution for one alpha that should be the first usecase.

for path only you will need to pass last_alpha and last_coef
Thanks, that's cleaner like you said.
якщо назви методів некорректні, то зразу переіменовуй. в phpunit є прикольний режим запуску тестів ```--testdox```
спробуй
    phpunit --testdox
Can we just change this line to is_string?
So this basically dumps all that information from the context into the log line? Given the toString() implementation above, that will result in multiple lines (`\n`) to be written into the log.
Ben, la lisibilité : 10800s=3h
I wonder if we can abstract this a little. Having to know that the menu element is a child of the widget element is a bit too much coupling.
You should move this test to `test/runnable/traits.d`, it's a module for the `__traits`.
Moved to package functionality.
Updated to derive from NativeAbstractTextControl class.
Please use the != NULL as in other places for consitency,
Let's get some braces around these if statements in these helper functions :)
Let's skip this and move to CLI directly... (`git clone... composer.phar...`)
Why is `freemarker-clj.shim` used here?
Agreed.

For some activities (like slave datasets that don't need computing), ```abortSoon``` has the same effect as in this case, which adds even more confusion.
It seems unnecessary to rename these variables.
I realize my way explodes when `num_quads == 0`. I'm personally OK with that, since that means somebody passed a CIDR of less than 8. A check should probably be added to the type for that, since that's just not a valid construct.
Maybe. The point is this default `Content-Type` will be mostly (if not only) served along  with `Content-Length: 0` header.
I don't think we want to execute tests step by step. Lets call `self._mozmill.run once` with all the tests by removing this for loop.
I realize that you're trying to resolve a potential security issue -- however, doing reflection on the class seems like overkill. Couldn't we check against the typehint _after_ instantiation instead? Otherwise, I foresee this being a potential performance hit.
Bien joué junior ;) !
parameterize using the data provider for all states.
This is a great point! I just did an update to my branch to include the element test data which will be verified in real-time. This link is tied to the test data that is generated from the test class, so it CAN be changed at any point during the test.  This dependency is now updated accordingly. Now, if the test data is changed, then it will be reflected in the method that requires that this link be present.
@shacker doesn't look like it's necessary to add important on the padding properties, can we remove it?
@christianv Brilliant solution!
Need to specify args in the doc string. Not sure what 'fuseki' is. A subprocess.Popen instance?
space after & is unnecessary
I think I would personally prefer to see this shortened another way or actually let it go long.

Its just odd to me to read the matcher in this way.
I would suggest we make this a step-by-step process

e.g.

Step 1, fire up the app server and deploy the example. See what log messages you get when running it.
Step 2, copy XXX to YYY
Step 3, restart the app server and observe how the log messages have changed.
To me, my comment reminds me better of how my code works.
I love good documentation, but this branch is not the place for it.  This branch needs to be merged, the sooner the better, because lots of other stuff depends on it now.  We can document it after it's in master, like we did with CesiumViewerWidget.
I actually have no idea what this is.  @shunter ?
Why destroy the north and south poles here?  They use a trivial amount of memory, and it runs the risk of shader recompiles when the poles come in and out of view.
Sorry, I don't understand your comment. Could you explain further? I clone `rect` because if `point` is already inside `rect` then there are no further modifications and it takes care of creating a new `BoundingRectangle` if `result` is `undefined`.
Test the following:

```
var webcolor = [
  'black', 'gray', 'darkgray', 'lightgray', 'white', 'red', 'green', 'blue', 'cyan', 'yellow',
  'magenta', 'orange', 'purple', 'brown', 'transparent',
  'aqua', 'fuchsia', '#f0f', '#ff00ff', 'lime', 'maroon', 'pink', 'navy', 'silver', 'olive', 'teal'];

var webcolorPointer = 0;

var win = Ti.UI.createWindow({
  title: 'Webcolor Demo'
});

var rows = [];
var row;
var count = webcolor.length;
var color;
for (var i=0; i< count; i++) {
	color = webcolor[i];
	row = Ti.UI.createTableViewRow({ height: 40, backgroundColor: color, title: color });
	rows.push(row);
}
var table = Ti.UI.createTableView({ data: rows, backgroundColor: 'stripped'});
win.add(table);
win.open();
```

You'll see that these colors show up as transparent.
Must check the returned int value is a valid intValue. This will pass for `label.lineBreakMode=1000`. Also needs a default value.
To be true i am not sure to get this one but i trust you!
Android also supports property "id", the id of the row this contact belongs to (essentially this is a SQL search of a contacts database)
Android supports this
I feel like this should maybe go up higher. My previous comment was based on not seeing this information. Width/Height always take precedence over positions, so I think that should be made clear before talking about positions.
would you mind fixing the spacing here? happy to merge then
remove this js file
Ок, я лох.
Probably copy pasted, but will do!
Good point. I keep forgetting that `popFrontN` (and therefore `drop`) doesn't pop exactly what you give it, which is rather annoying IMHO. I guess that that fits in with `take` and `takeExactly` though (though in _those_ cases, taking less than asked for is sometimes reasonable, whereas I generally only pop if I know what's supposed to be there - that may just be how I do things though).
for consistency woudl be better to be a static method fromMutableMap() // see TreeMap which has the same named
> But isn't that the case anyways? The spec says "[releasing validators] is typically done when the ValidatorFactory is being closed."

**typicailly** - right now the choice is open. 

> Yes, my point is that I'm doubting whether we need such a method at all. In another comment Emmanuel said "who creates things has to release them", that's right and thus I think ConstraintValidatorFactory should itself be responsible to release its created validators when it is closed/destroyed itself.

that is a fair argument. If we would say that the cleanup occurs at ValidatorFactory closing time we could indeed go down this route. In fact I also never liked _releaseInstance_
Yeah, so i think remove it then ;-)
the logic of the class per-se is fine; but I'm not quite sure if it is the right distribution of logic. IMHO most of the code here should be part of an EO model extending a regular model which should contain the logic; don#t you think?
RemoteConnectorView
is PSU_FilterIterator really not namespaced?