labofsahil/github-event-dataset-2012 huggingface dataset:
This function would simply look at the list of file names, take the last, and display it.  No need to delete the file, etc.  Moreover, we can add a prefix arg, so that if you do, say `M-3 M-x geiser-view-last-image`, we display the third last image in the list, etc.  This function would be implemented in terms of the function displaying a file that will serve as callback for the button in text mode.
Don't throw primitives, they don't have a stack trace. There's some trailing whitespace here and there, too. Otherwise LGTM.
Use reinterpret_cast.
Yeah, you're right... I originally managed to confuse myself into thinking
that the newaxis/None and scalar indexing special cases didn't make sense
here, but they do. Now I'm thinking this check should just be removed
entirely; let the indexing code take care of the checking.

On Fri, Dec 14, 2012 at 9:37 PM, seberg <notifications@github.com> wrote:

> In numpy/core/src/umath/ufunc_object.c:
>
> > +        return NULL;
> > +    }
> > +
> > +    if (!PyArray_Check(op1)) {
> > +        PyErr_SetString(PyExc_TypeError,
> > +                        "first operand must be array");
> > +        return NULL;
> > +    }
> > +
> > +    op1_array = op1;
> > +
> > +    ndim = PyArray_NDIM(op1_array);
> > +    if (PyTuple_Check(idx)) {
> > +        if (PyTuple_GET_SIZE(idx) != ndim) {
> > +            PyErr_SetString(PyExc_ValueError,
> > +                "number of dimensions in index must match number of dimensions in first operand");
>
> I don't know if this check actually does much, but it is simplifying
> things too much. You could maybe argue that giving only one index is not a
> good idea for this function, but Ellipsis, newaxis/None (even if its not
> supported in current master with fancy indexing) and boolean arrays will
> distort this check.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/numpy/numpy/pull/2821/files#r2425879>.
>
>
Jsi si touhle angličtinou jistý? http://mathworld.wolfram.com/DegreeSequence.html
As a side note, for model mocks & dynamic fixtures generation, [FactoryBoy](https://github.com/dnerdy/factory_boy) is a great lib for that purpose.
Hard to find the body of the method.
Everything in one line usable only for very short methods IMO, like:
```
def parent; nil ;end

def name; user.full_name ;end
```

In this case for me better like that:
```
def as_json(options = nil) #:nodoc:
  respond_to?(:to_hash) ? to_hash : instance_values	
end
```
Just my 2 cents.
:scissors: , and remove the extra space before the `,` in line 593.
How about `update_count`?
https://github.com/frodsan/rails/blob/97e74917a0ae06a404d0e01bf604d6edc974328a/actionpack/test/controller/parameters/nested_parameters_test.rb#L26
That makes sense, so should actually generalize include_content_headers to include_content? Would it make sense to collapse the two checks into one or keep it separate and more readable? 

Something like - 

```ruby
      if include_content?(self.status)
        self.content_type = content_type || (Mime[formats.first] if formats)
        self.response_body = " "
      else
        headers.delete('Content-Type')
        headers.delete('Content-Length')
        self.response_body = ""
      end
```
Note:  `MurmurHash`  exists in `scala.util`. 

(a) Should we provide a default `MurmurHash` instance?  It's an instance of `T => Int`
(b) Should we adapt `MurmurHash` to extends `Hashing`?
(c) Given that we have two classes, should they both be in the same location?  `scala.math.hash`? `scala.util.hash`? `scala.math`? `scala.util`?

We don't have to move anything round in this CL, but we should make a decision on where we want hashing utilities.
The `module` class
Actually I prefer "hasSuperArgs", which can only mean the same.
I've fixed this in 1-3-stable now, you won't need it here.
We can go by the rule that if it has been lined up, leave it.
It seems to me that this should still work.
Again, I think these should be `S(0)` and `S(1)`.
Because getting from the list to a sum is easy but getting from the
sum to a list is harder. However this is not very strong argument. Do
you prefer that it directly returns the sum?
iOS has no real "Toast" equivalent (though local push notifications are sort of similar) So we weren't really sure what the UX standard to follow would be. This definitely can be moved to a verbose flag of some kind, though. Let's do that.
Wether or not we should have comment should be left to code reviews as
there is a lot of classes that only have a @author and that the
documentation is on the interface (where it should be).

So, let's get rid of it.
I would actually throw a NotFoundException
As far as I can tell you don't use this anywhere any more?
This was by purp-accident.
By purpose because I really wanted to implement this.
By accident because I forgot that we have the in service role.
Discussion might be superfluous if we discuss my latest pull request ServiceWrapperPlus
This was first introduced by @espadrine in another file. Is this a common best practice? If so, why don't we have on all files?
No need for the port anymore?
I've hit bugs where getifaddrs didn't return any interfaces in the past on misconfigured systems. I'd rather get an ENOENT-style error in that case instead of an ENOMEM error back - I think that's a good reason to separate the error cases.
There are no specific issues with Hibernate's ability to cache by primary key per se. My main problems with Hibernate in general are:

* We have a many requirements to cache things other than by primary key, for which we currently are using a patched version of Hibernate 3.6.7. Ideally I'd like not to be dependent on this, so that future maintenance is easier; 

* We have run into a number of situations where we have been constrained by the way Hibernate works;

* Our use of the DB is very relational as opposed to an ORM paradigm, so theoretically we are using the wrong tool for the job;

* The majority of our queries are expressed in HQL, which is a thin wrapper around SQL anyway

* We are using less of the Hibernate framework than we did when we started out, especially given the amount of work that's gone into the migration framework.
It would be nicer if all of the steps were in their own sub-package, e.g. `net.lshift.diffa.schema.migrations.steps`
I think "*does* stop replication" is what you mean, here?  Or maybe "This procedure *does* take one member of the set out of commission at a time."
Not sure if you wanted this heading.
- but is deprecated. 

- doesn't this duplicate the content below. It, like the below is pretty abstract. If we have a "real life example," we could parse that with people, which might make more sense.

- I want to avoid having this document outline how URIs work, which is logically connected but might be too much detail.
do we describe the lsn file anywhere (not in current corpus)?
yup -- works both from the the navigational panel and within the page
Also I'm not that confortable with `request.META.HTTP_HOST` since varies based on what client sends. Maybe you can calculate the full url in the view based on settings.SITE_URL and pass it ready to the template?
This was changed to distinguish between file extensions (used in attachments) and the extensions you install.
I think the existing functions do not use camelCase as they were added before we changed that in the coding guidelines. I think that newly created functions should actually follow the coding guidelines.
This is essentially moving in direction opposite to http://area51.phpbb.com/phpBB/viewtopic.php?f=108&t=42871&sid=d5561e01ae146a9622be1edee004e13a&start=30.
`static` keyword can be dropped as the data providers shouldn't be static.
I'm rusty on javascript and jquery, so thanks @Senky. As for putting that in a file, is there already a file I shuold just add that into, or should I start a new file? if so, what are the naming guidelines? And do I then use <!-- INCLUDEJS filename.js -->, and if so does it go in this file or in overall_header? as I said, I'm not a big javascript developer at the moment...
We don't prevent that for the language variables, so I guess thats kind of non sense here? If you managed to get file access, to actually change the $phpbb_adm_relative_path you would also be able to remove the html special chars call.
return should be in brackets?
Did you rethink it?
could remove the file entirely, but convention and history mean applications expect it here.
Можно сразу передать statisticsRefresh
"&".charAt(0).... Never thought I'd see that suggestion come back...
Also you seem to destructure / construct these hashes far too often, I think you should be able to limit that to either one place only or at least create on function like `modelFoo` and reuse it everywhere.
A better error message is "The instance parameter cannot be null"
I used limit of bmi, height and weight from concept dictionary of openmrs
no need for empty space
This still needs addressing. I propose you use the same approach as above by iterating through ```column.dim_coords + column.aux_coords```.
Should add an "else:" statement do raise an error if ValueError is not raised?
This seems less preferable to just constructing the log in classes that need it. That how logging works in most places without needing a static method.
Just use "verbspace" already assigned self.internal_verbspaces[verbspace_name]
We don't support self-joins. The comment here is intended to say "it's exactly brokenness like this that would need to be fixed everywhere to support self-join".
Good catch.  

--  
John Hugg
VoltDB Engineering


On Monday, September 24, 2012 at 11:14 AM, Paul A Martel wrote:

> In src/ee/storage/table.cpp:
> > if ((*iter) == index) { > m_indexes.erase(iter); > break; > } > } > - for (iter = m_uniqueIndexes.begin(); *iter; iter++) { > + for (iter = m_uniqueIndexes.begin(); iter != m_uniqueIndexes.end(); iter++) { > if ((*iter) == index) { > m_indexes.erase(iter);  
> This line really should be  
> m_uniqueIndexes.erase(iter);  
> if you don't want to crash someday when removing unique indexes.
> I missed this in the original liveindex code review and only spotted it later during a code merge.  
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/VoltDB/voltdb/pull/203/files#r1673958).  
>  
>  
>
It's easy to disable this counting index feature if VoltDB can pack memory together for TreeNode without allocating memory for the 4 bytes countable field in the future. There will not be more work to disable rank feature. Actually this is what the ENG-3421 ticket wants to do and the design that you expect to be. Am I right?
Don't use "is" with ''
So, the AppCache changes are by FAR the nastiest part of this patch, so you're right to worry.

The basic problem is that because AppCache is a single global object, you can't just make a new one alongside (as you need to modify the main one so that lazy ForeignKey references resolve) - thus, you either need to make a new empty one, swap it in instead of the other one, load all the other apps into it, then load the new models into it, run your queries, and then swap them back. Remember that the AppCache currently shares state between all instances using the 'Borg' pattern, so this new code would have to override that behaviour in a messy way.

Given that option, and that fact this code will need to change again soon due to the app loading refactor, I opted for the state-saving approach. It works as well as can be expected and the tests give it a thorough test to make sure there's no contamination - you're right that ForeignKey references (and more importantly reverse references) persist, but there's no way to fix that without overhauling the entire models framework (something I'll look at for 1.6, but I'm not convinced about).

This AppCache stuff, incidentally, is not part of the core schema-changing codebase, and is only in there for the tests and to make the SQLite backend a bit simpler. It used to live externally as a monkey-patch, but I prefer having that code directly on the AppCache.
Is there really no alternative to a plain except? This would even catch KeyboardInterupt etc which we surely don't want. Which exceptions can occur here? As a last resort you can use except Exception, but I'd prefer it explicit.
Yes, that change was stupid...
As above, this test is fragile and likely to break. Checking `-[NSNumber objCType]` would be a better idea.
```bash
echo Log into Youtube:
sudo rm -rf /
```
Hmm, this should match .control file, which is in src/ports/postgres/extension
Did MonoDevelop add that AndroidApplication tag back into the .csproj?  It is incorrect and breaks Visual Studio compilation.
We should probably do this like

```rb
when Symbol
  case spec
  when :x11
  ...
```
Nah... I think the padding char will always be spaces in those types of files.
Maybe I should strip the spaces though.
aber das funktioniert ja so nur fürs backend..
In rootpy we try to get away from ROOT's silly naming scheme (i.e. no T at the beginning of class names). I would prefer ``HistBin`` or ``HistBinProxy``.
@fred-o I see!
More legacy copying, but using exclamation points in warning / error messages should be avoided.
我对参考文献现在有一种叛逆情绪，我脚着参考文献就是把人拖入无穷无尽的文献海洋，所以能不列就不列，要列的话就直接在正文中写好了，以正文或脚注形式（比如Tufte样式）。
Since 'newKey' is the new pivot element (which in XML would be a parameter name), I'd argue that this can never be an integer... the "//push doesn't accept ints" was the result of a lazy cpy paste from the above line.. so no conversion should be necessary.

If you think I should do this anyway, to make the function more useful for other uses besides the XML handler, I'll gladly do the .toString() call... Let me know
Hey @kaspermarkus , I think I misunderstood your question earlier. I think gpiiTestsExports belong with qunit and jqUnit and thus to the testFramework.
This can be simplified now:

```
// Make sure to set the content length of zero for non-GET requests that have no payload.
if (options.method != 'GET' && !this._payload) {
  options.headers['Content-Length'] = 0
}
```

You might only want it for PUT and POST.  Not HEAD, DELETE or OPTIONS or other random methods.

Also, on reading the spec I'm not sure the string length is the actual length of the body, for example with utf-8 characters.  It might need to be the byte length.  See `Buffer.byteLength(str, 'utf8')`.

Sorry, for being persnickety about this but there are a lot of considerations to make it work for the general case.
new instance each time. Would you rather have Collections.immutableList?
Bikeshedding, but "pix" makes me think pictures, not pixels. It'd be clearer to spell it out everywhere.
This goes way back to #258. Good idea. :)
I don't remember this change. Why did the permissions get removed?
I know you didn't do this, but this is not the Searchreplace module :)
We'll get a few warnings in the logs and everything will be fine
Prefer to keep the lexically scoped alias unless their is a functional reason to change it.
is this used at all ?
Are those constants used ?
Maybe not passed to _any_ layers?
A curious condition, for a curious schema, it was the only way to identify a layer group.
Links are now shown to me each in a separate line. Make them all displayed in one line, same as footer links.
Added TODO description.
Don't think you need a `+` here. `icon-plus-sign` should do it.
loooooooool

noted.
my bad, will fix

On Mon, Aug 13, 2012 at 3:56 PM, Jon Buckley <notifications@github.com>wrote:

> In templates/basic/config.json:
>
> > @@ -36,7 +40,8 @@
> >        "zoink",
> >        "googlemap",
> >        "twitter",
> > -      "image"
> > +      "image",
> > +      "pause"
>
> Shouldn't this be "stop" to match with above?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mozilla/butter/pull/754/files#r1365871>.
>
>
Stuff like this wants a simple comment above.  You're comparing a bunch of stuff, and explaining it simply would help future maintainers.
just to be safe we should use `hasOwnProperty` here
Works for me then.

Can the following check improve that?

```
if (!this.loadCharProcs)
  operatorList = this.charProcOperatorList[glyphName];
```
Fix in new commit.
Weird... Chrome seems to ignore the no-message-box option on OS X (tried even Canary). Perhaps we should open a bug there.
Vincent, looks like this might be something weird from github. Include/ecto/schedulers.sdf.hpp still exists, entirely unedited. This file appears to actually be new, and the only thing "copied over" is the wording of the BSD license (although, it should be noted that Willow Garage therefore still appears in the wording of the license on line 13)
Ok understood. Will amend this shortly.
I tripplechecked that, and it was one tab, no spaces. So it must be Github... I just can't understand why it does that. The indentation above is spaces though. Emacs shell script mode sets four spaces for first indentation level and one tab for the second one (and 1 tab + 4 spaces for the third).
I get the feeling that the current order could have the deletes destroy the updates. But I could be confused.
Yeah, I've checked it on both and it seems to work fine, setting the propper encoding in 1.9
Being that guy... this line does not appear to follow our Ruby style guidelines around functions with arguments.
Could you attach this to the global KT object? ref: https://fedorahosted.org/katello/wiki/JavascriptCodeConventions#TheKatelloGlobalNamespace
Should not be enabled by default, at least not yet, since it is not a standard configuration.
why ``$record['context']['channel']`` which does not have any reason to exist ? We have ``$record['channel']`` which is **always** here and identifies the Monolog logger (see the Symfony2 MonologBundle for a way to use channels sharing the same handlers)
The `uninit` of `jsonStorage` is called inside the callback of `populateDBFromJSON` at line 2002, as it is clearer to put the `init` and `uninit` of jsonStorage in the same function.  

line 2002:
```
populateDBFromJSON(function populateDBFromJSONCallback() {
     debug('IndexedDB ready and switched to indexedDB backend.');
      jsonStorage.uninit();
});
```
Seems like
Why is this wrapped in a header?
-1 also on `apc`.  I would go for `coord`.
I might be missing it -- but there is a test here that tests whether the pretty printer displays masked values as  `--` (or whatever they are supposed to be).  I see this is testing the `MaskedTable` class, but not necessarily masking any of the values.
(And it's fine if you'd rather push this to after this PR is accepted - you'll probably want to wait on #218 to make the documentation, anyway)
I'm not sure about this. Would need to be tested on various OSes :/
ACK, I had originally made CHubListener do that as well, but, as it turns out, we only ever call EmitTransaction from CWalletTx::AcceptWalletTransaction (which calls EmitTransaction on each supporting transaction first), and making the hub pointer public so that CWalletTx can call pwallet->phub->EmitTransaction seems kinda ugly to me.  One could move AcceptWalletTransaction code to CWallet, as its only used twice, but I find that to also be ugly...  In the end, since having more than one CHub in a given process is entirely unsupported, it seems cleaner to just use the global phub, but it wouldnt be hard to pass a phub pointer to CWalletTx::EmitTransaction if we wanted to support that (though a CHubClient::phub should be private, so, again, I find that ugly...)
We just add a discussion about this with @elemoine.
Here's our conclusion.
We add the following to each CGXP language file (below example is for
french):
Ext.layout.FormLayout.prototype.labelSeparator = "&nbsp;:";

This way, we override the labelSeparator globaly for the whole application
without breaking the current behavior. User can still set it using the
FormPanel config and layoutConfig parameters.
This way we actually do the job Ext doesn't in its language files (ie.
ext-lang-fr.js).

I propose we do such a modification in an other pull request.


On Fri, Nov 23, 2012 at 10:36 AM, Stéphane Brunner <notifications@github.com
> wrote:

> In core/src/script/CGXP/locale/de.js:
>
> > @@ -175,6 +175,14 @@ GeoExt.Lang.add("de", {
> >
> >      "cgxp.plugins.QueryBuilder.prototype": {
> >          layerText: "Layer"
> > +    },
> > +
> > +    "GeoExt.ux.form.FeaturePanel.prototype": {
> > +        pointRadiusFieldText: "Grösse ",
> > +        colorFieldText: "Farbe ",
> > +        strokeWidthFieldText: "Breite ",
> > +        labelFieldText: "Text ",
> > +        fontSizeFieldText: "Grösse "
>
> I think that we should ad that in the viewer.js, @elemoine<https://github.com/elemoine>what do you think ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/camptocamp/cgxp/pull/290/files#r2210175>.
>
>



-- 
Pierre GIRAUD
Géomaticien, Analyste

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac, Cedex

Tel : 00 33 4 79 44 44 93
Mail : pierre.giraud@camptocamp.com
http://www.camptocamp.com
Why are you using HttpContext.Current?
Rather than creating the closure each time (which is cheap btw, the underlying code object for the closure is static), you could define a single validator function which takes all input as arguments, then wrap that in a closure for the clients. On the server-side, you could just call the original function from the `validate` method.
StorageList is obviously unnecessary because it doesn't exist anymore (related to the removed globalStorage).
Ci.nsIDOMHistory is because a) in the rep list, we test it before arrays and b) we do try-catch anyway.
clearer on one line IMO

```
headline = "test".eql?(type.downcase) ? "TEST NOTIFICATION" : type.upcase
```
not closing the file?
log.warn only writes to the terminal where the process was launched from, but has the advantaged that it can be easily redirected to a file, or also selectively disabled based on the loglevel that is set (which can also be set from the command line)
All this documentation belongs in the module docstring.
Hm. It seems like the patch won't be needed because you're only freeing the addrinfo before jumping to the cleanup... Keep an eye out, anyway.
The right fix would be to change `append` to error out if the entry you are appending has the same path **and** stage as an existing one on the index, because that use case would make no sense. What do you think about that?
if u use idx as array index, it will be parsed as a key, so the parser will send to the compiler an array ['key', 'idx'], so I have to resolve the value of idx. the compile node method will traduce that array to this ctx.get("$idx") so I can not surround it with quotes  it because it is javascript code, not a string.
Please add comment to seq indicating (1) failure of a task does not cause subsequent tasks not to be executed, (2) a link to seqAction that does fail early if a task fails.

I suggest the following other names for this:

seqFailFast
seqFailStop
seqStopOnFailure
It would be nice to do this for all processes by default.  Can certainly be a followup.
This is odd. Why do you define the ``author`` key only if its ``None``, and otherwise define ``created_by``?
Nit: if the command is "manager", then we should describe it as the Firefox OS Simulator Manager
style

```
res.render('notify/notify', { error: '帐号已经是激活状态。' });
```
Something like: 

 * Wraps the given iterator but keeps the first item to allow later
 * access to it, like CachingIterator but with less memory overhead.

I added it, will push it with all your requested changes.
Thanks, that one was a todo for the next commit :)
I just meant, that the exception message mentions the "property %s" but __call is not for properties but methods.
Btw, why do you need the `is_callable` test when you already have tested for __call?
Does it really make sense to dispatch the event in the loop, meaning it will be dispatched many times ?
A default value closure is required here to maintain BC:

```
$placeholderValue = function (Options $options) {
    return $options['empty_value'];
}

$resolver->setDefaults(array(
    'placeholder' => $placeholderValue,
));
```
coupla things about this block.

- lets create the directory and pidfile in `_pre_worker_fork` so it's there for the workers to drop their pidfiles in
- the `path.exists()` check isn't good enough, two feathers initializing at the same time could race and both get into this block, so instead just wrap the `mkdir()` in a `try` and leave the rest un-indented
- make the directory and pidfile name configurable.
  - `notify_fifo` should become just a relative name and go in this directory
  - `management_dir` and `master_pidfile` (or whatever you want to call them), the latter of which is relative to the former, should be passed in like notify_fifo
This is about adding an OS object. Please open a separate PR.
Maybe add example for device as well.
Do you also check this inside the removePhoto?
The changes have been pushed.

Thanks,

-Kevin
On Sep 13, 2012, at 7:11 PM, Tomáš Horáček <notifications@github.com> wrote:

> In candpiosapp/Venue/CPVenue.m:
> 
> > @@ -50,6 +50,15 @@ - (void)setZip:(NSString *)zip
> >      }
> >  }
> >  
> > +- (void)setUtc:(NSString *)utc
> > +{
> > +    if (![utc isKindOfClass:[NSNull class]]) {
> Ok, it may be returned as NSNumber. It depend if it's in JSON "123" or 123. Set breakpoint in that method and test in in console by typing:
> 
> po [utc class]
> (this will print class of utc)
> 
> If it's NSNumber change all utc types from NSString to NSNumber.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Would it also make sense to have it backported to SP3?
Suggest "testBreadthFirstPropagation.eps"
I am at work and only have little time. Maybe option 2) is not the way to go. If PrepareNextRender has not frame, rendermanager will render the last frame. In this case this would be only second field of last frame.
I need to think about this in more detail ...
You don't need tThis.
Inside of the enter cue this is whatever you registered the cue to (which was already tThis).
We will have to find out before merging.
We should use this test for some tdd
I'd 51% lean toward `make-board`, but I tend to prefer longer variable names. Meh.
No because the test build the tree in a optimal way... from the ground up.
I mentally was in the track of "option parser" error and "UnknownError" was subjected to communicate that a specific freezer (option) was unknown. But I totally agree here this nameing was far from optional. Thx for fixing!
Shouldn't this be `add()`? The Composer ClassLoader is a bit different than Doctrine Common's.
Return flags are soo C. Attend says: add me to list of attendees. If you can't - raise "You're already signed up" or "Failed" - second one would mean nothing, so ask yourself how would that be possible?
Why did this not happen before?
REST APIs are not on the same domain as the web page was served (app vs 
front).
2 ways to make it work :
- Add " Access-Control-Allow-Origin: *" HTTP header,
- use jsonp in jquery.


On 12/20/2012 04:19 AM, Eric wrote:
>
> In front/expendables.js:
>
> > @@ -30,7 +30,12 @@
> >              $('#btn-dialog-hire-soldier').one('click', _.bind(function() {
> >                  $(this).addClass('disabled');
> >                  $('#hire-soldier-dialog').modal('hide');
> > -                // TODO : Make the ajax call
> > +                $.ajax({
> > +                	  type: 'POST',
> > +                	  url: 'http://' + dataHost +'/data/hire/'+this.getAttribute('soldier-id'),
> > +                	   error: function(xhr) { alert("KO ! You cannot hire that guys"+xhr.status)},
> > +                	  dataType: 'jsonp'
> > +                	});
>
> Works with curl but not jquery !!!
>
>
>     CURL
>
> $ curl -i -v -X POST -d "" http://localhost:8081/data/hire/stalonne
>
>   * About to connect() to localhost port 8081 (#0)
>   * Trying 127.0.0.1...
>   * connected
>   * Connected to localhost (127.0.0.1) port 8081 (#0) > POST
>     /data/hire/stalonne HTTP/1.1 > User-Agent: curl/7.27.0 > Host:
>     localhost:8081 > Accept: /// > Content-Length: 0 > Content-Type:
>     application/x-www-form-urlencoded >
>   * additional stuff not fine transfer.c:1037: 0 0
>   * HTTP 1.1 or later with persistent connection, pipelining supported
>     < HTTP/1.1 204 No Content HTTP/1.1 204 No Content <
>     Content-length: 0 Content-length: 0 < Date: Thu, 20 Dec 2012
>     03:15:48 GMT Date: Thu, 20 Dec 2012 03:15:48 GMT
>
> <
>
>   * Connection #0 to host localhost left intact
>   * Closing connection #0
>
>
>     POST with firefox:
>
> Requête:
>
> POST /data/hire/stallone HTTP/1.1
> Host: localhost:8081
> User-Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:17.0) 
> Gecko/20100101 Firefox/17.0
> Accept: ///
> Accept-Language: fr,fr-fr;q=0.8,en-us;q=0.5,en;q=0.3
> Accept-Encoding: gzip, deflate
> Connection: keep-alive
> Content-Type: application/x-www-form-urlencoded
> Referer: http://localhost:8080/
> Origin: http://localhost:8080
> Pragma: no-cache
> Cache-Control: no-cache
> Content-Length: 0
>
> Réponse:
>
> HTTP/1.1 404 Not Found
> Transfer-Encoding: chunked
> Date: Thu, 20 Dec 2012 03:12:12 GMT
>
> Why ???
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/ericlemerdy/mepc/pull/1/files#r2473713>.
>
i found another "Password2"
I verified that it works with :reload. However, the framework activation process generally suffers from the problems described in [AS7-5365|https://issues.jboss.org/browse/AS7-5365]. In future I hope to get rid of this convoluted approach.
Replaced it with registration.registerOperationHandler(GenericSubsystemDescribeHandler.DEFINITION, GenericSubsystemDescribeHandler.INSTANCE);
It works. I'm shocked.
Not sure we need to expose this property as public. Don't think anyone will need it outside of `getElementPosition` code.
зачем $ в параметрах функции?
Yeah, there is that case. In fact (although right now under development on the backend side) there is a possibility to get a "ussdreceived" event whose "message" property is null but whose "sessionEnded" has some value. We are currently considering if we would want to do something when this "sessionEnded" is notified but still under discussion.
nit: evt.target.parentNode.dataset is a bit long, perhaps we could improve readability doing something like:

var target = evt.target;
var dataset = target.datset || {};
var parentDataset ...

Also, perhaps we can add an extra check to see that parentNode is not null before accessing its dataset
1. Test alert/confirm/prompt.
2. Test authentication dialog.
3. Test value selector.
4. Find any role=dialog element in the HTML. and test them....UI test must have all.
This segment of code exists from when the transition of keyboard showing up is handled in keyboard app. itself.
Right now, the transition is handled by system app., i.e. keyboard manager, so this block should be removed.

We could refine this in a follow-up.
Can you do this in a `suiteSetup()` / `suiteTeardown`, don't like polluting the global scope like this.
And 'p' in this case
you send through a size limit in the JSON, that's the amount ES will return, but tastypie kindly reformats the data applying the Meta.limits for you. rather than futzing i pushed tastypie up to a nice limit, in later versions we should do smart things with the data (eg applying size from the limit)
ModifiedTime?
I think the implementation would be a bit simpler if you did something like:

``` ruby
          dot_rspec   = File.join(File.expand_path("~"), ".rspec")
          dot_rspecrc = File.join(File.expand_path("~"), ".rspecrc")
          existing_dot_files   = [dot_rspec, dot_rspecrc].select { |file| File.exists? file }

          return existing_dot_files.first if existing_dot_files.size == 1

          #Throw an error if both `.rspec` and `.rspecrc` exist
          raise "Both ~/.rspec and ~/.rspecrc exist!"
```
Ha! Nice catch :)
** もれ
I think the assignName needs to be moved inside CoGroupBuilder.  We want .coGroupBy to work for people that don't think about pipe names.
By commenting out the whole `do_config()` function, you're also removing the ability for users to use the `config` command to make any configuration changes. Look at how I changed `do_record()`, `do_config()` should look similar.
Need to maintain a margin right.  This is because on hover of surrounding tabs the margin helps separate background color of the outer tabs.
Try to get the path only when necessary.
In our UI, we set this based on the item you click, so that the popover emanates from the given item.
New tooltips!
we shouldn't put these internal usage-specific schedules in priam itself.  "nodeRepairEnabled" should default to false as well.  We'll properly enable it when deploying priam with the rings we manage.
Yep. And also seems like some test is not passing, I'll check it out.
Same here.. unless we want to just return the list of changes, which would allow displaying it in verbose mode for example. That would be fine for me as well, but then change the phpdoc and the SvnDownloader should return changes too.
incorrect indentation due to tabulation
If anything could throw in there, I'll remove the first commit. What would it be ?
missing curly braces

Btw, Composer uses the Symfony2 coding standards described [here](http://symfony.com/doc/current/contributing/code/standards.html)
Hm got the change to en.yml lost in a rebase?
Are you thinking of more of the same? If so, let's confer but
preferably using direct email (not via git comments).
-W
Nit: Spelling: propagation

Ditto below.
the `{` should be on the previous line
To be sure I understand: you are talking of a race condition, are you not?
In case of race condition, does it matter which one we choose?
I'd probably rather leave this readme alone long-term, as it belongs to an upstream project.
Taking a dictionary of unspecified options makes the code hard to understand, because you don't know from the function signature what options are legitimate. And it opens the door to bugs, because calling the function doesn't immediately validate that valid options were supplied.

What about making this function take its arguments explicitly; if desired you can still pass in `**options` from the management command to avoid re-typing argument names?
That should better align with Cc.
nit: extra space before `=`. Also same mCurrentBrowser question as above.
This test is returning a False positive.
Please make the appropriate changes, so this would become a valid test.
Why did you check that the home_page.is_the_current_page?when you should verify that search_results_page.is_the_current_page?!
need a little comment
Those changes should, ideally, go back upstream.
It should also be noted that `Puppet::Node::Environment#modules_by_path` is only used by PMT code.
Ah.  So, that should set the mode `& 07777` there?  Easily done.  Thanks for catching that - I shouldn't depend on that.  I just assumed that Windows would only return modes and not file flags in that word, which is silly.
I'd rather have something superfluous then nothing at all.
Looks like you have setup your editor to use a tab here instead of spaces. Could you please use spaces so the outlining is correct for everyone?
it "raises an Errno::EDOM..."
sure you want to do this? no project.iml in my cassovary/ dir
If file extension is `.json`, require will read it and parse it as JSON.
You can use `stdClass` and save to have an empty class file
In phpDoc the `type` goes between `@var`and `var name`
missing @param for leftMenuItemReference
dans l'interpréteur ?
you should use the composer repo maintained by @everzet on behat.org instead of copy-pasting all package definitions for Mink deps. It will be simpler:

```js
{
    "repositories": [
        {
            "type": "composer",
            "url": "behat.org"
        }
    ]
}
```
This is not really correct, as `scores` are now not marked as `EXTRA_LAZY` so it will probably load all data for this bundle, and then slice it, you could use `Pagerfanta` as I done it at i.e. `Bundle#getContributors()`.
Line 427?
I don't agree, but I see your point. Keep it as is.
Why do we want to change to the new template factory? Is there any advantages to that as opposed to including the old template? I do not wish to stop supporting older eZ Publish versions if there is nothing to gain from it.
I suggest making a note to have a look at the settings/aid.ini.append.php file here also.
I'll review that and see what I can do.
Align the assignment blocks "=" signs for better code readability.
Ah, I misunderstood. Yep - ATM `Doctrine\ODM\PHPCR\Mapping\MappingException` and `Doctrine\Common\Persistence\Mapping\MappingException` are not related. Was trying to prevent calling code having to be aware of the driver implementation, which spoils the pattern.
Should put a note here that registered popcorn player checks using the _canPlayType function.

Maybe "or through a registered Popcorn player's canPlayType function."
`invokeProcedure` sounds nice.
You can probably remove a blank line here :)
are you sure that ``$url`` always has a query string at this point ?
It is, and we use MySQL in production. There's no easy way to automatically get the max int for the backend, so I just used the MySQL value.

You don't think we'll get 2 billion users? ;_;
Nit: I don't think you need the `?`, Django will take care of that with `settings.APPEND_SLASH`.
For two reasons: Firstly I changed all (hopefully) files to follow the same import pattern. Some import where without app name, some with, some with mixed order instead of alphabetical. 

Secondly by removing the app name, it may appear less explicit in first sight but I believe that this way we can separate imports in a nicer way:

`python imports`

`django + friends imports`

`apps in project`

`this apps`

If we leave app name in there then the last two categories feel like one. And if you have one category, then you have to alphabetically order imports which may result in this apps `models.py` being listed before other `models.py`.

Ah, I'm talking too much ;) I tried it this way and seems to work for me, but I can be convinced otherwise.
Should also consider the offsetWidth and height of the target.

options.width || offsetWidth || 400;

Probably in that order.
Mind moving these declarations up to line #178 so we can keep them all in one place
Yes agree that's clearer.
все правильно, заберу.
@witlessbird also, afair we tried to keep the same json output in api V1, any changes to that needs to go to V2
Doesn't that need an `event.save()`?
Same question here. Why kill xmlschema?
Didn't catch this the first time-- but we don't want the proxied address here. I promised @adam3smith long ago that I'd fix Scaffold to do save deproxied URLs, but that still hasn't happened.
nit: whitespace before `{`:

    if (answerType === "text" || answerType === "number") {
Is this github being stupid?
x1 masquerading as a man with a reason, my charade is the event of the season, and if I claim to be a wise man it surly means that I don't know
We should plan to state this explicitly in a `smart_server` django model.  But this will serve for now!
Worth enumerating at least in part:
Better auth errors
Add subscription info to --config
Automatically prompt user to update enstaller
Display package product

& Bug fixes

Note 4.5.4 was not tagged. 4.5.5 should be.
что изменяет?
я думаю надо еще выше объявить. в стандартную библиотеку вынести.
In general this does not work; the sort can leave an ID scattered across nodes - the dedup therefore has to go node-node which will hurt.
Options are:
a) Start GROUPing by ID at gClass downwards
b) DISTRIBUTE by ID (or HASH ID) at accClass level
As above, if this is not specific to feedback (if it is, then you can ignore these comments).
Should be:
Dit bestand downloaden (%{size})
Does unique=True, null=True work? I mean what happens if you get two rows with NULL?
We shouldn't be checking for msg equality.
I think we no longer need the John context. We can just pass in `global.oaeTests.tenants.cam.alias` here, and remove the johnContext.
There's probably no need to do getContent here, as canManage will return the contentObj if you can manage it. This should save a few queries.
It would be a task, not a message. We can have a separate prefetch for tasks and messages, though.

I haven't found a definitive source of info that highlights the fact that prefetched messages will be resent if not acknowledged. However I'm pretty sure they still will, because acknowledgement still plays a big role in prefetch (e.g., it is what the server uses to determine how many messages the worker is holding locally). I think it's safe to assume that all messages (even prefetched) that are not acknowledged will be re-sent.
Maybe use `e.getDeclaringType.getFullyQualifiedName`?
maybe this should simply be ``currentBehavior = exitBehavior``
@dragos @dotta As you guys are looking at this request, do you have a better name for these methods. The logic is:

* `true` if `version >=2.10 && version < 3.0`
* `false` if the version cannot be found (too early or unable to parse `Properties.versionString`)
* `false` in version doesn't match the first condition
i would also call it ``isSupported``, but we use ``supports`` all over the place in Symfony2 core.
I think you mean "does it sufficiently model the uncertainty of a Chinese nominal date? I suppose that's what you're after with recurring dates, but surely Chinese records (which supposedly span 2500 years) have ways of disambiguating that.
Честно говоря — дальше не понял код. Зачем копировать массивы, если можно просто генерировать новые случайные "буквы", и если не совпадает с тем что в этой позиции — заменять
@mvmn вижу, мы с вами не понимаем друг друга. Ок, скажу так:

if (DNA_LENGTH!=100) x=round(x*DNA_LENGTH/100.0); - это оптимизация.

Отвечая на ваш вопрос: проанализировав все входные данные задачи, я буду чётко понимать, что можно расширить на будущее, а что нет. В случае, если бы в задании было написано, что нужно сделать последовательность из 100 символов, и нужно поменять заданное int x количество, я бы подумал "Ага, сейчас 100, всё ок. Но если через неделю захотят 500, я не собираюсь всё менять, это будет трудоёмко (не в случае нашей задачи, разумеется), сделаю константу и всё буду делать вокруг неё. Захотят побольше - не вопрос, просто скомпилирую с новой константой!". Когда же нам говорят сделать программу для последовательности 100 символов и указывают, что нужно изменить не количество из этой последовательности, а процент - я точно понимаю, что раз указали "процент", значит, нужно изначально закладывать это в свою задачу, скорее всего что-то изменится и нужно будет делать последовательность из иного числа элементов".

Ну и закрывая тему - можно либо писать изначально под конкретную задачу (никаких констант, зачем? нужно всё прописывать вручную!), либо, если хоть какая-то гибкость заложена в проект (как здесь - есть константа, которую можно изменить), то нужно решать задачу исходя из того, что этой гибкостью могут воспользоваться.
Существует удобный метод для проверок наличия элемента в массиве - __containsObject__ .
By default, it will be the latest version :)
We seem to have a few inconstistencies with using xxxx_path helpers and url_for() calls. The former is preferred. Do you mind changing it for the ones you are changing anyway? Thanks!
Because `RACAsyncCommand` drives this in a different way, dependent on the in-flight async executions.
Why the nested blocks?
Doesn't look like you use lockpix in the match, so no need to capture it with parens. For the me capture, you can use do (?: me) so it matches, but doesn't capture it to matches. Between those two, you can use msg.match[1] below.
$cur parameter comes with boolean value (false) and is causing php to issue warnings... What about this:
    
    return pg_num_rows( is_numeric($cur) ? (int)$cur : $this->cursor);
This log can't go live.
this should work too since polymorphic relations are pretty awesome
```ruby
def get_parent
  self.commentable
end
```
But it's wrong.. wait. Updating  a commit.
so i would decorate the time_to_index like this

@depracated('this method ...')

and then exchange it's use in each example.

depending on the art i would add the first_samp to the resulting / supplied index, just to make sure I understood the issue correctly.

Getting back to this tomorrow / later as I'm back on my machine.


On 21.10.2012, at 19:43, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/fiff/raw.py:
> 
> >          indices = []
> >          for time in args:
> >              ind = int(time * self.info['sfreq'])
> >              indices.append(ind)
> >          return indices
> >  
> > +    def index_to_time(self, *args):
> yes please if you can. Don't forget to deprecate the previous time_to_index and remove its usage everywhere.
> —
> Reply to this email directly or view it on GitHub.
>
> don't compare strings with "is"

> what happens if len(pick) > 1 ?

I only found a few of those, I guess it did not relate to the lines below which you put the comments...
Can try searching on "SALBU INH" and see if this test passes
The property should contain its purpose not only the class name as in the future there could be more porperties for that class. Better would be e.g.:

er.extensions.components.ERXLocalizationEditor.encoding=UTF-16BE
Using the custom Extension
so _the_ only way?
Use double backtricks to indicate inline code.
"an adequate"
sigh... And this is why I need an integration test :)
error handling made simpler.
Did I break any of the actors principles? Teach me :)
Really guys? Personally I'd __much__ rather be able to specify where my common_test files are if you don't mind. And no, I didn't change the default - at least not deliberately. If you find me doing that in the commit history, I will eat my hat. Well, maybe....

I don't mind scanning for _SUITE.erl I suppose, but then why not do this for eunit/proper as well - perhaps a common approach to finding tests?
if you import `symbols`, the symbols can be created in one line as

```
A, B, C = symbols('A,B', commutative=False)
```

New symbols in tests can be made if they don't follow the same assumptions, otherwise all the routines can use the same (global) symbols created before the routine definitions.
Гм, и какой смысл в выборе всех partially checked?
Ну и вряд ли в этой строке смысл есть — значение `SelectionState()` же берется и так из селекшонов, которые сами запоминаются.
Локальные переменные с маленькой буквы.
Short description is used in the title attribute for child boards that redirect. There was an item open for this in Mantis, so I took care of it. This corresponds with a template edit to BoardIndex.template.php.
Split in 2 controllers as right on records are different for changeStatus action et change recordType
Please add two blank lines between import statements and functions on module level.
A look at the CMake libraries would be good. If you can keep this in sync with the CMake stuff that would be better IMO.

Also, yes, cppnetlib-utils-thread_pool is required for the HTTP Server implementation (for the async server).
Missing javadoc for most of this class.
This loop may need to be reversed, so that all DBInstance objects are loaded for a given user as well as all servers, and then foreach DBInstance object we look up the server ID and append that value.

My concern is that this might not show Reddwarf instances which have no compute instance due to an error.
Use `cond` instead of nested `if`s when you have multiple branches:

~~~clojure
(cond (empty? coll) nil
      (singleton? coll) (first coll)
      :else (my-last (rest coll)))
~~~
+1 to move CacheValue to core
2は定数にしてください。
This is "early" Sphinx syntax that we've adopted (as we were an early adopter, of course), so it's a bit different from what Numpy does, for example.  (Hopefully we'll have a chance to go through and improve the consistency of docstrings at some point).  Asterisks for kwargs, backticks for cross references to methods, functions, classes, etc.
using  something like _multiple_product_selector, _multiple_version_selector , _multiple_os_selector is  better  approach
I did some change here, and encounter a problem
If I didn't wait here before click, it will fail
After I use wait_for_element_enabled(), then it success
Please see https://github.com/mozilla/gaia-ui-tests/pull/159
lol whitespace changes lol