labofsahil/github-event-dataset-2012 huggingface dataset:
There is a comment on line 138, bypass.
@wiltave : you followed the PEAR coding standards correctly, but Rouslan's (roccivic) suggestion looks better. (and is also correct)
I made the other modifications, but I forgot to add spaces at the beginning of 189 and 190. When I try to push --force with only those two spaces different, it says everything's up to date. Ever encountered this?
Can we get this from the manifest instead of going to the element?
@hafriedlander Do you know if IE7+ is smart enough to not cause a memory leak here, given the handler fn is unset in its own definition?
Hi Keith,

> First, o we always succeed then, and never return WT_NOTFOUND?   So, if I have records A, B, and C in a table and call:
> 
> ```
> cursor.set_key(H);
> session->truncate(NULL, cursor, NULL, 0);
> ```
> 
> it would succeed?

I'd probably make this one fail with WT_NOTFOUND.  I think that simplifies the code, anyway:

		if (start != NULL) {
			WT_RET(start->search_near(start, &cmp));
			if (cmp < 0)
				WT_RET(start->next(start));
		}

> Second, the problem with moving it into the session level is that we need some way to do cursor comparisons and the session level doesn't know how to do that.   We'd have to export some cursor API up to that level?

We get the cmp value out of search_near already, so we can figure out if we need a next/prev without anything new.

I guess you mean the error checking, that if start != NULL and stop != NULL, then start <= stop?

> I'm happy to make & test this change if you want (although we have to talk about the second question, unless you just want to bite the bullet and offer cursor.compare which does a full comparison (as opposed to cursor.equal which does simple equality).

I'm coming around to that (replacing WT_CURSOR->equals with WT_CURSOR->compare).

It's certainly better than having both equals and compare in the cursor API, and because of the way we do collators in the native API, there will never be the problem BDB has, where comparing records can be horrendously expensive (e.g., from Java).

If you happy to make that change, that would be great: thanks!

Michael.
Noted, I'll create a bug for 0.2! Thnx ;)
Would be nice to have a couple doctests here and in other window subclasses.
modified default behavior for 2 column elements
Right, going to do that instead.
Are you sure ``$mockApplication`` has the correct type as ``object<PHPUnit_Framework_MockObject_MockObject>`` is not a sub-type of ``object<Zend\Mvc\ApplicationInterface>``?
Are you sure ``'FirePHP'`` has the correct type as "string" is not a sub-type of "string"?
Da müsstest du auch noch auf Nullpointer checken (wie oben).
Shut up, I was this close to convince him!
From deploying Joomla! CMS, I'd rather not have an exception thrown which breaks the website due to some invalid template...especially if it was in an admin template which then made it impossible to fix without directly updating database.
combine this line and the next
delete these comments
You could probably avoid to write the same path twice (see line 131)
This was my mistake. There is no need for "else".
And same here. You should chain jQuery calls together. You create input above, just attach also event handler there.
Removed stupid effect :)
> Heh, you respond fast

Sorry. I think that you have already spend some time on the subject before commenting here and that you are commenting here only when you are stuck.
Good idea to check, but make this an assertion.
And login != connecting. Login is when user authenticates. Connecting is when it establishes HTTP PUSH channel. We want to cycle in the later case. Login can be a very rare event.
Make this as a list, colon at the end and then a bullet list, no commas or dots at the end of each line.
Zend класы используем c префиксом Zend
Would be nice to also include the destination path in the message.
No need for strict checks here either. The modules won't be loaded anyway if this fails, and that happens a couple of rows below
I agree! TortoiseMerge should not be responsible for housekeeping
const uint32 diff -> uint32 const diff
AFAIK this will never trigger the assert, as a string as argument is always != 0. Try `assert(0 & ..` or `llvm_unreachable(..`.
let's group all those function in circus/util.py please
Would drop the parens.
Unnecessary comma after `a`.

I think the last sentence can be improved: All logos are high resolution without background.
are the two csv files the same? then, I think we only need one copy
shoudn't this be '$orderby'? http://www.mongodb.org/display/DOCS/Advanced+Queries#AdvancedQueries-%24orderby
This might be complete overkill, but: 

Could `HighVoltage.route_drawer` refer to an object that knows how to draw routes? 

It could default to something like `HighVoltage::BasicRouteDrawer`. Then `HighVoltage.root_routes` could be a class method that swaps out the `HighVoltage.route_drawer` to `HighVoltage::RootRouteDrawer`?

Then in `routes.rb`, you could do something like `HighVoltage.route_drawer.draw` and replace the conditional with polymorphism.
Ah, now I see what you mean. Unfortunately, I guess, one does not simply stream a YAML file. And all our other resources are in this format.
I think access request is not used anymore
Right now there's just a setter for setting the media ID; this would just involve adding a new one (probably to _MediaPlayer) that sets the media property itself. Shouldn't involve much reworking, just a few more lines in _MediaPlayer.
How do we know Dr. Zero is a real doctor?  Please post a copy of your medical license.
There are so many errors that JSLint gives up on this code at 39%.
Dittto
Only the name_attribute is required, the rest are only sometimes required depending on the action and are verified then.
Oops, thanks for spotting! Coding with an ill child in the background looks to be a lot more distracting than I thought! Once I've incorporated your review comments, I'll take another look through all the diffs...
semi-considered opinion:

* don't set(HOSTNAME) ... leave that to follow SoftwareProcessEntity conventions (e.g. AWS-reported hostname) ... important i think if nginx is behind some firewall/hardware load-balancer / DNS l-b, it should definitely *not* be the domain_name which nginx is serving
* setAttribute(DOMAIN_NAME, getConfig(DOMAIN_NAME) ?: getAttribute(HOSTNAME))
Strictly, should also do `if (resolve) resolveClass(result);` (in case a class has been added that has not yet been linked).
Do we want this atlassian-ide-plugin.xml file checked in?
already done this !catalog.isLocal check a few lines above, so won't come here.
Same as previously.
I fixes return type of objectForInfoDictionaryKey() a short while ago. I will remove `.id`.
Line 653 appears to be indented by four spaces rather than two.
The default value here should be false.
Instead of doing node.set's here we should just change the sets to defaults.  node.set is really something that should never be done unless there's a reason
This is the failing test on travis. It fails under 1.8.7, jruby and ree. For some reason, diffs are not even getting touched, even though I have directly stubbed `configuration.color?`. This is very odd, as you can see if you look in the differ at line 71, diffs are returned only if this method is false.

I'm currently installing 1.8.7 to play around and try and work out why this is breaking.. if anyone has any bright ideas, let me know.
Sounds good, will try adding on Monday
Same as above for this._contact.
evt.data is equal to the value of the 'message' parameter in otherWindow.postMessage(message, targetOrigin);
I think here you can just do 

```
$(".chzn-select").chosen({allow_single_deselect: true, no_results_text: "No results matched"});;
```
Nuke_freq
are these CPPFLAGS and LDFLAGS still needed with homebrew's superenv? It normally adds the include and lib of `keg_only` formulae to the compiler.
I actually added a function, but it doesn't come through very clearly in the diffs. So there is now GetImageFromFile and GetImageFromServer.
We might also add in the GPS UBX/NMEA to this object, instead of in system settings.
Since this board is assemble yourself, it might be nice to have a short comment before these to indicating the connections (although that's basically what it says below).
Will that together with some doxygen.
* GIven that JobRegistry really isn't an internal component and 
* The direction you'd like to take this functionality per the blog post associated with this Jira issue

I'd say it makes sense to make it a first class citizen.
b/c the value or the key? or the value of the key?
Если в конструкторе Scanner произойдёт исключение, то inFile не будет закрыт.
bufferedReader не закрывается. И вообще непонятно, зачем он сделан статическим полем.
change the name/folder to something like helloworld-jdg to no colide with previous existing helloworld quickstart
file a bug, or do it now :)
But yes, this is needed to make the wrapper case pass.
That's a Debug statement, right?
This should read:

```ruby
  # Refinery::Blog.user_class = <%= Refinery::Blog.user_class.inspect %>
```
Shouldn't [choice](http://docs.scipy.org/doc/numpy/reference/generated/numpy.random.choice.html#numpy.random.choice) be the right thing?
don't quite understand the *in* at the end of the sentence
That would be pretty awesome. But pretty sure that is not the case. That would need python function calls in libsvm, right? Not sure how to do that without numba. Well possible without numba but non-trivial.
I would just delete the line. You can check the shape of coef_. This way, your test will have at least one assertion.
Why the change? You don't want to cater to <9 features any more?
Just a warning?
Should disconnect in accepted()
But look, playerHasMoneyToEnter will always return true if the teleporter is the console/not a player. It took me a few minutes to figure that out, the code really needs refactoring (/cc @Multiverse/core-development-team)
Structure ?
I'm not sure the title is very explicative. How does this sound?
 _Returning distance to query point in the results_
or
 _Returning distance to query point in the search results_
should be

    for ( Object entity : pois ) {
I think it's clearer inside the loop, and efficiency is not a concern here
That makes the default products rely on a random pick. `products.keys()` is pseudo-random.
uggh. I make this mistake all of the time too (trailing comma is not supported pre 2.7.7 or so). I wonder if puppet-lint would detect this...
Thanks for your private key.... you'll probably want to change it now.
Why move this to `base_views`? It is _the_ API view. Seems confusing to me.

If the move was done to separate the Whiskerboard implementation (like the Incident endpoints) from the generic API stuff, why not toss the JSON mixin, list, and detail views in `base_views` too?
Can we store the current semester somewhere central and tokenize it here, rather than hard-coding?
hrmmm i see us repeating this quite a bit. Wonder if we can put some logic around this.
Can you add a comment explaining what these are used for?
Nuke these comments
This parameter should just be named `ensure`.
Hum..., good shot this revert is not completed !, this two "exec" should be removed, sorry
Debugging, will hose the resultant executable.  =(
The ```if``` block and the ```else``` block are identical, which means the same code executes regardless of the condition.  Remove the condition.
i dont see the point
as you have the version and host in their own columns. it doesnt make sense.

On Fri, Sep 28, 2012 at 6:51 PM, Juan Vazquez <notifications@github.com>wrote:

> In modules/post/windows/gather/enum_tomcat.rb:
>
> > +		end	
> > +		print_status("Done, Tomcat Found.")
> > +		
> > +		tbl_services = Rex::Ui::Text::Table.new(
> > +			'Header'  => "Tomcat Applications ",
> > +			'Indent'  => 1,
> > +			'Columns' =>
> > +				[
> > +					"Host",
> > +					"Tomcat Version",
> > +					"Port",
> > +					"Web Application"
> > +				])
> > +
> > +		results.each { |r|
> > +			report_service(:host => session.sock.peerhost, :port => r[2], :name => "HTTP", :info => "#{r[0]} #{r[1]}, Application:#{r[3]}")
>
> I would like to change the :info a little. With the actual reported info
> it's what I see:
>
> Services
> ========
>
> host           port  proto  name  state  info
> ----           ----  -----  ----  -----  ----
> 192.168.1.133  8009  tcp    http  open   192.168.1.133 7.0.30, Application:Unknown
> 192.168.1.133  8080  tcp    http  open   192.168.1.133 7.0.30, Application:Unknown
>
> I think would be nice to change the report_service call to:
>
> report_service(:host => session.sock.peerhost, :port => r[2], :name => "HTTP", :info => "#{r[0]} Tomcat #{r[1]}, Application:#{r[3]}")
>
> (Note which I've added the "Tomcat" string to the :info value)
>
> What do you think sectorix? Do you agree? I really think info would be
> much clear :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rapid7/metasploit-framework/pull/840/files#r1720036>.
>
>
Version field isn't needed anymore
res should be check to not be null before doing it
user #{peer} as prefix on all the print_* calls, please
Hmm, that's unfortunate.  I agree having to pass `tform.__call__` would be really awkward.

*Originally*, I was pretty strongly against

```python
warp(image, inverse_map=tform)
warp(image, inverse_map=tform.inverse)
```

because I thought it would be more natural for `warp` to call the transform's `inverse` method.  But, looking at the function signature, it does say that the transform *is* the `inverse_map`, so it's not too crazy to assume that the user should explicitly pass the inverse transform.

In the end, it'll be confusing no matter what we choose. I'd go with the least magical: call whatever's passed to `inverse_map` (i.e. don't  check for a `inverse` method). I don't think there needs to be a `forward` method. In fact, I'd suggest changing the docstring below to say `Apply the transformation to the given coordinates.`
Originally I wrote this with `color` but changed to `spectrum` for generality.  You're right that RGB(A) is probably by far more common usage, though.  I have no problem changing the name.  Any preference?
Alternative constructor for `b`:
```python
b = np.hstack([xd, yd])
```
Two questions:
1) Why is this async? Asynchronity here seemingly leads to a race between patch_source and completions.
2) What's the scope of patch_source effect? How do I unpatch sources?
I think `allow_nil(false)` should also be `allow_nil(bool)`, right?
Can you remove password, as we don't want to recommend this approach of storing user passwords to our users.
NOT ACCEPTABLE!!! LOLZORS
not ``target`` but ``version`` :)
I suppose you added this for speed?  You don't want to convert your typed array to an array of `Cartesian` just to call `fromPoints`.  I don't blame you.  Longer term, what we really need is a fancy and fast abstraction to work with both so we don't have to duplicate code like this.
i left it in for people working on the code. Does this become public?
The extent is mutable. Do I need to enumerate all of the possible exceptions again here? Can I just add an @see to the function?
It looks like we have a protocol which is used to communicate between the harness and the driver for this - it should be documented somewhere, like our debug protocol is.
Similarly, return [self isEnabled]
braces open in the next line
I do appreciate the pull request, but the package authors should probably just list code authors.
`themeroller.find( "div.picker-on" )`
> помойму не-питонисты так не делают

почему они так не делают? потому что они ненавидят других людей? ))

я думаю что нужно не просто сделать все в одном файле, но еще и как-то так сделать:

    ns.EventFile = FileType uploaders.EventUploader
    ns.URLFile = FileType uploaders.UrlUploader
remove it entirely instead of using ``@return void``. ``void`` has no meaning in PHP
It is saying if the packet should be sent to the client. See https://github.com/ElasticPortalSuite/BungeeCord/blob/master/src/main/java/net/md_5/bungee/UserConnection.java#L258
Yes, and?

Give a method which return if the top window is the last window and I could change this behavior  :smile:
> But since you've done it, thanks :-)

You're welcome :) I try to be flexible in these matters, and actually the separately created map doesn't read that bad either.

> We should discuss fluent APIs and builders over a beer some day.

Absolutely, that will be fun :)
No need for this change; taking the plain username ensures that you only get the right branch if you know the real username, and after this we're just going to hash it twice.
What's the functional difference to startupInPluginMode? Could any of this be refactored into a single helper?
Was this fixed in that latest batch of changes?
I think you should separate the functions that deal with modifying the global state of the bindings, and the functions that deal with events / DOM. RIght now, the two are closely intertwined, and it makes the code fairly hard to read and, in the future, to maintain I'm afraid.

Here, you have logic that operates on the DOM in the middle of logic that modifies the hotkeys.

What about a set of functions called `onSomething` that deal with events, and a set of functions that modify the keybindings? You could put the logic about the `parentNode`, its expando property `hotKeyBinding`, getting the various modifier states from the DOM in one function, and then call another function, maybe `modifyKeyBindingAndSave`?
should I put this in a new step file, because it's so general?  or can I just put it in registration_steps.rb?
Some of these other changes emerged just through organic growth and testing of the fundamental change idea.
Just curious about this:  Did the definition change from 'lineType' to 'line-type' or are you just catching an old typo?
I don't see creating new migration as much overhead. But okay if this was the decision I guess we can live with that for now.
.toArray() is discouraged in general, and having it in an inner loop even more so ;)
Yeah, you can make that change, and you can remove the data-confirmed-remove attribute.

You should be able to use jQuery to grab the href attribute of ```$a_remove_tag```, which you can then pass to ```window.location.replace```.
Actually it does (although in a dumb way). It is inside a for loop going through all the timeblocks that this class meets, so we are adding the weights multiple times.
Can we uniquely identify this span so that it doesn't rely on this specific markup to work?
Is this something that's been left out/untranslated?
this is a lifecycle event and not a request-based one, so debug is a better fit imo.
Are steps required?
Yes, lets continue execution without `args`!

##### P.S.
Do not try to revise pulls with Github diff as its impossible to understand changes not seeing surrounding code.
MIPS64
No need for urlencoding, because drupal_goto calls url(), which calls urlencode
Right - but with identical messages. it makes it hard to debug if someone posts it on the forum.

If you use  "Using a custom correlation key without ... " instead

or

"Using optimized-correlation (with a custom correlation key) without caching consumers..."

It will be unequivocal where the WARN came from
I don't want to do that at init time, because I initially did, but realized that people actually change their session engine on the fly. Yes they do :)
So need to do the check.
BrowserStack, not Browserstack. Comma before initialize. "`taget` object" -> "`server` property". The default for host is a string so it should be quoted.
Oops exactly. It's more simple ... and can detect this problem on other configuration (custom compilation of php, ...)
Aunque no es la redacción original, personalmente movería `como cuatro acciones` después de `agruparlas`
This is the business part of this fix. The rest is support for IDE use and test compilations.
This should be 'class main'.
yes we will need to add him eventually, but he is so far away.
Good point. I've generally ignored this kind of thing because it's a hack until we get a proper MediaWiki API for getting content in the form we need, but that probably won't happen any time soon.
@mweimerskirch This controller is implementing a REST api for the thread. Why would we have 1 invalid case when all others are working fine ?

I suggest the following:

```php
$view = View::create()
    ->setStatusCode(Codes::HTTP_BAD_REQUEST)
    ->setData($errors);

return $this->getViewHandler()->handle($view);
```
*tpme_tests* -> *database*?
I would have a full stop after returned and start a new stentence
That comment is not helpful, you should say 'default to the number of samples'
``isset`` is a bit faster, and we won't have to deal with ``null`` values in the array anyway
These pre-emptive network checks are no longer necessary here, as network failures now fail gracefully.
Glad to contribute :)
Your syntax definitely looks better, i'll make the change!
without debugging, this is the existing code. change should be reverted.
How about the one from above. "catch of %s hides catch of %s" and "duplicate catch type %s".
How about `unless $?.success?`
Ah I have only tried with Bedrock and it works. Maybe other repos are not so lucky.

Do you see another way to do this?
IMHO, this whole file shouldn't be changed in this PR.
why were you inconsistent with the link?
Yes you are correct. Runtime uses the default method for picking a color.
Эти элементы нужно именно что *удалять*. Иначе карта ответов будет строиться неправильно, причем из-за этих, теперь скрытых, но таки вполне себе присутствующих  ссылок.
My bad, I was thinking about something else.
Tässä oli tarkoitus toteuttaa `boolean`-funktio itse. Valmista `boolean`-funktiota *ei* siis saa käyttää apuna.
Again, this is a generic worker and any and all exceptions are allowed.

That's why we added the pylint disables.

If someone made this code more specific, they could freely do this.