labofsahil/github-event-dataset-2012 huggingface dataset:
I think you may want to use the html5 contextmenu attribute instead. If you put this attribute on the homescreen itself it should be caught by the system application and then you can show/hide a menu to set the wallpaper and do other stuff later.
nit: 'initializing' (typo)
Nit: please re-format this comment (80-char limit)
The fix has landed, no need for the workaround.
Why *.header* class? Is more closer to a `section`more than a `header`.
Nice catch! Reusing KeypadManager's function. Thanks!
I was thinking more in extracting to a function the loop, then you pass a parameter and apply to each list.
So you can reuse the loop and the adding/removing clasess and data.

Is this possible?
You’re right, I’ve just added a `parseInt()` on mnc — github doesn’t refresh this view but it’s visible in the full patch.
bad indent there
We should reuse the browsing contexts but please read previous comment
What is `#screenscreen`?
Didn't want to add a listener just cause of the sim change estate. I hope we don't have to deal with this quite often, and having that listener just for an operation that we don't perform that often ... not so sure.

@aymanmaat we need your advise, should we be ready for @albertopq comment? Always pending on the sim state or can we leave as it is (just checking when you launch contacts)?
It's better to use getters, what do you think about it? Evme.Utils.isKeyboardVisible
Ah, I understand now. Thanks for clarifying.
Same with these. We can default these in the options hash I think.
does this make more sense?
We used the Savon gem to deal with SOAP requests on Goldeneye, maybe it would be a good fit here as well https://github.com/site5/goldeneye/blob/master/lib/goldeneye/drivers/savon.rb
lol, how about not changing it at all?
Don't have to return
Looks like this was introduced for Excel support in SCiCustomer, but the implementation was not added to tent collection. I'll clarify that and push a version of collection with getURL() (and change above to @get('collection').getURL())
Pull requests update automatically. Change the line and commit your change and the PR will automatically update to match it.
This file has several merge conflicts in it.
aah seems I was wrong. Wait I want to check and come back. What I thought was its pluralization. 

Thanks.
Want to move some where quickly, will get back after a few hours. In the mean time if @pmjones  is here , he will check and merge.

Thank you for the PR.
You've done away with the code to ensure the Mod is loaded, is this 'cos you consider it defensive programming?
Assuming that writability is required, it should be checked here too..
``@return`` for a constructor ?
As we discussed I think it's best to leave this out. If people start adding it when they write repositories by hand (if anyone still thinks that's a good idea) and mess it up because they don't normalize properly, it's bad.
more private -> protected
原文: Since view.$(selector) is now equivalent to view.$el.find(selector) rather than $(selector, view.el) it can no longer be used when selector is an HTML string or DOM element.

監訳案: `view.$(selector)`は`$(selector, view.el)`では`view.$el.find(selector)`とすることと同様になったため、`selector`がHTMLの文字列やDOM要素である場合に利用することはできなくなりました。
I doubt that matters (never encountered this problem), but even in this case, pessimistic versioning for these gems will be enough.
Just as an aside, I extended our test framework to make a test that returns a connection instead of a browser.

This allows us to check response codes and headers and such. In this case I have asserted the Cache-Control header
Should strip ABSPATH not basename
It doesn't have anything to do with EnumerableCollection because user can also provide the index themselves via locators. Maybe use default as zero?

````
def index
  @locators[:index] || 0
end
````
In line [81](#L1R81) search term for each tab title is wrapped in <em> tag. This is displayed  in result list so user can immediately see why result is matched.
Maybe add a comment that's temporary and ok for fennec as we do have only window.
https://github.com/mozilla/browserid/issues/1538
Maybe allow this to be a class, also with the ability to pass params?
I'd just add a commit on this branch to stub them, and we can try to add acceptance tests in a future pull request.
This should use `Puppet::Util.replace_file` to swap the files over, rather than hard-code it.
We can chat about it when I'm in the office - I'm totally fine with stubbing it out.  Are you referring to these IN PARTICULAR, or to most of the statements in all the "before :each" blocks?
What is the `splice` for?
I'm not sure there's any strong reason, but *why* I did it was so that you don't have to set the stylesheet in a device-orientation specific way twice (once in viewDidLoad, and once in viewWillRotateToInterfaceOrientation). Instead you can just do it once, and then call restyle!

There's probably a nicer solution; but I haven't figured it out yet.
Don't call `local_remove` here.  Do the same thing as `local_create` and call it during a ring event.  You do it this way because the ring is the authoritative source.
This needs to have a filename passed to ``__init__()``
This does not match the syntax
set the backdrop z-index as the modal z-index - 1
only if it's not a dict should we look at __dict__
Did that hurt performance that much? I think this might be needed in some circumstances. Although I can't remember it exactly BUT these lines look like they would break some stuff eventually when they are missing :)

Everything else looks pretty good! Can I get these two lines back eventually?
What about IPv6 support? Is it required by WebYaST?
Should we add array type hinting ? Anyway, I will change my Step validator to remove the addValidator, so that we share the same interface.
@weierophinney The values are never used, they are only there to fill the constants with a value. It won't matter much if i decrement the values, guess I will then.
Don't use `Zend\Json\Decoder`
You can omit this line since both are in the same namespace.
It was never there, but I can fix that.
Yes. At first I added it in the interface but I remembered that you told me not to. So now the Factory just checks if there is a method called init, and call it. Maybe we should even remove it from the Element and let people add it if they want.
bytes need to be preceded by the dollar sign
wrong param, should be ListItemType
Ok, I added some unit tests, to the best of my ability but I've never used xunit before and don't really know how. I may revisit tomorrow, but I could really do with some help here. For the most part, I'm satisfied that bar the unit tests, I've implemented all your suggestions and I'm leaning towards leaving it there.
You can just do holder.add(NavigationComponent.class).setDefaultExaminers...
wonder if we could add:

    with context.new(on_complete=sum_results) as batch:
        pass

Thoughts?
Ok, right, looked at this out of context. It's fine.
That line is unnecessary, the assignment is unused except as a return value.
you should remove the ``@return void`` here
It can not be used in setUp because this properties are used in dataProvider (which is called once before setUp). It can be moved to static setUpBeforeClass as static properties. Or i can add some lazy getters with factory functionality.
Wrong indentation:

```php
$conditionSql = ($criteria instanceof Criteria) 
    ? $this->_getSelectConditionCriteriaSQL($criteria)
    : $this->_getSelectConditionSQL($criteria, $assoc);
```
must be tired, i somehow thought we have 2 checks now. all fine and correct.
No, that's not a good solution.

I did that first, but this gives problems with deeper subclassing. See commit 4594a7acc8fad1778560d43c696549d1e456ffbc
add your name
You could cache it in your app.
Hm, this method is one big hack now. Not sure if I want to support this.
makeGetValue can generate unsigned values for you, that is the fifth parameter. So add `, null, true` to makeGetValue here instead of the CORRECT_SIGNS stuff.
Typo here =)
btw, it is possible to use decorators to modify a function's docstring as well.  But, personally, I prefer using format strings for duplicate documentation.  See how we populate the docstrings of various axes methods.
Same as above, should this be parametrized?
You only use this once later - why don't you just inline it on line 169?
Its got it to have a border that's spaced away from the actual body. Also, the #profile-photo has the whole thing with the cropping of image thumbnails and whatnot.
Did this not get fixed?
In terms of display and markup, there are a couple problems here. First, the parser is insisting on wrapping the URL in p tags, so it's displaying on a separate line from the word Screencast. It's currently outputting:
```html
<li>
  <a href="url">Question?</a>
  <br />
  Screencast: 
  <p>http://thing thing thing</p>
</li>
``` 
But we try not to use br tags, so what we want is:
```html
<li>
  <a href="url">Question?</a>
  <p>Screencast: http://thing thing thing</p>
</li>
```

However, in terms of accessibility, leaving URLs exposed is generally a bad idea. Imagine having a long URL read out loud to you. It's hard to understand, annoying, and doesn't tell you anything about what the link is for (people who use screen readers may sometimes choose to browse a list of links removed from context). A good solution would be to remove the faux-label "Screencast:" and use the URL and question text to generate something like `<a href="url">Screencast for "Question?"</a>` or create another field so the person who edits the FAQ had to specify link text to use so it would be like `<a href="url">Screencast link text.</a>` 

The problem with the latter method is it would rely on the FAQ writer to make sure their link text was accessible and descriptive (e.g. not something like "click here for screencast").

To be honest, I think the best mark up here would be this:
```html
<li>
  <span class="question"><a href="url">Question?</a></span>
  <span class="screencast"><a href="url">Whatever text we use for the screencast link</a></span>
</li>
```

Then we could use css to set those spans to `display: block` and give them a bit of padding/some margins.
The controller should have a reference to the view, not the oposite??
chmod 750
@jcredding - yeah, I sound like a total hick!  Thanks, I'll clean it up.
@mattn: What's so bad about `fnameescape()`? It was created explicitly for this use case; I use it in almost all of my plugins. The bug with `!` isn't that serious (would be great if you could actually fix it, though :-)

Your alternative is long and cumbersome, and you have to put the last line into a `finally` clause to be sure that it gets executed when the sourcing causes errors.
Use the `$orange` variable
"The -ms-interpolation-mode property is obsolete as of Windows Internet Explorer 9. Do not use. The -ms-interpolation-mode property was introduced in Windows Internet Explorer 7." via http://msdn.microsoft.com/en-us/library/ie/ms530822(v=vs.85).aspx
`eq_`
It might be cool it both do a check here, logging to watchdog if it dosen't exist, and also to make sure on the config screen to do a validation that the file exists.
Any reason not to rely on __DIR__ for `../ezpublish` ?
if the filename is not look like an regular filename, include it in the baseURL
Again, Indentation/Whitespace
I agree with @davehunt that `feedback` should be removed. it reads more cleanly from within the test.
There is no longer a default value for the `file_ext` option, but I replaced literal values with %default in some other options!
It'll show up in the query string value, which is logged with LOG_INFO. This is just to show which code-path was taken.
Should this be a separate namespace? It's a different HTTP route, and that has its own namespace. Is there a dependency here?
Can we use the getGroupMembers function for this ?
This check is already done on line 89. 
Also, on line 89, it should be
```
if (err) {
 return callback(err);
}
...
```
Shouldn't this be indexResource rather than indexContent?

This type of stuff feels like it could benefit from a little bit of abstraction (perhaps some custom model/classes?).
```
var SearchResource = function(id, data, indexResource, indexMembers, indexMemberships) { 
     var that = {};
     that.id = id;
     that.data = data;
     that.opts = {
         that.indexResource: indexResource,
         that.indexMembers: indexMembers,
         that.indexMemberships: indexMemberships
    }
    return that;
};

..

MQ.submit(SearchConstants.mq.TASK_INDEX_DOCUMENT, {
    'resourceType': 'content',
    'resources': [ new SearchResource(contentId, null, false, false, false) ]
});
```
I've followed up on this as well.
node-gyp supports versions 0.6 and up
Since this method has a side-effect (opening an editor), maybe a better name would help. `withEditor` makes me think it retrieves the corresponding editor for a java element, and does something with it. `openEditorAndApply`? :)
Looking at the code in CmfGenerator I'm not sure why you can't just extend now and add that capability along with the content magic. Can you explain?
I like this. I would like the analogous production alias to get this same change.
This function needs moving, I'll have a look at defining a generic service find function that you (and my other code) can use.
GitHub markdown made your \<R\> invisible. Now I understand. Willfix.
Missing spaces around `else`
Set this variable to `null` is useless.
Growl goes to backward. try 6a44a79b54418eaf49974fe8d71b5154eb6c0a6e please.
It would be nice if you could also throw an `is None` check around the places where `bz2` is used so people don't start getting confusing errors. Maybe just throw `Exception('Install the bz2 module for bz2 support')`, or something.
Need to test that you can't select a production centre (check there is no select with name 'phenotype_attempt[production_centre_name]' )
You're in the json spec here. It should be JSON type, not XML type.
Посмотрите пожалуйста как реализован этот метод у других. Все гораздо проще.
Простите, у вас комментарий через почту пришёл в неизвестной кодировке, я несколько кодировок перепробовал, но так и не смог прочитать исходное сообщение. :(
согласен, исправил
заменятся 1 раз, функция возвращает уникальное значение, если не пойдет по второму кругу. Во всяком случае этот вопрос обсуждали на стековерфлоу со ссылкой на документацию =) Поэтому в контексте данной задачи - не пойдет.
Если уж вы описали данный метод в имплементации, следовало бы его добавить и в интерфейс.
Конечно же округленное, при чем в меньшую сторону
Well it's an add-on and I was thinking that maybe it should even log to xbmc.log because that's where people will look if something goes wrong. What do you think? Or is /var/log standard practice for loosely coupled add-ons like this?
Anyway, gonna have to change the log-level.
You need to include your full email address here.
In a future rev, I would like to see us make this more generic, having a app-wide filter with controller-specific behavior feels wrong - but if all else works, I am fine leaving it for now, lets just revisit it later
can inline the `if`. personal pref :smile:
the ``catch`` should be on the previous line
actually, maybe row-resize would be even better
You should punch him in the face.
On Dec 13, 2012 6:57 PM, "Mark Lavin" <notifications@github.com> wrote:

> In email_reports/models.py:
>
> > @@ -63,6 +63,7 @@ def get_path_to_pdf(self, user, view_args={}):
> >          p.communicate()
> >          return tmpfilepath
> >
> > +
>
> I'm not sure how to take that comment.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dimagi/email-reports/pull/3/files#r2411649>.
>
>
Missing a space between `){`.
fixed in the next commits
We do do that, just not documented :+1:
I think 'governing-periods' would be a nicer URL, i.e. consistent with the slugs.

I'm pretty sure you can use `:as` on the `resources` call, i.e.

```ruby 
resources :governing_periods, :as => 'governing-periods', :only => [:index, :destroy]
```

However, since we're only using two actions from the generated resources and creating a third one, it may make more sense to just create all three manually.

Also, if you look at `rake routes`, it's not common to have a custom URL helper (`:as => :update_governing_periods`) for the update action, since tt's just a `PUT` to `governing_periods_path`. We should follow that convention here.
need to make this more portable, what about dynamic dns?
This logic is repeated quite a bit, why not abstract it?
minor: space before CodecPool.
You have to exclude non-published and deleted resources here.
On second thought, I guess it makes sense to have it be a mask since "drop" is in the name. I'll get over it :)
Are we doing validation elsewhere that these items are well-formed? Because otherwise, this would be a good place for that perhaps? What happens if someone does: `receipt[target]`?
I see.  There's a problem there though, because by that point, the body has already been (attempted to be) parsed.  If POST_DATA is false, it shouldn't attempt to parse the body at all, since it's not going to use it and parsing the body is quite expensive, requires creating extra buffers etc.  And it's still attempting to parse any content type other than multipart/form-data as application/x-www-form-urlencoded, it should only attempt to parse x-www-form-urlencoded if the body is x-www-form-urlencoded.
you need a ``versionadded`` note saying it was moved to the component in 2.1 only
What if the username or password have the literal ":" character in them? Shouldn't this be encoded somehow?
Do we really need this require?
Nope, this is a problem with the helper library itself
Absolutely right. the lazy was a C&P from the other router def, where I threw in a lazy as a workaround for initialization order. I'm not saying it's nice, but it's a WIP.
`to.equal 'fake-id'` - I don't think you need `be`
This is the fix for your autocomplete problems. The File Tree's fuzzy matching replaces browser autocompletion.
comme indiqué dans l'autre pull request, on pourrait plutôt avoir un abstract public function getSelector() retournant l'id du  dao. Cette methode étant générée par jDaoGenerator (lignes 120-130)
Точка с запятой лишняя.
Можно и не обрамлять круглыми скобочками, тащем-та.
Acento en "números". (Ya sé, soy un forro por las cosas que corrijo.)
I'm not certain on that, I will ask Renee :)
why not caching this ?
replace "Content-type of text/plain or text/html" with " text/plain or text/html Content-type"
url should be generated outside
This should be

```java
   return geopoint == null;
```

but as I wrote, the semantics of this are questionable…
Never mind its been updated..
can u explain the logic behind this?
Hmm.. for some reason this notation doesn't write the entries and it'll fail the functional test.
it's not an appropriate time to make a release.
I would have waited gladly on the master change, but it already happened: the query module is broken right now.

Depending on the snapshot fixes the build, which is currently broken.. since we're not releasing Infinispan 5.2 final very closely, IMHO taking the snapshot is the lesser evil.. I'll fix it as soon as we do have a release.
You should throw an `HttpException` is possible. This while help when debug is enabled.
the Sf2 coding standards (used by Assetic) don't add use statements for classes of the global namespace.
Meh… I think I was going to do something with the var… and then just didn't.
Notice that this line probably puts the scuppers on including the boilerplate script in setup.py (at least before building the c code) in the future.
What? I do not understand this line. Can anyone explain what on Earth `b'.'` is?
rename this to rc_file, to be PEP8 compliant and consistent with the other functions around it
to be safe, I would add this line to the destroy function as well just in case
What should it check for? We just need to be sure that the values coming out are doubles, right? They could come in as other things. @danhammer we ran into a bug for this. Can you remember why we switched this to `(double ,,,,,)`?
@apex13 Many of these styles seem to be duplicated in `lhnavigation.css`, `sakai.base.css` and `dashboard.css`.
We should figure out which ones are actually applied & move everything to `dashboard.css`.

![Duplication](http://f.cl.ly/items/0a1V3U0h11190C2c1J2J/Screen%20Shot%202012-05-24%20at%202.24.04%20PM.png)
I'm actually using my own CS, and usually keep spaces around `` ! `` :)
@lisitsyn This class is more "empty", it allows more flexible control over how the multiclass machine is trained and applied. While CMulticlassMachines abstracts common patterns that includes OvR, OvO, ECOC, etc, we need more flexible control for CPT -- both tree-structure and online, quite different from previous MC machines in shogun.
Now I updated to use the CMulticlassEvaluation's conf mat computing.
some documentation please :)
something is weird here with the indention...
Let's use `opts['media']` format instead of `opts.media` to make it explicit that the compiler shouldn't try to rename it.
settrue -> set_true ?
This is no longer absolutely true, I'd move this comment down to where we're calling __wt_tree_walk the second time, that is, explain why it's necessary to do that in some cases.
Are you sure ``$injectionMethod`` has the correct type as "integer|string" is not a sub-type of "string"?
Very well. Eh, I think perhaps we should just leave this plugin code as it is. It works, and it isn't overcomplicated. We can just let plugins and their infrastructure evolve as needs be. We have a Plugins section now, anyway.
We can't accept samples with advertisements.
See earlier comment about commenting style.
I worry only technical users will know what this is. At the very least, should add some tooltips to all these, explaining how they're used.
Looks like some extra indentation there.
It seems I'd originally intended for people to write their own tests here, but I agree it's better to just put the tests here directly. We should remove the above comment, though :)
Does this line actually work?

I would think that you would need to either use a typed get-input method like `getTcpInput` or case the input to `TcpInput` explicitly.
Simplify. I would use only by alphabet.
Use transblock tag and pass url and name as parameters. You cannot concatenate strings like this because maybe in some language it should be displayed differently. Sam for date above.
OK, let us go step by step. First make signals where you provide Python object as an argument.

Then somewhere else, on the place where you hook into the signal, you want to use `send_update` method. The question here is, what exactly do you need on the client side to retrieve? Do you need whole object? For now, you can manually construct the dict from the object, so map object fields to dict fields and put that as an argument. Add a TODO that you have to be using Mongoengine serialization, to be consistent. But again, if you really need a whole object.

And I am not saying that you do a real HTTP request, just that you a bit misuse the Mongoengine workflow to get JSON.
It's highly recommended to use camelCase in javascript: postStatus: 'ACTIVE'
Okay, alls is fine :-)

I tested this and indeed `--enable-aqua` works as advertised and `:x11` is needed too because otherwise I get a build failure.
Missing bracket, and this should be: `if ('pdf' !== $request->getRequestFormat()) {`
So I fixed the if statements everywhere except here. Should all those if statements be 3 liners? or would it be ok to leave them as 1 liners here?
> Can you not do the same thing with:
>
> %message= errors.full_messages.join('. ')

Hmm, I don't think so. With this code, the last message won't have a dot at the end of the sentence.

The purpose of adding a dot was to make the messages appear as sentences (because Rails will give you just messages like "Name can't be blank" <-- without dot at the end), and the purpose of the join was to join the sentences together separated by spaces. So in case we want to make it into sentences, we either loop twice or loop once and then append a final dot. The first solution is clearer in code,  the second saves cycles, but I don't think it's going to make any difference. The computational complexity still remains O(n) and the number of errors will be usually < 10, so I'd go with the clearer solution.

> Also, I would suggest changing the delimiter to something other than ". " It's possible that this could appear one of the messages. For example at the end of a sentence. This makes it difficult to parse the individual messages in the client. How about splitting on newline or semi colon?

I'd rather go for semicolon then :)

> Lastly, I'd suggest using "#{message}." It's safer than using + (it will not raise exceptions when message is not a string).

Nice, thanks :)


So I'd make it either this:

    %message= errors.full_messages.map { |message| "#{message}."}.join(' ')

which would return string more friendly to a human:

     <message>Pool can't be blank. Name can't be blank.</message>

or this:

    %message= errors.full_messages.join(';')

which would return string more friendly to a machine:

    <message>Pool can't be blank;Name can't be blank</message>
Is it really necessary? Are we using these views now?
http://stackoverflow.com/questions/7982525/visual-studio-disabling-missing-xml-comment-warning

It seams that it is, I though that I remembered another one but stackoverflow does not agree.
As an HTML pedant it bugs me that Sharethis insists on using non-valid element attributes.  But that's something I'll have to just pester them about :)
Removing this file definitely makes sense b/c of the Horizon cookbook...
array(
    'object_manager' => an instance
)

It has to be an instance, not a string, so it's type hinted.
@basz try to test the single unit. See comment on PR, since I think that must be enough to ensure it is working. The url view helper can be mocked so you test the input and output. Same holds for the view, just test the call is made and don't test that black box itself.
doesn't exist :)
avoid direct paths to things on your disk? I replaced this by `/path/to/chaussette` in the master branch.
I think by watcher -- since this is linked to the frequency of the process streams (and their number)
seems like a bit of overkill to me...you must have figured it out since you
knew it was testing. Remember, everyone writes code their own way and in
their own style. I sincerely hope you don't think that our code is going to
look like yours. Frankly, if it works, I'm happy!

On Sun, Sep 16, 2012 at 11:11 PM, Todd Pickell <notifications@github.com>wrote:

> In
> GroceryInventorySystem/GroceryInventorySystem/GroceryInventorySystem.cpp:
>
> >  using namespace System;
> >
> >  int main(array<System::String ^> ^args)
> >  {
> > -    Console::WriteLine(L"Testing GitHub / Pivotal integrationn");
> > -    return 0;
> > +Console::WriteLine(L"Testing GitHub / Pivotal integrationn");
>
> If this is for testing purposes surround it with comments stating so
> before pull request.
> /*****. Testing item class *****
>
> Code here;
>
> *************************************/
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/myappleguy/ciss243Final/pull/3/files#r1615873>.
>
>
Can we pin it to a specific tag, or if not, a specific commit hash? We don't want a breakage to happen without us changing anything :)
True, yes.
data/modules/StationRefuelling/StationRefuelling.lua already does this.
this bumps the requirement to PHP 5.3 on windows.
this should probably come from the config value of the routing bundle. but thats a viebundle issue, not related to this merge.
It is probably more than good enough to be a function. I'd considered the case where you could define a "5-pointed star" object, and then draw it everywhere. But making it a function is good enough for me.
Oups, on it's way.
There is a typo in [runit template](https://github.com/Fewbytes/redis2-cookbook/blob/master/templates/default/sv-redis-run.erb#L3). It has been already defined in [package recipe](https://github.com/Fewbytes/redis2-cookbook/blob/master/recipes/package.rb#L7).
Hmmm, added a comment which vanished, so apologies if this appears twice.  I think this makes sense.  Am I right in thinking that the sorts of SBProfiles for which the flux is *not* exact are those with negative regions (either due to noise or the choice of interpolant), as discussed below?

For all-positive SBProfiles, it seems to me perfectly reasonable to ask the user any user who wants Poisson shot noise in the total flux to set N = flux and draw N from a Poisson distribution itself, before calling a shootDraw() method.
Ah good point, will change...
I think you don't need this file as it does not appear in the opam file anyway
can remove this later, just transition code for this switchover
I'd prefer ImmutableMap rather than MutableMap. I don't think start() doesn't modify the locations arg passed in, and I'd like to keep it that way!
Why does this URL not need to be prepended with "application/"?
Suspect this is just my lack of familiarity...
This one I'm very passionate about, actually. You seem not to have understood it properly, so I'm glad you brought this up.

I use `do` notation to indicate that I'm invoking functions for their *side effects*. I see the operation of using a function for its side effects as a completely different operation from using a function as a method of modularising and de-deuplicating (DRYing) of code. This intent should be represented with a different syntactic form, even though it produces the same JS output. So I would never write `if do @animate`. Check out the other places I made this replacement, it should make more sense now.
Ah! Okay, I thought you just didn't like my idea. :P

Mock returns the mock object as the return value of `patcher.start`. `mock_browserid` uses this to alter the return value of `_verify_http_request`:

```python
def __enter__(self):
    self.patcher.start().return_value = self.return_value
```

So what you can do instead is store it in a variable, and then return it. The value returned from `__enter__` is used as the value assigned by the `as` clause of the `with` statement. 

Then, in `__call__`, retrieve the mock object in the with statement:

```python
with self as _verify_http_request:
    return func(*args, **kwargs)
        return inner
```

Then add a kwarg to `__call__` and check that to see if you should include `_verify_http_request` in `args` (I suggest including it at the front of the list, since that would match mock convention).
Nit: Spaces around plus.
Валера казав, що краще це робити в конструкторі
You don't need to dynamically load the abstract model - you can import it the normal way.  Oscar doesn't support overriding the abstract models themselves - they are meant to be subclassed explicitly for that.
Is this one of the places where we use different json libraries, or will this always be the stdlib json? Are we sure that it never returns unicode under Python 2?
Can you add a comment mentioning the reason for doing it this way?
I don't see where `len` was defined. Should it be `rows.length`?
This totally works but I think you have an opportunity to create a more robust method if you were to just call it `validate` and pass it a hash as param.  

You can pass whatever params off to Galaxy validation w/o caring what's in the hash.
修正ありがとうございます！
上記の条件を要約すると「該当のプロジェクト(通常のプロジェクトor個人用語集のプロジェクト)に所属する glossary_source が一つでも残っているか」ということになると思うので、それがメソッドに切り出されて、このメソッドでは以下のような感じで1行で済むと良さそうです！
`delete_glossary(glossary.name) unless glossary_source_of_the_same_project_exist?(glossary_source) `
i would use a greater_equal here (or less_equal and switch the parameters)
in some edge case, all of the apps could be the same price.
Ok I will make the necessary adjustments
We should add some spaces around the locator here.
> ホットリローディング処理

確かにいきなり出てきておかしい気がします。自動再読み込みと変更します。

> 本コマンドによる

「このコマンドによる」の方が自然かと思いますので、変更したいと思います。

> WARファイル配置

「の」が抜けていました。修正します。

> 面倒なWARファイル配置などの実施もなく

ご提案頂いた文章の方が自然かとお思いますので、修正したいと思います。
Just FYI there is also a `messages.info(request, '<message>')` shorthand
Would this work? I don't this it will?
> ahojnnes: Concerning peak_local_max: You mean returning the coordinates of the very one centre-of-mass as opposed to returning the coordinates of all pixels, if peaks are flat (i.e. multiple pixels have exact same intensity)? (NOTE lines 13-14 of current peak.py)

Yes, that was my intention. But we could also add another wrapper function around `peak_local_max` called `corner_peaks` which applies the center-of-mass approach. Because corner detection makes IMO no sense if multiple corners are returned in the same "neighborhood".

> PS: How do you markup a function name so that 'peak_local_max' displays like in your post? Thanks.

Could you rephrase this sentence, please? I'm not sure what you would like to express here.
I would use fast_svd as the default, as it is better if the default options work with both numpy arrays and sparse matrices...
What happens with the deletion of documents? Don't we update it in this case too? I would combine both in the first if condition because admins should be able to do so.
Please use `sizeof()` instead of `count`.
This will be changed in the new branch 'chore/improved-build-screen
This line shouldn't change.
I don't think there's an official policy on this, but returning `ErrorExp` forces code to avoid blindly assuming the new expression is value.  I think there is an `isError` function somewhere which checks for either `e->tok == TOKerror || e->type->ty == TYerror`.  But considering how mishandling only ever causes mild diagnostic bugs...

> `Error: cannot cast _error_ to ubyte[]`

This `_error_` can also be avoided by saving the expression/type.
At some point we can work out a proper policy for this and make it consistent throughout dmd.

>But why are there at least two ways of flagging errors in DMD? :)

Yeah, at least three if you include manually checking `global.errors`.
I'm pretty sure that instead of checking for kqueue, you can just see if `__linux__` is defined.
It's not shadowing another variable afaik - I moved the definition from before the if into the only branch it was used in.
I _thought_ had to be an asboluate OS file system file path., so would need to differ depending on whether run on Win/Lin.

I can look at IFileDescriptor::setDefaultDir impl. again..
Note that I have removed the ```-legacy``` argument, as discussed before. I'm not sure that, or in fact, any other argument above, is actually correct. They were extracted from ```regress.bat```.
Would be a good time now, to use IArrayOf<IPropertyTree> wouldn't it?
(not sure what the <StringAttr> reference referred to)
I should say though, that the link is currently builds.rss so we either need to change it in urls.py or in the template.
I did try but it did not create the two rules...
Typo: s/classes_prefix/class_prefix/
yup. Im removing it in fact since we decided not to do service management connection strings for now.
This is backwards incompatible no? Consider

    table = MyTable([...], sequence=('foo', 'bar'))
    table.sequence = ('bar', 'foo')

The updated `table.sequence` won't be honored.
please typehint the array
I'd say a talk about using cloud storage services is a perfect match for DevOps track.
Maybe you can just break here to end the loop
This will break 1.8 for sure.  It's rather important to fix this.
He is in Author?
Because we always need the last row of the A matrix. In case of the affine transformation we would have to write ´range(6) + [8]´.

Renamed the attribute of the polynomial to `_params`.
I tried to motivate with a failing test, but it turns out `_.each(undefined, function(){});` passes silently.  I agree that explicitly initializing bindings in the constructor is more clear anyhow.
Just noticed that this spec is commented out. Should it be removed or uncommented?
Please can you add 2 more space in front of this line. We follow PEP8 which says 4 spaces for softtab
That's what I had before, but Matt Amato thought it would be good to make a public class for it since the values `bottomLeft` and `topRight` were not well exposed to other classes (unless someone looks at the object inside TextureAtlas directly).
Well, I took off the `c` suffice and just added `Cartographic` this seems to be the pattern we've been following else where the "default" functions always use `Cartesian` and if we want a version using `Cartographic` we just append that to the name.  I'm up for other ideas, but at least we're being consistent right now.
Why create `description`? Why not pass the object literal directly to `ExtentTessellator.compute`?  Less is more.  Less named variables.
So the conclusion is to get rid of `TextureCoordinateRegion2D` and use either `Rectangle` or `Cartesian4`. I'm sort of leaning towards `Rectangle` because it is more explicit about what the data means, however `Cartesian4` would be a bit easier to integrate into the existing code. @pjcozzi, I don't know what you mean by `" since this is Renderer level"`. Both `Rectangle` and `Cartesian4` are in Core.
Are you sure you want to publish all of this?
Looking at our code it appears to work in Android as well.  Also your demo code (when run on device) indeed shows a difference between #f0f and #5f0f.
Because on iOS, the property "error" is a string. I deleted these and put all those info to a string for parity with iOS.
Can you use "${entries.length}em;" instead?
There is really no reason for the parenthesis.
Fixed in 8b9c05457b43aed5e6810d39c69b8f0d64d77c91
У тебя редактор отступы что ли не умеет контроллировать?
can also be interpolated
Sure..

Matches what I do in rake tasks... might as well be consistent.

Thanks

On Fri, Feb 24, 2012 at 1:39 PM, Dylan Smith <
reply@reply.github.com
> wrote:

> > @@ -25,6 +25,9 @@ def add(connection)
> >          config = {'protocol' => 'https'}
> >          config['domain']   = ask("Domain? (leave blank for
> #{connection}.myshopify.com)")
> >          config['domain']   = "#{connection}.myshopify.com" if
> config['domain'].blank?
> > +        # this next line allows us to name a site ccm when the actual
> is coolio-coolio-manna, so we talk to coolio-coolio-manna with cli.rb
> console ccm
> > +        config['domain'] = "#{config['domain']}.myshopify.com" if
> (/\.myshopify\.com/ =~ config['domain']).nil?
>
> How about the following instead?
>
> ```ruby
> config['domain']   = "#{config['domain']}.myshopify.com" unless
> config['domain'].include?('.')
> ```
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Shopify/shopify_api/pull/15/files#r486362
>
Good point, thanks. TBH, I copied it from repo controller spec and I'm not very happy about that.
I think using `static if` would have been a lot more appropriate here and in the destructor.
Totally agree. The variable was named "r" at first, so the comment was needed.
> Because you are assuming that any multidimensional static array has to be static array. Is such relationship of these terms stated anywhere?

Are you even listening to yourself here? Asking whether a multidimensional static array has to be a static array is like asking whether a yellow car has to be a car or whether a tall building has to be a building. It's a static array by definition. It's just a particular type of static array.
You can define `isAlgebraic` template like follows.

``d
private template isAlgebraic(Type)
{
    static if (is(Type _ == VariantN!T, T...))
        enum isAlgebraic = T.length >= 2;   // T[0] == maxDataSize, T[1..$] == AllowedTypesX
    else
        enum isAlgebraic = false;
}

unittest
{
    static assert(!isAlgebraic!(Variant));
    static assert( isAlgebraic!(Algebraic!(string)));
    static assert( isAlgebraic!(Algebraic!(int, int[])));
}
```
I've requested a backport for 3.1.3, but I am not sure when that's going to come out. It might be that Spring 3.2.0 comes out before 3.1.3 does. At any rate, it's out of my hands.
"All those objects can be used in the models and they get in the generated list of OpenEngSBModelEntries generated by the getOpenEngSBModelEntries method."

Maybe reword one generated to "created"
could this be a case for single-shot actors instead of futures?
You've removed the NS part of the attribute, why? That is more than a refactoring, and could potentially cause regressions.
Not sure it's better or worse, but we could try something like:
```
environment = raw_input(_("Environment") + ': ').strip()
```

The appended ': ' is a little weird, and wrong in a few locales, but it should pick up that translation.
There must be another way to get this working without using an a tag with a dummy href.
We should make this line <80 chars long
Problem with this assertion about MAX_PATH is that *W winAPI allows calls with long names up to 32768 wchars if
UNC path is used.
Either way there are 3 ways out:
a) always use malloc+scope(exit) free
b) use alloca as 32KB on stack is fine (probably not), but at least test for exceeding this length.
c) use alloca if size is small (e.g. <256) and malloc + scope(exit) if bigger.
MINOR: Refers to log_entry_buffered.h instead of log_entry_buffered_tests.h in comments.
Same NPE worries.
I guess it really doesn't matter, but they'll keep bouncing around if we don't agree on a convention.
We crossed paths, I just replied to Gary's comment so please read.
looks like there's a period within after.-commit
How about giving the .titleText td "vertical-align: top"? The title position would be fixed in this case.
Well, I generally enable only metadata API on my compute nodes and the others APIs are enabled on controller nodes, but it might indeed be more compatible to enable all APIs by default. Thanks.
I had tried with "Chef::Resource::File" and "Chef::Provider::File", its still throwing error. Reverted back code to use "FileUtils.rm_rf"
why do you ignore ``web/js`` and ``web/css``?
` zf2-tutorial/module/Album/test/Album/Model` > `zf2-tutorial/module/Album/test/AlbumTest/Model`
AlbumTest/...
Already inconsistent throughout, suggest we leave this issue for now
Please revert this. You are reverting the previous update
Cum apare în html? Ideal ar fi `<input name="personal_name_title" autofocus>`, adică să nu fie `autofocus=""` sau ceva.
Ther are so many similar lines above! I'd use some common getter and setter for all those properties.
зроби символічним лінком на оригінальний конфіг
Don't bother with this assert.  More pythonic to not strictly enforce the type.
RetunValue=ReturnValue

How about `requiresReturnValueValidation()`, `requiresParameterValidation()` etc. for the example method names?
unless you plan on writing native unit tests for this extension, you can remove this folder
чому comments?
It's useful if a user type a command with the name argument of a non-existent route.

``` bash
$ ./app/console fos:js-routing:debug non-existent-route
```

I think it's better to tell the user that the route do not exist. If the route exist, then I check if it's exposed.
This plugin shouldn't depend on jQuery.
Not needed.  Just have a `self.authentication` set in `__init__`