Added HttpCache\Store::generateContentDigest() + changed visibility
merged branch lolautruche/httpCacheStoreExtendable (PR #6016)

This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes #6016).

Commits
-------

9b0cad4 Added HttpCache\Store::generateContentDigest() + changed  visibility

Discussion
----------

Added HttpCache\Store::generateContentDigest() + changed $root visibility

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
License of the code: MIT
Documentation PR: -

## Description
This PR adds 2 small changes in base `HttpCache\Store`:

1. Adds `generateContentDigest()` protected method, allowing to easily override the default behavior for special cases.
2. Change `$root` visibility to *protected* to let descendant access it.

This allows special implementations of HttpCache when storing specific cache files in a different place is needed.

## Example
An example of implementation can be found [in eZ Publish 5 source code](https://github.com/ezsystems/ezp-next/blob/master/eZ/Publish/Core/MVC/Symfony/Cache/Http/LocationAwareStore.php). In this example, eZ Publish content cache entities are stored under a different folder than regular cache entities in order to ease cache purge based on a content location.

## Testing
No unit tests were added since the behavior didn't change and the new method is protected.

PS : It would be nice to have this in 2.1 branch as well :smiley:
fixed docblock return type
Fix docblock in Doctrine Bridge
[Routing] Fixed undefined variable + typo
Fix PHP 5.4 segfault
remove logic that could not be triggered anyway

the regex by the compiler is always valid. even if it was invalid like '' it wasn't caught by the exception and would have given a php notice.
Merge pull request #2 from Tobion/patch-2

remove logic that could not be triggered anyway
merged branch pborreli/patch-3 (PR #6038)

This PR was merged into the master branch.

Commits
-------

a146156 Merge pull request #2 from Tobion/patch-2
38802ea remove logic that could not be triggered anyway
f7ea68f [Routing] Fixed undefined variable + typo

Discussion
----------

[Routing] Fixed typo + removed dead code

---------------------------------------------------------------------------

by Tobion at 2012-11-17T16:00:04Z

@pborreli: pborreli/symfony#2

---------------------------------------------------------------------------

by pborreli at 2012-11-17T16:02:08Z

@Tobion totally agree, tried to setup a phpunit test which could trigger this exception but couldn't ..
merged branch pborreli/fix-travis (PR #6039)

This PR was merged into the master branch.

Commits
-------

9843d29 Fix PHP 5.4 segfault

Discussion
----------

Fix travis PHP 5.4 segfault

This is a well known issue :
https://bugs.php.net/bug.php?id=53976
https://bugs.php.net/bug.php?id=51091
merged branch nomack84/fixed_docblocks (PR #6033)

This PR was merged into the master branch.

Commits
-------

644de74 Fix docblock in Doctrine Bridge

Discussion
----------

Fix docblocks in Doctrine Bridge
merged branch eriksencosta/patch-2 (PR #6032)

This PR was merged into the 2.1 branch.

Commits
-------

0b088ec fixed docblock return type

Discussion
----------

fixed docblock return type
Improve docBlock
merged branch lanthaler/master (PR #6030)

This PR was squashed before being merged into the master branch (closes #6030).

Commits
-------

749dac1 Improve docBlock

Discussion
----------

Improve docBlock

This is just a minor change documenting the return type of `SerializerInterface::deserialize()`.
Renamed variable for consistency
tiny refactoring for consistency
[DI] removed unneeded is_object() calls
[Routing] fix Route recompilation when hostname changed
merged branch Tobion/patch-4 (PR #6058)

This PR was merged into the master branch.

Commits
-------

acf8a70 [Routing] fix Route recompilation when hostname changed

Discussion
----------

[Routing] fix Route recompilation when hostname changed
merged branch Tobion/is_object_instance_of (PR #6051)

This PR was merged into the master branch.

Commits
-------

966e7d6 [DI] removed unneeded is_object() calls

Discussion
----------

[DI] removed unneeded is_object() calls

I searched through all of symfony for occurences of the coding style `(is_object($value) && $value instanceof Object)` with a regex like `is_object\(\$[a-zA-z0-9]+\) && \$[a-zA-z0-9]+ instanceof `.
The `is_object` calls are not needed in this case. Only the DI component made such duplicate checks.