labofsahil/github-event-dataset-2012 huggingface dataset:
@ghalliday @richardkchapman 
Although this is not a pull request, please review that these eclagent changes are appropriate for the proposed roxieMem OOM callback enhancements.  In particular, do I need to synchronize the spilling (freeBufferedRows) to not overlap with the addRow/sort logic?
I just was shocked by why you call stokc level qty and not simply stock?
BTW, worth checking out: an open-source node hosting platform: http://nodester.com/
I know you're a busy person, but thanks so much for your help along the way. 

BTW: how often do you come out to the east coast and do you ever do any speaking engagements? I saw a video of your talk at Huge last year (http://www.ustream.tv/recorded/15819869)

I work for a web shop here (www.rosetta.com), and I have been trying to be some sort of evangelist for more forward thinking design techniques. I work in my company's NYC offices surrounded mostly by graphic designers. Besides the usual web development responsibilities, I also work directly with the designers and art directors trying to educate them about designing for the browser vs. designing for print. For many of them it's a big paradigm shift in thinking.

A talk from a person such as yourself would certainly help build on the ideas that I have been expounding.
man that looks tedious :-) Thank You!
What does "substantially the same" mean?  (equals, congruent, determined by ...)
um pequeno aviso, espero q quando alguem use um generate q por acaso gere testes desnecessários (controller, view, routes, etc) ou arquivos como o de Factory que pode dar pau, por algumas estarem em mais de um local, apague os mesmos.
You also do this in the custom_on_send_message method, so this probably happens twice now?
[I called it last year!](http://mths.be/151370448070914048)
http://www.nancymargulies.com/
What I get for only spending 5 minutes on it. Good catch.
@dprince - fair enough, just wanted to double check. Otherwise seems good to merge when you are ready.
Was this introduced from porting Ant to Shifter?
There may be very specific use cases in which the extreme hackery in `gallery-soon` is worthwhile, but as a general-purpose utility in YUI itself, it would give me the willies. It's the most micro of micro-optimizations, and I don't think we should encourage its use by anyone who doesn't completely understand its black magicks.

It's clever as hell, but it's also relatively large for such a simple purpose, and it's edge case city. Maintaining browser compat and ensuring proper test coverage seems like it would be a nightmare.
What did you change here ?
also, why haven't we specified type on all these? boy scout!
I think you want to return `true` here?
not as far as I can see: why?
How would you know if you were using scala.collection.Seq (which is autoimported by Predef) and immutable.Seq?
You're right. With the val in ReflectiveDynamicAccess(val classLoader: ClassLoader) we've just given a public guarantee that the classLoader is stable and immutable.

But:
  * We are saying we are dealing with DynamicAccess and not ReflectiveDynamicAccess

private val _pm: DynamicAccess = createDynamicAccess()
 def dynamicAccess: DynamicAccess = _pm

Here we have a mutable guarantee with the highest API being DynamicAccess#classLoader()

The compiler cannot change anywhere a dynamicAccess() is used to use a field of RDA. In runtime the JVM can.

If it would be def dynamicAccess: ReflectiveDynamicAccess then sure we've just given a more robust guarantee.

  * Our extended class was compiled from Java that has no notion of vals and thus cannot respect our Scala guarantee.

All this goes in favor in Scala should not decide to use the field. ;)

I just can't see this happening.

But ok, I don't like this either. It's a hack because I didn't want to duplicate RDA code and I explicitly didn't want to modify any existing akka code. It solved both.

What do you recommend we do?
What if heartbeatInterval is -1?
this makes no sense.
In the original code we sent the potentially wrapped "message" argument, but here we send the potentially unwrapped one. Is it guaranteed that the message is never wrapped in this case?
I tried to make the #cache-actor-setup self contained, but I guess it's not worth it as anyone should know how to create an actor system anyway. Good catch.
What about mutability of the Iterable?
ok, thanks, that is nice, I have changed to something like that

withDefault doesn't replace the `map(_ -> 0).toMap`, because that is the conversion from Set to the initial Map, but anyway it's a nice improvement to use withDefault
why not test actual communication with SSL? could include non-expiring certificates with the source.
I'll add a description here, it's number of connections.
That is a good idea. More actorish. But on the other hand I think a latch is easier to understand.
Both work fine; the only reason I prefer fmin is because it doesn't spew millions of "division by zero" warnings, which I find a bit disturbing.
Thanks for the notice! I've converted some list comprehensions to generators a couple of days ago in 2and3 branch ( https://github.com/nltk/nltk/commit/e92945018df7774b860643348b3740004fb92803 ), but this one (and several others) was missing; this is fixed in https://github.com/nltk/nltk/commit/89575bda2419f78746f864e6605a2e8538c017d4 (2and3 branch again).
Yes: this only effects Macs and Helvetica is a nicer font.
Yeah, that's more or less where I was going with this.  Doing it this way makes that obvious right off, so we want to design something cleaner and simple.
тут удалять нельзя. Этот декоратор используется для фильтрации персон. Не всем можно отправлять и получать товар. Если убрать этот декоратор, то даже только получатель будет видеть эту страницу.
We are not using Jgraph any more
1. Deindent ``node = node.parent`` so it only happens after the ``for`` loop.
2. ``return False`` after ``while``.
get{Something}Type(i)
This line can go away.
Can we just call this column `expires_at`?
User scoped?
Just a style improvement, I think we should use the actual record name and value names suggestive of what it is over a generic pattern.
I think you must revert this change, since what I explained here: https://github.com/HPNeo/gmaps/pull/116#issuecomment-8180379
was it needed for width calculations, or for min-width style on dom elements?
I think the getClone() should be inside the bracket e.g. getFitness().getClone()) and getPosition().getClone())
In the NSPopover API, a contentViewController change is animated.
This macro is no longer necessary, is it?
Whitespace noise. Happens in a number of other places as well (as trailing whitespace or otherwise).
The buffer flags seem to be defined in such a way, yes. (Not exactly sure why, but its used like that elsewhere and didn't work without).
отступ 2 таба
поля именуются с префиксом m
это поле и следующее тоже
Depends on how browsers behave when fractional seconds are given. I don't know :)
Shouldn't this be "Must have with_manual_interventions set to **true** for this test to run"?
Gotcha - updated.
Just curious: what's the benefit of creating two multi-column indexes here? Do they order differently on create and update? Or would they be the same exact index?

Also - watch out for MySQL; it will only use one index per table query. So having both indexes there would be an unnecessary cost to db performance. To account for this, you may have to create a method like def one_index_per_table_query?; false; end on the abstract adapter, and def one_index_per_table_query?; true; end on the MySQL abstract adapter, and use that method here to create only one join table index for people using MySQL. Tests would have to reflect that biz logic, too.
Sorry, it's just a detail but why we don't use 1.9 Hash syntax here ?
No newline at end of file :-1:
If you don't pass a project it blows up here with `UnboundLocalError: local variable 'project' referenced before assignment`. So you need to add an `else: project = None` or something like that above.
I think toOption and toSeq don't belong on Try, it's mixing concerns and one could argue why there is no toSet etc.
I suggest having the "to"-method that was recently added to the collections so you could transform a Try to essentially any container.
In that case, why not handle it more like emptyValDef, which is defined as
```
  object emptyValDef extends ValDef(Modifiers(PRIVATE), nme.WILDCARD, TypeTree(NoType), EmptyTree) {
    override def isEmpty = true
    super.setPos(NoPosition)
    override def setPos(pos: Position) = { assert(false); this }
  }
``` 
Make an object pendingSuperCall or something extend Apply(Select(Super(This(tpnme.EMPTY), tpnme.EMPTY), nme.CONSTRUCTOR)), List()). Maybe a little special handling in TreeCopiers is necessary (although emptyValDef seems to be getting by without it) but I think it would easily be worth it not to be constantly shuffling those meaningless nodes around. Given the amount of custom code involving the super-call, the least we can do is give it some identity beyond an agglomeration of application nodes and tpnme.EMPTYs.
sounds like something for another PR, right, @xeno-by ?
Don't mean to be terribly picky, but should this be a top-level private[concurrent] class?  Avoiding `$outer` in bytecode is ok by me...
after discussing with Martin we decided to rename this to `isParamWithDefault`
This logic is more simply put:
```
if (sym.name == name)
  reifyProduct(tree)
else
  reifyProduct(Select(qual, sym.name))
```
This is a workaround for the following error, which I am seeing when tox does `python setup.py sdist`:
    
```
      File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/archive_util.py", line 131, in make_zipfile
        import zipfile
      File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/zipfile.py", line 464, in <module>
        class ZipExtFile(io.BufferedIOBase):
    AttributeError: 'module' object has no attribute 'BufferedIOBase'
```

I am not too sure what causes this or why this fixes it, but I found it by Googling and finding another project on GitHub which did this to fix the problem.
ok, I understand now.  We don't use np.broadcast_arrays so far, IIRC, but it seems to be a good idea.
I like to indent to match indent from the beginning of the expression, I've fixed it here.
I guess that would work, but I don't see why `M[:, -1:]` should be different from `M[:, -1]`.  And anyway, that wouldn't work if I wanted to extract a column that wasn't on the edge.
This is from the merge with master. I am unsure why it shows up here but it should not be a problem.
yes, it's a lazily evaluated filter. At the moment though I can't see why we need to filter. This should probably just be `expr.args[0]`, no?
Coverage is a valid reason to move this to the next line. Fixed.


On Fri, Nov 2, 2012 at 4:15 PM, Aaron Meurer <notifications@github.com>wrote:

> In sympy/unify/unify.py:
>
> > +                    for x in _unify(aa, bb, sop, **fns): yield x
> > +            elif len(x.args) == len(y.args):
> > +                for x in _unify(x.args, y.args, sop, **fns): yield x
> > +
> > +    elif iterable(x) and iterable(y) and len(x) == len(y):
> > +        if len(x) == 0:
> > +            yield s
> > +        else:
> > +            for shead in _unify(x[0], y[0], s, **fns):
> > +                for x in _unify(x[1:], y[1:], shead, **fns):
> > +                    yield x
> > +
> > +def _unify_var(var, x, s, **fns):
> > +    # print 'UnVar: ', var, x, s
> > +    if var in s:
> > +        for x in _unify(s[var], x, s, **fns): yield x
>
> It originated from our code coverage checker, which cannot distinguish
> these two statements. So if the conditional is always false, it will show
> up as covered even though the yield is never run. Probably if the coverage
> checker were improved in this regard then little cases like this would be
> acceptable.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/sympy/sympy/pull/1633/files#r2021248>.
>
>
Generated from what?
All I found was PEP 257, which says use u"""Unicode text here""".  Not
sure if sympy has any conventions they follow with regards to unicode.

On Wed, Jun 20, 2012 at 4:30 PM, Jason Moore
<reply@reply.github.com>
wrote:
>> @@ -65,4 +65,74 @@ def set_point(self, p):
>>              raise TypeError("Particle point attribute must be a Point object.")
>>          self._point = p
>>
>> +    def linmom(self, frame):
>> +        """Linear momentum of a particle.
>> +
>> +        The linear momentum, L, of a particle, P, of mass 'm' with an inertial
>> +        velocity, ^N v^P is given by:
>
> @hazelnusse Do you know what the conventions are on using unicode in python docstrings? We could opt for using unicode superscripts, subscripts, etc. Then we can write readable text based simple math equations.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sympy/sympy/pull/1346/files#r1022731



-- 
“People call me a perfectionist, but I'm not. I'm a rightist. I do
something until it's right, and then I move on to the next thing.”
― James Cameron
I would have made the same remark if I had reviewed these PRs. There is no doubt that, on its own, `def` is more readable than `lambda`. `lambda` is useful to avoid disrupting the flow of the code, but in a class definition there is no flow to disrupt.
Very nice introduction!
There is no Doctrine_Entity, they are plain old PHP objects and will always be what is returned, the tests is pointless.
I have accidentally posted my reply in wrong place. It should be here: https://github.com/Pylons/Kotti/pull/158/files#L3R46. Sorry for that.
This seems somewhat doubled. Maybe start with all_results in the beginning?
Передавать logger
This TODO is a good idea - can you write this up as an issue?  Would be great to make this logic into scopes if possible so it could be reused in lots of places.
Unfortunately, I don't believe you can use CSS to control colours within a canvas, so they need to be in code instead.
This is probably the only one of these that probably doesn't have to be de-parameterized.  It can be nice to know the data source in the subject.
I think the form definition is confusing in this setting.
I think I still don't understand, even given the comments on line 109. Maybe revisit comments around #109 to explain why one might want two loggers, both pointing at STDOUT, turned on.
I would prefer the use of a more descriptive variable name. Yes, $it is short for $iterator, but someone else might not understand that.
On my system it runs the same. Running all dbal tests:
Baseline: 0:39
Sequences: 1:14, 1:34, 1:31
Seq w/trans: 1:25, 1:34, 1:31

The only way to get a performance increase will be to parse the fixture that was loaded and only update those tables.
The example clarifies that enough, imo

>> 
>> 	<div class="indent">
>> 		<p><code>$current_user</code> is right, but <code>$currentuser</code> and <code> $currentUser</code> are not.</p>
>> 	</div>
>> +	
>> +	<p>In JavaScript, variable names should use camel caps:</p>
> 
> Camel case can also mean the version with the first letter capital. Maybe mixed case? Or clarify that the first letter is not capital.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/phpbb/phpbb3/pull/779/files#r776309
Not a huge fan of doing two things in the initializer, iterator of a for loop. Just place above and inside the loop?
Aici trebuie rescris ca:

{% url challenge_stats op.0.id %} deoarece ai numit în urls.py challenge_stats, iar parametrul se dă în interiorul templatetag-ului url.
yep, cool
I don't see why the logger should be coupled to the backend. It seems like an orthogonal concern.
This is intentional so that we can mock out _doRequest. Before the unit tests were mocking out what is now _makeRequeset, which skips 90% of the logic in this library.
is this property still used?
Now that I think about it, I think the `require('yui/handlebars').Handlebars` is the more standard way of using YUI server side according to the docs. I'm not sure what the difference is though.
How does it get from request query string to template? I really doubt that this field has ever any other value then none. Does redirecting really work for you?
ahem ;)
Using statements should be places inside namespace declarations
suggested creating a var for this link elsewhere, in case it needs to be updated later
(could break it up, e.g.: MOTECH_SERVER = http://motech.rcg.usm.maine.edu/motech-platform-server/; and "formdownload" can be kept here)
I feel this is an unnecessary wrapping of a numpy function.
Correction - please could you convert to using http://pypi.python.org/pypi/mock
name null is an error -- doesn't pass "validate -- though I'm not sure what calls validate when. Here, I think we're just favoring a false return over risking an NPE under unpossible conditions. Would you suggest a better way? assert first, then test?
Writing `get_count()` in a way that would cache the count for subsequent calls would be the Django way. (for instance, it's like user.get_profile() works). This would free you from writing this loop multiple times in this module.
use the .exist() filter
`if Array.isArray` [would be better](http://perfectionkills.com/instanceof-considered-harmful-or-how-to-write-a-robust-isarray/).
can this ever be invalid deref?
This kind of stuff is useful for debugging. This way we *know* the handle has been disposed and the object is in sync. Is there a good reason to remove it?
Turns out it's not quite as simple as I thought...

Firstly - Yes, it's O(n), but, N is very small, and the way get_field_by_name() is O(1) is by pre-caching all possible lookups, so there's a first-call cache warming expense. In this usage, we're on a management command, and get_field will be invoked exactly once, so we're going to be in territory where the expense of cache warming to get the O(1) lookup will exceed the O(N) cost we're trying to avoid.

Secondly, it's not as simple as replacing the internals of get_field() with get_field_by_name(), because the cache priming in get_field_by_name() assumes all the models have been loaded (because it includes all reverse FK and M2M relations). get_field() only depends on self. This should get a little cleaner once app loading lands, but as it currently stands, it's difficult to guarantee that get_field_by_name() is actually callable.

So - I'm going to call this a no-fix; or, at least, a "not my bailiwick" fix. Meta certainly could be cleaned up, but that's a much bigger fish that needs frying.
This will store references to iterable content which has `close()` method, so we can close them after the are iterated.
this should be ``2.4`` as 2.3 is already in RC and so new features cannot be added in it anymore
Tried everything and I couldn't get it to work...
The reason is that selectors often have common parts. It is currently a common occurrence. However, since most (maybe all native Sizzle?) selectors go through `select`, this way may be better.

Still, I'd prefer not to use `Token` anywhere but tokenize. The use case here is not that a `Token` is needed. It's just that you want to pass `match` somehow to compile. It's not very consistent. I'd rather give in to a private var on `compile`.
I will add more check here.
I think you really mean "unmanaged resources" and not "managed objects" right?
I don't immediately see any other alternatives than nested for loops. Suggestions?

 Is this code hard to read, or just unfamiliar?
Extra : here.
on the cleanup branch I've moved all of this forms to a forms.py file. Do you still think we should move these two classes to another file (possibly  in another dir as well, something like ispdb/common/forms/ dir) ? Or can we let them on forms.py file?
right.  i was riffing of the old line which had ||0 but you are
correct.  even simpler.

j

On Sat, May 12, 2012 at 6:17 PM, Mike Perham
<reply@reply.github.com>
wrote:
>> @@ -274,7 +274,11 @@ def normalize_options(opts)
>>          Dalli.logger.warn "DEPRECATED: Dalli's :compression option is now just :compress => true.  Please update your configuration."
>>          opts[:compress] = opts.delete(:compression)
>>        end
>> -      opts[:expires_in] ||= 0
>> +      begin
>> +        opts[:expires_in] = opts[:expires_in].to_i || 0
>
> to_i never returns falsy so you don't need the ||
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mperham/dalli/pull/214/files#r812884



-- 
Visit http://bunnymatic.com
Yes, this works for both building from head and from the tarball.
May not need to force wrap here (say will do that)
because otherwise the line is waaaay too long.
and still there it's a bit too long
We can add one later if and when it makes sense to. It's not really core to this branch, and it'd be a lot of work to make everything that uses it consistent enough to actually use it.
Ok. will change.
"""
Return comments as an unnested, flat list.

Note that there may be instances of MoreComment objects. To easily remove those objects, use the all_comments_flat property instead.
"""
Il reste des "démons" qui n'ont pas été trucidés :smile:
jo stimmt
I'm :-1: on just about any helper method except for `current_user` - and in this case we're only actually using it once. Go ahead and move it to the Meetup class.
Like the following?

` wp user add_to_blog` --blog=<site> <user-login> [--role=<role>]`
yes of course.
I am going to add someting like this:
Both "org.apache" and "org.codehaus" are default providers of MOJO plugins which are especially dedicated to Maven projects.
The MOJO stands for "Maven plain Old Java Object".
Each mojo is an executable goal in Maven, and a plugin is a distribution of one or more related mojos.
For more information see http://maven.apache.org/plugin-developers/index.html
The tests are fantastic, thank you.

Just to be clear, they do fail without the changes to RunNotifier?
Doesn't this test still pass even if "withStacktrace" is removed above?
Can we please not have commented code? Either in or out...
Just write `Pause` and let people figure out how to unpause.
This might not work on small screen. You should test this with Firefox responsive design mode to ensure that it does.
Hmmm. It's interesting that tinycolor forces spaces between commas--that feels like something we should be able to preserve since it's really a stylistic issue. Probably a future feature though.

I think we should consider taking out the last two lines, since they seem redundant with what `commitColor()` is already doing. I'll try taking them out and test around it.
I don't think this could ever trigger any change events, so I don't believe it needs to be inside the _duringSync brackets.  It seems a little better to keep it outside that block -- clearer (easier to see why the flag is needed when it only wraps the needed code) and a bit safer (smaller surface of code that could throw & break the flag).
I originally thought a refresh() was required (and refresh also caused a re-sort). Turns out that sort() is all that was required, so refresh was replaced with sort. Please let me know if you see any problems with the functionality.
We can't add comments in JSON file as it can throw error on load. So we can add a comment here.
I am not sure if this needs to be uri encoded, so be sure to test files and folders with space characters.
Is this not just a bug in APF or something that these replacements don't happen automatically? These fixes look incredibly patchy.
Filter is truthy so the `!!` can be omitted here. Doesn't really matter tho.
Isn't the style attribute backgroundColor? Can you confirm that this works?
God doesn't run on Windows.
Maybe this should actually return the whole panel data frame - then there's a row for each panel in the plot.
Isn't it the original x's?  And `n` isn't used?
If you could avoid changing indentation like this, it makes the change easier to manage, and would be appreciated.
Should "" be "none" and you change "none" to ""?
Can you throw in a usage comment for this function too, like you did for `getTrackEvents`?
Looks like all of this was bumped to the right only one space.

Doesn't look like it needed.
We should probably start using some good Preconditions checking here - TODO for later - make sure negative values aren't put in here, etc...
Not important, but you can tighten up a lot of these match clauses by doing them on one line
This commit blows up datastremas when other properties are accessed. IT assumed a full array is passed in not a partial array, so changing other properties doesn't work when we do this.
Did you meant this to be an  ||=
I noticed that this currently displays this as "Make this my default organization" with a star following it.  If the star is filled in, that means it is the default org; however, if the star is not filled in, it is not the default org.

I wonder if the current text+star behavior might be confusing to users.  For example, as a user, if I am not familiar w/ the behavior of the star, I might come to the page and click it (when it is filled in) thinking that I am making this the default organization, when in reality, I am unselecting it.
Would a case statement work better here?
This test is incomplete: it will fail if newrelic is loaded on your server whereas a test for your fallback handler feature should be skipped in such case, not fail.
Don't String.Format the payload.
Yes, I agree - this is definitely not user-friendly at the moment.
I'm, of course, very opposed to a function. A factory class is very standard programming design pattern - it's not breaking any new ground. The docs should say

   This class returns objects that are subclasses of the abstract class SphericalCoordinateBase, for example
    ICRSCoordinate and GalacticCoordinate.

I think this is a serious case of preemptive confusion. Make it clear in the docs how it works and provide clear examples, and it will be fine.

Also, functions are not OO. Or, if you want to look at it from a Python lens, functions are objects just the same. Nothing is to be gained with a function except bad style.

@taldcroft I looked more closely at the link you gave above. It's describing exactly what we're doing here. The implementation is a little different, but the API has the same result.

Having the base class be the factory class isn't very clean. `Coordinates` is simpler than `SphericalCoordinateBase`, which isn't friendly.

Right now, the factory will return many different classes based on the input keywords. I don't see how it can (or should be) extended to every possible class we support. Let's keep it light now and extend where it makes sense later.
So at the moment, the file is only downloaded when ``read`` is called - do we want to change that here so that it always downloads to a temporary file (if no caching) and then opens with ``open``?
是不是该叫TimeBasedService？
Notice that get_return_values is sorting and uniq'ing to work around this problem (line 128). Would that not be enough?
TODO
Handle headers
Set the teacher(s) for these students
I like Logger
Were converters deemed not worth maintaining?
The simulation is passed twice because I need it for the Runner and I need it later to execute isSuccessful method. But I agree this looks weird.
remove the parentheses since it's just one line in the loop body.
Why not list all tfs remotes? granted, in most cases there will only be one, and it will be a parent of HEAD, so it may not be much different.
You'll want the `@skip_doctest` decorator I mentioned above here as well.
Which one do you want me to change it to? I'm good with any of the alternative you suggest. In my opinion, they are all the same in term of readability. Everyone can figure out that all of these means reading the first line (modulo some fine detail).
please revert!
It looks like there are a lot of additional changes to Nimbus in this pull request. Is it possible to single out only the changes necessary for the messagecontroller feature?
We could add another buffer... we should only get asked to fill in the buffer if there isn't enough already there which currently means a pkt-line would be larger than 2k, which while possible, causes other problems for the repo anyway (long file names).

The only way I see would be to keep this extra buffer here so we can fill that one instead, but that simply moves the problem to a bit later
Why is this error being set?
`#ifdef __LP64__` then.
None at all. Fixed.
None of these are html files, so they probably shouldn't be called like that. Call them addons.txt?
Remove this, as you already have something below that matches an empty path.
can't be.  the class web.application, exaspiratingly does not derive from 'object' - so it is not a "new style class"
Same for this. https://github.com/mozilla/zamboni/blob/master/mkt/ratings/tests/test_views.py#L97
Good!
Let's try with re-edit files.
Same as above for both here and below
I never used the `+` operator with arrays as I find it counter-intuitive. Can you revert this change?
should be named ValidationListenerTest
Ii should say `Boolean`.
hhmmm, so even if I am not a friend of someone I can still get all the comments she/he made. I think we need to change this.
Same as above: `initWithObjectsAndKeys:` or `@{}`.
```setNotificationSettingsForDistance ```  has been already defined on 118 and this line was duplicate - have no idea how did appear. Removed in latest commit.
Instead of the two `try`s, how about casting it as a string?

```ruby
email.to_s.strip.downcase
```
I agree with both of these comments. I just had an epiphany. The refactor continues! Stay tuned.
Don't know if this is better:

```ruby
"invitee_type <> 'Group'"
```
I'm not exactly removing this part, I'm going to upgrade `AvalancheImagineBundle` to `LiipImagineBundle` and reuse most of the code already present
vaccum operation should be done in a seperated commit, referencing #2974
Please confirm that no longer setting ```self.sct``` is intentional.
it'd be nice if this were already available, but that would need something like ModuleLoader or wahtever to create Routes and pass this into the constructor.
fă te rog fix-uri din astea într-un commit separat
Roger wilco.  PR will be updated once I get out of work today.

On Thu, Jul 12, 2012 at 10:14 AM, Peter Wagenet <
reply@reply.github.com
> wrote:

> > @@ -164,6 +164,8 @@ Ember.Application = Ember.Namespace.extend(
> >        this._createdApplicationView = applicationView;
> >
> >        applicationView.appendTo(rootElement);
> > +    }else{
> > +      Ember.assert("ApplicationView and ApplicationController must be
> defined on your application", false);
>
> Better yet, drop the `if/else` altogether. And move the assert up to where
> the `if` was.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/emberjs/ember.js/pull/1134/files#r1151704
>
We can still support legacy clients by detecting this parameter and adding a Stage.IMMEDIATE call to the ModClusterConfigAdd handler.
InterruptedException has a special meaning. It means a user is canceling an action.  Callers will likely misbehave upon receiving it. This should be a different exception.
You mean using setBbox instead of setting a public field? I like being consistence between the C++ and JS API. I am sure this is what we aim at all levels: finding the best mapping between the C++ and JS API. The alternative is to use a field and getters and setters on the JS side.
should be `data-z-index-level`, sorry about that.
@alivedise Done! Thanks for the tip!
Don't like the idea of making the postNewSuccess doing more things than tasks related to activities.

Also we don't need to reload the contact, when returning from the activity we will leave the contact app in the contacts list view, as long as we do the back as well.
Yep sure, I meant that. Just creating the issue in order to don't forget it.

I'll land as soon as @basiclines reviews the style
My physics is not good either :) I was thinking of 'bounce' of something like that. I think you want to do a bounce effect, not a shake one, right?
I don't like to include app changes in to this PR. It should be focused on `/shared/style/`, also that change makes that button lose the red color.
There is no new code for catching and displaying this throw? I have left Nan / Infinite as valid returns as they quite nicely toString as 'Infinite' which is then displayed
Why don't you use a mozSetting to cache the value for now? (not saying this is clean, just that it will avoid to open this little page - with all the overhead of a process - on every startup).
You can use an early return.
I would replace all the "else" following the format "} else {", just for being consistent across the app code.
If there is any chance that this line would cause gecko to free resources more quickly, I'd keep it in.  Doesn't seem like it could hurt anything and it might help with memory management.  (But I'm just guessing).
you know what, it's not worth it. i'll store the pk for now.
I can do even better:
```python
'logs': [LogRecord.getMessage(m)
         for m in self._stats_manager.logs]
```
This function takes the following arguments: `value, baton, callback`.
[See](https://github.com/redu/help-center/pull/6/files#r2120468). You wouldn't need to replace here with span if you had used a class. :grin:
It looks like there used to be `red`, `yellow` and `green` methods...can these be safely removed?
This is maybe just me, but I find (ag.reduce _) confusing when I know that reduce is arity 2. I guess it works, but it feels odd that it does.
Document this method and the arguments it takes.
This explanation doesn't mean anything useful.
Then erase it as an argument.
implements Named
Nvm, saw footnote.
Well, the resulting code under main would be rather large, and also all the stream vodoo happens there, so I ended up separating it.
I thought it would be more clear to have an advice in the base class for this?
type: OpenFire?
If it is not necessary, please remove it... having dead code around makes maintenance a lot more costly. :)
そういえばコンテナになる変数は複数形のほうがいいのではないでしょうか
Also what is 18 and 32?
Don't we *not need* this file anymore?  I thought we could just use the udp_client, and pass in the last argument.  If the udp_client already does what we want, there is no reason to add superfluous code.
we don't use in_addr_t anywhere, why is it needed here?
Hmm, maybe shouldn't use alert, as they mess up the draw loop. I remember when I was first learning Montage I ran into some weirdness by using alerts.
Missing `-` in `<-` in these two spots.
Honestly I don't see any value in making this prototype hierarchies. They just make whole thing look more complicated. This would have worked just fine:

```js
function cfxError(message, name) {
  var error = Error(message);
  error.cfxError = true;
  return error;
}

function InvalidArgument(message) {
  return cfxError(message, 'InvalidArgument')
}

function InternalCfxError(message) {
  return cfxError(message, 'InternalCfxError')
}
```
nit: `new function () { ... }` is less common than `(function () { ... }))()`
Otherwise, is it really important to hide `hasInterface`? Can't it just be a non-exported method inside of xpcom?
What about simplify in this way, and remove the `onload` variable as well:

    merge(content, {
      get onload() { return window.wrappedJSObject.onload },
      set onload(f) { window.wrappedJSObject.onload = f }
    });

?
It could be also be done using `this.unsafeWindow` that is shorter, but it's better avoid to have a dependency like that, even if it's a temporary fix.
The Etherpad suggests this must authed. Does that mean anything for the front-end call, or can I just assume that the server will return a failure if the user isn't authenticated?

https://id.etherpad.mozilla.org/primary-transition-ux-swarm
Hawt!
@6a68, @klrmn - it is fine to leave it as is here since this belongs to the upstream repo. To follow DRY, it should not repeated in the docs/TESTING.md file, but a mention with a reference to this file would be extremely useful.
Many sorries for overruling but if we're doing a click in the method then we name the method with click. That means the user action is clear in the name of the method.

We might use `go_to` if there is a `selenium.get` inside the method. but in that case there is no explicit user action, we're just skipping ahead to the url we want to test :)
do you mean the <section id> or the <script> , the arrangement was the same as the home index
can you add a blank line before `continue;`
Doesn't this create a global var?  It's probably best to just use the browser default.  Another framework could change this var and break functionality.
Personally, I prefer a switch() instruction for that kind of comparisons ($static)
I'd put a "break;" after line 168, and then you can lose the else statement:
```php
if ($value instanceof FilterChain) {
    $input->setFilterChain($value);
    break;
}
$this->populateFilters($input->getFilterChain(), $value);
```
I'm not sure if, from the performance perspective, is best extract the methods first and then do 'N' access to the cache (array) rather than test if the method_exists 'N' times
Can you come up with a better name that describes what this class is used for? Maybe TestTreeNode?
Is this TODO still needed? looks like you fixed it :P
TransformComponent has the following methods...

getTransform (old snapshot value)
getTransformLive (live value that is current of this tick)
isPositionDirty (if live != old)

You don't need to store position yourself.
The hot path is type equalness, which we probably want to optimize as much as possible. In the case of vType === pType, we currently do the === check a bit too often, and we set __proto__ to what it already was. You may want to consider restructuring it a bit for that.
`if (old) {` -> `if ( old ) {`
yeah but for link , thats a seperate field within the image plugin.  so, incorrect usage, no?
@anti Herrigyyd! Missä on yhtiö?
Could you check with him?

On 28 Mar 2012, at 17:56, sgilda wrote:

>> @@ -201,26 +201,41 @@ The README for each quickstart will specify which configuration is required to r
>> 
>> Review the README file in the root folder of the quickstart for specific details on how to build and run the example. In most cases you do the following:
>> 
>> +1. The command used to build the quickstart depends on the individual quickstart, the server version, and how you configured Maven.
>> +    * If you are running JBoss AS 7, it uses community artifacts available in the Maven central repository, so command line arguments are not usually required. 
>> +    * If you are running JBoss Enterprise Application Platform 6 and did not configure the Maven user settings described in [Configure Maven for JBoss Enterprise Application Platform 6](#eap6mavenconfig) above, you need to specify command line arguments. 
>> +2. The command also depends on whether you are deploying an EAR or a WAR.
>> +    * For a WAR, you can build and deploy the archive as one step or as two separate steps. See [Build and Deploy the Quickstart EAR or WAR in One Step](#buildanddeploy1step) and [Build and Deploy the Quickstart EAR or WAR in Two Steps](#buildanddeploy2steps) below for details.
>> +    * For an EAR, the build and deploy must be done in one step. See [Build and Deploy the Quickstart EAR or WAR in One Step](#buildanddeploy1step) below for details.
>> +3. If you want to redeploy a quickstart that uses a database, you should undeploy it first. This ensures the database is cleaned up correctly before the redeploy.
> 
> In the cmt quickstart, Tom said: If you need to redeploy the war then ensure that you explicitly undeploy it first so that databases are cleaned up correctly.
> 
> I wonder if he had issues?
> 
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/167/files#r616183
for (link <- storage.pop()) {
  ....
}
s/sms/SMS
s/invloved/involved
This was an oversight. I have corrected it and forced an update.
Will this work if it's used? If not, we should probably detail in the README what's needed here.
Change to `http://example.net`
Takes a callback `poller` and executes it; the callback should be boolean.
Isn't this going to turn them off for admins as well? Since admins are tested with logged_in_as_admin?, and they can use them right now.
I think you should make this new empty Line at the end of the file...
I kinda like the convention because it makes it clear what's an instance method and I find it more readable, but yeah, it's redundant.  I'll go ahead and do it in the less redundant way.
Oh what
Is it really needed to remove the path? The treemenu is not a full replacement in many cases as it only show a selection of the containers.
You should want to add "(indexed by 0)"
Add these to your gitignore
Please give it more corresponding names.
Like: samplesCountFromTerminatedThreads and totalRequestedSamplesCount
So this is actually in the .gitignore, but for some reason it wasn't being ignored.
Ubuntu has a 6 mounth beta delay... I think someone will easily find the bug (if there is one).
In a "explicit form", there is already a bug : your script don't support 12.10... bad things.
This could probably be implemented as: 

```python
try:
    self.get_feed(url)
    return True
except UnhandledURL:
    return False
```

for de-duplication's sake, but I don't think that's a dealbreaker.
Since these three specs are testing the same thing, I think it'd be appropriate to wrap them in a context block like:

```
context "when using content_for?" do
  it "returns true when page part has content" do
    #...
```
In the previous implementation, the extra fields were added as top level properties on the profile. Thinking about the ease of use of the API, I think that might still be better. Also, the extra fields should be hidden when the user is private.
I'm a bit confused as to how this works for users that have their visibility set to private. When other users are looking at them, the only thing that should return is publicAlias (as the displayName), nothing else. This makes it look like you're adding a whole bunch of null values into the response.
Actually, it's not so good. Moving all the logic in the enumeration object makes it static and would prevent caching in the future (that is important for constant pool parsing in case of *Forwarders*)
Shouldn't this in a ``finally`` block?
That whole section of code is pretty hopeless, but this is better so I'll do it.
Wieso müssen alle Typen aufgelistet werden? Kann nicht einfach field.value im Default-Fall verwendet werden?
This pull request does more than one thing.  I dispute the need for changing how to look for the library but not the need to fix the tests.
GRAWR whitespace changes intermingled with technical changes. I see this a lot in tuttle... IMHO remove these, and do a separate "remove extra whitespace" commit for all of tuttle. Simpel to do in sed, and not dangerous.
The user class distorts the alignment of the action buttons in the deployments listing (introduced by the Ushahidi push plugin) on the user dashboard i.e.

![user Class Present](https://dl.dropbox.com/u/2635815/user-class-present.png)

__With the class removed:__

![user class removed](https://dl.dropbox.com/u/2635815/user-class-removed.png)
The method is meant to return an `array()` but `find_all()` returns a `Database_Result`
Do we need to do that at all? I personally prefer not breaking them up.
Would you add a test that covers this bug and submit with this PR please?

And by the way thank you for the submission, if the test if a problem just let me know and I will take a look when I free up some time.
zal er even naar kijken *WORKING ON IT*
"Создайте имплементацию (реализацию) метода mutate. Метод должен заменить X процентов символов в массиве DNA в случайном порядке; Х – значение переданной переменной типа int. Нужно заменить строго Х процентов, то есть заменять одну ячейку можно максимум один раз." - что в этих словах не понятно?

Я думаю можно закончить на этом дискуссию.
Обращу ваше внимание на следующий момент: несмотря на то, что свойство readonly, геттер будет возвращать NSMutableArray*, то есть, ссылку на наш объект, который, к тому же, можно будет изменить (он же mutable).

Свойство можно оставить, но геттер нужно переписать "под себя", чтобы он возвращал не ссылку на себя, а ссылку на свою копию - от её изменения ничего не будет зависеть.
We'd probably want to avoid the creation of the element all together on line 18. Otherwise the css suggestion of setting `display: none` is equivalent. 

https://github.com/jquery/jquery-mobile/issues/2084#issuecomment-3455733
Sounds good to me +1
> The reason why I didn't use  mne.fiff.Raw as input is that the function modifies the data, if someone uses  compute_proj_ecg directly from python this could be a problem.

ok but you may want to do something on the raw before using
compute_proj_ecg like filtering, marking bad channels etc. I don't
think modifying the data is a problem if it's clear in the doc string
and we could have a copy parameter as in numpy

> I can save the events and proj here, no problem.

good
is appending `_` the standard way of not overriding builtins?
https://github.com/secondmarket/mongeez/pull/16
we have one
Any thoughts on a memoized #session method?
No return type required, it's ignored.

The request handler is just an event listener on `request` event:
https://github.com/joyent/node/blob/master/lib/http.js#L1619

And return values from events are ignored:
https://github.com/joyent/node/blob/master/lib/events.js#L85

Sorry, it's probably confusing, that I'm returning - that's node style of doing stuff nothing else:

````javascript
// instead of this
if (proxiedPath) {
  proxy.proxyRequest(...);
  return;
}

//  nodejs style is
if (proxiedPath) {
  return proxy.proxyRequest(...);
}
````
Blank line before this line...I'll stop commenting on this. Please check the docstrings and insert line breaks before logical "paragrahs" and indent bullet-like lists (even if there is no bullet).
We should not allow these. Correct approach would be to assign the multiline expression to a variable.
The yum variable `$arch` should probably be used instead of `$basearch`, since the repo uses i686 instead of i386.
Good point. Let me make that change
The pattern other classes in the framework have been following is `initWithGitRepository:` (c.f. `GTRemote`, `GTIndex`, etc.)
We need a javascript guru - the context menu is definately disable-able...
use ```parsed_page``` in place of ```get_page(page)```
Backticks around JS
Nice solution for this!
I think it could be better to create the file here: var/stamps/venv_installed.
Is this limitation documented?
I don't understand that: nothing other than the btree code sets this statistic field.
Please always put if-bodies in brackets.
For loops like this, I've made it so that the animation ends slightly before its reset. There's special code which makes sure that the subframes don't get overrriden with an image_index = 0 and whatnot
Um, I sorta need this function. I pass it a list of modules from the tiapp.xml and it determines which ones are installed, missing, or incompatible.
extra paren there
Nice use of semantic exception here.
Should be the same as 254 above
The exception should be logged
I am going to mention it on Dev Portal, in the Utilities section.
Static strings should be with `'`. Put spaces around `()` in anonymous functions. Please specify all arguments in JavaScript functions which function can take, so that later on is visible what is available.
Indentation/wrapping should be fixed here.
No, you should limit `update_weather` tasks, not `generate_weather_tasks`. The former should not access their server too many times.
I don't like this comparison? It cannot be equality?

I don't like that you can match any substring? Can you limit this somehow, so that it matches really just the portion that should be equal? Like trailing part or something?
That is too hard-coded. Please define a class, something like "automatic-width" which you then match and configure.
Anyway I wrote to them
Made into constant.
(Although in JavaScript there is no really dicts, but still.)

(Yes, this is confusing because it is different between Python and JavaScript.)
I'd feel happier checking `elif not isinstance(value, basestring) and hasattr(value, '__iter__'):`, just so that objects which *aren't* strings but have a `__str__` or `__unicode__` could get co-erced anyway. I'll add a couple of test cases which define this behavior more clearly.