When deleting an instance, avoid freakout if iscsi device is gone

It's fairly easy to get into a state where an instance is not running,
the iscsi infrastructure has been torn down, and the instance cannot
be deleted because the iscsi device cannot be successfully removed.
This patch ignores the associated return value for that scenario and
marches forward in the teardown process.

Fixes bug 1022520

Change-Id: Ib28790892eebe341ac10a92250cf872605fefe9b
Don't block instance delete on missing block device volume

It's easy to create an undeletable instance by specifying an invalid
volume id in the block device mapping. The instance errors, but
subsequent delete fails because the volume is missing. We already
ignore the DiskNotFound case during delete, so this adds a case for
VolumeNotFound.

Change-Id: Ibc516ee4452d088cddf10bbeb315697ce900e5c5
Making docs pretty!

  * Before: http://stsh.me/2Qv
  * After: http://stsh.me/2Qw

Change-Id: I4609e66820cd49b7443d18b9e0decf638da42581
Adds bootlocking to the xenserver suspend and resume

Bootlock prevents an instance from being resumed accidentally if the dom0
were rebooted or a whole slew of other possible interactions. We'd prefer to
keep suspended instances suspended.

Change-Id: I82fb734b79270aa87cd3bb08797885d5fda11f6b
Remove deprecated auth from GlanceImageService

* Drop the code block specific to deprecated auth in image
  deletion code
* Remove reference to deprecated auth in the auth_strategy
  config option help text
* Related to bp remove-deprecated-auth

Change-Id: Id0f4f287d33d01d54642fbc544ada9b7ef1b83ec
Imports base64 to fix xen file injection

Adds base64 to agent.py as its required for file injection to work.

Fixes bug 1023698

Change-Id: I231b6f5e031106471aeff38769e8fc79dcd45b45
Fix .mailmap to generate unique AUTHORS list.

As per 3456b667c38aa1d439482b9c95838aba6d3d6c5c, Monty
merged code to generate AUTHORS file.

With this fix, git log honors .mailmap specification,
irrespective of name/email combination used for commit and
generate unique entries in AUTHORS file.

* .mailmap
  Handle all full name/email combination to ensure following
  command return unique records.
   $ git log --format="%aN <%aE>"

Change-Id: I44f1db1a991fd312ab37455b44985281ed1d392f
Merge "Imports base64 to fix xen file injection"
Merge "Don't block instance delete on missing block device volume"
Convert remaining network API casts to calls

Fix for Bug 1021340

During compute/terminate_instance networking is de-allocated by a call to
network/api/deallocate_for_instance(), which is implemented as an rpc.cast to
the network manager. This in turn will eventually call
network/manager/deallocate_fixed_ip(), which in turn call the compute API to
trigger a security group refresh, which will get the instance from the database

However because original call to the network manager is a cast there is a chance
that the compute manager will delete the instance record in the DB before the
compute API (in the network manager) tries to retrieve the instance. At this
point the security group refresh fails (leaving rules in place which are a
security risk when the IP is reused), and potentially stopping otheraspects
of the network deallocation from completing.

Changing this from rpc.call to rpc.cast will fix this issue.

Aside from this specific use of a cast there are 4 other casts in the
network API:
  add_fixed_ip_to_instance
  remove_fixed_ip_from_instance
  add_network_to_project
  release_floating_ip

and to avoid other timing issues these will also be converted to calls.

Change-Id: I5cdcc628293d3e7cf165c5ffe4883f138783f73f
Merge "Fix .mailmap to generate unique AUTHORS list."
Floating_ip create /31,32 shouldn't silent error

Fixes bug 1017682 the netaddr.IPNetwork.iter_hosts
method doesn't return any IPs when /32 or /31 and
should throw an exception instead of silent error

Change-Id: Id8875b6016a4dbb40b29d2f7687e6c35491e0129
Merge "Adds bootlocking to the xenserver suspend and resume"
Use the dict syntax instead of attribute to access db objects

To make the code style consistent, use instance["attr"] instead of
instance.attr in the code.

Change-Id: I766c714cb86d3b67ff9787bc50e5e20e37c9b574
Merge "When deleting an instance, avoid freakout if iscsi device is gone"
Merge "Making docs pretty!"
Merge "Floating_ip create /31,32 shouldn't silent error"
Merge "Use the dict syntax instead of attribute to access db objects"
Adds snapshot_attached_here contextmanager.

This patch does three things:

    * Moves more code into vm_utils to better match our separation of
      concerns.

    * Reduces complexity of the vmops._destroy method.

    * Adds snapshot_attached_here contextmanager to make the
      snapshotting code a bit cleaner.

Change-Id: I544dc2ba203519d32a5ecce4a87157b5c4a55076
Merge "Remove deprecated auth from GlanceImageService"