labofsahil/github-event-dataset-2012 huggingface dataset:
Crud. Somehow this slipped through. I believe it is a bug with my IDE as I kept having to fix this.
I'm not sure if this is helpful here, but I was always instructed to perform a hasOwnKey() check here when enumerating items in an array or hash.  Would checking hasOwnKey make sense here too?
実行ジョブのフォロー

→

     実行中ジョブのフォロー
Please no single `@`, use `this` instead.
This is actually a bug... We are not using the Ordering in the case where we push to reducers.

We can do this by setting the comparator in the sorting fields.  See TypedPipe.scala for an example of how to fix it.
Use the same e-mail throughout your code.
Why does this method take `conn` if you never use it?
You need to have 'com_kunena' in there. I would just replace variable with component name..
FYI had to put in quotes and then unquote so that both media queries and variables like 40px get parsed correctly. If you know a better way I'm all ears.
Ok, just wondering on your reasoning :)
See above. This happens when we have a LESS rule that generates a CSS ruleset, or in any case any ruleset that gets instantiated during the transformation phase (from the LESS AST to the CSS AST)
The point is just that normalizing the getPrettyVersion value should
give you what getVersion returns. If that's not the case things break,
so just make sure you strip any garbage from the pretty version while
loading pear packages.
@vsizov +1. Required description is not ok
I'd be tempted to do something like:

    `@import "module/_modules.less`

then inside `_modules.less` have something like:

    `@import _media.less`
    `@import _nav.less`
etc. Keeps the main LESS file clearer.
Missing NULL check.
Doesn't that always advance the cursor? Should this be place under the if in line 39?
The `siteName` is escaped before somewhere?
I was experimenting with something before and this was left over code. Will change it for next patch.
No `:focus` selector?
I think the behavior should accept both string (YAML) and array values. CML schemas is not the only way to build a model. This can also be done using PHP, or... YAML. So the fact that the rule value is a string should be treated as a special case. That means the code should feature this kind of snippet:

```
protected function cleanupParameters()
{
  $parser = new Parser();
  $params = $this->getParameters();
  foreach ($params as $key => $value) {
    if (is_string($value)) {
      $params[$key] = $parser->parse($value);;
    }
  }
  $this->setParameters($params);
}
```

And this method should be called upon initialization.
It is generally better to use a class level instance variable than a class variable like this - the semantics are much less odd.
this should probably just use the new nested exception functionality
Dam!! I was sleeapy... sorry let me fix that
I think saving these positions can be done without using the settings. Sublime provide `add_regions` which will store region(s) in the view under an arbitrary string key (e.g. `'vintage_last_edit'` in this case). Also, all of the selections could be added, if that's desirable.

I used a similar technique on my pull for `gv` (#97) here:
https://github.com/sublimehq/Vintage/pull/97/files#L1R743

That pull has not been merged, I think in part because anything that listens for a common event deserves more scrutiny.
two space indents
Here a context comment for translators is missing too BTW.
For classes that are only offering static methods, we typically recommend making them abstract. They do not need the "Abstract" prefix, however.
Already noted earlier, but do not break this line into two -- it causes issues with phpdocumentor, and makes it harder to understand semantically.
If there is not a specific schema class then the code must return an instance from the generic Uri class
There was a comment describing the cause to replace single line with all these specific lines:
We removed the bootstrap-scrollspy because it caused a bug of setting dropdown tab active after scroll
`<?=` is unique in that it is like an expression operator.
Formatting is off, you need a space after the "if".
Bind to the enter key instead of submit, since we don't support non-javascript, we don't really need to use a form, and if you look at the template, we only use the input element.
Weird function name
next time you sen a PR. Take care to the coding standards. You should be using spaces, not tabs.
Missing the line break between param and return
see the comments on the XmlDriver
Instead of using `<br />`'s you should think about using CSS to get the spacing you're looking for.
:+1: for this abstraction
Perhaps add a list, so it can be gleaned for the docs we will one day autogenerate?
Maybe print something to stdout as well, since we're exiting here?
I'll check it out. According to the spec the `response_type` is not needed (I believe it's not even defined for the access token). The scope would be something that could move up to the `GenericResourceOwner`.
kept same, re: http://guides.rubyonrails.org/action_controller_overview.html#the-flash
I typically use bang methods in the controller - you're going to want to know if it fails.
Indent here.
SuperNit: space after `)`:

```js
var Badge = function(assertionUrl, spec) {
```

I generally do a space after `function` as well for anonymous functions, but I also try not to use anonymous functions. I'd actually probably rewrite this as:

```js
function Badge(assertionUrl, spec) {
```
Sometimes you use popped, sometimes this.  Be consistent.
I think this should be broken out onto multiple lines.
Not necessary, since you are using opacity: 0;
On Tue, Jul 31, 2012 at 2:12 AM, Ohad Levy <
reply@reply.github.com
> wrote:

> > +        <%= text_f f, :name %>
> > +        <%= selectable_f f, :provider, ComputeResource::PROVIDERS, {
> :include_blank => "Choose a provider"},
> > +                         {:disabled=> f.object.uuid.present?,
> :'data-url'=> provider_selected_compute_resources_path, :onchange =>
> 'providerSelected(this);'} %>
> > +        <%= textarea_f f, :description, :rows => 3 %>
> > +        <div id='compute_connection'>
> > +          <%= render
> "compute_resources/form/#{@compute_resource.provider.downcase}", :f => f
> unless @compute_resource.provider.empty? %>
> > +        </div>
> > +      </div>
> > +      <div class="tab-pane" id="organizations">
> > +        <%= multiple_checkboxes f, :organizations, @compute_resource,
> Organization %>
> > +      </div>
> > +    </div>
> > +
> > +  <% else %>
> > +    <%= text_f f, :name %>
> > +    <%= selectable_f f, :provider, ComputeResource::PROVIDERS, {
> :include_blank => "Choose a provider"},
>
> can we use the if twice (e.g. for both tab and tab content) instead of
> duplicating the other tabs view?
>

Yeah, I'm sure that'll work.

This was admittedly some haphazard coding due to a last minute change...


>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/theforeman/foreman/pull/121/files#r1270458
>
is there any reason not to clear all tokens that expired by default?
On Tue, Jul 31, 2012 at 2:09 AM, Ohad Levy <
reply@reply.github.com
> wrote:

> > @@ -32,6 +32,11 @@ def show
> >    def create
> >      if params[:compute_resource].present? &&
> params[:compute_resource][:provider].present?
> >        @compute_resource = ComputeResource.new_provider
> params[:compute_resource]
> > +      unless User.current.admin?
> > +        if SETTINGS[:single_org]
> > +          @compute_resource.organization_ids = [Organization.current.id
> ]
> > +        end
> > +      end
>
> does it make sense to move it into a common helper method?
>
> also, not 100% sure, but does it make sense to move it to the model (as
> both User.current and Settings are avail)
>

Interesting.  Something like:

def Organization.when_single_org &block
  unless User.current.admin?
    if SETTINGS[:single_org]
      yield
    end
  end
end

I just need a little help on the rubiness of it, I'm sure.


> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/theforeman/foreman/pull/121/files#r1270450
>
Was able to remove entirely and replace with `this.stopListening`
Javadoc said Written Object, which is better. getWrittenObject()
Yes, I think it should be.  Will update.
Might be a little confusing -- is 2^3 a part of 2^5? (Not sure if we write exponents in `getPrimeFactorization`, but we maybe should if we don't.)
If you do `"\\text{side}="` then the `side` won't be italicized.
The only place this method appears to be used is in the MockConnector. That implies to me that it shouldn't be in this class.
777 is far too permissive, and usually unnecessary.
listening...
It is from 4923584
When would you want to return the encrypted text? Should this raise an error instead if the key is missing? Maybe it will be more clear after you update the usage description.
I personally used the footer for this issue

all the hover cards open in a  down-right  direction  so if we move the "mouse" from down to up then we are sure that there are no overlapping cards
This ID is used by remote clients, right? It could be a race condition; for example, a client sends CloseNotification(3) just after that ID has been freed up and allocated again. I'm not sure that matters in practice, but you could use a monotonic ID instead.
OK, I'll go with 775.
I think that if users want to add new REST endpoints, it could be limiting to not have this capability. Does the overhead of the JSON check actually cause a significant issue?
Grepping for that doesn't result in anything. Keep calm and carry on.
Should be on the line above
you can just do 

`RestAPI.Content.createComment(getRandomCommenter(), contentId, getRandomComment(), replyTo, commentCreated);`
Please indent this appropriately
So you'd just check the URL and base the logic on that?
SecurityContext was used for ease-of-use. The idea was that rather than passing a tenant, principal type, and principal ID into almost all authenticated services in the system, you could pass this token. As secure service methods would be accepting the tenant/principal information mostly to perform authentication, the SecurityContext is easily ready to do all that. "Level 1"-type caching is also an option in this design, as you have a stateful object that dissolves after the "session" is complete -- I don't think there is another way to achieve that with nodejs. It might seem more helpful when you start to consider API-to-API calls, you just keep passing along the security context.

It could also make it clearer that it represents the "authenticated context", and not necessarily just some user ID that is used for other purposes (e.g., User A (authenticated security context) connects with User B (just some principal)).

The importance of the SecurityContext has less weight as of PR #7 (group membership using roles), but I think it still has some merit.
Nope, it has been renamed to "references" now, I didnt notice that, perhaps its done recently. Thanks for noticing it.
you might want to factor out a separate function to determine user id based on username, since you're doing this in several places.
please do this:
```lua
    local soldierpatrol = Soldier_patrol:new("SoldierPatrol", 10 * TILESIZE,
                                             REPUTATION_RELUCTANT)
```
the comment is still wrong. There is nothing explaining what ``$jar`` is here. You should read your comment with the new version of the file (forgetting the old one) to see that there is an issue for people not knowing your change
Why are these commented? :)
Those 4 lines should be just one:

    $out .= ' <option>'.$val."</option>\n";
Тогда лучше возвращать NSArray, иначе можно изменить вашу последовательность (метод возвращает объект, который можно изменить).
почему бы не использовать конструкцию ?
 switch (randValue)
 {
     case 1:
          [_dnaarr insertObject:@"A" atIndex:i];
          break;
     case 2:
          [_dnaarr insertObject:@"T" atIndex:i];
          break;
//.............
 }
Yeah, that can work.
It was too simple for me, I'll fix that.
BTW, there is a good chance this won't work at some point in the future under WW either if we localize it to just Cordova. We haven't overridden FileReader there yet though :-)
Was this still necessary?
This should verify that at least the given interval has passed since the last value was sent.
Can you please uppercase these macro parameters? It's difficult to distinguish variables from text substitutions otherwise.
Should this really be in here? Shouldn't any script to be included be part of the overall and only one determined license?
Rails har noen fine metoder for å genere JSON. Her kan du f.eks. gjøre:

```ruby
render json: Category.where(parent_id: category).to_json(only: :id, methods: :human_name)
```

Isåfall må viewet som bruker den endres til å forstå `human_name`. Hvis det er viktig å unngå kan du f.eks. gjøre:

```ruby
hashes = Category.where(parent_id: category_id).as_json(only: :id, methods: :human_name)
hashes.each { |e| e[:name] = e.delete(:human_name) }

render json: hashes.to_json
```
Wat ik eerder al zei ;-)
shouldn't you break here after finding the index?
I think de799b12f51a9ff7a98e18bd8d59ae428558bcc7 does this correctly. Am I wrong?
Or, should I just put everything in a separate file and only import sample_path()? This would be nicer.
Also I commented on it .


On Wed, Dec 5, 2012 at 2:48 PM, Alexandre Gramfort <notifications@github.com
> wrote:

> In mne/viz.py:
>
> > @@ -1031,6 +1037,13 @@ def plot_image_epochs(epochs, picks, sigma=0.3, vmin=None,
> >          (data.shape[1] == len(times))
> >      show : bool
> >          Show or not the figure at the end
> > +    scalings : dict
> > +        The scalings of the channel types to be applied for plotting.
> > +    titles : dict
> > +        The titles associated with the channels.
> > +    keep_only_data_channels: bool
> > +            If False, all channels with be kept. Otherwise
> > +            only MEG and EEG channels are kept.
>
> I guess you've seen the PR now.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/221/files#r2320468>.
>
>
Length (upper case)
I can't tell from this whether this tries the same server `max_retries` times or tries `max_retries` other servers. If the latter, does it have a list of servers to try from?
If I place it before the list, how it will target only the enum line? Do you have an example of the actual doc?
This path is actually correct - the vendor path has been updated for composer, which will have directories line `vendor/doctrine/orm`, `vendor/doctrine/common`, etc. What you have up there is how it looks currently on the 2.0 branch.
若图像超过这个大小
Yea, I have no idea what I'm doing here.  Just trying to remove autoload.
 It'd be awesome if someone that wanted autoload gone would help remove it
:)

It looks like I can essentially replace Mutex with Monitor, and it'll
magically work?


On Fri, Dec 28, 2012 at 1:54 AM, Eric Lindvall <notifications@github.com>wrote:

> In lib/faraday.rb:
>
> > @@ -181,7 +181,12 @@ def lookup_middleware(key)
> >      end
> >
> >      def middleware_mutex(&block)
> > -      (@middleware_mutex ||= Mutex.new).synchronize(&block)
> > +      @middleware_mutex ||= Mutex.new
>
> This seems like a very dubious way to initialize a Mutex. If you have two
> threads that call middleware_mutex at the same time, they may get
> different mutexes the first time.
>
> Also, instead of trying to use @middleware_mutex.locked? to create a poor
> mans recursive mutex, this should really just use Monitor instead. It
> acts just like a mutex but it's recursive.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/technoweenie/faraday/pull/224/files#r2514046>.
>
>



-- 
Rick Olson
http://github.com/technoweenie
what's the difference between "message" and "body"?
I was referring to 'modname'.  It is not used anywhere.

I also wondered about '__docformat__', but a few other modules have that, so I assumed it was some sort of numpy convention.  Travis might know more about that.  Does numpy still maintain compatibility with epydoc?
What if input is `'`' and default is `null`? Shouldn't it return `null` in this case?
Я решил, что не стоит. Потому что там может быть мусорка и тогда не понятно, какое поведение он ожидал. Лучше этого избежать.
Не убьют. Я пользуюсь рссками очень давно и ни в одном клиенте подобного не
видел. И даже в голову не могла прийти необходимость такого
А он и создавался как make_shared в ljaccout. Так что все ок
> * Como usuario me gustaría que el sistema me identifique para permitirme acceso.

Era parte de lo planificado.

---

> Reunión de Andrés con JD acerca de lo que pienso hacer para indexar attachments.

Creo que no es necesario poner este tipo de cosas...
It is 1 only for first 5 operations. Then it will be 5, 25... until 500. See comments.
What if the first person has a field first_name, but the second has not?
No - I tested:

```ruby
# first.rb
module FirstModule
  require 'c:/second.rb'
  def self.goodbye
    puts 'Bye!'
  end
end
```

```ruby
# second.rb
module SecondModule
  def self.hello
    puts 'Hi!'
  end
end
```


```ruby
load 'c:/first.rb'
true

FirstModule
# > FirstModule

SecondModule
# > SecondModule

FirstModule::SecondModule
# > Error: #<NameError: (eval):155: uninitialized constant FirstModule::SecondModule>
# > (eval):155
```
You should probably use bootstrap notification features
please revert these routes
I think the overall PSF API is good. I like the idea of constructing a PSF object that can take a function or an array. The sampling parameter is also good.

Having `psf_photometry` operates in a similar fashion to aperture_photometry is nice because it provides continuity. I'm wondering though how we would deal with crowded fields, which after all are the type of data that will require PSF photometry to be done? Let me be more specific. In general, one has to perform the PSF fitting on multiple/all sources at the time because they overlap with each other. Would it be `psf_photometry` fitting everything jointly under the hood? To me that's what makes most sense because it takes away the challenge away from the user to figure out how the provided `<coordinates>` might interact. In the example above, I'm assuming that the `<coordinates>` argument can be a list or something of that kind, so that they are all processed at the same time. In principle, it should be a linear problem: solve for the amplitudes given a set of positions, an array and a kernel (whatever it is a function or an array).

In the first iteration of the PSF API that is pretty good. However, we should maybe plan to add a few more functions. One that would return the residual image is almost essential otherwise one cannot search for unfitted source in an iterative way.
```python
    residual_image = psf_residual_map(image, (x, y), psf, results_psf['flux'])
```

Another option is to have the residual image returned by the `psf_photometry` routine itself.

One more issue to raise. We need to consider a way of improving the position of the `<coordinates>`. Regular source finding algorithms will probably get the position of sources wrong if they are blended. It's when things are fitted with the proper PSF kernel that the position can be nailed down. This might be done by adding optional arguments to `psf_photometry`.
```python
    results_psf = psf_photometry(image, (x, y), psf, tune_coordinates=True, tune_limit=2.)
```

Bear in mind that the coordinate tuning must have a maximum limit otherwise things can go wrong rapidly.
These units tests should now be obviated by  `hasValue` entries in the ontology, yes?
u and your 16 registers with variable reuse. Pep100 dont reuse variable names NGHUTPR
`concat` on turvallisempi vaihtoehto kuin `flatten`, sillä toistettavina alkioina voi olla sekvenssejä. `mapcat` tekee mukavasti sekä `map`:n, että `concat`:n.
This change can be reverted, right?  You've just re-ordered the imports?
I wonder if we need a base DelegatingCommandFactory :)
Let's hope the next one who needs something like this extracts a base class, this thing is huge!
Why do you reverse the order? This seems like an unnecessary change from the previous behavior.
First (and this took me a while to internalize) in general the Go idiom for getting a pointer to a zeroed struct is to use "new", i.e. `self := new(StatsdOutput)`. Second, if we're not doing anything w/ the statsdClient in this constructor, then why do we have it? The plugin bootstrapping code can just call new(StatsdOutput) itself.
PS if you are concerned about the failure if there 0 valid ones, you can catch the List out of range exception and throw a new failure with a relevant error message. This would be useful information when combined with a screenshot.
I agree with @zacc that for a smoketest this is good enough.

@jds2501 let me suggest that you file a git issues to capture the fft instead of adding TODO statements to the code base. We can add this to the suite at a future date.
Shouldn't this be "partie" instead of "jeu"?  It's the "instance" of a game that's being copied.
actually ignore previous comment for now, use rightscale-#{node[:rightimage][:cloud]} but always upload to dev bucket:
rightscale-#{node[:rightimage][:cloud]}-dev, we have a separate process for copying from the dev --> non-dev bucket
@gsilver - About `topnav_skip_bg.png`, do we still need this in the pull request?
It seems like we're now using gradients for this.
Can't we use this instead of doing 2 different if statements?

```
{if reverse && activity['sakai:activity-nonactor']}
```
Based on the file view, this block of code looks like it uses [tabs rather than spaces to indent](https://github.com/arnodeclercq/nakamura/blob/77e5b92ad91e4bed7d07c6863ed967a0f7f81015/scripts/preview_processor.rb#L267). Please check that and fix accordingly.
Sorry to pick a nit, but the current version of `maven-surefire-plugin` is 2.12. I just did a successful build and test with it. Can we use it?
I'm on my tablet, so I'll have to commit the changes later.

Missing:
```
    $identifier[$name] = $data[$name];
```
With the templates all being pre-compiled, this test is no longer valid.
Static functions should be `in_this_format()`, also they're ideally at the top of the file, above all the instance variables and methods.
I think we can remove these
This is just noise to keep spell from complaining about "twrite" not being a word.
You may guess already.
looks like the indentation for this entire block is off? should be about 17 spaces in?
Are you sure that the property "serviceManager" exists? Did you maybe forget to declare it?
Put your styles here.
Bound it with the categories namespace by doing this:

.categories {
  styles here
}
die können eigentlich gar nie null sein, weil die anhand der selben liste errechnet werden. und da jedes rating ein bier und ein user hat geht das immer auf..

aber schaden kanns nicht ;)
How about testing empty strings and bad format(s) too?
whoa whoa let's not get carried away here =)
Your fix might also help to fix this one : https://issues.jenkins-ci.org/browse/JENKINS-12800
But I'm not sure that it works if you have a space in codeSigningIdentity
Did you try it ?
you could do something like:

```javascript
var options = get(this, 'options');
if (options.allowBlank === true) {
  return value === ""  || value === null || value === undefined;
}
return false;
```

It might be a personal taste, but I dislike using `if (...) { return false; } else { return true; }`
\\you
No need for random uid. Just pick something like: `getStyleBackroundPosition`. If you're still paranoid just do a quick search against the repo. and adjust, if necessary.

In the end, a descriptive class name will help debug than a random UI
I'm pretty sure we need to keep the domain name here. This script is meant to potentially be used on arbitrary external domains.
Sounds good, but outside the scope of this pull request :)

Are you happy to merge as is, so shall I add some kind of "require 'ping' if RUBY_VERSION < 1.9" ?
Ah yah, I was surprised to see superagent was pretty much two separate libraries.
Yes. Just make sure that we don't override any method of `BrowserIDBackend` in our `MongoEngineBackend` by accident.
I don't think it's a good idea to use this format because it's localized and javascript can't parse it, so my diff function doesn't work.
Change class to something more generic?
(That yes was for adding to `requirements.txt`.)

You could add Mercurial repository in a similar way how we were adding git repositories. But this library is published on PyPi. So you can just add it only with name and version and will find it automatically.

```
pip install django-missing
```
This is not needed anymore?
Hmmm no it's still not okay. Now I'm not getting slovenian translations. I made a commit so you can check. I'm currently clueless. Maybe there is just some stupid mistake.
Why unsetting this?
This (sending token) should be possible to do only if user has e-mail address defined.
I was thinking the same thing for these lines, gotta differentiate no longer used code from code that's merely not working.

Personally I would like to just remove them, but I know you like to keep this stuff around as a sort of protocol documentation.
If you want to keep them in the source, I think a simple prefix on each line would be good, how about:

//scripted//this.Attributes[GameAttribute.Hitpoints_Max_Total] = 308.25f;
Perhaps something like this https://gist.github.com/4182fefc4182e912f445 ?
Makes sense, but we probably should covert this from an exec to services and notify the services (that is likely outside the scope of this pull request).
conditions?you mean do this thru DB and SAI?but the mob is dead,it would not cast the remove blood spell or add killcredit.
Small typo for pending there.
We don't need to associate the token to a user, so not anymore. This is clearer in the new commit where there are two methods, where you can pass nil as the user.
OCD spacing alert!
should be arraySize(a) instead of arraySize (a)
I see it is explained later in the docs, nvm.
MongoDB in Action recommends to use safe by default. What does the mongo community do?
Maybe a reference to "Infinispan cache names and purpose" or to the section I recommended to add
Once this book is updated to the latest and greatest Django version, will the old versions be still available on djangobook.com? If so, it'd be better to link to them. If not, we could link to the official Django documentation at least.
Right about here is where we should introduce addEventListener and attachEvent, explaining a bit of the history there before introducing jQuery
Because it's for limpyd internal use only ?
If we add rspec dependency we also need to add it to the gemspec:

https://github.com/luislavena/win32console/blob/master/tasks/gem.rake#L22
If you don't mind, let's avoid relative imports
I would put this in the contribute.rst dociument, rather in the readme, and reference the contribute doc in the readme.
Right, so the event comes from the top/leaf widget and cascades down the stack, but it needs to be stopped when we reach the widget that was disabled.

Not sure what you mean by "especially for some containers and not others".
Understood; thanks for the pointer.
There is [Conary](http://wiki.rpath.com/wiki/Conary), which is similar to Pacman, but written in Python and vastly more advanced, and its PKGBUILD equivalent is a Python file. You can rollback with it. I think it supports everything you want. It should not take a lot of work to port it to any system.
FYI, these can be empty, but it's not that important.
Don't trust me on this one, but I think I remember trying it out with multiple fingers and  
the ignoring/tolerance still working correctly.


On Wednesday, 14 November 2012 at 01:54 , Takayama Fumihiko wrote:

> In src/util/multitouchextension/KeyRemap4MacBook_multitouchextensionAppDelegate.m:
> > int valid_fingers = 0; > for (int i = 0; i < fingers; ++i) { > double x = data[i].normalized.position.x; > double y = data[i].normalized.position.y; > - double threshold = 0.1; > - if (threshold < x && x < 1.0 - threshold && > - threshold < y && y < 1.0 - threshold) { > + > + if ((leftThreshold < x && x < 1.0 - rightThreshold && > + bottomThreshold < y && y < 1.0 - topThreshold) || > + current_status_[i]) { //don't ignore edge if touch has already been validated  
> Thank you for pointing out!
> Considering multiple fingers, we need a little more adjustment for accidental edge detection.
> I'll add this feature soon.  
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/tekezo/KeyRemap4MacBook/pull/89/files#r2119501).  
>  
>  
>
yes it`s based on http://www.rabbitmq.com/api-guide.html#returning
Why did you remove this whole file?
Do you need "extends Serializable" here?
You don't need to set the property unless it was null
Yeah, I think this jut gets passed off to jQuery's event delegate or whatever it is called.  It uses the "event target" syntax.
Thanks, I've altered the timedelta conversion as suggested.
they can, just not in the default CustomAggregatingEnricher which two lines down assumes it is an attribute.  so this change just prints a better error message.
Good point. As noted before, I've been using ByteArrayOutputStreams, so these would no-op in that case, but normally bad.
do we no longer pay attention to this config key?
yes typo
What?

You have the devise views copied into `app/views/devise/sessions/`. Why not modify them directly?
According to perldata uninitialized elements of hashes return undef. So if callid is missing in `$args` `$args->{callid}` should evaluate to undef and therefore `$self->{callid}` should be set to `undef` if it is missing from the arguments.

a small test:
```perl
my $a = {a => 'b'};
my $test = $a->{callid};
use Data::Dumper;
print Dumper($test);
print Dumper($a);
```

prints 
```
$VAR1 = undef;
$VAR1 = {
          'a' => 'b'
        };
```

I'm not very happy with not writing tests for that in the test suite - but it would require some additions to the mogilefs client (e.g. asynchrone version) which i intend to do when playing around with it for the json code
This module is for the Play 1.x series only.
The comment should probably read "probably yellow" seeing 33 is quite brown-ish on some terminals :smile:
My bad... was checking that it worked...
This was less about whether or not your docs are good (as a rule, they are). But Andrea is our voice, and she needs to approve all docs :)
No, it just slipped by. Removed.
простіше зробити один чекбокс
I would like a little more context here. This doesn't make sense on its own.
I guess you could use a documentFragment her but I won't block on that.
I was thinking about allow the banditAlgo to return groups of jobs that it says should be evaluated by evaluate together ... and which would come pre-loaded with the relevant idx/vals data.  I have an idea about how this would work, but I think it's less good then having the bandit just generate new configs by generating new idx/vals and passing those back at the end along with the specs and results.
Don't change the indentation please.
check Hex_decode() defined in util/Hex.h
Not sure how this file ended up in this directory.  Deleting while fixing things up.
Форматирование html страдает
I have a PR here for removing the class variables.  I was able to successfully change ```has_many``` to ```define_method``` I need to do the same for belongs_to and then I can delete the class variable entirely.
I wonder if we should also make this into class_eval?
new String() лишний
Не очень понял. Проверять на null, или ещё что-то? Чтобы более информативные сообщения были? Вручную проверять?
It is hard to read..
Can we rename that: `openToolForTab`?
Oh yeah. just noticed that.
Typo here needs fixing
I prefer the `options[:label] == false ? input : (label + input)`
I got the real problem and agree that the only way is filter input or label. I commit at master.

Thanks again mate.
I don't think it makes sens to use the inertia to select the number of cluster. inertia is to be minimized for a fixed expected number of cluster. If the number of clusters increases, inertia will always decrease hence the best model will always be `n_clusters=5` in this case, whatever the data.
I will try. It is copy & pasted from ``getattr``.
I fellt "small computer" a bit weird. maybe just remove the part after e.g.? feel free to leave it in, though...
those functions need to be updated
Even thought the user does not set ``sparse`` himself, there are places where ``sparse`` is set to ``True`` by the constructor (``sklearn/svm/sparse/base.py``).
yeah, it could be split into its own method, but if we go for the last suggestion by @willdurand this pr is dead
This seems a little messy - when I take the mean image across 2 or more functional runs, is it safe to assume they have the same affine? Even though they are realigned together, I am still hesitant! Would having a separate registration for each functional necessarily be a bad thing?
what if two uploads have been enqueued for the same URL. Shouldn't we cancel all of them?
some comments please indicating that File should relate to a file NSURL, and a BinaryData should be an NSData. If thats what you intended.
who knows how many middlewares we'll add!
Minor point, but it would be better (more efficient) to attempt the connection directly to the cluster xpath, rather than Environment and then getPropTree(path to cluster)

[ I realize other routines do similar ]
Should keep the extern (not strictly needed but I think we usually do...)
Add a comment along the lines of

For a tree broadcast, calculate the next node to send the data to.  i represents the ith copy sent from this node.  node is a 0 based node number.
It returns a 1 based node number of the next node to send the data to.

Why the output number is 1 based I don't know - seems a bit inconsistent.
Should be using reset(). I will repush.
I think it needs to be control->getPropInt64()
>I think it might trigger a misaligned access assigning to meta on some architectures.

Even though meta is 1st member?

If we consider this non-portable, I can code it so that it avoids the pack. The code would be more bloated though, I'd have to derived some of the keyToHash etc. members of superhash, and hash meta and activityId separately and combine.
Why not just add the line to the configuration file?
Do we have any `*~` files? Also the `tmp/*` is too magic. What if we have that at some point. 

Also, I don't know what .swp files are. Do you? Shall I remove them too?
ok, I remember now. The problem with specifying the entire file name is that it doesn't apply to nested partial rendering. In this case you get Missing partial shared/aspect_dropdown inside aspect_global_helper::aspect_membership_dropdown. So it doesn't seem right to specify the whole file name there, since someone else might be using it counting on getting the json version. So just setting the formats avoids that.
I don't think it's more readable but it does not relies on non-standard features that will at some point even be deprecated in favor of different standard coming in ES.next.
Why are you re-introducing $module into this? It was removed by @SpiffyJr because the MVC is agnostic about modules; it only knows about controllers. (In fact, this is true of "actions" as well -- the MVC really only cares about controllers; "actions" are an implementation detail that certain controller types use.)

I guess I'm uncertain what this, and the other module-related code in the commit, adds. Can you either (a) clarify the rationale, or (b) remove those references?
``secondary_fetcher`` ? This naming seems really weird.
Would devs want to override this set? If so, we should probably add a setting "erlc_options".
Hmm, this seems to want to autowire a new service but I don't see the new service defined yet...
Is there a better way to do it ?
what method do you mean ?

Gorshkov Aleksey
IBM Certified
programmer 
Grid Dynamics
 +7 952 203 9796
Skype:aleksgorpsk
www.griddynamics.com
email: agorshkov@griddynamics.com

On 24.10.2012, at 15:16, dennisyv <notifications@github.com> wrote:

> pls correct mistake in method name
> 
>
Multiple `let`s can be combined by just lining them up.
i'd suggest not using sourceModel for this, otherwise it's going to get confusing and you'll need a seperate getter for filtered models

(+ source model will always contain the self contact, if the engine supports that)

so:

Q_INVOKABLE int contactCount()
{
    return rowCount(QModelIndex());
}

should work?
I'd like some better comments about what this method does, what the arguments are, etc.
this still will load capistrano for passenger, the if applied in line 142 would make the block loading only when capistrano is loaded.
Did we port these tests from components?  A few of these test have a good bit of math.  Are we better off using simpler input so the tests are more digestible?  OK with me either way.
Per my comment below, I suppose the name `intersect` is actually OK.  Position, negative, and intersect (or intersecting) are good names for the return.
Ignore this, it's an incredibly minor change and most likely will have no affect on performance.  I must have just been in a picky mood.
Why not always use `image.src`?
get rid of `diagonal` and use `upperRight.subtract(lowerLeft, upperRight);` instead to avoid the throw-away instance.
We could argue that occlusion culling is outside the scope of this pull request, but I'd like to get it out of the way now since it would be the very next thing we add.
Synchronizing on codeSnippets is safer.
You are right.
Then i dont see how to correct this, adding it as a property must break  a case :s
And i dont get why it should clip only when having children
errorCode should be renamed to statusCode.
it seems OK to me. the error message should be clear enough in case of a misconfigiration. obviously this needs some docs too
Ok. Entonces dejémoslo así, pero anotémoslo que lo tenemos que aclarar.
How about using  ```T.tupleof[$-1].stringof.endsWith("this")``` ?
There's certainly no need for it, but it avoids unnecessary code duplication. Why declare a different type for every range that needs to use the dollar sign with `opSlice` or ranges which need to declare `opDollar` with a special type rather than just use `length`?
They are  good, but imo tedious to write and maintain
Don't we need this anymore?
I think a `Command` is the thing that gets run, and a `CommandRunner` is the thing that runs it. I *think* you're using `ParsedCommand` and `Command` for these two concepts. Can you pick better names?
1. %cd% may not actually be the folder where the install script resides - I really don't think you should be removing the above four lines. It is quite handy to be able to run the install script from elsewhere (e.g. from the test folder).

2. To get things working on XP, wouldn't it be far simpler to use %dps0 instead of %dp0 (instead of quoting every use of %DIR% and %ROOT%)? That is:

     set DIR=%dps0
use a more speaking name for page if possible
shouldn't this else be: else if( settings.useStencil )?
Agree. I'll update the branch.
Yes, there is an obvious race condition here in case 'receiver' is being updated by a bind and the user at the same time.

- If the bind feedback comes back first, that's expected and OK
- If the user updates arrives first, that update is wrongly ignored :fire:
this is totally useless IMO. ``$config->default`` is always ``null`` with your implementation
This is not necessary for prototypes.
This is an interesting consequence of the inlining -- even though we call `isconnected()` on a local variable, it applies to it parent argument.

But if they had:

`float x = a; status(x, "a");`

That code would return `false` right ?
см https://github.com/imomoisoft/pathfinder-ext-demo/pull/3/files#r1451721
Typo: "...as parameter *is* undefined..."
guess this is also what causes the error on travis. the failures are that doctrine/phpcr-odm#180 was not merged. i merged that one now.
Maybe rename to `body_rows` or `gallery_rows` or `data_rows` (but this may be confusing b/c it has no relation to the existing `data` variable)?
yeah, I actually tested this.  works nicely.  :)  But I'll check out your example, too.
If `!ev` is true, `!ev.type` should throw an error, no?
`static` or `__gshared`? They're mutually exclusive, DMD just doesn't enforce that. What did you intend?
Dude, it's called static, strong typing. :)

These properties are useless. I can't know anything about the values they give me. I can't serialize them to files, write them to memory, ... or whatever I might want to do. This is different for so-called Voldemort types because they are designed to not have a name. What these properties return are simple primitive values.

Yes, C code using macros is typically designed so that the programmer should assume nothing about the type of the data being operated on. We don't have that 'luxury'. Even if the type of these values changes in some $FUTURE_VERSION of Linux, you have to change *the fields anyway*, which will *break compatibility anyway*. Making these properties `auto` buys you nothing.
a/~~needs~~/will/
Non-Spring code convention.
Just reformat code.
There are a lot of diseased conventions below
This code is identical to that in clearDestination().
Thanks, I'll add the check.
There was a change in /etc/bismark/bismark.conf that didn't seem to get into the build without that change.
For JavaScript code use [this code style](https://github.com/wlanslovenija/PiplMesh/pull/199#commitcomment-1707793).
This method is probably a bit too long. Good guideline: 3,4,5 lines are all your methods "should" be.
pls import-uri la începutul modulului
I see, i didn't consider the offset until now.

According to the collada specification

The <accessor> offset = The index of the first value to be read from the array. The default is 0. Optional.

so generally the offset is mostly 0 but if it was larger say it was 3, it would start reading the array 3 values from the beginning, right? 

making the line you mention always be true like you said

```actionscript
if(560 < 563)  //true
```

instead of adding the offset should it subtract it? because its starting 3 values in?

```actionscript
if(560 < 557) //false
```

Does that look right to you?

Infact why does this original line add the offset? shouldn't it also subtract it?

```actionscript
if (array.array.length < (offset + (count*stride))) {
```

or am i misunderstanding something
Can we break this up into multiple lines for readability.  It's really hard to follow as is.
You're writing position, but nothing else (that I can find).  So there will be no visual representation.
It's kind of sketchy to overload operators for this operation.  The user could just as easily think the operators compare magnitudes, for example.  Use methods instead of eliminate the ambiguity.
is this the same thing that i did earlier? im confused why it says you are adding it... did u just move it?
I added keywords mainly because I added a new argument (type) to Message.__init__() and I was frustrated with the amount of refactoring I had to do. The keywords, I think, would make it easier in the future to add or remove arguments. I agree that x and y should be optional, though. I'll default them to None.
the entire method seems to do this:
```python
return cls._parse_yaml_file(filename).get('MESSAGES')
```
bien vu...
I guess I'm not clear on the flow here.  Can you maybe explain briefly how this is meant to work?

I see now that the check decorator does some magic with a mapping of methods, but I'm not sure what it's doing without spending substantial time looking at it.

So, how and where does ```actor_role_in_actee_org``` get called?
The `.get_backend()` here instantiates it.  This `render_model` is just here for general usage as an instance of `BasicRenderModelBackend`.
That was a copout, wasn't it?  Fixed in 029ccbb4ac29363595705d5a5d1c26acf56d44d6.
this looks like bugs waiting to happen. 

also should be smalltalk to smallTalk
worth putting an assertex(transaction) in then ?
It's "Orbit Downloader 6.4 on Windows 7 SP1"

My fault, sorry!
I would argue that if our test framework (JUnit) offers a way to group tests it makes sense to use that instead of depending on tools on top of it (Eclipse, Maven), e.g. for people using a different IDE. But like for the points below (external resources, tests that don't actually test Culturegraph), I'm perfectly happy working on this in our `lobid` branch (there is already some other stuff for which I didn't open a pull request, see https://github.com/fsteeg/culturegraph-semanticweb/tree/lobid).

Or would you be happy with this if it were in an `examples` package, as in https://github.com/culturegraph/culturegraph-metamorph/pull/1
not sure if you meant to type this or not, i might have written "...infact the last 4 digits are ignored"
@HakanS Is everything clear so far? Is it so ready for commit?
My feeling is that when you check something out fresh from master there should be *no* warnings.

If there are too many warnings then warnings are pointless.  You cannot tell as a contributor if you have added any more warnings or not without filtering through a massive list.  So instead of preventing errors, the application and ignoring of code analysis could actually make developers ignore normal warnings up to level 4 - as they are lost in the code analysis ones.
 
I agree that code analysis should be on... but only when the code itself is good enough.  It should be on locally and given a task "get project x to build with no warnings when code analysis rules y are applied".  Warnings are eliminated locally, then that change is applied back to source control.  From that moment on if anyone breaks that rule it will be due to a change that person has made locally, thus they have a chance to fix it and meet that new bar set before it is taken.  You could use those warnings as a moderator as a basis to check code quality on pull requests.  Can you really do that now?

Many of the warnings listed are not simple to fix - some are even architectural in nature.  Do you really want those warnings in the faces of people new to the SDK?
Would nice to be specific with public/internal/private. Also mark it abstract if it isn't designed to be directly instantiated.
I'm not sure if this is the right place or way to throw this exception:
1. What does the stack trace look like when something blows up in the pipeline?  If it's really confusing to a user where the error came from, we might think about at least rethrowing from within the service itself to rebase the call stack.
2. Some methods return specific codes in the 400s to indicate what type of failure.  Furthermore, most failing status codes will come with an XML error payload that describes exactly what went wrong (which is probably what we should use as the message of the exception).
redundant...
first time introducing a hard dependency sucks but I guess it will have to be.
What upper bound should be used?

2.1.* ?

>=2.1,<2.2 ?
make a method signature without version number
The two tests below fail because the code for META-256 has yet been completed since META-257 hasn't yet been merged into master
its not querystring parameters its the parameters in an Action method
Is this used for anything but tests? If so, it should not be in lib IMO.
Can we also do !!attribs.required here?