labofsahil/github-event-dataset-2012 huggingface dataset:
That's an interesting idea. The best way to represent this problem is something that's been troubling me for a while!

I'd been thinking about storing an array of co-ordinates to represent the connections. Each set of co-ordinates would be the location of an island it was connected to. What do you think the pros and cons are between these two approaches? I think one of the trickiest parts of the problem is making sure that the bridges don't cross one another, and I'm not sure which would be easier.
Can we collapse each of these into a single (long) line?
In WCF 1 `&hellip;` was used, did that change?
Is this call to updateLastStyleSheet still necessary?  I've been getting the following error and can only seem to resolve it by commenting this line out.

Console:

2/11/12 6:57:17.462 PM [0x0-0x3ab3ab].com.google.Chrome: [3970:519:12873508785561:ERROR:CONSOLE(29)] "Uncaught TypeError: Cannot read property 'url' of null", source: chrome-extension://jnmceelcmiphmhggeimpgbhlececmpmb/devtools.html (29)
I still have a lot to learn, working hard though. Building now with setEnv and a few other fixes. Thanks for taking the time to help, Firerat.
I also notice something, 'int', it stays black, but when I copy the word 'int' from another line where 'int' is green. It stays green wherever I paste it; why?
In google chrome your autocomplete field jump up and down depending on are there any suggestions or no.
Removes fragment code if we don't need it once more.
change the lines playPage(1) to playPage(16)
page 1 is the initial pose
page 16 is the ready-to-walk pose
Oh, yes, I didn't notice the .htaccess file and as I tested with lighttpd it didn't have any effect.
Nothing in web-app for this plugin, so we'll leave it out of the repo for now.
ok, thanks, I see it
notification auto power fixes 2/2
'Experimental Factor' dropdown is now a 'Condition', but I agree that this is not ideal. I think that the advanced interface will need an overhaul, but this will have to wait till we have clear requirements for the baseline vs differential Atlas. The change in this request is a minimal one that eliminates user's confusion with having to select factors before selecting values.
"fill into" should be "save to"
Surprisingly yes, at least in PhpStorm. I've moved both comments to above the assignments, and addressed your other suggestions.
Kind of, but also there's the corresponding CSS style which will also attempt to hide the div when the browser renders the event. 

As for screen readers and to the extent that I am familiar with them, I don't think this is going to work well, particularly because readers don't seem to like dynamic changes to the page. Navigating to an actual error page would possibly trigger the reader event to detect the change and read the screen aloud, but dynamic pages are probably ignored. of course, I am basing this analysis based on memory and prior experience. Could be totally wrong! :)
We can update the other ones in a different commit, but please revert this one :-)  It used to be JA-SIG we just never updated.

Also, for some reason I never got an email about this.
We probably should support that still. I'll look into adding support for wikimarkup in a reasonable way.
foreachChild(system.stop) ?
to avoid the intermediate list it should probably be: bytestrings.map(_.iterator)(collection.breakOut)
we don't want List[String]?
This one looks pretty ugly to me, multiple vars and side-effecting in filter
Yes, I know that and you know that. I'm just thinking mainstream.
I'd do:

    def fakeTimeGenerator(timeIntervals: Seq[Long]): Clock =
      new AtomicReference[List[Long]](
        timeIntervals.tail.foldLeft(List[Long](timeIntervals.head))((acc, c) ⇒ acc ::: List[Long](acc.last + c))
        ) extends Clock {
          @tailrecoverride def apply(): Long = {
            val current = get
            if (compareAndSet(current.head, current.tail)) current.head else apply()
          }
        }
Collapse the imports using brace-notation
documentation code should go into scala/java doc spec classes, see (almost) all other documentation
@bantonsson That is correct!
@rkuhn the problem is that we never go from Down to Removed, which will be fixed in another existing ticket
In python 3, the results of `map` don't have the shape that you expect. Look [here](https://github.com/dfm/emcee/blob/master/emcee/ensemble.py#L352) to see how we dealt with it in the `EnsembleSampler`.
test_save_draft                                                     ERROR
        PGError: ERROR:  null value in column "creator_id" violates not-null constraint
        : INSERT INTO "card_revisions" ("card_id", "content", "created_at", "created_by", "creator_id") VALUES ($1, $2, $3, $4, $5) RETURNING "id"
        STDERR:
Apparently it is needed.  It may be that it can be done in another way, but this really isn't causing any problems if we do it this way.
sol is not a wagn concept.  should not be here.
OptionParser will default to a destination that matches your long option name. So in this case, the dest= argument is unnecessary. Up to you if you want to keep it anyway.
we should try to keep lines short in the docs too.
I may have missed them in the diff, but are there REST API docs for this call?
Why did you add the header twice?
I don't think so.  First mention of role_card is `role_card = role_card.refresh`.  the second role_card there will break things, won't it?

in any case, needs testing.
Can you call this toggle_messageview_theme?  It makes it clear that this pertains only to MessageView and not the rest of the app.
Then some alright.  You rule.
That wouldn't work with `if times` below; generators are always `True`-ish.

Also, we're dealing with a max of 3 items here. :)
i've added msg.eval  for debugging the  worker but forgot `else`

lines 59-62
r.js generates files with the form define(["dep1"], function(){})
which were creating infinite loop

change in worker-client is needed because   location.host  is null 
when opening ace from file and new worker with wrong url crashes firefox
Please keep these opening braces on the same line as the if.
We could tell which postgres version `pgvm` are uninstalling, may be something like:

"removing postgres version X.Y.Z installed by pgvm!"
sure! same error as last time..:)
Cosmetic point: In the other file, you put all the private methods in a separate region; here, you intersperse them with the public methods.  Either way is fine with me, but please pick one style and stick to it.
[nitpick] This conditional makes me very uncomfortable. I don't think it will pass shifter's jslint, either.
I prefer arguments.length checks to argument truthiness, since arity is more explicit and predictable.
STYLE: Rename AFNICommand

Reasoning: majority of AFNI classes will subclass this, not the original AFNICommand class
This will bypass the inputs.outputtype - what I did to address this was add 

'AFNI_1D' = '.1D'

to the Info class outputtype and set the outputtype in the class, while throwing a warning to the user when they attempted to set the outputtype that it was ignored.
but this way we will loose the description string
Ah, I see now. Hm. From a UX perspective, this all should not be here, but in the LayerProperties and Styler dialogs. But getting it there would be quite some effort, so I guess we can keep it here for now.
Please document the "ready" event, and add a note in the api docs for the createStore method that this method fires the "ready" event. The latter is important for subclass implementors. You could also have the base class fire the event - whatever works better for you.
```ruby
def each_template(paths, name, &block) #:nodoc:
  templates = lookup_context.find_all(name, Array(paths))

  if templates.empty?
    raise ActionView::MissingTemplate.new([paths], name, [paths], false, 'mailer')
  else	
     templates.uniq { |t| t.formats }.each(&block)
  end
end
```

Is not better to read?
Alright, great!
This is the one issue I thought the pull request would definitely have.  I was unsure of how to make netaddr a PostgreSQL only dependency
I know this is nitpicking, but would you mind using `else super` like the other one above? :)
No need to indent.
In fact, they could be links to the method docs. `[[Position.isDefined]]`
Oh, sorry, I haven't explained clearly what they do. If you have more than max{Normal,Implicit} classes, it will create a single node that reads "X classes/traits" and the tooltip contains the list. You can see an example here: https://scala-webapps.epfl.ch/jenkins/view/scaladoc/job/scaladoc-diagram-nightly/ws/build/scaladoc/library/index.html#scala.Serializable@inheritance-diagram

There is already a list of global implicit stop-list (hardcoded in scaladoc). Also you can always annotate your node to have something similar to a local stop-list:
```
/** @inheritanceDiagram hideIncomingImplicits */ 
class NoMoreIncomingImplicits
/** @inheritanceDiagram hideNodes "i.dont.like.this.ThisClass", hideSuperclasses */ 
class NoThisClassAndSuperclassesInMyDiagram
```
don't merge, even if otherwise tempted, I just saw a bug on the line we are currently discussing
Here's a nice ascii diagram I made when I was trying to sort this out.  It's in the neighborhood of def companionClass.

    /** The internal representation of classes and objects:
     *
     *  class Foo is "the class" or sometimes "the plain class"
     * object Foo is "the module"
     * class Foo$ is "the module class" (invisible to the user: it implements object Foo)
     *
     * class Foo  <
     *  ^  ^ (2)   \
     *  |  |  |     \
     *  | (5) |     (3)
     *  |  |  |       \
     * (1) v  v        \
     * object Foo (4)-> > class Foo$
     *
     * (1) companionClass
     * (2) companionModule
     * (3) linkedClassOfClass
     * (4) moduleClass
     * (5) companionSymbol
     */
Well, the doctest passes.
I have put the list of references at the top of the file; in the docstrings I refer by them by number; is it not
acceptable?
I do not have a specific reference in mind, just the vague memory of articles discussing how nice it is that there is no `switch` in python :)
The discussion has disappeared, though I found it in my mailbox. Anyway, the dict is yielded, so it could definitely be mutated. And even if it were safe, any Python programmer worth their salt would be forced to inspect the source code just to be sure.
Any particular reason to change these two but not the others?
This does two changes 

1. top down instead of bottom up. I suspect that it is more efficient to try to apply rules to big things before smaller ones in hopes that big chunks are removed quickly
2. we apply lots of rules to each node before moving on. There are far fewer traversals. This is on recommendation from aaron in the rule-subs branch. 

I'd also like to note that I was able to radically change how rules traverse trees without introducing an error in the application code (currently only MatExprs). It might actually make sense in the future to exhaustively optimize this single line of code by checking all possibilities against the test suite. 

I'll put those two notes in the commit in a while.
Use backticks to create latex output in sphinx.
You added trailing whitespace here and in a number of other lines. Please remove any trailing whitespace.
Add tests for this function (as evaluation).
You need to change these function names to match the new longer versions "linearmomentum", etc
好了，现在好像差不多了。
fixed in 1f653c5
Here and below. This seems a bit strange? If the node has 1 version then there will not any rows and columns in the nodal element matrix? The element matrix then only gets entries for the versions. Shouldn't this loop over the nodes, derivatives and versions?
It's the end of the day on Friday but this is still fuzzy to me. Maybe just elaborate a bit in the comment?
any ideas?
Which isn't user friendly. Then you have to go way up into your ExceptionHandler, catch the page not found, and still redirect to the index page. Why? I can see the purist argument for it, but we're writing web applications.

Plus, then we have to modify the tutorial to talk about handling exceptions in this way. I'd rather reserve that for a future part of the tutorial which I'm working on. Already 3452345 things going on in the blog tutorial.
Response is not used.
if it is an error we can use:
  Log.error "Error loading content data cd=%s" % arguments["cd"]
I think I'd probably melt them into the one single implementation, since this area is unlikely to get touched or refactored for quite a while I would think.
Should this say `as breaker has been tripped`? Also, could this get an alert code (but still stay at DEBUG level) ...
This is much more clear and easier to maintain... IMHO I would keep it as it is
again, no need for the =="1". Also, since you are checking this request variable twice, you might consider doing `$back_to_post = request_var('backtopost', 0);` and then doing `if ($back_to_post)` each time you need to check it.
We will be using symfony controllers and routing anyway?
"it" seems fine to me if "item_type" isn't available; the next best would be "item_t" or "i_type", both of which are a bit silly. Does anybody actually look at what the keys are called anyway?
Is this every going to be anything but 1?
Checking in commented out code isn't great.
Put this into a seperate file too.
I am hidebu
All the places where forEach is used aren't hotspots. I mean, they're not run every frame -- all of them are setup functions, used when initialising an animation or adding a subject.
Fair enough. Perhaps we could consider a url builder to use so we're sure we get consistent results.
I thought that jslint complained about `a = b = ...`.
agree. I'm gonna recommend that in the monotonic-timestamp readme also.
The properties and method override are missing XML comments
Tssk tssk...empty summary =)
What is the build error you get when using this patch?
It might be better to fix it, rather than to omit it in order to have consistent behavior across architectures.
Create the view of the Grid to test
Strictly speaking, there is no 'time' dimension.
不要主动调用。
I can't remember for sure, but is there a risk to get a SyntaxError on Python 2.4?
I do agree with your derivation. However, the old code was not wrong, it actually arrived at the same answer, but I prefer your derivation to mine because it doesn't require a transpose. 

Specifically, the old code had the tensordot inputs switched: tensordot(y, gz) instead of tensordot(gz,y). Therefore the old code had to do the transpose to get the resulting gradient dims into the proper order, but after that transpose it produced the identical answer.
Obsolete comment -- this BUG is now fixed?
Belly rub watchdog.
http://www.python.org/dev/peps/pep-0257/#one-line-docstrings
snd?
Good good. Maybe we can document all the global-level containers we have and reset them all with a similar function call?
These methods seem to duplicate a lot of the actual implementation, which definitely isn't right.
If you aren't explaining it, or showing how to use it, then its just a distraction - and should be left out.
Maybe my comment was not clear.

I like the approach. However it is not clear why you do not override the method "clean" instead of "is_valid" as stated in the django documentation.
In the former case you will save some lines of code (for example you do not need to specify an _add_errors method). If there is any reason to not follow the official django documentation for custom validation, please document it.
DISTRIBUTED BY (fid) may be better, as this table will be joined on it.
Added a sentence that this does nothing more than calling the backend's seed function. The best way to use it is use it only for debugging!
Specifically, the `null` check. I would assume that the empty string check is superfluous? Wouldn't the code below work fine for that case?
Didn't you have some funny camelcase mapping code, is this still correct?
>but it seems to be that the Makefile defines those variables at the start and they will override whatever is passed in as command line arguments.

That's not how make works; command-line arguments have precedence over the standard assignment (=) operator. You of course need to pass these variables to both the "make" and "make install" invocations; it does not "remember" them between invocations.
Really the whole thing should be turned into a Requirement.
Yet another untraceable log message and a callback with no error passed to it.
What @jmazzi said
Also, why do you need the response when loading the schemas?
Most definitely :)

On Nov 25, 2012, at 1:24 PM, Dave Smith <notifications@github.com> wrote:

> In lib/ijod.js:
> 
> > @@ -99,6 +75,87 @@ function qq(q, sensitive) {
> >    return ret;
> >  }
> >  
> > +
> > +// returns all rows but validates by idr (required in row)
> > +function dbAll(base, sql, binds, cbDone)
> > +{
> > +  var ndx = {};
> > +  var ret = [];
> > +  instruments.increment("ijod.partitions."+(partition.getPart(base)||"none")+".range").send();
> > +  instruments.increment("ijod.ranges").send();
> > +  partition.readFrom(base, function(parts){
> > +    if(exports.debug) logger.debug("dbAll", base, parts, sql, binds);
> > +    async.forEach(parts, function(part, cbParts){
> IIRC, forEach runs in parallel -- do we want to hit all the partitions at the exact same time?
> 
> —
> Reply to this email directly or view it on GitHub.
>
I've set these to bail properly without an HTML5 player, but I've left them stubbed out in a form that'll make it easy to reintroduce phonegap functionality if/when we get there. The PG audio plugin supports all of these in some fashion. It looks like the PG video plugin (as yet) does not.
Added a comment to #1029. I thought the Async withTimout() util handled this.
The problem is the sort plugin listens for the same "jstree.create" event, and does the sorting immediately. We register for the same event, but are second in line since we register after the plugin. 

I tried one more thing - call sort, but this time sorting the parent of the newly-created item. If this doesn't work then I'll need to wait until I get access to a Windows machine to fix it.
Do we want 'command' to be a getter/setter? I think it should be read-only.
for all of this paragraph, maybe replace "us" with "the application" or something like that... I'm not sure what would sound best there...
The problem with putting the argument list on the same line is that Emacs doesn't know how to indent it correctly. The function body gets indented the same as the argument list.
Drop the constructor
We generally only use final for parameters or local variables when absolutely required (i.e., they are used in anonymous inner classes). Using final everywhere makes the code too verbose with no significant benefit, IMO
The 35 seemed like a typo in the readme.
No, you need function. But you should make it call default function in a way to get request. This is a bit tricky, but you should check nodewatcher's account sub-app code and see how it is done there. ;-) (I made a hint some time ago about that, too.) Good luck searching. ;-)
I'd totally do that
If that's ever going to be feasible we're going to need an index on the name column. Probably on the timestamp column too. Otherwise we won't even be able to do the pagination. 

By the way, can you show me how to use the API to do edits on a release. The ones I had I made manually with mysql.
you can remove both font-weight and font-style
Message please!
Could you move `i` to top, cache ` _listContainer.childNodes.length`
This is not necessary given our list of browsers -- see the wiki.
We don't need this, that's the point of having it go last.
You don't really need to escape that last quote, right?
> Can the following check improve that?

> ```
if (!this.loadCharProcs)
  operatorList = this.charProcOperatorList[glyphName];
```

This makes the calls in `getTextContent` work. But if there is a type3 font on a page and getTextContent is called before the `PartialEvaluator_getOperatorList` function on the page, then rendering the glyphs later fails, as the operatorList is missing.
Unless the diff is lying to me, this looks like a 2-space indent. Can you make it 4 spaces, to match the rest of nose's code?
Is this code still necessary?  If not then remove it.  If it's still required sometimes then make it conditional.
WTF? ;)
Why not just use 'i' instead?
Tähänkin long
there's a problem here when `bit_shift` is a non-zero multiple of 64. Using `B.chunks[s+1] << (63-bit_shift) << 1` should solve it.
This was to mimic the notation yum uses. N is big to indicate the default option. When you hit just the enter the default option (No here) is used. To make it more user friendly we should indeed use gets.strip.downcase
Should 'name' be 'new_name' in the error message?

May want to use something like: 
_("Could not copy system group [ %s ] to [ %s ] ") % (name,  new_name)
Please, wrap the line, 120chars per line is maximum.
Don't think so, unless you want to go through all the users when deleting an org, to check it wasn't default for them
@pitr-ch 
add_option is described here 
  http://docs.python.org/2/library/optparse.html#defining-options
and it does not have "required" option.
We only define it for OptionValidator (see check_options())
I agree that having "required" as separate string would be nice, but that is different work. I just made our code consistent. And as this seems like long diff, it is really only fraction of our all options in katello-cli. So changing it everywhere where is used "required" will be much bigger work.
It also seems like you don't have to pass `null` as the second parameter since `==` will catch `undefined` as well.
@Seldaek It's used for information, just to create a routing key for rabbitmq(or over MQ server, i use it for rabbitmq), to easier manage logging messages. I'll check on $record['channel'], maybe it is better to use it.
This is still vulnerable to </SCRIPT>, </script [^>]*> and more. I would be inclined to escape every "/" instead of just "</script>".
@taldcroft - I guess that I was thinking the word 'data' sounded pretty generic - i.e. if the variable is `val` and the description is `data`, that is not enough to tell me what kind of data this is. I guess 'times' might be confusing though?
@mdboom , `AsyncConeSearch` is mentioned in the `client.conesearch` "Examples". From your feedback about the docstrings, I think I'll have to move them to `client.rst` and split them into clear sub-sections.
oh.. not IsInitialBlockDownload() again...
If INVALID_SOCKET and SOCKET_ERROR are both -1, there's no need to compare against both. I agree replacing `>` with `!=` is sensible, though.
Oh my - never mind then.
That would require every single method to check whether the parser has ran already ran and call it if not. Either I inline that (three LoC per method) or create another method and call it from every other method. That's just ugly. This object is utterly useless if you don't run the parser. It's not like some part of the object is useful and some of it isn't -- the whole object is useless w/o the parser. I could argue that it indeed does just that: assigns the proper values to the class properties.
when is this method called? Did you mean `_data_changed`?
should be in input... and let's call it `is_bpc` and make it a boolean
Seems like a bug fix, should be a separate commit
This is the main project README file, it shouldn't be touched for this PR.
I think it makes sense to leave the default as True here, because that maintains backwards compatibility.
Why are you adding the width & height? shouldn't we just inherit from the parent?
Please modify this after merge.
Also: crlf smudging
hm yeah, I understand. So either a middleware, or perhaps simply a view decorator? What I am thinking about here is that if a page needs some view logic, it won't use this simple shortcut. How do I still let it have a newsletter form in the footer?
This file can be empty since you don't use it. Just don't delete it, IIRC Django uses it to make sure this is a real "app".
Like the .span(*) mixin, we also have .span_narrow(*) with a narrower column width for smaller viewports. Usually just swapping from wide columns to narrow columns -- with the same number of columns -- handles the tablet size. So this would be .span_narrow(7)
This change drops the line length from 80 to 79 so check.py stops complaining. It's cosmetic.
Is there a reason you can't test all of them (if they exist)? What happens if (by some dark magic) there are three instead of two?

    for tile, listing in zip(featured_tiles, featured):
Should `setting` have a default value?
There's an idea, we could just write to memcache for that switch and avoid a few db calls per test.
this import should go in the block with `import jingo`
Personally I think it's ok to have that reserved. I'll defer to you though.
yes. We rely on the use statements in the phpdoc too (see all other places)
Please do not remove this. Or the addViolationAtSubPath I give you a usecase where this comes in handy.

```php
class UniqueInCollectionValidator extends ConstraintValidator
{

    /**
     * {@inheritdoc}
     */
    public function validate($collection, Constraint $constraint)
    {

        if (!is_array($constraint->property_paths) && !is_string($constraint->property_paths)) {
            throw new UnexpectedTypeException($constraint->property_paths, 'array');
        }

        if ((!is_array($collection)) && !($collection instanceof \Traversable)) {
            throw new \InvalidArgumentException('This validator should only be set on a array or class implementing Traversable!');
        }

        /** @var $propertyPaths PropertyPath[] */
        $propertyPaths = array();
        foreach ($constraint->property_paths as $pp) {
            $propertyPaths[] = new PropertyPath($pp);
        }

        $values = array();
        $count = 0;
        foreach ($collection as $item) {
            $value = '';
            foreach ($propertyPaths as $pp) {
                $value .= "\0" . $pp->getValue($item);
            }

            if (in_array($value, $values)) {
                $this->context->addViolationAtSubPath('[' . $count . ']', $constraint->message, array());
            }
            $values[] = $value;
            $count++;
        }
    }
```
and btw, you are setting them in the router **after** it is used, due to the priority of the listeners.
And the initialization of the router should go in the RouterListener
Isn't this a violation of the Liskov Substitution Principle?
Done, and test written.
We could say the same for the context.. One assignment isn't the end of the world in terms of duplication.
and btw, this would **break** the BC for the full-stack framework as you would be replacing the app variable with a variable providing less stuff.
I'm not sure how to name it. If you have any ideas, let me know, the only alternative I got currently is getMetadataKeyValue() or getMetadataKeyInformation()
コミットメッセージが first commit だと何を変更したのか分からないので何をどうしたっていうのを書くと良いと思います
then we can make room when they come :)
What about

    arguments = params.fetch(:registration, {}).fetch(:arguments, {})

also an option
Plese use @"OK" - it's iOS standard
Test feels too big. I'd break it into three (maybe 4) separate tests based on the three stubbed methods, and a separat test for the `message_body`.

Reason for more smaller tests is when they break, it's easier to read and more specific to the feature which has broken.
Trololol, fixing it.
思考了一下，我个人觉得版本号这样来命名吧。A-B或A.B（中间有个点），A为年份，B为版本号，其中B为整数时为公开发行，B为小数（比如2.3）即为在版本2的基础上进行修改的内测3版本。你觉得呢？
Actually I'm going to retract my point and say it does make sense to include these extra request types. Seems like they are only used in [WebDav](http://msdn.microsoft.com/en-us/library/exchange/aa142923.aspx). I'll fix the typo, remove the extra non-standard stuff and merge this in.
Is this include needed here?
user doesn't have to pass all parameters
wow, you can do that!
fixed... attention this comment is on a revision and not on the current diff
Yes, I can put it in Flame.Panel, no problem. I suppose it's not to different from the title bar in that it's hidden if it's not activated.
I would strongly advice you to group your views, collections and models in separate namespaces. Such as `app.models.Group`. Also I think you should follow a naming convention for clarity like `GroupModel` or `ScoredGroupCollection`.
True. I didn't know about .attr() when I wrote the test that used .className. Fixed here: 3b2db74
These comments can be removed.. i put it in reverse order already.
took the backdrop static off the new modals because i would rather let the user excape them then them feel likehtye have to make a new session corpus etc.
I don't think this will catch all promotion events. For instance, the event name for coupon code promotions is `spree.checkout.coupon_code_added`. From what I could tell all the promotion events do not start with `spree.promo`.

Maybe that is something that could change? I imagine that would would be a 1.x vx 1.2.x change because it would most likely break a bunch of code.
`.disableSelection()` is deprecated, it needs to go away. It's there to prevent text selection during drag.
Just use .css("width") here, wrapped by parseInt, of course.
I don't think you need to do a variable of eventId since you're passing evt as a parameter to addProviders
seven (data-state="edit")
I think that pass the db value of property if id is exist.
So, I check it together.
Array.isArray faster in ES5
Please, place the variables as closest as possible to their first use.
ahah, how did I let this extra space pass before? ;)
Indeed it is working :-) I checked all the cases where the CustomDialog was previously used and invoked and now the "Confirm" BB is used and shown instead. The only drawback is the fact that in order for the dialer to cover the whole Communications screen app, we needed the BB to be in the main index.html dialer's file, and consequently the contacts and Facebook JS files running in the Contacts iFrame inside the Communications app need to use the parent.document.getElementById() to "communicate" with the BB (show it and hide it, basically).

@etiennesegonzac , @basiclines , @jmcanterafonseca , would you say this is the way to proceed? On the other hand, would you be fine with extracting the injection of the HTML BB code to a library giving the developer some options to configure it such as the text and listeners of the buttons and so on (much like it was in fact done in the original CustomDialog.js file?
Calendar colors makes perfect sense (because we can avoid the db overhead) but why time_header?
What is invalid exactly?
Use addEventListener instead of onmousedown/onmouseup directly.
Semantic keyword strings will be helpful to visual designer who doesn't 
understand Japanese at all. Thanks.
Good trick :)


Jean

On Fri, Jul 27, 2012 at 5:08 PM, David- <
reply@reply.github.com
> wrote:

> > -         $('#loading').hide();
> > -     }
> > +    // We create a container before the AJAX request to display the
> widgets in the right order.
> > +    id_widget += 1;
> > +    container_object = $('<div id="widget-cell-' + id_widget +
> '"></div>').appendTo('#' + placeId);
> > +    //container_object = $('#' + placeId);
> > +
> > +    $.ajax({
> > +        url: url,
> > +        context: container_object,
> > +        success: function(html){
> > +            $.fn.AddEasyWidget(html, this.attr('id'), {});
> > +            this.children().unwrap();
> > +        },
> > +        error: function(xhr) {
> > +            this.html('Error loading this widget!');
>
> Yes, "this" is the jQuery object given in "context".
> The unwrap is used to remove the empty div (the "this" object) we have
> added before the AJAX request as a placeholder. That's way, we finish with
> the same HTML as before and we didn't have to modify the easyWidget plugin.
>
> By the way, we have forgotten the unused "//container_object = $('#' +
> placeId);" line. Oups. I remove it.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/naparuba/shinken/pull/482/files#r1253248
>
I don't think this is quite right, since the childopts could be something like -Dsome.config="aaa bbb".
What do you think about moving it into examples/engine.py or something like that? You can leave a place holder here (deployment/engine.py) with a comment saying we haven't had time yet but to look at the example py file.
I looked at the faraday redirect follower but it conflicted with the repo archive api that returns a 302 redirect oddly enough.
(1) You can name FallbackHandler => CodePlexHandler
(2) Since they are stateless, could we make them Singleton.
(2) I would order as follow.
- BB, GitHub, Codebase => probe http header (cheap)
- Rest probe body => more expensive.
It would be ideal if all can rely on header probe.  Body probe may raise issue if body is not in common form (eg. not all in payload) and body may not be able to be read again.
对于这个函数来说，由于需要保存到 rs 中，需要授权，故此可以认为是 rs 的功能之一。
但是对于 url?imageMogr/xxx/save-as/<Bucket:Key> 来说，要想把此功能放到 rs 服务，实际上应该认为 <Bucket:Key> 是主体，其他是参数，也就是函数原型应该是类似这样的结构：

rs.imageMogrify(key, url, opts)

其中 opts 是 imageMogrify 的参数。bucket 名则已经在 rs.Service 构造中传入。
remove case class.
MockHttpRequest
Markers don't have any of these attributes .

see: http://duncan99.wordpress.com/2011/09/25/google-maps-api-adding-markers/
I moved the forms from views to a `forms.py` file, but I was having some difficulty using ModelForm. It looks like I'm going to have to change several things with how my forms work such as validation in addition to utilizing ModelForm, so I will probably address the form problems in a separate ticket.
Woah, yeah. This is weird.
shouldn't this be `contact_types`, then?
Do we need to both subclass *and* delegate?
I wonder if this should just always be included? @djmitche @maruel
When is ssList going to be empty? And in that case, do we still perhaps want to create a build. In any case, the `return` will fail currently, if that ever happens (or perhaps do the wrong thing).
It isn't clear from reading this description that the callback is just used for generating the message, which is always posted to gerrit, rather than just an arbitrary callback from which one can post to gerrit.
I have not really looked at the code conventions, sorry.

If you think the solution is fine to be merged, I can fix that and send a new pull request. What do you suggest?
We should not be building the array later, this is what I would do

```c++
jsval elts[children->count()];
for (...) {
    // set elts[i] here
}
JSObject *jsarr = JS_NewArrayObject(cx, children->count(), jsval);
```
That way, we won't need to root anything.
typo => command
There is no assertion.
I'm sorry but my measurement is different (but it still wonders me):
I'm using exactly the same code (same debugging - none) and I'm only removing and adding the bit-length field of the variable in the struct.
with bitfield: 22122 bytes
with uint8_t: 22636 bytes

btw: it saves one byte RAM per configured sensor (default 10 bytes)
Should also include ``bundler`` as a build dependency.
It's in gitolite's hook file. 

not safe.
It isn't yet.  I was already in `UiaDll.cpp` and I need this to be able to implement using the `:text` accessor within the DLL itself.  It currently is not used yet.
Was this file just committed accidentally?
Would you mind changing this to `"0.12.x"` instead, so that it's up to date with our latest release?
It is a good idea to do such thing for compatiblity. It is a bad idea to start using multiple names.
I'm totally fine letting them as soon as we use only main name in our codebase. (`serialize`, `parse`)
Either title or this section is confusing. Is it embedding into app ?
Or do you mean install instructions ?
And remove this line
ok, added medium for populate_summary_cache at 10 minutes.  and added medium to process_objects at the same interval as the others.
So this is like a template? Wouldn't it be better to have it as a global variable in that file with a specific name?

I know that this file doesn't really obey the coding style but please keep it as best as possible, e.g. indentation, body of object member methods.
@pcarlisle yeah fair enough - I've modified the code to reflect this.
glwtWindowCreate should not show the window on the screen. This is to allow writing offline tools, like shader compilers and texture compressors that use OpenGL but don't open a window.
Probably better to use Date.today instead of using send() like this.
yeah some :sparkles:
If you specify a runner, the `DetermineRunner` function isn't called, so the color flag isn't used.
`top` is defined by Capistrano and is used here to avoid calling some other upload method that is defined in the global namespace.
These comments should be on the lines immediately preceeding a _("translatable string") so that they end up in the files sent to translators.
Is the delimiter "|" used also somewhere else in the code? Then it might be defined as a constant (at LanItems.ycp).
You need to test what type of $input you have -- $input can be either an InputInterface or an InputFilterInterface. When the latter, isRequired() is not available. (Encountered this issue when testing Zend\Form based on this commit -- there's now fatal errors in that test suite.)

Please correct, and make sure you run the Zend\Form tests as well as Zend\InputFilter tests to ensure there's no other unexpected breakage.
No problem, that's been done.
If you set the expirationSeconds after the "CONTRUCTOR", or after expired, it reloads the expire time and doesnt expire the session.
Wrong doctype (should be bool). Furthermore, please add a cast to bool in the function : $this->onlyAlnum = (bool) $value;
See line 691
Also, I think we should use the same pattern in components for default config. Eg a method instead of the public class var. 

-Mike

On Apr 9, 2012, at 12:25 PM, Luke Opperman<reply@reply.github.com> wrote:

>> +        $this->_config = $config;
>> +        
>> +        $ref = new \ReflectionObject(static::instance());
>> +        xdebug_disable();
>> +        
>> +        $keys = array();
>> +        do {
>> +            try {
>> +                $keys = array_merge($keys, $ref->getProperty('requiredConfig')->getValue());
>> +            } catch (\Exception $e) {
>> +                
>> +            } 
>> +            $ref = $ref->getParentClass();
>> +        } while ($ref);
>> +        
>> +        xdebug_enable();
> 
> Got it.  sounds like we could skip the xdebug calls just by checking for the property then?
> 
> However, I'm not a big fan of the approach, sneaking around the inheritance model of php - it simplifies the end-class but at the expense of giving the end-class no ability to control the final situation, and the end-developer the ability to trace using regular knowledge of php. vs using a method rather than a property:
> 
> public function requiredConfig() {
>  return array_merge(parent::requiredConfig(), array("someValue", "anotherValue");
>  // but have the option of doing more.
> }
> 
> (that said, it would be nice if PHP offered the dynamic property / metaclass support of our preferred languages, to avoid having to make this choice. :) )
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Cumula/cumula-core/pull/43/files#r660772
@stloyd thanks for advice, done.
Your bundle's badge has been queued for generation
use Github\HttpClient\Exception as GithubException;
Well, it's half-right. There shouldn't be a space after `=`, but there should be a space after `;`. In other words, the correct version is `<?=$variable; ?>`.
Remove the tag contents - Rule the web
We could probably make this change in `master`, unless it was accidental?
That is my guess, too. But I honestly can't figure it out. Gedit opens it without problem with automatic encoding. The command "file handler_cgi_base.c" returns "handler_cgi_base.c: C source, UTF-8 Unicode text". Only when I force Gedit to open it with ISO-8859-15 it displays it like that.  Additionally, when I look at the file in Github, everything is okay, too.

Hmmm...
a usable filter or an error. what does ldapsearch with empty string as filter return? (otherwise support __init__(self,value=None) and return LdapFilter() instance)
This should be using `filetools.adjust_permissions`, but I'm working on that in a different branch, it's useless to change it here. Just discard this remark, it serves as a reminder to myself to check where os.chmod is used.
But then this code can be removed?
code style: add a space after the ':'

fix indentation: the first character of this line should be in the column _after_ the column where '{' in the line above
It will install correctly, but the installation will not work because the license server setting is wrong.

We need a general way of handling this, so that the regression tester can detect this and take appropriate action in case the software run tests (if any) fail.

E.g. use "licserv.example.com" as a default setting for all license servers.
vars_attropl

What is attropl short for? Attribute ... list?
`Połącznie kont`
Then, we add a dependency on the relevant artifact:
save sprint before page
Again, why the alias?
Trailing whitespace in a bunch of lines from here and below.
"latte"
It could be but I think taking names from a form and returning groups is pretty specific to form logic, not to model logic.
Same here. Whitespace inside the .replace brackets
`Popcorn.foreach` plz
Any way to avoid calling the same code twice? How's this benchmark?
selectタグのオプションで利用したいならそれ用のhelperがあります。
what should we do with the edit? should we add another link?
Added a first go at hints. Is there a wiki on the templating you're using in the answers? i.e. I'm specifically trying to figure out how to start an each from the 1th element instead of the 0th.

Also couldn't figure out how to store intermediate variables in the hints, or if that's possible. It would make the hint code shorter/cleaner.
It would be nice to elaborate a little here, e.g. "Use the fundamental theorem... F(b)-F(a), where F(x) is the function whose derivative is f(x)." or "F(x) is defined as the function where F'(x) = f(x)" or something like that.
This is workaround for jvm bug http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6302954
It could, but then it makes it hard to test as the indentation required by coffeescript gets in the way.
omg everyone...

# INJECTION HAS BEEN ERORR ! #

EVERYONE HIDE.
You can remove this part - no need for commented out fragments.
I'd vote for using @QueryParam here instead of @PathParam.
We don't do replace strings in templates, out build process is not meant for having knowledge about the application on a design level. We use the design system in eZ Publish for these things, as in only current way to inject differences is using css and if needed overriding template.
Hello David,
Yes, I realy meant 
jList := JOIN(origData, dsIdList, LEFT.id = RIGHT.value, GetRecords(LEFT, RIGHT, baseId), LOOKUP, FEW);

Regards
Victor
I don't think you meant to commit this line. Also, every other change in this file is a whitespace change. Noble idea, but since you didn't actually make any functional changes to the file, I'd prefer to see the file reverted.
It's really no biggy either way, it just helps with avoid repo contamination for people who might not notice they committed a file.
Could we not use the @plibdir variable here so that we aren't hard-coding these paths in multiple places?
I think we said we'd split this out into a separate `it('verify create comment validation)` test
should be spaces between these parameters that are being passed.
we could also forward to matchRequest, but would lose all request parameters except the url. not sure if that would be a good idea. thoughts?
Ummm, maybe you're right. I don't have my notes with me right now. You known the code much better than me. I'll be happy to test the changes you thing are better.
Some part of this may be necessary, but I'm generally confused as to the purpose of this block of code.
Thanks for finding that, was wondering what the lag was, will async it up tomorrow

Sent from my Windows Phone
________________________________
From: Brendan Forster
Sent: 25/06/2012 7:56 PM
To: Jake Ginnivan
Subject: Re: [DownmarkerWPF] Code cleanup (#298)

> +        void WbLoaded(object sender, RoutedEventArgs e)
> +        {
> +            WbProcentualZoom();
> +            loadedWaitHandle.Set();
> +        }
> +
> +        public double ScrollPercentage { get; set; }
> +
> +        public IntPtr ControlHandle
> +        {
> +            get
> +            {
> +                if (windowHandle == null)
> +                {
> +                    windowHandle = (long)Application.Current.Dispatcher.Invoke(
> +                        new Func<long>(() => CreateWindowHandle(control)));

This line blocks on the main thread - for a while - when opening a file for the first time.

Not sure of a solution (brain is fried) but concerning nonetheless.

---
Reply to this email directly or view it on GitHub:
https://github.com/Code52/DownmarkerWPF/pull/298/files#r1041225
Требования к функциональности программы явно указаны в ТЗ искючительно для случая 100 элементов.
Глобальные переменные - плохо. Если хочется избавится от магических чисел, то лучше создать метод initWithLenght у класса Cell.
@beribas нет, вы бы так ничего не сэкономили, ведь потом каждый чар нужно переводить в NSString, и потенциально каждая буква будет отдельным обьектом в памяти (опуская оптимизации). Не хорошо. Вариант @hmmvot лучше потому, что у вас в памяти будет только 4 обьекта, и дальше вы просто играетесь с их указателями. В последствии можно будет сравнивать указатели, а не содержимое обьектов (однако тут свои подводные камни, когда речь зайдет о внешнем интерфейсе класса), но это в этом и только в этом случае.
Спасибо за замечание - тут идея в том, что mutate обрабатывает два крайних случая, поэтому ассерт включает 0 и 100, а doMutate - стандартный кейс, поэтому ассерт не включает 0 и 100. Нагляднее было бы сделать `percent >= 1 && percent <= 99`.

On 06.11.2012, at 9:39, zhorkov023 wrote:

> In osx-project-1/main.m:
> 
> > +@implementation Cell (mutator)
> > +
> > +- (void)mutate:(int)percent {
> > +    NSAssert(percent >= 0 && percent <=100, @"Percent should be between 0 and 100 (inclusive)");
> > +    if (percent == 0) {
> > +        return;
> > +    }
> > +    if (percent == 100) {
> > +        [self regenerateDna];
> > +        return;
> > +    }
> > +    [self doMutate:percent];
> > +}
> > +
> > +- (void)doMutate:(int)percent {
> > +    NSAssert(percent > 0 && percent < 100, @"Percent should be between 0 and 100 (exclusive)");
> 
> NAssert у тебя выполняется два раза в строчке 21 и 33. Хотя процент не меняется.
> А идея классная про проверку процента
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
А почему нельзя использовать более краткую и читабельную форму обращения, кроме как по идеологическим причинам используемым в языке.
Да, пока у вас 100 элементов. А если задать 450 элементов?

Да дело даже не в количестве элементов, я подозреваю, что вы сейчас будете говорить что-то типа "в задании указано 100 элементов и точка!". Точно так же можно сказать, что в задании указано что х - процентный показатель, и точка! Соответственно, количество элементов для изменения ещё нужно вычислить, исходя из этого процента.
попробуй здесь использовать log_in вместо 4х строчек. DRY же )
This only works if the default browser is Chrome. Is it worth detecting if the default browser is not Chrome and informing user? Is this just a temporary fix?
You added this new test for `take:`, so I assume you want to address the issue.
The test doesn't catch it, because a `RACSubscribable` made with only `empty` and `concat:` always completes.
What you need is a subscribable that sends one value, and then doesn't complete.
It could probably be a `RACSubscribable` specific test.
This should be a category method on `NSInvocation` – it doesn't need a reference to `self`.
拼写错误吧，是unsigend
coords : array,  shape=(n_vertices, 3)
Actually, it's pretty easy to include both stderr and std. What do you think about having both? That gives us backward compatibility...
"forth" vs "fourth", "internet" vs "Internet"
You should include the correct namespaces before this line:

    use Symfony\Component\DependencyInjection\Compiler\PrependExtensionInterface;
    // ...