labofsahil/github-event-dataset-2012 huggingface dataset:
i am not sure sure, but i would like to see the bugs in haystack so we can hunt it down :)
seen.values.toSet is probably the best option here
Lo vi, pero no era lo que yo buscaba, además me parece que usa la fecha de
hoy del navegador y yo no quería depender de eso


On Thu, Nov 29, 2012 at 12:30 PM, Alpha <notifications@github.com> wrote:

> In source/CommonJobs/CommonJobs.Mvc.UI/Scripts/my-menu.js:
>
> > +                    text = "Hoy";
> > +                } else {
> > +                    if(days == 1) {
> > +                        near = true;
> > +                        text = "Mañana (" + text + ")";
> > +                    } else {
> > +                        if(days == 2) {
> > +                            near = true;
> > +                            text = "Pasado mañana (" + text + ")";
> > +                        } else {
> > +                            if(now.day() >= 4 && days < 5 && date.day() == 1) {
> > +                                near = true;
> > +                                text = "Próximo Lunes (" + text + ")";
> > +                            } else {
> > +                                if(days < 7) {
> > +                                    text = text + " (en " + days + " días)";
>
> Creo que moment.js tiene un feature para hacer estos fuzzy-dates.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/229/files#r2265962>.
>
>
I prefer the form above

```ruby
def as_json(options = {})
```

I trust that if someone is explicitly calling `as_json` with `nil` that they mean to, and therefore should be given an exception.
Using "slurm" defeats the purpose of the drmaa abstraction. Maybe scilifelab.utils.drmaa is a more appropiate name for a wrapper (if such a wrapper abstraction is needed at all).
GREAT use of gsub and regular expressions!  Gold star!
Hi!  Do you still have questions after seeing Renee's answers?  Let us know, we're happy to help :)
it should be prefixed by 'get'
Use multilines
@jabley is right, Rails wouldn't be able to automatically determine the inverse of this operation. Therefore the changes should be in an "up" method - and a down method optionally defined.
You mean at standard mutexes? The problem is that there is no shared mutex (multiple readers, single writer) in the standard... or I could replace with std::mutex but then the reading lock would be expensive.
In favour of readability, I'd call this ConsistentHashStatistics
Err, duplicate...
Can't we just remove instead of comment ?
Only 2 dots if we want to imitate the git command.
We could start using specta/expecta for this feature.
I'm not a fan of renaming the variable here -- it makes it less clear what's happening in the lines below.
Wrap these comment lines to less than 75 characters
sonofagun. Will fix and re-push.
<3 thx!
Actually, let's take care of this in a followup.
So is it a constant?
The variable is never used here, and this essentially looks like a global variable which is bad practice.
It's hard to spot where it is read/modified, and what the consequences of the modification are.
But anyway, that's been in there before and a different discussion
would suggest also making this CDATA:
<code>desc.appendChild(this.getXMLDoc().createCDATASection(...))</code>
I would prefer to see this line simply removed. Since we use Git, we have a record of it and could get it back. No need it tempting ourselves to uncomment this line accidentally in the future
@christianv  resolve
oae-hidden
Funny enough, it's never called.
i don't see any performance advantage. and if you create query from dql there is no other way to set parameters than via query. thing is if you change the way how you create the query (builder/dql) this will stay the same.
should this get [...] "the page: " + err?
Alright, I created a new branch off this one which sketches out the code for the approach that I'm talking about. It still needs unit tests fixed and added for the new code (especially in DomHelper), but it should give you an idea of what I'm talking about.

https://github.com/typekit/webfontloader/compare/bs-improve-font-watching...bs-improve-font-watching-2

Maybe we can work with that and merge it into this branch if we decide we want to go with that approach?
oh, yeah. or rather I depend on connection.is_experiment_enabled? to return true or false when the db entry is nil.
I guess this "Must be less than \c eviction_trigger" too?
I prefer more of a duck typing approach. If it has a handle method it will work, otherwise there is going to be an error anyway.

The interface is more for extension authors to see what they need to do.
Are you sure the method ``setOptions`` can be called on ``$this->_paginator`` (of type "object<Zend\Paginator\Paginator>|null")?
Are you sure the class "Zend\Amf\Parser\Exception\ExceptionInterface" actually exists, or did you maybe forget to add a USE statement?
a city guard's armor
data callback调用一下位置。
cs? пустая строка в конце файла
Thanks for looking at this so quickly.  Obviously the specs of `#summary_url` and `#summary_message` aren't that strict.  The only place this really seemed to matter was the Campfire hook.  It turns out the Push helper doesn't include the URL in the message, so your change actually made things more consistent.
please leave all those quotes alone, just blows up the diff
occurring
Egregious use of creative spelling
Because they are the Best. Descriptions. Ever.
degree is also fixed
I believe the rule is multiline arrays are on the same line, multi line functions on a new line.  I did run this through phpcs multiple times (obviously since that is how I know were the issues were).
instanceof is a better way to check for a target being a property--it consults the prototype chain. This would fail for anything passed in with a target property, such as {target:3}
Ok, tinha-me esquecido disso. Assim faz sentido fazeres `head :bad_request` por omissão. :)
But that's not actually verifying that the returned videos are the popular videos, just that they're sorted by popularity:

```python
popular = []
self.assertEqual(popular, sorted(popular, reverse=True, key=lambda v: v.watch_count))
```
what i meant is that this method essentially is a recursive loop until every leaf is reached. but if this is the same in core knp and can not be avoided without the rewrite they are contemplating, then i am ok to merge this.
Good point. I'll add the subnet to the filename tomorrow.
Facebook automatically redirects back immediately if user has already authorized the application. Twitter does not?
Name variables consistently please. There are really to many similar names.
No, this was OK. `remove` will anyway only remove if it exists. You adding should be done only if it does not yet exists.
No, here we want spaces! Aggh.
Why you want to set it?
Also write an alternative, something like "If link above does not work, you can open ... directly and copy-past the following code ..."
Hmm, now I'm confused about what either of these actually do.

The bottles are `-bottle`, not `.bottle`, right? And even if these two lines are adjusted to `-bottle`, that will still break Pathname#version again because `-bottle` will no longer be part of the stem?
For readability, can you put the `settings.placement =` stuff on their own line? doesn't need braces, but would be much more legible.
this is where the lua load path is actually changed
Don't we normally put helper functions at the top of test files?
where are spell_faction_champion_death_grip, spell_toc_heroism and spell_toc_bloodlust
Why did you implement this function? The dispelled unit is always finded with GetTarget(), the aura target is the same of dispelled target...
@Subv 

Better is a matter of opinion. Anyway, I'll "fix" it when I change the hungarian notation.

I do have to ask though if you all know this unwanted code exists (such as hungarian notation or this function I used), why isn't one of you taking the initiative to patch it out? Isn't that what you're supposed to do when you're managing a project?
What's the purpose of "default_val"? It seems like this feature extractor should not return any feature if the word can't be mapped to a float, right?
Strip this constructor. Not needed for the purpose of this example
and also the case where there is no space
Update this comment. Should not refer to graphics.
we'll need to add support for arrays. The serialization should be delegated to the gem. In this case, we should be able to send the params this way:

    "in_replacement_names[0]" => ["one", "two"]
Meh, the rcfile module will depend on both libs in any case, so no worries.
Yes, this is safer. Thanks!
Moving `ngx_http_pagespeed_str_to_string_piece` to header file.

(we don't actually need `ngx_http_pagespeed_string_piece_to_str`; removing it)
Second line has a bug. Its supposed to be checking for button 10, and setting the shortcut to 0.
The idea is that the code in the constructor with Ship m_targetShip and in UpdateTimeStep should be probably the same. They are not, but I would probably rather repair this in some subsequent correction/bugfix. It is working in all cases I now know and I wouldn't like to break it by hastily correction. It will probably yet require some testing - how is the autopilot able to pursue its target ship to rotating frames, etc. 

The difference is:

Constructor<i>
	double dist = std::max(VICINITY_MIN, VICINITY_MUL*MaxEffectRad(target, ship));
	m_targframe = GetNonRotFrame(target);
	m_posoff = dist * m_ship->GetPositionRelTo(m_targframe).Normalized();
	m_posoff += target->GetPosition();</i>

TimeStepUpdate<i>
		m_targframe = m_targetShip->GetFrame();
		m_posoff = m_ship->GetPositionRelTo(m_targframe);
		m_posoff += m_targetShip->GetPosition();;</i>

I'm not sure which one is precisely correct now, they are, however, doing almost the same job.
Oh how french you are ;) hehe
yes, sloppy me.


On Fri, Nov 16, 2012 at 3:19 PM, Skipper Seabold
<notifications@github.com>wrote:

> In statsmodels/graphics/factorplots.py:
>
> >      response : array-like
> > -        The reponse variable. If a `pandas.Series` is given
> > +        The reponse or independent variable. If a `pandas.Series` is given
>
> Dependent?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/statsmodels/statsmodels/pull/569/files#r2151950>.
>
>
Is this form of String concatenation as slow as it is in Java? Would it be better to preallocate a buffer since you know the size?
Perhaps you should update the "with" key to the new Ruby 1.9 syntax?
Note that these are marked as @private which I thought would exclude them from the API docs for now - I do intend them to be public, but wanted to do that as a separate step in case we change our mind about the semantics.

I've added clarifications to the docstrings. Yes, it's across all series, and it excludes invisible series, confirmed in the callbacks.js auto-test. This was a bit tricky since the datasets are prefiltered and get a different numbering scheme, I added the new method datasetIndexFromSetName() (also marked as @private) as a workaround, though I think it may be clearer to refactor the logic to change visibility without renumbering.

The blog entry refers to this coordinate system as DOM coordinates, so I think it's already consistent with that.
Why set the width and height in the style attribute, where elsewhere you use the width/height attributes?
Comment: Nice use of the fat arrow! I completely forgot about it. Now I need to go back and refactor some of my code...
Ah, good point, this is indeed bad form.  I'll make that change now.
Good point.  Yes.
For now, I updated the dox to indicate that end-users shouldn't expect to use this class.  However, when I tried changing the name to ```_PowerspectrumRealizer```, doxygen still produced dox, so I didn't keep this change.
holy smokes.  ok!
I don't want to use the Precondition because it means that I need to send some specific headers then, and that I need to take care of them in the client, which I don't. The client doesn't know what the condition is, no?

I was thinking about having a special header `X-Lock` header that we could use to handle this kind of cases: if it's present we act like this and return a conflict or a PreconditionField.
yes! It won't compare non empty arrays.
nit: The convenstion is to to use '-' as a separator instead of '_'

Also do you really want to replace the full application with the gallery app? Sounds to me that you want to open a the gallery as a new application? (window.parent.WindowManager('../gallery/gallery.html)). And can you add a comment next to this code to remember to replace it once we have intents (good use case for it!)
this busts the 80char limit for PEP8 line length
I guess this line has been duplicated.
no sure but would u need to specify the type --- $cookie_plugin = null -> CookiePlugin $cookie_plugin = null
Agree. I am trying to see if we can just specify "/sink" as the contextPath in this case without /m-js/samples.
I promise i'll work on this as soon as I find a moment :)


On Thu, Dec 13, 2012 at 11:00 AM, peabody124 <notifications@github.com>wrote:

> In ground/openpilotgcs/src/plugins/coreplugin/iconnection.h:
>
> >      struct device
> >      {
> >          QString name;
> >          QString displayName;
> > +        int vendorID;        // Only makes sense for USB devices
>
> Yeah casting a QObject * is probably a more C++ way and more readable. I'm
> just not terribly proficient in C++ trickery :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/PhoenixPilot/PhoenixPilot/pull/79/files#r2411680>.
>
>
I don't think you meant to include these lines, did you?
I'd like to have a general solution to this, but this is fine for now.
Log if an account cannot me removed.
OK, if upstream includes each by itself I'm good with that too, I had thought that loading less files would be preferred. Oh well.
Ja, weil wir sie aktuell nicht brauchen. Bei uns genügt die Integer-ID. Nimm sie bitte erst mal raus, wenn wir sie brauchen können wir sie wieder einfügen, ok? Danke.
Тестов маловато.
А если interrupted, то закрывать не надо?
@ctweney Can you also add

rvm get head; rvm install jruby-1.7.0
Can you explain why you need to access `styleWindow.top`? To get `doc.styleSheets`? What document is `doc`?
please remove this.
We should use single quotes here.
Also of note, I've noticed in my interweb searches, that every example seems to show it as a symbol, not a string, but likely this is a bug in Chef, in that both should be valid.
Très cool!

Please put a note in the narrative documentation that Isotonic regression can be used to make a problem approximately linear using the transform or fit_transforms methods.
or `safe_sparse_dot`
Hi Michael,
You need to change `(path) -> `to `(error) ->`
Consider instead having scraper.Start return a channel, and having Start create the goroutine within it.  That way control of the channel (creation, closing) is all in the same place.  Right now the channel is created in one place and closed in another.
Consider moving implementation of async parse here.

go func() {
...
}()
I really don't think those () are necessary!!
The import is still here, maybe you forgot to `commit` before a `push -f`?
Do we know what the default background of a container is?  Does it default to transparent or something else?
Is there a way to break it up so the target isn't part of the argument list? Perhaps another named parameter "arguments":

    [self.webServiceManager makeRequestWithFormatKey:@"getContentWithDynamicPath" andTarget:self andArguments:@"TestData.json", nil];

This way it would have to be a nil terminated list, which conforms to most other obj-c calls that take a va_list 

We'd then want to change this method's last paremeter to "argumentList" to avoid confusion:
    -(RZWebServiceRequest*) makeRequestWithFormatKey:(NSString*)key andTarget:(id)target andParameters:(NSDictionary*)parameters enqueue:(BOOL)enqueue arguments:(va_list)args;
Hotels?
I would argue the typical use case is to find pubs :D

Kidding, but should we not either say "an example is", or talk more generically about "locations of interest"?
Then how am I supposed to decide if it is safe to merge?
Like the snippet just above, a false return indicates some type of unexpected internal error (resource name was missing or wrong format, basedn not defined, etc) which would be caught during unit/function test. If the resource already exists it will still return true
Not sure what you mean by early exits.   How is this style different?
Instead of unwinding you should be able to use queryPropertyInList(defaultAtom, attrs) (and avoid the if (attrs test))
This will only happen when all super/file structure is already up within the transaction, so you can assume the "transaction is already going".
StringAttr is a typo... ;) I meant IPropertyTree...

Changing it to an array, changes a lot how things are manipulated below, and would need a more careful examination. I thought it could be done later, since we're still guaranteeing that the array is being freed.
I wonder if it might be useful to use a single selector to identify anything that should be removed from the tab order, e.g. ".idi-no-tab-order" or something? This would reduce the number of jQuery calls.
how does this get installed? browserid_form seems to be undefined when I try to run this.
Oh, I see it being used elsewhere. Let's make it configurable via settings in ``conf.py``.
I press element by css "([^"]*)"
Yes, let's open an issue for local cache refactoring or removing.
Би ганцаараа ингэж бичээгүй юм аа. Монголын IT-н бүх компаниуд кодын стандарт дээрээ ингэж бичсэн байдгын. Тиймээс л "буруу" гэж бичээд байгаан. Энийг хараарай. https://github.com/python-mongolia/py-mn/blob/master/peps/pep-0008.rst
use overflow: hidden instead of the height
Hmm, so what about boolean values that are missing?
This approach fails if we need to add new fields to the book. You should use `assoc`.
I pulled this configuration up into the AbstractAndroidMojo since it should probably be used for other aspects of the build.
@videlalvaro ``suggest`` does not install anything. It tells the user that these packages may be used (and you can pass any string to it, not only version constraint).

@TomAdam PHP extensions should be prefixed by ``ext-`` for the package name
I just try to be as general as possible. In medical images you get loads of unpredictable things stored in headers / tags, so these are my string-handling habits shining through. I don't have a problem removing them - just wanted to save you from commenting on every instance!
Alright, I got the button working and removed this extra code.
no need for the surrounding string interpolation
In Components, we don't expose this method publicly.  We only use it internally for the AddMergingData method.  Does it need to be public here?
Begging for an `@example`.
We prefer the original code.  Generally, we only put increments in `for` loops that control the loop itself, and I believe this will accumulate more floating-point precision lose than the original code.
var self = this; should be suffice.
Yeah they were spaces...weird. It's fixed now.
This is one of those things that might need to change in a later rev if we add user-defined tests for their own harness/app for testing their individual components.
This block and the error block are the same, other than the data. Perhaps add a `data` variable and set it based on the conditional, then just have one block that returns the `jsonpTemplate()` result using `params.callback` and `JSON.stringify( data )`.
I've noticed jQuery src code has no `opts` abbreviated like that, but `options`. So, I'm changing here as well...
I don't understand this sentence
shouldn't this also match? the order of the named args is *wrong* but since they are named args they should work no matter which order. Building the RegExp to match it will be trickier, maybe will require a different kind of mechanism then just a plain RegExp - Maybe simplify the current RegExp (remove names) and add a new method call that check if the named args are where it expects it to be.
It's really not though. How would you write a test for that? Try really hard to put a promise in a fourth state? Then what---the only way to find the state of the promise is through `then` which has its own set of testable behavior specs.

I'm all ears if you can think of something of course :)

On Nov 29, 2012, at 2:54, "Luke Smith" <notifications@github.com<mailto:notifications@github.com>> wrote:


In README.md:

>
> -1. In the pending state, a promise
> -    1. must provide a way to arrange for a function to be called with its fulfillment value after it has transitioned to the fulfilled state, or with its reason for being rejected after it has transitioned to the rejected state.
> +1. A promise must be in one of three states: pending, fulfilled, or rejected.


I bulleted it because it's a testable assertion. But np. Will unbullet.

—
Reply to this email directly or view it on GitHub<https://github.com/promises-aplus/promises-spec/pull/49/files#r2261826>.
Let's break this function into multiple lines
excellent, thanks. its definitely an advanced topic how to use something else, just we need to avoid a misconception
Agreed, I will correct that.
because it ends up holding a jQuery object.
I wonder if there's a more intuitive way to explain the equation instead of implying that you should have it memorized.
why stutter?

    private enum string
        zis = "this",
        zat = "that",
        zeOzer = "the other";
s/implementation/implementations/
s/basically //
It seems to me that if you're not going to be using `TestTypes` in more than one place, you might as well just put the types directly in the foreach, since the alias is essentially useless and just takes up extra lines of code if it's only used once.
For now it doesn't work at least because of this:
```D
union U { int a, b; }

void main()
{
	static U u = U.init; // Error: duplicate union initialization for b
}
```
what about eliminating them parens :o)
It's not a big deal, but in case you didn't know, if a template only has a single argument, you can forgoe the parens, which tends to make the code more legible. In this case, that would mean

    v = uniform!"()"(0.0, 1.0);
Do you use the logger or the facesContext?
the same is valid for most methods in this class
Maybe a GetRow here so that we aren't looking at 0th elements of an array below?
So this is definitely too aggressive, but it works well enough for now.  We'll probably want to add a probability to this insert, so that in, say, 50% of the cases it gets added.
Please remove this line. It is not needed (and won't work), because your package's name is set in your packages.json file.
those must be my comments, I write profanities in comments and it was a hackathon, I let it all out. I probably used panel because of the container id of the tab which is #Commentspane.
I think I simulated click indeed because i wasn't able to grab that listener (it's an anonymous function or something).
As for changing the comments code to make it happen, it would be possible indeed. I tried to touch the comments code the least possible.
@lsmith77 unless you want to bump the requirement to 5.4 (and I would hate you for that as I'm stuck on 5.3 at work for the app using FOSRestBundle), yes. You cannot use ``$this`` in a closure on 5.3
You might want to use appendFilters(filterAll) here instead.
Else, you need to add l10n for "All Files"
compro, pero hay que cambiar esto para que no tenga efecto u.u
Ok. I'll update the request again.
Yes, but I thought about it and for every point you mentioned I've found an argument:

* Indentation: Grouping of logical coherent code blocks
* Wrapping space around operators: Avoids "boolean-snakes"
* single space after keyword: Syntax error otherwise :D
Will `widgetData.htmlblock` always have `.content`? Maybe we should check just in case?
Way too many assertions here - if this test is specifically about the case of two test cases by the same user, only assert what you care about in that situation. It may be that what you actually care about here is just that both cases get the correct user, and the efficiency that the user is only queried from the database once - you can use Django's built-in ``assertNumQueries`` for that.
You should probably add a bunch of `/// ditto`s here.
I was thinking it wouldn't break anything since it's a default argument. It should be source compatible, but it's probably not binary compatible.
solrQuery and dismax checking has moved up in the function
I'm worried now about the >0x7f part. The initial bug was more about problems with low ASCII, wheras this will affect Unicode characters that do not need encoding. Ideally, the code will only do the conversion when *required*.
Why all the change in indentation?
Capital I fosCommentThreadId
Yah, exactly.
Got it. I guess it is up to the application to decide if they if/how/when to invalidate tokens. E.g. an iOS app that has a "Sign out" button.
Maybe we should have an introductory sentence explaining that the aforementioned rules do not apply for constructors; That is, constraints may be added to the parameter and return values of overridden constructor as required.
Its better to create this callback within here than to use the same one. That way you can have more than one purchase request at once in theory.
@kk1fff you have to change comments above as well.
We're in a helper.

It's a smell to access the DB via a helper.
Instead do this:

def locale_list(locales)
  locales.collect {|l| [l.name, l.id]}
end

and before calling this helper method, just initialize a global variable in the controller
@locales (in the controller)

then call the helper method like this:

locale_list(@locales)
Update alignment to match change you made in netfields/__init__.py?
Doesn't look like you're using two spaces soft tabs here.
This logic's ability to group the splices is commendably clever, but I think longer term it's better to just put the consolidation logic in the ImapSlice/related helper logic implementation when it gets refactored.  It's pretty simple for the ImapSlice to do a peephole optimization to just see if the thing being inserted is being inserted at the position one more than the most recent splice 'in the can' and do the same thing when the dates are already ordered as they are (required to be for correctness) here.  (Similarly, this logic does not need a second pass; it can flush when it starts a new run.)  Alternatively, migrate it there as a batchMerge operation or something.
Like above, I think it's **correct** that we don't return the socket if an exception is thrown.
min_child_no --- это boolean тут сложно понимать.
Why add $rel to arguments? It's set withing the function.
Caps on `S`pecial
You are right, that stubbing does fix things, and I missed it when I looked at the code.  I am quite satisfied with this.
Make sense. I will change it. (I haven't done the native implementation yet).
Somehow I feel "and this is really painful" is not necessary here. This sentence would be IMHO just fine without it.
Wth happened here? O_o
Tässä tehdään nyt jotain niin monimutkaista, että en voi antaa pisteitä, vaikka testi menevätkin läpi.
It is better not to show href at all if it simply does not have url to be redirected. So please do it with my solution.
Yes, this will fix the problem.
Chybi mi na konci
```php
?>
```
I haven't looked at the actual impls of this SPI, but do they require access to the Class and Method ? or do they only need that to read the Annotation info? If only Annotation info, then maybe we should pass a 'annotation metadata object' down here instead ?
I don't believe this first line is necessary
what does Google say regarding the key?
`$(function() {`

Is sufficient.
I don't see test me variable used anywhere in the method, except for a debug statement.
I'd love to see what happens when this error pops up in an industrial environment. Total chaos... lol