labofsahil/github-event-dataset-2012 huggingface dataset:
Here's a practical example, using ZfcUser:
(`$mapper` is instance of [`ZfcBase\Mapper\AbstractDbMapper`](https://github.com/ZF-Commons/ZfcBase/blob/master/src/ZfcBase/Mapper/AbstractDbMapper.php#L45))
```php
$select = new \Zend\Db\Sql\Select();
$select->from('user');
var_dump($mapper->selectWith($select)->toArray($mode));
```

`var_dump` output when `$mode = HydratingResultSet::ARRAY_RAW`:
```php
array (size=2)
  0 => 
    object(ZfcUser\Entity\User)[500]
      protected 'id' => int 1
      protected 'username' => string 'PS158749' (length=8)
      protected 'email' => string 'adamlundrigan@cdli.ca' (length=21)
      protected 'displayName' => string 'Lundrigan, Adam' (length=15)
      protected 'password' => string '*****' (length=60)
  1 => 
    object(ZfcUser\Entity\User)[505]
      protected 'id' => int 2
      protected 'username' => string 'PS842124' (length=8)
      protected 'email' => string 'foo@bar.com' (length=11)
      protected 'displayName' => string 'McTesterson, Testy' (length=18)
      protected 'password' => string '*****' (length=60)
```

`var_dump` output when `$mode = HydratingResultSet::ARRAY_HYDRATE`:
```php
array (size=2)
  0 => 
    array (size=5)
      'username' => string 'PS158749' (length=8)
      'email' => string 'adamlundrigan@cdli.ca' (length=21)
      'display_name' => string 'Lundrigan, Adam' (length=15)
      'password' => string '*****' (length=60)
      'user_id' => int 1
  1 => 
    array (size=5)
      'username' => string 'PS842124' (length=8)
      'email' => string 'foo@bar.com' (length=11)
      'display_name' => string 'McTesterson, Testy' (length=18)
      'password' => string '*****' (length=60)
      'user_id' => int 2
```

I would expect the behaviour to be opposite.  Currently, RAW reutrns hydrated objects and HYDRATE returns raw rows.
In line with previous comment, change "execute" to "onDispatch".
This import is not necessary.
what does this return
By design it's a callback, I don't see why we would add any custom behavior to it since some people call it and others don't :D
Ah yes I see. I hadn't actually checked to see if ItemStack had overridden an equals method. :p
Unfortunately you can't return anonymous types from separate methods. If I keep it inline... Anyway I'll first-class the type.
Ah, right, missed those additions – fixed.
"redirect" ohne "c"
Should be in the coding standard. :-)
Dart style is to use var here. It's a recommendation, not a requirement.
Is it really debugging if you aren't being all annoying and redundant? ^__^
Changed
I think an *error in the regexp* and *no match* should be differentiated, e.g. by checking for ```!== FALSE``` and ```!== 0``` respectively.
hm, actually i would just call it PHPCR - you will get back a PHPCR Result with rows from which you can, among others, get the nodes. not the nodes themselves.
Yes, +1 for me.
Le 12 déc. 2012 09:58, "Pascal Borreli" <notifications@github.com> a écrit :

> In eZ/Publish/Core/MVC/Symfony/Routing/UrlAliasRouter.php:
>
> > @@ -142,8 +142,6 @@ public function matchRequest( Request $request )
> >          {
> >              throw new ResourceNotFoundException( $e->getMessage(), $e->getCode(), $e );
> >          }
> > -
> > -        throw new ResourceNotFoundException( "Could not match UrlAlias" );
>
> because it's unreachable
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ezsystems/ezp-next/pull/187/files#r2390037>.
>
>
could you move this to pkg_setup() ?
This would limit webasset support to the ``ArticlesGenerator`` and ``PagesGenerator`` generators, so the ``TemplatePagesGenerator`` will not supported for example.
I think it would make sense to send a new signal called ``generator_init`` (or ``jinja_environment_ready``) at the end of ``Generator.__init__`` method so that you can listen to this signal here to register ``generator.env.assets_environment`` for all generators that inherit from ``Generator`` class.
add some comments why you are parsing this error message.
split docstring across multiple lines
It's already in the pom, I think?
Buzz is using the Symfony2 CS
Still doesn't answer my question as to whether that date is accurate.  Also, this file looks to be a page object, not the __init__.py files I'm used to.  Please confirm.
Ahh unfortunately it's the only way i've found so far to update the values in the UserProfile of the person being created, we obviously can't pass it in with the normal user stuff that's happening in the super (that'd just plain not work), if we do it in the model it won't populate the field because the instance isn't able to be accessed correctly there (unless we do it in the else part but that means we can't have a blank IRC name). I'll continue to look for possible solutions with the code but unfortunatly my home internet is down again so i'm writing this from my phone :(
Could this ever raise `AttributeError` if `self.user.api_key` is missing?
Should ESR17 have a higher priority then ESR10?
This feels error-prone; shouldn't the play calls just be able to do this itself?
^^ whitespace.
So that doesn't seem to work. When I run the job and check the mozmill-tests folder in the workspace via the hg command, it only reports a single branch:

$ hg branches
default                      822:dff8ba7429a3
It seemeds cleaner to use Status since it is a part of the JAX-RS standard while the ClientResponse is a part of Jersey (as is, logically, also the actual response being checked). The status is sent by the server to the client "404" is 404 on both ends so I don't see this as a problem.

Do you want me to use com.sun.jersey.api.client.ClientResponse.Status instead of javax.ws.rs.core.Response.Status?
Haha yeah, I contemplated simplifying it... but I thought that might confuse whoever is reading the code more since it would be harder to spot errors. These coordinates came from the change of coordinates formula from rotating the lines by some angle defined by the tilts. The center of rotation is always (6, 2), which is close to the center of the graphie div. The original coordinates for the lines' endpoints I drew up based on Ben Eater's trello diagram.

I made each line 12 units, but if we ever decide that the graphie section is too big to fit on a particular browser, we can change the coordinates easily here by re-plugging in values.
We don't use these tests any more since they're so fragile and don't do that great a job of testing the sorts of things that tend to actually break, so as an FYI, there's no need to include them in the future.
I'm not sure how to force inclusion of the input tests. If its not available, should I return undefined, or can I include it somehow?
I imagine this is different for you guys as well, we should move some of this stuff to a separate npm module so it's transparent, this sort of executable stitching is pretty common
Is this what we want? This will track completions that errored out as well as successes.
Yes and no  it is propertiary and used by our customers in Denmark. Other than that it is internal :) Maybe we should just remove that class and be done with the confusion about it.
Isn't there also a global gitignore that could be used instead of commiting "the full list" to every repository?
are there any reasonable preconditions we should put here?
Yes, but it serves up stale cache data when an error *doesn't* happen. Unless we always invalidate twice -- once before the update and then again afterward. I haven't seen that pattern in an application before, I think I've only seen after.
Yea.. it was super helpful for unit tests though to have that request logging. I'd say we could just strip out the logging if we pull it into it's own library, but as mentioned it is really good to have.

I guess another option is to make it event-driven. `on('beforeRequest', ...)`, `on('requestError'...)`, then the dependencies don't have to follow the library.
Hmm, I think I've covered that below (~ Line 383). grep for `if (expectAccess)`
IMO, it would be easier to read without having to pass the boolean argument. What do you think about having instead ``assertNoForwarder`` and ``assertHasForwarder``
You can use `results.data?.name` to guard against those. =)
Security fix. `req.ips` now behaves according to the specs and only returns an list of IPs if `app.set("trust proxy", true);`
This will break tests for PHP < 5.4, where SQLite3 isn't available.
Why is this needed, when you've already converted the array to a string?
Вот именно. Если у Cell не 100, а допустим 500 ячеек, то мой метод может возвратить hammingDistance > 100( но < 500). Соответственно, в методе mutate я конвертируют это число процент. Просто в нашем случае percent будет всегда равен x.
лучше бы 100 определить как #define
init - это же метод NSObject-а, если я его переопределю к нему уже не будет доступа, если я правильно понимаю, и если кому-то  захочется использовать этот метод без инициализации моими значениями, то уже не будет возможности.
Сп.
@Senior-Student так я ж и говорю, что изначально ещё не понял, зачем снимать копию, потом не совсем понял, зачем нам здесь хэммингово число. Утро такое, да. =)
Надо же, буду знать
Здесь затрагиваются такие принципы объектно-ориентированного программирования (ООП), как инкапсуляция и наследование.

Говоря простым языком, инкапсуляция - это когда мы защищаем какие-либо переменные нашего объекта от внешнего вмешательства, чтобы никто, кроме нас самих, не смог изменить нашу переменную в классе. Это "защита" переменной. В вашем случае, у вас есть переменная DNA, которая по умолчанию private, то есть, к ней нет доступа извне. Зато можно написать свой интерфейс, так называемые сеттеры и геттеры, которые дадут доступ к нашей переменной.

Теперь по поводу наследования. NSMutableArray - наследник NSArray. Отличия одного от другого: NSArray - неизменяемый массив, NSMutableArray - изменяемый массив. Другими словами, NSMutableArray - это NSArray, имеющий методы для добавления, удаления, изменения объектов NSArray.

Вернёмся к вашей имплементации. В геттере возвращаемое значение типа NSMutableArray - изменяемый массив. И это нехорошо, наш массив можно изменить извне, и весь написанный код будет бессмысленным (в данном случае), потому что он написан только для случая, когда в массиве 100 элементов! Понимаете? Нам нужно защитить DNA от губительных изменений, так как в коде программы мы считаем, что у нас не может быть больше или меньше 100 элементов в последовательности ДНК.

А иначе, я могу перед вызовом `NSLog(@"%i", [cell1 hammingDistance:cell2]);` в файле main.m добавить следующую строчку:

`[[cell2 DNA] removeObjectAtIndex:arc4random() % [[cell2 DNA] count]];`

которая удалит случайный элемент в ДНК cell2, и возникнет ошибка при выполнении метода hammingDistance - доступ к несуществующему элементу cell2.DNA[99]. 

Если возвращать в геттере 

`-(NSArray *) DNA`

то у меня не будет доступа к методу removeObjectAtIndex!

Надеюсь, я доступно объяснил...
Yes it's entirely done in JavaScript. I agree it should not display the columns in the first place. I'll look into this.
Cool, good call
For recursion. See line 147 below.
Oops... I missed that in cleanup.
We already lazy instantiate images in `current`. Do we need to instantiate all layers?
Comments have alignment problems in HTML.
Could you please changed this to `=== undefined` or `!== true`?
I think we should rename this to `mainScheduler`, to avoid any associations with queues (a concept not really exposed by `RACScheduler`).
Yes, but the big problem is logical: why do you call "insertid" if there was an update ? there is no sense on doing this.
Yes, does, see above. So one could have two private functions, one for single channel, one for topo and then whatever interface. Have to see, whether / how this will look like with regard to code duplication. But might be a neat way to get around a new object.
> what abound 'kind' ?

+1
that's very long the example and enthought.mayavi should exist for a few more months or maybe years. I am -1 on that
This isn't much good since I don't check it below... ideally it'd return a static placeholder instead.
`@announce` lets you see what aruba is doing, `@gem` setups up and installs the reflow gem
"Let's write a ...", or even better "Let's create a ..."
规则很多
I don't really know what Lukas meant by that...
I'm having trouble following this change. As best I can tell this flag should be set by the framework if it encounters a `@` token. What is the use case that would need this set explicitly?
This is wrong.  It should make a big difference what x is.  That's the whole reason to put a separate argument in the first place.
bizarre de mettre à null les clés primaires alors que l'on demande de les protéger.
лол, я олень.
Te quise hacer un pull a tu branch pero me fallo GitHub
Redefine method
If you want to change the order of a existing list, use list.sort() instead of sorted. It is more efficient.
weird naming again.  i suggest ```add-subs-to-activation-key``` (adding a "-" where one was missing).
Same thing again.
Any way to replace this `i` for something more elegant? I mean something that gives me the index for the array element in each iteration. May be each_index?
$request->query->get(
trailing whitespace :(
Unecessary 'pass'.
we have now avoided having an instance stay in a build state forever i assume? I think this is the right approach but just curious when was the last time we saw build forever?
here's the new text: " This option applies to non-transactional caches only (both clustered and local): if set to true(default value) the cache keeps data consistent in the case of concurrent updates. For clustered caches this comes at the cost of an additional RPC, so if you don't expect your application to write data concurrently, disabling this flag increases performance."
I'm definitely against this change, if startCaches() really takes 12 minutes we should investigate why that happens instead of avoiding it in the test suite.
actually ndb is used, db is not
I think I might file an issue to have this be turned into something less cheesy.
You can use `('css selector', 'li.icon[aria-label="%s"]' % APP_NAME)` here, it's neater
All these variables are local to this function, so you don't need to prepend a `_`.
An API for inserting test data would be so beneficial for this project!
Thanks for using the new documentation node.
а Typehinting Closure в 5.3. есть ведь?
Ah, OK. I rewrited my method and export plugin. Can you check my last 2 commits?
ok.  removed the benchmark.  but in pushing the new code, all comments were erased from the pull request.  that's fine I guess -- but worth noting.
Delete all of formarunner, or just this bit at the top? It's been really useful/enlightening to have this part of the workflow all in one place so I'd hate to see it go without some kind of replacement.
yeah, i guess that's just not been merged, yet?
Top level categories should still be ordered by category_position, this should be the same order *everywhere*..
Hmmmmm, Using category ID as well may just complicate things. XML Import works in the following order:-
* Categories
* Forms and custom form fields
* THEN reports.

During import across deployments, category ids MAY change(almost definitely). Including that in the download may cause mismatches.
That's new to me, but it sounds fair.
If I get it right, it then enforces using the parentheses also when calling 
the function. So if you put parentheses, you can't mistake it with a 
sideeffect-less attribute request.
This message is a bit long, should probably make this a bit more lightweight.
I was trying to illustrate how she put the emphasis on certain words (the ones she thought were important, the only ones she would have said if it were Dragon-Tongue), but yeah, reading it again I just sound like a douche. Would it have been better with just the capitalization or is that still annoying?
ah, so we're not using the md5 hash of the email to reference the user? what if they change nicknames?
переменные с маленькой буквы
`if (type == 'unload' && fn.$ref){`
I f we get the content-lenght we can use this value to initialize the ByteArrayOutputStream object to avoid the expensive resize process
It's added in `#to_hash` (this changed since you first wrote the code). I agree with the intention that the digest should exclude the line number.
Why?  The developer using nokogiri should probably figure out *why* they're passing arrays and format them the way they want.  I really don't like the idea of supporting "laissez-faire" API like this.
Please change function names to lower_with_underscores, here and everywhere.
(And not B nor C have been selected. If one is, then message mentions only the other one.)
I don't like *plošča*. Maybe *ploščica*?
And I still need one more variable `logged` in User document to prevent duplicate subscriptions?
Yeah i meant like this...

#: .\account\templates\user\login.html.py:54
#, python-format
msgid "If you don't have an account <a href=\" %(the_url)s \"> click here to register.</a>"
msgstr "Če nimaš računa <a href=\" %(the_url)s \"> klikni sem za registracijo."
I mean isn't there some command in mongo that fails when there are None types in an array? I saw it a lot during testing but I am not sure what caused it.
Write `:` after TODO string. Start with upper case letter. (Normal sentence.)
And `id` is what?
No spaces around `=`.
yes^^
This replaces the foreach_templates method which was a bit cumbersome and ugly to test. Having a simple array means we can test this in more robust and implicit terms. `no_tasks` tells `Thor` this is not a task method.
Currently, it returns a similar ``VariableDoesNotExist`` exception that misusing the ``slug`` portion with a non-resolving variable name would return.  

But, the ``url`` **override** should not particularly care if it resolves, perhaps changing it to ``self.url.var``? Thoughts?
Heh, Use Tom. My website is http://tomforb.es

Thanks!
I'll give it a whirl when I get home from work
Actually scratch that. You are right.
The Fixtures.java in core seems to depend on the generated thrift classes.
for puts you want to keep around for debugging you _can_ use logger, which rails provides.  But mostly kill teh puts.
There is nothing simple about it, don't pretend there is :)
As an API this is IMO a bit unclear: filtered by what?
We now have support for config objects, we should basically deprecate this old form. The new form is more self documenting.
It's for string pattern matching. `(( ))` is for math. `-eq` is bracket numerical.
we need a keyword argument so the user can, if necessary, determine whether we have a constant included.
for example: 
With full dummy set, constant is implicit
(full set of spline basis functions also has constant implicit)
with nonlinear model, constant might be a parameter.

what we would also need is a ddof correction, for example if the user demeans the data (removes panel fixed effect, within group), not for Rsquared but for tests and pvalues
There was a bug. ```Data.components```, used as defaults when ```--components``` is not specifed, is in Camel-case, but the options for ```--components``` should be entered in Snake-case. 

Therefore, if we ran ```bundle exec thor cldr:export```, ```plurals.xml``` wasn't exported.

So, right now, everything entered is camelized in order to fix this bug. (I should explain this in that pull request)
давай переименуем в upload_from_url или как-то так, а то это сбивает с толку название

а лучше: вытащим аплод в другую сущность. я бы еще base добавил для ровного счета тогда
might need to also add a method that doesn't take any argument otherwise the rest of the site will break
Is there a HTTPS version of it? So that URLs works also on HTTPS-based websites (otherwise you get a mix-content warning).
as I've mentioned above, currently configuration file is useless in my logic some parts of TNArchipelEntity is using this configuration for example "machine_ip" is being used in ArchipelAgent/archipel-core/archipelcore/archipelEntity.py:160

I'm not sure which parts can be removed. can you please do the cleanup or guide me?
Yes.  That's a logical !=.  The actual code is (I believe):
if (BigInteger.ZERO.equals(payloadSize)) ...
i don't think we need the factory. the spring context handles that. we could just use InboundDocQuery.
I see.  That makes sense.  But in that case, we probably shouldn't mention it at all in the docstring.
I'd like dx -> pixel_scale, but it's kind of all over the code in lots of different functions, so it seems like it should get its own issue.

As for wmult, I'm open to alternative names.  We could certainly do that as part of this issue.
Use nil here instead of "" so that your recipe can do things like
```ruby
if node[:nexus][:smart_proxy][:enable]
  install_stuff
end
````
Does this currently just work on localhost? How does this relate to SshMachineLocation.run and SshJschTool?
I couldn't see any non-test code that uses ShellSensorAdapter so not sure whether its use-case is specifically for localhost or not.
I think it's nice to do `checkNotNull(item, "item") so the NPE message says what was null. Otherwise one has to go to the source code line to check what was causing the NPE.
don't sleep.  use:

TestUtils.assertEventually(timeout: 5*SECONDS) { assertEquals(...) }
Use `alias` instead of `super`.
Yes, indeed ... But I'm like a "bit polisher", so ... The fastest is always better :) I'm used to people that don't like my codes over readability, lol
Maybe do "rpm -Uvh" instead of "rpm -ivh" here. That will prevent the user from getting an error if they have already installed the EPEL release package.
I somewhat agree with @schisamo here, and there are a couple of options we have for addressing cross-platfrom directory creation within Omnibus recipes. One cannot (or should not) simply call `FileUtils#mkdir_p` within the build block since doing so would cause a directory to be created at evaluation time of the Omnibus configurations and not at execution time.

We could wrap the `FileUtils#mkdir_p` call in a Omnibus DSL `#block` call, and that would be the shortest path home, but if directory creation is something that happens frequently then we might consider exposing this as a higher-level method in the build block.

For now, I'm content with letting the users (us) get dirty with plain-old Ruby.
This raises an exception for me because ``ProductAlertForm`` requires an additional argument ``product``. The solution is a bit tricky, I think, because we have to create a form for each product in the list. My suggestion would be to use a template tag that creates the product form on the fly. I could be something like this:

``{% get_product_alert_form product as product_alert_form %}`` 

This assumes that the assignment tag has the context passed through to get access to the ``user`` object. Alternatively, this could be passed in as well. 

What do you think? Is there a more sensible solution for this?
Where are the routes configurations?
Consider writing something like:
return Message.find("author = ?1 OR recipient = ?1", this);
It is more elegant I think.
ident is differen than the rest.
I figured a way to remove the extended class from the the client factory, just added another commit where I had to set the client variable to public in order to utilize it here -> https://github.com/arturo-c/USARugby-Stats/blob/guzzle_change_to_master_branch/lib/Source/APSource.php#L22
I'm not sure, but maybe it should be private?
Not sure about it, but shouldn't it be 0 for cancel?
I think the `String(...)` call is redundant. The `+` operator should convert the other values to strings. To be explicit, you should be able to call `items[i].geo_info.centroid[1].toString()`. I don't think we need to worry about null/undefined references, because we should always have two values in the `centroid` field. If not, it's a bug.
Табуляция поехала
As mentioned above, I don't think mock_galaxy sets up any expectations and so I think this test doesn't actually test anything.
В примере вот так:
 [a very long result of toString() method of some object with huge amount of data],
  1,
  10
  )
Если после 10 есть '\n', значит и после 100500 должен быть '\n', разве нет?
yeah, this restarts authentication which animates the modal view controller again, so the animation here was not needed. there would also be a race condition between the two animations, unless i wait for viewdiddisappear
Please use soft tabs (4 spaces) here. Otherwise, looks great!
Great idea! I have just pushed a new commit that adds this and makes use of it in my test. If it's accepted I'll update the other tests to use it as well.
I was planning to make a WallPostManager similar to the ReationManager instead of just doing this on the View:

https://github.com/onepercentclub/bluebottle/blob/master/apps/reactions/managers.py

I think the manager approach is more flexible for future code changes.

A quick peek at the ReactionManager makes me think it can be used for the WallPostManager directly (or with some small changes to make the GFKs field names the same). So maybe we can extract it to a GenericForeignKeyManager class or MixIn. What do you think?
Ok, the ``tree.py`` directly uses ``array2d``. So everything is good with the testing suite ;)
would it have a performance impact to move the `if squared` condition out of the for loops at the cost of a slight code duplication? If we can get a > 10% speedup here I would be in favor  of moving that condition check outside of the loop.
You probably need to check whether coef_ is present in the estimator and not None (for the first call to fit).
Already fixed locally. Please don't clutter the PR with repeated requests. I do a "search and replace" locally. Thanks for the suggestions though.
OK, changed _dmd_ to _compiler_. The message was copied from toobj.c which has similar error detection. AFAIK the TypeInfo classes must always be in object.d or object.di, even if a different runtime is used.
I guess I copied the function declaration from verrorSupplemental() which is also lacking the argument name. I've added it that function declaration too.
I got it, will fix it. thanks.
I'll drop this for now, but I'll say that then it seems we should call setOpacity on both control_ and container_ since if we have a non-transparent background then setting the opacity of control_ won't do much to show what's behind it.
added N_TEXT_ALIGNMENT enum
same comment for object destruction is here
Yep c'est fait sans l'histoire du modulo ;) ça marche !
C'est normal que tu n'importes plus models.* ?
Espace en trop devant termes : La liste des entrées  (c'est une question)
this path is the same that root_path?
I pretty much left this alone because it was out of my scope
As above, use `getIdentifierValues`
@SpiffyJr this particular test fails because of `doctrine_em` being used... This is exactly what I've been talking about today... Please give it a look, I think we're actually providing broken functionality until that major BC break I've suggested is applied.
What do you suggest. Is there a noop query otherwise. I guess you could create some odd TermQuery as well. An empty BooleanQuery seemed reasonable.
long term I expect the index to use will need to be based on the filter condition.  (There could be multiple indexes for a table.)
maybe expandExprText();
Right, ok.
This is related to the argument I am making about caching above ^ I don't think it's advantageous to do a /current/versions query for specific products/versions.
Actually, we shouldn't be dealing with report_list at all in here that's a separate bug @ossreleasefeed is working on.
The choice is between consistency with this `newFrame` method or with window.open, watcher.openWindow, ...
And a consistency with window destructor which is `close` instead of destroy.
What about using `this` in `on`, `once` & all ?
Instead of fighting against prototype it would be simplier for everyone to embrace it instead of working around it.
This `method` function is yet another thing to grok before figuring out how Jetpack code is working.
It is easy to read, really easy. There is no doubt about that, but when you want to understand what's going on, or if you want to debug it and you get a complex stacktrace, it becomes not that easy.

So here, instead of:
`on: method(on)`
we would have:
`on: on`

And here https://github.com/Gozala/addon-sdk/blob/975b90f51a02d8a0b079c36631d47ce3a428e9fd/packages/addon-kit/lib/private-browsing.js#L50
instead of:
`exports.on = on.bind(null, exports);`
we would have:
`exports.on = on.bind(exports);`

Anywhere else, if we want to use these functions directly, we will have to use `call`.
I know it is a con, but pros are: no unecessary functions (no backtrace pollution, no performance issue [I was told that methods aren't inlined in current JS engine]) and one thing jetpack-specific less to know (`method` function).
Please just use the raw string rather than a static variable or a define.
using the id may fail on 32-bits systems as the id is a 64-bits integer. Twitter recommends using ``id_str`` which contains the id as string
You might consider a more specific key here, like `:resque_scheduler_master_lock`.
cleanup the code here. Please remove all tests that aren't going to run.
What about this? If it's unneeded code, delete it. If you're not sure, ask @wrwrwr :-)

Btw, `.insert` probably returns multiple keys for the multi-insert case. I'm not sure what to return in that case. (Probably nothing, but better have a look at the SQL backends.)
Don't actually need that
It definitely shouldn't be using `||`, this was a copy/paste job from sensor code.  I'll fix it.
Add `this._polygonHierarchy = undefined;.`  Again, do you see why?
@mramato did anything really change in this file that I should look at?
swap the conditions to make this faster
default:Titanium.UI.KEYBOARD_APPEARANCE_DEFAULT
Note that the interface being used may not always be en1. Could be loopback (for localhost) or en0 on some systems.
The construction of this is a little bit awkward (the last part is a fragment).  How about "One of these &lt;Titanium.Media&gt; constants: ..." ?
Space around =.
Why is this needed? It wasn't there before.
If `self.exts` is being initialized in the constructor as `None`, is there a reason for it? If not, why not initialize it there as `[]`?
Hey @sergiogonzalez ,

Same as above. This seems like the simplest method possible for creating a vocabulary which seems to be useful for everybody using the API.
The 4th version makes much more sense indeed. Go for it.
I had the bad habit of including 'should' at the start of every description. Remove 'should' and possibly change the description to 'increments a set...'
So, you are proposing to support this:
```D
import std.typecons: destruct;

struct S { ... }

S f() { ... }

void main()
{
	destruct(f());
}
```

Practical use cases?
http://dpaste.dzfl.pl/0cda8d0f

Bug?
Can't you just pass options here like `post("api/issues.json?issue[summary]=#{summary}&issue[lat]=#{lat}&issue[lng]=#{lng}", options)` I believe that should fix it but I haven't tested

Since options is passed in with the url here:
https://github.com/codeforamerica/seeclickfix_rb/blob/master/lib/seeclickfix/request.rb#L7
Default sanity check should be defined in easyblock, not in easyconfig.

The default custom sanity check paths can still be overridden here, if need be (but that's not there case here, stuff below should go in the easyblock).
Might as well do `new ArrayList<Record>(records)`, then mutate in place, to save resizing the array.
We cannot leave it commented. It's either fix or delete.
So I guess the new user-manager requires new unit-tests, right?
Where do you ever touch call_open_time to set it?
I'm puzzled. `JSON.parse(JSON.stringify(foo))` is supposed to be `foo` right? Or are you abusing these functions to perform something else?
Hm, normally you'd use ToProperty here, but if you're in a CM ViewModel, I think this is the best you can do. Also, make sure to specify an IScheduler on Throttle (you probably want RxApp.DeferredScheduler)
Good morning, Kevin.

Thank you for the suggestions.
I went ahead and made the corrections and submitted my changes.
Please, let me know if I need to do anything else.

Thanks again,

-- 
*Henry Demirchian*
(818) 624-7657
henry@demirchian.com

On Tue, Oct 30, 2012 at 5:55 AM, Kevin Yank <notifications@github.com>wrote:

> In repositories.json:
>
> > @@ -1,6 +1,7 @@
> >  {
> >  	"schema_version": "1.2",
> >  	"repositories": [
> > +		"https://github.com/hdemirchian/CSSFormat.git",
>
> Rather than adding your repo at the top of the list, please follow the
> convention and insert it in alphabetical order. This will help keep this
> (frequently modified) file easily maintainable.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/wbond/package_control_channel/pull/717/files#r1978010>.
>
>
Same for the rest of the parameter updates in this file.
sure  

--  
Russell Madsen
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)


On Tuesday, August 28, 2012 at 12:35 PM, Tim Branyen wrote:

> In tasks/server.js:
> > processer.set("paths", ["assets/css/"]); > processer.render(function(err, css) { > + if( err ) > + log.writeln("STYLUS ERROR! \n", err);  
> Can you provide more information here, like what file erred?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/backbone-boilerplate/grunt-bbb/pull/52/files#r1477241).  
>  
>  
>
if we return true - could we return !true for other cases.  It would provide an easier recovery path
I don't quite get what you mean by scheme, do you mean metalink standard by scheme? [ or I might be dream walking and you could mean the actual "scheme" programming language!]
We need something for XML here, ``->fixXmlConfig('whitelisted-doctype', 'doctype_whitelist')``.

The XML config would look like this then:

```xml
<visitors>
    <xml>
        <whitelisted-doctype><![CDATA[<!DOCTYPE...>]></whitelisted-doctype>
        <whitelisted-doctype><![CDATA[<!DOCTYPE...>]]></whitelisted-doctype>
     </xml>
</visitors>
```
Не логичнее ли что-то везде иметь пэрентом этот объект?
as the code is currently written, "single step for each" is not required.
sorry, i still keep asking about this distinction, but if for some reason multiple handlers become attached to `gotoNextProblem`, are they guaranteed to run in some order (i think no, right?) and also, if the execution depends on the terminal handler returning bool, is there a possibility that one of them would hijack the needed return value? 

i guess this feels like a space where events are good, but maybe this one should be totally private or not subscribable?
we should change this to use the config property `sakai.config.enableBranding` instead of relying on a css selector, just in case the HTML changes in the branding widget. This change should be made here and below
Looks like it was fixed in the latest 1.2.0 branch
*Thrown*
MINOR: comment refers to file as "main.cpp", but actually called "02-threading.cpp"
I am not prepared to concede this one.
Technically, I need to fix the persist mode. This way a user can pass in the mode in an case insensitive manner.
Well, now you are thinking too far and getting at the core of the issues I was facing last week and trust me I have at least 6 more scenarios on top of yours where the current or the new code will not work and we decided to live with that and only address the specific scenario described in 2610.
As to your test I don't think your assumptions are valid.
Here is the rule for a single argument:

_Single argument ALWAYS means payload. If payload is set via annotation or expression all conventional mappings are ignored._  

This rule is based on current functionality

What your test shows is that if there is a payload expression with single argument method and the expression does not take anything about this argument into account we should check if this argument matches the headers criteria. But that contradicts the rule i just stated. You know I am not on board with that rule but it is what it is. It also assumes that I know the content of the expression and wether it does or does not map this argument into a payload. So essentially by providing an expression you are overriding the conventional mappings and therefore this map will not and should not be mapped via conventions that are currently in place.
We can fix that during the merge. Is this the only comment you have? Can it be merged if addressed?
Actually i'll fix it diring merge so no need to do anything
maybe this would be clearer if it said "any new messages with the same correlation key as the removed group" instead of "new messages in this group"

since it's talking about something that happens between removing the group and forming a new one, it seems odd to say "this group" here
True, it was a draft that was not properly copied. Will fix
Ok Done
todo later: should contain a real documentation block rather than the property name
The ``|`` symbol could be empahsized using `` `|` ``.
`CFileValidator::$safe` по умолчанию равно `false` начиная с 1.1.12, потому нет необходимости указывать это.
Can this test be strengthened? Test the subject.user_id against the @user.id?
the status is here too, this might make sense, or might not.. im also not sure that the render will happen so that these show up, even if you want them too.
We don't have any copyright requirements for test code AFAIK. I've already checked in code with this. I agree that I should remove my name, though. I'll leave only the "Copyright (c) 2012 Microsoft. All rights reserved." there for now, and check with LCA later to see if we need to have something different. Thanks for pointing it out.
Why do you need to override the method?
Missing line break.
Avoid yoda conditions.
Encapsulate attribution and comparison
Why this line could not work?
Done - needed to check for existence of hint_content - otherwise it breaks:

  1) Error:
test_hint_should_not_be_generated_by_default(HintTest):
NoMethodError: undefined method `html_safe' for nil:NilClass
yep, i will have to make a full restore of the html files as i've done in the css ones for following up correctly the codeguidelines
Ment to avoid any mouseenter event, that could be fired as a consequence of the scrollTop invocation, from changing the active element
Not descriptive enough, and also set as a property rather than a method ('returns' inappropriate). This should be a readonly for module development purposes.

This returns the bundle associated with the locale.
That actually seems like the most correct directory to me.
Needs to be shorter than 23 characters.
The actual absolute import name here would cause the line to exceed 80 columns.

I'd rather keep it as it is than using ungainly parenthesis, trailing backslashes or exceeding the 80 column limit.
Yea, i guess that makes sense. However it's a bit of a different situation with .bbwpignore. Would the user ever really want this file in their archive? Seems odd.
using static here doesn't make any sense, this should be const
This keeps the header in place, so that the items don't disappear. Previously they were getting moved when peeked vs shown, due to us removing the class and the height/width that goes with it. We need to have a class that defines a placeholder.