labofsahil/github-event-dataset-2012 huggingface dataset:
By default it is. But we don't have any class type restrictions for the engine so any class can be used. But I am happy to change it to whatever you suggest.
Zoom (not Permalink)
I didn't understand @sbrunner's comment at first. He suggested I put "true" in "``". I'll fix it right now.
The question now is "should we leave grouping config option set to true by default?".
Remove ```this.```.
Use `@start_date = @start_date.beginning_of_week` and `@start_date.end_of_week`
Again, this union calls for a clear and concise explanation of what it is.
Please change this to...

    import unittest2 as unittest

    ...

    if __name__ == "__main__":
        unittest.main()
Oh, That's right.
What about:

```ruby
def decrypt
  @logger.info "Secret provided. Decrypting with: '#{command}'"
  output = `#{command(@secret)}`
  ...
end

def command(secret='XXXXX')
  "gpg --batch --yes --cipher-algo AES256 --passphrase #{secret} --output #{@decrypted_file.path} #{@encrypted_file.path} 2>&1"
end
```

This removes the scrubed_command method and defaults to the safe operation (not exposing the secret)
To check for line/cell mode, you should use `if cell is None`, as it's possible to get an empty string as a cell in cell mode.  What distinguishe line from cell mode calling is only that `cell == None` when called in line mode, not that cell evaluates to False as a boolean.
No, I went and read the C source -- __name__ will always be defined.

>
I like it. :ok_hand:
Yep, I must have missed that one.  Are there rules for some formatter or are y'all really good at maintaining this?  I always put the braces on the wrong lines.
I'm thinking, doesn't Docurium parse the comments if they are next to the actual enum values?
Yes, typo.
Fixed it
I'm not sure this covers the test right. It seems like the test is checking to see if for a given forum, the threads are sorted by datetime. But if there is only one thread, then it's always sorted.

Seems like we want to create a forum here. Then create a few threads with various datetimes (probably want to specify the datetimes since it's part of the test), then make sure the ThreadsFeed puts them in order correctly.
Why swallow the error? Why not just let it fail. Is having an error an expected thing? I appreciate that we ultimately want to return False but I'm wondering if we should instead just let the error happen.
style, 空格啊
Maybe say here "Default is 1, which also means default is on" or something to that effect?
Tell you what, I'll do this bit myself but if you could read that guide for next time it would be a massive help! :)
Another errant space.
The current way probably makes testing easier, so I'd keep it as is.
At first I named it `send`, but `end` follows `WritableStreamInterface` and actually makes sense too.

I see `end()` as `I've finished preparing the request, it can now be sent`. It ends the preparation of the request, and as a result, sends the request.

Once `WritableStreamInterface` is implemented, `write()` will also trigger sending the headers (if not already done), and in this case `end()` won't start the request.

This is how nodejs's http.ClientRequest works. XMLHttpRequest#send work like this too.

I could have added an additional `send()` or `writeHead()` method, but this would make the interface less easy.
Where are the tests for the changes?
if there is not bin folder in $butch_install_dir , this line copies busybox to be bin in the folder $butch_install_dir
I find the current writing more readable due to the long property names.
This allows you to control the way you compile them instead of relying on the [current behavior of Twig_Function_Method](https://github.com/fabpot/Twig/blob/master/lib/Twig/Function/Method.php#L32) which allows this even if it is not a method. At some point, Twig might want to add some compile-time check that the method exists to guard against typo in the extension code.
@fabpot what do you think about it ?
I'm not sure. It is essentially a nullable boolean (true / false / null are the options).

I will leave it to the community to decide it's boolean nature. :D
Then the first condition would not make any sense if it always evaluates to true, but I haven't looked that deeply.
@fabpot what about moving it to the Templating component ? It would optionally integrate the translation component in it this way, making it easier to use the PHP templating and the translator standalone (some other helpers could then be moved too).
ok :) @kriswallsmith ?
missing 3 ``=``
you might even do that in `remove_tempfile`, so you only pass a relative name to that function.

also don't add `.pid`, the user-specified worker_pidfile should be the filename
DRY じゃないので一つ上のネストに上げてはどうか。
refactor rename to pageControl
what about doing something like

```ruby
def invitation
  @message_body = group_invitation_message_body
  self
end
```

instead of `tap`ing? Seems more obvious that you're using it as a builder due to the explicit `self`.
This loop is a little verbose, you only really use the key to refer to the dict val, so you can simplify it like:

```
for metric_type, metric_suffix in HAProxyMetrics.METRICS.vals():
    name = ".".join(["haproxy", kind.lower(), metric_suffix])
    if metric_type == "counter":
        self.counter(name)
    elif metric_type == "gauge":
        self.gauge(name)
    else:
        logger.error("Unknown metric type: %s" % metric_type)
```
This is only converting within one z "plane", the zstride is not used.  So I passed 0 instead of the more complicated expression that would be the correct zstride if the call needed it.
You said a code god wrote this too me in a vent pm...
Code gods aren't derp.
No need to wrap this in php tags.
I've added this as comments so the the structure remains, and the next one adding one can simple uncomment and change the text. Should I remove it completely?
Should this gem be inside `Gemfile.devtools`? I would expect it to be in the main Gemfile, and the devtools specific deps to be here.

I would expect to be able to run a rake task for devtools that updates this Gemfile.devtools file with a snapshot of the latest file. I thought I saw something like this when reviewing devtools (?).
Good one, I forgot, I usually use runtimeexception to signal code inconsistencies. Yes, lets have our own exception subsystem. We could essentially create a "NdefException extends RuntimeException" and then the NdefEncoderException inherits from that. We probably want some kind of NdefRecordValidationError and NdefMessageValidationError and such later.
FrameworkBootstrapService should fall back to sysprops, not this object.
Injecting the server-wide shared executor service as is done at https://github.com/jbossas/jboss-as/pull/2434/files#L1R108 (particularly https://github.com/jbossas/jboss-as/pull/2434/files#L1R114) gets rid of the need for the JPAService change and the JPASubsystemAdd change.
Yeah, that's fine. I won't hold up the merge for that change.
What is the benefit of providing the entire content as the description? Do users not just interact with the contents of the dialog right away since that's where focus should be?
This is not what I asked for. Please use something like this: `$info = pathinfo($page, PATHINFO_EXTENSION)`.
entry_point -> entryPoint
AFAIK, that won’t work if the app uses `disabled="false"`, but I guess I could live with it.
This should make music work better with the email app, too. Thanks.
This file lives in the System app so constants should be added as property of `StatusBar` to prevent conflict with other files.
* XXX Note: We presume that contact.name array has only one entry.
@vingtetun As i told you in https://github.com/mozilla-b2g/gaia/pull/4956#r1658837  , we are using `100` for any element that are above the content, but if you have any other strong opinion about this, i will be open to change it :D
but empty lines at the end of a file are cool.
@jmcanterafonseca ook, thx.
I like this new option a lot, but I'm not super happy with the name.  I used "episodes" in the `:new_episodes` record mode, but everywhere else in the VCR code base they're called "HTTP Interactions", and I think I'd like to stick with that here.  So maybe `:allow_unused_http_interactions`?

BTW, "Wherher" should be "Whether".
The all-ports field needs to be removed. See my comment in nimbus.clj. In standalone mode, the "meta" field contains the list of ports.
Maybe LOG.debug the exception here?
We don't need these comments since they're described in dsl_spec.rb.
Can we agree on a header format? I've been trying to be consistent with # Programmer: Name <email>. Thoughts on this? Also, we'll have to start adding license info in each file.
Remove the "of".
>Redirect.path
>path

Excuse me?
Now you do not have to declare ivars. It only clutters header. BOOL should be declared in class extension as a property
The following "firstNode" code was our own fix for a bug that the first line number would be wrong if there are hidden lines. It looks like Marijn's "normalNode" fix was addressing the same problem, so I just took out our version.
I went ahead and reverted this to what's in Marijn's master just to avoid needless differences. I don't know if this has a significant impact on performance, but let me know if you think I should switch it back to the smaller number.
Yes, this commit https://github.com/neomonkeus/buildenv/commit/ddb2afe4e47f51edaa0a7c67302cba40ccc3c409 caused it. Think I was replicating your changes before rebase, so will add an additional commit to fix this
What is hidef and where does it come from?
ಠ_ಠ I thought it’s called before, somehow.
How about rename to scheduleUpdateWithPriorityLUA().
I think you can remove this block. It doesn't contain any conditions.
I have changed comment.
yes, afterwards do ldapVhost.unset(user) to free the string, it won't be used anymore
```#include "base.h"```
*** Stopping here for today ***
"there for" -> "therefore"
No validation check anymore for negative values?
For backwards compatibility, if the options hash is blank, it shouldn't be passed to "can_update?" or whatever, because the user's method may not be expecting it. I will fix that, though.
This isn't sufficient: it will catch the problem if, and only if, the *first* use of a custom function is wrong - so this would work:

    scope.function_blah([1])
    scope.function_blah(1)

We need to actually change the function definition code itself, so that the check is performed every time.
This probably doesn't need to live through to the final version, since having just one parser is fine.

The general pattern is excellent, though, and I fully approve of the strategy and design.
note for myself: add var
Technically, you don't need the "implements" here, as AbstractLocation already does so.
On Thursday, July 26, 2012, Marco Pivetta wrote:

> >       */
> >      public function createService(ServiceLocatorInterface
> $serviceLocator)
> >      {
> > -        if (!$serviceLocator instanceof ServiceManager) {
> > -            return $serviceLocator;
> > -        }
> > -
> > -        $controllerLoader =
> $serviceLocator->createScopedServiceManager();
> > -
> > -        $configuration    = $serviceLocator->get('Config');
> > -        if (isset($configuration['di']) && $serviceLocator->has('Di')) {
>
> This one can still live in `ControllerManager`


No, it can't. If its in there, we open the security hole again.


>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zendframework/zf2/pull/1985/files#r1243473
>


-- 
Matthew Weier O'Phinney
matthew@weierophinney.net
http://mwop.net/
Yeah, I assumed the change you suggested, to convert array to parameters
so that 3rd parameter 'id != 1' is 'exclude'.
=) yeah, better be safe than sorry.. I'll restore it
@param boolean $allowNonSepa
no param doc tag for sValue
The Pods project is still calling App.configs and was crashing during vendor build with a No Method Error
If ``file_get_contents`` will return empty response, then it will crash with ``Undefined index 'package'`` etc.
This won't work as long as `Doctrine\Common\DataFixtures\AbstractFixture::$referenceRepository` is private. I'll PR for changing it.
Fixed by  f7c3812
I don't like using VanillaActionController here, why not give it the EntityHealthChangeEvent?
@vesak Nyt maksuaineistokopio ei ole enää tarkka kopio alkuperäisestä, kosa tuo $popvm_nyt generoidaan uusix myös kun $tee == "KIRJOITAKOPIO".
Also what would `snew` do? how is this different from login?
Agreed for constructor, this would need to be done in dependency injection compiler pass.

One alternative to having FieldTypes in storage is requiring field value converters to understand null as empty value.
I've considered this, but in discussion using FieldTypes in storage came up as a better approach.

@docb22 any comments on this part?
encode ascii here is needed for strftime(), not for writing into a file.

On Python 2, this works: fmt is a utf-8 encoded byte string
```
# -*- coding: utf-8 -*-
from __future__ import print_function
import datetime
fmt = "Øl trinken beim Besäufnis in the year %Y"
d = datetime.date(2012, 12, 8)
print(d.strftime(fmt))
```
However, this does not: fmt is unicode now
```
# -*- coding: utf-8 -*-
from __future__ import print_function, unicode_literals
import datetime
fmt = "Øl trinken beim Besäufnis in the year %Y"
d = datetime.date(2012, 12, 8)
print(d.strftime(fmt))
```
Therefore, fmt has to be encoded.
real fix here is to use try-except block with ImportError, but you can leave it like this (will be resolved when merging)
I think the `!` only applies when using `>` and the file exists.

When using `>>` for appending in a file, it isn't necessary.
Ah nice.  I started with your ogre branch but then figured master has some of the changes I wanted to merge in so I rebased.
Until you wrote this I was pretty much `parse_url()` ignorant. :) I'll try to keep it in mind for future URL parsing needs.
... toArray(), arr);
Are you still using `shutil`?
This is hella janky.
No white space :p
move these to the same line as the first 3
Should have them declared as one var.

var something,
      something two;
How about a slightly more descriptive test name here, to better match the rest of the test suite?
This should use `_.defaults`, so that `context` can overwrite `globals`.
If the user selects subject there is no issues at all.  Say the user selects Attribute and the name to be say "UserName", if the user now sets something like UserName=blahblahblah; in the free from JIT field, as long this value is correct the assertion would work.  

-----Original Message-----
From: Ryan Brainard [mailto:reply@reply.github.com] 
Sent: Thursday, May 03, 2012 3:56 PM
To: Mahanthi Gangadhar
Subject: Re: [axiom] JIT Changes (#4)

> @@ -168,7 +171,7 @@ protected Subject buildSubject(String nameIdentifierValue)
>      protected abstract Subject buildSubject();
>  
>      protected AttributeStatement buildAttributeStatement(
> -            List<Attribute> additionalAttributes) throws IllegalStateException {
> +            List<Attribute> addAttributes) throws IllegalStateException {

Also, what happens if someone used the form for attributes, but also set the same thing in free form JIT field? Does it matter if they are using subject or attribute for user id? See comment below about testing.

--- 
Reply to this email directly or view it on GitHub:
https://github.com/ryanbrainard/axiom/pull/4/files#r770368
Please split long lines (this one and others) to get back to 80 columns.
A regular extra `<link rel="stylesheet"` thing would work.
So for now lets use the Workspace SCM setting for the most important workspace and we can update the other ones once the Workspace plugin supports multiple dependencies.
superfluous `apply`?
Please fix indentation and add curly braces throughout this method.
Nice,  we should do that more often in future project.
Will fix as well
I agree with you that this is somewhat inefficient, also creating new elements on every frame is not so good for GC
Not totally sure I understand this. Are you just trying to create two streams - one that does - and one that does not = cvec? why not:
pDis1 := dis(number<>cvec);
pDis2 := dis(number=cvec);
On the other hand - do we **really** need to use math module here.

Initially I used it because it uses BigInteger internally and that would allow to do calculations without overflowing.

We need to test extreme values for periods to see when the use of Whole is needed and see if the use is really warranted.
I am going to bust that out into it's own button on the nav bar.  I don't like that register is hidden behind the login button.

I will most likely have another button labeled "Sign Up" and change the current "Login" to "Sign In"
is this worth a warning? silently not doing anything could be a recipe for frustration
I prefer to make the param defaults `None` and then look up a constant (class-level or module-level) for the actual default. It's a little more code, but it means callers can pass `None` for a parameter to get the default value and the constants make it easier to see what the defaults are.

```python
class Foo(object):
    DEFAULT_GRAPHITE_URL = "http://127.0.0.1:8000"

    def __init__(self, graphite_url=None):
        if graphite_url is None:
            graphite_url = self.DEFAULT_GRAPHITE_URL
```
I removed the `readConfigForModule` function
Discussion on IRC:

mrvisser: sudo is generally a feature support / admin users want, so we'd be hitting 2 birds with one stone.
[4:44pm] nicolaas_: We could just have a link in the admin UI that gives them a session on a tenant
[4:44pm] stuartf: I agree that sudo is a highly desired admin feature, I'm not sure if it's the ideal solution for this particular problem though
[4:45pm] mrvisser: ah, a special login entry-point
[4:45pm] nicolaas_: yeah
[4:45pm] nicolaas_: I don't think they need to be able to log in through the main UI
[4:45pm] mrvisser: right that's what i had going through my head
[4:46pm] mrvisser: that would probably work. we'll want to do a quick pass through the application to verify we're using ctx.tenant().alias v.s. ctx.user().tenant  in an appropriate manner

@mrvisser was planning to make this part of this PR, but would create a follow-up ticket if that proved to be too much work.
The canManage function isn't used to unlock access to content and doesn't throw an error when a user cannot access the piece of content. It is only used when trying to perform a management action onto the content. It currently only throws it when the content doesn't exist, but I think it should also throw a 401 when the user doesn't have access to the content. When the user does have access to the content, I agree that it should continue to return true/false.
This method is able to put multiple tenants into maintenance mode so the name should probably reflect it as well.
Should use the fromUuid function
Shouldn't need this function.
Will do - I used a new define because i did not want to get spammed by the other EPG_TRACE mssages.
@davidtyh missing a star is the major problem for the yesterday's assertion failed. But after I fix this, I found that every time I  emit a l-value, i got null, so I think I need to separate the process of emitting l-value and r-value.
Exception handling (and logging)  where execution of the callback is unsuccessful
No problem, _.map is succinct, will amend.
why setting the kernel here ? The WebApiContext does not need it
Okay, just making sure if it's not already guaranteed at this point of execution.
Очень сложно запутать до полной нечитаемости такой простой метод. Вам это удалось :-)
поскольку массив инициализирован с единицы, последний ген проверен не будет?
Собственно, как и больше 100.
Hi,

CURRENTLY there is an error in gamma effect (Imagick driver) - it is throwing 'Failed to negate image'...

Should drivers share the same descriptions for the exceptions?

As for now it is not true... I can put all effect exceptions in order, but please let me know what the preferred convention is / will be:

My sugestions

negation:
Failed to negate the image

gamma:
Failed to apply gamma correction to the image

grayscale:
Failed to grayscale the image

I'm not a native - please let me know what should be done.

-- 
best regards,
Konrad Korzeniowski



[2012-08-12 08:13] Bulat Shakirzyanov:
>
> In lib/Imagine/Imagick/Effects.php:
>
> > @@ -30,7 +30,7 @@ public function gamma($correction)
> >          try {
> >              $this->imagick->gammaImage($correction, \Imagick::CHANNEL_ALL);
> >          } catch (\ImagickException $e) {
> > -            throw new RuntimeException('Failed to negate image');
> > +            throw new RuntimeException('Failed to apply gamma correction to the image');
>
> please keep exception message consistent across drivers
>
> —
> Reply to this email directly or view it on GitHub <https://github.com/avalanche123/Imagine/pull/147/files#r1358089>.
>
unloadable
a scope cookie
This is the best I could come up with. I'm open to suggestions.
probably don't need this
这个函数是从clojure.core里面抠出来的？是觉得挺有用所以加在这里是吧？
Please also add checks to ensure

 - there are at least two commits
 - all of them are non null
>I think I'm hitting against my limited git knowledge here. I don't even know how I can make it so that a blob can be used in two notes, each one having a different target.

Creating two notes with the same exact message should reuse the same `Blob`. Which could be verified as `git_read_note()` should return the same oid.
A `Note` is indeed built from a `Blob`, but I wouldn't say it **is** a `GitObject`. How about only exposing the oid of the `Blob`?
Good idea, I will add this.
I think I like "old_" something and "new_" something. Maybe "old_conditions" and "new_conditions"? I'd probably just go with "old_event_ids" and "new_event_id", but I think clarifying that one is a current/old state and one is the future/new state is good.
Could you change that to a case statement please?
please rename this to something more meaningful, something like extractNews
What does does it do searching on name here if you have already restricted to a certain patient id?  Shouldn't the string instead be used to limit by Location name or provider name?
spacing after comma
why is it an array? (the result)
Hi Johann, thanks for the tip. I tried it already with GitHub and commandline, but the only way I get it in the repository was to commit the gitignore file, change the local file to the original content from wonder and commit again.

Sorry for that, hope you will give the pull request a chance anyway.

The next time i will give Tower a chance.

Stefan
``So-called 'native' handlers are session handlers are``
Are you sure about this one ? Can't find it anywhere in the coding standard section, and I specifically checked the validation part of the book in the documentation, there is no line between annotations.
This is wrong. It neds to return the validated value. (which can be transformed by the validator btw)
Extraneous javadoc
I usually prefer to not use velocity directives inside #set. You should use this instead:

    #set ($name = $wiki.wikiName)
    #if ($stringtool.isNotBlank("$!firstalias.wikiPrettyName"))
      #set ($name = "${firstalias.wikiPrettyName} (${name})")
    #end
Using smae approach as above you can scrap half the LoC
Тут обрамляющие скобки-то и не нужны.
.content.spot-rows
Good to see some specs -- nice work.
This test is already done in ``task_abstract::processLoop``
Likewise it will complain about a lack of curly braces
Are those double quotes escaped because they're inside the singles?
This won't quit works as the sequences can contain `nil`s/
Because x instanceof ClientCommand is much easier to read, quicker to code and quicker to run than using reflection to get annotations.
Since VisibleOwnerReentrantLock only exists to make getOwner() public, maybe we should merge these classes.
I didn't realize they were part of the same sequence... could you add a comment in both places to say where the rest of the sequence it?
I forgot to remove it at the time, but UNION_CONSISTENT_HASH should have disappeared in 5.0 - there's no way we're going to have both types of consistent hash in a cluster.
this has nothing to do here. ``compileDebug`` is called to write the code needed inside such check
Its times like these that I personally would not follow the PEP8 *guidelines*.
I think this method's docstring should mention the rcParam that it uses (i.e. explicitly mention ```savefig.format```). 

Also, mention that the returning extension does not include the period, and change the ```If invalid, use .png``` to ```If invalid, use "png"```.

Finally, more at @mdboom, is this the behaviour that we actually want? For instance, if a user specifies "raw" to be the default filetype, shouldn't that be what they get, independent of which backend they are using for their GUI.
Please use parentheses here instead of trailing backslash.
Missing space before `1000`
Magic begone! https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/js/grid.js#L470
So why wouldn't this be:

self.marionette.flick(unlock_handle, 0, unlock_handle_y_centre, 0, -100, 800)
Leaving it is fine w/ me, just wondering as to the porpoise.
thanks @probins I have fixed it :-)
I have now redone the pull request with only an `isElement` check. 

New commit message now contains the output of failed tests. I think they are ok. Most of them are "Google doesn't like you using the API from localhost", and a couple of "this feature not working in Safari" (which I assume is true for all webkit browsers).

Please let me know if there is anything else I need to do, and thanks for your time and attention.
noew remove the float_t casts and I merge!
The password rules are simple: any character restriction is a bug (http://dropsafe.crypticide.com/article/9342) .. and any info security expert would agree. However its out of scope for this pull request.. This will get covered by #686
Is it possible to define the element type for the array of parameter ``$datetimeFunctions`` (using ``array<SomeType>``, or ``SomeType[]``)? I found this a couple of more times on lines: 150, 207, 226, 245, 321.
Are you sure ``$validator->isValid(0)`` has the correct type as "Boolean" is not a sub-type of "Boolean"?
removed the comment and instead added an alert informing that custom event listener is not working for Blackberry yet
remove "_-p_ http://..."
It's not synced.
white space is your friend, just sayin':)
Guess I should have read a little more closely. :)

Can you make a JIRA for the outstanding issue? I'm going to push this pull request.
Shouldn't this be:
```js
if (ZeroClipboard._client) return ZeroClipboard._client;
```

That would treat it as a singleton rather than a user trying to create a new `ZeroClipboard.Client` instance and instead getting `undefined` back.
incomplete tags
`-description` is a debug method. Rather I would propose something like: `id value=  [parameters objectForKey:key]; [value respondsToSelector:@selector(stringValue)] ? [value stringValue] : value; `
why `__send__` vs just `send`?
Not good, because month are string - name of month and not a number
In general. You can define a HTML fragment in template. And then use that as a base for populating it dynamically. Sometimes (especially for static things) it is easier than just constructing everything with JavaScript. So, instead of creating DOM in JavaScript, you have a hidden/not-used HTML fragment in the template and then you extract/clone that from the DOM, whenever you need it, and fill it with data.
I already have getImageChoices(user), which gets the available choices. Default choices are just for defining field class.
`input:disabled[type="checkbox"]` maybe?
You probably want to check `upper_limit` not `self.upper_limit` here, no?
Move this to the top, so if == 0, then do this, otherwise go into a loop. Code be much more readable in this way.
I've been trying for few days now to find a way to build such query, but I had no luck. I literally checked all pages on google about this topic but I'm still stuck at the query. Any help would be much appreciated. I assume I have to use something like this:
``` api_models.Post.objects(comments__author=user) ``` - returns me the posts, which have comments written by an user. But this is just one part of the query and I don't know how to combine posts, comments and users together in a query.
You can use [for-empty](https://docs.djangoproject.com/en/dev/ref/templates/builtins/#for-empty) construct instead.
(Based on date of source, not when we fetched.)
Hm, I think I am lost here :S
I did it that way but couldn't do it using `with`, I tried different syntaxes but no one worked.
<li> tag (and some content that is hidden) is shown as you predicted. Will add a surrounding if around.
This can then be extended to support Posta Slovenija sending? So we could calculate exact amount?
Fixed in c9a26ec
I think this note got messed up somehow, but it's funny that you and will pick apart different aspects of my function object :)  As of the latest commit the class is called _do_import_old_items()
We already have a view/template for changing the password. I would suggest we leave that as its own thing; we can put a link to it here if we want.
Won't this make it not a link anymore? Or do we have some kind of special processing?
No need to strict check, we expect an autoloader to be in place after `autoload.php`. It will fail soon after otherwise. Anyway, the two choices are the typ
Could you maybe explain this too me? I am still not completly used to zf2 but making this class an instance of EventManagerAwareInterface should always inject the dependency even if it is an invokable. The only reason i see it would call null if you instantiate this Class directly without going through the sm.
below*
`tree_id` here should be opts.tree_id_attr
I tried to impliment this in HTC Ville (one S) source and am getting an error upon compiling the actaul s2w-switch.c file that this function is undeclared prior .... gahhhhh... if you have advice i would greatly appreciate it
This is the hook 2.5.2 is using to let iPhoto parser add additional data to the pboard that mimics iPhoto. We need to figure out how to do that under the 3.0 architecture, I figure by either:

* Synchronously using XPC to tell the parser what's happening
* Have the parser messenger do the work without involving XPC
the browser doesn't have to "remember" them, it's the per-element attachment and cost of having 1000s of handlers that's the issue here.
I've found that problem in `ServceSettings.php` and fixed it.
It's assumed throughout nginx, too.
I created l1_demo/short_demo.py.  The code here can be integrated into the html documentation at e.g. http://statsmodels.sourceforge.net/stable/discretemod.html.

As for where to physically put the demos (or to just remove them all together), I'll leave that decision entirely up to you.  

Also, how can I give you write privileges for my branch?
``iterative`` instead of ``igls``
or just maxiter=1  (maybe not)

docstring for fit() is missing
Space around `==`. Please use `'` for constant strings (and `"` for user strings, like translatable strings).
Look at the JSONAssert class.  It was a recent library addition.  It will help you here.
CONNECT-interceptor-bean.xml can be centralized to CONNECTCoreLib
Yes, I'll fix!
Perhaps add a note here to see the yaml MOD3 script (or whatever we rename it to) for an example of this feature of YAML in action in this multi-'document' (yet same file) mode?
Fixed in commit 6774519
I think this requires potentially n^2 database reads

is there any way to fetch donation data for each friend while it reads it in the outer loop -- isn't there an include(:donations) or something?
I think this is hard to read, personally, but I guess its ok

Weird that a redirection is happening in a helper...
again, this is an occasional convenience, so put in Entities or even Locations.  confuses the hierarchy to put it here, i think.

esp when we also typically have a hostname sensor and maybe a getHostname method.  it probably means the same thing.
note whirr has some nifty dns reverse resolution stuff (not for now, but could be handy one day).
Looks like this will build examples/portable-cloudfoundry, which depends on sandbox.
But the top-level pom.xml deliberately doesn't build anything in sandbox.
So is this correct?
You are comparing signed and unsigned here, don't do that.
답을 달았는데 달리지 않았네요 ㅠㅠ

다른 풀 리퀘스트에 올리신 커밋이 같이 올라와있습니다. 다른 브랜치로 만드셔서 작업하시는 것도 좋을 것 같습니다. :)
You seem to have duplicated the error from mozilla/source-map#19.
On Wed, 31 Oct 2012, Hannes Magnusson wrote:

> > +		} else if (strcmp(option_value, "false") == 0) {
> > +			servers->default_fire_and_forget = 0;
> > +		} else {
> > +			*error_message = strdup("The value of 'fireAndForget' needs to be either 'true' or 'false'");
> > +			return 3;
> > +		}
> > +		return 0;
> > +	}
> > +
> > +	if (strcasecmp(option_name, "w") == 0) {
> > +		/* Rough check to see whether this is a numeric string or not */
> > +		if (option_value[0] >= '0' && option_value[0] <= '9' || option_value[0] == '-') {
> > +			servers->default_w = atoi(option_value);
> > +			mongo_manager_log(manager, MLOG_PARSE, MLOG_INFO, "- Found option 'w': %d", servers->default_w);
> > +			if (servers->default_w < 1) {
> > +				*error_message = strdup("The value of 'w' needs to be 1 or higher (or a string).");
> 
> Are you sure about that? I don't remember 0 being specifically disallowed

Spec does not say a thing about this, I have asked for clarification. 
This is not something that should stop this PR from being merged though 
(as we can always relax it later).

cheers,
Derick

-- 
{
  website: [ "http://mongodb.org", "http://derickrethans.nl" ],
  twitter: [ "@derickr", "@mongodb" ]
}
This chunk: `map ( Play.current.getFile( _ ) )`, this will result in disk IO for every type of suffix available. I think a better approach is when something is requested without the '.md' extension, we just add it. Make it a requirement that all content files are Markdown format.
Ficar atento ao utilizar strings unicode sem utilizar o modificador de string-unicode (ex: u'pão' )
You have to sleep to let the server go down. I've replaced it with a poll loop that's less arbitrary.
see #361
Can you add the bug number here, so it would be easy to check periodically for if the bug is fixed?

And we definitively do not need to update the whole screen here. This was done as some point for demo purpose and that's also something we need to fix :) We can do that as a followup too.
It may sound stupid, but we're trying to remove all line-ending white spaces. Lonnen and I for example use software that automatically remove them, so if we end up editing a file full of ending white spaces, it can become a pain... 

Also, please make sure you use white spaces instead of tabulations for indentation. Most code editors have options to automatically replace tabs with spaces.
nit: you don't really need the line break here
Autres possibilités : avoir des pages aboutus.fr.html.haml, aboutus.en.html.haml, etc.
Note: We had to wait for a full release of zinc before we could pull this in.  I believe zinc has a new release with your fix, could you update/test this against the new release?

Thanks much for the fix.
Сделано!
Можно предыдущее значение кешировать в локальной переменной.
We need to way for the next -with-transactions BOM to get jbossjta artifact
what is "ubher"?
Please use a space after # .
attr_accessor should autogenerate this method for you.
Ah yeah, it's correct in my project, but I missed it when updating this version.  Lemme check real quick to make sure I didn't miss anything else.

It seems to work for how I'm using it :)
I (partially) addressed this issue by grouping all 8bit cores and 16 bit cores, so now there is only one duplication
Call these `num_*` for better readabality?
+1 I overlooked that.
Here also, please give the shapes passed in the error message. This helps for quick debugging.
true solution?
`FactorAnalyzer` would make more sense, both in the context of existing class names and if you ever choose to extend this to support the MFA (mixture of Factor Analyzers) model.
with the "+" marker, I can see no difference. Does it have any effect?
Should this function be moved to the linear_model subpackage, in the coord_descent module? Maybe with some renaming?
Likewise for paths
MultiTestSuite

Note the e in suite
It would be more understandable when naming this method 'didAppendScreen' instead of 'appendedScreen' (because appended could also be meant as an adjective here)
It seems not to like this.
Folding in just these changes to cg87.c results in:

  core.exception.AssertError@std/format.d(1272): expected = `1+1i`, result = `1+0i`

for 64 bit Linux only.
I added a comment. Function callbacks will always return "undefined" unless they're overridden.
I was reading the contracts for getline/fgetln and was just thinking of text files, forgot that this could be used for binaries as well.
I think we do need because the same function is called when adding more files into a superfile.
It may be cleaner to use "".join(traceback.format_exception(...)) than a StringIO here, I *think* the two are guaranteed to produce the same output.
Remove this and de-dent.
Run check.py on this file and you'll see that it's got left over stuff
Then cd into it and run git status to see *why* it's dirty. 
You might need step into each sub module. E.g.

```
cd vendor
git status
cd src/funfactory
git status
cd ../../src/something-else
git status
```
Good point. In actuality, if CACHE_MIDDLEWARE is False, CACHE_MIDDLEWARE_FILES is ignore. I think. At least that's what I wanted. I might add a comment to go around that potential confusion.
Done in #54 :)
I would go for `texArea.addEventListener('keyup', function() { .. }, false);` form instead.
Same as https://github.com/zendframework/zf2/pull/786/files#r471229
You probably want it to be:

   THUBNAIL_ALIASES = {
      'small': {
         'size': (100, 100),
      },
      'banner': {
         'size': (600, 70),
      },
      'zoomed': {
         'size': (0, 720),
         'quality': 100,
         'detail': True,
         'replace_alpha': '#fff',
         'sharpen': True,
         'bw': True,
         'crop': 'smart',
         'upscale': True,
      },
   }
This constructor is not needed unless is being called from code that has not been updated to use IDFPageFactory
@shacker so you opted for doing the duplication?
Hm. Just realized that `node['current_user']` still works when sudo'ing ohai:

    sudo ohai | grep current_user

Seems it uses `Etc.getlogin`, which doesn't seem to be that robust.
https://github.com/opscode/ohai/blob/master/lib/ohai/plugins/passwd.rb#L31
http://www.ruby-doc.org/stdlib-1.9.3/libdoc/etc/rdoc/Etc.html#method-c-getlogin

Having said that, I just tested this in a `pivotal_workstation` recipe and it displayed my username fine:

    require 'etc'
    log Etc.getlogin

Could we abandon `WS_USER` for `node['current_user']`? And if not, can we write a new ohai plugin to fetch this information?
Hey David, I wrote some tests and made sure an already encoded Subject will not break the code.
needs stdlib because it is using anchors afaik.
Newline at the end of the file, please.
This could be simplified a bit by using a ```case``` statement:
```ruby
case datastore["CLIENT"]
when /^\d{3},/
...
when /^\d{3}-/
...
```
I think DEFAULT_CRED and USERPASS_FILE could be mixed. If USERPASS_FILE is nil, use the default password and username, for example. Would be easier to use I think.
You missed this bug, yo.
changed that...
There is btw no need for __toString.
I'd like to see these as first checking if dir exists, then creating if not, and if an error occurs show it.
This change is not needed and actually goes counter to the style we are using for Java referenced in: https://wiki.appcelerator.org/display/pe/Java+coding+standards

Our internal guide itself does not call it out but the style used in the Oracle standard which we default to (linked from our wiki page) shows a space between args and this is the style that has been adopted and should be used.
`includeAbsolute` is some kind of legacy support, which we still use in drillbit (so we require it for now).
Hey, Adam, where is all this stuff coming from? Did you write the index.html?
Instead of "programy" there should be "programu"
puts "\nYou can view the file here on s3:", link
I have resolved this
why allowing only the 2.0 tag here ? you don't even allow the whole 2.0.x serie, and it means you forbid using it with 2.1 as well.

Btw, this is even more broken as the 2.0 tag of the bundle cannot be installed by composer as the support of composer was added only in the 2.0.1 release
NOTE TO SELF:  resume review at this point
Does anything depend on `@test_status` being set to this value?
Should we have this as a constant somewhere?
И правила другие вроде немного
Actually no, I should've used $cli->notice here as it has been used for notifications to cli everywhere else in the file :) I'll update the PR.
vendor/extensions/engines/db/migrate -> vendor/extensions/events/db/migrate?
The annoying thing with `real` is that it can be practically anything - even `float`. This code needs to work for both cases.
Typo: s/Configuraiton/Configuration/
Is that down-cast required?
s/spi/SPI/
This will never return null.
please avoid names like f... although they're scope is quite short feel free to use native language to describe the output; nextFileInQueueToInstall or fileToInstall, or whatever
Is there a way to capture headers in middleware? I only know how to  in the `Goliath::API` app itself.
please use the short class name in the phpdoc as the class is in the use statements (same in other places
you really need to use the g(path) pattern here.  Putting the paths into the steps is very risky!
Haha, I implemented it at 3 different ways (at least partially, before backing off each one in turn) and this was the simplest and by far the least invasive on the renderer side.
Может таки точка? Проще машинке парсить, чем в каждой строке искать запятые и менять их на точки
i don't know .. i have little experience with listeners
Oh. sorry. This coerces a possible string into a list. Seems like the string case shouldn't exist anymore. But I'm foggy on the deprecation status.
:+1:

But also bear in mind *Fowler, Martin. 1999. Refactoring - Improving the Design of Existing Code. Addison Wesley*, where Fowler says that comments should explain the *why* and not the *what*. Use refactoring to improve the code. Code should tell a story to the reader, not the comments.
It's a tinyMCE issue that seems to be happen occasionally, but doesn't seem to be causing any problems (mainly during init).
just for me: this check is async, probably posting
Fixed using alternate method.
I am not missing any points; I think you are missing mine.

In master if you have payload-expression="'foo'" (i.e. a constant) and a single Map<String, Object> parameter; you get a payload of "foo" and the map in the headers; with your change we now sliently drop the headers.

We either need to __not__ change that behavior or __fail fast__ (with an exception that tells them how to "correct" the situation).
No, as long as the checks are in place. Just making sure there is no NPE.
Yes, we're just about to do a release to the forge.  All of my work so far has been merged back into the original repo that I forked from, though... inkling/puppet-postgres.  Feel free to email me to discuss further, we would love additional submissions!
What's the purpose of adding these lines of code if they're commented out?
active_support adds a cool method here:

```
if movies.blank?
```

To use it, add this to the top of your file:

```
require 'activesupport/all'
```
Does the API return anything human-readable we can expose? Or is the status code the only information we have?
Yes, some glu tests were failing because one descendant of GString (org.codehaus.groovy.runtime.GstringImpl) was deserialized by Jackson using Java reflexion. This led to 'statusInfo' being deserialized in a weird way, something like:

"statusInfo": { "values": ["running", "stopped"], "strings": ["", "!=", ""], "valueCount": 2 }

instead of:

"statusInfo": "running!=stopped"

It took me a while to find the origin of that :)
> Ehm, but we are extending tastypie with support for mongoengine. The idea is to support all fields mongoengine support in documents in tastypie resource. No?

If that was your intention, then there should be a separate EmbeddedIndexedListField and EmbeddedSortedListField, and the sorted version has to do sorting the way mongoengine.fields.SortedListField does, which means adding 'ordering' and 'reverse' to the field attributes. Currently you are not doing any sorting.
Using `Dummy` objects here is not a solution, it is however needed due to some coupling between `Session` and `IngameGui`.

The `message_widget` is used all over the place (not limited to gui code). It's not the first time that I thought about using our message system here. For one, it could remove the dependency on the ingame gui from some parts of the code (`horizons.world`, `horizons.components`), but it might also make it easier to test (might not be that important though).

`display_game_speed` is called by the session whenever the speed changes. I think this is something the ingame gui should handle itself. I'm certainly at risk here of treating messages like the ultimate solution, but it just is so easy to solve it this way. If someone cares about a change in speed, it listens to events and acts accordingly. No need for the session to delegate here.
This is also part of a bigger plan to further separate GUI and game code, which will be useful if we attempt to split the game into multiple processes.

`show_menu/hide_menu` is used by cursor tools, I'm not sure what to do about that.
So if x and y are optional, what about reordering the parameters? After all, we're adding *messages*, so IMO that should be the first thing.

`message_widget.add("DRAG_ROADS_HINT")`

The message is the result of an event at a specific location? Well, let's add that information:

`message_widget.add("MOVE_OUTSIDE_OF_WORLD", x=ship.position.x, y=ship.position.y)`
`message_widget.add_custom("Foo bar baz", x=building.position.x, y=building.position.y)`

I find that much easier than `add(x=None, y=None, string_id="DRAG_ROADS_HINT")`. If the order of parameters feels natural, there is no need to specify the parameter name before each argument.

```
message_widget.add(
    x=building.position.origin.x, y=building.position.origin.y,
    string_id='NEED_MORE_RES', message_dict={'resource' : res_name})
)
```

becomes


```
message_widget.add(
    "NEED_MORE_RES", x=building.position.origin.x, y=building.position.origin.y,
    message_dict={'resource' : res_name})
)
```

You may argue that this doesn't change much. You're right, complex cases stay complex, but easy ones become less bloated.
I think this should be:
```
"dependencies": ["utils"]
```
locale_list(@locales) as said before
Is there any reason why we can't put this in an initializer rather than `application.rb` only I try and avoid altering that if at all possible as it just makes work when doing rails version upgrades.

Also, what was the logic behind the `:headers => :any` clause? I don't think we have any requests that need custom headers do we?
if no exception then fail
ah, yeah, apparently github is not great about that.  It was the .author = blah[0] line.
Android does not have this method.
I've pushed the correction into this pull request.
This returns to `management` is a subsequent commit.
Seems as though those values might not be applicable on Windows, so should be conditionally out or something?

In the same vein, perhaps it is worth considering using a platform independent path, so that we can figure out which one is applicable and not, eg, load your FOSS facts in PE, and vice-versa?  Coexistence, on Unix, is considered a required feature, and separating the paths feels like a good decision in supporting those.
Absolutely. Forgot about that. DONE
I restructured collapsibles. Collapsibles were still unweildly due to their one height nature, which is understandable. So instead, I just converted the talks into a normal content layout which looks and feels less tedious to flip through.
did we want to update the hash?
Seems rather excessive to spit out typo warnings in my opinion :)
As if the page itself was sitting on device somewhere