labofsahil/github-event-dataset-2012 huggingface dataset:
Updated my code, think you might find usefull

page-jsguide.php >> added the_permalink() to sub headers link that weren't working

////////////////////////////////////

function.php >> Updated first image in post to first check for featured image & resolved issue #17

also removed >> set_post_thumbnail_size( 160, 120 ); 
instead I added >> add_image_size( 'bootstrap-thumb', 160, 120 ); // 160 pixels wide by 120 pixels high 

Its simpler to access bootstrap-thumb than ( generic ) thumbnail in catch_that_image() function

All this also solves the following issue in Bug Tracker >> RECOMMENDED: No reference to the_post_thumbnail()

//////////////////////////////

added "No Image" ( small - 160x120px )

//////////////////////////////

New screeshot image ( 300 x 225 ) resolves "Screenshot is wrong size!" in Bug Tracker

//////////////////////////////

header.php >> resolved issue #31 "Typo in header.php" ::: Also attended to favicon not showing by adding "get_template_directory_uri()" to this and other icon url's
yea go for it!

On Fri, Jan 13, 2012 at 8:27 AM, Nicolas Rannou
<reply@reply.github.com>
wrote:
> should we tag and create a "release" branch?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/xtk/X/commit/4586876e9e32d5a6c97fde966d4cacb948066571#commitcomment-864681
Not this change by itself, it's just to decide how many bytes per pixel GL_BGRA is.
Changed with include
s/stoping/stopping/ :)
Well, the entire table is loaded with each request (via `ConfigurationSetting.all`; cf. 9c27526515ae66717a22905596fbdc33cefb13ae / 3d011258c05df2ced5b97104081c62b28fbc5925), so would that actually make a difference?
Looks good. Drop it.
This should be assert(false), I think.
This is wrong. It should get the reflection object, the class from the object and then the human name.
This comment is not needed anymore
Ha, I just wanted to report this problem. Where was it reported?
Ah.. havent noticed the `<%== %>` (new thing for me)
I use Czech locale and there are some national characters in translation and in product name. Maybe thats the issue.
I'll try to debug compiled template.

`<h1><%== 'Úprava zboží' + " &ldquo;#{@product.name}&rdquo;" %></h1>` works properly
so I guess there is problem with i18n... I'll try to look deeper.
A Webby pode dar pau se não tiver?!
So it should :D
.data uses more resources than .attr, because it does stuff like caching.
ok, I'll write a fast test (w/o sockets, tls, and everything) and push commit to the master today then.
You probably don't need to move this - it's only there to guard the members of CZeroconfWIN, so as long as you're not touching the members, you should be fine.
I think it makes the code more robust. If the default config changes in the future, or the user touches it, you get a meaningful error. I think it's bad style to access resources before testing whether they are available. One should not rely on resources outside one's control.

```
$ cat /tmp/test.ini 
[general]
is_empty =
$
```

```
In [110]: config.read('/tmp/test.ini')
Out[110]: ['/tmp/test.ini']

In [111]: config.has_option('general', 'does_not_exist')
Out[111]: False

In [112]: config.has_option('general', 'is_empty')
Out[112]: True

In [113]: 

```
Also done, thanks.
Why did you remove outputting the documentation files?
Looks like m_cooldownTime uses seconds instead of milliseconds as base. Please try 290f8e4
just squashing bugs for a stable and proper eden-pvr :)
Removed since I no longer use it.
:beer: :cocktail:

Woot! well done finding it :)
I already emailed with Jordi Boggiano, who's behind the site. He was gonna look at it tomorrow

Thanks!

On Jan 23, 2012, at 12:55 AM, William DURAND wrote:

> Something seems wrong on packagist since you changed the name.
> /cc @seldaek
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/evert/SabreDAV/commit/1bd4f8c73611080869a1f2bbd2f3c87e8abbaad5#commitcomment-890875
Sous Vide Controller - Work in progress
Maybe a line in readme.md would help.
I knew about the dependency problems with cabal, but did not think of that clean.
Hola,

Creo que te falta actualizar, a mi me funciona.
Con respecto a "¿ Habría que cambiarlo también en el html?", el commit es sobre el html (timetable.html)
I never thought about detecting such code but it seems a good idea.
The diff doesn't look good, it contains changes already applied to trunk and unrelated to this pull request.
спасибо. 
Макс работай :)
I don't get it -- so CSSModel.js is just like Model.js, but it declares a 'static' as well?  Doesn't seem like it needs to inherit from Model at all, and any place that currently uses CSSModel can just use Model instead.
Very nice. I hope it solves the quest Save Krennan Annas which is one of the main quests.
MA-LI-SI-MO

AGUANTE EL BOTON VERDE PARA CONTACTARSE
I don't think these are really necessary...you can do the same thing with `bin(unsigned(x))`. Or maybe `nibs` should be a method of `num2hex` for integers instead.
ahhh k we gonna say  all other testing so far fine in the halls
это изменения к 7 заданию
also some stuff in the validator:

    vendor/src/amo-validator/jetpack/addon-sdk/packages/api-utils/lib/xul-app.js
    31:  Sunbird: "{718e30fb-e89b-41dd-9da7-e25a45638b28}",

    vendor/src/amo-validator/jetpack/addon-sdk/packages/api-utils/tests/test-xul-app.js
    30:  var apps = ["Firefox", "Mozilla", "Sunbird", "SeaMonkey",

    vendor/src/amo-validator/jetpack/addon-sdk/python-lib/cuddlefish/app-extension/bootstrap.js
    76:    Sunbird: '{718e30fb-e89b-41dd-9da7-e25a45638b28}',

    vendor/src/amo-validator/validator/constants.py
    25:    "{718e30fb-e89b-41dd-9da7-e25a45638b28}": "sunbird",
это вроде в ассеты не упаковано, https://github.com/spree/spree/blob/0-70-stable/dash/app/views/admin/overview/index.html.erb#L162
I agree that this doesn't look useful as-is anymore, looks like the intended behavior was to grab all betas ("version like '%b%'"), which could still be done but is not done this way anymore since the breakpad client doesn't send in this info.
@fligtar says a privacy policy is required now
здесь надо использовать assosiation (правда нормальной доки быстро не нашел, постарайся посмотреть сам)
This could be null.
I fixed this ages ago o.O
@JMobius, @the-smith, I have added marked the Extension Charms of Solar Hero Style as available only to Solars (and Moonshadows).
Do you have any suspicion that the Charms we're meant to really make the base style larger, instead of following the pattern established by the two addons from 2E core?
good call, the tests will, but really the paypal tests shouldn't be testing that, just something is called, the only place its used is mkt. tests altered.
Do we need this line for Show page too? I think we can remove this as remove_duplicate_suggestions is only needed in the create action.
something that's not written!
Agree. Would a reenterCurrentState() method satisfy that scenario?
the problem persists on control-attribution.
Honestly, I'm not sure whether it even make sense to include IDEA project since it can be automatically generated when needed.
All the `catch` blocks above are redundant, this one is enough.
Looks like this line is bugged, since we only have one slot, and 3 strings passed for formatting.
no. its different. SWT DateTime has a different toString() function. ...which yields different format which out Date class cannot take.  that's we I insisted to store everything in string form in the database. Anyway we can fix this in the second version.
All older source steps and also the trigger and mail steps do not pass a codebase.
Also, this appears to be exactly the same as the `play` version in the master repository:

https://github.com/mxcl/homebrew/blob/master/Library/Formula/play.rb

Any reason we have it here as well?
EventEmitter2 supports namespaces and listening on a parent namespace to get all sub namespace events.
You don't need multiple emitters but rather only one that you can create in a lazy fashion and return only it.
extract local variable
Why `%??%` instead of `?`?

You could then call it with

```
        self.execute(statement,
                     (id_event, id_src, id_dest, id_src, id_dest, id_dest,
                      id_event, id_src, id_dest, id_src, id_dest,
                      keywords, from_t, to_t, limit))
```

I presume
Don't really need this if this is all we're testing.
There is at least one other file vulnerable to this exploit.  I've made a branch to address it here, and have tested it

https://github.com/yehster/openemr/commit/bc0f07c64bfda43cb0f1cef977a4e322fd7ce047
"wrench work" isn't very descriptive...
`val tree = global.body(sourceFile)` would probably be better, then you might even be able to remove the `TreeCreationMethods` mixin.
An idea for future implementation would be to have this redirect to a list at
http://www.cyclescape.org/groups
@amiroff: Why is logo not updated on the site?
Yes, it needs to be volatile as set and read by different threads.
Regarding the public inner class and getters/setters, it was something I missed from the first draft: you're right, they can be just package-protected.
Why is this here? If nothing else it needs comments to clarify!
please break this line into multiple lines
[5] Sort: Fix Siphon de vie. 

Désoler.. aller trop vite.
It sure is, if you look a couple of lines lower (69), you can see that the "bones_queue_low_js_and_css" is added to the action with a priority of 100. The default is 10. You could up that to 999 or something if you wanted to be EXTRA certain  :)
Since we don't have a proper parser that will warn about this kinds of mistakes I think the +"0" should be re-added.
Now then, I've already had this conversation before and there's conflicting information. If you switch them around phpcs reports that they are the wrong way around.
This works, but if you have a dropdown that flows over the edge of the black bar, it gets clipped.
Not sure why, but didn't seem to like the foo.bar naming convention; changed to foo_bar
este commit no iba ah?...
Now we're getting somewhere :)

"cap deploy:setup" does in fact exist (and creates the shared directory). It doesn't seem to run automatically when you do just "cap deploy" which is ok. But I still don't see how to setup play to log to that directory... did you do that manually?
> Yes, but not without switching back to
> function showElementCommentlist($where, $limit) {
> ;-)

Uh.. right, I didn't notice that.. :)
versions:

ruby 1.8.7 (2010-06-23 patchlevel 299) [x86_64-linux]
rake, version 0.8.7
why ?
i used this rev, and i get this error on this rev, my commit is ok for this rev or ?
i dont know with rev makes this compile error
Yes there is.  However it will cause a LINK() on each child, and this is called sufficiently often for the time to be significant.

(The meta information is calculated whenever a dataset node is created - which includes whenever a new one is created when a tree is transformed.)
Yes, that's what I'm refering to. And I like such nitpicking, because the devil is always in the details. Especially when writing code.
Why don't we do this for all messages?
In db already, thats why delete by type
I don't mean acid or hensei instead no eventai scripts at all, and hensei is eventai.
Maybe you could add it so you can shoot with Left_click ?
Para tu wea de andar weando en las web, esa wea solo es envidia sabi que tu mugre db vale caca, por decirlo poco hasta los chanchitos de durotar dan t11.

loco sin vida, vira a tu mugre de proyecto y deja tranquilo al resto ^^ bye
It just doesn't draw the debug-shapes of all objects. U can still use it for debug purposes, just delete the // ;)
I would rather use `void(response.authorization)` here to be more future proof. As personal choice I would also go with `response` instead of `res` but that's more of a personal choice to avoid abbreviation when it remains short.

One big part missing though, is validation. What append if the authorization is refused ? We need to check the response status before the `void`, I don't think that checking the status of the void itself matters much though, as even if an error occurs here, the authorization will be automatically waived after maximum 30 days (might depend on the bank).

I could then start with the following refactoring:

    def store(payment_source, options = {})
      response = authorize(1, payment_source, :store => options[:billing_id].to_s)
      void(response.authorization) if response.success?
      response
    end

We still need to deal with blank alias, if the billing_id option is missing, we could generate a unique one, what do you think ?

`ActiveMerchant::Utils::generate_unique_id[0...30]` if an option I use.

In case we create an alias, how to return it as well as the response ? We return the alias on successful response otherwise the response object on failure ?

    # Store() will return the billing_id (alias) if everything went fine, otherwise the response object will be returned.
    def store(payment_source, options = {})
      billing_id = (options[:billing_id] || ActiveMerchant::Utils::generate_unique_id[0...30]).to_s
      response = authorize(1, payment_source, :store => billing_id)
      response unless response.success?
      void(response.authorization) 
      billing_id
    end

Let me know how does that feel. ;-)
Hey do you know when are you going to send the report to our customers? They are asking me!  
Thanks, Alba

> Date: Thu, 23 Feb 2012 23:03:52 -0800
> From: reply@reply.github.com
> To: albagaby@hotmail.com
> Subject: Re: [SENG403-Group-5] Application Files (656cb2b)
> 
> Views are rendered inside a layout which has the html and body tags, these aren't needed and break stuff in some browsers.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/paulcoyle/SENG403-Group-5/commit/656cb2b84b112ee1aebae4a2cded95a97b6c9b26#commitcomment-1005914
Simple and clear.
If you add anymore models you are probably going to want to use this again. You could create a partial, or a helper method when the times comes and just pass in the model object.
I'll revert that ASAP. If you file a pull request we can make sure I don't forget it! :-)
@ariestav:
The files included in the demo HTML are not versioned (they always point to the latest version of the included files).
Therefore, I would recommend you to download the resources and include them directly on your own server.

The errors you encountered are probably due to an update of the Bootstrap Image Gallery itself, which doesn't expose a "imagegallery" method on the jQuery object anymore and relies on the latest version 2.0 of the Bootstrap modal plugin.

If required, you can access the old version of the image gallery on the 1.4.0 branch of it's repository:
https://github.com/blueimp/Bootstrap-Image-Gallery/tree/bootstrap-1.4


@YummyJuice:
If possible I would recommend you to update to the latest version of the plugin.
Please note that I usually don't support older versions.
Hey, it turns out there was no conflict at all when I merged master in my branch, lovely! I will continue to work on this tomorrow, gotta leave right now. Test it if you want: select a planet and press 'u' to add units. I'm just drawing them as collision boxes so it's normal that the rendering is crappy.
should be
` if ( gridDialect == null ) {

and spaces should be around all logging statements below as well
Need to add elevate license to license page.
00101'  ≤+120011*
the one you point out didn't have an error, that was just for the sake of consistency :)

this was definitely an error:

ofLog(OF_LOG_NOTICE, "device[" + deviceCount + "] " + p2cstr(pascalName) + " - " + p2cstr(pascalNameInput))

you probably didn't see it cause it's surrounded in a big #ifdef OF_VIDEO_CAPTURE_QUICKTIME
Can someone try latest git? I hope it's fixed css

If you want to override scss variables you have to define them and afterthat import active_scaffold instead of require it
I believe the results from the JSON view are sorted from beginning to end due to the order_by clause in Program.getTimeSlots().
Имхо, раньше было лучше :)
This fix introduces a bug in the NavigationBar so needs more work before it can be considered as a real bugfix
no mays; we've decided --> is implmeented :-)
Getting the profile ID is already implemented :)

   this.refreshInfo();

So what you should do is that, when we init() this API, you should call refreshInfo() directly, then you can get the ID by doing this:

   this.getInfo().id;
If anything, it may have been added early on just in case it was needed? I agree it is not used anywhere - let's remove it pls.
ARTICLE_LOG_COPYEDIT_REVISION maps to the locale key submission.event.copyedit.copyeditRevision ("Copyeditor revisions file updated"), which isn't appropriate for this; I'd suggest adding a new log constant that indicates that copyediting was marked completed on behalf of xxx by yyy so that it's distinguished from the usual "author completes copyediting" process.
I updated FinsLis.cmake. Please test c51f46b
the comment should be updated as well (or removed)
"parsed through" feels a little redundant. Could just be "This will be parsed and added to shape's API ..."
I didn't understand, where I should set `$child->subtype`?
We're not worrying about tensor fields for now I guess?
This second allows all configs to define nodes and ssh_options.  Only the master should be able to setup these options.

Named configs should only be able to setup jobs and services, and they would need to have the config name prepended to their names to prevent overlapping names between configs.
I would argue that this is still incomplete, since the set of command context variables remains undefined.
wow, unorthodox to say the least, add a dot please:

try cell.tell(envelope.message, envelope.sender)
That was what behaviorStackPlaceHolder was doing until it was retired ;-)
Drop this check
def start(actor: ⇒ Actor, name: String)(implicit system: ActorSystem): ActorRef =
  Await.result(CamelExtension(system).activationFutureFor(system.actorOf(Props(actor), name = name))(10 seconds, system.dispatcher), 10 seconds)
This `implicit` does not actually do anything, does it?
I vote for the .build to be there since in 2.10 and forward you'll have to import language.implicitConversions to use that w/o warnings.
who is the sender of this tell?
I think that the order should be `RandomDotOrgSeedGenerator`, `SecureRandomSeedGenerator` and then `DevRandomSeedGenerator`. The `SecureRandomSeedGenerator` is configurable from the outside, but the `DevRandomSeedGenerator` is hardcoded to `/dev/random`. This leaves more possibilities to configure your way around bad `/dev/random` implementations.
just curious: does this make a difference?
I don't think that is possible, because roles comes from `import SunnyWeatherMultiJvmSpec._`, i.e. the configuration object, but perhaps there is a way?
I think that checking the header might be a good idea.  making sure we get the url from the db is good but we don't seem to deal with the resource not found issue
Is there a reason we have changed font?
Good call adding it as the first parameter. It's a consistent piece across all calls and makes sense.
The documentation for this method doesn't describe this enumerator.

You seem to have removed the tab (`\t`) from the indentation of this line (and further lines).  See https://bugs.ruby-lang.org/projects/ruby/wiki/DeveloperHowto#coding-style to format your patch correctly.
Using an Actor for the collection would solve this problem.
Still says Kitsune.
"/blog/blog/ está certo?
+ download::Fini() in the destructor
I'll think about it. The Tranport API uses Addressses, that's why how it  
is now.
> Do you mean "homeAddress"?

It is the correct local address to be used for this remoteRef. I like the  
"homeAddress" proposition :)
typo: base_A.twig
I would write: The purpose of the ``base_A.twig`` base template is to factor out ...
Nifty! Thanks.
Yeah, I was just going for API parity, so if that's all, then we can leave that be. My bad!
This can be done through the layer contents instead.
I Know but the trick is that in 1.6 this test will have all its sens as the deprecated_in_jelix_1.5.php will be removed.
This function should be moved to the top-level (and remain a named function), where you pass in the `completionGroups` array as a argument.
Is the `==
Indentation is weird here... nested lists should line up.
This was OK previously - change back and re-commit please.
превратите это во что-нибудь читаемое, пожалуйста
I was afraid the push with force option would destroy this thread i.e. the commit/diff would no longer be available (not sure if the pull request is still retained), so I thought I'd stay away from it just to be safe.

I'll do the needful and submit right now. thank you so much!
I'm fine with `:none`, I'm also fine with renaming `id` to something else, like `conditions` (or anything better that you can come up with, I suck at naming).
Yeah, so we tried to encapsulate what the conversion was trying to get at. So like `#hash?` for example is the thing that determines if the node is a hash.

Everything could kinda use better names.
I think we should cache the `send(store_attribute)`
This should be a constant. Also put a space after each `,`
Maybe something like

```ruby
case value = send(store_attribute)
when ActiveSupport::HashWithIndifferentAccess
  value
when Hash
  value.with_indifferent_access
else
  HashWithIndifferentAccess.new
end
```

Should the `serialize` declaration use `HashWithIndifferentAccess` too? Looks like this will always serialize as `Hash` then convert to indifferent access on first read...
> that whitespace was removal of 4 white spaces that existed 

Yeah, this is a weird case; normally we don't accept whitespace changes unless you're refactoring the code. There's no code here, though, so that's why I'm ?.


>  I did a git ammend - is that an OK practice (for rails) for something like this?

Yep.
It seems not to be thread-safe, but maybe it's ok to use mutex here in case this code is required to be thread-safe.
Do you mean `==` here?
This is deprecated because it is already removed from `master`.
Who knows, in this all-side-effect universe. If we'd write functions which returned things questions like this wouldn't even come up.
I think I used `:` as a separator for the -skip-packages command. Can you also change that to `;`?
Sure, there's a style sheet, but the style sheets aren't selectable. There's only one "style" for Scaladoc (as nice as theming would be!). 

The short answer is that no one has ever reorganized the user-facing chunks of Scaladoc (i.e. the templates that generate HTML, etc) in hopes of making a theme-able Scaladoc.
I vote for snowman too but let's fix it another time.
Could you make this ``from scipy.fftpack import fft, fftshift`` in all examples?
The existing code is clearer.
could you run the pep8 tool over this to check for whitespace errors according to pep8? Again, there should be spaces after commas.
I was thinking that too, however `Relational` supports it and I preferred to keep it consistent with it.
OK, though it's likely that something at some point will assume that this is guaranteed, even if it's really not.

By the way, allowing to disable it might potentially make some algorithms faster, if the reduction at each step ends up being a waste of time.
@samdark just a reminder: it's still not on http://yiicookbook.org/errata :)
return true is fine...if the above doctrine code fails, it will throw an Exception anyway.
you can cache that if you like but i think it isn't important at this stage of refactoring.
Can you factor this code out into a separate function?
or instead of a verbose flag, a Java interface that the client can implement. If there's a registered listener that implements this interface, then we'd pass them the success or failure, and let the client decide whether to put up a toast or convey this to the user however they see fit.
There you go:  be6005e
I've been using `with nested():` lately and like it.
How is that better?  If the test dies as soon as there's a `<` character, the counter will never go above 1 anyway.

Possibly closer to markupsafe's behavior: introduce a `bless` function, analogous to `Markup()`, which removes `@`s.  Then change the `startswith` to `in`.
Pardon my ignorance, but if it's a typo and no tests failed, does it mean there are missing tests? Or maybe it's a flag for an Ajax mechanism (which I'm unaware of), which then make it difficult to test in the current PR?
Turns out `Symfony\Component\Serializer` does not come with a YAML encoder.
Should the API calls on the `i1` and `i2` not be juxtaposed here i.e. to assert `scenario.i2.overlap(scenario.i1) == scenario.i1.overlap(scenario.i2)` or does that make no difference?
Here too, if Curator can maintain the actual data of the nodes, then it might have that available for us in this call and we can just rely on the actual object instead of deconstructing the zk path.
These queries can be rewritten with OR to be done once per the entire function, but then if user voted on a large number of polls the resulting query would be huge and possibly exceed max packet size. I suppose we can leave them as is for now.
Space before curly bracket
This should be a class_exists($controller_class) check as the new call below can otherwise still fail even if it's false. Although you might want to use a different error message if the class does not exist than if it is false.
Quotes in the selector, please
Is this necessary? And for now it should probably be 1.1.0 until you do the rewrite?
Scuze, repar acum.
If I'm reading the code correctly, when -p is given the file *isn't* written.  Is that correct?  If so, it seems strange to print the name of a file that doesn't exist.
Yes they are for IDE generated files.
presently, cannot submit unless a patient is selected. removing commented code
subtask of RAXAJSS-324
prefer that you don't pass a string as an arg - it's prone to typos, mistakes. 

Could: 
- pass a boolean, defaults to true, rather than using a string as an argument
- or you can also pass something like ```options```, which is more extensible in the future


```
this.sendEncounterData({includeBmiObs : true});

// ...

sendEncounterData(options)
{
  if (options !== null && options.includeBmiObs === true)
  {
    // include BMI obs
  }
}

```
Why is it needed? The default linker is now "cvm", and it has lazy evaluation always turned on.
Add ASSERT_TRUE of return value.
> どうせインストールの途中でhtml以下の権限チェックしてたりするから、そこにinstallディレクトリの権限チェックも追加するとか?

そうか、インストールステップのパーミッション確認手順で install ディレクトリ内すべて書き込み権限あるかチェックすればいいんですね！天才や！
Here you'd use ``physid = m.group(1)``.
``blank=False`` is the default, creates noise.
While we're in here should we potentially do something about this hardcoded timeout?  Or maybe file an issue about it?
I think you can use `helpers.startsWith(sysPath.normalize(path), sysPath.normalize(test))` here.
the timer class is the one who calls this method.  I would be fine with moving this check into the timer - especially since the timer is where we set the decay interval anyway - it belongs better there.  I will push a commit for this.
can you remove it?
$this->getName(), $fieldName
Works fine for everything except GET requests with question marks, bash/zsh interpret them funny. The quotes are merely out of habit.
Woops! Sorry about that. =) Will fix.
@daveschaefer - If you would like to go ahead and take care of it that would be amazing, but if you don't have the time or desire I certainly understand and can take it from here.  Just let me know what works best for you.  Thanks!
args can have an Array of jQuery objects as of 1.8.0 but context should either be a DOM element or jQuery object at this point.
The original didn't put a space before the arguments list though: ".test` `("
+3 bytes gzipped; I'll mostly defer to you on prioritizing size/clarity/performance when they're in conflict.
I'll have to revisit this, but for some reason IIRC, when I testing this against all the 2.0 supported browsers, I had some weird fails in Firefox. I'll take another look. Originally I just wanted to `return true` here, for all of the reasons you gave... I'll look tomorrow
I was going to adopt the `event:subevent` notation so subscriptions could be made more granularly but I think using what is already being done in Nami, like you said, for consistency.
I'd fold this into LocalizingClient and make it more flexible. At some point, we're going to need to test other user agents, so it should allow us to specify which one we're using.

If you don't want to do that, I don't think I'd subclass LocalizingClient just to provide that. Seems much easier to just write a factory method for creating a LocalizingClient with the specified ua.
`url` must be a stable tarball or tag; `head` should be used for trunk.

Are there stable releases? We're trying to avoid head-only formulae these days.
The breakage to `eigen` is my fault, it was specifying a different build type previously but that was lost when I updated the formula. I'll try to remember to push a fix later unless someone else gets to it.
Okay, I'll add some more explanations, remove the return and try to use the provided patch. Bit it'll require some testing that I will do tomorrow or next week.
When I tried using Xcode 4.3 without the CLT basically nothing worked without lots of CFLAG hacking like this. I would think at least the -L and -I blocks will all be needed for compiling any C++ code that uses Unix headers.
@tfiwm: that's because colors.js does monkey patching of the String class which we don't want happening. Also we want control over the actual colors.
Doesn't this just make it equivalent to not overriding `param_docs` at all?
This should really be generalized into one routine for dither, radmon, and fidsel.
I'm -1 on using ShellJS right now. We are already pulling in  fstream-ignore
and rimraf and I think it'd be best to continue using those, rather than
incorporate a different API for accomplishing the same thing... or would it
be less maintainable?
@marcphilipp, maybe it's too early in my time zone but I believe @dharkness was referring to the parameter name. If not I apologize. What you prefer the method name reportMissingExceptionAs or withMissingExceptionMessage?
This should be confirmed. If it's does need to be removed, then there should be a switch to enable/disable it, possibly in config.yml.
navigator.language doesn't return the operating system language when running brackets-shell. Can we change ``brackets.app.language`` to return ``navigator.language`` when ``brackets.inBrowser`` is true?
@jasonsanjose - would you be able to add these additional tests?
I considered being clever and using different strings per OS ("Show in Finder" / "Show in Explorer") but thought I'd try the simplest thing possible first :-)
primeras?
Missing return JSDoc.
What about files with weird names, e.g. with apostrophes in the name? (This same comment probably applies on other places with such XML construction).
Thanks, fixed in e475d7e7abdc9bfe04689f015f5e0338f3af5ce9
why last day of month? not 1st day of month or 1st day of next month?
I've moved the entire code block from the `handleSetFont` function into the `PartialEvaluator_loadFont` function. The reason was to have the `charProcOperatorList` property on the `font.translated` property available right when the font is loaded.

Take a look at this call stack:

`getTextContent -> fontCharsToUnicode -> font.charsToGlyphs(charCodes) -> Font_charToGlyph(charcode)`.

Within the `Font_charToGlyph` function, if the font is a type3 font, we lookup the operation list for each glyph 

```
        case 'Type3':
          var glyphName = this.differences[charcode] || this.encoding[charcode];
          operatorList = this.charProcOperatorList[glyphName];
          fontCharCode = charcode;
          break;
```

If the `charProcOperatorList` is not available on the font, this lookup failed. I tried pass a flag to the `Font_charToGlyph` function in the case we are only interested in the `fontCharCode`, such that the lookup in the `this.charProcOperatorList` is prevented. But as there seems to be some caching, this caused the code to fail later on.

Happy to change this if you give me some pointers how to do it better. Otherwise, can we improve this code in a later PR?
Hack? :)
Can't we derived from a common base class? There's a lot of duplicated code here with the folder handler.
Tests that require sleeping to validate functionality are generally bad.
name, path;
You shouldn't have to block here, but instead chain the futures so you can return one that executes this first and then the batch
I wonder why we need both propertyNames and fields here, is this a title mapping for propertyNames? If so, why not use a key value object structure instead? Can you clarify what the structure of both of these looks like?
Does this mean that if a data.cdb gets reordered due to some edits, all domain IDs shift too?
args lenght check added here
This file is quite long. Worth of splitting into two or more smaller ones.
I don’t know. Currently it’s `../dialer`, I’ve just used a relative path (since this json file is in apps/) instead.

AFAIK there’s no description of this data structure: I’ve kept the `webapps` array from webapi.js, removed all `manifest` members and put the array into a separate JSON file. I agree the tem “origin” is misleading, since it’ll always be a relative path.
Remove this or L119?
And just to be clear, I think `_w_integral`, `_efunc`, and `_inv_efunc` should stay too.
In general blank lines are ignored.  One could get around this by customizing the Inputter, but probably not worth the effort.  Also ignoring blank lines is probably more robust since people might put in blank lines and expect the data file to still parse.
I think PEP8 convention is to put all arguments on the same line.

Do you want to make `NDError` an abstract base class using the `abc` module? See, e.g., https://github.com/astropy/photutils/blob/master/photutils/aperture.py
These should be relative imports
(for 1- and 2-dimensional datasets)
Is there a reason the relative imports are commented out?  That's the form that's probably safer to use...

Also, either here, or in line 8, you want to change the first `convolve_fft` to `convolve` - the tests are giving an error unless I change that.
OK, just leave as is.  If there is a chance that it will help (vs. people shooting themselves in the foot), then leave in the options.
Can you please remove that double-space, it really sucks on Transifex to have these, thanks :).
Same for the second string below...
Yeah, it's fine...
ACK to writing "log file", I like nothing better than Bitcoin-Qt here ... but it is a client logfile, no matter if bitcoin-qt or bitcoind have written it, so what about "Open the clients debug log file from the current data directory. This can take a few seconds for large log files."?
"unsigned int n = -1" is not undefined, but has a well understood behavior.
@ceeram The array_search portion looks good. But the multiplication point still kind of weird to me. For example, if `$size` is `10MB`, you will have `'10MB' * pow(1024, 1 + 1)`. Seems it is working, but is kind of weird to do math with 'MB' in the variable.

Btw, to avoid a issue in the future, what you think in use `strtoupper` in the unit? It will allow '10mb' as well.
You can easily get arrays into GET and therefore fetch them using this method.
Is the code in URLCompressed.git entirely from you? If not, shouldn't you add a reference to the original code/author?
why implementing a teardown which cannot be executed ? All the next lines are dead code
what does this mean? skipDoxygen?
Please don't make functions in loops
"umarkov" kinda makes me sad, but I think I agree with the design decision of not putting the markov generation stuff in the collection.
> I don't want to duplicate the code. Do you have an idea?

You are correct - there is a lot of duplication in those TfsHelper classes. The TFS API has been a bit .... different between versions and we've tried to hide it as much as possible from the rest of the GitTfs code. So yes there's a bit of nastiness in the corners.

Just focus on the TFS 2010 version for now - we'll figure out if the API is the same for TFS11. I think 2008 we'll end up throwing a NotImplemented exception.
This part is fine as well.
even if we must have these ugly parameters as fields, I suggest we do not expose them to users, and instead make the builder and getters return natural objects
Shouldn't you be doing something with the icalproperty, or did you just want to check if it doesn't throw?
if that's the style you'd prefer, no problem. mainly didn't bother with the #ifdef as per the suggestion of @carlosmn in the above comment.

so, i just pushed a new commit..
Just realized this query is too late ...
Shouldn't this be `writeResolvableList(out,__conflicts__);`
I'm not sure about this... the idea is for it to be a stable dataset *except* for time, so I guess it's ok.
Yes thats what I'd like to see improved...
As I said before, this is just one step towards the holy grail.
Ah, right.

I'll fix this as well later on tonight, thanks for pointing it out.
$jsonp (renamed as callback as @vicb said) should default to null IMO. Same in ::create
It's certainly a mistake.. I cannot see the reason of the second assertion. I think you should remove it.
Should be `/Tests` to work on Windows too.
Good catch! Images removed.

Why don't you want to do a full review?
I don't understand what you mean when you say "When we break parens onto new lines, we do it for parens in the method."
I've been thinking about this, and I'm starting to believe that we should remove `macro_arguments`.  How about:

    <macro($num) { """
        {{ $num }} references the first argument passed to the macro; false if not specified.
        {{ $filesRemaining }} references a variable from the developer.
        {{ brandName }} references an entity.
        {{ plural() }} calls the plural macro.
    """ }>

The new grammar says `$foo` is a variable reference which can only resolve to a primitive value type.  `$foo..bar` and `$foo.['bar']` (both attribute expressions) are thus syntax errors, and we can detect them when parsing.

I'm not too scared of collisions.  Let's assume the localizer happens to use a name for the macro argument `$num`.  If the developer adds a `num` variable to the context, `$num` inside of the macro still references the first argument, not the developer's variable.  If the localizer wishes to use this variable in the said macro, she needs to change the macro anyways and can then fix the collision.  I think this will be a rare edge-case, too.
adobe的字体确实漂亮些。不过可能是我本地没有它的字体的原因，所以如果加上这个选项就会报一堆错。
另外，个人觉得很多人都没有adobe的字体，所以还是推荐将此选项放到用户说明文档中说明，来推荐有adobe的字体的人使用adobe字体，或在sample-master这些样例中使用即可，不需要在cls里包含。
关于字体版权问题，我不知道是不是你考虑得太过于谨慎，因为(我个人觉得)ctex的这六款字体应该是处理好了相应的版权问题才放到其宏包里的，所以如果有版权的问题也应该是和ctex的纠纷，至少和咱们没有关系。
Apart from the hello and init primitives, the names should contain a verb
so that somebody reading the recipe can follow the steps.  Imagine a cookery
where a recipe step is "Cake" when you want to know when to beat the eggs
and add the sugar.

SPECTRUM is generic too.  The Description doesn't expand on this 
either.  Something like '"_FORM_SPECTRUM_FROM_INTERFEROGRAM_"
would be better.
describe the options for processing type -- sequential or semiparallel and what it means,
It's worth noting that this only applies for OSX users.
Umm, just making sure you're reviewing carefully? :)

Thanks for catching that, fixed.
they're not required, sometimes my muscle memory from haxe/js kicks in.
Frankly I do not think it's worth the hassle. Let's just try to avoid this situation in the future.
Perhaps also link to http://emberjs.com/guides/outlets/?
familiarity with Route's super class is expected.
Should a break; be added?
> you should get exactly one mozbrowseropenwindow event, for the first one. The second open call is entirely transparent to the embedder, or at least it should be.

@jlebar That happened, and worked well. Except in the use case in background service where a 

      window.open("foo.html", "background", "background");

Will be "simulated" when the phone boots up, and the app frame cannot get this existing "popup" by calling this `window.open` itself.

@daleharvey That also means this use case doesn't apply to Gaia browser :P You should remove this part in this pull request.
My initial idea was not waiting for it, but it keeps busy the phone and result on a beautiful white screen while loading the "Loading" overlay. If we can avoid the white screen, getting the contacts on first place would be the best option
Regarding this two commented lines. This should be fixed ASAP. Now if I hide the header (line 295) the unordered list moves up and the first item is behind the main header block ¿?

Any ideas how to solve this?
Tell that to the UI folks :)
Why? Image should be 100% 100% in order to fill the space with the image
Makes sense. I'll add that. Thanks!
Is this commented out for performance reasons and we'll put it back if linear-gradient gets faster?  If so, linear-gradient no longer needs to be prefixed (https://developer.mozilla.org/en-US/docs/CSS/linear-gradient).  If not, please remove the commented out bit.
Not really sure about the performance (depends on the implementation), but I would use getElementById instead querySelector
Maybe add a comment here (or file a bug) about the fact that this could be more efficient when the new search string has the old one as a substring.  But I wouldn't block landing on this.  Get the feature in, and then fix the performance bugs later.
nit: guidelines are } else { on the same line
I'm not sure you need to credit me for this.  Although if it were more of a hack, it's not a bad way to make have to not say anything bad about it :)
trailing semi-colon (probably a merge issue here)
https://github.com/mozilla-b2g/gaia/blob/master/apps/keyboard/js/imes/jszhuyin/jszhuyin.js#L1360
A cleaner way to write this is:

(->> my-assignment
        (filter #(->> % key (contains? task-ids-set) not))
        vals
        set)
Wouldn't it be better just add a link to [our StackSverflow.com page](http://stackoverflow.com/questions/tagged/netty?sort=faq)?
https://github.com/osmandapp/Osmand/blob/master/OsmAnd/src/net/osmand/plus/activities/MapActivityActions.java#L1155
var here :)
BitConverter is close but we'll still have to do a bunch of moving things round so it really doesn't help much.
Actually, collapse both of these modules into a new one called "XHRHeaders". Not enough meat on these bones to warrant them being separate.
@brunomachado, is this selector affecting any element? I did a small search and couldn't find any HTML where `.help-central-header h2 a` would target.
``Select`` is a case class, so it can be used for pattern matching, and remove one level of matches.

```scala
case select: Select => 
  select.qualifier match {
    case lit: Literal =>
```
becomes
```scala
case Select(lit: Literal, _) =>
```
# before
    [リソースモデルソース](http://rundeck.org/docs/manual/plugins.html#resource-model-sources)
    
    # after
    [リソースモデルソース](http://rundeck.org/docs/manual/plugins.html#リソースモデルソース)

ページ内リンクはこれでうまく行くか後で再確認が必要かも
one-liner please
So presumably this method is only going to be used by ```skewJoinWithSmaller```. Instead of passing countFields and dummyFields as params, you could define them as constants and call them as such instead of passing them in the method call.

Not a big deal, but it would just make the method call slightly shorter.
this._subscribers[dest] is the subscriber's event queue to transmit. It is initialized with an empty queue.
I don't understand why you do `client = None` and then immediately afterwards do `client = self.pool.get()`. Why have the `client = None` in the first place?
But now, i have a HUDGE quantity of mesh created, the render thread can't follow !
They are changes in the queue engine side ?
Mmmh.

Je pense qu'il vaut mieux ne rien mettre du tout en fait, et installer node sur nos machines respectives.
just `sa.join` will work here
probably `getUsersContacts`
I also have a limited knowledge of AMD, but I don't believe your implementation is correct for libraries that provide / rely on global constants. For example, Underscore and jQuery have a AMD shim that defines their name, because many libraries absolutely rely on that EXACT name as the name of the library, and the same would be true of less. For this reason, I believe the name should be defined.
Why did you delete this submodule?
but they should simply be registered first, so that their support method is called first. I don't think handlign them separately is needed
Sorry, I didn't get it. As far as I can tell you the binding logic is inside compile.coffee and it doesn't use insertAfter. So, why would it fail?
http://api.rubyonrails.org/classes/ActiveRecord/Integration.html#method-i-to_param
Valid comment, didn't took that into account. I chose `CommitList` because it's a list of singular commits, not a list of plural commits. But will revert that :)
New arguments should be added at the end to preserve the previous positional API.
Yes, both are working now. Neither were working until I changed them.
I only fixed a typo in a comment so this isn't outdated like github thinks.

That feature sounds cool but I hope that acceptance of this plugin doesn't have to wait for it.
why not LogStash::Event#include?(key) ?
Yeah main problem here is that module initializes itself asynchronously but provides synchronous API to it's consumers. This is quite misleading design & user also confusing for module users as there is no need to initialize anything, as by the time they'll get a chance to use this module it's already initialized. I think only reasonable solution here would be splitting this module into several pieces:

1. `l10n/bootstrap` that can is used from bootstrap as follows:

```js

// Creates `@l10n/hash` pseudo module for l10n/core
function setupLocales(hash) {
  loader.modules['@l10n/hash'] = { exports: Object.freeze(hash) }
}

require("api-utils/l10n/bootstrap").
  read().
  then(setupLocales, reportLocalesError).
  then(run)
```
Where `run` is current [onLocalizationReady](https://github.com/ochameau/addon-sdk/blob/a59e5e0dce1faecf76acba3cc1e5069b4084b228/packages/api-utils/lib/addon/runner.js#L94)

2. Make `l10n/core` consume a `globalHash` synchronously by importing it from pseudo module `@l10n/hash`.
This check occurs in several places throughout the code, a user.hasPassword function would be a useful abstraction.
Missing a semicolon here and below.

(I'm OK with semicolonless JS but there are some lines with them above, yet these last two don't have any. Please be consistent :-))
you should update this pull if you accidentally removed something
callback on err like above
This is already fixed in the new TB
Totally happy to see more tracking of things like this at debug level, where they don't bother anyone in a normal run.
Sad but true. Albeit I don't think you can call it "spelling". :P
I'd like to do this, but I really can't. The code is evaluated in Puppet::DSL::Context instance which expects a Proc, not a string, because it is also instantiated when creating a new node, definition or hostclass.
@daniel-pittman This link takes me to `ReplaceFile`. I think you want http://msdn.microsoft.com/en-us/library/aa365240(v=vs.85).aspx
Apologies for the mixed commit, that was clumsy of me.

Those are the only changes. We just were not handling the should_not_receive earlier and thus the failure.
Do we need the `return` here?
It doesn't actually execute immediately, since the handler that starts the kernel is distinct from the handler that manages shell messages, so if something happens on the client side and websockets aren't connected or if an execute request message isn't sent down the shell socket, the heartbeat logic seems like it wouldn't kill the kernel. Since it's always set to True on every execute request, changing the init value to False just solves the corner case of something happening between the time that the kernel is created and the time the server receives an execute request.
Yep, fixed and pushed. Thanks.
Warum der Kommentar?
What about using protocol-less url '//search.twitter.com/' so it defaults to the current page's protocol
This is not doing what you think it's doing, and causes a test failure.