labofsahil/github-event-dataset-2012 huggingface dataset:
This is doing a strict referer check if there is no Origin header. That's going to cause lots of incorrect failures for the case where the browser is configured not to send a Referer header, or where the network strips the header.  According to Barth et al. [1], not sending the Referer header is very rare for same-domain HTTPS (which is why we had it like that before), but not that rare for HTTP - probably because the network cannot strip the header for HTTPS, but can for HTTP. This could be anywhere between 0.5% - 7%.

[1] http://seclab.stanford.edu/websec/csrf/csrf.pdf
The second one is better. But be carreful to CS
For as many of these tests as possible, you should use the other version of loadVtt which takes an expected number of cues, so that we can assert that we get what's expected.
Hey Rick. I understand your concern. I think this is an issue with converting tests meant for validation to unit tests. They are kind of different beasts.

I wrote my tests to check the validator. These tests were supposed to demonstrate fails. Now that the parser doesn't do validation, I figured that these tests would pass simple by not blowing up the parser. The fact that they blow up the parser out of the box already exposes flaws in the parser, and thus these tests have done their duty.

You are right that I could add tests for other things, but I feel like then I'm just adding padding to some tests that are already doing their duty.

I think also, since (as far as I know) we are supposed to parse things to the best of our abilities, should this not pass?
Maybe I'm just confused as to what should happen if the syntax rules are not followed.

If I'm going about this the totally wrong way though; please let me know! Discussion is good!
Also, I've never seen `?=` used at the beginning. I guess that works because this is using `g`?
These four nested for-loops are a verbose way of expressing a tensor product (sometimes referred to as an outer product of two matrices).  Eigen doesn't support tensor products, so we weren't able to remove all the for-loops, but we did replace the two inner-most ones with a matrix multiplication.
For `if` statements can you include brackets please? 
```
if (blahblah) {
  break;
}
```
(you'd see "null", helping you guess what might have caused the problem)
I know this isn't directly related to your change but can you please comment what the values of {{type}} can be here?
I'm going for getTokens, but don't feel strongly either.
You fell into the syntactic trap! This doesn't work at all. What this does is catch ValueError and call the resulting exception "TypeError". You need to surround these with parentheses:

```
    except (ValueError, TypeError):
```

Definitely worth testing to make sure your code fix is correct.
Remove previous line confirm=options.confirm

    unless options.confirm

confirm isn't used anywhere else.  Optionally, this is a good opportunity to generically implement confirm in the base command as a generic method

    def confirm(message)
      unless options.confirm
        results { warn message }
      end
    end

Also on command would be a confirm_option helper

    def self.confirm_option(message)
       option ['--confirm'], message
    end
nice thanks for adding this comment.
Yeah, all of those things would be good.  By item, I'm going to use path.

I was thinking that other exceptions should be propagated upward, but now I don't think so anymore.  I'll change to catch StandardError.
^get an unnested

Otherwise, LGTM.
I think I got that with line 6. I was trying to fit in with the style of the preceding code.
you want a for loop!
typo? "bye" -> "by"
Yes, except `--blog` is optional (defaults to the main blog).

Also, what happens if the user already has a role on the given blog?

Maybe rename `add_to_blog` to `set_role` and `remove_from_blog` to `delete_role`.
Rather than throwing exceptions from AfterClass (which confuses some runners), please create a static inner class that has the """@DataPoint"""s and tests on it, and run that with an instance of JUnitCore.  (Let me know if you need a pointer to an example).  Thanks.
The first two test from #528 are now good for nothing.

Other tests in real scenario should be added like this:
+ all listeners are added in main thread;
+ notifier fires events to those listeners via several threads;
+ after finished, all listeners should count correct number of events fired from notifier.

What you think?
Was this not important?
I think this method could go in `mulberry.Device`.
I'm pretty sure I gave you another text to replace this one.
I think you want ```\s*``` here, since there could be any amount of whitespace before/after the "="
Good suggestion. I like it.

-----Original Message-----
From: Glenn Ruehle [mailto:reply@reply.github.com] 
Sent: Friday, June 08, 2012 5:33 PM
To: Ty Voliter
Subject: Re: [brackets] Offset to line number optimization (#1019)

> +    function getLines(text) {
> +        return text.split("\n");
> +    }
> +
> +    /**
> +     * Returns a line number corresponding to an offset in some text. This version
> +     * is optimized for repeatidly calling the function on the same text in a loop.
> +     * Use getLines() to divide the text into lines onces, then repeatidly call
> +     * this function to compute a line number from the offset.
> +     *
> +     * @param {Array.<string>} lines - an array of strings corresponding to the
> +     *      lines of text in a string.
> +     * @param {number} offset
> +     * @return {number} line number
> +     */
> +    function offsetToLineNumForLoops(lines, offset) {

Instead of having two functions, how about allowing the first parameter to be a string or an array. If it is an array, do the optimized version. If it is a string, do the slower one.

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/1019/files#r955020
This should specify where menu items are placed in the case where after or before is specified, and relativeID is not found (e.g. "last").
It's a little funny that query's two fields are treated inconsistently: queryStr  is initialized to null but later usually overwritten with the real value, while attrName isn't initialize at all, but is just written later.
Does this need to be broken out as a separate helper function?  If it's only ever called from `Menu.removeMenuItem()`, could you just inline this code in there?
I added it in a different place. We don't even have to wait until close() is called. As soon as we pass key events to hintList, we can always make sure that this flag is reset to false.
80 chars per line or less, please.
i usually put a blank space in between methods, so it's easier to see where one ends and the next begins.
Missing TODO description.
there's no need for begin in this case
another tiny space just before the "VIDEO"
This probably don't need to be here.
plz put a space after the slashes.
What was your intent with `uiCuePlugin`? To add more non-editor API? If not, I'd rename it to `editorController` or something. Using `commands` and `cues` makes it a bit misleading.
700? Const it!
same for truthy as above
we can require data to be an arraybuffer or string and not do this check
Also it's not an RDS name, it's an RDS SG name.  The ID/class should be self-descriptive if possible.
if we didn't .dup above, the scope.slice! massacres all the hash keys that are already stored in the hash, which is why sven and I saw duplicate empty hash keys.

Moral of the story: You shouldn't write imperative code like that, hmmkay? ;)
If it's always set then I guess span2 is correct.
Please remove this comment if there is no longer description :)
if we ever add a button to the feature editor, this would not work, so use a for loop instead everywhere.
ah, but we can't do that here because we only see one RR at a time
Rewrite ALL the tests. :-)

I first want to make sure we have everything working, before changing something to the current set of tests.
What a nice construction! I changed it that way. Thanks, Petr!
It is present in upstream since subscription-manager-0.96.6-1, while in RHEL6 gold is subscription-manager-0.95.11-1.
People which install from ISO and not from network will most likely do not have network connection (that is the reason why they use ISO usually).
Now lets assume we start using new dependecy rubygem-foo, which is in base RHEL or in optional. I.e. we do not provide such package on ISO.
yum will fail ("package rubygem-foo is not available") but since you use run_command(), users will just see on output:
```Error executing command: yum install -y katello-all```
or even with my suggestion:
```Error 'Command '['yum', 'install', 'fooo']' returned non-zero exit status 1' while executing command: yum install -y katello-all```
We should print something which give sysadmin hint that he should install package rubygem-foo from RHEL installation media.
You may check from satellite.git the file satellite/install/install.pl and function check_required_rpms() how it was done in Satellite.
I'm pretty sure replicated is already the default.
Also, unioning queries on partitioned or combinations of replicated and partitioned is much more interesting.

BTW, fyi, as of recent releases, the preferred way to specify replication/partitioning is in the DDL files -- see the doc.
Either keep the code and the `contact-placeholder.png` altogether, or remove the entire block instead of comment out.

You can always recycle the code from git commit log, don't worry.
`toggleSearchMode`
这个问题我考虑过，但是还是决定把他们断开，因为我认为以前通过URL对象做内部参数传递用途是非常奇怪的。

那种情况应该真的传递一个url对象。

get() => 从实际的$_GET里面取数据，不修改。

Request对象 => 负责处理复杂一些的POST和GET数据，以后可以和Form绑定做些校验, 也是不应该修改任何用户数据的。 

Url对象作为parse_url, generateUrl的操作对象，拿来做URL拼接用，这里可以修改Path啥的。



Router那部分你提醒我了，我觉得现在Router里面的实现不好，又拿Url做数据载体用了，就会出现一个Url直接_toString以后不等于自己的情况，因为$_GET里面东西多了，这会非常奇怪。

Router里面应该把分离出来的变量作为参数传给-->$method(),而不是->$method($url)。
typo: and are not listed
But isn't `fieldList` a copy of the whitelist? I think that is what @lorenzo and I are trying to get at.  Perhaps this doesn't need to be a public method?  It is just a helper method after all.
prod_level, mat_level
I'm okay with just testing parts of the data here since assets is so big, but in general, we know the exact output we expect for our made-up input data; we can test it all and thus have less chance of something slipping past our chosen assertions.
`bloodline`
If we are going to store kernel ID and kernel status in a single key, perhaps it would be clearer to just do:

```python
f['kernel'] = km.kernel_for_notebook(nid)
```

And then in js, you would check null:

```javascript
                if(kernel){
                    this.add_shutdown_button(item, kernel);
                } else {
                    this.add_delete_button(item);
                }
```


Also minor style note: try to add spaces around assignment.
I'm going to look into obtaining a reliable and persistent Windows box we can all log into remotely so we can once and for all have more solid Windows testing and access to easier debugging on Windows as needed.  Stay tuned, though do go ahead on this with @jstenar as well in the meantime.  It also occurred to me that @jdmarch might have access to Windows testing, any chance you know what to do here, Jonathan?
There are joining functions in `urlparse` / `urllib.parse`, but they seem more complex, so yes, I'm inclined to go with `'/'.join`.
yeah.. actually this should be removed IMHO.  most of this is just getting access to the PrivateKey, which is much easier to deal with outside of jclouds.  I'd recommend changing this to normal identity/credential where credential is the PEM encoded private key string.  less parameters, the better.
I'm using Github for Mac.
Why is this returning instead of jumping to cleanup?
I'd use `@function` here (it's technically an alias) but this is a global function, so that may be more appropriate.
You're right! Thanks.
The edge case you identified (the case where the chosen value isn't long enough), happens whether or not key is specified. You are right that the `key=None` case is probably not needed though.

It could be rewritten to allow an arbitrary number of keys to truncate, or to just keep truncating until it is small enough. The reason I wrote it like it is because I realized that these cases (needing to truncate multiple keys) don't show up in the use case I was writing for, so I wasn't sure I should be spending too much time on them.

What behaviour would you suggest  when `key` is specified, and truncating that key isn't good enough?
This is confusing too, but apparently we can get invalid modes based on what I read in the comments.
s/repositery/repository -Serious nit pick ;)
True - did it right the first time : )
It's not a *requirement* that RouteLinker does *not* implement IDisposable, so wouldn't it be more correct entirely deleting this test?
Yes. We differentiate this vs. a normal `Throwable` because we know the HTTP request succeeded successfully but it was a client-side error in deserializing the data. The normal exception control flow doesn't get any request/response info.
Are the following assertions (till row 495) really needed?
That is why the assertTrue(true),  throw is already a failure, but strict will complain about the lack of asserts without the true===true.  Not sure of a good 'it didn't blow up' assert that fits strict.

Would changing it to be assertNotEquals, or should I fill in the test to have a known full trace, to test the flattenArgs w/incomplete?
Does it really make sense to define this method in the class ? It looks to me that its only use case is the unit test, so it should be a method defined in the testcase (and accepting the router collection as argument)
this blank line should be removed
also null
I did it in d905a1b but before I fix the tests for UserSecurityIdentity, can you tell me if this is good for you?
or put it into MergeExtensionConfigurationPass since it seems there can only be one merge pass.

speaking of which, the phpdoc for PassConfig::getMergePass() seems out of date:
https://github.com/symfony/DependencyInjection/blob/master/Compiler/PassConfig.php#L179
Thanks! Removed from both KernelForTest and HttpCacheTestCase. https://github.com/RobLoach/symfony/commit/6620fd9014c59727c974b44e285e1faa4d341a5e
Do we usually put spaces between type casts and values?
.... indentation....
Please remove this auto-generated code.
absolute: top 8px right 8px
Given you've downloaded the whole lot, I'd be tempted to unpack it **all** and make it available. We should consider that for a future PR.
Ah. I'm never sure of these exceptions. Since you've defined it, return an UnhandledEpsgError?
please pickup the necessary ones
nit: can you put the q param first?  It's the high order bit.
Is there a reason why passivation is disabled _by default_? Wouldn't this behave differently when compared to multinode cases where I guess passivation is true by default?
PS: Please *no* formatting changes with real code changes :-(
We still need to remove the chroot prefixes on the paths that were returned by the server.
A facebook contact cannot be removed, will be in the contacts lits forever :(

Right now the only way of removing a contact is going to the edit mode, with this change we will be never be able to remove them.
Do we have another flow for this?

Thanks.
nit: remove the extra line break
How could I show the dialer without making a call
Can I do that by only doing    
KeypadManager._phoneNumber = number;	
KeypadManager.render();
?
50 seems really small :/ What about 250ms? Also it could be a constant too :)
On the first launch of the app, this won't be triggered.

You need to execute it a first time at init otherwise if the activity launch the contact app for the first time we won't have the cancel button.
I check and it's OK
+1 Totally agree
Would it be better to just remove the next button instead of disabling it?  Or if that causes problems in the code, maybe you could hide it?
Lol, that was actually more a todo item. the code I have now is not your error handling code :)
As said offline 'screenchange' could be replace by the visibilitychange event (this can be done in a diffferent pull request).
skipping self?
It is feasible to return the final url after all the redirecting. However, i'm curious why you think it is important to return a uri that is unlikely to redirect.
Это часть библиотеки локализации Rails.
No, it was me for the SSH stuff
I don't know what an "application instance" is.
Environment variables aren't used to start Java apps.
missing space after ``!==``
should be `->getParam('action', null)`, as dispatchables don't have a concept of `action`
Are there missing `u''``s here and below?
``composer.lock``, not ``composer.json``
this title need to be updated too
Sure I will change that this evening.
This should be done **after** the read.  On the first iteration through this function, the stsc might not be meaningful.  We want to add to the array the difference also after the read.

Make sense, or am I crazy here?
Maybe this should be moved to https://github.com/humanmade/WPThumb/blob/0af33b42f5e81be4e629cec2216c1293f3015af8/wpthumb.php#L819 i.e. the original WP Thumbed image is working, width / height is working etc.
info: there is a udev rule in https://github.com/ipa320/setup/blob/master/udev_rules/01-cob.rules which maps the LED board to ttyLed
this line is already in master. Can you rebase this new commit on top of what's currently in master?
I don't disagree with any of that.  I had planned on getting rid of the explicit call to `Rows.new` in this pull request.  This method would have been necessary for me to do that, but I ended up deciding to do it in another pull request.
Missing ending ";"
At the moment the menu items are stored in the assets table with a wrong parent id and level, to fix this add the following code over here to retrieve the correct information:
```
		// This is a menu item under a menutype.
		if ($this->menutype)
		{
			// Build the query to get the asset id for the parent menutype.
			$query = $this->_db->getQuery(true);
			$query->select($this->_db->quoteName('asset_id'));
			$query->from($this->_db->quoteName('#__menu_types'));
			$query->where($this->_db->quoteName('menutype') . ' = ' . $this->_db->quote($this->menutype));

			// Get the asset id from the database.
			$this->_db->setQuery($query);
			if ($result = $this->_db->loadResult())
			{
				$assetId = (int) $result;
			}
		}
```
Oh clever, this should fix module includes bug https://logstash.jira.com/browse/LOGSTASH-329
This line shouldn't be returning the value of the include directly.  It should ignore the include return value, chack to verify the class or interface was loaded and return true/false based on that fact.

Including a file that has a 'return' in it causes the call to include to return that value instead of true and this can of course cause problems.

An overall better idea might be to use the ZF autoloader in place of the Varien_Autoload class if possible.
better to use the global `sp` set at the top of this file, because the implementation may stop setting prefs after an unload.
What are the usecases of `@packaging` in Firefox?
Bah, I should not review pull requests before coffee. The table you're adding this to is "Optional Common Attributes", which contains "attributes that *all* settings may have". But this attribute is specific to the control type, so should be documented in the table under "Setting Types" alongside the `control` type - which it already is.

It's possible that this is terribly confusing, but I think if the table just presents all the attributes and lists which ones apply to which types, then it will be even more confusing.
Why not just reuse the rebuild() method that already exists and seems to do almost the same thing?
why is the table width and cellpadding is being hard coded.
(Use 3rd person declarative) - This is throughout all comments - not entring this for the rest.
That would actually be even better yeah, does take a lot more rewriting stuff though.
What do you mean? Using ruby 2.0.0dev (2012-07-05 trunk 36322) [x86_64-darwin10.8.0] and changing from `File.unlink @link` to `rm_r @link` does not work at me. As you said, `File.exist?` uses fstat, not lstat. I'm not sure it's good to change File.exist?, because a symlink should be transparent by default (and I can't find an appropriate name, File.lexist? is no good).

It might be fixed in mspec, using lstat, is that what you mean?
"The identifier of the entity that published the most recent post that was seen."
this line should actually be deleted...
missing name of the argument `array $attributes`
Fixed in source - sorry, the comment can be deleted.
"\ No newline at end of file"
You lost the "|" characters between the various interfaces/classes.
`$this->getOrganizationRepository()` not anymore exists.
It probably got created by git as a result of a merge conflict at some point.
fixed by https://github.com/Pita/etherpad-lite/pull/1059
Doesn't this check all the protections, not just the spawn point?
`classname` too?
Ieks
You can inline this error constructor.
This code is wrong. It does not take care or the property visibility.

Instead of using the ReflectionClass directly here, you should use the Doctrine ClassMetadata of the related object to get the value.
Since you set it to undef above, this will cause warnings in the logs. You can't stick an undef variable in a string -- the result is undefined. Please set it to blank ("").
Mplayer vypise prazdy riadok na zaciatku a konci videa, su nerozlisitelne. Pridam koment.
vscgroup : replace by some configuration value or schip schema
i don't think we should rename it to eg hpcgroup (this is vsc namespace afterall), but without a schema this is useless
Is this needed? It will be in CPATH by default,
is there a reason why it should not be in CPATH? In this case, this solution is wrong.
I've introduced rbenv instead of rvm at last :smile_cat:
i think this is the most important problem atm. we probably either need to push filtering and validating into the rest controller of createphp or overwrite that controller. ideas and PR welcome.
I'd prefer to keep them in:

1. Saves a redirect.
2. Saves the very rare case that a POST to the almost-right URL fails.
3. It's a bit more explicit and doesn't cost much.

Maybe just a style thing. Feel free to call me out as wrong and I'll change. :D
/en-US/ in not necessary.
I don't understand why you're changing this test.
I wonder if we should wait until 100%?

I think we can pretty safely fire can play through as soon as vimeo says we are ready.
Oh. I didn't actually read the comment. I just assumed this would be the real addresses. Sorry about that ;-) As long as there is no confusion as to what memory location belongs to which description in the comments keeping them up to date isn't that important. However if there's a chance of not being sure which is which....I guess that's up to the author. I'd replace the realistically looking addresses with placeholders though (0x... or something).
I removed the TODO. But what's the reason to have a switch-case with one case over a simple if-else statement?
そんな意図が表されるものだとは知らなかった…
:+1:
maybe event.currentTarget; but i'm not 100% sure on it. definitely not event.target, see my comments above about how the event.target is the innermost element the event started from, not necessarily the element that matched the selector.
private, made it private[camel], added note for internal use
Best. Error. Ever.
alright, that I completely understand. This version is a complete rewrite since Github API v3 is supported.

Could you revert your change in this file so that I can merge it? Thanks!!
Just to document: discovered that neither registration will raise an error in the event of non-success HTTP status. So James decided we'd do the simplest thing and ignore the fact that, if those libraries are changed, there could be errors raised by the Router/Rummager delete requests.
Fair point, but of course programmatically it doesn't matter. Ultimately I think you're arguing for documentation to not use it as a keyword argument, right?
Where does the variable come? ($execute)
part of the kludge mentioned below
Can we clear this TODO?
No need to increase this, it will send the remaining data the next spin.
After I read  code in clearObjectViewCacheArray( array $objectIDList ) which already contains " eZContentObject::expireAllViewCache();" ,  I more think to use "clearObjectViewCacheArray" to expireAllViewCache...,ideally..
The query should return a check by row, no?
Actually, looking more closely, this CSS isn't specific to login/register? or is it? Right now it's everywhere Bootstrap is enabled, but it looks pretty login-specific. What do you think?
лучше завести структуру для вершины, в которой все информация о ней, чем хранить кучу параллельных массивов
we have a second instance of Adblock Plus in this file but we have to find a suitable addon
It would be cool if this could auto-discover commands, but that could probably go in another pull request.
Yup, we can definitely be confident -- Cascalog's going to need a bit of work before it supports local mode.

```java
JobConf jc = ((HadoopFlowProcess) flowProcess).getJobConf();
```
I have no idea if it matters at all, but this could be marked `^:const`.
Yeah, absolutely. It was just a note for the next sprint. We have to figure out our UI hosting strategy first.
There's a logical error in this. getBasicProfile is used for getting other people's basic info as well, and we shouldn't be exposing whether or not these people are tenant and/or global admins. We should only be exposing these fields on the me feed.
There are two traversals of all annotations, maybe it would make sense to optimize if the model is an instance of `IAnnotationModelExtension2`, which has an overload for this method that takes a start/end position to look for annotations. Since `SemanticHighlighting` uses annotations, it's not uncommon to have more than 10.000 annotations in an editor.
Эта строчка имеет следующий смысл.
После удаления, например второго элемента, массив получается в 0-ой ячейке 0, в 1-ой ячейке 1, а во 2-ой ячейке значение 3.
Этот массив для того чтобы выбирать однозначно те элементы из основного массива которые не прошли процедуру мутации
По обоим пунктам нет возражений.
Если не смотрели лекцию 3, как раз самое время! Можете закрепить знание о методе description объектов-наследников класса NSObject.
"Rafineerimistehas" is better than "Rafineerimis Blokk" (it would be equivalent if original block would be "Refinery block")
The search ID MUST be a UUID in canonical string representation, and SHOULD be unique...
Looks like this is missing a description. Could you add one please?
got it! in the form view, i had <%= f.label "Email" %> instead of <%=  f.label :email %>
The `ThreadAffinity` pattern is only required when one has to call to `Ensure.Success` and potentially retrieve an error message.
Can you rename this `objectish`?
I haven't tested without the `ref` modifier. IIRC this *might* be required for structs. @jamill ?
If you find a less "noisier" way than `ref` which makes both .Net and Mono happy, let's go with this.

```
/home/travis/builds/libgit2/libgit2sharp/CI-build.msbuild: error : LibGit2Sharp.Tests.NoteFixture.CanRetrieveTheListOfNotesForAGivenNamespace: System.NullReferenceException : Object reference not set to an instance of an object
/home/travis/builds/libgit2/libgit2sharp/CI-build.msbuild: error :   at LibGit2Sharp.Tests.NoteFixture.<CanRetrieveTheListOfNotesForAGivenNamespace>m__24 (LibGit2Sharp.Note n) [0x00000] in <filename unknown>:0 
  at System.Linq.Enumerable+<CreateSelectIterator>c__Iterator27`2[LibGit2Sharp.Note,LibGit2Sharp.Core.Compat.Tuple`2[System.String,System.String]].MoveNext () [0x00000] in <filename unknown>:0 
  at System.Collections.Generic.List`1[LibGit2Sharp.Core.Compat.Tuple`2[System.String,System.String]].AddEnumerable (IEnumerable`1 enumerable) [0x00000] in <filename unknown>:0 
  at System.Collections.Generic.List`1[LibGit2Sharp.Core.Compat.Tuple`2[System.String,System.String]]..ctor (IEnumerable`1 collection) [0x00000] in <filename unknown>:0 
  at System.Linq.Enumerable.ToArray[Tuple`2] (IEnumerable`1 source) [0x00000] in <filename unknown>:0 
  at LibGit2Sharp.Tests.NoteFixture.CanRetrieveTheListOfNotesForAGivenNamespace () [0x00000] in <filename unknown>:0 
  at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (System.Reflection.MonoMethod,object,object[],System.Exception&)
  at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0 
```
I think I forgot to remove the heading below mne.preprocessing. Thematically it should belong to Projections.
we could have 

denoise_raw(raw, bads, copy=True | False)

if copy = False denoise is done inplace assuming raw.preload = True
Let's enhance this to return an error to the user that contains a message explaining what happened. The error should be in JSON format like this:
```{statusCode: 500, message: "Something went wrong"}```

don't forget to change the Content-type to application/json
need to make sure attempts == 1
Kind of ugly chain of methods. I'd refactor this.
You end up sending a lot of unchanged content this way.
"you won't loose them"
We prefer to break code examples onto multiple lines if it reaches the 80 character (a longer line will produce horizontal scrollbars). You should do something like:

    .. configuration-block::

        .. code-block:: jinja

            {% render '...:news' with 
                {}, 
                {'standalone': 'js', 'default': 'AcmeDemoBundle:Default:content.html.twig'} 
            %}

        .. code-block:: php

            <?php echo $view['actions']->render(
                '...:news',
                array(),
                array(
                    'standalone' => 'js',
                    'default' => 'AcmeDemoBundle:Default:content.html.twig',
                )
            ) ?>
@weaverryan : I added something to point that out.
定义nginx不进行从缓存中取得响应的过程的条件

->

定义nginx不从缓存中取响应的条件。
What for?
As far as i know this is the correct way to represent sheme-less (or network-pah reference) URIs.
Reads are already resumed at this point, you just need to return here.
I see it here https://developer.mozilla.org/en/CSS/outline-style, but it may just be part of Mozilla's implementation, and it shows up in WebKit's user agent stylesheet as well.


I went with "auto" because I want the flexslider to respect the browser defaults, which in WebKit would be overridden by "thin dotted." 

The important thing is to provide a clear indication of focus by removing the outline:none :focus declaration.
```python
>>> (2*log(2)*x**2*log(x+1)).as_independent(x)
(2*log(2), x**2*log(x + 1))
>>> (2*log(2)*x**2*log(x+1) + 1).as_independent(x)
(1, 2*x**2*log(2)*log(x + 1))
>>> (2*log(2)*x**2*log(x+1) + 1).as_independent(x, as_Add = False)
(1, 2*x**2*log(2)*log(x + 1) + 1)
```
Хм, не понимат. Почему бы просто сразу всегда не показывать иконку? Все равно она у тебя не прячется потом.

Кстати, возможно, имеет смысл прятать иконку, когда ничего не проигрывается. Таки это не единственная иконка личкрафтов, и потому нет смысла держать ее все время в трее, как в случае всяких амароков.
Yes, the title. I must apologize, I have messed up the MainViewModel (and ThemeManager) files somehow, having them show up as completely changed, instead of just the few lines I have actually modified. My bad indeed, I'll tread more carefully next time, making certain my commits are clean.
I was forced to read the ruby-docs because I couldn't figure out how to easily compare elements in an array and see which had a higher value (in this case - an integer greater than the other). What would be the more conventional way? To use inject?

    [@move_a, @move_b].inject do |m, e|
      m = e if e > m
    end
Makes sense. I tend to go for speed in any files that I know are completely stand-alone, but am always curious about other useful practices.
Please use string interpolation
lolwut? who wrote that ;)
True. My point with the comment though is sometimes restarts stop and start the VM, and these files mysteriously vanish. So rather than have the process fail because it can't delete files that aren't there, I'm catching the exception. Maybe I should move this comment to the except block so what I'm referrer to is clearer.
are these comments needed?
I think this should be a warn as configuring the cache like this doesn't really make sense?
We tend to start test methods with test..., so it makes it easy to spot those which are test methods as opposed to helper methods. Consistency :)
And covariants require B to actually override x(), which is tedious and unfortunately cannot be made compulsory
another possible place to replace with np.hypot()
Please use `.text()` instead of `.html()`
add a #TODO:  comment
По #96 никто ни к чему не пришел. Не стоит что либо менять, тем более это не тот случай когда название интерфейса занято классом, как описано в #96.
no need to change this, the if statement you changed applies to PEAR coding standard
what's a "beta update"? Could this be more helpful? I don't think it adds much to the name of the function, right now.
Good point, we probably don't need them. They are general purpose, but if we have no need for css animation, then we don't need them here. More complex animations we'd probably have to use javascript for anyway, as a lot of the actions are already javascript*. 

I'd be tempted to leave the duration mixin in there, and remove the more complex animation keyframe stuff (and delay, as the use case isn't as general purpose). The duration mixin lets you do simple ui stuff like transition hover changes easily. It might be worth using this effect on our button hover? It might not be worth it though. I can remove them all for now if that's easier?


(* I think it would be nice to animate the expanding and shrinking of panels, particularly the preview as the change is a little jarring.)
yeah, but we still allways have composer.lock for composer install command ;)
- Are you sure the method ``expects`` can be called on ``$this->context`` (of type "object<PHPUnit_Framework_MockObject_MockObject>|null")? Please also check line 45.
- Are you sure ``$this->never()`` has the correct type as "object<PHPUnit_Framework_MockObject_Matcher_InvokedCount>" is not a sub-type of "object<PHPUnit_Framework_MockObject_Matcher_Invocation>"? Please also check line 45.
- Are you sure ``get_called_class()`` has the correct type as "string" is not a sub-type of "string"?
- Are you sure ``0`` has the correct type as "integer" is not a sub-type of "integer"?
Is not use in that class
Man... this is heavyyy on the DB
gibt es eben NICHT! hab mich auch gewundert... oder einfach nicht gefunden. Es gibt wohl ListUtils.sum(List, List) aber die summiert 2 Listen.
Can we change this to take a big array of options with some nice defaults rather than a huge list of params please?
Yes, I don't see any usage of it. Can I just remove it? (you don't have to do it, I can take care of it, I'm just double checking with you before going ahead :))
Why are you redefining the url shortener?
Note: [`document.write` doesn’t work on XML-based documents](http://ln.hixie.ch/?count=1&start=1091626816).
You should be able to safely remove these 2 gems.
Seems to be one too many indents here?
is it necessary to keep these lines ?
Agreed. If someone serves a binary file with ``text/``, they are doing it wrong on many levels.
this project doens't use Selenium
could you switch all these calls to openFrameworks ofBeginShape() calls?
It is needed, because I have a "menu" on the left:
"""
<div id="menu_list">
        <p><a href="{% url user username=user.username %}">{% trans "Profile" %}<a/></p>
        <p id="current_item"><a href="{% url account %}">{% trans "Account" %}<a/></p>
    </div>
"""
And if it is not in the div, It jumps arround when you change from profile to account.
*piškotku v tvojem brskalniku morajo biti omogočeni.*

Dot at the end!
We have renamed this field (`request_get_next`). Please do not reintroduce it.
No mine actually worked also, so this wasn't the problem(but if it was only /token/ it return confirmation_token='n', no idea why). But love you solution. If I understand correctly, this is just to check if there is anything after <code>/token/</code>, it is actually very similiar to if sentence. If there is it will add the code after the first and until the last question mark. Else it will add nothing.
Download this locally and add it to static files. We do not want to depend on third-party servers.
Right, and the same in link.html. What you said for wrappeduser.html is correct as well.

In other words, make the else condition match what was the previous value for target, before your change. If target wasn't specified before, then use its default value of ''. That way nothing changes for users who don't have this preference turned on.
Type here should be org.jboss.as.quickstarts.html5rest.HelloWorld
Could we change line 1560 to:
hours_data.get('name', []).append({

?

This would eliminate the need for lines 1552-1553
But the values were already extracted in AuthenticationAdapter.
Enforce cast to `(string)`
There is a small problem with webkitFullscreenEnabled vs. mozFullScreenEnabled (please note the "S"), but I can use the prefix for other functions, will submit you a new pull request later? (I'm new to git)
should be a stub
Nit: This is still not the layout recommended on m-c.
Nit: Usual bracket remark. Please tell me if you have no intention of doing it, I will stop with these nitpicks.
Okay, understand better now!

On Sep 12, 2012, at 6:32 PM, Christian Krebs <notifications@github.com> wrote:

> In src/network/network_details_templates.js:
> 
> >      {
> > -      // Add data-spec attributes on certain firstline tokens, tracked in state
> > -      attrs.extend(["data-spec", "http#" + (token[STR]).trim()]);
> > +      attrs.extend(["data-spec", "http#" + token[STR].trim()]);
> 
> E.g. to extend an existing array with a return value of map.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Indeed. It works because it gets vector through libs.h further up, but changing it anyway - good to be explicit.
If the file is empty just delete it.  If not should we stick it in the trash? or rename it?  (just thoughts/questions)
!= 0 would not work on the BigInteger object type.
Thank God we don't have containers and grid systems, that would make the page organized and ugly.
No worries, you were quite right!
I've just done it, checked that it's not used anywhere else at the Python layer (it's not) and run scons and scons tests. All fine.  Would you like me to push?  (I also made the changes to lan5 etc. in base.py, for testing, but can revert these if it will cause a merge conflict).
tab here.  Should do a quick grep for tabs in your .h and .cpp files to find others that might be lurking.  I think mmgr.cpp should be the only one with tabs in it, since I never converted it to our style.
What do you mean? You want the test to be called like test_get_children rather than test_getChildren?

The convention I'm using is to put test_ in front of whatever the model method is called, and ContentSection has names like getChildren and countChildren. 

I prefer linking the test name with the name of what it's meant to test, so you know that they go together (and can learn the API by reading the tests.)
You should add the following tests to be complete : 
* `should_pass_if_actual_is_contains_given_string_only_once`
* `should_fail_if_actual_is_null`
* `should_throw_error_if_string_to_find_is_null`
Really? You foresaw the need for, and began work for this last year? :-)
took me ages to find this ... and this was causing the unwanted scale-back.
but at least i understand the other logic better now.  clever maths here btw!
Would prefer testQuerySensors to be `enabled=false` and not commented out, and a TODO or FIXME saying why it is not enabled.
Make refreshNeeded field final?
OS.class_NSTableView is objc.id, objc.id is a pointer of dwt.internal.objc.runtime.objc_object structure.
Declaration of objc_object is:

```D
struct objc_object
{
    Class isa;
}
```
Mmmh. A new warning for 1.3.0 is completely acceptable imo.
I actually don't think we want to limit this to arrays only.  Anything that duck-types to the parts of the array interface we need here should be sufficient.
Wait... this method never fails.

I see you have a pattern of using `retry()` and then `assert`. Why not combine them into one method?
You shouldn't need to export databaseimpl, as it's internal. Where do you need it?
I thought I was using 79 character lines. I'll check this.
Well either we just assert out to avoid people from passing non-ASCII chars or we just return false. Not sure about that yet.
yay, abstraction!
As long as we're having to rebrand, might get at this one, too.
The pathplanner should choose for itself if it wants to keep running or not. So I would suggest moving the conditional to inside the path planner (note, I'm referring to the path planner lib math, not the FSM/PathPlanner hybrid module) and running the path planner each loop.

The path planner checks wether the goal state is the current active_waypoint, and if it wants to (which this simple path planner does) return to the main loop. This isn't really branching logic-- which would belong in FSM--, just a tacit admission that for all identical initial and goal states we have identical trajectories, regardless of the current state.
Wrong version of the spring-beans xsd.
Repeated code, makes more sense move it to out of the if
this is probably cludgy. Anyone a better idea how to maintain per-project settings from within backlogs? I choose not to use a hash by project because the settings screen (checkbox) would get complicated then...
yeah you're right...damn
ExecutorService (создание через Executors).
Extension используется только для форматирования с паттерном (что-то после ```:```)
Change this to Assert.equal(link_selected, duration) and it will be perfect.
We should use the methods name and click defined in FeaturedApp https://github.com/mozilla/marketplace-tests/pull/186/files#L2R62
This is duplicate code.
そうですね。個人的にはアリアリだと思ってますが。
読みづらい原文に忠実な直訳よりも、読みやすい超訳派。意訳展開アリアリ。
もちろん、内容があっていることが前提ですが。

この辺は、全体で意識合わせておかないとですね。
It is possible but I thought it might incur some overhead. I'm not sure how big that is, though. On numpy arrays, indexing with indices is slower than boolean masks I think.
check_pairwise_array have checked that for you :)
I would use `sklearn.cross_validation.train_test_split`. I think our examples should be the channel through which we promote best practices, since fragments of them usually end up copy-pasted in user code.
Why is this necessary in this case?
> @GaelVaroquaux I am a little unclear about your point here, what is your
> concern between making it as a standalone function rather than a method here?

I'd like it to be a function, rather than a method, because it is easier
to plug in a larger setting, e.g. in another algorithm that's using
spectral embedding as a component. For instance in spectral clustering.
``make html-noplot`` is the same as ``make`` btw
heh, yeah :)

well, i guess usually when you `p` (output) stuff in the global namespace then you do that for testing if your app (classes) works as expected. ideally you'd write one test for each of those expectations and "assert" that they're actually met.
Do you have a coding standards doc for your project?
I put a FIXME to handle this better
This else is redundant an unnecessary.  It's already set above.
I think extending the `AbstractConfigurationFactory` isn't the correct approach. Instead, the drivers should come from a driver factory. This both allows extending/replacing the driver factory and keeping the current event based logic.
no need for a condition - it is always true.
should cast -1 to unsigned - and possibly have it as a constant.  ALL_BITS?
Fair enough.

Can I have some uri construction methods based on the types in juri.h ? ;) only kidding.
should be 'be they'
should these all have inline qualifiers on them?
For compatibility with older builds, we need to call getRecordSize(NULL) for the value to store in the index. hThor code already (or rather still)  does so...
It's outside the scope. Just like you don't say `sudo pip install pep8`.
```py
except ValueError:
```
The output here is e.g.
ia64 hp server Integrity Virtual Machine
it would probably make more sene to grab the output of "uname -m", which is either "ia64" or something like "9000/123" for PA-RISC machines.
Are those links correct? I don't see anything. Is there something I have to setup on my own? Could we create a mozauto user?
I thought it looked cleaner, since now we only go one deep with the if statement, instead of two. Plus its a key lookup in a dictionary that should happen in O(1) opperations
please delete this file.
I concur -- doGet() would be a good name for the HTTP method.
the result of this call to `reverse` is not used anywhere, so this line `(reverse x)` is unnecessary
Hmm,  hashKey.left(2).toString() doesn't compile against my 4.8.2 nor is toString() mentioned in any of the recent QByteArray docs I could find, but anyway, the end result is the same.
s/contexts/types/ if you're renaming it
"savin' all my 'of' for you ..." :heart:
fixed. As well as in other modules.
I was looking for a standard way to fetch DC info in msf or meterpreter. I didn't find it.
Read unamed memory structures with railgun was not something I was ready to accept when a simplier local HKLM lookup was available.
You should maybe wrap your code in a standard function, that newbies like my could easily find in the framework. 
I would have used it.

I also have a doubt regarding the usefulness of trying to connect to a DC without a valid domain user/computer account ?
Extra whitespace? Maybe move `::` to the end of text, i.e. `clockwise, the matrix should be::`.
Should be using new-style classes wherever possible. (`TestRedirects(object):` if it doesn't need to have another base class. Unless this is Py3?)
Why extract this function?
Please use `self.urlopen` for all calls. It does some referer magic etc.
I don't think this should be a resource but rather a constant. Constants like these usually don't go into resources.
I don't like create methods for 5-7 lines of code but if you see that would help, then let's do it.
Fired when the selected text in this text area changes
(http://developer.apple.com/library/ios/#documentation/uikit/reference/UITextViewDelegate_Protocol/Reference/UITextViewDelegate.html)
Plain text gets converted to HTML, so an extra space doesn't cause any problems in the generated output.
Can we remove the extra space here? =)
Is this project really the best place for this code? It seems like a useful library that could live on its own and be pulled in via pub. I also don't understand how this fits with dart-html5-samples or the build process.
The only addition was winston. I have sorted the vars. Ok?
Always prefix member variables with "m_".
@eshamow and @kbarber there is one little bit that is missing, at least I believe so. I mean, the missing bit is error handling on argument type-checking. For instance, calling to_sym on [] and {}, as well as any Float will result in NoMethodError, then for both positive and negative Integer it would return simply NilClass, and finally for empty string '' we'd get ArgumentError being risen.
Can you remove it again?
do we need `target="_blank"` or anything special?
I agree, but @splitbrain didn't want to have an entry for the default template, see http://www.dokuwiki.org/template:default?do=revisions
@splitbrain, can we persuade you (for both template:default and template:dokuwiki)?
I have completely forgotten about `endsWith`, it's better.
Or just use `reduce!commonPrefix` – would be interesting to see what code DMD generates for it.
Is `PSU::FORCE_SSL` necessary?
I think you can get rid of the `$HOST` variable and allow BASE_URL to be:

````
$GLOBALS['BASE_URL'] = '/webapp/calllog';
````
Nevermind.  Looked into it.  Seems like it's the latter?  Will do.
Richard says this way is more concise... I advocate changing the old tests to this syntax.
It's an internal variable invisible to the users.
bracket police!

I also agree with this. `unless` is easily abused, but in this case it's exactly right