labofsahil/github-event-dataset-2012 huggingface dataset:
A const is fine. But if you made it a class attribute, then you don't have to change any other code.
configman is awesome!
I recommend using the `mock.patch` thing as a decorator instead. Then you don't get this almost insane 4-level indentation.
Removing those lines breaks the unit test: 

<pre>IntegrityError: insert or update on table "bug_associations" violates foreign key constraint "bug_associations_bugs_fk"
DETAIL:  Key (bug_id)=(1) is not present in table "bugs".</pre>
exploitab*i*lity
http://elsdoerfer.name/docs/webassets/expiring.html#expire-using-a-querystring
le comportement par défaut est d'utiliser une query-string, et avec ma branche master j'ai bien `/static/gen/main.css?de833b92`.
Il est aussi possible de modifier le bundle (dans le template `layout.html` pour obtenir un truc genre `/media/screen.acefe50.css`.

D'ailleurs il me semble qu'il faut faire la config sur l'instance de la classe, pas sur `Environment` directement:

``` python
assets = Environment(app)
assets.url_expire = True
assets.directory = os.path.join(CACHE_DIR, 'assets') # note: ca plante chez moi
```
nit : an --> a ?
@fre5h може таки винесемо це кудись за рамки цього проекту? функціонал потрібний для всіх проектів
Hello @schmittjoh , don't worry, look at https://github.com/romainneutron/symfony/blob/44dfdca1c35ee6b956e3814bb96d090504453b46/src/Symfony/Component/Process/Process.php#L212 , we're outside windows scope here :)
You can already do that by extending the application and overriding the `getDefaultInputDefinition` method.
AFAIR, not all rendered templates are rendered by this method, far from it. So, your array can be incomplete. Last time I checked (and I think nothing big changed since then), it was just impossible to get all rendered templates.
shouldn't you use the ``LG_CHAR_ESCAPING`` constant here ?
Thanks @ruimarinho . Yeah ... so I noticed while implementing the above flag, that makeDisposition doesn't set the Content-Disposition header. It just creates something that can be used as its value. So ... setting Content-Disposition headers is indeed a bit crufty. But still: Isn't that something valid for *all* responses (or rather ResponseHeaderBags)? I'd leave it for a seperate more general PR.
IMHO zlib compression in PHP should be disabled, and your webserver: nginx, lighthttpd,apache should take care of that
No, it is a test about importing other resources (some in the ini formats and others in the YAML format).
Done for readability.
esession -> session
Rather than trying to thread the Node through the call stack, I added an implicit DynamicVariable class val which is set to the node being operated on at the top level. If an exception is thrown anywhere in the class, it picks up the current value of the dynamic variable and the position information is grabbed from it.
move `int bottomOffset = ...` inside `if` block - it's used only inside this block
New hash syntax.
Acest fișier trebuie de pus în `.gitignore` nu în depozit. Fiecare poate avea diferite versiuni de ruby.
This code appears to leak Session objects - we need to delete them here, or better yet, just use a boost::shared_ptr so that they get deallocated automatically.
Evil smiley again ;-)
How about:
```
return prj.transform_points(self.source_projection,
                            xy[:, 0], xy[:, 1])[:, 0:2]
```
When you call to the callback, is better if you use:

```
process.nextTick ->
  cb()
```

Because that is really async.
What's the point of displaying `currentState` in the message if there's no `currentState`? Since this only effects initialization wouldn't it be better to do this check in the code that handles `initialState`?
Naming nitpick:  `my_class` is not a class.
Name attribute should be just removed.
connectors have it as backward compatibility
This still leaves a problem where if the user created a rule named "rule-my-rule-name-starting-with-rule-prefix" (intentionally) then the name attribute will not get written out. Perhaps, we could just write out the "name" attribute without this condition check? That would still be backward compatible, from what I see.
`this.document[0].activeElement` for cross-window support. Also, have you run into cases where there is no active element? That should only occur if the document hasn't loaded yet.
better with inputstate -> inputState?
This list item should not be removed.
Good addition! Thanks.
Let's file a bug on this and reference the bug number here.
// Bind events
Correct indent if you really want to keep this comment
Indeed... ;-)
Are we certain the job started by pr.sh will never begin after this job is started?
(use ' instead of " too)
I'm a silly cow.
AlarmsDB.getAlarmList((function al_gotAlarmList(list) {
      this.fillList(list);
    }).bind(this));
we prefer return earlier, so please use 
`if (oldPanel.className === 'current')  
  return`
EnsureSuccessStatusCode already does that. It gives us the status code and message.
Either that, or the <VirtualHost *:80> is not necessary when we have the same Alias statement in the global namespace. It seems that this statement is the only reason why the alias works for SSL, and presumably it will work for non-SSL also without the need for the below VirtualHost block.
Wrong copyright holder. #5
`endings` :-)
i am using version .99.3-1, which is pretty old i guess. 
i added, a get(), which will default to 'png' for users of old mpl.
and maybe test that it is within the configured range...?
Roll what into an assert?
condition is not clear (using both || and && in one line)
Same goes into this one. No special cases. In long term these are going to make our APIs unusable.
If you assign port=0, TCP will dynamically allocate a port.  `master/buildbot/status/web/baseweb.py` has a getPortnum function you could co-opt for the purpose of recovering that port:

    def getPortnum(self):
        # this is for the benefit of unit tests
        s = list(self)[0]
        return s._port.getHost().port
This redefines this function, which is probably not what you want
@paulmillr @molily ping
Why should rename to CCFileUtilsAndroid.cpp?
I think the name is not consistent with other files, such as CCCommon.cpp.
Added cast to bool
Actually, fixed in https://github.com/composer/composer/commit/4e9e66a95711d643b9ade82bc274c744fe1af21b
@ahume @mattandrews  Is this line here because doing a full dom scan three times is inefficient (starting from line 126)? There's no test for in FWIW
It should be in subdomains/www/php  - It was never tested and may never be used if I don't need to save a physical page in order for the iframe to pull it in.
Probably my editor removed it, I double checked now and it *should* be there. :)
label1
Lets just log error instead of throwing.
Would not it make more sense to combine `extraHarnessOptions` with `harnessOptions` itself ? What's the point of accepting two different options that get combined later anyway ?
@lloyd - good catch.
Super pedantic comment - `if(` should be `if (`
This docstring is out of date, should say `perftest_ref_data.json`
There shouldn't be a case where it is invalid on startup that I am aware of. If the config and preferences are fail-safe then it shouldn't have a problem on startup.

However, deleting the folder after startup is a flaw, but handling it properly would involve checks in a couple places (turn on logging, open folder).
if (null !== $columnName) {
There is a typo, an extra "e" in "unresoleved", `remove_unresolved_default_spec` is correct.
I feel this is flat-out unnecessary we could just use our public domain name `rubytij.org` no need for the extra config.
pls write a couple of lines about why these probabilities are chosen (in addition to, if still needed, link to this reference)
might as well add a newline to eof
kill extra space
That was to make sure I didn't blow up calling `position()` on a non jQuery object.  If you think it's overkill, I can take out the check.
@PaulKinlan That's not a problem. Just add grunt as a devDependency, and use it as much as you want in testing ;)

What I'm talking about here is to remove grunt as an actual dependency.

Sidenote: grunt 0.5 is going to be more split up, so you'll be able to use the various components individually.
Also, in setEventManager, you should set identifiers:
```php
$eventManager->setIdentifiers(array(
    __CLASS__,
    get_class($this),
));
$this->eventManager = $eventManager
return $this
```
Definitely, I just copied&pasted under it because after trying to create new buckets with S3 class, I discovered that non-DNS compliant buckets are not permitted with REST api calls, but only with SOAP calls.

The question is: should we switch to SOAP? Amazon own sdk is based on REST, but I can imagine folks who already have uppercases or strangely named buckets and would like to access them as well.
Well, I did based on the existing files I have found in a /_files/ directory. Should I apply this change to all of them?
http://packagist.org/packages/?tag=Admin+Generator
As You can see in the link the spaces are allowed in Tags - also there is no info about keywords limitations in composer's Schema documentation.
You should use single quotes here
You can just comment out the two assert lines above instead of deleting this section. We do want to restrict this to milliseconds, but we haven't yet enabled the code that enforces that.
-> `tempTodos`
Eli jos laskuriville on asetettu kassalippaan tiedot niin haetaan tämän kassalippaan tiedot. Jos kassalippaan tiedot ovat tyhjiä niin palautetaan yhtion takaa löytyvät tiedot, jos jotain on asetettu niin palautetaan kassalippaan tiedot.

Semmoinen tuossa on mahdollista, että jos kassalippaan taakse on asetettu vajavaiset tiedot (esim. kassa on asetettu, mutta pankkikortti ja luottokortti puuttuvat) niin nämä tiedot palautetaan. Pitäisikö tuossa testata, että kaikki tiedot varmasti löytyvät? Voiko sellaista tapausta olla, että kassalippaan taakse on asetettu vain osa tiedoista?
I don't think we need this clause, instead, we could simply write:

    defp do_mkdir_p([]) do
      :ok
    end

WDYT?
sscanf FTW !
eh, toto je hnusne aktivne cakanie, preco sa radsej nezablokujeme?
Spaces after :
I think `vfsStreamWrapper` should not generate an id. Why not use `spl_object_hash()` directly here? This would also remove the duck typing like coupling from `vfsStreamFile` to `vfsStreamWrapper`.
You've already explained it, and I misread, but thanks.
I think this should be indented once more, right?
Improper indenting. See `make lint`
no more items? it seems like we don't really need it but I'm not sure I see the down-side of including it since you've already written it? It won't make anything slower I think.
要するに僕は何が言いたいかって言うとそれはスタイルシートでやって．
@simonster you can probably tell better if using `Zotero.Utilities.Translate.prototype._convertURL` from utilities_translate would work in `Zotero.Translate.ItemSaver._saveAttachmentFile` and if it would be compatible with all browsers.
Maybe this should map to ```manuscript```?
Thanks, changed it to PUT.
Brief definition of exposed events here, please.
It's a naive refactoring, so the `LONG` and `null` are both [legacy from this version](https://github.com/gnugat/dbal/blob/b5f8b2d850b0e67313597e2a7f45d04772df61f4/src/Fridge/DBAL/Platform/MySQLPlatform.php#L52).
ага. понятно. но тут код дублируется.
и вместо == false пишут даже не != true
The reason I used DefaultConfiguration instead of a singleton is because SwaggerConfig can be passed to the controller, and in fact, if you use an IoS container like autofac or unity etc, you can have it automatically inject a SwaggerConfig. Also makes unit tests easier; singletons are hard to test.
I agree and change it.
I fully understand the code, and stand by my comments. This is harder to follow than the minimal duplication - and I don't often argue for duplication! We shouldn't code for the future but what if the search behaviour changes in any of these page objects? I would be concerned that any such changes would be hard to find, considering they will be in a base page object. No more objections from me on this, do as you see fit.
You don't need to wrap this because there's an assertion in the method
Bit of an encoding problem here :S Can you check your editor's settings?
Yeah... I can see that.. although in order to avoid repetition in my event validation code, I would end up composing those functions into another function anyway.

I'll just remove it for now.
Currently, the ensureSchema function are executed concurrently, so this can potentially fail. How about we only refresh the pool when cassandra.init has finished?
It is a custom validator, but unfortunately node-validator doesn't allow you to pass an object into the check function. This was the only work-around I could find.
Hmm, actually maybe you could, if you combine the 0 and array-end guards, and just pass a +1 or -1 in as an extra parameter for the step.
And I just saw the note right after the ``<extension>`` declaration. Discard my comment then.
Eh eh, yes, the local profile still exists in the ``build`` project. The one in the ``build-toolchain`` was entirely useless (check the pom).
Maybe you should also have a catch on ``IOException`` and fail gracefully. What I mean is something like the following:

```scala
catch {
  case e: IOException => fail("Exception occurred while opening file: "+e)
}
```
Remove FIXME and the inclusion of <iostream>.
whitespace police! (sorry)
spaces before and after function arguments...
Only `$newname`'s place can be changed, `$filename` and `$disposition` must remain the same for backwards compatibility.
@pingvin4eg @Sachs Я тоже в этом деле новичок. После java все совсем по-другому(юнит тесты). Ребята, одна особенность, если добавить юнит тесты к уже написаному коду, то не забудьте подключить все *.m файлы к таргету юнит тестов
![image text](http://i.piccy.info/i7/86129ae50f26b7861dcc7bb1ffe1f6b7/4-48-198/8623282/Zn_mok_ekrana_2012_11_05_o_20_47_20.png)
I agree, is there a header layout file that's featured in all pages? I couldn't figure which file did that, so I just added the meta_tag and related to all files that contained <head>. It would be annoying to maintain in the future.
Its okay I just opened a different pull request for it. My branch was completely fine in github and locally, it was just the pull request that somehow got a little messed up. Thanks though :)
If we do not do this right now, we will never do it. I am not sure that this is the best possible solution. At least a comment with an explanation of the parameter would help here.
I noticed ``buildInstaller.sh`` failed because it was looking for ``BRACKETS_WWW_SRC``. This git checkout changed me back to master and the older version of the file. Once this is all checked in, it works fine though.
Are the clean/dirty states, which are tracked in ORM, important here? That's the main difference between this file and its ORM counterpart.
I did gofmt.  I just did ran gofmt again and it stays the same.  Did you mean above line 41 (it's not clear from the GUI which line you mean).
Sure, I really don't care how it's done. :)

But while we're on the topic, it does seem odd to me because `Data` is read/write, no? So that would allow any code along the stack to modify properties in  there. Thus if you created `GitErrorCode` as a wrapper property, it wouldn't really be readonly, though semantically that's exactly what I'd expect.

All for a little less effort?
:two_hearts: comments like this.
With the improved average picking from the recent PR we then would pass two top-level pick args, picks and ave_picks?
Maybe temporarily remove self._data in __getitem__ before calling self.copy()?
i use it to get the XML data form the BBC RSS, i make request and receive the XML as response
Yeah, I guess perhaps it is not required since it should never fail.
The thinking was that if it happened to unexpectedly failed, we log an warning which would give a ticket which we could fix...

If I guess I could just do a fileTimestamps(f.getAbsolutePath) instead, because if the absolutePath is not found it could just fail all together - this way should be easy to fix.

So what do you think keep it, remove the logging or just do: fileTimestamps(f.getAbsolutePath)?
Why do you populate this with hardcoded values instead of the ones you've been passed?
Are we using path anywhere?
`https` here

Also, with the `#fastcgi_buffer_size 32k;` - maybe it's also not necessary to even mention this?
Maybe move the line from the README into the error output?

```ruby
def print_error_message
  puts "\nERROR: #{@file_name} is not valid JSON. Learn more: cat #{@file_name} | pbcopy; open http://jsonlint.com"
end
```
No, this is still wrong.  It should be `3` in this case.  

An example use case here would be taking a series expansion of some expression and using .coeff() to get the coefficient of each term.  Suppose I have something like `(exp(x + y) + cos(x - y)).series(x)`.  I want to get the coefficient of each term, so I use something like

```py
a = (exp(x + y) + cos(x - y)).series(x, 0, 6)
[a.coeff(x**i) for i in range(6)]
```

But that doesn't work for i = 0, because it doesn't know that that means the constant term.  So, with this fix, I should be able to do

```py
[a.coeff(x, i) for i in range(6)]
```

and get what I want, namely, something like `[exp(y) + cos(y), exp(y) + sin(y), exp(y)/2 - cos(y)/2, exp(y)/6 - sin(y)/6, exp(y)/24 + cos(y)/24, exp(y)/120 + sin(y)/120]`.
Ah, I see. But I need the config in the AMQPBasedMailboxSettings class, because the AMQPChannelPool is created there. Is it possible to pass the config to it? Also, if I understand this correctly, this means, that all the other durable message boxes also just use the default values!
Тут точно брейков внутри нигде не нужно?
Missing javadoc for the `sslConfig`.
Ruby methods usually don't need an explicit return statement, it returns the value of the last statement executed by the method. So you could just say "word" here and you would get the same result.
I can't believe I never thought of this before, but you can you a protocol-less URL to serve a page based on it's current protocol (http or https).  You can read about this feature here: <http://stackoverflow.com/questions/4831741/can-i-change-all-my-http-links-to-just> and in the referenced RFC.  If you change the link to use the protocol-less url I'll gladly merge this change in.  Send me a ping when the URL is updated.
are you sure you want to commit this ?
Place the test in a group "mongodb", then add a profile to the pom which adds the group to the surefire config:

<plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-surefire-plugin</artifactId>
            <configuration>
               <groups>mongodb</groups>
            </configuration>
</plugin>
Sure… but that doesn't stop the compiler complaining about it.
Okay. Then it's okay to leave as is.
I still think there's no difference between tabs or spaces if the project use one of them across its whole codebase. And I don't think there's a problem with tabs in diffs, patches or whatsoever.
Sorry, may have misinterpreted what you wrote. If you mean that the whole function `unpack-feature-vec` should be in thrift, note that it's not unpacking a thrift object, it's unpacking the feature vector, which is filled with thrift objects. There may be a better way to do this but it's not related to the thrift api.
rebundle revision and repository should probably be an input.  Please open a ticket and be mindful when you merge, or just make as an input now.
Can you break these nested loops up into functions for readability?
why do you use streaming features if you in the end only work with a dense feature matrix?
newscoop/themes/publication_* would be future proof
Jo, taky souhlasím. Opravím.
I think in the current implementation your observation is correct. The `Connection` object does not make a lot of sense but using external types that you can't control all over the place is a bad smell. I think our `Connection` should be more a wrapper around the original sequel object. This allows us to inject specific code if we need to (backwards compatibility for example). We can't rely on the sequel object because we have no control over it.

I think applying some kind of Wrapper around the sequel object would give us that benefit and take away to pain.

opinions?
I've moved it next to the btree handle list to clarify.  When the data handle abstraction is done, these lists will be combined.
Fix FQN.
+1, that's also why I think that the check should remain in the loop.

I didn't know about that method, thanks.
Is it possible to define the element type for the array of parameter ``$values`` (using ``array<SomeType>``, or ``SomeType[]``)? Please also check line 358.
Should the type for parameter ``$defaultValue`` not be "string|array|null" instead of "string|array"?
make_model and make_model_year aren't actually characteristics - users should specify make, model, and year individually:

http://impact.brighterplanet.com/automobiles?make=Ford&model=F150+FFV&year=2012

There's also a little special sauce that guesses the right vehicle if you provide fuel:

http://impact.brighterplanet.com/automobiles?make=Ford&model=F150&year=2012&automobile_fuel=gasoline => Ford F150 2012
http://impact.brighterplanet.com/automobiles?make=Ford&model=F150&year=2012&automobile_fuel=ethanol => Ford F150 FFV 2012
This may be a BC break, when I first released the library composer (and therefore it's autoloader) wasn't very popular, so I bundled Pimple under this namespace to avoid clashes.

It should be ok, but we may need to shout about it, or go to a 1.0 release.
can't you just set `modelsToRemove` here directly (avoiding another variable)
There is a typo here
Ref kommentaren over, trenger vi egentlig `/munin` hvis `docroot` settes til `/var/cache/munin/www`?
Please break these up into separate tests (i.e. make a method for each test).
Is there a reason you added this? We removed all of them a while back because doc generators are capable of seeing the strict keyword before function declarations and don't need this tag anymore. It just means we have to maintain the same information in two placed.
This comment can be removed
Should probably be checking the status to see if this needs to be an update or a removal.
@stof this could also be considered to be done in KnpMenu itself
Can you please check the code of Django class-based views and see where `success_url` is used? If you are too lazy to read documentation. Because I have a feeling that you do not understand what `success_url` is and what it does.
`nodes_models`.
So it simply it is not possible. I am checking the JavaScript code from Django and it maps all values with `pluralidx`.
So who does not have Facebook ID?
Hm, why you made also action? (Just curious.)
Hm, probably better is *online_users*.
run only celery

[Tasks]
[2012-09-22 11:13:56,440: WARNING/MainProcess] celery@Crystal has started.
c:\Python27\Scripts\env_piplmesh\lib\site-packages\celery\loaders\default.py:64: NotConfigured: No '
celeryconfig' module found! Please make sure it exists and is available to Python.
  "is available to Python." % (configname, )))
No handlers could be found for logger "multiprocessing"
[2012-09-22 11:13:57,460: ERROR/MainProcess] Consumer: Connection Error: [Errno 10061] No connection
 could be made because the target machine actively refused it. Trying again in 2 seconds...

run all together, this error repeats constantly:
  File "c:\Python27\Scripts\env_piplmesh\lib\site-packages\celery\utils\__init__.py", line 293, in g
et_cls_by_name
    return getattr(module, cls_name)
AttributeError: 'module' object has no attribute 'DjangoLoader'
No handlers could be found for logger "multiprocessing"
raise an error.
See my comment on dashboard.html https://github.com/Full-House-UW/fullhouse/pull/117/files#r2093321.
Sorry, I'm from a german project and thought it would be better with this than without.
wtf:D
Good points all, diff below.
I had thought about that, but wanted to be implicit about what we are doing.  I want ppl to see that and realize something is different about that URL than the others.

The only2  APIs with non standard pathing is compute-volume and nova-compute.  I wanted to call those out, and if we find we are making more exceptions to this rule, rework how we do this with probably a helper method.
After tests, then we'll change it all in one go.
I've come around. I agree with you. Take a look at https://github.com/doctrine/DoctrineModule/pull/95. Your comments would be much appreciated.
good catch. I will update the #229
Loops, that is what the construct is....duh! Well I feel stupid now.
Extra whitespace after `.collapsed`
seems we leak pool_ here
Yeah, I think that would be good (or we could just put the options into RewriteOptions, since 2/3 of the implementations would be using them. Anywho, a TODO for now should be good.
What if size >= 4096?
Almost the same code as an existing code, should be refactored to avoid code duplication.
Indeed, I'll do that.
x would also be better replace by something like params.

not important for now, it's only internal, and params is used for x[:K]          ``params_full`` ?
I think this should be set to whatever it was before: `HighVoltage.root_routes = @old_root_routes_setting`, and set the ivar in the `before(:all)`.
``if not chunk`` means you were disconnected prematurely. Returning data here will make the caller think the recv() finished fine when it did not. In reality this just means we'd fail when trying to deserialize the protobuf instead of earlier, but I still think this is dangerous and misleading in generic pooling code.

Perhaps define:

```python
class RecvError(socket.error):
    """Disconnected while reading from a socket"""
```

And raise that instead of returning data.
This is so deliciously recursive.  :-)
Good point, I forgot about it being in the atmosphere namespace.
What do you think about adding Code and Secret to the current request object and have a multi-style lookup?
Inadvertent whitespace change.
I'm going to go ahead and merge this one.
Please raise a bug either against affiliates or bidpom (whichever is appropriate) so we can resolve this and remove the refresh 'hack'. Also, please reference the bug in the comment.
I have this error when a use your line of code :
undefined method `posts' for #<Refinery::User:0x007fad5233e788>

It's why i used ```ruby Refinery::Blog::Post...```
Could you add the 'has array observers' and 'does not have array observers' cases like below, to be consistent?
Nano-point: it's a bit cleaner to use the ``create`` method on the manager.  Eg ``fp1 = FlatPage.objects.create(...)``
ease of coding
Won't that be part of the "modularization of the code"?
return null to be consistent with the fact that you're returning an element above.
I had it pinned to 2.8.8 for a specific tweak, but I think we should be open ended on the version match here, probably 3.0.* since there have already been some big fixes in 3.0.x, including one for a bug I reported in 3.0.3.

https://github.com/guzzle/guzzle/blob/master/CHANGELOG.md
Missing close bracket here, did you make sure this compiles?
No problem, lilvinz, I think it's great to have Jenkins. A couple growing pains, sure, but that's to be expected. 

(PS: love how you snuck in a "test this please". Is the string configurable? We should have it be "will you kindly"?)
According to http://www.ietf.org/rfc/rfc2045.txt (section 5.1): 
Content-Type should be:
content := "Content-Type" ":" type "/" subtype
                *(";" parameter)
                ; Matching of media type and subtype
                ; is ALWAYS case-insensitive.

which means that type is required, but parameter (charset) is optional. In w3 17.13 stated that default value of Content-Type is text/plain but since we need to specify encoding we have to explicitly set it to text/plain + charset.
“be provider”?
Not sure if i agree with this. Isn't it more confusing that .display_location is not a display version of .location but rather a display version of .location.parent? it seems like this should be called something like "parent" or "region" or something.
И как же так - ты закрываешь System.in
Писать об ошибках надо в System.err
геттеры-сеттеры обязаны быть public. Поэтому можно использовать метод getMethods()
It would be nice to explain a bit more the difference between the two modes here e.g. "In this mode, the application and the data grid are running in the same JVM" (and similar for client-server mode)
All of the other quickstarts include the version number 'JBoss 
Enterprise Application Platform 6', similar to the way they show the 
version for JBoss AS 7. Don't we need it? They only run on version 6. 
They don't run in JBoss Enterprise Platform 5.

On 09/03/2012 10:43 AM, Pete Muir wrote:
>
> In carmart/README.md:
>
> >
> > -0) Obtain JDG distribution with productized Infinispan libraries (library distribution)
> > +* _Library mode_  -  All libraries (JAR files) are bundled with the application and deployed to the JBoss Enterprise Application Platform 6 or JBoss AS 7 server. Cache is configured programatically and runs in the same JVM as the web application.
>
> I think it should be "to JBoss Enterprise Application Platform or 
> JBoss AS 7."
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/infinispan/jdg-quickstart/pull/10/files#r1517260>.
>
why do you do all that to get `doc`? Why not: `let doc = iframeWindow.document`?
You do not need to define kMpq, kMpf.
Please remove this.
yes it should be removed
You have 2 spaces after return.
UnitテストからUnitテスト
Remark: If we don't round the money_donated to the lower end then having 4 tests for the same simple method seems a bit overkill, right? ;-)
We should exit with something other than `0` in these cases — something went wrong.
Unused imports: graph_laplacian in cluster/spectral.py and
pairwise_kernel in manifold/spectal_embedding.py (rbf_kernel is also
imported twice).
@GaelVaroquaux 
The code does also work right for enet_path now. The corresponding test in ``linear_models/tests/test_strong_rules/test_enet_path`` tests that the solution is correct. There is no test to check, that in the first run, the basic strong rule is used and in the following the sequential strong rule. I checked this behaviour by looking at print output. I have yet to come up with a written test. (Maybe be a solid hint that the design is not so good yet)
On pourrait virer ce commentaire non ?
Replaced `assertClass()` with `assertInstanceOf()`.
A generic problem for the whole lot. Fixed further down.
container_ should never be NULL
added an assert
Pourquoi tu fais des méthodes static et pas des méthodes de classe ?
Tes méthodes concernent à chaque fois une étude en particulier, elles n'ont donc pas à être static.
I pulled this in, but please just delete code instead of commenting it out.  Easier to get it out of course control later if needs be
Correct, I'm just avoiding writing the row if we don't have any data for it. Is there a better way to do that?
This doesn't produce any useful information for variable length rows.
Yes I agree, I will change all/others.
I don't believe so, off hand. But I can check in a bit.

Is there a reason that you're opposed to not actually depending on
phantomjs? Seems like you'd want to declare it, but maybe I'm missing why.

Are you expecting that the end user supplies their own version of phantom
so they can choose? If so, that makes sense.

Sent from my iPhone

On Dec 19, 2012, at 9:56, Ken Collins <notifications@github.com> wrote:

In package.json:

> @@ -12,7 +12,8 @@
>    "scripts":       {"test": "cake test"},
>    "dependencies": {
>      "mocha": ">= 1.4.x",
> -    "commander": "~ 1.0.5"
> +    "commander": "~ 1.0.5",
> +    "phantomjs": "~ 0.2.3"

Would this still work if this line was not here?

—
Reply to this email directly or view it on
GitHub<https://github.com/metaskills/mocha-phantomjs/pull/32/files#r2464058>.
Change this to:

```python
@mock.patch('requests.get')
def test_status(self, rget):
```
This algorithm will return true for cases like "... ) ... ( ...". A possible fix would be to check that unmatchedParen never becomes negative.
I though this $this->renderChildModel('content');
Needs alignment fix
Actually there are no sections anymore in the new config concept (same for INI, there they are just a different syntax of nesting).
Having multiple data sources per data set is deprecated, since it causes problems when managing the data. I'd much rather use appropriate types for each metric and add single-DS types for stuff we can't match to an existing type.

There are, of course, exceptions. From a quick glance it looks like we could make an exception for send / receive buffers and add an *io_buffer* type:

```
io_buffer    rx:GAUGE:0:U, tx:GAUGE:0:U
```
Alternatively:

~~~clojure
(if (contains? a-set elem)
  (disj a-set elem)
  (conj a-set elem))
~~~
lowercase use and explicitly
I get the following with `true`:

```ruby
YAML.parse(true).to_ruby
TypeError: can't convert true into String
```
devops maybe, but I think the other ones are much more interesting...
datastore options may come in as an empty string.  Better would be something like:
````ruby
com_opts[:target] = datastore["OUTPUT_TARGET"]
if com_opts[:target].nil? or com_opts[:target].empty?
    com_opts[:target] = ...
end
````
Can you expand on this description a little bit? What's the 'callmenum' about?
I'm going to ask for a osvdb
Ah I see. Fixed.
No, Not really, I do really prefer to have:

```ruby
describe Shoulda::Matchers::ActiveModel::AllowMassAssignmentOfMatcher do
  describe "#description" do
    context "without a role" do
      it "includes the role name" do
      end
    end
  end
end
```

In this case you actually are describing the description method, its not a context of something that alters the output of a method.

The `class, "#method"` syntax is nice but sucks for Shoulda thanks to the long names.
We may be about to drop `?as=u` globally, and, in general, these targets (your `expected` values) are subject to change at any time via the SUMO admin.

I think the important thing to cover is that all the links from in-product (we'd have to find a list) actually go somewhere. _Where_ isn't so important, since it's subject to change and thus pretty fragile, so we should probably just ensure they eventually redirect to a 200, not a 302. In fact, we could do better and assert that the first and only redirect is to a 200, and if it ever redirects twice we need to go update the target.
I'll follow the Context strategy. This console.log is needed. without it, there's no indication of what went wrong with the eventsource. it just ends the connection.
I think it's not needed anymore
Is this check necessary? The Chef `file` provider should already do this check and the associated log.
This will append urls to a string. That's not what you want. Rather directly add it to the backend. Then you also don't need the r1 variable at all.
Shure, fixed.
@jeffmccune Anything else jump out at you?
wouldn't valueExists be a better name?
погоди, а нахера тебе тут tabOrder?
This bug is "Submiting a new review hangs"; not sure the real bug # here.
`transform = hasSSSE3Support() ? &transformSSSE3 : transformX86;`

8x reduction :o)
Should not this function make public? Or there should be a substitute function.
It is foreseen that similar much code appears for any program that is not Phobos as having faced it in std.csv.
as above, let's make this work with ranges of `ubyte`
Wait, how thoriginal code worked then? Before that Appender need not to know the size of T?
Regardless I believe declaration order doesn't matter inside the class, 
it's only inside functions that we have plain old top-down dependence.
Of course it will work. But where is the problem?
This is a corner case in my style guide: it's a static if/else pair guarding a bunch of cases in a single giant switch. 
What I tried to do is avoid indention hell as most of the code in there already stretches past our preciuos 80-colum rule. 
And it would duplicate the code if I'm to split it in two.

To me a single double brace is a lesser evil here then useless overindentiing of the whole.

That all being said I have a huge refactoring in the works that avoids having explicit monstrous switches like that  (and ugly braces ;) ). It will also solve code duplication problems more cleanly.  But by all estimates I won't be able to finish it in time for 2.061.
No, the introduced symbol is a template. (etc)
at least I would split it up into two statements. First create the hash map and then just use it as argument to _isEqualTo_. I find this very hard to understand on a single line. And why not just populate the hash map via put?
Tell me this: why did we open it in a new task in the first place? Presumably that fixed a different bug…
Is this whole if/else necessary? Can't you just have the logic that is in the else run?
wall is intended here? or a accidental change?
Okay - would it be feasibly to just change it back?
Okay, just verified this in rails console: `Chronic::parse("")` returns `nil`. Therefore, the "no end time" case is already handled correctly, and you don't need the following if block:

```ruby
if encounter['end_time'] == ""
  encounter['end_time'] = nil
end
```
well imho it has a cost for the end user in that it can break their caching strategy.
this one is not used (and does not come from the client)
Which has the benefit of not including headers which are not custom properties.
You don't actually use the NS_* constants, so don't require them
Name lenght is very project-centric. We should not enforce this. 

Line lenght is something i despise. The convention should not enforce this rule. It's often a rule of thumb in software development that can show you that a method is doing much more than it should do. Even if you do consider this a rule, this is very project-centric. 

As for line endings, i agree with `\n` being the default.
double quotes -> single quotes.
Does FreeBSD require this? On Linux, it isn't required.
The struct X is just a dummy namespace, so I've used half indentation, but, yes, it is a little confusing. Will fix.
Hi, Oleg
Is there something lost here? 
Or is **else** just redundant?
In other words:
```
if (TransactionSynchronizationManager.isActualTransactionActive()) {
		this.postProcessFilteredMessages(filteredMessages);
}
or something else, but not empty **if** block...
```
From what I see its only used in this class so may be it should not be public, unless you planned for it to be
What if the URI uses https scheme instead of http?
No, no. This issue was just on standby. It worked for me and I worked on things way cooler than string formatting: 
a semi-smart offline data cache system that 
auto updates its cached intervals when new data comes and 
knows which parts of the time series are still missing, and 
updates the plot when new data is received 
(even if it is still waiting for other parts of the requested time series), so 
it will be really easy to break the requested data interval in several parts,
so that the user would not have to wait for 5000 points to transfer which can now be split to
10 requests for 500 points and the graph would just update itself 10 times. 

Now, the query string. ...unless I think of some other super cool, super interesting new feature ;) 


On 29. 09. 12, at 12:45, Mitar <notifications@github.com> wrote:

> In tests/test_project/test_app/static/test_app/js/datastream.js:
> 
> > +                var h, i = 0,
> > +                    j = arr.length;
> > +
> > +                while (i < j) {
> > +                    h = Math.floor((i + j) / 2);
> > +                    if (val > arr[h][0]) {
> > +                        i = h + 1;
> > +                    } else {
> > +                        j = h;
> > +                    }
> > +                }
> > +                return i;
> > +            }
> > +
> > +            if (!collection || !$.isArray(collection) || collection.length === 0) {
> > +                throw new Error('WTF: collection should never be null or empty here.');
> Ehm, no cursing please.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
After a second though, I think the ``getSubClass`` should accept a ``$name`` argument. So you need to add a few more methods :
* ``hasSubClass`` method
* ``hasActiveSubClass`` method
* ``getActiveSubClass`` method
not totally sure. i just used the code that was in a previous part
I can't understand this line.
Condition will be true all time when offset > 0.
This is pretty awesome! :godmode:
I thought about it, but wasn't really trying to make a generic client (otherwise there are a lot of other features I could support as well). We only ever increment by 1, so I'll just fix it if that change is ever needed.
I have that committed in a rebased branch, however your new chapter doesn't build for me with Sphinx 1.1.3. Will try to resolve that later.
```
.. note::

   Use restructured text note perhaps?
```
az 950bishtar nakon
в construct
As mentioned above _UNCHANGED_ is a adjective describing a state whereas the other emum values describe an action. Some suggestions:
*  _KEEP_
*  _KEEP_UNCHANGED_
* _DONT_INTERCEPT_
Update here: when writing more than one notification with the same tag onNewData invoked with error like: 'Items in the Universal inbox must be unique, and testNotification.TheTag is not unique"'.
No need to inherit QAbstractEventDispatcherPrivate as none of its data/functions are used
I agree.  I see lots of references to View.INVISIBLE, View.VISIBLE and View.GONE in the source, but I can't find where they are defined in TiUIView.java. Would you mind pinging me on irc to clarify this, please?

Thanks
Let's rename `q` to `query` so it's a little easier to read the code. We're not tight on space and I'd rather we use the longer name so it's easier to follow
I ran out of steam for the edit.  The last sb is unexpected because it's a new sb, and the point is maybe to use one sb to build with.  CBF[_,_StringBuilder] didn't work for reasons lost to sobriety. Wait, it's that SB is Builder[Char, String], a builder for String; SB is not itself a builder of SB.  You can see this was a useful extended exercise.  In a way.
Yes, it's based on the STK builder, but shouldn't we rename it for our purposes?
This will create issues if the autoincrement value on the role table is lower than the old roleid, and will cause a Primary Key conflict.
After discussion, we decide it's special case and doesn't need a shortcut.
You could also do this in one shebang. :)

`data["rim:permissions"] = {
    "rim:permit" : [ 'read_geolocation', 'run_when_backgrounded', 'access_internet' ]
};`
I'm amazed this works. Still, remove the extra comma?
Just use toHaveBeenCalledWith as opposed to mostRecetCall
because "GUID" is being used in multiple places, it should be a const string.

`private const string SessionGuidKey = "GUIDKey"
...
Session[SessionGuidKey] = Guid.NewGuid();
...`
Myös lauseke (< 12 age 20) palauttaa booleanin.
I think this is useful to show what `$attribute` is for.