labofsahil/github-event-dataset-2012 huggingface dataset:
Hey Mike,

I was able to put together an initial implementation of breaking out the
middleware support to client and server layers. Please take a look at the
latest commit on the topic branch and let me know your thoughts. Basically,
I refactored middleware.rb into client/server layers and made the Chain
class something that can be instantiated and re-used as opposed to a single
static instance like we currently have.

Commit here:
https://github.com/mperham/sidekiq/compare/a093e29a9a...8bf25385d2

New middleware can easily be added to the client-side with (by default
there is no middleware unless you configure ignore duplicate messages flag):

```ruby
Sidekiq::Client.middleware.register do
  ...
end
```
and to the server-side with:

```ruby
Sidekiq::Processor.middleware.register do
  ...
end
```

Let me know if you think this is a good direction ...

Thanks,
Ryan

On Wed, Feb 8, 2012 at 11:50 AM, Ryan LeCompte <lecompte@gmail.com> wrote:

> Hey Mike,
>
> I have all of these changes already in my local sandbox, I just haven't
> uploaded them to the repo yet. I'll do it later tonight for sure, including
> the deisgn change for client-side middleware.
>
> Thanks!
>
> Ryan
>
>
> On Wed, Feb 8, 2012 at 11:44 AM, Mike Perham <
> reply@reply.github.com
> > wrote:
>
>> A couple of points:
>> 1) It looks like you're still doing set operations, not top-level hash
>> operations.
>> 2) The client shouldn't do any of the MD5 work if ignore_duplicate_jobs?
>> is false.
>> 3) We'll need to refactor this into client-side middleware.  If you want
>> to take a stab at the design and implementation, feel free.  I'll try to
>> find some time over the next few days to work on it.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/mperham/sidekiq/commit/a093e29a9a26288591ee9d3033101f5f1593575f#commitcomment-946634
>>
>
>
Почему число Long? Это чем то вызвано? Где возможно старайся использовать long он занимает на много меньше места так как это примитив.
It's best to keep tool-related files like this out of version control, since they are specific to your computer. You can do that using an [ignore file](http://help.github.com/ignore-files/).
You call this a diff? Serioiusly, man, what is this?
Isn't this basically if/else? Because if you don't use SignLink, you have to use the original...
It was just experiment, if it draws the finger. Waving is a good idea, but at first I rather finish the other classes ;)
The reason for all the higher case to lower case with $R/$C/$N is because in-game it would show with a capital as well. For example if your character is a paladin and the text would be $R, it'd say "Paladin" instead of "paladin".
How hard would it be to replace this commit_list with a priority queue? There are parts of git that experience O(n^2) behavior inserting into the commit list. The worst offender was hacked around by fce87ae (Fix quadratic performance in rewrite_one., 2008-07-12), but I've had to fix a few others. E.g., ea5f220 (fetch: avoid repeated commits in mark_complete, 2011-05-19), which was triggered by large numbers of refs (like we have in our network repos). But even with the hack in fce87ae, I think each insertion is O(width of graph), where the width is the number of simultaneous lines of development.

I wrote a priority queue implementation and did a test patch to fix the same problem as ea5f220. It works, but we didn't end up applying it because the commit_list data structure is so embedded in the git code, and ripping it out would involve a lot of rewriting. Since libgit2 is starting from scratch, it might be a good time to see if we can use a more sensible data structure.
Well, it's specified to have 32 pools (that's the reason for the 100-millisecond reseed interval), but you're right that someone could add another one. With the new seed-length calculation, that doesn't matter.

I'm not opposed to using DIGEST-LENGTH. I've changed to a hardcoded (digest-length :sha256); I hardcoded it because this whole thing assumes a 16-byte cypher and 32-byte key.  We'll need to wait until there are 32-byte cyphers with 64-byte keys to worry about a future Fortuna^2...
@nimbupani want to update to remove Opera Mobile from the non-supported list?
комменты могут только создаваться и просматриваться, соответственно это надо ограничить и в роутах (прописать какие урлы будут доступны)
"If a movie's first layer is named snapshots, it'll be a flipbook" -> why not name the layer flipbook as well, just to cut down on the lingo?
It's primarily created to improve project wlan slovenia (http://wlan-si.net/)
Is portal which will provide information about events, bars, restaurants, museums, newspapers and other media, e-shops ...
You can find more info here https://common.tnode.com/trac/piplmesh/
Nope :)

Will commit a fix
Thank you for the problem report.

I have two questions for you:

1. The [documentation](http://www.gnu.org/software/tar/manual/html_section/exclude.html) states that `--exclude-vcs` will cause tar to ignore `.gitignore` files.  Is that true?  If so, that would be a problem since that is a versioned file in the repository that should show up in the diff.
2. Did you confirm that `gnutar` supports the `--exclude-vcs` option?  `gnutar` was added specifically because a MacOS user ran into problems.  Unfortunately, I don't see this option documented on the [Mac OS X man page for `gnutar`](https://developer.apple.com/library/mac/#documentation/Darwin/Reference/ManPages/man1/gnutar.1.html).

Thanks,
Tim
FWIW, I've run proxy.ganesha.nfsd on this branch - worked just
the same as it was with your 'next' branch.
I'm not an expert, but I guess that this line is quite important. In this case, if the ProjectMeasure class does not reload information about its column, I guess that the field will not be accessible on Ruby side if there's a call like "project_measure.committer'. @simonbrandhof, WDYT?
do we want to show this? we not okay with 404'ing on stuff that isn't ready?
thx..
Can you elaborate on this a bit? I have tw setting and like how it works.
Not sure if you are targeting also Windows, but in order to support Unicode file names on Windows you will need to have a special case here to pass the file name as `wchar_t*` instead of encoding it to `char*`. See e.g.

https://github.com/lalinsky/acoustid-fingerprinter/blob/master/tagreader.cpp#L227
This should not need to be done.  The check here is done on purpose for verifying the wiki account has the SMF member ID.  This attempts to prevent any duplicate name sharing that may occur from the name correction we have to do for characters MediaWiki doesn't support and SMF does (and vice versa).

If this is failing, then when we initially created the user, it didn't set the smf_member_id in their options.  We force/retain the smf_member_id on all options updates by making it a hidden forced setting.
Pretty curious as to why Vagrant needs its own gem environment, feels like a step towards Vagrant is becoming everything + the kitchen sink? 

Surely it would be easier to encourage users to make use of Bundler?

Cheers,
Chris
Isn't the throw keyword missing here  ?
Free C/C++ courses, hooray!
Да, я знаю. Но пока надо же как-то этим делом пользоваться :)
dies ist eine supergute änderung.
:heart:

btw, I think it's a good idea to include both [jruby modes (1.8 and 1.9)](https://github.com/tenderlove/nokogiri/blob/master/.travis.yml#L8-10).
For me, works well..

Missing define tooltips for each icon.
+1 I think this would be a good addition
Mike, sorry I wasn't able to pull this as you don't have it in your 0.9-devel branch. Can you merge this into your fork's 0.9-devel branch and send another pull request that includes just this? I want to attribute this one properly to you as well.
With my version no.  If it can I don't know how that support would look, but am leaving the door open for future support.
Make this translation friendly, such as:
You have the following number of characters left: (this then makes it so the translators translate the full string and not two separate halves.
Also use the xlt() function.
My editor is using 4 spaces for a tab but, I will double check that line and see what the deal is.
Hi,

I just added a bug fix from the main branch to our fork, so you're ok.

Paul


On Sun, Jan 8, 2012 at 1:14 PM, Eduardo Scoz <
reply@reply.github.com
> wrote:

> Hi @prnewman what was this bug? How can you reproduce it? I would like to
> fix it in the main branch if it's an issue. Thanks!
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/zipmark/QuickDialog/commit/793c124f181a6932299c37e32552d42e329f7b62#commitcomment-847812
>
。。。有最优先集火目标不表示你就能杀得到他
Why bother? To be clean, simply.
Hi Jim:
I think it's better to use this link
http://www.liferay.com/web/juan.fernandez/blog/-/blogs/extending-an-assetrendererfactory
Thanks!
Juan
is this branch ready for testing somewhere so i can verify your bugfix?
Ъм защо не промени директно заявката с ORDER BY created DESC ?
lol yeah thanks. Definitely run.bat
I didn't groom it yet. I'll branch it today and look where things need to
be.

* We should get all files in a bunch, yes. This however eliminates most of
the roundtrips with payload. It can crash with a timeout, still. This is
70% of the work and I'll see if I have time to bullet-proof it right now.

* The md5 implementation I am using is in the python-cloudfiles from
rackspace. It could change, but that's the best notice we'll get. I don't
know any better ways of futureproofing without extra effort. Custom
metadata would work, but the current hash just works. And, the etag comes
from the hash. The property name is just funny.

I'll throw you a line to review my branch.
On Jan 31, 2012 4:20 AM, "Paul Oswald" <
reply@reply.github.com>
wrote:

> I was just about to implement this when I saw your version. Couple of
> things:
>
> * The comment `# we will have to update it, grab the object` should be
> below the `with` statement
> * Does this actually work to prevent a request going out? Doesn't getting
> a file's etag require a round trip to the server? We already have the
> file's hash in the `cloudfile_info_list` no? Wouldn't it be faster to use
> that?
> * Etags are opaque identifiers so it may be fragile to assume that it is
> an md5 hash. The server could update those to be dates, sha1 or whatever.
> Better to use the hash sent to us in the metadata.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ferrix/django-cumulus/commit/3682344a8a950f39a40340ce47ad376405860735#commitcomment-916676
>
This should be "before_filter :setup_sub".
would suggest also stating that map size is limited to 640x640, so you can't use it for large full-screen maps, only for small ones like this
Very nice, I apologize for the confusing commits. I probably should have just left those in after I added them.
FYI, I prefer FESTAssert's API these days.
jo ich findes einfach hammerst frech was manche leute so abziehen
This is a really welcome contribution! Especially the new diagrams. However when I run it locally I have some small issues:

- HTML samples appears with &lt instead of <. 
- A lot of warning about too short underline for title but I'm not sure this is a real issue.
- I have definition lists ends without a blank line; unexpected unindent warnings

and so on.

Do you have the same issues or is that maybe a configuration issue on my side?
Not sure why the file permissions changed, but I'll change them back.  Some files (.v and .ucf, for instance, do not need to be executable, but will change them back for consistency).

As I said before the .xise and .gise files are automatically generated by Coregen every time an .xco file is imported into a project.  Again, will revert for consistency.  I would argue that only the .xco files should be checked in to git in the coregen directory.  After additional thought, I've decided that having 2 separate coregen directories will cause more problems than it solves.
Should you add a courtesy reference to https://github.com/jordanbyron/mission_of_mercy/blob/master/lib/tasks/setup.rake? ^_^
if you ever have to do this, you're violating the $naming convention
<= 5?
Great work!

Is this a final release or is it still WIP?
т.к из-за данной валидации при сохдании альбома и добавление картинки, не проиходило сохренение. и в лога была ошибка  - Images album can't be blank. Удаление валидации позволило исправить это. а в video  я забыл ее просто удалить. сейчас исправлю.
It's going to have to change to properly support shelling out too.
@tompatros you might want to also make the constructors and some methods global as well, without that it wouldn't be possible to instantiate or do much with the class from other code.
Is not PinyinIME used for entering your pin?
The ADD_COMBAT_EFFECT is an interesting idea.  You definitely want to move the get_effects function outside of a specific talent and into the Actor class (or the class/interface/Combat.lua mix-in) so that multiple talents can call it.  Additionally, your comment saying there are other cases (on miss, always, etc) that should be considered is spot on.  The easiest way to do this would be to have a separate table for each case, so a combat.on_hit, combat.on_miss, and combat.on_attempt tables.  If you are finished coding on it for the day and want me to I can go ahead and merge our forks together.
Well, actually it only happens with PCLN because photons don't pass through PBCN. But I've applied the fix to PBCN as well, just in case that behaviour is ever changed.
This loop should be in the "which" utility function. If `program` is a string, it should look for just that, if it's something else, loop over it like here.
mdl is not a pointer
It's possible that we also need to use the new smd.c code and all new smd related files, i.e. smd_nmea.c.
Ok Bootz, I will have a look, 'ause in my server I have same script and I want to check the different.
If you don't like it here. Don't let the door slap you on the ass when you leave. Your ignorant comment was removed.
There is Location.reset_counters (https://github.com/rails/rails/blob/d9ebc76d70a122544452189f0cb93d3854f2043f/activerecord/lib/active_record/counter_cache.rb#L17), but it's probably not what you want here. Maybe it'd be better to try and avoid needing to do this clearing in the 1st place. Are there duplicates or something? We might need a find_or_create_ (http://edgeguides.rubyonrails.org/active_record_querying.html#find-or-build-a-new-object) but IIRC we had some weird issues with this.
thats why not always, DoCast is like forced no just like "IfCan" :)
Actually, this commit :https://github.com/simone201/neak-kernel-sgs2/commit/de8a812c6d36600d6b0c585c68f4ad082ad4a1f9
is the one that broke SIO. You should only revert that commit. The other one is fine (as it's in Siyah and RedPill without problems).
Makes sense. I'll see about merging it into `next` for the 0.5.1 release. I want 0.5.1 to have as little API changes as possible and just address stability (lockdown of the API and thorough testing/docs) and bugs, but since this is sugar, I don't think there will be a problem including it in next.
@ahodesuka Nah, you did a much better job.
Da eliminare!
ACK'd, I'm on it.
thanks a lot, I'll make note no more non-ruby-ism seep in
It is a SCM best practice not to leave commented out code that was once committed.
Please remove those lines.
Проверил, try/catch не нужен. Лиса просто возвращает undefined.
Where's the Like button for this commit? :-)
Block comment for what this is for.
Does this really print what you want it to? Maybe .toString() would be better?
I agree, I understand that why you ask we to code the Schema Result by self.
The libra is an entirely different wireless chipset. It isn't present on the P500.
The only reason LG had it enabled was because it's a lazy way to get the wireless private extensions (WEXT_PRIV) built into the network stack.
Pros:
        It enables someone to have more control on how their code is displayed. You may like tabs 4 spaces wide, and I may like it 3. By using tabs for the initial indent, we get an abstraction to be able to configure this. 

    Cons:
        A programmer has to be more conscious of what they're doing to determine whether they should be tabbing, or spacing. Jeff Atwood believes it combines all the complexity and pitfalls of both approaches.
        In practice, haven't found the necessary attentiveness for this being present by default. 

    Relevant articles:
        http://www.codinghorror.com/blog/2009/04/death-to-the-space-infidels.html
        http://blogs.msdn.com/b/cyrusn/archive/2004/09/14/229474.aspx
Problem? I don't see no stinkin' problem.
ah I see. what about this:

```java
class StackMobModelQuery<T extends StackMobModel> {
  public StackMobModelQuery(Class<T> cls) {...}
}
```
You get the compile time type safety (and remove the necessity to downcast) while also following the convention.
maybe hacky but better than nothing
Ok, I'll re-verify this part; I thought of it as odd myself. If you're 
correct we'll have a new refactoring request in JIRA to remove some 
AuxiliaryArchiveAppenders from a few containers.
On 05-03-2012 16:17, Aslak Knutsen wrote:
> Not sure about this part. The Container does not need to package the Enrichers specially, the Enrichers do that them selves. The Container only need to provide the dependency to the artifact so it's on ClassPath.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/VineetReynolds/arquillian.github.com/commit/e47c5870086e8a4da57acd52d8c4696d657eac57#commitcomment-1042511
If the type of object is known, consider using type-hinting on the argument.
Let's remove '(I think, maybe we can check/discuss this...)' - if we find out otherwise, we'll change the documentation
Use an 2012-06-27in the form `yyyy-mm-dd` and write out author names.
These should be documented as sub-parameters and not marked-up with HTML, YUIDoc does this.

```javascript
/**
Method description...

@method simulateGesture
@param {Object} [options] Optional config used to define the event behavior.
  @param {Array} [options.point] Indicates the [x, y] coordinates where the tap should be simulated.
**/
```

You can see a great example of this here:
https://github.com/yui/yui3/blob/master/src/app/js/app-base.js#L307
This should not be in code
Rewrite to be a one-pass operation
Alright so if the "v" is not supposed to be used here, name it "_" as per convention.
remove ` == true`
this is going to be problematic.  lots of sites will already have cards of these names.  broken migrations are huge headaches.

Plus, these aren't settings, they are settings groups.  if you go to their card, what will you see? 

I really think this should be all code based for now.
s/not/no/
Looks good. So I am guessing the intention is that if 2 distributor configs are passed and one of them is invalid, entire repo creation fails?
That makes sense. I wasn't cognisant of the escape vs unescaped paths.
I would think we don't need plot.  I don't think it does nesting.  basically lew created it before we learned the "&" syntax for map.
has to, or it will double render, this is not just style
Could addAsServiceProvider(Extension.class, SystemPropertyExtension.class)  be used instead?
This hack should probably be moved into the EnumerateDevices function instead and insert it at the front.
nevermind.. the upgrade is in this pull too.
Indeed. In the original code, the File Item is constructed only with the filename in that case ?!
I'll just copy-paste to keep the filiation.
Yeah, and if you amplify the video stream by 60 dB the guisounds get attenuated by 60 dB.
Any reason why you store the sort order as a string instead of just the value of the SortBy enum? You have to convert it to the string when storing it and back from a string when reading it.
or `j-ESSEOWENS`. Because the function name is `_quick_runner()`.
Can schemas contained characters that need to be escaped?
this Triple does deserve a name
I'd drop the "Note that" from this sentence.
Please don't add trailing whitespace. Empty lines hsould remain really empty
wouldn't `if (cb) cb(err);` also work?
`assign` shouldn't be used for objects under ARC. This should be `unsafe_unretained` instead.
It's not `instancetype` because an `NSNumber *` won't be returned from this method if invoked against `NSNumber` (for example).
@jwilling I've done as you requested, using `!= nil`. :mailbox_with_mail:
`unsigned int` please.
File cacheDir = new File(System.getProperty("java.io.tmpdir"), "pdnative");
fs.open can take a string like "0666"
We clearly need some AFNI users to voice their opinion here. AFNI defaults to BRIK/HEAD file pairs which we don;t even handle properly for copying.
I have done the rest (with the exception of adding that check for Python 2.4, which I am unsure where to add right now, it seems it was always missing). Probably I am just not seeing it, but I don't know how to simplify this well. Putting the shape setting separately would hardly make it better.
Const добавить можно
опустить ниже
выше был using namespace qReal::versioning
Suggestions?  You disagree with approach or turning whitelist_attributes on?
Indeed. I'll fix it.
My apologies, that was a typo in the expectation, I altered it now to:

```ruby
Code.new(:letters => [ "z", "d" ]).valid? #=> false
```
Since this is the only place ```retrieve_variable``` is called, is it safe to say we can omit your ```raise``` line and let the ```ArgumentError``` be called after this method returns?
4.0 is still master. Is this issue present on 3-2-stable as well? If so we will need the CHANGELOG entry.
Yes, we need to detect whether the response was a redirect and provide an informative error message.
You can use `options.fetch(:validations, true)` here.
Got it, I'm setting AC::Parameters config directly in https://github.com/rails/rails/pull/7251/files#L4R23, so this isn't really required here, right?
I'm always torn about pinging gems. I've removed one or two in my edits, previously. I think it's best not to show too much favoritism towards any particular gem in the guides.
yes, that looks much better
I agree def Numpy.
preppend the header?

```
Examples
========
```
perhaps you know that you can have a nested list comprehension:

```
type(part)([type(li)([l[i] for i in li]) for li in part])
```
TODO here
On 08.07.2012 21:10, Aaron Meurer wrote:
>>       if not expr.has(C.TrigonometricFunction, C.HyperbolicFunction):
>>           return expr
>>
>> +    groebner = opts.pop('groebner', False)
>
> This is what confused me.
>

Ups, that shouldn't be here, obviously. Removed.
Object is already nullable.
couldn't we use the .class instead? I though that they added an alternative to the string literral for every "Name" methods
Would it be possible to labe // When a employ proxy and use a brief explanation
他のとこも間違ってたかもなんですが、correct_user?使わないとまずい気がします

https://github.com/ToQoz/UITalk/blob/develop/app/controllers/application_controller.rb#L24
as you can see from the code, these are equivalent. the advantage is that you can easily swap between let and let_before.
matteColor
i must have missed that whitespace
dunno, but this code is going, I have a another version :D
word missing: "consiste à ____ le dossier"
You should unref() the async.
I like how the limitations of msvc have made you really conservative. B'vo :-)
That's just feng shui.
What is this last URL pattern used for?  Can't see where 'activation' is coming from.
This should also be done via the data provider interface, probably.
Vendor files should not be artificially manipulated, though.
This line should be deleted probably?
It comes before.
github botched my escaped angle bracket. Point being, what comes out of htmlspecialchars is not necessarily a valid xml tag name.
HTML entity appended could be moved into template probably, I'm not sure about that.
Consider making 500 a class constant.
From the manual:

> A E_WARNING level error will be generated on failure.

It also returns false. Should I use @ to suppress the warning or use the warning instead of the echo above?
Add an empty line please.
This *is* #1082?
So "avatar driver's template name" might be good, ok?
Doc block?
That seems ok.

"Setting up the container" simply means instantiating a mock one with an array of stuff it contains.
id 也一样， #home_main.container
ibid `this.findOne( _slug: slug, next )`
Other edge cases:
-  calculates radians for radians as a string
-  calculates radians for radians as a number
@basecode just told me you are changing stuff. Please don’t feel forced to do this. I just wanted to advertise the services of my good friend `reduce` ;-)
The crash happens because there's no IConfigurable with id='inadyn' (id needs to be 'inadyn' on line 15)
CompositeLog
remove unneeded (global!!) variable ```patentAge```
CONSTANT_NAME should be all caps
为什么有个空格？
Here you register this optimization to run by default. We do not want that. What about using the tag "gpu_async_transfer" instead of 'fast_run' and 'gpu'? I think it will work correctly. Then you can enable it with the theano flags optimizer_including='gpu_async_transfer' or with mode.including('gpu_async_transfer').
It would be better to check against basic.NotConstantError, which is more precise. Eventually, all code using get_constant_value should move away from TypeError.
Was this behavior specified by ajgent? I think several of us commonly expect C-c to exit. Also, the sun.misc sighandling code isn't present in all versions of openJDK; at least last time we tried to use it, we ran into portability problems.  

~insert "real computer" rant here~
space between {
note here that prepending or appending "add-on"s to inputs requires that there is not spacing between the span and the input otherwise there becomes space between the two...
Import the package
I think that the string should be prefixed by 'r' (raaw string), so as the backslashes are not interpreted as special sequences.
For consistency with the rest of this documentation, and because we're talking specifically about the interfaces, I think we should go with `{@code Iterable}` and `{@code Collection}`. Or is there a compelling reason not to?
There is a mix of tabs and spaces here
It would be cleaner to use "".format()
To be clear, what I meant before is that the current templates would probably work well, or be easy to adapt to mobile. I haven't actually checked this.
should this also be done when adding an organizer, since currently we do not know when someone got promoted to organizer?
Change to force as per the discussion in the other git repo
Wurde wohl aus dem Install-Addon kopiert, dort sind die Plugins "core" und "packages" System-Plugins.. ;)
Macht hier wohl keinen Sinn.
should this method have assert in the name? As-is it looks like it should return a boolean.
nit: {@code AndroidManifest.xml}
i'd just exit early here too with a `return`
Should we continue to prefix all our standard preferences documents with "_flat," or perhaps we should simply remove all the old hierarchical ones. We could keep a particular document around to test that hierarchical preferences still work within the system (for backwards compatibility). But I think it will be confusing to have two versions of every user's preferences.
Why do we use `@` instead of `this`? Cause its clear once you know whats going on.
`self` is unused -- can remove
I didn't see you encoding the path for unsafe characters like '(', ')', or space character in _getUrlList. If you're not going to show encoded urls in code hints, then at least you have to encode it before insertion.  You also need to decode query before passing it to _getUrlList so that it can match to items in code hint list.
I like the idea of having either a registered Command or a simple callback. Requiring a Command feels heavy and Eclipse-y.
This definition should be moved into the module. Can you try a shim like this:

```
window.FileError = window.FileError || {
    ...
};
```
Ah, good catch. I'll fix that.
I took a look at this, and I think -4px works better for the various cases we care about.
The `_self.doc.getValue()` is the last know contents to the worker. If the file is changed after that, asynchronous events are sent to the worker with updates. Eventually, the worker will get the new contents and the analysis will re-trigger. And I don't think using the document string in a key would cause a performance problem; at worst, the runtime will have to do string comparison with two big strings. We use that string all the time in e.g. the parser, where it also lives in memory for a while and more expensive operations than string comparison are performed. The approach might cause a memory problem if it sticks around for too long, but I think that risk is mitigated with the new cache cleanup in place.
Wow, I wasn't aware of that option. Thanks for letting me know!
I updated the commit. Could you take another look?
Typo, should say "but only on Unix-like. I'll convert copy to symlink.
This class can be removed now right?
QObject* parent = 0?
For grammatical purposes, “waiting for” should match with “fading out” at the end of the sentence.
there's extra space after `wrapper`
I don't think you need this check? `hidden` won't appear in the class list twice if you call `add('hidden')` twice, right?
`( [` -> `([`
Do we need these browser-prefixes? Should we have more or none?
indentation be ridiculous
See https://github.com/mozilla/butter/pull/1198/files#L1R75
YES. Thanks for noting that -- fixed.

---
Ryan Pitts
@ryanpitts
http://www.ryanpitts.com


On Wednesday, October 3, 2012 at 1:32 AM, Andrew Hayward wrote:

> In media/js/listfilter.js:
> > var filterVal = $(this).val(); > if (filterVal) { > + // hide the list container to avoid potential repaints > + $(filteredList).css('display','none');  
> Given that filteredList is already jQuery-aware, there's really no need to run it through $() every time like this. filteredList.css should just work. (See also: filteredList.find.)
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/mozilla/source/pull/67/files#r1747603).  
>  
>  
>
I like this. It will help on our test servers to show errors to devs immediately.
Line 583 in FileDownloader.py could also be changed to:
while retries == 0 or count != retries:
This needs to be on the same line as the if-statement just for the sake of the .coveragerc :)
This no longer applies I guess since you added a new param but whatever
This looks like a copied javadoc from above ^
If I'm reading this right, whenever a new client runs `shell:wait`, *all* clients will get a state message. That's probably not desirable (and another reason to create a `WorkerStreamer` instance per client).
I don't know. I wrote this line automatically... I'll correct it :).
Formy
缩进有问题的
fixed in 9ec3e0e810e9c3b1cc494441dc87abd2e30551ea
Remove `@params`
Yes you are. Hubs are evaluated once per app domain.
Use the html5 |hidden| property instead and revert the logic.
Sure.  Can't hurt.
Can you move this to the `earth_orientation` module as a new `earth_eccentricity` function?  In the next version I think we'll want to convert these to using the SOFA or equivalent functions, so having them all in one place is a good idea.
直接把这个叫做g()啊。。。我认为这个是json endpoint的代码，是非常上层的代码啊，出现在Graph.php里面好奇怪啊。

我原来以为g()是个对graph()方法的封装，处理掉exception用的呢。。。 

这些代码放这里我觉得不合适。 宁可有个JsonEndpoint的类，放里面
@laanwj What do you say? Is the general idea for that reset button a good one and what about the detach thing?
This sounds less technical ... I'm going to update that string, have to think a little more how exactly though :). Thanks for your input.
Yes, my point was that just checking for PR_SET_NAME should probably suffice?
True, I'll fix that and the omission in View\View.
Why you need this comment here?
typo on description
Type? missing 's'
Wrm is dit weg?
Should these functions be exported?
Your notes disappeared. Don't know why. Changed back to `github.user`
I tried to rewrite the docstring to make  it easier. For some reason it doesn't format %R? nicely in my ipython console but %%R? does. In the line case, it seems blanklines are removed? Is there some special syntax I should use?
Not really. There's a `util.py` in the mozorg app, but this one feels more like it should stay in the firefox app. I'd say just create a `utils.py` in the firefox app and throw it in there.
ah, yes. makes sense
Do you do the `loop.first`/`loop.last` thing so as to not have an empty `<ul></ul>` if there are no topics?
it was a workaround used in the runapp.js packaged inside b2g-desktop,
and apparently we don't need it because we wait b2g to be ready before 
send a runApp command :-)

so I'm very happy to remove this not needed workaround :-D
I can't see immediately how, since all callers of checkRotation() are synchronized. And yes, with that rational the volatile on doingRotation is unnecessary. Making checkRotation()/doRotation() synchronized would make the assumptions here clear and would not add noticeable overhead since acquiring a owned lock is dirt cheap.
factory :presentation_two is only used in one test. I'd suggest that you create it in that test by overriding values of presentation. 

presentation_two = FactoryGirl.create(:presentation, :presentation_date => Date.today, :name => "Presentation Two',  :team => ....)

I'd also give this a more meaningful name.
Will add the template as you said.
Why do you need a text here? Or what do you mean exactly? I would assume that you can use Elastica_Query::toArray() and add it to the array.
and public methods should be declared before private ones
I know. For gods sake, it's just for consistency.
`{@inheritdoc}` would be entirely correct.
Please add the comment to FormTypeGuesserInterface and use {@inheritdoc} in all implementing classes.
Doesn't this make HttpFoundation a required component for Routing? Would need to adjust composer.json.

Also I'm not sure this whole approach is good. The only good thing is, it's BC.
The problem I see is that the `Request` attributes are ignored in `matchRequest` and instead the RequestContext is used for matching.
So if Request != RequestContext the matching is not as expected. To solve this we would need to override the RequestContext in matchRequest.
But that's also strange, as the RequestContext of the constructor would only be used for `match` but not `matchRequest`.
So it doesn't work consistenly both ways.

It might be time to get rid of RequestContext at all. And use Request everywhere. But that's not BC.
Or I think I have a better solution that is also BC:
Adjust UrlMatcherInterface so that the param of `match` can be a string, a RequestContext or a Request.
And the UrlMatcher can handle all three possibilities.
This has been removed, it was part of the previous iteration. Thanks!
I've renamed back to hostnamePattern and made the call to setHostnamePattern unconditional in addCollection
The interaction with the ACL interfaces needs to be improved anyway, but changing the identity inside the identity is not a good idea. 

If it means that we need to remove the convenience constructor, then that's what we need to do.
Idem for Basque: the default shortening of the week days should stay in lowercase. (view Finnish comment by @bleadof )
You're right, I should modify the controller. Currently, if you do not pass any parameters, it returns ALL photos. I'll update that now.
In this case we already have an object that does just that... the Invitation model :) just about done with the refactor.
Do not modify that line.
You shouldn't need this at all in oiiotool.  Use the ImageBuf interface for reading and writing images.
Also, the rest of oiiotool works almost exclusively in floating point, these probably should as well, even if they have to "bin" results.
Heu, fait chier de devoir installer MySQL en local.
Et dommage de rendre public la BDD de Geekweavers.
These methods break any existing impls outside the AS codebase. Can this be deferred to AS 8?

Hmm, I guess not. :(
"other props then" -> "props other than"
Questo file.... a cosa server ?
Se è per appunti, è meglio metterlo come file di testo e basta in doc
add geotagging code in this loop
Why mousedown instead of click like everywhere else?
In this case you only need to change for:
MessageManager.getMessages(ThreadUI.renderMessages,null,null, function() {
 window.history.back();
});
Could u explain this in a bit more details pls.
two spaces. `gjslint` your code :)
```javascript
if (settings && this.reservedSettings.bluetooth) {
    settings.getLock().set({'bluetooth.enabled': true});
}
```

It is to say, **turn on** bluetooth status iff the status of the reserved value is true.
Otherwise do nothing.

Same as `ril.data`.
while ((item = queue.shift())) {
}

(gjslint will complain and so will js strict option (not same as "use strict"))
Scroll management in order to avoid 'fake' clicks in the app.
if it's always empty string then you don't need to specify it.
Got it! Will be included in my next PR ;)
@davidflanagan I added a THUMBNAIL property here and used it for assigning <code>metadata[THUMBNAIL]</code>, just want to make it the same with other properties.
You don't really need to prefix the property of your TimeManager object with moz.
Nit: space between WPA and (TKIP/AES) please
sorry but I though that I implemented what he said to me. What is the problem here? thanks
filed my version as pull request #93, cheers!
Magic? Why we dont use -1 or 0. If it is real id we need to assign an id from any part of that way
@filipewl, replaced to class. 959c7fbbef
And do we ~really~ need to use a jQuery iterable function?
Weird, not sure how this works, given that ```updated?``` appears to be set by ```updated_by_last_action```:

From resource.rb in chef gem:
```
    def updated_by_last_action(true_or_false)
      @updated ||= true_or_false
      @updated_by_last_action = true_or_false
    end

    def updated?
      updated
    end
```

There could be some LWRP magic making it work?  Should be easy to tell with a reporter.  The only other idea I have would be to call ```run``` on each resources in the provider, and then check the sub-resource's ```updated_by_last_action?```
I've read through the code, but not yet understood how things fit together so please pardon my question:

Should we be using only names to identify mappers? You may have multiple ways to connect two models together, sometimes using different PK/FKs, and sometimes using the same PK/FK, but different conditions. In those cases would we always be using the same mapper? (this isn't a rhetorical question, I don't know the answer, but I thought it might be important to bring up)
funny indentation? :squirrel:
If we can't start the app, you should log why we couldn't do it.
Follow proper Python naming conventions.
We should probably restrict presentation time to a format (like done [here](https://github.com/Freeseer/freeseer/blob/experimental/src/freeseer/frontend/cli/freeseer_talk_parser.py#L205)). What do you think @zxiiro, open a ticket?
variable should be camelCase.
can this be made into a full path call, "@get('error.content')" ?
It seems like these presenters could be much simpler if they followed a pattern more like https://github.com/alphagov/frontend/blob/master/app/presenters/search_result.rb#L20 ?
Concise!  Absolute agree, thanks.
setFrameSize or setDesignResolutionSize must be called to set proper window size. The same thing was necessary before this commit.
Oops, I missed that. Can you please fix that @Taluu
Oh I see, probably because fileutils is included in the tests but not in the application. Will do that now.
Yes, changing both would be better.
For the last time, can you please at least view the diff before sending pull requests?
Please keep using JSession::checkToken(). JRequest is deprecated.
Well, you have branching with a ternary operator and which can be understood only by users familiar with the reflexivity features of ES5. I prefer an `if...then...` in which all users are guaranteed to understand at least the simple case.

You know, simplicity :)
This is hard to read: can you use a newline with braces?
You may use the Propel exception by adding the Full Qualified Class Name here:

    @expectedException \Propel\...\InvalidArgumentException
Is 'unknown' the best return value if the file doesn't exist? It seems like it might be better to return `nil`.
This probably belongs only in the upstart provider - I don't thing anyone uses generic SysV style scripts in /etc/init, right?
使用getString
Not required here.
so if I get how code works, this can happen only string suffix is ```-bus``` so it indicates that there is just two elements.
I also see that you second time call splitstring on same interace. so I think it can be moved to own variable like ```interface parts```
And third thing that makes me curious is what is 2 and 1 here? I think there should be definitevelly at least constants and better some description ( in perfect case near such constants. So e.g.

```
// Old interfaces looks like <...>-<device kind>-<device name>
integer OLD_INTERFACE_BUS = 1;
integer OLD_INTERFACE_NAME = 2;
```
I cannot remember how constants looks like in ycp, so probably it can be done better way. and again you should place such definition near its usage.
s/Zend_Date/DateTime/
Ah, i was looking for how to do that!
Right now length can end up being 0 for gametypes with mini_rounds.  That needs to be fixed before per minute stats get added so as not to throw a divide by zero error.
Yeah that's awesome. I'd close this pull request now if you can as it's now a duplicate.
This can be simplified with:
@inventory_items = create_list(:inventory_item, 3)
works in conjunction with most of the in_time_zone/to_time_in_current_zone functions. Specifying the default time-zone to PST should help align with user's expectations of time (Calcentral probably revolves around Berkeley time), due-dates, and in general, time-zone aware datetime fields (such as google calendar, canvas tasks)
Can you just check the DQL? In that case you don't have to create the database table. This is enough to verify the bug is fixed. The actual execution should not be part of this test.
you should not ignore the XSD.
if i output the children before the save all looks well:
string(26) "/functional/parent/child-i"
string(26) "/functional/parent/child-h"
string(26) "/functional/parent/child-g"
string(26) "/functional/parent/child-f"
string(26) "/functional/parent/child-j"
Nevermind, just looked below and noticed that both paths can have a new and existing record. So why the 2 options here? What am I missing?
One space too much before the "=>" ?
Changed to "good cache performance"
I wonder if you cannot store the p object on options._p?
I set it to needs work and linked this comment.
Yeap I'll file a ticket to update the test's
Might as well put incopyrightholder data here too, to show that license is given priority over copyright holder if nameofwork does not exist.
May I add the email from your commit here?
Same thing here about moving this below the nil check.
Don't undersell yourself! You also made this work at all, since the file is named jquery_ujs, and not rails. :)
Is GStreamer feeding blocking? If so, you may want to force this source and the one above to have a dedicated clock..
明示的にしたほうが良いですね・・・
/@[¥S]+[¥s]*/ とします。
Kind of the same thing is missing here (SCRIPT_VERSION), but it's also missing in lots of syco istallation scripts.
You right. I didn't know. Thanks!
This whole thing would be a good candidate possibly to cache the whole outcome of. 
The cache_key for it could suffixed by if you're logged in or not. 
Also, to invalidate the cache all you'd need to do is to wipe the cache_key(s) on any Event save signal.
This is clearly broken, but I don't recall right now how we handle this. Does "Jr." go into the first name? If so, how is that formatted?
Ah, I see: no covariance in Java-land. Carry on.
request a channel from the connection actor, then handle the setup of the channel by sending the returned channel to self, then depending on the result, send back the ActorRef or the failure.  It ensures that the channel is started and ready to process messages when the ActorRef is handed back to the sender.  That minimizes the need to have a channel callback listener in the client, though you may still want to have one in case the channel bounces later.
see http://stackoverflow.com/questions/6381425/should-the-id-of-elements-be-made-global-variables-and/6381766#6381766

seems like a bad idea
Should this be weak?
Because I'm a baka
I didn't add the simulator as a requirement because it gets installed with Xcode and the iOS SDK.  I did update the start of the paragraph to note the use of the simulator.
END_NODE should be computed at run time based on the contents of the path dictionary, in the (unlikely) case that * already exists in the path dictionary
Merge this into a single ``@Path("/person/{personId}")`` annotation and I think that's it.
Note the lack of a text property in this object. This story basically has no branching outcomes based on skills and just immediately gives out results. Instead of coming up with a unique structure for this, I just associated the reward with the none skills result and left out the text property. If we didn't want to make text optional, we could also do this structure as:

```json
"skills": {
    "none": {
        "text": "",
        "rewards": [...]
    }
}
```
you need to update `get_category` here too :)
I'll remove it  because is not used :D
I would consider using commons.io ExceptionUtils.getFullStackTrace here; it will walk through nested exceptions rather than just printing the outermost one.  Sometimes this can be really useful.

http://commons.apache.org/lang/api-2.4/org/apache/commons/lang/exception/ExceptionUtils.html#getFullStackTrace(java.lang.Throwable)
I like the 3 individual migrations idea.

However, for the separate transactions: isn't there a possibility that that would leave them in a state where they couldn't run puppetdb at all?  If we explode all the way back to their original database state, then they can revert to the previous puppetdb jar and should be able to run.  But if we leave them half-way migrated, then it's possible that neither the old nor the new puppetdb package/jar that they have will actually be able to run against their db.  Right?
Ah nice, I could've sworn I was getting the row key back when doing paged queries.
I'm not able to reproduce this, so this for loop gets a bit simpler.
Please use the new RestUtil.encodeURIComponent for this.
this should have a check for err first.
Missing semi-colon. Also, there still doesn't seem to be a need for `lib` to be returned in the readFile callback..
TestAPI should be higher up.
It also looks like this is all repeated below. Any chance that this can be consolidated?
Oh, yes, I do now
マイナスにしたー
should only save if the value changes
You have missed the $Id$ line from the header from this file. It should be part of the header of every file.
Should this be done by default? Does username and password need to be required anymore?
Ah, I wasn't aware of that exchange. I'm still wary of having it as part of the Pig pull request.
А где, кстати, проверка входящих данных? Мне, пожалуйста, поменять 1000% элементов.
Пересмотрите пример в лекции, конструкция `if (self)` там использована неспроста.
dak180 wrote : 
> the only problem is that you can get certain compile time issues that only show up under one architecture

I intend to compile for all architectures at least twice a month, so compile time issues will inevitably be spotted.
On the other side, I compile Development many times a day... So the balance seems clear to me.
I solved this problem in my pull request (https://github.com/adobe/brackets-shell/pull/64) in a slightly different way, so we need to resolve the best place to get this data from.
TODO: このへんは decorator に追い出したい
Can you please add spaces around the block return type: `createSubscribable:^ RACDisposable * (id<RACSubscriber> subscriber) {`
consider regexp as a naming convention
@kohsuke actually had the brilliant idea to invert control and move the templates themselves into the runtime gem. I think that makes a whole lot of sense. I'll open a ticket for it though as I don't see it as a reason to hold up this merge.
这里说不需要实现`<, >, <=, >=, =, ==`的理由好像放在`+ - * /`上面也一样成立？
:static确实没用吧? 还是你故意加的?
maybe this could be a logger.warning ?
I'd rather rely on the pick_types method and keep the FIFF internals away from here. We might have at some point a data abstraction that goes beyond fif