labofsahil/github-event-dataset-2012 huggingface dataset:
As I mentioned in bugzilla I don't think `target` is a good property name here, it's used for many different things in different contexts, most commonly as a an event target. Also commonly to refer to a target element. In this case it has totally different meaning that may be confusing. I can also imagine that in a future we may use `target` property limit mods for tabs of the specific window for example.

I have suggested `
+1 to @lloyd's comment. `.expires` or `.expiry` would be more immediately comprehensible.
Would you mind flipping the declaration with foStream so you can group the foStream.init with its declaration?
"classic"?
That seems reasonable. The code below that uses this constant also filters out hidden files. If we went to a whitelist then we wouldn't need to do that as well. The biggest problem is that the way we figure out the parser for a file, if one isn't found for a given file we warn the user.

If we went to just depending on having a parser that accepts the file and don't get rid of things like the backup files, then we would need to get rid of that warning (which isn't the end of the world).

If we were to do just a straight whitelist, what do you think we would put in it? It seems like a whitelist would also be platform specific in the case of executables for external facts.
The "now" time is 1:30, how is this within the range of 23:00 - 1:00?
This block in not necessary.
I guess you based this on the `flatten` implementation but there it's just for recursion :-)
This (extra) line should be removed.
will investigate, thx
That makes sense to me; having it later in the chain usually makes no sense.
That code still present in xmlFileNameToRst

https://github.com/ezimuel/zf2/blob/87b1f20c83edaff7ed04053ad59160611877bc82/bin/doc2rst.php#L414
no semi-column :)
We tried to search for that but we couldn't find anything that returns True/False for Group.
Well, I'd say that we make it optional at least then, and turned off by
default. Also, can you separate out the exec definitions and the resource
chaining? Teh syntax used here can be hard to read.

Walter

On Sat, Aug 25, 2012 at 8:03 AM, Eugene Kirpichov
<notifications@github.com>wrote:

> In manifests/agent/config.pp:
>
> > +  }->
> > +  exec {"change master_to":
> > +    command => "/usr/bin/mysql -u root < /etc/mysql/master_info",
> > +    unless => "/usr/bin/test -e /etc/mysql/master_info && [ -e /etc/mysql/replication.done ]",
> > +  }->
> > +  exec {"slave_start":
> > +    command => "/usr/bin/mysql -u root -NBe \"SLAVE START\"",
> > +    unless => "/usr/bin/test -e /etc/mysql/master_info && [ -e /etc/mysql/replication.done ]",
> > +  }->
> > +  exec { "test_greplication":
> > +    command => "/usr/bin/touch /etc/mysql/replication.done",
> > +    unless => "/usr/bin/mysql -NBe 'SHOW SLAVE STATUS\\G'|grep 'Waiting for master to send event'"
> > +  }->
> > +  file { '/etc/mysql/replication.done':
> > +    ensure => present,
> > +  }
>
> Do you mean they're dangerous if the database is currently being actively
> used, or in some other sense?
>
> Well, these execs complete the MMM setup; if we have to complete it
> manually, this kinda defeats the purpose of using Puppet to me :) What do
> you think?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Tribily/puppet-mmm/pull/2/files#r1458777>.
>
>



-- 
Walter Heck

--
Check out my startup: Puppet training and consulting @
http://www.olindata.com
Follow @olindata on Twitter and/or 'Like' our Facebook page at
http://www.facebook.com/olindata
Any way you can use addEventListener instead of using inline event binders?
This looks weird to me. Shouldn't it be the time of the latest item ?
@samiluukkonen Uudet ominaisuudet kommentoimatta. Ny ei tajuu mitä tässä on ajateltu
auditcare login intercept needs to be put before default django login stuff to hijack it.
Because items() in Py2 returns a list, in Py3 an iterator. In many circumstances this difference is negligible, but sometimes [it crashes](http://parenchym.com/pymblog/copying-data-structures-quirks.html). Explicitly converting the return value of items() to a list is a safeguard (e.g. 2to3 does this always).
Oh yes, well spotted.
This was not intended, my search and replace s/_env/env/ was too hungry!
I'll fix that, thanks.

On 30 October 2012 09:39, Simon <notifications@github.com> wrote:

> In pelican/generators.py:
>
> >
> >              if logging.getLevelName(logger.getEffectiveLevel()) == "DEBUG":
> > -                self.assets_env.debug = True
> > +                self.assetsenv.debug = True
>
> I don't know why you changed assets_env to assetsenv but doing this you
> must also change lines 164/165 in __init__.py which use assets_env
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/getpelican/pelican/pull/223/files#r1976101>.
>
>
How about up above where you define the $?
add this:

if found:
    warning("Only easybuild.tools.environment.set should be used for setting environment variables.")
Shouldn't this be indented one more space to be inside the parenthesis?
These will always `return True` because `is_element_present` does not throw an exception.
This variable doesn't exist
Instead of burying them maybe we should throw a helpful error message. Thoughts?
no space in-between `function` and `()`
You should set this to 'test-id' and use it throughout the test
nit: Empty line before the license block
I think there may be a problem with the matching if the location being matched includes 'http://'

For example, the location (the URL) being examined could be in any of the following forms:

fanfiction.net
http://fanfiction.net
www.fanfiction.net
http://www.fanfiction.net
www.adultfanfiction.net
adultfanfiction.net

"http://fanfiction.net" gives a false negative - it should be matched but won't. I wrote a spec to help and submitted as pull request to your branch. (The spec is failing on this one URL, to demonstrate the point.) Thanks for attacking this issue!
@kellyredding - this doesn't match with the `apply` above
Hmmm, it's not on a button, it’s a piece of text below the button (perhaps we can take it away completely).  The button itself reads "Format Response"

-----Original Message-----
From: Ryan Brainard [mailto:reply@reply.github.com] 
Sent: Thursday, May 03, 2012 3:52 PM
To: Mahanthi Gangadhar
Subject: Re: [axiom] JIT Changes (#4)

> @@ -63,7 +65,8 @@ label.saml.idp.SAMLResponse=Base 64 Encoded SAML 
> Response  label.saml.idp.target=Target  
> label.saml.idp.RelayState=Relay State  
> label.saml.idp.RelayStateOrStartURL=Start URL / Relay State
> -
> +label.saml.idp.FormattedResponse=A more readable SAML response

This is on a button, so should be in the form of a verb phrase (e.g. Format SAML Response)

---
Reply to this email directly or view it on GitHub:
https://github.com/ryanbrainard/axiom/pull/4/files#r770341
The only way a timeout should occur is if `res.end()` is not called within a preset amount of time.  This means that there can only be one timeout error.  This deferred error can only happen once at most.  IMHO, this behavior is desired.

Say an error occurs (i.e. `next(err)` is called)... the error handler can decide whether or not to call `next()` or do `res.send(500);` or whatever.  Maybe the error handler prints the message to stderr, or maybe an email is sent.  If the error handler decides to call `res.send()`, then technically, no timeout has happened.  So, there is only one error reported to the client.  Similarly, only one timeout error can happen.
this breaks when the association has an underscore
e.g. config_templates becomes configtemplates
Please change `directories` to `directory`
Avoid `_` in URLs. It's better to use `-`.
@waymirec -- can you test this with POP?  Tweak it to work w/ POP?
Why you don't change the version in 2.x.y and explain that x and y vary? In this way the documentation should start to seem obsolete only when Cordova 3.x.y will be out.
Did you know that you don't have to give controls a name property unless you're going to manipulate them in the code? I don't see any references to this.$.fittableColumns2 anywhere in the code, so it should probably be anonymous.
Then I prefer *Parts as I often think of a property as a field and that would be confusing ;)
As for Add & Mul
can you please add a doc comment on $validate?
I decided on the same thing after working with it, and sleeping on it, for a little while.
Need to figure out better naming. Making everything extensible is also making things... complicated
all right.
Probably doesn't affect too much, but this should be `mem.split(':', 1)` in case there's a ":" in the API key.
Yeah, I agree with the application.js 

If you can add the deprecation code that'd be awesome.
Should we take this opportunity to move to a helper method or PORO (Plain Old Ruby Object) or should we continue using content_for?
Change to a puts
blank line alert
I guess most of the install.js scripts will need this.
Obviously the developer will have to provided the CQL statement to actually create a proper CF.
I'll add it in.
Is there any use in making this available as a function in oae-util? Also, we can probably use underscore's _.map function for this.
Trailing space, I fixed this.
Yeah, only problem is that I just realized that one is **not** the ``debugTarget`` actor, it's the ``ScalaJdiEventDispatcher`` actor. Sorry for the oversight.

However, I've a proposal that could help readibility. What about changing it to ``companion``, or ``companionActor``.
Possily a helper category to extract the colors could be nice.

Maybe: [UIColor extractComponentsR:(CGFloat *)r  G:(CGFloat *)g...]

Just keep in mind that this won't always work because there are different color spaces.  It's not a concern here since you control the colors.
а відносні урли не можна робити?
The debugger gem works on ruby 1.8 as well!
in 3x you can also now do `req.accepts(['json', 'html'])` which returns the acceptable type (if any) which is probably more what you're looking for, this variant will not return a random value even with */*, that's up to the user to default
Ooops :-/ I'll fix it..
short class name now (but I used FQCN for a long time though).
I changed my Netbeans source formatting settings to match Symfony's and unfortunately it doesn't have formatting options for arrays like this.
Going to be honest, I didn't even pay attention to what parenComplete did until just now.  I assumed it was some sort of parenthesis matching.

I've just been trying to get completions working with emacs, and the quickest path to that was what I added here.  I like the idea of matching clang's completion syntax since that should make integration of existing tools a bit easier.  (I modified a version for emacs pretty trivially and I know there are similar tools for vim.)  But it's your project.  Let me know what you want to do with it.
Хм. Да, следовало наверное поставить проверку на выходе, что элемент таки отличен от исходного.
Благодарю за замечание.
Could you please use *_path() helpers over url_for here? Thanks! See also: #820. Looks good otherwise!
new var here?
We should pass the JS callback here then ``return true;`` to skip the standard callback handling.
Can you write this in a single line?
whoops. I think that's leftover from when I was thinking of adding other filters like user=, which I obvs. didn't get around to.
No need to wrap this in a dictionary if we're only passing a single object through.
What does `initialPageSize` do exactly? Looks like it effectively makes the page size be `45` instead of `40`...
@Haacked 

>All for a little less effort?

It's not about avoiding implementing the deserialization. Although that's a nice side benefit :) 

You can peek at the following comments for a better context

 - https://github.com/libgit2/libgit2sharp/pull/183#issuecomment-6372508
 - https://github.com/libgit2/libgit2sharp/pull/183#issuecomment-6374035
 - https://github.com/libgit2/libgit2sharp/pull/183#issuecomment-6400232
 - https://github.com/libgit2/libgit2sharp/pull/183#issuecomment-6404110
Not a huge fan of `user.inbox.messages.create` but not sure what I'd do to improve it.
you should use the ``:method:`` syntax so that it links to the API doc
I'm not that familiar with Sinon, but shouldn't this be inside a beforeEach ? Does it remove the spy after each test ?
А если я не хочу шарить?
А даже если хочешь - все равно придется отдельно шарить. Сначала заливать,
а потом менять на нем пермишены. Так что пофигу.
Код должен быть читабельным. Читабельность подразумевает говорящие имена
переменных, прежде всего.
Проверь, чо.
А это разве может не выполняться?
filter er sat til ```None``` ved første GET
There are two usage strings in the same file? Changing both this and the one in the top of the file is going to be a hassle.
Can we deal with this by actually sending a complete event rather than mocking @complete?
OK for now  -- but this (just like the wiki api docs generator it's based on) is super-fragile.  It assumes that `allValuesFrom` constraints will only be used in one of two very specific ways in the ontology.  I think it will break, e.g. if I directly assert in the ontology that a person's `foaf:gender` needs to be "male" or "female".
I'm sure you'll recover somehow. :)
I just meant --zoom and --fit-width/page_width for each page.


On Thu, Dec 13, 2012 at 8:17 PM, Simanas <notifications@github.com> wrote:

> In src/HTMLRenderer/general.cc:
>
> > +    if(zoom_factors.empty())
> > +    {
> > +        zoom = 1.0;
> > +    }
> > +    else
> > +    {
> > +        zoom = *min_element(zoom_factors.begin(), zoom_factors.end());
> > +    }
> > +
> > +    text_scale_factor1 = max<double>(zoom, param->font_size_multiplier);
> > +    text_scale_factor2 = zoom / text_scale_factor1;
> > +}
> > +
> > +double HTMLRenderer::text_zoom_factor (int page_number){
> > +
> > +	if(is_positive(param->fit_every) && !is_positive(param->zoom)){
>
> You are wrong. Currently the smallest of --zoom,
> --fit-width/document_width and --fit-height/document_width is used to get
> text_scale_factors for every page.
>
> In my modification if you remove param->zoom check, then for every page
> the smallest of --zoom, --fit-width/page_width and --fit-height/page_width
> will be used, which would be a stupid behavior. :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/coolwanglu/pdf2htmlEX/pull/57/files#r2406508>.
>
>
Maybe we should consider stuffing the id into the context as well?
if you add the taskmanager_queue name to the rdl conf where is it used?
I hold to the fact this code is wrong here. This isn't the JSON that goes to the guest, though (which would be handled by the guest api module), this is the JSON that came in from the user as part of the prepare call.

As for not importing the extensions in the instance models, I don't think we have a choice. The MySQL user stuff is in the prepare call. If we really wanted to isolate all of the MySQL stuff to the extension directory we'd be unable since the instance create requires knowledge of users and databases, which is an extension. So we may need to think a bit more on the instance call before we can truly isolate it.
Yes, if I want consistency in the types stored in the cache
Style: object literal
I agree. I'm just saying that I think we're past idiomatic Objective-C by now. :P

It would be a little unconventional to do the error = `nil` thing, but it'd be clear and, I think, easier to use.
ArrayListを返すため、メソッド名は"getFlopCards"のような複数形にしてください。
ArrayListを返すため、メソッド名は"getFieldCards"のような複数形にしてください。
Ok, great.
I'd throw `*request*` and the associated middleware into its own namespace. Either way, you can still check `*request*` in `redirect`. It would look something like this:

```clojure
(defn redirect
  ([url] (redirect url :permanent *request*))
  ([url type] (redirect url type *request*))
  ([url type request] (dostuff)))
```
`regar[d]less` is misspelled
even though LoginManager isn't used on Windows all platforms still need to load this config, so use platform-independent paths
sorry, stupid mistake :(
Got your point. My mistake.
I don't feel strongly one way or the other about this.   The balance function should run fast enough that I doubt waiting on the lock during open could be detected, there's just not that much computational work going on there.
rename this to `port-in-use?` - that's more idiomatic clojure :)
This code did not parse for me. Apparently, there is an error somewhere around this line:

Unexpected token ';'
Are you sure the class "Zend\ServiceManager\ServiceLocatorAwareInterface" actually exists, or did you maybe forget to add a USE statement?
``function getRenderErrors()`` does not seem to conform to the naming convention (``^(?:is|has|should|may|supports)``).
The change button only seems to turn the switch off. Do you see this? I can't seem to get KS to run for android. Can you check if it's broken there too?
Könnte man auch mit dem StatusService handeln. Einfach hier Exception werfen und dann im Status service Error Message senden. Haben wir bei anderen Resourcen auch so gemacht.
Please make this 80 chars
Can you file a bug to validate this in pub too? Early errors are happy errors.
Please correct me if I am wrong, but PHPUnit can do whatever Mockery can do as well. I have already converted the MigrationTest.php to PHPUnit mocking going to commit later.
do these hard-coded values pose a problem in some browsers?
Small typo here: "concatenate".

Maybe it is useful to include the task's names here (`watch` and `concat`).
I've received this change from another pull request, I'm restoring it to previous version.

Eng. Gabriele Pongelli
Yeah it's a bit confusing but I think it really is identical to the first code block in the mergeNodes and what I put  is based on the comment for the first code block. THat's why I said there were other oddities, because the code in mergeNode is identical to that block.  
Also it is specifically an update not an add and the method only deals with attributes of an element not  the element. The addNode method adds the element itself.

I think that whole block of methods could use some love but at minimum the docblock shouldn't be a copy and paste from another method.
There is a risk of memory leak here. What happens if android decides to recreate the fragment? You are going to have a reference to the old fragment. I am not sure, but it is possible.
This is probably not your changelog
Why all these changes? Are the imports broken?
I wasn't sure how to drive this fix through a test for this branch, but I'm assuming it's the same mistake.
Spaces. Comments.
what about rasing 404 ??
This is what i get in JS Console:
Napaka: this.animate is not a function
Izvorna datoteka: http://127.0.0.1:8000/static/piplmesh/jquery/jquery.js
Vrstica: 8427
OK. As you want then.
Try to use [django-mongogeneric](https://github.com/jschrewe/django-mongogeneric).
user.facebook_token is a string field, so obviously it cannot be a tuple :-D
Also, access_token is a tuple, so key is in access_token[0]. I don't know what is a purpose of token_secret, and as I didn't use it at all, i will just set access_token (twitter_token) to token_key.
Ok, now I'm reading this document: https://docs.djangoproject.com/en/dev/topics/class-based-views/ :P
We do not have `else` on the same line as `}`. Why this change?
What is this additional space here?
OK, after some testing I discovered why my Firefox crashes. Because new and news event handlers are registered. It seems jQuery does not bind handlers only once.
That would work equally fine. Could you create a new pull request? I'll merge it :)
Reverted back to _true_
amateur mistake
fix log message: this is not a wireless controller
fixed in 00d28a28
the MockUser in BIDPOM also uses 123donetest_.
really, i don't really care what the user name is, we almost never see it =).
Typo: `_callback_data`
You get a brandnew `ResourceInfo` object on updates, right? Was wondering if that caching could be too agressive, but I guess not.
Personally, I prefer the `!` syntax to `== nil`. Another reason for a style guide.
Things like this can be vectorized to avoid these loops. E.g., with abbreviated names, but you'll probably want to keep yours.

```python
nobs = self.nobs
dsp = (1 + np.dot(eta1, data)).T
dspp = dsp.copy()
idx = dsp < 1./nobs
not_idx = ~idx
dsp[idx] *= 2. * nobs - (nobs) ** 2
dsp[not_idx] = 1./dsp[not_idx]
dspp[idx] = -nobs ** 2
dspp[not_idx] = -dspp[not_idx] ** -2
root_prime = np.sqrt(-1 * dspp)
JJ = root_prime * self.est_vect
yy = dsp / root_prime
```

Two questions. 

Why are you using row vectors and then transposing? Does it make sense just to have everything has column vectors so you're not having to transpose or reshape all the time?

I assume you're going to want to use these elsewhere. Should log_star, log_star_prime, and log_star_prime_prime just be functions instead of methods?
Not that I have seen

I got dots for missing values, and python raised an exception
I would rather do :
GIT ?= git
HG ?= hg
Do not import objects directly. Just modules (`from django.contrib.auth import models as auth_models`).
this is a copy-paste artifact, removing the assertion.
Yeah, that's better.  I'll fix.
Replicating seems redundant.  So I rephrased it a bit for the first version of the comment.
It might be worth saying explicitly something about how it's unrealistically large, but was chosen so the effect of varying PSF ellipticity would be visually clear in the output image.
HOSTNAME is a standard SoftwareProcessEntity sensor so i think we should leave it alone.  even if nginx is responding to a different primary domain that is not necessarily its hostname.
I'd remove the _redirect when not found_ logic. The redirects are fine if you want to have a complex path name system but, in my opinion, to enforce a locale in the path have no real usefulness.

I'd do something like

```ruby
CanaryConcrete::Application.routes.draw do

  scope ":locale", locale: /#{I18n.available_locales.join('|')}/ do

    resources :groups 
    resources :pages

    devise_for :users
    match "admin/groups" => "admin#manage_groups", :as => :user_list
    match "admin/groups/:id/edit" => "admin#update", :via => :put, :as => :edit_user_group

    root :to => 'pages#index'

  end

  # Not sure if we can put an extra param, but this will be nicer than to make a redirect from the root
  root :to => 'pages#index', locale: I18n.default_locale
   
end
```
Instead of `.logout`, I'd prefer something consistent with the selector above, like `#browserid-logout`.

Also, there should probably be a space between lines 13 and 14.
I don't like switching to this because it's brittle; if we change how `mock_browserid` works this may have to be updated. Although, admittedly, if `mock_browserid` changes, testing specific arguments passed to `_verify_http_request` is going to be brittle anyway.

Are there issues with adding a parameter to mock_browserid that makes it pass in the mock object?
タイトルだけじゃなくて全部がかわっているように見える。
If `count` doesn't work (as per the comment above), why are you using it here?
is changing this to `refresh` a breaking change?
цей момент можливо зайвий
There won't be an error in the seeking, the output screen will just be garbage. You either need to select based on the video properties, or allow the user to select the safe or unsafe seek. I would argue that safe should be the default. (That's how I implemented it in my screenshot function that I didn't get around to polishing & submitting.)
Please, revert it to be on one-line.
are you planning not to use .webinos then what will be the basepath used by file api. any current directory
Right, it works much better with the latest version. It still is significantly less responsive than with 'mousedown', though, but I agree it looks nicer.
and this line should be an empty line, not no line at all :)
What channel?

-- Amin



On Sat, Mar 3, 2012 at 3:46 PM, Geoffrey Parker <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,118 @@
>
> I'll try to be on irc today if you want to talk about it.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/w7cook/OpenBook/pull/19/files#r515047
>
this looks like it need the `else` for the `<td></td>`
Comment should end w/ full stop :)
This should probably be /obj/item/clothing/suit/forensics
Can you update this to use the default custom post status?
Названия не по стандарту
Закрытие не в finally?
I was ready to change the code right after mentioning that we do not typically use multiple var statements.
But it was curious to know why it is considered to be unreliable :)
This is a good point that I didn't consider. I pretty much copied the code for uploading from https://github.com/mozilla/marketplace-tests/blob/master/pages/desktop/developer_hub/submit_app.py#L181, and that's a test that has been passing for awhile. It all works for me on my local machine, but that doesn't address this concern of yours.  Maybe the remote machine running the browser also has an img.jpg file in the expected location?
@elskwid shouldn't this read `%r|^test/minitest_helper\.rb|` ?
Added TODO below.
just define a var and use that in the INCLUDES= below, so we don't need to c+p the whole include line please
The following section should be formatted as a table?
Maybe it would be better to fail here if we can't parse instead of silently using the current time.
Note that as per the scikit's convention, 'verbose' should accept also an integer, where bigger is more verbosity. That said, most code written with boolean in mind also work with integers.
I think it would be user friendly to output (some of) the new labels in the error message.
On 10/09/2012 07:21, serge-sans-paille wrote:
>
> In pythran/pythonic++/modules/list.h:
>
> > @@ -29,7 +29,8 @@
> >          //TODO: have to raise a valueError
> >          template<class T>
> >              long index(core::list<T> &seq, T& x) {
> > -                return std::find(seq.begin(),seq.end(),x)-seq.begin();
> > +                //return std::find(seq.begin(),seq.end(),x)-seq.begin();
>
> Remove the comment and use correct indentation please
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/serge-sans-paille/pythran/pull/12/files#r1563249>.
>
Indentation seems coherent with the rest of the file....
Okay, then the latest commit should have everything done.
ensure that when a single file is sent in, the output is a single file and not a list.

```
from nipype.utils.filemanip import list_to_filename
...
return list_to_filename(out_file), list_to_filename(par_file)
```
I think the '_' suffix should be reserved for members and not methods, specially not static functions.
Was there a specific intention for the use of the suffix here (also in TiObject)?  If it's because these are private functs, then the prefix could be used instead.
It is private.
@JakeWharton is right, the comment should be moved. If you do it here, I'll take care of other places in the library.
Par exemple, les status d'un enregistrement ou les status d'une databox :
Not really sure what the best thing to do here is...
Ow. Interesting.
should be -qs I think, not -qa. The alignment of the text seems a little out too.
Absolutely! Don't know how that ended up getting the file name. ;)

Changed now to do the same as in DeleteSuperFile.
check.py is complaining that there isn't an extra blank line right here
This approach turns problematic if we later decide to add new keys to the book representation. It would be better to use `assoc`.
From the comments of the documentation: "Both getExtendedStats() and connect() issue notices/warnings if the server is not there. Thus you have to mute both calls."
http://php.net/manual/en/memcache.connect.php#106786
Let's rename this to just `completed_task`. The get part is implied and reminds me of java / C# :flushed:
it's just going to get turned into a bug about printing debug unnecessarily - granted, there's a few other places here that already print things that should be ifdef-guarded, but there's no need to add more
ditto continue
You can create your own dummy java classes (please commit also your java code, so we can verify :)) and then use Rex::Zip::Jar to create the jar when needed. 

There are some browser modules that use Rex::Zip::Jar as java_mixer_sequencer.rb. Another example of Rex::Zip::Jar use can be found on the impl of Msf::Util::EXE.to_jar() (exe.rb).

Also, java browser exploits are good examples about how to add the java code and classes, feel free to ask if you've doubts still.

BTW, it's just my 5 cents, maybe other more experienced developers have something else to say about that :)
This was the bugged line.  The rest are lines that had issues when I wrote the rspec to test the change to this line and made sure there was coverage for all of `add_module_path`.
Should be called `toggleElement`, since it doesn't just hide it.
i would not inject the UoW here .. instead just grab it from the DM when you need it ..
"Sie müssen mindestens achtzehn sein, um dieses reddit ansehen zu können"
i'm looking into removing the arrays now based on another comment. If i can't, i would consider speed more important than looks but if you all would rather see the varargs version, I'll put that in.
Ah, ok, I see.  I missed that the milliseconds were broken out by this point.
Since we intend these values to be floating-point, append a `.0`, e.g., `1.0`.  JavaScript doesn't care, but humans do.
I don't really follow this.  I mean from a technical standpoint I understand the class property on a HTML element can reference multiple classes but I am not sure if it fits naturally here.  The margin value happens to coincide (despite the positioning being different or nested etc) but the class is in theory a style definition for that specific element.  

If I instead did something like class="indentv1 bmarginv1" where both classes are generic then it creates an artificial relationship where indentv1 and bmarginv1 are generic which isn't the case technically since it's only happen stance that the margin values are the same from one element to the other.  If I went this route I run into trouble when I decide I don't want my margin to be 50px anymore, maybe now I want 30px.  Other element types rely on this "generic" class so I have to either update ALL of the elements of type A to use the new 30px class or change ALL of the elements of type B to no longer use that class and use something else instead.

To me, this also would break one of the biggest advantages of using the CSS classes in that I can update the style for a HTML element from the style definition (single place) for that element versus having to go update all the elements that use those class (for example:  adding a new class to be applied to a large number of the same element type).

Lastly, from a size of source aspect I think that would actually bloat the code on any real scale.  If you have 20 of a certain element, the additional overhead of the extra "margin-left" in the CSS class definition would be less than the additional " mymarginclass" that would be on every single HTML element using it.

Thoughts?
Android doesn't have the text property
The indentation got messed up. I wonder if it's because of Dart Editor or tabs vs. spaces.
Space before "(".
agains --> against
How about the following instead?

```ruby
config['domain']   = "#{config['domain']}.myshopify.com" unless config['domain'].include?('.')
```
this shouldn't return text without the property name indicating that. Can you do `details_page.buttons.text` in the test itself?
I believe that it would be more correct to use "and" than "from" here, and "function" would be more correct than "functionality." But personally, I'd probably go with something more like

> DollarToken's only purpose is to be the type used when function signatures require a special type for $(D $). In particular, if a type other than $(D size_t) needs to be used for $(D $), then $(D opDollar) needs to return a special type, and $(D opSlice) needs to have an overload which accepts it. DollarToken is provided to make it so that such ranges don't have to declare their own type for that.
fadeOut could be a parameter too. No ?
I pushed some updates. Unfortunately, I don't think that I changed this particular issue. I just added tests. For me everything is fine in the IDE as well as on the command line (JDK 6 + 7)
Changed to 2.*.
This will throw an error when record_size doesn't exist.
Why is this wrapped?
I'm talking about using index iteration to avoid using the 'in' keyword. Not to avoid the indexOf at the end.
Howcome these lines are commented out?
wrapKewFowWriteSkew might be a better name for this method as it's not serialization that it is doing.
This is JBoss Cache configuration, not Infinispan one. Fixing it in the patch I'm building...
Looks like there's an issue with the 'name' and 'ADD_A_PERSONAL_NOTE_TO_THE_INVITATION' translation.
Same code as on 1888. Can you put this in a separate function?
Who commented it out?
After printing hte OBR for the encounter you should loop over the encounters obs' and print them.  See https://tickets.openmrs.org/browse/HLQRY-38
May be
i'll measure what's faster
Nope, just wondering if we do it now, we won't have to refactor later (or worse, end up with several of these).
Do we really want to add mavenlocal() permanently? I usually add it locally when I need it.

Also, this file is using non-standard leading spaces instead of tabs - this line has tabs. We should either make this use spaces or, preferably, convert the file to use tabs.
Please capitalize the first letter of Git when it is not being used to specify the command.
Is the backslash actually necessary?
Hm. And where do you run `settings.py` with execfile?
Sobra `El`
I'm not sure why GitHub's saying something changed here... all I did was try (unsuccessfully) to get the text background layer to work correctly on Lion.
It would be better if were just be able to copy/paste directly from the JavaScript files. We shouldn't care that much about it being properly prettified.

This would also make it easier to update the documentation.
Well, to me the main point of these tests are to make sure that the overall process doesn't crash.  Hopefully more fine-grained unit tests check that the correct output is generated.
Thanks for the catch; previous debugging statements.  About to remove.
Can this be moved to profiles/modules/codes/fields.py
OK. Then leave it like this, it could fail at some concatenation. But this is really ugly.
Because it can traverse only **modules**. If __init__.py is not in the directory, this is not a Python module. But you have them. Hm. Circular imports?

Anyway, don't use `*`. :-)
instead of using false as default for a string, I would use null
This is something we need to fix in the entire CLI tool. For other commands also we are validating params like this.
Should refer to Java instead of ActionScript (simple copy-paste error), no big deal.
**Error:** Expected "if (...) {\n"; found "if(...){\n"
I agree with Rowan here. We're given a specific list of fields by the user. If any are null, I'd rather explicitly say so.
This should probably not be hardcoded, but rather configurable in some admin panel.
Why all this space?
Should probably redeclare the property in the class continuation as readwrite and set redirectURL using the property accessor.
Yes.  This attribute contains the condition for the first time around the loop - so the counter is always 1.
Doesn't this mean that the counter will always be replaced by one?
Why not make the triggering node a parameter as well? Then we can get both the node and the area.
You do not need a trailing 2
That is where it still lives. We haven't decided what to do, but we\ll probably move it over.
No check for `system` above
indent + spaces
Если корня дерева не существует, то наш узел становится корнем.
We should add a `-*something*` option for consistency. Maybe `-x`?
By indenting the following lines, they show as code.
I think we should avoid passing objects to this method(s). For instance now we made sql script (and all other classes in this hierarchy) code dependent on DBUnit. I would rather pass configuration (or relevant part of it) during construction of relevant object instead. 

Why do we need it btw? To obtain DataTypeFactory class?
Isn't this file already being run from the server side? We should be able to do the comparison right here.
I assume it would rotate without locking?
Better name will be GP_DICTIONARY_PACKAGE_GROUP_UUID = "conceptpublishing.dictionaryPackageGroupUuid"
*confused* why cant you call commands? isn't this what we do?

Kind regards,
Andreas

On Tue, Feb 28, 2012 at 09:57, pgrm
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,121 @@
>> +﻿activemq:browse
>
> First I wanted to call the Help-Command automatically and take also the description and have it as ToolTipText - but since i couldn't call any commands i withdrew the idea and kept it simple for the beginning
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/loom-csharp-visualstudio/pull/9/files#r495019
These are things I ported over from Dropwizard. ResourceURL.resolveRelativeUrl was dropped. This fancier logic popped up here: https://github.com/codahale/dropwizard/pull/216/

There's also a note there as to why Codahale dropped the caching. (tldr: 5 micros for cached, 50 micros for non cached -- so it wasn't performant enough for the complexity of the code)
say => par exemple