labofsahil/github-event-dataset-2012 huggingface dataset:
I like fundamental and agree with mjtamlyn. That said, 

The flowcharts are purposefully in this simplified format for now and I request they stay in this format on this pull request. In other words, I would like it to be addressed in a future pull request. In fact, @jacobian says he has an idea for rendering them, and @idangazit should certainly be given his say. On a side note, I prefer Graphviz, but only out of familiarity.

As for their completeness, while I would like to get them to 100% right now, that is not a small amount of work. I think a better option is to accept this monolithic pull request sooner rather then later, then let the flow charts be handled in a smaller pull request or a series of them. That way they can be more easily audited and will allow more eyes on them, making a deep problem very shallow. :wink:
Ahh. Credit would be nice :-D
Done in 60214bb
Would `assert sites is not None` be better? Or is this meant to catch empty lists as well?
another accidental `when` here and at line 25
Yes, and that's the only change actually needed. Please, make a pull request that is focussed, THEN make a different pull request to deal with size issues.
Are there any performance consequences of using `jQuery.css()` here?
Isn't this something like percentile_rank()?  At least row_asc+row_desc means count.  It's faster to reduce the number of distinct window specification (order by fval asc/desc can be one).
That is, of course, an option, and arguably a good discussion to have. In general, I am not dogmatic about the anatomy of a MADlib module and am fine with moving the intra-iteration (per aggregate) initialization to after reading the first input tuple (or maybe even _k_ input tuples). Conceptually, we would just be giving the initialize method a look-ahead of one row (or _k_ rows, respectively).

On the other hand, there are cases where we need to pass explicit arguments anyways, when some information cannot be deduced with a look-ahead of just constantly many rows (e.g., the some hypothesis tests need count information).
Someone should investigate this and submit a fix if need be.
for the lulz?
...and the for loops.
We use two space indents for html.
must bind to port, i think it still needs root
You can use `Array.prototype.reduce()` to achieve the same result :)

```js
[1, 2, 3].reduce(function(a, b){ return a + b; }) // 6
```
Agreed that it's pretty pointless to return an object you pass in. We'll refactor later.
"locale" doesn't seem to be imported (and I don't believe would work the way you expect; since it's interpreter-wide, locale-settings won't pick up the user's settings)
It wasn't my intention to expose uglify to the users of compact. I suggested keeping it abstract so that the compressor could be swapped out without needing to change the options. What you've done here is fine, but I think adapting the options and removing the reference to uglify except in the compress function would.

I'm not sure if @bengourley has any thoughts on this matter?
This material presumably isn't yet interpreted by anything so would be best not committed for now
Remove all of this logic and just use fluid.set
in maven this is a resource
see this
http://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html
you can also see why other directories are used with a purpose

@dsaff is the junit using cpl.
The purpose of it here is that it is telling to the maven to be packged to the root of JAR. I think the current JAR files have this license there.
Pls correct me if i am wroong.
For safer parallelizing, don't pass back the whole pi.config, construct a new object and just pass back the fields that need updating.
Yes... I was actually thinking of doing `$("*").addClass("vert-resizing")` on resize start and then the removeClass on the resize end. This way, the handle cursor isn't overridden by other rules, and we can take the resizing classes outside and shouldn't be affected by any element changing the cursor style...

I assume that's what you meant in the beginning.. or maybe I'm missing the point?

If this is not entirely satisfactory, maybe we can leave it for now and think it through.
What do you think about sorting this list alphabetically? I think that it makes lists easier to read.
Currently, code hints are filtered to show only items that have 100% of query in hint, so we would first need to change the way hints are filtered for this to be a future goal.
We should wrap this in a doc.batchOperation() call.  In this case, include the setSelection() code within that block too.

Sorry, I should have caught this in the original code review.
Fixed now. I did merge but missed that change though :S
Doesn't seem necessary to skimp on whitespace in this string--might as well make it more legible.
Bear in mind that the fail() case for extension loading is never invoked: if an extension doesn't exist or crashes during init, we just never get a response instead.  So even though this is now attached to `always()`, the result will still never resolve if there's any sort of error.  (I don't think this has any effect on the rest of your patch, but just thought I should point it out for clarity).

For details see here: https://github.com/adobe/brackets/issues/954#issuecomment-6030374
Ditto -- old name referenced by unit test.  And same for previousRule/Range() below.
what does it mean to add `false` as a second argument to the `addEventListener` ?
Wonder if this was just a mistake on my part when I wrote `CaseBlock`. Or it might have been an xmlns thing that behaved differently.
Output buffering seems a bit silly since you can just concatenate strings :)
a few consistency details here:

CSS classes used for styling use '-' and not '_' , underscore is only used in 'js_', so this should be 'js_bars-vertical', however, by convention, CSS class that start with 'js_' should not be used for styling, but only in javascript code, so a consistent class name here would be 'bars-vertical'
Missing class description.
Put in an anonymous namespace.
Shouldn't we expose the `visible` property instead?
I had to change this because "install/bin/mcf_extract" didn't exist.
Perhaps we should try to get rid of the pwd somehow and use "./bla" ?
I would just return `models.CustomUser` (or `models.User` as I would call it) and leave to any possible future implementation to extend the method if wanted.
Document example usage, in same way how it was for gravatar tag.
See below: https://github.com/mozilla/butter/pull/924/files#L1R508
again, might as well stay consistent on the spacing
The above 4 lines could be done in 2
`objectList` is originally an object, or array? If it's an array, you don't need underscore to use `map`.
There's this issue remaining.
I haven't been able to figure out if PDFView.load() executes once, or every time there's a PDF loading.
Sicne PDFView has no init() method, I left it there until someone confirms or gives me a better place.
Public field?
A virer.
we know rLabel == di->zone is true - line 937 guarantees it
Some indentation pains in this file by the looks of it.
Let's keep the alphabetical order :)
definitely a better name, good call
Why are there two of these files?
I would allow scalars as well here. (scalars when added don't do anything to the error, when multiplied they scale the error).
这个函数也用searcher。。。够狠，以后至少每个viewad要多打一次Searcher了
we can make cache and use notify to update cache when data update.
Part of the reason for checking the length of the used preflist against the N-value was to prevent failover to all fallbacks. Pipe requests should only failover to primaries.

The reason for this behavior is demonstrated by KV's map phase: it attempts to lookup an object locally, and if it can't find it, it passes the request on to the next item in the preflist. If the preflist is not kept to primaries-only, then a bucket-key pair that truly does not exist will be passed all the way around the ring before finally failing, which can be quite expensive.

I believe the desired behavior here was to not fail in the case where handoff makes a primary move. Perhaps we could meet in the middle by using only the first N of the elements returned by `riak_core_apl:get_apl/4` as `Preflist`, instead of the whole list?
space=space
Fixed with last commit, compiles again with boost 1.47!
Oh, right. Leftover from an older version. Fixed now.
I thought the default for separator was supposed to be `&raquo;`
ok, triggered an error.
i'm not sure if to tell user the rule should not be solved (actual implementation) or implement a deep investigation to define if class or method does not exist.

your opinion?
This block of code is repeated at least 3 times now, I think it might make more sense to have a separate method to setup the filesystem for each test.
Nope, 10 is the second argument to the parseInt funciton, the 'radix', please refer https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/parseInt
Add a line break between attribution and control structure
Missing space between attribution and control structure
But couldn't we just insert it in the namespace environment?
That's what we want, right?
Default is now 2.0.
the empty value string thing is an implementation detail of ec2.  I don't think we should replicate this here.
These methods need documentation blocks. See [NIAttributedLabel.h](https://github.com/jverkoey/nimbus/blob/master/src/attributedlabel/src/NIAttributedLabel.h) for a good example of documentation.
I'd appreciate {} even for one-line if's :)
of **your** choice
git_index_free(repo_index);
I think this section could be rewritten like this:
```javascript
if (dntEnabledButton) {
    dntEnabledButton.appendChild(msgText);
    if ( !enabled ) {
        $(dntEnabledButton).addClass('insensitive');
    }
} else {
    return enabled;
}
```
URL reversal
Ok will do, I will also squash my commits to make this cleaner.
we don't need a non breakable space here
Why do we need to do this, aren't we using settings_test?
What happens if you try to run the app without setting *lockscreen.enabled* to `false`? It's unfortunate that we have to wait some indeterminate amount of time after setting this setting before running the app. In my experience, it's nearly impossible to set such a timeout correctly, because of the tradeoffs between making it slow enough to work on slow machines while fast enough to seem performant on fast machines.
silly me. I edited after the notification had gone out.
doesnt seem like you really need this variable assignment
No The apps in the app directory do, and the test for http_warmup does
Alright. Will do.
просто кінцевій сутності Payment (по суті окремого бандлу) пофіг чи це платіж за квиток чи за щось інше. тому звязок був односторонній
You should replace `INF` here, too.
No I did mean it - it's my understanding that this is how your escape `%` signs inside `sprintf` - we get a warning when we run the tests without this.
That's what I was thinking! A library should be a library and not try to be anything else! The option handling is a mess anyway, it should be using getopt.
应该是这个“+”出现问题，换成别的定量值就OK。
Removes this #ifdef. This is the reason why it was not compiling on my mac.
Numvber -> Number
If we do not append "None" there will be a gap between the url_list and the tag_list that we don't want.

The "None" tag won't reach the backend as if it's None, the default tag would be added which is instance:host_port.
This can never occur?
I didn't realize you were using Comparators for the search functionality...they are really only meant to sort things (see the docs:  http://docs.oracle.com/javase/7/docs/api/java/util/Comparator.html).  However, if it works, then it's good enough for me!
Non, je dois la supprimer
does this try:except really have to be this huge? Looks like it could catch a lot of false-positives.
Don't see why this can't just be one line.
likewise here, put $q first
where did the text complete go? we need this...
This fails because the file doesn't exist in the 7.1 branch. It's not in the 7.1 branch because 7.1 is still on version 1.3.0.  I suspect this test is pointless in this branch.
pow(2, floor(log2(ma, 2)))  will give you the biggest power of 2 value that fit in to full memory instead of minimum one. If you do this it will still work but you will be always limited to one GPU thread all the time because there is no more memory available for another thread.

A possible alternate solution is to use 
```
ma = pow(2, ceil(log2(mt, 2)))
```
instead of 
```
ma = 1;
while (ma < mt)
    ma <<=1;
```
and you will get same result but I guess it is harder to understand by an average developer.
Too late to make this comment, but - this isn't going to work in the case where the manifest specifies a developer property with a url only. I just confirmed on device this does not work. Will be filing a bug shortly.
Inclide -> Include. Also can you open a bugzilla bug for that and ask it for beeing blocking-basecamp?
Can you remove this code (since it will be fixed by pull request #1537)
Great, I have something like this written already but I never committed it. I'll use your's solution now.
I think you should add isVideo:false to this object, too, just to be explicit.

Sorry to be vague on this. I haven't really worked through the issue of dealing with corrupt or misnamed files in gallery yet... But I think this approach of tagging known-bad files is the way to go.
Please remove that for this version of the patch. If you use WindowManager.launchHomescreen() for now you don't need that. I would like a first patch that add supports for the FTU in application.js with as few modification of the window manager as possible and then open a followup if more things are needed. Thanks!
I have discussed with Eric about the contentType, He said it's very possible that contentType is empty.
Also, I have tested with devices in real world, and the results matched to what Eric said, contentType is empty, even it's a jpeg or mp3 file.
Since contentType is passed by the paired devices via bluetooth,
(we are not able to decide it for currently implementation, gecko won't parse it, but I think it should in the future)
It will be better to handle the formats (filename extension) that we have known now.

Like -
1. for Gallery : .jpg and .png
2. for Music:  .mp3, .ogg, .m4a and .aac

We still can handle the exceptions in every apps, Gallery and Music, maybe more in the future,
if the transferred file is "really" not supported.
we'll leave it to a separate refactor pull request
typeof always returns string, I thought that it's not necessary, but OK, I'm fixing it.
Why do you need to update the UI here?
I don't think this method is necessary on the interface. The only place that uses it is the Testing#submitLocalTopology method, and that can just be gotten rid of.
Odd place for this.
Don't use var when the right side isn't obvious. What does this return now?
I get that as well but where in msbuild do we use the property "KuduReferenceAssemblyDirectory". I guess I need to look at the msbuild code.
Actually, thinking about this some more, I can see now that there needs to be a fallback for the case where `:default` is misconfigured...so falling back to white seems OK.
Even though it is a bit dangers, I would make this a var, so we can change it in a job until we figure out a better what to set this.  If it is a var, we can control it on a per-job basis (at the start of the job).
Yeah we should add that to the checklist
Shouldn't it be called 'keypath' then? It gets confusing later since you do `key.key()` when in reality it may be more descriptive to say `key_path.key()` or `key_reference.key()`.
edited again

>Why not drop the else anyway.

What do you mean?
You should be able to fix my mistakes by the way.
I agree, but this will bring other changes.  Marked as a todo.
What is a tic? I suspect that it stands for ticket, if so it would be more readable to just use the word ticket instead aka: git_tickets = []  If you are using vim then using longer variable names is not a big deal with ctrl-p and ctrl-xl.
getColor() should be used to reset the color.
Might there be a benefit here (I’m thinking mainly in terms of performance, but there might be some semantic difference too) to using a [match-all query](http://www.elasticsearch.org/guide/reference/query-dsl/match-all-query.html) rather than matching on `*:*`? Or do we have a sufficiently small index that we don’t mind?
This is never called.  It also introduces a rather dangerous element to the race condition above -- if a tag is inserted on one master and removed on another, the subsequent use of that tagid will result in a dangling reference.  This is a rare condition, but still a bug.

I don't think any users will face a situation where the number of tags grows too large, so there probably isn't a strong need for this method to exist at all.
Do we really need this crazyness? I mean can't it just handle itself well with one single rfs for the whole driver instance lifecycle?
Thanks for the help.
How about handling this in Serenade itself. If browser is IE < 9 and it the element is a checkbox or a radio and the event is change we could bind it to click transparently. What do you think about this?
in hardware/pinning/yourHardware.m4 add something like this:

ifdef(`conf_BUTTONS_INPUT', `dnl
pin(BTN_UP, PC2, INPUT)
pin(BTN_RIGHT, PC3, INPUT)
pin(BTN_DOWN, PC4, INPUT)
pin(BTN_LEFT, PC5, INPUT)
pin(BTN_ENTER, PD2, INPUT)

#define BTN_NUM 5

#define BTN_CONFIG(_x) \
_x(BTN_UP)\
_x(BTN_DOWN)\
_x(BTN_LEFT)\
_x(BTN_RIGHT)\
_x(BTN_ENTER) 
')dnl
According to HTTP response code docs (eg. http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html):
Response with status 403 should describe the reason why the server refuses to serve the resource. We could do this, but the reason is quite complicated to explain and it's bound to change in the future as the delete feature is improved. As the docs suggest, we can alternatively use 404 without explaining. IMO, both approaches would be fine.
"=" alignment
Should I have put a `return MOD_RES_DENY;` after this?
the same as answer
can't we use the 'windows' module here?
Otherwise `module` should be `requirer`.
I'd prefer feature detection as done earlier:  `if (window.BrowserApp) // fennec`
Please use relative require form.
I didn't mean to add that, but I still don't know the answer.
is this property misnamed?  it's a *url* now right?  not just an origin.
so, this is why I would like us to think of BigTent as a delegated IdP. If you can't reach BigTent, then you fall back to secondary just like we do today. But if you *can* reach BigTent, then providing a path by which a successfully reached IdP re-triggers secondary is, I think, not something we should do. If BigTent is reachable, and Google is down, then users can't log in using google email. I think that's okay.

We have to be very careful not to explode the number of paths for the user, if only for security reasons.

In general, our story for primary-reverting-to-secondary is likely something that will need a bit of work. I don't think we'll be able to predict every case ahead of time, though we can try.
That's better thanks
What i meant was, you don't have to touch on the footer links. You just need to touch on headers. So make another pull request.
This should be refactored to its own method IMHO
Is the name unclear?  Or perhaps just my docs for it?  Seems like there is precedent for this being singular... operating system $PATH, ruby's $LOAD_PATH, etc.
@jeffweiss No we cannot. It is provided by a core package however in Solaris 10, SUNWgtar, so now I've returned a specific error specifying that one should install it. If you think I need to go to greater lengths let me know.
When there are errors during the run such as typos in manifests, `raw_summary['resources']` is nil. I have updated the specs  and code to handle this condition. 

After some testing, I can confirm that we are sending emails even when there are errors which prevent the mertics from being set.
Done: https://github.com/puppetlabs/puppet/pull/903
It seems better to do `self.const_get(class_name) if self.const_defined?(class_name)` rather than rescue NameError.
`nil` ment "no resource found" (which is not an error) and `Puppet::Scope.findresource` also does the same thing. I moved this function to Puppet::DSL::Actions class and it is a private method now (there are few changes in it too).
it "raises a TypeError when passed a non-Exception object"
And specs also allow uppercase letters `[A-F]`
Doesn't sadly :( Check http://travis-ci.org/#!/Ocramius/zf2/jobs/1012000
space after closing )
"à" devrait être "a"
Yes, that's what we do, but no it doesn't rule out GitHub's auto-merging feature.  Pull Requests are raised against `develop`, by virtue of that branch now being the default for the repository; this is what happened with all my pull requests in the last 1-2 weeks.  

A note on the branching strategy, which might make things a bit clearer (or just confuse the issue further!): the `develop` branch moves ahead of `master` with each merged pull request, and will consist only of these pull request merge commits.  When we're ready to ship a production release, `develop` will be merged into `master`, which will be a nice fast-forward merge. We can then optionally tag that release as well, and `develop` will start to move ahead of `master` again with newly-submitted pull requests.
why fake? It seems to be real ContainerBuilder ;)
Support functions for "Emulator-targeted deployment"
JQuery?
I really wish you could like comments on Github.
won't this leak between iterations in the for-loop?
OK. How this sounds to you then:

1) Change `run` to support a global option;

2) We can add `return` support to both scan and run;

After 1) and 2) is done and it is not enough for you to distinguish groups, we can think about an API for groups. Wdyt? Thanks!
Maybe use `|default()` instead of ternary operator ?

```jinja
{% set latitude = field.value.latitude|default( 0 ) %}
```
We might want to nip this `$.each` in the butt too. Just do a normal for loop.
this could return misleading results.

```javascript
typeof(null) === "object"
typeof([]) === "object"
```
perhaps you'd want to do something like:

```javascript
if (message["message"] !== undefined && message["name"] !== undefined) { ///...
```
It doesn't, as long as you assume that all the required dependencies are there. 

Thus, this introduces another error category: 'dependencies'.
group `versionsuffix` with `name` and `version`
use a multiple docstring here instead of comments, so we can have this function properly in Sphinx-generated documentation
Although in this example it it probably superfluous, without it I think there is a risk of mixing applications resulting in unpredictable  behaviour. In the simplest case there could be source files that no longer compile after the pom is overwritten.

I think it is good practice to tell the user to clear out the app first. Maybe after being done with this app he may use the same git repo to test the other quickstarts and without the rm he will definitely hit problems.
Not if you are running a "managed" Arquillian test.
I like two spaces around every `=`, easier to read.
part 2-single exammarks for 1 grades
Hmm, this is interesting.  Adding a field for every field isn't necessarily going to scale, and at some point I suspect we'll end up wanting that granularity. But then how big is this really going to get, anyway? Need to think about this a bit.

If we *do* go with field per field/group, we should consider defining our own field type somewhere, `phonebook.fields` maybe, that wraps up a lot of this.

```python
# phonebook.fields
from django.db import models

from phonebook.whatever import VOUCHED, PERMISSION_LEVELS

class PermissionField(models.IntegerField):
    default = VOUCHED
    choices = PERMISSION_LEVELS
```

I'm not 100% sure if that's actually how you subclass a field, it's been a while, but that's the idea.
Lowercase this whole function name. `test_ircnick`.
ah now that I think about it I think it's actually paused, will change
Wie wärs mit:
Falsches Zertifikat oder Passwort für registrierten Benutzer. Wenn Sie sicher sind, dass dieser Benutzer mit einem Passwort geschützt ist, versuchen Sie es bitte erneut. Falls nicht, brechen Sie ab und überprüfen Sie Ihr Zertifikat und Ihren Benutzernamen.

Aber falsch ist das oben auch nicht.
I'd make this an `if` statement.
`k=v\nk2=v2`
I had a check of the throbber and its displayed property is not reliable. Let's remove that wait and retain waiting for the gallery items.
we'll get a field for dataset - CSL already has a type.
This may cause some unnecessary exceptions being thrown. xpathText could return null.
This can be simplified further: requestParameters.gateway != null.  Briefer is better.  See http://static.springsource.org/spring-webflow/docs/2.0.x/reference/html/ch03s05.html for more opportunities to leverage special EL variables.
Made it thread-safe by using AtomicBoolean for "isInUse".
I tried loops at the beginning, but found this to be easier. At least to write.
If we don't have any plans for an `UpdatesHelper` at this time, this file can be removed.
Shouldn't it be more of a "I'm ready"  and not "tell me what to do i am your slave"?
does this ever divide by 0?
Why doesn't this use the status method defined above?
I'll do that :d
What does this raise?
This is a somewhat marginal case but I think we might want to drop the Verify here, this probably shouldn't be exposed to system's as they could grab the upstream cert and bypass thumbslug entirely, in which case what's the point of using thumbslug. It's not a huge risk but we're probably better off without it. Removing the annotation will make it super admin only, which should be ok for thumbslug.
Good doc on limitations of XDomainRequest http://blogs.msdn.com/b/ieinternals/archive/2010/05/13/xdomainrequest-restrictions-limitations-and-workarounds.aspx
vector\<char\>
fix this import also, same as before.
Although the litmus test suggests checking the url of the faq page, relying on urls to stay the same can create selenium tests that will break easily if the url changes.  Changing this assert to check that the title of the page contains "Frequently Asked Questions" would check that the test is on the right page without relying on the url.
i'd push this logic into createwhereclause

so you can just say:

qstr.push( createwhereclause(args) )

and createwhereclause returns empty string if no args
Probably better to collapse those into a single line, rather than duplicate them:

    module Puppet::Util::Puppetdb::CommandNames

That way you don't have duplication of the type of those wrapper entities.
you don't need the parentheses:

```ruby
def edit
  @setting = Refinery::Setting.find params[:id]
end
```
Again, s/got_to_page/go_to_page
Since the function calling this continues iterating over `libs` and setting the lib variable, not returning lib here would cause the wrong value to be overwritten in the loop.
Yea setRole and removeRole were meant to delegate to _applyRoleChanges instead of have their own queries. I think I'll just remove setRole and removeRole to be consistent with the removal of addGroupMember and removeGroupMember.
Shouldn't this be the model.js file ?
I think it's worth making the modules, etc. hashes instead of arrays, will make a lot of code easier.
That's basically the same though, especially as custom type imply Object.

If the explanation is `Content/Principal/Tenant object`, they'll still have to find out what these objects are. So for new developers, it'll just be harder to read. For developers with experience in our codebase, it'll be much faster and clearer to work with.
This function should check whether or not the user trying to do this is actually a manager of the group.
`_` precedence here as well
Looks like the createUser is already taking care of this. Please ignore.
Hmm, where's that initialized now? I can't find it?
@jferris Rake can take multiple task names as parameters, and will run them in that order.
Я гонял на 100%, но согласен, что на больших процентах метод работает крайне медленно. Вообще говоря, он может работать бесконечно. =)
This association seems wrong....
This requires Vista or higher.
Replace ``BRACKETS_WWW_SRC`` with ``BRACKETS_SRC``?
Why are you formatting the mail message like this? Email already has a subject and a from. I'm not sure why it's being duplicated here. Since we're posting this directly to the mailing list, why not make it look a little more like real email? Maybe to make it stand out a little, you could prefix the subject with [From Cincyrb.com]
commit name - pennomi?
invalid if `$this->identifier` is null
I disliked it too. I was trying to keep "background" in there, but I like your suggestion more. :+1:
What happened to the signal-based API? This seems significantly less powerful and not really in the vein of what RAC does.
These imports were moved, please keep the original order for ones that aren't being changed.
yes, indeed that was my original idea when developing that function (applying it to the descriptions of the help page; but didn't had time to work to it, up to now); currently it's just used to create a background box around the keyborad keys of the shortcut, in order to better highlight them.
So if you find a way to implement line wripping in a generic way, we may reuse it in many context.
this should be in its own pull request. and check.vends.length should be its own variable as well
直接叫eventbus吧，更合理，因为agent也没有叫mk-agent。
@xumingming 标准库里mod跟rem的差别就是一个可能返回负数，一个不会。而无符号数的情况不会出现负数，于是mod和rem就采用了一样的实现
This was necessitated by the commit I added to `testrepo_wd`. This test should now be more future-proof.
It was used from the constructor and did set the name to an empty string, if the submodule wasn't valid. What i had in mind those days, was:
```
Git::Submodule s( mRepo, "Anything-that-does-not-exist" );
Q_ASSERT( !s.isValid() );
```
But that will work with the new code, too.
That's fine, I'm just a little obsessed with parallelizing, I'll revert that part. I'll also revert the changes to the inverse computation to put the line replication back in -- I tend to automatically apply DRY principles whenever I see an opportunity, I'll ask if it makes sense next time.
Something's missing here I think.
These should be List<T> right?
You should create links to the API documentation for objects as described in the documentation: http://symfony.com/doc/current/contributing/documentation/format.html#adding-links
当关闭缓冲时，收到响应后，nginx将其同步传给客户端。

当关闭缓冲时，收到响应后，nginx将以同步的方式迅速将其传给客户端。
Wouldn't it better to send the coverage data only once, after all specs ?
You need to do this inside the constructor of the reporter. This way, it tries to connect to growl server, even if you don't use `growl` reporter. If you don't have growl installed, you get some errors.
Something like

	def create_spm_prefix_trait(default):
		return traits.String(default, field='prefix', desc='output prefix')

	class SomeInputSpec(SPMCOmmandInputSpec):
		out_prefix = create_spm_prefix_trait('a')
Or would promote.on-fail be a better default?
La verdad que envidio tu vista JD y tu rapidez. Me sumo a lo que dice Andrs. 
Muchas Gracias por las correcciones a los 2.
Maana lo corrijo. 
abrazo

> Date: Mon, 19 Mar 2012 19:11:14 -0700
> From: reply@reply.github.com
> To: matiasjose78@hotmail.com
> Subject: Re: [CommonJobs] Last Updates *.Markdown and *.Pdf to 2012.03.19-Entrega-Documentacion-Sp... (#41)
> 
> > @@ -0,0 +1,88 @@
> > +#Product Backlog CommonJobs ([Trello])
> > +[Trello]: https://trello.com/board/product-backlog/4f15d6128f513d777e0269bd
> > +**Los numeros son los Story Points asignados a cada Tarea/UserStory.*
> 
> No, me parece brbaro, son cosas que se le escapan a cualquiera y viene muy bien que alguien las vea.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/CommonJobs/CommonJobs/pull/41/files#r578113
¿Esto determinaría que una búsqueda "Hola*" y "Hola?" con wildcards devolverían los mismos resultados? Entiendo que es así porque parecería que la búsqueda es siempre la primera parte de la palabra. ¿Queremos que así sea?
This looks a bit generic, it will match any span whose text is $1.  Maybe make a little more specific like

`//div[@id='myfoopanel']//span[contains(.,'$1')]`
I think there's a much more straightforward implementation of this, I have one in test.tree:

```clj
(defn tmap "Does a depth-first walk of the zip, passes each node thru
            f, and returns the tree"
  [f zip]
  (let [walk-fn (fn [l] (let [new-l (zip/edit l f)] 
                         (zip/next new-l)))]
    (->> zip
       (iterate walk-fn)
       (drop-while (complement zip/end?))
       first
       zip/root)))
```

Then you just have to call it:
```clj
(defn tree-edit [tree filter-fn edit-fn edit-other]
  (tmap tree (fn [node]
               (if (filter-fn node) 
                 (edit-fn node)
                 (edit-other node)))))
```
This stuff should be baked into the Sass compiler, I have opened a new issue for that: https://github.com/nex3/sass/issues/471
That was verified before I did the PR :) it works(tm) with a single entry or multiple entries.
You could put a skip decorator on this method rather than commenting it out.

Although if we plan on keeping skipped tests in long term I have some ideas on how to mitigate the problems that introduces. We should discuss it if that's the plan.
maybe i am missing something but i think this function would always throw this type error for context.
Good point. There are two thresholds: lower one (maxBatchQueueSize * batchThresholdFactor) and upper (maxBatchQueueSize)
I see, the tests that don't have a `des.shutdownNow()` call in a finally block actually fail during construction.

I'm not sure if it's feasible to have both 'unmanaged' executors (supplied by the user) and 'unmanaged' executors (created by the DES constructor, if the user did not supply an executor).
I guess it's only a matter of preferences. I tend to use ```for``` when it doesn't reduce too much readability, as its performance is around two times better than ```foreach```, but given the size of the sample, it is a rather minor optimization (well, unless you actually have something like a hundred thousand or more module paths and/or stylus assets, in which case you would probably need to rethink your assets organization).

In any case, I can update the code if you think it is actually an improvement. It's not like I really care about that particular line of code. ;)
I agree that the line ```(unless *patch_artist* was *True*. See above.)``` was incorrect and that it should be taken out. 

Would you mind adding some information about the keys that exist in the returning dictionary?
You left space around the `=` sign of the `dtype` kwarg.
At the very least, catch Exception, but I would rather catch IndexError and whatever else might come from numpy (ValueError, maybe?)
Nice idea! Extra bonus points for that! :smile:
My mistake.

I'd then use the shape method instead of the length attribute, but that's too much nitpicking :)

Thanks for clarifying.
@jsloane Fixed
@arnodeclercq Thanks, makes a bit more sense now and I have some ideas why that didn't work.

I'm still interested if adding an `@media` within `sakai.base.css` would be a good solution as well.
Would love to hear @bp323 view/take on this.
This code is not yet ready and the type hinting will be on ``AdvancedMethodInvocation``.
Fixed all this in an update.
Can you test that the list identity changed here? Otherwise you would get false positives if the write() call has no effect at all.
sweet
but line 111 should not be removed
It should be if (row) {
Why is memset not sufficient?
Я просил убрать тебя href='#' вообще
Rather than `$language = ((isset($user->lang[$lang_key])) ? $user->lang[$lang_key] : $lang_key;` use `$language = $user->lang($lang_key);` that method was designed to do that, IMO the API should always be used when possible.
Passing the language string or just the key into the function doesn't matter much, IMO passing the string is the correct approach as the function is designed to only assign the option to the template.
Using err for help request is kinda strange (imo), otherwise LGTM if it builds.
Are you sure ``'Pagination scrolling-style manager must extend ScrollingStylePluginManager; received "ZendTest\\Paginator\\TestAsset\\InvalidAdapter"'`` has the correct type as "string" is not a sub-type of "string"?
Are you sure you want to override the parameter ``$partial``? This often makes code less readable.
forgot the delay option.
"Lets" -> "Let's"
Is there not a URL or URI class that can handle the representation of the URL, avoiding the need to introduce regexes?
Sieht hübsch aus! :metal:
That's not true.
The [KeyValueStoreTestCase](https://github.com/doctrine/KeyValueStore/blob/master/tests/Doctrine/Tests/KeyValueStoreTestCase.php#L28) has a `$storage` argument, so no warning will be shown.
CodeStyle(CS)
Avoid the crash caused in Boost.Thread 3 when joining a thread which is no longer joinable.
I don't see any reason why it can't exit there when it's only 1....  but if I was going to fix that, then I'd move it further up a bit and do  switch for 1, 2, and more words.   2 is an error condition of some sort[since you can't have only one argument if doing a comparison or arithmetic... ie countModules('leftNav and') is an incomplete condition.    As such, that would require going in and adding unit tests for the 3 options which I don't feel like doing right now.
Totally forgot docblocks, thanks.
I'm not sure if anything in this method is necessary. The reason I do this with hResume is because I need to convert between different formats (say, a date like '01/2012' to an hResume-compatible date format.) So this is there I would do that transformation. I don't think there is a corollary here, so this method can go
Just a minor style thing: Please use a partially applied function (omitting the second parameter list) instead of a lambda.
Yes. Widgets/panels.
Please explain how it didn't work. We can try and make it work.
And same as for discussion above, be careful where you put those signals. So adding subscribers is a part of creating an object. But sending notifications should come later, when we are really sure everything was done properly and we are just about to return the response.
No, don't manually formate date, use function from `tastypie.utils.formatting` (you patched).
Yes the main problem was, I didn't even suspect that igypigi will do the fixes, so I didn't sync the branch, and didn't have igypigi's fixes. And than Github crashed and so on. I hope there are no interferences.
Hm, maybe we should start writing code-style documentation. ;-)
*Password (repeat)*?
This should be string marked for translation.
I next PR
Is `_em_job_id` actually still used anywhere? I don't think it is.
Agreed, I really don't like it :)
ok. just add.
prolly forgot to remove line 415
wie kriege ich den aktuellen User?
Change "Too" -> "To".
Do you think we should provide specific methods for the possible different types of metadata? So, make those types first-class citizens. For example, a method named specifically to get the distance of an object from the centerpoint of the query.
Typo. "Lebel"
`true` is not a type :) `bool`
This looks odd. I haven't followed it all the way through, but can you check if it was superceded by the updates to httplib2 and by support for the requests module?
The dependencies' versions are moved to `<properties>` tag in the parent `pom.xml`.
Reasonable, although that particular test case is a wee bit golfed ;)

Want to send the patch?
ok, I will restore that
removed all interfaces in latest commit
Move this outside of the 2nd ``foreach``
`window.event_handlers`.
alpha: 0.7
I thought more explicit code will be somewhat more self-documenting but maybe that is not needed.
Not really, I just like to provide an initial value.
Why 12288?
What? Why autorelease? `existingObject`is created with `[QSObject objectWithIdentifier:]`, which should already return an autoreleased object. Why would you autorelease it again, without retaining it first?
Oops, I needed to reapply the changes of Xavier by hand as my rebase conflict resolving went wrong.
Constant strings -> `'`.
I would recommend protocol independent: `//` rather than `http://` or `https://`
No; don't merge - working on James' comment (and it will include your suggestion because of that change :-)
Good call. :)
utiility function, actually unused.
Is this an enhancement that it's worth making in the WebAppMonitor, e.g:
    new WebAppMonitor(url).logFailures(LOG).logProgress(LOG, 1000, TimeUnit.MILLISECONDS);

Just a thought.
##Manipulating the DOM
my thought on `enabled` was actually driven by when we want to turn it off, ie in Test mode. So it needs to be present and enabled to be initialised.

btw can I ask that we use British English in any method names that we have control over.
I added a commit (0311ab0) that uses the SHA256 computation algorithm in the test to generate SHA256 strings as documented on this wikipedia page: http://en.wikipedia.org/wiki/SHA-2
액티비티로 바꿀께요.
Typo, should be "Unknown".
It's still odd :-þ
https://github.com/mongodb/mongo-php-driver/commit/0e252c61299be556f5853e3aba19bcf4d66e6503

The problem was CREATE_BUF() was called before we had set the flags so the flags were always ignored.
We need to have applied the full read preferences and slaveokay bits before creating that packet, which is why I moved it even further down
Funnier part is that doc string is a copy paste of another resource and is totally unrelated to this one :-P
you should use an exception of the component here as the Security component always throws its own exception (extending the SPL ones)
I didn't know how to redact that
It's a Ubuntu One file. I need to remove it.
Utiliser les helper pour celà. Pas besoin de faire du HTML ici. 
f.select
I think it is a terrible idea.

Think about what would happen if a developer changed idGenerator or storeFactory at runtime?
In JavaScript we are also able to configure the "token name".... the default in JavaScript is "Auth-Token";
Also looks like the constructor below is never used.
Thanks, I wasn't sure what the replacement function was
Just remove the line if it is not needed, don't comment it out :)
Тут можно сделать всё эффективнее. Во-первых, System.out обернуть в OutputStreamWriter, тогда можно out сделать типа Writer (только надо в finally не закрывать System.out). Во-вторых, сделать локальную переменную last, чтобы на каждую итерацию лишний раз не ходить в коллекцию. В-третьих, надо конструировать не только компаратор для Pair, но и для String - код получится без лишнего if.
System.in?
Формат не тот, что в задании.
Because curl exceptions are wrapped inside FacebookApiException...
I like this. How does `logPosts()` sound? It's short, it seems to say what it does, and since it doesn't take an argument I feel like we can drop the 'enable' bit.
The apps are sorted descending so use is_sorted_descending().
Not all wallpost types will have authors (e.g. system wall posts) and some wall post types will have required authors (e.g. media wall posts) and some wall posts will have optional authors (e.g. text wall posts). But you're right, I think it's cleaner if I put this in the base:

```python
author = models.ForeignKey('auth.User', blank=True, null=True)
```

Sound good?
It looks like @joshmoore is correct that this may be [another U.S./U.K. difference](http://www.bbc.co.uk/worldservice/learningenglish/grammar/learnit/learnitv57.shtml). But my understanding is that the decision was made to standardize on U.S. English. So it should stay `Bio-Formats's`. Or would could do `Bio-Formats's's's`, just to be extra safe.
I'm not completely sure that this is equivalent to your loop, but my suggestion is to replace your calls to `maximum_filter1d` by something like the following:

```python
    hspace_max = ndimage.maximum_filter1d(hspace, size=distance_size, axis=0,
                                          mode='constant', cval=0)
    if min_angle > 0:
        hspace_max = np.hstack([hspace_max[::-1, -min_angle:],
                                hspace_max,
                                hspace_max[::-1, :min_angle]])
    plt.imshow(hspace_max)
    plt.show()
    hspace_max = ndimage.maximum_filter1d(hspace_max, size=angle_size, axis=1,
                                          mode='constant', cval=0)
    if min_angle > 0:
        hspace_max = hspace_max[:, min_angle:-min_angle]
```

Note that this doesn't remove maxima in the *same neighborhood* that have the *same value* (since both will match `hspace_max`). Your loop removes these duplicates, but it does so by keeping the first of the duplicates (based on the loop order). I'm not sure that's ideal, but I don't have a better solution off the top of my head.

BTW, when I run the following example with the current implementation, I get 2 peaks instead of 1:

```python
img = np.zeros((15, 15), dtype=np.bool_)
rr, cc = line(0, 5, 14, 6)
img[cc, rr] = 1
hspace, angles, dists = hough(img)

h1, a1, d1 = hough_peaks(hspace, angles, dists)
```

(I'm actually not quite sure why the loop doesn't suppress the second peak, actually.) Using the implementation I copied above, I get a single peak. Note that I had to filter out duplicate maxima in the same neighborhood using

```python

    labels, n = ndimage.label(hspace_t)
    coords = [np.round(ndimage.center_of_mass(labels==ii)).astype(int)
              for ii in range(1, n+1)]

```

instead of

```
coords = np.transpose(hspace_t.nonzero())
```

But labeling only works here because the duplicate maxima are touching (hence in the same labeled region), so it won't work in the general case.
Appart from the minor remarks that I made above, this is good to go!
Congratulations, @kuantkid !
Hm I never really thought about the class naming scheme.
You definitely have a point there.

Not sure if I prefer the other name, though.
Maybe I'll ask on the mailing list.
'"{0}"'.format(...)
Well, the tests are working as they are. I will dig in to see.

Anyway,I will remove that commit and forget the indexing from 1 and stick to the old way (where the profiles were generated in the loop and this starting from 0, which is not the case now) and keep confusing everyone else until forever :-)
Ehm, creating everything and using only one of them?
Can you use tabs as indentation here? Thanks!
This does not fulfil the contract of being "interpreted local to the current file" as specified in the docs.
Do we know that we'll have access to the dpi to support all these unit types?
Note: V8 doesn't implement basic JavaScript objects such as "Date". We're going to need implement a bunch of JS functions and objects.
Signatures model restricts mass-assignment availability to certain fields. Therefore it should be safe. Please check if you can find fields which should not be available for mass-assignment when creating the model.
Is it working for has_one_remote ?
Can you add the driver config here?
So, the result type is at the end of the body's arguments or is it at hard-coded positions given the node type?

There could be a better way of doing this... Isn't the result type always relevant (for other node types, except for the obvious ones)?
Missed Jake's comment here.
NB: This was wrong on 64bit platform before, only an issue if all nodes had >UINT_MAX rows though.
should be type="search"
already made in one line. one-line formatting of simple annotation is more readable, so let's leave as is.
Would this still work if this line was not here?
Please refactor dataset title logic into its own method.
Actually, I see line 375 only catches ``ValueError``. We should mirror that here.
Bit worried about this one.. What's the latest status of highline for windows/linux/mac? Also, mri/jruby/etc?
Please don't include configuration files.
No reason, just wasn't thinking.
Should we change this to self.timeout at the same time?
style nitpick: no need for braces on a single line
sysvol_path instead ?
No, that would be crazy.
Camelcase'd be "adjustUrl", and I would call it right after initialize(), so in line #109.

I would be a good idea to skip this checking in the case of Backbone.history not being used.
Is this fix related to the bug?  Or did you just spot it while you happened to be in here?
The world coordinate members are read only. They should only be accessed with the `get*WC` methods. Should these functions return a clone instead? Accept a result parameter?