labofsahil/github-event-dataset-2012 huggingface dataset:
Ok, but just for conversation, I *would* need the use tag if I were doing something like this, correct?

    {% block choice_widget %}
        {# so some something different #}
        {{ block('base_choice_widget') }}
    {% endblock %}
Nevermind, I see what you're doing here (after looking closer at the shim you wrote)
Changed this table for openID, but still I don't know if I should be saving a passphrase and a username
Actually, except for a wikipedia link, all lines where below 80 chars...
This change is certainly wrong. The ALL_TYPES_EXCEPT_OWN map can't be null in a method of a WayPointType object, because it has been initialized as final non null in the static code (which is executed on class loading). Please revert this change.
If for no other reason, the code sucks, and I haven't touched it in ages. In 2012, I will either create another caching framework or promote somebody else's that I test and find exemplary.
A good point well presented ;)
I'm not sure about this one. My destination jar names are exact to what is shipped in .zip distribution.
I'll check and change for you. But this is probably going to be a constant hassle when you get windows editor based pulls, so might be a good idea to put this info somewhere visible.
please use auto_ptr here. this will allow you to remove the delete below.

I will update other codebase uses of delete in favor of auto_ptr. delete is not very c++ like and can be prone to leaks if there are other exceptions.
You forgot to import EventHandler
Yup, now it's a different command that reads all three parameters (name, players, ...) - server probably needs  to be updated.

Check network protocol page for more details.
Hmm, makes sense. I just copied over the priorities from the old event system code.
Damn, I knew there had been a reason why I was doing it that way. Will revert it.
Sorry, VS converted, I didn't think to include the project files.
I agree, and the schema agrees with us both.
The attrs are both marked required and the browser views will not add questions or answers if you don't supply the text.
What's this comment for? Do you want it to be on top of `attr_reader :d` ?
This function doesn't belong here. Put it into your sandbox ros package since it is more something that should be in the executive.
The patch was submitted to the Zsh mailing list and has been [committed](http://zsh.git.sourceforge.net/git/gitweb.cgi?p=zsh/zsh;a=commitdiff;h=ee03cac7fea67062eff3340b018b8d38c35f6a95). However, we should include it and not wait until a new Zsh version is released.
Thanks! ARC makes things so much easier!
Depends on whether we allow for scrolling - in the flexvis graph viewer, you could pan on the background.
We need to update trade data only when trade is in progress
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp
index 5ba80ca..585a31f 100755
--- a/src/server/game/Entities/Player/Player.cpp
+++ b/src/server/game/Entities/Player/Player.cpp
@@ -12884,12 +12884,15 @@ void Player::SplitItem(uint16 src, uint16 dst, uint32 count)
         AutoUnequipOffhandIfNeed();
     }

-    //! Update item count in trade window, prevent spoofing
+    //! Update item count in trade window if trade in progress, prevent spoofing
     //! Since pSrcItem has its count updated (see above), Item::GetCount() will return the new count
     //! in the underlying packet builder function
-    TradeSlots const slot = GetTradeData()->GetTradeSlotForItem(pSrcItem->GetGUID());
-    if (slot != TRADE_SLOT_INVALID)
-        GetTradeData()->SetItem(slot, pSrcItem);
+    if (GetTradeData())
+    {
+        TradeSlots const slot = GetTradeData()->GetTradeSlotForItem(pSrcItem->GetGUID());
+        if (slot != TRADE_SLOT_INVALID)
+            GetTradeData()->SetItem(slot, pSrcItem);
+    }
 }

 void Player::SwapItem(uint16 src, uint16 dst)
@aios Hmmmmm... what the hell are you demanding? Do you think TC devs are your servants or something else? lol!
i do like jokes too, but that is not way to say something... they are working hard to make it work fine and you should be grateful with them, and dont demand them nothing. Hope you understand it, im exited too with all this :)
yep! good Job! now Trinity need mmaps )))
Hi! It's divided for better organization, just like the Ext framework files. It uses the ext loader to load all the files or to compile a minimized version of the app. 
I just enabled the issues on the repo.
$ git fetch origin
$ git rebase origin/master
$ git pull origin master

Will avoid this merge =P
Hi Mike, I'm really sorry it took me so long to get to this.  I've been crazy busy at work.   I'm going to merge this soon, however can you do me a few favors first.  It looks like you've added your eclipse (or cfbuilder) project settings in this pull request.  Can you please remove them from the pull request, specifically settings.xml, .project, and the .settings/* files.  Also it looks like you added a cfabort to mxunit/index.cfm.  Can you remove that as well?   Thanks - Ryan
username login is failing silently and as far as i can tell it is because I don't have EMAIL_AUTHENTICATION set which means that AuthenticationBackend.authenticate() just returns None immediately
is it preferable to have merge-commits or to pass --rebase here?
haha whoops, I already merged it in but I don't think you gave me your new library.zip for this...because of this I don't think I'm seeing the right things...
Asmir, my last commit should enable you to test for disabled samba account.
looks much cleaner than before.  thanks!
The commit message was supposed to read "cast labels array to object".
@RichardWarburton Rejected

    @BeforeMethod(groups={"implementation"})

Would cause TCK group tests to fail. This is corrected later though
This pull request is just a humble suggestion. I suspect there are reasons this functionality hasn't been exposed, but doing this works for our application. Some other users may want to do the same. There is a low-ranked feature request on the topic: http://highcharts.uservoice.com/forums/55896-general/suggestions/1395263-support-for-contextmenu-event
Sure, I would be glad :). This particular fix is probably dependent on my previous changes (i.e. lazy database creation e18602e).

PS: You already have my email as we were in contact before (glin at seznam).
hmmmm, something missing from the end of this line.........
merci ;)
Can you do only one query ? with a subquery
Symfony2 2.x ;-)
This is an easier way to get that expiry date:

    max_date = store_credits.where('remaining_amount > 0').maximum(:created_at)
I wonder why github doesn't show anything for web/static/js/simile/extensions/portfolio-eventsource.js in this diff. I ended up looking into why this was removed:

```
-    if (productName.length > 0) {
-       name = name + " (" + productName + ")";
-    }
```

It got introduced back when I was rebasing for fixing commit messages and wanted to know the reason. I am guessing there was a conflict and not having it any more was chosen (Jarno seemed to confirm this). As a note for the future we can annotate the commit messages for merge commits too to explain such UI changes. Please let me know if my logic was faulty.
Hey Olivier,
I'm not sure when Github sends notifications but just in case it didn't I
wanted to let you know I just replied to your comment from last week. :)

https://github.com/Wsiegenthaler/nativelibs4java/commit/df19f663de4567aeeaaabbd4a76a7148e704630d#commitcomment-971562


On Sat, Feb 11, 2012 at 3:08 AM, Olivier Chafik <
reply@reply.github.com
> wrote:

> Hehe, was probably too tired when I wrote those remarks yesterday, didn't
> even bother to search for "get_global_id" :-D Thanks for relieving my
> concerns ;-)
>
> It's great you've added a test, you should also make sure it runs as
> automated tests as part of the build (this probably applies to other stuff
> in ScalaCL/Test, which was initially more of an informal manual test
> directory).
>
> Oh, and I think it would be beneficial to devise some sort of optional
> predictible seed... Some "randomized" algorithms require absolute
> reproductibility (for instance, Monte-Carlo pricing in finance). Not sure
> it's possible with scala.math.random, but maybe we could think about
> supporting scala.util.Random in some way... (replacing it "ad-hoc" with a
> scalacl.util.CLRandom ?)
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Wsiegenthaler/nativelibs4java/commit/df19f663de4567aeeaaabbd4a76a7148e704630d#commitcomment-956420
>
Remove all of these printStackTrace calls.
por enquanto a coisa tá entre aspas mesmo.. tenho feito nada no projeto, assim como outros nem deram as caras, ok!
mas mesmo assim, sinto-me no direito de reclamar sobre isso, embora eu não ponha a mão como vocês estão fazendo, estou acompanhando o que está sendo feito e leio essa bagaça toda aqui..

acho que as aulas servem pra isso (alguns faltam alguns dias, mas o lugar de fazer isso é lá), tem nada que sair instalando coisas, mudando coisas que talvez façam outros testes quebrarem não..
this is not a useful way, if u want to contribute, use our review system

but as i have told, your "fix" do not fix anything it's just cosmetics
First part depends on discussion of other comment.

Agree about "extending the template engine" doc, but not sure belongs in this pull request. That's more a generic "here's all the ways you can add things to the template engine", rather than just "here's how to add a global or iterator variable".
Ok, questo non l'avevo testato. Ti dispiace stare attento che before lo metta realmente prima di un altro field? Il concetto è che before = None va in fondo, mentre tutti gli altri vanno sopra il field identificato dal before. Purtroppo secondo me questa parte è critica in quanto abbiamo un index relativo ad una lista con un elemento in più, infatti facciamo la seguente:
1. Otteniamo l'indice
2. Eliminiamo un elemento
3. Inseriamo all'indice ottenuto prima
E secondo me sminchia: forse ci vanno dedicati un dieci minuti di pensiero ed estrapolati i casi limite.
Am 01.01.2012 14:20, schrieb zachariasmaladroit:
> auch nicht mit Youtube HD videos ?,
>
> Ton beim Abspielen von HD videos ?
>
> Front Kamera ?
>
> das waren, glaub ich, die Probleme in der Vergangenheit mit zu aggressiven Einstellungen,
>
> ich werd das jedenfalls mal eine Zeit lang testen
>
> Danke !
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zachariasmaladroit/android_kernel_samsung_aries/commit/f20ba0f166d07b4016795eefcb6a8ddb336f428b#commitcomment-830254
>    
ich habe es selbst nicht alles getestet. aber ich vermute/hoffe, dass es 
jemandem aufgefallen wäre. den kernel haben ja über 100 leute runtergeladen.

mit meinen "alten" einstellungen, bevor pawit etwas an der bootmem.c 
geändert hat, kam ich so auf 354 mb ram. jetzt sind es "nur" noch 348.
This is a carryover from the Elasticache base.  Deleting in both elasticache and RDS.
So we're not going to support using using the mouse wheel on a horizontal ScrollView? If this is the case, it should be documented as a known issue in ScrollView's user guide where it mentions support for the `mousewheel` event.
Unless I'm misunderstanding the use-case, calling Y.DOM.getDocScrollX() ("dom-screen" module) or node.get('docScrollX') ("node-screen" module) will return a normalized scrollTop value for the document.
The indention of above lines is not right.
Preview is the next feature, I'm investigating in it.
in other Settings we have named the constants with first as capital letter
Yes, this is what we agreed on with Viktor. Do you think it's problematic?
Of course you are right, your definition of α is the established one. And since I got that wrong, I correctly assumed that I did more mistakes yesterday: the factor in the decayRate calculation needs to be inverted (i.e. 0.69315 instead of the 1.4427). Sorry about the confusion!
a small readability improvement would be to place the init and start calls inside the scope of the val creation, i.e.

    private val actorCell: ActorCell = {
      val actorCell = newActorCell(_system, this, _props, _supervisor)
      actorCell.init(ThreadLocalRandom.current.nextInt(), sendSupervise = true)
      if (actorCellShouldStart) actorCell.start()
      actorCell
    }
so the reason that you increase this is to make sure that the awaitCond Leaving is ok before Exiting happens?
how about "message" and "originalCause"?
those 3 lines are identical on second, third and fourth, you can extract them to a

    runOn(second, third, fourth) {
I think we can move this to the base config. And turn it on for the tests we need it in.
Very useful Stefan. ThX!
also could we do STY?
Oops, don't commit the minified files (also goes for the rest below). This looks like you committed these by mistake
Flushed these out in what I hope is a clear description if you wanted to take a look.
I think that was all temporary and we can take out the tests.  I think I have, but maybe downstream.
Ouh :D
Several more... smb for example.
You are right - then I guess best is to just remove the "return;".
I will also remove the white-spaces in L314.
There is a helper class for elapsed time, use that instead.
Wow, did you implement this already? Fantastic! Hmmm... I think this is something we'll need the Arquillian test-harness in 2.0 to test properly since we can't really install and load plugins during test execution at the moment. For now just leave the test stubbed out like this. That's fine! Excellent!
i think we should add dependencies with `npm install package --save`
eww, I don’t really like these implicit conversions: they are only known-ok if the wrapper never escapes (i.e. only enrichments) or is very special cases (like the NOP conversion between ActorRef and ScalaActorRef). Please make this explicit where used.
Please user the setter (and getter below) instead of the ivar.
le isset n'est pas indispensable puisqu'il y a toujours cette propriété (même si vide)
This is almost the same as ProcessArgs.  Please refactor to eliminate code duplication.
Empty string task not supported!
wrap with Collections.unmodifiableList(...)
почему 14? вынести в именованную константу лучше
`uniq!` won't solve because they are different objects and we cannot "compare"

    User = Class.new User
    old = User
    Object.send :remove_const, :User
    User = Class.new
    new = User
    old == new #=> false

However, `old.name == new.name` are equal. So maybe you could keep a hash based on the name, this won't leak memory, but it also won't allow the garbage collector to act until the class is reloaded.
Why do you not use the new hash syntax on ```link_to```?

```<%= link_to "Path", "#", 'data-route-helper' => '_path',...```
Do you mean `typename` ? ^^
typo: `reflection`
ok, I misread the skew part

mask = abs(skew) < 0.000016
So we're no longer creating an anonymous user for all orders? This may cause problems as I expect some stuff maybe expect an order to have a user?
should this be `is True`?
I have added all the changes that you suggested @smichr. My last remark about another pull request is wrong.
Actually, I don't think this docstring is included in Sphinx.
I think this function is based pretty strongly on the other one on the file. Probably common logic should be factored out somehow.
Is this still supposed to be here?

If you are using this to easily run the doctests, you should know you can add an argument to ./bin/doctest to match the tests you want to run. So ``./bin/doctest sympy/physics/gaussopt.py`` will just run these doctests, and even just ``./bin/doctest gaus`` will do the same.
I think it would be useful to sort these by line number.
Now, when I store the names of objects in `Dummy` symbols, `Basic.__eq__` will never return `True` for objects with the same name, because all `Dummy`'s are different.

Changed all (un)equality operators to use "other" to refer to their argument.
Did you perhaps mean "right angle"?
probably the former, but keep in mind this block of code was copied and pasted ;)
Should be better documented now. Also checking for all conditions for normalization properly.
You are the ruler here, but in general the rule is fine to me, just haven't noticed a style guide ;)
My rule is to write a code "readable enough" and apply small comments in more complicated parts. I find myself really poor in inviting names and labels.
As above, applications have no need to import this header. It should be omitted from Rebel.h.
Can you please document the purpose of this category here?
And then:

    var ex = new Exception(L20n.MISSING_ERROR, 
                           'XHR returned an error code for url: ' + url,
                           xhr);
    fallback(ex);
"Extremely" is awfully imprecise :)
Recently split chunks ... = passive.
Seems like it was a quick bugfix in migration: https://github.com/mozilla/kuma/pull/158
You have a query directly above which restricts on the same user_id set. Combine them into a single query.
@bantu 2 is not likely, but if the other two are supported that should work as well anyways.

@p I do not know of another way to set this up in a way that meets our needs in the YML config. If you or anyone knows of a way to set up the YML config to support our needs where the cache driver is not sent unless needed, please tell me.
Add a description of what it does. Looks like it provides some higher level methods on the assumption that certain lower level methods are implemented in derived classses.
You are reassigning `$cache_dir` here, same below and above.
does `free_percent` need to be declared too?
Filename pattern can not be specified here as long as we have 'main.cpp' right at the top of 'src/'.

The library code and the executable code must be moved to a separate directories if we want to use patterns/wildcards here.

But actually I like the approach when each file is listed here.
Yeah, for the new code I started using that syntax.  Alas, addons/ac/deploy.server.js is fairly old code.

Oh, also, that documentation syntax does work so well when the keys can have arbitrary values, which is the case here.
They are the same value just different representations. What's the point other then it's shorter?
Well, I guess that commit is somewhat unrelated to this pull request, so I'm going to rebase/remove the commit and maybe bring it up as a separate pull request. And it's kinda useless anyway, as we might be better of to build a derivation depending on the kernel to provide a more real, out-of-tree scenario.
throughout your code ... please end lines with semi-colons, even if optional in JavaScript it's a best practice to not lead to unintended mistakes
java.sql.Timestamp supports nano precision. We shouldn't throw away any micro precision here.
Did we decide if this stuff is necessary? Or is it only called once now?
Yes, that's a typo. Thanks.
close it like description_lines in 1.1.10 and 1.1.11
Yes, size is in GB
yeah, but this is placeholder for andrzejs code
Yes, look at tests.calculators.hazard.classical.post_processing_test.QuantileCurveCalculatorTestCase (test_run and test_run_with_weights)
how about
`return unless version = xxxx || yyyy`
`{-# LANGUAGE CPP #-}` is used in other files, though.

    $ ack -l 'LANGUAGE CPP' | wc -l
    18
Caching parts of a selector can be helpful. I'm not sure which is better.
`*classes`
Ok I can try to use the one in `#{HOMEBREW_PREFIX}/lib`.  I probably don't need to set it but did that not knowing what the problem was. I will correct that.  Oiio can't detect openjpeg's include on its own because it uses a custom CMake module, FindOpenJpeg.cmake that looks here:

    # Generic search paths
    set (OpenJpeg_include_paths
         /usr/local/include/openjpeg
         /usr/local/include
         /usr/include/openjpeg
         /usr/include
         /opt/local/include)
could you find a more explicit name? largest_component ?
We shouldn't catch Exception (this has been changed to be even more explicit in another branch), but this is the first pass of removing it.  Only StandardError is caught.
This works for me, Dirk--thanks!
Consider a step before this about stopping the Pulp server. I'm not sure if pulp-manage-db will interfere with a running server, but it might just be safer to tell them to stop it.
Not everybody knows that mondogb deals with collections and with session keywords everywhere in this module I think it's better this way.
The ``_removeNote`` can remain specific only to ``FlowLayoutNotes`` if you don't want it present in the original Notes example also.
please use negative identity operator instead of the negative equality operator
Please remove this debug statement.
Perhaps generalize this to `(K, A, A) => B` ?
Hah hah.
Getting analysis early is most important to me. If we can guarantee that, it gives us liberties at runtime to make optimizations and fast startups that aren't possible otherwise.
Sweet!  Deal.
:thumbsup: 

I wrote the original code in a hurry. It's now time to make it so clean you want to luck it. Thanks for your help!
Good point. I left this in place because the whole notion of `hasContainer` is gone in the imminently merging `view_caching` branch but I'll move it around now for completeness.
see, I told you... now 2 "typos" any other comment about this pull request?
Actually, aren't we checking whether `this.media.poster` exists where ever we use it? When would we want it to be an empty string?
I went with an empty string to match the behavior of _getImage and _getAuthor. I assume it's because these values would be strings, but I don't have any particular attachment to an empty string here other than apparent convention.
I don't see any conflicts with this shortcut, so why did you choose a different shortcut for mac and win? We should be consistent wherever possible.
For consistency with other function names in this file, this should have an underscore in front since it is not exported.
But `:input` would also include other form elements like checkboxes and buttons where we _do_ want to prevent default.  If we wanted to be really picky we'd want the above two cases, plus `<textarea>`, plus `<select>`.  But since there are no instances of those in the colorpicker UI yet, I'm inclined to think what we have above is good enough for now.
Same comment here regarding namespacing the event.
I basically rewrote these tests so mapping can be tested both ways: file path <---> url. That allows testing of url mapping of files outside of project.

But, reading your question again, I realize that's not quite what you were asking for :) Live Preview (I believe) works like this:
1. It maps local HTML file path to a url and opens it in browser
2. Gets the assets loaded in browser, and maps the urls back to local files.

So that functionality is dependent on what the server (if applicable) and browser support.
jslint complains about ``_topLevelSuiteMap["All"]``. I can add ``sub: true`` to remove the error if we prefer.
I know NJ mentioned only those rows in red, but the three rows in yellow -- 219 for [, 221 for ] and 222 for ' -- are not working on Windows. So can you add those as well?
Same question as above for fileLocation: The old code checked for "if (fileLocation)" before dereferencing it. Are you really sure that it will always be defined?
Included in #1813
I think what lennart means is that it DOES match `if (err) log(err)`, which gives you a false positive.
lots of string needing translations here
Is setting this empty string necessary now that you have the line to follow?
controller 名稱通常都是 table 名稱 (model 名稱的複數)
即: fotos
列表的 action => index
單一的 action => show
參考一下之前筆記
Shouldn't you just override `form_valid` and put:

```
username, password = form.save()
new_user = auth.authenticate(username=username, password=password)
auth.login(request, new_user)
return super(RegistrationView, self).form_valid(form)
```

into it and this is it?
s/even/event/
Looks like it does to me. This says it will at least assign a target to being the default and if one comes along that actually specified that it is then that one will be.
Keep it. https://github.com/mozilla/pdf.js/contributors inaccurate, e.g. Julian contributed more than 2 commits https://twitter.com/jviereck/status/271154213235605504. Some people might contribut not via github, so we shall not forget them.
I think this was way better.
I like the last suggestion best. We don't try to be smart, but just help out in the case of an error ;-)
Zero must have sharp teeth :D
'.so' should be searched in the module_path first: if found, then its a dynamic shared object and the module_name should be the name with '.so' removed; otherwise it's a module_name.
int delta = timeSinceBase / DateUtilities.ONE_DAY;
for(int i = 0; i < ABTestEvent.TIME_INTERVALS.length; i++)
  if(delta > ABTestEvent.TIME_INTERVALS[i])
    timeInterval = ABTestEvent.TIME_INTERVALS[i];
Let's add a comment here and on the TraceTimeline that explains what it is
Maybe include the actual sbt/git commands here?
Can you add one more assert which takes all stream names together?
Can you check indentation here?
Just pass C_NULL to `tmpnam`, and copy the return string.
Ref: https://fedorahosted.org/katello/wiki/I18N

For strings containing more than 1 parameter that need to be translated, we should be using a format similar to : 
_("Params: %s and %s") % [param1, param2] 

vs embedding the ruby variables within the string.
The use of the backtrace in consumer_group.rb was to be consistent with the reset of the glue.  I do see a case in one of the new controller actions where the backtrace could be duplicated; therefore, will submit a change for that (i.e. system_group_errata_controller.rb : def install).
Yes, thats true, sorry for that, I've overlooked that... will remove it.. thx !
Removed this file in master
It was plotting the real values of the whole array. Masked arrays were not making a difference.
What happen if I run marionette with the --b2gbin env variable while an instance is already running?
nit: remove the commented line :)
I didn't mind having the setup/cleanup in the generatorTest() function like in browser_dialer_contacts_search.js
Remove dead code (and white spaces)
yes, this is still in there as originally self was an inheritance from ndarray, so that worked then. As it is not the case anymore now, this should be self.error.
I didn't have anything that fancy in mind.  I just meant that when one time object is converted to another system, it should store the results of that conversion rather than doing the conversion every time the attribute is looked up.  That's what the time implementation I started on does.
Is setting `width[-1]`  here really necessary or desired?  Even if the line is short and filled with spaces, does that matter?  I probably don't understand something.
是哦。。。傻了，我再提一个
`partipates` -> `participates`
Yes, though the BDB version most likely doesn't compile anymore. This was converted from Mike's code which tried to keep compatibility, but that's just an unneccessary burden.
My understanding is that this is well defined.  The implicit type conversion is from unsigned short to signed int, which is always safe.  (Since the short is unsigned, there is no sign to extend.)  The compiler doesn't even blink at this with -Wall, but it does gripe often about the 3 lines in net.h that assign a literal -1 to an unsigned int.
Yes it sucks. Maybe we should simply get rid of socks4 :p
Oh, right, you did this above. Never mind.
Yuck, more global flags?
I was referring to the level values.  They look like you could be using the built-in constants like E_NOTICE etc.
This seems like a good place to use a [@dataProvider](http://www.phpunit.de/manual/current/en/writing-tests-for-phpunit.html#writing-tests-for-phpunit.data-providers).
Couldn't this just be `(?:[0-9]*[\.]{$lnum})`  I don't understand why the alternation is needed.
you dont have to change the test case, since the default value is null, you dont have to provide this second argument.
I see. And by the way, what's wrong with using the NSRails-given `remoteID` property as the primary key? It's there exactly so you don't have to do location_id :)
Yep, I'll do that.

On Mon, Mar 12, 2012 at 1:52 AM, jonlemmon <
reply@reply.github.com
> wrote:

> > +        it "can add a user tag" do
> > +          post :add_user_tag, id: @group.id, tag: "testytag", user_id:
> @user.id
> > +          post :add_user_tag, id: @group.id, tag: "testytag2",
> user_id: @user.id
> > +          post :add_user_tag, id: @group.id, tag: "testytag3",
> user_id: @user.id
> > +          #debugger
> > +          @user.group_tags.find_by_name("testytag").name.should
> include("testytag")
> > +          @user.group_tags.find_by_name("testytag2").name.should
> include("testytag2")
> > +          @user.group_tags.find_by_name("testytag3").name.should
> include("testytag3")
> > +        end
> > +        it "can delete a user tag" do
> > +          post :add_user_tag, id: @group.id, tag: "testytag", user_id:
> @user.id
> > +          @user.group_tags.first.name.should include("testytag")
> > +          post :delete_user_tag, id: @group.id, tag: "testytag",
> user_id: @user.id
> > +          @user.group_tags.first.should be_nil
> > +        end
> > +      end
>
> Thanks for the feedback. That all makes sense to me.
>
> I've never used mocks myself. Any chance you could refactor a test or two
> to include a mock? And/or send a link explaining how and when to use mocks?
> I'm wondering if you're suggesting we change all of the controller specs to
> be using mocks, or just this spec? And what about model specs? So many
> questions...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/enspiral/loomio/pull/16/files#r543364
>
an `hbox` should work here now with a recent fix to Form's generated constraints.
That's accessible via either:
      lib.get_node(self.json, j.RTRUNS)
or:
     self.json['study_info']['runsPerRtVisit']
Where did this bit come from? Nothing else in this pullrequest is S3Upload related
Can you please make sure you have a space after each comma, and around `=`?
I'd recommend:

```python
if keyring_loaded:
    try:
        keyring.set_password('www.google.com/calendar', usr, pwd)
    except keyring.backend.PasswordSetError:
        PrintErrMsg('Unable to save password to keyring.')
```
According to the [Rails docs](http://rubydoc.info/docs/rails/3.0.0/Object#duplicable), the non-duplicable objects are: nil, false, true, symbols, numbers, class objects and module objects.
when yours is merged, i'll do 
```
.render-error, .js-error{
...
}
```

For now, I'll go to sleep.
You'll want a space after "after".
Yeah, that's much better. Still wrapping my head around the internals of the code. Thanks for the tip.
Remove this file too
that's what we do one most of the firefox pages, check out one of those templates. There's an {% site_js %} block you should use for page-specific stuff I think?
This is where feedbparser should come in and display the 5 most recent posts. I assume it will be from the privacy blog yes. Do we have a template tag for feedparser or some other example of how to use feedparser in the templates?
yeah, just search and replace `};` with `}`
``connection`` here shouldn't be an attribute but a simple variable. No ``self.``. (I used to do that as well but changed after Peter's review. )
IIRC returning a string here will render a 200 response, when we want either a 400 or 500.
What do you think @twobraids ?
We always use curly braces, even when they're not necessary
I've restructured the code in the function to always return a clone: https://github.com/bhouston/three.js/commit/ae3164787e7a07ed5c59860fdb8b59f9389a45bc
Also I believe you should use the character itself in UTF-8 instead of using &acuta; and &agrave;
I can remove the message, but I think it's useful when just displaying exceptions' message without exception class
Thanks, I've fixed this now and pushed.
Not a good name.
Upps , you use those space for indentation.
I was thinking something more similar with @schmittjoh's implementation or MimeTypeGuesser here.
Registering predefined adapters in the constructors (at class level maybe to avoid overhead for each new instance.
The first registered adapter that is supported is used (that means we should register more specific/faster adapters first). The current PhpAdapter will be the last registered so we will always fallback to it if nothing else is available.
And then maybe a `register` method (static?) which allows to add a custom adapter (which will be added as the more specific).

I think the end user doesn't have to know in most cases which adapter is chosen. The component should use the best one automatically.
`(` and `)` can be removed, but you need to change check into `null ===`.

Same line below.
Setting the filename like @jalliot mentioned would be a plus. Setting the disposition flag is not enough because you can't control the filename with precision as it is always based on the real filename. The `ResponseHeaderBag::makeDisposition` method works, but I still think such feature would fit perfectly on the scope of the `BinaryResponse`.

Looking forward for this merge. Thank you @niklasf!
I guess we will have to ask @fabpot what he thinks about it.
Honestly what I was thinking from the beginning was adding a `class_exists('Symfony\Component\Process\Process')` check in the `isSupported` (or `isValid` for now) method. People who don't have the Process component could still use the Finder with the slower PhpAdapter and others could leverage native adapters.
That might be even more important when you'll implement the Windows adapter.
This suggests that sympy-bot supports Python 3
```ruby
reg_host = URI(@regsitrationserver).try(:host) 
```
should work here as we are within rails I guess
no need to assign to variable, just return it.

line is too long, try splitting on separate lines:

```
CGRectMake(0,
           0,
           ...,
           ...)
```
There's already a 'is_intra_pool' boolean defined a bit further down in the function - might be worth moving the definition up and resusing that here.
We need to go through the entire app and do this. I've yet to write a test for the app (all i've done is refactor) and this feedback keeps popping up. There are probably tons of places someone was doing this.
We don't display the events the same way, there are small differences.

I will create a cleaner interface when I'll work on custom service checks.
They are only jpeg bytes because you are asking them to be. Can it return pngs? (my concern: PIL doesn't exist on python3 yet, so if we add it as a key "optional" dependency, we are making a future python3 port harder)
This was done to avoid importing pyshp until needed. I think that is a fairly weak reason to do it, but on the other hand, it does mean that some things just about function without pyshp. Its hard to see here, but has this been factored out because it is being used in several places?
Its necessary to limit the line width.
Why did you add these comments?
These calls need to just be ``put(...)``, not ``SASL_PROPS.put(...)``.  You get an NPE as is.
please inherit all classes from `object` (New style classes)
else if (password.isDefined()) {
    config.setSslTrustStorePassword(password.asString());
}

Right? That maintains the previous behavior for those who are expect it.

Actually, better I think is to add a 3rd property solely for the keystore password, with PASSWORD maintaining the current behavior. PASSWORD becomes a deprecated alternative to keystore-password and truststore-password.
I don't think you should be creating a new root here based on the same virtual file as the deploymentResourceRoot. I think you should just be adding these filters to the deploymentResourceRoot, and then using ModuleRootMarker on it.
this is commented out for now. I will remove that method in any case.
Brian suggested this lib as possible sollution since AS already depends on it. I can propably hack something in NetUtils as well.
Does Python not have `private`? I'm using get_abbrev in a different script, but it's not used in books.py or pysword.py.
Oops, I missed that. You could also just use: `$page = substr($page, -(strlen($ext)))` rather than recompiling the page name. Your choice.
it should be \` not \'
could go the list iteration route too, http://wiki.python.org/moin/PythonSpeed/PerformanceTips#Loops

```python
[_save_thumbnails(image, path, conf[key]['size'], conf[key]['suffix']) for key in conf.keys()]
```
nit: alignment sounds weird
No need to do |this._ringtonePlayer all over the place. Make it a local variable |var ringtonePlayer = this._ringtonePlayer;| and use that. That will be more readable and that would also let you get rid of |var self = this;|
Do we need both selectors here?
@alivedise Thanks for the tip!
I thought it was "pushing down" the homescreen, but looks like it does not.

Let me check right away.
Including it... ;-) Thanks!
ok, although I prefer having only one return per function instead of multiples return statements. But in any way I change it too without problem you know more than me I'm sure
Is this going to migrate out to the test framework at some point?
Ok, nothing broken.. Just broken user. ;-)

The 49 second thing is imperfect, but I believe, better than NOT doing it!

Eventually the formula should be improved to know that the check being scheduled has a check_interval of say 5 minutes, to make sure it doesn't get scheduled in the last N seconds of the 5 minute interval. Where N should be longer than 10 seconds, as these may have long timeouts. we could also consider the timeout assigned to a check to determined what N should be! Fun algorithm to figure out, but not really blocking for 1.2.1 !!
Ich sehe da z.B. `automod-1.0.1-pt_br.zip`
It will be handled in the next stage, so I'd prefer to leave it if thats OK?  Its also a little more verbose to those reading the code.
Same carrier return style as mentioned above. Although I guess you won't need the require now that we're inline the two modules that provide this.
Maybe we should instead say "a string containing 1.9.3" or something along that line.
原文では `` ``
require Cacheable directly, not via index
rvmrc files should be already loaded, maybe it would be enough to check:

    [[ "${rvm_ignore_dotfiles:-no}" == no ]] || return 0

I would like to avoid using `exit`, and use returns only.
The binaries installed by composer should be ignored. So you should exclude the ``bin`` folder (except the ``configure_adapters.sh`` script)
We have `"ext-apc": "to use the APC adapter"` in composer.json but maybe nobody read it :P It quite hard to write specification/test when we have such conditions in constructor... it will just break when someone does not have apc installed.
You'll have to do it later anyway.
Would be good to memoize this to save parsing the file over and over.
There is literally *no* downside to binding to `click`. Are we honestly not recommending this to people purely for the sake of aesthetics? That seems silly.
I don't like the dependency on perl, tail, cu and especially bc. I am pretty sure that this can be realized with awk/sed as well.
Place brackets around multiline boddy
The previous version of inst_path only allows to get the installation 
path of staticdocs.
This is to allow getting the install path for the package that is being 
documented, whether it is in development or installed.
As far as I know, staticdocs does not work yet with installed packages, 
but it might be a good thing have in the future.

I use it in citations to get the path to the CITATION file.
I also use it to get the path to the file REFERENCES.bib (other pull 
request).

-- 
Renaud Gaujoux
Computational Biology - University of Cape Town
South Africa


On 20/06/2012 15:34, hadley wickham wrote:
>> @@ -1,15 +1,32 @@
>> -inst_path<- function() {
>> -  envname<- environmentName(environment(inst_path))
>> -
>> -  if (envname == "staticdocs") {
>> -    # Probably in package
>> -    system.file(package = "staticdocs")
>> -  } else {
>> -    # Probably in development
>> -    srcref<- attr(find_template, "srcref")
>> -    path<- dirname(dirname(attr(srcref, "srcfile")$filename))
>> -    file.path(path, "inst")
>> -  }
>> +inst_path<- function(..., package=NULL) {
> What does this do?  (and why's it related to citations?)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hadley/staticdocs/pull/27/files#r1017544
Thanks, my mistake [e35bca6]
OK. The point is about using packet time as source time in offline mode. One bad point here is that TimeGet() uses gettimeofday() which is far slower than time().

Do I cook a TimeGetUnix() function ?
Addon may be unloaded after several windows are closed, so this listeners should be removed either on window unload or add-on unload, depending which one comes first.
Please use function form of `typeof` as suggested by style guide.
Example here illustrates how one can implement `timeout` function for promises, which is quite useful in real world. It takes promise and creates another one and returns yet another one that is resolved to promise that will be fulfilled first.
It exposes `exports` as `loader` but it's a good point, I'll add that.
I'm not sure why do you need to separate `PrefsObserver` and `PrefsTarget`. I'd rather see something like:

```js
const { Class } = require('api-utils/heritage');
const { EventTarget } = require('api-utils/event/target');

const Target = Class({
  initialize: function(options) {
    EventTarget.prototype.initialize(options);
    let branch = Cc["@mozilla.org/preferences-service;1"].
      getService(Ci.nsIPrefService).
      getBranch(branchName).
      QueryInterface(Ci.nsIPrefBranch2);

    branch.addObserver('', function(subject, topic, name) {
    if (topic === 'nsPref:changed')
      this.emit(name, name);
    }.bind(this), false);
  }
})
```
this listener should be removed at some point.
camel case please.
[Fixed](https://github.com/mozilla/browserid/commit/14d4bb9335e5098632c9c5033449519acff78447)
If we match *only* the dot then the `gsub` *stops* at the dot, not removing the trailing X screen number, and we are left with the second zero. But [dbus-launch does remove the screen number](http://cgit.freedesktop.org/dbus/dbus/tree/tools/dbus-launch-x11.c?id=dbus-1.6.8#n114). So the change you introduced seems wrong. But I can be convinced with a working example involving `DISPLAY=:0.0` :-)
Just to be difficult, linux (at least) accepts single quotes to wrap commands with spaces, but Windows does not :-).
This should be :file:, not :samp:
To avoid excessive indentation I would drop this if/else statement and exit early like...:

```
if not listOfRawRows:
    raise OoidNotFoundException(ooid)
column_mapping = ...
```
was this removed or is the diff just weird haha
let's do `return String(str).replace(..` instead
Our coding standards suggest to use single quotes where possible Can you revert this changes?
The || should be on it's own line.
Please comment variables, also add author and since tags to class documentation.
Sorry Sir, I did it. I wanted to make code server for c language. But by mistake, it pushed on github. So sorry for that.
I think this is probably going to cause more problems than it's worth - especially if the system python happens to be 2.5.
TBD: should toArray() be responsible for this btw? if it was toJson() I'd have no objection.. this (datetime to string conversion) is probably often used when we store model to the database. should we not create toStringValueArray() method for this use-case instead - which will try to convert everything into string.
Any way you can include the one in the top level assets folder?
test for the timezone bug unearthed by travis.
@anti t-funkkarit läpi linjan!
Extra line here?
I think 1.8.7 doesn't like the parens here on what is a method call (to `image_uri`) without an outer set of parens. I'm not sure though.
Mne sa ten komentar nepaci, podobne ako napr `i += 1 # zvysime i o 1` - mam pocit ze nema ziadnu pridavnu hodnotu. Alebo naozaj nie je jasne, co robi `*` a `!.gitignore`?
s/2012/2011-2012/
Please read my detailed answer here: https://github.com/getpelican/pelican/pull/551#issuecomment-10133503
This prevents npm from accidentally publishing the package.
fix copyright header, only JT
This syntax seems suspicous. Maybe `new Error()`?
missing MPL 2 license.
Weird spaces around docstring text (and there should be a period at the end of it).
That's what the added CSS file is.
Let me rephrase: where on the site can I see this?
I'd rather do the special casing (i.e. getting a list of stringified group names) for a search query of group objects outside of the class method. So, I moved it out to the view instead.
true, we could "safify" it as a closure argument.
Whoops, I removed that as it was no longer needed. Clearly left this guy behind :\
Could it inherit it from Base?
Would prefer if this was json wrapped (see other plugins). Not a hard requirement though.
how about a variable instead? like
```sh
ifdef WIN32
MKDIR = mkdir
else
MKDIR = mkdir -p
endif
```
And use it like so:
${MKDIR} ...
Someone who was a nitpicker (not me, of course...) might say that the titles for relationship and character should be pluralised, to go with the titles on the work form, and with the help bubbles. ;) (i.e. title="relationships" etc)
The link text should be "contact Open Doors."
Sorry I can't pull any changes to the gemspec.
Would change this to require 'stripe/version'
This default isn't the same as the default listed below.
`pluralTex(NUM_1, "is")` (as of today!)
I'm worried this might not work correctly in all browsers. I've always been more comfortable with `$("#answers")` rather than `$(answers)`
What do you think about making this method final? It's now called inside each of the various log methods (which we want to be as fast as possible), so adding 'final' makes it more likely (all things considered) to be inlined.
Change #test to match new variable name on line 48.
It feels like we should do something to more formally deprecate this and log any usage of the old approach? For now I'd guess that just logging it via the Rails logger would be best, but we might want to switch approach once we have more monitoring tools in place?
https://github.com/delving/schemas.delving.eu/blob/master/itin/itin_1.0.0_record-definition.xml
This seems like the wrong place to style a reservation button?
CS: space inside parenthesis needed + whitespace needed after variable name
do you mean self:: here?
== true
s/visibile/visible
you changed the code, now change this too
but that's coffeescript---we gotta use javascript in the jst :)
I don't think we need to mention the time limit...it'll be the same for each slow query listed, so it seems like noise to me. How about `Slow query detected (%.4f sec); %s;`.
No, this is used, sorry. This is the final confirmation message if everything worked correctly.

http://cl.ly/1B1j0a2B0h0S1N2P3e0b
Maybe use `sender ! 'linked`. It would be one less issue when migrating to Akka. Then again, the whole linking would be different... so, nevermind. ;-)
> I don't think we should push too hard on having DSLs everywhere. in is not a good method name, it depends on having something else around it to understand what it does. So I'd rather make this method findTestsIn, or simply findTests.

I see your point. What made me pick ``in`` is that this is a method in an module, so you will most likely always call it with the module name prefixed. That said, I'm absolutely ok in changing it into ``findTests``.
Why did you add back this code, commented? It looks like it was deleted before. (same for the code scanner).
Ch. 5 iv
If you look at the `GuzzleHttpAdapter` it's pretty straight forward. So either there is something we can configure on the `Guzzle\Http\Client` in `GuzzleHttpAdapter` or this is something that's happening deeper in Guzzle.
Misschien kan het nog versimpelen:

```js
healthBar.updateWith(this);
```

en in de `HealtBar` heb je dan:

```js
updateWith: function(entity) {
   this.track(entity);
   this.setBarTo(entity.health);
}
```
это может очень надолго затянуться, вместо метода проб и ошибок лучше сначала сделать выборку индексов, по которым производить мутации, и пройтись только по ним один раз
Пересмотрел еще раз. Не нашел там рассказ про переменные класса. И на сколько я понял в objective c их нету.
В реальной жизни да, так оно и будет. И если менеджер проекта не уточнил - то и перед заказчиком отдуваться ему. Программист же выполнил всё по ТЗ.
I don't know what "shown in the XDR data" means; I think you can remove it.