labofsahil/github-event-dataset-2012 huggingface dataset:
I was blocked on writing browser tests because tests were broken, but now that's fixed I'm blocked by the solution! If you could explain why mozbrowser needs turning off in some cases, perhaps I can help with a solution :)
I think you need to use `$_SERVER` then as introducing a new setter just for testing is wrong IMO.
Should be in controllers/Statuses.java
LOL winblows support
license header? :)
This code is written to solve the NetworkOnMainThreadException on tablet, but the solution might just be change from static to instance httpClient :)
Vorschlag: Du könntest ja bei beiden Strings schon mal "Beispielformate" vorgeben, z. B.:

Uhrzeit: {Timestamp}, Stichwort: {Keyword}, Einsatzort: {Location}, {Street} {StreetNumber}

Oder so. Wird zwar später noch geändert aber schadet ja nicht für die experimentierfreudigen...
У самого List есть метод addAll
Формат специфицирован, ничего лишнего добавлять не надо.
space around the `>`
他の文章の硬さから言うと
    本コマンドによる
よりは
   このコマンドによる
That sounds like a great idea! I will close this PR and open a new one based on your comments.
I think we usually have author name and paper name
looks like you still have a bit of work :)
Sorry I forgot to clean up. I have pylint turned on, that should give the same result?
I am wondering if QuickSort is a good choice for sorting features. My concern is that it degenerates to O(n^2) when the array is already sorted. The fact is that, as you build deeper nodes, they become purer, which often correlates with purer features as well, which in turn means that you will tend to sort arrays with more and more identical elements. A degenerate case. 

What is your opinion? I remembered that you tried heapsort in the first version of this PR?
Mes tests donnent ... Si je supprime les deux tout fonctionne quand même correctement. C'est peut être ce que je te disais, il me semble avoir install gcc avec gmp. Ils sont peut être lié dans ma compilation du moins. Tu pourrais faire les tests de ton coté?
As discussed, I don't like this ungenericity too much but on the other side don't have an immediate cool idea on how to fix it.
Spricht in meinen Augen nichts dagegen. Bin dafür da es leichter zu lesen ist.
Yeah...its possible as I might have some differences in my coding formatting than what you may have (as I went and tweaked it some).
Thanks for your mention, @andralex . If possible, please see the discussion in [bug 3449](http://d.puremagic.com/issues/show_bug.cgi?id=3449). I think it breaks the *spec* described in TDPL.
This is not the right place to put it, in some cases you will end up skipping the deprecated test and duplicate code unnecessarily. TOKdot should be accepted in the if statement below as well as identifiers.
Test method name `testStreamWrapperConfigN` does not say much... I would prefer if you will rename those test to `shouldConfigureStreamWrapper` then `testStreamWrapperConfig2` can be divided to `shouldAllowToDefineProtocolOfStreamWrapper' and `shouldAllowToDefineWhichFilesystemsShouldBeAddToStreamWrapper' or something like that.
I don't like that this is after doing buffer->replaceInternalData. Better to set local offset and length variables, then read, then check readData.isEmpty(), then do replaceInternalData (if there was no error).
Can you provide the full traceback ?
Let's do something like `$this->bugService = $bugService`, no?
we should really not have whitespaces between @param and @return , that appears to break some tools which we happen to need.. I had to fix many over the weekend.
Agree with var. name change to nextSpillHTE though.
Yes, will change.
memory leak here as well.  I would normally assign to a temp for two calls.
This will detect the exit code of grep, not check.py, which will almost always be 0
why do we have to conditionally create this? why not just always manage the state dir?
and I dont do the jquerty `( path, callback )` spacing :p `(path, callback)` is fine
By placing all aliases into a single repository at the end of the pool you break priorities. Each alias package should keep its original priorit, so it should go into the same repository that the original is in.
should we run each migration individually and run syncdb/loaddata on each iteration with newly created models?
parameterize 2. what does that mean?
`def` määrittelee aina nimen koko nimiavaruuteen näkyväksi. Jos haluaa määritellä nimiä funktion sisällä,  kannattaa yleensä käyttää `let`iä
##### `numpy` casting change

fixed with:

     np.multiply(a, dtype((2**m - 1) / (2**n - 1)), out=b)
What does the `abcd` do here? are these similar to a magic number? Could we use a well named CONSTANT instead?
Minor nit: As before could we use single quotes instead of double quotes.
Needs @exception in the doc. Applies throughout.
@shunter any thoughts on organization here?  I can go either way since we already have some other more general stuff in the root `Specs` directory, however they are a bit lower-level.
Doesn't this belong on `Matrix3` (and `Matrix2` and `Matrix4`) similar to `getColumn` and `getRow`?
- new callback function
Should be `reading` instead of `writing`
Added description for size in the autoFillHeight moduleAPI description.
ditto re 4
We should link to the endian documentation IMO:  http://en.wikipedia.org/wiki/Endianness
On Android, 'focus' is fired when one of the tabs gains focus.
group vars (you can leave the empty line between them for clarity).
Should add to the description that if TopCap/LeftCap is set to 0, the image is scaled uniformly.
At the moment, it isn't possible. I believe this is a future feature though.
Слишком много аргументов  - подумай как уменьшить.
Point taken. I'll update both of these things in the morning.

Sent from my HTC Inspire™ 4G on AT&T

----- Reply message -----
From: "Krzysztof Wilczynski" <reply@reply.github.com>
To: "David Trzcinski" <david.trzcinski@reddog.com.au>
Subject: [puppetlabs-stdlib] Addition of lib/puppet/parser/functions/str2saltedsha1.rb (#67)
Date: Thu, May 3, 2012 12:08 am




> +    require 'digest/sha1'
> +    require 'base64'
> +    raise(Puppet::ParseError, "str2saltedsha1(): Wrong number of arguments " +
> +      "passed (#{arguments.size} but we require 1)") if arguments.size != 1
> +
> +    password = arguments[0]
> +
> +    unless password.is_a?(String)
> +      raise(Puppet::ParseError, 'str2saltedsha1(): Requires a ' +
> +        "String argument, you passed: #{password.class}")
> +    end
> +
> +   srand;
> +    seedint    = rand(2**31 - 1)
> +    salt_hex = seedint.to_s(16)
> +   "000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000" + salt_hex + Digest::SHA1.hexdigest([salt_hex].pack("H*") + password) + "00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
 00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000"

I really did a real-life LOL when I've seen how long is this line :-) Anyway, consider this as an improvement:

<pre>
('0' * 168) + salt_hex + Digest::SHA1.hexdigest([salt_hex].pack("H*") + password) + ('0' * 1024)
</pre>

--- 
Reply to this email directly or view it on GitHub:
https://github.com/puppetlabs/puppetlabs-stdlib/pull/67/files#r761830
vars need to be moved up I think. Also, a newline would help.
DRY:

```
[http://ruby.pe/](http://ruby.pe/) => <http://ruby.pe/>
```
Should also add a comment why it was inlined this way?
Is that really necessary? There was debate over changing the module name, so that would then break the location of the user's answer file...
ну да наверное а что?
:( а мы можем неймспейс за объект же выдать? тогда тут будут `@` и это будет понятнее и читабельнее. хотя может и бредовая идея
if you use "exclude" key on find you don't need the continue
First of all: [composition over inheritance](http://en.wikipedia.org/wiki/Composition_over_inheritance).

Secondly, I don't think `SectionSet` is a good idiom for what is going on here. I'd rename that to `ContentPage`, and then saying "a content page has a collection of sections" makes more sense.

Third, I think that very idiom of `section_set << my_new_section` is a bad idea. Already you are using hash-like properties inside SectionSetPresenter (looking things up by id, etc). What if tomorrow you decide to switch the internal collection to be hash instead?

If this has been implemented as something like:

```
def add_section(section)
  sections << section
end
```

It would be easy to change. Relying on Array#<< as the external interface means potentially breaking external code.
smoking gun: the introduced symbol is a value
This shouldn’t be happening on the branch:  we should be bumping the version on the `master` branch once a new feature is merged, according to the [Gem guidelines](https://github.com/alphagov/wiki/wiki/Gem-guidelines).

Also, it’s a new feature, so bumping the minor version would probably make more sense.
Did you leave this here deliberately?
This should actually be either 

    (defn- defhandler ...)

or

    (defn ^:private defhandler...)
Devia ter feito o controlador com scaffold:

def scaffold = true
E tira fora o index.
Yes, but will validate to True when the retry_with_cleaned_cache is 1, True, "alb", [12,4,5], etc...
I kept fp. If using f_low and f_high, it should be f_low for the high-pass and f_high for the low-pass to be consistent with the band-pass.. which is confusing.
don't think this is correct?
Also, it is possible to view all these TODOs in the IDE's task list - there's a special mode for that.
how about call it byteArray instead of bytes?
`textContains` -> `containsText`

Reads: Elements XYZ contains text ABC
isn't it enough to use following expression?

`driver instanceof GrapheneProxyInstance`
top level cases section isn't required, at least not how it's written now
Shouldn't we remove `sakai.api.Security.safeOutput` in here since we're already doing this in `renderLibraryTitle`?

For me this created a double escaping issue: http://cl.ly/EsiS
I thought native scrollbars were the intended behavior, but I understand now. This will be reverted.
That's confusing code. You want if (PLAYER1_DEAD && !PLAYER2_DEAD) {...} if (!PLAYER1_DEAD && PLAYER2_DEAD) {...} for clarity.
you can use the CmsManager to retrieve the block
As this method isn't in oscar, I can't really merge the pull request yet as it would break other installs.

One option would be to patch oscar to support this method but before I do that, I'd like to understand a little more about why you need to link the shipping method to a shipping address.  Could you expand on that?
исправил, но звучит как-то странно. может "для каждой из последующих строк, которые он перебирает."?
arg... done.
rename ADDED->CREATED
yeah, just ran into this issue when trying to put this in prod. Doing 
that now, thanks for the feedback.
Unnecessary empty line?
For compability. Some components are expecting an object, not an array with one element.
please don't change this indentation
This adds a new public method and as such must be a new minor version.
Yes, we depend on Rails. :)
I think that on one computer (can't remember which project) I had a problem with just res.
this is why i use ${project.basedir}/res
600 seconds = 10 min
Benefits far outweigh the risks IMHO. 
We could warn developers about building the smart sql from data entered by the user to avoid sql injection, although, it's hard to see the point of an authenticated user doing a sql injection to get to data he already has access to anyway.
And what if `lessc.inc.php` does not exist? Should not it check at least if `$phpbb_root_path . 'styles/' . $user->theme['theme_path'] . '/theme/socialnet.css'` exists and if not, create empty file?
Tohle mozna bude potreba zmenit na precteni existujicich souboru a prevzeti jejich verzi
UMIL returns is necessary. We should give some info to output.
Because this is replaced in `jQuery` functions
```js
$sn = {
    init: function(){
		var self = this; // self is $sn
		$('some object').click(function(){
			console.log( self == this); // is FALSE; this is $('some object')
		});
	}
}```
Lets go ahead and update this.
I disagree on which one is easier actually. Based on past experience, including over 3 years in JBoss Clustering support, changing the IPs is much easier than changing ports. It confuses people less and makes things easier to debug. 

You avoid having to do mental calculations on the port numbers when looking at logs. Take a extreme: let's say the port offset is 17. 

So, you have node1 in localhost:8080 and node2 in localhost:8097

vs 

node1 in test1:8080 and node2 in test2:8080

Which looks more readable to you? :)
@nukulb @kwallis Do you guys want this done??
Please remove log statements
Consider to wrap method's content in try/catch.
Unless I'm misunderstanding the last example, multi-line docstrings that start like `"""foo` and `"""\nfoo` are the same... (see the final example).  For one-line doc strings I'm totally on board, but multi-line ones read weird when the summary is preceeded by `"""` in my opinion.
After discussing it offline with David, he confirmed that the transaction was not necessary.

In fact doing a put/get of a single element outside of a transaction is equivalent to doing them within a transaction, the only difference is that the retry happens server side whereas with ndb.transaction you have client side control on the transaction retry.