labofsahil/github-event-dataset-2012 huggingface dataset:
K... not sure what you mean by no but ok...
On Jan 4, 2012 6:02 PM, "Will Keaney" <
reply@reply.github.com>
wrote:

> No.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/CyanogenMod/android_kernel_samsung_victory/commit/265325bba6eb5ba78b2e92de0314cf471d488dde#commitcomment-838586
>
So in the ncdf the normalized data is stored as: ```"float BDC[AS,DE]  Longname:BDC Missval:1e+30"```. I don't know enough about creating ncdfs (could keep looking into it...) but it looks like the matrix is "BDC", with dimensions "AS" rows by "DE" columns where "AS" is number of assays and "DE" is number of design elements. It seems that if you try to write the data matrix back to the ncdf untransposed, it still ends up with these dimensions, not sure how, i.e. whether it transposes it or does something else...

I haven't come across anything saying that you can't store matrices with large numbers of rows (e.g. "DE" in the one I looked at was 31099). I guess that we can't really change it without going to change every single ncdf in Atlas though. I can add to the comments that we transpose because of the way the data is stored in the ncdfs.
See this list for other available libraries:
Yeah this is my mistake. I'll delete it in the next pull request revision.
Y.soon is probably a whole different topic for discussion but I'll try to be brief with comments here.

I feel the speed benefits are worth it.
http://jsperf.com/y-soon-vs-settimeout

I've read the timers used by setTimeout are expensive in other ways.  I haven't tested this myself so this might be inaccurate.  Depending on implementation, they can consume a bunch of memory, drain mobile device and laptop batteries, and add overhead to every turn of the JavaScript event loop.  I feel like any of the implementations of Y.soon from gallery-soon (other than the fallback) would be less expensive, but I haven't done any actual performance comparisons to validate this claim.

As promises are intended to be a low level utility, performance should be a consideration.  I can imagine a reasonably complex app chaining a dozen small promises for one unit of io.  Then if the app does tons of near real time io, the cost of all the throw-away timers is going to add up.

I'd like to refactor Y.soon into a bunch of submodules and use conditional loading to decide one implementation to load.  Then developers could choose to bypass conditional loading and use a specific implementation like MessageChannel, instead of it being completely wasted bytes.  It's annoying that gallery-soon depends on node-base, especially in Node.js.

Y.soon could be brought into core by defining it as the fallback implementation using setTimeout 0.  The gallery will continue to provide alternative implementations to replace that one.
@juandopazo Your implementation of `flatten()` will only do a shallow flatten since it is not a recursive algorithm. We should definitely go with a non-reduce-based implementation. Here's a JS Perf with a couple:
http://jsperf.com/yui-array-flatten

Lodash's implementation seems like the way to go.
Uncompleted comments
This introduces a dependency on awk and is also a bit inefficient. The summation can also easily be done in Perl, e.g. (not tested)

```
use List::Util;
my $size = sum (split ' ', `nix-store -q --size @missing`);
```

It's also possible to prevent a call to nix-store by using the queryPathInfo() function in Perl.
Nice catch, @grunny I'll take care of that right now.
ah, thx
it's a MultiNodeSpec and should therefore be tagged as long-running. It's that in master also.
What is the purpose of this object?
jsessionid should probably be removed from this url?
I think `JavaLoggingEventHandler` is a good thing. An advantage over slf4j with j.u.l. is that it doesn't require any dependencies, but I guess it solved some problem also.
this will need to be fixed to use the actual appropriate address, right?
What will be the capacity for nodes where the metric is undefined? Do you have a default value when you call capacity and check for an Address?
Or avoid Strings altogether and provide a function from (T, Int) => Int to ConsistentHash.create (then you can hash the address and the path name completely without having to create any new strings, just use Murmurhash and `extend`. Wdyt?
I'll change another usage in `Serialization` also
nope, see implementation, also for traversals.
we would make import scala.collection.immutable.Seq part of our copyright header :-)
we must watch out for `Seq` anyway
I'm seriously thinking how this could be auto-checked. If not by scalastyle, with regexp, perl or whatever, part of the build.
File containing `Seq` must always contain import scala.collection.immutable.Seq
this should probably use `sync/atomic`
This will need a little help to work right now.
Hrm, so we *do* have a directionfinder... then why is its functionality duplicated in the ODF methods?  Sorry if I simply overlooked something important.
<pre><code>
url = base.h.url_for(
action='proxy_resource',
controller='ckanext.resourceproxy.controller:ProxyController',  
...
</pre></code>

* The "action" parameter tells url_for what method (pylons calls them actions) of the controller it should use. This refers to the method on controller.py:24 and it has nothing to do with the CKAN logic layer actions
* The "controller" parameter points url_for to the right controller
Figured you would, it's your influence at work. :) My first instinct was to make it a DTO but I'm really happy with how it came out being able to send itself to the server.
my mind.
fixed~
Also worth noting that this logic doesn't hold for options that are defaulted in the runner `__init__()` kwargs. That stuff should maybe be explicitly handled.
*bikeshed:* I'm wondering if `:block` is the best choice for key here, or if it should be `:wait` 

`lock(:block => true)` vs. `lock(:wait => true)` 

any opinions @eric @ryanlecompte ?
what's the commented lockedSet.add() about? what does the comment apply to, the commented code or the if?

why do you need this check of lastIndex != r.index?
I'd rather see this left as None in the default case. The later check;

  if max_requests and request_cound >= max_requests

should still be valid.
I don't know what `ABS` is, but it seems wrong when `fabs` exists.
This method still needs to be reindented.
No. That's a behavioral change as well.
Not a big issue, but you could probably lose a space before the description here so it lines up with the next description.
Like I mention in the other pull request, it'd be nice if `wait()` could be cancelled. It'll serve as the most typical example of how to implement deferred methods.
ah! pure laziness, in the second case, it should be:

```
_, name = ...
```
Maybe NPY_UNSAFE_CASTING_WARN ?

Also the comment formatting should be

    /*
     * blah
     */
Don't we want a legend for the feeds? This can easily be achieved by configuring the styleMap for the feed layer with a rule.
convert_to_string_ex afair :)
Is that ``\`` supposed to be there after ``-b``?
I suggest 
    
    expires: statement.cache.expires
пробела перед присваиванием не хватает
Перенеслось почему-то
Should this be `=~` ?
Why set the `"size"` to nil?
Asset cleaning has been removed from the pull request, see above
We should indent the `=`
"Is that a donkey or a baseball?"
Yeah it's a bit tricky since I can only return one value (short of returning values via pointer args). I could introduce a special return type for this function, but that seemed overkill. I reasoned that if you preceded or followed the isEmpty call with any other calls to QueueFile_XXX functions, these would fail?
Hmm. I wanted something that would just return an image without any axes, title, etc. and there didn't seem to be an easy way to do it in the current setup. I don't really like the idea of having a separate plot function either, so the plan was to add it and then combine/refactor it later.
You can also sometimes get into trouble with positive vs. not negative if it happens to be zero (or non-negative or non-positive).  So use the one that is correct for zero.
Ah, so this is where it's used.
Well, I've left some "old-style" examples somewhere, just for the sake of diversity in examples (since they often show one almost one and the same thing).
This was already tested above?
Why does this not use `glom` (which is imported but not used in this file by the way)?
https://bugs.php.net/bug.php?id=10721

> This odd character is quite intentional, and is there in order to ensure that any functions created don't clash with user-defined functions.  You can see in the code that this extra NULL byte is accounted for and deliberately being added, it's not a coincidence :)
Well we could remove the warning logging...
No particular reason. This part is only intended to give a reasonable stability to pressure solutions in the incompressible case, and the current code achieves that well enough.
I don't think it's an issue in these cases where our model query is so simple. If it were more complex, with scopes, conditions etc, then I would expect it to be in the controller.
everything in the config database is only used in the context of sharded clusters.
Is this `sitemap.py` actually necessary any more? Looks like everything's done from the cron task.
Rather than doing a full-on `save()`, it would be better to just do an `UPDATE` query. You can [use the Django `update()` queryset method](https://docs.djangoproject.com/en/dev/ref/models/querysets/#update) like so:

    Document.objects.filter(pk=doc.pk).update(is_redirect=1)

That results in a simple SQL `UPDATE` query, and won't bump `modified` timestamps or trigger any of the other things that automatically happen with `save()`
Give the checkbox input an id and make {sessions.KEY} a label for that id.
That is how set_config() is initiated in install/install_install.php a couple of times
unnecessary space between topic and comma ```topic ,```
@igorw For an example, please see this proposed update to naderman's example extension: https://github.com/naderman/phpbb3-example-ext/pull/8/files
In the `controller/main.php` file, the handle() and foo() methods return non-empty Response() objects, the content of which is sent to trigger_error(). The bar() method uses the standard output method of using the template system.

Note that I had to add an argument to page_footer() (in this PR) to allow it to skip the exit_handler() call so that it can be used with extensions without exiting before a Response is returned.
Needs to be updated to the current edition of this line, see any of the other files probably.
Unnecessary and only covers some of the cases. Perform unlink, check return value, use error collector to obtain any php spam produced.
#801 has my suggested fix.
I'll read the docs on underscore.  I don't know what idiomatic JS looks like.
Oops, this shouldn't be here
this comment needs updating, it isn't ignored, it is shoved into a metric :)
fixed in 299079b
unneeded brakets
coma is extra here. also moving, not move. also capabilities is more correct here.
Also, typo Insead should be Instead
Не точно. Имах предвид да е top-level като `when a user is not logged in`.

Но всъщност, ако искаш го остави така. Пак е ОК.
I'd argue for just have the index.js rather than two files if we're going to follow convention.
Well, there are other implications on this one. Can we merge this and later on discuss how are we going to deal with collisions and multiple requests? /cc @drewfish
No page title?
These three functions should be refactored into one function that takes a parameter string and index
You will .sort(string) and .setUi('decline') on the index passed in
```print``` and ```print2``` are vague. Would be better to name the action appropriately.

For example:
```action=print``` might instead be ```action=fillPrescription```
and 
```action=print2``` might instead be ```action=printPrescribedDrugs```
(I should probably delete most/all the console.logs)
We should be doing a search on the encounterType using its uuid and not its name. 
Thus, it should match encounterType based on its uuid (which we can assume to be unique)
It might also be useful to have a validator that can validate that the encounterType.uuid exists in the database... but may be that's for 2nd iteration of the module
Can you clarify on this change?
No. I don't want us to depend on yet *more* data in our tests.
`Plugin/Foo/` would have it's own `composer.json` (if it's an install package). This is only for the APP's package file.
in case of error, you would need to check ferror
I'm fine with it as long as it's possible to use the default cacert on the system rather than the bundled one. Some people claim that sometimes the system cacets work when the mozilla certs don't (I've never encountered this or seen proof of it though). Maybe setting CURLOPT_CAINFO to '' on a request's curl options would achieve this. I guess this would just need to proven in a unit test.
`function(data, type)` => `function( data, type )`

I'm going to skip the rest... there are plenty.
True. Do you volunteer to write it? :)
Since you have been "using namespace dbal::eigen_integration", "ColumnVector" instead of "Eigen::VectorXd" is preferred. Also "Matrix" instead of "Eigen::MatrixXd".
s/ar/assoc_rules/
modified to use consturct_array
BTW: I use a PostgreSQL hash table here (as opposed to a C++ hash map) because it will eventually be garbage collected when its PG memory context is deleted. Therefore, no C++ destructors would be called and using C++ objects (unless they are [plain old data (POD)](http://en.wikipedia.org/wiki/Plain_old_data_structure)) would result in undefined behavior. The SystemInformation, FunctionInformation, TypeInformation classes are therefore POD.
translate3d here too
return type should be const ref or a pointer
Don't ask me how I came across this one . . .
Using Filter instead. Django created a key relation in the database which we don't want. Instead I added name and user fields to the Expectation model.
Why RuntimeError?
These should not be here. This is a bug on reddit's end.
Ага, так лучше :)
Nah, 1 line per run makes sense. Just checking.
Also, line 5 is wrong, there is no ms implementation
`page = page.lstrip('/')`
Hm. I think it would be hard to do. I'd prefer to at least try and keep the state exactly as it was before we enter the context manager. You never know what the upstream user is expecting, in principle. It could also be that when the context manager exits, the user is expecting the canvas which was assigned during the `with` lifetime to never be written to again.
What I mean is, just make api_username a method that extracts it from the options.
Still doesn't feel like a win. :(  What's the left-hand of a plus operator in math?
Same here - don't comment out lines but feel free to remove them. We'll always have the Git history in case we want to get back some lines from the past ;)
The Menus code only calls PopUpManager.addPopUp() once during initialization, so I think we'd need to change that code to call PopUpManager.addPopUp() every time menu is displayed to make this change.

I believe everything is working with no memory leaks, but if we want to make changes like this, then I think we might want to push this issue to the next sprint.
Also, I thought we weren't going to tackle submenus yet. Might be best to leave them out unless we think they would significantly affect the basic design.
not sure what I was doing wrong, but it's now fixed.
That's fine (although jQueryish folks are used to that kind of ambiguity--they're used to the fact that (generally) the thing being assigned is the first thing in the chain, because everything else just does `return this` to allow for chaining to continue).
maybe just:
`return callback(new Error('changeLive isn't supported'))`
I see now, yeah it makes sense, to migrate from "scaling_bloom" -> "dabloom", at some point in the future
I like 'if ARGV.length.nonzero?'.
What do you think?
Of course you are right. I don't even know why I added that.
Message is also displayed when user logs in with Facebook.
Perhaps you should only check for the `status` key, as we don't really care what exact text is in the desc (and then we can reword it without breaking the test).
Should you have `root: null` here for self-documentation?
Same as the note in cornfield/app.js, if this variable isn't being used for anything then nuke it
As far as I know webkit is the only one that has kept it prefixed. I could be wrong.
Actually, just use a regular for loop here? It is faster.
Why do you want this change here? Won't this strip out licenses that might matter, or is everything the exact same license?
Inline style.
Why not use
```coffeescript
@list.find(@options.slidesSelector).eq(position).before(slideHtml)
```
in all cases?
Actually, only `'TestFlight.h'` here would be enough
Yes, Foreman support both and have it configurable.
Right! I am not done with headpin testing yet, thanks.
Never any regions
I'd rather not for that reason. There aren't many instances. The tests should point to any inconsistencies.
Handling it this way decreases code duplication, because I can handle parsing a single unit the same way in the context of pyparsing and outside of pyparsing.  I don't think the exception catching overhead is problematic.  There's a great (but perhaps out-of-date) benchmark of this here:

http://paltman.com/2008/01/18/try-except-performance-in-python-a-simple-test/

Noteable for this case:

```
3. If it is likely that the element does exist, then there is a very slight advantage
to using a try/except block instead of using has_key, however, the advantage
is very slight.
```
See below.
I am still sure that you could merge it and save 1 line of code, but the logic is easier to follow this way (at least for me), so I am wiling to invest that extra line of code.
Ah, ok, yeah it make sense to wait - so for now we should *not* port any of the releaser stuff to the affiliated package template, then, I suppose.
Why not just have the RPC call be the last expression in the function?
There's no need to name "static" labels that will not accessed in the code...
Btw, I think I found out why this was a problem with gcc and just pushed a tweak which should remove the associated clang warning
Yup i think that is better, i've commited the suggested changes.
Examples need to be updated
As specified in your issue yes (equals for me).
yes, http://dev.regiogis-beo.ch/sbrunner-regiogis/wsgi/?debug
This seems wrong to me. It makes it more difficult to merge criteria together as you have no way to distinguish an undefined first result (which should use the previous value) or an explicit 0
Use a typedef or "auto" keyword
this will be quite ahrd to debug. i wonder how we should do that in general?
ah, i think i put that in because there was no test for it, and you added a test at the same time in t'other branch, will clean
`5s` instead of `%s` in the format string.
I don't think this will work right with most editors because they'll wrap the cursor at the end of a line. What about moving the cursor left to the first column and then using up/down arrows to change lines, then moving right? It's not as clever as terminal but it'll work in vim and emacs unless there are tabs present.
I don't think this needs to be a method on the shell, as this module is already pretty big. I think a function in `IPython.core.oinspect` is probably the way to go.
oversight.  will correct that
これは不要な気もしますが、無いと動きませんか?
Tests for corner cases (e.g., 0 elements, 1 element)
Not yet, the page is en-US only, and while I'd still mark them up with l10n stuff normally, they aren't really final yet either.
And that's in the request--got it. :)
Solution would be to simply do a `pass` on the `except NoSuchUuidFound` and de-dent the line `raise CrashIDNotFound(crash_id)` two steps.
it's either insanity or senility -- that's nuts
чому? треба щоб не вилітав ексепшн. форма нормальна. тут вічаплоадер щось хєрить
This depends on TwigBundle as you are now using the ``{% render %}`` tag
for an interface, you could use ``$this->getMock('...')`` directly. Disablign the original constructor is useless for interfaces as they don't have one
the ``Traversable`` check is useless here, as it will never be reached. traversable objects are also objects
Just a nit picking: defining a variable which is used just once does not make much sense IMHO, I would use $('#uid-error') call directly.
You should probly keep the resume caching.. its a pretty hefty load from the storyboard.
This `event_id` method returns an `Event` object. Should be renamed.
I tried this and it didn't work, but perhaps I fat fingered something. I'll try it again. 

I've tried both leaving off the partial and leaving off the locals hash independently and both failed actually.
瓦擦，你还会使用createSingle，不错啊～
'bottom',123  应该是 'bottom':123

另外，如果传入的 是 {'top':0,'right':0,'bottom':0,'left':0}是否符合？
You're right, happened to some other characters as well, see 144 etc. No clue how that happened, but is there a way to fix that now?
Why hide this away? It looks like a routine that might be of interest to end-users.
var k is safer, just do it in both for loops
It should also indicate that if you type the scroll name again, it will remove it. eg. "Which scroll would you like to add / remove? (blank to finish)"
You can just remove this.  You almost never want to leave commented code in your repo.  If you want to go back to how the code was before, that's what git co <old version> is for.
why not calling the option ``enable_search_split_words`` or something like that ? we already have afffirmative names, for instance ``allow_single_deselect``
oops, i foudn a typo. i will fix it in a commit after this pull request is done..save-resize-small should be .icon-resize-small
String interpolation, and can use => on `@render` and remove the need to pass in a context
This block is just completely useless. Look at HTTP client instead of hardcoding strings, e.g. see HttpGet.METHOD_NAME.
Convention is that variables starting with an underscore are private. Obviously nothing enforces that. And note also the existence of properties.
I just read the article you suggested. I admit, it's pretty interesting.
Anyway that's not the case pointed out by the article, so i would prefer keep using the shorter (and IMHO more-readeable) syntax
为哪样必须要有个时间才能不能用vpn，应该开始不得值，然后必须给他值并且有效才能用啊
As i told you via Skype, my comment is invalidated :D you should do in the way that is already done, thank you!
...set({
  'icc.stkMainAppMenu': JSON...
});

To be sync with the style you use for sendStkResponse.
These event handling should go to `SystemDialog` itself. Window Manager should not handle them here.
Included ;-) Thanks!
Declare self where it is used. This is usually a good practice that helps code maintenance too. Also in this case it would same some memory in the case where you return early because of the value of fastEnough / farEnough
What about using a data attribute |banner.dataset.crash = 'true';|. In order to remove it you can simply do |delete banner.dataset.crash;| in the transition callback.
pattern match here instead?
UI じゃないので「」ではなく "" にしない？
Why have a Timer class if you're not using it?
а чего через лямбду? никакие ж параметры не передаются
давай так

    scope :public_attachments, where(public: true)

и еще, давай просто public, все расно вызываться будет Attachment.public, или может event.attachments.public - то есть все равно видно что это аттачменты
please lowercase ``null``
这个文件的冲突需要解决
This should be up to the developer to figure out, imo.
The var is already defined in globals.h.
Please take out the print statements.  We just want it to print out statistics at the end.  Printing *during* a test is a very bad idea as it can corrupt the data.
Yes, we only have info before switching to error.
These lines are identical to those at line https://github.com/jamescasbon/PyVCF/pull/42/files#L1R106
Perhaps factor this out into a method: would then be clearer what is happening here.
I've tried to remove this file too, but during installation it gives me error on line 356 , "INSTL_ERROR_INITIALISE_SCHEMA".
Leaving an empty files let me complete installation.
Yes. Is that OK?
This is API is complicated for no real value other then just being OOP. Could you please just create module level functions like:

- `add(list, item)`
- `remove(list, item)`

And then make use of it simply by passing list to it:

```js
Array.slice(arguments).forEach(function(item) { add(list, item) })
```

In general I'd recommend to use namespaces only for storing data properties and not for the methods.
Obviously you'll also need to export add / remove form this module.
@lloyd - We need to review both the TOS and the privacy policy for the "name/photo" feature already, so we can ask about this.

https://bugzilla.mozilla.org/show_bug.cgi?id=755732
any reason that we would not use the `TIMESTAMP` field of mysql?  like we do for staged.ts?  It shaves 4 bytes and is symmetric.  we don't get MS resolution, but I don't think we care, right?
This line and the next seem wrong, they are using the old standalone scripts instead of the manage command
Since there's a build step you could do it there, if the machine had yui, etc.
i tried that, and `rm` took like 10 minutes with 450k files lol
I need `(.*)` here as I'm using `$1` after matching with that regexp.
ok, did not search for that
`FileUtils.rm_r` indeed works with dangling symlinks (it uses `File.unlink`), but `mspec`'s `rm_r` won't: https://github.com/rubyspec/mspec/blob/master/lib/mspec/helpers/fs.rb#L31

`rm_r` seems to be an often used helper in rubyspec, so that's why I used it upper.
Do you think it makes more sense to use `FileUtils.rm_r` instead of `File.unlink`? I think the latter is clearer on the intention.
Do you want I modify my comment such that it mentions explicitly it's `mspec`'s `rm_r`, not FileUtils's one ?

In any case, this is clearly a bug of mspec's `rm_r`, which I will report.
In the end I thought kernels were being forked when "evaluate" was clicked, aka we have an execute request. Unless we implement a pre-forked pool of kernels, I don't see why one would ever exist without having something to execute immediately.
On Tue, 1 May 2012 14:02:19 -0700, Sarah Hoffmann wrote:
>>
>> -		$sDatabaseName = 'nominatim';
>> -		$aSpec = array(
>> -			0 => array("pipe", "r"),  // stdin
>> -			1 => array("pipe", "w"),  // stdout
>> -			2 => array("pipe", "w") // stderr
>> -		);
>> +		// import generated change file
>>  		$aPipes = array();
>
> Shouldn't that line go into the else above as well?
>
Looks like a no-op to me. I'll test if it still works with this line 
removed.
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/twain47/Nominatim/pull/4/files#r758598
adding some comments on the params of the class would be great. (just like the comments before ArrayDirectedGraph)
Why do you rewrie this part?
Why ? ternary operator is bad for the code coverage
It sounds to me like we'll need to regenerate packages once this is merged -- is that correct?
@jmikola Yes, like Writer\Db::setFormatter() : it's the same case for me.
@Maks3w so FirePhpFormatter supports datetime format if you don't raise an exception? Silent errors it is very wrong (or the evil) IMHO!
Should we keep this consistent with Checkbox, which has default true (or vice-versa)? IMO I like default true.

If it turns out that there are no differences between Checkbox and MultiCheckbox elements, do we really need MultiCheckbox? Same goes for Radio?  Or is the intent to have an element per form input type (even if the classes have no overrides)? cc @weierophinney
True, but why have it here?
Why this should be removed?
This is a huge function declaration. I would consider removing those function pointers and assigning them in wherever you create xKIChat. That should only happen once (I think--I haven't actually seen that yet), thankfully.
Also add one more new line after this one.
Unfortunately, no. That one does not account for the git settings used. I now derive it from how the heredoc string is present in the file.
Single-quotes.

Use a `ENTER_KEY` constant instead of 13: 

```js
ENTER_KEY = 13

...

if evt.type == 'keyup' && evt.which == ENTER_KEY
```
since Props adds the prefix in, we need to take them out here (if we want to use the plugin properties directly)
Good to know.  Also, this file was committed in error 'cos we aren't using it - it was part of an initial sketch for how the UI might work.  I'll remove in a new commit (and be tidier in future).
Not sure if this should be part of the core. Maybe a simple tool could get the results from lyricli through a pipe and do this instead?
@harjis D.R.Y. Eiks tää ny palauta just samaa ku kyselyt ja $presult rivillä 334?
@samiluukkonen Ei kai ny sentään?
well, it is more logical to support this case than the case of Doctrine being installed as a deps of your project IMO, as ``--dev`` only installs deps for the root package, meaning the testsuite will work only if your project requires Console in some way
Is there somehow a possibility for us to prevent multiple instantiation with consecutive calls to ->expr()?
Maybe we could use a private property to help on this task
you should typehint the interface
`...` will be represented internally as `{ :"...", line, [] }`. It is already available in master!
You do not need these comments
:-1:
I don't think the solution (in a project with fewer than 500 LOC) is to start including additional libraries all over the place to facilitate simple functionality.
define constants on top of the file.
this is now "method" : "getLoggerLevel"
I assume this is in here for some circular dependency reason or something? Can you explicitly mention it so someone who thinks they're smart doesn't bother trying to move it out?
This can be just <pre>eventType</pre>.
This list should have a space between the punctuation and the names.
why?

just use: consumer.tell(Start, sender)
Looks like a string to me.
Can you make the dots black? When they're blue I want to drag them around…
These don't seem to be used. Can they be removed?
@stof It seems they are necessary. Both properties are needed to recreate the changes in the Schema, but neither are exposed by any method. 

The `AbstractAsset$_quoted` property is necessary to know if a column or table name should be quoted.

`ForeignKeyConstraint$_options` is necessary to create a new foreign key. The only way to retrieve an option is to know its name and use `ForeignKeyConstraint#getOption` -- and thats just for a single option. Is there a comprehensive list of available options?


Both could be easily solved in DBAL, but that would make this non-BC for everything except the next version of DBAL and later.

Thanks for your feedback. It's very much appreciated!
Fix bug where externalSorting could never be turned on (referencing wrong config property)
Doc please, and also on $namespace.
It does make sense. Thank you for the explanation
This is wrong, really wrong....
какой-то не очень эффективный способ хранения..
Watch your whitespace/indenting
Should be `OPENSLIDE_PROPERTY_NAME_COMMENT`.
The BODY_TO_IMU is defined straight up for the Quadshot, but in rate control it is more intuitive to control it like an aircraft. To do this the sticks need to switched.
I have some of the functionality sitting in my repo as port of the rest api work.
Can you add that as a comment?
I think we should lean towards having more initialization logging rather than less. I think all other modules may have initialization logging now. I purposely wanted a log configuration that held the log configuration in the "pre-initialization" log, and then a log entry in the new log saying that logging initialized correctly.
We should probably wrap all this up into the IO module. Something like `IO.destroyBrokenStream`.
А если в ДНК стоит А и выпадет опять А? То будут заменены не строго все Х процентов.
Затраты на поиск объекта в массиве будут возрастать с ростом объема массива. При больших значениях процента (особенно если длину ДНК сделаем не 100, а побольше) это нехорошо.
В обсуждении задания фигурировал гораздо более "легкий" по ресурсам метод сортировки отдельного массива в котором изначально присутствуют все индексы.
Категория должна была находиться либо в классе Cell, либо, что еще предпочтительнее, в отдельном классе.
Конечно не критично) Ты, как и я, выполнил эту задачу ещё давно, поэтому вопрос не в формальной правильности решения, а в нахождении оптимальных методов и вылизывании кода, познавая особенности нового языка)
Если уж так, то и твои замечания к моему коду совсем не критичны, но интересен же взгляд со стороны и объективная критика.

Кстати, как замерял время? Профайлером?

У меня в профайлере 98-105 ms при 100% мутаций обоих ДНК из 10000 элементов на младшем МБП 2009 года. Не то чтобы я тут фаллометрию устраиваю, но как-то так.
same here. I won't point it out anywhere else :)
BUGSNAG_RELEASE_STAGE shouldn't be here? It's aggregated from the required fields above.
depois podemos criar routes pra melhorar isto. /id/$id é péssimo
FUCK, I saw it just after merging
the x-slides is a container, where the CSS transformation is applied.  this affects all the x-slide tags nested within it.  by declaring these tags separately, it keeps the references to them clean in the css and javascript code behind.  it removes the need for an ID tag and/or class designation.  This widget is a port of the original slidebox element, that included them.  They've been kept for similarity's sake.
dispatch_get_current_queue has been deprecate in iOS 6 and will probably be removed completely in the next release. Please don't use the current current queue. Either use a global one or have an overload of the API that allows the queue as an argument.
That would be neat although I'm not sure worth it when we can just use backticks. However, that should probably be discussed when we write the damn thing! (Related: we should probably do that soon)
@codyhoag After this step of clicking the Publish Gadget, it would be good to show an image of the dialog.
`FIND_RENAMES` being the default, passing null would be enough there
The test repositories (*TestGitRepository* and *TestEmptyRepository*) are now hosted under the libgit2 organization. Could you please replace the `nulltoken` url segment with a `libgit2` one?
Now that I think about it, I didn't see any unit tests that used these parameters. It looks like they return the outcome of this method, which makes it odd that they're being passed in.
I didn't understand how the old tests used to pass, given that this typo was in there.
if bad_file is not None:
```
$ node
> var osenv = require('osenv');
undefined
> osenv.tmpdir()
'C:\\Users\\Sean\\AppData\\Local\\Temp\\'
```

Looks correct to me.
A url like this: http://gardenerslist.herokuapp.com//items - that doesn't have a username throws a 404.
When I say 'ruby' i mean =ruby (in zsh), not rvm (or rbenv) version of ruby. So I think it's better do something similar to:
```
pmodload 'helpers'
is-callable ruby && ruby --version
```

I hope you agree with it
I fixed this because I wanted to add new styles to an existing attachment and then reprocess all of the existing records to get the new styles generated. I use the `:hash` in the filename, and `:updated_at` as part of the `:hash` as is the default. Using the existing rake task without this fix, it just ate all my images. Everything would be regenerated, but `:updated_at` never got updated, so everything would get lost, even the originals since it's no longer possible to generate the correct hash.

I did not change any previously working behavior with this pull request. `#reload` never worked. It only appeared to because the test was broken. It's not feasible to fix `#reload` without breaking lots of other stuff, so I just removed the test.

It's also impossible to fix the reprocess:missing_styles rake task, but I just left that instead of deleting it. Someone must have wanted it at some point. The problem here is that `:updated_at` gets updated on `#reprocess`, but it's only saved per attachment, not per style, so either you don't update `:update_at` or you have to update all styles at once.

Either way, all of this code is one huge mess of bugs, and this pull request is the first step to fixing things.
And what about in this specific test? @dummy does not respond to :updated_at.

On Tue, Jun 12, 2012 at 2:36 PM, Geoffrey Hichborn
<reply@reply.github.com>
wrote:
>> @@ -1090,12 +1090,6 @@ def do_after_all; end
>>        assert_equal now.to_i, @dummy.avatar.updated_at.to_i
>>      end
>>
>> -    should "return nil when reloaded and sent #avatar_updated_at" do
>
> @dummy.avatar.updated_at should just return @dummy.avatar_updated_at, whatever it is based on @dummy's life cycle.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/thoughtbot/paperclip/pull/914/files#r969696
Can it have multiple Channels?
no, it is part of an implicit, the user-level API is onRouteDefinition on the Consumer, which allows you to customize the Camel route for the consumer at definition. http://akka.io/docs/akka-modules/1.1/modules/camel.html#intercepting-route-construction
Ah, I thought propertyIsEnumerable would be consistent with for … in!  How about creating two temporary objects with {}, and copy both a and b's *truly* enumerable properties so that our friend hasOwnProperty can be used instead?
Хардкод цветов — отстой. А если у кого-то другая тема?
Cuál es el propósito de esta clase? Si todo se va a especificar de afuera, se justifica el reuso?
Tenés razón. Ya mismo lo mando.
oh :+1:  good to note this !
remove the reasons
please be more precise, use `$request->request`
I'm gonna bitching a little here, but can you put a carriage return here?

```objc
- (void)synchronizeLastEventId
{
...
}
```
This is a terrible idea.  I think it should be bar, instead.
This code was moved from elsewhere. Done regardless.
Jos `inits` ja `tails` palauttavat alkiot sopivassa järjestyksessä, on voi tämän kirjoittaa:
~~~clojure
(defn rotations [a-seq]
  (rest (map concat (tails a-seq) (inits a-seq))))
~~~
Yep, this just fine. But it would be a nice exercise to do this without `count` :)
wouldn't this also apply to SQL Server ?
I'm not picky on which.
http://www.chicoree.fr/w/Interroger_le_DNS_avec_Python#Mise_.C3.A0_jour_dynamique_du_DNS
I introduced this in 37e3851ec451a4d63ba03bfde84c070999b6ab3f. I hadn't appreciated that the axes (or rather, the axes' object id) was intentionally part of the key.
We should probably update this web address to matplotlib.org.
I think there is an rcParam for that....
See above re: avoiding panics in the type assertion and avoiding unnecessary map field lookups.
we could click this 2 methods in one by adding a bool argument 
<code>def click_signature(self, index, valid=false):<code>
would <code># find the index of the first non-empty signature</code> be a better comment?
Ugh, I suck at typing alarm ;)
SAPUI5 is too huge to host in same dir as app. So will assume / suggest a 'definitive' dir to use as convention: '/sapui5/' like this:

```html
<script src="/sapui5/sap-ui-core.js">...
```

And each user can replace that with whatever is relevant for them.
changes in memory? Are you saying that it's mutable? And what does "refactor" mean in this context? Does this belong in the docstring?
Should keep the `else` on the previous line.
oops, editor was using spaces instead of tabs. probably have many whitespace mistakes. will correct :)
I'm not sure if replace is undefined, will it create it in the global scope? Should var be used instead?
rake always loads the bundle anyway
this should only ever be `true` or `false`, no?  you can ensure that if you pass `!!enabled` above instead of just `enabled`
this one can be placed outside 'unless' block
This is because HTML markup is used in the script (also a leftover from 3.0), can be refactored as well I guess.
I wanted to enable the Agent specific code to handle --help.  Otheriwse I'd have to handle it in the main virgo_init.c, and I don't think we have enough information there to print things like where the docs URL is.
Are you sure ``$rootNode`` has the correct type as ``object<Symfony\Component...Builder\NodeDefinition>`` is not a sub-type of ``object<Symfony\Component...er\ArrayNodeDefinition>``?
- Are you sure ``array(' ' => $thousands, '.' => $decimals)`` has the correct type as "array" is not a sub-type of "string"?
- Are you sure you can call ``strtr()`` with the given parameters? It seems like at least the 3. parameter (``$to``) is missing, no?
I'd let the properties be just strings and let the user set them to whatever string they want. I don't think we'll always have delimited strings here.
Den PK haben wir ja als request uri, z.B. /beers/15 drum bin ich mir nicht sicher obs überhaupt noch einen parameter braucht.
Ah, I see.  I suggest removing it, as the shortcut doesn't really save any typing.  It's good to keep the entry point count low - at least early on.

But as usual, no really strong opinions on the matter. :)
I wanted to show here, that if you do pass all arguments without names, then they must be ordered.  How about

    // optional arguments must be called in order if not named.
I noticed this an one other debug print ("done here") were emitting at the staging site.
To avoid the costly `count` and `==`:
~~~clojure
(empty? (filter (complement pred) a-seq))
~~~
Same as above but only applies to fetchObject().
I'd probably err with Christophe and agree the double parenthesis on simple operators like this is a tad excessive.
Changed it to be an auto property using an local variable for the 'out' within the Set {
No, it's the default recommended from http://pragprog.com/book/bhtmux/tmux. I agree with you for the most part, but the generic tmux configuration is super complicated and does not cater to the "average" user. These settings are more geared toward a general audience, and the people who need different settings will have enough experience to change them, if that makes sense.
Falta indentar
just noticed this we should label it something like ".parse(fn)" to reflect the feature
(In my approach.)
You should make diff time update itself as time passes.
Why are you doing this manually? And not through `urllib.urlopen`?
Should maybe `<div>` itself go to the template from where the form is included? And only `<form>` and its content stays here?
No need for additional file. Just put it into `home.js`.
`self._meta.object_class =` could be better than `self._meta_object_class`, no? ;-)
Testing again?
Dammit. This means I'll probably need to add scripting support for these.

SIGH.
I think the DecisionTreeWorker should go into its own module the same way the SessionManager did.
I wonder if it isn't a tab vs. spaces issue...

If you end up doing a new push, I wouldn't mind if this was addressed, but it's not a big deal...
I hope your decision was not a bad one :p
See https://github.com/cloudmine/cloudmine-ios/pull/23/files#r1299094
Should we add a note here about contrasting this with the live nodelists returned by getElementsByTagName, etc, or does that just muddy the waters here? (cc @addyosmani)
Yes, nestLevel is not an appropriate name. What is the [] construct called? It is not scoping? Either way this var should be renamed to something like. nextNestMarkerIndex
Oh, that should probably mentioned somewhere, but having a look at other commands you'll find out that we have the `validate` method which takes care of validation of the input. You should put what you put in the `message` method in there instead. But in your specific case, you don't even need to do this: You can use the "property" class attribute (like here: https://github.com/mozilla-services/circus/blob/31ab93047859588b2d94a5ff71d877d7a99715d2/circus/commands/sendsignal.py#L103) which makes the properties required.

Also, if you do that, there's no real need to check that there is "name" in props, and you can just do "get_watcher" + run on it.

The `message` function is used to return information about what happened after the command. Since this is a fire and forget thing, you don't need this so you can just get rid of this `message` method.
That's a good observation. Maybe we should tell them apart via separate
commands?

/kzu

--
Daniel Cazzulino | Developer Lead | XML MVP | Clarius Consulting | +1
425.329.3471


On Mon, Mar 12, 2012 at 21:45, Craig Wilson <
reply@reply.github.com
> wrote:

> >          {
> >              if (this.State == SagaState.AwaitingPayment)
> >              {
> >                  this.State = SagaState.Completed;
> > +                this.commands.Add(new CancelSeatReservation {
> ReservationId = message.Id, ConferenceId = message.ConferenceId });
>
> I understand that cancelling a reservation and expiring a reservation do
> exactly the same thing... however, the business meaning of the two things
> is very different.  One means that a user cancelled the reservation while
> the other means that the system cancelled the reservation.  Is there a way
> in this form to tell the difference if we need to investigate a customer
> complaint?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mspnp/cqrs-journey-code/pull/12/files#r549314
>
andá _pro_ ahí
Why the extra spaces before the =?
I have decided to change it to snake_case, but won't get around to it until this weekend, do u want to wait until then to merge?
Pacman is available on many more Linux distributions and operating systems than Arch Linux, including [Mac OS X](http://www.archmac.org/).
This file would greatly benefit from some comments explaining what's happening :)
What if, somehow, filename contains HTML characters? "<blink>" Then this would break. The filename should probably be HTML escaped (apf may have something for that, otherwise an easy fix is `filename.replace("<", "&lt;")`.
Empty line before.
nit: else location
I'm glad we've finally landed on XHTML as the markup, since we're closing these br tags!
I think this check should be moved out of the use_shear block so you can check that the user didn't pass in any extra kwargs along with a _valid_ shear.  e.g.
```
ell = galsim.Ellipse(shear = shear, x_shift=1, g1 = 0.2)
ell = galsim.Ellipse(shear,shift, x_shift = 0.3)
ell = galsim.Ellipse(shear, g2 = 0.3)
```
etc.
I can push the changes I suggested: I have a version here, to check it still worked before making a silly point!  But I didn't fix the draw_stamp docstring...
Good point.  I should check for other obsolete comments of that sort.
I agree w/ Reiko.
Ok. Will have to read bout this.
we don't actually set the username and password on the node object, right? This is passed into our LWRPs and read from a data bag I thought
Well, I could just _always_ include it =)  Then it won't be mysterious and will be safest.

On Dec 15, 2012, at 9:37 AM, Sef Kloninger <notifications@github.com> wrote:

> In main/c2g/models.py:
> 
> > @@ -1667,6 +1667,16 @@ def past_all_deadlines(self):
> >      
> >          return datetime.now() > compareD
> >      
> > +    def load_mathjax(self):
> > +        """uses a regexp to figure out if the rendering of the exam needs mathjax
> > +           the regexp are rough, but should not have any false negatives.  (at
> > +           worst we load mathjax when we don't need it.
> > +        """
> > +        if re.search(r"\$\$.*\$\$", self.html_content) or re.search(r"\\\[.*\\\]", self.html_content):
> Sure, I understand false positives aren't tragic, could just be a mysterious tough-to-debug performance hit if/when it happens. I'm OK with this.
> —
> Reply to this email directly or view it on GitHub.
> 
>
Is 2 seconds a good timeout?
True. But this was existing code.
Personally I'd just include one of these two lines of javadoc, given they are the same for the method description and the return description.
Missed converting a null-check? Should this be `(Strings.isEmpty(ssl.certificateDestination)) ? ... : ...`
Wrong indentation. But too minor to worry about blocking the pull request for it.
have access to plutot que write down ?
Dont get the 1- prefix part?
I think this function is still needed to handle static asset detection and correctly handling static theme assets.
same check, check for 'yes' and 'no' before running
I had to rename this to 0005_... as it clashed with another 0004_ migration.  You may need to tinker with your south history to get this working when you merge master back in.