labofsahil/github-event-dataset-2012 huggingface dataset:
Can we not do that further down in the value-handling functions? MySQL does similar stuff for NullBooleanFields currently without a feature flag, and it works fine.
There's a minor issue I noticed:

Since there's no `ORDER BY` on this query, I noticed that multiple runs of the same demo produced results in a slightly different order.

First result set: http://pastie.org/5487752
Second result set: http://pastie.org/5487754

Here's the diff: http://pastie.org/5487756

I think ordering by `asset_ref` would be a good idea; that way the resulting XML is always consistent. What do you think?
The fact that different call sites ignore some of the values returned by `getSandboxInfo` suggests that they should only call those functions needed to produce the values actually used.
I dunno. I think having addons.rb reaching into PgUtils seems a little envious.

I thought about both ways and settled on this one as the least surprising.

When I was first looking through the code, I found translate_fork_and_follow and was like WHY ISN"T THIS WORKING! ... 'cause it should have been. An ack for translate_fork_and_follow took me to this code. Wiith everything encapsulated inside of translate_fork_and_follow all of the logic related to that is in one place, not 2 (inside and out).

With that said, if you really want the check on the outside, I'll be happy to move it there to get this included.
There looks to be some duplicate code around for traps that need to hook additional at-exit functionality (reset terminal color, set echo).

Perhaps an initial trap to avoid messy output and then another one as needed.   This would reduce the probability of "it threw an exception, the service must be down and i hate you forever" support tickets.
There's no benefit after it passes through gzip. We can trim off two bytes by adding a private parameter to `.css` and returning `jQuery( elem ).css( type, value, extra )` here, but I'm absolutely **not** getting behind that mess.
Are you sure? The second request is executed from the `done()` callback of the first request. `start` is attached to `fail` of the first and `always` of the second.
We need a better name than `internal`.
I agree it's worth finding out. But then, even if maintaining a temporary table could be done in no time, the speedup is at most 2.
This function can surely be implemented with random() and some other existing PLPGSQL facilities. Actually, for demo purpose, I originally wrote a version leveraging random()/generate_series() with PLPGSQL. But that function's performance is much worse than this C implementation. (Ten times slower)
Fixed:

        throw std::invalid_argument("Must be used as an ordered aggregate, "
            "in ascending order of the second argument.");
Also this is bad.
Preferred way to do this is:

```rb

system "make", "install",
               "--always-make",
               "DESTDIR=#{prefix}",
               "SBINDIR=#{sbin}",
               "BINDIR=#{bin}"
```
This has to be done as a separate argument, e.g.

```rb
args << "--no-edit" unless ARGV.verbose?
```

because `system` is invoked as (essentially) `system "git", *args`, so there is no shell to do arg splitting for you.
Ok. What does it do? Can you link to the issue?
Hmm. What does [Semver.org](http://semver.org/) says about that?

> A pre-release version MAY be denoted by appending a dash and a series of dot separated identifiers immediately following the patch version. Identifiers MUST be comprised of only ASCII alphanumerics and dash [0-9A-Za-z-]. Pre-release versions satisfy but have a lower precedence than the associated normal version. Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92.

So I'll stick with using a dash, and rubygem guys should update their version numbering strategy ;)

Can't you replace the dash by a dot using a regexp? I know it's a far-from-perfect solution, but I'd really like to keep the version number into a single place.
formatting here should be changed to have function call indented under try, etc.
Il faut que tu utilise les formats et passe les arguments en paramètres pour que les données soient sécurisées.

Par exemple : https://github.com/payutc/server/blob/master/POSS2.class.php#L243
This seems to be compiled on every msgidExists call, basically every time a message is requested. I see that this can be precompiled once for each jed instance.
At the time of observation, this star had been used as an acq once and that acquisition had been successful.
Sorry, I somehow dropped off this thread.  I'm trying to keep up with GitHub traffic, but my latency seems to be on the order of weeks these days.

I feel that with Comparable being part of java.lang, it makes sense to support this in core assert.  I've written one-off comparison assertion methods quite a few times.  I'm also much more mellow on Hamcrest these days: if someone's willing to be the champion for the latest JUnit working with the latest Hamcrest, and will set policy and accept bugs, I'm not going to stand in the way.

I think that Dotmesh is unlikely to grow beyond a niche usage: there's too many places where it's just too magical.  cgruber and I have also proposed github.com/truth0/truth, but I'm also not sure that has enough advantages to pull its weight.

So....

I think that something in Assert about comparables makes sense.  That said, given "assertLessThan(X, Y)", I'd have a hard time being 100% sure whether I was asserting one thing, or essentially the opposite.    Without that being solved, we're in deep water.

The DSL option would probably be jarring to people used to being able to examine one method's Javadoc and see what's happening.  I'm not totally against it, but want to be sure we examine the whole space before jumping to that solution.

What about something like:

assertComparable(x, LESS_THAN, y);

?
Is there any way to do this that doesn't involve throwing an exception?
Can you think of any issues this may cause if someone actually wants to assign something to `null`?
Since this is really a model operation, I think we should go through Document here (i.e. `this.document.getLine(endLine)`). We should (ideally) only access `_codeMirror` from Editor for view-type operations. (Though there are probably other areas where we're violating that rule today&mdash;we'll need to clean more up if/when we have a real separated model.)
What you're saying makes sense, but won't $("*") return every element in the entire Brackets DOM tree? I think you want to limit it to the panel that's being resized. We can talk about it more when you push up a pull request.
I think this logic would be better in `_normalizeKeyDescriptorString()`, since that's actually where the logical loophole is that causes the problem--i.e., it should be treated as a workaround for the fact that we're splitting on "-", and we should explicitly test for the case there.
Ideally we don't need this if we use 'a' instead of 'span'
remove $ and window
I hear you on the incomplete sentence issue, I'd prefer it otherwise as well!

With regards to the specific action the idea was to not give any false impressions. All this code does is call this._onLostContent, which (due to subclassing) might be a different version than the one in the same file. This comment might therefore become outdated without any chance of the author noticing the discrepancy (and is, in fact, flat out wrong for MultiRangeInlineEditor.js, where a different _onLostContent gets called by the same code).

So I'd propose to replace "just close" with "call this._onLostContent" or something less literal - but I'm definitely open for counter positions!
Could we do that style of docs for _keyMap in addition to _commandMap?
See comment above regarding leaving this as `undefined` instead of using -1.
Check out LocalTime.MIDNIGHT
Added comments. This is more heuristics than pure math, but I adjusted the starting scale and broadened the mults arrays to help ensure equivalence with the original algorithm.
How come you called str on it? The ids are already strings (or unicode).
"must be zero or positive."
"can contain", not "can contain"
Why... is this here, actually? It's a reference to a removed video on youtube...
make 2 var declarations into 1
After adding the `<html>` wrapper we're only left with a string. Giving users a DOM tree to manipulate seems much more friendly than forcing them to deal with HTML source.
I get yelled at for not putting local imports underneath 3rd party imports
`key, val = changes[fn_].items()[0]`?
With the merged changes, if the poller successfully polled(line 145), the loop would never be broken.
This is as of bfa5ab188ce59b3ccad5737b937813dcebc9d8a9 fixed.
The problem is that Nexus main pom uses 4.8.x in DM and that results in failures.
%ud -> %ui
we never specify eta values in config which would underflow Java float's rep accuracy, and the value is generally up-casted to double when used, e.g. in CachingCVB0Mapper when constructing TopicModel instances.
I assume this wasn't intended?
What failure condition is this `try` catching?
I'm not sure how I got away with this.
I don't think it is necessary to translate test tools.
Clean what up?
"join" is not the right word, here.
Look into using .live() or .bind() instead of .click()

It works better for when you're adding and removing tags dynamically.
There is no meaning to the numbers themselves, but I thought it would be good to remain consistent with the built-in Python logging module. We could keep the numbers private, i.e. setting the level (via set_level or configuration file) could be done via words (e.g. ``set_level('debug')``) which would be more explicit, but the use of numbers internally makes it easier to check if a message is more important than the threshold. However, I'm open to suggestions!
I'm fine with it not being in this PR, though it should be pretty simple to implement for SDError, e.g. (untested):

    def validate_shape(self, shape):
        if np.isscalar(self.values):
            return True
        else:
            return self.values.shape == shape

where ``self.values`` are the standard deviations. Then in NDData, you just need to call ``validate_shape`` rather than just checking the shapes directly. But feel free to postpone this if you want.
This is the current count of 'in flight' objects we've sent that the client has not acknowledged.
Does is matter that this is after the no newline?
It's a copy. You're right, it would be nicer with const&.
If this is a constant now, how can you write to it in line 1426?
It'r rebased to upstream master, so it should be. Why do you think it isn't?

Sent from my Nokia phone
-----Original Message-----
From: Philip Kaufmann
Sent:  17/05/2012 16:41:01
Subject:  Re: [bitcoin] Parallel block download (#1326)

> @@ -2396,6 +2393,21 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv)
>      }
>  
>  
> +    // Ask a connected node for block updates
> +    if (!pfrom->fClient && !pfrom->fOneShot &&
> +        //(pfrom->nVersion < NOBLKS_VERSION_START ||
> +        // pfrom->nVersion >= NOBLKS_VERSION_END) &&
> +         nAskedForBlocks < 8 && !pfrom->fAskedForBlocks && !CaughtUp()) // TODO - tune
> +    {
> +        nAskedForBlocks++;
> +        pfrom->fAskedForBlocks = true;
> +        printf("initial getblocks to %s\n", pfrom->addr.ToString().c_str());
> +        pfrom->PushGetBlocks(pindexBest, uint256(0));
> +        NodeSummary();
> +    }
> +
> +
> +    if (strCommand == "version") ;

But in the end this pull is not mergable like it is?

---
Reply to this email directly or view it on GitHub:
https://github.com/bitcoin/bitcoin/pull/1326/files#r839082
So its not needed to strictly respect the "return string" return type?
Can we at some point make the router be responsible of the infections? It is annoying having to remember how to inflect the words when you just need to use the correct controller name
Carful => Warning
I wasn't able to replicate this, but can see how it might occur. I will probably use a slightly different way to ensure the user is not signed in for WebDriver, but may leave RC as it is as it should not suffer from stale elements.
What's the reason for this change? This is locating the body element, which we don't interact with.
git ignore still does'nt work ;/
Isn't it simpler just to do `HOME = os.path.realpath(HOME)` unconditionally? If it wouldn't trigger this `if`, then doing it unconditionally would make no difference.
Yeah, tox is a little bit inflexible at times. If you want, I can remove the `tox.ini` stuff from this PR. Or I could keep it but just remove the `readline` stuff.
log configs should only be in src/test/resources...
A few more cases where we can keep 'enabled'.
Maybe set a `visible` property binding that makes it only appear for the non-supported entities? Then you can push that and so the support for monsters and NPCs in another change.
@nuisanceofcats I am exporting this hooks array so that larger rewrites can be moved out into sub modules that import hooks and can push more functions into the array.
Nothing.  It just reports errors with context, which makes it far far easier to debug this sort of thing.
If URL starts with '/' (relative) it returns "FALSE" therefore condition is not satisfied
This should get changed to:

    tags.order_by('name')
Waiting for response from @whimboo.
__whimboo__ wrote:
> So with this dataURL the NetUtils.asyncFetch() call will throw an exception? ...

No, it doesn't. But the example below ...

        Components.utils.import("resource://gre/modules/NetUtil.jsm"); 
        NetUtil.asyncFetch("mailformedURI", function(aInputStream, aResult){
          Components.utils.reportError(Components.isSuccessCode(aResult));
        });

... throws: [`NS_ERROR_MALFORMED_URI`][1]
> [Exception... "Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsIIOService.newURI]"  nsresult: "0x804b000a (NS_ERROR_MALFORMED_URI)"  location: "JS frame :: resource://gre/modules/NetUtil.jsm :: NetUtil_newURI :: line 198"  data: no]


[1]: https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIURI ""If the string cannot be parsed as a URI, NS_ERROR_MALFORMED_URI thrown.""
Would you mind to make this logic a bit more easier to understand? Right now it's kinda hard to see how long the while loop will be running. So instead of negating the condition change it to: `while (self.result === false && !self.timeIsUp)) {`.
Why not use `config.somethingSomething` here? In fact, don't tell me. Jot it down as comment :)
Ok, in the context of a streaming request body the end just seems really awkward. Thanks for the explanation, all makes sense now.
IMO, you should add a separate factory for now instead of hacking the form_login one.
I guess @elnur could take a look at how it is done in the method Symfony\Bundle\SecurityBundle\DependencyInjection\Security\Factory->createAuthProvider()

There a new definition is created in the DI container for each instance. I guess that the same thing needs to be done here.
This tag requires to have TwigBundle anyway. So the case without TwigBundle is still broken
Ok I see what you mean.
Is this much better than retrying with a fixed time out?
I like it. Will add.
А почему не работает? Решение декрементить счетчик в контроллере не очень нравится
R/O : CountedPtr
What? While this code path is *unlikely*, it's not altogether impossible, and there's zero harm in checking for it.
Hello,

The library names mimic the file name.  The intention is to recall the 
characteristics of the ECF and prevent errors.

The name suffix have the following meaning:
* -safe : full void-safe library
* -confident: library settings adjusted so that a voidconfident system 
can be built.  The libraries settings are - at least - full class 
checking and attached by default.  When possible, the voidsafety level 
is 'initialization' instead of 'none'.

A voidconfident system has those general settings
- full class checking
- attached by default
- on demand void safety

Yes the names are long.  It's the price I propose to pay for clarity.

Best regards,

PG Crismer


Le 21/11/2012 16:35, Jocelyn Fiat a écrit :
>
> In library/gobo-core-confident.ecf:
>
> > @@ -0,0 +1,29 @@
> > +<?xml version="1.0" encoding="ISO-8859-1"?>
> > +<system xmlns="http://www.eiffel.com/developers/xml/configuration-1-10-0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.eiffel.com/developers/xml/configuration-1-10-0 http://www.eiffel.com/developers/xml/configuration-1-10-0.xsd" name="gobo-core" uuid="C8E29BA5-FA2D-4088-A05B-82AFF31B8E3B" library_target="gobo-core">
> > +	<target name="gobo-core">
> > +		<root all_classes="true"/>
> > +		<option warning="true" full_class_checking="true" is_attached_by_default="true" syntax="transitional">
> > +			<assertions precondition="true" postcondition="true" check="true" invariant="true" loop="true" supplier_precondition="true"/>
> > +		</option>
> > +		<setting name="console_application" value="true"/>
> > +		<library name="base-safe" location="$ISE_LIBRARY\library\base\base-safe.ecf"/>
>
> I am not sure having -safe and -confident in the library's name is needed
> I don't really mind, but it makes the name longer
> But if this helps catching issue like using non void-safe lib in 
> void-safe application why not.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/gobo-eiffel/gobo/pull/3/files#r2195200>.
>
Sure, that's fine. Thanks for digging into it.
"breaks the the whole"

"the repeated"
var style = image.style;
@jlebar Let me write a separate e-mail for you on this.
Yes.
Now sleep menu set the absolute of icon image path when request for the list menu.
what does pageHideBySwipe mean? if you are in Evme view and you receive home button event, is always pageHideBySwipe true?
I added those line to the shared/js/mediadb.js, @davidflanagan you can take a look at it and see if I am doing right.
I think it is enough checking <tt>el</tt>. Could it be having a valid parent but no offsets?
And here a `p`
http://openid.net/specs/draft-jones-json-web-token-07.html#anchor5
We should initialise this.isDecimalSeparatorPresent, and set it to false instead of deleting when necessary
nit: aName -> name
Perhaps we could refactor this in a single sentence:

var addressInfo = fbdata.current_location || fbdata.hometown_location;
if (addressInfo) { out = fillAddress(addressInfo); }

Works for you guys?
I'm afraid we're not properly rebased if we see this change here...
I had originally tried to borrow some CSS properties from keypad-icon for keypad-subicon, but it didn't work out. I can remove this...
nope!! forgot it there when testing :shameForMe
Nit: shouldnt be on a line break
Same as before, create a local variable and use it for app.manifest.entry_points
If we create DOM element first, we should both add 12/24h pickers for preparing CSS selector.
I don't think that is a good way.
I prefer to create these element in JS.
Sorry, I think my previous comments got lost...

Yeah, a CountMinSketch works like a Bloom filter, so if the CMS says the frequency is zero, it's a true zero. (but not vice-versa)
move to ``data``?
This is consistent with the python commenting since the """ in python is
the last line in a comment section of the function. Here I use that extra
#. I've tried to be consistent in all my comments, please point out any I
may have missed.

On Fri, Nov 16, 2012 at 9:10 AM, Chris Bunch <notifications@github.com>wrote:

> In AppController/lib/app_manager_client.rb:
>
> > +   #
> > +   # Args:
> > +   #   app_name: Name of the application
> > +   #   app_port: The port to run the application server
> > +   #   load_balancer_ip: The public IP of the load balancer
> > +   #   load_balancer_port: The port of the load balancer
> > +   #   language: The language the application is written in
> > +   #   xmpp_ip: The IP for XMPP
> > +   #   db_locations: A list of datastore server IPs
> > +   # Returns:
> > +   #   The PID of the process started
> > +   # Note:
> > +   #   We currently send hashes over in SOAP using json because
> > +   #   of incompatibilities between SOAP mappings from ruby to python.
> > +   #   As we convert over to python we should use native dictionaries.
> > +   #
>
> To make this consistent with other Python and Ruby documentation, either
> remove the extra lines or open an issue about this inconsistency and one of
> us can do it next sprint.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/AppScale/appscale/pull/99/files#r2154053>.
>
>



-- 
Navraj Chohan (Raj)
PhD Candidate @ UC Santa Barbara
http://cs.ucsb.edu/~nchohan
http://appscale.cs.ucsb.edu
http://nlake44.posterous.com
Include the URL you tried to fetch from.
"Done stopping app #{app_name}"
OK, but why?  It seems unlikely that this object will have a prototype, but if it did do we really want to ignore it?  An inherited error should count the same as a regular error, right?
http://archive.installgentoo.net/g/?task=search2&search_media_hash=JzttJtC%2FvUvmRiXJ0abzDg%3D%3D
Valid concern. The method `fetch_publication` method is used the `RootController` and the `ExitController`.

Should we place `./lib` and rename the module or better to put it in the `ApplicationController`?
Actually, I'm not sure what this is checking, if `buildset` is `None`. It looks like it asserts that that `expected_*` are `None` and `{}` respectively.
the substr is wrong. The goal of the feature is to allow having a query string for the path (see the PR)
Since `Rails.root` is a `Pathname`, this also works:

```
require Rails.root.join('lib', 'federation_logger')
```
Fix some strange errors on some crazy gcc versions such as gcc 4.2 on amd64 platform.  See!
http://tldp.org/HOWTO/Program-Library-HOWTO/shared-libraries.html
Since this is HTTP only, it should go in the `director.http.Router` constructor function.
1. maybe admin_users_path
2. too long string with condition at the end. Please make it more readable
why not do a strcmp here?
this is broken in the case there are no dependencies
updates to client code for new signature of CompleteRegistration()
I am wondering if there is a cleaner way to load the templates but still produce the desired results.

Instead of the extra housekeeping, it would be nice to be able to do something like:

```
res.send(templates.dialog())
```

Adding the extra functionality to templates.js feels like it would junk that abstraction up.
But the property is always present, it's just a boolean now right?

> data[entry].isIncremental = isIncremental(data[entry]);
You should simply make home_page.header_region.type_in_search('job board'), because this method does not return anything.
If _get_validation is expensive, we could pass the `rules` parameter directly to validate_param and convert_param.

The problem is that they are public, while `_get_validation` isn't. That's easily solved by having a private version that accept the `rules` param directly, while the public one still uses the method.
That issue appeared when I created an example module in Ruby DSL and `init.rb` file was evaluated more than one time.
These aren't very useful either. We don't add tests for all the possible arities that could fail, only the specified behavior. In general should_not raise_error is almost always not a useful spec.
I'm curious: why the try/except block?  Do we expect it not to work sometimes?
The core extensions have been taken from ActiveSupport. Therefore, if AS is included we should choose that implementation over the ones we have defined ourselves.
What happens if swear.txt doesn't exist? You need to handle that gracefully (print some error and exit) rather than crashing. 

I'd recommend opening the file with: 
```
try:
    with open('swear.txt') as f:
        for word in f.read().split():
            # do things with word...
except EnviromentError:
     #print error, exit, etc
```
with 'with' keyword ensures that that file object f is closed, even if exceptions are thrown.
btw, using the behat.org composer repository will simplify your work to install Goutte as you will be able to require ``fabpot/goutte`` and rely on @everzet's work to define all deps instead of having to copy-paste them.
This line doesn't seem to do anything?
Great.

Yes making helpers private is nice for communicating intent. I should be more consistent myself in the `logic.clj` but the details of the cKanren support are still changing.
all functions and helper functions are dieing on their own in EAPI>=4.
Copyright 1999-2012 :-b
This deserves at least some documentation on the python side (not in pelican docs, but in a docstring here).

It seems strange to me to have a method _from_settings with a "get_page_name" argument.
Please use a multi-line string here, 80char's wide is recommended, but we allow 120 chars.
This isn't right, you can't create this app from an archetype. I've reverted locally.
Imports should be grouped in the following order:

    standard library imports
    related third party imports
    local application/library specific imports
pls update all the occurrences
other than the spacing lgtm
Works for me. We can always tweak it later.
erm yes...
Also some weird whitespace here.
was something i put in there for debugging...removing.
I've done that, hopefully in the correct places (both py2exe and py2app seem to require the respective OS which I don't have at hand).
We can't seem to fix the way the parser marks up blockquotes combined with paragraphs, but this will at least fix the way it looks by mimicking paragraph styles even when there's no paragraph tag.
Let's simplify/optimize and replace lines 93 and 94 with this:

```JavaScript
for (var i=locales.length;i--;) {
```
is_active is preferred, I think - it's the active field on the user, is_authenticated just tells if a user is logged in.  is_active can be toggled by an admin to "remove" a user.  for us it probably doesn't matter very much though...
For aesthetic reasons, this would read better if it was `if(!isTitleCase(value) && !isMacro) {`
I'd just keep the modules stuff instead of rewriting all this and building something custom. That gives you much more flexibility
This default isn't the same as the default listed above.
I'd go with "Let x be the first number in the sequence"... but that's just because that's the usual first step in a math proof ;-)
This causes warnings
I'm still not convinced by this.
Not use "json_encode" function, now is Botstrap::json_encode
http://en.wikipedia.org/wiki/Isabelle_Adjani
+1 for adding this in the BC doc.
I'm not in love with this mehod too... What do you think of this other proposition?

``` php
$prefixLimits = array(
    'LONG'   => 16777215,
    'MEDIUM' => 65535,
    ''       => 255,
    'TINY'   => 0,
);

if ($length === null) {
    $length = $prefixLimits['LONG'] + 1;
}

foreach ($prefixLimits as $prefix => $limit) {
    if ($length > $limit) {
        return $prefix;
    }
}
```

Anyway, if the length is lower of equal to zero, what do we do? Return the biggest value ? throw an exception?
публичные методы сверху пишут, чтобы их можно было прочитать не вдаваясь в подробности
Yeah, probably, but consistency is good.
You seem to have misspelled debug
Actually, I think those "support" properties are not necessary as long as the "homepage" is up to date.
On Thu, Aug 02, 2012 at 05:53:59PM -0700, Chris Price <reply@reply.github.com> wrote:
> > @@ -0,0 +1,87 @@
> > +;; ## JDBC helper functions
> > +;;
> > +;; *External code should not call any of these functions directly, as they are*
> > +;; *subject to change without notice.*
> > +
> > +(ns com.puppetlabs.jdbc.internal
> > +  (:use [clojure.string :only (join)])
> > +  (:import (com.jolbox.bonecp.hooks AbstractConnectionHook))
> > +  (:require [clojure.java.jdbc :as sql]
> > +            [clojure.tools.logging :as log]))
> > +
> > +(defn query-param->str*
> 
> I mirrored this after the clojure.java.jdbc stuff, and it seems consistent with their patterns to me.  @grimradical if you agree with nick on this one let me know and i'll go rename all those methods.  Personally I think it makes it clearer that they are `internal`, though.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/puppetlabs/puppetdb/pull/243/files#r1298768

I'm +1 on @nicklewis suggestion. I think that the asterisk, at least
in this code base, represents a function whose entire existence is in
support of another function...there basically little-to-no utility in
calling them on their own. Most often you see that in macros that need
a helper function; you don't want to put that inside of the macro
(because macros are kind of hairy enough as-is), so often times people
will make a variant of the macro in function form. See
`com.puppetlabs.utils/keep-going` as an example.

We should give this function a proper name, I think.
I think we should reverse this so the comment is added to the Comment CF first, and then to the CommentsByContent CF to make sure that a non-existing comment is not added to the comment list for a piece of content in case something went wrong. However, looking at, it might be possible to do this in a batch query.
Can you document what this file is doing?
Done.

I've also refactored the image utility a bit so that the cropAndResize does the validation up front.
These should probably be name instead of description
Shouldn't this test check that ``listLike`` is **not** in the returned proposals?
Note to self: What are these trailing spaces, remove it!
Oh, you can use the `*Computer` hierarchy for general purpose... so you can disregard the comment. Though I'd be more comfortable if the method wasn't private, it's too weird :)
hmm but further down we do check for a RouteObjectInterface: https://github.com/symfony-cmf/Routing/pull/25/files#L0R139
don't like this... we should parse once at the top of the stack (in requestUploadsForUser)
I've tried you'r branch and it works for me with only `zendframework/zend-http`.
Do you use the latest composer version?
As this file is empty, please remove it.
перепроверил, вот что получилось ( genomeLenght=15 чтобы компактнее)
первый столбец это r = arc4random()%(self.genomeLength-i)+i;
второй arc4random()%self.genomeLenght
 13, 0
 7, 0
 11, 13
 13, 3
 14, 4
 6, 10
 7, 7
 8, 13
 8, 4
 9, 14
 12, 3
 13, 11
 14, 8
 14, 9
 14, 10

в твоем случае рандом генерируется из остатка от деления рандомного числа на self.genomeLenght-i, и к нему еще прибавляется i (поэтому в конце все значения ближе к максимуму)
я по прежнему ничего не понимаю

а что такое t в комментарии выше?
Okay, I think this is simple - 
I should add checking of this condition = 
if (percent =< 0) { return; }
@Senior-Student да, с конкретной реализацией ничего плохого не станет, но при большом количестве элементов может быть ой. Тем более, что стек ведь используется общий, это хорошо, что у нас простая задача, но ведь до твоей рекурсивной функции тоже нужно ещё дойти, и поместить какое-то количество возвратов! В любом случае, рекурсия оправдана только для заведомо не особо большого количества итераций.
Отлично, моё предположение было верным. =)
Почему бы не сделать class method?
как я понял это работает

unreplaced_indexes это массив из цифр от 0 до 99

в строке **30** перебор, столько раз сколько надо мутировать генов, ок
в строке **32** получаем рандомное число, (arc4random() % unreplaced_indexes.count значит оно ограничено сверху 100 на вервом шаге)
допустим это число 10
в **34** получаем число из массива по индексу, кстати в этом массиве по интексу 10 лежит число 10, по 20 => 20 и т.д
**35** - заменяем, ок
**37** - удаляем

а что произойдет если рандом в строке **32** выкинет опять число что и на предыдущем шаге? что будет по этому индексу в массиве unreplaced_indexes?

И еще вы именуете переменные в разных стилях (unreplaced_indexes, newReplaceIndex) по-моему читабельние придерживатся единого стиля (кстати  в Obj C, все функции в кемелкейсе (addObject, removeObjectAtIndex) )
чтобы вывести ДНК в одну строчку используй NSLog(@"%@",[self.DNA componentsJoinedByString:@""]);
Even though this line is commented out, we may want to change this to say Sprint 13 so it will be caught in any global searches.
упс
ref. http://ruby-doc.org/docs/Newcomers/ruby.html#logical
This will work on K3 but won't work on DXG because there is no MX in /proc/cpuinfo. We have Hardware like like:

K3:
[root@kindle root]# grep MX /proc/cpuinfo 
Hardware        : Amazon MX35 Luigi Board

DXG:
[root@kindle root]# grep Hardware /proc/cpuinfo 
Hardware        : Mario Platform
Can we move this class outside the on_load hook? We could define it outside of the AR like this:

    module OrmAdapter
      class ActiveRecord < Base
        # ...
      end
    end

And then inside the load hook we simply do:

    ActiveSupport.on_load(:active_record) do
      extend ::OrmAdapter::ToAdapter
      self::OrmAdapter = ::OrmAdapter::ActiveRecord
    end

Wdyt?
    end
Not sure what the industry standard is, but I might suggest `redirect_to root_url` for clarity, and avoiding the use of strings-related redirects
`int` here, please.
I had hit an issue running the ```CanCloneARepository(...)``` tests where the test would create the SelfCleaningDirectory object and register the temporary directory path for deletion, but the test would fail in ```Repository.Clone(...)``` before the temporary directory actually got created. On cleanup, the test would throw an exception indicating that it could not find the path of the temporary directory (as it does not exist). The end result is that the test reports that it failed to find the path of the temporary directory (which hides the original exception).
I commented it because the lines above it (also relevant to having patch / distance info) were commented for some reason. I assumed that there was a reason for it---e..g, it wouldn't write properly such that it could be read again or something---and I didn't want to introduce any regressions. Do you know why the lines above it were commented?
I am always afraid that copy does not do the job. I would hack it with a deepcopy after removing the raw attribute...
Yeah. Like read_events and write_events should be under both the Events heading, as well as the File I/O heading. I think this will make it so users who think, "what can I do with events?" will see all event-related options there, and if they later think, "what types of I/O are supported", will see all their I/O options under that heading. Make sense?
to avoid breaking peoples code can we come up with another method name? time_as_index and index_as_time and deprecate time_to_index?
but we should let it in the example (and say this is the default) to demonstrate the approach (and show how to modify it, see find_sources example).
same here regarding the error
Because it was not compatible with other positioned stuffs. In other
places, the offset of position is after @ whereas for the case of import,
the offset of position is the position of @ itself.
For example in
"@hello", offset of position would be 1 whereas in
"@import test._" offset of position would be 0. So it should be changed to
1.

On Tue, Aug 7, 2012 at 9:34 PM, Sadek Drobi <notifications@github.com>wrote:

> In framework/src/templates/src/main/scala/ScalaTemplates.scala:
>
> > @@ -386,8 +391,7 @@ package play.templates {
> >        }
> >
> >        def importExpression: Parser[Simple] = {
> > -        positioned(
> > -          at ~> """import .*(\r)?\n""".r ^^ {
> > +          at ~> positioned("""import .*(\r)?\n""".r ^^ {
>
> why would positioned start after the at here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/playframework/Play20/pull/402/files#r1325300>.
>
>



-- 
Amir Shaikhha
what does ... mean?
This should read:

```
<shell>
heroku run rake db:migrate
heroku run rake db:seed
</shell>
```

right? :)
可适当调整语序：
给变量<var>$ancient_browser</var>设定值。
same with this, I think this should be callBack
This method is too long, it should be refactored and broken down into smaller units. This will also make it much more testable.
Use TestLatch (it's an Awaitable so you can use Await)
removed def system from Camel trait, it is not needed in the end for the user. (you can always get to the system using the normal routes) Added a comment that Camel is shutdown when the associated ActorSystem that uses a Camel extension is shut down.
Я не понимаю все равно. Какая разница буду я выводить формат локальный, или
свой, если там только цифры, плюс short формат уебищен чуть более чем
полностью
Spacing above functions, please!
please remove blank line
Sorry Ed, you asked me if this if was necessary, I glanced at it cross-eyed, thought it was there in case the volume wasn't needed, and said to keep it. Complete fail on my part, the if needs to go away or we'll actually break the ability to *not* have a volume. ＿冂○
indeed needs to be volatile.
It is not relevant for state transfer.
versions for dependencies should be specified in the parent/pom.xml dependencyManagement section
I may be wrong, but I think this line will still cause pypi installations to fail for python 3. The problem is that setup.py evaluates this line at package time, causing only the python 2 packages to be bundled on pypi (assuming you package with python 2). The only way this code would work, as far as I know, is if you create two separate pypi projects and upload them separately; once with python 2 and once with python 3.
I agree with @pelson. This example is for exposing the __object-oriented interface__. Using the `pyplot` state machine is discouraged.
Oh, I see.  I misread what this was doing.  My B.
Ближе к вечеру поправлю
arrow antipattern; try to break up that code into flatter structures...
shouldn't we make the default version configurable?
Careful! Merely setting the level here, causes Log to init himself if he hasn't been initialized!

c.f. master branch of RightAgent:
308     def level=(level)
309       init unless @initialized
Need to be careful here, because the core site chooses the filesystem path to which the user-data.txt file gets injected (Rackspace lays it down for us). I'm not aware of any core-site changes, so the core will still tell Rackspace to lay it down in cloud_state_dir.
For future reference, I think we're sometimes abusing the data- attributes. However, I think this is fine for now.
Missing a space here.
@christianv Sorry, these shouldn't have been in the patch.
Please follow code style there
use the naming convention of shogun: basically call it CLARS instead of LARS...
Awsome!
I did not take part in the discussion but i think it would be great to somehow incorporate probabilities for the labels.
@stojg You're still allowing setting of self::$encryptors even if it has no effect. I would suggest removing this logic, and only leaving the deprecation notice in there (and unregister() below). Also, you should remove the $encryptors static.
and there)
https://github.com/troyand/timetable_jan/issues/19
你引入path之后用过吗？
Learn Japanese?
"it became" -> "`notify!` was called in"
you should use ``{@inheritDoc}`` for all methods documented in the interface, to avoid duplicating all phpdoc. It makes it easier to maintain it (typos occurs only in 1 place for instance)
Can you actually remove the 'process' variable, everywhere? We actually don't use it anymore O.o
nit: synchronize
сюда пустую строку после объявления namespace
(Mostly some setters and getters with inconsistent names have been deprecated.)
For tests, just allow the exception to bubble up. No catch block required.
This should be updated to use `on`.
maybe `req.on('response', this.saveCookies.bind(this))`
Will not answer this question.
We have this now done in other way. Please merge with latest from main repository and you will see.
Just remove unused translations.
What did you do with this file? Broke indentation? I see that you cleaned some things. But also broke some things. So we indent always. For template or HTML block/tag.
So i just put this:

#: .\account\templates\user\login.html.py:54
#, python-format
msgid "If you don't have an account click here to register."
msgstr ""

in translations and translate this to slovene ?
Why none? I liked empty string more!
Well I could override get(), but the effect would be the same. I have to set attributes somewhere.
And get_success_url just gets it, but I want to set it.
No, `abspath` should be last! You first construct path, and then you find `abspath` of that. ;-) Now we have definitely not an absolute path because we construct it with `..`!
Maybe we can add a `_path` attribute to all rootpy objects which references the `Directory` from which the object was retrieved. Does ROOT already provide a way to access this?
i would say name this method: addAnimationListener
and rename the AnimationNotify to AnimationListener which looks like this:
```
public interface AnimationListener {
    public void start(UIDisplayElement target);
    public void stop(UIDisplayElement target);
}
```

Also put it into the gui/framework/event package.

To access this through the UIDisplayElement add this method:

addAnimationListener(Animation clazz, AnimationListener listener) { ...}
hmm, that sounds 'less than ideal' at best.  If this is truly the case, then we may want to think about how and what we want to actually inherit in the engine's application controller (this can be a later task, not part of the initial integration effort)
This is custom (bad) way of defining template name in class based views.

You should use hooks already provided by FormView in django

```python
class NewPaymentView(FormView):
    form_class = PaymentMethodForm
    template_name = "getpaid/payment_post_form.html"
```

and then use ```self.get_template_name()``` method
idiomatic clojure is hyphens instead of underscores, how about `:best-category`?
It's valid python syntax but seeing as it's the only command after the while loop times out there's not really any need for it so I've removed it.
Fix this comment to no longer reference init_main_conf.
Surely, but one is willing to bear some burdens for such a blazingly sleek user interface with the whole Unix power underneath. And I can imagine, that porting a fully-blown Linux package manager over to OS X is trying, because the whole base system and user interface is out of control for the package manager.
maybe fine for now, however I thought of removing this calculation from the fit method.
Looks like we can calculate this in a way that uses fewer calculations. (But I haven't checked yet what we *really* need later on.)
does it make sense to have nobs in axis=1 ? usually we have observation in axis=0. Application multi-equation models?
The compatibility tests could be more easily extended with a check superclass, and avoid code duplication when it works for all tested models
Changed tolerance in https://github.com/rgommers/statsmodels/tree/speedup-nonparametric
ok, consistency is a reasonable argument, pulling now.
Please do not concatenate strings, use string interpolation, all at ounce, also the dict-version of interpolation for increased readability.
What you're missing is that when I wrote the comment I thought that the pkflat gave unit variance, then when writing the test I remembered that it's variance=0.01, but forgot to update the comment.  Fixed now!
Yes, Peacock is what I thought of too.  Also there's Bartelmann & Schneider review from 2002, but it doesn't seem to use Delta^2 anywhere (which is too bad, since it does define P_kappa, angular shape correlation function, aperture mass, etc.!)
I won't remember . I also retried multiple times without this piece of code - JInput can't find natives ...
Pascal case
good observation.  stop semantics are a bit unclear but i agree with you, it shouldn't end the lifecycle, just minimally stop the app running.  question as to whether it should stop an associated VM but that isn't relevant here, where it is clear, it should be issuing a vmc stop.  (have done this.)
I think it's better to throw an exception - IllegalArgumentException
missing trailing comma


```javascript
"inits":["init.qcom.rc","init.bryce.rc"],
```
Redigér nyheden
Unfortunately, leaving it rt makes it test different things between Ace and 4.3. Switching to non-rt lets me test what I actually need to test between the two.
Is the logic here what we want? Specifically, do we want it so that we use entity.owner if owner is null, not only if owner AND app AND sharing are null? Is what I'm saying making sense?
That's actually not correct, I think. It's the button's text so "Resume" makes more sense. Can you revert that particular change?
On Thu, Feb 23, 2012 at 1:42 PM, Dan Yamins
<reply@reply.github.com>
wrote:
>> @@ -862,8 +866,52 @@ def checkpoint(self, result=None):
>>              handle = self.trials.handle
>>              handle.refresh(self.current_job)
>>              if result is not None:
>> -                return handle.update(self.current_job,
>> -                        dict(result=result))
>> +                ####XXX The multi-result format is expressed here
>> +                #Either the return is a dictionary, in which case its a single result
>> +                #OR, the result is a list; the first item of which MUST be a dictionary
>> +                #and is assumed to be the result for the original spec and which
>> +                #has its record get updated just like for the first case, while
>> +                #the rest of the items MUST be (spec, result) pairs which are
>> +                #inserted anew.
>
> Well, because actually the result corresponding to the original spec needs to be treated differently: it has top be updated as opposed to added.   So I figured, IF things are going to have to be different anyway, might as well make the datastructure make that easier and clearer.  There has to be a convention for where the original result is anyway ...
>
ok, this is fine too.

> Btw does it make sense to separate the jobs DB from the results DB?   (Or really, the Trials object from a Results object?)  Trials are what control the job scheduling and submission, and Results are what's interacted with to for hyperopt purposes and results analysis.   One Trial can correspond to several entries in Results.  The multiple things that the andit would inject asynchronously should be in Results, not Trials.
>
This sounds like a lot of tricky code shuffling to me, what would be
the point exactly?
Yeah, I was wondering about this myself. Seems like we should be be using something else in this case. I'll look for other examples in the codebase.
you should remove the leading backslash to be consistent with other class names
might try just doing $event = $command->execute(), pretty sure it formats it for you.
If you used a real IDE you wouldn't have that problem :trollface:
Please renamed this service as I already asked previously. It is **not** a wrapper. The wrapper is your SundownParser class.
This is something I really don't like.  You'll see a similar thing where altitude hold mode is enabled.

The problem is that essentially this is doing something that the current path follower doesn't support (iterate through waypoints).  The PathDesired that is being set here is the output from the PathPlanner.  So in principle it shouldn't have to depend on the PathPlanner module even running to perform position hold.

I was hoping to address this with the routing improvements https://groups.google.com/forum/#!topic/phoenixpilot/dFcR9qiQGbw
by using the event "FlightMode=PositionHold" to trigger a copy from PositionActual to PathDesired
I don't think a step like this belongs in calabash. We want to encourage everybody to write high level custom steps.
http://openfiresource.de/wiki/index.php?title=Coding_Guidelines#Mustervorlage_Dateilayout
Prefer this instead, in case this class gets subclassed:
    protected final transient Logger logger = LoggerFactory.getLogger(getClass());
Because we carry a lot of "window" and "document" properties, I'd like us to use the same convention: can you rename `contentWindow` to `panelWin` or `panelWindow`?
Yuch, should be `gDevTools.showToolbox(target, toolId);`
Fixed
We should move this import at the beginning of the file, as per http://www.python.org/dev/peps/pep-0008/#imports
'Imports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants.'
At some point, I may learn. I thought I already ran ``s/leafs/leaves/``.
Thanks.
n_component cannot be None after these lines: it gets computed by cs_graph_components