labofsahil/github-event-dataset-2012 huggingface dataset:
Declaring selected as a set improve a little performance.
It is the same for `selected_add`.
1.5.1.

On 16 July 2012 14:37, Peter Prettenhofer
<reply@reply.github.com>
wrote:
>> +
>> +                n_total_samples = n_node_samples
>> +
>> +                X_ptr = <DTYPE_t*> X.data
>> +                X_stride = <int> X.strides[1] / <int> X.strides[0]
>> +                sample_mask_ptr = <BOOL_t*> sample_mask.data
>> +
>> +                # !! No need to update the other variables
>> +                # X_argsorted_ptr = <int*> X_argsorted.data
>> +                # y_ptr = <DTYPE_t*> y.data
>> +                # X_argsorted_stride = <int> X_argsorted.strides[1] / <int> X_argsorted.strides[0]
>> +                # y_stride = <int> y.strides[0] / <int> y.strides[1]
>> +
>> +            # Split
>> +            X_ptr = X_ptr + feature * X_stride
>> +            sample_mask_left = np.PyArray_ZEROS(1, &n_total_samples, np.NPY_BOOL, np.NPY_DEFAULT)
>
> @glouppe What numpy version do you have? I use ``'1.6.1rc3'``, maybe that's the problem...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/scikit-learn/scikit-learn/pull/946/files#r1168423
+1. I would pack all this into a single prune method in the `Tree` class.
Not clear if that's a start or end time.
This snippet with the unused variable is copy-pasted in multiple places over the codebase. Should I fix those as well (maybe in another pull though)?. I copy-pasted it here as well since I'm still learning my way around and this seemed the right way to loop through the array.
The long long? As above, I didn't notice that last one was distinct. My bad.
Looking at this now, is there any reason `is_indexable_callback` was made an option at the `persistence` level, rather than `listener`? I don't think it has any meaning outside of a listener, correct?
It's mostly going to be repeating the warnings that will have been issued in the ForEach (*subit) loop above here.
Should mark and avoid, or turn the 'subs' loop around so it's scans 0->n and looks for @num's that match and warn on rest.
As the rename action happens outside of CDistributedFileDirectory::renamePhysical, I don't think this criticalblock is in correct place anymore.. 
perhaps it is not needed?
Not directly related, but would be good to not hard-code the "::" separator string.
not sure what that's doing? removing 1st two chars? didn't u mean last 2 chars [", "] ?
Would be better if last in for loop, not to add though.
HTTP 1.1 has been the state-of-the-art for the past 13 years, so I'd guess that it will remain supported into the near future.
You will have to choose between `is` and `has` :p
Yeah, as @weierophinney said, this assumes the locator involved is a `Zend\Di\Di`, but we should only really rely on it implementing `Zend\Di\Locator` which simply defines `get()`.
the `len(list)>0` could just be `list`, since empty lists are false. But it feels a bit weird: the only way to get an empty list here is if `rvalue` were an empty string, since even `"foo".split(",")` returns a one-element list. Could this whole clause be replaced with `if ".." not in rvalue` ?
I didn't. That's @pmjones who wrote that originally. :)
I had this in on previous attempt but ending up here means that we have not found the package config and don't have the compiler flags.
this method was not added so added it to resolve compilation error
@christianv Ah! Very cool - and now I see the logic of redeclaring these.
long line, missing spaces etc.
Yes, no worries for that. I did not include it since I wasn't sure about the outcome of the acceptance process ;-).
I think you should verify res isn't nill too. 

```ruby
if res and res.code == 401
```
Default database choice must be mysql for backwards compatibility.
We also need some tests for the new functionality.
OK, cool. If you find the time to add tests of the shape of the returned arrays in the test functions, that'd be awesome.
Could you please provide an example of when this is necessary?
I know we removed this function, and now it does make sense to add it back, but `cull` is a really bad name for it, right?  It doesn't just cull; it creates a command list for a potentially visible set
It's not, yet.  The TODO should stay as a reminder to fix it there.
"...in local mode..." (you mean "remote" right?)
Remember and forget proxy are not needed for setters; they are done automatically unless the setter method is overridden. Also, rememberProxy should never be called from the main thread (because by then it's too late). Short version: Forgetproxy and rememberproxy in this fix is not needed and should be forgotten.
I'm referring to the byte wastefulness in regards to local storage. For every string that we store, we'd use an extra 4 bytes (2 bytes per char) for the extra quotation marks. The 5MB limit is a big constraint that forces us to be smart with the chars that we store; the current implementation uses CPU time to do the necessary checks to save storage space.
I did but you're right, error is better
just figured this was a brain fart from my side. forgot it's the tinmyce version here. :)
Nit: Does an em-dash typically lack surrounding whitespace?
я бы сделал классом. мало ли что будет в будущем, и элемент явно неуникален (и назад пути не будет если оверрайдить станут)

я бы вообще все у нас что есть делал только классами (и ролями? %) ), без айди
смотрится очаровательно
While this project currently has on defined coding standard, you have a mix of different indentation styles going on in here. This project prefers the Compact Control Readability style, but I would accept Allman style as long as they are consistent.
Yes, that's a good idea - breaking up by phrases.

However, in that case, I'd separate with two newlines.

Like this comment.

But you never know. Sometimes, you want to bust out a paragraph. Like this one,
as an example. And for a paragraph it reads better justified, I perceive.

Fur rilz.
I don't know what you mean here.
> The matter of faulting one for one's style (particularly if just a mainstream one) is not even in the question, so it's odd to even mention.

I bring it up because you're indicating that there's something wrong with the style being used here, and nowhere has it been agreed to use the style that you're suggesting over the one being used here. So, it seemed like you were objecting to code using this style at all.

Now, if you want to argue that the code here doesn't follow the style of the module as a whole, then there are grounds for that, since we're trying to keep the style in modules consistent, but if you get picky enough about what constitutes the style of the file, then there you are always going to find problems. Personally, it never even would have occurred to me to do any other kind of indentation, even if I were trying to follow the style in the file. And it's not like the style of the file is all that consistent anyway - just look at stuff like whether the body of the if statement goes on its own line or not or whether braces are used or not. It doesn't even consistently put braces on their own line, even though that's one of the few universal rules. The reality of the matter is that unless you watch every single commit to a module like a hawk and insist on a particular style for every commit, the style is not going to be consistent, even if the majority of committers try to keep it consistent. And without you explaining somewhere what exactly constitutes the style of the file, I'm sure that a number of us will screw it up even if we're trying to follow the style that you want.

So, if you want to insist on your style of indenting, because it's consistent with the rest of the module, then fine, but if you're going to be super picky about formatting, I think that it's pretty much a given that you're going to be disappointed.
I think here we should do this: if one of the visitors accepts zero arguments, call that when the variant is empty instead of throwing an exception. If no such visitor, throw.
Function pointer types should be `void function()` instead of `void()*`.
The only two functions which may be an issue are minRunLength and ensureCapacity. The rest of the code is my own. *Descriptions* of these functions can be found in the Timsort paper, if you wish to rewrite them:
http://svn.python.org/projects/python/trunk/Objects/listsort.txt

I proposed renaming the function to distance it from the Android source code (since the rest is identical to the Python C code).

This is why I released my code to the public domain. To hell with receiving credit!
ie10, no ?
上記のコールバックアプローチの限界として、ちょっとした同期ロジックを書きたいだけでも、非常に面倒になってしまう点が挙げられます。
ここ、なんで`element["pattern"]`に変更したんでしょうか。

`element["pattern"]`だと、ルールに`pattern `と書いただけで空文字が入ってしまうので、`pattern`というキーを設定するってことは、それが空文字だろうがなんだろうが、なんか設定する意思を表示したものとして扱うために`has_key?`したような記憶があります。
ok, je me coucherai moins bête :)
http://www.appinf.com/docs/poco/Poco.TextConverter.html does this if you are interested.
these 3 parameters should be declared as private variables
if (contentType.IsNullOrEmpty)
(question) The comments indicate that you want this:

    dataSpecs = config.data.concat([]);

Unless I am mistaken, the actual code here one line 513 is a noop.
please remove this flag
(perhaps relevant -- if there's a nicer way to do this, lemme know)
ahh, great point.  yeah, that makes the code better.  I also changed it to a try...except instead.
@kukulich Yes, also a solution

    "There are $number {$animal}s on {$location['number']} {$location['type']}s\n";
    sprintf(
        'There are %d %ss on %d %ss' . PHP_EOL,
        $number,
        $animal,
        $location['number'],
        $location['type']
    );

But the main question remains: Is it useful to _enforce_ concatenation just to avoid double quotes?
Just for reference, I'd rather see this as separate tests for user-email, tags, suites, etc. That way the failure granularity is better, this way if one of those things fails it could mask a failure in another one. But that's not a big deal, it's something I sometimes get lazy about too because it's really tempting to stick a bunch of stuff in a single test, so I'm not bothered if you decide to leave it this way.
@bartvde I guess this should be fixed? If so could you do a new pull request for this please?
Right and there are other methods for it if you look at the entire utils class. So this particular method was added on top of all other methods Gary had which do allow you to provide ConversionService instance
or you can change the method name to 'provideEvaluationContext' and move the IF statement there ;) while calling it every time
Should this be called stopOrderlyShtdownCapableComponents? My concern is that in line 497 its the first method that is called and *other* somehow implies that when everything specific is shut down you can now shut down all others. wdyt?
I use all-caps to denote that it is a constant.
Maybe in this case with say `instantiate a service for you` is enough since `service` is a term outside of OOP
I think I'll write it on ML to make it the same for all components but this PR change it only on parts it's wrong parsed and make is conform with this component itself.

(The pipe could be a problem within tables)
Falta un caracter de marca de título
@bp323 Shouldn't this be an H2? (The H1 seems to be "statistics")
please don't use ``content`` as this is likely to conflict with block name in app layouts. You should prefix the block name
Make this a static class.
Once you perform the string concatenation outside the where clause, the function should reduce to a single ored together `if` statement.
Hmmm. I wanted to search for an item in the Array here.
At first priority I wanted to use `Array.length` in the `add` to correctly decide when to register the observer.
My second priority was the easy search - to remove menuitems by their id. So I tried the associated Array, 
but sadly `Array.length` and `someArray["menuitemID"]` are opposite of each other.

Re-read the code again, a simple linear search will do the job here - with `Array.some`.
Could You show me a preferred way to search in Array?
If you want to type (a lot) more, you can use the constants in MaskBuilder :p.
Aquí no se si es mejor una cosa o la otra, se que fue @stripTM quien montó estas variables de esta forma y te puede decir qué es mejor.
+1. For other NLP tasks, this module isn't particularly useful.
You could refactor to this?
```python
this_questionnaire = get_object_or_404(Questionnaire, pk=questionnaire_id)

orderedgroups = this_questionnaire.get_ordered_groups()
questiongroup = orderedgroups[order_info-1].questiongroup
   
questionForm = make_question_group_form(questiongroup ,this_questionnaire )
```
Can we use the `unredacted` scope please.
subj should not be a parameter, because subject_id is being fed in
I suppose this is just style, but I vastly prefer inject over tap. Tap hurts readability and adds extra code for no benefit.

```
storage_path.children.inject([]) do |cookbooks, p|
  cached_cookbook = CachedCookbook.from_path(p)

  cookbooks << cached_cookbook unless cached_cookbook.nil?
end
```

or even: 

```
storage_path.children.inject([]) do |cookbooks, p| 
  cookbooks << CachedCookbook.from_path(p)
end.compact
```
пробелы можно не ставить теперь
Could we just return early here if its not time for another GC? This way we don't need two conditionals checks.
Since these are docs for master and this property will be removed post 1.8.X do we need to document this?
This description just isnt' useful. An external link or small discussion about Logcat categories would be extremely useful here (since all the methods here represent different categories)

See the overview of the Android Log class:
http://developer.android.com/reference/android/util/Log.html
Indeed it should. I just fixed that.
Methods don't avoid the need to synchronize; I could have two threads both race with `setCallback` and `getCallback`. The only way you can get away without synchronizing is if `callback` is `final`, and you set it in the constructor.
Is there any reason we're not just calling this ServiceBusService?  It feels weird that you're changing from the word Service to the word Proxy.
Ok, I agree with your additional check.

I think previously I was confused about the additional condition of checking if the old `id` is lower than the new `id` AND that the old `id` does not already exist.
As I stated, that both conditions would only be true if a role was deleted from the database (which can be done manually, as you probably already know).
As that is a correct use case for you, that check should work beautifully.
I am not sure about this one.
Сняв это условие - ничего хорошего не произойдет.
Далее обнаруживаем бодыль:
1. Скрываем по меню кнопки "Скрывать изображение"
2. Заходим в настройки, выбираем "Очистить"
3. Перезагружаем страницу.
4. Пост остается скрытым.
This if statement will always pass. Is it needed? The code never has a status different from 0 or 1.
Ah yes, you're right. It shouldn't end up in the bar either way. I'm ok with leaving it as is.
You shouldn't need broad now
I would probably say to execute this line rather than add it to your profile. If you add it to your profile you need to restart or resource your profile before it will be active. Besides if people want to add it it should be up to them, but it overrides your path with QNX stuff so its not ideal for non BB development.
{ needs to go on newline
why include mast? isnt this a rospackage depended in manifest already?
This is really what you wanted to see happen, I'm not sure why the spying wasn't working before but this is modified and cuts to the chase without resorting to spying at a higher level.