labofsahil/github-event-dataset-2012 huggingface dataset:
Why do you return an empty list here while you return a dict containing at least ``'crashtrends'`` when there is data? I would expect a default dict to be returned.
I would suggest outputting to a logger (file) instead of to the console (stdout).  This will allow for reviewing later if the terminal window is not setup to have that much of a backlog.  Same below for the puts row.inspect.

e.g.

logger = Logger.new("filename")
logger.info row.inspect
Could you emit 'logger' instead of logger? We could have a switch statement in the main module then to set the correct tooltip not only for the logger. That way we would also only need a callback for onmouseover for each individual element.

We could also make it more general by using the id of an element we want to have a tooltip for in the callback. Just passing it over to main.js which then can set it correctly. A better name for the emit type would be 'update_tooltip'.
Thanks for the regex lesson, initially i had a single regex catching all 3, but i split those up for better error messages
you might want to rename config to clientConfig to be consistent.
NM, fixed.
Can you change this to

    let …
    in …

instead? Right now, the indentation makes it look like `genUniqueDecl` is being bound to something.
This call to `show` should be moved to the end of the script now that there are multiple calls to `plot_harris_points`.

Also, the call to `plt.plot` (a few lines up) is unnecessary.
I would use ``PUT`` here. this action is idempotent: sending it several times will lead to the same result than sending it once: the available versions are updated with the one available on github
Good work on adding a whole set of new unit tests
I'll add this, but it shouldn't have given any errors.  Did it?
I'm not sure what it means for a paint to surround the occludee object.
When you iterate over objects like this, you need to wrap each iteration in a if(polylineBuckets.hasOwnProperty(x)) block or you will get unwanted properties that may be on the prototype.
I actually properly handle this case, it's just the comment wording that is a little off, I'll clarify.
How can we test this better and still keep the test reasonable?
Fair enough.  I think the presentation would be better served by a usage type organization rather alphabetical but this is consistent so I will give on this.
This property is still read-only on Android
`![superResult isUserInteractionEnabled]` is a more reliable check. `touchEnabled` is always false which is probably a bug in our TiUIView class
One could argue that we should have a TiDialogProxy as a base class for both the dialog types to hold generic properties but I will leave that out of this PR as creep ;)
Shouldn't .git and .svn be in the ignore directories?
I can change CanvasElement to var, but CanvasRenderingContext2D must remain or I get warnings about using the methods for context (like createImageData()).  Since I was already using that really long type anyway then, I just thought it looked less odd to keep the CanvasElement type also.  But, no problem changing it to var.
get rid of fugly empty lines
You are right, ok doesn't look correct here. For an instance, it seemed right to use `writeln` for section headers and `ok`/`error` for inner text. But, fixed in 560e74ce9f662ae0aad02fbb36192930b831ed0c
Agreed, will fix tomorrow.
The "problem" is that this would fit into the WritingInterface, but that's not an abstract class (of course)

But I'm fine adding that to BaseTransport, even if it doesn't totally fit there
s/`skipWhite(s)`/`skipWhite(ss)`/;
There's nothing fundamentally wrong with this sentence, but because the trait is `hasSlicing`, I believe that in the documenation, we typically talk about ranges having slicing rather than being sliceable (though I probably would have gone with `isSliceable` had I been naming the trait - not a big deal though).
why? use `codeUnitLimit!S` straight on the rocks
unusual indentation, I think "in" and "body" should be aligned
More nitpick: Isn't that just `Unqual!T`
> meaning the instances would not get released until the validator factory gets closed.

But isn't that the case anyways? The spec says "[releasing validators] is typically done when the ValidatorFactory is being closed."

> Btw,I don't think that the spec explicitly states when releaseInstance is supposed the be called

Yes, my point is that I'm doubting whether we need such a method at all. In another comment Emmanuel said "who creates things has to release them", that's right and thus I think `ConstraintValidatorFactory` should itself be responsible to release its created validators when it is closed/destroyed itself.
Just a question. What are the default values for these options? False?
s/Uri/URI/g
Indenting wrong on these lines (and `numRegularRecords`).
pls check the final manifest.mf; but I'm quite convinced that those are not exported
because I would always prefer a list to an array ^^ on the caller side of view. But of course I can change it if you think its better that way.
This is removing a previously working feature: Preview historical pages.
It used to open in a new window, because 3.0 doesn't have controls to switch between "draft", "live" and "at historical date" as well.
That's fine, but no reason to remove the feature?
Maybe you should document that the `$disqus_shortname` could be passed as an include parameter (check `standard/disqus.tpl` to see how we did it)
Check here: https://github.com/EnthusiasticCode/ReactiveCocoa/commit/71dfc62de9f008171ac8243183a9c729bc8aeaed
In the "if" statement above, can add this code (from my sample in #406)

        $dateValue = Utilities::rfc1123ToDateTime($value);
        if (!$dateValue ) {
            $value = $dateValue ;
        }

The boolean is also easily handled:

    } else if ('true' == $value) {
        $value = true;
    } else if ('false' == $value) {
        $value = false;
This is a bit of a complex conditional, and it's over 80 cols, next time lets break it down into a multi-line if:

http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Conditional_Expressions#Conditional_Expressions
I would rather not have puts left in the code after debugging.
peices or pieces? ;)
are we using this again?
Yes, I was a bit hesitated to implement that. As default, CacheNamingStrategy is set for visitor and I don't found any way to change this behavior. Maybe I should introduce a new config option for NamingStrategy?
не проверял, но насколько помню - оно ругается, если их нету.
Isn't the column a integer?
We don't like autosave files
Any particular reason for using auto here? Unless there's a semantic reason, please avoid it so the declaration is clearer.
Not required anymore?
this would probably be better as a one-liner:

    selector = ... if typeof selector ...
This should get bumped to 0.1.0 since it's adding changes to the public interface and not just fixing bugs. I try to follow http://semver.org/
Nick, `fileutils` is part of the Ruby standard library; however, it is
still better to use Chef resources when possible.

-- 
Douglas Thrift
RightScale - Linux Systems Engineer
<douglas@rightscale.com>
<http://www.rightscale.com/>
On Aug 24, 2012 7:34 AM, "Nick Stakanov" <notifications@github.com> wrote:

> In cookbooks/db_postgres/providers/default.rb:
>
> >
> > -  log "  Wiping existing runtime config files"
> > -  `rm -rf "#{node[:db][:datadir]}/pg_xlog/*"`
> > +  ruby_block "wipe_existing_runtime_config" do
>
> I'm concerned about using of 3d party gems like "fileutils" in chef
> cookbooks.
>
> we should use native chef/ruby or bash methods to perform this operation.
>
> you can use file resource like this:
>
> Dir.glob("#{node[:db_postgres][:datadir]}/pg_xlog/*").each do |item|
>   file item do
>     action: delte
>   end
> end
>
> directory resource, you can delete directory and then create it again
> but this way can break postgres and need testing
>
> or you can use bash script to remove this files.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rightscale/rightscale_cookbooks/pull/135/files#r1453566>.
>
>
message > mensaje
Yeah I meant that OSX is case-insensitive, sorry.
We shouldn't be filtering on `website_url`, here or in `clear_rejected_duplicates`.  Multiple videos can come from the same website.
the field will be of type DateTime, not just analogous
I'd expect it to be faster actually as raising an exception is generally costly.
question: I can understand why we are finding for `node: uaToken` but not the `{ _id:""` part. I can see the API here: https://github.com/mongodb/node-mongodb-native/blob/master/docs/queries.md , but I'm a bit confused.
Same: `getApplicationsForUA`
agree it's more readable. I can do it in another pull request so you don't have to.
I think this should be checked on the parent comment instead of the root, to allow different order at different depths. Here is my use case (not yet fully implemented in our app as I could not figure the right way to do it with the existing code base): we are restricting replies to 1 level. And we want the first level of messages sorting by date DESC (latest first) but their replies to be in the ASC order (to read them logically).
It would be great to be able to achieve this with the new JS code
refactor into a more sensical MVP design, incorporating the entitypropertyform.
Preferred, not demanded.  Given how code sniffer doesn't like the indentation convention previously noted on the multiple line  // comment of the original code I think this is an acceptable trade to indicate that this is a single multiline comment.
My bad, TERMINATED.
Oh no sorry I misread the order of the arguments :)
A property is just a pair of accessors, so it can't really be renamed, can it?
Maybe we should change to the reverse strategy: filter stop words first. Most bigrams with stop words seems noisy, and if the users wants to use stop words is to probably to explicitly get rid of the noise.
Oh, I do believe that looks real nice.
If the user moves the mouse after the execution of this method, we must cancel the restriction imposed in line 381
Off the top of my head: Loop, either, or, and are missing
foreach, fnet_button are proprietary; they must be removed
This should be calling ``exclude``.
the name of the pagination parameter should be configurable instead of hardcoding it as ``page``
This should be: return 1;
Not sure if this is the best choice of possible answers. What is the difference between 'Prints nothing' and 'Prints and empty line' ? One is probably redundant. In addition, how can it possibly print <lazy> ?

I would replace the second answer with: 'Prints a NaN'

I don't think we need to always strive for 4 answers, 3 would should be just fine.
`V[K]` is always associative array type, so this additional constraint is not necessary.
`var comment_id = $sn.getAttr($(this), "cid");`
from here to line 72:

why that many empty lines? If you do not want to give a comment here, I think maximum of 2 empty lines should be used to visually help developer to separate logic.
You right it should happen only on threshold value for comparison should be value === 14 and value === 4 for critical. The assumption here is that battery level increase/decrease only by 1 percent so the condition won't be missed, can we rely on that?
I'm shooting the messenger a bit here, but we are migrating all the code out of this file an opting for an include from where you call "showTargets". We have re-factored it in the context menu going into WP, so I was hoping that we could change this so we don't have to re-factor later?