labofsahil/github-event-dataset-2012 huggingface dataset:
I am so goddamn sick of doing that port. http://blog.steveklabnik.com/posts/2012-01-17-moving-from-sinatra-to-rails
They are all set to zero by default...
Well, Optional is one way do to that but all it really does is turning the Java "null" construct into a "I am a special object representing null and if you use me correctly, you avoid NPEs and see different exceptions". I am curious to why you see that as better than regular null checks?

I agree that this somewhat helps with the "I can write all this as a big function" but Java is not a functional programming language, no matter how much Guava tries to turn it into one.
I am not sure I understand the logic here, can you explain? This is decorated with the change_user permission. So once we get to this point, we know the active user is allowed to edit other users. However, if that user is a staff member (= has access to the admin pages in any way), then you reject them here?
Good point - I'll make a comment on my other commit that's all about this class.
This is a great candidate for some hot linq action.
You should be able to do:
`SelectedGame.SelectedCategory = SelectedGame.Categories.FirstOrDefault(cat => cat.CategoryId == categoryID)`
and replace everything from line 118 to 132.
named function incorrectly.
flux WMS(host,srs,format,) -> WMS stream(host,srs,format)
I don't think you miss anything. Unless the pull request has been made from an old monomap version, we MUST have this dependency.
`profile` is never define here?
Please rewrap.
Register buttons are not showed to me translated.
Please use a class :).
Also check that we still have track events here.
This probably doesn't matter, since it lives on the project.
STAMEN-TERRAIN is really buggy, and only supported in some locations.  Can we switch to TONER or WATERCOLOR (WATERCOLOR is most likely to work ime).
Can you move the content of this chunk into a new function on the PartialEvaluator like the `pe.optimizeQueue()` one? E.g. 

```
pe.signatureAnnotations(this.getAnnotations(), list);
```
I don't think we do this in any other code. I'd prefer it not be there.
Shouldn't this be install.rdf.in?
This code would conflict with valid test manifests that point to Mac `.app` paths (instead of an executable file). Those are supported by `test.py`:

https://github.com/mozilla/pdf.js/blob/master/test/test.py#L319-320
By default, the Salt master listens on TCP ports ``4505`` and ``4506`` on all interfaces
Remove this and add license.
You're right, I did misplace the `<ul>` tag. Fixed in the new commit.
I would move the description from TemplatesContent controller here, leaving there just a small comment, that it provides interface to the template content.
similar to 232
Maybe make this section more verbose, like

for p in procs:
    (prc, fh, metricfile) = p

or for (p, fh, metricsfile) in procs (if that works)
Definitely, but I want to do it after all of the SetOperator classes will
be implemented. I don't have a good feeling yet about remaining ones.

On Fri, Sep 21, 2012 at 5:27 PM, Paul A Martel <notifications@github.com>wrote:

> In src/ee/executors/unionexecutor.cpp:
>
> > +
> > +        std::vector<Table*>& m_input_tables;
> > +        Table* m_output_table;
> > +    };
> > +
> > +    struct UnionAllSetOperator : public SetOperator {
> > +        UnionAllSetOperator(std::vector<Table*>& input_tables, Table* output_table) :
> > +           SetOperator(input_tables, output_table)
> > +           {}
> > +
> > +        bool processTuples() {
> > +            //
> > +            // For each input table, grab their TableIterator and then append all of its tuples
> > +            // to our ouput table
> > +            //
> > +            for (int ctr = 0, cnt = (int)m_input_tables.size(); ctr < cnt; ctr++) {
>
> A template function might make sense here to reduce boilerplate. It would
> encapsulate the table iteration and customize its behavior in terms of a
> parameter-class-specific processTuple() method called in the inner loop.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alexeevm/voltdb/pull/3/files#r1665938>.
>
>
This API is about to be deprecated — replaced by a more XHR-like one.
See [bug 745114](https://bugzilla.mozilla.org/show_bug.cgi?id=745114) and the related front-end (#1226).
And this also works (using the previous variable)

```
In [95]: ICRSCoordinates(cp)
Out[95]: <ICRSCoordinates RA=10.68458 deg, Dec=41.26917 deg, Distance=7.7e+02 kpc>
```

maybe worth mentioning?
Actually, that should be `astropy/*setup* to skip some of the sub-package setup modules.
I don't understand why, but this doesn't work... It needs to be != - any idea why?
Once there are some built-in readers/writer this should start with user-oriented docs, and there should be an example in the `index.rst` getting started stuff.  But this is appropriate for now.
Fixed. I did not tried the validate option, somehow i thought, that install/update would do an implicit validate...
I would leave it in core.php as it changes how CacheHelper and CacheDispatcherFilter behave.
This param is called `$value`, not `$number`.
Can you redo both fixes in separate pull requests?
CS issue :)
these tests can be deleted.
This should probably say "Closes in: 2 weeks (DD-MM-YY GMT +1300)".

See the Rails `time_ago_in_words` helper for more information on how to display that.
These lines should match up with cellFrame on the line above.
Space after commas?
not according to the doc, 
And for example, I access the same server, sometime throught 127.0.0.1 and sometime through 192.x.x.x ... it  will be annoying to have an hardcoded ip or hostname...
I didn't totally grok the way `git_filters_apply` works on my first read. I guess I was just visually grepping for some kind of copy. Anyways, you're completely correct, I've removed the offending lines.
Right, it's probably left over from the refactoring.
No `<label>` element associated with the select element
Also, I'm not entirely sure I see what the coverage number represents. The equation seems fishy.
I'll file a bug to convert the current grid system to be a set of mixin's rather than classes.
Please remove all dump statements.
``PostgreSQL and Python``
ah, it gets used later on. Still, I think it should be in the top of the file. That catches more errors. Import-time is easier to debug than run-time.
As this is in base.py, please import it instead of copying the code.
if the user's locale is not an available locale on [MDN](#L4R62) we should fall back to `en`
Yes it's not in use, will remove it.
That's why he mentioned line endings - Also permissions changes (whether on purpose or not) can cause this.
Yep!

Emailing from my iPhone 4S like a BOSS!

On 5 May 2012, at 13:59, Frost<reply@reply.github.com> wrote:

>> @@ -120,6 +120,7 @@ public function install()
>>                'comments_enabled' => array('type' => 'INT', 'constraint' => 1, 'default' => 1),
>>                'status' => array('type' => 'ENUM', 'constraint' => array('draft', 'live'), 'default' => 'draft'),
>>                'type' => array('type' => 'SET', 'constraint' => array('html', 'markdown', 'wysiwyg-advanced', 'wysiwyg-simple')),
>> +                'preview_hash' => array('type'=>'VARCHAR', 'constraint' => '32','default'=>''),
> 
> I also meant to ask if updating the details.php file to include the preview_hash was necessary/desired in addition to the hash, hadn't heard differently. I'd imagine the details.php sets up a fresh install while the migrations handle the upgrade...
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/pyrocms/pyrocms/pull/1379/files#r778233
Can you put a new line between the variable setter and `return` please (including all following functions in this class)?  It's consistent in all React source.
Avoid single letter variables. Something like `package_response` is better here
We have about 4 of these comments littered throughout the code base (and this was a copy of one). I'd like to address them all in a followup then. We should start filing issues for things like this.
- all refs seem to be handled - 3rd party bundles ?
- I am mainly talking about the cache folder in string (ie `a:9:{i:0;C:46:"Symfony\Component\Config\Resource\FileResource":60:{s:52:"/var/www/sf2.2/app/cache/dev_new/as`)
this class should probably be marked as deprecated in favor of the parent one
There's a typo in the method name. Should be `testDestroy`.
``$request->getSession()`` as it returns ``null`` when you don't have a session :)
Please follow the Symfony coding standards. The name should be camelCased (and btw, many places in symfony are simply using ``dispatcher`` as name).
a class depending on Doctrine Common should go in the bridge instead of being the core implementation IMO
Why define a constant if it's only showing up once in the code? 

You'll have to look at the comparison and then go look up at the constant.
Oops, unnecessary space added here at EOL.
Perhaps this could be a weak-ref? http://docs.python.org/library/weakref.html
Is this necessary? This breaks the terms of the ```Downloader``` interface (```url``` is a method).
Отступ потерялся
The code here resembles [theme_ting_reference_formatter_default()](https://github.com/aakb/ting/blob/667965df9ee0c1289516097dcbd779337cbb1ab5/modules/ting_reference/ting_reference.module#L169).

Why not call call this instead?
Here's the usage of ``array`` as noted above.
No spaces around the =
this makes it so we can now click on the datum in an activity feed, and see it in the center view.
Re Sensei,

Oki, je vais prendre en compte ta modification ce soir !
Hmm, after looking at the patch a bit more it looks like the osgi JPA support is limited to one PU per bundle? In which case this is fine
Probably better to search within the button pane.
If we get rid of the timeout, how will you solve the problem?
Do you use values in the monitor to determine which hyperparameters to select as part of the cross-validation algorithm? That's almost certainly very wasteful because it forces you to compute the validation error at least twice when it's only necessary to compute it once.
We can probably factor all the `suiteTeardown` into the main one, MockUssdUI won't mind the extra teardown.
You could use the same code as line 674 ! ;) All in one line
Checking mozMobileConnection is not enough, but I could do something like:

```javascript
if (navigator.mozMobileConnection &&
    navigator.mozMobileConnection.data &&
    navigator.mozMobileConnection.data.network) {
  var dataNetwork = navigator.mozMobileConnection.data.network;
  var mcc = dataNetwork.mcc;
  var mnc = dataNetwork.mnc;
} else {
  return;
}

If `navigator.mozMobileConnection.data.network` isn't defined, the rest of the function doesn't make any sense anyway.
well spotted. thanks
names were changed to showListWithMessages / showListWithoutMessages
prefix the class name with `lockscreen`
this will break when we enable CSP for real I think.
Remove if unneccesary.
But here the problem is not really teh scheduling, that is always '58s' if
I understand it well, but the data we give to graphite as the time get.

If we look back at the start of this ticket, the graphite problem was that
the scheduling was drifting, so we did have in the behavior : "next check =
last planned check + 5min + latency" (because we used the check time
arrival, and not the planned time). Now we are using the last time, without
looking at the real time where we received the check (so we reduce the
latency from the scheduling).

Now : is graphite able to manage this? Graphite problem was a constant
drifting, but now the value is nearly constant, and only one check here or
here can have 1~2s more (the latency is not possible to compute by
definition), so it should be ok for it to manage.

Maybe the 49 thing is just not need for graphite graphs to be ok. Can we
test with and without the 49 part to see if there are holes in the graphs?


Jean

On Mon, Oct 8, 2012 at 2:50 PM, xkilian <notifications@github.com> wrote:

> In shinken/objects/schedulingitem.py:
>
> >                  else:
> > -                    self.next_chk = int(now + time_add)
> > +                    self.next_chk = int(self.next_chk + time_add)
> > +                # If check interval is a multiple of 60 (seconds), the check must be scheduler
> > +                # between 0 et 49 absolute seconds.
> > +                # Else re-schedule if the check is scheduled between 50 et 60 inclusively in absolute seconds.
> > +                # We assume here that checks do not take more than 10 seconds to execute.
>
> It is the check latency…
>
> Let's take my example series: here is the planned time and check execution
> latency:
> 10 h 0 m 58s, latency 1s
> 10 h 1 m 58s, latency 3s
> 10 h 2 m 58s, latency 1s
> 10 h 3 m 58s, latency 1s
> 10 h 4 m 58s, latency 1s
>
> Graphite time-stamped data
>
> 10 h 0 m 59s
> 10 h 2 m 01s
> 10 h 2 m 59s
> 10 h 3 m 59s
> 10 h 4 m 59s
>
> That is why having the check scheduled in the last few seconds can cause
> gaps in the time-series databases.
>
> Anything that causes the self.next_chk to drift around is bad. It must be
> a fixed interval. Shinken can still execute it a few seconds late or on
> time, that is not a problem, but over time it should not cross over a
> minute threshold.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/naparuba/shinken/pull/629/files#r1784284>.
>
>
sure, returning None is better. pushed !
This feels like a hack just to get the examples to pass. How about using ExampleGroup.describe in the examples (and get rid of RSpec::Core in some of the other cases in the same file).
I knew something was fishy, but I didn't realize I left it broken. Do you want me to add an edit to this pull, or fix in another pull?
tests if the MySQL database is the upgraded version using MEDIUMBLOB or the old version using VARCHAR.
if it is updated, it puts a ObjectOutputStream's byte array output to the MEDIUMBLOB, if not, put the Object itself as a VARCHAR. (broken old version)
321 行目で 「Temporary ジョブ」と訳しているので、H3 でも Temporary でいいのかも :smiley:
because i want to let it rasterize in three phases?
Would you guys be willing to add TypedCsv following the TypedTsv pattern? That would be really nice, as we could then use the Mappable interface, which works well with the typed API.
by the way - the replacement for gcc47 did not needed escaping, why do you escape single quote?
Why do you do this? The code is clear that you do it, so this comment should explain why.
revisar esto
This code selects the Recording tab in the config tool. None of the code highlighted here is testing a checkbox... Can you explain more?
It's not about cancelling, it's about being able to use it again after a connection error.
Egads, this is hairy. I wonder if you don't really want to make this two separate forms - but it's up to you.
I commented this and line 45 as the CMAKE configure gives the following error message and then stops building with the lines left in:

CMake Error at cmake/HPX_Message.cmake:10 (message):
  Syntax error in cmake code at

    C:/Users/Andrew/Documents/GitHub/hpx/cmake/HPX_Message.cmake:10

  when parsing string

    Header found in C:\ProgramData\NVIDIA Corporation\NVIDIA GPU Computing SDK 4.2\OpenCL\common.

  Invalid escape sequence \P
Either works.  This will have to be changed in future anyway as this call will be wrapped up into the fetch_artefact call.
I think he means that it's a valid URL. You can just stick it through [this](http://www.ruby-doc.org/stdlib-1.9.3/libdoc/uri/rdoc/URI/Parser.html) and see if you get something sensible back.
Could we just do
```
if reactor.running:
  return defer.maybeDeferred(f, *args, **kwargs)
```
or is that too much magic. (I guess maybe the later)
typo? place *where* the configuration is located
OK, change to return (file_exists($file) && include $file);
it went through, we have to make it right and also rebased/squashed
```
/**
 * Whether the credentials cache is enabled
 * @var Boolean $useCache
 */
```

That said, I would rather call the property `useCredentialsCache` and omit the description line entirely because it becomes obvious what it is.
the description is wrong here. This var does not contain the credentials but a boolean.

And the phpdoc description should be on its own line (the first one of the doc comment)
because you made it protected, meaning it is a potential extension point and using ``self`` does not allow extending. But as I don't see the need for an extension point on this array, and it was not there before, you could simply switch to private and keep ``self``
this one line is toooo long
As of jQuery 1.7, the .live() method is deprecated.
No \n needed, wrapper adds it
Didn't notice this file. I guess this can be deleted?
Sure thing. My reasoning for adding the return is because `doc` is kinda secretly tucked in behind the `end` keyword, making it difficult to spot. But that's only me.
`class='major bug'` is probably appropriate here.
This was the rather lengthy declaration to get at the browsers DOM.

I believe you were alluding to using more explicit DOM events like this as a way to clean up the tests. I think it could work! Though I wonder if there's a cleaner approach than what I have.
Those errors where thrown by subscript loader when attempting to load non existing files, this test does handles that. I could change boomer.js example to throw this exception instead if you want to.
It feels to me that `api-utils/l10n/core` should directly export short local.
you don't need callback argument here.
I am not sure how else to the Listener here without making a class for it.  Ideas welcome.
There's a balance between an open web and privacy? That implies giving up privacy would give me a more open web, or that a closed web would be the most private of all. This same wording showed up in the Persona Copy draft that Crystal mentioned on the list last week. Should we review that copy before merging it, or merge now, adjust later?
ah ic, okay then I'll leave this issue unresolved for another story
I wonder if I should just implement the `ifconfig` method as a wrapped call to `exec`.
Good call.  Added deprecated signatures back in for my next commit.
It has come to pass.
It's fixed, thank you.
`ambiente di produzione`
I agree with @weierophinney. Your syntax is not common, so your intent is not clear at all.
I'm against that as well. Thats mainly owing to the "old" behaviour of Zend\Uri that expected relative URIs without a scheme to be of type \Zend\Uri\Http. I will see through the tests whether chainging that back to 'null' will break anything.
Ah, right -- forgot about that! :-)
@weierophinney There are more files without the namespace declaration:

>library/Zend/Form/Annotation/AnnotationBuilder.php
library/Zend/Form/Annotation/Attributes.php
library/Zend/Form/Annotation/ErrorMessage.php
library/Zend/Form/Annotation/Filter.php
library/Zend/Form/Annotation/Flags.php
library/Zend/Form/Annotation/Hydrator.php
library/Zend/Form/Annotation/Input.php
library/Zend/Form/Annotation/InputFilter.php
library/Zend/Form/Annotation/Name.php
library/Zend/Form/Annotation/Type.php
library/Zend/Form/Annotation/Validator.php
Rephrase, unclear
GenericAnnotationParser
You can reduce this to
```@throws Exception\InvalidArgumentException```
Come sopra
This gets rid of the weird problems in mercurial pulls/pushes about unverified certificates. You'll see the relevant line in the .hgrc under `web.cacerts`.
what about underscores ?
missing a few spaces for correct indentation :p
We probably only need a float here too. ;)
Idiomatic.js: Space inside parens.

`(function(todos, document) {` -> `(function( todos, document ) {`
APPROVED
I was thinking that as well, but if we did that we would want a separate class just for logger to handle any options passed by the user.  This way they have the best of both worlds.  Either they define a logger or we do.  Plus, it deals with all the testing issues.
@satuaalto Ennen tässä on käsitelty ASIAKAS-saraketta, nyt käsitellään YTUNNUS-saraketta. Eli aika kova muutos, en valitettavasti usko, että voidaan lennosssa vaihtaa tätä konseptia näin. Tehdään mieluummin tässä tapauksessa poikkeus siihen kohtaan jossa tsekataan kentän maksimipituus.
First letter should always be uppercased. Do you start a paragraph using lowercase? =P
This is obviously for MySQL: are there other engines using different characters for quoting identifiers?
Doing `buffer ++ [codepoint]` is bad in terms of erlang performance. We should use recursion or always append at the top. I would write this as:

    def codepoints(string) do
      do_codepoints(codepoint(string))
    end

    defp do_codepoints({ char, rest }) do
      [char|do_codepoints(codepoint(rest))]
    end

    defp do_codepoints(:no_codepoint) do
      []
    end
Aha! Fungovalo mi to, lebo som tam mal __init__.pyc. 
Teda init vratim spat.
use 

prefmpi = self.getcfg('preferredmpi')
... % prefmpi

to clean up
add a (simple) docstring here, e.g. "return encoded version of class name"
I had tried `(void*) arg` but that didn't shut gcc up.
Yes, ignore me -- my brain is obviously a coffee behind my fingers.
can we do it custom field?
A test for this method would be nice as well.
Do you need the parenthesis around the `'foo' % var`?
is there much overhead with just including connect lib utils?
Shouldn't you be pulling the groups from `self.cleaned_data` and not `self.instance`?
the problem is, we seem to be experiencing intermittent failures of this test. it is my suspicion that with so many different people running these tests against the same server, there may be a race condition where multiple separate people/test processes are pushing the button in between the two measurements. that it only increments exactly one can really only be tested when you're sure nobody else has access to the data.
Okay, I made the change.
My initial view was that why should a data process not have an input. I figured if you have something that only produces output, it should be called a data producer. But I was probably mistaken about the way meanings are used for the words, and the nuances of names. Thanx.


From: Luke Campbell <notifications@github.com<mailto:notifications@github.com>>
Reply-To: ooici/coi-services <reply@reply.github.com<mailto:reply@reply.github.com>>
Date: Wednesday, September 12, 2012 11:00 AM
To: ooici/coi-services <coi-services@noreply.github.com<mailto:coi-services@noreply.github.com>>
Cc: Swarbhanu Chatterjee <SChatterjee@asascience.com<mailto:SChatterjee@asascience.com>>
Subject: Re: [coi-services] Remove transform resource from data process managment service (#274)


In ion/services/sa/process/data_process_management_service.py:

>
> -        if out_data_products is None:
> -            out_data_products = {}
> +        validate_is_not_none( in_data_product_ids, "No input data products passed in")


Data processes, to my knowledge can have (no) input data products...

—
Reply to this email directly or view it on GitHub<https://github.com/ooici/coi-services/pull/274/files#r1587862>.
no console.log here please.
A space is missing after `elseif`.
@MoonScript because if(!""){console.log("yep");} writes yep to the console log. We have several translations that are empty strings for good reasons which the old check failed for.

I think the authors original intention was to not include any third party libraries. I think I can do this cleanly with asset pipeline though, so I'll give it a shot.
Ah, that changes things. I'll rework this patch, then.
You don't need this if statement, since ```ZU.xpath()``` will just return an empty array if it doesn't find anything, and iterating over it won't hurt.
Description does not reflect method name. Load != get.
Typo? Shouldn't it be contemplate
sounds good, will update
I leave it to you, seems like since this is a heuristic anyways checking the length just in case can't hurt anything. 

    String mimeParts = typeParts[0].split("/");
    String extension = mimeParts[mimeParts.length > 1 ? 1 : 0];
No idea how that changed.
Seems better to me.
I saw a comment on this before and now I don't. I'm using this code because its the code for the developer page for facebook/twitter (and quite similar to g+).
I would use a dict here with authentication as name. It should have username and password as properties.
I think this is not a very good idea. Consider all those rel="nofollow" anchors where this would trigger.
In the normal quadrotor case you when you enter the mode you want to set the ref yaw to the current yaw. Which is done in reset_psi_ref_from_body().
So this is not the solution... I more and more get the feeling that we need to handle the transitioning vehicles separately (or at least depending on which "mode" they are in, hover or forward flight).
shouldn't this create + return a subdirectory below FILES_DIR?
Dict comprehensions require Python 2.7. For 2.6 you need something like this:
```python
dict((k, m_config[k]) for k in cls.CLIENT_METRIC_KEYS if k in m_config)
```
Why would that be wrong? Keywords are perfectly legitimate functions. Consider a case like:

`(maptrans {:a :foo :b :bar}  {:a {:foo 1} :b {:bar 2}})`

I would expect to get back `{:a 1 :b 2}`.
[""]
    {:get (constantly (redirect DASHBOARD-URL))}
Yeah fair enough, the plural would be a better indicator.
Doesn't this return the group object now?
remove useless ``super`` call
My first reaction to ``scanBackward`` and ``scanForward`` was that maybe a method with the common logic should be extracted. Though, I soon realized that the code would actually become harder to read than it is now. (just sharing my thoughts here ;-))
Yep, I have the same mixed feeling.
Remove double space after "WYSIWYG Editor"
то що тут?
Russian for `allowed` should be smth like `позволенные` or `допустимые`, shouldn't it?
Just stick this under EPG_TRACE rather than a new define.
```js
'undefined' != typeof document
```
I need the new version of the grit personally. I am agree u to lock the version for the popular. u can just ignore this.
The challenge here is that if predicate is not present, you still need to add it to the query. This means assoc_type can only be given with a predicate. This is good, but please check this condition.
please follow the style guide... http://codeigniter.com/user_guide/general/styleguide.html
Передаем (NSString *). Возвращаем (NSString *). Тогда почему (id)?
заполнение массива происходит ленейно - 0 1 2 3 4, и мутация соответственно тоже
по условиям задачи нужно производить мутацию по случайному индексу
вопрос снимается, посмотрел внимательней, что происходит. в общем, много "пустых" итераций и тут и там, об этом тоже в комментариях ранее упоминали, но ничего не поменялось.
Лишняя инструкция
Just cleaning up a lint error from yesterday's pair session with Gord.
I'm not sure this is the best place for this logic. I think this needs to be moved to the context menu block under the bb10 ww platform. This file is just a generic touch event emulator. So, it should trigger a "longpress" event that can be captured elsewhere. We cannot start mixing platform specific logic with ripple core components. For example, the Cordova platform has no interest in this bit of code.
This error message makes no sense.
Use the params keyword here:

    res = urlget(url, params=dict(fields="mode"))
Maybe we can delegate respond_to to `@api`
There's still a bit of an issue here. If a subscription yields an object, we'll have filled in the non-subscribable arguments, but not necessarily the other subscribables, right?
Gjort!
This is a relic of the past. I removed it as it is no longer necessary.
Added a require. Yeah. Imma hacker alright.
same baseline pb
Avoid [unnamed numerical constants](http://en.wikipedia.org/wiki/Magic_number_%28programming%29#Unnamed_numerical_constants) I would put `"89504e470d0a1a0a"` in a variable and give it a descriptive name, like `var PNG_IDENTIFIER = "89504e470d0a1a0a"` so that someone reading the code later will know why we are comparing the first 8 characters to that seemingly random string.
I stil find visit types by id or uuid, but I don't use exception to change the flow (it's considered bad practice) so I check if it's a number to decide which service to call. The final result should be the same.
@DaQuirm "Never allows a change to SUBJECT" reads a lot better than "Never allows to change SUBJECT" in my opinion. 

While English is my first language, I'm not an authority over the language. :)
Use attr_reader for `cache_dir ` here and on [line 22](https://github.com/refinery/refinerycms/pull/2083/files#L5R22). In case `cache_dir` needs to change in the feature we'll have to change it only in one place.
`not . null`
the filename is wrong as you explicitly warn against this file above
wrong constant names. ``FORMAT_`` is missing
I don't think that any of these should have capital letters after the first line. What do you think?
This is because they trail with `|` which means `split` gives an empty result. Perhaps its better to just check the last one and then slice it off it's empty? Toss up between strict-parsing and efficiency?
.put('/' + db_name("b")+ '/barfoo', "{\"bar\":\"foo\"}")
Oh, thanks, will fix this as soon as i get home.
Thinking about it. What's the point of awaitActivation when you can just do Await.ready(camel.themethodthatreturnsthefuture(actorref), timeout)?
IMO - you should changed the standard. getters and setters only do one thing. It is a waste of bits to document something so simple unless it does something more.
it is. I'll think up something new than this, there is a strange smell here.
Пробел же после SLOT.
qWarning
Это уж скорее `PWarning_` или даже `PCritical_`. А если это вызывается в ответ на пользовательские действия сразу — можно и вообще `QMessageBox`'ом уведомить.
no need to indent the content of fenced code blocks. However, you need to add the opening PHP tag otherwise the syntax highlighting would not recognize the code
Just a quick detail, a single `#` is sufficient.
98 should be a string here, no?
这里面大量使用5.4的新特性了么？如果没有的话，我更倾向于原来的 array
Here you also need to hide the remove button in an else case, as we are reusing one single view instance all the time. Basically you have to explicitly set each view property which can be modified for a cache.
Geocaching.com
Change committed.  I also added the one blank line back that I had removed.
We already have MySqlAppStatus.is_mysql_installed.
Wouldn't it be more efficient (memory wise) and faster, to use arrays internally within the method and in the last step convert it to a set?
We should pass a config instead of relying on the directory structure.
@dmcdougall Please don't turn the kwarg into an arg.

The solution:
```python
eps = np.abs(self.ax.dataLim.extents).max() * 0.001
angles, lengths - self._angles_lengths(U, V, eps=eps)
```
I hate magic numbers like this.  Maybe we could use np.INF and np.NINF?
What exactly is being tested wrt self.axes?  Being None?  Being of length greater than zero.  I know PEP8 encourages this sort of semantics, but it is a pain in the butt to me to understand the intention.
This line is fine, but I don't believe the ```abspath``` is necessary. Normally: 

```
os.path.join(os.path.dirname(__file__), 'mpl.rc')
```
Would suffice.
Could this not be ```np.arange(256)``` rather than 257?
Well, `cm.cmap_d.keys()` and `cm.datad.keys()` both include all the reversed names like `gray_r`, which is probably not desirable for printing?  _cmapnames is created from datad before it gets the reversed names added to it, so I used that.  Didn't realize it shouldn't be exposed to the user like that, though.
Wouldn't int16 do?

```
>>> np.int16(0) - np.int16(255)
-255
```
I had to look up what hatch_style actually was. Maybe its worth stating in the docstring that it's ```hatch_style = (self._rgb, self._fillcolor, hatch)``` and what ```hatch``` is. Actually, what *is* ```hatch``` :-)? Is it always immutable or hashable?
Nevermind, this is just a whitespace change. I don't know how these things work, I'm such a noob.
I don't know if I agree that getting rid of the test is the right way to go about this. Perhaps the right way to do this if the test is say more "validating" the framework is to move it into a separate directory outside of the tests directory. 

I did see value having these styles of tests in the past for framework validation, although I agree that they shouldn't be in the same directory.

I'd suggest creating a different directory for these "framework validation" tests.
hi, if use wait_for_condition but can't solve the problem
Good point.  I really had no idea what people were using that field for anyway; I find it useless.  In English "game" is ambiguous, but I'm fine with committing to "jeu" for the French translation.
Thanks for the answer.
I think that I would prefer the notation below that is more explicit for me

firstset.union(secondset)
@dooremont please fix the indentation
I think the title will need a |safeUserInput
This can probably go now, as the widgetloader should take care of this.
4 spaces needed inside this `if`
@bp323 : We should consolidate the classes we are still using in our base.css file and remove this file (as well as the FSS folder)
I think you wrote this before last Friday's refactoring, which moved all the SlingHttpServletRequest stuff out to the base DomainObjectSearchQueryHandler class. The goal is to let these domain-specific handlers work purely with sessions and maps, so as to enable server-side use.
Group.ADMINISTRATOR_GROUP is added here to match the logic of adding User.ADMIN_USER. The group should have rights everywhere and so does not need to be explicitly added as a manager.
please put return false in a new line
Thanks, I have fixed this. :)

Now please review again for merging.
Good attention to detail here (translating into en_GB), but will need to be done through getlocalization.com (see http://doc.silverstripe.org/sapphire/en/misc/translation-process)
Actually, It's not possible to obtain the session key using `dev/tests/startsession`. It's not featured in this pull request.
As long as everything is okey :)
Would be nice to have this as a template in the `templates` directory and load it via requireJS's text plugin, so that we don't have too much embedded HTML/CSS in our JS.
I split out the "dirty the root page" semantic into a separate function, it's only used by the checkpoint code.
Query layout is incorrect!
Alright, going to change that.
Are you sure you want to override the parameter ``$attribs``? This often makes code less readable.
Are you sure ``'Pagination adapter manager must extend AdapterPluginManager; received "array"'`` has the correct type as "string" is not a sub-type of "string"?
Can we use this https://github.com/avalade/grunt-coffee ?
мне кажется этого метода не существует
"If the optional type T was specified, then call the [[DefineOwnProperty]] internal method of O passing “name”, Property Descriptor { [[Value]]: T, [[Writable]]: true, [[Enumerable]]: true, [[Configurable]]: true }, and false as arguments."

so this should check for e.name
I'm not a fan of removing all the periods for these types of cases.  For example, say you wanted to added some extra information; you'd need to add a period to separate it.

```
The mocked database object for use by test methods. Say something else about it.
```
You would know better than I do. This simply maintains current functionality. If we want to investigate changing that functionality, perhaps that could be considered in another pull request.
Ah! Thanks, @scribu. I actually only used this shortform syntax because it was used in the imagick one, so the other guys must've forgotten that too. So we'll have to amend it throughout.
It is used, it is used so that the generic json writer will include "source" : getSource() in the ajax calls.
spaces around operators on the previous two lines
Оно и так организовано. Если в path записать, например, `/lightning/bsdb/config`, то все var'ы будут жить там.
Уносить это в chroot параметр zookeeper-сессии не хочется, потому что у этого параметра scope — вся ZK-сессия, то есть это коснётся всех юзеров данного io_zhandle.

Вообще сделать параметр chroot у io_zhandle можно, но с другими целями, а конфигурация пути до конфига транспорта пусть останется здесь.
Why store `urlresolvers.reverse('twitter_callback')` into session?
(you have a typo in your comment) 

Never thought about that :) This solution would be good.
Why importing signals?
Omg :)

2 days ago I had it like this: raise forms.ValidationError(_("A user with that username already exists.")), then you said: "Use self.error_messages". So I did it like that. Now you want me to go back as it was before.
Confused :S
*Vrednost je izven meja.*
Rewrap in our style.
I am really interested in seeing why you will be using this. ;-)
Do we really want to dump all plugins? I am not sure, because we also need filer content then, files, images, and so on. How could otherwise the content be rendered?

But on the other hand, this would allow also easier work for designer.

I am not sure why you don't use existing reverse relations on pages? `[page.placeholder for page in pages.placeholders]` and `[plugin for plugin n placeholder.cmsplugin_set]`
Good catch on setting `group`, thanks. I guess I need better tests around this.

Validation isn't broken, because we only assert that the field is present, not that it's non-`None`.
Ya, it's a confirm popup that continues with the action if you say yes and returns if you cancel
I understand. I could indeed remove the else statement as it's not needed here.
You mean, 5.0f? face :palm_tree:
"%*"
Which unit is this, use TimeSpan.FromMinutes(xxx).TotalSeconds, or TotalMilliconds, or something.
No exactly. The only case where this could break is when you have a while loop preceded by curly bracket in your do clause... I don't even know what the dev would be wanting to do while creating such a complicated nested logic. Anyway - it's either that or nothing.
No round trip? Converters are generally used by both SequenceFileLoader and ...Storage.
Same comment as the protobuf-based loader - how about hooking into MultiInputFormat and not having these format-specific loaders to simplify things for users.
'fields' should be applied only for top level json?
Немного странный способ.
Думаю, правильней было бы создавать класс Connection (Protocol по-твистедовски или назови его как угодно) и держать в нем состояние.
Тем более что состояние может быть довольно сложным.
Впрочем, прямо сейчас можно ничего не менять.
Humm, why there two loops? Can't we loop on it._commands['all'] and then testing hasattr ?
https://docs.djangoproject.com/en/dev/ref/request-response/#httpresponse-subclasses
That is exactly my point, the case in the code are PASCAL cased, when a word with more than one letter that needs to be capitalized, we only upper case the first letter. For details, please see http://msdn.microsoft.com/en-us/library/x2dbyw72(v=vs.71).aspx
The exported View should be added as a feature.
ahh, ok I missed line 586, ok go for it :)
Should just be `void CalcLighting(`...
This isn't complete, need also ``add_extension`` in the same way as for ``fast_linbin`` below.
There are [a lot of disputes](http://devblog.avdi.org/2010/08/02/using-and-and-or-in-ruby/) in Ruby community about using `and` and `or` in conditions. These operators have precedence different from their alternatives `&&` and `||` that requires more careful usage of them in conditions. As the result, some companies, like Github, simply forbid using `or` and `and` at all (see [styleguide](https://github.com/styleguide/ruby)), others leave them for chaining operations like `validate and save`. There are still some ppl that use them just because they are more verbose, but I believe these proud guys are in the minority. Honestly, I used to use them myself but under the pressure of the community switched to `&&` and `||` in conditions. 

@camertron, do you have some recommendations on that topic in Twitter's styleguides?
please keep the paginator count in a variable to count only once (like you did for the MongoDB adapter btw)
Okay, I just did it and was really struck by the fact that we never EVER use it.
You're right, I"ll remove that.
and here is seems like ```half_light_radius``` is not an allowed keyword?
Add system back.
That was usually code for debugging ( when we may ever add a " debug mode " ) but removed . Pulling changes from this repo , then pushing . Many thanks ;)
Thanks. Nice that it now tells you which key had the null value, rather than just a generic NPE.
Not sure what the use-case is for these addItem methods, but presuming it will become apparent as I read on through the code.
Better to log instead of e.printStackTrace
Some jclouds code in master definitely does use Objects.hashCode and Objects.equal.
e.g. commit 17079743f18ba3d1406f20ff1644882e8c5beb74
`these figures` plutot que `this statistic`
will it work with old OpenStack api? if yes rename in "openstack.properties" and add in description  note about supported api version
This is confusing "Downloading Phonegap" is the title, but the sentence says "Apache Cordova". Let's choose one brand name, and also perhaps explain the name change in an admonition.
Yeah, that makes more sense to me. I'll see what I can do with that in the next couple days.
`is None` is the correct check here.
Tim,

I agree, but that was the level before, I only moved them from
attributes/default.rb to the recipe.

Best,
Mariano

On Thu, Oct 25, 2012 at 5:51 PM, Tim Smith <notifications@github.com> wrote:

> In recipes/default.rb:
>
> > @@ -19,15 +19,52 @@
> >
> >  include_recipe "java"
> >
> > +case node["platform"]
> > +when "centos","redhat","fedora"
> > +  node.set["tomcat"]["user"] = "tomcat"
> > +  node.set["tomcat"]["group"] = "tomcat"
> > +  node.set["tomcat"]["home"] = "/usr/share/tomcat#{node['tomcat']['base_version']}"
> > +  node.set["tomcat"]["base"] = "/usr/share/tomcat#{node['tomcat']['base_version']}"
> > +  node.set["tomcat"]["config_dir"] = "/etc/tomcat#{node['tomcat']['base_version']}"
> > +  node.set["tomcat"]["log_dir"] = "/var/log/tomcat#{node['tomcat']['base_version']}"
> > +  node.set["tomcat"]["tmp_dir"] = "/var/cache/tomcat#{node['tomcat']['base_version']}/temp"
> > +  node.set["tomcat"]["work_dir"] = "/var/cache/tomcat#{node['tomcat']['base_version']}/work"
>
> Instead of doing node.set's here we should just change the sets to
> defaults. node.set is really something that should never be done unless
> there's a reason
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/opscode-cookbooks/tomcat/pull/6/files#r1946630>.
>
>



-- 
*Mariano Cortesi *
*CTO & Co-Founder @ Zauber Labs*
mariano@zauberlabs.com <mariano@zaubersoftware.com>
*twiter:* @mcortesi5       *skype:* marianocortesi
*github:* @mcortesi        *gtalk:*
mariano@zauberlabs.com<mariano@zaubersoftware.com>
*cel number:* +54 911 6505 1750
http://www.zauberlabs.com
Why does this only find authors who have made a blog post before? I'm confused
De acordo
They weren't in the beta release (so have never been supported). I added them during an earlier sprint, but there is no testing for them, and can't until we get a more serious test environment. Thus they're not going into 1.0.
the curly brace should be on the previous line for control sturctures
important comment is unclear - a missing "not", or "but" should be  "and"
mmm I think subclassing is probably a better solution than having a public field, what do you guys think?
@christianchristensen yeah - definitely agree with that - it's bothering me a lot.  I'm gonna do a few quick searches to see if I can use twig without $app
Don't really need a '{0}'.format(...) here -- that'd be equivalent to str(...) which isn't needed either because os.path.join returns a string.
python
Python 2.7.3 (default, Oct  7 2012, 12:28:38) 
[GCC 4.2.1 Compatible Apple Clang 4.1 ((tags/Apple/clang-421.11.66))] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import this
The Zen of Python, by Tim Peters

...
Namespaces are one honking great idea -- let's do more of those!
what, no oxford comma?
+ вопрос про бинарные файлы - что считать "строкой" в бинарном файле? Куски данных, разделённые символами с кодами \n  и \r? Получается, что "строки" могут содержать внутри себя нулевые байты? Считать ли те же нулевые байты разделителями слов? Если нет - как выводить их на экран?
This is the critical line here: Stop the load before sending off the notification that the loading failed
自分が入ってるから1の時に削除していい（実際には0はないんですけどね）んですが、確かに削除してからチェックしたほうがいいですね
Could use an internal link?
these lines have been removed for each core
yes sorry for that
Let's extract this functionality into the decorator discussed on list.
You're right, but this means displaying warning messages when the "new" code is correctly used.  I'm +/-0 on this one.
It seems to me that you don't need this function. What you are really looking for is the tertiary operator:
<pre>
transition_matrices = np.eye(n_dim_states) if self.transition_matrices is None else array2d(self.transition_matrices)
</pre>
80fa799
Is there a particular reason to make this a function instead of a static member variable?
Here is a bug, sorry about this. What I mean here is to use ``connected_components.sum()`` rather than ``len(connected_components)``, That is when the connected_components does not grows in current round, then we can stop rather than wait for looping for `n_node`.
I'm curious. How was just `Error` a problem? I think I just copied an example from somewhere so I don't know for certain which is correct.
Correct. This method should be defined in MockProviderApplication class as it is the object that we save. Also it will not be the class method.
In provider_appliations_controller#create action you do:

```
def create
  @provider_application = current_provider_model_class(:provider_application).new(params[:provider_application])
  if @provider_application.save
    redirect_to provider_applications_path
  else
    render :new
  end
```
and the provider_applications#new action:
```
def new
    if params[:launchable_id].present?
      @launchable = current_provider_model_class(:launchable).find(params[:launchable_id])
      @provider_application = current_provider_model_class(:provider_application).new
    else
      redirect_to launchables_path, :alert => "Please select Application Blueprint first"
    end
  end
```

and the provider_applications/new.html.haml:
```
= form_for @provider_application do |f|
  = f.hidden_field :launchable_id, @launchable.id
  = f.text_field :name
  = f.submit "Launch " + @launchable.name, :id => 'save'

```
Hrm, this is consistent with `xpcli`, if we decide to change it (and I agree we should) it should be done in both places.
Put it on line above
I've added some REMarks for you :)
Un tableau d'identifiants de collections. Si aucun identifiant de collection n'est donné, la requête est exécutée sur toute les collections disponibles
Dans le module admin, cliquer sur...
You are using se same line of code in show update edit and destroy. Perfor a private method in this controller to get this info: @user = User.find(params[:id]). Then use the method as a before filter.
I don't think this will do what you think it will do. I believe @artefacts will contain a query proxy object, and will only be run when iterated upon.
I would feel the same about most (if not all) daliadmin methods...
going mad, thought I saw a reason before..
I'll check with mutable on cache and allAllocators off shortly.
This does look right..

Your rows are already in rowsToSort, and you are iterating through them and inserting into same array afaics..
what happens if an old delta is shorter than the new header?
>note that I tell it the array is 'i' elements

Ok, yes I'd missed that part.

A comment wouldn't go a miss to clarify
It is unrelated, except that it should be doing the same thing, and one of the changes I experimented with, and then removed, involved more work being done in this case.
My test cases weren't thorough enough, and this code changed many times. ;)

I think by "quote" you mean "escape", right? This code is only supposed to remove escapes, not quotes.
reminds me of code in resolveRemote() should it be commoned up?
I really don't understand the logic here. Granted, I'm not familiar with the business logic. However, it's odd to change the value of a variable like that. So I think it would be great with a little comment explaining WHY this is done.