labofsahil/github-event-dataset-2012 huggingface dataset:
I don't remember why exactly, but I tried to put this in the template but couldn't get it to work. There is an issue with Dojo templating where certain things like event handler registration only work if done after things are added to the DOM, but with templates there is  a Catch-22 problem (I saw discussion of this on the Web), and I discovered that the only way around it was to add the button via JavaScript. It took a few hours to figure all of this out. It would be nice if the Dojo docs actually explained these limitations rather than requiring each and every developer to re-discover them.
Confiteor quia peccavi nimis cogitatione, verbo, opere et omissione: mea culpa, mea culpa, mea maxima culpa.
alertImageView was allocated, so removing this will cause a leak on non-ARC builds. I suppose the allocation could be changed to autorelease instead of explicitly releasing though. I'll need to think about this a bit more as well as memory profile differences if the autorelease pool is removed.
I didn't mean \#90, but instead \#99.  Though there are connect retries here that were attempts to address \#90...
Technically speaking, we could separate `with` from th type class, but keeping it this way allows for a more efficient representation, since we can use Control.Exception.mask directly instead of the lifted version.

As for the name: I agree. Have any recommendations? I was thinking off `allocate`.
I guess you mean `ui-test-widget` :P
This probably needed to be changed to UnsupportedOperationException. Using this exception from the sun package was an accident.
зачем?

2012/2/3 Ildar Hizbulin
<reply@reply.github.com>:
> хорошо бы `<form:select path="mode" items="${modes}"/>` поднять над textarea
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/maxcom/lorsource/commit/f13926a382fbce63af4d1276a7c26c6f2bf38a62#commitcomment-929684
Fold this into agl::Window as per Eyescale/Equalizer#70.
For `gCollect()` and other boiler-plate code, the best place is obviously in the generator. For more interesting code, such as what's in Reference, I would do the following:
`Implementation<SomeImpl>: BasedOn<SomeImplBase> { .... };` that would generate `SomeImpl: public SomeImplBase { .... };`
My theory is that `callback` is an optional argument, so while this seemed to work correctly for `jitsu` it would break for less sophisticated cli apps. It's also possible I made a mistake and accidentally added a callback in a scope where `callback` wasn't even defined.

I'd leave it be, except we want to hit the callback with `jitsu` so we can print 'nodejitsu ok' after showing the help.
Can you send a pull request for this? Would love to get it properly reviewed and into master.
Since we control all the test code, can't we remove this method all together and replace any code that uses it with a direct call to cleanUp?
Truth be told, main menu now sucks because of weird color and inconvenient location
Really a XD bug.....why did I do something like this Orz
SPAM ONS AUB KEER NIET!
Jejeje, great!
You'll be able to remove the parens once you switch your args to the standard order.
That is the general direction I want to take the packager.

The only issue is figuring out the ordering of includes (since that really matters now with Almond)
This looks much better than my pull request! Thanks for fixing.
Take a look now. UDPBurstTask has a single TYPE and I created two (mutually explicit) radio buttons to capture the direction
イベントハンドラー設定中の誤操作で TweenMain.Form1_Load メソッドの中身が空っぽになってた･･･:scream:
https://github.com/opentween/OpenTween/blob/74c0560a/TweenCS/Tween.cs#L549 （重いので無理して見なくていいです）
для сведения: вроде рельсы поймут даже если удалить этот метод вообще (они догадаются по наличию вьюшки с правильным именем), но лично я не удаляю методы - так мне понятней и проще какие методы есть
![so close](http://www.paulohsms.com/wp-content/uploads/2011/03/fred-mercury-queen-meme-so-close-150x150.png)
scanner won't work without alert hack, but will work in clean ruby project -- check to see if helpers/layouts/header/footer/jquery is affecting it
updating bank info/profile info currently works, but is not using correct submit call!
Does this do what we want? From the looks, existing eventclients won't be updated?

Users currently using Dharma from xbmc ppa should be able to upgrade and see existing eventclients updated, and optionally install the ones requring deps (java, bluetooth, etc)
This looks wrong. The labels will not usually be in the same space as the input features. For example, a convolutional model of CIFAR-10 has the space of 32x32 images as its input space, but its labels are just integers from 0-9.
I would be handy to put this change in the Change Log for this version. I just spent 4 hours debugging my program after upgrading to 2.1. If it was in the change log I would have updated my field sizes and had no problem to fix.
с точки зрения логики ты сейчас должен показывать подсказки, а тут какая то валидация....
y esto para que es?, no entiendo D:!. ahora que ves lo de distract creo que esta spell interrumpe cuanto tomas agua y esas cosas.
saludos, ya regrese D:!
Oh I see, it's used there. No worries, leave it as is.
Thanks, I think this is now fixed.
this is alright but I reckon when/if we ever assert a web_root option for maraschino we will have to change to relative paths right?
You are trying to commit your local changes to sqlconf.
Very bad thing to do.
Van't you get the specialty title from the Title in the Specialty lists
i agree that this is currently superfluous, but this general method seems like it could be a good localStorage write abstraction if we do ever return to using localStorage again (or not, i guess other people will have written better abstractions in the future (i.e. bankersbox?))
sparser then models regularized with a l2 penalty.
Oups forgot comment : search @import in compressed file too (in use with compass and compressed output style for example => single line)
Good point, Ewan. It makes sense using core Likes with adjusted language strings.
I'm not sure why there is an empty do block here. It looks like there is also an empty block in the the content_partner route above as well. Did there used to be code in the block that was removed? I suspect you can remove the do block from this and the content partner block above.
Not from what I could see... might me missing the point entirely tho!
1) /usr/include/sys/types.h:153:22: error: duplicate 'unsigned'
/usr/include/sys/types.h:153:22: error: two or more data types in declaration specifiers

-> I see, it shouldn't include that file but types.h from the emulator (see m68k.h). It seems like I added the include to m68k.h for something I then reverted later (C89 fixes probably ?) but forgot to remove it later. I think we can safely remove #include to types.h from m68k.h and let #include to stdlib.h in m68kops.h (and yes it was already there, it's indeed needed by a few functions). It's however strange the compiler is not picking the correct include file (it makes me wonder what it does with the other C files where types.h is needed).

2) Thanks for the explanation about NTSC filters, I will have a deeper look into Blargg's configurable implementation (it's very possible I removed stuff not needed for GX port when I first implemented it) but I guess we can safely use the USE_15BPP_RENDERING #define for that one and modify vdp_render.c to allow NTSC filters for 15 or 16-bit RGB output.

3) About SRAM being always active, I answered you in the bug report topic.
Or so I thought -_-
Hi Tair,

If you like the back ticks, feel free to leave them in everywhere (including windows). My point was purely:

`cd C:\Program Files\PostgreSQL\9.1\bin\`

Should be:
cd C:\Program Files\PostgreSQL\9.1\bin\

i.e. none of the other *cd* commands have back ticks around them.
qm prefix done.
Nice Gravatar
```c++
-if (caster->GetCreatureType() == CREATURE_TYPE_BEAST() || caster->IsMounted())
+if (caster->GetCreatureType() == CREATURE_TYPE_BEAST || caster->IsMounted())
```
is `Object.get` /  `Object.set` now going to be the standard way of accessing object properties?
Ugly but effective.
Thanks jHack !
Cheers
Is this correct? Isn't AUTO auto-ack as well?
This is not enough. The table {dev_git_user_aliases} provides just explicit mappings - that is a mapping based on some additional email address than the one currently used by the user at moodle.org. If some developer has the same email in the Moodle profile and in the Git commit, no alias is created for them and the userid is stored directly in {dev_git_commits}

So we need something like

    SELECT DISTINCT userid FROM {dev_git_user_aliases} UNION ALL SELECT DISTINCT userid FROM {dev_git_commits}
The only reason why I don't like mysql is that I like postgres much more.

But for rails development I don't care about database backend.
Should be a list of floats or integers
Actually, this works since i can't easily get an iterator from an Array.
Nice one. We should definitely not take ourself too serious. It'll be a lot of fun with these messages :smile:
I would write e-mail, but I cannot find contact on you here:

Would you mind if I will integrate your branch back to upstream? There are quite a few fixes I think other would appreciate too, like this one.
By the way, this cookbook is not currently used (new Ruby VM images are not deployed) and we probably take this as an opportunity to switch to using the tarball.
Why note "32M" like the other two changes?
Actually, I intended it to be enabled only when jribble target is chosen. Notice that JribblePlatform is being instantiated only if jribble target is selected:
https://github.com/scalagwt/scalagwt-scala/blob/scalagwt/src/compiler/scala/tools/nsc/Global.scala#L71

Thus, we touch this setting only if jribble target is selected.
@chillu, that makes sense, will add
@brettfishman paired with me on these changes and deserves equal credit.
This line isn't checking that there is something in the username. A username with the length of 0 characters would still be considered valid with this if statement.
"this function" being cmd_exec?  Yeah, without the test -r it gets kinda ugly.
> Just curious - why are we removing this one `else if` here? Is this check encompassed in the `if` statement on the next line?

The `if` block above throws, so the `else` is unnecessary. Control can't pass positively through both `if` clauses.
*starts playing broken record*
Space-indentation
Space-indentation
Space-indentation
Space-indentation
Space-indentation
This means it no longer logs a severe error if the lastAddedCommand doesn't implement IdentifiableResult.

But IMO, the better default behavior is probably to fail-fast when it isn't an instanceof IdentiableResult?
Hm...  There must be a better way...

Aha!  Take a look at .exists() (same link as for count() above).  I think the following would be cleaner, but otherwise functionally equivalent:

```
if not meeting_times.exists():
    return False
```

As for the ordering, I kinda feel like requiring ordering by a particular field but not checking this, is in some sense worse than not checking at all; it's a less-likely but harder-to-catch failure mode.  I'd rather risk using Django's private API (meaning we might have to fix it in a future release, but probably not as I think this particular bit of code is relatively stable).  It looks like the following would work:

```
assert meeting_times.query.order_by and meeting_times.query.order_by[0] == 'start'
```
What do you think of:

```ruby
user_required and return unless @article.public?
```
I think there is a more subtle bug here. From looking at the code I see two things:

1. The same DequeueReusableCell key is used with two different cell styles
2. If #1 is fixed DetailTextLabel should never be null when summarySection != -1 

I've found this out btw, because I have a case where DequeueReusableCell even with separate keys is not returning cells with the proper styles (i.e. the styles that there were created with). I've got a repo case for this that I will be reporting soon.
Ughh.. I had that one too, but I edited it with github's gui editor and all unicode hell broke loose. Nice idea Wired.
se alguem souber fazer esse form com simpleform agradece a ajuda, pois nem um dos colaboradores do mesmo, conseguiu =/
Performance.  The only reason for the change was to reduce the number of operations needed to obtain the function. Granted, it was a micro-optimization.
eso eso, es que lo cambie en casi todos lados pero demás que se me pasó uno :)
Pro: no need of immediate `position: relative` ancestor.
Cons: relying only on this this positioning will break if any vertical modification comes between the beginning of the "closest positioned parent" and the field.
Example: http://jsfiddle.net/7BgEy/
https://github.com/IceColdSandwich/android_frameworks_base/commit/5f1efd89eafdc8f868e828677638cacddc9888ea
Hi Alec,

Thanks for all these and apologies for the errors. I'll have a look
tomorrow (or ASAP) and respond here when I've implemented these fixes.

Best,

M
On 2 Nov 2012 19:44, "Alec Smecher" <notifications@github.com> wrote:

> In templates/about/index.tpl:
>
> > @@ -32,7 +32,7 @@
> >  	{if $currentJournal->getLocalizedSetting('reviewPolicy') != ''}<li>&#187; <a href="{url op="editorialPolicies" anchor="peerReviewProcess"}">{translate key="about.peerReviewProcess"}</a></li>{/if}
> >  	{if $currentJournal->getLocalizedSetting('pubFreqPolicy') != ''}<li>&#187; <a href="{url op="editorialPolicies" anchor="publicationFrequency"}">{translate key="about.publicationFrequency"}</a></li>{/if}
> >  	{if $currentJournal->getSetting('publishingMode') == $smarty.const.PUBLISHING_MODE_OPEN && $currentJournal->getLocalizedSetting('openAccessPolicy') != ''}<li>&#187; <a href="{url op="editorialPolicies" anchor="openAccessPolicy"}">{translate key="about.openAccessPolicy"}</a></li>{/if}
> > -	{if $journalSettings.enableLockss && $currentJournal->getLocalizedSetting('lockssLicense') != ''}<li>&#187; <a href="{url op="editorialPolicies" anchor="archiving"}">{translate key="about.archiving"}</a></li>{/if}
> > +	{if $journalSettings.enableLockss || $journalSettings.enableClockss && $currentJournal->getLocalizedSetting('lockssLicense') != ''} <li>&#187; <a href="{url op="editorialPolicies" anchor="archiving"}">{translate key="about.archiving"}</a></li>{/if}
>
> (As above)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/pkp/ojs/pull/49/files#r2020452>.
>
>
I'm not sure I understand the question.
the parseError function is supposed to enrich the error message with line numbers and add line number, char number and stylesheet to the error object before throwing.
yes, space at the end to make a new line.
Just a note that all parameters should be final.  :-)
won't this result in a server 500?  It really should be the status code for bad input.
AFAIK, once per classloader, which is the intended behavior.  I'll do some research and testing, though, now that you ask since it's a good question.
Is this the correct order? Should we introduce a composite operation to avoid accidental fcukups?
What about: statusPromise.failure(InvalidException(e)) and statusPromise.failure(e) ?
removed.

RESOLVED
unmask_re is the wrong name now since mask/unmask is now history.
Nevermind, you're using node.placement, which is a static string. I blame the long day.
when do we need  the alternative contrast specification ?
this line is bad use named params
Have you seen Dominik's email to ckan-dev about process testing with webtester? I think these kind of tests might be the best for this as reasonably quick to implement, can derive tests from user stories, tests the whole code from top to bottom. May also need some functional tests e.g. for the api
BLOCKER: Missing unit tests for get install schedule for a consumer
BLOCKER: Missing unit tests for get all installed schedules for a consumer
BLOCKER: Missing unit tests for get schedule when consumer is missing
BLOCKER: Missing unit tests for get specific schedule when consumer or specified schedule is missing
I don't like the idea of hardcoding time outs in code like this. Is there a config accessible to this code we can put this into? In the unbind case, this may be a problem if the CDS unbind does clean up operations that take longer than 10 minutes, we'd have no way of ever controlling this value.
these should use #fetch, no?
Hmm. Never mind. we use non encoded paths in xbmc, and encode on request libsmbclient.
We need to not have `$_POST['key']` or `$_GET['key']` anywhere in queries, especially since this code is completely open to be seen, it's a security risk.

This data needs to be validated.

It happens a bunch of times on this page, as well as `pages/admin/seo/webpage/ajax/save-seo.php`
Testing when servlet mapping is found
please adjust whitespace
I don't think we want to kill the whole daemon just because a calculation went wrong. It could be for metrics you don't even care about for example. I also don't think we need an extra event just for errors. The flush case in the backend should be able to handle this just fine. But I think we should update a counter `statsd.calculation_error` or something like that to actually record the failure.
I'd rather keep it abstract because it forces you to do be explicit about what you want.
Alright, well, that debate ended fast. I'll fix the `if ()` statments... :cry:
Can you please add some documentation to this class and its methods/properties?
Use `MakeCallback()` here.
Confirmed that these APIs are not all present on Windows XP so LoadLibrary/GetProcAddress are the right way to go (same pattern was used for ETW).
listen for the 'next' event
I would suggest merging this with these changes and then go though lenv.c and split it into a Windows and Unix version.  Then we need to change the Windows version to use the *W functions.  The put function may also need updating.  Not sure if that is also broken on modern Windows.
Unnecessary constructor argument - `false` is redundant.
@normanmaurer +1
not just the same coordinate (spelling) system, but also in the same space within that coordinate system with the same voxel dimensions.
I should have taken a greater look at the PHP source before asking that, sorry.
This isn't really a bad thing, but why the `\n` here?
I agree. I was simply trying to match the style of existing tests. See `#test_skip_invalid_escaped_attributes`.
I would prefer to write that as 2 different test (one for normal string input, another with an html_safe string), and can do that if you agree.
@carlosantoniodasilva no, there are a lot of things that are autoloaded across the rails codebase
Portuguese again
Wow, that's a tricky one mate, a TreeSet will not want to become a HashSet, right?
In general (and here specifically) you should separate the error handling from the logic.  Write a clean method which returns MacroImplBinding, and wrap a call to that method with the exception handling code (in another method if appropriate.)This makes code way easier to reuse, including within the same file -- and if there's one skill where we are in desperately short supply, it's successful code reuse.
Yeah, I'm capable of working around it.  A setting which disables swing would be thrilling, way ahead of what I'm currently doing, "git merge origin/java7" with periodic annoying failures on swing if I forget.
Add at the end of the test file:

    if __name__ == "__main__":
        run_module_suite()

where run_module_suite() is imported from numpy.testing.
I would refactor this into

    key_string_lengths = [len(key) for key in self.keys()]
    
    m = max(key_string_lengths) if len(key_string_lengths) else 0
Please do not alter `.travis.yml` to add support for 1.9.2. We were encountering intermittent segmentation faults on 1.9.2 and as such we do not officially support it for Spree. We recommend people use either Ruby 1.8.7 or 1.9.3.
Well, it was to prevent someone shooting themselves in the foot if changing constants. Since this function is called only once per queue lifetime, I thought it was OK to check.
Should these be immutable?
The real tests in here should be under test_real.
I think this method is just Union(self.args)
Indeed, `Add(0, 0, 0)` should end up as `0`, not `Add(0)`. So going `Add(0, 0, 0) -> Add() -> 0` would avoid complicated special-casing.

Another thing: this rule only makes sense for associative objects and applying it to Basic is therefore rather confusing.
Actually, I am not using this variable for this test and I plan to remove this
It looks like you take in only one arg and don't use any keyword arguments (You pass them on to FiniteSet but it doesn't take any either). 

You could simplify this to just "partitions" if you wanted to take in a list of lists
Alternatively you could accept "*partitions" and accept input like  
Partition([1,2], [3])
You can just use `min_module_version='0.12'`
Remove spaces around `**` here and below.
If you added the `@threaded` decorator, would it then work?
I have the impression that using None is more "pythonic". It is what usually is suggested. You can just add as a first line of your function `packages=packages if packages else []`
OK, next time please add a space between `if` and `(`
convert the scheme to lower case before this comparison incase we get something like HTTPS or HTtps
On line 262:

```
registerExceptionHandler();
```

What if they're using appblade sdk but do not want the custom crash reporting?
This API is complicated not to say that does not really solves much, I can always require `event/send` and use it for sending events on objects I'm not supposed to. Only real way to prevent everyone from doing it is by capturing `event` instance in a lexical scope and exposing proxy that let's one to observe it and does not let you send. That's exactly what signal is supposed to do IMO.
This is true, but the caveat is that ActiveRecord allows you to use the
prepared statement syntax, whereas this does not.

On Fri, Sep 14, 2012 at 11:52 AM, Takashi Yonebayashi <
notifications@github.com> wrote:

> In src/java/com/rapleaf/jack/AbstractDatabaseModel.java:
>
> > @@ -533,8 +533,26 @@ public boolean deleteAll() throws IOException {
> >
> >    @Override
> >    public Set<T> findAll(String conditions) throws IOException {
> > -    PreparedStatement stmt = conn.getPreparedStatement("SELECT * FROM "
> > -        + getTableName() + " WHERE " + conditions + ";");
> > +    return findAll(conditions, null, null);
> > +  }
> > +
> > +  @Override
> > +  public Set<T> findAll(String conditions, int limit) throws IOException {
> > +    return findAll(conditions, null, limit);
> > +  }
> > +
> > +  @Override
> > +  public Set<T> findAll(String conditions, String orderBy, Integer limit) throws IOException {
>
> Pure string conditions are supported in active record and are vulnerable
> to SQL injection. I think it's up to the developer to avoid SQL injection
> when they construct their query string.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Rapleaf/jack/pull/52/files#r1610612>.
>
>
Taras says this is fine :)

Also, we need to assign an empty dict anyways at some point.  And, lastly, currently this code is mostly intended to be run in test cases.
These tests belong in the `ConfigValidationTest` for consistency with other domain object validation tests.
The transaction semantics have changed here - previously, all parts of the transaction were within one session, but now the parts might be spread across multiple sessions.  If each part/action commits, this should be fine, but if not...
I don't see any need for multitouch support. What you've got working is really clean and smooth - exactly the functionality I'd expect from this. What I'm seeing is errors surrounding multitouch. I noticed it bugging out a little bit occasionally, and eventually realized that it was when I was accidentally touching with two fingers, or if I put a second finger down while I was still interacting with the first. I might play around with that piece if I have time. I'll let you know if I come up with a solution.
Hmm, I don't seem to have `jquery.simplemodal.1.4.1.min.js` - should that be a part of the PR?
looks like you could consolidate this to the parent conditional?
Should point to the actual license. `@license http://opensource.org/licenses/gpl-2.0.php GNU General Public License v2`
@EXreaction  please describe the actual limitation that you are hitting. As far as I am aware it is possible to pass arbitrary parameters to any constructor. Therefore, don't pass parameters that are not needed.
I don't see the issue. You can change the magic call function of the cache service to maintain BC.
Function name and return value needs some more looking into if this function is supposed to work like all the other validate functions such as validate_jabber.
this.dimensions, this._dimensionPaths, options.useAllDimensions, this.dimsUsed should probably all be cached outside the double loop here.
controversial
I think there's still some validity in lines 185-188. If there's no binder for a mojit, we don't need the binderMap information.
Have a look at getCompilerOptions

Am Mittwoch, 19. Dezember 2012 schrieb muescha :

> In lib/assets-compiler.js:
>
> > @@ -27,16 +52,27 @@ AssetsCompiler.prototype.require = function(module) {
> >  };
> >
> >  /**
> > + * Precompiles assets in /app/assets/coffeescripts and /app/assets/stylesheets
>
> If i look through the code there is never the assets/coffescripts folder.
> Only the assets/javascripts folder
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/1602/compound/pull/250/files#r2469967>.
>
>


-- 

Mit freundlichen Grüßen,
Sascha Gehlich
Founder & CEO

Mobil: +49 (0)151 4190 2765
Mail: sascha@gehlich.us
Web: http://www.filshmedia.net

*FILSH Media GmbH*
Kortumstraße 26
44787 Bochum
Germany

Firmensitz: Bochum
Amtsgericht Bochum, HRB 14141
Geschäftsführung: Sascha Gehlich
The viewLocationCache argument to the GetViewsThatEngineCanRender method was hiding the viewLocationCache field. I made GetViewsThatEngineCanRender static because it fixed the hiding problem and also made sense anyway.
There were callback in another callback.
http://scitools.github.com/iris/developers_guide/documenting/docstrings.html#multi-line-docstrings
One letter difference between `concrete_reference_target` and `concrete_reference_targets`.

Rename `concrete_reference_target` to `target` ? or something else ...
ok, I'd prefer not to do it. it seems like something I might mess up in a subtle way.
Is this gonna use the boost lib in the system instead of the one in third_party/cpp?
Is this save necessary?
Devices in Ralph are symbolized by 'fugue-wooden-box' icon.
maybe a slightly different name: tryAvailablePrototype might imply this exception kind of behavior???  Not really sure.
This check was removed because there's no guarantee that an email field exists anymore. 

It might be possible to resurrect it by abstracting the underlying idea onto an optional method on the User class, but frankly, my inclination is to just kill the feature.
You're right in that the _meta of the other model will also be affected (plus the other class will get a ReverseSomething added to it as an attribute), so there's no way it's perfect - however, since the migrations code largely runs in a single one-off thread, that's generally not a problem. I agree we don't want people using this in code, though, especially as we want to change the way this works to have the separate caches passed around the models in future.

Perhaps a suitably large warning and a promise that we'll break it next release?
please move $types to the end otherwise this is a BC break that i cannot merge.
How will we then ever execute the line there delete rows from previous tests ?
Yeah we do want that.
Not a huge fan of this variable name -- how about `prompt_responses`?
Yeah.. that's a problem. Although, I'm thinking this will be a non-issue if we are going to convert to using UTF8. That's another thing I was going to do in the parser refactor, shouldn't be too hard.
If cascade should be avoided here. What about holding the data in a single Map<CounterEntity, Double> instance?
Agreed. I've changed it in the latest commit.
Also s/elemenets/elements/
How do we enforce the function signature?
These changes make sure users can't crash the server by sending backslashes.
I'm not very familiar with OAuth, what is an example of such a request?
I'd prefer to start making the change to use verbose
Why the `lists:flatten` call? Would at least be worth a comment and/or some type specs.
Tyop: "on" -> "one"
You mean that a test is missing here?

like test_outbound_message_multipletransport
This is just to suppress the INCOMING and OUTGOING logging for `enquire_link`, which happens every minute or so. We log a much briefer message instead.
I think it should be clearer that this graph's creation and destruction will not affect the base graph (at least not the wiring and instances... the internal state of those instances may be, if they're mutable)
Shouldn't you pass `$assoc_args['file']` to the upgrader?
这个意见本来就是对的~~我都是写的脚本自动下载编译最新的R。
不过我的版本完全是由于我弄了不同的BLAS...对于不同规模的问题表现差的太远。 相信这么折腾的人不多。

On 2012-3-31, at 上午1:07, Yihui Xie wrote:

>> @@ -253,5 +291,17 @@ font = TT DejaVu Sans Mono
>> language = en
>> ```
>> 
>> +Mac下需手动修改Renviron文件,比如对于X64的R,修改为
>> +
> 
> 我这个安装指南带有强烈的个人偏见，比如对于多个版本的R我持反对意见，不要干这种事情，永远遵守一条原则：用最新版本的R，只用一个版本的R。对于那些旧版本下能运行而新版本下不能的程序，就一条路，改，改到它适应新版本。
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/yihui/r-ninja/pull/2/files#r629506
once this is changed to a checkbox, this style will have to be changed or deleted.
Wrong spaces at the start of the line. Sigh.
To me this looks like a command would be optional. Should that be limited to special menu items like separators?
Reminder: Also need to do this in toggleSidebar().
No, these do not need to be localized. The "Text" string is a simple reformatting of the "text/plain" mimetype that is not localized.
Hardcoding these strings means that the unit tests will fail when run on non-English locales (or if we tweak the wording later). Should we look these up in the string table instead?
That sounds right. I removed the export and also moved the detailed description of the "id" property from Command() to register()

-----Original Message-----
From: Jason San Jose [mailto:reply@reply.github.com] 
Sent: Wednesday, May 23, 2012 1:36 PM
To: Ty Voliter
Subject: Re: [brackets] Menu, MenuItem, key bindings, and Command API (review only) (#927)

> @@ -76,4 +176,6 @@ define(function (require, exports, module) {
>      // Define public API
>      exports.register = register;
>      exports.execute = execute;
> +    exports.get = get;
> +    exports.Command = Command;

This export is unused. Is it safe to assume register() is the only creation point for Commands?

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/927/files#r870972
What's the purpose of "*1" ? That seems to be unnecessary.

Same question for "* 0" ?
Triple `=`'es
Close is called automatically on shutdown. It's done using register_shutdown_function() instead of destructor, so that it's closed even on fatal error.
In other words, I think there's no need for destructor override here.
EMAIL_HOST_USER is django's way of doing this. EMAIL_LOGIN is something we invented. we should really phase it out (is only now used in something in dimagi utils, but that scares me)
You should call this `_publish_snapshot` if it's just a helper and not a view so that that's visually clear.
See comment below, same here.
Please take the url from process.env['BUGZILLA_HOST']
Something as simple as `seasons` would be much more descriptive than `x`.
Yes, one each selection modification the selection model call all selection listeners.
Revert this change you made here; you don't want the default for end to be 0
How about just `constructPlayer`, since it's actually manipulating the dom here?
I think I saw code above where pitch was defaulted to 0 if not present.  Should it be 1?
Should be "unit" not "units".  Same everywhere else.
I checked our API users, and none of them specified the type parameter
This is an odd API choice.  Why not pass an options object, and leave out that param?
For consistency's sake, `@param {Object} options: `.
m_progItem doesn;t seem to be deleted
shebang isn't supposed to have a space in it. It at least in my case prevents sublime from recognizing what the file is.
Does this ```@medistrano_pir``` need to be an instance variable, or would it work as a local variable?  It's generally best to avoid instance variables except where they genuinely represent some state of the object.  I know Rails doesn't always work that way - in particular with passing instances variables from controllers to views.  However, reducing the amount of state in an object can be very useful for lots of different reasons - for example it takes up less memory, it's faster to copy/serialize/deserialize it, and it's easier to refactor methods when they don't have side-effects.  You also run into fewer concurrency issues.

I don't want to over-dramatize this - it's just one instance variable, and maybe you have a good reason for using it - but basically you generally want to avoid using instance variables when a local variable would do the job, just as you would avoid using a global variable if an instance variable would do the job; it's a similar sort of thing.
Similar comments here on several points.
Shoot, I was reading split('.')[1]. My bad on that
We actually want ``category.title`` here. The name is the looser of the two.

As a side note, "name" and "title" were tragic choices for naming these two things. Sorry about that. I'm game for different ones, but generally what I was trying to get at is that all the "PyCon US" conferences had the same name and that the title included which year it was. We could add a year column, but we already have a recorded column (or start_time--whatever it's called) and I wanted a single column to sort by.
I think you need a } here.
Figured.  Thanks for explaining.
I believe for PEP8, this should be:

`if type is not None:`
Ah, I didn't think about that... You mean the ``file://`` or the path? I.e., you're suggesting ``'file://' + pathname2url(join(absdir, 'index.html'))``? (`pathname2url` doesn't seem to add ``file://``, and without that it fails on OS X...)
Not that I'm aware of - see http://docutils.sourceforge.net/docs/user/rst/quickref.html#bullet-lists .  I completely agree with you on this one - I've had the exact same situation where the blank line makes it look awkward as plain text.  It does look look less spaced out in the html version though, so that's something.
I suppose it could be hacky, but maybe having it append the node name + key/value or something to /tmp/rt/post_commit.log and check the contents in the test could work? That should disappear in between tests. What do you think?
The code with 1.48 was also different, so to be safe I think that is correct.
Matts code checks for < 1.49 for his compiler warning detection, but for the fix to work it has to be 1.49 (with version above that we could remove all that hacks and checks alltogether).
This is not very readable plus has unnecessary merge with empty array. Better to replace with this:
```php
if ($merge) {
	$this->_inputDefaults = array_merge($this->_inputDefaults, $defaults);
} else {
	$this->_inputDefaults = $defaults;
}
```
> if you still not understand the purpose, ...

In my previous comment I already said "..this change does make sense."
I agree with this change.

I'm fine with the longer line since it's just a string. It's still much clearer since you don't have function parameters hanging off the edge of the screen.
[quote from=the_usability_guy_who_complains_once_again]
Do end-users know what "URL" means?
Google uses the "link" word.
[/quote]


On Thu, Nov 22, 2012 at 5:23 PM, Alex Saunier <notifications@github.com>wrote:

> In core/src/script/CGXP/locale/en.js:
>
> > @@ -46,7 +46,8 @@ GeoExt.Lang.add("en", {
> >          toolTitle: "Permalink",
> >          windowTitle: "Permalink",
> >          openlinkText: "Open Link",
> > -        closeText: "Close"
> > +        closeText: "Close",
> > +        incompatibleWithIeText: "Carful: This URL is too long for Microsoft Internet Explorer!"
>
> Carful => Warning
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/camptocamp/cgxp/pull/292/files#r2206987>.
>
>



-- 
Pierre GIRAUD
Géomaticien, Analyste

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac, Cedex

Tel : 00 33 4 79 44 44 93
Mail : pierre.giraud@camptocamp.com
http://www.camptocamp.com
Typo error : 
>>> weEk future.
Should this error message be updated?
hum... i don't now if it's due to this, 
but the pager is now 'below' the cells and can't be clicked ...
There would be drawback compatibility issue, with the current the second parameter is for setting the autocomplate (true or false)
Actually, this entire function can be simplified quite a bit by using `git_path_contains_file()` I think. Just create a single `git_buf` with the `repo->path_repository` root, and then you can just write `git_path_contains_file(&root, MERGE_MODE_FILE)` etc for all the tests instead of having to join all the paths yourself. It will be half the code and should do fewer allocations, too.
This should probably be right below adjustScrollbar to make it clearer, or even just pass the function in directly if you're not using it anywhere else.
Is the username always submitted via GET querystring? What if it's submitted as part of the authentication header instead? I would think tastypie would provide some better way to get at the authenticated user (probably just `request.user`)
the question there would be, does the tastypie default Throttle work?
This one is very out of date! Latest version is 2.5.0 on pypi.
What about port? That might be really important when, for example, switching between postgres and pgbouncer which I recently did for my personal server. I edited just the port to 6432 and left all the other db connection settings as is.
fixed it, thanks for finding!
You're right :)
But i can submit a new pull request beceuase of a .gitignore :S
I hope thay can close and delete this pull request o i can submit a new one!
Comment for step 14.
Can these versions be more specific? This component may be going into 2.2, but does it require the 2.2 version of these deps?
Is it possible to widen the visibility in a child-class? I don't know. Because that's what would happen in BC code.
It's probably better to not call $this->normalize at all (in `all()`) in this case.
Nice catch. Nope for `event-dispatcher`, but yest for `config`, as PR provides couple of commits into `Config`.
The issue with negative numbers is that it will make the name start with ``-``, which can lead to an invalid id (if it is the root or if the parent has an empty name)
Maybe not - I don't know.
could be simplified `foreach((array) $name)` -> no need for the `if`
Maybe job-scheduler-uncaught-exceptions?
Please use `initWithObjectsAndKeys:`. Or use `NSDictionary *parameters = @{ ... };` and then `[parameters mutableCopy]`.
Single quotes preferred when not interpolating.
名字决定不改了，isCover的意思就是是否有覆盖，互相重叠。
No, it should not be shared...  They are two separate questions, and should be answered independently.
Should this be the extension or the Resources since this is a resource test?
Likewise. Sadly that doesn't fit.

I've updated to use the ```.format``` interface in the forthcoming commit.
Yeah, it could've been, i've been following the pattern that's in other handlers, added merging the ifs to my todo list ;P
There should not be any Perl code in a recipe.   The recipe should comprise the
documentation, comments, and the list of processing steps (with optional
arguments).   See the Programmer Manual.
www.starlink.ac.uk/docs/sun233/node4.html.
this seems to be used all over the place. Couldn't we have something in cms.utils that provides this try/except logic?
Shouldn't `near()` still operate on a field? This doesn't seem to agree with the [Geospatial Indexing](http://www.mongodb.org/display/DOCS/Geospatial+Indexing#GeospatialIndexing-Querying) docs.
not necessary, user resource idempotent
The async/sync behavior can be configured on a per-webapp basis. That wasn't the case when the original version of these tests was written (AS 4). So let's switch these war to sync replication and get rid of the delay and possible spurious failures these sleeps add.
absolutely, as should the ssl one be :)
No, as we need the anchor within the menu. The item object contains the original option only.
No, but assigning to unused variables is confusing, and so in this case, because you were assigning in the var statement, you were creating throwaway variables. I just moved the var declarations up, and then only assigned when necessary.
Don't do this. This blocks settings app as I said in bugzilla comment.
Talk to me on IRC or here if you have some thoughts.
Style warning was triggered here.
I'd think that these styles would be appropriate for all sections, wouldn't they?
Did you also move/remove the icons of the sleep menu?
var dataset = e.target.dataset;
@jcarpenter and I are going to discuss this with TEF in more detail.  @autonome is going to file FB bugs and nom them for blocking.
Cool, thx :)
Для checkbox не совсем подходит слово "включить", лучше изменить на "Использовать английские названия вместо местных" (?). Подразумевается вопрос ,а checkbox это ответ Да или Нет.
Why is this test commented?
Two more test cases comes to my mind: `BaseForm[12, 3] // FullForm` which should return `BaseForm[12, 3]`, and e.g. `BaseForm[10, -2]` which should print the error message. Thanks!
Same comment from the pulp_rpm one for completeness in this pull request:

I'm not a huge fan of adding docstrings for overridden methods if nothing has changed. I'd rather leave it up to the developer to check the base class (which admittedly didn't have docstrings until a few minutes ago) which is the definitive guide to what the method should do IMO.
Why are you taking out the state info here?
We should probably have `mongo` and `postgres` [groups in the Gemfile](http://gembundler.com/man/gemfile.5.html) so that users can install only the appropriate gems for their chosen storage engine.
It's not super important, but [Composer](https://github.com/composer/composer) works under 5.3.2 and it's necessary to run the tests (without manual tweaking).
Document parameter.  Also maybe pick a better variable name for it.
>  behold: !$! :)

Looks like an expensive sandwich.
```js
return [text, !!options.asString, !!options.disableLambda].join('||')
```
Inside object Monoid put:

implicit def optionMonoid(implicit mt : Monoid[T]) = new OptionMonoid[T](mt)

and then this will get picked up automatically with:

implicitly[Monoid[Option[T]]]

or inside the ones for tuples.
Be more specific about the types of Exceptions that this can throw, and possibly use multiple `except`s if necessary.
Add Behat scenario to check inventory line exists after form submission.
if you dont like the usage of SDL, you can make that msleep(1)
Some schedulers may want to be active on all masters: try/force/triggerable come to mind.
This was previously a call to find that removed all .git/index.lock in the repo checkout; I had a change merged that made it use repo forall for performance reasons (doing a find on the whole repo checkout can take a very long time). However, it's since occurred to me that this means that the index.lock is no longer being removed from the manifest .git repository. You may want to do that
My comment was general, and not actually related to this specic line. In fact, I believe I removed the printing statement in this case.
保留中の変更がある場合は`"change"`イベントを発火し続ける。
Ahm.. Yeah :)
Why '.', but not product.path?
On Tue, Nov 27, 2012 at 1:50 PM, Victor Julien <notifications@github.com>wrote:

> In src/detect-engine.c:
>
> > @@ -492,12 +494,28 @@ static void *DetectEngineLiveRuleSwap(void *arg)
> >
> >      for (i = 0; i < no_of_detect_tvs; i++) {
> >          int break_out = 0;
> > +        int pseudo_pkt_inserted = 0;
> > +        usleep(1000);
>
> whats the purpose of this sleep?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/inliniac/suricata/pull/228/files#r2232088>.
>
>

Just incase the detect thread is still processing a a packet inside, we
give it some time to finish before we can send a pseudo packet.  Coming to
think of it, we could have rather run the usleep before the for loop.

-- 
Anoop Saldanha
SCLogError
there is an issue here : if two repositories indicates the same order, we don't see the first one in the list since it will be overwritten by the second one.

I think you should add the order in the array('name'=>...), and provides a function to sort the final list.
`$().ready(`? I've always seen `$.ready(`. Does your alternate form work?
This module should not have such dependency.  If you'll end up moving this function to other module, please either move require to the beginning of the module or if not possible submit a bug and point to it with a comment. Run-time require is not compatible with a future JS modules.
It may be worth it emptying `modules` and `sandboxes` so that if something goes wrong we won't leak all modules.
(for example if loader is leaked, we will leak all modules instead of just the loader)
I pushed new revision with some modification on python side in order to avoid adding such attribute in first place.
So that harnessOptions will only contain attribute that have to end up in harness-options.json file.
All others (locale, packages, icon, icon64) are now in `options` object.
This changed allowed me to prepare the next step. So now the JS side receive SDK and Addon absolute path,
so that you can start building manifest in JS.
Oh oops, yeah, this is a merge error. I can fix that and submit another pull request or you guys can fix as you merge it.
You'll need a property in the page object which returns the page's actual title, and then you can compare that to an expected value in the test. 

I notice that there is a ```page_title``` property in base.py, which tag_results.py inherits from, so that may work, or it may not based on how it's implemented. I suggest trying to use that first (which would mean you wouldn't have to add a property to tag_results.py), but if it doesn't give you what you want you may have to add a property to tag_results.py which might make use of self.selenium.title.
I don't like to duplicate functionality.
Yes, I should move it.
On Jun 1, 2012 4:48 PM, "Stefano Ricci" <
reply@reply.github.com>
wrote:

> > @@ -0,0 +1,63 @@
> > +package org.openforis.collect.model.editor;
>
> Should it be part of SurveyManager? Why is it in the model package?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openforis/collect/pull/2/files#r913785
>
Sorry for that, no reason at all! Will fix it.
Do not use implicit imports here, please. Just import view functions at the top of the module.
Can't hurt, sure.
Test that the markup includes the name correctly.
See note on the FileResolver implementation -- if $password can be optional, it should be defined as such here; otherwise, all implementations need to make it a required argument.
if you see `setArrayObjectPrototype` there are the possibility of pass a non ArrayObject as argument
Should that not be case-insensitive ?
Type?
This gem file has a mixture of single quotes and double quotes. Please make this consistent.
might need some assistance with this, haven't ever built helpers for views
mean I can
should have three l's (and I'd prefer install_libpath)
banged it UP
you probably want to add guava as an explicit dependency in the pom.xml with scope "test"
Yey, silent failure! @Guillaume: tu pourrais t'installer un serveur errbit pour être tenu au courant?
this works, but just wanted to point out that this also works:

```python
new_csp_frame_src = settings.CSP_FRAME_SRC + ('data:',)
```

Just saves the list conversion. Not worth changing.
Yeah I agree, I'm not keen on this approach. If we really want to reduce duplication then we could have a page object method that returns a boolean, but I would question the value in such repetitive assertions.