bugtool: Collect bond state information from ovs.

This is an enhancement in bugtool archive output to determine the bond
state information. It is implemented as a plugin which internally calls
"ovs-appctl bond/show" command to get bond state.

Feature #11283.
Signed-off-by: Arun Sharma <arun.sharma@calsoftinc.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
bugtool: rename label names in plugins related to ovs-appctl

It improves to have proper out file name in bugtool archive with respect
to ovs-appctl commands. E.g. if command is 'ovs-appctl lacp/show' then
the related out file will be 'ovs-appctl-lacp-show.out'

Feature #11283.
Signed-off-by: Arun Sharma <arun.sharma@calsoftinc.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
Fix "make distcheck" failure since we weren't cleaning up a generated file.

Signed-off-by: Ben Pfaff <blp@nicira.com>
ofproto-dpif: Make parameters const.

The ofproto parameters to lookup_input_bundle(), get_ofp_port() and
get_odp_port() may be const.

Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Ben Pfaff <blp@nicira.com>
ofputil: Accept OFPP_NONE as a valid output port.

Ofproto-dpif treats an output to OFPP_NONE as a NOOP, but ofputil
treated it as an error.  The former behavior seems more natural.

Reported-by: Teemu Koponen <koponen@nicira.com>
Signed-off-by: Ethan Jackson <ethan@nicira.com>
odp-util: Fix parsing of actions encapsulated within "sample" actions.

Signed-off-by: Ben Pfaff <blp@nicira.com>
dynamic-string: New function ds_get_test_line().

This eliminates some code duplication.   An upcoming commit will add
another user.

Signed-off-by: Ben Pfaff <blp@nicira.com>
odp-util: Add tests for parsing and formatting ODP actions.

Signed-off-by: Ben Pfaff <blp@nicira.com>
ovs-bugtool: Close file descriptors after use.

In ovs-bugtool, we do a bunch of Popen calls to
get the results of some shell commands with stdout
set to PIPE. Once we are done, we need to
close the file descriptors.

Bug #11083.
Signed-off-by: Gurucharan Shetty <gshetty@nicira.com>
Remove forward declaration of vsp_vlandev_to_realdev()

There is no need to for a forward declaration of vsp_vlandev_to_realdev()

Signed-off-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Ben Pfaff <blp@nicira.com>
cfm: Avoid null pointer dereference in cfm_process_heartbeat().

Found by clang.

Signed-off-by: Ben Pfaff <blp@nicira.com>
ofproto: Remove write-only variable.

Found by clang.

Signed-off-by: Ben Pfaff <blp@nicira.com>
Avoid assigning the same value to a variable back-to-back.

Found by clang.

Signed-off-by: Ben Pfaff <blp@nicira.com>
Avoid writes to variables that are never read back.

Found by clang.

Signed-off-by: Ben Pfaff <blp@nicira.com>
ovs-ofctl: Avoid impossible check for !osm in fetch_port_by_stats().

At the time of the call to ofpbuf_at(), we know that the ofp_stats_msg is
present because ofputil_decode_msg_type() reported that it was.  Therefore,
we can use ofpbuf_at_assert() and don't have to check for a null pointer.

Found by clang.

Signed-off-by: Ben Pfaff <blp@nicira.com>
ofp-parse: Mark ofp_fatal() as never returning.

This makes clang less confused.

Signed-off-by: Ben Pfaff <blp@nicira.com>
ovs-dpctl: Remove obsolete documentation of limit on number of datapaths.

Reported-by: Vjekoslav Brajkovic <balkan@cs.washington.edu>
Signed-off-by: Ben Pfaff <blp@nicira.com>
ovs-vswitchd: Document some limits.

Signed-off-by: Ben Pfaff <blp@nicira.com>
docs: Fix bad troff markup.

Signed-off-by: Ben Pfaff <blp@nicira.com>
ofp-util: Match on NXAST_CONTROLLER as an output to OFPP_CONTROLLER.

Found by inspection.

Signed-off-by: Ben Pfaff <blp@nicira.com>